IRC Chat : 2011-08-15 - OpenMRS

00:02:32 *** wyclif has quit IRC
00:15:23 *** wyclif has joined #openmrs
00:53:39 *** msambath has joined #openmrs
02:03:08 *** suho has joined #openmrs
02:03:08 *** ChanServ sets mode: +v suho
02:45:26 *** jportela has left #openmrs
02:50:58 *** gbastien has joined #openmrs
02:56:23 *** jriley has left #openmrs
03:10:44 *** upul` has joined #openmrs
03:10:44 *** ChanServ sets mode: +v upul`
03:26:21 *** jwishnie has joined #openmrs
03:26:29 *** surangak has joined #openmrs
03:34:20 *** finbrein has joined #openmrs
03:36:49 *** finbrein has quit IRC
03:37:36 *** finbrein has joined #openmrs
03:40:16 *** gbastien has quit IRC
03:40:40 *** jwishnie has quit IRC
03:46:59 *** jwishnie has joined #openmrs
04:05:14 *** jwishnie has quit IRC
04:06:31 *** surangak has quit IRC
04:11:18 *** surangak has joined #openmrs
04:24:14 *** upul` has quit IRC
04:25:00 *** upul` has joined #openmrs
04:25:00 *** ChanServ sets mode: +v upul`
04:58:28 *** jwishnie has joined #openmrs
05:04:38 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Adding tooltip help to complex obs handlers <http://feedproxy.google.com/~r/OMRStrunk/~3/2oB-3d_jWlo/OpenMRS>
05:06:56 *** finbrein has quit IRC
05:12:50 *** jwishnie has quit IRC
05:25:10 *** suhothayan has joined #openmrs
05:25:10 *** ChanServ sets mode: +v suhothayan
05:25:28 *** suhothayan has quit IRC
05:33:11 *** jwishnie has joined #openmrs
05:34:45 *** finbrein has joined #openmrs
05:38:09 *** dkayiwa has joined #openmrs
05:43:35 *** bryq has joined #openmrs
05:43:35 *** ChanServ sets mode: +v bryq
05:44:39 *** finbrein has quit IRC
05:55:09 *** bryq has quit IRC
05:57:36 *** pascal` has quit IRC
06:08:51 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22234 <http://feedproxy.google.com/~r/OMRStrunk/~3/MGhNe7fVVKA/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Completing feedback tasks : instead of 'PatientHandler' 'LocationHandler' etc, we now display just 'Patient' or 'Locatio... <http://feedproxy.google.com/~r/OMRStrunk/~3/wXV4Q-paTeo/OpenMRS>
06:16:18 *** bwolfe has joined #openmrs
06:16:18 *** ChanServ sets mode: +o bwolfe
06:45:28 *** jwishnie has quit IRC
06:49:12 *** rafa has joined #openmrs
06:49:12 *** ChanServ sets mode: +v rafa
06:51:49 *** jwishnie has joined #openmrs
06:55:30 *** bwolfe has quit IRC
07:14:49 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Making PersonService and PatientSetService extend OpenmrsService - TRUNK-2515 <http://feedproxy.google.com/~r/OMRStrunk/~3/f-jLx1IYb-k/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22347 <http://feedproxy.google.com/~r/OMRStrunk/~3/2ZQGQ6t_Rv4/OpenMRS>
07:19:47 *** jwishnie has quit IRC
07:29:52 *** jwishnie has joined #openmrs
07:31:02 *** magoo has joined #openmrs
07:33:37 *** jwishnie has quit IRC
07:52:54 *** magoo has quit IRC
07:53:25 *** bwolfe has joined #openmrs
07:53:25 *** ChanServ sets mode: +o bwolfe
08:00:33 <bwolfe> dkayiwa, rafa, you good to go today?
08:00:42 <dkayiwa> sure
08:01:36 <rafa> sure :)
08:01:57 <bwolfe> dkayiwa, rafa, you're working on the 1.9 bugfixes sprint, right?
08:02:17 <dkayiwa> yes
08:02:50 <rafa> bwolfe: right it's the plan.
08:03:23 <rafa> bwolfe: Darius asked me to prepare some docs for the future Metadata Sharing Server project
08:03:42 <bwolfe> um, ok
08:04:20 *** magoo has joined #openmrs
08:18:56 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22353 <http://feedproxy.google.com/~r/OMRStrunk/~3/ZzFJHy8jvMo/OpenMRS>
08:33:05 *** dkayiwa has quit IRC
08:35:49 *** aja has joined #openmrs
09:16:25 *** surangak has quit IRC
09:16:43 *** surangak has joined #openmrs
09:17:11 <surangak> /msg NickServ identify test
09:18:40 <surangak> Please ignore this, I just felt that someone might need to know my password ... (grrrrrrrrrr)
09:24:59 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22422 <http://feedproxy.google.com/~r/OMRStrunk/~3/vb-POBtcJTI/OpenMRS> || New Changeset: OpenMRS (trunk): Fixing ClassNotFoundException when creating person with some attribute types - TRUNK-2460 <http://feedproxy.google.com/~r/OMRStrunk/~3/uF90JFygWsk/OpenMRS>
09:32:06 *** pascal` has joined #openmrs
09:47:05 *** suhothayan has joined #openmrs
09:47:05 *** ChanServ sets mode: +v suhothayan
09:48:27 <bwolfe> surangak, I hope you don't use 'test' for all your other passwords :-)
09:48:44 <surangak> :D
09:48:49 <surangak> no afraid not..
09:49:06 <surangak> since im so new to IRC, i kinda guessed that something like this world happen :D
09:49:53 <surangak> its extremely embarassing :(
09:51:09 *** suho has quit IRC
09:56:28 <bwolfe> surangak, no worries. happens to the best of us
09:56:44 <bwolfe> I always double check before I push enter to make sure it has the /msg in front and no white spaces
09:57:20 <surangak> bwolfe, ya, i think that may have been the problem here too
09:58:11 <surangak> bwolfe, hope none of our people at Indiana were visting the state fair last saturday ...
09:58:27 <bwolfe> surangak, wow, that made world news?!
09:58:41 <bwolfe> the fairgrounds are about 2km from my house. we usually go there every year
09:58:53 <bwolfe> (obviously not this year since we're in kenya)
09:59:00 <surangak> bwolfe, im rather keen on news... once upon a time I used to be a newshound
09:59:23 <bwolfe> yeah, very sad about it though
09:59:37 <bwolfe> no one that we know was hurt (that we've heard yet anyway)
10:00:25 <surangak> bwolfe, over here, at the time we had the war going on... there were bombs going off all over COolombo one time
10:00:34 <surangak> bwolfe, and that was pretty scary
10:01:20 <bwolfe> yeah, I'll bet
10:01:49 <bwolfe> upul` would keep us up on the news when the war was ending and the extremists were being pushed out
10:03:34 *** vchircu has joined #openmrs
10:04:10 <surangak> bwolfe, these days, since there are no extermisits, the people have to go on witchhunts :) http://www.adaderana.lk/news.php?nid=14543
10:29:04 *** suhothayan is now known as suho
10:38:08 <bwolfe> aja, how are users supposed to map their concepts to the codes that are used?
10:38:28 <bwolfe> is there a way for you to list out programmatically all the concept maps that have been defined in an app?
10:38:59 <bwolfe> aja, fyi: I've committed to the module, you might want to update before you start coding today
10:41:51 <aja> bwolfe: for the first question:user can 1.manually map by editing the concept 2.can get concept dictionary that have all mapping(Eg:MVP dictionary))
10:43:58 <bwolfe> hmm
10:44:04 <aja> bwolfe: second:according to my knowledge no way. Josh has to help...
10:44:11 <bwolfe> I figured it was manual
10:44:17 <bwolfe> but we need to make it a little easier
10:44:36 <bwolfe> would be nice if we could scan the incoming apps, look for references to codes, and keep those in a list somewhere
10:44:49 <bwolfe> then there could be an admin page that lists off everything and shows which concepts are mapped already and which still need to be
11:13:57 <bwolfe> aja ^^
11:14:40 <aja> bwolfe: yes
11:15:56 <aja> this is what i manually did for some apps to run.:)
11:20:13 *** goutham has joined #openmrs
11:21:09 <bwolfe> aja, ok, needs something more. :-)
11:34:37 <rafa> bwolfe: I just noticed that when I set up an implementation id installing 1.9 it created a concept source for me. Do you know when this feature first appeared?
11:38:50 *** upul` has quit IRC
11:39:22 <bwolfe> 1.4
11:39:31 <bwolfe> rafa, 1.4
11:39:35 <bwolfe> its been there for a long time
11:39:39 <bwolfe> but no one uses it. :-0
11:39:41 <bwolfe> :-)
11:39:54 <bwolfe> the impl id in the wizard didn't appear until 1.7 probably
11:40:05 <rafa> bwolfe: cool thanks
11:40:10 <bwolfe> I wonder if you make an impl id through the admin interface if it will create the concept source
11:40:36 <aja> bwolfe: Do you know any handy way to generate test dataset from database?
11:41:05 <rafa> bwolfe: yes, it does. At least in 1.9 :)
11:41:34 <bwolfe> aja, where do you get your smart apps from?
11:41:51 <bwolfe> aja, theres a unit test in trunk that will help you. I can't remember the name of it though :-/
11:41:59 <bwolfe> look in the org.openmrs.test.tests package
11:42:13 <bwolfe> or maybe without that last tests. I can't remember...its been so long...
11:42:21 <bwolfe> rafa, strange...
11:45:11 <aja> bwolfe: i got smart apps from here https://github.com/chb/smart_sample_apps
11:49:32 <bwolfe> aja, uh, where in there?
11:51:14 <aja> bwolfe: i just emailed you all apps that can run with smartcontainer module.
11:52:54 <bwolfe> aja, thanks. looks like all of these reference an online repo and pull from there. is it possible to package this all in one? or are they not published that way at all?
11:53:07 <bwolfe> a lot of implementations run without being connected to the internet.
11:55:44 <aja> bwolfe: i suggest to create an OpenMRS module to host them.they are just java-script apps.
11:56:09 <bwolfe> an openmrs module?
11:56:18 <bwolfe> what do you mean?
11:56:34 <bwolfe> why can't all the html/images/etc just be in one zip file? or are you only allowed to upload json files?
11:57:08 <bwolfe> aja, does it have ot connect to that every time, or do you download on first install and cache?
11:58:41 <aja> bwolfe: first look this http://wiki.chip.org/smart-project/index.php/HOWTO_Build_a_SMART_App#Barebones_App
11:58:48 <OpenMRSBot> <http://ln-s.net/94Y_> (at wiki.chip.org)
12:00:31 <bwolfe> aja, ok, but the bootstrap is being served from smartplatforms.org, not from openmrs
12:00:35 <bwolfe> how is tihs working then? :_)
12:00:38 <bwolfe> :-)
12:03:36 *** downeym has joined #openmrs
12:03:36 *** ChanServ sets mode: +o downeym
12:03:36 *** OpenMRSBot sets mode: +o downeym
12:04:39 <aja> bwolfe: if some one want to host an smart app he have to serve request for bootstrap and publish smart_manifest.json.
12:06:29 <aja> so then smart container will get the URL for bootstrap & index form the manifest and send the request
12:07:30 <aja> finaly the index page will contents is displayed within the Iframe.
12:08:45 <aja> smart app is just a html web app with javascript.
12:09:12 <aja> refer this http://wiki.chip.org/smart-project/index.php/Developers_Documentation:_Terminology#Installing_a_SMART_App
12:09:17 <OpenMRSBot> <http://ln-s.net/94Yk> (at wiki.chip.org)
12:12:00 <bwolfe> aja, look at revision 22541. Is there a reason you used hiAbsolute instead of hiNormal ?
12:12:17 <bwolfe> (I just changed it to use low/hiNormal)
12:12:50 <rafa> bwolfe: I need to take over TRUNK-2275 to finish two other tickets. Do you know Kishore?
12:13:16 <bwolfe> !ticket TRUNK-2275
12:13:17 <OpenMRSBot> bwolfe: [#TRUNK-2275] Domain object, liquibase changeset, and hibernate mapping for EncounterProvider - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2275
12:14:27 <bwolfe> rafa, I do not
12:14:35 <bwolfe> looks like he just assigned himself on thursday
12:15:09 <rafa> bwolfe: yes, I guess I leave him a comment and work on something else.
12:15:10 <bwolfe> put a comment on that you need to finish this asap and you'd like a (potentially incomplete) patch from him
12:20:06 <aja> bwolfe: sorry,it is my mistake.you are right.
12:21:51 <bwolfe> ok, np
12:21:59 <bwolfe> aja, are you just working on my comments from the reorganization review?
12:22:40 <aja> yes
12:23:07 <bwolfe> I have committed some more files as I go through things. one of which was one of the things in the reivew
12:23:09 <bwolfe> *review
12:23:18 <bwolfe> so I suggest updating often. :-)
12:23:24 <aja> bwolfe: and writing unit tests.
12:31:30 <aja> bwolfe: what do you mean by "watching concpet edits" regarding resetting the ConceptMap?
12:31:58 <bwolfe> aja, meaning one solution is to aop around the ConceptService and if a concept is saved, you clear that ones maps from yoru cache
12:33:18 <bwolfe> aja, in SmartVitalSigns you are referring to codes without sources. are you not worried about overlap of codes?
12:36:41 *** cta has joined #openmrs
12:36:54 <cta> hello
12:37:12 <bwolfe> hi cta
12:37:27 *** r-friedman has joined #openmrs
12:37:49 <r-friedman> bwolfe: hi ben, got a minute?
12:38:05 <bwolfe> r-friedman, I'll spot you a minute and a half
12:38:11 <r-friedman> cool
12:40:00 <aja> i think i have considered this.The conceptCode is retrieved from getVitalSignCode().
12:42:06 <aja> bwolfe: it looks up concept code only for SNOMED CT(for position concept) and LOINC sources.
12:42:19 <cta> bwolfe: Ben, I have already added new patch with unit tests for for ticket TRUNK-32 (ORUR_01.getLocationId). Also I created review https://source.openmrs.org/cru/CR-TRUNK-453 for this
12:42:31 <bwolfe> thanks taras!
12:42:42 <bwolfe> aja, ok...at least for now, right?
12:42:48 <bwolfe> more coudl be added later
12:43:30 <cta> bwolfe: np, Ben. Sorry that I did it so late ;-)
12:47:11 *** goutham has quit IRC
12:48:00 *** downeym_ has joined #openmrs
12:48:00 *** ChanServ sets mode: +o downeym_
12:51:55 *** downeym has quit IRC
12:51:55 *** downeym_ is now known as downeym
13:07:11 *** surangak has quit IRC
13:08:46 *** surangak has joined #openmrs
13:16:47 <bwolfe> aja, do the smart apps every pass in a limit?
13:17:13 <bwolfe> I'm looking at the vitalsigns "getAllForPatient" method...it quite possible could return A LOT of data.
13:23:08 <aja> bwolfe: i guess it should have a limit but not sure ,i am asking Josh.
13:23:55 *** Echidna has joined #openmrs
13:23:55 *** ChanServ sets mode: +v Echidna
13:24:34 <bwolfe> ok
13:25:05 <bwolfe> aja, if there isn't one provided by apps then I think we should make a global property and set it to something
13:25:21 <bwolfe> if we have a number to work against then we can do a lot of tricks with the openmrs api to speed things up
13:25:28 <bwolfe> (fetching things in different ways)
13:30:39 *** jriley has joined #openmrs
13:40:27 <r-friedman> ** bwolfe fetches things in a different way
13:40:50 <bwolfe> indeed
13:41:10 <bwolfe> r-friedman, did you not really need my time earlier? was that just a test? :-)
13:41:24 <r-friedman> no, i did, can i ask now?
13:43:08 <bwolfe> yeah
13:43:13 <bwolfe> times up
13:43:23 <bwolfe> :-D
13:43:37 <r-friedman> do you have a cleartext password, password and salt field values I can use to get into a DB?
13:44:56 <r-friedman> you might rather e-mail them to me that put them here
13:45:05 <r-friedman> that->than
13:47:25 <bwolfe> r-friedman, look on the wiki. theres a page about hacking into your own database. it gives you a hashed pw and salt to use
13:47:33 <bwolfe> I think its on the Administering Users page
13:48:04 <r-friedman> ok, i'll try again, i did a search on salt and didn't find it,
13:55:39 <r-friedman> bwolfe: i remember that page but no luck finding it
13:55:57 * bwolfe rolls up his sleeves
13:56:50 <r-friedman> * bwolfe changes a diaper
13:58:06 <bwolfe> nah, I don't roll up my sleeves for that
13:58:38 <bwolfe> r-friedman, https://wiki.openmrs.org/display/docs/Administering+Users
13:58:45 <OpenMRSBot> <http://ln-s.net/94Ze> (at wiki.openmrs.org)
13:59:06 <bwolfe> looks like someone took out the password and salt
13:59:21 <bwolfe> instead it just says to use the secret question/answer column
14:00:04 <r-friedman> so i guess i could just hack those to known values and be ok
14:02:24 <r-friedman> bwolfe: haha doesn't work with admin because there's no person backing it
14:02:38 <r-friedman> or it's a bug that remains from when all users had persons
14:02:51 <bwolfe> r-friedman, its on users, not on person table
14:02:58 <bwolfe> could be a bug...
14:03:06 <r-friedman> right, i'm getting this message:
14:03:28 <r-friedman> org.hibernate.ObjectNotFoundException No row with the given identifier exists: [org.openmrs.Person#1]
14:03:44 *** jportela has joined #openmrs
14:03:44 *** ChanServ sets mode: +v jportela
14:03:56 *** djazayeri has joined #openmrs
14:03:56 *** ChanServ sets mode: +o djazayeri
14:04:04 <bwolfe> r-friedman, yeah, seems like an error
14:04:15 <bwolfe> r-friedman, ticket it for me, will you?
14:04:19 <djazayeri> hi bwolfe, rafa
14:04:21 <r-friedman> ok
14:04:23 <djazayeri> wyclif:
14:04:29 <rafa> hi Darius
14:04:35 <bwolfe> r-friedman, and then to fix your problem, create a row for with person_id = 1 and then do your thing
14:04:43 <bwolfe> hi djazayeri
14:05:19 <djazayeri> scrum time?
14:05:20 <rafa> wyclif asked for a day off today, didn't he? :)
14:05:25 <bwolfe> yeah
14:05:32 <djazayeri> yes, but I see him logged on.
14:05:34 <bwolfe> he's heading to the dentist right abou tnow
14:05:44 <bwolfe> he leaves his laptop on at home overnight
14:05:51 <djazayeri> ah, okay
14:06:25 <rafa> and he answers in the middle of night sometime :)
14:06:37 <bwolfe> yes, very strange to see him on at 3am his time
14:06:42 <bwolfe> and then he leaves again
14:06:57 <bwolfe> its like he stops to look at his laptop on his way to the bathroom and then back to bed
14:07:04 <rafa> hehe
14:07:24 <downeym> i think it's always on nearby so he might wake up for a minute, look to see what's new, then go back to sleep
14:08:09 <djazayeri> I'm sure he's glad we're documenting all this, for archival on the internet.
14:08:14 <downeym> :D
14:08:14 <bwolfe> I can't do that. if my brain kicks into gear at night I'm awake for hours. I just don't let that happen
14:08:24 <rafa> :D
14:08:34 <djazayeri> so, shall we scrum?
14:08:38 <bwolfe> yes, wyclif's bowel movements and sleeping habits should be public knowledge :-D
14:08:45 <bwolfe> oh, scrum it
14:08:56 <rafa> haha
14:09:04 <rafa> yeah, let's scrum
14:09:29 <djazayeri> okay, want to go first?
14:09:34 <rafa> sure
14:09:36 <rafa> (-: Rafal :-)
14:09:37 <rafa> Today:
14:09:37 <rafa> * Created https://wiki.openmrs.org/display/projects/Metadata+Sharing+Server+Project
14:09:37 <rafa> * Tested MDS - GSoC
14:09:37 <rafa> * Fixed TRUNK-2537: Module css styles in separate files don't load in Internet Explorer 9 (IE9)
14:09:37 <rafa> https://tickets.openmrs.org/browse/TRUNK-2537
14:09:37 <rafa> * Picked up
14:09:38 <rafa> - TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property
14:09:38 <rafa> https://tickets.openmrs.org/browse/TRUNK-2260
14:09:39 <rafa> - TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers
14:09:39 <rafa> https://tickets.openmrs.org/browse/TRUNK-2261
14:09:40 <rafa> Tomorrow:
14:09:40 <rafa> * Backport TRUNK-2537
14:09:41 <rafa> * Work on TRUNK-2260 and TRUNK-2261
14:09:41 <rafa> Blockers:
14:09:42 <rafa> * Need to wait for TRUNK-2275 Domain object, liquibase changeset, and hibernate mapping for EncounterProvider
14:09:42 <rafa> https://tickets.openmrs.org/browse/TRUNK-2275
14:09:43 <OpenMRSBot> <http://ln-s.net/94Zr> (at wiki.openmrs.org)
14:09:55 <bwolfe> haha, had that one ready, didya? :-)
14:10:25 <rafa> no no I just wrote it ;)
14:10:40 <bwolfe> heh
14:10:59 <rafa> I need to invent a better marker at the top :D
14:11:03 <bwolfe> if you did, I'm disappointed with your "minimal" code output these last few months!
14:11:35 <djazayeri> bwolfe, forget code, let's put him to work on documentation. :-)
14:11:43 <bwolfe> true
14:11:50 <rafa> haha, okay I take it back :P
14:12:00 <bwolfe> although he'd be done in about 20 mins. then we'd have to come up with 1000s of tickets for him to work on
14:12:57 <djazayeri> rafa: regarding trunk-2275, hopefully Kishore will comment on that soon
14:13:57 <djazayeri> anyway, there are other tickets open in the sprint
14:14:23 <djazayeri> in case we don't hear back soon
14:14:39 <rafa> djazayeri: yes, I'll jump to other tickets unless he answers by tomorrow
14:14:55 <djazayeri> okay
14:14:57 <djazayeri> me:
14:14:59 <djazayeri> Friday:
14:14:59 <djazayeri> * Checked in OCC-56 (allow uploading and downloading of concepts from 1.6 to OCC) (finally!)
14:14:59 <djazayeri> * Checked in OCC-82 (client shouldn't need a concept source, but should upload via its implementationId)
14:14:59 <djazayeri> * Created OCC-90 (xml is bad for concept mappings to sources without an hl7 code)
14:14:59 <djazayeri> * Created SXS-3 (about NonUniqueObjectException when deserializing multiple ConceptNameTags)
14:14:59 <djazayeri> * Created OCC-93 (refactor code related to users)
14:14:59 <djazayeri> * Created OCC-94 (test uploading and downloading concepts with mappings)
14:15:00 <djazayeri> Weekend:
14:15:01 <djazayeri> * Reviewed TRUNK-2259,
14:15:01 <djazayeri> * Set up tickets for this Sprint
14:15:29 <djazayeri> Today
14:15:29 <djazayeri> * Code review provider tickets from TW
14:15:30 <djazayeri> * Sprint tickets
14:15:41 <djazayeri> no blockers yet
14:16:44 <bwolfe> djazayeri, are you focusing on the bug fixing sprint ?
14:16:54 <djazayeri> It's a "grab bag" spring
14:16:59 <djazayeri> spring->sprint
14:17:06 <bwolfe> right, I could tell
14:17:10 <bwolfe> a motley crew
14:17:16 <bwolfe> a regular mutt
14:17:23 <djazayeri> A couple tickets about visit attributes, some about multiple-providers-per-encounter, and then some bugfixes
14:17:28 <bwolfe> a rag-tag team of bugs
14:18:17 <bwolfe> djazayeri, I need to take wednesday off, so you could focus on smart for a day if you want
14:18:31 <djazayeri> just to mix things up even more?
14:18:50 <djazayeri> we'll see
14:18:58 <djazayeri> got a report for us?
14:19:18 <bwolfe> yes, just to mix it up
14:19:30 <bwolfe> wyclif is out for a day too, so we're down a bit already :-/
14:19:36 <bwolfe> today:
14:19:37 <bwolfe> reviewed module archetype for goutham
14:19:37 <bwolfe> reviewed
14:19:37 <bwolfe> spent an hour looking for working printer/scanner for @&#*ing RG paperwork
14:19:37 <bwolfe> CR-TRUNK-440
14:19:37 <bwolfe> CR-MOD-259 for aja
14:19:39 <bwolfe> cleaned up the interface/privileges of smartcontainer
14:19:41 <bwolfe> reviewed aja's work on 2 smart app tickets
14:19:43 <bwolfe> cleaned up a third
14:19:45 <bwolfe> added a few more smart app tickets
14:19:49 <bwolfe> tomorrow:
14:19:51 <bwolfe> more of the same
14:20:38 <rafa> will you be still looking for a working printer/scanner?
14:21:38 *** aja_ has joined #openmrs
14:21:39 *** gbastien has joined #openmrs
14:22:40 *** aja has quit IRC
14:22:59 *** aja_ is now known as aja
14:23:25 <bwolfe> rafa, I got it
14:23:26 <djazayeri> rafa: ben needs your OCC post-sprint review
14:23:31 <bwolfe> rafa, and then I had to fix it
14:23:39 <bwolfe> djazayeri, rafa sent it a few hours ago
14:23:46 <djazayeri> ah, okay
14:23:57 <bwolfe> he's the only one so far...
14:24:04 <rafa> ha! :D
14:24:05 <bwolfe> dkayiwa and wyclif are slackers ;-)
14:24:07 <djazayeri> I got no others
14:24:16 <djazayeri> Where is dkayiwa anyway?
14:24:26 <rafa> I haven't seen him today
14:26:50 <bwolfe> he was on this morning
14:27:02 <djazayeri> okay, I'll email him.
14:30:51 <bwolfe> aja, you still around?
14:31:08 <aja> yes
14:31:45 <bwolfe> aja, we do a "scrum" at this time (30 mins ago) every workday for the people in the current sprint.
14:31:56 *** rafa has quit IRC
14:32:16 <bwolfe> aja, you want to give you update? we just say 1) What we worked on that day 2) what we will work on the next day and 3) what (if any) blockers we have
14:32:36 <bwolfe> aja, its easiest to write it out in a text file and then copy/paste into here
14:37:06 *** dkayiwa has joined #openmrs
14:38:16 <aja> Today i worked on the suggestions that are given at review CR-MOD-259 and added some unit tests.
14:38:44 <bwolfe> ok. and tomorrow aja?
14:39:16 <aja> i will work on tickets related to documentation
14:39:29 <bwolfe> aja, good choice
14:40:17 <aja> Blocker#1:finding the suitable time for resetting concept caches
14:41:21 <aja> Blocker#2:make the concept mapping easier.
14:41:42 <aja> thats all
14:41:43 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): TRUNK-2537: Module css styles in separate files don't load in Internet Explorer 9 (IE9) ... <http://feedproxy.google.com/~r/OMRStrunk/~3/hUijQsD6bfg/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2537: Module css styles in separate files don't load in Internet Explorer 9 (IE9) ... <http://feedproxy.google.com/~r/OMRStrunk/~3/kJ6eALdP39g/OpenMRS>
14:43:56 <bwolfe> aja, I made a ticket for #2. you might want to claim that one if you're working on it
14:44:09 <bwolfe> https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10550
14:44:15 <bwolfe> see that page yet aja?
14:44:15 <OpenMRSBot> <http://ln-s.net/94_C> (at tickets.openmrs.org)
14:45:23 *** surangak has quit IRC
14:47:02 <dkayiwa> hi bwolfe
14:47:06 <bwolfe> hey
14:47:20 <djazayeri> hi dkayiwa
14:47:23 <dkayiwa> bwolfe: am i too late for the scrum?
14:47:27 <dkayiwa> hi djazayeri
14:47:33 <bwolfe> dkayiwa, for everyone else maybe
14:47:35 <bwolfe> you can go now
14:47:39 <dkayiwa> ok
14:48:00 <dkayiwa> Worked on: PersonService should extend OpenmrsService - TRUNK-2515
14:48:01 <dkayiwa> Worked on: getHydratedObject giving class not found for person attributes that are org.openmrs.Patient.exitReason and org.openmrs.DrugOrder.discontinuedReason - TRUNK-2460
14:48:01 <dkayiwa> Now working on getHydratedObject giving errors for person attributes that are char,int, and float options when put itrying to create a new Patient - TRUNK-2459
14:48:01 <dkayiwa> Spent some time moving around town looking for an inverter/battery solution to help me over the increasing electricity outages. Will be working late to compensate for this time.
14:48:05 <dkayiwa> No blockers
14:48:38 <djazayeri> I see a few of those are committed
14:48:41 <bwolfe> how much are generators in uganda?
14:48:42 <djazayeri> I'll review at some point today
14:49:14 <dkayiwa> bwolfe: the last time i checked the cheap ones could go for around 500 USD
14:49:31 <bwolfe> thats not too bad.
14:49:33 <dkayiwa> ok djazayeri
14:49:35 <bwolfe> they're close to 1000 here
14:49:43 <bwolfe> (theres only one kind)
14:50:07 <dkayiwa> bwolfe: they could be about that by now. prices have doubled since i last checked
14:50:10 <dkayiwa> :)
15:06:05 *** bwolfe has quit IRC
15:08:12 *** pascal` has quit IRC
15:18:05 <cta> djazayeri: Have you seen that I added new patch with Unit-Tests for TRUNK-32? Also I added review for this https://source.openmrs.org/cru/CR-TRUNK-453
15:20:42 <djazayeri> cta: yup, saw it
15:20:47 <djazayeri> thanks!
15:20:58 <djazayeri> It's still not 9am my time, so I haven't review it yet. :-)
15:21:08 <cta> ok
15:21:58 <cta> djazayeri: Darius, can you please also start to review code for my GSoC project https://source.openmrs.org/cru/CR-TRUNK-448
15:22:16 <djazayeri> okay, I'll add that to the list.
15:29:31 *** downeym has quit IRC
15:37:26 <cta> djazayeri: Thank you, Darius!
16:12:15 <djazayeri> dkayiwa: I commented on TRUNK-2459
16:12:31 <djazayeri> if you need clarification about a sprint ticket, please ask here on IRC
16:18:34 *** yanokwa has joined #openmrs
16:18:34 *** ChanServ sets mode: +v yanokwa
16:25:32 *** jportela has quit IRC
16:28:04 <dkayiwa> ok
16:55:44 *** asgoyal has joined #openmrs
17:01:24 <asgoyal> djazayeri: hi
17:01:47 <djazayeri> hi
17:01:52 <asgoyal> djazayeri: I want your guidance for the ticket OCC-10 :)
17:02:09 <asgoyal> https://tickets.openmrs.org/browse/OCC-10
17:04:50 <djazayeri> hmm
17:05:03 <djazayeri> what about it?
17:05:04 <djazayeri> :-)
17:05:14 <asgoyal> I am not able to understand where to start looking at it from
17:05:18 <asgoyal> like which files to look at
17:05:43 <djazayeri> Why did you specifically choose that ticket?
17:05:53 <djazayeri> It actually involves writing code on the OCC server, which is a different codebase
17:05:59 <djazayeri> so I wouldn't necessarily recommend it
17:05:59 <asgoyal> wow
17:06:04 <asgoyal> then
17:06:10 <djazayeri> I'd stick to something in the regular OpenMRS codebase
17:06:24 <asgoyal> which one will you recommend me?
17:06:39 <asgoyal> oh ok
17:06:40 <djazayeri> try picking one from here
17:06:40 <djazayeri> https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10552
17:06:45 <OpenMRSBot> <http://ln-s.net/94b0> (at tickets.openmrs.org)
17:10:28 *** saimanohar has joined #openmrs
17:11:20 <saimanohar> Hi all
17:12:23 <saimanohar> I have a small question:how do we access module resources in a controller.In a jsp page we can say ${pageContext.request.contextPath}/moduleResources/.Is there a way to do a similar thing in a controller?
17:16:30 *** jriley has quit IRC
17:17:01 *** jriley has joined #openmrs
17:24:09 *** rafa has joined #openmrs
17:24:09 *** ChanServ sets mode: +v rafa
17:24:32 *** downeym has joined #openmrs
17:24:32 *** ChanServ sets mode: +o downeym
17:24:32 *** OpenMRSBot sets mode: +o downeym
17:39:02 <asgoyal> djazayeri: may I ask you to explain me a small piece of code in brief?
17:39:11 *** magoo has quit IRC
17:42:49 *** rafa has quit IRC
17:46:03 *** saimanohar has quit IRC
17:46:57 <djazayeri> asgoyal: what's up?
17:47:14 <asgoyal> its in openmrsautocomplete
17:47:34 <asgoyal> this.conceptCallback = function() { var thisObject = this; return function(q, response) {
17:47:34 <asgoyal> if (jQuery.trim(q).length == 0)
17:47:34 <asgoyal> return response(false);
17:47:34 <asgoyal>
17:47:34 <asgoyal> // changes a single element into an array
17:47:34 <asgoyal> var includeClasses = jQuery.makeArray(options.includeClasses);
17:47:36 <asgoyal> var excludeClasses = jQuery.makeArray(options.excludeClasses);
17:47:38 <asgoyal> var includeDatatypes = jQuery.makeArray(options.includeDatatypes);
17:47:42 <asgoyal> var excludeDatatypes = jQuery.makeArray(options.excludeDatatypes);
17:47:44 <asgoyal> /*$j("#log").html($j("#log").html() + "<br/>" + thisObject.test + "--" + thisObject.testing);*/
17:47:46 <asgoyal>
17:47:48 <asgoyal> thisObject.searchCounter += 1;
17:47:50 <asgoyal> DWRConceptService.findConcepts(q, false, includeClasses, excludeClasses, includeDatatypes, excludeDatatypes, false, thisObject.makeRows(q, response, thisObject.searchCounter, thisObject.displayNamedObject));
17:47:53 <asgoyal> }}
17:47:56 <djazayeri> asgoyal: use pastebin please
17:48:02 <asgoyal> oops sorry ok
17:48:53 <asgoyal> djazayeri: http://pastebin.com/gMj95pec
17:49:44 <djazayeri> okay, so what's the question?
17:51:39 <asgoyal> hm... i want to know what that function is doing
17:52:11 <asgoyal> and where does it get the parameters q and response from...
17:54:02 *** bwolfe has joined #openmrs
17:54:02 *** ChanServ sets mode: +o bwolfe
17:55:28 <djazayeri> asgoyal: do you have an example of where the function is used?
17:55:39 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Fixing getHydratedObject giving errors for person attributes that are char,int, and float options when put trying to cre... <http://feedproxy.google.com/~r/OMRStrunk/~3/5edtRWvuqog/OpenMRS>
17:56:06 <asgoyal> hm.. that function is not used but i got a similar one at conceptReferenceTerm.js
17:56:47 <djazayeri> asgoyal: here's an example usage, from activeListAllerty.jsp
17:56:48 <djazayeri> var autoAllergyConcept = new AutoComplete("allergy_concept", allergyCallback.conceptCallback(), {
17:56:48 <djazayeri> select: function(event, ui) {
17:56:48 <djazayeri> $j('#allergy_concept_id').val(ui.item.object.conceptId);
17:56:48 <djazayeri> }
17:56:48 <djazayeri> });
17:56:56 <asgoyal> http://pastebin.com/LXfTZe6w
17:56:58 <asgoyal> oh
17:57:41 <asgoyal> djazayeri: can you tell me the name of the file where u found that code?
17:57:52 <djazayeri> activeListAllergy.jsp
17:57:57 <djazayeri> So, going back to the definition of the conceptCallback function, notice that it's a function that returns a function
17:57:59 <asgoyal> oh thanks :)
17:58:03 <asgoyal> ok
17:58:10 <djazayeri> e.g. function() { … ; return function(q, r) { … } }
17:58:11 <asgoyal> yep
17:58:13 <asgoyal> yes
17:58:23 <djazayeri> so saying conceptCallback() will actually return you a function
17:58:29 <asgoyal> oh ok
17:58:34 <djazayeri> Which is intended for use as a callback
17:59:05 *** jriley has joined #openmrs
17:59:17 <asgoyal> oh ok
17:59:26 <djazayeri> The reason the code is written like that is to allow the "thisObject" variable to be set when generating the function.
17:59:37 <asgoyal> ok
18:00:18 <djazayeri> so if I say conceptCallback(), that executes a function which generates a new function customized for usage in the place I called it from
18:00:59 <asgoyal> aaah ok
18:01:14 <djazayeri> the q and response arguments will be provided when you eventually use the callback
18:01:38 <asgoyal> so that is what we have to provide the parameters tothe returned function
18:02:09 <djazayeri> correct, although the idea is that you don't call the returned function directly
18:02:25 <djazayeri> rather it's a callback that gets called by the autocomplete widget at some relevant point
18:02:49 <asgoyal> hm..
18:03:01 <asgoyal> so
18:03:10 <asgoyal> in the sample code tht you showed me
18:03:24 <asgoyal> how are we providing the parameters to it?
18:03:33 <djazayeri> we don't provide parameters to it
18:03:37 <asgoyal> like we just call the conceptcallback
18:03:39 <asgoyal> oh
18:03:48 <asgoyal> but that will return the funciton
18:03:55 <asgoyal> so q and response for that?
18:04:10 <djazayeri> if you call something a "callback", you typically mean that it's a function that will be called by some UI widget, scheduled task, etc, at an appropriate point in the future
18:04:19 <asgoyal> ok
18:04:41 <djazayeri> but it's up to the UI widget, scheduled task, etc, to provide the arguments to that function call at the appropriate time
18:04:47 <asgoyal> oh
18:05:02 <asgoyal> is it like an event handler?
18:05:23 <djazayeri> yes, exactly
18:05:35 <asgoyal> oh k
18:05:37 <asgoyal> last thing
18:05:59 <asgoyal> the select: ... i didn't understand its content
18:06:07 <asgoyal> select: function(event, ui) {
18:06:07 <asgoyal> $j('#allergy_concept_id').val(ui.item.object.conceptId);
18:06:07 <asgoyal> }
18:06:10 <djazayeri> I haven't looked at the underlying code, but I assume this is the event handler for "user typed in the text box of the autocomplete"
18:06:21 <asgoyal> oh ok
18:06:31 <asgoyal> yeah i have to do something similar for the drug ingredients
18:06:59 <djazayeri> sorry, I typed that later
18:07:26 <asgoyal> like when the user puts in some name for drug ingredients it should automatically display the drug ingredients name (concept names)
18:07:27 <asgoyal> oh np
18:07:28 <djazayeri> the content in the allergy example looks like a callback function for the "select" event
18:07:38 <asgoyal> ooohh
18:07:57 <djazayeri> and what it does is set the value of the #allergy_concept_id element to ui.item.object.conceptId
18:08:17 <asgoyal> oh ok
18:08:23 <asgoyal> so how will it change for my case
18:08:28 <asgoyal> like i want to display
18:08:33 <asgoyal> a list of options to user
18:08:45 <asgoyal> when he enters a letter or two of some concept name
18:09:05 <asgoyal> so that he gets a list of option as a drop down once he starts typing in text field
18:09:47 <djazayeri> by the way, have you tried doing this using the simpler "conceptField" tag first?
18:10:02 <asgoyal> oh no..
18:10:21 *** JoshMandel has joined #openmrs
18:10:23 <asgoyal> oh you mean just displaying the concept names?
18:10:23 <asgoyal> i did that
18:10:23 <djazayeri> the idea is that it wraps the complexity of the autocomplete widget for you, making it much easier to use
18:10:29 <asgoyal> oh
18:10:33 <djazayeri> no, letting the user pick a concept
18:10:40 <asgoyal> oh .. no i haven't
18:10:54 <asgoyal> i dont know how to use it
18:11:58 <djazayeri> The simplest way to let the user choose a concept, in the UI, is to do <openmrs:fieldgenformFieldName="conceptId"type="org.openmrs.Concept"/>
18:12:16 <asgoyal> oh ok
18:12:29 <asgoyal> wow thanks i will try this then
18:13:40 *** wyclif has quit IRC
18:14:07 *** JoshMandel1 has joined #openmrs
18:14:17 <downeym> Hi JoshMandel1 and welcome to the #openmrs IRC channel.
18:16:14 *** aja has quit IRC
18:16:28 <JoshMandel1> Hi there! Just wanted to check in and see if I can help answer any SMART sprint-related questions. (Any minute now I'm going to take over the nick JoshMandel from my former self.)
18:16:54 <djazayeri> hi JoshMandel and JoshMandel1
18:16:58 *** JoshMandel has quit IRC
18:17:05 *** JoshMandel1 is now known as JoshMandel
18:17:29 <JoshMandel> Hi Darius
18:17:31 <djazayeri> I have no questions (since I'm not working on the Sprint). bwolfe?
18:18:55 <bwolfe> there are some questions on a few of the new tickets I made
18:19:13 <bwolfe> like "is it possible to scan an app when its being loaded to see what mappings its going to request" ?
18:19:21 <bwolfe> (I think we've asked this before though)
18:19:42 <djazayeri> dkayiwa: did you notice the failing unit test from your recent commit?
18:19:59 <JoshMandel> Right -- interesting questions and a really good idea for an extension to the manifest file format. But there's no formal way right now.
18:20:03 <dkayiwa> djazayeri: i saw it, i just wonder why?
18:20:49 <dkayiwa> djazayeri: compiles well on mine. what could it be?
18:20:56 <djazayeri> did you touch PersonAttribute.java?
18:21:03 <dkayiwa> yes
18:21:09 <djazayeri> https://ci.openmrs.org/browse/JUNIT-TRUNK-1239/
18:21:31 <djazayeri> com.mysql.jdbc does not exist. (this shouldn't be imported)
18:21:40 <djazayeri> and something about StringUtils not found
18:21:50 <dkayiwa> oh i see
18:21:59 <bwolfe> JoshMandel, even with scanning it the files?
18:22:04 <dkayiwa> let me fix it immediately
18:23:11 <JoshMandel> bwolfe: I'm browsing the tickets on https://tickets.openmrs.org/browse/SMART. What's the best way for me to find questions attached to issues? ("Activity Stream" seems helpful, but I want to make sure I'm not overlooking something.)
18:25:11 <JoshMandel> bwolfe: not sure what you mean about scanning the files. Do you mean like static analysis of an app's code? (In general an app might keeps it source code proprietary, e.g. a REST app that runs on a remote server.)
18:25:51 <djazayeri> bwolfe: I think we should just look for a way for the app to "publish" terms it cares about, but scanning the code seems like a bad idea.
18:25:58 *** Gagaman has joined #openmrs
18:26:35 <bwolfe> JoshMandel, yes, thats what I meant. but that makes sense
18:26:56 <JoshMandel> Agreed. SMART should define a formal declarative way for apps to indicate this. But we don't have that right now. (Informally, apps can do this in their documentation.)
18:27:14 *** bryq has joined #openmrs
18:27:14 *** ChanServ sets mode: +v bryq
18:28:29 <bwolfe> JoshMandel, think you can have that in the next few days? ;-)
18:29:37 <JoshMandel> Well, for our 1st crop of apps we're "stuck" with the specification we used for our $5K SMART App Challenge :-)
18:30:19 <JoshMandel> We're still working on a versioning scheme...
18:30:43 <bwolfe> JoshMandel, add it, make it optional, then "suggest" to apps that they add it to theirs ;-)
18:30:46 <Gagaman> Hi!
18:30:49 <Gagaman> dkayiwa: I'm getting an error with XForms using it's patient creation form
18:30:56 <bwolfe> hi Gagaman
18:31:03 <Gagaman> are you still in charge of the module?
18:31:04 <dkayiwa> Gagaman: which error?
18:31:07 <bwolfe> JoshMandel, have you seen the sprint homepage? https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10550
18:31:07 <OpenMRSBot> <http://ln-s.net/94_C> (at tickets.openmrs.org)
18:31:14 <dkayiwa> Gagaman: yes
18:32:07 <r-friedman> djazayeri: got a minute?
18:32:08 <Gagaman> a There is no patient with id: '0' after canceling the creation of the patient
18:32:09 <bwolfe> JoshMandel, the new tickets and tickets with questions are just in comments right now in the tickets in the sprint. the stream you found is probably best :-)
18:32:15 <djazayeri> r-friedman: what's up?
18:32:40 <r-friedman> i saw the name of the MySql driver pass by a few lines ago with dk
18:33:00 <dkayiwa> Gagaman: which version of the module are you using?
18:33:00 <r-friedman> i am working with the jasper report module, and it needs a connection to the DB
18:33:10 <r-friedman> the way it was originally written, it only supported mysql
18:33:22 <r-friedman> i am wondering if this is the case elsewhere in openmrs
18:33:31 <JoshMandel> bwolfe: yes, thanks. In general it's a good bet to e-mail me with specific questions, but I'll do my best to keep up with the feed. Just want to make sure I don't overlook details.
18:33:35 <r-friedman> there is a loadDatabaseDriver routine in dbutils
18:33:47 <r-friedman> it uses stuff out of the runtime properties file
18:33:56 <dkayiwa> Gagaman: that is fixed in the latest version
18:33:57 <Gagaman> The latest. I was using the 4.0.4, got the bug, saw the changelog to the 4.0.5, grinned with relief, did the upgrade... and yet the same error
18:34:00 <r-friedman> but it is not exposed through the admin service
18:34:04 <bwolfe> JoshMandel, what, you have better things to do than to hang out in here during my working hours ?!?
18:34:18 <r-friedman> nor is the connection to the db exposed
18:34:26 <r-friedman> do you think modules should share connections with core?
18:34:50 <r-friedman> do you think the properties to set up a connection should be available thru admin service?
18:35:31 <djazayeri> r-friedman: I don't think we've previously exposed the raw db connection
18:35:37 <JoshMandel> bwolfe: Ha, I'm always looking for new sources of interrupts! (Integrated gnome desktop messaging when my name is mentioned in a msg certainly seems to be doing the trick...)
18:35:55 <djazayeri> Offhand I don't think we want to
18:36:23 <bwolfe> r-friedman, the db connection can be had through the hibernate session in the dao layer
18:36:39 <bwolfe> not sure we should expose it for people to just muck around with it in their service layers :-)
18:36:51 *** Gagaman_ has joined #openmrs
18:36:58 <r-friedman> bwolfe: good to know about getting at it thru hibernate
18:36:58 <downeym> Hi Gagaman_ and welcome to the #openmrs IRC channel.
18:37:16 <r-friedman> but if you are starting up either birt or jasper, you need to pass as DB connection
18:37:44 <dkayiwa> Gagaman: just tested with the latest version and my cancel does not throw any error
18:37:45 <Gagaman_> Sorry, router failure. dkayiwa, do you need the stack trace? Any clean place to post it?
18:38:14 *** Gagaman has quit IRC
18:38:30 *** jriley has quit IRC
18:38:43 <r-friedman> djazayeri: my big concern is that there are other modules out there that are not supporting all DBs because of the difficulty of getting the driver name
18:39:00 <djazayeri> r-friedman: your concern makes sense
18:39:18 <Gagaman_> Do I need to redesign the Form with the new version of the module?
18:39:25 <dkayiwa> no
18:39:42 <dkayiwa> Gagaman_: cross check one again the version you are using
18:39:48 <dkayiwa> and then try hit cancel again
18:40:06 <djazayeri> You need a jdbc DBConnection (or something)?
18:40:09 <djazayeri> You = the modul
18:40:28 <r-friedman> djazayeri: yes, for jasper or birt reports
18:40:52 *** wyclif has joined #openmrs
18:40:53 <r-friedman> it looks like birt is fading the issue by getting an intermediate output able
18:40:55 *** wyclif has quit IRC
18:40:58 <Gagaman_> 1.8.2 Build 21762, latest XForms
18:41:15 *** wyclif has joined #openmrs
18:41:31 <djazayeri> r-friedman: but people often use birt with direct db connections
18:41:48 <r-friedman> so they are configuring it directly on their machines?
18:41:56 <djazayeri> I don't know how they set it up
18:41:57 <dkayiwa> Gagaman_: which exact version of the xforms module?
18:42:16 <Gagaman_> 4.0.5
18:42:18 <r-friedman> i mean, that's always possible
18:42:37 <dkayiwa> Gagaman_: let me test it again on 1.8
18:42:45 <djazayeri> r-friedman: I think this is probably a good question for the dev list.
18:42:52 <r-friedman> but it seems smoother to take the info from the runtime properties file
18:42:59 <r-friedman> ok i will take it to the list
18:43:03 <djazayeri> I'd like to think a bit more about whether it's "correct" to expose the db connection
18:43:09 <djazayeri> surely the runtime props should be available.
18:43:51 <Gagaman_> Ok. Please let me know how to submit the bug, the "report bug" button redirects me to http://localhost/scrap
18:44:08 <Gagaman_> Anything I need to install?
18:44:11 <r-friedman> i think they are but we are not requiring driver name
18:44:58 <r-friedman> ok i will take it to the list, tks
18:45:06 <djazayeri> r-friedman: I guess it makes sense that you should be able to ask for the driver name
18:45:28 *** bryq1 has joined #openmrs
18:47:31 <dkayiwa> Gagaman_: installing 1.8 to see if i can reproduce it on this very version
18:47:50 *** bryq has quit IRC
18:48:39 <Gagaman_> dkayiwa: Thanks. Do you know why the "report bug" button redirects me to localhost/scrap ? Is there anything I should install?
18:51:45 *** sunbiz has joined #openmrs
18:51:53 *** ChanServ sets mode: +v sunbiz
18:52:32 <sunbiz> hey all
18:52:36 <sunbiz> look at https://tickets.openmrs.org/browse/TRUNK-1926
18:52:49 <dkayiwa> Gagaman_: let me first confirm that its a bug
18:53:15 <Gagaman_> dkayiwa: Allright
18:53:31 <sunbiz> when Im upgrading to 2.0 of liquibase, they have removed the modifyColumn from the core
18:54:02 <djazayeri> sunbiz: do they explain why?
18:54:17 <sunbiz> instead they recommend using modifyDataType
18:54:25 <sunbiz> http://liquibase.org/v2_upgrade
18:55:45 <bwolfe> sunbiz, its fine to change it in the demo and core datasets
18:55:55 <bwolfe> its NOT ok to change it in the liquibase-update-ot-latest. do we use it there?
18:56:07 <bwolfe> (or use the defaultvaluenumeric there?)
18:56:54 <djazayeri> sunbiz: I agree with Ben. We should avoid changing existing changesets unless it's really necessary
18:57:22 <djazayeri> so in this case we should include the extension to enable modifyColumn to work for past changesets, but stop using it going forwards.
18:59:01 *** sunbiz has quit IRC
19:00:07 *** sunbiz has joined #openmrs
19:00:33 <JoshMandel> bwolfe: I commented on your mapping issue (https://tickets.openmrs.org/browse/SMART-22?focusedCommentId=173291#comment-173291)
19:00:37 *** ChanServ sets mode: +v sunbiz
19:00:40 <OpenMRSBot> <http://ln-s.net/94cf> (at tickets.openmrs.org)
19:01:40 <sunbiz> djazayeri: there isn't a broad explanation, but seems more appropriate... modifyColumn could do many things... that has been divided to specific tags now
19:01:56 <djazayeri> sunbiz: that makes perfect sense going forwards
19:01:57 *** jriley has joined #openmrs
19:02:00 <sunbiz> but they haven't mentioned in detail in the sparse documentation of liquibase
19:02:04 *** Gagaman_ has quit IRC
19:02:04 <djazayeri> but modifying past changesets should be avoided, I think
19:02:27 <sunbiz> yes... but it has to be done at this instance, because the library is being upgraded
19:02:42 <sunbiz> I've tried adding the extension library... for modifyColumn
19:02:45 <djazayeri> and?
19:02:57 <sunbiz> but it is not taking the defaultValueNumeric tag
19:03:04 <sunbiz> from the modified columns
19:03:34 <sunbiz> sorry... defaultValue* attribute from the modifyColumn tag
19:03:45 <djazayeri> ah, okay
19:04:08 <djazayeri> well, if you get it to work using the extension, I guess changing to modifyDatatype is fine
19:04:38 *** r-friedman has quit IRC
19:04:38 *** vchircu has quit IRC
19:04:58 <bwolfe> sunbiz, its an extension, modify it so it works. :-)
19:05:02 <sunbiz> u mean... "if you *CAN'T* get it to work" using extension
19:05:18 <djazayeri> yes
19:05:20 <djazayeri> :-)
19:06:24 <sunbiz> bwolfe: u want to modify the extension...
19:06:39 <bwolfe> sunbiz, or copy/paste to a new one
19:06:40 <sunbiz> so... modify-column-2.0.0-mod. jar now??
19:06:47 <bwolfe> hehe
19:06:53 <bwolfe> modify-column-openmrs-2.0.0
19:07:13 <bwolfe> extensions are meant to be modified/added/etc
19:07:21 <bwolfe> the core jar, not as much
19:07:23 <sunbiz> yes
19:07:42 <sunbiz> but modifyDataType is more obvious tag to be used
19:11:40 <sunbiz> bwolfe: also the new 2.0 xsd validation fails with modifyColumn
19:12:01 <sunbiz> but thats probably trivial and we can stay at 1.9 xsd
19:12:02 <bwolfe> how so?
19:12:26 <bwolfe> if he's allowing tags from extensions he shouldn't be validating so strictly!
19:12:31 <sunbiz> http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-2.0.xsd
19:13:18 <sunbiz> bwolfe: sadly he does!!
19:14:15 <sunbiz> or probably I've to add another xsd from classpath that may be included in the extension library
19:18:52 *** sunbiz has quit IRC
19:24:43 *** sunbiz has joined #openmrs
19:25:14 *** free__ has joined #openmrs
19:25:26 <free__> hi all
19:25:58 <free__> can any one give the template for module documentation ?
19:26:50 <dkayiwa> free__: have you looked at any of the existing module documentation?
19:26:59 *** yanokwa has quit IRC
19:27:15 *** ChanServ sets mode: +v sunbiz
19:27:24 <sunbiz> djazayeri bwolfe : please comment on the ticket
19:27:47 <sunbiz> since the modifyColumn fails validation
19:28:25 <bwolfe> free__, theres a "copy" option in the "tools" dropdown of every wiki page
19:29:08 <free__> dkayiwa ya i have seen one is differing another , is there any standard template ?
19:30:10 <dkayiwa> free__: oh i see!!! So you are just looking for the best to copy as template?
19:30:35 <free__> dkayiwa yes
19:32:11 <free__> dkayiwa: can u give ?
19:34:06 <dkayiwa> free__: may be https://wiki.openmrs.org/display/docs/FormEntry+Module
19:34:15 <OpenMRSBot> <http://ln-s.net/94dD> (at wiki.openmrs.org)
19:36:19 <jriley> What are ConceptSets used for?
19:36:41 <djazayeri> jriley: that's the domain class that represents set membership
19:36:49 <jriley> I've looked at the Concept and ConceptSet classes , bt what are they used for?
19:36:53 <djazayeri> e.g. Isoniazid is in the set Tuberculosis Drugs
19:36:59 <jriley> A concept carries around this sortable set of concepts because ...
19:37:05 <jriley> Ah! Ok!
19:37:21 <djazayeri> it's empty unless isSet is true
19:38:02 *** jportela has joined #openmrs
19:38:02 *** ChanServ sets mode: +v jportela
19:38:38 <jriley> and this shows up in my concept dictionary, like when I define Tuberculosis Drug
19:38:40 <jriley> Thanks
19:38:55 *** asgoyal has quit IRC
19:39:02 <jriley> Looks like ConceptSet could be named ConceptSetMember
19:39:55 <djazayeri> yeah, our convention is to use the two table names. Though I think CSM would be more intuitive
19:40:48 <djazayeri> strictly speaking it's the "membership" rather than the "member"
19:47:09 *** suhothayan has joined #openmrs
19:47:09 *** ChanServ sets mode: +v suhothayan
19:48:24 *** jportela1 has joined #openmrs
19:48:30 *** jportela has quit IRC
19:48:39 <downeym> Hi jportela1 and welcome to the #openmrs IRC channel.
19:50:17 *** jportela1 has quit IRC
19:50:41 *** suho has quit IRC
19:51:41 *** jportela has joined #openmrs
19:51:41 *** ChanServ sets mode: +v jportela
19:56:26 *** muthah has joined #openmrs
19:56:36 *** jportela1 has joined #openmrs
19:58:57 *** jportela has quit IRC
19:59:00 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Fixing compiler error on build server - TRUNK-2459 <http://feedproxy.google.com/~r/OMRStrunk/~3/NujbcdEsME8/OpenMRS>
20:02:48 *** jportela1 has quit IRC
20:04:38 *** jportela has joined #openmrs
20:04:48 *** ChanServ sets mode: +v jportela
20:06:42 *** cta has quit IRC
20:08:33 *** jportela1 has joined #openmrs
20:09:08 *** jportela has quit IRC
20:10:00 *** free__ has quit IRC
20:15:12 *** jportela1 has quit IRC
20:18:08 *** jportela has joined #openmrs
20:18:08 *** ChanServ sets mode: +v jportela
20:20:03 *** bryq has joined #openmrs
20:20:03 *** ChanServ sets mode: +v bryq
20:20:11 *** jriley has quit IRC
20:21:16 *** bryq1 has quit IRC
20:21:45 *** bwolfe has quit IRC
20:22:16 *** jportela has quit IRC
20:22:50 *** jportela has joined #openmrs
20:22:50 *** ChanServ sets mode: +v jportela
20:22:55 *** yanokwa has joined #openmrs
20:22:55 *** ChanServ sets mode: +v yanokwa
20:23:36 *** gbastien has quit IRC
20:32:07 *** bryq has quit IRC
20:32:09 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Register now for our next #OpenMRS implementers meeting: Oct 11-14 in Kigali #Rwanda: http://t.co/V07AiVn #ICT4D #eHealth #HealthIT <http://twitter.com/OpenMRS/statuses/103194220604555264>
20:32:41 *** yanokwa has quit IRC
20:41:31 *** gbastien has joined #openmrs
20:41:35 *** jportela1 has joined #openmrs
20:43:19 <djazayeri> downeym: the wiki page says "Meals are included in the registration fee"
20:43:22 <djazayeri> does that mean all means?
20:43:36 <djazayeri> all meals?
20:43:38 <downeym> djazayeri: as far as i'm aware
20:43:56 <djazayeri> surprising to me that it includes dinner, but okay. I'll ping dawn
20:43:57 *** jportela has quit IRC
20:44:15 <downeym> what i heard was that the evening meals will be sponsored
20:44:24 <djazayeri> okay
20:51:22 *** jportela1 has quit IRC
20:51:58 *** jportela has joined #openmrs
20:51:58 *** ChanServ sets mode: +v jportela
20:54:18 *** dkayiwa has quit IRC
21:01:13 *** jportela has quit IRC
21:01:45 *** jportela has joined #openmrs
21:01:45 *** ChanServ sets mode: +v jportela
21:02:03 *** jportela has left #openmrs
21:04:33 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Announcements List: Save the Date: 2011 Implementers Meeting <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1108&L=openmrs-announce-l&P=1203> || New Changeset: OpenMRS (providers): changing pom.xml files so that having the providers branch and trunk checked out simultaneously doesn't confuse eclipse <http://feedproxy.google.com/~r/OMRStrunk/~3/OJJKNKPvIas/OpenMRS>
21:08:36 *** downeym has quit IRC
21:09:01 *** downeym has joined #openmrs
21:09:01 *** ChanServ sets mode: +o downeym
21:09:01 *** OpenMRSBot sets mode: +o downeym
21:29:42 *** gagaman has joined #openmrs
21:31:14 *** gagaman has quit IRC
21:36:55 *** sunbiz has left #openmrs
21:36:57 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/dmwWwlcdab4/OpenMRS> || New Changeset: OpenMRS (providers): changing pom.xml files so that having the providers branch and trunk checked out simultaneously doesn't confuse eclipse <http://feedproxy.google.com/~r/OMRStrunk/~3/Ig5Du-KCGSw/OpenMRS>
21:42:37 *** jprice has joined #openmrs
21:57:10 *** suhothayan has quit IRC
22:04:25 <jprice> hi djazayeri, r u there (and willing to divluge that fact....) ?
22:04:36 <djazayeri> I'm here
22:05:35 <jprice> so, I saw the comments in TRUNK-2557. It is not clear to me what the status of the issue is. could you clarify for me ?
22:06:06 *** jriley has joined #openmrs
22:15:33 <djazayeri> jprice: the issue is that we haven't been able to find a proper place in the HL7 message where we'd indicate an encounter type
22:20:51 *** gbastien has quit IRC
22:37:31 *** downeym has quit IRC
22:42:31 <jprice> so is the status that it is on hold for now ? (I did try using the formId approach but that did not work)
22:42:48 <djazayeri> correct
22:42:59 <djazayeri> Tomorrow I think I'll have time to try posting the message again, and checking the debugger.
22:43:18 <jprice> ok. thanks.
23:22:45 *** wyclif has quit IRC
23:27:30 *** jriley has quit IRC
23:31:50 *** asgoyal has joined #openmrs
23:34:20 *** jriley has joined #openmrs
23:59:20 *** wyclif has joined #openmrs