| 01:43:37 | *** goutham has joined #openmrs |
| 02:27:30 | *** robbyoconnor is now known as ` |
| 02:27:36 | *** ` is now known as r0bby_ |
| 02:27:43 | *** r0bby_ is now known as robbyoconnor |
| 02:54:00 | *** goutham has quit IRC |
| 02:57:03 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Moca Module 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=moca&version=&1.0> |
| 03:13:52 | *** finbrein has joined #openmrs |
| 03:17:44 | *** finbrein has quit IRC |
| 03:18:00 | *** finbrein has joined #openmrs |
| 04:08:10 | *** finbrein has quit IRC |
| 04:10:18 | *** upul` has joined #openmrs |
| 04:10:18 | *** ChanServ sets mode: +v upul` |
| 04:36:55 | *** surangak has joined #openmrs |
| 04:48:19 | *** finbrein has joined #openmrs |
| 04:48:30 | *** gauravpaliwal has joined #openmrs |
| 04:48:30 | *** ChanServ sets mode: +v gauravpaliwal |
| 04:48:54 | <gauravpaliwal> hi anyone here ? |
| 04:51:20 | <gauravpaliwal> like alert is their any way to have notification of openmrs_msg directly from the controller ? |
| 04:56:43 | *** gauravpaliwal has left #openmrs |
| 05:18:40 | *** czakian has joined #openmrs |
| 05:19:09 | *** robbyoconnor has quit IRC |
| 05:40:16 | *** robbyoconnor has joined #openmrs |
| 05:40:16 | *** ChanServ sets mode: +v robbyoconnor |
| 05:58:25 | *** gauravpaliwal has joined #openmrs |
| 05:58:25 | *** ChanServ sets mode: +v gauravpaliwal |
| 06:04:51 | *** bwolfe has joined #openmrs |
| 06:04:51 | *** ChanServ sets mode: +o bwolfe |
| 06:18:48 | *** pascal` has joined #openmrs |
| 06:25:50 | *** pascal` has quit IRC |
| 06:40:55 | *** rafa has joined #openmrs |
| 06:40:55 | *** ChanServ sets mode: +v rafa |
| 06:41:52 | *** pascal` has joined #openmrs |
| 06:42:08 | *** cta has joined #openmrs |
| 06:44:37 | *** dkayiwa has joined #openmrs |
| 06:55:58 | *** finbrein has quit IRC |
| 07:02:55 | *** gauravpaliwal has left #openmrs |
| 07:19:33 | *** finbrein has joined #openmrs |
| 07:41:19 | *** cta has quit IRC |
| 07:43:46 | *** goutham has joined #openmrs |
| 07:54:54 | *** cta has joined #openmrs |
| 08:11:37 | *** bryq has joined #openmrs |
| 08:11:37 | *** ChanServ sets mode: +v bryq |
| 08:18:57 | *** surangak has quit IRC |
| 08:21:04 | *** goutham has quit IRC |
| 09:08:03 | *** finbrein has quit IRC |
| 09:08:19 | *** finbrein has joined #openmrs |
| 09:11:53 | *** surangak has joined #openmrs |
| 09:14:57 | *** surangak_ has joined #openmrs |
| 09:14:57 | *** surangak has quit IRC |
| 09:26:00 | *** surangak__ has joined #openmrs |
| 09:26:28 | *** surangak_ has quit IRC |
| 09:26:42 | *** surangak has joined #openmrs |
| 09:52:06 | *** magoo has joined #openmrs |
| 10:10:28 | <bryq> rafa: Hi, I've got problems with merging as always :) Everytime I try to merge my branch into trunk there are some errors. I've tried to merge from revision we've merged last or from revision we started the branch, but always few files aren't up to date. I think it is caused because of that we did the catching-up commits with unresolved conflicts. My solution to this problem is: merge trunk into my branch (which should be smooth) and then replace |
| 10:12:03 | <rafa> bryq: Hi, it should work both ways. I'll look into that over the weekend and let you know. |
| 10:13:26 | <bryq> rafa: But I will merge the trunk into my branch. Okay? |
| 10:14:58 | <rafa> bryq: It's not necessary, but if you've got some free time feel free... |
| 10:36:36 | *** pascal` has quit IRC |
| 10:37:50 | *** pascal` has joined #openmrs |
| 11:06:12 | <bwolfe> bryq, have you seen the "branching and merging techniques" wiki page ? |
| 11:07:31 | <bryq> bwolfe: Yes |
| 11:08:32 | <bwolfe> oh, ok |
| 11:08:54 | <bryq> bwolfe: The page was useful, but I was still having errors |
| 11:10:01 | <bwolfe> bummer |
| 11:10:12 | <bwolfe> I always bring the branch up to date with trunk |
| 11:10:14 | <bwolfe> then merge back |
| 11:10:45 | <bwolfe> if its not too big, when merging back I do it with a patch file. eclipse will let you compare two different branches to get a patch file out of it |
| 11:13:08 | <bryq> bwolfe: The branch is really big. 3 months of developing. I tried to keep it up to date with trunk |
| 11:13:28 | <bryq> bwolfe: Now, when I'm merging trunk into branch everything goes smooth |
| 11:18:17 | <rafa> bryq: No worries. We'll do it the same way as before. I'll do it, but won't commit and I'll write you instructions so that you could play with it yourself. It's just that I don't have time right now. I'll ping you by Sunday. |
| 11:20:28 | <bryq> rafa: Okay :) I'll do some more code cleaning now |
| 11:21:14 | <rafa> bryq: You could start writing documentation as well :) |
| 11:21:41 | <rafa> bryq: You'll need to update some of exisitng wiki pages and add new ones. |
| 11:23:10 | <bryq> Good idea |
| 11:26:02 | *** james_regen has joined #openmrs |
| 11:26:02 | *** ChanServ sets mode: +v james_regen |
| 11:33:56 | *** upul` has quit IRC |
| 11:50:39 | *** surangak has quit IRC |
| 12:00:25 | *** wayne has joined #openmrs |
| 12:02:29 | *** rcrichton has joined #openmrs |
| 12:02:29 | *** ChanServ sets mode: +v rcrichton |
| 12:21:25 | *** elliott_w has joined #openmrs |
| 12:21:25 | *** ChanServ sets mode: +o elliott_w |
| 12:37:27 | *** downeym has joined #openmrs |
| 12:37:27 | *** ChanServ sets mode: +o downeym |
| 12:37:27 | *** OpenMRSBot sets mode: +o downeym |
| 12:40:38 | *** gbastien has joined #openmrs |
| 12:59:24 | *** wayne has quit IRC |
| 13:00:09 | *** finbrein has quit IRC |
| 13:00:34 | *** elliott_w has quit IRC |
| 13:08:34 | *** rcrichton has quit IRC |
| 13:24:36 | *** rcrichton has joined #openmrs |
| 13:24:47 | *** ChanServ sets mode: +v rcrichton |
| 13:33:39 | *** chopin has joined #openmrs |
| 13:33:42 | <chopin> when is 1.8.3 coming out? |
| 13:40:16 | *** downeym_ has joined #openmrs |
| 13:40:16 | *** ChanServ sets mode: +o downeym_ |
| 13:40:48 | *** finbrein has joined #openmrs |
| 13:41:57 | *** downeym has quit IRC |
| 13:41:57 | *** downeym_ is now known as downeym |
| 13:53:49 | *** wyclif has joined #openmrs |
| 13:54:53 | *** jportela has joined #openmrs |
| 13:54:53 | *** ChanServ sets mode: +v jportela |
| 13:55:16 | *** jportela has left #openmrs |
| 13:56:58 | *** jportela has joined #openmrs |
| 13:56:58 | *** ChanServ sets mode: +v jportela |
| 13:57:42 | <rcrichton> Hi bwolfe, djazayeri, I've been working on OCC-86 and I've got a fix for it but in the process I've changed the name of the implemtation source in the serialised xml as it wasn't right. This should break uploads to the OCC server unless everyone updates both the module and the server. Is this ok to commit? |
| 13:57:46 | <chopin> when is 1.8.3 coming out? |
| 13:58:11 | <downeym> wyclif: ^ ^ |
| 13:58:12 | <wyclif> chopin, do you need it so soon? |
| 13:58:24 | <chopin> YES |
| 13:58:29 | <wyclif> why? |
| 13:58:32 | <chopin> i need the openmrs.js fix |
| 13:58:36 | <chopin> not sure how that didn't sink in previously |
| 13:58:38 | <wyclif> ohhhh |
| 13:58:57 | <chopin> also, if you look you will find LOTS of dojo references still in openmrs |
| 13:59:04 | <chopin> (generally) |
| 13:59:08 | <chopin> widgets, mostly |
| 13:59:11 | <wyclif> am so sure when we will release |
| 13:59:21 | <chopin> what is required for 1.8.3 to be released? |
| 13:59:24 | <chopin> what tickets? |
| 13:59:26 | <chopin> i will work on them |
| 14:00:24 | <wyclif> we are just leaving enough time to see if any more bugs are found that can be fixed in 1.8.3 |
| 14:01:00 | <chopin> what is that time window |
| 14:01:11 | <chopin> i have to tell my implementation (the only one, apparently, that runs 1.8.x) |
| 14:01:17 | <bwolfe> rcrichton, what do you mean? is it a misspelling in the xml? |
| 14:01:33 | <bwolfe> rcrichton, its ok to commit. the only users are devs in here on the sprint |
| 14:01:53 | <bwolfe> chopin, why do they need 1.8.3 ? |
| 14:02:06 | <bwolfe> chopin, do a search for all tickets with fixVersion of 1.8.3 |
| 14:02:38 | <chopin> they need the openmrs.js fix |
| 14:02:46 | <chopin> until then i've given them a custom war file |
| 14:02:51 | <chopin> but that's not a permanent fix |
| 14:03:09 | <chopin> indeed anyone running formentry on 1.8.2 needs the openmrs.js fix |
| 14:03:23 | <chopin> so, 1.8.2 is essentially broken, since it bundles formentry |
| 14:03:32 | <bwolfe> no one uses formentry anymore |
| 14:03:35 | <bwolfe> its so 2005 |
| 14:03:37 | <rcrichton> bwolfe, Yeah the implemetationSource object in the serialised xml was called implmentationSourceID so I fixed it then realised it broke the import, so I fixed it everywhere, just checking its ok to commit |
| 14:03:47 | <chopin> (then why is it bundled?) |
| 14:03:57 | <downeym> touche' |
| 14:04:05 | <downeym> https://tickets.openmrs.org/browse/TRUNK/fixforversion/13607 |
| 14:04:08 | <bwolfe> because we party like its 2005 |
| 14:04:11 | <OpenMRSBot> <http://ln-s.net/93zB> (at tickets.openmrs.org) |
| 14:04:12 | <bwolfe> rcrichton, yes, its ok ot commit it |
| 14:04:28 | <chopin> just sayin' ... it's broke |
| 14:04:34 | <djazayeri> rcrichton: what are you committing? |
| 14:05:59 | <rcrichton> Its a fix for OCC-86 but in the process I changes something in the serilization that will break upload to the OCC server unless dev update to the latest module and server code that I will commit |
| 14:06:10 | <rcrichton> devs* |
| 14:06:20 | <djazayeri> okay, I was in the middle of working on that too |
| 14:06:25 | <djazayeri> can you pastebin a patch? |
| 14:06:36 | <djazayeri> and I'll look at it real quick? |
| 14:06:47 | <rcrichton> Yeah ok, will do |
| 14:08:25 | <rcrichton> djazayeri, http://pastebin.com/akSk46u0 |
| 14:11:13 | <djazayeri> rcrichton: add a p to "imlementation" in an exception, and it looks good |
| 14:11:50 | <rcrichton> djazayeri, ok will do :) |
| 14:12:01 | <djazayeri> actually, what's the module-side change? |
| 14:13:04 | <djazayeri> I have an uncommitted change that changes the OccUpload.implementationSourceId from a ConceptSource to an ImplementationId |
| 14:13:13 | <djazayeri> but I can probably apply this after your fix. |
| 14:14:06 | <rcrichton> djazayeri, Just beacause I changes the name of the field in the OCCUpload.class from implementationSourceId to implementationSource it needed to be changed in the module for the upload to works |
| 14:14:18 | <djazayeri> okay |
| 14:14:59 | <rcrichton> I'm commit both now and you can have a look |
| 14:16:39 | <djazayeri> cool |
| 14:16:57 | <djazayeri> bwolfe, rafa, rcrichton, dkayiwa, wyclif: scrum time? |
| 14:17:07 | <bwolfe> ah yes, I suppose it is scrumtime |
| 14:17:11 | <bwolfe> scrumetime (R) |
| 14:17:17 | <bwolfe> err, scrumtime (R) |
| 14:17:50 | <wyclif> ok |
| 14:17:51 | <rafa> hey! |
| 14:18:43 | <dkayiwa> :) |
| 14:19:04 | <bwolfe> rafa, you go first |
| 14:19:11 | <rafa> Today: |
| 14:19:11 | <rafa> * Worked on: |
| 14:19:11 | <rafa> - OCC-60: Develop algorithm for concept priority |
| 14:19:11 | <rafa> https://tickets.openmrs.org/browse/OCC-60 |
| 14:19:11 | <rafa> - OCC-19: Send data to OCC about how many forms, obs, a concept is used on |
| 14:19:11 | <rafa> https://tickets.openmrs.org/browse/OCC-19 |
| 14:19:11 | <rafa> I'm testing both right now and I'll commit soon. |
| 14:19:12 | <rafa> Monday: |
| 14:19:12 | <rafa> * Review some of Piotr's code |
| 14:19:13 | <rafa> * Not sure yet |
| 14:19:13 | <rafa> No blockers. |
| 14:19:35 | <bwolfe> how close to commit rafa? |
| 14:19:43 | <rafa> 1-2 hours |
| 14:22:02 | <rafa> I'm writing some extra tests now and I still need to test it by clicking through |
| 14:23:28 | <bwolfe> nice. |
| 14:23:36 | <bwolfe> dkayiwa, you ready? |
| 14:23:47 | <dkayiwa> Finished working Improved workflow for showing suggestions during concept creation - OCC-61 |
| 14:23:48 | <dkayiwa> Now working on OCC server doesn't support creating concept sources with hl7Code length > 5 - OCC-83 |
| 14:23:48 | <dkayiwa> No blockers. |
| 14:24:21 | <djazayeri> dkayiwa: you probably shouldn't do OCC-83 |
| 14:24:25 | <djazayeri> see the comment I'll post in 5 seconds. |
| 14:24:30 | <dkayiwa> ok |
| 14:24:42 | <cta> bwolfe, djazayeri, wyclif I created review for my GSoC project and added you to list of reviewers. It's here https://source.openmrs.org/cru/CR-TRUNK-448 If you will have opportunity, please, make this review and inform me. |
| 14:25:53 | <bwolfe> dkayiwa, awesome. did you attach any screenshots perchance, or will I need to update everythign and get it running to see what you've done with it? :-/ |
| 14:26:18 | <dkayiwa> you will need to run it |
| 14:26:22 | <wyclif> cta, cool |
| 14:26:51 | <bwolfe> dkayiwa, boo |
| 14:26:58 | <bwolfe> dkayiwa, how abouts a nice screenshot? ;-) |
| 14:27:28 | <dkayiwa> bwolfe: are you trying to be lazy :D |
| 14:27:31 | <bwolfe> ok dkayiwa, pick out a diff ticket since darius is rejecting your 83 :-) |
| 14:27:34 | <bwolfe> dkayiwa, yes |
| 14:27:35 | <bwolfe> yes I am |
| 14:27:47 | <dkayiwa> :) |
| 14:27:53 | <dkayiwa> sure let me do so |
| 14:28:14 | <bwolfe> rcrichton-- |
| 14:28:29 | <bwolfe> dkayiwa, thanks! |
| 14:28:33 | <rcrichton> :( oops |
| 14:28:39 | <bwolfe> ok, wyclif? |
| 14:28:44 | <dkayiwa> bwolfe: am cancelling the ticket |
| 14:28:58 | <wyclif> yesterday: |
| 14:28:58 | <wyclif> * revisited OCC-70 and OCC-73 to respond review comments |
| 14:28:58 | <wyclif> * OCC-88 |
| 14:28:58 | <wyclif> * had a one on one with ankur |
| 14:28:58 | <wyclif> * did some code review for the GSoC project branch |
| 14:28:58 | <wyclif> * Had some discussions with darius on IRC about OCC |
| 14:29:00 | <wyclif> today: |
| 14:29:02 | <wyclif> * do some smaller sprint tickets that can finished today |
| 14:29:04 | <wyclif> * Need to complete reviewing the GSoC project branch |
| 14:29:12 | <bwolfe> dkayiwa, you could do that while deleting the controller, since it isn't linked and shouldn't be used |
| 14:29:23 | <dkayiwa> ok |
| 14:30:03 | <bwolfe> wyclif, dkayiwa, rafa, I want to finish as many tickets as possible, but also know that we're having a 1 week sprint on the occ in 2 weeks time. |
| 14:30:06 | <bwolfe> !sprints |
| 14:30:06 | <OpenMRSBot> bwolfe: Error: "sprints" is not a valid command. |
| 14:30:08 | <bwolfe> !sprint |
| 14:30:09 | <OpenMRSBot> bwolfe: Error: "sprint" is not a valid command. |
| 14:30:25 | <bwolfe> !learn sprintschedule as https://wiki.openmrs.org/display/RES/Sprint+Schedule |
| 14:30:25 | <OpenMRSBot> bwolfe: The operation succeeded. |
| 14:30:26 | <dkayiwa> bwolfe: and also delete its corresponding jsp? |
| 14:30:49 | <bwolfe> dkayiwa, yeah, might as well |
| 14:30:53 | <dkayiwa> ok |
| 14:30:55 | <bwolfe> the jsp is nothing without the controller |
| 14:31:01 | <dkayiwa> sure |
| 14:31:02 | <djazayeri> Actually, spending some time cleaning up code and/or creating unit tests would be worthwhile |
| 14:31:15 | <bwolfe> (unless its used for displaying sources) |
| 14:31:21 | <wyclif> question, if a concept is downloaded and re uploaded without edits, do we recreate it on the server in the first place? |
| 14:31:41 | <bwolfe> djazayeri, general cleanup, no. specific cleanup as defined in tickets, yes |
| 14:31:47 | <bwolfe> wyclif, yes |
| 14:32:36 | <djazayeri> Here's my report |
| 14:32:38 | <djazayeri> Thursday |
| 14:32:38 | <djazayeri> * Discussed solution for OCC-82, OCC-86 |
| 14:32:38 | <djazayeri> * Spent a long time trying to figure out how the client downloads concepts from the server. This code is a mess. Created OCC-89. |
| 14:32:38 | <djazayeri> * Blocked trying to import a concept due to NonUniqueObjectException on ConceptNameTag#4. (The code is very confusing.) |
| 14:32:39 | <djazayeri> Today: |
| 14:32:39 | <djazayeri> * OCC-82 (client shouldn't need a concept source, but should upload via its implementationId) |
| 14:32:40 | <djazayeri> * Finally finish OCC-56 |
| 14:32:40 | <djazayeri> * Other code reviews |
| 14:32:41 | <djazayeri> I'm blocked on the fact that the import concept code on the module side doesn't have any unit tests, and it's not done in a service, so it's not obvious how to write one. |
| 14:33:10 | <djazayeri> (without just copying all the code from the controllers) |
| 14:33:48 | <bwolfe> anyone else having issues importing? |
| 14:33:56 | <bwolfe> if not, then its probably a 1.6 issue :-/ |
| 14:34:06 | <djazayeri> likely |
| 14:34:15 | <bwolfe> yes, agreed that we should clean up the code and servicify it |
| 14:34:28 | <djazayeri> Actually it's probably because nobody has tried to import a concept that has any concept name tags |
| 14:34:28 | <rafa> works for me on 1.8 |
| 14:34:38 | <djazayeri> because those are never used in practice post-1.6 |
| 14:34:45 | <dkayiwa> does not work on 1.6 |
| 14:35:01 | <bwolfe> they're deleted really |
| 14:35:32 | <bwolfe> djazayeri, might be a general issue with the tags that carries through. but could be that its looking up the tags and not able to save them ( I remember some intersting code in the server to do search/replace of tags so as to not duplicate them) |
| 14:36:03 | <djazayeri> I remember seeing this same exception about tags sometime in the past |
| 14:36:06 | <djazayeri> (not in occ) |
| 14:37:04 | <djazayeri> It's just that having to test it through the UI is very annoying. Maybe I can write a unit test that calls the controller |
| 14:37:32 | <bwolfe> also a possibility |
| 14:38:41 | *** suho has joined #openmrs |
| 14:38:41 | *** ChanServ sets mode: +v suho |
| 14:39:07 | <suho> hi downeym |
| 14:39:26 | <bwolfe> ok, rcrichton, you have an update? |
| 14:39:35 | <bwolfe> and is wayne in here hiding behind some name? |
| 14:39:53 | <rcrichton> Yeah I do, seems Wayne isn't on the IRC |
| 14:40:01 | <rcrichton> * Read code review comments from CR-MOD-264 for OCC-74 |
| 14:40:05 | <rcrichton> * Just committed small change from the comment now |
| 14:40:10 | <rcrichton> * Worked on OCC-86 |
| 14:40:14 | <rcrichton> * Just commited change now |
| 14:40:21 | <rcrichton> * In porcess of creating code review |
| 14:40:25 | <rcrichton> * Also, just broke the build. Will run the tests and re-commit... my bad |
| 14:40:29 | <rcrichton> no blockers |
| 14:40:57 | <bwolfe> !ticket OCC-86 |
| 14:40:58 | <OpenMRSBot> bwolfe: [#OCC-86] Cannot upload first concept to OCC - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-86 |
| 14:41:08 | <suho> downeym, i have some issues with submitting the mentor feedback, its giving and error saying "Please enter your primary OR backup mentor's full name."! |
| 14:41:40 | <suho> downeym, but i did enter his full name |
| 14:42:47 | <bwolfe> ok. |
| 14:42:49 | <bwolfe> my update: |
| 14:43:01 | <bwolfe> today: |
| 14:43:01 | <bwolfe> (4 hours of vacation for social worker's visit) |
| 14:43:01 | <bwolfe> emails |
| 14:43:01 | <bwolfe> reviewed Wayne's patch |
| 14:43:01 | <bwolfe> fought with **&$ing rg timecard |
| 14:43:02 | <bwolfe> reviewed smart tickets |
| 14:43:06 | <bwolfe> monday: |
| 14:43:08 | <bwolfe> get smart |
| 14:43:41 | <bwolfe> its raining pretty hard here now |
| 14:43:50 | <bwolfe> pretty sure we'll lose power and/or internet soon :-/ |
| 14:43:55 | <bwolfe> any last minute questions for me? :-) |
| 14:44:47 | <dkayiwa> how is Meghan? :) |
| 14:45:35 | <wyclif> monday: am considering taking a sick day because i will losing a wisdom tooth so i want to rest after that |
| 14:45:50 | <dkayiwa> oh sorry!!! |
| 14:46:01 | <wyclif> it's a wisdom tooth |
| 14:46:13 | <dkayiwa> so you will get less wise? :) |
| 14:46:27 | <wyclif> am on a mission to get rid of all wisdom teeth |
| 14:46:33 | <dkayiwa> lollllllllll |
| 14:47:25 | <wyclif> i will be sending an email to notify the rest of the team |
| 14:48:12 | <wyclif> bwolfe, so if there are edits, i link the concepts otherwise no |
| 14:48:36 | <djazayeri> wyclif: huh? |
| 14:48:46 | <wyclif> if that is true, i believe these concepts should always be the linked |
| 14:48:50 | <djazayeri> If the concepts are identical, you should group them. (that's what it's called, right?) |
| 14:48:51 | <bwolfe> wyclif, otherwise you link them as similar |
| 14:48:56 | <bwolfe> group==link |
| 14:49:06 | <djazayeri> if they're not identical, just link them as similar, but not exact. |
| 14:49:18 | <wyclif> i link them as exact if there are no edits, right?' |
| 14:50:09 | <wyclif> am working on https://tickets.openmrs.org/browse/OCC-71 |
| 14:51:02 | <djazayeri> I would argue that you link them as exact _if they are exactly the same_ |
| 14:51:17 | <djazayeri> do you actually know if there are edits? |
| 14:51:34 | *** asgoyal has joined #openmrs |
| 14:53:38 | *** jwishnie has joined #openmrs |
| 14:55:01 | *** wyclif has quit IRC |
| 14:55:30 | <bwolfe> wyclif, yes, no edits == exact. theoretically you could have the module tell the server that dateChanged is null, therefore there are no edits (as a cheap/easy way to determine it quickly) |
| 15:00:04 | *** bwolfe has quit IRC |
| 15:01:05 | *** bwolfe has joined #openmrs |
| 15:01:05 | *** ChanServ sets mode: +o bwolfe |
| 15:02:03 | *** finbrein has quit IRC |
| 15:02:39 | <djazayeri> downeym: why do we require passwords > 8 for our openmrs ids? |
| 15:03:21 | <djazayeri> That's longer than my banks and credit cards require |
| 15:05:33 | <downeym> remind me not to use your bank. |
| 15:06:34 | *** wyclif has joined #openmrs |
| 15:08:14 | *** cta has quit IRC |
| 15:08:53 | <downeym> https://www.owasp.org/index.php/Password_length_&_complexity |
| 15:09:03 | <OpenMRSBot> <http://ln-s.net/93zj> (at www.owasp.org) |
| 15:10:08 | <bwolfe> http://xkcd.com/936/ |
| 15:11:20 | <dkayiwa> bwolfe: is there a link for downloading the MVP concept dictionary? Or do i have to email Andy for it? |
| 15:12:00 | <bwolfe> dkayiwa, theres a dropbox that he shares with you |
| 15:12:07 | <bwolfe> I don't think its public |
| 15:12:31 | <dkayiwa> ok |
| 15:12:55 | <djazayeri> downeym: is it >8 or >=8? |
| 15:13:06 | <djazayeri> anyway, I do not think that our OpenMRS ID passwords need to be that long |
| 15:14:33 | <djazayeri> or that strong... |
| 15:14:57 | <djazayeri> What's the real fear here, in exchange for me not being able to use my standard weak password? |
| 15:17:16 | <downeym> 8 characters is industry best practice, see link above |
| 15:20:13 | *** finbrein has joined #openmrs |
| 15:21:05 | *** dkayiwa has quit IRC |
| 15:21:44 | *** rcrichton has quit IRC |
| 15:22:41 | *** bwolfe has quit IRC |
| 15:27:43 | *** yanokwa_ has joined #openmrs |
| 15:27:46 | *** yanokwa has quit IRC |
| 15:28:18 | <djazayeri> what "industry" |
| 15:31:32 | <downeym> OWASP is generally considered by the infosec industry as the standards/guidance body for people making webapps |
| 15:32:14 | *** jportela has quit IRC |
| 15:33:40 | *** finbrein has quit IRC |
| 15:33:54 | *** finbrein has joined #openmrs |
| 15:36:28 | *** jportela has joined #openmrs |
| 15:36:28 | *** ChanServ sets mode: +v jportela |
| 15:39:48 | <djazayeri> downeym: I read the link. I don't really care that much. Just saying that in my mental model, our OpenMRS pages don't fall into the category of "things that _really_ need to be secure" |
| 15:40:59 | <downeym> djazayeri: understand your view point when thinking about wiki pages, etc. but keep in mind OID is used as central authentication for all our IT systems including email servers, etc |
| 15:42:12 | *** jportela has quit IRC |
| 15:48:38 | *** wyclif has quit IRC |
| 15:56:57 | *** downeym_ has joined #openmrs |
| 15:56:57 | *** ChanServ sets mode: +o downeym_ |
| 15:59:28 | *** downeym has quit IRC |
| 15:59:29 | *** downeym_ is now known as downeym |
| 16:03:57 | *** wyclif has joined #openmrs |
| 16:04:52 | *** goutham has joined #openmrs |
| 16:08:25 | <rafa> djazayeri, wyclif I updated tables on the occ server with my last commit, so you'll need to rerun occ...sql. I changed OccUpload too so you'll most likely need to update the module as well. |
| 16:08:42 | <wyclif> ok |
| 16:08:48 | <djazayeri> rafa: just re-run it? |
| 16:08:53 | <djazayeri> no need to drop tables? |
| 16:09:11 | <rafa> djazayeri: I think it drops tables by default |
| 16:09:44 | <rafa> djazayeri: confirmed it drops tables anyway |
| 16:09:49 | <djazayeri> okay |
| 16:10:24 | *** magoo has quit IRC |
| 16:10:26 | <jprice> morning djazayer; -do u have any more suggestions on what I can try / is it possible for you to run my msg through a debugger on your system ? |
| 16:10:53 | <djazayeri> jprice: no more suggestions, no more time |
| 16:11:16 | <djazayeri> maybe chopin can give you a de-identified HL7 message that you can compare to |
| 16:11:47 | <djazayeri> (chopin: he specifically is having trouble setting whatever field in the message has the form id.) |
| 16:11:55 | *** jwishnie has quit IRC |
| 16:12:53 | *** jwishnie has joined #openmrs |
| 16:14:45 | <jprice> ok. i will just keep playing around with it . r u sure what i am trying to do will work once i get the msg right ? |
| 16:15:13 | <djazayeri> the infopath formentry module creates encounters this way |
| 16:17:16 | *** gbastien has quit IRC |
| 16:19:57 | <jprice> chopin are you there ? or can anyone else out there point me to a valid HL7 msg that creates an encounter. i cannot get mine to work. thanks so much ! |
| 16:20:05 | *** yanokwa has joined #openmrs |
| 16:20:05 | *** ChanServ sets mode: +v yanokwa |
| 16:23:06 | *** yanokwa_ has quit IRC |
| 16:24:47 | *** downeym_ has joined #openmrs |
| 16:24:47 | *** downeym_ has joined #openmrs |
| 16:24:47 | *** ChanServ sets mode: +o downeym_ |
| 16:26:18 | *** downeym has quit IRC |
| 16:26:18 | *** downeym_ is now known as downeym |
| 16:26:35 | <jprice> djazayeri, maybe i can look at the code for the formentry module to see what it does. if you think t hat would be useful, where can i get the code ? |
| 16:26:57 | <djazayeri> jprice: actually form entry converts custom xml to hl7 via an xslt |
| 16:27:45 | <djazayeri> http://demo.openmrs.org/openmrs/admin/forms/formViewXslt.form?formId=1 |
| 16:27:52 | <OpenMRSBot> <http://ln-s.net/940v> (at demo.openmrs.org) |
| 16:57:12 | *** downeym_ has joined #openmrs |
| 16:57:12 | *** ChanServ sets mode: +o downeym_ |
| 16:59:53 | <djazayeri> wyclif: what did we decide to do about creator/dateCreated metadata |
| 17:00:20 | <djazayeri> e.g. I upload my first concept, so OCC goes to create a ConceptSource for me. |
| 17:00:58 | *** downeym has quit IRC |
| 17:00:59 | *** downeym_ is now known as downeym |
| 17:01:43 | *** czakian has quit IRC |
| 17:03:19 | *** downeym has quit IRC |
| 17:05:31 | *** downeym has joined #openmrs |
| 17:05:31 | *** ChanServ sets mode: +o downeym |
| 17:05:31 | *** OpenMRSBot sets mode: +o downeym |
| 17:09:42 | *** yanokwa_ has joined #openmrs |
| 17:09:42 | *** yanokwa has quit IRC |
| 17:10:25 | *** jwishnie has quit IRC |
| 17:13:36 | *** Suranga has joined #openmrs |
| 17:24:27 | <wyclif> hi djazayeri |
| 17:24:34 | <djazayeri> hi |
| 17:24:52 | <wyclif> sorry! i was off my desk |
| 17:25:33 | <wyclif> creator/dateCreated for all domain objects? |
| 17:25:40 | <djazayeri> for ConceptSource specifically |
| 17:25:55 | <djazayeri> when I try to upload my first concept, the server needs to create a ConceptSource for me. |
| 17:26:04 | <wyclif> we never reached a conclusion |
| 17:26:13 | <wyclif> yes |
| 17:26:15 | <djazayeri> was this a ticket discussion? |
| 17:26:38 | <wyclif> hmm.. |
| 17:26:48 | <wyclif> i doubt |
| 17:28:20 | <wyclif> i personally dont like the user table on the occ server |
| 17:29:05 | <wyclif> if i upload a concept to the server, data about who uploaded it should be persisted on the clients |
| 17:29:15 | <wyclif> and never on the server |
| 17:29:47 | <djazayeri> what do the creator fields usually point at? |
| 17:30:06 | <wyclif> so if an admin wants to know who s messing with their dictionary, they should get this info locally instead of making a trip to another server |
| 17:31:20 | <wyclif> when a concept or associated entity is persisted that has a user that has no row in the users table on the oc server, the save logic creates one for them |
| 17:31:20 | *** lh has joined #openmrs |
| 17:31:24 | <wyclif> and that is the creator |
| 17:31:24 | <djazayeri> I agree with you that storing client-users in the occ users table is pointless |
| 17:31:39 | <wyclif> occ should have no users |
| 17:31:59 | *** suho has quit IRC |
| 17:33:00 | <wyclif> having users on the occ server complicates a couple of areas that would otherwise have been simple to implement |
| 17:33:14 | <djazayeri> so, given that ben isn't around now, can we make an executive decision about this? :-) |
| 17:33:25 | <wyclif> and there are several areas in the code that have hacky code because of users |
| 17:35:39 | <djazayeri> so, I suppose the quick solution for me would be to make concept_source.creator be non-required. |
| 17:36:05 | <djazayeri> maybe I'll just do that |
| 17:36:12 | *** muthah has joined #openmrs |
| 17:36:15 | <djazayeri> Since this sprint is nearly over |
| 17:36:44 | <wyclif> i recall the last ticket he commented about today OCC-86, he was not yet convinced that the users table is useless |
| 17:37:25 | <wyclif> i agree with making concept_source.creator be non-required for now |
| 17:54:04 | *** bwolfe has joined #openmrs |
| 17:54:04 | *** ChanServ sets mode: +o bwolfe |
| 17:57:06 | <djazayeri> bwolfe: you there? |
| 17:57:12 | <bwolfe> yeah |
| 17:57:56 | <djazayeri> What's up with storing copies of client users in the occ server's users table? |
| 17:58:52 | <bwolfe> gives all concept editors access to occ |
| 17:58:53 | <djazayeri> e.g. when the server creates a ConceptSource based on the client's uploaded implementation id, it fails because it doesn't have a "creator". (I can fix this by just changing ConceptSource.hbm.xml to not require creator.) |
| 17:58:59 | <bwolfe> it used to be the only way to get a login :-p |
| 17:59:37 | <bwolfe> djazayeri, it didn't require creator 3 days ago. that was a sprint change by wyclif because of whatever he changed in concpetsource duplication (which apparently meant no concept sources) |
| 17:59:51 | <djazayeri> okay, so we can safely unrequire that... |
| 18:00:07 | <bwolfe> yeah |
| 18:00:38 | <djazayeri> but you're saying that if I upload a concept to OCC, then whoever created/edited that concept on my local server gets a login to the OCC? |
| 18:02:53 | <wyclif> i would favor that once a concept is reuploaded, we don't create a new one, but rather persist the changes, that way, editing gets done on the client and not server, so that we dont have to store users |
| 18:04:43 | <bwolfe> djazayeri, yes. right now that login doesn't do much. but I was envisioning it like a club that you get to join and so can edit/prune/vote/comment on concepts in the occ then |
| 18:05:10 | <djazayeri> I don't really see the point in having that be tied to your local user accounts |
| 18:05:30 | <djazayeri> I think it'd be much cleaner to manage that by having people request an account on OCC. |
| 18:05:40 | <bwolfe> djazayeri, you're suggesting it all be tied to a generic account? |
| 18:05:51 | <bwolfe> or just not have creators on the occ? |
| 18:06:02 | <djazayeri> I'm saying both |
| 18:06:12 | <bwolfe> huh? |
| 18:06:35 | <bwolfe> wyclif, when you copy/download someones concept and then reupload you get your own row in the occ |
| 18:06:42 | <bwolfe> if you edit your concept and upload again your row is edited |
| 18:06:51 | <bwolfe> you can never edit someone else's row |
| 18:06:52 | <djazayeri> 1. I think that if I upload a concept to OCC based on my implementationId, it is irrelevant what actual local OpenMRS User created and edited the concept. |
| 18:07:19 | <djazayeri> I.e. if Ellen uploads PIH concepts with the PIH implementationId, then the only relevant players here are PIH and maybe Ellen. |
| 18:07:32 | <djazayeri> It doesn't matter that she uploaded a concept that I created 2 years ago. |
| 18:08:35 | <djazayeri> 2. I think that if we want people to have user accounts on occ, they should go to the occ homepage and click on Request Account. We shouldn't automatically create accounts for any implementation-local user that's referenced in the creator/changedBy of any concept that gets uploaded. |
| 18:08:42 | *** robbyoconnor has quit IRC |
| 18:09:01 | *** robbyoconnor has joined #openmrs |
| 18:09:01 | *** ChanServ sets mode: +v robbyoconnor |
| 18:09:31 | <bwolfe> djazayeri, its possible that uploaded users are by default marked as "inactive" |
| 18:09:43 | <bwolfe> and so the user can't log in until an admin does something |
| 18:10:06 | <djazayeri> bwolfe: regardless, I think it's bad overall system design |
| 18:10:21 | <djazayeri> why would we want this "feature"? |
| 18:11:45 | <djazayeri> And what happens if I have created concepts on PIH, PIH-RWANDA, and DJLAPTOP, and I upload them. |
| 18:11:55 | <djazayeri> That leads to me having 3 inactive accounts on the OCC server. |
| 18:13:54 | <djazayeri> And the only "benefit" is that an admin can go activate one of those accounts, without me requesting one? |
| 18:16:35 | <bwolfe> it also gives us the audit trail |
| 18:16:55 | <bwolfe> if we drop all creator/changedBy columns we lose that. granted, I think its a very small commodity that we're losing... |
| 18:17:12 | <djazayeri> I don't think it's a relevant audit trail though. |
| 18:17:34 | <djazayeri> Because I never re-download my own concepts. And if someone else downloads my concept, my userIds are meaningless to them. |
| 18:18:40 | <bwolfe> if you download someone elses concepts the userIds aren't included. its only an audit trail at the server |
| 18:18:46 | <bwolfe> (at least I don't think they're included...) |
| 18:23:26 | <djazayeri> I don't really think it's the server's business... |
| 18:23:47 | <djazayeri> and that audit trail isn't being used, and won't be. |
| 18:23:48 | *** jportela has joined #openmrs |
| 18:23:48 | *** ChanServ sets mode: +v jportela |
| 18:24:05 | <bwolfe> it can be seen when browsing the concepts on the occ |
| 18:25:08 | <djazayeri> Okay, well, I don't think it should be. :-) |
| 18:25:49 | <bwolfe> if we remove it now, what are we gaining? |
| 18:26:06 | <bwolfe> aka, I missed why you're bringing this up now... |
| 18:26:20 | *** gbastien has joined #openmrs |
| 18:26:26 | *** goutham has quit IRC |
| 18:26:57 | <djazayeri> There's no immediate need, since I can just disable the not-null check in the hbm.xml for ConceptSource. |
| 18:32:48 | *** james_regen has quit IRC |
| 18:35:00 | <wyclif> bwolfe, we get rid of alot of hacky code |
| 18:35:42 | <wyclif> that tries to first save a user before saving the referencing object |
| 18:36:18 | <wyclif> bwolfe, have a look at the conceptManager.retrieveXXX methods |
| 18:37:02 | <bwolfe> am I looking at hacky code there? |
| 18:38:02 | <wyclif> and right now the association type will between user and source was inconsistent depending on if you are referring to an implementation source or a source defined in an implementation |
| 18:38:55 | <wyclif> bwolfe, e.g see conceptmanagerimpl.retrieveImplementationSouce |
| 18:40:39 | <wyclif> actually those multiple calls to save were the reason for duplicate sources and the reason for them was tryin to get around creators and retire |
| 18:40:46 | *** downeym has quit IRC |
| 18:41:08 | *** rafa has quit IRC |
| 18:41:29 | *** downeym has joined #openmrs |
| 18:41:29 | *** OpenMRSBot sets mode: +o downeym |
| 18:41:29 | *** ChanServ sets mode: +o downeym |
| 18:41:29 | *** downeym has quit IRC |
| 18:41:36 | *** yanokwa_ has quit IRC |
| 18:41:37 | *** downeym has joined #openmrs |
| 18:41:37 | *** ChanServ sets mode: +o downeym |
| 18:41:37 | *** OpenMRSBot sets mode: +o downeym |
| 18:41:44 | <wyclif> djazayeri, bwolfe so getting rid of users would help getting rid of that logic |
| 18:42:22 | <wyclif> djazayeri, you also need to drop the DB not null constraint on the table |
| 18:42:30 | <djazayeri> there aren't any actually |
| 18:42:35 | <wyclif> really? |
| 18:42:38 | <djazayeri> or maybe it's because the default value is 0 |
| 18:43:02 | <djazayeri> just changing that in hbm.xml caused it to run correctly |
| 18:45:26 | <wyclif> lok |
| 18:46:11 | *** bryq1 has joined #openmrs |
| 18:48:46 | *** bryq has quit IRC |
| 18:50:03 | <wyclif> apparently i should merge back my concept mappings stuff into trunk before the next occ sprint since concept mappings would have changed |
| 18:50:22 | <Suranga> downeym, hello |
| 18:50:29 | <downeym> Suranga: hi |
| 18:50:47 | <Suranga> downeym, in cause you're wondering who created an anyomous support ticket |
| 18:51:01 | <downeym> Suranga: do you know the ticket number by any chance? |
| 18:51:01 | <Suranga> downeym, im afraid that was me, I had forgotten to log in :( |
| 18:51:15 | <Suranga> downeym, let me check... |
| 18:51:31 | <Suranga> downeym, but dont worry, its not a big issue... |
| 18:52:25 | *** bryq1 has left #openmrs |
| 18:52:45 | <downeym> Suranga: ok. let me know if i can help :) |
| 18:53:29 | <Suranga> downeym, thanks, no problem... ill buzz u if i can find the ticket id... |
| 18:57:22 | *** Suranga has quit IRC |
| 18:58:44 | *** chopin has quit IRC |
| 19:02:42 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): More patches for obsValidator - CustomDatatypeHandler issues <http://feedproxy.google.com/~r/OMRStrunk/~3/k2fS5qYT9b4/OpenMRS> |
| 19:05:50 | <djazayeri> bwolfe: I'm hitting an error when trying to import a concept in a unit test for the module |
| 19:06:11 | <djazayeri> not-null property references a null or transient value: org.openmrs.ConceptMap.source |
| 19:06:25 | <djazayeri> looking at the XML I got from the OCC server, I see: |
| 19:06:39 | <djazayeri> <conceptMap id="22" uuid="134723ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB"> |
| 19:06:39 | <djazayeri> <concept reference="1"/> |
| 19:06:39 | <djazayeri> <source id="23"/> |
| 19:06:39 | <djazayeri> <sourceCode>1051</sourceCode> |
| 19:06:39 | <djazayeri> <comment>From Excel</comment> |
| 19:06:39 | <djazayeri> <creator reference="7"/> |
| 19:06:39 | <djazayeri> <dateCreated class="sql-timestamp" id="24">2010-10-24 13:09:59 PDT</dateCreated> |
| 19:06:40 | <djazayeri> </conceptMap> |
| 19:07:19 | <djazayeri> Have I messed something up on the server-side? |
| 19:07:33 | <djazayeri> i.e. the server shouldn't be saving a concept mapping with no source. |
| 19:07:37 | <djazayeri> wyclif: you might know the answer |
| 19:08:03 | <bwolfe> looks like xstream put in a link to another source somewhere else in the xml |
| 19:08:10 | <bwolfe> <source id="23"/> |
| 19:08:24 | <djazayeri> no, that means it's an empty property, with id=23 |
| 19:08:38 | <djazayeri> it would say reference="23" in the other cse |
| 19:08:58 | <wyclif> djazayeri, hmm... |
| 19:09:09 | <bwolfe> ah, right |
| 19:09:40 | <bwolfe> a map with no source is not good. |
| 19:09:47 | <wyclif> are adding the test data or using existing test data? |
| 19:09:57 | <djazayeri> standard test dataset |
| 19:10:06 | <djazayeri> but I think the error is server-side |
| 19:10:45 | <wyclif> i mean are you using the test-putConcepts.xml files |
| 19:11:08 | <wyclif> i added some test upload files ,are using those or your own? |
| 19:11:12 | <djazayeri> no, i'm using my own xml that I am producing from the server now |
| 19:12:01 | <wyclif> then you need tweak it and make sure it is matches what you have in the occ testdataset |
| 19:12:40 | <djazayeri> I'm trying to import *actual* occ server output into an in-memory-db in a module unit test |
| 19:12:50 | <djazayeri> the point is not to tweak anything |
| 19:13:04 | <djazayeri> anyway, the point here is that the output from the server has source==null |
| 19:13:13 | <djazayeri> even though in the DB I see a source=2 |
| 19:13:30 | <wyclif> oh |
| 19:13:57 | <djazayeri> Incidentally, on the server-side, in AcceptOccResultController it does s.getXstream().registerConverter(new ConceptSourceConverter()); |
| 19:14:24 | <djazayeri> which skips the attributes and just returns hl7Code |
| 19:14:28 | <djazayeri> although I don't know why that's missing. |
| 19:14:57 | <wyclif> may be the deserialise is set to omit source field on conceptmap |
| 19:15:12 | <wyclif> look at the XstreamSerializer |
| 19:16:20 | <djazayeri> ah, actually the sources on the server don't have hl7Code. |
| 19:16:37 | <djazayeri> the transitively-mapped sources I mean |
| 19:16:46 | <wyclif> ok |
| 19:17:01 | <djazayeri> actually there are duplicate sources now |
| 19:17:02 | <djazayeri> sigh |
| 19:17:15 | <djazayeri> so, there are duplicate sources for the two concepts I uploaded. |
| 19:17:17 | <djazayeri> I don't know why |
| 19:17:22 | <wyclif> duplicate sources on the occ server? |
| 19:17:35 | <djazayeri> But the AMPATH, SNOMED CT, etc, all have hl7Code = null |
| 19:17:36 | <wyclif> after importing |
| 19:17:42 | <djazayeri> wyclif: I have uncommitted code |
| 19:17:48 | <djazayeri> presumably that's causing it. |
| 19:19:01 | <wyclif> but that soourceHl7Code attribute is only used to save a copy of the original occ concept data on the client |
| 19:19:07 | <djazayeri> wyclif: in your occ server db right now, do you have concepts? |
| 19:19:25 | <wyclif> it is not used to set the source property of the mapping |
| 19:19:35 | <wyclif> yes |
| 19:19:55 | <djazayeri> can you do a select * from concept_source and see if there are any with hl7_code = null? |
| 19:21:34 | <wyclif> djazayeri, i think that converter might cause some problems |
| 19:21:55 | <wyclif> it should onoy be used for the attribute and not the tag |
| 19:22:45 | <downeym> hey, was there a date set for 1.8.3 release? |
| 19:23:09 | <wyclif> djazayeri, that would certainly return am empty result set because i manually inserted 1 concept_source with an hl7 code |
| 19:23:32 | <djazayeri> wyclif: You've uploaded concepts to your occ server, right? |
| 19:23:37 | <jprice> djazaryeri-it looks like i am doing what the form entry is doing (but i do not know xslt that well so perhaps not). there is a comment at top that says it gets the encounterId from PV segment. i hate to give up on this after working on it so much. should/could i submit a ticket on it so it can get looked at when someone has time ? |
| 19:23:46 | <wyclif> djazayeri, there are no database changes in minor releases |
| 19:24:00 | <wyclif> djazayeri, that was meant to downeym |
| 19:24:10 | <wyclif> downeym, , there are no database changes in minor releases |
| 19:24:28 | <djazayeri> wyclif: did you upload any concepts to your occ server that had mappings? |
| 19:24:29 | <wyclif> so there none that was created for 1.8.3 |
| 19:24:38 | <wyclif> downeym, the one for 1.8.0 should work |
| 19:24:52 | <downeym> wyclif: what i meant was, has a date been decided on which 1.8.3 will be released? |
| 19:24:56 | <wyclif> djazayeri, no an di believe they would fail |
| 19:25:21 | <wyclif> reason being that convertor would set the value as hl7Code |
| 19:25:33 | <wyclif> i recommended using sourceId |
| 19:25:41 | <djazayeri> wyclif: so the only concept sources in your occ server db are the ones auto-created to represent "you"? |
| 19:25:46 | <djazayeri> and they do have an hl7Code? |
| 19:26:03 | *** chopin has joined #openmrs |
| 19:26:13 | <wyclif> i have one row i inserted to represent my implemenatation id |
| 19:26:29 | <wyclif> yes djazayeri |
| 19:26:36 | <djazayeri> okay |
| 19:27:00 | <wyclif> djazayeri, are you uplaoding or importing? |
| 19:27:30 | <wyclif> i beleieve importing a concept with mappings might fail |
| 19:27:30 | <djazayeri> jprice: we may try to fix the issue about allowing you to specify an encounterId in PV1 next week. |
| 19:27:59 | <djazayeri> jprice: I don't have time to investigate further now. |
| 19:28:23 | <wyclif> djazayeri, so if you fail, i guess create a ticket for that |
| 19:28:37 | <djazayeri> bwolfe: have you uploaded any concepts to OCC that have mappings? |
| 19:28:47 | <bwolfe> no |
| 19:28:52 | <wyclif> but am 95% sure it would fail because of that converter |
| 19:31:23 | <jprice> ok thanks. how do i know if/when it is fixed ? |
| 19:32:13 | <wyclif> djazayeri, the solution would be for the converter to have a way to do the conversion for specific class types |
| 19:32:36 | <djazayeri> wyclif: alternately I shouldn't have sources in my OCC db that have no hl7code |
| 19:32:49 | <wyclif> i understand that |
| 19:33:02 | <wyclif> and you should fix that |
| 19:33:31 | <djazayeri> jprice: create an OpenMRS ID and watch this ticket: https://tickets.openmrs.org/browse/TRUNK-2557 |
| 19:33:33 | <wyclif> djazayeri, but again i higly believe those mappings won't get created after you fix your blank hl7_codes |
| 19:33:59 | <djazayeri> wyclif: I mean that the occ server app shouldn't have created sources with blank hl7 codes. |
| 19:34:06 | <djazayeri> I myself didn't do anything wrong. :-) |
| 19:34:36 | <djazayeri> Also, as the code stands now, every upload seems to create a duplicate concept source for me. |
| 19:35:01 | <wyclif> not having duplicate sources was fixed |
| 19:35:33 | <djazayeri> wyclif: it's broken again, either by rafal's recent commit, or my uncommitted code. Anyway, I can debug this from here. |
| 19:36:16 | <wyclif> djazayeri, the reason 2 are getting created i because someone is calling save instead of retrieve |
| 19:36:27 | <wyclif> save will always create a new one |
| 19:36:55 | <wyclif> but retrieve will first check for an existing one using the natural keys |
| 19:37:17 | <wyclif> and natural keys for concept source are name and hl7 code |
| 19:37:23 | <wyclif> so if you have those not set |
| 19:37:35 | <wyclif> you will end up getting duplicates |
| 19:37:41 | *** pascal` has quit IRC |
| 19:38:10 | *** pascal` has joined #openmrs |
| 19:38:26 | <wyclif> because the DAO wont be able to fetch the existing one |
| 19:38:38 | <djazayeri> wyclif: the problem is in my uncommitted code |
| 19:38:40 | <djazayeri> I have found it |
| 19:38:57 | <wyclif> is it related to what i said above? |
| 19:39:02 | <djazayeri> sort of |
| 19:39:22 | <djazayeri> It's that I added an "implementationId" property to ConceptSource |
| 19:39:23 | *** jportela has quit IRC |
| 19:39:32 | <djazayeri> so it can either have an hl7Code or an implementationId |
| 19:39:50 | <djazayeri> and I check for that case in retrieveConceptSource, but I'm checking for it too low. |
| 19:39:59 | <wyclif> is that meant to act like a discrimator |
| 19:40:17 | <djazayeri> I figured it'd be useful as one. |
| 19:40:22 | <wyclif> sorry! discrimnator |
| 19:40:33 | *** chopin has quit IRC |
| 19:40:38 | <djazayeri> But I hadn't counted on the natural key business. |
| 19:41:16 | <wyclif> typically unique properties should all be added to the natural keys |
| 19:41:49 | <wyclif> so that an existing source can be fetched by a unique field |
| 19:42:13 | <wyclif> or else a new one gets created |
| 19:43:09 | <wyclif> djazayeri, if you have a minute, can you please look at the code in ConceptManagerImpl.retrieveImplementationSouce |
| 19:43:17 | <wyclif> djazayeri, and tell me if you like it |
| 19:44:58 | <wyclif> djazayeri, let me know when you succeed to import a concept with a mapping |
| 19:51:22 | <djazayeri> wyclif: going to grab lunch now, but at first glance I don't understand why you're saving the thing without creator, and then resaving it with it |
| 19:52:29 | *** chopin has joined #openmrs |
| 19:53:13 | <djazayeri> in a broader sense, I think that having these retrieve methods that happen to create things in the background is bad style. |
| 19:53:51 | <wyclif> ok |
| 19:54:45 | <djazayeri> but you're copying that |
| 19:55:20 | <wyclif> copying |
| 19:55:21 | *** chopin has quit IRC |
| 19:55:48 | <wyclif> that logic is one of the reason we need to get rid of creator and user |
| 20:06:43 | *** jportela has joined #openmrs |
| 20:06:43 | *** ChanServ sets mode: +v jportela |
| 20:22:20 | *** bwolfe has quit IRC |
| 20:26:29 | *** finbrein has quit IRC |
| 20:43:36 | *** wyclif has quit IRC |
| 20:54:38 | *** lh has quit IRC |
| 22:04:39 | *** downeym has quit IRC |
| 22:11:21 | *** gbastien has quit IRC |
| 22:12:14 | *** asgoyal has quit IRC |
| 22:17:08 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: From Kenya -> Silicon V, CA: 26 hrs l8r, in 4 hrs heading to Google #SciFoo camp, feel compelled to talk on global he ... <http://twitter.com/OpenMRS/statuses/102132263898185728> |
| 22:28:54 | *** gbastien has joined #openmrs |
| 22:40:20 | *** pascal` has quit IRC |
| 22:41:58 | *** pascal` has joined #openmrs |
| 23:49:21 | *** gbastien has quit IRC |