| 00:21:49 | <jprice> can I assume that if the messages are 'Queued Messages |
| 00:22:12 | <jprice> Q that the Process HL7 task has not seen them ? |
| 00:41:32 | <wyclif> djazayeri, am here |
| 00:43:57 | <djazayeri> wyclif: you've successfully uploaded concepts to your occ server? |
| 00:45:55 | <wyclif> yes |
| 00:46:03 | <wyclif> i actually added that line |
| 00:46:05 | <djazayeri> did you have to manually create a concept source? |
| 00:46:08 | <wyclif> that throws that exception |
| 00:46:19 | <djazayeri> ah, okay |
| 00:46:28 | <djazayeri> well, I disagree with it. :-) |
| 00:46:32 | <wyclif> it means you trying to upload concepts from unknown implementation which is not allowed |
| 00:46:41 | <djazayeri> right, but how do I upload my first concept? |
| 00:46:51 | <wyclif> we want to know who is uploading the concept |
| 00:46:52 | <djazayeri> I've authenticated via implementationId and passphrase... |
| 00:47:51 | <wyclif> djazayeri, if you read the wiki page of the occ, one of the requirements before using the OCC is to create an implementation id by registering |
| 00:47:58 | <djazayeri> I did that. |
| 00:48:18 | <djazayeri> When I try to upload my first concept, I successfully pass the checkImplementationId check. |
| 00:48:24 | <wyclif> then you hl7 code should the one you registered |
| 00:48:44 | <djazayeri> the problem is that there's no row in concept_source on the occ server. |
| 00:48:47 | <wyclif> sorry! then your hl7 code should be the one you registered |
| 00:49:06 | <wyclif> have you read my response to your email |
| 00:49:28 | <djazayeri> I haven't received it yet |
| 00:50:31 | <wyclif> it means insert a row into the occ concept source table with an hl7_code matching what you have registered as the implementation id |
| 00:51:33 | <djazayeri> I was able to get around the problem by manually inserting a row into the database via sql |
| 00:51:47 | <wyclif> i believe occ should have all registered implementation in that table |
| 00:51:47 | <djazayeri> But the workflow is not correct. |
| 00:52:06 | <djazayeri> Ah, so you think that will happen automatically in the real production OCC? |
| 00:52:08 | <wyclif> djazayeri, it is just because you are on a test server |
| 00:52:23 | <wyclif> djazayeri, that is my assumprion |
| 00:52:44 | <djazayeri> That doesn't seem right, because we're authenticating the implementation id against a remote server... |
| 00:52:45 | <djazayeri> right? |
| 00:53:01 | <jprice> djazayeri: looks like there is an SQL exception during processing that says encounter type cannot be null. how/where do i specify the encounter type in the hl7 msg (is that part of the hl7 format ?) |
| 00:53:12 | <wyclif> in production, the occ should be aware of all registered implementation ids |
| 00:53:33 | <djazayeri> wyclif: I suspect that's not true, but let's ask ben tomorrow |
| 00:53:49 | <djazayeri> jprice: I don't know. see if it's mentioned on our hl7 wiki page |
| 00:54:27 | <wyclif> djazayeri, do you recall my issue saving a new source and user at the same time |
| 00:54:38 | <djazayeri> vaguely, yes |
| 00:55:47 | <wyclif> this is one of the problems that cause it, if an unregistered implementation tries to upload a concept, then the user and concept source table associations fail on saving |
| 00:55:56 | <wyclif> because the source and user are both new |
| 00:55:59 | <wyclif> and they are related |
| 00:56:13 | <wyclif> so my point is that, first register and then upload |
| 00:57:25 | <wyclif> that way, the occ should auto import registerer implementation ids onto the occ server's concept source table |
| 00:57:29 | <djazayeri> Okay. I think the answer is that when we authenticate someone by checking their implementation id and passphrase (which is done via a post to a remote url), then we should also create a concept source if one doesn't exist yet. |
| 00:57:45 | <djazayeri> it doesn't have to happen just because you create an implementation id |
| 00:57:52 | <djazayeri> it can happen when you upload your first concept |
| 00:58:11 | <wyclif> djazayeri, am fine with that, as long as at the point of uploading, the occ knows about the implementation |
| 00:58:27 | <wyclif> djazayeri, and that is what the exception catches |
| 00:58:39 | <djazayeri> I'll create a ticket |
| 00:58:49 | <wyclif> sure |
| 01:00:21 | <wyclif> djazayeri, am still against storing the implementation sources and other sources in the same table on the occ |
| 01:00:39 | <djazayeri> wyclif: I agree with you on that, but it's not my decision. |
| 01:00:57 | <wyclif> because the association types for user-implementation are different user-other sources |
| 01:01:20 | *** rafa has joined #openmrs |
| 01:01:20 | *** ChanServ sets mode: +v rafa |
| 01:01:26 | *** jriley has left #openmrs |
| 01:02:02 | <wyclif> djazayeri, and this is the reason why an implementation source could not get created on the first upload by cascading |
| 01:13:05 | *** deadpool has joined #openmrs |
| 01:13:11 | <jprice> how do i create an encounter manually from the UI ? maybe thats the issue...there are none present for my patient...there does not seem to be a place in the HL7 message for encounter type. maybe it is one of the jason object parameters like "source" and "data" |
| 01:17:36 | <deadpool> jprice: the only way i know how to create an encounter manually is by the html forms |
| 01:20:19 | <jprice> thanks. do you know how to specify one while posting an hl7 msg ? |
| 01:21:51 | <deadpool> jprice: not too sure about that don't know too much about hl7 |
| 01:26:50 | <jprice> so when I go to Encounter Management and try to Add one the 'save encounter' button stays greyed out. any ideas ? |
| 01:28:22 | <deadpool> so yeah install html form entry |
| 01:28:25 | <deadpool> it is a module |
| 01:28:50 | <deadpool> or you need to do microsoft infopath |
| 01:29:23 | <jprice> i am running the standalone version. the HTML form Entry module appears to be running. |
| 01:29:51 | <deadpool> have you created a form using htmlform entry? |
| 01:29:58 | <deadpool> if you haven't you should do that first |
| 01:30:00 | <jprice> yes |
| 01:30:31 | <deadpool> in encounter management do you not see the form you created? |
| 01:31:17 | <jprice> yes i do. there are also others pre-defined like "ADULTINIT" but the button is inactive for those also |
| 01:32:25 | <deadpool> so if you click on the form you created the save encounter is greyed out |
| 01:33:29 | *** rafa has quit IRC |
| 01:34:14 | <jprice> yes |
| 01:36:25 | <jprice> deadpool : thanks for the help. i have to go no and will get back to this tomorrow. if you think of anything email me at jmprice@gmwhi.org |
| 01:38:41 | <deadpool> jprice will do |
| 01:38:48 | <deadpool> sorry i couldn't help you today |
| 01:48:15 | *** jportela has quit IRC |
| 01:49:53 | <deadpool> djazayeri: do you know where the tomcat users.xml is located in ubuntu |
| 02:00:09 | <deadpool> nv got it |
| 02:01:18 | <deadpool> i do have a quick question i am trying to deploy openmrs on tomcat before i was doing it on jetty so that was easy but when i deploy it and try to run the installation wizard it is asking for openmrs-runtime properties at a certain location shouldn't the isntallation wizard create one for me? |
| 02:02:22 | *** robbyoconnor has joined #openmrs |
| 02:02:22 | *** ChanServ sets mode: +v robbyoconnor |
| 02:11:04 | *** deadpool has quit IRC |
| 02:21:50 | *** deadpool has joined #openmrs |
| 02:21:59 | <deadpool> djazayeri: any ideas? |
| 02:23:16 | *** deadpool has quit IRC |
| 02:48:58 | *** upul` has joined #openmrs |
| 02:48:58 | *** ChanServ sets mode: +v upul` |
| 03:40:12 | *** surangak has joined #openmrs |
| 03:51:50 | *** mccallumg has joined #openmrs |
| 03:51:50 | *** ChanServ sets mode: +v mccallumg |
| 03:53:58 | <mccallumg> hi surangak |
| 03:54:30 | *** surangak_ has joined #openmrs |
| 03:55:05 | <surangak_> mccallumg, helooo |
| 03:55:30 | <mccallumg> do you have a few minutes? |
| 03:56:06 | <surangak_> mccallumg, sure whats up ? |
| 03:56:39 | <mccallumg> do you want to practice again? |
| 03:56:57 | <mccallumg> you don't have to |
| 03:57:04 | <mccallumg> if you're confident ... |
| 03:57:10 | <mccallumg> you did really well last night |
| 03:57:15 | <surangak_> mccallumg :) |
| 03:57:30 | <surangak_> mccallumg, do u feel that im ok to go ? |
| 03:57:57 | <mccallumg> if you present like you did last night. yes. definitely. |
| 03:58:07 | <surangak_> mccallumg, :) |
| 03:58:18 | <surangak_> sorry i got rather late today.. |
| 03:58:18 | <mccallumg> but don't get nervous and talk too fast |
| 03:58:33 | <surangak_> ya, thats my biggest fear |
| 03:58:46 | <surangak_> did u see the mail i had send yesterday ? |
| 03:59:22 | <mccallumg> just let me check |
| 04:00:37 | <mccallumg> surangak_: so it appears to me that the tool tip is useful for some handlers but not for others, right? |
| 04:00:47 | <surangak_> mccallumg, thats what i was think too |
| 04:01:04 | <mccallumg> mccallumg: for example, useful for domain objects. But not necessarily for images. |
| 04:01:18 | <surangak_> in case of image handlers, the user doesnt need to be told that he has to 'select and upload an image' |
| 04:01:30 | <surangak_> mccallumg, I agree, totally |
| 04:02:32 | <mccallumg> surangak_: is it a technical challenge to have it as an option on all handlers? |
| 04:02:48 | <surangak_> nopz.. not really |
| 04:03:03 | <surangak_> the only question is wether its worth it |
| 04:03:32 | <surangak_> i guess later on, if someone does extend a totally new version of image handlers, then a tooltip would come handy there too.. |
| 04:03:45 | <mccallumg> surangak_: even if it isn't as necessary as it is to specify the format of autocomplete on a domain object. |
| 04:04:20 | <mccallumg> mccallumg: the creator of an image handler might want to put something in there like " select a png or jpeg file only" |
| 04:04:40 | <surangak_> mccallumg, ah, I had not thought about the file types... |
| 04:05:00 | <mccallumg> surangak_: if it isn't anymore work then I'd let it be a option on all handlers |
| 04:05:20 | <surangak_> mccallumg, i think for images, certain image types r not supported.. so in that case a helpful message will be great |
| 04:05:27 | <surangak_> mccallumg, Ill add this today, no problem |
| 04:05:54 | <mccallumg> surangak_: and if the handler creator chooses not to use it ... then it is just the same as the way things are now. |
| 04:06:19 | <mccallumg> surangak_: be careful adding features right before your presentation |
| 04:06:51 | <mccallumg> surangak_: keep a version from this minute handy - before you make last minute simple changes. |
| 04:07:10 | <surangak_> mccallumg, yes.. I know the feeling... Ill take a clean checkout and keep it as backup |
| 04:07:40 | <surangak_> mccallumg, and i should upload the slides to the wiki, and probably slideshare , d ' you think ? |
| 04:08:24 | <mccallumg> surangak_: just as long as there is a link publicly available where people can download them |
| 04:08:36 | <mccallumg> surangak_: and make sure the slides are numbered |
| 04:09:03 | <surangak_> mccallumg, sure will do |
| 04:09:40 | <mccallumg> surangak_: ... and if you like to have extra insurance you can do demo screenshots and append them to the end of your presentation in case the network has problems. Then you can talk through the demo using the slides. |
| 04:10:05 | <mccallumg> surangak_: but that is your choice. we know the connection will be good |
| 04:10:09 | <surangak_> mccallumg, u mean I should add them to the slides itself ? |
| 04:10:34 | <mccallumg> surangak_: you can. images pasted over the entire slide |
| 04:10:55 | *** poorroop has joined #openmrs |
| 04:11:02 | <surangak_> mccallumg, actually, thats a good idea... i dont trust the network much :) |
| 04:11:17 | <mccallumg> surangak_: up to you. if you have time it is a nice backup to have. |
| 04:11:49 | <surangak_> mccallumg, Ill do that ahead of the presentation, i should have enough time |
| 04:12:10 | <mccallumg> surangak_: ok. I'm going to head to bed then. talk to you in the morning |
| 04:12:23 | <surangak_> mccallumg, sure, will do |
| 04:12:36 | <mccallumg> surangak_: bye |
| 04:12:43 | <surangak_> mccallumg, good night... |
| 04:13:08 | *** mccallumg has quit IRC |
| 05:44:30 | *** jwishnie has quit IRC |
| 05:50:54 | *** dkayiwa has joined #openmrs |
| 05:50:56 | *** jwishnie has joined #openmrs |
| 06:19:08 | *** dkayiwa has quit IRC |
| 06:56:26 | *** poorroop has quit IRC |
| 07:02:10 | *** poorroop has joined #openmrs |
| 07:06:04 | *** surangak__ has joined #openmrs |
| 07:06:23 | *** surangak has quit IRC |
| 07:06:31 | *** surangak_ has quit IRC |
| 07:07:02 | *** rafa has joined #openmrs |
| 07:07:02 | *** ChanServ sets mode: +v rafa |
| 07:07:14 | *** surangak has joined #openmrs |
| 07:12:24 | *** dkayiwa has joined #openmrs |
| 07:21:04 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS Greg Warren commented on 22422 <http://feedproxy.google.com/~r/OMRStrunk/~3/lvMG69IrTqM/OpenMRS> || New Changeset: OpenMRS (trunk): java.lang.ClassCastException: org.openmrs.Person cannot be cast to org.openmrs.Patient - TRUNK-2033 <http://feedproxy.google.com/~r/OMRStrunk/~3/IzCOzrdWMoA/OpenMRS> |
| 07:28:15 | *** bryq has joined #openmrs |
| 07:28:15 | *** ChanServ sets mode: +v bryq |
| 07:35:58 | *** poorroop has quit IRC |
| 08:27:20 | *** magoo has joined #openmrs |
| 09:19:12 | *** magoo has quit IRC |
| 09:42:33 | *** dkayiwa has quit IRC |
| 09:44:16 | *** pascal` has joined #openmrs |
| 09:44:16 | *** ChanServ sets mode: +v pascal` |
| 09:47:44 | *** dkayiwa has joined #openmrs |
| 09:54:34 | *** Echidna has joined #openmrs |
| 09:54:34 | *** ChanServ sets mode: +v Echidna |
| 09:56:30 | *** dkayiwa has quit IRC |
| 09:57:22 | *** bwolfe has joined #openmrs |
| 09:57:22 | *** ChanServ sets mode: +o bwolfe |
| 10:14:45 | *** dkayiwa has joined #openmrs |
| 10:18:02 | <bryq> rafa: Hi |
| 10:18:11 | <rafa> hi |
| 10:18:18 | <bryq> rafa: I've attached yet another scrennshot to ticet META-120 |
| 10:18:24 | <bryq> rafa: Have a look at it |
| 10:18:31 | <rafa> ok |
| 10:19:10 | <rafa> bryq: I love it :) |
| 10:20:10 | <bryq> rafa: I've got an idea. Propably it will take some time when we agree about this page look and feel. So I think we could merge my branch and after we agree I'll commit to the trunk. What do you think? |
| 10:20:14 | <bryq> rafa: :) |
| 10:20:44 | <bryq> rafa: I liked every version of this page, but let's wait for Darius ;-) |
| 10:21:40 | <rafa> bryq: Ok, go ahead and do the merge |
| 10:21:53 | <rafa> bryq: please create a ticket for the merge operation first |
| 10:22:08 | <bryq> rafa: Okay |
| 10:22:39 | <rafa> bryq: and a code-review so we can easily see the changes |
| 10:22:53 | <bwolfe> dkayiwa, did you not commit the fix for this? https://tickets.openmrs.org/browse/OCC-84 |
| 10:24:46 | <dkayiwa> no |
| 10:25:41 | <rafa> bryq: actually did you clean up the code? |
| 10:26:04 | <rafa> bryq: I've seen some messages hard coded |
| 10:26:52 | <bwolfe> dkayiwa, oh, ok. well...darius did :-p |
| 10:26:54 | <bryq> rafa: As far as I remember hard-coded messages are only on configure page. Am I right? |
| 10:27:08 | <dkayiwa> bwolfe: did he commit? |
| 10:27:29 | <bryq> rafa: Shall I move configure messages into properties file too? |
| 10:27:42 | <bwolfe> dkayiwa, the ticket says he did |
| 10:27:47 | <dkayiwa> ok :) |
| 10:28:10 | <bryq> rafa: Ohh, on addInvalidSubscription.jsp are hardcoded messages too |
| 10:28:22 | <bryq> rafa: I'll look onto all pages and do the cleanup |
| 10:28:23 | <rafa> bryq: I'm remembering editing yesterday something in the creating package workflow as well |
| 10:28:45 | <rafa> bryq: yes, please move configure messages too |
| 10:28:54 | *** rcrichton has joined #openmrs |
| 10:28:54 | *** ChanServ sets mode: +v rcrichton |
| 10:29:21 | <bryq> rafa: Okay |
| 10:38:06 | <rafa> bryq: I'll release the 0.9.0.2 version now and bump trunk to 0.10 where you can merge then. :). |
| 10:39:32 | <bryq> rafa: Okay, I'm now cleaning the code, so dont hurry |
| 10:39:48 | *** jportela has joined #openmrs |
| 10:39:48 | *** ChanServ sets mode: +v jportela |
| 10:43:01 | *** jportela has left #openmrs |
| 10:43:48 | *** magoo has joined #openmrs |
| 11:07:05 | *** james_regen has joined #openmrs |
| 11:07:05 | *** ChanServ sets mode: +v james_regen |
| 11:27:21 | *** surangak_ has joined #openmrs |
| 11:28:03 | *** surangak has quit IRC |
| 11:28:08 | *** surangak__ has quit IRC |
| 11:28:14 | *** surangak has joined #openmrs |
| 11:31:10 | *** upul` has quit IRC |
| 11:31:25 | *** jportela has joined #openmrs |
| 11:31:25 | *** ChanServ sets mode: +v jportela |
| 11:45:28 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 0.9.0.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&0.9.0.2> |
| 11:59:21 | <bwolfe> dkayiwa, https://answers.openmrs.org/questions/50/how-do-you-create-repeating-tables-using-the-xforms-module |
| 11:59:30 | <OpenMRSBot> <http://ln-s.net/93jY> (at answers.openmrs.org) |
| 11:59:34 | <dkayiwa> aha |
| 12:25:14 | *** dkayiwa has quit IRC |
| 12:28:51 | *** bwolfe has quit IRC |
| 12:29:15 | *** dkayiwa has joined #openmrs |
| 12:34:43 | *** cta has joined #openmrs |
| 12:35:02 | <cta> hello |
| 12:45:19 | *** gbastien has joined #openmrs |
| 12:47:45 | *** wyclif has quit IRC |
| 12:53:29 | *** bwolfe has joined #openmrs |
| 12:53:29 | *** ChanServ sets mode: +o bwolfe |
| 12:54:22 | *** jriley has joined #openmrs |
| 12:57:44 | *** downeym has joined #openmrs |
| 12:57:44 | *** ChanServ sets mode: +o downeym |
| 12:57:44 | *** OpenMRSBot sets mode: +o downeym |
| 12:57:56 | *** jportela has left #openmrs |
| 13:04:03 | *** bwolfe_ has joined #openmrs |
| 13:04:03 | *** ChanServ sets mode: +o bwolfe_ |
| 13:05:18 | *** bwolfe has quit IRC |
| 13:06:29 | *** rcrichton has quit IRC |
| 13:13:04 | *** dkayiwa has quit IRC |
| 13:15:36 | *** magoo has quit IRC |
| 13:17:15 | *** dkayiwa has joined #openmrs |
| 13:22:41 | <rafa> bwolfe_: are you around? |
| 13:22:45 | <bwolfe_> no |
| 13:22:53 | <rafa> bwolfe_: :) |
| 13:23:22 | *** bwolfe_ is now known as bwolfe |
| 13:24:25 | <rafa> bwolfe: I've noticed that filtering of concepts is done with java instead of with the db in the occ server |
| 13:24:48 | <rafa> bwolfe: are we in a process of changing that? |
| 13:25:20 | *** nribeka has joined #openmrs |
| 13:25:20 | *** ChanServ sets mode: +v nribeka |
| 13:25:23 | <bwolfe> I don't think there is a ticket for it |
| 13:25:33 | <bwolfe> if I knew thats how it was done I would have made one. :-) |
| 13:25:48 | <bwolfe> I know tag filtering is java based, are the other params too?? |
| 13:26:08 | <bwolfe> nribeka?! what brings you yonder?? |
| 13:26:15 | <rafa> bwolfe: I look at the controller and it just calls getBaseObjects and does all the filtering in java |
| 13:26:44 | <rafa> bwolfe: however, there are proper filter methods in dao |
| 13:26:51 | *** rcrichton has joined #openmrs |
| 13:26:51 | *** ChanServ sets mode: +v rcrichton |
| 13:27:01 | <downeym> Hi rcrichton and welcome to the #openmrs IRC channel. |
| 13:27:28 | <rafa> bwolfe: I'm asking because I want to order concepts based on ranks and want to know if I need to do it just for getBaseObjects or all other filter methods in dao |
| 13:27:48 | <rafa> in case we eventually switch to them :) |
| 13:28:02 | * bwolfe doesn't remember what the other filter methods are |
| 13:29:23 | <rafa> there's findConcepts(String search, List<ConceptSource> sources, List<OccTag> tags, Boolean includeRetired, |
| 13:29:23 | <rafa> Boolean ignoreMapped, int page, int pageSize); |
| 13:30:10 | <nribeka> blue yonder bwolfe |
| 13:31:23 | <rafa> bwolfe: ohh I looked in a wrong place |
| 13:31:31 | <rafa> bwolfe: nevermind |
| 13:31:44 | <bwolfe> rafa, ? where were you looking? |
| 13:31:56 | <rafa> bwolfe: I looked at rest/OccResultsController |
| 13:32:47 | <rafa> bwolfe: but I guess I should be looking simply at ConceptController |
| 13:38:56 | *** gbastien has quit IRC |
| 13:40:08 | *** finbrein has joined #openmrs |
| 13:43:01 | *** wyclif has joined #openmrs |
| 13:48:03 | *** bwolfe has quit IRC |
| 13:53:24 | *** dkayiwa has quit IRC |
| 13:53:57 | *** r7friedman has joined #openmrs |
| 13:53:59 | *** dkayiwa has joined #openmrs |
| 13:54:06 | *** r7friedman is now known as r-friedman |
| 13:54:10 | <downeym> Hi r-friedman and welcome to the #openmrs IRC channel. |
| 13:54:15 | *** downeym has quit IRC |
| 13:54:23 | *** downeym has joined #openmrs |
| 13:54:23 | *** ChanServ sets mode: +o downeym |
| 13:54:23 | *** OpenMRSBot sets mode: +o downeym |
| 13:54:41 | *** danielf` has joined #openmrs |
| 13:54:45 | *** ChanServ sets mode: +v danielf` |
| 13:55:12 | *** finbrein has joined #openmrs |
| 13:56:02 | *** jportela has joined #openmrs |
| 13:56:02 | *** ChanServ sets mode: +v jportela |
| 14:00:18 | *** rafa has quit IRC |
| 14:00:30 | *** mccallumg has joined #openmrs |
| 14:00:30 | *** ChanServ sets mode: +v mccallumg |
| 14:01:36 | *** rafa has joined #openmrs |
| 14:01:36 | *** ChanServ sets mode: +v rafa |
| 14:06:30 | <r-friedman> downeym: where are past developer calls archived? how long after the meeting before they become available? |
| 14:07:59 | *** rcrichton has quit IRC |
| 14:18:14 | *** rcrichton has joined #openmrs |
| 14:18:14 | *** ChanServ sets mode: +v rcrichton |
| 14:22:03 | *** finbrein has quit IRC |
| 14:25:17 | <downeym> r-friedman: Hey there. In most cases we have recordings posted on each meeting's page and/or etherpad notes. |
| 14:25:48 | <r-friedman> tks, caught you in chat, figured you were too busy there to get here -- way to multitask |
| 14:26:31 | *** elliott_w has joined #openmrs |
| 14:26:31 | *** ChanServ sets mode: +o elliott_w |
| 14:34:51 | *** judy has joined #openmrs |
| 14:36:43 | *** judy has joined #openmrs |
| 14:44:12 | *** rooppoor has joined #openmrs |
| 14:44:26 | <downeym> Hi rooppoor and welcome to the #openmrs IRC channel. |
| 14:47:34 | <downeym> mccallumg: I'm way behind on email but i think your blog idea is a great one. :) |
| 14:47:43 | *** bwolfe has joined #openmrs |
| 14:47:43 | *** ChanServ sets mode: +o bwolfe |
| 14:47:55 | <downeym> r-friedman: I need about 7 more displays for this meeting :) |
| 14:48:48 | <mccallumg> downeym: thanks. I'll proceed to migrate information. Hopefully, backdated posts won't show up as new in the RSS feed. |
| 14:49:03 | <downeym> mccallumg: i don't think they will |
| 15:10:31 | *** dkayiwa has quit IRC |
| 15:11:45 | *** rcrichton has quit IRC |
| 15:12:02 | *** dkayiwa has joined #openmrs |
| 15:22:59 | *** umashanthi has joined #openmrs |
| 15:22:59 | *** ChanServ sets mode: +v umashanthi |
| 15:25:48 | *** dkayiwa has quit IRC |
| 15:28:31 | <mccallumg> just for the record. that is not my daughter in the background |
| 15:28:56 | <bwolfe> ha |
| 15:29:00 | * bwolfe also calls "not it" |
| 15:29:47 | <surangak_> l:) |
| 16:02:26 | *** judy has quit IRC |
| 16:03:04 | <djazayeri> bwolfe, wyclif, rafa, dkayiwa |
| 16:03:08 | <djazayeri> scrum time? |
| 16:03:17 | <djazayeri> danielf`: I forget if you're also working on the sprint |
| 16:03:24 | <djazayeri> or if that was ryan |
| 16:03:24 | *** jportela has left #openmrs |
| 16:03:24 | *** goutham has joined #openmrs |
| 16:03:34 | *** surangak has quit IRC |
| 16:03:46 | *** surangak_ has quit IRC |
| 16:04:51 | *** bwolfe has quit IRC |
| 16:05:15 | <djazayeri> anybody? |
| 16:05:28 | <wyclif> djazayeri, hi |
| 16:05:33 | <wyclif> i emailed my update |
| 16:05:38 | <djazayeri> I saw it |
| 16:05:58 | *** mccallumg has quit IRC |
| 16:05:58 | <djazayeri> I really wanted to discuss the tickets I'm blocked/confused on with Ben... |
| 16:08:51 | *** jriley has quit IRC |
| 16:09:12 | *** elliott_w has quit IRC |
| 16:10:38 | *** downeym has quit IRC |
| 16:12:19 | <wyclif> am off for lunch with the group |
| 16:12:24 | <djazayeri> okay |
| 16:18:17 | *** bwolfe has joined #openmrs |
| 16:18:17 | *** ChanServ sets mode: +o bwolfe |
| 16:18:31 | <djazayeri> bwolfe: I'd like to discuss a couple tickets |
| 16:18:33 | <djazayeri> (in 2 minutes) |
| 16:18:41 | *** umashanthi has left #openmrs |
| 16:19:53 | *** danielf` has quit IRC |
| 16:25:06 | *** pascal` has quit IRC |
| 16:26:29 | <djazayeri> you there? |
| 16:38:42 | *** jprice_ has joined #openmrs |
| 16:40:30 | *** rafa has quit IRC |
| 16:40:34 | *** jprice has quit IRC |
| 16:44:41 | <jprice_> does anyone know if 1) in an HL7 msg /PV1 segment, if what the spec calls 'Admission Type' is what is used by openMRS for 'encounter_type' |
| 16:45:09 | <jprice_> and also if there has to be an existing encounter ID or it will create the one with the ID in the PV1 segment if it does not exist ? |
| 16:48:28 | *** jwishnie has quit IRC |
| 16:51:56 | *** goutham has quit IRC |
| 16:59:44 | *** danielf` has joined #openmrs |
| 16:59:49 | *** ChanServ sets mode: +v danielf` |
| 17:07:21 | <jprice_> i am trying to create an encounter using 'Manage Encounters' and when I fill out the form the save encounter button is greyed out. what do i have to do to be able to save the encounter? |
| 17:07:43 | *** finbrein has joined #openmrs |
| 17:10:06 | <djazayeri> jprice_: IIRC the required fields are patient, encounter type, datetime, provider |
| 17:10:50 | <jprice_> thanks. i filled all those out. |
| 17:10:59 | <djazayeri> maybe location too |
| 17:11:36 | <jprice_> i filled that one out as well. i filled out all the fields on the 'Encounter Management' screen |
| 17:12:50 | *** r-friedman has quit IRC |
| 17:22:39 | *** judy has joined #openmrs |
| 17:28:09 | *** rafa has joined #openmrs |
| 17:28:09 | *** ChanServ sets mode: +v rafa |
| 17:30:07 | *** downeym has joined #openmrs |
| 17:30:07 | *** ChanServ sets mode: +o downeym |
| 17:30:07 | *** OpenMRSBot sets mode: +o downeym |
| 17:31:59 | *** downeym has quit IRC |
| 17:32:00 | *** nribeka has quit IRC |
| 17:32:01 | *** elliott_w has joined #openmrs |
| 17:32:01 | *** ChanServ sets mode: +o elliott_w |
| 17:32:05 | *** downeym has joined #openmrs |
| 17:32:05 | *** ChanServ sets mode: +o downeym |
| 17:32:05 | *** OpenMRSBot sets mode: +o downeym |
| 17:32:21 | *** cta has quit IRC |
| 17:35:57 | <wyclif> hi bwolfe |
| 17:39:21 | <bwolfe> hi wyclif |
| 17:39:32 | <bwolfe> djazayeri, I'm around now |
| 17:40:22 | <wyclif> bwolfe, is this true if conceptA is similar to concept B then the reverse is true |
| 17:40:34 | <bwolfe> yes |
| 17:41:57 | <wyclif> then we need to use a list of similar concept maps and not a list of similar concepts as the property for concept |
| 17:42:31 | <wyclif> this is because hibernate doesnot support what we want with many-to-many mappings |
| 17:42:51 | <wyclif> unless the mapped entities are different |
| 17:43:04 | <wyclif> but in this case it is concept to itself |
| 17:43:44 | *** asgoyal has joined #openmrs |
| 17:43:54 | <wyclif> asgoyal, https://tickets.openmrs.org/browse/OCC/fixforversion/13602 |
| 17:43:59 | <OpenMRSBot> <http://ln-s.net/93n1> (at tickets.openmrs.org) |
| 17:44:40 | <bwolfe> wyclif, why does it have to be a map? Its still just a list of other concepts its similar to |
| 17:46:28 | <wyclif> hmmmm... |
| 17:47:13 | <djazayeri> wyclif, bwolfe: one question is whether we want this in the POJO at all |
| 17:47:31 | <bwolfe> doesn't really have to be |
| 17:47:33 | <djazayeri> Do you really need to be able to say concept.getSimilarConcepts()? How about just service.getSimilarConcepts(concept) |
| 17:49:19 | <djazayeri> okay, so regarding occ-68 (I think) |
| 17:49:26 | <djazayeri> sorry, occ-86 |
| 17:49:45 | <djazayeri> bwolfe: you believe that uploading a concept should automatically create a concept source |
| 17:49:55 | <djazayeri> wyclif: you removed this feature because it was creating duplicates |
| 17:50:32 | <djazayeri> but I think we all agree that it's okay to create a new one if it doesn't exist, based on the fact that the upload has authenticated against the implementation id |
| 17:50:34 | <djazayeri> right? |
| 17:50:47 | <bwolfe> right |
| 17:50:48 | <wyclif> i agree that may be we get rid of getSimilarConcepts from concept |
| 17:51:15 | <wyclif> djazayeri, i agree with your work flow |
| 17:51:41 | <djazayeri> (Keep in mind that OCC server isn't supposed to be an API and platform in the way that OpenMRS is. If we need a function, let's put it in a service.) |
| 17:51:54 | *** rafa has quit IRC |
| 17:52:13 | <wyclif> i.e if the occ server authenticates you, then it should create implementation at this point |
| 17:52:16 | <djazayeri> Okay. My next question is about OCC-82 |
| 17:52:24 | *** elliott_w has quit IRC |
| 17:52:24 | <bwolfe> !ticket OCC_82 |
| 17:52:25 | <OpenMRSBot> bwolfe: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/OCC_82 |
| 17:52:26 | *** elliott_w_ has joined #openmrs |
| 17:52:26 | *** ChanServ sets mode: +o elliott_w_ |
| 17:52:27 | <bwolfe> !ticket OCC-82 |
| 17:52:28 | <OpenMRSBot> bwolfe: [#OCC-82] Upload does not include my implementation ids description - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-82 |
| 17:52:40 | <downeym> Hi elliott_w_ and welcome to the #openmrs IRC channel. |
| 17:52:42 | <bwolfe> did you answer my question on that one yet? |
| 17:52:46 | <djazayeri> basically that we require people to register an implementation id, and then we also require them to create a concept source |
| 17:52:48 | <wyclif> but this means that implementation source should not have a creator |
| 17:52:51 | *** elliott_w_ has quit IRC |
| 17:52:57 | *** elliott_w has joined #openmrs |
| 17:52:57 | *** ChanServ sets mode: +o elliott_w |
| 17:53:21 | <djazayeri> bwolfe: IIRC it required me to create that concept source. |
| 17:53:28 | <djazayeri> (manually) |
| 17:53:32 | <bwolfe> your own? |
| 17:53:39 | <bwolfe> err, a concpet source with your impl id? |
| 17:53:42 | <djazayeri> I think so, but maybe I'm misremembering |
| 17:53:42 | <djazayeri> yes |
| 17:53:45 | <djazayeri> on the client |
| 17:53:45 | <bwolfe> on the module side or server? |
| 17:53:49 | <bwolfe> strange |
| 17:54:07 | <bwolfe> that might have been how things used to be, but the impl id is separate on the client now |
| 17:54:22 | <djazayeri> Well, either it required me to do it, or it did it itself, but regardless the thing created didn't have a description |
| 17:54:25 | <djazayeri> hence my upload failed. |
| 17:54:51 | <djazayeri> although, annoyingly, the server accepts uploads without validating them |
| 17:57:37 | <djazayeri> So, bwolfe, you believe than when we set our implementation id through its management page, this should automatically create a concept source? |
| 17:57:48 | <djazayeri> Should that be done by core, or the occ module? |
| 17:59:48 | <djazayeri> (note that I'm running 1.6, so maybe this is different there than in 1.7+) |
| 18:00:01 | <bwolfe> no, djazayeri, why should it create the source? |
| 18:00:31 | *** elliott_w has quit IRC |
| 18:00:53 | *** elliott_w has joined #openmrs |
| 18:00:53 | *** ChanServ sets mode: +o elliott_w |
| 18:00:53 | <bwolfe> djazayeri, the occ module should just do the xml serialization correctly (not require the concept source and put the desc in the impl id in the xml top level element) |
| 18:01:27 | <djazayeri> bwolfe: Okay. So what's currently happening is that the OccUpload object (in the module client) has an "implementationSourceId" property that's a ConceptSoruce |
| 18:01:40 | <djazayeri> so the upload actually relies on the existence of that conept source |
| 18:01:55 | <bwolfe> yeah, thats a leftover from when impl id WAS a source |
| 18:02:05 | <bwolfe> the server might take it in as a source |
| 18:02:25 | <djazayeri> Okay |
| 18:02:41 | <djazayeri> so what I should really do is change things on the client so that it gets this data from the implementation id |
| 18:02:53 | <bwolfe> yes |
| 18:02:58 | <djazayeri> okay |
| 18:03:16 | <djazayeri> makes sense |
| 18:07:39 | <wyclif> going back to my issue, so you want marking concepts as similar to be done via a service methods and not concept.addSimilarConcept and calling save, right? |
| 18:07:57 | <djazayeri> seems more appropriate to me |
| 18:08:06 | <bwolfe> yeah, lets do that |
| 18:08:10 | <wyclif> ok |
| 18:08:14 | <bwolfe> makes your life a lot easier too :-D |
| 18:08:17 | <jprice_> hi djazazeri , thanks for the response. i tried using 1^ADULTINITIAL wherw ADULTINITIAL was one of the pre-defined encounter types. There is no encounterId=1 for my patient but hope it will create one |
| 18:08:27 | <jprice_> oh, and that did not work |
| 18:10:14 | <bwolfe> jprice_, is the encounter_type.encounter_type_id column == 1 when ADULTINITIAL is the name? |
| 18:10:40 | <jprice_> how do i check that ? |
| 18:12:02 | <bwolfe> look at the encounter_type table |
| 18:12:14 | <bwolfe> or the urls on the Manage Encounter Types admin page |
| 18:13:28 | <jprice_> no sure how to check the table. in the url, yes typeId=1 |
| 18:17:49 | <jprice_> according to hl7 spec the third field is patient location. 4th is Admission type, but the length of that is only 2 and there are no subfields |
| 18:24:50 | *** danielf` has quit IRC |
| 18:34:21 | <djazayeri> jprice_: I looked at the code. Actually there's a problem: the encounter type is not read from the message. |
| 18:35:54 | <jprice_> should it be ? is that why it is saying it is null ? |
| 18:36:21 | <djazayeri> This code snippet: |
| 18:36:25 | <djazayeri> // TODO: resolve encounter type from MSH data - do we need PV1 too? |
| 18:36:55 | <djazayeri> so, what currently happens is that the encounter type (which is required) |
| 18:37:03 | <djazayeri> is taken from the *form* |
| 18:38:36 | <jprice_> so is there something i can do to get it to accept the hl7 msg ? |
| 18:38:55 | <djazayeri> yes, i'm on a phone call now, will answer in bits and pieces |
| 18:39:34 | <jprice_> ok sorry to bother you i really appreciate your help whenever it is convenient for you. i already feel guilty for consuming so much of your time |
| 18:46:57 | *** bryq has quit IRC |
| 18:47:00 | <djazayeri> So, you should definitely create a ticket asking for the ability to specify the encounter type in the hl7 message |
| 18:47:04 | <djazayeri> because that's the right solution |
| 18:47:20 | *** bryq has joined #openmrs |
| 18:47:20 | *** ChanServ sets mode: +v bryq |
| 18:47:22 | <djazayeri> the workaround is to create a Form that represents this |
| 18:47:30 | <djazayeri> (Manage Forms -> Add Form) |
| 18:49:46 | <djazayeri> that form will specify an encounter id |
| 18:50:38 | <djazayeri> and you need to indicate the form in the message in MSH -> message profile identifier[0] -> entity identifier |
| 18:55:10 | <djazayeri> jprice_: see https://wiki.openmrs.org/display/docs/HL7 |
| 18:55:40 | <djazayeri> in the example message it's the 1 by itself in the MSH segment |
| 18:56:02 | <djazayeri> so you should create a form called "BP Monitor Reading" or something, and set its encounter type to be the right thing |
| 18:56:08 | <djazayeri> then your hl7 message should include that |
| 18:56:25 | <djazayeri> -> should include the internal formId of that form in the MSH segment |
| 18:56:35 | <djazayeri> bwolfe: so, to follow up |
| 18:56:58 | <djazayeri> We agreed that the client doesn't need to have a concept source to represent itself |
| 18:57:06 | <bwolfe> right |
| 18:57:06 | <djazayeri> rather it will pull that info from the implementation id |
| 18:57:17 | <bwolfe> right |
| 18:57:26 | <djazayeri> the implication of this is that the OCC Server is going to be creating a concept source to represent the client. |
| 18:57:48 | <djazayeri> So if I upload a concept, and you download it, you will then get an OCC-Server-created concept source representing me. |
| 18:57:48 | <bwolfe> right |
| 18:57:57 | <bwolfe> right |
| 18:58:51 | <djazayeri> But I do _not_ get that concept source in my own client |
| 18:59:18 | <bwolfe> right, we should block that. or prevent it. its not really necessary |
| 18:59:44 | <djazayeri> One unfortunate side effect of that is that if I'm sharing concepts via both OCC and Metadata Sharing, there will end up being two different concept sources that represent me |
| 18:59:49 | <djazayeri> one for each module |
| 18:59:58 | <djazayeri> (and I'll only have the MDS one, not the OCC one, myself) |
| 19:00:32 | <bwolfe> yes, unfortunate |
| 19:00:37 | <djazayeri> although in a future version of OCC, I'll presumably see the mapping to that source as an update to my OCC concept, that I can pull down. |
| 19:00:44 | <djazayeri> All in all it strikes me as strange. |
| 19:01:13 | <djazayeri> If there's going to be a concept source to represent me, shouldn't I be the one to create it? |
| 19:01:23 | <djazayeri> and shouldn't I know about it? |
| 19:02:00 | *** goutham has joined #openmrs |
| 19:03:02 | *** downeym has quit IRC |
| 19:03:45 | *** downeym has joined #openmrs |
| 19:03:45 | *** ChanServ sets mode: +o downeym |
| 19:03:45 | *** OpenMRSBot sets mode: +o downeym |
| 19:08:42 | *** goutham has quit IRC |
| 19:18:05 | <djazayeri> bwolfe: Anyway, I guess I'll just work around the current workflow now, and raise this on the dev list. |
| 19:20:14 | *** Suranga has joined #openmrs |
| 19:25:57 | <bwolfe> djazayeri, hmm, the fact that an impl id is a source at the server is just conincidental. I'd rather we not create it at the local if we don't have to |
| 19:26:32 | <jprice_> thanks djazaryeri i will submit the ticket and try what you suggest |
| 19:57:56 | *** james_regen has quit IRC |
| 20:23:18 | *** Suranga has quit IRC |
| 20:27:03 | *** downeym has quit IRC |
| 20:27:47 | *** downeym has joined #openmrs |
| 20:27:47 | *** ChanServ sets mode: +o downeym |
| 20:27:47 | *** OpenMRSBot sets mode: +o downeym |
| 20:28:08 | <jprice_> djazayeri : i tiried the following and it did not work. the form I created is Id=2 Name=BP Monitor |
| 20:28:11 | <jprice_> "data":"MSH|^~\\&|FORMENTRY|AMRS|HL7LISTENER|AMRS|20060809121931||ORU^R01|formentry-20060809121931|P|2.5|2||||||||2^BP Monitor^http://schema.openmrs.org/2006/FormEntry/formId^URI\r |
| 20:28:39 | <jprice_> i will be back in a couple of hours. i really want to get this thing to work |
| 20:37:10 | *** gbastien has joined #openmrs |
| 20:54:32 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: After reading http://notes.openmrs.org/devcall-2011-08-11 from Eldoret airport, I realize how far @OpenMRS community has ... <http://twitter.com/OpenMRS/statuses/101745626827587584> |
| 21:08:06 | *** judy has quit IRC |
| 21:11:30 | *** bryq has quit IRC |
| 21:14:53 | *** finbrein has quit IRC |
| 21:23:14 | *** asgoyal has quit IRC |
| 21:28:51 | *** elliott_w has quit IRC |
| 21:31:41 | *** bwolfe has quit IRC |
| 21:34:42 | <djazayeri> wyclif: have you recently uploaded any concepts via occ? |
| 21:34:53 | <djazayeri> I just got a sqlgrammarexception |
| 21:34:57 | <wyclif> not yet |
| 21:34:57 | <djazayeri> but unit tests pass |
| 21:35:03 | <wyclif> where |
| 21:35:09 | <wyclif> you might be right |
| 21:35:14 | <djazayeri> from OccConcept occ where occ.conceptId = :conceptId |
| 21:35:41 | <wyclif> hmm |
| 21:36:21 | <djazayeri> does upload and download happen simultaneously? |
| 21:36:42 | <wyclif> i think it shoule be occ.occConceptId |
| 21:37:02 | <djazayeri> who recently changed this? |
| 21:37:13 | <wyclif> am not sure about the simultaneous download and upload |
| 21:40:08 | <djazayeri> wyclif: in your recent commit you added the call that does: |
| 21:40:08 | <djazayeri> OccConcept occConcept = dao.getOccConceptByCreatedConceptId(conceptId); |
| 21:40:18 | <djazayeri> that's the one that's throwing the sql grammar exception |
| 21:40:53 | <djazayeri> you think I should just change the hql query to say occConceptId? |
| 21:41:07 | <wyclif> yeah |
| 21:41:17 | <wyclif> it was my mistake |
| 21:41:31 | <djazayeri> but there's also a concept_id column in that table, right? |
| 21:41:35 | <wyclif> i think i have a wrong column name in the test data and that is why i think the test is passing |
| 21:42:10 | <djazayeri> looking at the hbm.xml file it shows both properties: occConceptId (the id) and conceptId |
| 21:43:08 | <wyclif> you are right but why the test passes is because i set the value toa wrong property in my test data |
| 21:44:51 | <wyclif> let me try uploading one |
| 21:45:10 | <wyclif> can you check your occ_concept table |
| 21:45:12 | <djazayeri> Table 'openmrs16.occ_concept' doesn't exist |
| 21:45:18 | <djazayeri> just found the actual error msg |
| 21:45:34 | <wyclif> do svn update |
| 21:45:53 | <djazayeri> I did one quite recently |
| 21:45:58 | <wyclif> i let me change the id of the changeset that creates that table so that you can upgrade |
| 21:46:00 | <djazayeri> The liquibase.xml file has that changeset |
| 21:46:21 | <djazayeri> should I just delete a changeset id from my liquibasechangelog? |
| 21:46:29 | <wyclif> yeah |
| 21:46:33 | <djazayeri> ok |
| 21:46:34 | <wyclif> so that the table gets created |
| 21:46:44 | <djazayeri> Was that changeset previously something else? |
| 21:47:28 | <wyclif> djazayeri, wait i commit a liquibase.xml with a new changeset id |
| 21:47:35 | <djazayeri> that's not the problem |
| 21:47:57 | <djazayeri> the file isn't being executed |
| 21:48:01 | <djazayeri> liquibase.xml I mean. |
| 21:48:05 | <djazayeri> is that the right filename? |
| 21:48:06 | <wyclif> it is |
| 21:48:13 | <djazayeri> not for me in 1.6... |
| 21:48:20 | <wyclif> oh that is why |
| 21:48:42 | <wyclif> this was introduced in later versions |
| 21:48:47 | <djazayeri> I see. |
| 21:48:51 | <djazayeri> 1.7.0.13476 |
| 21:49:10 | <djazayeri> Okay, I'll create a ticket. |
| 21:49:20 | <djazayeri> and I'll create the table manually. |
| 21:49:45 | <djazayeri> actually, can you easily use some mysql tool to reverse-engineer your db and give me a suitable sql script? |
| 21:49:54 | <wyclif> i would suggest the module should require openmrs after this change |
| 21:49:54 | <djazayeri> suitable -> equivalent |
| 21:50:04 | <wyclif> or on the documentation |
| 21:50:05 | <djazayeri> require? |
| 21:50:35 | <wyclif> yeah |
| 21:50:42 | <djazayeri> require what? |
| 21:50:48 | <djazayeri> oh |
| 21:50:59 | <djazayeri> So, we're specifically making the occ module work on 1.6 |
| 21:51:09 | <wyclif> ok |
| 21:51:17 | <djazayeri> So my ticket is to backport the functionality to 1.6.? |
| 21:51:38 | <wyclif> then we can add the script to the sqldiff too |
| 21:51:53 | <djazayeri> actually, can you just change this from using liquibase to doing plain sql? |
| 21:51:54 | <wyclif> that we the table gets created always |
| 21:51:56 | <djazayeri> yeah, that'd be easier. |
| 21:52:02 | <wyclif> in both versions |
| 21:52:13 | <wyclif> good catch!!! |
| 21:53:52 | <djazayeri> assigned to you: https://tickets.openmrs.org/browse/OCC-88 |
| 21:58:55 | <wyclif> ok |
| 21:59:31 | <wyclif> djazayeri, after introducing liquibase.xml, is sqldiff execute still |
| 21:59:36 | <wyclif> i hope no |
| 21:59:41 | <wyclif> because it makes no sense |
| 21:59:46 | <djazayeri> wyclif: sqldiff is run first, then liquibase.xml |
| 21:59:50 | <wyclif> hmm |
| 22:00:01 | <djazayeri> I would propose removing the liquibase file and just doing it in sqldiff |
| 22:00:08 | <djazayeri> so there's no need to maintain two copies of everything. |
| 22:00:14 | <wyclif> djazayeri, with that order then can have it in both |
| 22:00:37 | <wyclif> because liquibase wont recreate due to the precondition |
| 22:00:39 | <djazayeri> Yeah, but why? Sounds like a way to guarantee that someone forgets to change both sometime. :-) |
| 22:00:51 | <wyclif> ok |
| 22:00:55 | <djazayeri> The DRY (Don't Repeat Yourself) principle |
| 22:01:07 | <wyclif> i think |
| 22:03:05 | *** downeym has quit IRC |
| 22:04:26 | <wyclif> djazayeri, what is version number |
| 22:04:30 | <wyclif> in sqldiff |
| 22:04:36 | <djazayeri> 1.0 |
| 22:04:53 | <wyclif> so it specific to module and not openmrs |
| 22:04:58 | <wyclif> i get it now |
| 22:04:59 | <djazayeri> It's the thing that goes in the occ.database_version GP |
| 22:06:58 | *** downeym has joined #openmrs |
| 22:06:58 | *** OpenMRSBot sets mode: +o downeym |
| 22:06:58 | *** ChanServ sets mode: +o downeym |
| 22:18:12 | <jprice_> \ |
| 22:20:36 | <jprice_> hi djazayeri, did my MSH segment look ok to you ? |
| 22:21:09 | <djazayeri> visually it looked fine but I have no idea |
| 22:21:14 | <djazayeri> is it the same error message? |
| 22:21:18 | <djazayeri> about missing encounter type? |
| 22:22:04 | <jprice_> yes |
| 22:22:36 | <djazayeri> I recommend googling for the definition of MSH |
| 22:22:56 | <djazayeri> and finding the fields that I mention in my email |
| 22:23:05 | <djazayeri> or via IRC (I forget where) |
| 22:23:35 | <djazayeri> the actual code is: |
| 22:23:35 | <djazayeri> formId = Integer.parseInt(msh.getMessageProfileIdentifier(0).getEntityIdentifier().getValue()); |
| 22:24:05 | <djazayeri> so, check hl7 docs and make sure you've got the right field for message profile identifier and entity identifier |
| 22:24:26 | <jprice_> ok thanks. i will do it right now |
| 22:29:23 | <wyclif> djazayeri, i have added a sqldiff.xml but it is not getting executes |
| 22:29:47 | <jprice_> there is nothing in hl7 std definition of MSG that says 'profile identifier' or 'entity indentifier' http://www.corepointhealth.com/resource-center/hl7-resources/hl7-msh-message-header on the wiki page for hl7 |
| 22:29:52 | <OpenMRSBot> <http://ln-s.net/93rK> (at www.corepointhealth.com) |
| 22:30:08 | <djazayeri> wyclif: in my db it says that occmodule.database_version is 1.0.2 |
| 22:30:14 | <djazayeri> so you'd need to use a number higher than that |
| 22:30:42 | <jprice_> there is message profile indentifier but no entitiy identifier |
| 22:30:45 | <jprice_> https://wiki.openmrs.org/display/docs/HL7#HL7-MSH%28MessageHeader%29Key%3A |
| 22:30:50 | <OpenMRSBot> <http://ln-s.net/93rL> (at wiki.openmrs.org) |
| 22:30:51 | <djazayeri> wyclif: actually, there's already a sqldiff.xml file with an empty diff, by lu |
| 22:31:23 | <jprice_> maybe it is UniqueSystem Id in that |
| 22:32:14 | <wyclif> ok |
| 22:32:32 | <wyclif> thanks |
| 22:32:46 | <djazayeri> jprice_: http://www.interfaceware.com/hl7-standard/hl7-segment-MSH.html |
| 22:32:51 | <OpenMRSBot> <http://ln-s.net/93rM> (at www.interfaceware.com) |
| 22:33:00 | <djazayeri> and the datatype is EI, which I assume means Entity Identifer |
| 22:33:05 | <djazayeri> so perhaps entity identifier is the whole thing |
| 22:39:41 | *** gbastien has quit IRC |
| 22:46:10 | *** wyclif has quit IRC |
| 22:54:10 | <jprice_> do u think the following mapping is correct : MsgProfileIndentifier=0-UniqueSystemId=2(the id of the form I created) |
| 22:54:46 | <jprice_> namespace of ass-auth=http://schema.openmrs.org/2006/FormEntry/formId UniveralIdType=URI |
| 22:55:17 | <djazayeri> I don't understand |
| 22:56:15 | <jprice_> the value to the left of the = is the name of the field as shown on the HL wiki page and the things to the right the actual values i used |
| 22:56:42 | <jprice_> i will be back in bit |
| 22:56:50 | <djazayeri> jprice_: message profile identifier should be 2 |
| 22:56:57 | <djazayeri> (the id of the form you created) |
| 23:23:12 | <jprice_> i tried that before and it did not work either. still same error abount numm encounter type |
| 23:28:37 | *** downeym has quit IRC |
| 23:41:30 | *** jprice_ has quit IRC |
| 23:42:30 | *** jprice has joined #openmrs |
| 23:42:53 | <jprice> that should have been 'null' encounter type not 'numm' |
| 23:44:40 | <jprice> is there a way for you to run my msg through a debugger and see why it is happening ? |
| 23:53:28 | *** yanokwa has joined #openmrs |
| 23:53:28 | *** ChanServ sets mode: +v yanokwa |