00:16:36
|
*** gbastien has quit IRC
|
01:51:35
|
*** yanokwa has joined #openmrs
|
01:51:35
|
*** ChanServ sets mode: +v yanokwa
|
02:15:58
|
*** chopin has quit IRC
|
02:48:46
|
*** djazayeri has joined #openmrs
|
02:48:46
|
*** ChanServ sets mode: +o djazayeri
|
02:51:55
|
*** upul` has joined #openmrs
|
02:51:55
|
*** ChanServ sets mode: +v upul`
|
02:52:57
|
*** djazayeri has quit IRC
|
04:12:25
|
*** yanokwa_ has joined #openmrs
|
04:12:26
|
*** yanokwa has quit IRC
|
04:30:44
|
*** surangak has joined #openmrs
|
04:31:31
|
<surangak> bwolfe, good morning bwolfe, r u really there ?
|
04:31:40
|
<surangak> bwolfe, small design clarification :)
|
05:45:19
|
*** bumi has joined #openmrs
|
05:50:22
|
*** goutham has joined #openmrs
|
05:51:42
|
*** robbyoconnor has quit IRC
|
05:51:43
|
*** r0bby has joined #openmrs
|
05:51:43
|
*** ChanServ sets mode: +v r0bby
|
05:51:46
|
<bumi> Hi,@bwolfe. Im using openmrs 1.6.3, on windows vista. I cant get the find field elements search box neither the concept search box, any idea?
|
06:03:00
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Improving on ObsValidator and handlers - supporting null or empty error messages <http://feedproxy.google.com/~r/OMRStrunk/~3/WMUT8oYklXo/OpenMRS>
|
06:11:38
|
*** bumi has quit IRC
|
06:18:46
|
*** goutham has quit IRC
|
06:57:02
|
*** yanokwa_ has quit IRC
|
07:09:02
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating ObsValidator Tests for complex Obs <http://feedproxy.google.com/~r/OMRStrunk/~3/Asy81Pzbo_8/OpenMRS>
|
07:12:14
|
*** surangak_ has joined #openmrs
|
07:12:14
|
*** surangak has quit IRC
|
07:15:07
|
*** surangak__ has joined #openmrs
|
07:15:07
|
*** surangak_ has quit IRC
|
07:31:59
|
*** danielf` has joined #openmrs
|
07:31:59
|
*** ChanServ sets mode: +v danielf`
|
07:59:38
|
*** bryq has joined #openmrs
|
07:59:44
|
*** ChanServ sets mode: +v bryq
|
08:29:57
|
*** dkayiwa has joined #openmrs
|
08:32:10
|
*** magoo has joined #openmrs
|
08:46:20
|
*** goutham has joined #openmrs
|
08:46:26
|
<surangak__> good afternoon dkayiwa
|
08:46:35
|
<dkayiwa> good afternoon surangak__
|
08:46:38
|
<surangak__> dkayiwa, IRC looks quiet today
|
08:46:44
|
<dkayiwa> hahahahaha
|
08:46:48
|
<surangak__> everyone missing :)
|
08:46:57
|
<dkayiwa> apart from bwolfe :)
|
08:47:06
|
<surangak__> dkayiwa, i dont think hes really here
|
08:47:16
|
<dkayiwa> sure?
|
08:47:23
|
<surangak__> dkayiwa, he was online since 5-6 hours ago.. i think he forgot to log off...
|
08:47:32
|
<dkayiwa> ohhhhhh
|
08:47:36
|
<dkayiwa> interestesting
|
08:47:54
|
<dkayiwa> hwo do you tell?
|
08:48:12
|
<dkayiwa> did you try talk to him and he did not respond?
|
08:48:20
|
<surangak__> dkayiwa, yeps :)
|
08:48:27
|
<dkayiwa> lollllllllllllll :)
|
08:48:33
|
<surangak__> dkayiwa, plus he was online really early...
|
08:48:41
|
<dkayiwa> oh i see
|
08:48:57
|
<dkayiwa> very very good detective info :D
|
08:48:59
|
<surangak__> dkayiwa, much earlier than usual... so i dont think hes 'gone out for a sandwitch' as he usually says :)
|
08:49:17
|
<dkayiwa> hahahahaha
|
08:49:22
|
<dkayiwa> may be he is baby sitting
|
08:49:44
|
<surangak__> dkayiwa, oh, u mean his family is also in Kenya ?
|
08:50:13
|
<dkayiwa> yes
|
08:51:36
|
<surangak__> dkayiwa, i heard on news that there is some kind os famine situation in africa ?
|
08:51:54
|
<surangak__> dkayiwa, they mentioned uganda too... but u seem to be doing well :-)
|
08:55:00
|
<magoo> dkayiwa i updated and am still gettting the same errors url http://pastebin.com/2b8w7ZFf
|
08:56:39
|
<magoo> is something wrong with maven repository ?
|
08:57:08
|
<magoo> its complaining about a missing file
|
08:58:32
|
<dkayiwa> surangak__: sorry was caught up here in some conversation
|
08:58:44
|
<dkayiwa> surangak__: that is very true
|
08:58:59
|
<dkayiwa> though the poorest are the ones who are starving. surangak__
|
08:59:12
|
<dkayiwa> magoo
|
08:59:15
|
<surangak__> dkayiwa, hows your family doing ?
|
08:59:20
|
<dkayiwa> magoo: let em look at it
|
08:59:31
|
<dkayiwa> surangak__: my family is doing well
|
08:59:34
|
<dkayiwa> thanks :)
|
08:59:54
|
<surangak__> dkayiwa, is sri lanka fortunately we dont seem to have that kind of problem...
|
09:00:18
|
<dkayiwa> oh you are so blessed by God :)
|
09:02:26
|
<dkayiwa> surangak__: do you believe in God?
|
09:05:39
|
<dkayiwa> magoo: can you checkout the basic module and see if it can compile
|
09:05:40
|
<dkayiwa> ?
|
09:06:05
|
<magoo> the openmrs module
|
09:06:43
|
<magoo> dkayiwa what module?
|
09:08:36
|
<magoo> it gaves the same errors
|
09:08:55
|
<dkayiwa> magoo can you pastebin them?
|
09:11:08
|
<magoo> url http://pastebin.com/jYZbkjG7
|
09:11:53
|
<dkayiwa> magoo: can you type mvn and commandline and tell me what you see?
|
09:12:28
|
<dkayiwa> magoo this is not for the basic module
|
09:12:53
|
<magoo> mvn is not recognised as a command
|
09:12:55
|
<dkayiwa> the modules are here http://svn.openmrs.org/openmrs-modules/
|
09:13:16
|
<magoo> what basic module?
|
09:13:25
|
<dkayiwa> check that link
|
09:13:37
|
<dkayiwa> its one of the openmrs modules (start up one)
|
09:15:58
|
<magoo> i dont seem to have these modules in my eclipse
|
09:16:45
|
<magoo> did i choose the wrong link when i was importing files
|
09:18:02
|
<magoo> dkayiwa i have checked the link but it seems i dont have the basic modules
|
09:21:03
|
<dkayiwa> magoo try checkout this http://svn.openmrs.org/openmrs-modules/basicmodule/
|
09:21:09
|
<OpenMRSBot> <http://ln-s.net/92FJ> (at svn.openmrs.org)
|
09:25:08
|
<magoo> dkayiwa i have been following this url https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers for the installation but it does not say anything about the basic modules
|
09:25:09
|
<OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org)
|
09:25:39
|
<dkayiwa> magoo: correct, i just want to ensure that your setup is fine
|
09:26:13
|
<magoo> dkayiwa should i repeat the entire installation process
|
09:26:33
|
<dkayiwa> yes you can
|
09:26:43
|
<magoo> using the links u have given me
|
09:27:16
|
<magoo> does it overwrite the existing installation
|
09:27:45
|
<magoo> or i have to re-install eclipse
|
09:29:25
|
<dkayiwa> you dont have to reinstall eclipse
|
09:30:59
|
<magoo> okay
|
09:33:57
|
<magoo> dkayiwa is it supposed to be a new installation or there is a way of replacing an existing project
|
09:34:38
|
<dkayiwa> delete and do it again (new)
|
09:37:13
|
<magoo> okay
|
09:54:24
|
*** r0bby has quit IRC
|
09:56:33
|
*** Echidna has quit IRC
|
09:59:53
|
*** Echidna has joined #openmrs
|
09:59:53
|
*** ChanServ sets mode: +v Echidna
|
10:20:46
|
*** pascal` has joined #openmrs
|
10:21:07
|
*** ChanServ sets mode: +v pascal`
|
10:21:17
|
<pascal`> Hey bwolfe
|
10:21:28
|
<bwolfe> hi pascal`
|
10:23:33
|
<upul`> hey bwolfe hey pascal`
|
10:23:54
|
<pascal`> Hey upul`
|
10:24:33
|
<bwolfe> hi upul`
|
10:25:21
|
<bwolfe> how goes life?
|
10:25:26
|
<bwolfe> dkayiwa: how goes the sprinting today?
|
10:25:51
|
<dkayiwa> not bad bwolfe
|
10:25:53
|
<dkayiwa> and you?
|
10:26:12
|
<bwolfe> just starting my day
|
10:26:23
|
<bwolfe> wednesday is the day I have to work through midnight :-/
|
10:26:25
|
<dkayiwa> oh yes we noticed that
|
10:26:42
|
<dkayiwa> you must have been baby sitting bwolfe
|
10:26:43
|
<dkayiwa> :)
|
10:27:39
|
<dkayiwa> or do you just oversleep like me? :D
|
10:28:23
|
<bwolfe> was up at 7am with the kiddos
|
10:28:34
|
<dkayiwa> oh i see
|
10:28:43
|
<bwolfe> this morning meghan and eden went to visit some orphanages. andy and I went grocery shopping
|
10:28:43
|
<dkayiwa> kiddos :D
|
10:28:59
|
<dkayiwa> oh that must have been fun
|
10:29:04
|
<dkayiwa> ladies and gents alone
|
10:29:05
|
<dkayiwa> :)
|
10:31:14
|
<bwolfe> heh
|
10:39:09
|
<bwolfe> dkayiwa: if I get the 1.6.3 jars into the mavenrepo, are you at a place where you could commit parts of your work?
|
10:39:25
|
<dkayiwa> bwolfe: yes
|
10:42:39
|
<bwolfe> ok, I'll work on that asap then
|
10:42:46
|
<dkayiwa> 8)
|
10:58:32
|
*** magoo has quit IRC
|
11:17:21
|
<bwolfe> dkayiwa: its started raining here
|
11:17:32
|
<dkayiwa> lolllllll
|
11:17:33
|
<bwolfe> hopefully my internet holds out long enough to get these uploaded! :-)
|
11:17:44
|
<dkayiwa> bwolfe: its about to rain here too :)
|
11:17:56
|
<dkayiwa> let me wish you luck :D
|
11:18:50
|
*** magoo has joined #openmrs
|
11:26:24
|
*** magoo has quit IRC
|
11:36:18
|
*** upul` has quit IRC
|
11:39:12
|
<surangak__> dkayiwa, sorry, just got back -
|
11:39:21
|
<dkayiwa> no problem :)
|
11:39:23
|
<surangak__> dkayiwa, we were having quarterly management review :-)
|
11:39:28
|
<dkayiwa> oh i see
|
11:39:31
|
<dkayiwa> and how is it going?
|
11:39:44
|
<surangak__> dkayiwa, in response to yr last question, we're roman catholics
|
11:39:51
|
<dkayiwa> oh i see
|
11:40:02
|
<dkayiwa> now i know the answer :D
|
11:40:02
|
<surangak__> dkayiwa, based on the review, the management is doing well :P
|
11:40:13
|
<dkayiwa> oh thats so good!!!
|
11:40:41
|
<dkayiwa> surangak__: any bonues because of that? :)
|
11:40:48
|
<surangak__> dkayiwa, oh yep, the management are very pleased about it
|
11:40:52
|
<surangak__> dkayiwa, :P
|
11:41:01
|
<dkayiwa> :)
|
11:41:35
|
<surangak__> dkayiwa, this is a bad economy, and we have to compete with the indian IT firms :)
|
11:42:04
|
<dkayiwa> oh yes
|
11:42:16
|
<dkayiwa> and its not easy to compete with indians :)
|
11:51:26
|
*** bryq has quit IRC
|
11:53:24
|
<bwolfe> dkayiwa: the 1.6.3 jars are up in the repo now
|
11:53:48
|
<dkayiwa> cool thanks bwolfe: let me do the needful
|
11:55:02
|
<bwolfe> ok, I'm trying it out now just with the switch. hopefully it builds :-)
|
11:55:15
|
<dkayiwa> ok :)
|
11:55:17
|
<bwolfe> looks like its downloading ok
|
11:55:26
|
<dkayiwa> ok
|
11:55:45
|
<bwolfe> (had to delete the org/openmrs/**/1.6.3 folders in my /.m2 repo though
|
11:55:53
|
<dkayiwa> ok
|
11:56:17
|
<bwolfe> yep, seems to wokr
|
11:56:19
|
<bwolfe> *work
|
11:56:27
|
<bwolfe> its just giving me 1.6 vs 1.7 errors now
|
11:56:35
|
<dkayiwa> ok
|
11:57:27
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Why thank you! :-) RT @TheLancetTech: Anyone who's interested in user-friendly open source medical record systems - have a look at @OpenMRS <http://twitter.com/OpenMRS/statuses/98713766757285888>
|
11:59:59
|
*** james_regen has joined #openmrs
|
11:59:59
|
*** ChanServ sets mode: +v james_regen
|
12:00:46
|
*** dkayiwa has quit IRC
|
12:15:26
|
*** upul` has joined #openmrs
|
12:15:26
|
*** ChanServ sets mode: +v upul`
|
12:19:37
|
*** gbastien has joined #openmrs
|
12:24:20
|
*** dkayiwa has joined #openmrs
|
12:25:38
|
<dkayiwa> bwolfe: did you commit the poms?
|
12:26:18
|
<bwolfe> the 1.6.3 ones to the mavenrepo? or the occmodule ones?
|
12:26:36
|
<dkayiwa> the occmodule ones
|
12:26:59
|
<bwolfe> no
|
12:27:03
|
*** wyclif has quit IRC
|
12:27:08
|
<bwolfe> I just changed 1.7.0 to 1.6.3 in the pom
|
12:27:20
|
<dkayiwa> yes thats what i also did
|
12:33:34
|
*** magoo has joined #openmrs
|
12:38:37
|
*** surangak__ has quit IRC
|
12:39:16
|
*** surangak has joined #openmrs
|
12:41:47
|
<bwolfe> dkayiwa: you about done with that ticket yet? its time you move onto bigger and better things. :-)
|
12:42:09
|
<dkayiwa> bwolfe: just a minute :)
|
12:45:25
|
<dkayiwa> bwolfe: ConceptSet before 1.7 did not implement Comparable<ConceptSet>. Any quick workarounds for sorting a conceptset list?
|
12:46:47
|
<bwolfe> copy/paste the method for sorting them into a comparator class in the module and then sort using Collections.sort(list, comparator)
|
12:47:49
|
<dkayiwa> oh i see see. thanks for the very very simpler option
|
12:55:04
|
*** chopin has joined #openmrs
|
12:57:16
|
*** upul` has quit IRC
|
12:57:18
|
*** upul`` has joined #openmrs
|
12:57:18
|
*** ChanServ sets mode: +v upul``
|
13:03:09
|
<bwolfe> dkayiwa: joining the review call now?
|
13:03:27
|
<bwolfe> you were 15 mins early for it (so says jeremy)
|
13:03:32
|
<dkayiwa> oh yes. had tried a few minutes earlier and was alone :)
|
13:04:15
|
*** upul`` has quit IRC
|
13:05:49
|
*** chopin has quit IRC
|
13:11:30
|
*** magoo_ has joined #openmrs
|
13:13:06
|
*** magoo has quit IRC
|
13:13:50
|
<magoo_> dkayiwa am getting this message when i try to create a new project http://pastebin.com/2PpJTaBE
|
13:15:43
|
<magoo_> when i check the workspace folder for flashmediaviewer directory i dont seem to the directory
|
13:15:46
|
*** wyclif has joined #openmrs
|
13:19:41
|
*** chopin has joined #openmrs
|
13:27:52
|
*** danielf` has quit IRC
|
13:30:41
|
<magoo_> dkayiwa send me the url again
|
13:31:32
|
<magoo_> dkayiwa
|
13:35:45
|
<dkayiwa> magoo_: you can check irc logs
|
13:36:23
|
<bwolfe> !irclogs
|
13:36:24
|
<OpenMRSBot> bwolfe: "irclogs" --- The OpenMRS IRC logs are publicly displayed online: http://wiki.openmrs.org/display/IRC/IRC+Logs
|
13:37:10
|
<magoo_> dkayiwa am having problems with may internet its on and off
|
13:43:18
|
*** downeym has joined #openmrs
|
13:43:18
|
*** ChanServ sets mode: +o downeym
|
13:43:18
|
*** OpenMRSBot sets mode: +o downeym
|
13:50:10
|
*** wyclif has quit IRC
|
13:50:10
|
*** chopin has quit IRC
|
13:57:19
|
*** djazayeri has joined #openmrs
|
13:57:19
|
*** ChanServ sets mode: +o djazayeri
|
14:00:02
|
*** wyclif has joined #openmrs
|
14:04:11
|
*** r9friedman has joined #openmrs
|
14:04:19
|
<downeym> Hi r9friedman and welcome to the #openmrs IRC channel.
|
14:04:19
|
*** r9friedman is now known as r-friedman
|
14:04:50
|
*** goutham has quit IRC
|
14:05:01
|
<r-friedman> bwolfe: Hi Ben, got a minute?
|
14:05:40
|
<bwolfe> r-friedman: sure, going to start the daily scrum, but you can talk through it. :-) (since I forgot last time I told you to wait until after)
|
14:05:50
|
<bwolfe> djazayeri, wyclif, dkayiwa: ready for scrumming?
|
14:06:03
|
<djazayeri> yes
|
14:07:12
|
<bwolfe> djazayeri: want to go first?
|
14:07:25
|
<djazayeri> okay
|
14:07:27
|
<r-friedman> bwolfe: with a criterion query, if you want to put the objects coming out of .list() into a typed list, do you just cast the whole criteria string ending in .list() with (List<type>)?
|
14:07:43
|
<bwolfe> yeah
|
14:08:11
|
<djazayeri> yesterday: * finished checking in code from ui2 sprint * talked to Hamish about meeting planning
|
14:08:26
|
<djazayeri> today:
|
14:08:27
|
<djazayeri> * will resume actual work
|
14:08:38
|
<djazayeri> * finish last sprint's code reviews
|
14:08:44
|
<djazayeri> * design calls
|
14:08:56
|
<wyclif> hi
|
14:09:02
|
<r-friedman> ok, and where does the api get the DB connection? how does it do it without knowing the driver class?
|
14:09:42
|
<djazayeri> (no blockers)
|
14:11:47
|
<bwolfe> r-friedman: sessionFactory is a spring managed bean. its injected into each dao class. when spring builds the sessionFactory object it gives it hibernate properties. When openmrs starts, it takes properties from the runtime properties as hibernate properties as well.
|
14:12:11
|
<bwolfe> in recent versions of openmrs, the driver class is used an the driver class is loaded by openmrs at startup
|
14:12:19
|
<bwolfe> djazayeri: doing some occ today?
|
14:12:35
|
<bwolfe> wyclif or dkayiwa, who's ready?
|
14:12:35
|
<djazayeri> bwolfe: Hope so, unless the design calls kill me
|
14:12:48
|
<djazayeri> feel free to point me to a ticket, or else I'll just pick one.
|
14:13:28
|
<r-friedman> bwolfe: i get the at startup, i can't find the routine where the magic happens.
|
14:13:55
|
<bwolfe> djazayeri: just pick one
|
14:13:56
|
<dkayiwa> Did some IRC, Had some discussions with my GSOC Student, Worked on Making OCC Module Work in 1.6 - OCC-57, Looked into Fixing the OCC database connection timeout - OCC-3, Now working on Null birthdate causes error when uploading OCC concepts - OCC-1. No blockers.
|
14:14:10
|
<bwolfe> r-friedman: which magic exactly? the loading of the driver class?
|
14:14:28
|
<r-friedman> yes
|
14:14:38
|
<bwolfe> I can't remember off-hand where it is...hibernate layer somewhere
|
14:14:58
|
<r-friedman> i think i am confusing you by changing the subject
|
14:15:02
|
<bwolfe> dkayiwa--
|
14:15:07
|
<dkayiwa> :)
|
14:15:14
|
<bwolfe> dkayiwa: multiple line is better than one block
|
14:15:23
|
<dkayiwa> ok will do so tomorrow
|
14:15:27
|
<dkayiwa> :D
|
14:15:36
|
<r-friedman> the jasper reports module is trying to pass jasper reports the driver to use. right now it is hard-coded to mysql
|
14:15:45
|
<bwolfe> dkayiwa: keep a text file and just keep inserting the days stuff there. (at least thats what I do)
|
14:15:51
|
<bwolfe> then its just a matter of copying/pasting
|
14:15:57
|
<dkayiwa> oh i see
|
14:16:03
|
<dkayiwa> thanks for the tip :)
|
14:16:13
|
<wyclif> am redy
|
14:16:17
|
<wyclif> ready
|
14:16:30
|
<bwolfe> ok, go ahead wyclif
|
14:16:33
|
<wyclif> yesterday:
|
14:16:33
|
<wyclif> * occ-33, revisted occ-70 to respond to review comments
|
14:16:33
|
<wyclif> today:
|
14:16:33
|
<wyclif> * picked up occ-69, should pick another when i get done with this
|
14:16:33
|
<wyclif> no blockers
|
14:17:03
|
<bwolfe> !ticket OCC-30
|
14:17:04
|
<OpenMRSBot> bwolfe: [#OCC-30] Add support to import OpenEHR Archetypes - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-30
|
14:17:08
|
<bwolfe> !ticket OCC_70
|
14:17:09
|
<OpenMRSBot> bwolfe: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/OCC_70
|
14:17:10
|
<bwolfe> !ticket OCC-70
|
14:17:11
|
<OpenMRSBot> bwolfe: [#OCC-70] Change way concepts are linked in occ server - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-70
|
14:17:25
|
<bwolfe> !ticket OCC-69
|
14:17:26
|
<OpenMRSBot> bwolfe: [#OCC-69] Make sure concepts are linked that were initially downloaded - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-69
|
14:17:42
|
<bwolfe> wyclif: how closely were you paying attention on the design call?
|
14:17:48
|
<wyclif> apparently, occ-33
|
14:18:11
|
<bwolfe> !ticket OCC-33
|
14:18:12
|
<OpenMRSBot> bwolfe: [#OCC-33] Duplicate Concept Sources uploaded - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-33
|
14:18:31
|
<bwolfe> ah yes
|
14:18:34
|
<bwolfe> that looks more right
|
14:18:37
|
<bwolfe> wyclif: how closely were you paying attention on the design call?
|
14:18:49
|
<wyclif> close enough
|
14:19:11
|
<bwolfe> heh, ok
|
14:19:25
|
<bwolfe> I need to modify OCC-70
|
14:19:36
|
<wyclif> ok
|
14:19:51
|
<bwolfe> instead of a "link_type" column, there should be a "similar_concepts" table. and concept.link_id is for all EXACT mappings only
|
14:20:08
|
<bwolfe> the similar concepts table should be many to many
|
14:20:59
|
<wyclif> ok
|
14:22:23
|
<wyclif> but from the design call, i still couldn't how different similar concepts will be from concet mappings
|
14:22:47
|
<bwolfe> concept_mappings are for concepts to SNOMED or ICD-9, or LOINC
|
14:22:51
|
*** surangak has quit IRC
|
14:23:03
|
<bwolfe> but linkages (similar concepts) are from concept to concept
|
14:23:07
|
<wyclif> ok
|
14:23:30
|
<bwolfe> and at tehse early stages of the occ, it will mean that they were once linked exactly but now had some edits and so are just "similar"
|
14:23:45
|
<bwolfe> or if someone copies a copy that is similar, they are both similar
|
14:23:49
|
<wyclif> ok
|
14:24:04
|
<wyclif> i will revisit the ticket today
|
14:24:15
|
<wyclif> bwolfe, , i saw your comment for occ-33, i just have to uncomment the listener i added in the applicaton contextc
|
14:24:46
|
<bwolfe> wyclif: ok, how does the listener prevent the dupes?
|
14:25:21
|
<r-friedman> bwolfe: tks got it
|
14:25:52
|
<wyclif> the listener also prevents dupes, when i leave everything else unchanged before any of my changes
|
14:26:03
|
<bwolfe> r-friedman: which class?
|
14:26:34
|
<bwolfe> ok, see if you can find the commit/reason/ticket that they did that before
|
14:26:38
|
*** jportela has joined #openmrs
|
14:26:38
|
*** ChanServ sets mode: +v jportela
|
14:26:39
|
<r-friedman> DatabaseUtil.loadDatabaseDriver
|
14:26:56
|
*** jportela has left #openmrs
|
14:27:08
|
<bwolfe> and if it looks like that is fixed for some reason, you can leave the code changed as you did. otherwise just use your listener.
|
14:27:21
|
<wyclif> ok
|
14:27:21
|
<bwolfe> wyclif++ for having two solutions at the ready :-D
|
14:27:40
|
<bwolfe> r-friedman: ah yes, ok, that sounds about right
|
14:27:55
|
<bwolfe> my update
|
14:27:58
|
<bwolfe> today:
|
14:27:58
|
<bwolfe> got 1.6.3 and 1.7.2 into mavenrepo properly
|
14:27:58
|
<bwolfe> fixed some unit tests in occmodule
|
14:27:58
|
<bwolfe> reviewed one of jeremy's tickets on trunk
|
14:27:58
|
<bwolfe> had design review
|
14:27:59
|
<bwolfe> will have design call(s) tonight
|
14:28:01
|
<bwolfe> tomorrow:
|
14:28:03
|
<bwolfe> more of the same
|
14:29:03
|
<dkayiwa> any blockers bwolfe?
|
14:29:46
|
<bwolfe> negatory
|
14:29:57
|
<dkayiwa> ok good. :)
|
14:31:48
|
<wyclif> while working on occ-33 yesterday, i noticed a couple of strange things, e.g the equals methods for occ objects
|
14:32:13
|
<wyclif> it wasn't clear to me why they are the way they are
|
14:33:11
|
<wyclif> and also i don't understand why we have columns that seem to be always null, they won't these cause alot of redundancy
|
14:34:29
|
<wyclif> and i assumed objects like concept source(Data) need to have a source solumn to know which source uploaded them
|
14:34:56
|
<bwolfe> concept_source IS the source
|
14:35:27
|
<bwolfe> although things like SNOMED mgiht be nice to know of the original uploader...but thats a very small use case
|
14:35:49
|
<bwolfe> which colums are always null?
|
14:36:03
|
<bwolfe> the equals are like that so that concepts can be compared on value instead of concept id, iirc
|
14:36:15
|
<wyclif> bwolfe, the id columns e.g conceptSourceId
|
14:36:26
|
<wyclif> are always null
|
14:37:28
|
<bwolfe> those would be the concept_source_id from the original uploader
|
14:37:37
|
<bwolfe> I don't actually see how thats useful
|
14:38:26
|
<wyclif> then why have it
|
14:38:58
|
<wyclif> but it seems like the equals methods are using these ids
|
14:39:36
|
<djazayeri> Interjecting without really knowing what you're talking about, but...
|
14:39:37
|
<wyclif> i ran into a couple of issues with these equals methods
|
14:39:48
|
<djazayeri> .equals should really just do comparison based on uuid
|
14:40:00
|
<djazayeri> (at least that's the change we just made in core)
|
14:40:19
|
<wyclif> i think the equals methods on the server should depend on the occMyObjectId and not myObjectId
|
14:40:28
|
<wyclif> or uuid
|
14:40:37
|
<wyclif> djazayeri, thanks
|
14:41:02
|
<wyclif> for now uuids are not getting to the server, and there is a ticket for this
|
14:41:28
|
<wyclif> but +1 for uuids
|
14:41:42
|
*** upul` has joined #openmrs
|
14:41:42
|
*** ChanServ sets mode: +v upul`
|
14:41:50
|
<djazayeri> Does the row on the server have a uuid column?
|
14:42:13
|
<wyclif> nope
|
14:42:31
|
<djazayeri> can you use the (integer?) primary key instead, for the equality check?
|
14:43:02
|
<wyclif> bwolfe, djazayeri can you look at ConceptSource.equals() and let me know if it looks right to you
|
14:43:21
|
<djazayeri> is this .equals supposed to be checking _identity_ (i.e. is it the same row?) or business equality?
|
14:43:26
|
<djazayeri> wyclif: in core? or on the server side?
|
14:43:34
|
<wyclif> occ server
|
14:43:43
|
<djazayeri> don't have code checked out, hold on
|
14:44:20
|
<bwolfe> wyclif: ok, I guess I'm misremembering what the equals was doing. if it was not using occ____id, then thats a problem.
|
14:44:24
|
<wyclif> i see as though the developer copied alot of the code from trunk and never changed some bits
|
14:44:41
|
<bwolfe> wyclif: conceptsource.equals in the server is wrong
|
14:44:43
|
<bwolfe> good catch
|
14:44:54
|
<bwolfe> thats probably a copy/paste problem when they were updating it to work with 1.8
|
14:44:56
|
<bwolfe> err 1.7
|
14:45:04
|
<wyclif> and all the other are like that
|
14:46:17
|
<wyclif> i spent alot of time trying to fix occ-33 and i noticed this was also partly a problem
|
14:47:59
|
<wyclif> bwolfe, all equals and hashcode methods on the server are then wrong
|
14:49:09
|
<bwolfe> wyclif: that .equals problem could actually be why it was duplicating (although I can't think up the scenario of HOW in my head)
|
14:49:15
|
<bwolfe> wyclif: ALL??
|
14:49:22
|
<bwolfe> shisters
|
14:49:27
|
<bwolfe> sheisters
|
14:49:39
|
<wyclif> bwolfe, what does that mean?
|
14:49:52
|
<bwolfe> means thats bad
|
14:49:57
|
<wyclif> ok
|
14:50:00
|
<bwolfe> fix that asap, would you? :-)
|
14:50:05
|
<wyclif> sure
|
14:50:24
|
<wyclif> bwolfe, djazayeri, now does it make sense to drop the myObjectId columns?
|
14:50:50
|
<bwolfe> wyclif: those are still needed on concept at least
|
14:51:08
|
<bwolfe> the uuid can be used in place of anythign with the myObjectIds did before
|
14:53:29
|
<wyclif> bwolfe, i still think Data besides MetaData on the server needs an origin source id
|
14:53:31
|
*** magoo_ has quit IRC
|
14:53:55
|
<bwolfe> wyclif: huh?
|
14:55:17
|
<wyclif> because one of the mistakes i noticed, the original developers mixed these up a little i.e the concept_source_id and the implemenation source id
|
14:56:07
|
<wyclif> or i was mixing them up, so i just wanted to have them defined well
|
14:57:48
|
<dkayiwa> bwolfe: is the server's receiving end for "Send All Concepts To OCC" working?
|
14:57:58
|
<wyclif> dkayiwa, not for me
|
14:58:07
|
<wyclif> it sends some and never all
|
14:58:20
|
<dkayiwa> bwolfe: am sending concepts to occ and i get "Concepts uploaded successfully!"
|
14:58:27
|
<dkayiwa> but i do not see them at the server
|
14:58:38
|
<dkayiwa> wyclif: do some of yours get sent succesfully?
|
14:59:00
|
<wyclif> dkayiwa, the server has a timer, so it doesn't take place immediately
|
14:59:10
|
<dkayiwa> oh i see
|
14:59:20
|
<wyclif> dkayiwa, if you wait for about 30sec,it should
|
14:59:32
|
<dkayiwa> wyclif: i have waited for more than minutes
|
14:59:56
|
<dkayiwa> wyclif: aren't they supposed to go into the concept table on the server?
|
14:59:57
|
<wyclif> dkayiwa, can you confirm of all your concepts get uploaded because mine were not
|
15:00:09
|
<wyclif> dkayiwa, correct
|
15:00:23
|
<dkayiwa> wyclif: client claims to have sent succefully, but server tables are empty
|
15:00:44
|
<wyclif> can you check your /tmp/uploads folder
|
15:01:02
|
<dkayiwa> wyclif: the xml files are still there
|
15:01:13
|
<dkayiwa> wyclif: are they supposed to be deleted?
|
15:01:19
|
<wyclif> dkayiwa, by the way, i also noticed that if an error occur, the module doesn't inform the user
|
15:01:46
|
<wyclif> forinstance if the server is down, it doesn't say so
|
15:02:00
|
<wyclif> but in the logs, you see the error
|
15:02:18
|
<wyclif> dkayiwa, did you set the global property for the server url?
|
15:02:34
|
<wyclif> and ensure the server was properly started
|
15:02:48
|
<dkayiwa> oh i see
|
15:02:56
|
*** bwolfe_ has joined #openmrs
|
15:02:56
|
*** ChanServ sets mode: +o bwolfe_
|
15:03:07
|
<dkayiwa> wyclif: i set the server url
|
15:03:13
|
<wyclif> hmm
|
15:03:20
|
*** bwolfe has quit IRC
|
15:03:26
|
<dkayiwa> wyclif as http://localhost:8080/occ
|
15:04:34
|
<wyclif> hmmm, and are the xml file getting created in the /tmp/uploads folder
|
15:04:41
|
<dkayiwa> wyclif: yes
|
15:04:53
|
*** bwolfe has joined #openmrs
|
15:04:53
|
*** ChanServ sets mode: +o bwolfe
|
15:04:56
|
<wyclif> and are there are no errors in the logs?
|
15:05:31
|
<dkayiwa> wyclif: no errors in the logs
|
15:05:44
|
*** bwolfe_ has quit IRC
|
15:05:54
|
*** pascal` has quit IRC
|
15:06:28
|
<dkayiwa> wyclif: may be i should try run the module in debug mode and see what its doing :)
|
15:06:38
|
<wyclif> try clearing the /tmp/uploads folder and restart the occ server
|
15:07:27
|
<dkayiwa> wyclif: every time is sync, it creates a new xml file in tmp/uploads
|
15:07:33
|
<dkayiwa> wyclif: ok let me do that
|
15:07:37
|
<wyclif> yeah
|
15:16:37
|
*** dkayiwa has quit IRC
|
15:23:07
|
<djazayeri> downeym: do you care about the text of the TW blurb I looped you in on?
|
15:30:06
|
*** asgoyal has joined #openmrs
|
15:31:10
|
<downeym> i really am not privy to their role, so yeah i guess i'm fine :)
|
15:31:55
|
<djazayeri> downeym: Their description of their role is fine. Wondering if you care about the phrasing of the OpenMRS part.
|
15:32:37
|
<djazayeri> (Wondering if you even careâjust that they specifically asked me if it's okay, rather than just doing it, so I figured I'd go through you.)
|
15:33:42
|
<downeym> i'm ok with it :)
|
15:34:00
|
<djazayeri> should I bother to refer such things to you in the future?
|
15:35:17
|
*** djazayeri has left #openmrs
|
15:35:24
|
*** djazayeri has joined #openmrs
|
15:35:24
|
*** ChanServ sets mode: +o djazayeri
|
15:39:01
|
*** pascal` has joined #openmrs
|
16:09:39
|
*** chopin has joined #openmrs
|
16:14:07
|
*** downeym has quit IRC
|
16:14:12
|
*** downeym has joined #openmrs
|
16:14:12
|
*** ChanServ sets mode: +o downeym
|
16:14:12
|
*** OpenMRSBot sets mode: +o downeym
|
16:17:47
|
*** bwolfe has quit IRC
|
16:20:52
|
*** upul` has quit IRC
|
16:23:55
|
*** lh has joined #openmrs
|
16:41:13
|
<wyclif> djazayeri, i have been looking at how the implementation sources/concept sources handled and i think it is wrong
|
16:41:15
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): backporting TRUNK-2508 to branches/1.8.x - replacing dojo references in openmrs.js <http://feedproxy.google.com/~r/OMRStrunk/~3/Ci7i1ZfF0A4/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2508 - replacing dojo references in openmrs.js <http://feedproxy.google.com/~r/OMRStrunk/~3/y5-gzZ6scQQ/OpenMRS>
|
16:41:52
|
<djazayeri> wyclif: okay, I'm still not up to speed on this sprint, so you'll have to lead me through this from the beginning.
|
16:46:21
|
<wyclif> djazayeri, basically there is an implemenation source i.e the one that is registered with the occ server and then there is a concept source defined in an implemenattion, according to the current code, these 2 are treated more less the same since they are stored in the dame table
|
16:46:21
|
<wyclif> same table
|
16:46:46
|
<djazayeri> let me check out the occ server code, hold on
|
16:47:16
|
<djazayeri> wyclif: is that mavenized? do I checkout from SVN? Or checkout maven project from SCM?
|
16:47:46
|
<wyclif> maven
|
16:47:47
|
<wyclif> so the relationship between a user and an implementation source and a user is many to
|
16:47:58
|
<wyclif> ignore my last message
|
16:48:06
|
<wyclif> djazayeri, it is mavenized
|
16:49:15
|
<djazayeri> okay
|
16:49:37
|
<djazayeri> so, there's a user, e.g. someone who can log in
|
16:49:50
|
<djazayeri> and they're affiliated with one or many implementations
|
16:49:58
|
<djazayeri> where's the sqldiff?
|
16:50:17
|
<wyclif> this difference comes in when defining a user who registered the implementation source with the server and the other users added in the users table because they created a concept source in their installation
|
16:51:23
|
<wyclif> it is under occ/src/main/resources/occ-1.7.x.sql
|
16:51:36
|
<djazayeri> thanks
|
16:52:26
|
<wyclif> so my point is that, we should draw a line between a user who registers an implemenatation and a a user defined in an implementation
|
16:52:28
|
<wyclif> OR
|
16:52:54
|
<wyclif> we should draw a line between an implementation source and a concept source in an installation
|
16:53:15
|
<djazayeri> so, I only 25% understand this but...
|
16:53:29
|
<wyclif> because all these users are stored in the same table and all the sources are stored in the same table
|
16:54:02
|
<wyclif> meaning when mapping the files in hibernate, it will ibvalid to set things like many-to-one or one-to-many
|
16:54:28
|
<wyclif> since it depends on what user or what implementation is under consideration
|
16:54:30
|
<djazayeri> definitely there should be a distinction between (1) an implementation-source, which is the thing that uploads concepts to OCC, (2) a reference-source, i.e. concept_source in the openmrs api
|
16:55:07
|
<wyclif> this is the main cause for a couple of bugs and hacks in the occ server
|
16:55:13
|
<djazayeri> It seems to me like a user should be able to belong to multiple sources...
|
16:55:53
|
<djazayeri> do you have the server installed?
|
16:56:00
|
<wyclif> yes
|
16:56:06
|
<djazayeri> rather: can you produce a data model diagram for it, from some mysql tool?
|
16:56:19
|
<djazayeri> or does that exist already?
|
16:58:32
|
<wyclif> djazayeri, i have mysql query browser, not he work bench
|
16:58:37
|
<djazayeri> hmm, okay
|
17:00:02
|
<djazayeri> are multiple users allowed to upload concepts to the same implementation?
|
17:00:41
|
<wyclif> djazayeri, if they are admins i guess
|
17:01:44
|
<djazayeri> wyclif: so, I agree with you that we need to split "concept source" into implementation vs reference sources
|
17:01:50
|
<djazayeri> and those should definitely be two tables
|
17:02:00
|
<djazayeri> I don't understand why we need to split users.
|
17:06:25
|
<wyclif> if we split sources, then no need to split users
|
17:09:33
|
<wyclif> djazayeri, the only problem is that the association type between users and sources would conflict if you wish to have a user from multiple implemenation
|
17:09:44
|
<wyclif> since the association type is many to one
|
17:10:01
|
<djazayeri> wyclif: to clarify, does OCC server actually just have one concept_source table which holds both "Darius's Laptop" and "SNOMED"?
|
17:10:17
|
<djazayeri> (and isn't there a ticket about this?)
|
17:44:13
|
<wyclif> yeah
|
17:44:45
|
<wyclif> not sure
|
17:46:34
|
<wyclif> djazayeri, i need to change all equals and hashcode methods on the server, should i create a ticket for this?
|
17:47:00
|
<wyclif> i recall we said it is not good to add tickets to a sprint
|
17:48:26
|
<djazayeri> wyclif: you should add a ticket for this
|
17:48:34
|
<wyclif> ok
|
17:48:40
|
<djazayeri> the idea is that it's not a good idea to add new _deliverables_ to a sprint
|
17:48:52
|
<djazayeri> if you need additional tickets to accomplish the pre-existing deliverable, that's fine
|
17:49:02
|
<wyclif> ok
|
17:50:51
|
*** bwolfe has joined #openmrs
|
17:50:51
|
*** ChanServ sets mode: +o bwolfe
|
18:15:13
|
*** jportela has joined #openmrs
|
18:15:13
|
*** ChanServ sets mode: +v jportela
|
18:15:54
|
*** downeym_ has joined #openmrs
|
18:15:54
|
*** ChanServ sets mode: +o downeym_
|
18:18:35
|
*** downeym has quit IRC
|
18:18:35
|
*** downeym_ is now known as downeym
|
18:23:20
|
*** jportela has quit IRC
|
18:31:08
|
*** dkayiwa has joined #openmrs
|
18:38:17
|
*** jportela has joined #openmrs
|
18:38:17
|
*** ChanServ sets mode: +v jportela
|
18:39:33
|
*** jportela has quit IRC
|
18:41:08
|
*** jportela has joined #openmrs
|
18:41:08
|
*** ChanServ sets mode: +v jportela
|
18:41:48
|
*** jportela has left #openmrs
|
19:04:04
|
*** jportela has joined #openmrs
|
19:04:04
|
*** ChanServ sets mode: +v jportela
|
19:09:54
|
*** james_regen has quit IRC
|
19:26:24
|
*** jportela has quit IRC
|
19:27:04
|
*** jportela has joined #openmrs
|
19:27:04
|
*** ChanServ sets mode: +v jportela
|
19:37:15
|
*** jportela has quit IRC
|
19:39:02
|
*** bryq has joined #openmrs
|
19:39:02
|
*** ChanServ sets mode: +v bryq
|
19:42:09
|
<wyclif> bwolfe, hi
|
19:42:45
|
<wyclif> djazayeri, hi
|
19:43:02
|
<djazayeri> hi
|
19:43:17
|
<bwolfe> hi...
|
19:43:21
|
<chopin> hi
|
19:43:32
|
<chopin> i can't find this topic on the wiki, so here goes.
|
19:43:34
|
<wyclif> bwolfe, djazayeri, am rewriting all the equals and hashcode methods, did we decide on using uuid or the respective occ ids
|
19:43:51
|
<djazayeri> i'm going to let bwolfe answer that
|
19:44:01
|
<djazayeri> is there even a uuid column though?
|
19:44:08
|
<bwolfe> uuid is probably better. but you need to finish the occ ticket where the uuids are passed from module to occserver
|
19:44:19
|
<wyclif> there is a ticket suggesting uuids
|
19:44:24
|
<wyclif> to get added
|
19:44:33
|
<chopin> I'm trying to run JUnit tests on a 1.7.x-compatible branch of formentry. I compiled and included the 1.7.2 jars from the 1.7.2 tag, and I'm still running into ClassNotFound errors (in eclipse) trying to load a context sensitive junit test.
|
19:44:44
|
<chopin> anyone know how to fix this / where the fix is?
|
19:45:16
|
<wyclif> and it would make life easier since i would only have to override equals in the BaseOpenmrsObject
|
19:45:34
|
<wyclif> and get rid of the individual ones
|
19:47:02
|
<wyclif> bwolfe, djazayeri am noticing there is a dependency issue about tickets in occ and i have a feeling some tickets will get resolved partly by others
|
19:47:35
|
<wyclif> because almost each ticket i try to do ends up leading me to another that has to be done first
|
19:48:00
|
<wyclif> so i might have to fall back to fix setting of uuids
|
19:54:14
|
<dkayiwa> wyclif: my occ server fails with a NPE while processing the file
|
19:54:42
|
<dkayiwa> but the exception is not output in the logs
|
19:59:00
|
*** r-friedman has quit IRC
|
20:00:05
|
<bwolfe> chopin: look at the module unit testing wiki page
|
20:00:07
|
<bwolfe> in the FAQs
|
20:01:30
|
*** asgoyal has quit IRC
|
20:01:59
|
<chopin> mmkay
|
20:04:35
|
*** downeym_ has joined #openmrs
|
20:04:42
|
*** ChanServ sets mode: +o downeym_
|
20:05:16
|
*** jportela has joined #openmrs
|
20:05:16
|
*** ChanServ sets mode: +v jportela
|
20:08:34
|
*** downeym has quit IRC
|
20:08:34
|
*** downeym_ is now known as downeym
|
20:17:25
|
*** jportela has quit IRC
|
20:21:34
|
*** jportela has joined #openmrs
|
20:21:34
|
*** ChanServ sets mode: +v jportela
|
20:29:08
|
*** Suranga has joined #openmrs
|
20:29:50
|
*** jportela has quit IRC
|
20:31:25
|
*** jportela has joined #openmrs
|
20:31:25
|
*** ChanServ sets mode: +v jportela
|
20:36:26
|
<dkayiwa> bwolfe: ConceptName.isLocalePreferred() returns null and hence i get a NPE when processing concept uploads. The NPE is in file Concept.java line 1158. So should i just change ConceptName.isLocalePreferred() from "return localePreferred" to "return localePreferred == null ? false : localePreferred"?
|
20:37:15
|
<bwolfe> in openmrs core?
|
20:37:35
|
<dkayiwa> bwolfe: no
|
20:37:41
|
<dkayiwa> bwolfe: in org.openmrs.occ.model
|
20:37:43
|
<bwolfe> rafal had this same problem with MDS and people trying to import things from wrong versions
|
20:37:44
|
<bwolfe> oh
|
20:37:48
|
<bwolfe> ok, then yes
|
20:38:34
|
<dkayiwa> bwolfe: and the error was not even put in the logs. i guess its to do with logger config
|
20:38:58
|
<dkayiwa> i only got it when tried to debug
|
20:39:41
|
<bwolfe> interesting
|
20:39:53
|
<bwolfe> so xstream was silently skipping it?
|
20:40:09
|
<dkayiwa> xstream was doing its work correctly without failing
|
20:40:36
|
<dkayiwa> it is the method Concept.addName() which was failing
|
20:41:04
|
<dkayiwa> so all i saw was that my upload files were never processed and error log had nothing
|
20:43:11
|
*** chopin has quit IRC
|
20:43:53
|
<bwolfe> weird
|
21:06:28
|
<Suranga> hello djazayeri r u around :-)
|
21:08:56
|
*** r0bby has joined #openmrs
|
21:08:56
|
*** ChanServ sets mode: +v r0bby
|
21:11:02
|
*** jeff__ has joined #openmrs
|
21:11:07
|
<downeym> Hi jeff__ and welcome to the #openmrs IRC channel.
|
21:11:21
|
*** gbastien has quit IRC
|
21:11:24
|
<jeff__> Hi, Thanks.
|
21:11:40
|
*** bryq1 has joined #openmrs
|
21:12:14
|
*** bryq has quit IRC
|
21:12:21
|
<djazayeri> hi Suranga, I'm around, but waiting to do a skype call with someone
|
21:12:28
|
<jeff__> does openMRS support inbound HL7 messages from an Interface engine like Mirth ?
|
21:12:29
|
<djazayeri> (so I can talk now, but may disappear quickly)
|
21:12:58
|
<djazayeri> jeff__: OpenMRS supports ADT-A28 and ORU-R01 messages.
|
21:13:00
|
<Suranga> djazayeri, sure, no problem, I just wanted to tell u i had commentd on TRUNK-2483
|
21:13:10
|
<djazayeri> you'd need to put them in the hl7 queue
|
21:13:20
|
*** batkinson has joined #openmrs
|
21:13:21
|
<Suranga> djazayeri, actually im discribing how om gonna fix somthing
|
21:13:34
|
<djazayeri> jeff__: which can be done through the API, and I believe also through an HTTP POST.
|
21:13:40
|
<djazayeri> and soon, through web services
|
21:13:51
|
<djazayeri> how would mirth send the message?
|
21:14:48
|
<Suranga> djazayeri, so maybe if you're free, u could take a look at it, no hurry, because im going off (its pretty late here) I wont be back for 6-7 hours :P
|
21:15:18
|
<jeff__> i am not sure how it would send the messages. i am new to all of this stuff. i think it can send hl7 messages on a socket if the EMR can listen on that port
|
21:17:39
|
<bwolfe> !hl7
|
21:17:40
|
<OpenMRSBot> bwolfe: "hl7" --- Read about HL7 at https://wiki.openmrs.org/display/docs/HL7
|
21:18:46
|
*** lh has quit IRC
|
21:21:34
|
*** dkayiwa has quit IRC
|
21:26:26
|
<jeff__> are there examples of how to use the HL7 import API anywhere ?
|
21:27:52
|
<djazayeri> jeff__: not sure. The API method would be HL7Service.saveHL7InQueue
|
21:28:02
|
*** gbastien has joined #openmrs
|
21:28:19
|
<djazayeri> you can see an example of a call to it (written ~5 years ago, so I don't promise it's still working) in org.openmrs.web.controller.remotecommunication.PostHl7Controller
|
21:28:31
|
<djazayeri> (you can search for that via source.openmrs.org
|
21:29:04
|
*** r0bby is now known as robbyoconnor
|
21:29:27
|
<jeff__> thanks. this will be a very dumb question but what language to you need to program in to use the API ?
|
21:29:59
|
<djazayeri> java
|
21:30:29
|
*** robbyoconnor has quit IRC
|
21:30:33
|
*** r0bby has joined #openmrs
|
21:30:33
|
*** ChanServ sets mode: +v r0bby
|
21:31:00
|
*** gbastien has quit IRC
|
21:31:35
|
*** r0bby has quit IRC
|
21:31:41
|
<jeff__> so do i have to write a java app to build an hl7 msg then call the API ? are there tools to help build the hl7 msg ?
|
21:31:53
|
*** r0bby has joined #openmrs
|
21:31:53
|
*** ChanServ sets mode: +v r0bby
|
21:32:02
|
<djazayeri> jeff__: what are you actually trying to do? e.g. who is actually sending the hl7 message?
|
21:33:55
|
*** Suranga has quit IRC
|
21:33:56
|
<jeff__> i am trying to build an app that takes a reading from a device such as a blood pressure or glucose monitor and sends the information to an EHR/EMR system.
|
21:34:08
|
*** r0bby is now known as robbyoconnor
|
21:34:56
|
<djazayeri> jeff__: actually, turns out that this is already do-able with our alpha web services module
|
21:34:59
|
<djazayeri> https://tickets.openmrs.org/browse/RESTWS-138
|
21:36:33
|
<djazayeri> So you'd be able to do something like an HTTP POST to (server)/ws/rest/hl7 with a payload like { "message": "KLJSDF||||SDF|S|DF|||||S|DF|S|F" }, and basic authentication
|
21:36:45
|
<djazayeri> I'd try that approach first.
|
21:39:32
|
<jeff__> forgive my ignornance as this is all brand new to me, i have not even downloaded or installed openMRS yet. what is the text in double quotes "KLJSDF.....an HL7 message ?
|
21:39:40
|
<djazayeri> yes
|
21:39:53
|
<djazayeri> (not actually a legitimate one, sorry, I copied that from the ticket)
|
21:41:27
|
<jeff__> so it seems what i need to do is pretty straightforward. if i just download and install openMRS will that capability be there ?
|
21:41:40
|
<djazayeri> you'd also need to install the web services module
|
21:42:19
|
<djazayeri> you can find a (large download) standalone version containing that here: https://wiki.openmrs.org/x/xoAaAQ
|
21:42:32
|
<djazayeri> but what specific hl7 messages are you sending?
|
21:42:59
|
<djazayeri> you'd also need to create concepts with mappings to the appropriate terminologies
|
21:43:22
|
<jeff__> where can i learn about that ?
|
21:44:22
|
<djazayeri> look here, and at its child pages: https://wiki.openmrs.org/x/b4Ns
|
21:45:01
|
<jeff__> this all sounds pretty complex....is it pretty hard to do requiring a lot of specific knowledge about openMRS ?
|
21:45:16
|
<djazayeri> well, it's inherent in any EHR system
|
21:45:32
|
<djazayeri> the system itself has a terminology
|
21:45:58
|
<djazayeri> and the device uses some other terminology
|
21:46:08
|
<djazayeri> so you need to be able to map those terminologies
|
21:46:28
|
<djazayeri> do you know what the hl7 messages outputted from the BP device look like
|
21:46:28
|
<djazayeri> ?
|
21:48:04
|
<jeff__> it is not an hl7 msg that is output. it follows a format defined by IEEE 11073. my app will be extracting the value and have to create the hl7 message,or something else that can be converted to an hl7 msg
|
21:49:07
|
<djazayeri> I see. In this case you don't necessarily need to use HL7 at all, if the goal is just to integrate specifically with 1 EHR (e.g. OpenMRS).
|
21:49:30
|
<djazayeri> you could just have your app use web services to create an encounter
|
21:49:37
|
<djazayeri> (with observations)
|
21:50:24
|
<djazayeri> more generally you _would_ want to use HL7 so you're not tied to one particular EHR.
|
21:51:24
|
<jeff__> thats sounds llike a good option. where can i learn about how to do that ? one of our requirements is to use hl7 for that very reason
|
21:51:58
|
<djazayeri> about hl7 in general? I'd google around.
|
21:54:53
|
<jeff__> no, about how to do what you suggested, using web services to create an encounter (i guess i have to do that terminolgy concept mapping no matter which way i go ?)
|
21:55:13
|
<djazayeri> Ah, those are OpenMRS-specific web services
|
21:55:26
|
<djazayeri> realize that this is completely alpha functionality
|
21:56:54
|
<djazayeri> see this page for details on how to get the module: https://wiki.openmrs.org/x/xoAaAQ
|
21:57:11
|
<djazayeri> and this page for the details of the API https://wiki.openmrs.org/x/P4IaAQ
|
21:57:53
|
*** bryq1 has quit IRC
|
22:07:21
|
*** wyclif has quit IRC
|
22:08:13
|
<jeff__> want to thank you 'djazayeri' for your help here. i am feeling a bit overwhelmed by all this new stuff. are there more examples of doing the post of the hl7 message (i guess that is what my app would have to do)
|
22:09:01
|
<djazayeri> jeff__: you're welcome. (I'm Dariusâone of the lead devs)
|
22:09:22
|
<downeym> jeff__: Hi there. Did you call in and write earlier today?
|
22:10:09
|
<jeff__> sounds like i am talking to the right guy ! yes i did. and i really really appreciate your assistance. i have been stuck for several days on how to proceed with my project.
|
22:10:56
|
<downeym> jeff__: Great. It sounds like you're already on the right track but let us know if you need further help or guidance getting started.
|
22:11:30
|
<djazayeri> jeff__: you can find an example hl7 message on our wiki somewhere
|
22:11:51
|
<downeym> https://wiki.openmrs.org/display/docs/HL7
|
22:12:31
|
<djazayeri> the piece that's going to differ for your use case is, for example where it says (in an OBX line)
|
22:12:33
|
<djazayeri> 5089^WEIGHT (KG)^DCT
|
22:12:59
|
<jeff__> some guidance getting started would be very very nice !
|
22:13:14
|
<djazayeri> you'd need to use "(snomed code for weight)^weight in kg^(hl7 code for snomed)" instead
|
22:13:46
|
<djazayeri> You'd need to have a weight-in-kg concept in the openmrs dictionary, and put a "mapping" to that snomed code on that concept
|
22:14:57
|
<djazayeri> you might want to ask a question on the openmrs implementers email list asking for more details.
|
22:16:55
|
<jeff__> so to get started i 1)download/install openmrs 2)enter the concept mapping in the dictionary, 3) write a small app that creates an hl7 msg and does the post ?
|
22:17:24
|
<djazayeri> yes
|
22:17:40
|
<djazayeri> it's possible that the packaged download on the rest webservices webpage already has concepts with mappings
|
22:22:48
|
<jeff__> thanks much. is there any special way i have to install, or configure openmrs after it is installed to be able to use the WebServices/Rest to post the hl7 ? and is there any other example i can look at for how to do the post of the hl7 msg ?
|
22:23:04
|
<djazayeri> look at the wiki page I sent a link to about the webservices.rest module
|
22:23:17
|
<djazayeri> it includes a link to a standalone distribution of openmrs
|
22:24:44
|
<jeff__> ok i have taken up enough of your time, i suppose it is time to jump in and start using it and get back with specific questions as they arise. thanks so much once again. do you always monitor this IRC or is there a better way to contact you ?
|
22:25:05
|
<djazayeri> irc, or the email lists
|
22:41:50
|
*** jportela has quit IRC
|
22:48:10
|
*** jportela has joined #openmrs
|
22:48:10
|
*** ChanServ sets mode: +v jportela
|
23:05:24
|
*** wyclif has joined #openmrs
|
23:25:46
|
<djazayeri> downeym: jira has been annoyingly slow for me today
|
23:26:15
|
<djazayeri> (transitioning an issue spins for 10+ seconds.)
|
23:26:33
|
*** jportela has quit IRC
|
23:26:44
|
<downeym> djazayeri: hm, all day?
|
23:26:51
|
<djazayeri> yeah
|
23:28:39
|
<downeym> djazayeri: it could be something network related that IU is still working on since the weekend
|
23:28:57
|
<downeym> i've been doing stuff with it this evening and haven't noticed any slowness, and the server looks ok
|
23:29:04
|
<djazayeri> okay, will complain again if it persists
|
23:29:08
|
<downeym> keep me posted
|