00:00:00
|
<wyclif> and the other question
|
00:00:26
|
<djazayeri> We will use a different mechanism (it's called something like RoleBasedPageMapper) to allow the sysadmin to map that when a certain role visits the page called "home" they see "dataClerkHomepage" instead.
|
00:00:52
|
<wyclif> ok
|
00:00:54
|
<wyclif> when i added an annotated class, am not sure if the framework is actually picking it
|
00:01:42
|
<djazayeri> is your class under org.openmrs.ui2 ?
|
00:02:04
|
<djazayeri> (that won't get picked up automatically, you'll have to rebuild and restart jetty)
|
00:02:25
|
<wyclif> when i map the table wrongly, say i specify a non existenct table, i the session factory wouldn't get set up due to this
|
00:02:31
|
<wyclif> yes it it
|
00:03:13
|
<djazayeri> So, what's the problem? The class isn't being seen?
|
00:04:03
|
<wyclif> i saw the custom SessionFactoryBean that you wrote and i noticed that as long as put it in that package it will find it but am not sure why it cant fail if i map it poorly
|
00:04:20
|
<djazayeri> hmm, that's odd.
|
00:04:27
|
<djazayeri> I would expect it to cause errors if you map it wrong
|
00:04:45
|
<wyclif> me too
|
00:10:38
|
*** r-friedman has quit IRC
|
00:19:26
|
<wyclif> djazayeri, i like your design of the DAO stuff where common operations CRUD methods are handled generically
|
00:20:15
|
<djazayeri> I got that idea from Fabiane at last year's implementers conference
|
00:20:45
|
<wyclif> wow! it cool, i don't why we never did this in the API
|
00:21:05
|
<djazayeri> woudl have required too much refactoring
|
00:21:11
|
<wyclif> yeah
|
00:21:28
|
<djazayeri> Since we already have EncounterService handlign Encounter, EncounterType, etc, it's problematic.
|
00:21:42
|
<wyclif> yeah
|
00:21:44
|
<djazayeri> though we could have hidden it at the DAO level
|
00:23:41
|
<wyclif> yeah, i now know why you named them SingleClassXXX
|
00:55:40
|
*** gbastien has joined #openmrs
|
01:01:18
|
*** yanokwa has quit IRC
|
01:01:43
|
*** yanokwa has joined #openmrs
|
01:01:43
|
*** ChanServ sets mode: +v yanokwa
|
01:05:56
|
*** yanokwa has quit IRC
|
01:06:10
|
*** wyclif has quit IRC
|
01:07:54
|
*** wyclif has joined #openmrs
|
01:08:43
|
*** wyclif has joined #openmrs
|
01:27:10
|
*** gbastien has quit IRC
|
02:45:50
|
<wyclif> djazayeri, who revised the login page
|
02:45:53
|
<deadpool> djazayeri: is there a way to do an openmrs core database search using a module without using the api?
|
02:46:12
|
<wyclif> djazayeri, in firefox it is floated to the left
|
02:46:25
|
<wyclif> djazayeri, not in the middle of the page
|
02:49:37
|
<deadpool> wyclif: i am looking at firefox and chrome i am getting the same thing
|
02:49:44
|
<deadpool> i don't see anything
|
02:49:50
|
<deadpool> this is the trunk right?
|
02:49:51
|
*** muthah has quit IRC
|
02:51:18
|
<wyclif> no
|
02:51:30
|
<deadpool> oh what are you using?
|
02:51:31
|
<wyclif> deadpool, this is the ui2-framework project
|
02:51:41
|
<deadpool> oh ok sorry my bad i will stop talking now
|
02:51:58
|
<wyclif> deadpool, , yes you can
|
02:52:17
|
<wyclif> add DAO stuff from a module
|
02:53:02
|
<deadpool> oh can i just load the pojo of lets say concept_drug and query it using those restrictions?
|
02:53:08
|
<wyclif> deadpool, you have to create and register your own services and DAOs in the module application context file
|
02:53:11
|
<deadpool> i won't get a mismatch session factory?
|
02:53:47
|
<wyclif> deadpool, i think you can get the DAO from the application context
|
02:54:18
|
<deadpool> yeah i have my dao with my pojo from my module but i wanted to do like a report for patients like when they were registered and stuff
|
02:54:30
|
<deadpool> so that would be searching by a specific date time
|
02:56:06
|
<wyclif> deadpool, autowire the applicationContext into your class and get the DAO from it
|
02:57:16
|
<wyclif> and then you can query the DAO and add execute your queries
|
03:11:19
|
<deadpool> wyclif: thanks will try that and see if that works
|
03:16:08
|
<djazayeri> wyclif: I moved the login page stuff around just for fun, but clearly I didn't test it out on different browsers.
|
03:16:12
|
<djazayeri> It looks cool on chrome though. :-)
|
03:22:55
|
*** upul` has joined #openmrs
|
03:22:55
|
*** ChanServ sets mode: +v upul`
|
03:23:21
|
<wyclif> ok
|
03:23:28
|
<wyclif> yeah i love it in chrome
|
03:54:15
|
*** surangak has joined #openmrs
|
04:11:51
|
*** mccallumg has joined #openmrs
|
04:11:51
|
*** ChanServ sets mode: +v mccallumg
|
04:12:07
|
<mccallumg> hi surangak
|
04:12:19
|
<surangak> mccallumg, helooo
|
04:12:57
|
<surangak> mccallumg, I've comitted working versions of our latest stuff
|
04:13:04
|
<mccallumg> surangak: is your presentation next week?
|
04:13:14
|
<surangak> mccallumg, nopz, 11th august
|
04:13:20
|
<surangak> mccallumg, two weeks :)
|
04:13:51
|
<mccallumg> surangak: ok. I'm ok with that.
|
04:14:22
|
<surangak> mccallumg, so we will have to prepare for it, like we did last time ...
|
04:14:42
|
<surangak> mccallumg, apparently network connection is th most serious problem everyone is having
|
04:15:18
|
<mccallumg> surangak: yeah. that's why we practiced before your first presentation. network problems are common.
|
04:16:03
|
<surangak> mccallumg, the stuff in my svn work, but there are some //TO DOs and cleaning up to do
|
04:16:18
|
<wyclif> djazayeri, how can i access a fragment param within a gsp?
|
04:16:19
|
<surangak> mccallumg, but the three refresh scenarios r working fine..
|
04:16:32
|
<mccallumg> surangak: good. Are we at the "no new feature" stage?
|
04:17:12
|
<surangak> mccallumg, sorry, dont get you... u mean we're not going to do any more featurs from this stage
|
04:17:30
|
<surangak> mccallumg, or that we;'re not going to change anything we did from now onwards ;-)
|
04:18:29
|
<mccallumg> surangak: I'm meaning. No new features.
|
04:18:51
|
<surangak> mccallumg, i think first we should to the major clean up of what we have
|
04:19:14
|
<surangak> mccallumg, put in the jquery, fine tune, check is we can remove ajax call etc.
|
04:19:31
|
<mccallumg> surangak: agreed
|
04:19:46
|
<surangak> mccallumg, following that, i'd really like to implement validation ( as in that mail on the dev list)
|
04:20:34
|
<surangak> mccallumg, plus darius had suggested that I maybe able to do away with one refresh scenario.. I need to check it out too
|
04:21:26
|
<mccallumg> surangak: I'd put validation at the very, very end. It isn't a priority for the summer. Clean documentation will be more important.
|
04:22:19
|
<surangak> mccallumg, aha, yep, thats another //TO DO - following latest addition of complexvalueKey and Text, will need to redo all that too :)
|
04:23:42
|
<mccallumg> surangak: good.
|
04:24:04
|
<surangak> mccallumg, i've also mailedd our mutual friend...awaiting reponse there too..
|
04:26:14
|
<mccallumg> surangak: Yeah, he's slow.
|
04:26:21
|
<mccallumg> surangak: ... to reply.
|
04:26:37
|
<surangak> mccallumg, :D
|
04:26:52
|
<surangak> mccallumg, fortunately I have 1.5 years to plan
|
04:27:11
|
<mccallumg> surangak: that sounds about right. You should have a reply by then.
|
04:27:33
|
<surangak> mccallumg, another small problem, afraid im going to be away from the keyboard over the weekend...
|
04:27:39
|
<surangak> mccallumg, family emergency
|
04:28:39
|
<surangak> mccallumg, ill be back as normal on monday....
|
04:28:57
|
<mccallumg> surangak: no problem. You're doing good work. Let me know if I can help ... from the other side of the world.
|
04:29:16
|
<surangak> mccallumg, you have been a great help already
|
04:29:38
|
<surangak> mccallumg, this friend of yours, is he a batch mate from victoria ?
|
04:30:28
|
<mccallumg> surangak: yes. He was doing his PhD while I did my MSc. We shared an office.
|
04:31:02
|
<surangak> mccallumg, wow, hes still at canada ? is he an achedemic now ?
|
04:31:33
|
<mccallumg> surangak: He's not a professor yet. He's working for a software company.
|
04:34:28
|
<surangak> mccallumg, anything that you wanted me to look into specifically ? with what I've been doing to complex obs ?
|
04:34:54
|
<mccallumg> surangak: no. things are going well.
|
04:35:53
|
<surangak> mccallumg, 60% of my work seems to be in design, 20 in development and 20 more in modifying :-)
|
04:36:11
|
<surangak> but thats how quality software is made, I guess
|
04:37:22
|
<mccallumg> surangak: not quite. 20% requirements. 20% design. 20%coding. 20% QA. 20% documentation.
|
04:37:40
|
<mccallumg> surangak: remember that in case it comes up in a job interview :)
|
04:38:04
|
<mccallumg> surangak: perhaps openmrs is heavier on the design phase ;)
|
04:38:17
|
<surangak> mccallumg, :-)
|
04:38:36
|
<surangak> mccallumg, over here we use agile
|
04:38:45
|
<surangak> mccallumg, we get storyboards
|
04:38:54
|
<mccallumg> surangak: cool.
|
04:39:16
|
<surangak> mccallumg, as long as it works, no questions asked :P
|
04:39:21
|
<mccallumg> surangak: I'm going to run. talk to you soon.
|
04:39:45
|
<surangak> mccallumg, sure, see you on monday ?
|
04:49:13
|
<mccallumg> surangak: monday - my time
|
04:49:29
|
<surangak> mccallumg, sure, will do
|
04:49:38
|
<mccallumg> surangak: bye
|
04:49:48
|
<surangak> mccallumg, bye, hav a nice day...
|
04:49:57
|
*** mccallumg has quit IRC
|
05:15:15
|
*** muthah has joined #openmrs
|
05:33:18
|
<djazayeri> wyclif: do you still need to know about fragment param in gsp?
|
05:33:36
|
<djazayeri> Should just be config.paramName
|
05:37:57
|
<wyclif> no thanks
|
05:38:28
|
<wyclif> but i will remember that when i need it
|
05:51:09
|
*** yanokwa has joined #openmrs
|
05:51:09
|
*** ChanServ sets mode: +v yanokwa
|
06:01:26
|
*** suho has joined #openmrs
|
06:01:26
|
*** ChanServ sets mode: +v suho
|
06:08:34
|
<surangak> IN case anyone missed this - Oracle Announces Availability of Java SE 7 : http://www.oracle.com/us/corporate/press/444374
|
06:11:43
|
<bwolfe> suho: yeah, not too many super awesome things in 7
|
06:11:51
|
<bwolfe> kind of like how 6 was...
|
06:14:07
|
*** rafa has joined #openmrs
|
06:14:07
|
*** ChanServ sets mode: +v rafa
|
06:15:10
|
*** finbrein has joined #openmrs
|
06:16:50
|
<surangak> surangak, at least its a start, from Oracles end, I suppose :)
|
06:21:43
|
*** pusakat has joined #openmrs
|
06:24:28
|
<bwolfe> surangak: are you talking to yourself again? ;-)
|
06:25:08
|
<surangak> bwolfe, sorry, i seem to be rather delirious :D
|
06:41:51
|
*** Yekkanti has joined #openmrs
|
07:23:30
|
*** rafa has quit IRC
|
07:32:16
|
*** suho has quit IRC
|
08:00:33
|
*** magoo has joined #openmrs
|
08:06:00
|
*** deadpool has quit IRC
|
08:09:40
|
*** rafa has joined #openmrs
|
08:09:42
|
*** ChanServ sets mode: +v rafa
|
08:34:05
|
<rafa> Hi bwolfe
|
08:34:16
|
<bwolfe> hey
|
08:34:42
|
<rafa> I need to edit a form
|
08:34:51
|
<rafa> org.springframework.beans.InvalidPropertyException: Invalid property 'xslt' of bean class [org.openmrs.Form]: Getter for property 'xslt' threw exception; nested exception is java.lang.reflect.InvocationTargetException
|
08:34:59
|
*** dkayiwa has joined #openmrs
|
08:35:08
|
<rafa> is what I get when I try to edit or add a completely new one
|
08:35:29
|
*** goutham has joined #openmrs
|
08:35:33
|
<rafa> It's a fresh installation of 1.9.x with demo data
|
08:35:38
|
<rafa> no modules installed
|
08:37:14
|
<rafa> bwolfe: have you ever seen that exception?
|
08:38:06
|
<bwolfe> rafa: thats a current bug, I think
|
08:38:11
|
<bwolfe> although I thought jeremy fixed it already
|
08:38:22
|
<bwolfe> search for that in jira and you'll find the forms ticket
|
08:38:39
|
<bwolfe> you can run a 1.8 openmrs against that same database and edit the form schema
|
08:39:46
|
<rafa> bwolfe: you're as always right :) https://tickets.openmrs.org/browse/TRUNK-2348
|
08:39:57
|
<rafa> bwolfe: ok, I'll try with 1.8
|
08:42:11
|
<magoo> hi every body a i have the following problem when i try to build the configuration i get the following message url http://pastebin.com/f2pUphvw
|
08:42:33
|
*** pusakat has quit IRC
|
08:43:41
|
<rafa> magoo: How did you invoke mvn?
|
08:43:50
|
<bwolfe> magoo: you need to do an "mvn install" at the root of the project
|
08:44:05
|
<bwolfe> this will call "mvn install" on the five subprojects in openmrs (api, web, tools, webapp, ??)
|
08:44:14
|
<magoo> okay
|
08:44:24
|
<bwolfe> when maven does an "install" it is packaging up the code and "installing" it into your local maven repository
|
08:44:49
|
<bwolfe> the "web" project expects there to be an "api" jar in your local repository in order to build
|
08:44:55
|
<magoo> okay
|
08:45:05
|
<bwolfe> so if you haven't done an "install" in your api project, the web project will not buidl
|
08:45:07
|
<magoo> let me rebuild
|
08:56:38
|
*** goutham has quit IRC
|
08:57:51
|
<Yekkanti> bwolfe: Hi Ben, I've looked into the webapp-testing failures. I've checked some possible scenarios it can fail in your machine.
|
08:58:34
|
<Yekkanti> bwolfe: I guess it would be that your target folders not getting cleaned (not sure)
|
08:58:39
|
*** muthah has quit IRC
|
08:59:18
|
*** muthah has joined #openmrs
|
08:59:25
|
<bwolfe> I remember doing an mvn clean many times. :-/
|
08:59:51
|
<bwolfe> and I remember deleting the test output dir manually one time when I saw some old GlobalProperty stories/tests in there
|
09:00:04
|
<Yekkanti> bwolfe: :) hmm
|
09:00:25
|
<Yekkanti> bwolfe: is it possible to revert the patch you've applied and run the tests
|
09:00:43
|
<Yekkanti> bwolfe: Just to make sure that is patch really causing problems
|
09:01:43
|
<bwolfe> I could...but if its running for you, thats proof enough that its me and not the patch :-)
|
09:02:08
|
<bwolfe> any ideas on what I can clean out of my mvn repo? is there a way for me to just delete jars for that run ?
|
09:02:24
|
<bwolfe> (I'm in kenya with low bandwidth, so I don't want to redownload a ton of jars)
|
09:05:22
|
<Yekkanti> bwolfe: Ohh! But i'm thinking that its not the external jar failures. According to the exception you've attached to the ticket it seems as a compilation error when running the release tests.
|
09:05:46
|
<Yekkanti> bwolfe: Is it possible to run the release tests once again now? after deleting the target folder manually?
|
09:06:02
|
<Yekkanti> bwolfe: I guess you are doing mvn clean from the project root
|
09:07:20
|
<bwolfe> yeah, from root
|
09:07:59
|
<bwolfe> how long are you around Yekkanti ?
|
09:08:20
|
<bwolfe> I need to run out. when I get back I can run the tests
|
09:08:26
|
<Yekkanti> bwolfe: I'll be here for another 3 hours
|
09:08:41
|
<Yekkanti> bwolfe: Ohh no problem i'll be on and off and available for another 8 hours
|
09:09:00
|
<bwolfe> Yekkanti: whats the ticket number again?
|
09:09:13
|
<Yekkanti> bwolfe: After 3 hours i'll take 2 hours break and continue for another 3 to 4 hours
|
09:09:16
|
<Yekkanti> bwolfe: https://tickets.openmrs.org/browse/APPTEST-48
|
09:10:01
|
<Yekkanti> bwolfe: Just for information its 2:40 PM(29th july) in india
|
09:10:03
|
<bwolfe> Yekkanti: ok, meanwhile, feel free to suggest or make any changes to releasetesting. there are a lot of tickets undone in APPTEST I think. :-)
|
09:10:13
|
<bwolfe> Yekkanti: you work strange hours. :-)
|
09:10:19
|
<bwolfe> (like me half the time I suppose)
|
09:10:24
|
<Yekkanti> bwolfe: :) yeah
|
09:12:54
|
*** yanokwa_ has joined #openmrs
|
09:12:54
|
*** yanokwa has quit IRC
|
09:17:38
|
*** surangak has quit IRC
|
09:17:49
|
*** surangak has joined #openmrs
|
09:27:10
|
*** bryq has joined #openmrs
|
09:27:10
|
*** ChanServ sets mode: +v bryq
|
09:38:04
|
*** robbyoconnor has quit IRC
|
09:38:55
|
*** robbyoconnor has joined #openmrs
|
09:38:55
|
*** ChanServ sets mode: +v robbyoconnor
|
09:55:50
|
<magoo> when i run a maven install i still get the following error message url http://pastebin.com/x0CvsgzB
|
10:11:46
|
<magoo> i still get the following message url http://pastebin.com/x0CvsgzB
|
10:31:32
|
*** magoo has quit IRC
|
11:27:16
|
*** james_regen has joined #openmrs
|
11:27:16
|
*** ChanServ sets mode: +v james_regen
|
11:38:19
|
*** bwolfe has quit IRC
|
12:12:39
|
*** Yekkanti has quit IRC
|
12:13:50
|
*** magoo has joined #openmrs
|
12:14:22
|
<magoo> can someone help about this url http://pastebin.com/x0CvsgzB
|
12:17:04
|
<surangak> hi magoo I took a look at it
|
12:17:15
|
<surangak> magoo, but afraid im out of ideas
|
12:17:27
|
<magoo> thx
|
12:17:45
|
<surangak> magoo, i could advise you to wait for a few hours, because ppl in the other time zones will be comming online
|
12:17:59
|
*** upul` has quit IRC
|
12:18:07
|
<surangak> magoo, maybe they could help with this..
|
12:18:25
|
<magoo> thanks surangak
|
12:18:38
|
<surangak> magoo, have u got yhe code checked out into an IDE, or are u using from the command prompt ?
|
12:19:18
|
<magoo> surangak: its checked out in the IDE
|
12:19:34
|
<surangak> does the IDE show u any errors ?
|
12:19:49
|
<surangak> magoo, webapp folder shows errrors, u can ignore that..
|
12:22:10
|
<magoo> surangak: you i should continue with maven configuration
|
12:22:36
|
<surangak> magoo, You have configured for maven, havent you ?
|
12:22:46
|
<magoo> yes
|
12:23:03
|
<magoo> sorry i was saying project configuration
|
12:23:26
|
<surangak> by project configuration u mean ?
|
12:24:18
|
<magoo> surangak: read this from the wiki page, To manage these configurations, right click the root project to bring up the context menu, select "Run as -> Run configurations...". Select the configuration under the Maven Build section.
|
12:24:49
|
<magoo> surangak: thats what i meant
|
12:26:05
|
<magoo> surangak: won't it be a risk to ignore the webapp for any future build and coding?
|
12:26:58
|
*** jriley has joined #openmrs
|
12:27:03
|
<surangak> magoo, i was worried about that too, but then I saw last comment at end of https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers
|
12:27:04
|
<OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org)
|
12:28:24
|
*** wyclif has quit IRC
|
12:37:42
|
*** Echidna has quit IRC
|
12:38:53
|
*** Echidna has joined #openmrs
|
12:38:53
|
*** ChanServ sets mode: +v Echidna
|
12:52:44
|
*** Yekkanti has joined #openmrs
|
12:57:07
|
*** muthah has quit IRC
|
13:02:13
|
<dkayiwa> djazayeri: are you awake?
|
13:07:52
|
<dkayiwa> hi rafa
|
13:08:04
|
<rafa> hi Daniel
|
13:08:38
|
<dkayiwa> rafa: is the metadatasharing modules now having its pages display well?
|
13:08:52
|
<rafa> dkayiwa: I can test
|
13:08:58
|
<rafa> dkayiwa: give me a minute
|
13:09:11
|
<dkayiwa> rafa: thanks so much. you will need to first update. :)
|
13:09:16
|
<rafa> dkayiwa: ok
|
13:10:24
|
*** Yekkanti has quit IRC
|
13:14:21
|
<rafa> dkayiwa: it still fails to load some resources
|
13:14:32
|
<dkayiwa> rafa: like?
|
13:15:30
|
<rafa> dkayiwa: "/openmrs2/scripts/jquery-ui/css/green/jquery-ui.custom.css", "/openmrs2/scripts/openmrsmessages.js?v=1.9.0.22029&locale=en_GB", and 9 more..
|
13:15:56
|
<dkayiwa> ok thanks
|
13:15:58
|
<rafa> you can easily test it if you download mds from the modules repository
|
13:16:11
|
<dkayiwa> let me do that now
|
13:16:11
|
<rafa> the page to access is module/metadatasharing/managePackages
|
13:16:20
|
<dkayiwa> ok thanks so much!!!
|
13:16:31
|
<rafa> dkayiwa: you're welcome
|
13:16:38
|
<dkayiwa> :)
|
13:16:58
|
<rafa> dkayiwa: it seems that you fixed some problems, because now it seems to be less resources missing
|
13:17:10
|
<dkayiwa> ok :)
|
13:19:00
|
*** surangak has quit IRC
|
13:20:23
|
*** bwolfe has joined #openmrs
|
13:20:23
|
*** ChanServ sets mode: +o bwolfe
|
13:23:07
|
<magoo> dkayiwa: still getting error messages url http://pastebin.com/3cVpcxsF
|
13:27:11
|
*** wyclif has joined #openmrs
|
13:31:17
|
<magoo> dkayiwa have u seen the url
|
13:31:21
|
*** gbastien has joined #openmrs
|
13:43:40
|
*** upul` has joined #openmrs
|
13:43:40
|
*** ChanServ sets mode: +v upul`
|
13:49:30
|
*** upul` has quit IRC
|
14:00:27
|
<wyclif> hi
|
14:01:24
|
<bwolfe> who's feeling scrummy?
|
14:02:02
|
<djazayeri> me!
|
14:02:21
|
<djazayeri> so, we're going to try google+ hangout again today
|
14:02:33
|
<djazayeri> let's see if we can get set up in just 5 minutes. :-)
|
14:02:40
|
<djazayeri> bwolfe, wyclif, dkayiwa, rafa
|
14:02:49
|
<wyclif> hi
|
14:02:56
|
<rafa> hi
|
14:03:01
|
<bwolfe> ha, yeah right :-p
|
14:03:19
|
<bwolfe> although I don't have a camera today
|
14:03:27
|
<bwolfe> well, I won't until my laptop comes back
|
14:03:36
|
<djazayeri> What happened to your laptop?
|
14:04:40
|
<bwolfe> the screen broke. so I sent it back to the us to get a warranty repair
|
14:04:49
|
<djazayeri> ah okay
|
14:06:44
|
<djazayeri> so...
|
14:07:03
|
<djazayeri> So, I feel so sad hanging out alone.
|
14:07:32
|
<djazayeri> rafal++
|
14:07:54
|
<bwolfe> its not showing up in my timeline...
|
14:08:07
|
<bwolfe> oh wait, do I have to go to yours?
|
14:08:14
|
* bwolfe is slow
|
14:08:37
|
<djazayeri> nah, maybe you weren't in my circle
|
14:10:05
|
<rafa> bwolfe, dkayiwa, wyclif were are you guys? :)
|
14:10:19
|
<bwolfe> @#&, need the plugin. sorry, forgot I hadn't loaded it up on this computer yet
|
14:10:33
|
<bwolfe> djazayeri: I just got the invite from you on gtalk
|
14:10:38
|
<djazayeri> dkayiwa, wyclif?
|
14:11:37
|
<wyclif> yesterday:
|
14:11:37
|
<wyclif> * TRUNK-2479, add data access layer for user defined pages
|
14:11:37
|
<wyclif> * Revisted TRUNK-2457 as per review comments
|
14:11:37
|
<wyclif> * Helped Ankur with trunk-2193 (User interface bit)
|
14:11:37
|
<wyclif> * Did partial work on the TRUNK-2480
|
14:11:38
|
<wyclif> today:
|
14:11:40
|
<wyclif> * Finish up with TRUNK-2480
|
14:11:42
|
<wyclif> * update documentation in https://wiki.openmrs.org/display/docs/OpenMRS+2.x+Developer+Documentation
|
14:11:49
|
<OpenMRSBot> <http://ln-s.net/91ex> (at wiki.openmrs.org)
|
14:11:49
|
<djazayeri> wyclif: we're trying to do a google+ hangout today
|
14:11:55
|
<wyclif> ok
|
14:12:01
|
*** asgoyal has joined #openmrs
|
14:13:42
|
<djazayeri> do you see my invite?
|
14:17:58
|
<djazayeri> wyclif, dkayiwa: are you there? do you see my invite? we're waiting for you.
|
14:28:40
|
*** Yekkanti has joined #openmrs
|
14:46:48
|
* bwolfe needs to find a usb mic. perhaps that works better
|
14:57:40
|
<rafa> djazayeri: you were right, I didn't look close enough at the form fields, they've got concepts
|
14:58:00
|
<rafa> it's just that there're plenty of them that are nulled
|
14:58:34
|
<rafa> ehs
|
14:59:11
|
<djazayeri> ah, right
|
14:59:12
|
<rafa> djazayeri: The only thing I miss now is the field name
|
14:59:21
|
<djazayeri> isn't there field.name?
|
15:01:12
|
<rafa> tableName and attributeName?
|
15:08:03
|
<Yekkanti> bwolfe: Any luck after running the release tests?
|
15:08:26
|
<bwolfe> Yekkanti: failed with some new error. I'm just getting some time now to just set it up on ci to see how it works
|
15:08:42
|
*** rafa has quit IRC
|
15:08:47
|
<bwolfe> kind of sucks that I won't be able to test locally...guess that gets me out of writing any more apptests/stories :-D
|
15:16:16
|
<Yekkanti> bwolfe: haha ;) Is it possible to ping or paste the error in pastebin
|
15:18:26
|
* bwolfe goes to run it again
|
15:20:35
|
*** Yekkanti has quit IRC
|
15:25:36
|
*** magoo has quit IRC
|
15:29:51
|
*** yanokwa_ has quit IRC
|
15:30:50
|
*** dkayiwa has left #openmrs
|
15:39:10
|
*** finbrein has quit IRC
|
15:39:21
|
*** gbastien has quit IRC
|
15:50:56
|
*** chopin has joined #openmrs
|
15:51:18
|
<chopin> hey y'all
|
15:52:06
|
<chopin> for TRUNK-2348, should i remove getXslt() and getTemplate() methods from Form.java or leave those in? (right now they attempt to get the xslt and template by calling the FormService)
|
15:53:47
|
*** magoo has joined #openmrs
|
15:54:37
|
<djazayeri> chopin: personally I think we get rid of those methods
|
15:54:49
|
<djazayeri> (deprecate them and have them return null, maybe)
|
15:55:16
|
<djazayeri> though, is there some reason why going through FormService to get resources fails?
|
15:55:39
|
<chopin> no, it doesn't fail ... but referring to form.xslt does
|
15:55:47
|
<chopin> (in JSP)
|
15:55:56
|
<bwolfe> form.xslt should call form.getXslt()...
|
15:56:00
|
<bwolfe> why is that failing?
|
15:56:25
|
<chopin> idk, it really shouldn't
|
15:56:32
|
* chopin looks more intently at the JSP
|
15:56:58
|
<djazayeri> We should just remove form.xslt from all core JSPs.
|
15:57:11
|
<bwolfe> chopin: yeah, you can remove/delte things from the web layer all you want
|
15:57:24
|
<bwolfe> but I'd rather just deprecate in the api objects
|
15:57:28
|
<bwolfe> and have them call the formservice for now
|
15:57:37
|
<djazayeri> +1
|
15:58:16
|
<chopin> ok, that's what i did before ... so i'll just remove references to xslt/template from the web and controllers
|
15:58:23
|
<djazayeri> yes
|
15:58:44
|
<djazayeri> Form Entry and XForms modules are going to need to provide the ability to manage those.
|
15:59:22
|
<chopin> yep, they have tickets for that
|
15:59:30
|
<bwolfe> right, thats fine
|
15:59:44
|
<bwolfe> I think theres been 2 people in the history of both that needed to change them via the web interface
|
15:59:50
|
<bwolfe> I was one and it was an accident
|
16:01:34
|
*** finbrein has joined #openmrs
|
16:02:38
|
<chopin> i was one and it was on purpose
|
16:02:53
|
<bwolfe> ok, mystery solved then!
|
16:02:56
|
*** muthah has joined #openmrs
|
16:15:26
|
*** magoo_ has joined #openmrs
|
16:15:50
|
*** magoo has quit IRC
|
16:16:33
|
*** chopin has quit IRC
|
16:19:04
|
*** rafa has joined #openmrs
|
16:19:04
|
*** ChanServ sets mode: +v rafa
|
16:21:00
|
<magoo_> i have failed to rectify the following errors url http://pastebin.com/pb8HMDvT kindly i need help
|
16:21:48
|
<djazayeri> magoo_: what JDK version do you have?
|
16:22:09
|
<magoo_> 1.6.0_26
|
16:22:30
|
<djazayeri> have you googled around for problems in Security.java?
|
16:22:34
|
<djazayeri> I haven't seen this before.
|
16:22:43
|
<magoo_> no
|
16:23:05
|
<djazayeri> I'd google around for maven xerces security.java
|
16:23:14
|
<djazayeri> maybe specifically for xercesImpl-2.8.0
|
16:25:44
|
*** wluyima has joined #openmrs
|
16:26:49
|
<wyclif> djazayeri, i think there is something you missed to add to to HibernateSessionFactoryBean
|
16:27:17
|
<wyclif> because for some reason, it can find my annotated calss but it doesn't validate it on startup
|
16:27:36
|
<djazayeri> no idea why that's happening
|
16:29:17
|
<rafa> wyclif: maybe it has something to do with hacky OverrideHibernateSessionFactory
|
16:29:51
|
<djazayeri> really we should make the change in the core openmrs api to allow JPA-annotated domain objects
|
16:30:17
|
<djazayeri> we wouldn't start using them in the core api, but it'd avoid the need for that hacky thing in 2.x.
|
16:30:58
|
<rafa> djazayeri: actually can't we override hibernate.cfg.xml?
|
16:31:51
|
<rafa> djazayeri: I was able to provide my own hibernate.default.properties maybe we can do the same for hibernate.cfg.xml
|
16:31:58
|
*** chopin has joined #openmrs
|
16:32:12
|
<djazayeri> perhaps we can, i didn't explore very much
|
16:32:40
|
<djazayeri> But I don't want to have to copy over anything and maintain parallel xml files, as new things are added to the api.
|
16:32:46
|
<rafa> djazayeri: anyway it's not necessarily the cause of wyclif's problem
|
16:33:09
|
<rafa> djazayeri: yeah, it's probably better the way it is
|
16:33:40
|
<rafa> regarding trunk-2206, can you answer to my comment?
|
16:33:42
|
<rafa> djazayeri
|
16:34:53
|
<djazayeri> rafa: the idea is that we should still have a "String UiUtils.format(Object)" that returns plain text.
|
16:35:16
|
<djazayeri> (basically what's currently formatAsText should become just format.
|
16:35:40
|
<djazayeri> and the logic that was in the html-ized version of format should go into fragments.
|
16:36:05
|
<rafa> djazayeri: but to do that I'll have to replace all ui.format to ui.includeFramget first, right?
|
16:36:36
|
<wyclif> djazayeri, i might know why
|
16:36:37
|
<djazayeri> Well, see how much work that will be
|
16:37:06
|
<rafa> djazayeri: maybe it's better that you look at my solution first, if it's what you meant
|
16:37:09
|
<djazayeri> I think that the current ui.format is used on very rarely
|
16:37:13
|
<rafa> djazayeri: and then I'll do the replacements
|
16:37:17
|
<djazayeri> okay, will do in a few minutes
|
16:37:21
|
<djazayeri> (gotta run for a sec)
|
16:37:36
|
<rafa> djazayeri: okay
|
16:42:31
|
<djazayeri> wyclif: why?
|
16:43:13
|
*** deadpool has joined #openmrs
|
16:44:54
|
<djazayeri> (why might it be, I mean?)
|
16:46:13
|
<djazayeri> rafa: here's what I'd do
|
16:46:33
|
<rafa> yes?
|
16:46:52
|
<djazayeri> 1. do a formatter for java.lang.Object that calls ${ ui.format(object) }
|
16:47:21
|
<djazayeri> 2. do a formatter for org.openmrs.OpenmrsMetadata that shows the name, and has the description as a tooltip
|
16:47:50
|
<djazayeri> 3. do a formatter for org.openmrs.Concept that shows the primary name, and has synonyms and description in a tooltip
|
16:48:08
|
<rafa> djazayeri: I've done 2, 3 (just the name)
|
16:48:10
|
<djazayeri> 4. get rid of the rest of them, because they'll be handled by the java.lang.Object one
|
16:48:26
|
<djazayeri> Basically I'd like UiUtils.format(String) to still exist and function.
|
16:48:37
|
<djazayeri> But it should guarantee that it's only giving you back plain text.
|
16:48:49
|
<rafa> djazayeri: ok, clear
|
16:49:14
|
<djazayeri> I suppose we could add UiUtils.formatAsHtml(Object) that evaluates the formatter fragment and returns it
|
16:49:28
|
<djazayeri> but I'd like to give people in their controllers easy access to the plain-text verison.
|
16:50:45
|
<rafa> djazayeri: ok thanks
|
16:51:00
|
<djazayeri> (I'm not going to repeat those comments on the code review)
|
16:53:14
|
<rafa> djazayeri: it's fine I'll fix it in an hours
|
16:53:49
|
<djazayeri> rafa: do you have OpenMRS 1.6.x running?
|
16:54:13
|
<djazayeri> actually, I should really just set that up as a test.
|
16:54:33
|
<djazayeri> but
|
16:55:01
|
<djazayeri> rafa: there are a couple people on the implementers list that just said that 1.6.3 isn't starting for them due to a problem starting logic 0.5
|
16:57:40
|
<djazayeri> wondering if you've seen anything similar
|
16:57:43
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @HITpol: #OpenSource alchemy: Healthcare and Alembic at #OSCON http://t.co/aNnSe0Y on @radar <http://twitter.com/OpenMRS/statuses/96974438410625024> || On Twitter: OpenMRS: RT @indivohealth: Thanks for the support and lively discussion of #indivohealth at #oscon. For anyone who missed it, slides are up! http ... <http://twitter.com/OpenMRS/statuses/96974201847693312>
|
16:59:42
|
*** lh has joined #openmrs
|
17:04:54
|
*** goutham has joined #openmrs
|
17:08:23
|
*** Yekkanti has joined #openmrs
|
17:21:45
|
*** chopin has quit IRC
|
17:34:50
|
*** chopin has joined #openmrs
|
17:45:36
|
<chopin> boooo: "Another User is already running database updates!" ... i want to see it too!
|
17:56:52
|
<djazayeri> I thought that redirected you?
|
17:57:00
|
<djazayeri> (or is that just in trunk)
|
17:57:58
|
<chopin> prolly trunk
|
17:58:06
|
* chopin is running 1.8.2 at AMPATH
|
18:07:24
|
<rafa> djazayeri: late response, no I haven't used 1.6.3 for a while
|
18:07:39
|
<djazayeri> okay, no worries
|
18:21:40
|
*** chopin has quit IRC
|
18:22:18
|
*** gbastien has joined #openmrs
|
18:23:20
|
*** goutham has quit IRC
|
18:23:26
|
<wyclif> djazayeri, it is because core uses the default hibernate Configuration class and if we want to mix things we need to use the AnnotationConfiguration
|
18:23:51
|
*** magoo_ has quit IRC
|
18:25:40
|
<wyclif> Or your OverrideHibernate post factory bean processor is getting called after validation
|
18:26:24
|
<djazayeri> wyclif: so the right solution is to support annotations in OpenMRS core, and get rid of my hack?
|
18:26:31
|
<djazayeri> we should create a ticket for this.
|
18:26:39
|
<djazayeri> Is it actually working for you, just failing to report errors?
|
18:26:43
|
<wyclif> yeah
|
18:26:47
|
<wyclif> yes
|
18:27:10
|
<wyclif> so they get loaded but after validation
|
18:28:23
|
<djazayeri> I don't quite understand what that means
|
18:28:40
|
<djazayeri> The classes are loaded if they pass validation?
|
18:28:54
|
<djazayeri> let me rephrase: is this blocking you at all now?
|
18:28:59
|
<djazayeri> or is it just out of curiosity?
|
18:30:07
|
<djazayeri> wyclif: if you're just exploring out of curiosity, I suggest you create a ticket about supporting hibernate annotations in the OpenMRS core API, and move on.
|
18:31:13
|
*** Yekkanti has left #openmrs
|
18:36:01
|
<wyclif> djazayeri, sure
|
18:36:15
|
<wyclif> i will create the ticket]
|
18:36:23
|
<wyclif> am not looking into it now
|
18:36:26
|
<djazayeri> ok
|
18:36:46
|
<wyclif> and i think i know the solution
|
18:54:04
|
*** bryq1 has joined #openmrs
|
18:55:21
|
*** bryq has quit IRC
|
19:30:04
|
*** james_regen has quit IRC
|
19:31:31
|
*** rafa has quit IRC
|
19:56:58
|
*** finbrein has quit IRC
|
19:57:41
|
*** finbrein has joined #openmrs
|
20:04:46
|
*** gbastien has quit IRC
|
20:06:53
|
<djazayeri> bwolfe: joining smart call?
|
20:09:48
|
<bwolfe> yeah, was in...got dropped
|
20:17:12
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: access control module <http://forum.openmrs.org/viewtopic.php?f=8&t=802#p3030>
|
20:17:52
|
*** asgoyal has quit IRC
|
20:24:01
|
*** bryq1 has quit IRC
|
20:31:19
|
*** bryq has joined #openmrs
|
20:31:19
|
*** ChanServ sets mode: +v bryq
|
20:43:33
|
*** gbastien has joined #openmrs
|
20:46:24
|
*** rafa has joined #openmrs
|
20:46:24
|
*** ChanServ sets mode: +v rafa
|
21:01:28
|
*** rafa has quit IRC
|
21:08:21
|
*** jriley has quit IRC
|
21:20:54
|
*** Echidna has quit IRC
|
21:24:31
|
*** Echidna has joined #openmrs
|
21:24:43
|
*** ChanServ sets mode: +v Echidna
|
22:01:26
|
*** gbastien has quit IRC
|
22:10:14
|
*** lh has quit IRC
|
22:57:38
|
*** bryq has quit IRC
|
23:01:06
|
*** muthah has quit IRC
|
23:07:35
|
*** muthah has joined #openmrs
|
23:26:08
|
*** robbyoconnor has quit IRC
|
23:27:35
|
*** robbyoconnor has joined #openmrs
|
23:27:35
|
*** ChanServ sets mode: +v robbyoconnor
|
23:31:16
|
*** djazayeri has quit IRC
|