| 00:04:36 | *** gbastien has quit IRC |
| 00:16:18 | *** bryq1 has quit IRC |
| 00:23:11 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Implement API method for retrieving PersonNames by personNameId - TRUNK-2199... <http://feedproxy.google.com/~r/OMRStrunk/~3/Hhf8tBUmJ2U/OpenMRS> |
| 00:29:37 | *** jportela has joined #openmrs |
| 00:29:42 | *** ChanServ sets mode: +v jportela |
| 00:42:45 | *** yanokwa has quit IRC |
| 00:53:15 | *** jportela has left #openmrs |
| 01:19:13 | *** jportela has joined #openmrs |
| 01:19:13 | *** ChanServ sets mode: +v jportela |
| 01:19:31 | *** jportela has left #openmrs |
| 01:29:15 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): integer attribute type <http://feedproxy.google.com/~r/OMRStrunk/~3/VvGWvo5n5cQ/OpenMRS> |
| 02:20:16 | *** wyclif has joined #openmrs |
| 02:39:28 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Starting at 8pm - #OSCON Humanitarian open source BoF session - Talk about projects saving the world. Room E143. #HFOSS <http://twitter.com/OpenMRS/statuses/96407037730230272> |
| 03:14:10 | *** upul` has joined #openmrs |
| 03:14:10 | *** ChanServ sets mode: +v upul` |
| 03:18:58 | *** upul` has quit IRC |
| 03:19:43 | *** upul` has joined #openmrs |
| 03:19:43 | *** ChanServ sets mode: +v upul` |
| 03:30:14 | *** muthah has quit IRC |
| 04:21:20 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): improved person attribute type: follow up update for the enum generalization process <http://feedproxy.google.com/~r/OMRStrunk/~3/Ukc3QbCX-8U/OpenMRS> || New Changeset: OpenMRS (improved-person-attribute-type): improved person attribute type: generalizing the enumeration approach <http://feedproxy.google.com/~r/OMRStrunk/~3/ZUw5FOJoMDM/OpenMRS> |
| 04:57:07 | *** rahul has joined #openmrs |
| 04:57:52 | <rahul> bwolfe : hi |
| 05:00:46 | *** rahul has quit IRC |
| 05:07:11 | *** deadpool has quit IRC |
| 05:31:27 | *** surangak has joined #openmrs |
| 05:56:47 | *** yanokwa has joined #openmrs |
| 05:56:47 | *** ChanServ sets mode: +v yanokwa |
| 06:01:14 | *** r0bby has joined #openmrs |
| 06:01:14 | *** ChanServ sets mode: +v r0bby |
| 06:03:12 | *** robbyoconnor has quit IRC |
| 06:24:20 | *** dkayiwa has joined #openmrs |
| 06:27:11 | *** rafa has joined #openmrs |
| 06:27:11 | *** ChanServ sets mode: +v rafa |
| 06:31:40 | *** muthah has joined #openmrs |
| 06:33:51 | *** pascal` has joined #openmrs |
| 06:39:45 | *** muthah has quit IRC |
| 06:51:48 | <surangak> bwolfe, helllooo, r u there ? |
| 07:05:31 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): phone number attribute type <http://feedproxy.google.com/~r/OMRStrunk/~3/L06mboXDv8s/OpenMRS> |
| 07:13:35 | *** dkayiwa has quit IRC |
| 07:16:49 | *** r0bby has quit IRC |
| 07:17:40 | *** r0bby has joined #openmrs |
| 07:17:40 | *** ChanServ sets mode: +v r0bby |
| 07:21:04 | *** dkayiwa has joined #openmrs |
| 07:25:40 | *** yanokwa_ has joined #openmrs |
| 07:25:40 | *** yanokwa has quit IRC |
| 07:26:26 | *** bryq has joined #openmrs |
| 07:26:26 | *** ChanServ sets mode: +v bryq |
| 07:37:33 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): email attribute type <http://feedproxy.google.com/~r/OMRStrunk/~3/cVJp9rrbovw/OpenMRS> |
| 07:41:02 | *** suho has joined #openmrs |
| 07:41:02 | *** ChanServ sets mode: +v suho |
| 08:11:22 | *** dkayiwa has quit IRC |
| 08:11:24 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): digits attribute type <http://feedproxy.google.com/~r/OMRStrunk/~3/k7azG_H7GmA/OpenMRS> |
| 08:12:10 | *** pascal` has quit IRC |
| 09:13:35 | *** yanokwa has joined #openmrs |
| 09:13:35 | *** ChanServ sets mode: +v yanokwa |
| 09:13:36 | *** yanokwa_ has quit IRC |
| 09:17:38 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Committing tag class and ObsForm.jsp as it is... <http://feedproxy.google.com/~r/OMRStrunk/~3/peurU-ewyCc/OpenMRS> |
| 09:21:20 | *** vchircu has joined #openmrs |
| 09:25:22 | *** bwolfe has quit IRC |
| 09:31:20 | *** magoo has joined #openmrs |
| 09:35:36 | *** suho has quit IRC |
| 09:53:43 | <bryq> rafa: Hi |
| 09:54:01 | <rafa> bryq: hey! |
| 09:54:49 | <bryq> rafa: To which users should we display alerts? Admins? Users with "Share metadata" privilege? |
| 09:55:22 | <rafa> bryq: Ideally "Share metadata" privilege |
| 09:55:39 | <rafa> bryq: but admins are fine too |
| 09:55:54 | <rafa> bryq: if you can't be that accurate |
| 09:56:11 | <bryq> rafa: But do you know how to get users by privilege? |
| 09:56:37 | <rafa> bryq: use UserService |
| 09:57:08 | *** rahul has joined #openmrs |
| 09:57:17 | <rafa> bryq: it's getUsersByRole |
| 09:57:47 | <rafa> bryq: did I change "Share metadata" string to a constant? |
| 09:57:59 | <bryq> rafa: But Role isn't privilege |
| 09:58:05 | <bryq> rafa: Yes, it's constant |
| 09:58:39 | <bryq> rafa: Role is e.g. "System Admin", not "Share metadata" nor "Manage users", etc. |
| 09:59:08 | <rafa> bryq: right |
| 09:59:25 | <rafa> bryq: role is aggregate for privilege |
| 09:59:48 | <rafa> bryq: you can query hibernate directly then |
| 10:00:32 | <bryq> rafa: Hmm.... But I'll try: role.addPrivilege(...) and check if it works |
| 10:02:22 | <rafa> bryq: don't change privileges for roles ;) |
| 10:03:29 | <bryq> rafa: I mean, I'll test: |
| 10:03:29 | <bryq> Role r = new Role(); |
| 10:03:29 | <bryq> r.addPrivilege(MetadataSharingConfig.MODULE_PRIVILEGE); |
| 10:03:29 | <bryq> List<User> users = Context.getUserService().getUsersByRole(r); |
| 10:05:20 | *** dkayiwa has joined #openmrs |
| 10:05:40 | <rafa> bryq: I bet it does id joins internally |
| 10:05:45 | <rafa> bryq: so it won't work |
| 10:05:54 | <rafa> bryq: you can try :) |
| 10:07:03 | <rafa> bryq: otherwise use Hibernate criteria. It's a piece of cake and suffices for now. You can issue a ticket to add that method to the api |
| 10:07:26 | <rafa> bryq: but we need a workaround now :) |
| 10:08:46 | <bryq> rafa: I think direct Hibernate access would work. I see some useful data in user_role table :) |
| 10:10:11 | <rafa> bryq: it's not that right to access it directly but since we've got no other option :) |
| 10:21:48 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Cleaning up obsForm.jsp <http://feedproxy.google.com/~r/OMRStrunk/~3/cK-VqK-lYXg/OpenMRS> |
| 10:49:47 | *** surangak has quit IRC |
| 10:49:56 | *** surangak has joined #openmrs |
| 10:50:07 | *** bwolfe has joined #openmrs |
| 10:56:22 | <bwolfe> Does it take 5 minutes for you guys for ui2 to start up? |
| 10:56:44 | <dkayiwa> when did you last update? |
| 10:58:42 | <bwolfe> Yesterday |
| 11:02:53 | *** muthah has joined #openmrs |
| 11:06:36 | *** upul` has left #openmrs |
| 11:09:42 | <dkayiwa> mine does not take that long |
| 11:12:39 | *** james_regen has joined #openmrs |
| 11:12:39 | *** ChanServ sets mode: +v james_regen |
| 11:21:07 | *** Yekkanti has joined #openmrs |
| 11:24:43 | <rahul> bwolfe : did u find the solution ? |
| 11:25:21 | <bwolfe> To your issue, or mine? :-) |
| 11:25:29 | <dkayiwa> :) |
| 11:25:51 | <rahul> bwolfe :mine :) |
| 11:27:52 | <Yekkanti> bwolfe: hey ben i'm jst now looking at the APPTEST Errors regarding the ticket https://tickets.openmrs.org/browse/APPTEST-48 |
| 11:27:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 21733 <http://feedproxy.google.com/~r/OMRStrunk/~3/KPHE_ufHG1E/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 21733 <http://feedproxy.google.com/~r/OMRStrunk/~3/tbqgwj-6MZo/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 21704 <http://feedproxy.google.com/~r/OMRStrunk/~3/f-I1wyfFd8E/OpenMRS> |
| 11:28:00 | *** rafa has quit IRC |
| 11:28:07 | <bwolfe> Did you try my suggestions from yesterday? |
| 11:28:30 | <Yekkanti> bwolfe: yeah i've did that. I'm unable to replicate the problem though! |
| 11:28:40 | <rahul> bwolfe : are reffering to me?? |
| 11:28:59 | <bwolfe> Was referring to rahul :-) |
| 11:29:17 | <Yekkanti> bwolfe: :) |
| 11:29:36 | <bwolfe> Yekkanti: hmm. It runs fine for you?? |
| 11:30:10 | <Yekkanti> bwolfe: Yep. I ran the complete suite. There was an assertion error (java.lang.AssertionError: Expected: a value greater than <0> page title with text "OpenMRS - Dictionary" got: <0> page title with text "OpenMRS - Dictionary" ) |
| 11:30:10 | <rahul> bwolfe:i did'nt get ur suggestion |
| 11:30:29 | <Yekkanti> bwolfe: apart from that i dont have any exceptions which you've pointed in the ticket |
| 11:30:59 | <Yekkanti> I've checked out the code from http://svn.openmrs.org/openmrs/branches/webapp-testing/ Guess i'm in the right path! |
| 11:31:05 | <OpenMRSBot> <http://ln-s.net/91Vb> (at svn.openmrs.org) |
| 11:31:24 | <bwolfe> Yeah, that's right |
| 11:31:42 | <bwolfe> Whats up with that error? |
| 11:32:15 | <bwolfe> And why is it not running for me? :-( |
| 11:32:54 | <bwolfe> Sorry, am on my phone rahul |
| 11:33:09 | <bwolfe> Can you check the logs from yesterday? :-) |
| 11:33:13 | <bwolfe> !irclogs |
| 11:33:14 | <OpenMRSBot> bwolfe: "irclogs" --- The OpenMRS IRC logs are publicly displayed online: http://wiki.openmrs.org/display/IRC/IRC+Logs |
| 11:33:44 | <Yekkanti> bwolfe: Regarding the assertion error not sure! I'll look into the code. And Regarding why its not running on your machine, would we have luck if we can delete the jar dependencies in your local machine and redownload them? |
| 11:34:20 | *** magoo has quit IRC |
| 11:35:22 | <rahul> bwolfe:okay |
| 11:35:24 | <Yekkanti> bwolfe: Do we have any CI running on the this particular branch! I'm relatively new to this branch and sorry if you think this is the dumbest question ever :) |
| 11:35:26 | <bwolfe> Hmm, yes, could be a maven repo issue. Which jars do you think are the offending ones? |
| 11:35:31 | <surangak> I just commiiteed revision no. 21999, if anyone wants to enter OpenMRS history book by committing revision No. 22,000, this is the time to do it :-) |
| 11:35:50 | <bwolfe> Ha |
| 11:36:07 | <bwolfe> I'm waiting for 22222 |
| 11:36:21 | <bwolfe> No ci child on that one yet |
| 11:36:39 | <bwolfe> I was going to set that up after merging to trunk |
| 11:37:14 | <Yekkanti> bwolfe: not completely sure! might be Jasper jar according to the error you've shown in the ticket. Lemme look into the code! I might take some time to go through the code as this is the first time i'm looking into it :) |
| 11:38:07 | <bwolfe> Ok, let me know what you find! |
| 11:38:50 | <rahul> bwolfe i can't find the suggestion in irc logs :( |
| 11:39:07 | <bwolfe> Bummer |
| 11:40:12 | <bwolfe> I saif something about the @transactional onyour service or overage |
| 11:40:27 | <bwolfe> Err, overage = interface |
| 11:42:31 | <bwolfe> Or using context.opensession() |
| 11:42:43 | <dkayiwa> bwolfe: after i included openmrs_static_content-servlet.xml, am now getting such error messages for module pages: |
| 11:42:44 | <dkayiwa> Caused by: java.io.FileNotFoundException: /WEB-INF/view//WEB-INF/view/module/reporting/dashboard/index.jspnull.jsp |
| 11:43:01 | <dkayiwa> bwolfe: could i have done something wrongly? |
| 11:43:17 | <dkayiwa> bwolfe: do you have any off the head tips? |
| 11:43:58 | <bwolfe> Don't include the whole file, just the urlrewrites part |
| 11:44:16 | <dkayiwa> ok |
| 11:45:23 | *** dkayiwa has quit IRC |
| 11:51:46 | *** muthah has quit IRC |
| 11:53:52 | *** muthah has joined #openmrs |
| 12:27:08 | *** rahul has quit IRC |
| 12:32:13 | *** bwolfe has quit IRC |
| 12:34:01 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 21979 <http://feedproxy.google.com/~r/OMRStrunk/~3/5142MlQRPLY/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 21878 <http://feedproxy.google.com/~r/OMRStrunk/~3/1OHFzyExvTc/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 21740 <http://feedproxy.google.com/~r/OMRStrunk/~3/ApTsEifZi7c/OpenMRS> |
| 12:38:14 | *** gbastien has joined #openmrs |
| 12:40:24 | *** bwolfe has joined #openmrs |
| 12:44:09 | *** wyclif has quit IRC |
| 12:47:20 | *** dkayiwa has joined #openmrs |
| 13:20:36 | *** Yekkanti has quit IRC |
| 13:32:40 | *** bwolfe has quit IRC |
| 13:36:53 | *** wyclif has joined #openmrs |
| 13:39:20 | *** jriley has joined #openmrs |
| 13:42:24 | *** magoo_ has joined #openmrs |
| 13:42:29 | *** wyclif has quit IRC |
| 13:42:46 | *** wyclif has joined #openmrs |
| 13:43:54 | *** sundeepnarwani has joined #openmrs |
| 13:45:27 | *** sundeepnarwani has quit IRC |
| 13:48:05 | *** wyclif has joined #openmrs |
| 13:48:16 | <magoo_> is it possible to build the entire project? |
| 13:51:32 | *** r0friedman has joined #openmrs |
| 13:51:36 | *** r0friedman is now known as r-friedman |
| 13:54:02 | *** bwolfe has joined #openmrs |
| 13:56:11 | *** jportela has joined #openmrs |
| 13:56:11 | *** ChanServ sets mode: +v jportela |
| 14:01:13 | *** mccallumg has joined #openmrs |
| 14:01:13 | *** ChanServ sets mode: +v mccallumg |
| 14:02:20 | *** bwolfe has quit IRC |
| 14:05:35 | *** mccallumg has quit IRC |
| 14:07:44 | *** mccallumg has joined #openmrs |
| 14:07:44 | *** ChanServ sets mode: +v mccallumg |
| 14:17:59 | *** gauravpaliwal has joined #openmrs |
| 14:17:59 | *** ChanServ sets mode: +v gauravpaliwal |
| 14:19:50 | *** magoo_ has quit IRC |
| 14:41:25 | *** batkinson has joined #openmrs |
| 14:42:19 | *** bwolfe has joined #openmrs |
| 14:42:19 | *** ChanServ sets mode: +o bwolfe |
| 14:44:15 | *** muthah has quit IRC |
| 14:50:50 | *** markolonius has joined #openmrs |
| 14:52:29 | <markolonius> hello! is there a way to download the entire user docs for offline reading pleasure? |
| 14:56:38 | *** gauravpaliwal has left #openmrs |
| 14:58:37 | <bwolfe> markolonius: I think there is way to download certain pages from the wiki in a pdf format. |
| 14:58:47 | <bwolfe> I think its something that confluence provides us for free |
| 14:59:13 | <bwolfe> not sure you'd be able to download the entire "DOCS" section/space of the wiki...that'd be a load on the server if it were provided |
| 15:09:19 | <markolonius> :/ yeah i'm downloading pages i need.. pdf doesn't seem to save the pictures along with it |
| 15:10:52 | <r-friedman> bwolfe: what did he say about help? is this a development standard? |
| 15:11:42 | <bwolfe> markolonius: thats too bad. need to let mdowney know about it. |
| 15:12:04 | <bwolfe> r-friedman: it was just a suggestion for his pages. we /should/ make it a standard though :-) |
| 15:12:11 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @downeym: So proud of all our 15 genius @gsoc students this year at #OpenMRS! <http://twitter.com/OpenMRS/statuses/96595399908925441> || On Twitter: OpenMRS: @fabianenardon Thanks for being here! #OSCON #OSCONJ <http://twitter.com/OpenMRS/statuses/96595292757037056> || On Twitter: OpenMRS: @groenpj Thanks! We'll take a look. <http://twitter.com/OpenMRS/statuses/96595021570125824> || On Twitter: OpenMRS: RT @gauravpaliwal: aja in @Openmrs has actually infinitely increased the quality of #GSoC stuff #hatsoff to that guy #Smart App http://t ... <http://twitter.com/OpenMRS/statuses/96593812960456704> |
| 15:12:21 | <r-friedman> is there a ticket? |
| 15:12:40 | *** suho has joined #openmrs |
| 15:12:40 | *** ChanServ sets mode: +v suho |
| 15:13:00 | <bwolfe> for what? adding help yext? |
| 15:14:40 | <bwolfe> *text |
| 15:32:16 | <suho> hi is there anyone here related to messaging module ? |
| 15:32:20 | *** Aja has joined #openmrs |
| 15:32:24 | *** deadpool has joined #openmrs |
| 15:40:52 | *** surangak has quit IRC |
| 15:41:03 | *** suho has quit IRC |
| 15:41:06 | *** Aja has quit IRC |
| 15:43:11 | *** markolonius has quit IRC |
| 15:43:14 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : Unformatted file web/pom.xml <http://feedproxy.google.com/~r/OMRStrunk/~3/RJLSdPVpJX8/OpenMRS> |
| 15:46:06 | *** gbastien has quit IRC |
| 15:58:04 | <wyclif> bwolfe |
| 15:58:31 | <wyclif> what locations does the OpenmrsClassLoader search? |
| 15:58:38 | *** gbastien has joined #openmrs |
| 15:58:42 | <bwolfe> locations? |
| 15:58:49 | <bwolfe> what do you mean? folders? |
| 15:58:53 | <wyclif> yes |
| 15:59:01 | <wyclif> does it include webinf? |
| 16:02:06 | *** goutham has joined #openmrs |
| 16:03:30 | *** dkayiwa has quit IRC |
| 16:07:11 | <bwolfe> not sure |
| 16:07:17 | <bwolfe> it def includes web-inf/classes |
| 16:07:52 | <bwolfe> it includes whatever its parent classloader includes. in tomcat/jetty, this shoudl be the WebappClassLoader they provide. and that includes web-inf or web-inf/classes |
| 16:08:16 | <bwolfe> djazayeri1: if I have a few random fixes to ui2, do you want me to just commit them or to create tickets first? |
| 16:10:20 | <djazayeri1> bwolfe: if they're big enough, make a ticket |
| 16:10:33 | <djazayeri1> if they're just small bugfixes, no need |
| 16:10:34 | <bwolfe> adding a class to 1xcompat ? |
| 16:11:04 | <djazayeri1> if that leads to the addition of significant new functionality (e.g. fieldGen now works!) then create a ticket |
| 16:11:09 | <djazayeri1> otherwise just commit and mention it to me |
| 16:11:59 | *** djazayeri1 is now known as djazayeri |
| 16:12:00 | *** ChanServ sets mode: +o djazayeri |
| 16:12:20 | <djazayeri> bwolfe, wyclif: quick scrum? |
| 16:12:27 | <djazayeri> (dkayiwa and rafa aren't here atm) |
| 16:12:36 | <djazayeri> so we can be very quick |
| 16:12:46 | <bwolfe> djazayeri: whoops, added it as part of my last commit. meant to uncheck it. it was RedirectController. formentry apparently references it in its spring config. see rev:22010 |
| 16:13:11 | <bwolfe> heh, hopefully quick, the kiddos are waiting on me to come play. :-) |
| 16:13:20 | <djazayeri> okay, well, what's your status? |
| 16:13:48 | <bwolfe> only did ui2 today so far, no occ because I didn't have internet to make any tickets, etc for the occ sprint |
| 16:14:05 | <bwolfe> looked into the schedueld tasks in ui2 ticket. they seem to work just fine |
| 16:14:10 | <djazayeri> great. |
| 16:14:21 | <djazayeri> did you claim the ticket? |
| 16:14:21 | <bwolfe> fixed the boolean object display |
| 16:14:28 | <bwolfe> yeah, claimed and closed |
| 16:14:37 | <djazayeri> ah yes. |
| 16:14:40 | <bwolfe> (inflating my ticket completion numbers ftw) |
| 16:15:01 | <djazayeri> nice, I think there are a few small ones left for you. :-) |
| 16:15:14 | <djazayeri> anyway, no blockers? |
| 16:15:19 | <bwolfe> and did a few optimizations on the Listener class to speed up startup. just committed that as part of wyclif's 2079 |
| 16:15:24 | <bwolfe> no blockers. |
| 16:15:26 | <bwolfe> quick question: |
| 16:15:47 | <bwolfe> when I click the magnifying glass I get a page that just has [object, object]. is that a KI ? |
| 16:16:00 | <djazayeri> KI? |
| 16:16:05 | <bwolfe> known issue |
| 16:16:20 | <djazayeri> which magnifying glass? |
| 16:16:34 | <bwolfe> I assume its supposed tob e the "search" one |
| 16:16:38 | <bwolfe> on the concept dictionary page |
| 16:16:51 | <bwolfe> next to the old boolean object drop down, etc |
| 16:17:05 | <djazayeri> hmm, that used to work |
| 16:17:16 | <djazayeri> i.e. it used to trigger the search, I think |
| 16:17:33 | <bwolfe> hmm, not doing that for me |
| 16:17:38 | <djazayeri> not for me either |
| 16:17:39 | *** Trevor has joined #openmrs |
| 16:17:53 | <bwolfe> ok, so its broken for you too? |
| 16:17:53 | <djazayeri> it definitely used to do it for the boolen (when it was a pointless dropdown) |
| 16:17:57 | <wyclif> hello |
| 16:18:24 | <djazayeri> it is correctly working in the Create Location page. |
| 16:18:37 | <wyclif> can i give my update now since i have to go for lunch |
| 16:18:48 | <djazayeri> So maybe it's just that ConceptService.getConcepts doesn't return anything if you give it "" |
| 16:18:52 | <djazayeri> actually, I don't know |
| 16:18:55 | <djazayeri> wyclif: go ahead |
| 16:18:59 | <bwolfe> ok, well, I can test again later tonight after I update |
| 16:19:14 | *** vchircu has quit IRC |
| 16:19:45 | *** dkayiwa has joined #openmrs |
| 16:19:47 | <bwolfe> ok, I'll be back in a few hours |
| 16:20:08 | *** mccallumg has quit IRC |
| 16:21:40 | <djazayeri> hmm, well, wyclif, you're too slow, so I'll go |
| 16:21:41 | <djazayeri> Yesterday: |
| 16:21:41 | <djazayeri> * design calls |
| 16:21:41 | <djazayeri> * sprint code review |
| 16:21:41 | <djazayeri> * TRUNK-2496 - investigating the idea of a multi-step "wizard" in 2.x |
| 16:21:42 | <djazayeri> Today: |
| 16:21:42 | <djazayeri> * continue TRUNK-2496 |
| 16:21:43 | <djazayeri> * sprint code review |
| 16:21:43 | <djazayeri> * continue last-minute design discussion for OCC sprint |
| 16:21:44 | <djazayeri> no blockers |
| 16:21:49 | <wyclif> yesterday: |
| 16:21:49 | <wyclif> TRUNK-2476, TRUNK-2477, TRUNK-2478 |
| 16:21:49 | <wyclif> Today: |
| 16:21:49 | <wyclif> * TRUNK-2479, TRUNK-2480 |
| 16:21:49 | <wyclif> * |
| 16:22:07 | <djazayeri> !ticket TRUNK-2476 |
| 16:22:08 | <OpenMRSBot> djazayeri: [#TRUNK-2476] liquibase changeset for user defined views - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2476 |
| 16:22:13 | <djazayeri> !ticket TRUNK-2477 |
| 16:22:14 | <OpenMRSBot> djazayeri: [#TRUNK-2477] PageViewProvider class - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2477 |
| 16:22:18 | <djazayeri> !ticket TRUNK-2478 |
| 16:22:19 | <OpenMRSBot> djazayeri: [#TRUNK-2478] Domain object with JPA annotations - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2478 |
| 16:22:26 | <djazayeri> !ticket TRUNK-2479 |
| 16:22:27 | <OpenMRSBot> djazayeri: [#TRUNK-2479] data access layer - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2479 |
| 16:22:32 | <djazayeri> !ticket TRUNK-2480 |
| 16:22:33 | <OpenMRSBot> djazayeri: [#TRUNK-2480] simple management pages - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2480 |
| 16:22:44 | <wyclif> i have a couple of things to clean out after code review |
| 16:22:48 | <djazayeri> wyclif: I've been making review comments |
| 16:22:52 | <wyclif> so i will have follow on the too |
| 16:22:54 | <djazayeri> okay, let me know if you have questions (after lunch) |
| 16:23:05 | <wyclif> i think they are all lear |
| 16:23:09 | <wyclif> sorry! clear |
| 16:23:17 | <wyclif> just one question |
| 16:23:49 | <wyclif> since we dont want to make changes in trunk, for now i will access the DAO layer directly for ticket, right? |
| 16:24:11 | <wyclif> for this ticket? |
| 16:24:14 | <djazayeri> wyclif: user-defined groovy pages will never go in the core API |
| 16:24:21 | <djazayeri> they're part of the web application |
| 16:24:56 | <djazayeri> We have to decide what kind of service layer architecture we want for the ui2 application (to balance good design and everything-is-an-interface, with rapid development) |
| 16:25:06 | <wyclif> so we are going to be accessing the DAO layer directly in web for all these right? |
| 16:25:14 | <djazayeri> not necessarily forever |
| 16:25:16 | <wyclif> ok |
| 16:25:18 | <wyclif> got you |
| 16:25:20 | <djazayeri> but if you do that for now, I am fine with it. |
| 16:25:22 | <wyclif> talk to you later |
| 16:25:26 | <djazayeri> bye |
| 16:25:29 | <wyclif> bye |
| 16:25:48 | <wyclif> Ben did you day openrmsclassloader looks in webinf |
| 16:29:14 | <dkayiwa> is it my turn now? |
| 16:29:18 | <djazayeri> yes |
| 16:29:28 | <djazayeri> sorry, didn't see you online. :-) |
| 16:29:32 | <dkayiwa> :) |
| 16:29:33 | <dkayiwa> Completed TRUNK-2489 (https://tickets.openmrs.org/browse/TRUNK-2489) |
| 16:29:33 | <dkayiwa> As i was about to consider TRUNK-2456 (https://tickets.openmrs.org/browse/TRUNK-2456) Completed |
| 16:29:34 | <dkayiwa> I came across a blocker for the reporting module where it complained that JQuery is not defined. I tried what Ben had suggested of including openmrs_static_content-servlet.xml but i ended up with more problems where pages that used to work before did not. Ben later on advised me to remove some things from this file and then again all worked. But the JQuery not defined error remained on the reporting module pages. DONE |
| 16:30:06 | <djazayeri> I don't think you should _include_ the static-content servlet |
| 16:30:17 | <dkayiwa> aha |
| 16:30:21 | <djazayeri> rather you need to do some of the mappings that it was doing |
| 16:30:29 | <djazayeri> what's the exact error for reporting? |
| 16:30:37 | <djazayeri> it's requesting /scripts/jquery.min.js? |
| 16:30:40 | <djazayeri> and that's not found? |
| 16:30:58 | <dkayiwa> Error: jQuery is not defined |
| 16:31:22 | <dkayiwa> Error: jQuery is not defined |
| 16:31:23 | <dkayiwa> Source File: http://localhost:8080/openmrs2/module/reporting/dashboard/index.form |
| 16:31:23 | <dkayiwa> Line: 78 |
| 16:31:25 | <djazayeri> Okay, but if you use firebug or chrome developer tools, do you see jquery being loaded? |
| 16:32:48 | <dkayiwa> just seen that i get the same error message even in non ui2 |
| 16:33:04 | <djazayeri> hmm... |
| 16:33:09 | <dkayiwa> that is reporting module version 0.5.4 |
| 16:33:10 | *** Trevor has quit IRC |
| 16:33:18 | <djazayeri> ah, try using the latest |
| 16:33:19 | <djazayeri> 0.6.2 |
| 16:33:25 | <dkayiwa> ok |
| 16:33:26 | <djazayeri> you also have to upgrade serialization.xstream |
| 16:33:31 | <dkayiwa> ok |
| 16:46:04 | <djazayeri> dkayiwa: so, I am looking at a reporting page in the network tab of chrome dev tools and I see that it's trying to include http://localhost:8080/openmrs2/scripts/jquery/jquery-1.3.2.min.js?v=1.9.0.21977 but that's a 404 |
| 16:46:20 | <dkayiwa> ok |
| 16:46:20 | <djazayeri> (there are a bunch of other 404s too) |
| 16:47:10 | <dkayiwa> yes because ui2 no longer has the script folder under webapp as it used in older versions of openmrs |
| 16:47:19 | <djazayeri> It does have a scripts folder |
| 16:47:26 | <djazayeri> but not jquery/jquery-1.3.2.min.js |
| 16:47:31 | <djazayeri> Presumably this is coming from an htmlInclude |
| 16:48:27 | <dkayiwa> oh yes seen it |
| 16:48:30 | <djazayeri> So basically we should add a mapping to the resourceReplacements map in PageContext, and have htmlInclude also use that mapping. |
| 16:48:42 | <dkayiwa> ok |
| 16:49:04 | <djazayeri> specifically we'll map "jquery/jquery-1.3.2.min.js" -> "jquery-1.5.min.js" |
| 16:49:12 | <dkayiwa> ok |
| 16:49:53 | <djazayeri> So, specifically for the resources that we're treating specially in 1.x, we also want to treat them specially in 2.x |
| 16:50:05 | <dkayiwa> ok |
| 16:51:04 | <djazayeri> other 404s I see are: style.css, openmrsmessages.js, openmrs.js |
| 16:51:39 | <djazayeri> It does seem like we'll want to take the 1.x style.css and include it in 2.x, but with a name like style-1x.css |
| 16:51:48 | <djazayeri> and add a mapping for that |
| 16:51:59 | <dkayiwa> ok |
| 16:52:58 | <djazayeri> openmrsmessages.js may be tricky (deal with that last) |
| 16:53:19 | <dkayiwa> shouldnt i just copy and paste it over? |
| 16:53:26 | <djazayeri> it's a .js.withjstl |
| 16:53:31 | <dkayiwa> ok |
| 16:53:48 | <djazayeri> so that would involve bringing over that hacky PseudoStaticContentServlet I wrote long ago |
| 16:53:53 | <djazayeri> and I'd prefer to avoid that. |
| 16:54:02 | <dkayiwa> ok |
| 16:54:10 | <djazayeri> openmrs.js, like style.css, should be copied over, but with a new name, like openmrs1x.js |
| 16:54:20 | <dkayiwa> ok |
| 16:54:38 | <djazayeri> alternately make a "1x-compatibility" folder and put openmrs.js in there |
| 16:54:44 | <djazayeri> same for style.css |
| 16:54:49 | <djazayeri> instead of changing the filename... |
| 16:55:00 | <dkayiwa> ok |
| 16:56:01 | <djazayeri> okay, gotta run for a bit |
| 16:56:07 | <dkayiwa> ok |
| 16:56:14 | <dkayiwa> thanks for the guidance |
| 17:00:56 | *** yanokwa_ has joined #openmrs |
| 17:00:57 | *** yanokwa has quit IRC |
| 17:04:50 | *** trevormells has joined #openmrs |
| 17:06:10 | *** goutham has quit IRC |
| 17:07:50 | *** dkayiwa has quit IRC |
| 17:11:18 | *** r-friedman has quit IRC |
| 17:12:06 | *** trevormells has quit IRC |
| 17:18:40 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @digiphile: For more on the "Health Internet," read @ahier http://oreil.ly/eelEzL & @NYTimes http://nyti.ms/hqJ4Yk #opengov #gov20 #OSCON <http://twitter.com/OpenMRS/statuses/96622672078848001> || On Twitter: OpenMRS: Expensive commercial tools aren't needed to do meaningful life science research and change the world. - @erigentry at #OSCON <http://twitter.com/OpenMRS/statuses/96621773260472321> || On Twitter: OpenMRS: RT @bigs: Like we couldn't imagine buying books online before the Internet, we don't yet know all the ways #health on the net will be aw ... <http://twitter.com/OpenMRS/statuses/96619701429481472> || On Twitter: OpenMRS: Protocols implemented in open source will be the basis of health care delivery in the very near future. @fredtrotter at #OSCON <http://twitter.com/OpenMRS/statuses/96618811175870464> |
| 17:31:24 | *** cta has joined #openmrs |
| 17:36:37 | *** Suho has joined #openmrs |
| 17:37:16 | *** Suho is now known as suho |
| 17:37:53 | <suho> hi anyone related to messaging module here ? |
| 17:38:37 | <suho> I whanted to know whare can I get a stable verion of the module ? |
| 17:42:58 | *** Suranga has joined #openmrs |
| 17:43:56 | *** gbastien has quit IRC |
| 17:53:15 | *** batkinson has quit IRC |
| 17:55:54 | *** jriley has left #openmrs |
| 18:02:36 | <bwolfe> suho: is there one attached to it's wiki page ? |
| 18:03:10 | <suho> bwolfe, no |
| 18:05:59 | <suho> bwolfe, that only points to the trunk |
| 18:21:30 | *** Yekkanti has joined #openmrs |
| 18:26:47 | *** muthah has joined #openmrs |
| 18:30:31 | *** Yekkanti has quit IRC |
| 18:37:49 | <bwolfe> suho: ask the dev list maybe. or check the archive to see if anyone posted one there |
| 18:43:23 | *** jportela has quit IRC |
| 18:43:50 | *** KGB_plague has joined #openmrs |
| 18:46:36 | <KGB_plague> my elder is in the hospital with heart problem and now machines keeping them going , is it ok if i hold them , does this give them strength to recover or will this affect her heart because i see the heart beat goes up when i hold them for 10 seconds and i stop holding them :( please i hope im in the right channel, the doctors here are like without care in such information i speak about |
| 18:51:37 | <djazayeri> KGB_plague: not the right channel. mainly computer programmers here |
| 18:52:41 | *** bryq has quit IRC |
| 18:53:32 | *** bryq has joined #openmrs |
| 18:53:32 | *** ChanServ sets mode: +v bryq |
| 19:07:19 | <wyclif> djazayeri, does the openmrsclassloader look in web-inf |
| 19:07:34 | <djazayeri> wyclif: I don't know |
| 19:07:37 | <djazayeri> probably not |
| 19:07:41 | <wyclif> ok |
| 19:07:42 | <djazayeri> what classes are in web-inf? |
| 19:07:44 | <wyclif> thanks |
| 19:07:56 | <djazayeri> or do you mean jar resources or something? |
| 19:08:06 | <wyclif> not classes but other recources like files |
| 19:08:10 | *** jportela has joined #openmrs |
| 19:08:10 | *** ChanServ sets mode: +v jportela |
| 19:08:17 | <bwolfe> wyclif: what are you needing to look up? |
| 19:08:36 | <bwolfe> wyclif: and it'd be easy to test. put something there and then try to load a resource from the classloader |
| 19:08:46 | <wyclif> this is something in the gsoc project that we are trying out |
| 19:08:57 | <bwolfe> OpenmrsClassLoader.getInstance().getResource("something.txt"); |
| 19:09:19 | <wyclif> bwolfe, would that find a file under web-ibf? |
| 19:09:33 | <wyclif> if yes, that would be cool |
| 19:09:36 | <bwolfe> we don't know |
| 19:09:37 | <bwolfe> just try |
| 19:10:05 | <wyclif> bceause the tool we are using, looks at the classpath, so if we swicted to the openmrsclassloader, then it would help us |
| 19:10:32 | <wyclif> find the messages.properties file under web-inf |
| 19:10:46 | <wyclif> the resourcebundles class doesn't |
| 19:10:55 | <wyclif> ok let me try |
| 19:14:58 | *** suho has quit IRC |
| 19:17:00 | <bwolfe> wyclif: if the standard classloader doesn't look there, the openmrsclassloader won't |
| 19:17:10 | <bwolfe> there is nothing about web-inf in our classloader...web-inf is a web layer idea |
| 19:30:10 | *** dkayiwa has joined #openmrs |
| 19:38:13 | *** james_regen has quit IRC |
| 19:42:12 | *** cta has quit IRC |
| 19:45:01 | *** Suranga has quit IRC |
| 19:51:35 | *** r1friedman has joined #openmrs |
| 19:51:47 | *** r1friedman is now known as r-friedman |
| 19:52:11 | <r-friedman> bwolfe: got a minute? |
| 19:53:01 | <bwolfe> sure |
| 19:53:33 | <r-friedman> i was looking at wiki/module+extension_points |
| 19:53:51 | <r-friedman> i was trying to figure out how a context-sensitive help might be accomplished |
| 19:54:14 | <r-friedman> but all the links to the interfaces on that page are broken, you've deleted them all |
| 19:56:02 | <bwolfe> probably because of the move to maven |
| 19:56:32 | <r-friedman> yeah, that's what the comments say, but where are the interfaces now? |
| 19:59:02 | *** KGB_plague has left #openmrs |
| 19:59:10 | <bwolfe> in there somewhere. :-) |
| 19:59:21 | <r-friedman> :-)) |
| 19:59:25 | <bwolfe> you can search in the upper right for just the class name and it should find it |
| 19:59:33 | <bwolfe> (the upper right in source.openmrs.org) |
| 20:00:02 | <bwolfe> things like /src/api/org/openmrs... moved to /api/src/main/java/org/openmrs.... |
| 20:00:04 | <r-friedman> tried that without success but will try again |
| 20:01:16 | <r-friedman> looks like the .java is key to making that work |
| 20:04:19 | <r-friedman> moved twice, but still not found |
| 20:04:34 | <bwolfe> which interface roger? |
| 20:04:49 | <r-friedman> boxext |
| 20:06:22 | <bwolfe> web/src/main/java/org/openmrs/module/web/extension/BoxExt.java |
| 20:06:34 | <bwolfe> thats what it is in trunk now |
| 20:07:53 | <r-friedman> ok, got it, tks |
| 20:07:56 | *** yanokwa_ has quit IRC |
| 20:08:20 | *** yanokwa has joined #openmrs |
| 20:08:20 | *** ChanServ sets mode: +v yanokwa |
| 20:12:50 | *** yanokwa has quit IRC |
| 20:15:50 | <r-friedman> bwolfe: ok i have fixed the links on the Module Extension Points home |
| 20:16:17 | <bwolfe> awesome, thanks! |
| 20:16:25 | <bwolfe> r-friedman++ |
| 20:36:24 | *** dkayiwa has quit IRC |
| 20:39:47 | *** dkayiwa has joined #openmrs |
| 21:16:46 | <djazayeri> dkayiwa: just commented on TRUNK-2481 |
| 21:16:54 | <dkayiwa> ok |
| 21:25:19 | *** Echidna has quit IRC |
| 21:28:58 | *** Echidna has joined #openmrs |
| 21:28:58 | *** ChanServ sets mode: +v Echidna |
| 21:29:03 | *** yanokwa has joined #openmrs |
| 21:29:03 | *** ChanServ sets mode: +v yanokwa |
| 21:57:37 | *** bryq has quit IRC |
| 22:10:08 | <djazayeri> dkayiwa: I see that you added an "openmrs-servlet.xml" file |
| 22:10:19 | <djazayeri> with just a bit of stuff in it. |
| 22:10:45 | <djazayeri> could you please rename that "1xcompatibility-config.xml"? |
| 22:10:57 | <djazayeri> to go along with app-config.xml and mvc-config.xml |
| 22:24:48 | *** gbastien has joined #openmrs |
| 22:36:20 | <dkayiwa> ok |
| 22:36:47 | <djazayeri> I mentioned this in a ticket comment too |
| 22:37:03 | <dkayiwa> ok |
| 22:50:48 | *** dkayiwa has quit IRC |
| 22:52:09 | *** wyclif has quit IRC |
| 23:11:22 | *** r0bby is now known as robbyoconnor |
| 23:11:28 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @anomalizer: This year's #oscon has lots of appeals asking geeks to work on healthcare. I concur. Better than getting people to raise ... <http://twitter.com/OpenMRS/statuses/96713956525223936> |
| 23:41:02 | *** wyclif has joined #openmrs |
| 23:45:01 | *** gbastien has quit IRC |
| 23:54:15 | *** jportela has left #openmrs |
| 23:58:57 | <wyclif> djazayeri, if this is we have a user defined page view, shouldn't we be associating it to the user? |
| 23:59:08 | <wyclif> sorry about the typos |
| 23:59:12 | <djazayeri> No. |
| 23:59:17 | <wyclif> why? |
| 23:59:31 | <djazayeri> The idea is that I (as a system administrator) may create pages, e.g. "dataClerkHomepage" |
| 23:59:33 | <wyclif> doesn't it mean other users can view it |
| 23:59:44 | <djazayeri> I _want_ other users to be able to view it. |
| 23:59:54 | <wyclif> well, ok |