| 00:03:59 | *** yanokwa has quit IRC |
| 00:17:15 | *** wyclif has joined #openmrs |
| 00:48:41 | *** gbastien has quit IRC |
| 01:19:27 | *** yanokwa has joined #openmrs |
| 01:19:27 | *** ChanServ sets mode: +v yanokwa |
| 01:20:58 | *** suho has joined #openmrs |
| 01:20:58 | *** ChanServ sets mode: +v suho |
| 01:41:16 | *** asgoyal has joined #openmrs |
| 01:42:11 | *** mathiaslin has joined #openmrs |
| 01:42:15 | <asgoyal> wyclif: hi... did you have a look at the pastbin links that i gave you? |
| 01:42:41 | <wyclif> just add a patch to the ticket, i will apply it and see why it fails |
| 01:43:18 | <asgoyal> oh ok |
| 01:43:25 | *** mathiaslin has left #openmrs |
| 01:44:30 | <asgoyal> wyclif, djazayeri: by that time.. can you gys suggest me some ticket which i can work on and learn? |
| 01:49:16 | <wyclif> just a sec |
| 01:51:25 | <wyclif> asgoyal, https://tickets.openmrs.org/browse/TRUNK-2448 |
| 01:51:39 | <asgoyal> wyclif: thank you :) |
| 01:57:26 | <asgoyal> wyclif: i attached the patch at trunk 2193 |
| 01:57:34 | <asgoyal> !ticket 2193 |
| 01:57:35 | <OpenMRSBot> asgoyal: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/2193 |
| 01:57:44 | <asgoyal> !ticket Trunk-2193 |
| 01:57:45 | <OpenMRSBot> asgoyal: [#TRUNK-2193] Add Drug Ingredients to API - OpenMRS JIRA - https://tickets.openmrs.org/browse/Trunk-2193 |
| 02:02:14 | <asgoyal> wyclif: what does this log message mean... i got it in console |
| 02:02:16 | <asgoyal> Unknown column 'ingredient0_.uuid' in 'field list' |
| 02:02:16 | <wyclif> ok |
| 02:02:31 | <asgoyal> is it something related to this that it is not working? |
| 02:02:40 | <wyclif> that might be the reason it is failed yesterday |
| 02:02:53 | <wyclif> because i was wondering what was the missing property |
| 02:04:13 | <asgoyal> so.... what is that property? |
| 02:04:25 | <asgoyal> in field list... |
| 02:05:04 | <wyclif> if you look at your drug_ingredient table, there is no uuid column |
| 02:05:06 | <wyclif> right? |
| 02:05:11 | <wyclif> can you add it |
| 02:05:12 | <asgoyal> oh yes |
| 02:05:14 | <asgoyal> oh ok |
| 02:05:22 | <asgoyal> through liquibase? |
| 02:05:25 | <wyclif> yes |
| 02:05:28 | <asgoyal> ok |
| 02:05:32 | <wyclif> the way you added units |
| 02:05:52 | <wyclif> look in the liquibase file how to add a uuid column |
| 02:06:11 | <wyclif> just do a text search of uuid in the liquibase file for an example |
| 02:07:20 | <asgoyal> wyclif: what is the full name of the file.. i forgot |
| 02:07:43 | <wyclif> just do alt+shift+r |
| 02:07:47 | <wyclif> and type liquibae |
| 02:07:55 | <wyclif> sorry, liquibase |
| 02:08:00 | <asgoyal> yeah there are many |
| 02:08:01 | <asgoyal> -core |
| 02:08:08 | <asgoyal> -demo |
| 02:08:11 | <asgoyal> -data |
| 02:13:57 | <asgoyal> need to resstart my computer |
| 02:14:01 | *** asgoyal has quit IRC |
| 02:18:31 | *** asgoyal has joined #openmrs |
| 02:26:43 | <asgoyal> wyclif: i think i know the reason why it was failing... i did not put any data in the database to test.... |
| 02:26:51 | <asgoyal> wyclif: ... my bad.. |
| 02:27:12 | <wyclif> that should not make it fail |
| 02:27:24 | <asgoyal> oh |
| 02:27:25 | <wyclif> it should only have an empty list |
| 02:27:40 | <asgoyal> anyways i have changed the liquibase..now running jetty run |
| 02:27:49 | <wyclif> the form should be able to be displayed without errors |
| 02:29:22 | <asgoyal> wyclif: YAY !! it works now! :D |
| 02:29:34 | <asgoyal> so... .. why is uuid SO important?! |
| 03:01:33 | *** upul` has joined #openmrs |
| 03:01:33 | *** ChanServ sets mode: +v upul` |
| 03:07:53 | <asgoyal> wyclif: i m trying this out |
| 03:08:02 | <asgoyal> <spring:messagecode="ConceptDrug.ingredients"/> |
| 03:08:11 | <asgoyal> and i have also added that in message.properties |
| 03:08:15 | <asgoyal> but it doesn't show any effect |
| 03:08:26 | <asgoyal> do i have to modify some other related file too? |
| 03:10:59 | <wyclif> good job |
| 03:11:09 | <wyclif> asgoyal, good job |
| 03:11:25 | <asgoyal> ? |
| 03:11:49 | <wyclif> have you added ConceptDrug.ingredient to messages.properties? |
| 03:12:07 | <asgoyal> yes |
| 03:12:37 | <wyclif> make sure you are not adding to the one under target |
| 03:12:44 | <asgoyal> ah the target !! |
| 03:12:52 | <asgoyal> ok .. now it will work... ah.. i hate myself |
| 03:13:03 | <wyclif> that is the first thing u should check |
| 03:13:14 | <wyclif> probably you need to filter out the target folder |
| 03:17:57 | <asgoyal> works :) |
| 03:18:04 | <asgoyal> will submit the latest patch now |
| 03:18:28 | <asgoyal> wyclif: shall i start with its later part to add drug ingredients? |
| 03:26:16 | *** suho has quit IRC |
| 03:32:24 | <wyclif> just add like 2 drug ingredients and see if they get displayed |
| 03:32:38 | <wyclif> asgoyal, just add like 2 drug ingredients and see if they get displayed |
| 03:38:57 | *** mccallumg has joined #openmrs |
| 03:38:57 | *** ChanServ sets mode: +v mccallumg |
| 03:43:45 | *** surangak has joined #openmrs |
| 03:47:43 | <surangak> mccallumg, hellooo |
| 03:55:35 | <mccallumg> hi surangak: I saw your blog post on testing :) |
| 03:56:00 | <surangak> mccallumg, midnight ramblings of a moron :P |
| 03:56:15 | <surangak> mccallumg, I wrote that around 2am in the mroning :D |
| 03:56:17 | <mccallumg> surangak: ramblings are good, Mr QA. |
| 03:56:52 | <surangak> mccallumg, so long as I hav not written anything embarassing ;-) |
| 03:57:53 | <mccallumg> surangak: I contacted a friend of mine. An international student. Waiting to hear back... |
| 03:58:09 | <surangak> mccallumg, thats great, I was wanting to ask you on that |
| 03:58:17 | <surangak> mccallumg, I like long term planning :P |
| 03:59:03 | <surangak> mccallumg, did u see, Darius and Burke had reviewed my mode ? |
| 04:00:16 | <mccallumg> surangak: I did. I don't have much to add. i'm not nearly as familiar with the code base as they are. |
| 04:01:01 | <surangak> mccallumg, based on what they said, I realized that I should stop using Jauto doc plugin for my comments :) |
| 04:01:37 | <mccallumg> surangak: It is good to start populating ... but you have to fill in the details. |
| 04:02:04 | <surangak> mccallumg, i think I may have to re do 70% of my comments.. |
| 04:02:14 | <surangak> mccallumg, the other two main points were, |
| 04:02:26 | <surangak> 1. can we use jquery instead of javasript |
| 04:02:32 | *** jwishnie has joined #openmrs |
| 04:02:40 | <surangak> 2. do we really need the dwr call to back end.. |
| 04:02:49 | <mccallumg> surangak: right. I saw that. |
| 04:03:26 | <mccallumg> surangak: burke just commented on ajax as well instead of a full page refresh. |
| 04:03:34 | <surangak> mccallumg, switching to jquery should be easy once everything is working... |
| 04:03:49 | <surangak> mccallumg, yep, i just got that mail... |
| 04:04:23 | <mccallumg> surangak: Can you select which jquery components to load for a page? or does openmrs load a standard set? |
| 04:04:33 | <surangak> mccallumg, he makes sense... |
| 04:04:40 | <surangak> mccallumg, it is probably possible |
| 04:05:08 | <surangak> mccallumg, but that would mean that I would have to accomodate all data types (even the ones that already exist) |
| 04:05:53 | <surangak> mccallumg, let me change that answer... |
| 04:06:18 | <surangak> mccallumg, earlier when I talked to Ben and darius, they suggested that reload was the only way i could do it... |
| 04:06:42 | <surangak> mccallumg, maybe they had missed something, or there is something else that Burke did not consider... |
| 04:07:07 | <surangak> mccallumg, I should probably show darius Burks response and ask what he makes of it.. |
| 04:07:26 | <mccallumg> surangak: I remember now. Yes. or remind Burke of the thread with Darius. |
| 04:07:55 | <surangak> mccallumg, sure, wiill do that |
| 04:08:42 | <surangak> mccallumg, i've been moving ahead with the reload solution |
| 04:09:15 | <surangak> mccallumg, right now actually i've got everything working with the reload solution |
| 04:09:39 | <surangak> mccallumg, all possible scenarios in the edit obs and save obs are good to go... |
| 04:09:43 | <mccallumg> surangak: yes. can you see a way to do it without a full-refesh? Does it seem like it could happen? |
| 04:10:08 | <mccallumg> surangak: you already tried, didn't you. and it didn't work. |
| 04:10:34 | <surangak> mccallumg, im not very positive that it could work |
| 04:11:05 | <surangak> mccallumg, because worrying over the refresh part went on over a long period of time |
| 04:11:22 | <mccallumg> surangak: explain what you've already tried to Burke. |
| 04:11:50 | <surangak> mccallumg, sure.. I'll do that |
| 04:12:03 | <surangak> mccallumg, I was wondering of the solution I already got working |
| 04:12:45 | <surangak> mccallumg, since it is working, i'd like to clean it up and commit it, just in case that the new system does not work, and we're stuck with nothing at the nd :P |
| 04:12:59 | <surangak> mccallumg, *at the *end |
| 04:13:22 | <mccallumg> surangak: yes. of course. I don't even require things to build for you to commit. Use the repository as a tool. |
| 04:13:51 | <surangak> mccallumg, so i could do this, i could start cleaning up and comitting stuff... |
| 04:13:58 | <surangak> mccallumg, i'll also respond to the mail |
| 04:14:21 | <surangak> mccallumg, normally mail debates can go on for some time :-) |
| 04:14:38 | <mccallumg> surangak: yes. when it comes to design ... |
| 04:19:15 | *** asgoyal has quit IRC |
| 04:24:51 | <surangak> mccallumg, wondering if djazayeri is here.. |
| 04:25:03 | <surangak> djazayeri, hi , r u still here ? |
| 04:28:53 | <surangak> mccallumg, nop, ill hav to catch him tonight (his morning) |
| 05:03:29 | <mccallumg> surangak: alright. talk to you later this week. |
| 05:03:45 | <surangak> mccallumg, sure, i'll drop those mails |
| 05:03:52 | *** mccallumg has quit IRC |
| 05:16:47 | *** mathiaslin has joined #openmrs |
| 05:25:08 | *** jwishnie has quit IRC |
| 05:26:18 | *** vchircu has quit IRC |
| 06:03:27 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Upgrading to work with Edit Obs <http://feedproxy.google.com/~r/OMRStrunk/~3/OxyHIbAgC-E/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Patient and Location handlers (improved get/save Obs and updated getValue() method) <http://feedproxy.google.com/~r/OMRStrunk/~3/Z5NP0y03FCM/OpenMRS> |
| 06:13:57 | *** dkayiwa has joined #openmrs |
| 06:20:34 | *** bwolfe has joined #openmrs |
| 06:20:34 | *** ChanServ sets mode: +o bwolfe |
| 06:23:23 | *** finbrein has joined #openmrs |
| 06:24:10 | *** rafa has joined #openmrs |
| 06:24:10 | *** ChanServ sets mode: +v rafa |
| 06:39:43 | <djazayeri> surangak: if you still have questions, I have approx 3 minutes. :-) |
| 06:40:01 | <surangak> djazayeri, howdy djazayeri ..no hurry |
| 06:40:21 | <surangak> but if u are free, maybe u could give your views on Burkes comment to my ticket :-) |
| 06:40:24 | <djazayeri> I mean I'm off to bed in 3 minutes, so it's now or tomorrow |
| 06:40:38 | <djazayeri> I'm about to comment. you mean: could we use ajax to inject html in a div? |
| 06:40:49 | <surangak> djazayeri, yeps ,thats the one |
| 06:40:56 | <djazayeri> yes, commenting now |
| 06:41:03 | <surangak> djazayeri, no hurry, i think you are up very late today ;_) |
| 06:49:15 | *** pascal` has joined #openmrs |
| 07:05:40 | <pascal`> morning bwolfe |
| 07:05:52 | <surangak> djazayeri, thanks for the input... too will respond by your time - tomorrow morning... :) |
| 07:06:14 | <pascal`> bwolfe, have you had your morning coffee or whatever it takes to wake yourself up? (You're in Africa, right?) |
| 07:06:19 | *** ChanServ sets mode: +v pascal` |
| 07:52:05 | *** robbyoconnor has quit IRC |
| 07:55:39 | *** yanokwa has quit IRC |
| 08:15:28 | *** bwolfe has quit IRC |
| 08:17:47 | *** bryq has joined #openmrs |
| 08:17:47 | *** ChanServ sets mode: +v bryq |
| 08:26:57 | *** bwolfe has joined #openmrs |
| 08:26:57 | *** ChanServ sets mode: +o bwolfe |
| 08:57:50 | *** magoo has joined #openmrs |
| 09:01:06 | <rafa> bwolfe: are you there? |
| 09:07:52 | *** mathiaslin has quit IRC |
| 09:08:30 | *** magoo has quit IRC |
| 09:10:39 | *** magoo has joined #openmrs |
| 09:12:59 | *** batkinson has quit IRC |
| 09:28:13 | <magoo> i'm failing to run maven as jdk i have tried to follow all the procdure on wiki's but i have failed any help |
| 09:35:46 | <dkayiwa> magoo: which wiki instructions are you trying to follow? |
| 09:36:54 | *** goutham has joined #openmrs |
| 09:36:59 | <magoo> https://wiki.openmrs.org/display/docs/Using+the+M2Eclipse+Maven+Plugin+In+Eclipse |
| 09:37:00 | <OpenMRSBot> <http://ln-s.net/8c8D> (at wiki.openmrs.org) |
| 09:38:13 | <magoo> http://maven.apache.org/guides/mini/guide-ide-eclipse.html#Maven_as_an_external_tool |
| 09:38:18 | <OpenMRSBot> <http://ln-s.net/91Ls> (at maven.apache.org) |
| 09:39:00 | *** finbrein has quit IRC |
| 09:44:35 | *** bwolfe has quit IRC |
| 09:46:52 | *** bwolfe has joined #openmrs |
| 09:46:52 | *** ChanServ sets mode: +o bwolfe |
| 09:49:26 | <dkayiwa> magoo: at which step did you fail? |
| 09:49:59 | *** omarIRD has joined #openmrs |
| 09:51:02 | <magoo> i'm supposed to set a path for maven cause i was trying to set the path for maven |
| 09:51:43 | <magoo> let me paste what what happens when i try to build openmrs |
| 09:58:11 | <omarIRD> http://pastebin.com/3ndCMXby |
| 09:58:26 | <omarIRD> Daniel this is the log file |
| 09:58:33 | <magoo> url http://pastebin.com/vRt3Yq0P |
| 09:59:04 | <magoo> that's when i try to build openmrs as a maven build |
| 10:04:15 | <goutham> bwolfe: Hi |
| 10:05:31 | <dkayiwa> magoo which os do you use? |
| 10:05:55 | <magoo> win xp professional service pack 2 |
| 10:06:14 | <dkayiwa> magoo: on the eclipse window menu, select preferences |
| 10:06:23 | <dkayiwa> then select installed JREs |
| 10:06:34 | <dkayiwa> and tell me which is selected on the right hand side |
| 10:06:57 | *** bwolfe has quit IRC |
| 10:08:21 | <magoo> in the execution environment |
| 10:08:54 | <dkayiwa> magoo no |
| 10:09:10 | <dkayiwa> magoo just click to select installed jre |
| 10:09:16 | <dkayiwa> s |
| 10:09:22 | <dkayiwa> not its kids |
| 10:09:41 | <dkayiwa> then tell me what you see |
| 10:09:50 | <magoo> okay |
| 10:10:16 | <magoo> jre6 |
| 10:10:29 | <dkayiwa> change it to jdc |
| 10:10:36 | <dkayiwa> sorry i meant jdk |
| 10:10:58 | <dkayiwa> add the jdk and remove the jre |
| 10:11:09 | <magoo> i click on the add button |
| 10:11:14 | <dkayiwa> yes |
| 10:11:26 | <dkayiwa> and browse for you jdk installation folder |
| 10:12:18 | <magoo> what should i choose on the installed jre type? |
| 10:12:29 | <dkayiwa> the jdk |
| 10:14:40 | <magoo> i have three type in the jre type Execution environment,starndard 1.1.x VM, and starndard VM |
| 10:14:50 | <dkayiwa> omarIRD a status of zero means failure on server |
| 10:15:14 | <dkayiwa> leave execution env alone |
| 10:17:41 | <magoo> confused enlighten more sorry |
| 10:18:14 | <omarIRD> daniel I know but do you know why responseStatus as 1 is interpreted as 0 in the client |
| 10:18:21 | <dkayiwa> magoo |
| 10:18:22 | <dkayiwa> dkayiwa: then select installed JREs |
| 10:18:22 | <dkayiwa> [1:32pm] dkayiwa: and tell me which is selected on the right hand side |
| 10:18:55 | <omarIRD> I have debugging on. I can see the server writing 1 instead of 0 to the output stream |
| 10:19:54 | <dkayiwa> omarIRD: am not sure of whats wrong with the client |
| 10:21:00 | *** finbrein has joined #openmrs |
| 10:21:41 | <omarIRD> ok. |
| 10:22:11 | <magoo> this is what i see on the right hand side Name: jre6, Location: F:\Program Files\Java\jre6, Type: Standard VM that what i see F: is my local drive |
| 10:22:36 | <dkayiwa> remove jre and add jdk |
| 10:24:03 | <surangak> magoo, do add ->standard vm -> and giv path to your jdk / bin |
| 10:24:19 | <magoo> okay |
| 10:26:41 | *** omarIRD has quit IRC |
| 10:27:59 | <magoo> this is what i have done Name: jdk Location: F:\Program Files\java\jdk1.6.0_26,Type: Standard VM |
| 10:31:44 | <magoo> dkayiwa it seem there is something wrong with jdk bin folder when i select is i get the following error msg Target is not a JDK Root. Java executable was not found |
| 10:32:32 | <dkayiwa> magoo just select the root of the jdk not the bin folder |
| 10:32:45 | <magoo> okay |
| 10:33:25 | <magoo> is this okay F:\Program Files\java\jdk1.6.0_26 |
| 10:36:48 | *** danielf` has joined #openmrs |
| 10:36:48 | *** ChanServ sets mode: +v danielf` |
| 10:37:01 | <magoo> dkayiwa then i rebuild |
| 11:03:58 | <rafa> dkayiwa: what was the fix for accessing modules urls? |
| 11:04:35 | <dkayiwa> rafa: the urls were working even without i started any work |
| 11:04:46 | <rafa> oh ok |
| 11:04:47 | <rafa> thanks |
| 11:07:34 | <dkayiwa> they just looked ugly |
| 11:07:46 | <dkayiwa> oh some of them like moduleResources were not working |
| 11:07:50 | <dkayiwa> so i fixed them |
| 11:11:06 | <magoo> dkayiwa: when i rebuild i get the following url http://pastebin.com/s8TDLLXR |
| 11:15:15 | <surangak> magoo, in your code, im seeing this line |
| 11:15:30 | <surangak> magoo, line 61 : [ERROR] Unknown lifecycle phase "instal" |
| 11:15:49 | <surangak> magoo, it should be mvn clean install ( note the double l 's) |
| 11:16:09 | <magoo> hahaha.. sorry |
| 11:16:24 | <magoo> infarct i was rectifying it |
| 11:16:38 | <surangak> magoo, did u type in instal before ? that should be the problem... |
| 11:16:59 | <magoo> yes typo error |
| 11:28:25 | *** bwolfe has joined #openmrs |
| 11:28:25 | *** ChanServ sets mode: +o bwolfe |
| 11:35:43 | <magoo> i'm getting these messages url http://pastebin.com/nkrF6rz9 |
| 11:37:59 | *** james_regen has joined #openmrs |
| 11:37:59 | *** ChanServ sets mode: +v james_regen |
| 11:40:19 | *** upul` has quit IRC |
| 11:40:42 | <surangak> magoo, it looks to me like xerces-impl jar did not get downloaded |
| 11:40:52 | <surangak> magoo, what hav u got in your F:\Documents and Settings\MAGOO\.m2\repository\xerces\xercesImpl\2.8.0\ |
| 11:41:11 | <surangak> magoo, have you got xercesImpl-2.8.0 |
| 11:42:49 | <magoo> surangak: let me check |
| 11:58:21 | <magoo> surangak: i have this F:\Documents and Settings\MAGOO\.m2\repository\xerces\xercesImpl\2.8.0 |
| 11:58:41 | <surangak> is there a jar in it ? |
| 11:58:51 | <surangak> xercesImpl-2.8.0.jar |
| 11:59:51 | <magoo> yes |
| 12:00:51 | <surangak> magoo, mmmm.... I had assumed that it would be missing... |
| 12:01:28 | <surangak> magoo, I seem to have run out of ideas |
| 12:01:44 | <surangak> magoo, maybe u could try re running the clean install command... :( |
| 12:01:58 | <magoo> okay thx for help |
| 12:01:59 | <magoo> okay |
| 12:12:03 | <rafa> dkayiwa: Did you manage to fix loading resources in modules? |
| 12:12:17 | <rafa> dkayiwa: It's not working for me. |
| 12:12:29 | <rafa> dkayiwa: I mean I only tested metadatasharing |
| 12:13:03 | *** gbastien has joined #openmrs |
| 12:16:06 | *** dkayiwa has quit IRC |
| 12:18:48 | *** goutham has quit IRC |
| 12:29:45 | *** wyclif has quit IRC |
| 12:32:34 | <magoo> surangak: observe this url http://pastebin.com/2tFZS1a8 |
| 12:34:15 | <surangak> magoo, this is only for the tools isnt it ? |
| 12:43:52 | <magoo> yap |
| 12:44:33 | <magoo> surangak: so i need to build for each individual module |
| 13:04:54 | <djazayeri> bwolfe: design? |
| 13:05:14 | <bwolfe> hmm, sitting on the wrong one I suppose |
| 13:05:18 | * bwolfe looks up correct ping |
| 13:05:30 | <djazayeri> 305801 |
| 13:05:54 | <bwolfe> *pin |
| 13:05:56 | <bwolfe> in |
| 13:07:04 | *** jriley has joined #openmrs |
| 13:07:38 | <magoo> surangak: i need to build each project separately |
| 13:09:55 | *** dkayiwa has joined #openmrs |
| 13:13:22 | <magoo> dkayiwa check out this http://pastebin.com/2tFZS1a8 |
| 13:17:54 | <bwolfe> djazayeri: got kicked from freeconf |
| 13:18:37 | <bwolfe> djazayeri: I'm saying if you find a few other methods in adminservice that are more appropriate in something like a utility service, then go for it |
| 13:19:31 | <magoo> dkayiwa have u seen the warnings |
| 13:20:25 | *** wyclif has joined #openmrs |
| 13:20:56 | <dkayiwa> yes |
| 13:22:24 | <magoo> how do i fix the warnings by updating the mavin plugins |
| 13:24:46 | *** jriley has quit IRC |
| 13:35:26 | <bwolfe> you can't hear me djazayeri ? |
| 13:36:57 | *** bumi has joined #openmrs |
| 13:42:40 | <bumi> Hi guys, i have posted this in implementers' list but i have got no solution so far, any ideas please, url:http://pastebin.com/scDp4yrV |
| 13:46:22 | *** finbrein has quit IRC |
| 13:59:29 | <bumi> \quit |
| 13:59:56 | *** bumi has quit IRC |
| 14:00:14 | <magoo> dkayiwa check out this http://pastebin.com/xyQSiq53 |
| 14:02:39 | <djazayeri> good morning! |
| 14:02:41 | <djazayeri> scrum time |
| 14:02:58 | <djazayeri> bwolfe, dkayiwa, wyclif, rafa |
| 14:03:13 | <rafa> hey! |
| 14:03:35 | <wyclif> hi |
| 14:03:37 | <bwolfe> yo |
| 14:04:32 | <dkayiwa> :) |
| 14:04:41 | <djazayeri> okay, who wants to go first today? |
| 14:05:57 | <rafa> Today: |
| 14:05:57 | <rafa> * Code-reviews |
| 14:05:57 | <rafa> * Resolved TRUNK-2492: In 2.x a stopped and started module does not register service beans |
| 14:05:57 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2492 |
| 14:05:57 | <rafa> * In progress TRUNK-2083: Allow data-driven forms from a form schema in the database |
| 14:05:57 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2083 |
| 14:05:57 | <rafa> Tomorrow: |
| 14:05:58 | <rafa> * Continue with TRUNK-2083 |
| 14:05:58 | <rafa> * Devs call |
| 14:05:59 | <rafa> * MSD testing |
| 14:05:59 | <rafa> No blockers. |
| 14:06:14 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Address Hierarchy 2.1.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=addresshierarchy&version=&2.1.1> |
| 14:06:22 | <djazayeri> Is MDS testing for Piotr? |
| 14:06:24 | <bwolfe> msd testing? |
| 14:06:30 | <rafa> yes |
| 14:06:35 | <djazayeri> (metadata sharing) |
| 14:06:40 | <bwolfe> is that similar to lsd experimentation |
| 14:06:59 | <rafa> hehe |
| 14:07:20 | <djazayeri> Okay, if necessary HFE trunk should be ready to go with MDS 0.9 |
| 14:07:20 | <rafa> no to confuse Ben ;) |
| 14:07:27 | <bwolfe> how goes the data driven form stuff? I like the prospects of that, but fear it is monumental... |
| 14:07:53 | <rafa> bwolfe: it'll be just a basic case for now |
| 14:08:19 | <rafa> bwolfe: to show possibilities :) |
| 14:08:33 | <djazayeri> yeah, rafa, try to do the simplest version possible. you must definitely finish it before going on vacation |
| 14:08:40 | <rafa> djazayeri: cool |
| 14:08:48 | <bwolfe> ok, makes sense |
| 14:09:03 | *** magoo_ has joined #openmrs |
| 14:09:10 | *** magoo has quit IRC |
| 14:09:24 | *** magoo has joined #openmrs |
| 14:09:28 | <djazayeri> rafa: regarding the module ticket you fixed, are you relatively confident that module loading/reloading is working correctly now? |
| 14:09:46 | <rafa> djazayeri: yes, I'm quite confident |
| 14:09:52 | <djazayeri> I feel like we keep running into "just one more bug" about it, and I wonder if we've done something different in 2.x vs 1.x |
| 14:10:47 | <djazayeri> okay, next? wyclif, dkayiwa? |
| 14:10:54 | <bwolfe> rafa: somethign that doesn't support everything, but does support a few basic/simple types would be great |
| 14:11:14 | <rafa> bwolfe: yes, it's the idea |
| 14:11:50 | <bwolfe> cool |
| 14:11:59 | <rafa> djazayeri: are there any chances for HFE to be released soon? |
| 14:12:01 | <wyclif> yesterday: |
| 14:12:02 | <wyclif> * completed work with trunk-2457, add manage settings page, started on trunk-2476, user defined page views |
| 14:12:02 | <wyclif> today: |
| 14:12:02 | <wyclif> * continue work with trunk-2475 |
| 14:13:05 | <djazayeri> 57? or 76? |
| 14:13:07 | <bwolfe> !ticket TRUNK-2475 |
| 14:13:08 | <OpenMRSBot> bwolfe: [#TRUNK-2475] Allow user-defined page views to be stored in the database - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2475 |
| 14:13:16 | <bwolfe> !ticket TRUNK-2476 |
| 14:13:17 | <OpenMRSBot> bwolfe: [#TRUNK-2476] liquibase changeset - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2476 |
| 14:13:42 | <wyclif> sorry! trunk-2475 |
| 14:14:20 | *** surangak has quit IRC |
| 14:14:41 | <wyclif> TRUNK-2476 is a subticket for it |
| 14:14:56 | <djazayeri> wyclif: cool, let me know if you have any questions about trunk-2475 |
| 14:14:56 | <bwolfe> its terribly named, fwiw |
| 14:15:08 | <bwolfe> 2475 looks to be a really cool feature too |
| 14:15:09 | <djazayeri> I think this is going to be really cool when it's done |
| 14:15:22 | <bwolfe> just about as cool as the data driven forms one...but not quite ;-) |
| 14:15:37 | <bwolfe> wyclif: how goes that, does it look doable? |
| 14:15:44 | <djazayeri> let me know if you have any questions |
| 14:16:01 | <bwolfe> brb, need to go shut the windows on my car |
| 14:16:33 | <djazayeri> okay |
| 14:16:37 | <djazayeri> dkayiwa: ? |
| 14:16:45 | <djazayeri> ? = your turn |
| 14:16:49 | <dkayiwa> Looks like am done with TRUNK-2456 (We need to do our best to allow 1.x modules to work in 2.x.) |
| 14:16:49 | <dkayiwa> Just doing some random manual tests to make sure i have not left out anything. |
| 14:16:50 | <dkayiwa> Next: Working on TRUNK-2489 (https://tickets.openmrs.org/browse/TRUNK-2489) |
| 14:16:50 | <dkayiwa> No blockers |
| 14:16:50 | <dkayiwa> rafa, you reported a problem with metadatasharing in 2.x. when did you last update? |
| 14:17:19 | *** magoo_ has quit IRC |
| 14:17:30 | <wyclif> it looks doable |
| 14:17:35 | <rafa> dkayiwa: I'll test it right now |
| 14:17:41 | <dkayiwa> ok |
| 14:17:41 | <djazayeri> dkayiwa: TRUNK-2456 is still "In Progress" is it ready for review now? |
| 14:18:12 | <dkayiwa> djazayeri: i need to first get all the small commit revisions i did for it |
| 14:18:33 | <djazayeri> Okay |
| 14:18:42 | <bwolfe> !ticket TRUNK-2456 |
| 14:18:43 | <dkayiwa> thats by today |
| 14:18:44 | <OpenMRSBot> bwolfe: [#TRUNK-2456] Make Reporting module work as much as possible in 2.x - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2456 |
| 14:18:50 | <bwolfe> !ticket TRUNK-2489 |
| 14:18:51 | <OpenMRSBot> bwolfe: [#TRUNK-2489] 2.x needs to support fieldgen - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2489 |
| 14:19:15 | <djazayeri> With the trunk-2489 fieldGen ticket, do make sure that you keep the code that you copy over confined to the compatibility1x sub-project |
| 14:19:26 | <dkayiwa> ok |
| 14:19:34 | <djazayeri> can you create a "compatibility" folder under WEB-INF and put the fieldgen jsp stuff in there? |
| 14:19:42 | <dkayiwa> ok |
| 14:20:13 | <djazayeri> Basically, fieldgen includes a whole bunch of code, and we want to bring it over purely for module compatibility purposes. I don't want anyone else to accidentally use it going forwards. :-) |
| 14:20:29 | <dkayiwa> ok :) |
| 14:21:57 | <djazayeri> no blockers? |
| 14:21:59 | *** jportela has joined #openmrs |
| 14:21:59 | *** ChanServ sets mode: +v jportela |
| 14:22:10 | <dkayiwa> oh i remembered one blocker |
| 14:22:29 | <djazayeri> dkayiwa: by the way, it's really cool to be able to do an svn update, and suddenly a module is working. :-) |
| 14:22:29 | *** robbyoconnor has joined #openmrs |
| 14:22:29 | *** ChanServ sets mode: +v robbyoconnor |
| 14:22:30 | <dkayiwa> for the reporting module, some pages report JQuery not defined error message |
| 14:22:45 | <dkayiwa> did that happen? |
| 14:22:46 | <djazayeri> only some do? |
| 14:23:28 | <rafa> dkayiwa: regarding the problem with mds it is that I use openmrs:htmlInclude file="/scripts/jquery/jquery-1.3.2.min.js and it translates to /openmrs2/scripts/jquery/jquery.min.js?v=1.9.0.21855 which is missing |
| 14:23:45 | <dkayiwa> oh i see |
| 14:23:55 | <dkayiwa> let me look into that rafa |
| 14:23:57 | <djazayeri> rafa, dkayiwa: that's some "clever" code I added in 1.7 |
| 14:24:13 | <bwolfe> thats a quick fix rafa |
| 14:24:15 | <djazayeri> see openmrs_static_content-servlet.xml |
| 14:24:21 | <djazayeri> (in 1.x) |
| 14:24:28 | <djazayeri> we need to preserve those same mappings in 2.x |
| 14:24:48 | <djazayeri> or rather, do the mappings "right" in 2.x |
| 14:25:12 | <bwolfe> at least preserve the "urlRewrites" from that file |
| 14:25:18 | <rafa> yes, it's nice :) |
| 14:27:25 | <bwolfe> ok |
| 14:27:48 | <bwolfe> dkayiwa: pretty sure that should fix your reporting pages too |
| 14:28:04 | <dkayiwa> which one bwolfe |
| 14:28:05 | <dkayiwa> ? |
| 14:28:25 | <bwolfe> the htmlinclude rewrite |
| 14:28:31 | <bwolfe> the one that rafa just brought up :-p |
| 14:28:56 | <djazayeri> dkayiwa: In 2.x I see a PageContext.translateResource method |
| 14:28:57 | *** dkayiwa has quit IRC |
| 14:29:37 | <djazayeri> currently there's a static Map in PageContext.java |
| 14:30:17 | <djazayeri> you should be able to use that, or add to that map, in some fashio |
| 14:30:25 | <rafa> djazayeri: daniel is missing |
| 14:30:31 | <djazayeri> oops |
| 14:31:22 | <bwolfe> ok, I'll jump in then |
| 14:31:25 | <bwolfe> today: |
| 14:31:26 | <bwolfe> fixed occ module tickets |
| 14:31:26 | <bwolfe> added a few occ tickets |
| 14:31:26 | <bwolfe> answered some emails |
| 14:31:26 | <bwolfe> danced a jig |
| 14:31:26 | <bwolfe> rebuilt ui2, hope to work on that in the bg of tonights calls |
| 14:31:31 | <bwolfe> tomorrow: |
| 14:31:33 | <bwolfe> occ, ui2 |
| 14:32:52 | <djazayeri> bwolfe: cool, I expect you to catch Rafal in number of sprint tickets done |
| 14:33:16 | <rafa> bwolfe: danced a jig? |
| 14:33:28 | <bwolfe> just making sure ya'll are paying attention :-) |
| 14:33:40 | * bwolfe looks up rafa's ticket total |
| 14:33:41 | <rafa> bwolfe: haha |
| 14:34:37 | <bwolfe> 6 tickets? np |
| 14:34:41 | <djazayeri> bwolfe: a clever technique is to write code that initially seems to work, then have some bugs arise. if you swing it right you can get three tickets out of one issue. :-) |
| 14:34:42 | <bwolfe> I only need 5 more to catch him |
| 14:34:50 | <bwolfe> hahaha |
| 14:35:00 | <djazayeri> Okay, my turn: |
| 14:35:02 | <djazayeri> Tuesday: |
| 14:35:02 | <djazayeri> * refactored and checked in code for the stuff I did Monday |
| 14:35:02 | <djazayeri> * a bit of sprint code review |
| 14:35:02 | <djazayeri> * code review for ankur, and some TW people |
| 14:35:02 | <djazayeri> * doesn't sound like I did very much. :-( |
| 14:35:03 | <djazayeri> Today: |
| 14:35:03 | <rafa> haha |
| 14:35:04 | <djazayeri> * design calls |
| 14:35:04 | <djazayeri> * sprint code review |
| 14:35:05 | <djazayeri> * another sprint ticket |
| 14:35:41 | <djazayeri> no blockers |
| 14:35:51 | <bwolfe> rafa's "haha" showed up in the middle of darius' update. looks like darius is doing "haha" today |
| 14:36:21 | <djazayeri> I do "haha" everyday. |
| 14:36:53 | <bwolfe> its good to have a little haha in your life. |
| 14:36:54 | <rafa> yeah that's the way! :D |
| 14:37:02 | <djazayeri> so, scrum done? |
| 14:37:04 | <djazayeri> any more questions? |
| 14:37:11 | <djazayeri> or comments? |
| 14:37:31 | <bwolfe> win has a hahahahahaha in his life every day it seems. (thats usually the first thing he says in the morning in our rg chat room) |
| 14:38:04 | *** danielf` has quit IRC |
| 14:38:12 | <bwolfe> did the ci build help you yesterday darius? :-) I saw an email go out about it |
| 14:38:13 | *** dkayiwa has joined #openmrs |
| 14:38:34 | <djazayeri> bwolfe: actually I didn't notice the emails until after I'd fixed it. |
| 14:38:46 | *** gbastien has quit IRC |
| 14:38:47 | <bwolfe> ah, bummer |
| 14:38:55 | <djazayeri> gmail doesn't mark those as "priority inbox" emails. :-) |
| 14:39:35 | <rafa> djazayeri: he'll learn ;) |
| 14:39:42 | <rafa> or else you need to teach him |
| 14:40:12 | <djazayeri> I've already taught it that CI emails are junk. :-) |
| 14:40:22 | <bwolfe> haha |
| 14:40:42 | <rafa> haha |
| 14:40:44 | <bwolfe> thats due to the large number of them that came through and you just archived without reading probably |
| 14:40:50 | *** bryq has quit IRC |
| 14:42:05 | <djazayeri> dkayiwa: you there now? |
| 14:42:19 | <dkayiwa> yes was disconnected |
| 14:42:30 | <djazayeri> okay, here's a summary of key points for you: |
| 14:42:31 | <djazayeri> * See "urlRewrites" in openmrs_static_content-servlet.xml. You need to preserve those. |
| 14:42:31 | <djazayeri> * See also, in 2.x, PageContext.translateResource(String) and the static map it refers to. |
| 14:42:31 | <djazayeri> * You may need to add the 1.x url rewrites to 2.x. You may need to have the htmlInclude tag use the translateResource map. |
| 14:42:37 | <dkayiwa> oh thanks |
| 14:42:56 | <dkayiwa> ok |
| 14:43:06 | <djazayeri> that should be the solution both for the MDS module issue of Rafal's and for the reporting module issues. |
| 14:43:16 | <dkayiwa> ok |
| 14:43:59 | <rafa> ohh btw I think I've fixed sound in google+, if you want to try again |
| 14:44:12 | <bwolfe> what was the issue? |
| 14:44:17 | *** bryq has joined #openmrs |
| 14:44:17 | *** ChanServ sets mode: +v bryq |
| 14:44:41 | <rafa> my sound card was working with a too good quality |
| 14:44:44 | *** magoo has quit IRC |
| 14:44:54 | <bwolfe> ha |
| 14:45:10 | <rafa> over 48 000 khz is not supported by gtalk |
| 14:45:23 | <bwolfe> strange |
| 14:45:29 | <bwolfe> too much bandwidth maybe? |
| 14:45:39 | <rafa> at least on my computer |
| 14:45:59 | <rafa> yeah it might be |
| 14:46:57 | <djazayeri> okay, perhaps friday we can try google plus again |
| 14:47:40 | <djazayeri> dkayiwa, wyclif, bwolfe, rafa: got that? friday we try a google+ hangout for the scrum |
| 14:47:51 | <dkayiwa> ok |
| 14:48:11 | <rafa> cool |
| 14:48:13 | <wyclif> sure |
| 14:48:19 | <bwolfe> okeys |
| 14:48:36 | <bwolfe> I'll start saving up bandwidth now |
| 14:48:43 | <dkayiwa> :D |
| 14:48:51 | *** lh has joined #openmrs |
| 14:51:10 | *** rahul has joined #openmrs |
| 14:51:38 | <rahul> bwolfe hi |
| 14:51:45 | <bwolfe> hi |
| 14:52:06 | <rahul> bwolfe have saw the mail |
| 14:52:07 | <rahul> ? |
| 14:52:18 | <rahul> have you*? |
| 14:52:32 | <wyclif> djazayeri, i want to discuss trunk-2475 |
| 14:52:46 | <bwolfe> yes, but havne't had a chance to look at it yet today |
| 14:53:06 | <djazayeri> wyclif: okay |
| 14:53:37 | <rahul> bwolfe : okay can you see and tell the solution when are free ? |
| 14:53:38 | <djazayeri> a general question or a specific one? |
| 14:54:09 | <bwolfe> rahul: when is this being called? from a schedueld task? a port? a post? a controller? |
| 14:54:12 | <wyclif> djazayeri, more about the design of the user defined pages |
| 14:54:29 | <rahul> bwolfe : from a controller |
| 14:54:42 | <bwolfe> you might need to open/close the openmrs session if you're not in a controller. Context.openSession().... try / finally { Context.closeSession(); } |
| 14:55:13 | <djazayeri> wyclif: the idea is that the framework will (already) automatically loop over all PageViewProviders |
| 14:55:24 | <bwolfe> rahul: where is populatePID getting called from? |
| 14:55:48 | <rahul> bwolfe : from Service Implementation |
| 14:55:54 | <djazayeri> wyclif: so, when you try to visit the page "myPage" it will look in core, modules, and (once you've added this) the the new table-based one |
| 14:55:57 | <djazayeri> until it finds a match |
| 14:56:00 | <bwolfe> ok, send that link out too rahul |
| 14:56:03 | <bwolfe> I need to run. bbl |
| 14:57:00 | <rahul> bwolfe :http://svn.openmrs.org/openmrs-modules/pixpdq/branches/api/src/main/java/org/openmrs/module/pixpdq/impl/HL7PIXPDQServiceImpl.java |
| 14:57:05 | <OpenMRSBot> <http://ln-s.net/91O+> (at svn.openmrs.org) |
| 14:57:17 | <wyclif> ok |
| 14:57:21 | *** pascal` has quit IRC |
| 14:57:50 | <djazayeri> wyclif: in the only xml configuration required should be to instantiate a new copy of your bean in app-config.xml, around the "additionalViewProviders" for PageFactory |
| 14:58:28 | <wyclif> djazayeri, which class represents the definition of a view or is it just text |
| 14:59:32 | <djazayeri> in the database it'll just be text |
| 14:59:55 | <djazayeri> I believe you'll use the existing GroovyPageView too |
| 14:59:58 | <rahul> bwolfe : did u get that link ? |
| 15:00:04 | <wyclif> ok |
| 15:10:27 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Problem with getAllergies <http://forum.openmrs.org/viewtopic.php?f=8&t=801#p3029> |
| 15:12:53 | *** asgoyal has joined #openmrs |
| 15:19:45 | <rahul> bwolfe : there? |
| 15:28:47 | *** lh has quit IRC |
| 15:32:17 | *** dkayiwa has quit IRC |
| 16:03:21 | *** magoo has joined #openmrs |
| 16:14:12 | *** magoo has quit IRC |
| 16:14:15 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OSCON - Talk about projects saving the world: join our Humanitarian open source BoF session tonight at 8pm in E143. #HFOSS <http://twitter.com/OpenMRS/statuses/96245977052233728> || On Twitter: OpenMRS: RT @ScottMuc: Really diving deep into @OpenMRS this evening. Shaking off my old developer cobwebs. Would love to make the xml db test da ... <http://twitter.com/OpenMRS/statuses/96242669122105344> |
| 16:24:40 | <bryq> bwolfe: Hi |
| 16:37:18 | *** rahul has quit IRC |
| 17:00:00 | *** Suranga has joined #openmrs |
| 17:16:10 | *** Suranga has quit IRC |
| 17:55:37 | <bwolfe> hi bryq (very late reply) |
| 17:58:19 | <wyclif> bwolfe, djazayeri, rafa if you run the changeset that adds the ui2-page-view table, you will have to drop it before rerunning the new changeset since i have changed the id and edited its details |
| 17:59:09 | <djazayeri> thanks for the warning |
| 18:02:31 | *** chopin has joined #openmrs |
| 18:04:45 | <chopin> hey folks |
| 18:05:03 | <djazayeri> hiya |
| 18:05:22 | <chopin> in a unit test, when i run executeDataset() on a data set then immediately try to access that data via the API, the data's not present ... should I flush something? |
| 18:05:33 | <bryq> bwolfe: Nothing now, I've solved my problem |
| 18:07:22 | *** bwolfe has quit IRC |
| 18:07:56 | *** bwolfe has joined #openmrs |
| 18:07:56 | *** ChanServ sets mode: +o bwolfe |
| 18:21:39 | <chopin> so ... any ideas why the API calls don't see data from the dataset? |
| 18:21:48 | <chopin> i thought we had run into this before ... |
| 18:21:55 | <djazayeri> chopin: it's always worked for me... |
| 18:21:58 | <chopin> either that or i need to use a smaller data set |
| 18:22:26 | <chopin> is it possible to ignore the standard test dataset? |
| 18:22:30 | <djazayeri> yes |
| 18:22:43 | <djazayeri> @SkipDefaultSetup (or something like that. @Skip + control-space) |
| 18:22:58 | <chopin> cool ... i'll try that |
| 18:23:01 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): gender attribute type <http://feedproxy.google.com/~r/OMRStrunk/~3/QSf6id1lX6Y/OpenMRS> || New Changeset: OpenMRS (improved-person-attribute-type): civil status attribute type <http://feedproxy.google.com/~r/OMRStrunk/~3/laF5_Aycs-s/OpenMRS> |
| 18:23:07 | <chopin> i might have been interfering somehow |
| 18:23:21 | <djazayeri> SkipBaseSetup? |
| 18:27:42 | *** yanokwa has joined #openmrs |
| 18:27:42 | *** ChanServ sets mode: +v yanokwa |
| 18:31:31 | *** yanokwa has quit IRC |
| 18:31:37 | *** yanokwa has joined #openmrs |
| 18:31:37 | *** ChanServ sets mode: +v yanokwa |
| 18:51:31 | *** bryq1 has joined #openmrs |
| 18:53:50 | *** bryq has quit IRC |
| 19:21:24 | *** suho has joined #openmrs |
| 19:21:24 | *** ChanServ sets mode: +v suho |
| 19:28:13 | *** magoo has joined #openmrs |
| 19:30:41 | *** magoo has quit IRC |
| 19:37:13 | <wyclif> djazayeri, can i have an example of the contents of content of a user defined view? |
| 19:37:29 | <wyclif> i.e the definition |
| 19:37:38 | <djazayeri> Hello ${ context.authenticatedUser } |
| 19:38:11 | <djazayeri> (Anything that can be in a gsp page) |
| 19:38:16 | <wyclif> it only contains text? because am trying to figure out how to resolve the controller name |
| 19:38:31 | <wyclif> does that mean no controller? |
| 19:38:37 | <bryq1> rafa: Hi |
| 19:38:48 | <djazayeri> wyclif: just return null for that method |
| 19:39:05 | <rafa> hi bryq1 |
| 19:39:12 | <wyclif> return null for getView() |
| 19:39:19 | <djazayeri> (actually you should preserve the hack that's in the core one, which looks for a <!-- CONTROLLER ... |
| 19:39:23 | <djazayeri> not for getView |
| 19:39:39 | <bryq1> rafa: Regarding your mail: are you using latest branch revision? |
| 19:39:43 | <wyclif> am in a PageViewprovider |
| 19:39:47 | <rafa> bryq1: yes |
| 19:40:02 | <bryq1> rafa: Which OpenMRS version? |
| 19:40:05 | <rafa> I just updated |
| 19:40:08 | <rafa> 1.8.x |
| 19:40:27 | <rafa> is it working for you? |
| 19:40:37 | <djazayeri> wyclif: look at what's in GroovyPageViewProvider.getView |
| 19:40:52 | <wyclif> djazayeri, am looking at that |
| 19:41:03 | <wyclif> and it resolvers a controller name |
| 19:41:11 | <rafa> bryq1 |
| 19:41:41 | <bryq1> rafa: Yes, everything works for me |
| 19:41:54 | <djazayeri> wyclif: so, make the controller name null at first |
| 19:41:57 | <bryq1> rafa: But I'm running OpenMRS 1.6 |
| 19:42:08 | <bryq1> rafa: I will check 1.8 |
| 19:42:10 | <wyclif> ok |
| 19:42:20 | <bryq1> rafa: Wait ~30 minutes |
| 19:42:23 | <djazayeri> or else copy exactly the logic that uses the regex to look for the contorller comment |
| 19:45:08 | <rafa> bryq1: I remember the problem |
| 19:45:11 | <wyclif> ok, we will need to do some refactoring at a later point as you suggested on the ticket and add some type hierachy |
| 19:45:33 | <rafa> bryq1: openmrsVersion is null and it fails validation |
| 19:46:00 | <bryq1> rafa: It could be the point |
| 19:46:11 | <rafa> bryq1: do you recall removing "if" here while merging? |
| 19:47:30 | <rafa> bryq1: see PackageValidator#validate |
| 19:47:44 | <rafa> bryq1: you reject when openmrsVersion is null |
| 19:48:16 | <rafa> bryq1: there's a bug in jetty and it does not initialize openmrsVersion properly |
| 19:48:29 | <rafa> bryq1: see my workaround in validateForWarnings |
| 19:49:15 | <rafa> bryq1: actually you can remove that assert from validate |
| 19:49:18 | <bryq1> rafa: I wanted to ask you one time why you are checking if openmrsversion is null, but I had forgotten to do it |
| 19:49:23 | <bryq1> rafa: I don't recall it |
| 19:49:23 | <bryq1> rafa: But why it is null? |
| 19:49:39 | <rafa> OpenmrsConstants.OPENMRS_VERSION is not set properly |
| 19:49:50 | <rafa> when running on jetty |
| 19:49:55 | <rafa> it works fine on tomcat |
| 19:50:07 | <rafa> I didn't investigate it further |
| 19:50:20 | <bryq1> rafa: Ohh, okay |
| 19:50:42 | <rafa> Comment it better than me :) |
| 19:51:12 | <bryq1> rafa: Is there any ticket for this bug? |
| 19:51:28 | <rafa> I don't think so |
| 19:51:47 | <bryq1> rafa: MDS should have information about OpenMRS version |
| 19:52:52 | <rafa> I think it's just an issue when we run openmrs on jetty with maven |
| 19:53:03 | <rafa> nothing to worry |
| 19:53:43 | <rafa> you could issue a ticket for trunk though |
| 19:54:04 | <bryq1> rafa: Good. So after removing version validation, package creation works properly? |
| 19:54:39 | <rafa> I'm trying it out right now |
| 19:54:58 | *** gbastien has joined #openmrs |
| 19:55:57 | <rafa> bryq1: yes, it works fine |
| 19:56:05 | <rafa> okay, I'll commit it. |
| 19:56:27 | <bryq1> rafa: Okay :) |
| 19:59:41 | *** dkayiwa has joined #openmrs |
| 20:00:02 | <rafa> bryq1: I'll issue a ticket for trunk too |
| 20:01:02 | <bryq1> rafa: For the null OPENMRS_VERSION? |
| 20:01:06 | *** james_regen has quit IRC |
| 20:01:26 | <rafa> yes |
| 20:01:43 | <rafa> I should have done it before. I forgot |
| 20:03:06 | *** suho has quit IRC |
| 20:23:55 | <wyclif> djazayeri, + for subtickets |
| 20:25:09 | <wyclif> djazayeri, the developer does tickets in bits, commits early small chunks of code and other developer can easily see the progress and give suggestion in time before getting off track |
| 20:25:32 | <wyclif> djazayeri, so +5 for you |
| 20:25:39 | <djazayeri> one for each subticket? |
| 20:25:47 | <wyclif> he he he, may be |
| 20:27:06 | <wyclif> djazayeri, and am learning more about the framework's internal machinery |
| 20:27:22 | <wyclif> djazayeri, before i was waiting for magic |
| 20:29:39 | *** chopin has quit IRC |
| 20:36:14 | *** asgoyal has quit IRC |
| 21:01:48 | *** dkayiwa has quit IRC |
| 21:06:07 | *** rafa has quit IRC |
| 21:07:04 | *** doverdose has joined #openmrs |
| 21:12:33 | <doverdose> hello all |
| 21:12:40 | <doverdose> i'm trying to setup my dev environment for the first time |
| 21:12:46 | <doverdose> and i'm running into some build issues |
| 21:13:04 | <doverdose> several of the unit tests for openmrs-api are failing |
| 21:13:47 | <doverdose> i'm assuming it's that the versions of code / plugins / ide are not playing nice |
| 21:24:18 | <djazayeri> doverdose: what's the error message you see? |
| 21:47:41 | *** jportela has left #openmrs |
| 21:52:05 | *** muthah has joined #openmrs |
| 21:55:54 | <doverdose> i've having the exact problem described here |
| 21:55:55 | <doverdose> http://openmrs-mailing-list-archives.1560443.n2.nabble.com/Maven-build-of-openmrs-api-fails-td6220118.html |
| 21:55:56 | <OpenMRSBot> <http://ln-s.net/8xf_> (at openmrs-mailing-list-archives.1560443.n2.nabble.com) |
| 21:56:43 | <doverdose> except that i'm building 1.9.0-SNAPSHOT instead of 1.8.x |
| 22:09:11 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Great to see our friends at Indivo presenting their PHR platform at #OSCON today. Info: http://bit.ly/oZGHNA #HealthIT #eHealth <http://twitter.com/OpenMRS/statuses/96338961651339264> |
| 22:21:56 | *** gbastien has quit IRC |
| 22:33:01 | *** jportela has joined #openmrs |
| 22:33:01 | *** ChanServ sets mode: +v jportela |
| 22:33:40 | *** jportela has left #openmrs |
| 22:41:13 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @ianmfore: Open source EHRs need communities to share customizations. Cheaper than customizing commercial EHR systems http://t.co/z0g ... <http://twitter.com/OpenMRS/statuses/96342112097943552> |
| 22:44:20 | *** doverdose has quit IRC |
| 22:44:52 | *** gbastien has joined #openmrs |
| 22:47:34 | *** wyclif has quit IRC |
| 22:48:24 | *** djazayeri1 has joined #openmrs |
| 22:50:14 | *** djazayeri has quit IRC |
| 23:27:02 | *** deadpool has joined #openmrs |