| 00:40:59 | *** wyclif has quit IRC |
| 00:41:25 | *** wyclif has joined #openmrs |
| 00:42:12 | *** mathiaslin has joined #openmrs |
| 01:04:20 | *** jportela has joined #openmrs |
| 01:04:20 | *** ChanServ sets mode: +v jportela |
| 01:04:45 | *** jportela has left #openmrs |
| 01:35:00 | *** yanokwa has quit IRC |
| 01:35:38 | *** suhothayan has joined #openmrs |
| 01:35:38 | *** ChanServ sets mode: +v suhothayan |
| 02:22:57 | <wyclif> djazayeri, is there any form of binding in the framework when submitting a form |
| 02:23:11 | <wyclif> or for now it is manual |
| 02:23:34 | <wyclif> i have to generate and read parameter named for all my form fields |
| 02:25:55 | *** yanokwa has joined #openmrs |
| 02:25:55 | *** ChanServ sets mode: +v yanokwa |
| 02:28:13 | <djazayeri> wyclif: there's a way |
| 02:28:17 | <djazayeri> i added it since the last sprin |
| 02:28:41 | <wyclif> is it on the documentation? |
| 02:30:42 | <djazayeri> wyclif: ticket is https://tickets.openmrs.org/browse/TRUNK-2216 |
| 02:31:32 | <djazayeri> I believe my last comment on that ticket is the best documentation we have |
| 02:32:23 | <djazayeri> gotta run to dinner now |
| 02:46:36 | <wyclif> great |
| 02:46:43 | <wyclif> this is what i was looking for |
| 02:48:30 | *** asgoyal has joined #openmrs |
| 02:55:08 | <wyclif> i don't think it handles lists |
| 02:55:15 | <wyclif> djazayeri, i don't think it handles lists |
| 02:56:08 | <wyclif> i.e if the property is a list, does it bind to the properties of the respective list item in the list like spring does? |
| 03:05:38 | *** muthah has quit IRC |
| 03:29:41 | <asgoyal> djazayeri: where is this variable "status" in conceptdrugform.jsp coming from? |
| 03:31:26 | *** mathiaslin has quit IRC |
| 03:33:33 | *** surangak has joined #openmrs |
| 03:36:48 | *** mathiaslin has joined #openmrs |
| 03:57:54 | *** yanokwa_ has joined #openmrs |
| 03:57:55 | *** yanokwa has quit IRC |
| 04:01:08 | <wyclif> asgoyal, see the attributes of the foreach tag |
| 04:01:27 | <asgoyal> ok wyclif |
| 04:01:39 | <wyclif> sorry! you mean status and not varStatus |
| 04:02:34 | <wyclif> status is set by spring to hold the value of the current property to bind |
| 04:03:32 | <wyclif> asgoyal, it is a reference to the bound property |
| 04:03:50 | <asgoyal> oooh ok ok |
| 04:03:53 | <asgoyal> now i get it |
| 04:06:21 | <wyclif> <spring:bindpath="concept"> |
| 04:06:21 | <wyclif> ${status.value} |
| 04:06:21 | <wyclif> </spring:bind |
| 04:06:21 | <wyclif> In the line above, status references the value of the propety concept of the model attribute |
| 04:11:03 | <asgoyal> oh thanks i got it :) |
| 04:11:11 | <asgoyal> wyclif: i got one more problem |
| 04:11:26 | <asgoyal> now drug.ingredients.. i can run that in a c foreach loop |
| 04:11:27 | <asgoyal> but |
| 04:11:49 | <asgoyal> then ingredient is of concept class and to get its name is again a collection |
| 04:11:52 | <asgoyal> what should i do? |
| 04:11:57 | <asgoyal> to print the name? |
| 04:17:34 | <wyclif> have you defined the var attribute for the foreach tag? |
| 04:18:16 | <wyclif> if yes, then use the dot notation |
| 04:19:20 | <wyclif> on that var |
| 04:19:58 | <asgoyal> yep trying that |
| 04:20:08 | <asgoyal> wyclif: i think i need like two foreach loops |
| 04:20:14 | <asgoyal> one which will loop over drugs |
| 04:20:26 | <asgoyal> the other which will just loop once to fetch the first name from concept |
| 04:20:38 | <asgoyal> foreach step="1" |
| 04:21:44 | <wyclif> no |
| 04:22:05 | <djazayeri> wyclif: you're right, I just wrote that form-binding thing to handle beans and/or domain objects |
| 04:22:22 | <wyclif> thanks, djazayeri |
| 04:22:27 | <djazayeri> we should write a fragment that automatically handles lists, but that's a problem for another day |
| 04:22:28 | <asgoyal> wyclif: but how do i get the name of the concept then |
| 04:22:39 | <djazayeri> if you can create a ticket and describe exactly what you were looking for, that'd help |
| 04:22:48 | <djazayeri> because I can't quite imagine it |
| 04:22:54 | <wyclif> asgoyal, dont loop over names, we prefer to print the best name in the locale |
| 04:23:04 | <wyclif> and there is a methods that does that |
| 04:23:19 | <asgoyal> but how do i do that in a jsp file? |
| 04:23:25 | <asgoyal> can i call functions in jsp ? |
| 04:23:30 | <wyclif> so i think if you concept.name.name, that should work |
| 04:23:36 | <asgoyal> oh ! |
| 04:23:40 | <wyclif> try that |
| 04:23:41 | <asgoyal> oh ok i will try |
| 04:24:32 | <asgoyal> wyclif: so i dont need spring:bind here? |
| 04:24:43 | <wyclif> asgoyal, did it work? |
| 04:24:58 | <wyclif> i doubt if it works since name is not a property on concept |
| 04:25:06 | <asgoyal> its names |
| 04:25:09 | <wyclif> yeah |
| 04:25:12 | <asgoyal> concept.names.name |
| 04:25:23 | <wyclif> try the concept_tag |
| 04:25:24 | <asgoyal> names is a conceptName class |
| 04:25:32 | *** suho__ has joined #openmrs |
| 04:25:35 | <asgoyal> concept_tag? |
| 04:25:43 | <wyclif> names is a list of conceptNames for a concept |
| 04:25:49 | <asgoyal> yes |
| 04:26:05 | <asgoyal> so concept.names.name wont work? |
| 04:27:02 | <wyclif> how about concept.name |
| 04:27:05 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: ID Generation 2.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=idgen&version=&2.1> |
| 04:27:14 | *** gauravpaliwal has joined #openmrs |
| 04:27:14 | *** ChanServ sets mode: +v gauravpaliwal |
| 04:27:23 | <gauravpaliwal> djazayeri: Hi |
| 04:27:44 | *** djazayeri has left #openmrs |
| 04:27:51 | <gauravpaliwal> suhothayan: Hi |
| 04:27:56 | <asgoyal> wyclif: that wont work i think |
| 04:28:24 | <wyclif> asgoyal, try it, i know that it should be able to work |
| 04:28:34 | <asgoyal> just concept.name? |
| 04:28:38 | <wyclif> yes |
| 04:28:45 | <wyclif> asgoyal, i think spring default to a method if it cant find a property |
| 04:28:53 | <asgoyal> oh ok |
| 04:28:58 | *** suhothayan has quit IRC |
| 04:29:00 | <gauravpaliwal> wyclif: Hi , just a query how can i test a portlet using junit anything modulethat do this |
| 04:30:23 | <wyclif> asgoyal, if looks the getter matching the property, if not it tries a method that starts with get and ends with the property name you specified |
| 04:30:30 | <wyclif> gauravpaliwal, hmm |
| 04:30:47 | <asgoyal> org.hibernate.exception.SQLGrammarException: could not initialize a collection: [org.openmrs.Drug.ingredients#2] |
| 04:30:54 | <asgoyal> with concept.names.name |
| 04:31:01 | <asgoyal> ok now i will try concept.name |
| 04:32:00 | <wyclif> gauravpaliwal, i have never written one but i know that you shoule be able to |
| 04:32:10 | <wyclif> using soring Mock objects |
| 04:32:19 | <wyclif> sorry spring mock objects |
| 04:32:40 | <gauravpaliwal> you means it works the same way the controller works ? |
| 04:32:48 | <wyclif> more less |
| 04:32:54 | <gauravpaliwal> only differnece is that it don't have any mv |
| 04:32:58 | <gauravpaliwal> i mean mvc |
| 04:33:01 | <wyclif> the approach is the same |
| 04:33:23 | <gauravpaliwal> okeys |
| 04:33:28 | <wyclif> gauravpaliwal, see PortletControllerTest |
| 04:33:45 | <gauravpaliwal> wyclif: okeys :) awesome this is what i wanted |
| 04:33:56 | <wyclif> gauravpaliwal, cool |
| 04:34:18 | <gauravpaliwal> wyclif: thanks |
| 04:34:27 | <wyclif> gauravpaliwal, no problem |
| 04:35:29 | <wyclif> asgoyal, remember to the var attribute and yout dot notation should start with its value unless you have added spring binding to it |
| 04:35:55 | <gauravpaliwal> wyclif: http://www.koders.com/java/fid0FF1627AE5B995C236F31D06748381233FBF64DC.aspx?s=Concept whoever is this he has solved my problem |
| 04:35:55 | <asgoyal> i have added a spring binding |
| 04:36:00 | <OpenMRSBot> <http://ln-s.net/91Au> (at www.koders.com) |
| 04:36:22 | <wyclif> i think the spring bind will fail |
| 04:36:31 | <wyclif> use pure jstl |
| 04:36:52 | <wyclif> i.e {varname.concept.name} |
| 04:37:06 | <asgoyal> oh ok |
| 04:37:57 | <wyclif> remember to set the varname |
| 04:39:01 | <asgoyal> wyclif: <c:forEachvar="ingredient"items="${drug.ingredients}"> |
| 04:39:01 | <asgoyal> <label>ingredient.names </label> |
| 04:39:01 | <asgoyal> </c:forEach> |
| 04:39:47 | <wyclif> use the attribute value of var |
| 04:40:21 | <wyclif> which is ingredient so it has to be ${ingredient.concept.name} |
| 04:40:45 | <asgoyal> what is .concept here? |
| 04:40:55 | <asgoyal> ingredient itself is of type concept |
| 04:41:08 | <wyclif> sorry about that |
| 04:41:22 | <wyclif> asgoyal, ${ingredient.name} |
| 04:41:27 | <asgoyal> oh ok |
| 04:41:50 | <asgoyal> hm... but there is also no property like name in it... its names |
| 04:42:04 | <asgoyal> (confused :S) |
| 04:42:07 | <wyclif> i know, but it should work |
| 04:42:11 | <asgoyal> oh ok |
| 04:43:04 | <wyclif> jtsl tries the getter and falls back to a methods that starts with 'get' and ends with the property name |
| 04:43:41 | <wyclif> so if you look at concept, it has s getName methods that loops over all names to find the best in the locale |
| 04:44:27 | <asgoyal> oh |
| 04:44:33 | <asgoyal> ... this is little confusing wyclif |
| 04:44:39 | <asgoyal> which is the file jstl? |
| 04:44:43 | <asgoyal> i want to have a look |
| 04:45:23 | <wyclif> asgoyal, are you saying it failed to work |
| 04:45:31 | <asgoyal> no no |
| 04:45:34 | <asgoyal> i m trying it out |
| 04:45:51 | <wyclif> jtsl is a technology |
| 04:45:58 | <wyclif> not a file |
| 04:46:02 | <asgoyal> lol i meant... while it is jetty:run.. i will have a look at the file you mention jstl |
| 04:46:03 | <asgoyal> oh |
| 04:46:53 | <wyclif> you dont have to restart the webapp if you only edit a jsp or messages.properties |
| 04:47:02 | <asgoyal> oh... |
| 04:47:17 | <wyclif> most resources are reloaded |
| 04:47:41 | <wyclif> if they are not under webinf |
| 04:48:11 | <wyclif> asgoyal, that should work |
| 04:48:30 | <asgoyal> oh ok .. i m trying.. |
| 04:53:33 | *** finbrein has joined #openmrs |
| 04:57:39 | <wyclif> are you still trying? |
| 05:01:11 | <asgoyal> wyclif: yes |
| 05:01:17 | <asgoyal> its giving some error.. trying to resolve it |
| 05:02:04 | <asgoyal> <tr> |
| 05:02:04 | <asgoyal> <th><spring:messagecode="ConceptDrug.ingredients"/></th> |
| 05:02:04 | <asgoyal> <td> |
| 05:02:04 | <asgoyal> <c:forEachvar="ingredient"items="drug.ingredients"> |
| 05:02:04 | <asgoyal> <label>${ingredient.name} </label> |
| 05:02:05 | <asgoyal> </c:forEach> |
| 05:02:07 | <asgoyal> </td> |
| 05:02:10 | <asgoyal> ... it doesn't work |
| 05:03:57 | <wyclif> i think you are doing something wrong |
| 05:04:41 | <wyclif> what do you get as output if you try ${ingredient.conceptId} |
| 05:06:51 | <asgoyal> trying it out |
| 05:10:58 | <asgoyal> wyclif: The following error happened somewhere on this page: |
| 05:10:58 | <asgoyal> javax.el.PropertyNotFoundException: The class 'java.lang.String' does not have the property 'name'. |
| 05:10:58 | <asgoyal> (The full error stack trace output is in the source of this page.) |
| 05:11:06 | <asgoyal> this is the error i get when i use ingredient.name |
| 05:13:27 | <asgoyal> wyclif: with ingredient.conceptId i get |
| 05:13:29 | <asgoyal> The following error happened somewhere on this page: |
| 05:13:29 | <asgoyal> javax.el.PropertyNotFoundException: The class 'java.lang.String' does not have the property 'conceptId'. |
| 05:13:29 | <asgoyal> (The full error stack trace output is in the source of this page.) |
| 05:16:57 | <wyclif> that confirms that there is something wrong you did |
| 05:17:35 | <wyclif> why are the drugIngredients of type String |
| 05:17:53 | <wyclif> because it means you var values are of type String |
| 05:20:04 | <wyclif> make sure you have no bind tags around it |
| 05:20:40 | <wyclif> can you paste the jsp code on paste bin and send me the link |
| 05:20:49 | <asgoyal> oh ok |
| 05:21:01 | <asgoyal> i made a mistake... i m correcting it now |
| 05:23:41 | <asgoyal> ok pasting.. i cant figure it out |
| 05:24:36 | <asgoyal> wyclif: http://pastebin.com/e9BSFCEa |
| 05:28:21 | <wyclif> asgoyal, replace you foreach tag with this: |
| 05:28:21 | <wyclif> <c:forEachvar="ingredient"items="${drug.ingredients}"> |
| 05:28:21 | <wyclif> <input type="text" name="ingredient" size="10" value=${ingredient.name} /> |
| 05:28:21 | <wyclif> </c:forEach> |
| 05:29:21 | <asgoyal> hm... here ingredient is of type drugIngredient |
| 05:29:29 | <asgoyal> so wont it be ingredient.ingredient.name? |
| 05:31:10 | <wyclif> can you just do what paste here and first ensure i works before you analyse it please |
| 05:31:25 | <asgoyal> oki sorry :D |
| 05:32:51 | *** suho__ is now known as suho |
| 05:33:48 | <asgoyal> wyclif: The following error happened somewhere on this page: |
| 05:33:48 | <asgoyal> org.hibernate.exception.SQLGrammarException: could not initialize a collection: [org.openmrs.Drug.ingredients#3] |
| 05:33:48 | <asgoyal> (The full error stack trace output is in the source of this page.) |
| 05:34:34 | <wyclif> that is now a problem in your mapping files for drug |
| 05:34:44 | <wyclif> the jsp is fine |
| 05:34:59 | <wyclif> look in Drug.hbm.xml |
| 05:35:06 | <asgoyal> oh ok |
| 05:35:17 | <wyclif> can you send me the paste bin for it |
| 05:36:42 | <asgoyal> alright |
| 05:36:51 | <wyclif> wait a minute, i might take back my words, so how come your unit tests pass? |
| 05:37:08 | <wyclif> if your mapping files were faulty, probably your tests would fail |
| 05:37:35 | <asgoyal> wyclif: http://pastebin.com/xL3MwFyP |
| 05:37:40 | <asgoyal> but my tests did not fail |
| 05:42:30 | <wyclif> asgoyal, what is the type of the collection of ingredients? |
| 05:42:40 | <asgoyal> DrugIngredient |
| 05:43:05 | <wyclif> Type of the collection NOT items of the collection? |
| 05:43:55 | <asgoyal> private Collection<DrugIngredient> ingredients; |
| 05:44:50 | <wyclif> can you get rid of the table attributes in the drug.hbm.xml file too |
| 05:45:08 | <wyclif> sorry the table attribute when mapping the set of ingredients |
| 05:45:14 | <asgoyal> ok |
| 05:45:46 | <wyclif> can i see your drugingredient.hbm.xml file |
| 05:46:02 | <asgoyal> sure |
| 05:46:51 | <asgoyal> http://pastebin.com/A6dhQBRm |
| 05:47:03 | <wyclif> your tests would still pass if they only check the size of the lists in the assertions but it doesn't mean your hbml file in perfect |
| 05:48:30 | <asgoyal> ok |
| 05:49:27 | <asgoyal> i removed the table attribute |
| 05:49:29 | <asgoyal> still doesn't work |
| 05:51:09 | <wyclif> can i see your Drug class and DruIngredientClass |
| 05:51:38 | <asgoyal> ok |
| 05:51:44 | *** bumi has joined #openmrs |
| 05:52:14 | <asgoyal> http://pastebin.com/NVeSEggT |
| 05:52:52 | <asgoyal> http://pastebin.com/4ndrsdSf |
| 05:56:05 | <bumi> Morning guys! i am designing a form in openmrs for infopath. There are several fields under patient that have to be added i.e district, village chairman, telephone number, etc; what is the best way to approach this challenge? please help. |
| 05:57:00 | <wyclif> asgoyal, i think the problem is with your getIngredients() method |
| 05:57:12 | <asgoyal> oh ok |
| 05:57:57 | <asgoyal> but that just returns back the variable ingredients |
| 05:58:25 | <asgoyal> is it something to do with its return type? |
| 06:01:25 | *** finbrein has quit IRC |
| 06:01:28 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Happening now: #OSCON BoF session on open source #HealthIT - room A105. Join us! <http://twitter.com/OpenMRS/statuses/95723462617862145> |
| 06:01:50 | <asgoyal> wyclif: my mom is going to call me from india.. so now i have to close this chat... will discuss this with you tomorrow.. sorry for this |
| 06:02:41 | <wyclif> asgoyal, what is the entire stacktrace in the server logs? |
| 06:04:13 | <wyclif> i have to go to bed too |
| 06:05:19 | *** bwolfe has joined #openmrs |
| 06:05:19 | *** ChanServ sets mode: +o bwolfe |
| 06:12:14 | <asgoyal> wyclif: i will show yo u the stacktrace tomorrow |
| 06:12:27 | <bwolfe> wyclif: when do you sleep? :-p |
| 06:12:38 | <bwolfe> this is two days in a row being up late.. .:-) |
| 06:12:44 | <asgoyal> wyclif: good night :) thanks a lot! ^^ |
| 06:12:49 | <asgoyal> lol bwolfe |
| 06:12:58 | <asgoyal> oh ok.. mom's call ... got to go now |
| 06:13:05 | <asgoyal> good night to you too bwolfe |
| 06:13:14 | <asgoyal> sleep well :) |
| 06:13:20 | *** asgoyal has quit IRC |
| 06:13:24 | <bwolfe> I'm starting my day now ankur |
| 06:13:30 | <bwolfe> whoops, gone |
| 06:14:03 | <gauravpaliwal> haha |
| 06:14:05 | <gauravpaliwal> :P |
| 06:14:16 | <gauravpaliwal> bwolfe: good night :D :P |
| 06:14:41 | <bwolfe> I have been awake for 2 hours, I think its bedtime |
| 06:15:22 | <gauravpaliwal> bwolfe: even asgoyal want you to sleep #prediction |
| 06:15:25 | <gauravpaliwal> :P |
| 06:18:06 | *** bumi has quit IRC |
| 06:27:53 | *** pascal` has joined #openmrs |
| 06:31:32 | <wyclif> bwolfe, am going to be now |
| 06:32:09 | <wyclif> i ended up debugging something with ankur and it took longer than i expected |
| 06:36:18 | *** pascal` has quit IRC |
| 06:44:40 | *** rafa has joined #openmrs |
| 06:44:40 | *** surangak has quit IRC |
| 06:44:42 | *** ChanServ sets mode: +v rafa |
| 06:44:52 | *** surangak has joined #openmrs |
| 06:46:05 | *** finbrein has joined #openmrs |
| 06:49:15 | *** pascal` has joined #openmrs |
| 06:52:19 | <surangak> just fixed one more embarrasing error (Phew !) |
| 06:53:36 | <bwolfe> how embarrasing? |
| 06:58:03 | <surangak> bwolfe, well, it would have been really embarassing if a QA found it :P |
| 06:58:37 | <bwolfe> do share... |
| 06:58:57 | <surangak> bwolfe, one of those "hey, do you know i get this when I try out your code ?" |
| 06:59:15 | <surangak> bwolfe, i was working on an edit complex obs |
| 06:59:22 | *** gauravpaliwal has left #openmrs |
| 07:00:09 | <surangak> bwolfe, seems that a tag class i wrote was evaluate every time obsForm.jsp was loaded |
| 07:00:09 | <surangak> even if it wasnt for a complex obs, and the tag class was not needed... |
| 07:00:27 | <bwolfe> ah |
| 07:00:36 | <bwolfe> a good waste of resources that there was . :-D |
| 07:01:23 | <surangak> plus a nice null pointer too, im afraid :P |
| 07:01:23 | <surangak> getting fixed now :) |
| 07:23:57 | *** dkayiwa has joined #openmrs |
| 07:38:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Followup fix to Context method call error caused by: add ability to specify changelog files when checking for unrun data... <http://feedproxy.google.com/~r/OMRStrunk/~3/SpDcTDOBLLY/OpenMRS> |
| 07:40:04 | *** magoo has joined #openmrs |
| 07:49:27 | *** surangak_ has joined #openmrs |
| 07:49:27 | *** surangak has quit IRC |
| 08:26:48 | *** danielf` has joined #openmrs |
| 08:26:48 | *** ChanServ sets mode: +v danielf` |
| 08:32:25 | *** mathiaslin has quit IRC |
| 08:39:19 | *** finbrein has quit IRC |
| 08:39:48 | *** finbrein has joined #openmrs |
| 08:42:20 | *** finbrein has quit IRC |
| 08:51:51 | *** upul` has joined #openmrs |
| 08:51:51 | *** ChanServ sets mode: +v upul` |
| 09:14:57 | <dkayiwa> hi bwolfe |
| 09:15:23 | <bwolfe> hey daniel |
| 09:16:09 | <dkayiwa> bwolfe: are you able to the the ui framework in debug mode and see the variable values? |
| 09:16:24 | <bwolfe> I haven't tried |
| 09:16:30 | <dkayiwa> ok |
| 09:16:37 | <bwolfe> but thats controlled by a flag when compiling |
| 09:16:58 | <bwolfe> if hte files are compiled by eclipse, I think its default is to include "debug,variables,___" (I cna't remember the third) |
| 09:17:02 | <bwolfe> I'm not sure what maven's defaults are |
| 09:17:11 | <dkayiwa> ok |
| 09:17:48 | <dkayiwa> bwolfe: did you also checkout the ui framework as a multi module project? |
| 09:18:08 | <bwolfe> yeah |
| 09:18:19 | <bwolfe> I have to now. all new versions of eclipse force it :-/ |
| 09:18:38 | <bwolfe> althought I've come to like it. I use the "working sets" to group them |
| 09:18:43 | <dkayiwa> ok |
| 09:19:17 | <dkayiwa> bwolfe: and do things like: right click open declaration work for you in any of the ui framework projects? |
| 09:20:15 | <dkayiwa> bwolfe: i get "The resource is not on the build path of a Java project" |
| 09:20:57 | <bwolfe> seems to |
| 09:21:12 | <dkayiwa> bwolfe: seems to work for you? |
| 09:21:17 | <bwolfe> dkayiwa: make sure htat there is a .project and .classpath in that framework project in eclipse |
| 09:21:19 | <bwolfe> yes, seems to work |
| 09:21:37 | <bwolfe> you should be ablet o just copy the .classpath from any other ui2 project because they all have the same top level structure |
| 09:21:48 | <dkayiwa> ok |
| 09:34:03 | *** bwolfe has quit IRC |
| 09:45:09 | *** Dodo__ has joined #openmrs |
| 09:45:21 | *** dkayiwa has quit IRC |
| 09:45:35 | *** dkayiwa has joined #openmrs |
| 09:46:04 | <Dodo__> dodo |
| 09:46:16 | <Dodo__> hello how are guyz |
| 09:46:54 | <Dodo__> i wanna ask a question |
| 09:47:00 | <Dodo__> any one is there |
| 09:47:18 | <Dodo__> ? |
| 09:49:20 | *** r0bby has joined #openmrs |
| 09:49:20 | *** ChanServ sets mode: +v r0bby |
| 09:50:03 | <Dodo__> haye |
| 09:50:13 | <dkayiwa> hey Dodo__ just ask |
| 09:51:40 | *** robbyoconnor has quit IRC |
| 09:56:38 | *** magoo has quit IRC |
| 10:00:51 | <Dodo__> my question is i wanna see my user from which i loging on the form |
| 10:01:04 | <Dodo__> please answer |
| 10:03:31 | *** dkayiwa has quit IRC |
| 10:03:51 | *** magoo has joined #openmrs |
| 10:09:10 | *** mathiaslin has joined #openmrs |
| 10:17:49 | <rafa> danielf`: Do you know where I can find a precise example of the form schema mentioned in https://tickets.openmrs.org/browse/TRUNK-2083? |
| 10:17:53 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Problem with getAllergies <http://forum.openmrs.org/viewtopic.php?f=8&t=801#p3028> |
| 10:18:06 | <rafa> danielf`: or do I have to invent one |
| 10:23:45 | *** mathiaslin has quit IRC |
| 10:24:02 | <Dodo__> is it answer of my question |
| 10:25:19 | *** finbrein has joined #openmrs |
| 10:26:52 | *** Dodo__ has quit IRC |
| 10:36:16 | *** dodo__ has joined #openmrs |
| 10:38:30 | *** dkayiwa has joined #openmrs |
| 10:39:44 | <dodo__> any one please answer my question |
| 10:54:03 | *** jportela has joined #openmrs |
| 10:54:03 | *** ChanServ sets mode: +v jportela |
| 10:55:35 | <rafa> dodo__: Can you please explain what you are trying to do? |
| 10:56:16 | *** dkayiwa has quit IRC |
| 10:57:06 | *** jportela has quit IRC |
| 11:01:03 | *** dkayiwa has joined #openmrs |
| 11:02:22 | <dodo__> dear i have a developed a forms in which i want to see the user name in the label box. |
| 11:02:51 | <dkayiwa> Dodo__: the logged on user? |
| 11:03:06 | <dodo__> like admin |
| 11:03:55 | <dodo__> as we login |
| 11:04:18 | <dkayiwa> Dodo__: why would you need that? Just wanting to know more |
| 11:04:58 | <dodo__> actualy in our country there are not more educated people |
| 11:05:17 | <dodo__> for there easy ness our managment decide to do like this |
| 11:05:53 | <dkayiwa> do you simply what to keep track of who filled which data entry form? |
| 11:06:29 | <dodo__> means |
| 11:06:29 | <dodo__> ? |
| 11:07:06 | <dkayiwa> i do not seem to understand what you want to accomplish by that |
| 11:07:43 | <dodo__> hey |
| 11:07:44 | *** surangak_ has quit IRC |
| 11:08:10 | *** rafa has quit IRC |
| 11:08:25 | <dodo__> on the form there is a drop down named provider ID |
| 11:09:07 | <dodo__> but i want to see the provider on the text box like First name Family name |
| 11:09:15 | *** james_regen has joined #openmrs |
| 11:09:15 | *** ChanServ sets mode: +v james_regen |
| 11:10:17 | <dkayiwa> that drop down will show the provider names for the user to select from |
| 11:10:48 | *** rafa has joined #openmrs |
| 11:10:48 | *** ChanServ sets mode: +v rafa |
| 11:12:02 | <dodo__> yes but i want to see the provider ID in the label of which we login at the start |
| 11:13:39 | <dodo__> is it possible |
| 11:16:44 | <dodo__> <dkayiwa> is it possible ? |
| 11:18:23 | <dkayiwa> Dodo__: the id is already shown |
| 11:18:28 | <dkayiwa> as part of the name |
| 11:18:32 | <dkayiwa> and the end |
| 11:18:39 | <dkayiwa> eg Super User [1] |
| 11:21:49 | <dkayiwa> do u understand what am saying Dodo__ |
| 11:24:39 | <magoo> it seems i have failed to set maven run as jdk instead of a jre |
| 11:26:04 | <dodo__> no i cant understand |
| 11:27:08 | *** finbrein has quit IRC |
| 11:40:23 | *** upul` has quit IRC |
| 11:47:38 | *** finbrein has joined #openmrs |
| 11:48:07 | *** bwolfe has joined #openmrs |
| 11:48:07 | *** ChanServ sets mode: +o bwolfe |
| 11:48:33 | <dkayiwa> hi bwolfe: welcome back :) |
| 11:48:40 | <bwolfe> thanks! |
| 11:48:44 | *** danielf` has quit IRC |
| 11:49:34 | <dkayiwa> bwolfe: any ideas as to why after svn updating my ui framework projects am getting this error? |
| 11:49:35 | <dkayiwa> java.lang.RuntimeException: Error occurred while trying to get the updates needed for the database. liquibase-update-to-latest-web.xml does not exist |
| 11:49:48 | <rafa> same for me |
| 11:49:58 | <dkayiwa> oh good am not alone :) |
| 11:50:09 | <rafa> what is the url pattern to access 1.x modules? |
| 11:50:19 | <bwolfe> hmm |
| 11:50:31 | <bwolfe> did you do a clean install of the root project? |
| 11:50:43 | <bwolfe> I renamed that file from -web to -ui2-application |
| 11:51:53 | <bwolfe> shnikies! I forgot to commit the web.xml file along with the other change :-( |
| 11:51:57 | * bwolfe is committing it now |
| 11:52:10 | * bwolfe apologizes to dkayiwa and rafa |
| 11:52:32 | <dkayiwa> no problem bwolfe: it happens to me too all the time :) |
| 11:52:40 | <rafa> bwolfe: no problem :) |
| 11:53:09 | <rafa> bwolfe: there's a rule that you can always work with the previous revision :) |
| 11:53:12 | <dkayiwa> good enough i did not have to fix it :) |
| 11:53:31 | <rafa> bwolfe: or else a previous to the previous |
| 11:53:35 | <rafa> and so on :) |
| 11:53:40 | <dkayiwa> :D |
| 11:53:45 | <bwolfe> ha |
| 11:53:50 | <bwolfe> yeah, I guess you have experience with that then |
| 11:54:14 | <dkayiwa> :) |
| 11:54:21 | <rafa> what about accessing good old 1.x modules in 2.x? |
| 11:54:31 | <rafa> I can't figure it out |
| 11:54:45 | <bwolfe> what do you mean by accessing? |
| 11:54:46 | <dkayiwa> rafa: do you get errors when you try to? |
| 11:54:55 | <dkayiwa> if you dirrectly type the url? |
| 11:55:10 | <rafa> yeah I end up with http 404 |
| 11:55:22 | <dkayiwa> rafa: oh, like for which module's url? |
| 11:55:34 | <rafa> in logs I see: No mapping found for HTTP request with URI [/openmrs2/module/metadatasharing/managaPackages.form] in DispatcherServlet with name 'Spring MVC Dispatcher Servlet' |
| 11:56:12 | <dkayiwa> i thought i had fixed that. :( |
| 11:56:39 | <rafa> dkayiwa: maybe you did, but we unfixed it again ;) |
| 11:56:40 | <dkayiwa> let me check out the metadatasharing module and look into it |
| 11:56:46 | <dkayiwa> hahahahaha |
| 11:56:50 | <dkayiwa> :):) |
| 11:56:50 | <rafa> dkayiwa: same for htmlformentry |
| 11:57:02 | <dkayiwa> which url for formentry? |
| 11:57:07 | <dkayiwa> may be i did not commit |
| 11:57:32 | <rafa> oh, I need to install it again |
| 11:57:46 | <dkayiwa> bwolfe: commited? |
| 11:58:13 | <bwolfe> yeah, 21894 |
| 11:58:33 | <dkayiwa> ok thanks |
| 11:58:38 | <bwolfe> rafa: "managaPackages" ?? |
| 11:58:46 | <bwolfe> could that be the problem? |
| 11:58:56 | <rafa> managePackages.form doesn't work too ;) |
| 11:59:08 | <rafa> but nice try :D |
| 11:59:12 | <bwolfe> bummer |
| 11:59:40 | <dkayiwa> :D |
| 12:01:01 | <dkayiwa> bwolfe: thanks. problem fixed. i wish i had asked earlier on. Had struggled a bit thinking problem was with me. :) |
| 12:01:25 | <bwolfe> pole sana |
| 12:01:31 | <bwolfe> yeah, ask in here first :-) |
| 12:01:39 | <dkayiwa> karibu. :) |
| 12:01:47 | <bwolfe> or if its a compile problem you can now check the ci build of ui2. :-) |
| 12:01:59 | <bwolfe> (altough all us sprinters will get an email if it doesn't compile) |
| 12:02:19 | <dkayiwa> did not want to ask too much without first trying (not to spam IRC) :) |
| 12:02:19 | <rafa> ohh and the modules work now too :D |
| 12:02:35 | <dkayiwa> :D May be Ben fixed them too |
| 12:03:43 | <bwolfe> hahaha, I have that effect sometimes...I just show up and things work ;-) |
| 12:03:51 | <dkayiwa> rafa: the css seems to be messed up though for the modules. am still struggling with that but not succeded yet |
| 12:04:01 | <bwolfe> dkayiwa: apply my same principle to emails as well |
| 12:04:05 | <dkayiwa> bwolfe d:) |
| 12:04:08 | <rafa> dkayiwa: yes, it's rather ugly what I see |
| 12:04:18 | <bwolfe> rafa: that has to do with moduleResources. isn't that a current ticket? is dkayiwa working on that? |
| 12:04:27 | <dkayiwa> bwolfe: sure i need to do the same. :) |
| 12:04:49 | <dkayiwa> bwolfe: i fixed module resources |
| 12:04:55 | <rafa> dkayiwa: but it's good enough for me to work. I need to fix message.properties. |
| 12:05:05 | <dkayiwa> bwolfe: but it did not fix the css problem |
| 12:05:14 | <bwolfe> ok |
| 12:05:17 | <bwolfe> hmm, strange |
| 12:05:20 | <rafa> dkayiwa: maybe it's all connected |
| 12:05:36 | <bwolfe> perhaps its overlapping with the ui2 css? or dependent on some css from the 1.x app that isn't there now? |
| 12:05:42 | *** dodo__ has quit IRC |
| 12:06:01 | <dkayiwa> rafa: for me, since am working on the ticket, it is not enough for it to just be good enough to work with. :) |
| 12:06:18 | <dkayiwa> bwolfe: ummmm |
| 12:07:41 | <rafa> you're right Ben I use styles and js from the old app |
| 12:07:43 | <bwolfe> is the css not loading or loading but looking wrong? |
| 12:08:27 | <rafa> bwolfe: I just checked. css and js are not available. They're in different folders now. |
| 12:09:43 | <dkayiwa> bwolfe: could it be because header.jsp is changed? |
| 12:10:30 | <bwolfe> if the path is different, than we need to have a way for the old path to still work (ideally) |
| 12:13:30 | <rafa> dkayiwa: I'll switch metadatasharing to use its own datatables pretty soon so if it's only this module, don't bother. |
| 12:13:54 | <dkayiwa> rafa: for every module i have tested |
| 12:14:17 | <rafa> ahh ok then we need a fix |
| 12:15:16 | <dkayiwa> rafa: do localization message work fine for your module? |
| 12:15:38 | <rafa> dkayiwa: no, I just picked up a ticket to resolve that |
| 12:16:38 | <dkayiwa> rafa: looks like thats where am stuck. |
| 12:16:42 | <dkayiwa> am getting javax.servlet.jsp.JspTagException: Theme 'green': No message found under code 'stylesheet' for locale 'en_GB'. |
| 12:17:07 | <dkayiwa> but before that, i get this: |
| 12:17:08 | <dkayiwa> WARN : org.springframework.context.support.ResourceBundleMessageSource - ResourceBundle [/themes/green] not found for MessageSource: Can't find bundle for base name /themes/green, locale en_GB |
| 12:17:08 | <dkayiwa> WARN : org.springframework.context.support.ResourceBundleMessageSource - ResourceBundle [/themes/defaults] not found for MessageSource: Can't find bundle for base name /themes/defaults, locale en_GB |
| 12:17:51 | <rafa> dkayiwa: https://tickets.openmrs.org/browse/TRUNK-2481, shall I pick this one or is it part of what you're doing right now? |
| 12:19:59 | <dkayiwa> rafa: actually i had not seen that ticket. Since the one am working on only said that old modules should work as much as possible. So looks like i have unknowingly attempted that ticket. Though no success yet. :) |
| 12:21:09 | <dkayiwa> https://tickets.openmrs.org/browse/TRUNK-2456 |
| 12:22:15 | <rafa> dkayiwa: I see. You seem to be doing pretty well. I'll leave it for you then :D |
| 12:24:37 | <dkayiwa> rafa: am not any where towards that, since i started on this same ticket last week. :) |
| 12:26:27 | <dkayiwa> rafa: but if i do not fix it by tomorrow, then i will give a chance for another brain to try it out from a different angle. :D |
| 12:27:56 | <rafa> dkayiwa: Deal! :) |
| 12:28:05 | <dkayiwa> sure. :) |
| 12:28:17 | *** mathiaslin has joined #openmrs |
| 12:30:00 | <rafa> bwolfe: do you know anything about the form schema from trunk-2083? |
| 12:30:06 | <rafa> !ticket trunk-2083 |
| 12:30:07 | <OpenMRSBot> rafa: [#TRUNK-2083] Allow data-driven forms from a form schema in the database - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2083 |
| 12:30:34 | <rafa> bwolfe: do I need to invent one or is it out there already? |
| 12:31:00 | <bwolfe> the form, form_field, field tables is what it probably refers to |
| 12:31:19 | <dkayiwa> yes thanks also how i understood it |
| 12:31:27 | <dkayiwa> thanks = that is |
| 12:31:37 | <bwolfe> yeah, looks like thats it |
| 12:32:07 | <rafa> where can I read about those? |
| 12:32:09 | <bwolfe> this probably depends on fieldGen though, doesn't it ? did someone get that working? |
| 12:32:24 | <bwolfe> about form schemas? uh, not sure you can. :-p |
| 12:32:33 | <bwolfe> run the 1.x openmrs and go to Manage Forms |
| 12:32:50 | <rafa> bwolfe: I don't think anyone touched fieldGen. |
| 12:32:51 | <bwolfe> there might be some pages on it under formentyr or infopath or Form Administration in the wiki |
| 12:33:17 | <rafa> bwolfe: you mean this https://tickets.openmrs.org/browse/TRUNK-2489? |
| 12:34:08 | <dkayiwa> he must be |
| 12:34:38 | <rafa> not much description there |
| 12:34:45 | <dkayiwa> rafa: this can be helpful to you: https://wiki.openmrs.org/display/docs/Administering+Forms |
| 12:34:50 | <OpenMRSBot> <http://ln-s.net/91D:> (at wiki.openmrs.org) |
| 12:35:21 | <rafa> dkayiwa: cool thanks |
| 12:36:03 | <dkayiwa> bwolfe / rafa : any clues as to what causes this: WARN : org.springframework.context.support.ResourceBundleMessageSource - ResourceBundle [/themes/green] not found for MessageSource: Can't find bundle for base name /themes/green, locale en_GB |
| 12:36:55 | <bwolfe> I thought that was a tomcat/jetty caching issue |
| 12:37:07 | <bwolfe> darius had a fix for that when it happened a few days ago to someone |
| 12:37:15 | <bwolfe> might check the irc logs |
| 12:38:21 | <dkayiwa> bwolfe: Darius just removed spring:theme elements which am returning back :) |
| 12:39:02 | <dkayiwa> bwolfe: like having a sick person and you just kill him instead of treating. :D |
| 12:39:33 | <dkayiwa> bwolfe: unless we do not plan to support it in openmrs 2 |
| 12:39:58 | <dkayiwa> bwolfe: because i was suspicious that the css problems could be linked to that |
| 12:41:19 | <bwolfe> hmm |
| 12:41:55 | <bwolfe> I don't see how it could be related |
| 12:42:14 | <bwolfe> but you need to have a themes/green folder in WEB-INF/classes I think |
| 12:42:23 | <bwolfe> (or wherever it is in the 1.x app) |
| 12:43:03 | <dkayiwa> bwolfe: you could be right. but still i should fix it for pages that use it |
| 12:43:37 | <dkayiwa> bwolfe: thanks for the pointer. let me try that out and will update you on how it goes |
| 12:44:18 | *** sgrannis has joined #openmrs |
| 12:44:19 | *** ChanServ sets mode: +v sgrannis |
| 12:47:08 | *** sgrannis has quit IRC |
| 12:47:28 | *** sgrannis has joined #openmrs |
| 12:53:35 | *** sgrannis has quit IRC |
| 12:55:48 | *** sgrannis has joined #openmrs |
| 12:55:48 | *** ChanServ sets mode: +v sgrannis |
| 13:12:48 | *** magoo has quit IRC |
| 13:23:42 | *** sgrannis has quit IRC |
| 13:24:01 | *** sgrannis has joined #openmrs |
| 13:29:53 | *** bryq has joined #openmrs |
| 13:29:54 | *** ChanServ sets mode: +v bryq |
| 13:40:49 | *** chopin has joined #openmrs |
| 13:41:25 | <chopin> hey guys ... does the reporting module function properly with metadata sharing module for copying reports from one instance to another? |
| 13:41:46 | *** sgrannis has quit IRC |
| 13:47:40 | *** dkayiwa has quit IRC |
| 13:51:58 | <bwolfe> ping rafa |
| 13:52:04 | <rafa> yes? |
| 13:52:17 | <bwolfe> chopin: might also check the reporting homepage to see if it says it works with MDS |
| 13:52:26 | <bwolfe> rafa: see chopin's question above |
| 13:52:44 | <bwolfe> iirc, its a matter of a few classes to support it |
| 13:52:44 | <rafa> chopin: As far as I know it doesn't. |
| 13:53:10 | <rafa> chopin: It would requie to write special handlers at least. |
| 13:55:13 | <rafa> chopin: I just remembered. It's even more complex. See https://tickets.openmrs.org/browse/META-4 |
| 13:59:07 | <chopin> rafa, ah ... so, is copying the reporting tables enough (behind the scenes) or is there more to it? |
| 14:00:44 | *** dkayiwa has joined #openmrs |
| 14:00:59 | <rafa> chopin: I can't answer you easily. I would have to checkout the reporting module and see the code. |
| 14:01:20 | <chopin> ah, sorry ... so you're on the MDS side not the reporting side :-) |
| 14:01:32 | <rafa> chopin: yes |
| 14:01:34 | * chopin waits for darius to wake up |
| 14:01:35 | <chopin> ;-) |
| 14:01:51 | <chopin> pascal`++ coffee++ |
| 14:01:53 | <rafa> chopin: good move :) |
| 14:02:03 | <chopin> pascal`++ |
| 14:02:06 | <chopin> coffee++ |
| 14:02:09 | <chopin> ++ |
| 14:02:14 | * chopin wonders of openmrsbot cares |
| 14:02:17 | <chopin> s/of/if |
| 14:03:03 | *** djazayeri has joined #openmrs |
| 14:03:04 | *** ChanServ sets mode: +o djazayeri |
| 14:03:18 | <chopin> dkayiwa, today is tuesday |
| 14:03:22 | <chopin> djazayeri, hi |
| 14:03:24 | <djazayeri> hi |
| 14:03:33 | <dkayiwa> chopin: ???? |
| 14:03:40 | <djazayeri> bwolfe, dkayiwa, wyclif, rafa: scrum time |
| 14:03:59 | <chopin> djazayeri, if i want to move reporting data from one instance to another, can it be done by just copying the reporting tables? |
| 14:04:08 | <chopin> dkayiwa, saw you called into the design review call number |
| 14:04:20 | <dkayiwa> oh yes chopin |
| 14:04:24 | <chopin> :-D |
| 14:04:28 | <dkayiwa> am so so forgetful |
| 14:04:28 | <wyclif> hi |
| 14:04:35 | <rafa> hi |
| 14:04:41 | <dkayiwa> i was wondering why there was no one chopin :D |
| 14:04:45 | <dkayiwa> am getting old :) |
| 14:04:47 | <chopin> (really, that number was just temporary ... should probably use the same number we use for other ones) |
| 14:04:50 | <djazayeri> chopin: if you have identical metadata, maybe |
| 14:04:52 | <bwolfe> chopin: look in the app data dir to see if reporting puts anything there |
| 14:05:05 | <chopin> djazayeri, should be ... copy of the db otherwise |
| 14:05:09 | <chopin> bwolfe, ok |
| 14:05:39 | <djazayeri> chopin: email mike for precise details |
| 14:05:45 | <chopin> ok |
| 14:05:51 | <chopin> asking my guy to send an email to the dev/impl list |
| 14:06:24 | <bwolfe> that'll work too |
| 14:06:40 | <djazayeri> good |
| 14:06:44 | <djazayeri> okay, scrum time |
| 14:06:47 | <djazayeri> who wants to go first? |
| 14:06:59 | <bwolfe> I can |
| 14:07:05 | <djazayeri> ok |
| 14:07:06 | <bwolfe> since I just wrote it up... |
| 14:07:12 | <bwolfe> today: |
| 14:07:12 | <bwolfe> worked on ui2 ticket for ui2 changelog file |
| 14:07:12 | <bwolfe> cleaned up occ module and mavenized it |
| 14:07:12 | <bwolfe> Fixing small bugs here and there in occ module |
| 14:07:12 | <bwolfe> tomorrow: |
| 14:07:13 | <bwolfe> occ, ui2, design calls |
| 14:07:26 | <bwolfe> but it looks similar ot yesterdays :-p |
| 14:08:10 | <bwolfe> my only blocker is figuring out how maven and nexus work :-/ |
| 14:08:13 | <djazayeri> was the ui2 ticket wyclif's? |
| 14:08:34 | <djazayeri> (I don't see you with any tickets in progress in the ui2 sprint) |
| 14:09:00 | <bwolfe> yes |
| 14:09:24 | <bwolfe> I did the 'if you have energy to convert the sql to liquibase' part |
| 14:09:35 | <djazayeri> oh, thanks! |
| 14:09:36 | <bwolfe> because I needed that in my db in order to start it up |
| 14:09:51 | <bwolfe> I also fixed the ticket I opened yesterday because wyclif's fix wasn't really a fix |
| 14:10:05 | <bwolfe> it was to trunk though |
| 14:10:09 | <djazayeri> I saw the ticket comments |
| 14:10:13 | <djazayeri> Will take a look. |
| 14:11:30 | <wyclif> bwolfe, which ticket? |
| 14:12:05 | <bwolfe> I dunno, the one in your inbox that has about 5 comments from me. :-) |
| 14:14:51 | <djazayeri> okay, ben, is there anything we can do to help with maven/nexus? |
| 14:15:13 | *** finbrein has quit IRC |
| 14:15:48 | <bwolfe> nah, was waiting for matt blanchette to appear online |
| 14:15:52 | <djazayeri> okay |
| 14:16:05 | <djazayeri> wyclif, next? |
| 14:16:18 | <wyclif> bwolfe, i think that methods should be able to work since the arguments we added are varargs |
| 14:16:43 | <djazayeri> wyclif: I peeked at Ben's commit, and it seemed like he was restoring a method with a different _name_ |
| 14:16:56 | <djazayeri> but I didn't look closely, or at all Ben's commits. |
| 14:16:57 | <bwolfe> name was the same djazayeri |
| 14:17:11 | <wyclif> i just think it because the change was in trunk and i guess you using the API version in the maven repo |
| 14:17:14 | <bwolfe> but the varargs are "1 or more", not "0 or more" |
| 14:17:24 | <djazayeri> So, I told Wyclif that if we replace method() with method(String…) it should be source-compatible |
| 14:17:35 | <djazayeri> I'm pretty sure varargs are 0 or more... |
| 14:17:42 | <wyclif> i thought so |
| 14:18:04 | <wyclif> so i used varargs since the methods can still be called with no argument |
| 14:18:16 | <bwolfe> ok, well, that makes sense since it was compiling fine without it |
| 14:18:33 | <bwolfe> but not sure why it wasn't running without it on mine |
| 14:18:33 | <wyclif> so it is a maven issue, right |
| 14:18:42 | <djazayeri> it should be source-compatible, but maybe not compiled-code-compatible |
| 14:18:52 | <djazayeri> I didn't think that would be an issue, but maybe it is. |
| 14:19:10 | <bwolfe> what version does ui2 use? if its snapshot, then its not a maven issue, it'd pull both from my local repo |
| 14:19:18 | <djazayeri> snapshot |
| 14:21:05 | <djazayeri> okay, wyclif, your turn. |
| 14:23:04 | <wyclif> yesterday: |
| 14:23:04 | <wyclif> i was working on TRUNK-2457 and i didn't get done with |
| 14:23:15 | <djazayeri> !ticket trunk-2457 |
| 14:23:16 | <OpenMRSBot> djazayeri: [#TRUNK-2457] 2.x Manage Global Properties page - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2457 |
| 14:24:08 | <wyclif> i have a small blocker |
| 14:24:17 | *** bwolfe has quit IRC |
| 14:24:28 | *** djazayeri sets mode: +v wyclif |
| 14:24:37 | *** djazayeri sets mode: +v dkayiwa |
| 14:24:41 | <djazayeri> yes? |
| 14:25:39 | <wyclif> so djazayeri, how do we want the form setting form to work? |
| 14:25:53 | <djazayeri> you mean binding? |
| 14:26:04 | <djazayeri> wyclif: why do you need to bind to a list in the gp page? |
| 14:26:17 | <wyclif> should we let the user save a single global property at a time like the gp portlet? |
| 14:26:29 | <wyclif> or it should be saved as a list |
| 14:27:01 | <djazayeri> I think saving the whole list at a time is good. (You'll only be showing a subset of the GPs) |
| 14:27:08 | <wyclif> i would suggest the former since it would save me from worrying about binding lists which is not supported in the framework |
| 14:28:11 | <wyclif> if am to allow saving the entire list, then i have to manually with a loop to match the paramter names in the form |
| 14:28:12 | <djazayeri> wyclif: if you can't efficiently write code that saves a list, that's a problem with the framework. |
| 14:28:26 | <dkayiwa> :D |
| 14:28:42 | <djazayeri> If it's just a loop, I think that's okay |
| 14:28:44 | *** bwolfe has joined #openmrs |
| 14:28:44 | *** ChanServ sets mode: +o bwolfe |
| 14:28:49 | <djazayeri> if it's a loop plus lots of hackiness, that's worse |
| 14:29:10 | <djazayeri> Perhaps a utility method that does the server-side version of a spring:bind for an object? |
| 14:29:14 | *** bwolfe has quit IRC |
| 14:29:31 | *** bwolfe has joined #openmrs |
| 14:29:40 | *** ChanServ sets mode: +o bwolfe |
| 14:30:19 | <bwolfe> sorry, lost my connection |
| 14:30:32 | <dkayiwa> bwolfe: welcome to Africa :) |
| 14:30:35 | <wyclif> i.s to say i the form i generate names e.g gp[0]. propertyValue and in the controller i bind the value by looping over request parameters following that pattern like spring does |
| 14:30:40 | <djazayeri> e.g. for (String propName : propertyNames) { GlobalProperty gp = bindForm(new GlobalProperty(), propName, "gp_name", "gp_value"); } |
| 14:31:50 | <djazayeri> wyclif: let's discuss after the reports |
| 14:32:01 | <wyclif> ok |
| 14:32:06 | <wyclif> so today: |
| 14:32:17 | <djazayeri> But let's make it work such that you save all the props at once in a submit |
| 14:32:21 | <wyclif> i want to finish up this and pick up another ticket |
| 14:32:33 | <wyclif> ok |
| 14:33:28 | <djazayeri> sounds good |
| 14:33:35 | <djazayeri> okay, dkayiwa, you're next |
| 14:33:45 | <dkayiwa> Fixed CSS and JavaScript problem for TRUNK-2456. Also completed TRUNK-2481. Will be working on ensuring that <openmrs:portlet>, <openmrs:htmlInclude>, and submitting forms work, for the remaining parts of TRUNK-2456. No blockers. DONE. |
| 14:34:07 | <djazayeri> !ticket trunk-2456 |
| 14:34:08 | <OpenMRSBot> djazayeri: [#TRUNK-2456] Make Reporting module work as much as possible in 2.x - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2456 |
| 14:34:08 | <bwolfe> dkayiwa: what was the css issue? |
| 14:34:14 | <dkayiwa> By the way bwolfe: your tip for the spring:theme error message worked. thanks alot :) |
| 14:34:14 | <djazayeri> !ticket trunk-2481 |
| 14:34:15 | <OpenMRSBot> djazayeri: [#TRUNK-2481] 2.x needs to include module messages.properties - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2481 |
| 14:34:38 | <bwolfe> good |
| 14:34:40 | <dkayiwa> bwolfe: did lots of things. Now trying to undo such that i know exactly what made it work |
| 14:35:19 | *** cta has joined #openmrs |
| 14:35:23 | <djazayeri> dkayiwa: TRUNK-2481 is still "in progress" in jira, so make sure to document the commit and/or open a code review |
| 14:35:23 | <cta> hello |
| 14:35:49 | <bwolfe> hi cta |
| 14:36:16 | <djazayeri> dkayiwa: also, regarding the portlet and htmlInclude tags, let's talk after all the reports |
| 14:36:31 | <dkayiwa> ok |
| 14:36:50 | <djazayeri> for htmlInclude I'd like to find a way for it to also work if you're in a "page" |
| 14:37:27 | <djazayeri> i.e. if you've wrapped the 1.x content in a 2.x page or fragment, and you htmlInclude something, it should make it into the 2.x PageContext |
| 14:38:16 | <djazayeri> any blockers? |
| 14:38:24 | <dkayiwa> NONE |
| 14:39:43 | <djazayeri> okay |
| 14:39:45 | <djazayeri> rafa: you there? |
| 14:39:46 | <djazayeri> your turn |
| 14:39:50 | <cta> bwolfe: Ben, I have already fixed problem with liquibase-data.zip file and added corresponding patch for ticket TRUNK-2446. See my comment. |
| 14:39:51 | <rafa> Today: |
| 14:39:51 | <rafa> * Corrected per code-review TRUNK-2484: Show login popup on unauthorized ajax calls |
| 14:39:51 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2484 |
| 14:39:51 | <rafa> * Tried to start with TRUNK-2083: Allow data-driven forms from a form schema in the database |
| 14:39:51 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2083, but I will need extra guidance. |
| 14:39:51 | <rafa> * Meanwhile found TRUNK-2492: A stopped and started module does not register service beans |
| 14:39:51 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2492 |
| 14:39:52 | <rafa> Tomorrow: |
| 14:39:52 | <rafa> * TRUNK-2492 |
| 14:39:53 | <rafa> * Continue with TRUNK-2083 |
| 14:39:53 | <rafa> No blockers. |
| 14:40:06 | <bwolfe> thanks cta |
| 14:41:36 | <djazayeri> wyclif, dkayiwa: try to make your reports look more like rafa's. (they don't have to be _that_ nice, but using line breaks, and including both the ticket number and a helpful description, makes it really easy to read) |
| 14:41:40 | <djazayeri> :-) |
| 14:41:50 | <djazayeri> rafa: trunk-2083 should indeed be interesting |
| 14:41:52 | <djazayeri> let's discuss |
| 14:41:56 | <dkayiwa> ok :) |
| 14:42:09 | <wyclif> ok |
| 14:42:32 | <djazayeri> my turn |
| 14:42:34 | <djazayeri> Monday: |
| 14:42:34 | <djazayeri> * HTML Form Entry Designer planning with Joao |
| 14:42:34 | <djazayeri> * added a Form Entry tab to patient dashboard in 2.x |
| 14:42:34 | <djazayeri> * Fixed a bug where fragment gsps weren't reloading after changes |
| 14:42:34 | <djazayeri> * added a 2.x FormEntryExtension class, and an adapter from 1.x FormEntry |
| 14:42:35 | <djazayeri> * HTML Form Entry module now successfully plug into Form Entry tab, with pretty urls, and is compatible with 1.x and 2.x with no branch needed |
| 14:42:35 | <djazayeri> * sprint code review (but not much) |
| 14:42:36 | <djazayeri> Today: |
| 14:42:37 | <djazayeri> * check in code for the stuff I did yesterday |
| 14:42:37 | <djazayeri> * sprint code review |
| 14:42:38 | <djazayeri> * another ticket |
| 14:43:12 | <djazayeri> no blockers |
| 14:44:27 | <djazayeri> so, we put off a bunch of discussions... |
| 14:44:38 | <djazayeri> wyclif about controller and binding |
| 14:44:51 | <wyclif> ok |
| 14:44:53 | <djazayeri> dkayiwa about htmlInclude |
| 14:45:09 | <dkayiwa> yes |
| 14:45:09 | <djazayeri> rafa about data-driven-forms |
| 14:45:40 | <rafa> last in the queue :) |
| 14:45:57 | <djazayeri> not necessarily a queue. Is anyone specifically waiting for that conversation to be able to proceed? |
| 14:46:17 | <djazayeri> and who can wait until 2nd or 3rd with no loss of time? |
| 14:46:20 | <wyclif> i guess for me |
| 14:46:53 | <rafa> djazayeri: I can be the last it's fine. |
| 14:47:05 | <djazayeri> okay, wyclif, let's go then |
| 14:47:09 | <wyclif> ok |
| 14:47:27 | <dkayiwa> djazayeri: will come back later in the night and we discuss |
| 14:47:28 | <djazayeri> perhaps we can actually use etherpad to brainstorm what you'd like to be able to do |
| 14:48:20 | <djazayeri> http://notes.openmrs.org/2x-binding |
| 14:48:34 | *** dkayiwa has quit IRC |
| 15:00:43 | <wyclif> DJ |
| 15:01:38 | <djazayeri> yes? |
| 15:02:12 | <wyclif> djazayeri, i realised that there are afew gp with no prefix as such |
| 15:02:26 | <djazayeri> that's fine, put them in a "general" section at the beginning |
| 15:03:10 | <djazayeri> cool? |
| 15:04:13 | <wyclif> the categorization i have in place is the basic one where we have core sp, module gp |
| 15:04:22 | <wyclif> and the general as above |
| 15:04:43 | <djazayeri> I was thinking you just group by the prefix before the first dot |
| 15:04:51 | <djazayeri> that has the side effect of making modules their own thing |
| 15:05:11 | <djazayeri> but it also means that the ~5 "security.*" gps will be together |
| 15:05:19 | <wyclif> i can group them by prefix but i have to figure out a title of the page based on the prefix which for now i do by capitalizing the prefix |
| 15:05:28 | <djazayeri> that's good enough |
| 15:05:37 | <wyclif> but the prefix might not always be descriptive |
| 15:05:42 | <djazayeri> that's okay |
| 15:05:49 | <wyclif> ok |
| 15:05:50 | <wyclif> thanks |
| 15:05:51 | <wyclif> am set |
| 15:05:59 | <djazayeri> The point is that we can iterate on this easily later |
| 15:06:07 | <wyclif> cool |
| 15:07:44 | <wyclif> for modules. i just get the list of started modules, and the i try to group the gps by modules id |
| 15:08:49 | <wyclif> but i also believe the prefix would still work in grouping module props |
| 15:08:57 | <djazayeri> wyclif: but if you do it that way, what happens to modules that are no longer started? |
| 15:09:20 | <djazayeri> I'd just go with prefix. It should cover all cases decently. |
| 15:09:45 | <wyclif> their gp dont get displayed, which is the case i thought even in 1.x |
| 15:09:58 | <djazayeri> nah, all gps get displayed in 1.x always |
| 15:10:20 | <wyclif> so i should then get the list of loaded modules |
| 15:10:29 | <djazayeri> just use the prefix |
| 15:10:32 | <wyclif> ok |
| 15:10:35 | <djazayeri> don't do anything tricky with modules |
| 15:10:38 | *** asgoyal has joined #openmrs |
| 15:11:42 | <bryq> djazayeri, rafa: Hi, do we have a meeting today? |
| 15:11:58 | <rafa> bryq: hi |
| 15:12:02 | <rafa> bryq: yes in 3 hours |
| 15:12:25 | <bryq> rafa: Okay |
| 15:44:25 | <djazayeri> rafa: want to discuss trunk-2083 now? |
| 16:00:54 | *** gbastien has joined #openmrs |
| 16:01:42 | *** pascal` has quit IRC |
| 16:02:22 | *** chopin has quit IRC |
| 16:03:30 | *** asgoyal has quit IRC |
| 16:03:45 | *** asgoyal has joined #openmrs |
| 16:04:02 | <rafa> djazayeri: I'm back, sorry |
| 16:04:24 | <rafa> djazayeri: do you have time now? |
| 16:04:30 | <djazayeri> sure |
| 16:04:49 | <rafa> so I'm a little confused with the schema thing |
| 16:05:00 | <rafa> how should that look like? |
| 16:05:09 | <djazayeri> have you looked at the edit form page in the 1.x application? |
| 16:05:18 | <djazayeri> it has a tree widget showing the "form schema" |
| 16:05:31 | <rafa> no I haven't seen that |
| 16:05:38 | <djazayeri> okay, that's key. :-) |
| 16:05:47 | <rafa> ok, I'm starting the app |
| 16:06:39 | <djazayeri> let's look at the demo server |
| 16:06:56 | <rafa> djazayeri: oh right, I forgot we got one :) |
| 16:07:40 | <djazayeri> here's one example of a form: http://demo.openmrs.org/openmrs/admin/forms/formEdit.form?formId=17 |
| 16:07:45 | <OpenMRSBot> <http://ln-s.net/91En> (at demo.openmrs.org) |
| 16:08:04 | <rafa> ok I seeit |
| 16:08:29 | <rafa> oh and the schema tree |
| 16:08:31 | <rafa> cool |
| 16:08:32 | <djazayeri> yes. |
| 16:08:36 | <djazayeri> open the Obs section |
| 16:08:44 | <rafa> done |
| 16:08:46 | <djazayeri> and look at the first question, e.g. FATHER DECEASED |
| 16:09:00 | <djazayeri> it has field type = concept, and points to a FATHER DECEASED concept |
| 16:09:14 | <djazayeri> it's also page #1, question #3 |
| 16:09:31 | <rafa> yes |
| 16:10:24 | <rafa> What is Field Part? |
| 16:10:25 | <djazayeri> or if you look at weight (kg), it's also a concept |
| 16:10:36 | <djazayeri> it's question 15.a. |
| 16:10:46 | <djazayeri> presumably height is 15.b, or something like that |
| 16:10:54 | <djazayeri> a and b are "field part" |
| 16:11:13 | <rafa> I see |
| 16:11:44 | <rafa> How those a and b should be displayed? |
| 16:12:19 | <djazayeri> so, the idea behind the form part of the data model, is that the form schema is the M part of an MVC model |
| 16:12:41 | <djazayeri> i.e. the form schema describes the logical structure of the form |
| 16:12:45 | *** r0bby is now known as robbyoconnor |
| 16:13:12 | <djazayeri> we do in fact have these field and field part, but they're not necessarily used by the formentry technologies |
| 16:13:35 | <djazayeri> (they're not required to be, and they in fact are not, at least for infopath and html. not sure about xforms) |
| 16:14:30 | <rafa> okay so it's stored as an xml |
| 16:14:40 | <rafa> right? |
| 16:14:48 | <djazayeri> the schema structure is stored in the form_field table |
| 16:15:37 | <rafa> Do we have a util to read that easily? |
| 16:15:52 | <djazayeri> there may be a "schema" column on form, but that's really part of the infopath form entry module |
| 16:16:11 | <djazayeri> not sure if we have good utils or not |
| 16:17:00 | <rafa> ok I can easily find how the tree is built |
| 16:17:21 | <djazayeri> so, up until this point, there's the form schema (which is the Model) and then each form entry module (infopath, html, xforms) stores some additional file or xml describing the layout (which is the View) |
| 16:18:03 | <djazayeri> what we want to do here is to display an form for entry, without requiring any of those modules, just based on the form schema |
| 16:18:23 | <rafa> nice :) |
| 16:18:27 | <djazayeri> The goal is to do a quick hacky job of this. |
| 16:18:58 | <djazayeri> There is not actually enough information in the form schema to do this right. So this ticket is really just going to be the starting point of a conversation about how to do this. |
| 16:19:30 | <rafa> djazayeri: ok, so what are the basics we want here |
| 16:20:16 | <djazayeri> So I'd written it a bit differently in the ticket, but let me propose a first pass that's even "easier" than what is in the ticket |
| 16:20:40 | <djazayeri> Assume we're only doing data entry of one encounter for one patient |
| 16:20:53 | <djazayeri> and this is only to create a new encounter, not to edit an existing one. |
| 16:21:47 | <djazayeri> You should hardcode widgets for encounterDatetime, location, and provider |
| 16:22:17 | <rafa> hardcode? |
| 16:22:33 | <djazayeri> If you look at the schema you'll see that there's a Patient section and an Encounter section |
| 16:22:51 | <rafa> right |
| 16:23:11 | <djazayeri> in theory you can ask edit/show different things about the patient and encounter |
| 16:23:24 | <djazayeri> Actually I think the standard schema layout we are using is poorly designed. |
| 16:23:50 | <djazayeri> really encounter should be _in_ patient, and _obs_ should be _in_ encounter |
| 16:23:55 | <djazayeri> they shouldn't all be parallel |
| 16:24:01 | <djazayeri> but we're going to ignore that now, and just do something quick |
| 16:24:26 | <djazayeri> i.e. in the long run we should support the idea that a single form collects data for two patient |
| 16:24:31 | <djazayeri> or for multiple encounters |
| 16:24:38 | <djazayeri> but not today |
| 16:25:26 | <djazayeri> for now we'll just assume it's a single encounter for a single, patient, and that you want to collect the datetime, location, and provider. (since those are the required fields) |
| 16:25:46 | <rafa> ok |
| 16:26:31 | <rafa> provider is a user? |
| 16:26:36 | <djazayeri> it's a person actually |
| 16:26:45 | <rafa> ok |
| 16:26:48 | <djazayeri> that will change in 1.9 or 1.10, but for now a person |
| 16:27:10 | <djazayeri> (it was a user in 1.5-) |
| 16:27:17 | <djazayeri> so... |
| 16:27:30 | <djazayeri> the idea is that you should just find the OBS field |
| 16:27:52 | <djazayeri> then iterate over all fields in that sub-tree, and find the ones that have field type = concept |
| 16:28:15 | <djazayeri> and do an obs entry field for each of those |
| 16:28:34 | <djazayeri> you should sort them by field number and field part and display them in that order |
| 16:28:39 | <djazayeri> (by page number too) |
| 16:29:09 | <rafa> all on a single page? |
| 16:29:33 | <djazayeri> yeah |
| 16:29:50 | <djazayeri> I would represent a "page" with a div |
| 16:30:01 | <rafa> ok |
| 16:30:25 | <djazayeri> make it such that the entire form is submitted in one page |
| 16:31:03 | <djazayeri> design-wise, make sure you make a fragment that takes just a formField as input, and draws it |
| 16:31:34 | <rafa> all right |
| 16:31:46 | <rafa> I think I understand now |
| 16:31:51 | <djazayeri> (the idea is that eventually we'll want to add the ability to define pre-field and post-field (javascript?) behavior |
| 16:31:58 | <djazayeri> and that will be a discussion topic) |
| 16:32:09 | <djazayeri> visually, each field should be: |
| 16:32:39 | <djazayeri> field number (field part): field name [widget for value], date: [widget for date] |
| 16:33:27 | <djazayeri> You can just start by handling the simple datatypes (e.g. numeric, string, date) |
| 16:33:45 | <djazayeri> (visually, one field per row) |
| 16:34:06 | <rafa> date is for each field? |
| 16:34:10 | <djazayeri> yeah. |
| 16:34:15 | <djazayeri> (should be optional) |
| 16:34:24 | <rafa> good |
| 16:34:41 | <djazayeri> but the schema can't currently represent whether or not to show the date field |
| 16:36:18 | <rafa> ok, is that all? |
| 16:36:25 | <djazayeri> I think so |
| 16:36:27 | <rafa> Ben has mentioned that https://tickets.openmrs.org/browse/TRUNK-2489 might be relevant? |
| 16:36:44 | <djazayeri> no, I don't think so |
| 16:36:53 | <rafa> good |
| 16:37:23 | <djazayeri> we already have the "field" widget in 2.x which is better than fieldgen |
| 16:38:02 | <rafa> Perfect, tomorrow I'll try to resolve the issue with starting/stopping modules and then work on this. |
| 16:38:13 | <djazayeri> ok |
| 16:38:49 | <rafa> thanks! |
| 16:55:44 | *** magoo_ has joined #openmrs |
| 17:03:12 | *** rafa has quit IRC |
| 17:10:31 | *** suho has joined #openmrs |
| 17:10:31 | *** ChanServ sets mode: +v suho |
| 17:10:41 | *** yanokwa_ has quit IRC |
| 17:11:10 | *** yanokwa has joined #openmrs |
| 17:11:10 | *** ChanServ sets mode: +v yanokwa |
| 17:16:46 | <wyclif> hi bwolfe |
| 17:26:24 | *** asgoyal has quit IRC |
| 17:29:12 | *** downeym has joined #openmrs |
| 17:29:12 | *** ChanServ sets mode: +o downeym |
| 17:29:12 | *** OpenMRSBot sets mode: +o downeym |
| 17:29:14 | *** downeym has quit IRC |
| 17:34:19 | *** asgoyal has joined #openmrs |
| 17:37:27 | *** Suranga has joined #openmrs |
| 17:45:02 | *** downeym has joined #openmrs |
| 17:45:02 | *** ChanServ sets mode: +o downeym |
| 17:45:02 | *** OpenMRSBot sets mode: +o downeym |
| 17:49:30 | *** rafa has joined #openmrs |
| 17:49:41 | *** ChanServ sets mode: +v rafa |
| 17:53:51 | <djazayeri> rafa, wyclif: which of these seems more intuitive (to put at the top of a fragment view, indicating and checking for required parameters) |
| 17:54:07 | <djazayeri> 1: config.require("href"); config.requireAny("icon", "title"); |
| 17:54:20 | <djazayeri> 2. config.require("href", "?icon", "?title") |
| 17:54:53 | <djazayeri> 3. config.require("href AND (icon OR title)") |
| 17:55:06 | <wyclif> hmm |
| 17:55:28 | <wyclif> 3 seems more intuitive to me |
| 17:55:48 | <wyclif> but 1 looks fine too |
| 17:56:01 | <djazayeri> 4. config.require("href", "icon OR title") |
| 17:57:15 | <djazayeri> actually, I like that last one. each (varargs) argument to require is required, but we support a way of making the strings "complex" |
| 17:57:30 | *** gbastien has quit IRC |
| 17:57:43 | <djazayeri> better: config.require("href", "icon |
| 17:57:55 | <djazayeri> or require("href", "icon || title") |
| 17:58:08 | <djazayeri> wyclif: does one of those variants of 4 seem as intuitive as 3 and 1? |
| 17:58:12 | <rafa> 3 is the most robust. It's the only one that allows for (href & icon) |
| 17:58:35 | *** downeym_ has joined #openmrs |
| 17:58:35 | *** ChanServ sets mode: +o downeym_ |
| 17:58:37 | <djazayeri> true, but it's also the most complicated to implement |
| 17:58:48 | *** downeym has quit IRC |
| 17:58:49 | *** downeym_ is now known as downeym |
| 17:59:21 | <djazayeri> Also, 4 could eventually support 3. |
| 18:00:08 | <djazayeri> so I think I'm going to go that way. |
| 18:00:59 | <djazayeri> unless rafa or wyclif veto that |
| 18:01:27 | <wyclif> hmm |
| 18:01:46 | <rafa> djazayeri: I'll save my veto for the future ;) 4 is fine |
| 18:01:58 | <wyclif> 4 is fine |
| 18:02:41 | <rafa> djazayeri: btw I was missing that feature |
| 18:03:10 | <djazayeri> config.require is there already, just not a way of requiring at-least-one-of-many |
| 18:03:22 | <djazayeri> possibly not documented though. :-) |
| 18:03:32 | <rafa> djazayeri: ohh I haven't seen it |
| 18:03:43 | *** vchircu has joined #openmrs |
| 18:03:49 | <rafa> djazayeri: It should be required in fragment, it'll self document them |
| 18:04:05 | <wyclif> am grabbing lunch |
| 18:04:17 | <djazayeri> yeah, will have to add it to the documentation |
| 18:04:18 | <rafa> djazayeri: I needed to skim through the entire thing to figure out what params I need to give |
| 18:08:13 | *** gbastien has joined #openmrs |
| 18:08:20 | *** yanokwa has quit IRC |
| 18:08:45 | *** yanokwa has joined #openmrs |
| 18:08:45 | *** ChanServ sets mode: +v yanokwa |
| 18:12:21 | *** goutham has joined #openmrs |
| 18:13:06 | *** yanokwa has quit IRC |
| 18:15:09 | *** goutham_ has joined #openmrs |
| 18:16:46 | *** goutham has quit IRC |
| 18:16:48 | *** goutham_ has quit IRC |
| 18:17:41 | *** goutham has joined #openmrs |
| 18:19:20 | *** magoo_ has quit IRC |
| 18:22:57 | *** lh has joined #openmrs |
| 18:29:39 | <suho> hi can someone help me how to refer one module from anther in ant environment |
| 18:30:46 | <suho> please direct me to the documentation |
| 18:31:25 | <djazayeri> suho: https://wiki.openmrs.org/x/0w8z |
| 18:31:37 | <djazayeri> (i.e. https://wiki.openmrs.org/display/docs/Module+Dependencies) |
| 18:31:38 | <OpenMRSBot> <http://ln-s.net/90SD> (at wiki.openmrs.org) |
| 18:31:59 | <suho> djazayeri, thanks |
| 18:39:35 | *** doverdose has joined #openmrs |
| 18:39:49 | <downeym> Hi doverdose and welcome to the #openmrs IRC channel. |
| 18:40:27 | <doverdose> howdy |
| 18:40:37 | <doverdose> i'm having some trouble with configuring my dev environment |
| 18:40:53 | <doverdose> specifically the SCM extras for eclipse |
| 18:41:31 | <djazayeri> doverdose: those are the most annoying part of the process |
| 18:41:49 | <doverdose> yeah i hope so, it's certainly a high barrier to entry |
| 18:41:54 | *** wyclif has quit IRC |
| 18:42:11 | <djazayeri> have you installed the SCM extras eclipse feature? |
| 18:42:43 | <doverdose> when i try to install the Maven Integration for Subclipse from the update site |
| 18:42:57 | <doverdose> it tells me that the org.maven.ide.eclipse dependency is missing |
| 18:43:11 | <djazayeri> you installed m2eclipse first? |
| 18:43:28 | <djazayeri> Are you using eclipse 3.7? (or whatever the very newest version is?) |
| 18:43:55 | <doverdose> Maven SCM Handler for Subclipse * not integration |
| 18:43:56 | <doverdose> helios |
| 18:43:57 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Breaking #OSCON session *today* 1:30-5:00: Social Coding for Good, #HFOSS, etc. Room E142. Join us & help save the world. <http://twitter.com/OpenMRS/statuses/95922624290504705> |
| 18:44:03 | <doverdose> (3.60 |
| 18:44:14 | <djazayeri> okay, things actually get _more_ complicated in 3.7 |
| 18:44:25 | <djazayeri> doverdose: did you install m2eclipse? |
| 18:44:28 | <doverdose> haha wow |
| 18:45:06 | <djazayeri> I blame eclipse and their mediocre maven support |
| 18:45:39 | <djazayeri> (if you happen to have seen a project that has a less annoying eclipse + maven + multiple modules setup, we'd love to learn that better way.) |
| 18:45:53 | <doverdose> i think so |
| 18:45:58 | <doverdose> i went to the update site http://download.eclipse.org/technology/m2e/releases |
| 18:46:09 | <OpenMRSBot> <http://ln-s.net/91GZ> (at download.eclipse.org) |
| 18:46:10 | <doverdose> and downloaded the Maven Integration |
| 18:46:26 | <doverdose> and that installed without complaints |
| 18:46:38 | <djazayeri> Is that an eclipse distribution? or a plugin? |
| 18:46:54 | <doverdose> plugin |
| 18:48:07 | <djazayeri> okay, that's a newer version than what I have. let's see |
| 18:49:50 | <djazayeri> hmm, my eclipse is unhappy... |
| 18:50:29 | *** bryq1 has joined #openmrs |
| 18:51:09 | <doverdose> m2e is ver 1.0.0.20110607-2117 |
| 18:51:34 | <doverdose> can you let me know which m2e release you're on, if eclipse decides to cooperate? |
| 18:51:39 | *** bryq has quit IRC |
| 18:51:56 | *** goutham_ has joined #openmrs |
| 18:52:42 | *** goutham has quit IRC |
| 18:52:45 | <djazayeri> working on it |
| 18:52:59 | <doverdose> thx |
| 18:53:22 | <djazayeri> (need to figure out how to start eclipse up with more JVM memory on the mac...) |
| 18:53:39 | *** james_regen has quit IRC |
| 18:55:04 | <djazayeri> doverdose: the eclipse update site I used was older. |
| 18:55:05 | <djazayeri> http://m2eclipse.sonatype.org/sites/m2e |
| 18:55:11 | <djazayeri> looking for my version # |
| 18:55:41 | <djazayeri> looks like 0.12.something |
| 18:56:14 | <doverdose> hmm not even the same major ver |
| 18:56:51 | <djazayeri> Yeah. I'm going to try cleanly installing the newer m2e and see what happens |
| 18:56:52 | <doverdose> will try to update through link |
| 18:56:55 | <doverdose> http://m2eclipse.sonatype.org/sites/m2e |
| 18:58:14 | <doverdose> tangential rant - my eclipse takes about 5 min to "Calculate requirements and dependencies" whenever I try to install plugins |
| 19:00:11 | *** bwolfe has quit IRC |
| 19:02:23 | *** downeym has quit IRC |
| 19:03:55 | *** rafa has quit IRC |
| 19:05:41 | *** jportela has joined #openmrs |
| 19:05:41 | *** ChanServ sets mode: +v jportela |
| 19:16:10 | *** goutham_ has quit IRC |
| 19:23:11 | *** lh has quit IRC |
| 19:29:09 | *** dkayiwa has joined #openmrs |
| 19:31:48 | *** wyclif has joined #openmrs |
| 19:34:28 | <wyclif> rafa, and i think that is the line that switches to the new dispatcher which has the correct context config with the right init parameter values |
| 19:43:53 | *** rafa has joined #openmrs |
| 19:43:53 | *** ChanServ sets mode: +v rafa |
| 19:47:20 | *** mathiaslin has quit IRC |
| 19:55:04 | *** downeym has joined #openmrs |
| 19:55:04 | *** ChanServ sets mode: +o downeym |
| 19:55:04 | *** OpenMRSBot sets mode: +o downeym |
| 19:55:24 | *** doverdose has quit IRC |
| 19:56:54 | *** cta has quit IRC |
| 19:57:53 | <Suranga> downeym, howdy.. r u busy ? |
| 19:58:03 | <downeym> Suranga: have a few minutes. what's up? |
| 19:58:17 | <Suranga> downeym, regarring your mail |
| 19:58:38 | <Suranga> downeym, i just tried attaching screenshots, but seems they too are not getting displayed |
| 19:58:47 | <downeym> ticket number? |
| 19:59:07 | <Suranga> tunk 2483 |
| 19:59:12 | <downeym> !ticket TRUNK-2483 |
| 19:59:13 | <OpenMRSBot> downeym: [#TRUNK-2483] Improving on complex obs handlers : The obsForm.jsp needs to display a custom field for user to input / view data - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2483 |
| 19:59:21 | <downeym> ok one minute |
| 20:00:23 | <Suranga> downeym, sure, no problem - actually this review is over, so we dont actually need it any more.. I was just checking out why images are not getting displayed any more |
| 20:00:34 | <Suranga> downeym, no worries |
| 20:00:47 | <downeym> Suranga: remind me what you used to make the screen shots? |
| 20:01:25 | <Suranga> downeym, i tried more actions -> attach filed |
| 20:01:32 | <downeym> i mean to create the image |
| 20:01:42 | <Suranga> downeym, then today i tried more actions -?> attach screnshot |
| 20:01:54 | <Suranga> downeym, its a jpg that i took earlier |
| 20:02:05 | <downeym> and what software did you use to create the jpg file? :) |
| 20:02:30 | <Suranga> downeym, mspaint... |
| 20:02:46 | *** gbastien has quit IRC |
| 20:03:21 | <Suranga> downeym, just a ctrl + alt + print -> paste to mspaint and save :) |
| 20:04:03 | <downeym> Suranga: can you try to download/save http://openmrs.org/media/kaduna-300x225.jpg then attach that one? |
| 20:04:28 | <Suranga> downeym, sure |
| 20:04:33 | <downeym> Suranga: ok, let me know |
| 20:08:12 | *** rafa has quit IRC |
| 20:10:03 | <Suranga> downeym, hi |
| 20:10:10 | <downeym> Suranga: hey |
| 20:10:12 | <Suranga> unfortunately that does not seem to work either |
| 20:10:45 | <Suranga> downeym, but still, its visible via the managet attachments page https://tickets.openmrs.org/secure/attachment/36636/screenshot-2.jpg |
| 20:10:55 | <OpenMRSBot> <http://ln-s.net/91HJ> (at tickets.openmrs.org) |
| 20:13:43 | <downeym> Suranga: ok, i've found a bug/issue in jira that i'll have to look at |
| 20:14:18 | <Suranga> downeym, sure, no problem... |
| 20:14:41 | <Suranga> downeym, finding bugs in Jira... we're pretty advanced arnt we :-) |
| 20:14:43 | <downeym> thanks for helping me troubleshoot :) |
| 20:15:06 | <Suranga> downeym, no problem, I was worried if it was something i was doing wrong :P |
| 20:15:31 | <downeym> Suranga: Could not initialize class com.sun.imageio.plugins.jpeg.JPEGImageReader |
| 20:15:36 | <downeym> Suranga: not you :) |
| 20:16:36 | <Suranga> downeym, wow.. i forgot that u had access to the back end logs :P |
| 20:16:42 | *** asgoyal has quit IRC |
| 20:16:55 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @DivaDanese: Prepping for a meeting I'm hosting at #OSCON today in E142 at 1:30pm on the subject of SocialCoding4Good. Come by if yo ... <http://twitter.com/OpenMRS/statuses/95944857381638145> |
| 20:17:58 | *** yanokwa has joined #openmrs |
| 20:17:58 | *** ChanServ sets mode: +v yanokwa |
| 20:22:44 | *** Suranga has quit IRC |
| 20:23:58 | *** batkinson has joined #openmrs |
| 20:26:12 | *** yanokwa has quit IRC |
| 20:26:38 | *** yanokwa has joined #openmrs |
| 20:26:38 | *** ChanServ sets mode: +v yanokwa |
| 20:27:20 | *** yanokwa has quit IRC |
| 20:27:26 | *** yanokwa has joined #openmrs |
| 20:27:26 | *** ChanServ sets mode: +v yanokwa |
| 20:29:30 | *** downeym has quit IRC |
| 20:30:24 | *** downeym has joined #openmrs |
| 20:30:24 | *** OpenMRSBot sets mode: +o downeym |
| 20:30:24 | *** ChanServ sets mode: +o downeym |
| 20:40:59 | *** batkinson has quit IRC |
| 20:52:06 | *** suho has quit IRC |
| 21:11:32 | *** downeym has quit IRC |
| 21:16:09 | <dkayiwa> hi djazayeri |
| 21:20:51 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OSCON Social Coding for Good session starting right now in E142. You should join us & help change the world. <http://twitter.com/OpenMRS/statuses/95954787761258497> |
| 21:20:51 | <dkayiwa> djazayeri: do u have time now to discuss the <openmrs:portlet>, and <openmrs:htmlInclude> tags as for TRUNK-2456 |
| 21:21:04 | <djazayeri> dkayiwa: in 10 mins |
| 21:24:36 | *** dkayiwa has quit IRC |
| 21:29:04 | *** bryq1 has quit IRC |
| 21:32:43 | *** bumi has joined #openmrs |
| 21:38:25 | <bumi> Hi guys, im stuck and i need help, basically im creating a convset concept, but im getting a null pointer exception, saying fomrField = null in method saveFormField,any help please.... |
| 21:43:54 | <djazayeri> bumi: are you doing this in the concept dictionary? |
| 21:43:56 | <djazayeri> or while creating a form? |
| 21:46:38 | <bumi> error shows up when i create a form, it says javascript error and then the loggs say its in the saveFormField method |
| 21:51:14 | <djazayeri> bumi: can you replicate this on demo.openmrs.org? |
| 21:53:44 | <bumi> let me try , but i actually went thru the classic 'current medication orders, example and it works fine on the same system 1.8.1 build |
| 22:13:08 | <bumi> djazayeri, it actually works fine in demo.openmrs.org, any ideas? |
| 22:13:37 | <djazayeri> bumi: it happens repeatedly? |
| 22:13:48 | <bumi> yes |
| 22:14:14 | <djazayeri> can you provide the full stack trace via pastebin? |
| 22:14:39 | <bumi> i actually dont know pasterbin... |
| 22:14:52 | <djazayeri> pastebin.com |
| 22:15:07 | <bumi> okay let me check |
| 22:21:35 | <bumi> pasted and submitted,that it @djazayeri? |
| 22:21:51 | <djazayeri> you need to past the url of that pastebin here in the irc chat |
| 22:22:18 | <djazayeri> basically that's a convenient way for you to show me a big ugly chunk of text, without directly pasting it in IRC. |
| 22:23:10 | <bumi> okay, here it is :http://pastebin.com/29xZXk5Q |
| 22:25:11 | *** gbastien has joined #openmrs |
| 22:25:39 | <djazayeri> please tell me the steps you take to get this error |
| 22:25:45 | <djazayeri> you created a concept with class=ConvSet? |
| 22:26:19 | <wyclif> djazayeri, can i access the httpRequest object from a controller of a fragment |
| 22:26:20 | <bumi> yes |
| 22:26:53 | <djazayeri> wyclif: yeah, it should be one of the automatically handled parameter types |
| 22:27:03 | <bumi> another paste:http://pastebin.com/Yb5my7vT |
| 22:27:04 | <djazayeri> if not, you can get to it through PageRequest |
| 22:27:18 | <wyclif> djazayeri, when i add the FragmentActionRequest as an argument it is null |
| 22:27:42 | <djazayeri> wyclif: the controller() method can't take a FragmentActionRequest |
| 22:27:49 | <wyclif> it works for the Fragment action but not the controller |
| 22:27:52 | <wyclif> ok |
| 22:27:59 | <wyclif> so it is page request |
| 22:28:35 | <djazayeri> https://wiki.openmrs.org/display/docs/Flexible+Method+Signatures+for+Controller+and+Action+Methods |
| 22:28:43 | <OpenMRSBot> <http://ln-s.net/91Ie> (at wiki.openmrs.org) |
| 22:29:12 | <djazayeri> also, you can do @RequestParam |
| 22:29:18 | <bumi> i created a convset concept and then added it to a form in observation section which has other concepts, and then on saving the form a message pops up saying javascript error |
| 22:29:39 | <djazayeri> what concept did you create? |
| 22:29:56 | <djazayeri> (what's it's name and datatype? is it a set? |
| 22:30:27 | <bumi> 'status at start art' |
| 22:30:40 | <djazayeri> wyclif: (actually, maybe you can't do a @RequestParam in a fragment controller method) |
| 22:31:22 | <djazayeri> bumi: what is its datatype? |
| 22:31:40 | <bumi> and then it has members: N/A |
| 22:32:30 | <djazayeri> bumi: are all of its members legitimate questions? I.e. do all of its members have datatype != N/A? |
| 22:33:21 | <bumi> no, some have numeric datatypes,and another is coded with N/A answers |
| 22:33:39 | <djazayeri> I mean datatype NOT N/A |
| 22:34:02 | <bumi> sorry yes, some have numeric datatypes,and another is coded with N/A answers |
| 22:34:22 | <djazayeri> Okay. Honestly I never use the form schema editor... |
| 22:35:39 | <bumi> okay seems im stuck for the moment, thanks for your help. |
| 22:35:44 | <djazayeri> Looking at the stack trace, I suspect it's because you have a concept without a name or description |
| 22:35:48 | <djazayeri> or else a field without a name |
| 22:36:34 | <bumi> okay i check again with that in mind |
| 22:36:48 | <bumi> okay i'll check again with that in mind |
| 22:37:48 | <bumi> many thanks djazayeri |
| 22:38:51 | <wyclif> djazayeri, that was helpful, because i have made the settings page a fragment that i just include on advanced settings page but but included in another page e.g a module can have it own fragment as long it specifies a prefix |
| 22:39:04 | <wyclif> sorry but can be included |
| 22:39:10 | *** batkinson has joined #openmrs |
| 22:44:22 | <bumi> quit |
| 22:44:41 | <bumi> \quit |
| 22:44:55 | *** bumi has quit IRC |
| 22:47:11 | *** jportela has left #openmrs |
| 22:49:09 | <djazayeri> wyclif: sounds cool, looking forward to seeing it |
| 22:50:21 | *** wyclif has quit IRC |
