| 00:46:26 | *** gbastien has quit IRC |
| 01:13:27 | *** jportela has quit IRC |
| 01:42:55 | *** gbastien has joined #openmrs |
| 01:55:10 | *** downeym has joined #openmrs |
| 01:55:10 | *** ChanServ sets mode: +o downeym |
| 01:55:10 | *** OpenMRSBot sets mode: +o downeym |
| 02:01:21 | *** downeym has quit IRC |
| 02:11:01 | *** gbastien has quit IRC |
| 02:28:12 | *** lh has joined #openmrs |
| 02:29:56 | *** muthah has quit IRC |
| 02:32:02 | *** lh has quit IRC |
| 02:39:16 | *** upul` has joined #openmrs |
| 02:39:16 | *** ChanServ sets mode: +v upul` |
| 03:19:14 | *** yanokwa has joined #openmrs |
| 03:19:14 | *** ChanServ sets mode: +v yanokwa |
| 03:19:22 | *** yanokwa has quit IRC |
| 03:19:28 | *** yanokwa has joined #openmrs |
| 03:19:28 | *** ChanServ sets mode: +v yanokwa |
| 05:04:25 | *** surangak has joined #openmrs |
| 05:04:28 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : Fixed storing selected by user language into session <http://feedproxy.google.com/~r/OMRStrunk/~3/w2T1wfQIYfs/OpenMRS> |
| 05:04:40 | *** saimanohar has joined #openmrs |
| 05:05:09 | <saimanohar> hello all |
| 05:07:14 | <saimanohar> i had a small question regarding the datetime parsing in a jsp.for example taking obsForm.jsp,when the obs object is returned from the formbackingobject it is a timestamp when is it parsed to dd/mm/yyyy while displaying? |
| 05:39:10 | *** finbrein has quit IRC |
| 05:58:50 | *** saimanohar has quit IRC |
| 06:01:47 | *** finbrein has joined #openmrs |
| 06:04:56 | *** finbrein has quit IRC |
| 06:13:02 | *** bwolfe has joined #openmrs |
| 06:13:02 | *** ChanServ sets mode: +o bwolfe |
| 06:40:36 | *** rafa has joined #openmrs |
| 06:40:36 | *** ChanServ sets mode: +v rafa |
| 06:41:28 | <rafa> bwolfe: Hey Ben! |
| 06:41:37 | <bwolfe> hey rafal |
| 06:41:50 | <rafa> I'll need your help |
| 06:42:15 | <bwolfe> in the future, or right now? |
| 06:42:30 | <rafa> bwolfe: Just tell me if you have a free moment |
| 06:43:38 | <rafa> it |
| 06:43:59 | <rafa> it's regading trunk 2482. |
| 06:44:09 | <rafa> !ticket TRUNK-2482 |
| 06:44:10 | <OpenMRSBot> rafa: [#TRUNK-2482] In 2.x, uploading a module completely crashes OpenMRS - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2482 |
| 06:44:21 | <bwolfe> ask away |
| 06:45:18 | <rafa> Do you have any idea why Hibernate might not be starting after starting/stopping, uploading a module? |
| 06:45:35 | <bwolfe> is the stack trace on that ticket? or somewhere? |
| 06:45:39 | <rafa> yes |
| 06:46:27 | <rafa> It worked before wyclif's commit. |
| 06:46:46 | <rafa> So theoretically it should be easier to find the problem |
| 06:47:02 | *** pascal` has joined #openmrs |
| 06:47:11 | <rafa> I tried a couple of things but with no avail |
| 06:47:24 | <bwolfe> can you link me to wyclif's commit? |
| 06:48:10 | <rafa> https://source.openmrs.org/changelog/contrib?cs=21794 |
| 06:49:14 | <bwolfe> thanks |
| 06:49:21 | <rafa> First thing I noticed was that filters were reordered in web.xml. |
| 06:49:37 | <rafa> I reverted HibernateFilter back to its original position |
| 06:49:42 | <rafa> but it didn't help |
| 06:50:33 | <rafa> I'm not that familiar with the entire process of starting/stopping modules |
| 06:50:52 | <rafa> thus I'm not sure where else to look |
| 06:55:34 | <bwolfe> ok, still loading it up |
| 06:55:51 | <bwolfe> internet speed is decent for me...but I have a temp computer right now so I'm downloading all the apps I need too! |
| 06:57:05 | <rafa> bwolfe: ok, thanks! Let me know if anything comes across your mind. |
| 06:57:32 | <rafa> bwolfe: It's breakfast time for me :) |
| 07:03:25 | *** dkayiwa has joined #openmrs |
| 07:10:41 | *** bwolfe has quit IRC |
| 07:11:09 | *** bwolfe has joined #openmrs |
| 07:11:09 | *** ChanServ sets mode: +o bwolfe |
| 07:12:49 | *** dkayiwa has quit IRC |
| 07:15:10 | <rafa> bwolfe: btw the head revision is not compiling, you'll need to go one back to 21849 |
| 07:15:53 | <bwolfe> ok |
| 07:26:27 | *** bwolfe has quit IRC |
| 07:29:57 | *** bwolfe has joined #openmrs |
| 07:29:57 | *** ChanServ sets mode: +o bwolfe |
| 07:30:20 | *** magoo has joined #openmrs |
| 07:31:33 | <wyclif> rafa, the order is filters is basically not any different from that in 1.x, the hibernate filer is supposed to come after is supposed to come after all subclasses of startupfilter |
| 07:31:49 | <wyclif> sorry! order of filters |
| 07:32:33 | <bwolfe> wyclif, where is first commit where you just copied/pasted files over? |
| 07:32:39 | <wyclif> rafa, the order of the filters is basically not any different from that in 1.x, the hibernate filter is supposed to come after all subclasses of startupfilter |
| 07:32:48 | <rafa> wyclif: yes, apparently it's not a problem |
| 07:33:25 | <wyclif> bwolfe, just a sec as i look it up |
| 07:34:20 | <wyclif> https://source.openmrs.org/changelog/CONTRIB/?cs=21779 and https://source.openmrs.org/changelog/CONTRIB/?cs=21780 |
| 07:34:26 | <OpenMRSBot> <http://ln-s.net/916w> (at source.openmrs.org) |
| 07:34:33 | <wyclif> but i have made a couple of more commits |
| 07:34:52 | <bwolfe> there shoudl be one before those |
| 07:34:58 | <bwolfe> wyclif: you have to be careful to list out all the changesets in the tickets and/or put the ticket id int he commit message |
| 07:35:46 | <wyclif> bwolfe, only characterEncodingFilter comes before them |
| 07:36:23 | <wyclif> bwolfe, the commits are linked to the ticket, i got them from it |
| 07:37:38 | <wyclif> bwolfe, raff, i need to go back to bed, i just got up shortly and saw your messages on the screen and felt i could chime in the middle of my sleep, if i said crap, am sorry! |
| 07:38:06 | <rafa> wyclif: thanks! have a good rest :) |
| 07:39:05 | <bwolfe> hehe, thanks wyclif |
| 07:39:06 | <bwolfe> gnight |
| 07:39:49 | <wyclif> talk to you later |
| 07:42:17 | <rafa> bwolfe: so Ben, Hibernate actually starts. I mean it builds a new session factory. |
| 07:42:32 | <bwolfe> ok |
| 07:42:36 | <rafa> I don't know why it can't open the session :/ |
| 07:42:38 | <bwolfe> but where does it fail? |
| 07:42:39 | <bwolfe> ah |
| 07:42:57 | <bwolfe> have you verified its not any of the other commits between wyclif's and head? |
| 07:43:05 | <bwolfe> or wyclif's and when it last works for you |
| 07:43:50 | <rafa> it last works for me before wyclif's commit |
| 07:44:01 | <rafa> the one I included in the ticket |
| 07:44:19 | <rafa> there was only a small issue then that I resolved |
| 07:44:30 | <rafa> but after wyclif's commit it all broke |
| 07:44:43 | <bwolfe> so 21793 would work for you? |
| 07:45:14 | <rafa> 21789 |
| 07:45:44 | <rafa> but yes 21793 there was nothing in between |
| 07:46:06 | <bwolfe> right, was just about to say that. :-) |
| 07:46:06 | <bwolfe> hmm |
| 07:46:29 | <bwolfe> try putting the app-config.xml etc back into the spring servlet in web.xml |
| 07:47:19 | <bwolfe> https://source.openmrs.org/browse/contrib/ui-frameworks/ui2-refactored/webapp/src/main/webapp/WEB-INF/web.xml?r1=21758&r2=21794 |
| 07:47:24 | <OpenMRSBot> <http://ln-s.net/9171> (at source.openmrs.org) |
| 07:48:38 | <rafa> ok |
| 07:49:25 | <wyclif> apparently, everything works fine for me |
| 07:50:58 | <rafa> Can you start/stop modules through manageModules, wyclif? |
| 07:52:07 | <rafa> btw you might have forgotten to commit something :) |
| 07:52:16 | <wyclif> rafa, i haven't tried it out, but i will first thing in the morning and try to debug the issue with you, but bwolfe is more knowledgeable with the module engine |
| 07:52:38 | <rafa> wyclif: no worries |
| 07:52:47 | <rafa> wyclif: good night ;) |
| 07:52:54 | <wyclif> goddnight |
| 07:54:12 | <rafa> bwolfe: it didn't help |
| 07:55:39 | <wyclif> rafa, there is a commented out line in the Context loader listener that load module, it might have something to do with it |
| 07:55:49 | <wyclif> try to uncomment it and try again |
| 07:57:14 | <wyclif> and note that we have a couple of files that exist twice but in different packages, so make sure you are importing the right ones |
| 07:57:28 | <wyclif> we need to clean this up |
| 08:23:38 | <bwolfe> rafa: any caching stuff on the classpath/ |
| 08:23:39 | <bwolfe> ? |
| 08:24:03 | <rafa> bwolfe: what do you mean? |
| 08:24:44 | <bwolfe> meaning this looks like a hibernate caching issue. are the caching files in the right place? (and findable by the classloader) |
| 08:25:40 | <rafa> bwolfe: I don't know where to look. |
| 08:25:40 | <bwolfe> going to ask this again: are you sure its that commit of wyclifs? did you try going to the first commit after that (that compiles) to see if it works? |
| 08:25:51 | <bwolfe> looks like there are multiple commits since then... |
| 08:26:26 | <rafa> bwolfe: yes, I did try. It doesn't work. |
| 08:26:47 | <bwolfe> so it really does have something to do with that commit... |
| 08:27:04 | <bwolfe> wait, does that mean it doesn't compile or the modules can't be loaded? |
| 08:27:15 | <rafa> it does compile :) |
| 08:27:25 | <rafa> but modules can't be loaded |
| 08:28:42 | <rafa> only the head revision does not compile |
| 08:28:57 | <bwolfe> ok |
| 08:30:38 | *** jopatrade has joined #openmrs |
| 08:31:28 | <jopatrade> hi we are working on a government project. We are looking for someone to implement the openmrs |
| 08:32:32 | <bwolfe> jopatrade: where are you ? |
| 08:32:53 | <jopatrade> zimbabwe |
| 08:33:44 | <jopatrade> we are developing a prisoner information management system, which has a medical area. We wanted to use openmrs for that |
| 08:33:54 | <bwolfe> ok. tough place to implement! I've heard stories about the government there not really wanting openmrs there |
| 08:34:18 | <bwolfe> oh, in prison? thats neat. maybe th govt only cares about the hiv clinic overlap |
| 08:34:49 | <bwolfe> there is a consulting shop in South Africa that I know about. and one in NBO. both do custom openmrs installs |
| 08:35:11 | <bwolfe> there are also groups in TZ, but I don't know if they travel out of tz |
| 08:35:28 | <bwolfe> there are 2 or 3 different implementations of openmrs in zim. have you seen those jopatrade ? |
| 08:35:40 | <jopatrade> im not aware |
| 08:36:54 | <jopatrade> ive been trying to install openmrs.war on a private tomcat at javaprovider.net for testing purposes however i keep getting errors |
| 08:37:18 | <bwolfe> what're the errors? |
| 08:41:12 | *** jopatrade has quit IRC |
| 08:42:43 | <bwolfe> rafa: I don't see any files that might have caused this change :-/ |
| 08:43:01 | *** jopatrade has joined #openmrs |
| 08:43:05 | <rafa> bwolfe: I was able to open a hibernate session in WebModuleUtil.refreshWAC just after the context was refreshed. It seems that the context is refreshed correctly. |
| 08:43:05 | <jopatrade> sorry i had not documented them.. i can give you temporary acess to the server, so u can have a look |
| 08:43:14 | <magoo> hi everyone having the following errors pastbin url http://pastebin.com/eKSSCXU7 |
| 08:43:38 | <bwolfe> rafa: you said you put the hibernatefilter back in? I see he removed it from the web.xml... |
| 08:43:59 | <bwolfe> magoo: what are you doing when you get that? |
| 08:44:00 | <rafa> bwolfe: It's there, but a few lines below. |
| 08:44:14 | <jopatrade> sorry i had not documented them.. i can give you temporary acess to the server, so u can have a look |
| 08:44:23 | <bwolfe> jopatrade: I'd rather have you work on it and give us the errors...means I can multi task better while debugging |
| 08:44:42 | <jopatrade> ok will do |
| 08:45:08 | <bwolfe> rafa: this makes it look like its totally deleted: https://source.openmrs.org/changelog/contrib?cs=21794 |
| 08:45:10 | <OpenMRSBot> <http://ln-s.net/916c> (at source.openmrs.org) |
| 08:45:13 | <bwolfe> you make sure its not commented out? |
| 08:45:21 | <rafa> yes |
| 08:45:49 | <rafa> I moved it back to its original place, but it didn't help |
| 08:46:08 | <rafa> Now, I'm trying to open a hibernate session within the same request that I stop the module. |
| 08:46:16 | <bwolfe> magoo: from the stack trace: Please verify that you run Maven using a JDK and not just a JRE. @ line 30, column 28 |
| 08:47:51 | <rafa> bwolfe: I was able to open it within the same request. |
| 08:48:06 | <rafa> bwolfe: it seems that the problem is only with next requests |
| 08:49:16 | *** jopatrade has quit IRC |
| 08:49:22 | <bwolfe> rafa: which cs are you running off of now? |
| 08:49:41 | <rafa> cs? |
| 08:50:35 | <rafa> bwolfe: what is cs :) |
| 08:50:42 | <bwolfe> changeset |
| 08:51:06 | <rafa> 21849 |
| 08:51:23 | <rafa> It's the latest compiling one. |
| 08:52:37 | <rafa> I'll debug the filters now |
| 08:53:23 | <rafa> bwolfe: they should go one after another in the order they're declared in web.xml right? |
| 09:00:40 | <rafa> bwolfe: I'm in OpenmrsFilter and I can sucessfully open a hibernate session with Context.openSession(); |
| 09:01:06 | <rafa> bwolfe: It seems that it's just the HibernateFilter that has problem with opening it correctly |
| 09:01:14 | <rafa> bwolfe: Any thoughts? |
| 09:06:45 | *** suho has joined #openmrs |
| 09:06:45 | *** ChanServ sets mode: +v suho |
| 09:09:43 | <rafa> bwolfe: OpenmrsFilter is the last one, so the exception occurs the way back |
| 09:10:15 | <rafa> bwolfe: But it shouldn't since I was able to open the session through Context |
| 09:10:31 | <bwolfe> rafa: hmm |
| 09:10:41 | <bwolfe> did wyclif change that filter though? |
| 09:10:48 | <bwolfe> yes, the execute in order (or are supposed to) |
| 09:10:55 | *** goutham has joined #openmrs |
| 09:11:03 | <bwolfe> so you just can't open a session when in a controller? |
| 09:11:23 | <rafa> no |
| 09:11:29 | <rafa> He just added some in between |
| 09:12:00 | <rafa> He also changed the way runtime properties are retrieved. |
| 09:12:13 | <rafa> maybe it has something to do with it? |
| 09:12:24 | <rafa> HibernateFilter does not use Context for sure |
| 09:12:41 | <rafa> It must be accessing database properties on it's own |
| 09:19:11 | <rafa> bwolfe: I'll disable filters one by one. |
| 09:19:14 | <rafa> see what happens |
| 09:19:24 | *** pascal` has quit IRC |
| 09:32:33 | *** pascal` has joined #openmrs |
| 09:37:22 | *** suho has quit IRC |
| 09:51:48 | <magoo> a bit confused how do i configure maven to run in jdk? |
| 09:51:51 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2258#CR-TRUNK-433 Fixed the review comments. <http://feedproxy.google.com/~r/OMRStrunk/~3/67iBcWi-AbI/OpenMRS> |
| 09:51:54 | <rafa> bwolfe: ha! I managed to tighten up the problem to web.xml. I switched this single file to the rev 21758 and it works! |
| 09:52:01 | <magoo> dd |
| 09:52:23 | <magoo> how do i configure maven to run in jdk? |
| 09:53:17 | <rafa> magoo: http://stackoverflow.com/questions/2503658/specify-jdk-for-maven-to-use |
| 09:53:22 | <OpenMRSBot> <http://ln-s.net/917j> (at stackoverflow.com) |
| 09:53:33 | <magoo> okay |
| 09:57:48 | <bwolfe> rafa: so its somethign between 21758 and what in web.xml ? HEAD? or some other revision? |
| 09:58:54 | <rafa> bwolfe: 21758 and 21794 |
| 09:59:54 | <rafa> I'll be copying changes one by one and see when it breaks |
| 10:00:37 | <bwolfe> yeah, thats the slow foolproof way of doing it |
| 10:00:45 | <rafa> oh it was fast actually |
| 10:00:49 | <bwolfe> you could do some sort of binary sort on it too :-) |
| 10:01:03 | <bwolfe> https://source.openmrs.org/browse/contrib/ui-frameworks/ui2-refactored/webapp/src/main/webapp/WEB-INF/web.xml?r1=21758&r2=21794 |
| 10:01:04 | <OpenMRSBot> <http://ln-s.net/9171> (at source.openmrs.org) |
| 10:01:08 | <bwolfe> got it already rafa? |
| 10:01:16 | <rafa> bwolfe: Spring MVC Dispatcher Servlet |
| 10:02:05 | <bwolfe> right, thats what I claimed before! |
| 10:02:05 | <bwolfe> the contextConfigLocation stuff? |
| 10:02:46 | <rafa> right, I must have copied it in the wrong place! |
| 10:02:57 | <rafa> in servlet-mapping below |
| 10:04:00 | <rafa> let me test the entire thing now |
| 10:05:54 | *** goutham has quit IRC |
| 10:06:11 | <bwolfe> goutham: do I need to check out/update/install all the different projects to test the wizard plugin/ |
| 10:07:40 | <rafa> bwolfe: it works! |
| 10:08:11 | <rafa> bwolfe: now the question is if we can leave it this way |
| 10:08:22 | <bwolfe> heh |
| 10:08:28 | <bwolfe> wyclif put a pretty long message there about it |
| 10:08:32 | <bwolfe> I would guess "no" :-) |
| 10:08:59 | <bwolfe> rename your runtime props and see if you can get to the init wizard without it failing |
| 10:09:31 | <rafa> ok, I'll try |
| 10:11:09 | *** goutham has joined #openmrs |
| 10:12:01 | <rafa> bwolfe: it works fine |
| 10:14:19 | <rafa> bwolfe: I'll commit that and let wyclif now. |
| 10:14:36 | *** bwolfe has quit IRC |
| 10:21:27 | *** bwolfe has joined #openmrs |
| 10:21:27 | *** ChanServ sets mode: +o bwolfe |
| 10:23:30 | <rafa> bwolfe: Thanks for your help! I only wish I did it right the moment you suggested it! |
| 10:24:04 | <rafa> bwolfe: It'd save us three hours |
| 10:24:23 | <bwolfe> rafa: I lost connection for a bit, does the startup and update wizard still load for you after putting those back? |
| 10:24:34 | <rafa> yes, it does |
| 10:24:53 | <rafa> I committed the change |
| 10:24:57 | <rafa> let wyclif now |
| 10:25:05 | <rafa> actually I started a reivew for him |
| 10:25:20 | <rafa> maybe there's a special case when it failed for him |
| 11:03:20 | *** james_regen has joined #openmrs |
| 11:03:20 | *** ChanServ sets mode: +v james_regen |
| 11:03:44 | *** jportela has joined #openmrs |
| 11:03:44 | *** ChanServ sets mode: +v jportela |
| 11:04:44 | *** jportela has left #openmrs |
| 11:14:12 | *** surangak has quit IRC |
| 11:38:40 | *** upul` has quit IRC |
| 12:19:32 | <bwolfe> rafa: is ui2 still broken for you? |
| 12:20:19 | <rafa> bwolfe: I don't know, I'm workning on the head revision |
| 12:20:25 | <rafa> bwolfe: shall I check? |
| 12:20:48 | <bwolfe> you mean "not working" rafa ? |
| 12:20:50 | *** magoo has quit IRC |
| 12:21:41 | <rafa> bwolfe: I mean I'm working on rev 21849 |
| 12:22:03 | <rafa> bwolfe: 21850 is broken |
| 12:22:21 | <bwolfe> ok, looks like I have 21855 |
| 12:22:35 | <rafa> bwolfe: 21855 is a small commit of mine, but it's not relevant |
| 12:22:46 | <bwolfe> we need a ci build of this project just so we can notify devs that they broke the build |
| 12:23:03 | <rafa> yes, it would be really useful |
| 12:23:55 | <rafa> Ben does our ci run unit tests as well? |
| 12:24:05 | <rafa> I guess it fires mvn command right? |
| 12:24:14 | <bwolfe> yeah, just runs maven commands |
| 12:24:21 | <bwolfe> there aren't any unit tests in ui2 though |
| 12:24:30 | <rafa> yes I noticed :) |
| 12:24:39 | <rafa> not good ;) |
| 12:26:36 | *** wyclif has quit IRC |
| 12:32:21 | *** magoo has joined #openmrs |
| 12:46:06 | <bwolfe> rafa: https://ci.openmrs.org/browse/SPRNT-UI2/ |
| 12:47:08 | <rafa> bwolfe: cool, but why it's green? |
| 12:47:26 | <bwolfe> was just checking that... |
| 12:47:36 | *** goutham has quit IRC |
| 12:47:40 | <bwolfe> perhaps because its installing at the top level instead of referecneapp? |
| 12:48:10 | <bwolfe> wait, no, top level is right... |
| 12:50:00 | <rafa> bwolfe: It fails for me building webapp... |
| 12:50:17 | <bwolfe> yeah, me too |
| 12:50:23 | <bwolfe> just not on ci. :-( |
| 12:50:38 | <rafa> strange |
| 12:50:53 | <bwolfe> oh, perhaps its a 1.8.x thing |
| 12:51:00 | <bwolfe> or the new trunk addition |
| 12:51:09 | <bwolfe> you need to do an svn update on trunk and install that |
| 12:51:28 | <rafa> bwolfe: oh maybe you're right |
| 12:51:44 | <rafa> bwolfe: I just remembered that Darius said something about changing to 1.8.x |
| 12:52:18 | <bwolfe> shouldn't be 1.8.x. wyclif's new feature was so trunk could run diff changesets |
| 12:52:33 | <bwolfe> and ui2 is taking advantage of that to run the ui-only liquibase changelog |
| 12:52:47 | <bwolfe> so you need the new api built and in your maven repo to be able to build against it |
| 12:52:49 | <rafa> bwolfe: English thing: I should use reminded myself right? |
| 12:53:21 | <bwolfe> what are you asking? |
| 12:54:12 | <rafa> bwolfe: I just reminded myself not I just remembered? |
| 12:55:56 | <rafa> okay nevermind google says both are correct ;) |
| 12:55:58 | <bwolfe> no, you said it right the first time |
| 12:56:14 | <bwolfe> the second is not correct |
| 12:56:23 | <bwolfe> (or at least americans don't say it) |
| 12:56:24 | <rafa> really? |
| 12:56:39 | <rafa> oh ok because it has 7 bilion hits in google ;) |
| 12:57:12 | <rafa> no sorry just 180 000 |
| 13:01:10 | <bwolfe> 180,000 is probably just non-native speakers saying it. |
| 13:01:55 | <rafa> hehe |
| 13:02:11 | <bwolfe> you can say "I just reminded Rafal to go to the store". but "I just reminded myself to go to the store" should be said as "I just rememberd to go to the store" :-) |
| 13:02:41 | <rafa> I used to think that if something has more than 10,000 in google it's correct |
| 13:02:48 | <bwolfe> and thats your free english lesson for the day |
| 13:02:53 | <bwolfe> heh, not anymore |
| 13:02:55 | <rafa> hehe thanks a lot! |
| 13:03:14 | <bwolfe> there are too many nonnative speakers writing blogs in english |
| 13:03:37 | <bwolfe> and then those get bot'ted and copied and then those get bot'd and copied and they're all indexed by google |
| 13:04:00 | <rafa> It makes sense :D |
| 13:12:06 | <rafa> bwolfe: Darius actually did not change the project to 1.8.x. It's still 1.9.x, but clean install on 1.9.x does help :) |
| 13:12:38 | <rafa> bwolfe: but it still proves that CI is a great thing to have ;) |
| 13:13:39 | <bwolfe> heh, wish I had done it this morning so that you could have been building it this whole day...or were you just operating fine on the other revision? |
| 13:14:22 | <pascal`> djazayeri, got a second? |
| 13:14:23 | <rafa> bwolfe: I was just fine with the other revision |
| 13:14:40 | *** ChanServ sets mode: +v pascal` |
| 13:17:12 | *** elliott_w has joined #openmrs |
| 13:17:37 | *** ChanServ sets mode: +o elliott_w |
| 13:18:35 | *** wyclif has joined #openmrs |
| 13:20:11 | <bwolfe> rafa: ok, good, I don't feel bad then. :-D |
| 13:25:48 | *** gbastien has joined #openmrs |
| 13:30:54 | *** asgoyal has joined #openmrs |
| 13:32:37 | *** elliott_w has quit IRC |
| 13:39:54 | *** suho has joined #openmrs |
| 13:39:54 | *** ChanServ sets mode: +v suho |
| 13:44:19 | <suho> hi can someone explain me why the Encounter types are used ? |
| 13:44:47 | <suho> Or please direct me to the documentations. |
| 13:46:34 | <asgoyal> djazayeri: sorry to ask this again but what was the syntax of naming the project (name template) while doing svn checkout of a fresh copy of code? |
| 13:47:03 | <asgoyal> projectname{artfacid}... i dont remember |
| 13:47:50 | <bwolfe> suho: encounter types are just a way to group encounters |
| 13:48:13 | <bwolfe> so all "return visit" forms are together, etc |
| 13:49:15 | <suho> in my usecase I have to design the system where the patient will be first diagnosed (1st encounter)and then the patient might get admitted several times.. |
| 13:49:35 | <suho> and in each time they will do some tests |
| 13:50:22 | <pascal`> lol http://twitter.com/#!/jkeiper/status/95479825409654784 |
| 13:50:28 | <OpenMRSBot> <http://ln-s.net/919C> (at twitter.com) |
| 13:50:34 | <suho> these are Thalassaemia patients |
| 13:51:44 | <suho> here each time when they are admitted do we need to create a encounter ? |
| 13:52:57 | <suho> and can we have many forms to add data to the same encounter ? |
| 13:53:32 | <bwolfe> suho: its one form per encounter right now |
| 13:53:54 | <bwolfe> pascal`: I think thats the only reason jer started using foursquare |
| 13:54:05 | <pascal`> chopin++ |
| 13:54:17 | <bwolfe> suho: you might want to look into the Visit stuff in 1.9+ (trunk) |
| 13:55:19 | <suho> so if the patient is admitted for one week in the hospital then all the data at that period should go to the same Encounter ? |
| 13:55:32 | <suho> I'm working on a deployment |
| 13:55:43 | <suho> so i'm only using 1.82 |
| 13:55:50 | <suho> *1.8.2 |
| 13:56:21 | <asgoyal> djazayeri: ^^ |
| 13:58:11 | <bwolfe> asgoyal: darius is asleep until about 2 mins from not |
| 13:58:13 | <bwolfe> *now |
| 13:58:26 | <asgoyal> oh ok |
| 13:58:32 | <bwolfe> he's 3 hours behind you...its not even 7am in seattle for him! |
| 13:58:40 | <asgoyal> can you help me with my question then? |
| 13:58:43 | <asgoyal> oh m sorry |
| 13:58:48 | <bwolfe> asgoyal: look at that drop down to the right. it shoudl show you the different options when checking out |
| 13:58:58 | <asgoyal> there are none |
| 13:58:59 | <asgoyal> i did that |
| 13:59:18 | <asgoyal> darius once showed me how to do it by viewing my screen thru skype |
| 13:59:48 | <bwolfe> itswhateveryouwant.{artifactId} |
| 13:59:52 | <asgoyal> he told me some syntax of naming to use in naming template to segregate project folders into indiviual projects |
| 13:59:54 | <asgoyal> oh |
| 14:01:46 | <rafa> it's time to scrum :) |
| 14:02:56 | <djazayeri> good morning |
| 14:03:05 | <rafa> good morning Darius |
| 14:03:45 | <djazayeri> bwolfe, rafa, wyclif |
| 14:03:50 | <djazayeri> (no dkayiwa?) |
| 14:03:55 | <wyclif> hi |
| 14:04:23 | <bwolfe> djazayeri: daniel sent an email. he'll be on late |
| 14:04:32 | <djazayeri> ah, okay |
| 14:04:37 | <djazayeri> so, rafa, you ready to go first? |
| 14:04:46 | <rafa> Today: |
| 14:04:46 | <rafa> * TRUNK-2482: In 2.x, uploading a module completely crashes OpenMRS |
| 14:04:46 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2482 |
| 14:04:46 | <rafa> - Wyclif, please review the solution. |
| 14:04:46 | <rafa> * TRUNK-2484: Show login popup on unauthorized ajax calls |
| 14:04:46 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2484 |
| 14:04:47 | <rafa> - I need to know, if I should work on this further or move on. |
| 14:04:47 | <rafa> Tomorrow: |
| 14:04:48 | <rafa> - Continue with TRUNK-2484 or pick up a new ticket. |
| 14:04:48 | <rafa> No blockers. |
| 14:06:48 | *** magoo has quit IRC |
| 14:07:06 | <djazayeri> briefly, what was the solution to the module-load-crash ticket? |
| 14:07:20 | <rafa> djazayeri: Ben helped me with that one |
| 14:07:51 | <rafa> djazayeri: it was missing some missing lines in web.xml |
| 14:08:20 | <bwolfe> the second location you defined the spring config files |
| 14:08:26 | <bwolfe> thats the one that spring reads when refreshing |
| 14:08:34 | <bwolfe> the def at the top of web.xml is what is read at startup |
| 14:08:39 | <bwolfe> so it worked at startup, just not at refresh |
| 14:08:42 | <djazayeri> ah, okay |
| 14:08:43 | <rafa> djazayeri: contextConfigLocation param in org.openmrs.ui2.core.spring.DispatcherServlet |
| 14:09:05 | <djazayeri> I didn't know that |
| 14:10:06 | <djazayeri> rafa: you can move on to a higher priority ticket |
| 14:10:16 | <djazayeri> (regarding the login-via-ajax one) |
| 14:10:21 | <rafa> djazayeri: I hope I didn't break the installation wizard by adding these three lines |
| 14:10:26 | <rafa> djazayeri: ok |
| 14:10:45 | <djazayeri> We'll discuss via the ticket the way to actually login via ajax. |
| 14:10:49 | <bwolfe> rafa: its still working for me. but has other problems near the end of it... |
| 14:11:20 | <djazayeri> (it's just ~5 lines of code, but that would bypass the checks that lock your account after too many failures) |
| 14:11:21 | <rafa> bwolfe: I run it without any problem, but I had a db already |
| 14:11:51 | <djazayeri> bwolfe: what other problesm? |
| 14:12:27 | <wyclif> adding those lines is fine as long as the hibernatefilter comes after the startupfilters |
| 14:13:13 | <bwolfe> djazayeri / wyclif : the anonymous role wasn't created and the admin user pw was still "test". I'm sure one caused the other |
| 14:13:20 | <wyclif> however, it works fine without those lines in 1.x |
| 14:14:06 | <wyclif> so i feel like we might mask some problem |
| 14:14:33 | <djazayeri> bwolfe: that's after re-running the wizard on an existing db? |
| 14:14:50 | <djazayeri> or, you mean you put in a new password, but it was never set? |
| 14:15:37 | <bwolfe> djazayeri: fresh db |
| 14:15:40 | <djazayeri> ok |
| 14:15:48 | <bwolfe> its the simple installer, it chooses Admin123 for me |
| 14:16:10 | <djazayeri> I only tried the advanced one. |
| 14:16:39 | <wyclif> bwolfe, do you recall the fix you made when running updates for doing a redirect afer 5 seconds, apparently sometimes it happens too fast and the script tries send the user to the index page yet the update is still in progress, i think we might need to increase that time |
| 14:17:30 | <bwolfe> there's a ticket for it wyclif |
| 14:17:33 | <bwolfe> WARN : org.openmrs.ui2.webapp.Listener - Bundled module folder doesn't exist: /home/ben/workspace/ui2-referenceapplication/webapp/src/main/webapp/WEB-INF/bundledModules |
| 14:17:33 | <bwolfe> Exception in thread "Thread-19" java.lang.NoSuchMethodError: org.openmrs.util.DatabaseUpdater.updatesRequired() |
| 14:17:42 | <wyclif> bwolfe, cool! |
| 14:17:53 | <bwolfe> (everything has a ticket) ;-) |
| 14:19:18 | <wyclif> bwolfe, i addes varargs to that method in trunk, so i think t should still pass if you make that call |
| 14:19:36 | <bwolfe> ok, well, it doesn't :-p |
| 14:19:38 | <wyclif> bwolfe, i added varargs to that method in trunk, so i think it should still pass if you make that call |
| 14:19:48 | <wyclif> hmm!! |
| 14:19:50 | <bwolfe> I updated and installed trunk then clean installed ui2 and ran it |
| 14:20:10 | <djazayeri> odd |
| 14:20:22 | <bwolfe> so consequently I get class java.lang.RuntimeException |
| 14:20:23 | <bwolfe> : Database out of sync with code: Anonymous role does not exist after logging in |
| 14:20:38 | <bwolfe> I assume its because Context.startup(props) didn't get called because of that databaseupdate error |
| 14:21:19 | <djazayeri> bwolfe: did you create a ticket for this? |
| 14:21:53 | <bwolfe> not yet |
| 14:21:59 | <bwolfe> just got it 10 mins ago |
| 14:22:15 | <djazayeri> okay, well, document it. :-) |
| 14:22:28 | <djazayeri> wyclif: your report? |
| 14:23:05 | <bwolfe> isn't that what irc is for? ;-) |
| 14:23:56 | <wyclif> Friday: |
| 14:23:57 | <wyclif> *I was blocked on TRUNK-2079 and created TRUNK-2488 and worked on it, then got back to finish up with TRUNK-2079 |
| 14:23:57 | <wyclif> *Had a gsoc session with my student |
| 14:23:57 | <wyclif> Today: |
| 14:23:57 | <wyclif> *picked up https://tickets.openmrs.org/browse/TRUNK-2457 |
| 14:24:13 | <djazayeri> !ticket TRUNK-2079 |
| 14:24:17 | <OpenMRSBot> djazayeri: [#TRUNK-2079] Incorporate liquibase updates and the initialization wizard into the 2.x web application - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2079 |
| 14:24:26 | <djazayeri> !ticket TRUNK-2488 |
| 14:24:30 | <OpenMRSBot> djazayeri: [#TRUNK-2488] Add ability to specify changelog files when checking for unrun database changes - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2488 |
| 14:24:34 | <djazayeri> !ticket TRUNK-2457 |
| 14:24:35 | <OpenMRSBot> djazayeri: [#TRUNK-2457] 2.x Manage Global Properties page - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2457 |
| 14:25:50 | <djazayeri> wyclif, bwolfe, later I'd like to discuss some of the things we have in WebConstants and whether we can move them elsewhere. |
| 14:25:52 | <wyclif> no blockers yet |
| 14:26:58 | <bwolfe> ok |
| 14:28:31 | <djazayeri> ben, your turn |
| 14:29:25 | <bwolfe> today: |
| 14:29:25 | <bwolfe> worked on occ tickets |
| 14:29:25 | <bwolfe> debugged for rafal |
| 14:29:25 | <bwolfe> debugged for gaurav |
| 14:29:25 | <bwolfe> building/installing occ server/module |
| 14:29:26 | <bwolfe> ui2 ci setup |
| 14:29:27 | <bwolfe> ui2 init testing |
| 14:29:29 | <bwolfe> tomorrow |
| 14:29:31 | <bwolfe> ui2 and occ |
| 14:30:00 | <bwolfe> no blockers yet |
| 14:31:01 | <pascal`> bwolfe, what are some reasons that I could be getting a NoClassDefFoundError error when trying to access one module's service from another? |
| 14:31:09 | <asgoyal> is it my turn? :) |
| 14:31:44 | <bwolfe> pascal`: the module needs to declare that it depdnsd on the other in the config.xml file |
| 14:31:47 | <djazayeri> asgoyal: sure |
| 14:32:16 | <bwolfe> should be something about that on the wiki |
| 14:32:21 | <bwolfe> pascal`^^ |
| 14:32:32 | <djazayeri> asgoyal: go ahead |
| 14:32:33 | <pascal`> bwolfe, thanks. |
| 14:32:35 | <asgoyal> today: will be working on trunk 2193 (trying to finish the last part), will try to complete it, if not will submit the patch |
| 14:32:40 | <pascal`> bwolfe, looking on the wiki. |
| 14:32:46 | <djazayeri> !trunk-2193 |
| 14:32:47 | <OpenMRSBot> djazayeri: Error: "trunk-2193" is not a valid command. |
| 14:32:51 | <djazayeri> !ticket trunk-2193 |
| 14:32:52 | <OpenMRSBot> djazayeri: [#TRUNK-2193] Add Drug Ingredients to API - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2193 |
| 14:33:18 | <asgoyal> done with the two functions (with the help of wyclif) |
| 14:33:29 | <asgoyal> no blockers |
| 14:33:43 | <wyclif> asgoyal, did you make the changes in the UI? |
| 14:34:08 | <asgoyal> no not yet, i was reading the tutorials... but will do that today as you had told me on friday :) |
| 14:34:41 | <wyclif> atleast displaying the ingredients should be enough, i know adding and removing might get a little complex |
| 14:34:49 | <asgoyal> yes |
| 14:35:03 | <asgoyal> so i have some idea how to do that... will work on it today |
| 14:35:12 | <djazayeri> asgoyal: cool |
| 14:35:16 | <asgoyal> if i am able to.. then will try to add and remove it too |
| 14:35:35 | <pascal`> bwolfe, it's on the Module Acces page. My bad. |
| 14:35:38 | <pascal`> pascal`-- |
| 14:35:38 | <OpenMRSBot> pascal`: Error: You're not allowed to adjust your own karma. |
| 14:35:41 | <pascal`> bwolfe++ |
| 14:36:03 | <asgoyal> djazayeri: i m trying to check out a new copy of openmrs trunk in the way u once told me openmrs.{artifactId} |
| 14:36:14 | <djazayeri> [artifactId] |
| 14:36:17 | <djazayeri> square brackets |
| 14:36:22 | <asgoyal> but its not getting separated as.. oh! |
| 14:36:23 | <djazayeri> Also, don't use a dot in the project name |
| 14:36:24 | <suho> hi bwolfe. Can you please let me know the state of "Visit" in 1.9. Can I apply the provided patches to 1.8.2 and get the visit Features |
| 14:36:33 | <asgoyal> so it will be like |
| 14:36:40 | <asgoyal> openmrs[artifactId]? |
| 14:36:47 | <djazayeri> asgoyal: yes |
| 14:36:51 | <asgoyal> oops |
| 14:36:53 | <asgoyal> ok :) |
| 14:37:02 | <djazayeri> My turn |
| 14:37:04 | <djazayeri> Friday: |
| 14:37:04 | <djazayeri> * sprint code reviews |
| 14:37:04 | <djazayeri> * Milestone on 1.x/2.x module compatibility: HTML Form Entry module successfully submits and creates a form |
| 14:37:04 | <djazayeri> * HTML Form Entry Designer planning with Joao |
| 14:37:05 | <djazayeri> Today: |
| 14:37:05 | <djazayeri> * sprint code reviews |
| 14:37:06 | <djazayeri> * another sprint ticket |
| 14:37:07 | <bwolfe> suho: you could...but 1.8.x will never be released with Visit features |
| 14:37:18 | <djazayeri> suho: that would be a bad idea. |
| 14:37:34 | <djazayeri> (because like Ben says, 1.8.x will not have visits) |
| 14:37:57 | <djazayeri> and you don't want to set an implementation up to be running off of a custom build. |
| 14:38:04 | <suho> but then I can update openmrs when 1.9 is released |
| 14:38:06 | <djazayeri> (also, the visit functionality is still alpha) |
| 14:39:23 | <suho> there is a requirement for visits... what should I do :( |
| 14:39:30 | <djazayeri> suho: you can probably get it to work, I'm just saying it's a bad idea, for those two reasons. (I.e. you'll have to manage a custom build, and the functionality is only alpha anyway) |
| 14:39:42 | <djazayeri> bwolfe, rafa, wyclif: no blockers for me |
| 14:39:46 | <djazayeri> so, scrum over? |
| 14:39:53 | <wyclif> ok |
| 14:40:32 | <suho> djazayeri, I'll try to convince them else try to do what I suggested and then later update to 1.9 |
| 14:40:50 | <suho> thanks for the advice |
| 14:41:03 | *** jportela has joined #openmrs |
| 14:41:03 | *** ChanServ sets mode: +v jportela |
| 14:41:08 | <djazayeri> suho: is this a hospital/inpatient installation? |
| 14:41:51 | <suho> its for Thalassaemia patients |
| 14:42:10 | <suho> kind of hospital installation |
| 14:42:52 | <suho> to manage the time and date of when they need to come and change blood and so on |
| 14:43:12 | <suho> and to maintain there recodes |
| 14:43:45 | <djazayeri> suho: yes, visits would be helpful for that. :-) |
| 14:44:18 | <djazayeri> one thing I would suggest you do is email the developers list, specifically asking people in the HISP India group how they've handled doing inpatient stuff without Visits in the data model. |
| 14:45:06 | <suho> ok thanks I'll do that |
| 14:48:57 | *** finbrein has joined #openmrs |
| 14:55:33 | *** pascal` has quit IRC |
| 15:00:43 | *** mario_vitalbox has joined #openmrs |
| 15:02:15 | <mario_vitalbox> Hola Darius buenos dias |
| 15:03:44 | <djazayeri> hola mario_vitalbox |
| 15:04:35 | <mario_vitalbox> Darius te envie un correo con un error al descargar y compilar la version de openmrs del branches 1.8.x |
| 15:05:48 | <djazayeri> mario_vitalbox: 1.8.3 todavia no existe |
| 15:06:01 | <mario_vitalbox> esta configurado con la version 1.8.3 y cuando voy ha esta rutahttp://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/test/openmrs-test/ esta es la 1.8.2 |
| 15:06:05 | <djazayeri> (entonces no se va encontrar en los repositorios publicos de maven) |
| 15:06:07 | <OpenMRSBot> <http://ln-s.net/919h> (at mavenrepo.openmrs.org) |
| 15:06:29 | <djazayeri> el ultimo release estable es 1.8.2 |
| 15:06:43 | <mario_vitalbox> cambio los la version en el build |
| 15:06:46 | <djazayeri> si estas trabajando con 1.8.x, eso va crear 1.8.3-SNAPSHOT |
| 15:07:10 | <djazayeri> has probado con "mvn clean install"? |
| 15:08:01 | <mario_vitalbox> si ya maven clean y luego maven install |
| 15:08:11 | <wyclif> djazayeri, i was looking at the VerticalTabPanelFragmentController and i though i can use this on the settings page |
| 15:08:26 | <wyclif> what is its id? |
| 15:09:08 | <wyclif> am assuming that is a generic widget that i can use anywhere i want to include tabs |
| 15:09:41 | <mario_vitalbox> y continua el mismo error |
| 15:12:09 | <djazayeri> wyclif: verticalTabPanel |
| 15:12:27 | <wyclif> cool, thanks |
| 15:12:28 | <djazayeri> or maybe widgets/verticalTabPanel |
| 15:12:45 | <djazayeri> (you can just drop the "FragmentController", and make the first letter lowercase. |
| 15:13:01 | <wyclif> djazayeri, so how do i know these id, is there a reference where to find this info |
| 15:13:21 | <djazayeri> wyclif: of a particular fragment? or a list of all existing ones? |
| 15:13:44 | <djazayeri> mario_vitalbox: dejame probar a hacer el build |
| 15:13:56 | <mario_vitalbox> ok |
| 15:14:10 | <wyclif> both |
| 15:14:35 | <djazayeri> wyclif: for an existing one, follow the convention, i.e. someId -> SomeIdFragmentController |
| 15:14:36 | <wyclif> probably the naming convention and also a list of all available |
| 15:14:55 | <djazayeri> for a list of all available, we don't have that yet |
| 15:15:21 | <wyclif> i found the controller |
| 15:15:30 | <wyclif> but not the id to use in the gsp |
| 15:16:01 | <djazayeri> You can determine the controller and the id from each other by the convetion |
| 15:16:23 | <djazayeri> You mean the id like ${ ui.includeFragment("verticalTabPanel", …) } right? |
| 15:17:01 | <djazayeri> mario_vitalbox: estas haciendo el build con "skip tests"? |
| 15:18:05 | <mario_vitalbox> no |
| 15:18:30 | <djazayeri> mario_vitalbox: el build (clean, y luego install) funziono para mi |
| 15:21:18 | <mario_vitalbox> yo le estoy dando la opcion openmrs-api->Run As -> maven clean, openmrs-api->Run As -> maven install y me genera el error. |
| 15:21:47 | <djazayeri> puedes hacer eso no al api, pero al "openmrs" |
| 15:21:55 | <djazayeri> el proyecto del raiz? |
| 15:22:01 | *** gbastien has quit IRC |
| 15:22:55 | <mario_vitalbox> no al proyecto desplegado, o sea a cada parte del proyecto -api,test,tool,we y webapp- |
| 15:23:09 | <mario_vitalbox> independiente |
| 15:23:22 | <djazayeri> hazlo al proyecto del raiz |
| 15:23:36 | <djazayeri> eso lo va hacer automaticamente a todos los otros, en el orden correcto |
| 15:24:34 | <mario_vitalbox> ok |
| 15:34:46 | *** gbastien has joined #openmrs |
| 15:36:53 | <djazayeri> mario_vitalbox: arreglo el problema? |
| 15:39:36 | *** gbastien has quit IRC |
| 15:40:28 | *** gbastien has joined #openmrs |
| 15:42:19 | <mario_vitalbox> Listo Darius ya ejecuto bien |
| 15:42:33 | *** finbrein has quit IRC |
| 15:42:52 | *** magoo_ has joined #openmrs |
| 15:43:41 | <wyclif> djazayeri, which is the controller gsp for admin.configureApplication |
| 15:45:08 | <wyclif> am trying to use the naming convention but still can't find them |
| 15:47:37 | *** upul` has joined #openmrs |
| 15:47:37 | *** ChanServ sets mode: +v upul` |
| 15:50:15 | *** goutham has joined #openmrs |
| 15:53:08 | <djazayeri> mario_vitalbox: bueno |
| 15:53:52 | <djazayeri> wyclif: the page (which probably has no controller) is "admin" |
| 15:54:02 | <djazayeri> "admin.configureApplication" is an extension point |
| 15:55:43 | *** gbastien has quit IRC |
| 15:57:09 | <djazayeri> wyclif: i.e. we're including the "linkList" fragment, and its items are taken from the extensions with type=LinkExtension and point="admin.configureApplication" |
| 15:58:25 | <wyclif> ok |
| 15:59:05 | <djazayeri> wyclif: the verticalTabPanel widget might need to be extended/improved to allow the tabs to be "dynamic" |
| 15:59:23 | <djazayeri> or it might just work out of the box. I'm not certain. |
| 16:02:06 | <wyclif> djazayeri, find this class has solved my problem CoreExtensionFactory |
| 16:05:01 | <wyclif> sorry i meant, finding this class by looking at call in the ExtensionManager solved my problem |
| 16:05:09 | *** muthah has joined #openmrs |
| 16:11:01 | <djazayeri> wyclif: cool |
| 16:11:15 | <djazayeri> but for the revised global properties page, we shouldn't need extensions, should we? |
| 16:11:34 | <wyclif> no |
| 16:12:11 | <wyclif> i just wanted to add a link extension to the configure application extension point |
| 16:12:31 | <djazayeri> oh, okay |
| 16:12:38 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OSCON Learn about projects saving the world - join our Humanitarian open source BoF session Wednesday 8pm in E143. #HFOSS <http://twitter.com/OpenMRS/statuses/95522059047804928> || On Twitter: OpenMRS: At #OSCON & want to save lives? Check out "Future of Open Source Development for Health IT" write-in BoF at 10pm tonight in A105! #eHealth <http://twitter.com/OpenMRS/statuses/95517224139374592> |
| 16:13:24 | *** muthah has quit IRC |
| 16:15:24 | *** upul` has quit IRC |
| 16:19:50 | *** muthah has joined #openmrs |
| 16:24:56 | *** gbastien has joined #openmrs |
| 16:29:16 | <djazayeri> How do I set it up so that my "openmrs18" application uses a different modules directory than "openmrs" |
| 16:29:21 | <djazayeri> It already has its own runtime properties file |
| 16:29:36 | *** gbastien has quit IRC |
| 16:29:36 | *** jportela has left #openmrs |
| 16:31:48 | <djazayeri> anyone? |
| 16:33:42 | <wyclif> me |
| 16:33:49 | <djazayeri> ah, it's in runtime properties... |
| 16:33:57 | <djazayeri> seems odd, actually. |
| 16:34:28 | *** dkayiwa has joined #openmrs |
| 16:34:45 | <wyclif> djazayeri, bwolfe , should the settings be managed from a page or you prefer it in a popup dialog |
| 16:34:50 | <djazayeri> page |
| 16:34:55 | <wyclif> ok |
| 16:35:22 | <djazayeri> wyclif: I want to get rid of the silly idea I had to have all the config/management be in a popup dialog |
| 16:35:56 | <magoo_> i have jdk1.6.0_26 installed on my pc but when i run the following command G:\Software\Eclipse32\eclipse>eclipse -vm F:\Program Files\Java\jdk1.6.0_26\bin\javaw.exe i get the message that jre and jdk must be installed no jvm found |
| 16:38:21 | <djazayeri> magoo_: no idea, sorry |
| 16:42:12 | *** gbastien has joined #openmrs |
| 16:50:34 | *** rafa has quit IRC |
| 16:58:48 | *** Echidna has quit IRC |
| 17:00:44 | <wyclif> oky |
| 17:01:31 | <wyclif> djazayeri, bwolfe ,dkayiwa, am off to an RG meeting, it ends in about an hour |
| 17:01:36 | <djazayeri> okay |
| 17:03:46 | *** Echidna has joined #openmrs |
| 17:03:46 | *** ChanServ sets mode: +v Echidna |
| 17:06:26 | *** jportela has joined #openmrs |
| 17:06:26 | *** ChanServ sets mode: +v jportela |
| 17:17:06 | *** magoo_ has quit IRC |
| 17:33:09 | *** magoo_ has joined #openmrs |
| 17:45:42 | *** goutham has quit IRC |
| 17:46:02 | *** gbastien has quit IRC |
| 17:47:07 | <bwolfe> djazayeri: its a gp actually. you can set the modules directory to an absolute or relative path to the openmrs app data dir |
| 17:47:31 | <djazayeri> bwolfe: thanks I figured that out. |
| 17:47:37 | <djazayeri> It seems like something that should be a runtime property |
| 17:49:43 | <djazayeri> bwolfe, wyclif: so, I'm proposing that we don't have the WEBAPP_NAME constant in 2.x |
| 17:49:54 | <djazayeri> we'll have a CONTEXT_PATH constant |
| 17:50:36 | <djazayeri> so theoretically we can run either at / or at /openmrs/something |
| 17:52:04 | <bwolfe> you always could djazayeri |
| 17:52:26 | <bwolfe> but I'm, fine going with just context_path |
| 17:52:30 | <djazayeri> bwolfe: I think some redirects will break because they've been coded with WEBAPP_NAME |
| 17:52:44 | <bwolfe> then those are bad redirects |
| 17:52:45 | <djazayeri> the issue is that the logic that decides what runtime properties file to look for uses WEBAPP_NAME |
| 17:52:49 | <bwolfe> and poo on those module writers |
| 17:52:58 | <bwolfe> right |
| 17:53:09 | <bwolfe> and that needs to remain in some fashion |
| 17:53:09 | <djazayeri> I think it was a core issue. Downey asked me about something. |
| 17:53:12 | <djazayeri> Not sure. |
| 17:53:20 | <djazayeri> anyway |
| 17:53:25 | *** muthah has quit IRC |
| 17:53:36 | <djazayeri> so, I agree that allowing different runtime properties for different versions of the app is good |
| 17:53:54 | <djazayeri> good = necessary |
| 17:54:07 | <djazayeri> wondering if there's another way we can code that |
| 17:54:09 | <bwolfe> right, and however that is acheived is fine by me |
| 17:54:20 | <bwolfe> bbl |
| 17:54:26 | <djazayeri> :-) |
| 17:54:47 | <bwolfe> we can code it using the context path ... minus the slash |
| 17:54:55 | <bwolfe> and if its just a slash, take out the underscore |
| 17:55:08 | <bwolfe> or revert to openmrs_runtimeproperties as the default |
| 17:55:37 | <djazayeri> Are the runtime properties read by the API? or just by the webapp? |
| 17:56:20 | <bwolfe> the api just gets a list of java properties |
| 17:56:26 | <bwolfe> err, a java properties object |
| 17:56:34 | <bwolfe> it doesn't read it specifically I don't think |
| 17:56:41 | <djazayeri> That sounds right. |
| 17:58:23 | *** yanokwa has quit IRC |
| 17:58:40 | <djazayeri> Okay, that sounds like a good enough solution for the runtime props for now. |
| 17:58:48 | *** yanokwa has joined #openmrs |
| 17:58:48 | *** ChanServ sets mode: +v yanokwa |
| 17:58:48 | <djazayeri> Probably we'll do this in another ticket though. |
| 17:59:01 | <djazayeri> wyclif: can you create a new ticket for: |
| 17:59:52 | <djazayeri> (actually, he said he's in a meeting, so I'll write this on the ticket.) |
| 18:03:06 | *** yanokwa has quit IRC |
| 18:10:54 | *** cta has joined #openmrs |
| 18:11:13 | <cta> hello |
| 18:11:26 | <djazayeri> hi |
| 18:19:50 | <cta> bwolfe, djazayeri: Hello, Darius, Ben! At rthe ending of last week I merged current trunk into my branch and have tested installation wizard after this. Unfortunately, I found out that on last stage of installation (exactly when OpenMRS tries to create database tables) occurs exception : "Can not find file liquibase-schema-only" . I investigated into this and found out that this is because liquibase-data.zip file has been changed. Change was affected by revisio |
| 18:19:50 | <cta> n "Move Encounter types from core data to demo data - TRUNK-2446 |
| 18:19:50 | <cta> Author: jtellez" Can you help me with this? |
| 18:25:25 | *** suhothayan has joined #openmrs |
| 18:25:25 | *** ChanServ sets mode: +v suhothayan |
| 18:28:15 | <djazayeri> hi cta |
| 18:28:56 | <djazayeri> the idea of that changeset was to move a few things between demo/core/schema |
| 18:29:34 | *** suho has quit IRC |
| 18:29:44 | <djazayeri> can you look in the zip and see whether a file got renamed? |
| 18:30:28 | <cta> yep |
| 18:31:57 | <cta> djazayeri: File was replaced, not renamed. Not it locates under liquibase-data.zip#liquibase-data/liquibase-schema-only.xml |
| 18:32:09 | <cta> Now --> Not |
| 18:32:21 | <djazayeri> and the liquibase-data is new? |
| 18:32:30 | <djazayeri> (new, and incorrect)? |
| 18:32:57 | <cta> liquibase-data/ folder is new |
| 18:33:05 | <cta> and it affects problem |
| 18:33:12 | <djazayeri> okay, so he probably built the zip file wrong |
| 18:33:31 | <djazayeri> can you comment on TRUNK-2446, and attach a fixed zip file that doesn't have the liquibase-data directory? |
| 18:33:37 | <djazayeri> (after verifying that that works?) |
| 18:33:44 | <cta> I verified |
| 18:33:48 | <cta> already |
| 18:33:55 | <cta> in Sunday |
| 18:34:18 | <djazayeri> cta: if you have a working file, attach it to that ticket, and comment why you're doing it |
| 18:34:25 | <djazayeri> and i'll apply it |
| 18:34:45 | <cta> but how to be with such directory for MacOS?? it also in wrong zip file?? |
| 18:35:20 | <djazayeri> cta: I'm confused... |
| 18:35:43 | <cta> I was confused two |
| 18:36:03 | <cta> now, under liquibase-data-zip we has following folders: |
| 18:36:27 | <cta> __MACOSX |
| 18:36:37 | <cta> and liquibase-data/ |
| 18:36:50 | <cta> each of them contain |
| 18:37:14 | <cta> liquibase xml files |
| 18:38:30 | *** magoo_ has quit IRC |
| 18:38:45 | <djazayeri> so, when I do an svn update and I unzip that file I do not see an __MACOSX directory |
| 18:38:47 | <djazayeri> (but I'm on a mac) |
| 18:39:09 | <cta> but before revision 21746 (commit for TRUNK-2446) we have had one zip file with three only files therein |
| 18:39:20 | <wyclif> personally, i added the extracted files and not the zip |
| 18:39:26 | <cta> its true |
| 18:39:46 | <cta> but do you see folder liquibase-data/ after unzip& |
| 18:39:50 | <cta> ?? |
| 18:40:07 | <djazayeri> cta: yes, but that's the name of the file I'm unzipping. so I assume that's just an artifact of the mac unzip program |
| 18:40:12 | <djazayeri> wyclif: you mean in 2.x? |
| 18:40:21 | <wyclif> djazayeri, yes |
| 18:40:36 | <wyclif> because the zip file was not getting extracted |
| 18:40:44 | <wyclif> we rather have them in jar file |
| 18:40:45 | <djazayeri> bwolfe: is there any (good) reason why we should have the liquibase demo/core/schema files in a zip? |
| 18:40:51 | <cta> but before commit 21746 we have had only three liquibase files, not a folder |
| 18:40:55 | <wyclif> what matters is them being on the classpatj |
| 18:41:00 | <wyclif> classpath |
| 18:41:15 | <djazayeri> So, personally I'd rather take them out of the zip in 1.x also |
| 18:41:31 | <djazayeri> I'm not aware of any reason they're in a zip |
| 18:41:32 | <wyclif> that is what i did for trunk-2079 |
| 18:41:59 | <wyclif> i extracted them out of the zip |
| 18:42:23 | <cta> because they inside folder WEB-INF/classes/liquibase-data/ inside classpath. But InstallationFilter reads them by path WEB-INF/classes/ |
| 18:42:31 | <cta> it causes error |
| 18:42:44 | <cta> wyclif, am soory, did you fix that? |
| 18:42:58 | <djazayeri> cta: wyclif changed things in the 2.x web application |
| 18:43:00 | <wyclif> only in 2.x |
| 18:43:01 | <djazayeri> which is something else |
| 18:43:11 | <wyclif> but not in 1.x |
| 18:43:21 | <cta> I'm working on 1.9.x |
| 18:43:31 | <cta> It should be fixed |
| 18:43:35 | <cta> I guess |
| 18:43:38 | <djazayeri> cta: try extracting the xml files from the zip, and putting them in the location that the application is looking for |
| 18:43:42 | <djazayeri> yes, it should be fixed. |
| 18:43:45 | <djazayeri> can you fix it? |
| 18:44:00 | <djazayeri> The quick solution is either to re-build the zip file with the right folder structure. |
| 18:44:13 | <djazayeri> The better solution is to copy whatever wyclif did in 2.x |
| 18:44:17 | <wyclif> aren't they packaged with the api? |
| 18:44:20 | <cta> Not urgently, but tommorrow I think |
| 18:44:54 | <wyclif> i think the best solution is to fix the packaging to include them in the jar file |
| 18:45:00 | <wyclif> i.e the API |
| 18:45:26 | <djazayeri> Definitely the schema and core belong in the API. |
| 18:45:30 | <djazayeri> I guess the demo can go there too |
| 18:45:44 | <cta> directly into /api/src/main/resources/ right??? |
| 18:46:10 | <wyclif> demo data should probably only get packaged with the application |
| 18:46:23 | <wyclif> so i would suggest demo data goes to the resources location |
| 18:46:33 | <djazayeri> wyclif: that's better, yes |
| 18:47:16 | <djazayeri> cta: I'm not sure, try it out |
| 18:47:25 | <djazayeri> or else look at where wyclif put things in the ticket he mentioned above |
| 18:47:32 | <wyclif> though in 2.x i included everything in the resource folder |
| 18:47:58 | <cta> ok, wyclif, I'll see it |
| 18:48:47 | <wyclif> cta, if you fix trunk to include them in the API, then we will remove them from the resources folder at that point and only retain demo data |
| 18:50:48 | <wyclif> cta, i will catch you on skype |
| 18:51:02 | <cta> ok |
| 19:01:48 | *** dkayiwa has quit IRC |
| 19:06:22 | *** bwolfe has quit IRC |
| 19:06:55 | *** asgoyal has quit IRC |
| 19:24:20 | *** mario_vitalbox has quit IRC |
| 19:24:37 | *** jportela has quit IRC |
| 19:24:40 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Thanks. :) RT @brad_84 SUPER COOL PROJECT! http://j.mp/brRxh7 #oscon <http://twitter.com/OpenMRS/statuses/95563650433171456> |
| 20:10:15 | *** gbastien has joined #openmrs |
| 20:15:12 | *** cta has quit IRC |
| 20:16:14 | *** muthah has joined #openmrs |
| 20:18:24 | *** wyclif has quit IRC |
| 20:22:10 | *** wyclif has joined #openmrs |
| 20:24:57 | *** suhothayan has quit IRC |
| 20:42:25 | *** james_regen has quit IRC |
| 20:50:10 | *** muthah has quit IRC |
| 21:12:49 | *** finbrein has joined #openmrs |
| 21:13:45 | <wyclif> djazayeri, are you able to view the patient dashboard in 2.x? |
| 21:13:58 | <djazayeri> last time i did an update I could |
| 21:14:19 | <djazayeri> do you see an error? |
| 21:14:25 | <wyclif> yes, class org.openmrs.ui2.core.FragmentException |
| 21:14:25 | <wyclif> : Error evaluating view: widgets/verticalTabPanel |
| 21:14:58 | <djazayeri> let me try |
| 21:15:25 | <djazayeri> what's the underlying error beneath that? |
| 21:15:39 | <wyclif> NPE |
| 21:15:59 | <wyclif> at org.openmrs.ui2.core.fragment.ConventionBasedClasspathFragmentControllerProvider . getController (17) |
| 21:17:09 | *** dkayiwa has joined #openmrs |
| 21:17:10 | <djazayeri> must be that fragmentName is null |
| 21:17:33 | <djazayeri> presumably you've used that fragment in a way that I hadn't coded for |
| 21:17:52 | <djazayeri> so, I think the cause of the error is that you're trying to do includeFragment(null) |
| 21:18:04 | <djazayeri> but that I have no pretty error checking for this |
| 21:18:09 | <djazayeri> could that be the case? |
| 21:19:35 | *** yanokwa has joined #openmrs |
| 21:19:42 | *** ChanServ sets mode: +v yanokwa |
| 21:19:48 | <wyclif> apparently the fragment name is not null |
| 21:20:39 | <djazayeri> hmm, okay, I'm rebuilding trunk so I can rebuild 2.x hold on |
| 21:22:19 | <djazayeri> wyclif: if the exception is actually at that line, either fragmentName must be null, or else basePackage must be |
| 21:23:16 | <djazayeri> I just svn updated, rebuilt, and all the core tabs work for me |
| 21:24:07 | <wyclif> hmm |
| 21:24:15 | <wyclif> i think i have caching issues |
| 21:39:36 | <djazayeri> wyclif: I think I'm seeing this too. |
| 21:39:41 | <djazayeri> The fragment isn't reloading |
| 21:39:59 | <djazayeri> I mean: I edit the fragment's gsp, but that isn't picked up until I restart the app |
| 21:40:01 | *** dkayiwa has quit IRC |
| 21:40:07 | <djazayeri> is that what you meant by caching issues? |
| 21:41:32 | <wyclif> djazayeri, i found the problem, it was my fault |
| 21:41:41 | <djazayeri> but are pages reloading right for you? |
| 21:41:49 | <djazayeri> after you edit the gsp? |
| 21:41:50 | <wyclif> i guess |
| 21:41:54 | <wyclif> i will check |
| 21:42:12 | <wyclif> i recall it worked fine in the last sprint |
| 22:04:09 | <djazayeri> wyclif: it did work fine in the last sprint, but I'm looking at the code and I think I was a bit careless when implementing a speedup for production mode |
| 22:04:20 | <djazayeri> would you mind checking whether changes to a gsp are picked up or not? |
| 22:04:42 | <wyclif> djazayeri, sure |
| 22:04:48 | <wyclif> a question |
| 22:04:55 | <wyclif> djazayeri, so this the approach for the settings page, am trying to make sure am getting the concept right in the framework, |
| 22:05:57 | <wyclif> for the settings page, i have added a SettingsExtension and a SettingsFragmentExtension, just like you did for the patient dashboard |
| 22:07:05 | <djazayeri> wyclif: So, you're going down the path of the correct long term solution |
| 22:07:11 | <djazayeri> that's not actually what I intended in this case |
| 22:07:30 | <djazayeri> For this sprint I just meant to do a hacky grouping by whatever is before the first dot. |
| 22:07:35 | <wyclif> for now what do you want? |
| 22:07:59 | <djazayeri> I'm not opposed to doing something "more correct" but if you're going to do that we should discuss. |
| 22:08:25 | <djazayeri> e.g. there are a handful of GPs like concept.weight, concept.height, ... |
| 22:08:51 | <djazayeri> those would end up grouped under a concept tab, which would show properties weight, height, ... |
| 22:09:03 | <djazayeri> (I'm describing the hacky solution now) |
| 22:09:32 | <wyclif> ok |
| 22:10:47 | <djazayeri> In fact I would definitely suggest going with that hacky solution for now. |
| 22:10:56 | *** gbastien has quit IRC |
| 22:10:56 | <wyclif> djazayeri, it seems to pick up my changes pretty well |
| 22:10:59 | <djazayeri> The point is that this is the "Advanced Settings" page for manage GPs. |
| 22:11:02 | <wyclif> in the gsp |
| 22:11:04 | <djazayeri> really? hmm. |
| 22:11:08 | <djazayeri> this is on a page or a fragment? |
| 22:12:49 | <wyclif> page |
| 22:13:01 | <djazayeri> ok, yeah, I broke the auto-reloading in fragments |
| 22:13:03 | <djazayeri> pages are still fine |
| 22:15:29 | <wyclif> but the fragments are not |
| 22:15:41 | <djazayeri> thanks for checking. |
| 22:16:24 | <wyclif> no problem |
| 22:19:59 | <wyclif> am heading home, catch you later when i get home |
| 22:20:06 | *** geni100 has joined #openmrs |
| 22:20:28 | <geni100> I saw on the message board at oscon that you guys are looking for devs. |
| 22:20:46 | <geni100> What are you guys looking to do over the next 3-6 months? |
| 22:21:17 | <djazayeri> geni100: a lot. :-) |
| 22:21:47 | <geni100> cool! :) |
| 22:21:49 | <djazayeri> geni100: a high-level view would be at go.openmrs.org/roadmap |
| 22:21:54 | <djazayeri> (start from 1.9) |
| 22:22:56 | <geni100> cool. Is the SMART container a GSoC project? |
| 22:25:00 | *** wyclif has quit IRC |
| 22:26:09 | <djazayeri> geni100: it is |
| 22:26:19 | <djazayeri> it's also going to be an ongoing project after that |
| 22:27:05 | <djazayeri> do you know SMART? |
| 22:27:11 | <geni100> very cool. I'm not sure on time (mine), but I may be of use. I've been building medical systems for myself (practice management, clinical decision support, medical data classification) and for a client (ChartLogic, charting solution) for a few years now. |
| 22:27:27 | <djazayeri> cool |
| 22:27:32 | <djazayeri> are you more of a developer or a system integrator? |
| 22:27:35 | <geni100> I'm very interested in picking up everything for SMART. ChartLogic is going that way in the near future (starting around August) |
| 22:27:41 | <geni100> I'm a developer |
| 22:29:03 | <djazayeri> we're curious to see how SMART plays out |
| 22:29:16 | <geni100> isn't there an OpenMRS talk at OSCON this year? |
| 22:29:29 | <geni100> I thought I saw that someone was going to talk about it |
| 22:29:55 | <geni100> yeah, me too. I had proposed something incredibly close to SMART to ChartLogic about 2 years ago, but we didn't do anything about it. |
| 22:30:01 | <djazayeri> from my perspective I hope SMART ends up being a way to bring cool EMR functionality from the US to some developing country projects |
| 22:30:15 | <geni100> so, architecturally, fascinating, hopefully there's the momentum to make things go forward |
| 22:30:15 | <djazayeri> One of our core team is at OSCON |
| 22:30:35 | <geni100> I'll have to find him/her. Who's here? |
| 22:30:37 | <djazayeri> we'd submitted a presentation, hopefully it got accepted and he's giving it |
| 22:30:41 | <djazayeri> http://www.oscon.com/oscon2011/profile/122954 |
| 22:30:45 | <djazayeri> Michael Downey |
| 22:31:43 | <geni100> Perfect, I'll have to track him down |
| 22:33:32 | <djazayeri> definitely catch up with him |
| 22:33:58 | <djazayeri> look us up back on IRC if you have time and want to get involvee |
| 22:34:03 | <djazayeri> (involved) |
| 22:41:44 | <geni100> thanks, I'll see what I can do. I've been talking to people (doctors) about you guys |
| 23:00:44 | *** geni100 has quit IRC |
| 23:01:04 | *** geni100 has joined #openmrs |
| 23:17:19 | *** muthah has joined #openmrs |
| 23:33:40 | *** wyclif has joined #openmrs |
| 23:42:31 | *** finbrein has quit IRC |