| 00:00:19 | *** edcable1 has quit IRC |
| 00:15:37 | <wyclif> djazayeri, do i need the trunk project to run the ui2 project |
| 00:15:53 | <wyclif> because logic can't get started |
| 00:16:16 | <djazayeri> wyclif: ui2 depends on trunk, via maven |
| 00:16:23 | <djazayeri> but not a particularly recent trunk or anything |
| 00:16:26 | <djazayeri> what doesn't start? |
| 00:16:39 | <djazayeri> Every time I start it up there is a logic-related stack trace, but that doesn't actually break things. |
| 00:19:14 | <wyclif> logic |
| 00:19:29 | <djazayeri> what about logic doesn't start? |
| 00:20:06 | <wyclif> i get the error that a core module logic cant start |
| 00:20:35 | <djazayeri> ah, you have to manually put logic-0.5.omod in your modules folder |
| 00:20:42 | <djazayeri> because ui2 doesn't have it bundled. |
| 00:21:46 | <djazayeri> wyclif: actually, can you create a ticket for this, since you've got access to the stack trace? |
| 00:22:05 | <djazayeri> e.g. "2.x web application needs a bundledModules folder including logic-0.5.omod" |
| 00:45:13 | *** edcable has joined #openmrs |
| 01:25:27 | *** deadpool has quit IRC |
| 01:26:17 | *** edcable has quit IRC |
| 02:22:55 | *** edcable has joined #openmrs |
| 02:43:23 | *** gbastien has joined #openmrs |
| 02:44:40 | *** upul` has joined #openmrs |
| 02:44:40 | *** ChanServ sets mode: +v upul` |
| 02:51:59 | *** edcable has quit IRC |
| 03:15:36 | *** gbastien has quit IRC |
| 03:28:14 | *** jportela has quit IRC |
| 03:32:06 | *** muthah has quit IRC |
| 03:32:33 | *** surangak has joined #openmrs |
| 03:39:32 | *** jwishnie has quit IRC |
| 03:40:31 | *** mccallumg has joined #openmrs |
| 03:40:31 | *** ChanServ sets mode: +v mccallumg |
| 03:44:16 | <surangak> mccallumg, helooo |
| 03:48:03 | <mccallumg> hey surangak. How's it going? |
| 03:48:33 | <surangak> mccallumg, well, it looks like we're heading in the general direction of progress |
| 03:48:44 | <surangak> mccallumg, i see you saw my latest mails... |
| 03:49:10 | <mccallumg> surangak: good. yes. this is a whole other design discussion I'm afraid. validation logic representation. |
| 03:49:50 | <surangak> mccallumg, mm... afraid im totally new to the logic module, never worked on that before :) |
| 03:50:16 | <mccallumg> surangak: don't get too into it. I'm not sold on the idea. I just threw it out there. |
| 03:50:24 | <surangak> mccallumg, u mean logic module has an EL custom to openmrs ? wow |
| 03:51:21 | <mccallumg> surangak: It supports a language from representing validation logic - not custom I don't think. |
| 03:51:33 | <surangak> mccallumg, aaah.. |
| 03:51:47 | <surangak> mccallumg, oh, those changes to page re load, im putting them in today... |
| 03:52:08 | <surangak> mccallumg, so there will be a review waiting for you tomorrow morning :) |
| 03:52:15 | <mccallumg> surangak: good. what next? another handler? location? |
| 03:52:36 | <surangak> mccallumg, mm.. actually i already created LocationHandler |
| 03:53:05 | <mccallumg> surangak: why doesn't this surprise me. |
| 03:53:05 | <surangak> mccallumg, once you create one handler class, its not a bigge to rite up others that follow same pattern |
| 03:53:21 | <surangak> mccallumg, sorry, didnt get you ? |
| 03:53:35 | <mccallumg> surangak: it's a good thing. I meant it as a compliment. |
| 03:53:51 | <surangak> mccallumg, aaaaah :D you got me worried back there ... |
| 03:54:34 | <mccallumg> surangak: let's get through the code review ... and the weekend. Then maybe we can set up a call with Burke and discuss next steps. |
| 03:54:47 | <mccallumg> surangak: is there any updating needed for the documentation? |
| 03:54:59 | <surangak> mccallumg, sure, i'll set up the review... |
| 03:55:10 | <mccallumg> surangak: good work. |
| 03:55:21 | <surangak> mccallumg, i was thinking maybe i should add Darius also, because im following his advice in my solution... |
| 03:55:26 | <surangak> mccallumg, thanks :) |
| 03:55:54 | <surangak> mccallumg, documentation will need a lot of updates, but i was thinking maybe we should wait until the review is done... |
| 03:56:03 | <mccallumg> surangak: yes, if Darius has time. only if he can spare time. I agree he is way better to review the design. |
| 03:56:39 | <surangak> mccallumg, but i need to update documentation with the key, text that Burke suggested... |
| 03:56:47 | <surangak> mccallumg, i should do that over the weekend... |
| 03:56:47 | <mccallumg> surangak: right |
| 03:57:04 | <surangak> mccallumg, ah, yep, ill ask darius to take a look if possible... |
| 03:57:30 | <surangak> mccallumg, im guessing that Obs and concepts are like the heart and soul of OpenMRS |
| 03:58:02 | <surangak> mccallumg, and that changing these are terribly serious buisness ? |
| 03:58:31 | <mccallumg> surangak: it would impact a lot of the application. |
| 03:58:37 | <mccallumg> surangak: why do you ask? |
| 03:59:01 | <surangak> mccallumg, the cnages i put in, they do some reload stuff on the obsform and controller |
| 03:59:18 | <surangak> mccallumg, so im worried if my design will 'pass' review :P |
| 03:59:32 | <mccallumg> surangak: we may have to consult Ben on this one. |
| 04:00:26 | <surangak> mccallumg, i had anticipated the issue that required us to reload the page, Ben and darius kinda suggested that the reload was the only way... |
| 04:00:43 | <surangak> mccallumg, so hopefully they should be ok with what I hav done :) |
| 04:00:46 | <mccallumg> surangak: oh ok. if they know about it already ... |
| 04:01:07 | <surangak> mccallumg, only what im doing, now 'how' i did it :-) |
| 04:04:25 | <surangak> mccallumg, i see u are changing your google profile also ... |
| 04:04:36 | <surangak> mccallumg, out with the old and in with the new ? |
| 04:08:10 | <mccallumg> surangak: did I? send me a link, plz. |
| 04:08:21 | <surangak> mccallumg, i mean your proto... |
| 04:08:32 | <mccallumg> surangak: I just clicked on the google+ link |
| 04:08:38 | <mccallumg> surangak: it asked me for a new pic |
| 04:08:42 | <surangak> u have switched your tradional pic right ? |
| 04:08:55 | <surangak> mccallumg, ah yep, thats it |
| 04:09:00 | <mccallumg> surangak: I guess so. you like it? |
| 04:09:55 | <surangak> mccallumg, lets put it like this , your earlier pic was pretty formal, and made u look like a bureaucrat |
| 04:10:11 | <surangak> mccallumg, the new one puts you in a more positive light :) |
| 04:10:41 | <mccallumg> surangak: yeah. The other one was official for the company. |
| 04:10:49 | <surangak> mccallumg, ah, i get it |
| 04:11:08 | <surangak> mccallumg, this once gives a much warmer impression of you :-) |
| 04:11:27 | <mccallumg> surangak: I did some cleanup on my blog too. Did you look at it this week? |
| 04:12:17 | <surangak> mccallumg, i see that you are moving towards a casual / informal look |
| 04:12:45 | <surangak> mccallumg, for some reason it makes me think of an independent consultant |
| 04:13:07 | <mccallumg> surangak: it's not really intentional. It's just more natural. |
| 04:14:43 | <surangak> mccallumg, i think u might need to add some pics to it though.. the arrows keep displaying the same image .. |
| 04:15:21 | <mccallumg> mccallumg: yes. It will happen. I haven't put any work into that slider yet. I suppose it is next. |
| 04:16:21 | <surangak> mccallumg, sorry, i also ment to ask, do you know any asians or foreigners who did their MSc at victoria ? |
| 04:16:34 | <mccallumg> surangak: of course. |
| 04:17:27 | <surangak> mccallumg, i was wondering if i could contact someone and see what kind of pre - preperation i can do ( I belive in long drawn planning ) |
| 04:17:57 | <mccallumg> surangak: sure. give me a day or two. If you don't hear anything, remind me again next week. |
| 04:18:09 | <mccallumg> surangak: I need to get in touch with some old friends. |
| 04:18:20 | <surangak> mccallumg, sure, no problem, I got plenty of time :) |
| 04:30:08 | <surangak> mccallumg, anything else that u want me to focus on over the week end ? |
| 04:30:27 | <mccallumg> surangak: no we've covered everything on my mind. |
| 04:30:50 | <surangak> mccallumg, aah, so we'll have to see how the review goes... |
| 04:31:48 | <mccallumg> surangak: I'm heading to bed now. talk again soon. |
| 04:32:02 | <surangak> mccallumg, sure, will do |
| 04:32:07 | <surangak> mccallumg, good night :-) |
| 04:32:34 | <mccallumg> surangak: bye. |
| 04:34:19 | *** mccallumg has quit IRC |
| 04:50:48 | *** Yekkanti has joined #openmrs |
| 05:19:08 | *** Yekkanti has quit IRC |
| 06:02:32 | *** bwolfe has joined #openmrs |
| 06:02:32 | *** ChanServ sets mode: +o bwolfe |
| 06:04:27 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): LocationFieldGenObsHandler added for better testing purposes <http://feedproxy.google.com/~r/OMRStrunk/~3/3m4IhOmtchk/OpenMRS> |
| 06:11:27 | *** dkayiwa has joined #openmrs |
| 06:20:20 | *** bwolfe sets mode: +v dkayiwa |
| 06:20:22 | <bwolfe> mornin' dkayiwa |
| 06:21:18 | <dkayiwa> morning bwolfw |
| 06:21:23 | <dkayiwa> bwolfe |
| 06:21:25 | <dkayiwa> :) |
| 06:22:03 | <bwolfe> !refer dkayiwa [tabcomplete] |
| 06:22:04 | * OpenMRSBot refers dkayiwa to "tabcomplete" --- Most IRC clients let you easily write someone's nickname in the channel using tab completion. Just type the first few letters, then <tab>, and voila! |
| 06:22:41 | <dkayiwa> :D |
| 06:23:05 | <dkayiwa> bwolfe: wowwwww :D |
| 06:24:17 | <surangak> and another one sees the light :-D |
| 06:24:27 | <dkayiwa> lollllllllllllllllllllll |
| 06:24:29 | <bwolfe> :-) |
| 06:24:39 | <dkayiwa> so no one remains in the dark :D |
| 06:24:50 | <surangak> Ben gave the the same advice a while back :P |
| 06:25:00 | <dkayiwa> hahahahaha |
| 06:27:00 | *** rafa has joined #openmrs |
| 06:27:00 | *** ChanServ sets mode: +v rafa |
| 06:27:25 | <dkayiwa> !refer bwolfe [tabcomplete] :) |
| 06:27:26 | * OpenMRSBot refers bwolfe to "tabcomplete" --- Most IRC clients let you easily write someone's nickname in the channel using tab completion. Just type the first few letters, then <tab>, and voila! :) |
| 06:37:17 | *** muthah has joined #openmrs |
| 06:37:57 | <dkayiwa> IRC is normally quiet in the mornings. But get to the afternoons!!! :) |
| 06:38:20 | <surangak> only few of us at office during mornings... |
| 06:38:44 | <dkayiwa> oh i see |
| 06:38:50 | <surangak> so poor daniel has to answer all the questions until some other ppl log in :) |
| 06:39:11 | <dkayiwa> lolllllllllll. yesterday was my worst. ::) |
| 06:39:26 | <dkayiwa> i did completely nothing other than IRC :D |
| 06:39:38 | <surangak> i noticed lot of action yesterday... |
| 06:39:46 | <surangak> this is early morning for u ? |
| 06:40:07 | <dkayiwa> and i was not able to give all the answers after having tried this and that :) |
| 06:40:17 | <dkayiwa> surangak: yes morning here |
| 06:40:40 | <surangak> dkayiwa, during the first few months i was working here, i was too scared to use IRC to ask questions |
| 06:40:49 | <dkayiwa> lolllllllllll |
| 06:40:50 | <surangak> dkayiwa, didnt want to appear stupid |
| 06:40:57 | <dkayiwa> surangak: hahahahahaha |
| 06:41:07 | <surangak> dkayiwa, i guess that my desision saved you a loooot of IRC time :D |
| 06:41:15 | <dkayiwa> hahahahahahaha |
| 06:41:47 | <dkayiwa> surangak: there are those who ask even without having first tried out their best |
| 06:41:53 | <dkayiwa> thats where the problem is |
| 06:42:17 | <dkayiwa> surangak: but generally asking can save you lots of time |
| 06:42:22 | <dkayiwa> :) |
| 06:42:44 | <bwolfe> dkayiwa, the trick with helping in irc is to not answering immediately |
| 06:42:53 | <surangak> dkayiwa, during the time period i was too scared to ask, i was stuck with that 'liquibase changelog lock problem for four days |
| 06:43:00 | <dkayiwa> bwolfe: oh i seeeeeeeeee |
| 06:43:06 | <bwolfe> finish what you're doing, then answer a few minutes later (especially if its someone that has already asked a lot of questions) |
| 06:43:11 | <surangak> didnt want to ask, because it looked stupid :P |
| 06:43:44 | <surangak> bwolfe, you just gave yourself away ! I heard that :-) |
| 06:43:51 | <bwolfe> surangak, you should make sure you document it well in all the places you looked so the next person doesn't have the same issue! |
| 06:43:55 | <dkayiwa> surangak: 4 days was really long to wait. :) |
| 06:44:10 | <bwolfe> surangak, my technique is well known. I've considered patenting it |
| 06:44:23 | <surangak> i finally got solution in a mailing list :) |
| 06:44:28 | <dkayiwa> bwolfe: that is a major major time savor trick you have given me d:) |
| 06:44:39 | <bwolfe> I delay responses longer and longer the more someone asks me questions. this goes for email, skype, im, irc, etc. (I haven't figured out how to do it in real life yet...) |
| 06:45:10 | <dkayiwa> bwolfe: without that trick, some days irc can be a full time job :D |
| 06:45:48 | <bwolfe> the delay does 3 things: it gives someone else a chance to also answer. it gives the one asking time to google it. and it also eventually means that the one asking realizes that googling for the answer is FASTER than just asking me every time (or at least thats the hope) |
| 06:46:05 | <dkayiwa> ooh i seeeeeeeeeee |
| 06:46:10 | <surangak> dont worry... I forsee that IRC will be relatively slow between September - March period :-) |
| 06:46:14 | <dkayiwa> makes so so so much sense bwolfe |
| 06:46:19 | <bwolfe> dkayiwa, yeah, don't let that happen. if you've spent the first half of your day on irc, ignore it for the afternoon. no shame in saying "I'm busy" |
| 06:46:38 | <dkayiwa> oh i see 8) |
| 06:46:57 | <dkayiwa> i can even sign off ;) |
| 06:47:00 | <bwolfe> so surangak, yes, if my responses comes 20 minutes later to you it means you've asked too many questions. ;-) (or it means I was off getting a sandwich) |
| 06:47:15 | <dkayiwa> :D |
| 06:47:18 | <surangak> :D |
| 06:47:22 | <bwolfe> dkayiwa, yep, you can sign off irc, but stay on other techs so we can reach you at least! |
| 06:47:34 | <dkayiwa> makes perfect sense. :) |
| 06:47:51 | <surangak> I must agree that your idea makes sense |
| 06:48:02 | <dkayiwa> so so much!!!! |
| 06:49:02 | <bwolfe> see, I should totally patent it |
| 06:49:12 | <bwolfe> and you two owe me royalties every time you use it ;-) |
| 06:49:18 | <dkayiwa> hahahahahahahahahaha |
| 06:49:32 | <dkayiwa> you are gonna get rich quick :) |
| 06:49:35 | <surangak> too bad no one asks me any questions on IRC yet :D |
| 06:50:09 | <dkayiwa> surangak: just try answering some and you will see them turn to you when bwolfe has delayed :D |
| 06:50:19 | <dkayiwa> thats what happened to me :) |
| 06:51:05 | <bwolfe> haha |
| 06:51:25 | <dkayiwa> or when bwolfe is offline :) |
| 06:51:30 | <surangak> maybe they are attracted to your outgoing and charming personality... |
| 06:51:52 | <dkayiwa> surangak: you only express it by answering one or two of them :) |
| 06:52:14 | <surangak> i think its because your online before most of the others, and you always respond when someone says 'hi' |
| 06:52:49 | *** muthah has quit IRC |
| 06:52:51 | <dkayiwa> thats only before i learnt Ben's trick :) |
| 06:55:36 | *** pascal` has joined #openmrs |
| 06:58:20 | *** ChanServ sets mode: +v pascal` |
| 07:08:39 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Improving on display for custom data objects - Page refresh changes now supported <http://feedproxy.google.com/~r/OMRStrunk/~3/3nUWmiEWhCo/OpenMRS> |
| 07:47:32 | *** yanokwa has joined #openmrs |
| 07:47:33 | *** ChanServ sets mode: +v yanokwa |
| 07:56:41 | *** bryq has joined #openmrs |
| 07:56:41 | *** ChanServ sets mode: +v bryq |
| 08:15:06 | <surangak> howdy, i created a review, and need to attach some screenshots (Darius suggested it) |
| 08:15:26 | <surangak> should I create a ticket for what I did, and attach a patch and screenshots to it ? |
| 08:15:39 | <bwolfe> you created a review before a ticket? |
| 08:17:38 | <surangak> am in the process of creating a review... :) |
| 08:22:31 | <surangak> bwolfe, hmmm... im unable to find my branch on the list to create a new issue.. :( |
| 08:23:58 | <bwolfe> surangak, if you're working on a branch then the ticket goes against the TRUNK jira project |
| 08:24:19 | <surangak> bwolfe, aaahh, got it.. thanks Ben |
| 08:48:45 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Backporting from 1.9.x TRUNK-2433: AdministrationService.saveGlobalProperties is dangerous, and should be changed ... <http://feedproxy.google.com/~r/OMRStrunk/~3/7_KuZaelLbU/OpenMRS> |
| 08:51:40 | *** upul` has quit IRC |
| 08:56:45 | *** upul` has joined #openmrs |
| 08:56:45 | *** ChanServ sets mode: +v upul` |
| 09:04:06 | *** yanokwa_ has joined #openmrs |
| 09:04:06 | *** yanokwa has quit IRC |
| 09:04:11 | *** magoo has joined #openmrs |
| 09:11:18 | *** pascal` has quit IRC |
| 09:25:22 | *** pascal` has joined #openmrs |
| 09:30:43 | *** bwolfe_ has joined #openmrs |
| 09:30:43 | *** ChanServ sets mode: +o bwolfe_ |
| 09:30:43 | *** surangak has quit IRC |
| 09:31:16 | <pascal`> hey bwolfe |
| 09:31:54 | <bwolfe_> hi pascal` |
| 09:32:03 | *** bwolfe has quit IRC |
| 09:32:05 | *** bwolfe_ is now known as bwolfe |
| 09:32:46 | *** surangak has joined #openmrs |
| 09:37:43 | <pascal`> bwolfe, I'm seeing the weirdest thing, none of my class files are being put in the omod, but they are in the build folder. Ever seen anything like that? |
| 09:38:08 | <pascal`> bwolfe, I'm creating a new module. I copied a project and pasted as a new project in eclipse to clone. |
| 09:38:08 | <bwolfe> meaning its not getting packaged correctly? |
| 09:38:27 | <bwolfe> did you copy over the same pom, project, and .classpath files? |
| 09:38:34 | <pascal`> bwolfe, well, I guess, yeah. The omod is there an everything, it just doesn't included any of the class files. |
| 09:38:52 | <pascal`> bwolfe, I guess I'll check the .classpath file, but everything seems correct in the build folder. |
| 09:39:16 | <bwolfe> no class files from the api project or from the omod project? |
| 09:40:08 | <pascal`> bwolfe, I think I figured it out. |
| 09:40:27 | <pascal`> bwolfe, bad classpath file... had "bin" instead of "build" specified as the output directory. Opps. |
| 09:40:30 | <pascal`> Oops even. |
| 09:40:44 | <bwolfe> oops you typed opps |
| 09:40:50 | <bwolfe> yeah, sounds about right |
| 09:41:18 | <bwolfe> maven in eclipse doesn't like our omod projects when you check them out. so you have to manually copy in the .classpath file :-/ |
| 09:41:19 | <bwolfe> very annoying |
| 09:41:44 | <pascal`> bwolfe, nope, same issue, and I'm not even using maven. |
| 09:43:28 | <bwolfe> clean build? |
| 09:43:46 | <bwolfe> are they omod class files or api class files that are missing? |
| 09:43:59 | <bwolfe> api ones are put into a jar and the jar is put into the lib folder in the .omod |
| 09:44:23 | <pascal`> bwolfe, well, they should be in the omod. |
| 09:45:04 | <pascal`> bwolfe, I don't have a jar, or know how to specify which classes are which. |
| 09:45:21 | <bwolfe> classes in the api project are in the api :-p |
| 09:45:26 | <magoo> dkayiwa is xform module supported by version 1.8 |
| 09:45:36 | <bwolfe> classes in the omod project are web based and go in the omod separately (I think...or it might use a jar too) |
| 09:46:07 | <magoo> i wanted to try it out |
| 09:47:30 | <pascal`> bwolfe, I'm using ant. |
| 09:47:44 | <bwolfe> oh, pre maven. |
| 09:47:50 | <dkayiwa> magoo yes |
| 09:48:11 | <bwolfe> did you change the build.xml file at all? |
| 09:48:20 | <bwolfe> do you have any compile errors? |
| 09:48:53 | <magoo> yesterday i failed to install the maven plugin into eclipse |
| 09:49:28 | <pascal`> bwolfe, no compile errors and I just changed the project name right at the top |
| 09:51:08 | <pascal`> bwolfe, --> <exclude name="**/*Test*" /> |
| 09:51:34 | <pascal`> bwolfe, so having the sentence fragment "Test" in your class name is illegal in OpenMRS? |
| 09:51:36 | <bwolfe> heh, do all of your classes have "Test" in them? |
| 09:51:36 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.7.x): Backporting from 1.9.x TRUNK-2433: AdministrationService.saveGlobalProperties is dangerous, and should be changed ... <http://feedproxy.google.com/~r/OMRStrunk/~3/yqTO3aVCpXs/OpenMRS> |
| 09:51:40 | <pascal`> bwolfe, yes. |
| 09:52:12 | <bwolfe> it is not illegal, its just the way that we're keeping unit test classes out of hte compiled omods |
| 09:52:16 | <bwolfe> feel free to take that line out |
| 09:53:16 | <pascal`> bwolfe, yup, I've taken it out. |
| 09:54:16 | <bwolfe> and all is when with the world now pascal`? |
| 09:58:08 | <pascal`> bwolfe, I think so. |
| 10:00:05 | <magoo> the xform module is installed but am getting an error |
| 10:06:34 | <magoo> dkayiwa the module is installed but am getting an error |
| 10:06:50 | <dkayiwa> which error magoo |
| 10:07:56 | <magoo> org.openmrs.module.ModuleException A servlet mapping with name xformDataUpload already exists. xforms's servlet is trying to overwrite it |
| 10:08:21 | <dkayiwa> which version of openmrs |
| 10:08:30 | <magoo> but i when i checked there 1.8 |
| 10:08:36 | <dkayiwa> magoo: |
| 10:08:51 | <magoo> it is version 1.8 |
| 10:09:02 | <bwolfe> dkayiwa, I thought you fixed that error... |
| 10:09:12 | <dkayiwa> yes bwolfe |
| 10:09:18 | <dkayiwa> am wondering |
| 10:09:27 | <dkayiwa> was it on 1.9 bwolfe |
| 10:09:44 | <dkayiwa> magoo just restart tomcat |
| 10:09:50 | <magoo> according to me is it because of the other version of xform 4.0.4 |
| 10:09:53 | <magoo> okay |
| 10:10:21 | <dkayiwa> bwolfe: i suspect we did not backport it because am very sure i fixed it |
| 10:11:25 | <bwolfe> ah, it was a 1.9 thing? |
| 10:11:34 | <magoo> i have restarted tomcat |
| 10:11:58 | <dkayiwa> bwolfe: yes |
| 10:12:11 | <magoo> or i was supposed to upgrade on the existing module not install afresh |
| 10:12:45 | <dkayiwa> magoo its a bug which we fixed in another version |
| 10:12:50 | <bwolfe> perhaps we should backport that dkayiwa... |
| 10:12:58 | <dkayiwa> ok |
| 10:13:02 | <bwolfe> (a later version magoo) |
| 10:13:09 | <magoo> okay |
| 10:16:18 | <magoo> should i re-install the module |
| 10:16:24 | <dkayiwa> no |
| 10:16:36 | <dkayiwa> a restart is enough |
| 10:16:46 | <magoo> okay |
| 10:25:00 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.6.x): Backporting from 1.9.x TRUNK-2433: AdministrationService.saveGlobalProperties is dangerous, and should be changed ... <http://feedproxy.google.com/~r/OMRStrunk/~3/sJsws5-_igw/OpenMRS> |
| 10:33:48 | *** cta has joined #openmrs |
| 10:33:57 | <cta> hello |
| 10:35:14 | <cta> bwolfe: Ben, what do you think about last Wyclif's comment on ticket 2458? |
| 10:37:21 | <bwolfe> !ticket TRUNK-2458 |
| 10:37:22 | <OpenMRSBot> bwolfe: [#TRUNK-2458] Stop multiple users from running the installation wizard - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2458 |
| 10:44:04 | <bwolfe> cta, sorry, I missed that question from wyclif somehow. |
| 10:44:08 | <bwolfe> I commented on it for you |
| 10:44:18 | <bwolfe> I need to run. I'll bbl |
| 10:46:24 | <cta> ok |
| 10:48:57 | *** bwolfe has quit IRC |
| 10:56:43 | *** upul` has quit IRC |
| 11:02:56 | *** nwilkie has joined #openmrs |
| 11:04:07 | <nwilkie> Hi there, is anybody around to help a new guy out with a taglib issue? |
| 11:04:17 | <magoo> yesterday i updated eclipse does it mean maven plugin is installed |
| 11:05:04 | <dkayiwa> magoo: how did u update clipse? |
| 11:06:02 | *** surangak has quit IRC |
| 11:06:10 | *** bwolfe has joined #openmrs |
| 11:06:10 | *** ChanServ sets mode: +o bwolfe |
| 11:06:30 | <nwilkie> OK well my question: I'm building a module, and I'd like for eclipse to recognize the openmrs taglibs for code validation and code completion. Is there a way to do this? |
| 11:06:49 | <magoo> clicked on help menu -> check for updates |
| 11:07:00 | <nwilkie> Right now Eclipse doesn't recognize any of the tags |
| 11:08:28 | <cta> bwolfe: Ben, I just added the patch that considers with Wyclif's comments for ticket TRUNK-2458 |
| 11:08:45 | <magoo> dkayiwa clicked on help menu-> check for updates |
| 11:09:34 | <dkayiwa> magoo: and then you installed the m2e plugin? |
| 11:10:17 | <magoo> i installed subeclipse |
| 11:11:34 | <dkayiwa> so u did not install m2e plugin magoo |
| 11:12:37 | <magoo> should i follow the same procdure to install the m2e plugins |
| 11:12:51 | <dkayiwa> yes |
| 11:13:44 | <magoo> this time rather than update i should click help-> install new software |
| 11:13:54 | <dkayiwa> yes |
| 11:14:15 | <magoo> okay then maven will be installed |
| 11:14:38 | <dkayiwa> that eclipse plugin |
| 11:16:41 | <magoo> should i select this option The Eclipse Project Updates - http://download.eclipse.org/eclipse/updates/3.7 |
| 11:19:23 | *** james_regen has joined #openmrs |
| 11:19:23 | *** ChanServ sets mode: +v james_regen |
| 11:20:38 | <magoo> dkayiwa i've seen the m2e plugin |
| 11:20:40 | *** bwolfe has quit IRC |
| 11:21:52 | *** nwilkie has quit IRC |
| 11:21:59 | *** rafa has quit IRC |
| 11:24:32 | *** bwolfe has joined #openmrs |
| 11:24:41 | *** ChanServ sets mode: +o bwolfe |
| 11:26:16 | <magoo> maven is installed |
| 11:27:10 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): CR-TRUNK-418#CFR-11334 Fixed the review comments. <http://feedproxy.google.com/~r/OMRStrunk/~3/jyLQu66HGac/OpenMRS> || New Changeset: OpenMRS (webapp-testing): Added css and styling files for improvements to reports - APPTEST-48... <http://feedproxy.google.com/~r/OMRStrunk/~3/ZInbg2yKues/OpenMRS> |
| 11:29:30 | *** jportela has joined #openmrs |
| 11:29:40 | *** ChanServ sets mode: +v jportela |
| 11:43:47 | *** bwolfe has quit IRC |
| 11:45:48 | *** bwolfe has joined #openmrs |
| 11:45:48 | *** ChanServ sets mode: +o bwolfe |
| 12:10:44 | <dkayiwa> bwolfe: do u know what could be causing this error. am on the openmrs2 ui framework. javax.servlet.jsp.JspTagException: Theme 'green': No message found under code 'stylesheet' for locale 'en_GB' |
| 12:16:44 | *** magoo has quit IRC |
| 12:27:15 | *** bryq has quit IRC |
| 12:27:16 | *** magoo has joined #openmrs |
| 12:28:17 | *** bumi has joined #openmrs |
| 12:33:13 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : fixed after-review comments. Changed way how wizards handle multiple user which running at the same time. C... <http://feedproxy.google.com/~r/OMRStrunk/~3/bDOMsM7S0JI/OpenMRS> |
| 12:35:10 | *** rafa has joined #openmrs |
| 12:35:10 | *** ChanServ sets mode: +v rafa |
| 12:36:18 | <bumi> help please on form design; how do i create a concept that has'yes' or 'no' as answer options, as well there are other options under 'no'... |
| 12:37:57 | *** bryq has joined #openmrs |
| 12:37:57 | *** ChanServ sets mode: +v bryq |
| 12:39:05 | *** bryq has quit IRC |
| 12:39:33 | <bumi> Hi,bwolfe i need some help;how do i create a concept that has'yes' or 'no' as answer options, as well there are other options under 'no'... |
| 12:40:25 | <dkayiwa> bumi: have u read https://wiki.openmrs.org/display/docs/Concept+Dictionary |
| 12:40:26 | <OpenMRSBot> <http://ln-s.net/8stL> (at wiki.openmrs.org) |
| 12:41:01 | *** james_regen has quit IRC |
| 12:45:08 | *** james_regen has joined #openmrs |
| 12:45:08 | *** ChanServ sets mode: +v james_regen |
| 12:46:36 | <bumi> yes i have read may be i have not understood properly, rephrasing my question, can i make no as coded concept cause there is a sense of finality with' no' |
| 12:47:57 | <bwolfe> bumi, boolean concepts in openmrs are actually coded concepts under the hood |
| 12:48:38 | <bwolfe> so you should just make your question a coded datatype and give it answers of "yes", "no", and "unknown" |
| 12:50:34 | <bumi> yes but you see the design is looking for a user to choose a reason for 'no' they are provided, so do i make those option as answers to 'no' concept?? |
| 12:53:17 | <bwolfe> ah, I see |
| 12:53:26 | <bwolfe> its usually written up as a separate concept |
| 12:53:42 | <bwolfe> if the question is "Does the patient like the color blue" |
| 12:54:00 | <bumi> here is the extract:ARV ADHERENCE: good or poor? if poor give reasons(toxicity, too ill...). |
| 12:54:03 | <bwolfe> then there would be another "Reason the patient doens't like blue" if "no" is selected |
| 12:54:44 | <bumi> sorry shud have said 'poor' though |
| 12:54:47 | <bwolfe> bumi, I'm not a concept expert, I'd suggest using a separate concept htough. you shoudl write to the implementers mailing list. there are plenty of people on there with opinions! :-) |
| 12:56:21 | <bumi> thanks @bwolfe for your help. |
| 13:01:55 | *** bumi has quit IRC |
| 13:09:00 | *** asgoyal has joined #openmrs |
| 13:12:17 | <magoo> SCM URL field is required |
| 13:12:49 | <bwolfe> use http://svn.openmrs.org |
| 13:29:59 | <magoo> Select SCM type and URL |
| 13:50:39 | <cta> bwolfe, wyclif: Ben, Wyclif, I just updated review for !ticket TRUNK-2458. |
| 13:50:59 | <cta> See https://source.openmrs.org/cru/CR-TRUNK-422 |
| 14:02:33 | <bwolfe> anyone feeling scrummish? |
| 14:02:54 | <djazayeri> scrum on! |
| 14:03:03 | <rafa> yeah! |
| 14:03:04 | <djazayeri> hi bwolfe, wyclif, rafa, dkayiwa |
| 14:03:22 | <djazayeri> is everyone set up on google+ |
| 14:03:26 | <djazayeri> we're going to try a hangout today |
| 14:03:46 | <bwolfe> ooo, hangout |
| 14:03:59 | <bwolfe> are you starting it up? |
| 14:04:03 | <djazayeri> (that means you'll have to describe your tickets in words, though, because the bot isn't listening for "!ticket" |
| 14:05:01 | <djazayeri> I have started the hangout |
| 14:06:46 | <djazayeri> rafa: The meter on my mic seems to be working |
| 14:06:56 | <rafa> djazayeri: I can't here you |
| 14:07:00 | <djazayeri> I can hear you |
| 14:07:19 | <rafa> djazayeri: I can't here Ben either :/ |
| 14:07:30 | <djazayeri> rafa: your fault. :-) |
| 14:07:43 | <rafa> djazayeri: yeah, right |
| 14:07:49 | <djazayeri> wyclif: you there? |
| 14:07:50 | <rafa> djazayeri: you didn't help |
| 14:08:34 | <djazayeri> rafa: try exiting and joining again |
| 14:08:35 | *** gbastien has joined #openmrs |
| 14:08:36 | <djazayeri> or try settings |
| 14:13:00 | <djazayeri> does my leaving kick you two out? |
| 14:13:03 | <bwolfe> ok, dkayiwa, are you ready? |
| 14:13:07 | <djazayeri> or does the hangout remain without me? |
| 14:13:09 | <bwolfe> djazayeri, I dunno, I closed it |
| 14:13:17 | <dkayiwa> bwolfe connecting.... |
| 14:13:56 | <djazayeri> remember to give updates for the last 2 days |
| 14:14:00 | <bwolfe> dkayiwa, we left the hangout |
| 14:14:02 | <djazayeri> since we had no sprint yesterday |
| 14:14:05 | <dkayiwa> oh |
| 14:14:08 | <djazayeri> back to IRC. |
| 14:15:05 | <djazayeri> dkayiwa or rafa: which of you is ready to go first? |
| 14:15:13 | <rafa> djazayeri: I'm ready |
| 14:15:17 | <rafa> Yesterday: |
| 14:15:17 | <rafa> * Worked on TRUNK-2453 (2.x Manage Modules page), TRUNK-2454 (2.x file upload widget) |
| 14:15:17 | <rafa> Today: |
| 14:15:17 | <rafa> * Backported TRUNK-2433 (AdministrationService.saveGlobalProperties is dangerous, and should be changed) |
| 14:15:17 | <rafa> * Corrected per review TRUNK-2453 (2.x Manage Modules page), TRUNK-2454 (2.x file upload widget) |
| 14:15:17 | <rafa> * Did TRUNK-2482 (In 2.x, uploading a module completely crashes OpenMRS) |
| 14:15:18 | <rafa> * Started with TRUNK-2082 (Make sure fragment actions don't bypass privilege checks) |
| 14:15:18 | <rafa> On Monday: |
| 14:15:19 | <rafa> * Continue with TRUNK-2082 |
| 14:15:19 | <rafa> * Maybe pick up a new ticket |
| 14:15:20 | <rafa> No blockers. |
| 14:15:42 | <rafa> bwolfe: how do you like it Ben now? :D |
| 14:15:49 | <djazayeri> so pretty |
| 14:16:31 | <djazayeri> (What was the issue with TRUNK-2482? Was there bad interaction between your commit and one of wyclif or daniel's? Or did yours just not work, but I didn't test it well enough?) |
| 14:16:55 | <bwolfe> very nice rafa. I award you one gold star |
| 14:17:34 | <rafa> djazayeri: it was my fault, partially ;) |
| 14:17:42 | <djazayeri> Also, TRUNK-2082 should be pretty quick, right? |
| 14:18:07 | <rafa> djazayeri: I just copied & pasted the logic from the old controller and it turned out that it needed to be fixed a little bit |
| 14:18:25 | <rafa> djazayeri: I'm not sure about that |
| 14:18:31 | <rafa> djazayeri: I just started with it |
| 14:18:34 | <djazayeri> ok |
| 14:18:52 | <rafa> djazayeri: You could give me some hints later on IRC |
| 14:19:21 | <rafa> djazayeri: Because I reached a strange code ;) |
| 14:19:29 | <djazayeri> ok |
| 14:19:32 | <rafa> djazayeri: Looks like a temporary hack of yours |
| 14:19:58 | <rafa> Ok, it's all from me. |
| 14:19:59 | <djazayeri> ok, let's discuss after updates |
| 14:20:09 | <djazayeri> dkayiwa? |
| 14:20:14 | <djazayeri> (bwolfe, get on skype call) |
| 14:20:47 | <djazayeri> (still waiting for burke though) |
| 14:21:32 | <dkayiwa> Mails, fixed xforms bug and uploaded new version, too much time on irc (Ben told me the trick today of avoiding that from happening again. :) ) , addressed review comments on https://tickets.openmrs.org/browse/TRUNK-2462, Now while working on TRUNK-2456, am blocked on an error message Theme 'green': No message found under code 'stylesheet' for locale 'en_GB' |
| 14:21:42 | <wyclif> djazayeri, , bwolfe , dkayiwa, rafa , i will be late for scrum chat, my car had an issue with the tyre, i should be there be online shortly after 10:30 |
| 14:21:49 | <wyclif> sorry about that |
| 14:23:05 | <bwolfe> heh |
| 14:23:13 | <bwolfe> dkayiwa, its a clean build issue, iirc |
| 14:23:33 | <dkayiwa> bwolfe: i tried mvn clean |
| 14:23:41 | <djazayeri> dkayiwa: actually i know the problem |
| 14:23:58 | <djazayeri> you're loading a module, right? |
| 14:24:06 | *** edcable has joined #openmrs |
| 14:24:42 | <djazayeri> I just did a commit (fixing headerMinimal) that should fix it |
| 14:26:18 | *** wyclif has quit IRC |
| 14:26:40 | *** dkayiwa_ has joined #openmrs |
| 14:27:00 | <dkayiwa_> sorry had a network problem |
| 14:27:53 | *** dkayiwa has quit IRC |
| 14:28:05 | *** dkayiwa_ is now known as dkayiwa |
| 14:32:51 | *** dkayiwa has quit IRC |
| 14:34:23 | <rafa> Guys don't be shy and srcum ;) |
| 14:35:46 | <bwolfe> rafa, sorry, darius and I joined a call we had sched for 5:15 :-/ |
| 14:35:53 | <bwolfe> and now we're distracted |
| 14:36:13 | <rafa> I see, no problem |
| 14:36:20 | <djazayeri> and dkayiwa is gone |
| 14:36:45 | <bwolfe> yesterday: i |
| 14:36:45 | <bwolfe> * occ tickets |
| 14:36:45 | <bwolfe> * releasetesting branch cleanup |
| 14:36:45 | <bwolfe> * occ sprint page setup |
| 14:36:45 | <bwolfe> * dev call |
| 14:36:45 | <bwolfe> * leadership call |
| 14:36:47 | <bwolfe> today: |
| 14:36:48 | *** dkayiwa has joined #openmrs |
| 14:36:49 | <bwolfe> * occ wiki page cleanup |
| 14:36:51 | <bwolfe> * checkout occ/occmodule, test build |
| 14:36:53 | <bwolfe> * releasetesting branch (frustrations, mostly) |
| 14:36:55 | <bwolfe> * reviewed a few tickets |
| 14:36:57 | <bwolfe> monday: |
| 14:36:59 | <bwolfe> * test occ/occmodule |
| 14:37:01 | <bwolfe> * ui |
| 14:44:33 | <dkayiwa> is the scrum meeting still on? |
| 14:44:45 | <dkayiwa> sorry i got disconnected |
| 14:44:49 | <djazayeri> yes, it's going very slowly though |
| 14:44:58 | <dkayiwa> ok |
| 14:45:06 | *** finbrein has joined #openmrs |
| 14:45:13 | <djazayeri> dkayiwa: I made a commit that should fix your problem, can you try? |
| 14:45:25 | <dkayiwa> oh thanks so so much |
| 14:45:29 | <dkayiwa> let me update |
| 14:47:24 | *** edcable has quit IRC |
| 14:47:42 | <djazayeri> rafa: You don't even necessarily need to look through the code. |
| 14:47:56 | <djazayeri> just try visiting a fragment action's url after having logged out |
| 14:48:03 | <djazayeri> and see what happens |
| 14:48:13 | <djazayeri> (I will comment on that line of code when I have a moment though) |
| 14:50:08 | <djazayeri> my report |
| 14:50:09 | <djazayeri> Wednesday and Thursday: |
| 14:50:09 | <djazayeri> * design and dev calls |
| 14:50:09 | <djazayeri> * sprint code review |
| 14:50:09 | <djazayeri> * Work on letting wrapped 1.x pages/fragments also submit correctly |
| 14:50:09 | <djazayeri> * Work on letting a 1.x module add a tab to the 2.x patient dashboard |
| 14:50:10 | <djazayeri> Today: |
| 14:50:11 | <djazayeri> * Finish work on wrapped 1.x pages/fragments, and dashboards |
| 14:50:11 | <djazayeri> * some other UI ticket |
| 14:50:12 | <djazayeri> * UI code review |
| 14:50:13 | <rafa> djazayeri: It display without any problem. |
| 14:50:35 | <djazayeri> rafa: but it should fail, right? because you have no privileges |
| 14:50:45 | <rafa> djazayeri: I guess ;) |
| 14:50:52 | <rafa> djazayeri: I tested with http://localhost:8080/openmrs2/fragment.page?fragment=manageModules |
| 14:51:04 | <djazayeri> is there a privilege check for listing all modules? |
| 14:51:22 | <rafa> djazayeri: you mean on the service method? |
| 14:51:26 | <djazayeri> try something like listing names for a patient |
| 14:51:33 | *** magoo has quit IRC |
| 14:51:54 | <djazayeri> that should definitely require the View Patients privileges |
| 14:53:10 | *** bwolfe has quit IRC |
| 14:54:32 | <djazayeri> rafa: actually, it should be fragment *actions* that we're worried about |
| 14:54:50 | <djazayeri> e.g. /openmrs2/personNames/listAll.action |
| 14:54:54 | <djazayeri> (not sure if that's a real url) |
| 14:59:36 | *** pascal` has quit IRC |
| 15:00:03 | <rafa> djazayeri: I couldn't access your url. What I did I opened patient demographics and logout and then refreshed names. |
| 15:00:14 | <djazayeri> and what happened? |
| 15:00:26 | <rafa> djazayeri: asked for the user and password |
| 15:00:38 | <rafa> djazayeri: so it seems to be correct |
| 15:00:57 | <rafa> djazayeri: I just checked and the manageModules doesn't check any privileges itself |
| 15:01:16 | <rafa> djazayeri: I mean when I do getLoadedModules action |
| 15:01:36 | <djazayeri> okay, so please add the check to manage modules, but I guess for the ticket, the behavior is already correct. |
| 15:01:54 | <rafa> djazayeri: It doesn't use any service method rather ModuleFactor and that's why nothing is checked |
| 15:02:04 | <rafa> djazayeri: yes, it seems to be correct |
| 15:02:08 | <djazayeri> (even better would be a javascript modal dialog popup if the fragment action was done via json) |
| 15:02:46 | <djazayeri> feel like doing that? |
| 15:03:45 | *** dkayiwa has quit IRC |
| 15:03:45 | *** yanokwa_ has quit IRC |
| 15:03:50 | *** yanokwa has joined #openmrs |
| 15:03:50 | *** ChanServ sets mode: +v yanokwa |
| 15:04:26 | <djazayeri> rafa: so if you were on an ajax-heavy page when you get logged out, you don't lose it |
| 15:04:35 | <rafa> djazayeri: Do you remember which exception should be thrown with no privileges? |
| 15:04:47 | <rafa> djazayeri: Ok, I can work on that. |
| 15:05:00 | <djazayeri> rafa: ContextAuthenticationException is if you're logged out |
| 15:05:21 | <rafa> perfect, thanks |
| 15:06:35 | <rafa> djazayeri: Who should be allowed to view this? |
| 15:06:54 | <djazayeri> The manage modules page? Administrators |
| 15:07:10 | <djazayeri> look in PrivilegeConstants to see if there's an appropriate "Manage Modules" privilege already |
| 15:07:16 | <rafa> djazayeri: ok |
| 15:07:37 | *** wyclif has joined #openmrs |
| 15:13:37 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : fixed using of pure JDBC for storing system default locale and admin locale property <http://feedproxy.google.com/~r/OMRStrunk/~3/WrVsKyDCYZ4/OpenMRS> |
| 15:15:05 | *** upul` has joined #openmrs |
| 15:15:05 | *** ChanServ sets mode: +v upul` |
| 15:15:19 | *** dkayiwa has joined #openmrs |
| 15:15:27 | *** finbrein has quit IRC |
| 15:23:07 | *** cta has quit IRC |
| 15:29:07 | *** rafa has quit IRC |
| 15:31:36 | *** rafa has joined #openmrs |
| 15:31:36 | *** ChanServ sets mode: +v rafa |
| 15:33:44 | *** magoo has joined #openmrs |
| 15:34:06 | *** dkayiwa has left #openmrs |
| 15:34:06 | *** gbastien has quit IRC |
| 15:38:05 | <magoo> dkayiwa am following this procedure File â New â Project â Checkout Maven Projects From SCM |
| 15:38:15 | *** rafa has quit IRC |
| 15:40:46 | <magoo> but when i click on Checkout Maven Projects from SCM i get the following msg |
| 15:41:23 | <magoo> Select SCM type and URL |
| 15:42:31 | *** finbrein has joined #openmrs |
| 15:42:46 | *** mandric has joined #openmrs |
| 15:50:32 | *** edcable has joined #openmrs |
| 15:53:53 | *** downeym has joined #openmrs |
| 15:53:53 | *** ChanServ sets mode: +o downeym |
| 15:53:53 | *** OpenMRSBot sets mode: +o downeym |
| 15:54:00 | *** downeym has quit IRC |
| 15:56:10 | *** magoo has quit IRC |
| 16:18:46 | *** pascal` has joined #openmrs |
| 16:21:04 | *** rafa has joined #openmrs |
| 16:21:04 | *** ChanServ sets mode: +v rafa |
| 16:29:26 | *** rafa has quit IRC |
| 16:31:52 | *** mandric has quit IRC |
| 16:34:37 | *** rafa has joined #openmrs |
| 16:34:42 | *** ChanServ sets mode: +v rafa |
| 16:38:42 | *** yanokwa_ has joined #openmrs |
| 16:38:43 | *** yanokwa has quit IRC |
| 16:53:45 | *** rafa_ has joined #openmrs |
| 16:53:45 | *** ChanServ sets mode: +v rafa_ |
| 16:56:21 | *** rafa has quit IRC |
| 16:58:05 | *** mario_vitalbox has joined #openmrs |
| 17:00:52 | *** rafa_ has quit IRC |
| 17:06:03 | *** lh has joined #openmrs |
| 17:10:34 | *** upul` has quit IRC |
| 17:11:14 | *** cta has joined #openmrs |
| 17:23:35 | *** muthah has joined #openmrs |
| 17:28:45 | *** rafa has joined #openmrs |
| 17:28:45 | *** ChanServ sets mode: +v rafa |
| 17:32:11 | *** mandric has joined #openmrs |
| 17:33:18 | *** rafa_ has joined #openmrs |
| 17:33:18 | *** ChanServ sets mode: +v rafa_ |
| 17:35:34 | *** rafa has quit IRC |
| 17:37:27 | *** rahul has joined #openmrs |
| 17:40:23 | <djazayeri> rafa_, wyclif, I'm thinking of switching the ui2 application so that instead of depending on openmrs-trunk, it depends on 1.8.2. |
| 17:40:36 | <djazayeri> In the long run, that's how it will behave. |
| 17:40:53 | <djazayeri> i.e. each version of the application depends on one specific version of the OpenMRS API. |
| 17:41:45 | <djazayeri> And I feel like if we start that with 1.8.2 now, then pretty soon we'll be at the point where someone can actually run the 1.8 and 2.x applications side by side as they consider developing new functionality in 2.x. |
| 17:41:50 | <djazayeri> Thoughts? |
| 17:42:03 | <djazayeri> (I haven't checked to see if we'd introduce any compile errors this way.) |
| 17:42:24 | <djazayeri> (And obviously when we actually release 2.x it will be based on something higher than the 1.8 API. |
| 17:45:23 | *** finbrein has quit IRC |
| 17:53:20 | *** yekkanti has joined #openmrs |
| 17:53:52 | <djazayeri> rafa_: I get the same error as before when I stop and restart a module |
| 17:54:23 | <djazayeri> actually just after starting it |
| 17:56:10 | <wyclif> djazayeri, ok |
| 17:56:23 | <djazayeri> (1.8.2 -> 1.8.3) |
| 17:56:29 | <djazayeri> oh, no, 1.8.2 |
| 17:56:40 | <djazayeri> actually, wyclif, did you deploy that to our maven repo? |
| 17:56:58 | <wyclif> not yet, will do it before end of today |
| 17:57:02 | <djazayeri> okay |
| 17:57:25 | <wyclif> what was the change you made in setting.xml? |
| 17:57:39 | <djazayeri> recently? what do you mean? |
| 17:58:55 | <rafa_> djazayeri: which module do you use? |
| 17:59:02 | <djazayeri> I've tried with several |
| 17:59:08 | <djazayeri> growthchart, webservices.rest |
| 17:59:31 | <rafa_> hmmm I'll see it again, but it worked fine for me |
| 18:00:04 | <djazayeri> I got that same NPE in hibernate both after stopping or starting a module, and after uploading one |
| 18:00:36 | <djazayeri> I believe that the OpenMRS context's session is being closed, and not re-opened, or something like that. |
| 18:01:30 | <rafa_> djazayeri: do you remember the exact steps you took? |
| 18:01:53 | <rafa_> djazayeri: it works fine for me when I'm testing it |
| 18:01:54 | <djazayeri> Seems like I can reproduce it very consistently |
| 18:02:13 | <rafa_> djazayeri: please try restarting and tell me how :) |
| 18:02:41 | <djazayeri> Easy: I navigate to the manage modules page, and I click on the check to stop an existing module. |
| 18:02:56 | <djazayeri> That click returns successfully, but then any other page I access is dead. |
| 18:03:23 | <rafa_> djazayeri: it doesn't happen to me |
| 18:03:28 | <djazayeri> perhaps related to the modules I happen to be running? Let me send you them so you can try to reproduce |
| 18:03:38 | <rafa_> ok |
| 18:03:53 | <rafa_> I'm testing with metadatasharing and htmlformentry |
| 18:04:01 | <rafa_> it's what I had around |
| 18:04:14 | <djazayeri> yanokwa_: you there? |
| 18:04:19 | <djazayeri> I have a stupid mac user question |
| 18:04:23 | <djazayeri> (I'm the stupid mac user) |
| 18:05:01 | <djazayeri> In a finder window, e.g. in a file upload dialog when attaching a file to a gmail message, how do I get to my ~/.OpenMRS folder? Can I show hidden folders? |
| 18:05:25 | *** rafa_ is now known as rafa |
| 18:05:52 | <rafa> djazayeri: it's too advanced feature for a mac ;) |
| 18:06:59 | <rafa> djazayeri: I've just loaded 5 modules now with no problem :) |
| 18:07:08 | *** finbrein has joined #openmrs |
| 18:07:10 | <djazayeri> you sure you checked everything in? |
| 18:08:49 | <rafa> rafa: I've got all code committed. No working changes. |
| 18:09:07 | *** Suranga has joined #openmrs |
| 18:09:26 | <djazayeri> (for those curious, command-shift-. shows hidden files...) |
| 18:10:23 | <djazayeri> rafa: I emailed you the modules I have there (I also have logic-0.5, but I didn't attach that) |
| 18:10:33 | <rafa> I've got logic too. |
| 18:10:45 | <rafa> let me try |
| 18:11:43 | <djazayeri> when you start up the app, do you see the error from HFE and codeassist about duplicate writeReplace, or something? |
| 18:13:59 | *** mario_vitalbox has quit IRC |
| 18:17:15 | <rafa> djazayeri: yes I see that one, but no NPE |
| 18:17:22 | <djazayeri> odd. |
| 18:17:32 | <rafa> djazayeri: all the modules you sent worked |
| 18:17:35 | <djazayeri> but you did get the NPE yesterday before you made that fix? |
| 18:17:40 | <rafa> yes |
| 18:17:59 | <rafa> the code is in rep for sure |
| 18:18:06 | <rafa> it's even attached to a code review |
| 18:18:45 | <rafa> It's a single line in ManageModulesFragmentController |
| 18:18:56 | <rafa> if (existingModule.isStarted())... |
| 18:19:04 | <djazayeri> I know, I reviwed it even... |
| 18:19:41 | <rafa> djazayeri: did you run clean install and everything? |
| 18:19:50 | <djazayeri> yes. |
| 18:20:06 | <yanokwa_> djazayeri easiest way is in the dialog, just enter the path.. |
| 18:20:22 | <yanokwa_> so you can just start typing ~ or /whatever |
| 18:20:45 | <djazayeri> ah, it'll figure that out? |
| 18:21:49 | <djazayeri> cool |
| 18:23:00 | <rafa> djazayeri: I've just done svn update. It seems that I didn't have a few files. I'll test now... |
| 18:27:23 | <rafa> djazayeri: got it! |
| 18:27:39 | <rafa> djazayeri: some later changes broke it |
| 18:27:52 | <djazayeri> okay, great, well, back to you then. |
| 18:28:24 | <rafa> why me :P |
| 18:28:31 | <rafa> I didn't make those changes :P |
| 18:28:56 | <djazayeri> I'm curious what broke it, actually. |
| 18:29:05 | <djazayeri> (you, because life isn't fair.) |
| 18:33:44 | *** yekkanti has left #openmrs |
| 18:35:26 | <djazayeri> switching ui2 to depend on 1.8 instead of 1.9.0-SNAPSHOT breaks a bunch of the DWR services in 1x-compatibility |
| 18:35:44 | <djazayeri> annoying that we have those copied there, rather than just referenced |
| 18:35:58 | <djazayeri> I don't suppose there's a way to use maven to include only some of the packages in a particular jar? |
| 18:41:35 | <djazayeri> or we could refactor the main OpenMRS maven project to include DWR as separate from web... |
| 18:42:25 | <wyclif> djazayeri, i need to make a change in trunk to be able to check for unran changesets in the ui2 liquibase file |
| 18:42:42 | <djazayeri> wyclif: hmm, really? |
| 18:42:47 | <djazayeri> I think that's a good thing to do anyway |
| 18:42:52 | <djazayeri> so, I'm 100% fine with doing it. |
| 18:43:34 | <wyclif> the method that checks for unran changesets take in no argument so it always defaults to the one in the API |
| 18:43:52 | <wyclif> so i have t ooverload it to take the argument for the file to check |
| 18:43:54 | <djazayeri> Any application that is built on top of the OpenMRS API should be able to specify (via Spring, I guess) what changeset files it wants OpenMRS to look at. |
| 18:44:14 | <wyclif> i dont think that is correct |
| 18:44:34 | <djazayeri> what class/method? |
| 18:45:08 | <wyclif> DatabaseUpdater.getUnrunDatabaseChanges |
| 18:45:50 | <wyclif> this is the only blocker to complete this ticket |
| 18:46:56 | <djazayeri> So, are you envisioning a workflow where in the 2.x application we have a slightly different update wizard, where it first does the core api updates, and then it does the ui-application updates? |
| 18:47:18 | *** gbastien has joined #openmrs |
| 18:47:24 | <djazayeri> wyclif: ^^ |
| 18:47:43 | <wyclif> that is what i have implemented, i want to avoid tying the web layer to the API layer |
| 18:47:58 | <wyclif> because using the API should not have to execute this file |
| 18:48:33 | <djazayeri> So, I was envisioning that we introduce a configuration parameter into DatabaseUpdater. |
| 18:48:40 | <wyclif> so everything is going to be in the web layer and that why i have to know which unrun changesets are in this file only so that i can ran them |
| 18:48:42 | <djazayeri> right now it has a private static final CHANGE_LOG_FILE |
| 18:48:57 | <djazayeri> instead it should also have a List<String> additionalChangeLogFiles |
| 18:49:04 | <djazayeri> that can be configured from Spring |
| 18:49:17 | <djazayeri> so it's not that the API would depend on the 2.x application |
| 18:49:36 | <djazayeri> but rather in the 2.x application's app-config.xml, it would add a String to that list. |
| 18:49:39 | <wyclif> am fine with ding it via spring |
| 18:49:48 | <wyclif> sorry doing it via spring |
| 18:50:11 | <djazayeri> The advantage of your way is that it gives more flexibility, the advantage of mine is that it requires less work for other application developers. |
| 18:50:48 | <wyclif> i agree |
| 18:51:09 | <wyclif> so should i create a ticket for this |
| 18:51:10 | <djazayeri> Let's see, is there a reason why when running the 2.x application, we would only want to execute the core-API-changesets? |
| 18:51:29 | <djazayeri> but _not_ do the 2.x application changesets yet? |
| 18:51:41 | <djazayeri> I can't think of one offhand. But haven't really considered that. |
| 18:51:51 | <wyclif> no |
| 18:52:02 | <djazayeri> wyclif: ****definitely**** a ticket. :-) |
| 18:52:12 | <djazayeri> in TRUNK with fixVersion = 1.9 |
| 18:52:41 | <djazayeri> At first thought, I'd prefer to go with the Spring-configured way |
| 18:52:49 | <djazayeri> is DatabaseUpdater instantiated by Spring though? |
| 18:53:13 | <wyclif> my point is that i right now my code can't ran the UI changesets because there is no way it can no if there are any that are not yet ru |
| 18:53:16 | <wyclif> run |
| 18:53:29 | <wyclif> no |
| 18:53:45 | <wyclif> it has static methods mainly |
| 18:53:53 | <djazayeri> Actually, is DatabaseUpdate _before_ we instantiate Spring? |
| 18:54:06 | <djazayeri> wyclif: I definitely want you to _do_ the ticket. |
| 18:54:08 | <djazayeri> (now) |
| 18:54:26 | <djazayeri> I just mean that we need to create a ticket in TRUNK to record the change we're making |
| 18:54:28 | <wyclif> and database update is done before spring is up, so this might rule out your option |
| 18:54:59 | <wyclif> this file has to run during initialization too |
| 18:55:15 | <djazayeri> wyclif: our web.xml has this at the beginning: |
| 18:55:16 | <djazayeri> <context-param> |
| 18:55:16 | <djazayeri> <param-name>contextConfigLocation</param-name> |
| 18:55:16 | <djazayeri> <param-value> |
| 18:55:16 | <djazayeri> /WEB-INF/spring/app-config.xml |
| 18:55:16 | <djazayeri> classpath*:/moduleApplicationContext.xml |
| 18:55:17 | <djazayeri> classpath*:/ui2ModuleApplicationContext.xml |
| 18:55:17 | <djazayeri> </param-value> |
| 18:55:18 | <djazayeri> </context-param> |
| 18:55:45 | <wyclif> i can do the ticket |
| 18:55:46 | <djazayeri> alternately, filters can have init-params |
| 18:56:10 | <djazayeri> Which filter does the updates? |
| 18:56:17 | <wyclif> UpdateFilter |
| 18:56:35 | <djazayeri> InitializationFilter you mean? |
| 18:57:10 | <wyclif> both of them run updates |
| 18:57:39 | <wyclif> Intialization updates the database after creating the schema and inserted core data |
| 18:58:26 | <wyclif> as my code stands, am running UI updates both at intialization and Update |
| 18:59:11 | <wyclif> and my challenge right now is that if i have new changesets in the UI changelog file, i can know so that the UpdateFIlter intercepts the request |
| 19:02:27 | <wyclif> sorry! i cant know if it contains unrun changesets and that is why i need to add this in core to be able to specify the file in which to find unrun changesets |
| 19:04:53 | <djazayeri> so, I propose adding a context-param in web.xml called additionalLiquibaseChangeLogs |
| 19:05:40 | <djazayeri> and the relevant filters can fetch that from filterConfig.servletContext.getInitiParameter |
| 19:06:04 | <djazayeri> it seems appropriate to me that you'd configure that the same place you configure which spring xml files to use |
| 19:06:08 | *** edcable has quit IRC |
| 19:07:12 | <djazayeri> wyclif: ^^ |
| 19:07:18 | <wyclif> djazayeri, hi |
| 19:07:52 | <wyclif> but still the filters need to pass the files to DatabaseUpdater |
| 19:08:03 | <wyclif> and that wouldn't be solved yet |
| 19:09:36 | <djazayeri> hmm, those are all static? |
| 19:10:29 | <djazayeri> okay, how about adding a String... additionalChangeLogFiles parameter to the method |
| 19:10:53 | <wyclif> Is it ok to change the method signatures say in DatabaseUpdater? without worrying about API calls that will break |
| 19:11:26 | <djazayeri> Adding a varargs (Stringâ¦) parameter shouldn't break things, I hope |
| 19:11:51 | <djazayeri> because it remains legal to call getDatabaseChanges() |
| 19:12:55 | <djazayeri> While we're doing this, we should add a wiki page "how to do additional db liquibase updates in an application that uses the OpenMRS API" |
| 19:13:05 | <wyclif> i mean do we have to deprecate methods in DatabaseUpdater or we can change it without worrying about users of the API |
| 19:13:17 | <djazayeri> I don't see a need to deprecate it. |
| 19:13:47 | <djazayeri> because (1) it will remain source-compatible, and (2) we've made no commitment to maintain these methods. they're not part of our public API. |
| 19:14:14 | <wyclif> ok |
| 19:15:06 | *** mandric has quit IRC |
| 19:23:33 | *** wyclif has quit IRC |
| 19:23:44 | *** wyclif has joined #openmrs |
| 19:24:55 | <rafa> wyclif: Do you have any idea which of your changes in your last commit might be related to Hibernate not starting properly after module upgrade? |
| 19:25:25 | <djazayeri> rafa: do you know what changesets it was in? |
| 19:25:32 | <djazayeri> probably adding one of the filters |
| 19:25:33 | <rafa> Any clues regarding StartupFilter and OpenmrsFilter |
| 19:25:49 | <rafa> It's rev 21794 |
| 19:25:51 | <djazayeri> I'd have thought that OpenmrsFilter was already there |
| 19:27:44 | <rafa> there are a couple of filters changed in this rev. |
| 19:28:02 | <rafa> The problem must be somewhere there. |
| 19:29:10 | <djazayeri> I'd look at the diff in web.xml |
| 19:29:16 | <djazayeri> what extra filter got added |
| 19:30:39 | <rafa> HibernateFilter got removed... |
| 19:30:51 | <djazayeri> or moved to a different place in the order? |
| 19:31:15 | <rafa> right |
| 19:31:35 | <rafa> Actually I see it declared twice in the old file |
| 19:31:38 | <djazayeri> so, one option is that the filters are out of order |
| 19:31:41 | <djazayeri> is one commented out? |
| 19:32:04 | *** james_regen has quit IRC |
| 19:32:05 | <rafa> yes, the later one |
| 19:32:16 | <djazayeri> I'd been experimenting with the two different ways of doing opensessioninview |
| 19:33:27 | <rafa> maybe I'll try to move the HibernateFilter up to it's previous position |
| 19:39:06 | <rafa> no it didn't help :/ |
| 19:39:35 | <djazayeri> so, when I googled for the specific error message (using the line in hibernate) |
| 19:39:57 | <djazayeri> It mentioned something about the cause being that the hibernate session is closed |
| 19:49:40 | <rafa> djazayeri: I'll have to go line-by-line of wyclif's commit I guess. |
| 19:49:49 | <rafa> djazayeri: I'll leave it for Monday. |
| 19:50:26 | <rafa> djazayeri: Have a nice weekend! |
| 19:52:16 | *** cta has quit IRC |
| 19:52:16 | <djazayeri> rafa: I was just going to suggest waiting until monday when bwolfe is online |
| 19:52:24 | <djazayeri> have a good weekend too |
| 20:04:08 | *** rafa has quit IRC |
| 20:15:03 | *** mario_vitalbox has joined #openmrs |
| 20:25:13 | <mario_vitalbox> Hola Darius |
| 20:29:16 | *** asgoyal has quit IRC |
| 20:32:13 | <djazayeri> hola mario_vitalbox |
| 20:33:52 | <djazayeri> mario_vitalbox: funziona lo que agregaste a html form entry? |
| 20:34:17 | <mario_vitalbox> Darius te envie un correo con la modificacion del htmlformentry, para que la mires porfa y me digas como esta. |
| 20:34:27 | <mario_vitalbox> ya la vamos a verificar |
| 20:35:35 | <djazayeri> yo estaba pensando en ejecutar los funziones en doSubmitHtmlForm, despues de la validacion, pero antes de enviar el formulario por web |
| 20:35:52 | <djazayeri> quieres ejecutar tu funzion antes de la validacion? |
| 20:36:12 | <djazayeri> Quisas podmos agregar dos listas: beforeValidation and beforeSubmit |
| 20:36:30 | <mario_vitalbox> si la idea es realizar unas validaciones antes |
| 20:36:43 | <djazayeri> okay, eso tiene sentido |
| 20:36:45 | <mario_vitalbox> ok voy agregar la otra lista |
| 20:37:03 | <djazayeri> okay, y llamales "beforeValidation" and "beforeSubmit" |
| 20:37:24 | <mario_vitalbox> ok |
| 20:40:20 | *** lh has quit IRC |
| 20:41:05 | *** jportela has left #openmrs |
| 20:47:05 | <wyclif> djazayeri, the order of the filters didn't change, and there is only one HibernateFilter, the other was commented out |
| 20:47:49 | <wyclif> the HibernateFIlter has to come after the StartUpFIlters others what would be the use to open a session when even spring is not yet up |
| 20:48:31 | <wyclif> sorry about the typos |
| 20:48:41 | <djazayeri> wyclif: yeah, changing filter order was just a quick try-it-and-hope idea |
| 20:48:54 | <djazayeri> I think we should just wait until Monday to debug this when ben is online too |
| 20:48:58 | <wyclif> but the idea is that i see nothing wrong with the current order |
| 20:49:04 | <wyclif> ok |
| 20:49:18 | <wyclif> is it failing for you too? |
| 20:49:20 | <djazayeri> he knows the most about the module framework |
| 20:49:35 | <djazayeri> It's failing when I try to start/stop/load/unload a module |
| 20:49:56 | <djazayeri> but that's just an inconvenience, because until two days ago there wasn't even a manage modules page. :-) |
| 20:50:09 | <wyclif> bbut i thought was failing even before my changeset |
| 20:51:12 | <djazayeri> It was failing in one specific case before your changeset, but failing in all cases afterwards |
| 20:51:23 | <djazayeri> actually that's probably a useful piece of information |
| 20:51:48 | <djazayeri> anyway, probably the underlying problem is something that I did differently in the 2.x application than ben did in the 1.x application |
| 20:52:00 | <djazayeri> but we can investigate later |
| 21:01:22 | *** Suranga has quit IRC |
| 21:25:38 | *** mario_vitalbox has quit IRC |
| 21:49:11 | *** gbastien has quit IRC |
| 22:03:31 | *** mandric has joined #openmrs |
| 22:04:57 | *** pascal` has quit IRC |
| 22:26:14 | <djazayeri> anybody there? |
| 22:40:23 | <wyclif> djazayeri, am here |
| 22:41:18 | <djazayeri> wyclif: can you look at this ticket and tell me if you see any attachments? |
| 22:41:19 | <djazayeri> https://tickets.openmrs.org/browse/TRUNK-2483 |
| 22:41:32 | <djazayeri> suranga attached a bunch, but I can't see them. |
| 22:42:41 | <wyclif> i dont see them on the ticket |
| 22:42:48 | <djazayeri> okay, so not just me, thanks |
| 22:43:13 | <wyclif> but when i go to manage attachment i see some attachments that are not patches |
| 22:44:04 | <djazayeri> ah, I didn't know you could Manage Attachments |
| 22:44:24 | <djazayeri> thanks, that helps |
| 22:52:08 | *** mandric has quit IRC |
| 22:55:22 | *** finbrein has quit IRC |
| 22:56:14 | *** yanokwa has joined #openmrs |
| 22:56:14 | *** ChanServ sets mode: +v yanokwa |
| 22:56:15 | *** yanokwa_ has quit IRC |
| 22:57:59 | *** lh has joined #openmrs |
| 22:59:16 | *** yanokwa_ has joined #openmrs |
| 22:59:17 | *** yanokwa has quit IRC |
| 23:09:18 | *** yanokwa has joined #openmrs |
| 23:09:18 | *** yanokwa_ has quit IRC |
| 23:09:18 | *** ChanServ sets mode: +v yanokwa |