| 01:04:04 | *** wyclif has joined #openmrs |
| 01:32:01 | *** jwishnie has quit IRC |
| 02:46:08 | *** upul` has joined #openmrs |
| 02:46:08 | *** ChanServ sets mode: +v upul` |
| 02:48:09 | *** jportela has quit IRC |
| 04:07:07 | <wyclif> djazayeri, |
| 04:07:31 | <wyclif> SprintMvcViewTest seems broken |
| 04:08:53 | *** surangak has joined #openmrs |
| 04:11:21 | <wyclif> hi djazayeri |
| 04:14:40 | <wyclif> i have turns of build issues |
| 06:01:34 | <djazayeri> wyclif: yes, it's daniel's fault |
| 06:02:08 | <djazayeri> you'd need to update to the specific revision 21755 |
| 06:02:19 | <djazayeri> I emailed daniel to ask him to fix it tomorrow morning |
| 06:02:48 | <djazayeri> hmm, SpringMvcViewTest is my fault. |
| 06:04:11 | <djazayeri> I see you or someone else fixed it. Thanks! |
| 06:10:13 | <bwolfe> 2+ |
| 06:10:41 | <bwolfe> (sorry andy at the keyboard there) |
| 06:11:43 | *** rafa has joined #openmrs |
| 06:11:43 | *** ChanServ sets mode: +v rafa |
| 06:19:10 | *** rafa has quit IRC |
| 06:36:56 | *** dkayiwa has joined #openmrs |
| 06:41:04 | *** magoo has joined #openmrs |
| 06:49:35 | *** pascal` has joined #openmrs |
| 07:12:07 | *** bwolfe has quit IRC |
| 08:02:11 | *** gauravpaliwal has joined #openmrs |
| 08:02:11 | *** ChanServ sets mode: +v gauravpaliwal |
| 08:08:43 | *** gauravpaliwal1 has joined #openmrs |
| 08:08:43 | *** gauravpaliwal has quit IRC |
| 08:10:59 | *** ChanServ sets mode: +v pascal` |
| 08:15:11 | <gauravpaliwal1> pascal`: |
| 08:15:13 | <gauravpaliwal1> hi |
| 08:22:31 | <pascal`> hi |
| 08:28:42 | <gauravpaliwal1> pascal`: when I am testing how can i add service context for example this code : http://pastebin.com/7Wt8BYk3 I have request as Private MockHttpRequest and I am getting error : http://pastebin.com/qYJVkkCQ , no service context exits ? code failing at line *6* |
| 08:31:01 | <pascal`> gauravpaliwal1, As far as I know, you need to use the right type of testing class to access the context. |
| 08:31:42 | <pascal`> gauravpaliwal1, have you seen this: https://wiki.openmrs.org/display/docs/Module+Unit+Testing ? |
| 08:31:49 | <OpenMRSBot> <http://ln-s.net/90Rl> (at wiki.openmrs.org) |
| 08:32:53 | <gauravpaliwal1> yes and the biggest problem is that I am using netbeans :( |
| 08:34:26 | <gauravpaliwal1> pascal`: what does right type of testing class means |
| 08:34:28 | <gauravpaliwal1> ? |
| 08:37:09 | <pascal`> gauravpaliwal1, I think you need a ContextSensitiveTest |
| 08:37:20 | <pascal`> gauravpaliwal1, but I'm not sure, it's probably best to copy a test from core. |
| 08:37:42 | <gauravpaliwal1> pascal`: I am using extends BaseWebContextSensitiveTest. |
| 08:40:05 | *** bryq has joined #openmrs |
| 08:40:05 | *** ChanServ sets mode: +v bryq |
| 08:55:52 | *** bwolfe has joined #openmrs |
| 08:55:52 | *** ChanServ sets mode: +o bwolfe |
| 09:15:40 | *** bwolfe has quit IRC |
| 09:21:56 | *** magoo has quit IRC |
| 09:26:37 | *** goutham has joined #openmrs |
| 09:31:06 | *** goutham has quit IRC |
| 09:32:15 | *** goutham has joined #openmrs |
| 09:32:38 | <goutham> djazayeri: hi |
| 09:32:41 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: XForms 4.0.5 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.5> |
| 09:40:17 | *** bwolfe has joined #openmrs |
| 09:40:17 | *** ChanServ sets mode: +o bwolfe |
| 09:46:42 | *** bwolfe has quit IRC |
| 09:52:23 | *** magoo has joined #openmrs |
| 09:53:22 | *** bwolfe has joined #openmrs |
| 09:53:22 | *** ChanServ sets mode: +o bwolfe |
| 10:03:08 | <goutham> bwolfe: Hi |
| 10:05:24 | *** surangak has quit IRC |
| 10:05:52 | *** surangak has joined #openmrs |
| 10:11:23 | *** bwolfe has quit IRC |
| 10:11:23 | <gauravpaliwal1> bwolfe: Hi |
| 10:12:53 | <goutham> gauravpaliwal1: hi , do u know how to add a dependent module to a new mavenized module |
| 10:12:55 | <dkayiwa> hi gauravpaliwal1 |
| 10:13:40 | <gauravpaliwal1> hi dkayiwa |
| 10:13:56 | <gauravpaliwal1> goutham: no :) |
| 10:13:57 | <dkayiwa> bwolfe could be having lunch :) |
| 10:14:04 | <gauravpaliwal1> np |
| 10:14:05 | <gauravpaliwal1> :) |
| 10:14:21 | <dkayiwa> you can join him :D |
| 10:14:40 | <gauravpaliwal1> dkayiwa: its evening in india |
| 10:14:41 | <gauravpaliwal1> :D |
| 10:14:50 | <dkayiwa> lollllllllllll :D |
| 10:15:12 | <goutham> gauravpaliwal1: Ok |
| 10:15:41 | <gauravpaliwal1> dkayiwa: do you know how to solve this problem : testFormBackingObject(org.openmrs.module.feedback.web.AddFeedbackFormControllerTest) Time elapsed: 0.084 sec <<< FAILURE! |
| 10:15:42 | <gauravpaliwal1> javax.servlet.ServletException: successView isn't set |
| 10:16:12 | <gauravpaliwal1> dkayiwa: i got this error on this statement : mv = instance.handleRequest(request, response) ; |
| 10:16:57 | <dkayiwa> could u pastebin the entire class |
| 10:18:30 | *** bwolfe has joined #openmrs |
| 10:18:30 | *** ChanServ sets mode: +o bwolfe |
| 10:18:39 | <gauravpaliwal1> dkayiwa: yes |
| 10:19:08 | <gauravpaliwal1> dkayiwa: http://pastebin.com/CNh6rW3r |
| 10:19:36 | <gauravpaliwal1> dkayiwa: line 65 vomiting error :) |
| 10:20:00 | <dkayiwa> ok |
| 10:22:24 | <dkayiwa> can u also pastebin the controller |
| 10:23:55 | <gauravpaliwal1> dkayiwa: yes |
| 10:24:32 | <dkayiwa> ok |
| 10:24:46 | <gauravpaliwal1> dkayiwa: it is here :http://pastebin.com/nD5UApZ0 |
| 10:25:10 | <dkayiwa> ok |
| 10:26:50 | <bwolfe> hi goutham |
| 10:26:59 | <bwolfe> (a late reply to your earlier greeting) |
| 10:28:02 | <gauravpaliwal1> bwolfe: we got to know that you are having lunch by dkayiwa :D |
| 10:28:13 | <dkayiwa> :) |
| 10:28:47 | <gauravpaliwal1> bwolfe: beat this : Chinese take copyright violation to new level. They copied the Apple store http://j.mp/n3k0od |
| 10:30:00 | <goutham> bwolfe: :) i just want to know how to add dependent modules to new maven module.. i figured it out myself :) |
| 10:30:40 | <bwolfe> goutham, good work. was it on the wiki? or should you add it for the next person that might need to do it manually? :-) |
| 10:31:14 | <gauravpaliwal1> dkayiwa: any pointer ? |
| 10:31:32 | <bwolfe> gauravpaliwal1, yeah, was at lunch, but I don't start my wednesdays or thursdays until about now because I have conference calls with the US after dinner (for hours) |
| 10:32:00 | <dkayiwa> still thinking member:gauravpaliwal1 :) |
| 10:32:11 | <magoo> dkayiwa when i try to follow the video frm this site http://eclipse.org/m2e/ i fail to get the maven plugin |
| 10:32:21 | <gauravpaliwal1> magoo: same here |
| 10:32:54 | <gauravpaliwal1> magoo: apache started a new project for this maven plugin i think that names something ime or something similar , you need to add that |
| 10:33:26 | <magoo> so i should try apache maven |
| 10:33:48 | <goutham> bwolfe: it was not on wiki.. |
| 10:34:05 | <gauravpaliwal1> magoo: let me check on my browser history |
| 10:34:16 | <magoo> okay |
| 10:34:44 | <dkayiwa> did u set the successView in your moduleapplicationcontext file gauravpaliwal1 ? |
| 10:35:32 | <gauravpaliwal1> dkayiwa: yes , http://pastebin.com/5tkxusV5 |
| 10:36:05 | <goutham> bwolfe: do u want me to add the steps on wiki ? |
| 10:36:54 | <bwolfe> goutham, yeah, add it to a child page of the Creating Modules page or add a new page if there isn't a good place to put it |
| 10:37:37 | <goutham> bwolfe: there is a space on wiki https://wiki.openmrs.org/display/docs/Module+Dependencies |
| 10:37:43 | <OpenMRSBot> <http://ln-s.net/90SD> (at wiki.openmrs.org) |
| 10:38:31 | <goutham> bwolfe: shall i add it there? |
| 10:39:47 | <dkayiwa> gauravpaliwal1: since you are in a unit test, first call instance.setSuccessView("someValue") and then try again running the test |
| 10:40:26 | <gauravpaliwal1> magoo: link : http://m2eclipse.sonatype.org/sites/m2e/ |
| 10:40:45 | <gauravpaliwal1> dkayiwa: someValue can be anything ? |
| 10:40:52 | <dkayiwa> yes |
| 10:41:32 | *** bwolfe has quit IRC |
| 10:41:45 | <gauravpaliwal1> dkayiwa: miracle its running :) |
| 10:41:47 | *** rafa has joined #openmrs |
| 10:41:47 | *** ChanServ sets mode: +v rafa |
| 10:41:51 | <gauravpaliwal1> dkayiwa: thanks |
| 10:41:54 | <dkayiwa> hahahahah :D |
| 10:42:02 | *** bwolfe has joined #openmrs |
| 10:42:02 | *** ChanServ sets mode: +o bwolfe |
| 10:43:21 | *** bwolfe_ has joined #openmrs |
| 10:43:21 | *** ChanServ sets mode: +o bwolfe_ |
| 10:44:57 | <gauravpaliwal1> dkayiwa: is it possible to read the data from response , I mean I am not getting any response.getParameter() ? |
| 10:45:05 | <bwolfe_> goutham, yes, add there. (sorry, got dropped) |
| 10:45:28 | <bwolfe_> the response is what is sent back to the browser from your server. there are no parameters there |
| 10:45:38 | *** bwolfe has quit IRC |
| 10:45:40 | *** bwolfe_ is now known as bwolfe |
| 10:46:11 | <gauravpaliwal1> bwolfe: so, how can i test wheather the servlet has executed correctly or not |
| 10:46:48 | <gauravpaliwal1> ? |
| 10:46:58 | <bwolfe> after it you can check using your service |
| 10:55:30 | *** jportela has joined #openmrs |
| 10:55:30 | *** ChanServ sets mode: +v jportela |
| 10:58:35 | <gauravpaliwal1> bwolfe: org.openmrs.api.APIException: Service not found: interface org.openmrs.module.feedback.FeedbackService , do I have to manually add something somewhere ? |
| 11:01:13 | *** bwolfe has quit IRC |
| 11:02:16 | <gauravpaliwal1> dkayiwa: org.openmrs.api.APIException: Service not found: interface org.openmrs.module.feedback.FeedbackService , do I have to manually add something somewhere ? |
| 11:03:45 | <dkayiwa> when do u get that error |
| 11:04:58 | *** goutham has quit IRC |
| 11:05:58 | <gauravpaliwal1> FeedbackService hService = (FeedbackService)Context.getService(FeedbackService.class); in testing |
| 11:06:01 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Introducing method getValue to Obs Handlers <http://feedproxy.google.com/~r/OMRStrunk/~3/VAG4iaxdAaY/OpenMRS> |
| 11:06:43 | <dkayiwa> gauravpaliwal1: is that in a unit test |
| 11:06:43 | <gauravpaliwal1> dkayiwa: full source code is here :http://pastebin.com/zucnkd3G |
| 11:06:48 | <gauravpaliwal1> dkayiwa: yes |
| 11:06:52 | <dkayiwa> ok |
| 11:07:20 | <gauravpaliwal1> dkayiwa: ben told i need to access to service to make sure the controller works |
| 11:07:42 | <dkayiwa> gauravpaliwal1: is your module installed and running? |
| 11:08:10 | *** james_regen has joined #openmrs |
| 11:08:10 | *** ChanServ sets mode: +v james_regen |
| 11:08:29 | <gauravpaliwal1> dkayiwa: how can i run my module while testing ? |
| 11:08:56 | <gauravpaliwal1> dkayiwa: its not running i am just pressing run test case |
| 11:08:58 | <dkayiwa> first run the web app and install your module gauravpaliwal1: |
| 11:09:16 | *** goutham has joined #openmrs |
| 11:10:19 | <gauravpaliwal1> dkayiwa: will running it outside the ide work , i don;t use embedded jetty i use netbeans and run them manually in tomcat |
| 11:10:48 | <dkayiwa> yes it will work |
| 11:11:07 | *** surangak has quit IRC |
| 11:11:18 | <magoo> i have downloaded the apache maven ver 3.0.3 can i just import the plugin into eclipse |
| 11:11:42 | <dkayiwa> yes magoo |
| 11:14:36 | <magoo> from the import dialog should i select plugin and fragments |
| 11:15:18 | <gauravpaliwal1> dkayiwa: still same error , i started tomcat and logged into openmrs but same error. |
| 11:15:58 | *** goutham has quit IRC |
| 11:17:15 | <dkayiwa> gauravpaliwal1 change yo base class to BaseModuleWebContextSensitiveTest |
| 11:18:42 | <gauravpaliwal1> dkayiwa: even thwn error :( |
| 11:19:01 | <gauravpaliwal1> dkayiwa: isn't that I have to initialize service somehwere ? |
| 11:19:23 | <gauravpaliwal1> dkayiwa: calling method like authenticated etc ? |
| 11:20:11 | <dkayiwa> oh yes |
| 11:20:15 | <dkayiwa> initializeInMemoryDatabase(); |
| 11:20:15 | <dkayiwa> authenticate(); |
| 11:21:00 | *** bwolfe has joined #openmrs |
| 11:21:00 | *** ChanServ sets mode: +o bwolfe |
| 11:21:00 | <magoo> ?? |
| 11:22:00 | <magoo> dkayiwa where should i import the plugin |
| 11:22:25 | <dkayiwa> magoo i was not following you |
| 11:22:28 | <dkayiwa> which plugin? |
| 11:22:50 | <magoo> the apache maven plugin i downloaded |
| 11:23:00 | *** rahul has joined #openmrs |
| 11:24:09 | <dkayiwa> magoo which wiki instructions are you following? |
| 11:24:35 | <gauravpaliwal1> dkayiwa: now got this :http://pastebin.com/pUPsYmHU |
| 11:25:55 | <magoo> http://eclipse.org/m2e/ when i follow the video i fail to get the plugin |
| 11:26:25 | <dkayiwa> gauravpaliwal1 which line throws that error |
| 11:27:55 | *** goutham has joined #openmrs |
| 11:27:59 | <dkayiwa> magoo: did you try add the eclipse update site for the plugin? |
| 11:28:09 | <gauravpaliwal1> dkayiwa: initializeInMemoryDatabase(); //i am using @BeforeClass annonation |
| 11:28:19 | <magoo> i just followed the apache maven link http://maven.apache.org/download.html i downloaded |
| 11:28:42 | <magoo> u mean when i update the plugin is automatically installed |
| 11:29:42 | <dkayiwa> gauravpaliwal1: can you make that call in the actual test method? |
| 11:30:24 | <dkayiwa> magoo: so you have already installed maven. correct? |
| 11:30:36 | <gauravpaliwal1> dkayiwa: trying |
| 11:31:21 | <gauravpaliwal1> dkayiwa: still error coming from the same line :( |
| 11:31:35 | <magoo> that's where am confused i dont know if its installed, how do i check that it is installed |
| 11:32:36 | <gauravpaliwal1> dkayiwa: wiki says something about this error |
| 11:32:43 | <gauravpaliwal1> dkayiwa: here is that : If you get an exception like org.openmrs.api.APIException: Service not found: class org.openmrs.module. ... then you may need to do one of two things. First, make sure that you have run the ant "package module" task. If you've already done that, then you probably need to fix your build file for the module you're including. Open build.xml in the module you're compiling Find the "package-jar" target Remove the li |
| 11:32:54 | <gauravpaliwal1> https://wiki.openmrs.org/display/docs/Module+Unit+Testing |
| 11:32:55 | <OpenMRSBot> <http://ln-s.net/90Rl> (at wiki.openmrs.org) |
| 11:33:21 | *** upul` has quit IRC |
| 11:38:08 | <rahul> hi |
| 11:38:39 | <rahul> I am getting this error can any tell why this error is coimng ? |
| 11:38:40 | <rahul> failed to lazily initialize a collection of role: org.openmrs.Patient.identifiers, no session or session was closed |
| 11:39:45 | <rahul> bwolfe : i am getting this error is there any solution ? |
| 11:41:28 | <dkayiwa> gauravpaliwal1: do you have that module committed any where for me to also test? |
| 11:41:30 | <bryq> Hi rafa |
| 11:41:37 | <rafa> hi bryq |
| 11:42:01 | <gauravpaliwal1> dkayiwa: let me commit |
| 11:42:08 | <dkayiwa> rahul: when do you get that error? |
| 11:42:11 | <dkayiwa> ok |
| 11:42:44 | <rahul> when i am i am accessing getIdentifiers for the second time |
| 11:42:55 | <rahul> dkayiwa |
| 11:43:01 | <bryq> rafa: How could I get a typeId for a class [ MetadataTypeHandler#getTypeId(java.lang.Object) ]? The problem is, that I want to display missing items while creating new version, but if the item is missing I cannot get its typeid :( (because it is null) |
| 11:43:19 | <bryq> rafa: The soultion is to implement: MetadataTypeHandler#getTypeId(Class) |
| 11:43:38 | <bryq> rafa: Or to display the missing's item class rather than typeId |
| 11:43:53 | <rahul> dkayiwa : when i am accessing getIdentifier() for second time |
| 11:43:56 | <dkayiwa> rahul is that from a module? |
| 11:44:07 | <rafa> bryq: If there's no such method yet, we definitely need it :) |
| 11:44:16 | <bryq> rafa: But getTypeId(Class) would work? |
| 11:44:24 | <rafa> bryq: sure |
| 11:44:38 | <bryq> rafa: Okay :) |
| 11:44:48 | <rahul> ya i am using in my module |
| 11:45:10 | <dkayiwa> rahul: so you mean first time works well? |
| 11:45:12 | <rahul> dkayiwa : ya i am using in my module |
| 11:45:47 | <bryq> rafa: I only wanted to know if there is no magic behind getTypeId(Object) method :) |
| 11:45:51 | <rahul> yes first time it will work |
| 11:45:56 | <dkayiwa> rahu: can u pastebin the class for me to look at? |
| 11:45:56 | <bryq> rafa: So I'll implement getTypeId(Class) |
| 11:46:05 | <rafa> bryq: Not really. btw you'll notice that it'll be needed to add this method to every handler. |
| 11:46:18 | <rahul> ya okay |
| 11:46:22 | <rafa> bryq: I'd suggest that you introduce something like BaseHandler |
| 11:46:35 | <rafa> bryq: with this method implemented |
| 11:46:43 | <rafa> bryq: and make other handlers to extend it |
| 11:47:07 | <rafa> bryq: but do it only if there's an easy way |
| 11:47:15 | *** bwolfe has quit IRC |
| 11:47:26 | <rafa> bryq: i.e. if you can really provide a general implementation for all handlers |
| 11:47:42 | <rafa> bryq: if it's not possible just implement it in every handler. |
| 11:47:43 | <bryq> rafa: It looks easy at the first glance |
| 11:48:24 | <rafa> bryq: yes, I think you could move the types map to the BaseHandler class |
| 11:48:52 | <gauravpaliwal1> dkayiwa: git : https://github.com/gauravpaliwal/General-Feedback-Module-OpenMRS/ svn : http://svn.openmrs.org/openmrs-modules/feedback/ |
| 11:48:57 | <OpenMRSBot> <http://ln-s.net/90Sx> (at svn.openmrs.org) |
| 11:48:59 | <bryq> rafa: Yes, every handler seems to have types map |
| 11:49:11 | <rafa> bryq: try to use eclipse refactoring tools :) it should be a few clicks only |
| 11:49:22 | <rahul> dkayiwa:http://pastebin.com/5BEGRFLK |
| 11:49:53 | <rafa> bryq: look for extract superclass |
| 11:51:01 | <bryq> rafa: I've never did it before. I'll try to use eclipse refactoring tools. Thanks for the tip :) |
| 11:51:11 | <dkayiwa> rahu: which line number? |
| 11:51:16 | <dkayiwa> rahul |
| 11:51:34 | <dkayiwa> gauravpaliwal1: let me check it out |
| 11:51:38 | *** bwolfe has joined #openmrs |
| 11:51:38 | *** ChanServ sets mode: +o bwolfe |
| 11:51:43 | <gauravpaliwal1> dkayiwa: thanks :) |
| 11:52:02 | <rahul> dkayiwa:16 |
| 11:52:08 | <rahul> dkayiwa : line 16 |
| 11:54:17 | <magoo> ?? |
| 11:55:38 | <rahul> dkayiwa : der? |
| 11:55:54 | <dkayiwa> rahul: thinking... |
| 11:56:17 | <rahul> okay :) |
| 11:59:04 | <magoo> dkayiwa what is jetty? |
| 11:59:25 | <dkayiwa> magoo: you can try google. :) |
| 12:00:33 | <magoo> i have tried google can i get the plugin |
| 12:00:56 | <dkayiwa> rahul: can i look at the entire class instead of just this method? |
| 12:01:42 | <rahul> yaa okay |
| 12:02:13 | <gauravpaliwal1> bwolfe: hi |
| 12:02:22 | <bwolfe> yo |
| 12:03:07 | <gauravpaliwal1> bwolfe: what could be the change to these lines from wiki https://wiki.openmrs.org/display/docs/Module+Unit+Testing after the mavenization ""org.openmrs.api.APIException: Service not found: class org.openmrs.module. First, make sure that you have run the package module Ant target. Secondly, make sure your test class extendsBaseModuleContextSensitiveTest. Second, make sure your "build" folder was on the .classpath so that Eclipse knows about you |
| 12:03:08 | <OpenMRSBot> <http://ln-s.net/90Rl> (at wiki.openmrs.org) |
| 12:03:52 | <bwolfe> gauravpaliwal1, when I see that with a mavenized module I do a clean build with both maven and eclipse |
| 12:04:07 | <rahul> dkayiwa : http://pastebin.com/673AA5nL line number 268 |
| 12:06:14 | <rahul> dkayiwa : did u get ?? |
| 12:06:24 | <dkayiwa> yes |
| 12:06:56 | <rahul> dkayiwa : okay did u get solution ? |
| 12:07:04 | <dkayiwa> not yet |
| 12:07:59 | <gauravpaliwal1> bwolfe: see this left side of the photo dependencies : http://twitpic.com/5tg6lu/full isn't that I need to have the feedback-api.jsr for testing ? |
| 12:08:09 | <rahul> dkayiwa:when i am calling that method second time with different patient list the error is coming |
| 12:10:30 | <bwolfe> gauravpaliwal1, not sure. whats your one nonclasspath dependency? |
| 12:10:30 | <bwolfe> and why is testng in there? |
| 12:10:30 | <bwolfe> and derbyclient? |
| 12:10:30 | <bwolfe> and poi? |
| 12:10:31 | <bwolfe> and what is snakeyaml? |
| 12:10:32 | <bwolfe> or logkit? |
| 12:10:33 | <bwolfe> jtds? |
| 12:10:37 | <bwolfe> freemarker?! |
| 12:10:41 | <bwolfe> bsh? |
| 12:10:42 | <bwolfe> avalon? |
| 12:10:45 | <dkayiwa> rahul: can u also pastebin the entire stack trace |
| 12:10:50 | <bwolfe> there are a lot of things that look weird... |
| 12:11:23 | <gauravpaliwal1> bwolfe: openmrs-api-1.8.0-alpha-tests.jar |
| 12:11:45 | <bwolfe> postgresql?? |
| 12:11:46 | <bwolfe> what about it? |
| 12:11:53 | <bwolfe> oh, thats the nonclasspath one? |
| 12:12:04 | <gauravpaliwal1> bwolfe: yes |
| 12:12:22 | <rahul> dkayiwa : http://pastebin.com/Q4H4MLJK |
| 12:12:39 | <rahul> dkayiwa : it is stack trace |
| 12:13:12 | <gauravpaliwal1> bwolfe: those came free when in netbeans i try testing , tried using eclipse but came back to netbeans because their are manhy other error comming there |
| 12:13:54 | <gauravpaliwal1> bwolfe: these unnatural things are because of this : http://pastebin.com/LEq37v7q |
| 12:14:07 | <rahul> dkayiwa : got it ? |
| 12:16:10 | *** bwolfe has quit IRC |
| 12:17:47 | <dkayiwa> yes rahul |
| 12:18:06 | <rahul> dkayiwa : did u get the solution :) ? |
| 12:18:32 | <dkayiwa> now looking into it rahul :) |
| 12:18:46 | *** bwolfe_ has joined #openmrs |
| 12:18:46 | *** ChanServ sets mode: +o bwolfe_ |
| 12:18:48 | <rahul> okay :) |
| 12:19:01 | * bwolfe_ really dislikes his ISP right now... |
| 12:19:05 | *** bwolfe_ is now known as bwolfe |
| 12:20:50 | <gauravpaliwal1> bwolfe: isp is everywhere a problem but atleast you can open all websites, in india the new dot regulation says mediafire like things will be blocked .:( |
| 12:21:49 | <bwolfe> that sucks |
| 12:23:51 | <dkayiwa> ragul: which version of the openmrs api are you using? |
| 12:24:48 | *** wyclif has quit IRC |
| 12:26:16 | *** bwolfe_ has joined #openmrs |
| 12:26:16 | *** ChanServ sets mode: +o bwolfe_ |
| 12:26:45 | <rahul> dkayiwa : 1.9 version |
| 12:29:11 | <dkayiwa> ok |
| 12:29:42 | *** bwolfe has quit IRC |
| 12:30:25 | *** bwolfe_ is now known as bwolfe |
| 12:30:58 | *** downeym has joined #openmrs |
| 12:30:58 | *** ChanServ sets mode: +o downeym |
| 12:30:58 | *** OpenMRSBot sets mode: +o downeym |
| 12:34:22 | <gauravpaliwal1> dkayiwa: have you tested it ? |
| 12:34:35 | <dkayiwa> not yet. but about to |
| 12:35:32 | *** rahul has quit IRC |
| 12:36:58 | <goutham> hi any one familiar with velocity templates? |
| 12:38:35 | <goutham> bwolfe: ? djazayeri ? dkayiwa ? :) |
| 12:39:08 | <dkayiwa> :) |
| 12:39:13 | <bwolfe> I have used them before. what are you needing to do? |
| 12:40:08 | <goutham> case is i need to spilt a property in my project and use it... so |
| 12:41:21 | <goutham> #set($temp = $moduleDependant.split(":")) |
| 12:41:39 | <bwolfe> is split a valid function? |
| 12:41:55 | <goutham> yes... |
| 12:42:10 | <bwolfe> I thought you could on do functions like: $nameoffunctionclass.split(moduleDependent, ":") |
| 12:43:27 | *** gbastien has joined #openmrs |
| 12:45:12 | <goutham> hum , as foreach , split is also a predefined function |
| 12:46:25 | <bwolfe> ok |
| 12:46:32 | <bwolfe> not sure i've used it... |
| 12:46:38 | <bwolfe> whats their documentation say about example usage? |
| 12:46:51 | <bwolfe> you're not using split htere like you would a foreach... |
| 12:48:08 | <magoo> still getting problems with maven plugin installation |
| 12:48:56 | <gauravpaliwal1> magoo: what error ? |
| 12:49:43 | <magoo> not errors its like i have failed to get the svn |
| 12:49:44 | <goutham> bwolfe: in documentation they told to use $varable.get(index) but i am not getting the values |
| 12:50:46 | <bwolfe> goutham, can you link me to the docs you're looking at? |
| 12:52:04 | <gauravpaliwal1> magoo: what you want to do using eclipse , if you wanted to some edit then you can also go for netbeans/eclipse that will have both plugins builtin |
| 12:52:59 | <magoo> using the netbeans development environment |
| 12:53:09 | <goutham> bwolfe: http://old.nabble.com/Use-of-split%28%29-td19466296.html#a19466296 , http://wiki.apache.org/jakarta-velocity/ListTool |
| 12:53:18 | <OpenMRSBot> <http://ln-s.net/90Tj> (at old.nabble.com) |
| 12:54:05 | <gauravpaliwal1> magoo: okey, they you can open the project directly i think |
| 12:54:27 | <goutham> bwolfe: i am collectively looking all of them :) |
| 12:54:33 | <magoo> using eclipse or netbeans |
| 12:55:23 | <bwolfe> goutham, split isn't in ListTool that I see |
| 12:55:43 | <bwolfe> the main velocity home site used to have a pretty good doc around their tags |
| 12:57:29 | <goutham> bwolfe: i dint find any thing related to wat i want.. i will have look at velocity main page again :) |
| 13:14:00 | <magoo> i was trying to import the maven plugin into eclipse and i got the following massage: Repository has been moved svn: Repository moved permanently to 'http://m2eclipse.sonatype.org/sites/m2e/0.12.1.20110112-1712/plugins/'; please relocate |
| 13:14:03 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: One hour until weekly #OpenMRS developer meeting - join us to learn about a new PHR system and more: http://bit.ly/ouUhzg #ICT4D #eHealth <http://twitter.com/OpenMRS/statuses/94028893719240704> |
| 13:17:04 | *** wyclif has joined #openmrs |
| 13:17:22 | <gauravpaliwal1> magoo: that was the main reason why i use netbeans |
| 13:18:54 | <magoo> guaravpaliwal1: you mean i should forget about eclipse i have netbeans 7.0 does it have the plugin installed |
| 13:22:43 | <gauravpaliwal1> magoo: netbeans have the plugin installed but I face a lot of problem using netbeans especially testing |
| 13:24:34 | <magoo> guaravpaliwal1: okay so let me fight with eclipse possibly i will be able to get the plugins installed |
| 13:29:01 | *** gbastien has quit IRC |
| 13:29:31 | *** Yekkanti has joined #openmrs |
| 13:31:30 | <Yekkanti> Hi, all the *FormControllerTest seems to hit the Service and eventually DAO. Any reason why we are not mocking the other layers during unit testing? |
| 13:31:40 | <gauravpaliwal1> dkayiwa: any clue ? |
| 13:32:26 | <dkayiwa> gauravpaliwal1: now on it :) |
| 13:35:24 | <gauravpaliwal1> dkayiwa: :) |
| 13:41:51 | <dkayiwa> gauravpaliwal1 what is the name of the test class? |
| 13:43:10 | <gauravpaliwal1> dkayiwa: AddPredefinedSubjectControllerTest.java |
| 13:43:36 | <dkayiwa> ok |
| 13:48:42 | <wyclif> djazayeri, , bwolfe , do you know why logic can't start? |
| 13:48:58 | <bwolfe> could be several reasons |
| 13:49:06 | <bwolfe> when/where/how ? |
| 13:49:09 | <bwolfe> stacktrace? |
| 13:50:34 | *** gbastien has joined #openmrs |
| 13:50:37 | <wyclif> latest from project |
| 13:51:16 | <bwolfe> from ui2? |
| 13:51:18 | <bwolfe> or trunk? |
| 13:51:22 | <bwolfe> or some other branch? |
| 13:51:35 | <bwolfe> you're being awfully cagey... |
| 13:53:24 | *** r0friedman has joined #openmrs |
| 13:53:34 | *** r0friedman is now known as r-friedman |
| 13:56:05 | *** markolonius has joined #openmrs |
| 13:56:18 | <downeym> Hi markolonius and welcome to the #openmrs IRC channel. |
| 13:56:26 | <markolonius> hi all! |
| 13:57:39 | <markolonius> i'm currently in Maxixe, Mozambique in Africa and was wondering if there was a torrent available of standalone openmrs? the city's internet seems to be at a crawl receiently and i'm having much trouble downloading it lol |
| 14:01:16 | <bwolfe> markolonius, are you getting it from sourceforge? |
| 14:01:30 | <bwolfe> !devmtg |
| 14:01:31 | <OpenMRSBot> bwolfe: "devmtg" --- Reminder: Developer meeting Thursday at 10:00 AM Eastern - http://wiki.openmrs.org/display/docs/Weekly+Developer+Meeting |
| 14:02:52 | <dkayiwa> gauravpaliwal1: does your maven install run without errors? |
| 14:03:31 | <gauravpaliwal1> yes |
| 14:03:41 | <gauravpaliwal1> but error come on testing |
| 14:03:46 | <gauravpaliwal1> dkayiwa: i mean no |
| 14:03:54 | <gauravpaliwal1> I have to skip testing for install |
| 14:03:55 | <markolonius> bwolfe: yes. speed keeps going down to around 5KB/s any internet place I know :\ |
| 14:04:04 | <markolonius> Kinda wish i could pause |
| 14:04:04 | <dkayiwa> ok |
| 14:04:11 | <bwolfe> markolonius, boo |
| 14:04:18 | <markolonius> super lame i know |
| 14:04:26 | <bwolfe> ping downeym, can you start a torrent for the standalone ? |
| 14:04:55 | <bwolfe> I'd gladly seed my overnight bandwidth...it gets up to at least 50k upload ;-) |
| 14:05:26 | <markolonius> lol thats superior speeds haha |
| 14:06:11 | <markolonius> my problem is if i stay here and download once it gets dark i wont be able to get to where i'm staying.. which is long walk in the dark lol |
| 14:06:20 | <gauravpaliwal1> bwolfe: 50 kbps is cool |
| 14:06:42 | <bwolfe> not what I'm used to though ;-) |
| 14:07:13 | <bwolfe> I get a max of 200kpbs down and 50 or so up. ...and I have to pay about $40 a month for it |
| 14:07:14 | <gauravpaliwal1> bwolfe: US is a super *bandwidth* rich country |
| 14:07:15 | <downeym> bwolfe: we just need to get you a private vsat :) |
| 14:07:16 | <bwolfe> 40 UDS |
| 14:07:30 | <bwolfe> gauravpaliwal1, this is in kenya, not the us |
| 14:07:30 | <gauravpaliwal1> UDS = $ ? |
| 14:07:37 | <bwolfe> err, USD |
| 14:07:46 | <markolonius> I had 100kbs the other week. then got disconnected at the last megabyte of the standalone lol |
| 14:08:00 | <markolonius> ever since then internet wherever i go is at 5kbs |
| 14:08:21 | <bwolfe> markolonius, there are browser plugins or download programs that will let you resume |
| 14:08:29 | <bwolfe> and actually firefox might let you do it natively |
| 14:08:31 | <markolonius> hmm |
| 14:08:42 | <markolonius> it says i can pause in firefox but whe i do it never resumes |
| 14:08:46 | <gauravpaliwal1> markolonius: download them all for firefox is good |
| 14:09:00 | <markolonius> hmm okie i'll try that out |
| 14:09:06 | <gauravpaliwal1> bwolfe: USD 40 is too much |
| 14:09:23 | <bwolfe> heh, its the cheapest for kenya for those speeds! |
| 14:10:05 | <gauravpaliwal1> bwolfe: i get 384kbps for $16 |
| 14:10:13 | <gauravpaliwal1> bwolfe: that is per month |
| 14:10:13 | <markolonius> :0 |
| 14:10:14 | <markolonius> where |
| 14:10:23 | *** bryq has quit IRC |
| 14:10:29 | <gauravpaliwal1> markolonius: http://www.downthemall.net/ is a good firefox plugin for resume download |
| 14:10:36 | <gauravpaliwal1> markolonius: india |
| 14:10:51 | <bwolfe> actually, thats a lie. its the cheapest for eldoret. a big swath of nairobi has a direct fiber connection. 8MBps for 30USD |
| 14:11:02 | <markolonius> oh, yeah india's telecommunications have excelled much more than africa these past years |
| 14:11:15 | <bwolfe> gauravpaliwal1, yeah, my plan is technically a 512kbps...I just never hit that |
| 14:11:31 | <djazayeri> Yekkanti: *FormControllerTest are effectively integration tests |
| 14:11:52 | <gauravpaliwal1> bwolfe: i get 50kbps in that 384kbps |
| 14:12:19 | <markolonius> bwolfe its nice to hear someeone that can relate speeds with me haha |
| 14:12:21 | <Yekkanti> djazayeri: so we will write only integration tests for controllers. am i right? |
| 14:12:46 | <bwolfe> markolonius, dkayiwa is in uganda...and has it worse off than me! |
| 14:12:48 | <gauravpaliwal1> although Govt. plan give 1mbps for $16 , but i can't rely on that |
| 14:13:06 | <bwolfe> Yekkanti, technically all of our tests are integration tests |
| 14:13:11 | <dkayiwa> hahahahahahaha |
| 14:13:13 | <markolonius> eh |
| 14:13:17 | <djazayeri> Yekkanti: Typically they'll just use the service layer with the known standard test dataset, so the effect is equivalent to having a mocked service/dao layer. (It's slower, but on the bright side any strange hibernate behavior "really happens") |
| 14:13:17 | <dkayiwa> :D |
| 14:13:42 | <markolonius> bwolfe: yeah my program's manager is from there. its pretty bad haha. |
| 14:14:50 | <djazayeri> Yekkanti: part of it is that for lack of resources. It's just quicker to write tests against a standard test dataset, than to mock everything. |
| 14:14:52 | <markolonius> i thought mozambique would be ok, but its very rare to have internet here. i got lucky and met some people. so i'm currently sitting in the basement office of a big hotel lol |
| 14:15:01 | <gauravpaliwal1> bwolfe: I am still strucked at that testing |
| 14:15:21 | <Yekkanti> djazayeri: If i want to have a test with complex dataset, I assume, that we need to insert the data in the controller tests and use it |
| 14:15:38 | <bwolfe> gauravpaliwal1, is your code committed? can I update and see it? |
| 14:15:39 | <djazayeri> You can manually run an additional dataset. |
| 14:16:01 | <gauravpaliwal1> bwolfe: should i leave testing for several days and move to something else and then come back ? may be I can understand the error later :( |
| 14:16:15 | <bwolfe> gauravpaliwal1, actually, you might want to change from alpha to snapshot |
| 14:16:24 | <bwolfe> and then do a full build on your 1.8.x branch |
| 14:16:24 | <gauravpaliwal1> bwolfe: git : https://github.com/gauravpaliwal/General-Feedback-Module-OpenMRS/ svn : http://svn.openmrs.org/openmrs-modules/feedback/ |
| 14:16:30 | <OpenMRSBot> <http://ln-s.net/90U_> (at github.com) |
| 14:16:38 | <r-friedman> bwolfe: can't hear this speaker |
| 14:16:42 | <Yekkanti> djazayeri: I see controller tests are extending BaseWebContextSensitiveTest instead of BaseContextSensitiveTest and executing the dataset is part of BaseContextSensitiveTest |
| 14:17:00 | <gauravpaliwal1> bwolfe: how can i do that edit the pom.xml ? |
| 14:17:05 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): TRUNK-2430 - fixed legacy theme userBar so it flows with the page <http://feedproxy.google.com/~r/OMRStrunk/~3/fCesQ7GosJY/OpenMRS> |
| 14:17:21 | <gauravpaliwal1> bwolfe: git : https://github.com/gauravpaliwal/General-Feedback-Module-OpenMRS/ svn : http://svn.openmrs.org/openmrs-modules/feedback/ |
| 14:17:21 | <OpenMRSBot> <http://ln-s.net/90Sx> (at svn.openmrs.org) |
| 14:17:45 | <djazayeri> Yekkanti: you automaticlaly get the standard dataset (unless you do @SkipBaseSetup), but you can also add additional data sets. See EncounterServiceTest for an example. |
| 14:19:01 | <Yekkanti> djazayeri: Yeah! as it is a service test executeDataset() method is accessible to it but for the controllers it will not be accessible as they extend different context |
| 14:19:27 | <djazayeri> Doesn't the web test one extends the service test one? |
| 14:20:00 | <Yekkanti> djazayeri: :( yeah they do i missed it! |
| 14:20:52 | <Yekkanti> djazayeri: Thanks for the info :) |
| 14:20:57 | *** markolonius has quit IRC |
| 14:22:01 | <gauravpaliwal1> bwolfe: moved to 1.8.0-SNAPSHOT :) |
| 14:23:05 | <bwolfe> and it still fails gauravpaliwal1? |
| 14:23:25 | <gauravpaliwal1> bwolfe: yes :(:( |
| 14:23:37 | <gauravpaliwal1> :'( |
| 14:23:57 | *** rahul has joined #openmrs |
| 14:23:58 | <bwolfe> gauravpaliwal1, was this after doing a full compile on yoru 1.8.x branch? a "mvn clean install" on the root (don't skip tests) |
| 14:24:12 | <downeym> Hi rahul and welcome to the #openmrs IRC channel. |
| 14:25:00 | <gauravpaliwal1> bwolfe: yes |
| 14:25:12 | <gauravpaliwal1> bwolfe: full compile verything |
| 14:25:38 | <rahul> dkayiwa : did u get the solution :) ? |
| 14:26:15 | <dkayiwa> rahul: not yet. it is a tricky problem. :) |
| 14:26:23 | <bwolfe> djazayeri, oh c'mon, that "user saved" is super helpful |
| 14:26:33 | <bwolfe> "save user" on the page right before that should be changed too |
| 14:27:14 | <rahul> dkayiwa : okay i am waiting for your reply :) |
| 14:27:44 | *** goutham has quit IRC |
| 14:27:58 | <dkayiwa> rahul: are you committing this somewhere? i could check out and see. |
| 14:28:04 | <djazayeri> Yekkanti: do you remember the ticket number that you're waiting my code review on? |
| 14:28:39 | *** jwishnie has joined #openmrs |
| 14:28:44 | <Yekkanti> djazayeri: 2257 and 2258 |
| 14:28:55 | <rahul> dkayiwa : no i guess .... |
| 14:29:37 | <dkayiwa> rahul: why? |
| 14:30:47 | <rahul> dkayiwa : i have seen same problem in the OpenMRS Mailing List Archives |
| 14:30:48 | <rahul> http://openmrs-mailing-list-archives.1560443.n2.nabble.com/lazy-initialization-error-with-hibernate-td6310379.html |
| 14:30:55 | <OpenMRSBot> <http://ln-s.net/90Ue> (at openmrs-mailing-list-archives.1560443.n2.nabble.com) |
| 14:31:02 | <gauravpaliwal1> bwolfe: whenever you are free please look at the source . |
| 14:31:36 | <dkayiwa> rahul: yes |
| 14:32:05 | <rahul> but i din't get the solution from it ... do find anything |
| 14:32:12 | <rahul> dkayiwa : |
| 14:32:56 | <downeym> !ticket TRUNK-2305 |
| 14:32:57 | <OpenMRSBot> downeym: [#TRUNK-2305] Default locale doesnt work right when creating new users - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2305 |
| 14:33:27 | <dkayiwa> rahul: i read it all too but never found. i suspect that it could be something somewhere in your project that could be causing the second call to be run outside the default transactional session. That is why i wanted to look at your entire code. |
| 14:36:15 | <rahul> ohh ... i have not updated to svn yet |
| 14:36:39 | <dkayiwa> rahul: is it possible for you to commit? |
| 14:38:06 | *** edcable has joined #openmrs |
| 14:38:10 | <rahul> now its not possible becoz its in another system and i will inform when i have updated to svn :) |
| 14:38:15 | <downeym> Hi edcable and welcome to the #openmrs IRC channel. |
| 14:38:38 | <edcable> Thanks downeym! Listening in :) |
| 14:38:54 | <downeym> edcable: fantastic :) http://connect.openmrs.org/ |
| 14:39:19 | <rahul> dkayiwa : now its not possible becoz its in another system and i will inform when i have updated to svn :) |
| 14:41:03 | <dkayiwa> rahul: don't they allow you to commit it for the public to see? |
| 14:43:23 | <rahul> ya they allow but i didn't update it ... my module in svn has older code |
| 14:46:02 | <wyclif> djazayeri, can i get rid of one of the web constants files |
| 14:46:32 | <djazayeri> Because there's one in org.openmrs.web, and another in org.openmrs.ui2? |
| 14:46:43 | <wyclif> correct |
| 14:46:58 | <djazayeri> I think we may need to keep the old one for 1.x compatibility |
| 14:47:01 | <djazayeri> not certain |
| 14:47:26 | <djazayeri> By the way, you were asking about the context path. I noticed that there's actually WebConstants.CONTEXT_PATH (in the ui2 one) |
| 14:47:36 | <wyclif> then i guess we get rid of the new one and copy over the new constants it defines |
| 14:47:42 | <djazayeri> no |
| 14:47:46 | <rafa> djazayeri: How to add js to a dialog page? |
| 14:47:59 | <wyclif> why not? |
| 14:48:08 | <rafa> djazayeri: I found PageContext and javascriptToInclude |
| 14:48:15 | <djazayeri> wyclif: you should be able to build and run the whole application _without_ 1.x compatibility |
| 14:48:33 | <rafa> djazayeri: but I'm stuck there |
| 14:49:10 | <djazayeri> rafa: something like "ui.includeJs"? |
| 14:49:19 | <djazayeri> (i.e. you'd do that via UiUtils) |
| 14:49:32 | <rafa> djazayeri: I guess I need to add it for all pages toastmessage is missing |
| 14:50:06 | <wyclif> my point is that since these are only constants,then there has to be a way of moving them over to a central location and update references to the moved constants |
| 14:50:19 | <rafa> djazayeri: the dialog box is in iframe and there's no toastmessage included |
| 14:50:32 | <djazayeri> rafa: ah, interesting |
| 14:50:56 | <djazayeri> wyclif: I'm assuming that the constants in the two files won't overlap too much |
| 14:51:02 | <djazayeri> wyclif: what examples? |
| 14:51:26 | <wyclif> WEBAPP_NAME |
| 14:51:28 | *** edcable has quit IRC |
| 14:51:39 | <wyclif> time stamp |
| 14:51:45 | *** edcable has joined #openmrs |
| 14:51:50 | <wyclif> application data directory |
| 14:52:23 | <djazayeri> rafa: do the dialogs use a minimal page wrapper? |
| 14:52:32 | <djazayeri> i.e. most pages use standardPage as a decorator |
| 14:52:39 | <rafa> I can't say ;) |
| 14:52:48 | <rafa> they don't use standardPage for sure |
| 14:52:54 | <rafa> that I can say |
| 14:53:01 | <rafa> where can I find the minimal page? |
| 14:53:03 | <djazayeri> right, maybe they should use a "minimalPage" or something |
| 14:53:09 | <djazayeri> I don't remember if I created one or not |
| 14:53:22 | <djazayeri> look in the directory that has standardPage, and see if there's a minimalPage there too |
| 14:53:36 | <rafa> nope |
| 14:54:20 | <rafa> What is the other way it can be produced? |
| 14:55:33 | *** Yekkanti has quit IRC |
| 14:55:43 | <djazayeri> rafa: is "dialog" a fragment? I forget |
| 14:56:11 | <djazayeri> or is it the thing accessible from the javascript in openmrs.js? |
| 14:56:20 | <rafa> djazayeri: thanks for the hint! |
| 14:56:24 | <rafa> djazayeri: it's a fragment |
| 14:56:25 | <rafa> got it |
| 14:56:34 | <rafa> dialogSupport.gsp |
| 14:56:58 | <djazayeri> yeah, but that might not have the iframe |
| 14:57:32 | <rafa> It doesn't have, but it declares some includeJs |
| 14:57:36 | <rafa> I'll try here |
| 14:58:18 | <djazayeri> rafa: if not, look in openmrs.js for the part where it creates an iframe |
| 14:58:43 | <djazayeri> It does this via DOM. I forget why. And that whole section needs to be refactored significantly. |
| 14:58:53 | <djazayeri> you could include some js there |
| 14:58:57 | <rafa> djazayeri: ok |
| 15:01:15 | <djazayeri> wyclif: I think we should get rid of the unused constants in the ui2 version of WebConstants |
| 15:01:33 | <djazayeri> e.g. things like INIT_REQ_UNIQUE_ID |
| 15:02:41 | <gauravpaliwal1> dkayiwa: any solution ? |
| 15:03:03 | <dkayiwa> gauravpaliwal1 not yet |
| 15:03:40 | <djazayeri> wyclif: anything that has to be duplicated should be primarily defined in the ui2 version, and the one in the 1x version can say CONSTANT = org.openmrs.ui2.core.WebConstants.CONSTANT |
| 15:03:50 | *** pascal` has quit IRC |
| 15:05:09 | <djazayeri> wyclif: you checked in code for TRUNK-2079, but didn't put it in Code Review state |
| 15:05:11 | <djazayeri> is that intentional? |
| 15:07:20 | *** magoo has quit IRC |
| 15:07:24 | *** rahul has quit IRC |
| 15:07:25 | <downeym> !ticket TRUNK-2079 |
| 15:07:26 | <OpenMRSBot> downeym: [#TRUNK-2079] Incorporate liquibase updates and the initialization wizard into the 2.x web application - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2079 |
| 15:07:32 | <wyclif> i intended it since i actually ony added new files with no changes in the code |
| 15:07:59 | <djazayeri> Is the ticket "done"? |
| 15:08:17 | <wyclif> the only concern was the location in i inserted which i assumed you comment on from the ticket by looking at the changesest |
| 15:08:31 | <wyclif> but i can craete reviews if you want me to |
| 15:08:47 | <djazayeri> my point is that I base my workflow (during a sprint) around the sprint dashboard |
| 15:08:56 | <djazayeri> so if the ticket isn't in a Review state, I'm more likely to miss it. |
| 15:08:58 | <wyclif> am yet to commit the changes |
| 15:09:12 | <djazayeri> I can review from the changeset |
| 15:09:13 | <djazayeri> no need |
| 15:09:32 | <wyclif> sorry, i maent i can create the reviews |
| 15:13:14 | *** edcable has quit IRC |
| 15:13:43 | *** edcable has joined #openmrs |
| 15:16:03 | *** magoo has joined #openmrs |
| 15:17:32 | *** edcable has quit IRC |
| 15:21:03 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Allergies and Problem <http://forum.openmrs.org/viewtopic.php?f=8&t=800#p3026> |
| 15:21:08 | <rafa> djazayeri: Darius it's not that easy :/ |
| 15:21:27 | <rafa> djazayeri: I've noticed that the page is generated from GroovyPageView |
| 15:21:42 | <rafa> djazayeri: Do you know of any template it might use? |
| 15:21:57 | <djazayeri> rafa: leading call conversation now |
| 15:22:12 | <rafa> djazayeri: sorry ;) |
| 15:22:27 | *** edcable has joined #openmrs |
| 15:32:48 | <rafa> djazayeri: ok got it! |
| 15:33:06 | <rafa> djazayeri: it's in fragment.gsp ;) |
| 15:33:47 | <gauravpaliwal1> dkayiwa: problem solved looks like difference lies in BaseModuleWebContextSensitiveTest VS BaseModuleContextSensitiveTest this working : http://pastebin.com/5wcGCK9s this isn't http://bit.ly/qd3Pzh /cc: bwolfe |
| 15:34:02 | <dkayiwa> oh |
| 15:34:02 | <djazayeri> rafa: is that the page that lets you include just one fragment? |
| 15:34:30 | <bwolfe> gauravpaliwal1, ah ha! |
| 15:34:30 | <rafa> djazayeri: I'm not sure what you meant |
| 15:34:40 | <bwolfe> can you document the error message and the solution ont he wiki somewhere? |
| 15:35:03 | *** deadpool has joined #openmrs |
| 15:35:20 | <djazayeri> rafa: fragment.gsp is in /pages, right? |
| 15:35:34 | <rafa> right |
| 15:41:29 | <djazayeri> (that's what I meant) |
| 15:44:37 | *** vchircu has joined #openmrs |
| 15:46:53 | <vchircu> hey guys...I have a couple of questions |
| 15:47:14 | <bwolfe> vchircu, you're only allowed one per day |
| 15:47:33 | <vchircu> :)) |
| 15:47:34 | <djazayeri> good thing he didn't ask if he could ask a question then. :-) |
| 15:47:50 | <vchircu> that could have been akward |
| 15:48:01 | <vchircu> how are you guys doing ? |
| 15:48:06 | <vchircu> oh...snap |
| 15:48:42 | <vchircu> How can I get the implementation version (eg: 1.8.1) and the DB provider (eg: MySQL 5.0.27) |
| 15:48:43 | <vchircu> ? |
| 15:55:06 | <bwolfe> OpenmrsConstants.OPENMRS_VERSION |
| 15:55:23 | <bwolfe> db provider? I think you have to get that from hibernate. not sure theres an api method for it |
| 15:57:49 | *** gauravpaliwal1 has quit IRC |
| 15:57:54 | <vchircu> ok, thanks..I'll look into that |
| 16:04:07 | *** edcable has quit IRC |
| 16:04:56 | *** djazayeri has left #openmrs |
| 16:08:21 | *** bwolfe has quit IRC |
| 16:09:39 | *** muthah has joined #openmrs |
| 16:15:40 | *** pascal` has joined #openmrs |
| 16:17:42 | *** mandric has joined #openmrs |
| 16:24:25 | *** djazayeri has joined #openmrs |
| 16:24:25 | *** ChanServ sets mode: +o djazayeri |
| 16:24:28 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Allergies and Problem <http://forum.openmrs.org/viewtopic.php?f=8&t=800#p3027> |
| 16:33:20 | *** edcable has joined #openmrs |
| 16:34:28 | *** dkayiwa has quit IRC |
| 16:48:00 | *** pascal` has quit IRC |
| 16:59:45 | *** lh has joined #openmrs |
| 17:00:25 | *** pascal` has joined #openmrs |
| 17:02:07 | *** gauravpaliwal has joined #openmrs |
| 17:02:07 | *** ChanServ sets mode: +v gauravpaliwal |
| 17:03:18 | *** rafa has quit IRC |
| 17:04:53 | *** r-friedman has quit IRC |
| 17:10:11 | *** gauravpaliwal has left #openmrs |
| 17:14:03 | *** Suranga has joined #openmrs |
| 17:17:08 | *** magoo has quit IRC |
| 17:21:32 | *** vchircu has quit IRC |
| 17:29:12 | *** rafa has joined #openmrs |
| 17:29:12 | *** ChanServ sets mode: +v rafa |
| 17:36:26 | <Suranga> djazayeri, howdy, r u around ? |
| 17:37:04 | <djazayeri> yes, I just pressed send on an email to you |
| 17:37:18 | *** mandric has quit IRC |
| 17:39:01 | <Suranga> djazayeri, oh, i didnt see it, let me check it out... |
| 17:39:50 | <Suranga> djazayeri, i ment to ask, remember u suggested a page reload solution to a problem i was facing a while back ? |
| 17:39:50 | <Suranga> djazayeri, ive implimented that.. |
| 17:40:39 | <Suranga> djazayeri, i was wondering if i could add you for a review on my implimentation :-) |
| 17:40:50 | *** vchircu has joined #openmrs |
| 17:41:14 | <djazayeri> sure, i can't promise to look at it quickly |
| 17:41:28 | <djazayeri> but don't hesitate to add me to any reviews related to attributes |
| 17:41:33 | <djazayeri> and handlers |
| 17:41:55 | *** Suranga_ has joined #openmrs |
| 17:42:42 | <djazayeri> Suranga: that particular sort of thing is particularly helpful to have screenshots of |
| 17:42:58 | <djazayeri> because code reviewing jsp is nearly impossible |
| 17:43:43 | <Suranga_> djazayeri, ah, so i should provide u with snapshots as well... |
| 17:43:56 | <Suranga_> djazayeri, will do |
| 17:44:04 | <djazayeri> yes, put some screenshots on the ticket |
| 17:44:05 | <Suranga_> djazayeri, ill send some time tomorrow ? :-) |
| 17:44:28 | <djazayeri> okay |
| 17:44:31 | <Suranga_> djazayeri, thanks for the reply, your mails are very very detailed... |
| 17:45:02 | *** Suranga has quit IRC |
| 17:48:41 | *** downeym has quit IRC |
| 17:49:24 | *** downeym has joined #openmrs |
| 17:49:24 | *** ChanServ sets mode: +o downeym |
| 17:49:24 | *** OpenMRSBot sets mode: +o downeym |
| 17:50:40 | *** jwishnie has quit IRC |
| 17:52:19 | *** magoo has joined #openmrs |
| 17:55:01 | *** gbastien has quit IRC |
| 18:03:22 | *** jwishnie has joined #openmrs |
| 18:10:18 | *** vchircu has quit IRC |
| 18:15:54 | *** Suranga_ has quit IRC |
| 18:18:10 | *** edcable has quit IRC |
| 18:24:41 | *** Echidna has quit IRC |
| 18:24:45 | *** bryq has joined #openmrs |
| 18:24:45 | *** ChanServ sets mode: +v bryq |
| 18:28:20 | *** edcable has joined #openmrs |
| 18:30:17 | *** Echidna has joined #openmrs |
| 18:30:17 | *** ChanServ sets mode: +v Echidna |
| 18:30:58 | *** bwolfe has joined #openmrs |
| 18:30:58 | *** ChanServ sets mode: +o bwolfe |
| 18:31:23 | <rafa> djazayeri: I'm almost done with my tickets. Are there any high priority ones you want me to start with or just pick up some random ones? |
| 18:39:31 | <bwolfe> rafa, in general you can take any of the higher priority tickets. just go in order. :-) |
| 18:46:52 | <rafa> bwolfe: ok, I guess it's early enough to claim that we'll complete all of them ;) |
| 18:48:28 | *** jportela has quit IRC |
| 19:05:30 | <djazayeri> downeym: do you have the module repo download stats? |
| 19:05:39 | <djazayeri> are they available by module version? |
| 19:06:48 | <downeym> https://modules.openmrs.org/modules/stats.jsp ? |
| 19:06:51 | <djazayeri> rafa: yes, sorry, was on a call. I prioritize them. |
| 19:06:55 | <djazayeri> them = the tickets |
| 19:07:05 | <djazayeri> so pick a Should before a Could before a Non-Essential |
| 19:07:25 | <downeym> djazayeri: not sure what happened to the images... hm |
| 19:07:46 | <djazayeri> downeym: but is it possible to see that data broken down by module version? |
| 19:09:06 | <djazayeri> (this isn't particularly important, I'm just curious) |
| 19:09:55 | <djazayeri> or by moduleId, but aggregated monthly would be interesting |
| 19:21:39 | <downeym> djazayeri: ah, i'm not aware of any way to do so, unless bwolfe put a backdoor in there somewhere :) |
| 19:22:19 | <bwolfe> patches are welcome |
| 19:22:24 | <bwolfe> it just breaks it down by module id |
| 19:22:50 | <bwolfe> would be simple to get per module stats that do it by version |
| 19:23:35 | <djazayeri> Can I just write you a sql query to run? |
| 19:30:47 | *** james_regen has quit IRC |
| 19:34:56 | *** goutham has joined #openmrs |
| 19:37:36 | *** bryq has quit IRC |
| 19:38:41 | *** edcable has quit IRC |
| 19:50:05 | *** edcable has joined #openmrs |
| 19:50:31 | <downeym> djazayeri: i can run a script for you, sure |
| 19:50:44 | <downeym> sorry i missed your message |
| 19:50:55 | <djazayeri> Actually I was asking ben that. |
| 19:51:07 | <djazayeri> I don't actually know what the data model is, so I don't think this is worth the effort. |
| 19:51:59 | <djazayeri> I'm curious why Form Import Export has so many downloads. |
| 19:52:24 | <djazayeri> I'm curious why REST was the most-downloaded module last week. Hopefully not because people were getting that instead of the webservices.rest module. |
| 19:52:52 | <djazayeri> but knowing version numbers isn't going to help :-) |
| 19:53:30 | *** bryq has joined #openmrs |
| 19:53:30 | *** ChanServ sets mode: +v bryq |
| 19:53:32 | <bwolfe> I was 3 of those REST module downloads last week |
| 19:53:34 | <downeym> djazayeri: sending you a csv now |
| 19:53:46 | <bwolfe> and may have accounted for another 5 with people here at ampath for it |
| 19:54:22 | <djazayeri> downeym: while you're in there, can you check on the stats specifically for the webservices.rest module? |
| 19:54:34 | <djazayeri> Do we just know # of downloads? Or do we actually have IPs? |
| 19:54:40 | <djazayeri> or something? |
| 19:54:56 | <bwolfe> we have IPs of people that check for updates of modules |
| 19:55:01 | <downeym> 9 downloads |
| 19:55:11 | <bwolfe> (and maybe even which version of openmrs they're pinging from) |
| 19:55:18 | <downeym> djazayeri: we could probably crunch web logs |
| 19:55:32 | <downeym> djazayeri: nothing in place to do that though |
| 19:55:42 | <djazayeri> well, maybe someday |
| 19:55:56 | <downeym> the only downloads of webservices.rest were 9 between the 15th and the 21st |
| 19:55:58 | <djazayeri> Maybe I should check the stats for the bundled version |
| 19:56:13 | <bwolfe> https://modules.openmrs.org/modules/statisticsGraph.jsp?module=webservices.rest |
| 19:56:16 | <bwolfe> :-/ |
| 19:56:18 | <djazayeri> Since that's when we released it. :-) |
| 19:56:20 | <OpenMRSBot> <http://ln-s.net/90XX> (at modules.openmrs.org) |
| 19:56:21 | <bwolfe> no pics there either downeym |
| 19:56:28 | <downeym> bwolfe: yeah not sure what happened there |
| 19:56:38 | <downeym> https://modules.openmrs.org/modules/statisticsGraphServlet?show=module_downloaded_this_year&module=webservices.rest |
| 19:56:54 | <downeym> something wrong with JFreeChart maybe? |
| 19:58:04 | <bwolfe> yeah, perhaps |
| 20:03:54 | <djazayeri> downeym: that csv was cut off at 1000 rows |
| 20:04:07 | <djazayeri> hence it only goes to 2009 |
| 20:04:15 | <djazayeri> are you running db queries? |
| 20:04:29 | <downeym> djazayeri: ah sorry |
| 20:04:36 | <djazayeri> I can give you sql |
| 20:04:43 | <downeym> i did a limit |
| 20:05:10 | <djazayeri> select id, version, count(*) from TABLE group by id, version |
| 20:05:37 | <djazayeri> mysql database I assume? |
| 20:06:29 | <downeym> no timestamp? |
| 20:06:41 | <djazayeri> I have two queries |
| 20:06:46 | <djazayeri> the second one would be: |
| 20:07:27 | <djazayeri> select id, concat(month(timestamp), '-', year(timestamp)), count(*) from TABLE group by id, concat(month(timestamp), '-', year(timestamp)) |
| 20:08:13 | <djazayeri> (I don't need the raw data, just interested in two specific aggregations) |
| 20:08:27 | <djazayeri> downeym: (by time and by version) |
| 20:09:31 | <downeym> djazayeri: do you want all modules or just formimportexport? |
| 20:10:56 | <djazayeri> all, as long as you're doing the query |
| 20:12:18 | <djazayeri> It might require "the math" to figure out what is due to particular module usage, and what's due to overall increase in openmrs usage |
| 20:13:30 | <djazayeri> downeym: ^^ |
| 20:17:13 | <djazayeri> wyclif: you there? |
| 20:18:03 | <downeym> djazayeri: incoming |
| 20:19:14 | <wyclif> hi |
| 20:19:22 | <wyclif> hi djazayeri |
| 20:20:53 | <djazayeri> hi wyclif |
| 20:21:10 | <djazayeri> were my comments clear about the package structure of the wizards? |
| 20:21:10 | <wyclif> hi |
| 20:21:24 | <djazayeri> I think it's best to keep them consistent with what's in 1.x |
| 20:21:31 | <wyclif> i haven't yet read them |
| 20:21:41 | <wyclif> i have tried to keep them consistent |
| 20:21:42 | <djazayeri> for example so when the gsoc project is done we can just re-copy everything over |
| 20:22:01 | <djazayeri> so, I actually don't like the way we've organized them, but I think we should leave them as they are anyway. :-) |
| 20:22:07 | <wyclif> problem if the way the new project finds scripts and css |
| 20:22:26 | <djazayeri> hmm, what's the problemâ¦it doesn't find them? |
| 20:22:53 | <djazayeri> can we just move them to where the 2.x application expects them? |
| 20:23:22 | <rafa> djazayeri: I wasn't able to use jquery.form for the ajax upload. |
| 20:23:44 | <rafa> djazayeri: How much do we want this functionality? |
| 20:23:47 | <djazayeri> rafa: I just did an svn update and was going to look at what you checked in so far. |
| 20:24:04 | <rafa> djazayeri: Geat. |
| 20:24:11 | <wyclif> i mean i had to changes file names in the .vm files that link to them to find them in the new location since the project folders are different |
| 20:24:20 | <djazayeri> rafa: eventually we're going to need the ability to do file upload in an ajax form |
| 20:24:43 | <djazayeri> wyclif: really? we couldn't just put them somewhere different? |
| 20:24:51 | <djazayeri> rafa: but it's not particularly critical now. |
| 20:24:55 | <wyclif> djazayeri, i will be comitting the code in the next couple of minutes, you will see what i mean |
| 20:25:01 | <djazayeri> wyclif: okay |
| 20:25:06 | *** bwolfe has quit IRC |
| 20:25:07 | <rafa> djazayeri: What do we want specifically? Is it jus a simple upload or things like progress bar, drag&drop, etc? |
| 20:25:19 | <djazayeri> rafa: if you're stuck on it, I'd just move on to another ticket. |
| 20:25:38 | <djazayeri> Right now forms can be submitted either with a POST or via ajax |
| 20:25:53 | <djazayeri> I would like a way for forms that submit via ajax to include file uploads |
| 20:26:01 | <djazayeri> don't care about progress bar, drag&drop |
| 20:26:42 | <rafa> djazayeri: The problem is you can't simply send a file via ajax. You need to fake it and create an iframe. |
| 20:27:06 | <djazayeri> rafa: so it'd involve storing that server-side for a bit? |
| 20:27:22 | <djazayeri> anyway, I think that's the problem we need to solve, at some point |
| 20:27:27 | <wyclif> djazayeri, your comments are clear |
| 20:27:28 | <rafa> djazayeri: it's one of possible solutions |
| 20:27:28 | <djazayeri> probably we should wait until we have a real use case for it. |
| 20:27:58 | <rafa> djazayeri: the other is to put the entire form in an iframe |
| 20:28:09 | <rafa> djazayeri: dynamically of course |
| 20:28:19 | <djazayeri> starts to get ugly. :-) |
| 20:29:00 | *** bwolfe has joined #openmrs |
| 20:29:00 | *** ChanServ sets mode: +o bwolfe |
| 20:29:06 | <rafa> djazayeri: anyway for the moment I would suggest to display an alert that java.io.InputStream cannot be used in an ajax form. |
| 20:29:36 | <djazayeri> rafa: I agree |
| 20:30:01 | <rafa> djazayeri: Okay, I'll do that and move on to other tickets |
| 20:48:12 | *** bwolfe has quit IRC |
| 20:56:54 | *** rafa has quit IRC |
| 21:15:51 | *** yanokwa has quit IRC |
| 21:20:45 | *** bryq has quit IRC |
| 21:34:05 | *** downeym has quit IRC |
| 21:49:51 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: ID Generation 2.0.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=idgen&version=&2.0.2> |
| 22:00:04 | *** goutham has quit IRC |
| 22:04:41 | *** pascal` has quit IRC |
| 22:24:27 | *** wyclif has quit IRC |
| 23:03:38 | *** gbastien has joined #openmrs |
| 23:21:57 | *** wyclif has joined #openmrs |
| 23:35:06 | *** gbastien has quit IRC |
| 23:42:07 | *** edcable1 has joined #openmrs |
| 23:42:35 | *** jportela has joined #openmrs |
| 23:42:35 | *** ChanServ sets mode: +v jportela |
| 23:44:34 | *** edcable has quit IRC |