| 00:10:11 | *** gbastien has quit IRC |
| 00:21:43 | *** yanokwa has quit IRC |
| 00:25:59 | *** jwishnie has quit IRC |
| 00:25:59 | *** jwishnie_ has joined #openmrs |
| 00:25:59 | *** jwishnie_ is now known as jwishnie |
| 00:34:57 | *** djazayeri has quit IRC |
| 00:49:24 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting, Conflicting ASM Library - 2469... <http://feedproxy.google.com/~r/OMRStrunk/~3/8Xlv_n-eMhk/OpenMRS> || New Changeset: OpenMRS (1.8.x): Back porting, Ordering of encounters on formentry tab incorrect - TRUNK-2465 <http://feedproxy.google.com/~r/OMRStrunk/~3/q6jktLrU1qk/OpenMRS> || New Changeset: OpenMRS (trunk): Follow up to, View Concept page should display the UUID - TRUNK-2231 <http://feedproxy.google.com/~r/OMRStrunk/~3/otGVxEJ8w0A/OpenMRS> || New Changeset: OpenMRS (trunk): Conflicting ASM Library - 2469... <http://feedproxy.google.com/~r/OMRStrunk/~3/GnO16c-j_54/OpenMRS> || New Changeset: OpenMRS (trunk): applying auto formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/k9Jd0b36E_Q/OpenMRS> || New Changeset: OpenMRS (trunk): Ordering of encounters on formentry tab incorrect - TRUNK-2465 <http://feedproxy.google.com/~r/OMRStrunk/~3/LLkWEuYmhyQ/OpenMRS> |
| 00:56:05 | *** wyclif has quit IRC |
| 01:00:03 | *** jwishnie has quit IRC |
| 01:06:27 | *** jportela has left #openmrs |
| 01:08:53 | *** gbastien has joined #openmrs |
| 01:21:35 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting, Follow up to, View Concept page should display the UUID - TRUNK-2231 <http://feedproxy.google.com/~r/OMRStrunk/~3/vm5tWxugkJA/OpenMRS> |
| 01:26:05 | *** wyclif has joined #openmrs |
| 01:44:41 | *** gbastien has quit IRC |
| 02:20:09 | *** jwishnie has joined #openmrs |
| 02:41:33 | <wyclif> bwolfe, hi |
| 03:26:04 | *** upul` has joined #openmrs |
| 03:26:04 | *** ChanServ sets mode: +v upul` |
| 03:51:43 | *** surangak has joined #openmrs |
| 04:07:01 | *** surangak_ has joined #openmrs |
| 04:16:33 | *** djazayeri has joined #openmrs |
| 04:16:33 | *** ChanServ sets mode: +o djazayeri |
| 04:25:06 | *** bwolfe has quit IRC |
| 04:35:36 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.6.x): Back porting to 1.6.x, 1.7.x, 1.8.x, Concept Stats Broken for both numeric and coded values - TRUNK-2389 <http://feedproxy.google.com/~r/OMRStrunk/~3/OHLaCckR-dM/OpenMRS> || New Changeset: OpenMRS (trunk): Concept Stats Broken for both numeric and coded values - TRUNK-2389 <http://feedproxy.google.com/~r/OMRStrunk/~3/P3qkcUZ64YU/OpenMRS> |
| 05:37:46 | *** yanokwa has joined #openmrs |
| 05:37:47 | *** ChanServ sets mode: +v yanokwa |
| 05:43:40 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting, Follow up to apply changes after code review - TRUNK-2389 <http://feedproxy.google.com/~r/OMRStrunk/~3/n8bRRqjmJak/OpenMRS> || New Changeset: OpenMRS (trunk): Follow up to apply changes after code review - TRUNK-2389 <http://feedproxy.google.com/~r/OMRStrunk/~3/VAi5M5t2gZk/OpenMRS> || New Changeset: OpenMRS (trunk): Follow up to use dateFormatTag and back porting the switch to 1.6.x, 1.7.x, 1.8.x on the concept stats page - TRUNK-2389 <http://feedproxy.google.com/~r/OMRStrunk/~3/JFCnlvh73aA/OpenMRS> |
| 05:44:13 | *** robbyoconnor has quit IRC |
| 05:44:31 | *** robbyoconnor has joined #openmrs |
| 05:44:40 | *** ChanServ sets mode: +v robbyoconnor |
| 05:59:16 | *** bwolfe has joined #openmrs |
| 05:59:16 | *** ChanServ sets mode: +o bwolfe |
| 06:24:28 | *** dkayiwa has joined #openmrs |
| 06:26:30 | *** surangak_ has quit IRC |
| 06:31:06 | *** surangak has quit IRC |
| 06:32:37 | *** surangak has joined #openmrs |
| 07:04:14 | *** dkayiwa_ has joined #openmrs |
| 07:04:27 | *** dkayiwa has quit IRC |
| 07:04:28 | *** dkayiwa_ is now known as dkayiwa |
| 07:34:12 | *** bwolfe has quit IRC |
| 07:38:20 | *** rafa has joined #openmrs |
| 07:38:20 | *** ChanServ sets mode: +v rafa |
| 08:04:59 | *** magoo has joined #openmrs |
| 08:07:22 | *** yanokwa has quit IRC |
| 08:24:57 | *** magoo has quit IRC |
| 08:27:44 | *** magoo has joined #openmrs |
| 08:31:49 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Upgrading DWRService to address concurrent access problems... <http://feedproxy.google.com/~r/OMRStrunk/~3/WwPL5RodQaM/OpenMRS> |
| 08:51:27 | *** bryq has joined #openmrs |
| 08:51:27 | *** ChanServ sets mode: +v bryq |
| 09:05:51 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): [TRUNK-2258] Service and DAO for EncounterRole <http://feedproxy.google.com/~r/OMRStrunk/~3/MTlNYvFR7zA/OpenMRS> || Shazin Sadakath: Moodle Password Hash Structure <http://shazsterblog.blogspot.com/2011/07/moodle-password-hash-structure.html> || OpenMRS Modules: Appointment 1.0.5 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=appointment&version=&1.0.5> |
| 09:08:45 | *** bwolfe has joined #openmrs |
| 09:08:45 | *** ChanServ sets mode: +o bwolfe |
| 09:11:46 | *** magoo has quit IRC |
| 09:25:14 | <dkayiwa> hahahahahah Raymond Francis Sarmiento :D |
| 09:25:54 | <dkayiwa> bwolfe: looks like you may have spare money to give to thieves :) |
| 09:32:58 | <upul`> interesting story |
| 09:33:15 | <dkayiwa> very very clever one. :) |
| 09:33:47 | <upul`> we have people like that in bus stops |
| 09:33:53 | <dkayiwa> seen the same story thousands of times before |
| 09:33:59 | <dkayiwa> oh |
| 09:34:03 | <dkayiwa> how do you deal with them? |
| 09:34:17 | *** magoo has joined #openmrs |
| 09:34:36 | <upul`> say have no money and move on |
| 09:34:53 | <dkayiwa> they need some discipline too |
| 10:07:56 | *** bryq has quit IRC |
| 10:52:20 | *** surangak has quit IRC |
| 10:53:25 | *** surangak has joined #openmrs |
| 10:56:52 | *** guest_ has joined #openmrs |
| 11:01:45 | *** magoo has quit IRC |
| 11:04:41 | *** james_regen has joined #openmrs |
| 11:04:41 | *** ChanServ sets mode: +v james_regen |
| 11:08:22 | *** guest_ has quit IRC |
| 11:17:41 | *** magoo has joined #openmrs |
| 11:17:45 | <rafa> bwolfe, dkayiwa do you know of any module that can be run in the 2.x UI? It doesn't have to work. It's enough I can install it, start and stop. |
| 11:18:26 | <dkayiwa> rafa: have you tried the xforms module? |
| 11:18:28 | <bwolfe> htmlformentry worked for me |
| 11:18:40 | <rafa> ok thanks |
| 11:20:03 | <rafa> bwolfe: btw what does WebModuleUtil do that ModuleFactory does not? In other words do I need to use both? |
| 11:20:42 | <bwolfe> I can't remember. does the webutil actually do the spring restarting? |
| 11:21:02 | <bwolfe> I think webutil looks for and installs the web related things: servlets, messages, etc |
| 11:21:13 | <bwolfe> but it'd be nice if there was a better way that it was done |
| 11:21:48 | <bwolfe> like if the web layer just extended the api layer factory or service and so did its things that way |
| 11:21:57 | <rafa> bwolfe: it seems to be doing what you say indeed |
| 11:21:58 | *** surangak has quit IRC |
| 11:21:58 | <bwolfe> I don't like how the two layers interact right now :-/ |
| 11:22:12 | <bwolfe> bwolfesmemory++ |
| 11:22:17 | <rafa> :) |
| 11:33:38 | *** upul` has left #openmrs |
| 11:44:40 | *** magoo has quit IRC |
| 11:48:04 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Move Encounter types from core data to demo data - TRUNK-2446... <http://feedproxy.google.com/~r/OMRStrunk/~3/GhGH3nIFXSo/OpenMRS> |
| 12:10:24 | *** wyclif has quit IRC |
| 12:27:36 | *** bwolfe has quit IRC |
| 12:29:43 | *** bwolfe has joined #openmrs |
| 12:29:43 | *** ChanServ sets mode: +o bwolfe |
| 12:43:44 | *** bryq has joined #openmrs |
| 12:43:44 | *** ChanServ sets mode: +v bryq |
| 12:44:14 | *** bwolfe has quit IRC |
| 12:52:46 | *** bwolfe has joined #openmrs |
| 12:52:46 | *** ChanServ sets mode: +o bwolfe |
| 12:52:49 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Allergies and Problem <http://forum.openmrs.org/viewtopic.php?f=8&t=800#p3024> |
| 12:54:06 | *** dkayiwa has quit IRC |
| 13:00:12 | *** dkayiwa has joined #openmrs |
| 13:02:52 | <bwolfe> freeconferencing!!! *shakes fist in air* |
| 13:03:04 | <bwolfe> </williamWallace> |
| 13:03:09 | *** bumi has joined #openmrs |
| 13:04:33 | <bumi> Hi everybody, can anybody please tell me the name of the concept used to represent ' NO' |
| 13:05:00 | <bwolfe> bumi, uh, I think its called "NO". :-) |
| 13:05:17 | <bwolfe> (or whatever you want to name it) |
| 13:05:56 | <bwolfe> there might be a global property you can set to tell openmrs the id of the concept in your dictionary that represents "no" |
| 13:06:54 | <bumi> okay, cause to search a concept u need at leat three letters! |
| 13:07:51 | <bwolfe> ah |
| 13:07:55 | <bwolfe> can you do "no " |
| 13:07:59 | <bwolfe> or " no" ? |
| 13:08:23 | <bwolfe> or search for "yes", and then look at the concepts before and after it. :-) |
| 13:08:31 | <bumi> okay let me try and see |
| 13:09:02 | *** dkayiwa has quit IRC |
| 13:09:33 | <bumi> Thank you v.much wolfe, i got it, 'preciate it. |
| 13:09:53 | <bwolfe> was it next to "yes" ? :-) |
| 13:10:00 | <bwolfe> what version of openmrs are you using bumi? |
| 13:11:06 | <bumi> it was first then followed by NONE,NORMAL.., im uisng 1.8.1 |
| 13:13:11 | *** wyclif has joined #openmrs |
| 13:13:42 | <bwolfe> hmm, I thought that there was just a delay for less than 3 chars, but it still did the search |
| 13:13:55 | <bwolfe> (that is supposed to be new in 1.8) |
| 13:14:11 | <bwolfe> or did we only add that to the patient search? |
| 13:15:48 | <bumi> have actually tried from in view concept dictionary? cause thats what i was doing as im adding new concepts |
| 13:16:03 | <bumi> have you actually tried from in view concept dictionary? cause thats what i was doing as im adding new concepts |
| 13:19:05 | *** asgoyal has joined #openmrs |
| 13:20:05 | *** bwolfe has quit IRC |
| 13:20:15 | *** burke_away has joined #openmrs |
| 13:20:15 | *** ChanServ sets mode: +o burke_away |
| 13:22:55 | *** bumi has left #openmrs |
| 13:32:37 | *** bwolfe has joined #openmrs |
| 13:32:37 | *** ChanServ sets mode: +o bwolfe |
| 13:38:27 | *** magoo has joined #openmrs |
| 13:42:53 | *** dkayiwa has joined #openmrs |
| 13:52:23 | *** dkayiwa has quit IRC |
| 13:53:52 | *** downeym has joined #openmrs |
| 13:53:52 | *** OpenMRSBot sets mode: +o downeym |
| 13:53:52 | *** ChanServ sets mode: +o downeym |
| 14:04:15 | *** dkayiwa has joined #openmrs |
| 14:04:32 | <bwolfe> djazayeri, are we scrumming now? |
| 14:04:38 | <djazayeri> yes |
| 14:05:00 | <djazayeri> Sorry, got stuck copying-and-pasting ticket numbers. :-) |
| 14:05:15 | <djazayeri> bwolfe, wyclif, dkayiwa, rafa, ready to go? |
| 14:05:46 | <rafa> I'm ready |
| 14:05:59 | *** burke_away has quit IRC |
| 14:06:24 | <djazayeri> okay, want to go first? |
| 14:06:53 | <wyclif> hi |
| 14:07:27 | <rafa> Today: progressing with modules management ticket. Actually got stucked on being unable to install any module due to failing logic module. |
| 14:07:31 | *** dkayiwa has quit IRC |
| 14:07:47 | <rafa> Is it working for you? |
| 14:08:15 | <djazayeri> I haven't tried re-installing logic for a long time (because it's already installed). What's the error you see? |
| 14:09:07 | <rafa> Bascially the moment the application starts the logic fails to load with: org.openmrs.module.OpenmrsCoreModuleException: The following modules are marked as 'core' by OpenMRS but were unable to start: logic v0.5, |
| 14:09:24 | <rafa> And I haven't tried to install it alone. |
| 14:09:35 | <djazayeri> Is there a stack trace in the log above that? |
| 14:09:36 | <rafa> It's from the beginning I run the UI branch. |
| 14:09:38 | <bwolfe> rafa, theres a "core modules" wiki page that tells you how you can turn off core modules |
| 14:10:17 | <rafa> djazayeri: yes there's |
| 14:10:58 | <rafa> http://pastebin.com/7yK0g60B |
| 14:11:09 | <rafa> bwolfe: did you turn it off or is it working for you? |
| 14:11:22 | <bwolfe> it was working for me |
| 14:11:29 | <djazayeri> rafa: I mean that _before_ that stack trace, in the logs, there should be an error saying why logic didn't start |
| 14:11:39 | <bwolfe> when I did my ticket on monday I had both logic and htmlformentry installed and showing as running |
| 14:11:45 | *** burke_away has joined #openmrs |
| 14:11:45 | *** ChanServ sets mode: +o burke_away |
| 14:11:49 | *** burke_away has quit IRC |
| 14:12:22 | <rafa> where can I find logs in jetty? |
| 14:12:30 | <bwolfe> the stdout |
| 14:12:37 | <djazayeri> if you're running in eclipse they just appear in the console window |
| 14:12:38 | <bwolfe> or in the "console" in eclipse if you're runnign them that way |
| 14:13:02 | <rafa> so it's exactly what I pasted |
| 14:13:05 | <rafa> nothing more |
| 14:13:22 | <djazayeri> okay, so let's debug this blocker after everyone has given their update. |
| 14:13:41 | <rafa> ok |
| 14:13:42 | <djazayeri> rafa: did you have more to add besides that you're blocked? |
| 14:14:00 | <bwolfe> rafa, perhaps your logic module disappeared from the war? try reverting it in the bundledModules folder in the webapp project |
| 14:14:24 | <djazayeri> Actually the 2.x application doesn't have any bundled modules |
| 14:14:27 | <djazayeri> IIRC |
| 14:14:38 | <djazayeri> so you might need to manually put logic-0.5.omod in your modules folder |
| 14:15:01 | <rafa> I changed a little bit the upload field widget. There's still ajax functionality to add, see comments under the ticket. |
| 14:15:20 | <rafa> !ticket TRUNK-2454 |
| 14:15:23 | <OpenMRSBot> rafa: [#TRUNK-2454] 2.x file upload widget - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2454 |
| 14:15:49 | <rafa> Tomorrow: will work further on the manage modules ticket |
| 14:16:11 | <rafa> One blocker as above ;) |
| 14:16:21 | <djazayeri> okay, cool. |
| 14:16:23 | <rafa> Now it's all from me |
| 14:16:33 | <djazayeri> Next up: wyclif |
| 14:16:38 | <djazayeri> (where is dkayiwa? did he lose internet?) |
| 14:17:01 | <wyclif> yesterday, worked on 1.8 ticketsi.e TRUNK-2465, TRUNK-2389 |
| 14:17:22 | <wyclif> and worked partly on my sprint ticket |
| 14:17:48 | <wyclif> Today - Release 1.8.2 is my priority, if you can review the reviews for the above tickets, and possibly work on my sprint tickets |
| 14:17:52 | <bwolfe> looks like daniel gave up 7 minutes into the scrum :-p |
| 14:18:23 | <bwolfe> wyclif, rafa, type your update into a separate file and paste it in. put one item per line just for readability/scanability |
| 14:18:29 | <djazayeri> wyclif: I code reviewed 2465 already. The code is fine, I made comments on the unit test. |
| 14:18:50 | <wyclif> i made made the changes in unit tests |
| 14:19:02 | <wyclif> and committed them, check the ticket for the revision |
| 14:19:09 | <djazayeri> Okay, I'll re-review. |
| 14:19:26 | <djazayeri> You warned downeym that we're releasing 1.8.2 today? |
| 14:19:35 | <wyclif> yes, he is aware |
| 14:19:42 | <rafa> bwolfe: I was first and needed to invent it live ;) |
| 14:19:44 | <bwolfe> if not, this is his warning I guess :-p |
| 14:20:04 | <bwolfe> rafa, fair enough. but /next/ time :-p |
| 14:20:34 | <djazayeri> the best part of doing it that way is that if you keep the notepad window open, you'll be able to see at a glance what you _said_ you were going to do the next day. |
| 14:20:39 | *** jportela has joined #openmrs |
| 14:20:39 | *** ChanServ sets mode: +v jportela |
| 14:21:21 | <djazayeri> wyclif: the fix for TRUNK-2389 is trivial and also doesn't really make any sense out of context. |
| 14:21:37 | <djazayeri> So you can approve it yourself based on the fact that it works now in the UI and it didn't before. |
| 14:21:45 | <djazayeri> No need for peer code review on that one. |
| 14:21:46 | <wyclif> ok |
| 14:22:07 | <djazayeri> So, how long will it take to release 1.8.2 after I review 2465? |
| 14:22:09 | <djazayeri> half the day? |
| 14:22:21 | <wyclif> i guess |
| 14:22:54 | <wyclif> let me focus on it once we are done with the scrum chat and try to beat 2pm EST |
| 14:23:22 | <djazayeri> okay |
| 14:23:27 | <djazayeri> No daniel |
| 14:23:27 | <wyclif> so for my sprint ticket |
| 14:23:31 | <djazayeri> yes? |
| 14:24:56 | <wyclif> i wanted to commit a revision for the files when i copy them into the project, this will certainly break the project start up |
| 14:25:26 | <djazayeri> You mean you want to do your commit as multiple commits? |
| 14:25:32 | <djazayeri> (I don't get what you mean.) |
| 14:25:44 | <djazayeri> Will you break things briefly? Or for a long time? |
| 14:25:49 | <wyclif> this is because there are a couple of changes in the files, so it will make it easier for you to see the changes made in individual files in crucible |
| 14:26:39 | <wyclif> how abpout if i copy over the files, comment out lines that break start up so that i dont block you guys |
| 14:26:40 | <djazayeri> I'm fine with you splitting it up, if you can make it such that the build is broken for <30 minutes... |
| 14:27:01 | <djazayeri> Actually, that's even better. |
| 14:27:14 | <djazayeri> Yes, do it that way. |
| 14:27:16 | <wyclif> i will try that |
| 14:27:34 | <wyclif> thanks |
| 14:27:49 | <djazayeri> And thank you for thinking about how to make the code review clearer and easier. Wyclif += 5 |
| 14:28:01 | <djazayeri> any other questions/comments/blockers? |
| 14:28:09 | <wyclif> nope |
| 14:28:47 | <bwolfe> wyclif++ |
| 14:28:51 | <bwolfe> is what you meant. :-) |
| 14:28:59 | <djazayeri> No, I find that silly. :-) |
| 14:29:06 | <wyclif> he he he |
| 14:29:15 | <djazayeri> Actually "Wyclif gets 5 bonus points" |
| 14:29:27 | <wyclif> can i have my points |
| 14:29:33 | <djazayeri> wyclif++ |
| 14:29:44 | *** gbastien has joined #openmrs |
| 14:29:48 | <bwolfe> you can redeem your bonus points for a slew of kind words from djazayeri |
| 14:29:57 | <djazayeri> Okay, my turn. |
| 14:29:57 | <djazayeri> Tuesday: |
| 14:29:58 | <djazayeri> * code review |
| 14:29:58 | <djazayeri> * Finished letting 1.x modules expose existing pages as 2.x "fragments" |
| 14:29:58 | <djazayeri> * assessed and organized tickets |
| 14:29:58 | <djazayeri> * Thoughtworks Code Jam (helped two Expedia UK people get OpenMRS installed. Hopefully soon we'll have contributors from Expedia's London office doing a "code jam") |
| 14:29:58 | <djazayeri> Today: |
| 14:29:59 | <djazayeri> * design calls |
| 14:29:59 | <djazayeri> * sprint code reviews |
| 14:30:00 | <djazayeri> * Work on letting 1.x modules wrap existing portlets as 2.x "fragments" |
| 14:30:01 | <djazayeri> No blockers |
| 14:30:17 | <downeym> wyclif: don't forget to bump issues to 1.8.3 |
| 14:30:19 | <downeym> in jira |
| 14:30:30 | <djazayeri> and create the 1.8.3 version. |
| 14:31:24 | * bwolfe thinks these should be on the release process page so we don't have to remind the releaser...just tell them to follow the "script" |
| 14:31:49 | <downeym> wyclif: was there a jira issue created for ampath's problem? |
| 14:31:49 | *** dkayiwa has joined #openmrs |
| 14:32:59 | <bwolfe> downeym, the one win was working on? yes |
| 14:33:16 | <djazayeri> Was that one committed to 1.8.2 yet? |
| 14:34:47 | *** dkayiwa has quit IRC |
| 14:34:56 | <bwolfe> I think I saw it go in...but not sure. wyclif? |
| 14:35:30 | <wyclif> i committed it |
| 14:35:42 | <djazayeri> great |
| 14:35:50 | <djazayeri> okay, finishing up the scrum... |
| 14:35:51 | <djazayeri> Ben? |
| 14:36:01 | <bwolfe> today: |
| 14:36:02 | <bwolfe> worked on occ sprint tickets |
| 14:36:02 | <bwolfe> applied one random liquibase patch to trunk |
| 14:36:02 | <bwolfe> will have design conf call this evening |
| 14:36:02 | <bwolfe> tomorrow: |
| 14:36:02 | <bwolfe> more of the same, plus dev call |
| 14:36:27 | <wyclif> see rev:21733 and backported it in rev:21736 |
| 14:36:44 | <djazayeri> bwolfe: can you think of other people to bug for real-life OCC use cases? |
| 14:37:06 | <djazayeri> if not, let's brainstorm some on our call this evening |
| 14:37:49 | <bwolfe> any other big meta data sharer |
| 14:38:14 | <bwolfe> ada might have an opinion. paul probably has some, but is out of "the real world" these days. |
| 14:39:58 | <djazayeri> okay, ada is a good one to ask |
| 14:40:40 | *** pascal` has joined #openmrs |
| 14:41:53 | <djazayeri> alright, that's the end of the scrum |
| 14:42:03 | <djazayeri> Let's figure out Rafal's issue. |
| 14:42:14 | <djazayeri> Oh, one other thing... |
| 14:42:23 | <rafa> I'm installing everything from scratch :) |
| 14:42:30 | <bwolfe> rafa, did you make sure the logic module is in your modules folder? and is it version 0.5? |
| 14:42:32 | <djazayeri> Seems unnecessary, but okay... |
| 14:42:49 | <rafa> yes, it was okay |
| 14:42:53 | <djazayeri> wyclif, rafa: Can you guys join Google+ by Friday, so we can try doing Friday's scrum as a Google+ hangout? |
| 14:43:05 | <rafa> I'm in |
| 14:43:27 | <rafa> djazayeri: still the same problem :/ |
| 14:43:43 | <djazayeri> can you pastebin more of the startup log? |
| 14:43:51 | <djazayeri> I.e. the stuff that happens before that stack trace? |
| 14:44:04 | <bwolfe> can you run openmrs trunk normally against hte same database? |
| 14:44:12 | <wyclif> i have joined, but with another account |
| 14:44:24 | <rafa> http://pastebin.com/BrxkZx3r |
| 14:44:28 | <djazayeri> okay, well, friend me. or circle me, or whatever. :-) |
| 14:44:31 | <rafa> my entire stack trace |
| 14:44:38 | <rafa> I mean log :) |
| 14:45:01 | <djazayeri> odd that "logic" isn't mentioned until the stack trace |
| 14:45:19 | <djazayeri> and the file exists at d:/workspace/org.openmrs-1.9.x-data\Application Data\OpenMRS\modules ? |
| 14:45:33 | <wyclif> i want to try out something with the 1.8.2 release |
| 14:45:34 | <rafa> no |
| 14:45:49 | <bwolfe> wyclif, meaning something new? |
| 14:46:22 | <djazayeri> rafa: each OpenMRS version has "bundled modules" in the WAR, which ought to always include logic. But 2.x doesn't have this (yet?) |
| 14:46:37 | <djazayeri> so you'll need to manually put logic-0.5.omod in your modules folder to be able to start. |
| 14:47:12 | <wyclif> but i dont think what iw as about to say is that necessary given we have made minimal changes to 1.8.x |
| 14:47:22 | <rafa> Ohh I thought I saw it in the war... |
| 14:47:38 | <rafa> maybe I was looking at 1.9.x |
| 14:47:51 | <rafa> then it should solve my problem |
| 14:47:57 | <rafa> I'll try it out |
| 14:47:57 | <djazayeri> yeah, it's not in ui2. |
| 14:48:17 | <djazayeri> wyclif: what are you proposing for next time then? |
| 14:48:19 | <wyclif> i just wanted to ask a few people to quickly test the war file prior to release this afternoon when i have packaged |
| 14:48:53 | <wyclif> that we any of us can test any different part of the app that comes to mind just to be sure |
| 14:49:17 | <wyclif> but as i said i think the changes are minimal, it is unlikely anything existing has been broken |
| 14:49:18 | <djazayeri> how about the standard tests that are supposed to be part of our standard release process? |
| 14:49:59 | <bwolfe> wyclif, for this I think this one you just test the 3 diff places that were effected |
| 14:50:02 | <wyclif> i did that for 1.8.0 but i never ran into any issues |
| 14:50:03 | <bwolfe> and with a bit of diff data |
| 14:50:17 | <wyclif> sorry for 1.8.1 |
| 14:50:47 | <djazayeri> I don't think you need to get extra people to do the testing for 1.8.2. |
| 14:50:49 | <wyclif> the standard release process doesn't catch all brokers from what i have noticed |
| 14:50:57 | <rafa> djazayeri: It helped thanks a lot! |
| 14:50:59 | <djazayeri> We really need to push to get the automated test suite running |
| 14:51:05 | <djazayeri> and covering more and more cases. |
| 14:51:23 | <wyclif> ok |
| 14:52:02 | <djazayeri> It's not feasible to pull a bunch of people to test every maintenance release, so we need to automate as much of it as we can. |
| 14:52:30 | <bwolfe> that is mostly the point of the "release testing" work that was done |
| 14:52:33 | <wyclif> but what i wanted, was for people to test those other things that come to mind quickly that are not in the release testing process |
| 14:53:23 | <djazayeri> So, I don't think that's necessary for 1.8.2 |
| 14:53:33 | <djazayeri> But it seems like a good topic for a dev call. |
| 14:53:37 | <djazayeri> Want to propose it for the agenda? |
| 14:53:55 | <wyclif> ok, never mind |
| 14:54:22 | <rafa> djazayeri: in ManageModulesFragmentController#startModule I found // TODO: create 1.9 ticket to create a ModuleService that can do this |
| 14:54:32 | <rafa> djazayeri: is it still up to date? |
| 14:54:56 | <rafa> djazayeri: I was intending to create some sort of class for this logic wihing the ui framework |
| 14:54:56 | <djazayeri> wyclif: It's an important point. |
| 14:55:20 | <djazayeri> So please do ask for it as a topic on a dev call. |
| 14:55:37 | <djazayeri> (Just that for 1.8.2 the point is to quickly release an improved version that doesn't have the blocker bug from 1.8.1.) |
| 14:55:53 | <wyclif> ok |
| 14:55:54 | <djazayeri> rafa: we haven't created a ModuleService yet, if that's what you're asking. |
| 14:56:13 | <rafa> djazayeri: I'm asking if I should create one :) |
| 14:56:14 | <djazayeri> currently there's a ModuleUtil or WebModuleUtil that does this. |
| 14:56:30 | <rafa> djazayeri: or just stick to what I've got now |
| 14:56:41 | <bwolfe> rafa, don't do many core changes |
| 14:56:59 | <bwolfe> there is a gsoc project from last year that added a bunch of things...one of which might have been a moduleservice |
| 14:57:23 | <djazayeri> Just copy some/all of WebModuleUtil into the 2.x application |
| 14:57:26 | *** asgoyal has quit IRC |
| 14:57:28 | <rafa> bwolfe: cool, so I'll just copy & paste the code from the old manage modules controller |
| 14:57:31 | <djazayeri> and put a // TODO refactor comment on it |
| 14:57:32 | *** wyclif has quit IRC |
| 14:57:48 | <bwolfe> good enough for me |
| 14:58:24 | <djazayeri> So, yeah, for purposes of this ticket, do it the (current) hacky way |
| 14:58:39 | *** wyclif has joined #openmrs |
| 14:59:00 | <rafa> Ok, perfect |
| 15:01:56 | *** magoo has quit IRC |
| 15:05:54 | *** bwolfe has quit IRC |
| 15:08:52 | *** downeym has quit IRC |
| 15:10:59 | *** downeym has joined #openmrs |
| 15:10:59 | *** OpenMRSBot sets mode: +o downeym |
| 15:10:59 | *** ChanServ sets mode: +o downeym |
| 15:22:34 | *** rafa has quit IRC |
| 15:23:45 | *** bwolfe has joined #openmrs |
| 15:23:45 | *** ChanServ sets mode: +o bwolfe |
| 15:25:11 | *** rafa has joined #openmrs |
| 15:25:11 | *** ChanServ sets mode: +v rafa |
| 15:26:24 | *** gauravpaliwal has joined #openmrs |
| 15:26:24 | *** ChanServ sets mode: +v gauravpaliwal |
| 15:31:44 | *** dkayiwa has joined #openmrs |
| 15:32:24 | *** lh has joined #openmrs |
| 15:34:33 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Allergies and Problem <http://forum.openmrs.org/viewtopic.php?f=8&t=800#p3025> |
| 15:34:48 | <gauravpaliwal> hi, anyone using openmrs testing plugin in eclipse |
| 15:34:56 | <gauravpaliwal> and seeing error the chosen operation is not enabled |
| 15:34:57 | <gauravpaliwal> ? |
| 15:35:43 | <djazayeri> bwolfe: what's the status of merging the application-testing branch? |
| 15:44:03 | *** goutham has joined #openmrs |
| 16:04:47 | *** cta has joined #openmrs |
| 16:44:56 | *** rafa has quit IRC |
| 16:53:31 | <djazayeri> hi jportela |
| 16:53:40 | <djazayeri> how goes today's work? |
| 16:53:46 | *** downeym has quit IRC |
| 16:54:30 | *** goutham has quit IRC |
| 16:54:30 | <jportela> I arrived at home a few minutes ago, so it's starting right now |
| 16:54:45 | <jportela> I have a question for you |
| 16:55:07 | <djazayeri> yes? |
| 16:55:25 | <jportela> what's the purpose of the AttributeDescriptor class in the htmlformentry module? |
| 16:55:40 | <jportela> I'm planning on using that, because I need a descriptor |
| 16:55:51 | <jportela> but the TagHandlers don't map all attributes available |
| 16:56:06 | <jportela> I don't know if those are the required attributes... |
| 16:56:23 | <djazayeri> It was introduced as a way of letting HtmlFormEntry export forms via metadata sharing |
| 16:56:44 | <djazayeri> I imagine it's currently used to describe all attributes that may reference other metadata |
| 16:57:01 | <djazayeri> e.g. surely ObsTagHandler declares "conceptId" |
| 16:57:09 | <jportela> yes |
| 16:57:15 | <jportela> ok got it |
| 16:57:31 | <jportela> so maybe it's not a good idea to mess with it to declare all possible attributes? |
| 16:58:12 | <djazayeri> so if we use that same descriptor for our purposes (I think we should) then we need to make sure the MDS-related code doesn't get broken. |
| 16:58:26 | <djazayeri> should be straightforward |
| 16:58:54 | <jportela> yes |
| 16:59:35 | <jportela> well, I would only have to make sure all attributes are defined for each tag, instead of just having the ones that may reference other metadata |
| 16:59:41 | <djazayeri> probably just making a change to HtmlFormExporter around line 94. |
| 16:59:56 | <djazayeri> Yes, so basically it's fine for you to add more things. |
| 17:00:34 | <djazayeri> (more attribute descriptors to existing tags, I mean) |
| 17:00:39 | <jportela> yes |
| 17:00:43 | <jportela> that's what I need |
| 17:00:45 | <jportela> ok |
| 17:00:52 | <djazayeri> do please email mgoodrich at pih.org and mention that you're doing this |
| 17:01:04 | <jportela> got it |
| 17:01:10 | <djazayeri> (say you're doing it in a branch, but ask if there's any reason this is a bad idea.) |
| 17:01:39 | *** asgoyal has joined #openmrs |
| 17:01:49 | <jportela> well, at the worst case we could add another collection of attributeDescriptors, so it shouldn't be a blocker |
| 17:01:59 | <jportela> but it would be nice to use what already exists |
| 17:02:04 | <djazayeri> yup |
| 17:02:09 | <jportela> ok |
| 17:02:12 | <jportela> so yesterday: |
| 17:02:31 | <jportela> basically I setup the demo/tests (which took me too long) |
| 17:02:33 | <jportela> also |
| 17:02:43 | <asgoyal> djazayeri: if the any parameter such as patient or ingredient is null... then should i keep a check of this and return null? |
| 17:02:43 | <jportela> I created a dialog that shows all attributes from a tag |
| 17:02:55 | <jportela> and mapped a textfield to it |
| 17:02:58 | <jportela> today: |
| 17:03:24 | <jportela> will basically generate the code for the tags, based on the input for each attribute |
| 17:03:38 | <djazayeri> asgoyal: where? |
| 17:03:55 | <asgoyal> in the getDrugsByIngredient for example |
| 17:04:46 | <djazayeri> asgoyal: You should assume that the data in the db is valid. You don't need to do extra validation of that. You can/should check parameters the user passes to the method, to make sure they're provided |
| 17:04:51 | <djazayeri> but don't return null in case of error |
| 17:05:03 | <jportela> and will try to render HTML code, using the taghandlers from htmlformentry, although that could take more than one day for getting to work (sorry for parallel talk) |
| 17:05:03 | <asgoyal> oh ok |
| 17:05:09 | <djazayeri> rather you should do: if (ingredient == null) throw new IllegalArgumentException("ingredient is required"); |
| 17:05:39 | <djazayeri> jportela: parallel talk is fine. so if I svn update the designer module, will I be able to see the demo test? |
| 17:05:48 | <jportela> yes |
| 17:05:56 | <jportela> for yesterday and today |
| 17:05:57 | <asgoyal> ok |
| 17:06:15 | <jportela> yesterday and the day before actually |
| 17:07:18 | <jportela> basically the tests makes a request for each controller, and sees if the map contains the same information on the DB (while printing out the values, for demo purposes) |
| 17:07:20 | <djazayeri> Okay, I'll take a look. When I did the original checkout I noticed that the htmlformentry jar/omod wasn't on the build path |
| 17:07:29 | <jportela> I already added it :) |
| 17:10:52 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Role-Based Homepage 2.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=rolebasedhomepage&version=&2.0> |
| 17:11:36 | *** gbastien has quit IRC |
| 17:16:57 | <djazayeri> jportela: I ran it, and it looks good. |
| 17:17:11 | <djazayeri> One request: let's actually split up the unit tests into two different things: |
| 17:17:58 | <djazayeri> 1. Real unit tests. These should go in the parallel test class to the class they're testing. They should test one function at a time, do appropriate asserts, and they should generally not print anything out. |
| 17:18:56 | <djazayeri> 2. Demonstrations. We're using JUnit for this as a convenience, but they're not actually unit tests. Put these all in a (modulePackage).test.Demonstration class. They don't need to do any asserts, and they should print things out. |
| 17:19:32 | <djazayeri> jportela: The real unit tests in #1 should use @verifies, but the ones in Demonstration shouldn't. |
| 17:20:09 | <djazayeri> Basically, let's make it clear what the real tests are, and not try to mix demonstration into them, rather we'll keep the two streams separate. |
| 17:20:10 | <jportela> djazayeri: got it |
| 17:29:38 | *** rafa has joined #openmrs |
| 17:29:41 | *** ChanServ sets mode: +v rafa |
| 17:35:25 | *** gbastien has joined #openmrs |
| 17:41:42 | <asgoyal> djazayeri: what do i have to do for: |
| 17:41:43 | <asgoyal> the user interface for Manage Drugs needs to allow specifying the ingredients |
| 17:41:43 | <asgoyal> this is optional--drugs that don't explicitly list ingredients are implied to be made exclusively of one ingredient, of (drug.concept, drug.doseStrength, drug.units). |
| 17:42:54 | *** pascal` has quit IRC |
| 17:43:14 | <djazayeri> asgoyal: the Manage Drug page (when editing a single drug) needs to allow you to optionally specify what ingredients are in the that drug. |
| 17:43:49 | <asgoyal> oh ok |
| 17:48:44 | <gauravpaliwal> djazayeri: how can i get context while testing getting the error : ERROR - Context.getServiceContext(255) |2011-07-20 23:18:00,768| serviceContext is null. Creating new ServiceContext() |
| 17:48:45 | <gauravpaliwal> ? |
| 17:49:13 | <djazayeri> gauravpaliwal: probably if you look higher up in the log file you'll see a stack trace that describes what the underlying problem is |
| 17:50:56 | *** downeym has joined #openmrs |
| 17:50:56 | *** OpenMRSBot sets mode: +o downeym |
| 17:50:56 | *** ChanServ sets mode: +o downeym |
| 17:56:53 | <djazayeri> downeym: can you please move this page to Project -> Unassigned Project: https://wiki.openmrs.org/display/docs/Cohort+Builder+Replacement+%28design%29# |
| 17:56:58 | <OpenMRSBot> <http://ln-s.net/90MC> (at wiki.openmrs.org) |
| 17:57:41 | *** bwolfe has quit IRC |
| 17:57:49 | <downeym> djazayeri: done |
| 17:58:02 | <djazayeri> thanks |
| 17:58:52 | *** gauravpaliwal has left #openmrs |
| 18:05:10 | *** goutham has joined #openmrs |
| 18:14:51 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): adding @regression comment to a unit test <http://feedproxy.google.com/~r/OMRStrunk/~3/4CAFKYII8nI/OpenMRS> || New Changeset: OpenMRS (trunk): adding @regression comment to a unit test <http://feedproxy.google.com/~r/OMRStrunk/~3/a4ZI1Bt5DU8/OpenMRS> |
| 18:25:36 | *** bwolfe has joined #openmrs |
| 18:25:36 | *** ChanServ sets mode: +o bwolfe |
| 18:37:21 | <rafa> djazayeri, wyclif, bwolfe does ui2 compile fine for you? |
| 18:38:24 | <djazayeri> I'll check |
| 18:38:51 | <djazayeri> nope |
| 18:39:06 | <djazayeri> dwr seems to have broken things |
| 18:39:16 | <rafa> correct |
| 18:39:51 | <djazayeri> I don't see dkayiwa around, he was working on this though. |
| 18:40:05 | <rafa> I see |
| 18:40:38 | <rafa> He forgot to commit sth I guess :) |
| 18:40:54 | <djazayeri> well, some things aren't compiling due to being in the wrong packages. |
| 18:41:14 | <rafa> well WebUtil class is missing |
| 18:41:24 | <djazayeri> that too |
| 18:41:39 | <wyclif> it does for me, but i probably need to do an svn update |
| 18:41:45 | <djazayeri> well, don't do it yet. :-) |
| 18:42:03 | <djazayeri> daniel's comment on TRUNK-2462 was Committed https://source.openmrs.org/changelog/OpenMRS/?cs=21707 , https://source.openmrs.org/changelog/OpenMRS/?cs=21756 and https://source.openmrs.org/changelog/OpenMRS/?cs=21757 |
| 18:43:23 | <djazayeri> If daniel has signed off for the day, we should probably revert these. |
| 18:44:14 | <djazayeri> the probably is probalby in 21756-7 |
| 18:46:44 | <rafa> I've got some local changes to commit. I don't want to lose them. Can you do the revert Darius? |
| 18:47:31 | <djazayeri> you could try doing an svn update to revision 21755 |
| 18:48:10 | <bwolfe> rafa, or you can commit and just hope you don't break it further ;-) |
| 18:49:48 | <djazayeri> or have you edited files that daniel touched in those commits? |
| 18:50:51 | <rafa> hmm no, I should be fine committing, but won't it complicate an eventual revert? |
| 18:51:34 | <rafa> Okay, it's late here anyway so I'll just wait till tomorrow :) |
| 18:51:41 | *** djazayeri has left #openmrs |
| 18:51:49 | *** djazayeri has joined #openmrs |
| 18:51:49 | *** ChanServ sets mode: +o djazayeri |
| 18:51:56 | <djazayeri> okay |
| 18:52:00 | <rafa> Daniel probably wakes up before me ;) |
| 18:53:25 | <bwolfe> rafa, make a patch of your code |
| 18:53:32 | <bwolfe> and put that patch up somewhere (or email it ot yourself) |
| 18:53:43 | <bwolfe> thats a cheapo backup |
| 18:54:36 | <rafa> bwolfe: no problem, it's just an hour of work ;) |
| 18:54:58 | <rafa> it will be safe on my hdd |
| 18:56:51 | <bwolfe> famous last words... |
| 18:57:11 | <rafa> hehe |
| 18:59:22 | *** rafa has quit IRC |
| 19:09:04 | *** goutham has quit IRC |
| 19:17:47 | *** cta has quit IRC |
| 19:23:34 | *** dkayiwa has joined #openmrs |
| 19:43:41 | *** james_regen has quit IRC |
| 19:44:00 | *** yanokwa has joined #openmrs |
| 19:44:00 | *** ChanServ sets mode: +v yanokwa |
| 19:46:31 | *** pascal` has joined #openmrs |
| 19:46:58 | *** asgoyal has quit IRC |
| 19:47:26 | *** asgoyal has joined #openmrs |
| 19:53:21 | *** bryq has quit IRC |
| 20:05:06 | <bwolfe> wyclif |
| 20:05:13 | <bwolfe> you don't have to move the tickets one by one |
| 20:05:41 | <wyclif> i can move them as a group i think |
| 20:05:52 | <bwolfe> yeah, but easiest way is to do it from the admin section |
| 20:06:46 | <bwolfe> when you "release" a current version, it asks you what to do with all the current tickets |
| 20:06:50 | <wyclif> i only to do when releasing in jira |
| 20:06:59 | <bwolfe> you can choose to bump them to 1.8.3 at that point |
| 20:07:03 | <wyclif> ok |
| 20:31:05 | <djazayeri> wyclif: are you about to release 1.8.2? |
| 20:33:24 | <wyclif> yes |
| 20:33:59 | <wyclif> am doing mvn release and packaging |
| 20:34:31 | <wyclif> you can view the release notes and edit them, you can view and edit them |
| 20:42:18 | *** pascal` has quit IRC |
| 20:50:53 | <djazayeri> wyclif, I have some edits to the What's New section |
| 20:51:36 | <wyclif> me too |
| 20:51:38 | <wyclif> thanks |
| 20:52:39 | <djazayeri> I'll email to you so as not to get conflicting wiki saves |
| 20:52:48 | <djazayeri> (or did you cancel that?) |
| 20:55:44 | *** asgoyal has quit IRC |
| 20:58:41 | <djazayeri> emailed you |
| 21:10:24 | <wyclif> ok, thanks |
| 21:10:26 | *** rafa has joined #openmrs |
| 21:10:26 | *** ChanServ sets mode: +v rafa |
| 21:10:59 | <wyclif> i had actually made the changes similar to what you emailed me |
| 21:14:22 | *** Echidna has quit IRC |
| 21:19:50 | *** Echidna has joined #openmrs |
| 21:19:50 | *** ChanServ sets mode: +v Echidna |
| 21:25:14 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): [maven-release-plugin] prepare for next development iteration <http://feedproxy.google.com/~r/OMRStrunk/~3/UO-I1AEo0hI/OpenMRS> || New Changeset: OpenMRS (root:): [maven-release-plugin] copy for tag 1.8.2 <http://feedproxy.google.com/~r/OMRStrunk/~3/WgxPp2SID9Q/OpenMRS> || New Changeset: OpenMRS (1.8.x): [maven-release-plugin] prepare release 1.8.2 <http://feedproxy.google.com/~r/OMRStrunk/~3/UW-MUwuJvco/OpenMRS> |
| 21:33:11 | *** rafa has quit IRC |
| 22:27:46 | *** gbastien has quit IRC |
| 23:00:46 | *** wyclif has quit IRC |
| 23:01:18 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OpenMRS 1.8.2 is now available - more improvements & bug fixes. You should download it now here: http://openmrs.org/download <http://twitter.com/OpenMRS/statuses/93807168301699072> |
| 23:05:49 | *** dkayiwa has quit IRC |
| 23:09:30 | *** downeym has quit IRC |
| 23:35:20 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (root:): Tagging 1.8.2 as latest <http://feedproxy.google.com/~r/OMRStrunk/~3/PNkSXaqBfiI/OpenMRS> || New Changeset: OpenMRS (root:): preparing to switch to 1.8.2 as latest <http://feedproxy.google.com/~r/OMRStrunk/~3/ztYrY5_oQ3o/OpenMRS> |
| 23:51:30 | *** lh has quit IRC |