| 00:55:19 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Module not start <http://forum.openmrs.org/viewtopic.php?f=8&t=799#p3023> |
| 01:02:32 | *** gbastien has joined #openmrs |
| 02:17:16 | *** djazayeri has quit IRC |
| 02:21:21 | *** suho has joined #openmrs |
| 02:21:21 | *** ChanServ sets mode: +v suho |
| 02:31:58 | *** jportela has quit IRC |
| 02:37:15 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): added a unit test for TRUNK-2418 <http://feedproxy.google.com/~r/OMRStrunk/~3/WHTTOGfnHhQ/OpenMRS> |
| 02:53:17 | *** djazayeri has joined #openmrs |
| 02:53:17 | *** ChanServ sets mode: +o djazayeri |
| 03:16:34 | *** upul` has joined #openmrs |
| 03:16:34 | *** ChanServ sets mode: +v upul` |
| 03:41:01 | *** gbastien has quit IRC |
| 03:42:22 | *** suho has quit IRC |
| 03:45:13 | *** surangak has joined #openmrs |
| 03:58:07 | <surangak> test |
| 05:02:48 | *** jwishnie has quit IRC |
| 05:39:07 | *** suho has joined #openmrs |
| 05:39:07 | *** ChanServ sets mode: +v suho |
| 05:48:59 | <suho> hi can get some support on xform module ? |
| 05:50:07 | <suho> i wanted to enter two identifiers one the patient registration field |
| 05:50:18 | <suho> how its possible ? |
| 05:51:05 | *** bwolfe has joined #openmrs |
| 05:51:05 | *** ChanServ sets mode: +o bwolfe |
| 05:52:34 | <suho> hi bwolfe |
| 05:53:05 | <suho> can i get some support on xform module ? |
| 05:53:37 | <suho> i wanted to enter two identifiers at patient registration. how to implement that in xforms ? |
| 05:54:09 | <bwolfe> suho, I don't know. is it not in the xforms documentation? |
| 05:54:34 | <suho> no its not there |
| 05:55:08 | <suho> and do you know how to customize the address template in 1.8.1 |
| 05:55:44 | <suho> in the war file i dont see the openmrs-sevlet.xml |
| 06:04:41 | <bwolfe> openmrs-servlet.xml is in the WEB-INF folder |
| 06:16:03 | *** bwolfe has quit IRC |
| 06:21:28 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Upgrading complex handler support <http://feedproxy.google.com/~r/OMRStrunk/~3/9eNPF_Z10KI/OpenMRS> |
| 06:23:42 | <surangak> thanks bot, for shouting that from the rooftops :D |
| 06:40:51 | *** dkayiwa has joined #openmrs |
| 06:54:13 | <suho> hi dkayiwa |
| 06:54:20 | <dkayiwa> hi suho |
| 06:54:25 | <dkayiwa> how long is the largest list? |
| 06:54:27 | <dkayiwa> roughly |
| 06:54:55 | <suho> it wont be that long, if i can add some logic like |
| 06:55:14 | <dkayiwa> if its not long, then you can just use the form designer |
| 06:55:17 | <dkayiwa> to add those lists |
| 06:55:33 | <dkayiwa> change the first selection list to type "Single Select" |
| 06:55:49 | <dkayiwa> then the rest of the dependant lists to "Single Select Dynamic" |
| 06:55:56 | <suho> for the province foo the district will be a,b,c and to province bar then district will be x,y,z |
| 06:56:12 | <dkayiwa> then use the dynamic lists tab to configure the dependencies |
| 06:57:14 | <suho> hmm .. is there any documentation |
| 06:57:21 | <dkayiwa> yes |
| 06:57:26 | <suho> i dont understand |
| 06:57:39 | <dkayiwa> let me give it to u |
| 06:58:59 | <dkayiwa> oh it was not brought from the old wiki. but let me explain |
| 06:59:27 | <dkayiwa> which one does the user start with when selecting |
| 06:59:36 | <dkayiwa> district or province |
| 06:59:40 | <dkayiwa> suho |
| 07:00:21 | <suho> hi |
| 07:00:34 | <dkayiwa> which one does the user start with when selecting |
| 07:00:39 | <dkayiwa> district or province |
| 07:01:29 | <suho> do you know the |
| 07:01:51 | <suho> Address Hierarchy module |
| 07:02:14 | <suho> i need that functionality |
| 07:02:20 | <dkayiwa> yes |
| 07:02:33 | <dkayiwa> its the one am providing |
| 07:02:40 | <suho> ok |
| 07:02:48 | <dkayiwa> which one does the user start with when selecting? |
| 07:02:59 | <suho> province |
| 07:02:59 | <dkayiwa> province? suho |
| 07:03:12 | <suho> then then district |
| 07:03:32 | <dkayiwa> so make the type or province "Single Select" in the form designer |
| 07:03:43 | <suho> ok |
| 07:03:55 | <dkayiwa> then you add its children |
| 07:04:22 | <dkayiwa> after that, you make the type of district to be "Single Select Dynamic" in the form designer: suho |
| 07:04:46 | <suho> hmm let me see |
| 07:04:55 | <dkayiwa> ok |
| 07:05:13 | <suho> ok done |
| 07:05:31 | <dkayiwa> done with making district single select dynamic? |
| 07:05:46 | <suho> yes |
| 07:06:02 | <suho> then how to enter the values there ? |
| 07:06:07 | <dkayiwa> now when district is selected, go to the dynamic lists tab |
| 07:07:02 | <suho> ok and |
| 07:07:19 | <dkayiwa> chose parent question |
| 07:07:30 | <dkayiwa> which is province |
| 07:08:16 | <suho> in the binding ? |
| 07:08:32 | <dkayiwa> binding is what you want stored in the database |
| 07:08:39 | <dkayiwa> when the user selectes this option |
| 07:08:56 | <dkayiwa> text is what you want the user to see |
| 07:09:05 | <suho> ok |
| 07:09:17 | <suho> so where is this "chose parent question" |
| 07:09:36 | <dkayiwa> see this text |
| 07:09:39 | <dkayiwa> Values for: District when the answer for: |
| 07:09:39 | <dkayiwa> |
| 07:09:40 | <dkayiwa> Province |
| 07:09:40 | <dkayiwa> |
| 07:09:40 | <dkayiwa> is equal to |
| 07:10:01 | <dkayiwa> you see the highlighted question |
| 07:10:09 | <dkayiwa> click on it lets you chose the parent question |
| 07:10:21 | <suho> ok got it |
| 07:10:40 | *** rafa has joined #openmrs |
| 07:10:40 | *** ChanServ sets mode: +v rafa |
| 07:11:06 | <suho> i added state/province there |
| 07:11:19 | <dkayiwa> then add new buttons lets you enter the districts for each selected province |
| 07:11:34 | <suho> ok |
| 07:11:44 | <suho> its very easy |
| 07:11:48 | <dkayiwa> once you get that pattern, you do the same for all the other levels |
| 07:12:11 | <suho> but |
| 07:12:15 | <dkayiwa> oh thanks. I thought it would be hard. user interface design can be tricky |
| 07:12:29 | <suho> the province drop down is |
| 07:12:33 | <suho> empty |
| 07:12:43 | <suho> how to add province and where ? |
| 07:12:46 | *** pascal` has joined #openmrs |
| 07:12:47 | <dkayiwa> did you add any children under province? |
| 07:13:02 | <suho> no for the parent |
| 07:13:18 | <dkayiwa> under form fields, select province, and then either right click to select add child |
| 07:13:32 | <dkayiwa> or click the add child toolbar button |
| 07:14:03 | <dkayiwa> since the data type for province is single select, the way you add its children is different from the others |
| 07:14:28 | <dkayiwa> the dynamic lists tab is only for those who type is "Single Select Dynamic" |
| 07:14:51 | <dkayiwa> I had all this documented but i wonder where it all went :O |
| 07:15:07 | <suho> now i got it |
| 07:15:13 | <dkayiwa> ok |
| 07:15:20 | <suho> yes add the documentations |
| 07:15:36 | <dkayiwa> looking for volunteers :D |
| 07:15:54 | <suho> i can help you :) |
| 07:16:09 | <dkayiwa> oh that will be wonderfull!!!! :D |
| 07:16:18 | <suho> u want me to write some |
| 07:16:29 | <suho> i think i can |
| 07:16:52 | <dkayiwa> u can add it here |
| 07:16:53 | <dkayiwa> https://wiki.openmrs.org/display/docs/XForms+Module+Properties+Tab |
| 07:16:59 | <OpenMRSBot> <http://ln-s.net/909k> (at wiki.openmrs.org) |
| 07:17:18 | <dkayiwa> under Dynamic Lists |
| 07:17:27 | <dkayiwa> for [archive:XForms Module Dynamic Lists] |
| 07:19:04 | <dkayiwa> that should work for you as far as address selection is concerned |
| 07:19:35 | <dkayiwa> not many people know about it because it is not documented well |
| 07:20:33 | <suho> yes |
| 07:20:40 | <suho> and i fond a bug |
| 07:20:50 | <dkayiwa> which one? |
| 07:21:01 | <suho> when i select the parent question |
| 07:21:09 | <dkayiwa> aha |
| 07:21:20 | <suho> i was able to add the stuff |
| 07:21:27 | <suho> and then after saving |
| 07:21:34 | <dkayiwa> aha |
| 07:21:46 | <suho> the selected parient question is not there |
| 07:21:52 | <dkayiwa> oh |
| 07:21:58 | <suho> the default one is getting selected |
| 07:22:09 | <dkayiwa> can you easily reproduce it? |
| 07:22:19 | <suho> the "gender" |
| 07:22:56 | <suho> but then if i reselect the province |
| 07:23:04 | <dkayiwa> ok |
| 07:23:11 | <suho> then i was able to see all the entered values |
| 07:23:33 | <dkayiwa> and after saving, does it this time preserve them? |
| 07:24:35 | <suho> so it is getting saved but the Qn is getting changed |
| 07:24:46 | <dkayiwa> how? |
| 07:24:52 | <dkayiwa> how does it get changed? |
| 07:26:41 | <dkayiwa> just done it here but still failed to reproduce the problem |
| 07:27:00 | <dkayiwa> may be it happens (the bug) only if you do things a certain way |
| 07:27:50 | <suho> i'll try this a gain |
| 07:28:14 | <dkayiwa> what i did was change a question's type to single select, added all the options, then changed another qestion's type to single select dynamic, started adding its kids using dynamic lists tab, saved. Reopened, and all was well |
| 07:29:58 | <suho> my version is from the repository |
| 07:30:12 | <dkayiwa> it shouldnt matter |
| 07:30:35 | <suho> same thing i did |
| 07:31:16 | <suho> but when i click anther element in form field and then reselect the district |
| 07:31:33 | <suho> i'm getting the Qn changed |
| 07:31:54 | <dkayiwa> which question gets changed? |
| 07:33:22 | <suho> i think we have to save step by step |
| 07:33:46 | <suho> earlier i added the all and saved at the end |
| 07:34:17 | <suho> but now i saved at each step |
| 07:34:28 | <suho> now its working |
| 07:34:55 | <suho> i think its getting confused when lot are getting changed at one |
| 07:37:23 | <suho> now |
| 07:37:44 | <dkayiwa> may be. if only i can reproduce it |
| 07:37:55 | <dkayiwa> because i saved at the end also and all was well |
| 07:38:10 | <dkayiwa> but i think if have had the same complaint from some other user before |
| 07:38:21 | <dkayiwa> though i failed to reproduce it |
| 07:39:12 | <suho> i'll try this again later and if i know how to reproduce ' |
| 07:39:21 | <suho> i'll let you know |
| 07:39:24 | <dkayiwa> ok that will be wonderful!!! |
| 07:39:31 | <suho> now i have saved this |
| 07:39:54 | <suho> but in the preview i can only see the province dropdown |
| 07:40:14 | <suho> and when selection that nothing is getting changed |
| 07:40:22 | <suho> have i missed anything ? |
| 07:40:32 | <dkayiwa> right click on the preview |
| 07:40:36 | <dkayiwa> and then select refresh |
| 07:40:53 | <dkayiwa> tell me after you have done that |
| 07:42:00 | <suho> on the preview tab ? |
| 07:42:14 | <dkayiwa> preview surface |
| 07:42:23 | <suho> u mean pull new elements ? |
| 07:42:32 | <dkayiwa> oh yes |
| 07:42:35 | <dkayiwa> :D |
| 07:42:45 | <dkayiwa> sorry it was renamed |
| 07:43:03 | <suho> ok done then |
| 07:43:27 | <suho> still the same |
| 07:44:17 | <dkayiwa> can you do a file save as and send me your form? |
| 07:45:16 | *** rafa has quit IRC |
| 07:47:10 | <suho> SEND dkayiwa /home/suho/Desktop/testFile.xml |
| 07:47:35 | <dkayiwa> mail or pastebin |
| 07:48:40 | <suho> i have mailed :) |
| 07:48:55 | <dkayiwa> ok :) |
| 07:48:58 | *** magoo has joined #openmrs |
| 07:50:34 | <dkayiwa> do i start with State/Province? |
| 07:51:15 | <suho> yes State/Province |
| 07:51:21 | <dkayiwa> and next? |
| 07:51:22 | <suho> then city/village |
| 07:51:29 | <suho> then postal code |
| 07:51:40 | <dkayiwa> oh i see |
| 07:52:11 | <dkayiwa> if you use text boxes, then u need to type |
| 07:52:20 | <dkayiwa> means like like auto complete |
| 07:52:27 | <dkayiwa> instead of combo boxes |
| 07:52:32 | <dkayiwa> so after selecting provice |
| 07:52:37 | <dkayiwa> type in city village |
| 07:52:48 | <dkayiwa> but which widget to use, choice is yours |
| 07:53:19 | <suho> thats good i like that |
| 07:53:36 | <suho> and can we have the same for province |
| 07:53:58 | <suho> to auto complete ? |
| 07:54:02 | <dkayiwa> yes |
| 07:54:07 | <suho> how ? |
| 07:54:08 | <dkayiwa> go to design surface |
| 07:54:14 | <dkayiwa> delete the combox widget |
| 07:54:27 | <dkayiwa> and drag drop a text box widget in its place |
| 07:54:47 | <suho> ok got it |
| 07:54:47 | <dkayiwa> make sure you do not forget to set the widget binding using the widget properties pane |
| 07:55:19 | <suho> yes , and to change the other way around need to add the combo box |
| 07:55:25 | <suho> that it right ? |
| 07:55:25 | <dkayiwa> yes |
| 07:55:28 | <dkayiwa> correct |
| 07:55:33 | *** surangak_ has joined #openmrs |
| 07:55:34 | <suho> great like this module |
| 07:55:39 | <suho> :D |
| 07:55:54 | <dkayiwa> it does so poorly on documentation :) |
| 07:56:05 | <dkayiwa> many things are hidden and not known |
| 07:56:08 | <dkayiwa> :) |
| 07:56:14 | *** surangak has quit IRC |
| 07:56:22 | <suho> we'll fox that .. |
| 07:56:36 | <dkayiwa> sure |
| 07:56:53 | <suho> is there any facility to add some calculations before saving |
| 07:57:00 | <dkayiwa> like? |
| 07:57:05 | <dkayiwa> can you give an example? |
| 07:57:28 | <suho> like when 3 is enter in the field 6 need to be saved |
| 07:57:35 | <suho> its like this |
| 07:57:46 | <suho> km and mile convertion |
| 07:58:04 | <suho> the under line concept is km |
| 07:58:31 | <suho> and is the date is in mile need to convert that |
| 07:58:37 | *** rafa has joined #openmrs |
| 07:58:37 | *** ChanServ sets mode: +v rafa |
| 07:59:14 | <suho> we can have a combo box for the type selection |
| 07:59:44 | <dkayiwa> is the calculation done every after each selection? |
| 08:00:20 | <suho> no only before saving |
| 08:00:41 | <suho> i think we can use aop and change that |
| 08:00:57 | <dkayiwa> if the calculation is very simple, then you can use the calculation property on the properties tab |
| 08:01:12 | <dkayiwa> but if its a bit more complicated, you can use the JavaScript tab |
| 08:01:19 | <dkayiwa> it will be saved with the form |
| 08:01:29 | <dkayiwa> i can give you an example to start with |
| 08:01:39 | <suho> it will be great |
| 08:02:14 | <dkayiwa> https://wiki.openmrs.org/display/docs/XForms+Module+Form+Designer |
| 08:02:21 | <OpenMRSBot> <http://ln-s.net/90$F> (at wiki.openmrs.org) |
| 08:02:28 | <dkayiwa> look under JavaScript Tab |
| 08:03:26 | <suho> yes i think thsts good enough |
| 08:03:31 | <dkayiwa> ok |
| 08:04:11 | <dkayiwa> you can drag and drop your widgets on the design surface |
| 08:04:18 | <dkayiwa> to place there where they belong |
| 08:04:31 | <suho> yes i tried that |
| 08:04:33 | <dkayiwa> i can see they are in different areas |
| 08:04:40 | <dkayiwa> ok |
| 08:04:49 | <suho> this one is for a sample |
| 08:04:55 | <dkayiwa> oh i see |
| 08:04:56 | <dkayiwa> cool |
| 08:05:00 | <suho> not the actual one |
| 08:05:19 | <suho> great now i have all what i needed |
| 08:05:35 | <dkayiwa> ok |
| 08:05:59 | <suho> and if you can provide multiple identifier then thats great |
| 08:06:12 | <dkayiwa> ok |
| 08:06:41 | <suho> else help me to do some partial implementation |
| 08:06:47 | <dkayiwa> ok |
| 08:07:03 | <suho> in a nut shell what i need is to have two field |
| 08:07:13 | <dkayiwa> ok |
| 08:07:35 | <suho> one or the prefered notifier (that need no to be changed at each time ) |
| 08:07:46 | <dkayiwa> ok |
| 08:08:07 | <suho> and another test field for the other one |
| 08:08:37 | <suho> and why do we have location to the identifier ? |
| 08:09:01 | <suho> i dont have good understanding on that |
| 08:09:06 | <dkayiwa> meaning? |
| 08:09:39 | <suho> when selecting identifier we also select a location when registering the patient |
| 08:10:05 | <suho> in the default panel |
| 08:10:18 | <suho> (not in xforms) |
| 08:10:38 | <dkayiwa> oh i see |
| 08:10:40 | <dkayiwa> am not sure |
| 08:11:41 | <suho> i dont think i need that to |
| 08:12:55 | <suho> so that it .. Thanks for your time and help :) |
| 08:13:07 | <dkayiwa> you are welcome. :) |
| 08:13:10 | <suho> that really helped me |
| 08:13:33 | <dkayiwa> and thanks for volunteering to do some documentation |
| 08:13:42 | <dkayiwa> which will auto guide others :D |
| 08:14:13 | <suho> yes i'll do that |
| 08:14:20 | <dkayiwa> 8) |
| 08:20:06 | *** bryq has joined #openmrs |
| 08:20:06 | *** ChanServ sets mode: +v bryq |
| 09:04:28 | <magoo> when i add a user to the system the new user cannot log in immediately after creation |
| 09:05:31 | <magoo> its after when i have restarted the application that's when the new user can log in why? |
| 09:12:12 | *** robbyoconnor has quit IRC |
| 09:12:35 | *** robbyoconnor has joined #openmrs |
| 09:12:35 | *** ChanServ sets mode: +v robbyoconnor |
| 09:14:55 | <dkayiwa> magoo: do you get any error messages when the user tries to login? |
| 09:17:39 | <magoo> i just get the error Invalid username/password. Please try again. but when i restart the application and log in |
| 09:17:53 | <magoo> i dont get any error |
| 09:19:23 | <magoo> for me i thought when i create user and after asigning roles its just automatic log on no need to restart the application |
| 09:22:17 | <dkayiwa> magoo: can you try pastebin your tomcat log? |
| 09:22:39 | <dkayiwa> looking at it could tell us what is happening. magoo |
| 09:24:00 | <magoo> okay |
| 09:26:35 | <dkayiwa> ok |
| 09:29:27 | <magoo> i have sent. url is http://pastebin.com/ZLgK4b1a |
| 09:33:56 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): TRUNK-2433: AdministrationService.saveGlobalProperties is dangerous, and should be changed ... <http://feedproxy.google.com/~r/OMRStrunk/~3/gNCrh61v5AQ/OpenMRS> |
| 09:34:31 | <dkayiwa> ok |
| 09:35:10 | <dkayiwa> magoo: which version of openmrs are you using? |
| 09:35:52 | <magoo> the newest 1.8 |
| 09:36:27 | <magoo> 1.8.0.1 |
| 09:36:33 | <dkayiwa> ok |
| 09:37:06 | <dkayiwa> magoo: can you reproduce the problem easily? |
| 09:37:43 | <magoo> how? |
| 09:37:54 | <dkayiwa> if you create a new user now |
| 09:38:03 | <dkayiwa> are you able to login as that user now? |
| 09:41:50 | <magoo> let me try again |
| 09:41:54 | <dkayiwa> ok |
| 09:46:31 | <magoo> yes i can log in but after restarting the entire application |
| 09:48:00 | <dkayiwa> magoo: so you just created a new user and was not able to logic as that user? |
| 09:48:11 | <dkayiwa> after logging out yourself? |
| 09:48:37 | <magoo> yes |
| 09:48:59 | <dkayiwa> after doing that, can you now resend me the error log? |
| 09:49:47 | <dkayiwa> magoo: which role did you give that user? |
| 09:52:15 | <magoo> http://pastebin.com/8ubDQdEt |
| 09:52:20 | <magoo> provider role |
| 09:53:11 | <dkayiwa> strange because i have just done the same and i was able to login |
| 09:54:03 | <magoo> let me create and see what happens again |
| 09:54:08 | <dkayiwa> ok |
| 09:58:58 | <magoo> its fine |
| 09:59:20 | <dkayiwa> what had u done differenly |
| 09:59:21 | <dkayiwa> ? |
| 09:59:38 | <magoo> logged in without restarting |
| 10:00:59 | <magoo> cz it did happen yesterday when i was creating users and i was kind of ignoring it |
| 10:01:09 | <dkayiwa> ok |
| 10:01:40 | <magoo> according to the log file what do u see am doin' wrong? |
| 10:01:47 | <dkayiwa> nothing |
| 10:03:17 | <magoo> hope it won't happen again |
| 10:03:23 | <dkayiwa> ok |
| 10:04:32 | <magoo> i will inform u immediately it happens again |
| 10:04:35 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Improving on the display of handlerConfig <http://feedproxy.google.com/~r/OMRStrunk/~3/XKYeF4oxTiI/OpenMRS> |
| 10:04:38 | <dkayiwa> ok |
| 10:15:09 | <bryq> Hi rafa, are you around? |
| 10:15:20 | <rafa> Hi Piotr |
| 10:16:01 | <bryq> rafa: Look at the ticket: https://tickets.openmrs.org/browse/META-100 |
| 10:16:25 | <rafa> Congrats on you hiting 100! :) |
| 10:16:34 | <bryq> rafa: What exactly do we want the "name" to be? |
| 10:16:51 | <rafa> handler.getName |
| 10:16:55 | <bryq> rafa: It was your great job too :) |
| 10:17:08 | <rafa> It's something to readable to display for the user |
| 10:17:49 | <bryq> rafa: Okay, so that will be for e.g. "Concept" (ConceptHandler.getTypeId(..) ). Right? |
| 10:18:17 | <rafa> no that will be precisely ConceptHandler.getName(...) |
| 10:19:02 | <rafa> typeId is a more friendly name for className |
| 10:19:36 | <rafa> You should be displaying typeId instead of className actually |
| 10:19:55 | <rafa> but store className in the ItemSummary class |
| 10:21:50 | <bryq> rafa: Where I will be displaying the typeId? |
| 10:22:03 | <rafa> It's just that we want to say the user that in the package is Concept (some-uuid-here) HIV for intance |
| 10:22:24 | *** suho has quit IRC |
| 10:22:32 | <rafa> For example when the item is missing |
| 10:22:37 | <rafa> You want to tell which item |
| 10:24:10 | <rafa> and it's better to tell "Concept (some-uuid-here) HIV is missing" rather than "org.openmrs.Concept (some-uuid-here) is missing" |
| 10:24:26 | <bryq> rafa: Ohh, okay. I understand now :) |
| 10:24:43 | <rafa> good |
| 10:25:22 | <rafa> Ohh and remember that it might happen the entire class is missing :) |
| 10:25:25 | <rafa> not just an item |
| 10:25:38 | <rafa> for instance when it came from a module that is no longer present |
| 10:26:24 | <rafa> You would tell the user "HtmlForm (org.openmrs.module.htmlformentry.HtmlForm) type is missing" |
| 10:27:35 | <bryq> rafa: Thanks for reminding it |
| 10:27:37 | <rafa> You'll determine it instantly when you try to get the HtmlForm class by reflection |
| 10:35:39 | *** bwolfe has joined #openmrs |
| 10:35:39 | *** ChanServ sets mode: +o bwolfe |
| 11:00:52 | *** upul` has left #openmrs |
| 11:02:48 | *** james_regen has joined #openmrs |
| 11:02:48 | *** ChanServ sets mode: +v james_regen |
| 11:08:27 | *** surangak_ has quit IRC |
| 11:47:54 | *** bwolfe has quit IRC |
| 11:51:20 | <rafa> dkayiwa: Do you have any idea where can I register a new bean in the ui framework? |
| 11:51:59 | <dkayiwa> rafa: i have no idea |
| 11:52:17 | <dkayiwa> am very newbie to this framework |
| 11:52:22 | <dkayiwa> :) |
| 11:52:33 | <rafa> like all of us :) |
| 11:52:40 | <rafa> well except Darius ;) |
| 11:53:42 | *** bwolfe has joined #openmrs |
| 11:53:42 | *** ChanServ sets mode: +o bwolfe |
| 11:56:07 | <rafa> got it app-config.xml :) |
| 11:56:17 | <dkayiwa> :D but soon we are gonna catch up with him |
| 11:56:20 | <dkayiwa> oh cool |
| 11:58:41 | *** jportela has joined #openmrs |
| 11:58:41 | *** ChanServ sets mode: +v jportela |
| 13:34:06 | *** bwolfe has quit IRC |
| 13:43:04 | *** gbastien has joined #openmrs |
| 13:51:03 | *** bwolfe has joined #openmrs |
| 13:51:03 | *** ChanServ sets mode: +o bwolfe |
| 14:01:11 | <bwolfe> scrum time? |
| 14:01:25 | <bwolfe> djazayeri, wyclif, dkayiwa, rafa |
| 14:01:32 | <rafa> Hello |
| 14:01:37 | <rafa> I'm ready |
| 14:01:38 | <dkayiwa> ;) |
| 14:01:43 | <wyclif> hello |
| 14:02:33 | <bwolfe> 3 of 4 isn't bad :-p |
| 14:02:45 | <bwolfe> darius needs to set his alarm a few minutes earlier... |
| 14:02:46 | <bwolfe> :-) |
| 14:03:00 | <dkayiwa> d:) |
| 14:03:29 | <bwolfe> do you guys have google plug accounts? want to sit on hangout while we go through this? |
| 14:03:36 | <bwolfe> dkayiwa, is that a smiley with a hat? |
| 14:03:51 | <dkayiwa> yes bwolfe :D |
| 14:04:08 | <rafa> bwolfe: I don't have one, but I'd give it a try |
| 14:05:11 | <djazayeri> hi guys |
| 14:06:45 | <dkayiwa> hi djazayeri |
| 14:08:23 | <djazayeri> we'll try doing this via voice |
| 14:08:41 | <djazayeri> can you join Ben's hangout on google+? |
| 14:09:04 | <bwolfe> rafa doesn't have a plus account. |
| 14:09:16 | <djazayeri> hmm, okay, I tried to invite him last week |
| 14:09:54 | <djazayeri> rafa: any luck? |
| 14:10:03 | <rafa> djazayeri: I didn't get your invitation, but I got one from Ben right now. |
| 14:10:08 | <wyclif> i have no google+ account |
| 14:10:25 | <rafa> seems like I'm in |
| 14:10:29 | <bwolfe> wyclif, I sent an invite to your yahoo address. (didn't have your gmail in the contacts g+ was giving me) |
| 14:10:44 | <bwolfe> dkayiwa, I sent one to you as well |
| 14:10:55 | <dkayiwa> yes i remember |
| 14:11:15 | <djazayeri> if you want the invite at a gmail address, let me know which one |
| 14:14:51 | <wyclif> yes |
| 14:14:58 | <wyclif> use the gmail |
| 14:15:13 | <wyclif> am getting the message Google Profiles is not available for your organization. |
| 14:15:22 | <djazayeri> wyclif |
| 14:15:24 | <djazayeri> at gmail? |
| 14:16:38 | <wyclif> i thought you could send it to wyclif@openmrs.org |
| 14:17:12 | <djazayeri> wyclif: email/or pm me your gmail address |
| 14:17:27 | <rafa> guys maybe we can do it with g+ tomorrow. |
| 14:17:48 | <rafa> irc today |
| 14:17:55 | <wyclif> i also think we can do this tomorrow which will give us time to set up accounts today |
| 14:18:04 | <djazayeri> okay, we'll do it tomorrow |
| 14:19:26 | <dkayiwa> sound is breaking here |
| 14:19:30 | <dkayiwa> djazayeri |
| 14:19:33 | <djazayeri> we'll try tomorrow for fun |
| 14:19:38 | <dkayiwa> ok |
| 14:20:01 | <djazayeri> alright, that was a productive use of 20 minutes |
| 14:20:09 | <dkayiwa> :D |
| 14:20:38 | <djazayeri> So, who wants to report first? |
| 14:20:54 | <rafa> I can |
| 14:21:36 | <rafa> Today: Worked on TRUNK-2454 and TRUNK-2453. I was blocked for a moment on uploading files, but forced it to work eventually. The first pass of TRUNK-2454 is ready and it would be great if Darius could review it. Tomorrow: will implement ajax uploading and finish TRUNK-2453. No blockers. |
| 14:21:54 | <djazayeri> !ticket TRUNK-2454 |
| 14:21:58 | <OpenMRSBot> djazayeri: [#TRUNK-2454] 2.x file upload widget - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2454 |
| 14:22:05 | <djazayeri> !ticket TRUNK-2453 |
| 14:22:06 | <OpenMRSBot> djazayeri: [#TRUNK-2453] 2.x Manage Modules page - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2453 |
| 14:22:24 | <rafa> nice :) |
| 14:23:48 | <djazayeri> I'm reviewing the file upload widget now |
| 14:23:59 | <djazayeri> Okay, next? |
| 14:24:21 | <dkayiwa> am working on the TRUNK-2456. still progressing |
| 14:24:38 | <djazayeri> !ticket TRUNK-2456 |
| 14:24:39 | <OpenMRSBot> djazayeri: [#TRUNK-2456] Make Reporting module work as much as possible in 2.x - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2456 |
| 14:24:55 | <djazayeri> okay, what aspect of that are you working on now? |
| 14:25:12 | <dkayiwa> was making DWR calls work |
| 14:25:19 | <djazayeri> okay |
| 14:25:28 | <dkayiwa> after having made .form work |
| 14:25:31 | <djazayeri> how is that going? |
| 14:25:43 | <djazayeri> (I thought that .form already worked...) |
| 14:26:02 | <dkayiwa> i tried out for the xforms module and it did not |
| 14:26:10 | <djazayeri> hmm, okay. |
| 14:26:15 | <dkayiwa> its going on well. just that after you finish one thing, you get another error |
| 14:26:19 | <djazayeri> Does xforms use @Controller-annotated controllers, or xml ones? |
| 14:26:27 | <dkayiwa> xml ones |
| 14:26:32 | <djazayeri> ah, and you got that working? |
| 14:26:37 | <djazayeri> Great! |
| 14:26:38 | <dkayiwa> yes |
| 14:26:46 | <djazayeri> I couldn't figure that out. |
| 14:26:53 | <dkayiwa> but i have a question? |
| 14:27:06 | <djazayeri> Okay, so, yes, I expect that ticket to be string of errors, one after another. |
| 14:27:08 | <djazayeri> yes? |
| 14:27:10 | <dkayiwa> does it mean i need to copy the core DWR classes under compatibility? |
| 14:27:39 | <dkayiwa> under = to |
| 14:27:44 | <djazayeri> Hmm... |
| 14:27:54 | <djazayeri> Sure |
| 14:27:59 | <dkayiwa> ok |
| 14:28:03 | <djazayeri> but if that doesn't work, they can go in webapp |
| 14:28:08 | <dkayiwa> ok |
| 14:28:38 | <dkayiwa> even moduleservlets were not working |
| 14:28:44 | <dkayiwa> so i worked on those too |
| 14:29:10 | <djazayeri> you did that ticket yesterday, right? |
| 14:29:18 | <djazayeri> (module resource, I mean) |
| 14:29:25 | <dkayiwa> yesterday was just module resource |
| 14:29:38 | <djazayeri> oh, module servlets. gotcha |
| 14:29:45 | <dkayiwa> ok |
| 14:29:57 | *** bwolfe sets mode: +v dkayiwa |
| 14:29:58 | <djazayeri> so, daniel, thinking about it, this sounds like a ticket where it would be good to make multiple commits, each time you get a new feature working. |
| 14:30:00 | *** bwolfe sets mode: +v wyclif |
| 14:30:03 | *** bwolfe sets mode: +v pascal` |
| 14:30:14 | <dkayiwa> ok |
| 14:30:18 | <djazayeri> You don't necessarily need to go back and do that |
| 14:30:20 | <dkayiwa> let me do that |
| 14:30:37 | <djazayeri> but I think it will be nicer to code review "just module servlet", and then "just dwr", rather than everything all at once |
| 14:30:51 | <dkayiwa> ok. makes much sense |
| 14:30:56 | <djazayeri> so do try to do multiple commits if that's possible. (and you can do them as soon as they work.) |
| 14:31:01 | <dkayiwa> ok |
| 14:31:05 | <djazayeri> alright, any more questions? |
| 14:31:17 | <dkayiwa> not for now |
| 14:31:25 | <dkayiwa> will ask on IRC as i get them |
| 14:31:50 | <djazayeri> ok. |
| 14:31:54 | <djazayeri> wyclif? |
| 14:32:30 | <wyclif> yesterday: TRUNK-2079, managed to get the init wizard to work |
| 14:32:53 | <wyclif> Today: finish up TRUNK-2079 by integrating the update wiard, pick another ticket |
| 14:33:02 | <wyclif> question: |
| 14:33:22 | <wyclif> currently we are using openmrs2 as the contexpath |
| 14:33:37 | <wyclif> when do we plan switching this back? |
| 14:34:05 | <bwolfe> it should not be hard coded anywhere |
| 14:34:19 | <bwolfe> (I know it is on a few pages now that are not under springs control yet) |
| 14:34:29 | <bwolfe> *it is not on a few pages |
| 14:35:16 | <djazayeri> looks to me that it's hardcoded in login.jsp and chooseRole.jsp, as well as being mentioned in pom.xml's webapp.name |
| 14:36:19 | <djazayeri> I figured we might default to using openmrs2 at the beginning, in case people are running 1.10 and 2.0 side by side |
| 14:36:23 | <djazayeri> but I haven't thought about that much. |
| 14:36:40 | <wyclif> because in the init wizard, it uses WebConstants.WEBAPP_NAME |
| 14:36:48 | <djazayeri> !ticket TRUNK-2079 |
| 14:36:50 | <OpenMRSBot> djazayeri: [#TRUNK-2079] Incorporate liquibase updates and the initialization wizard into the 2.x web application - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2079 |
| 14:37:12 | <bwolfe> WEBAPP_NAME shoudl be set by the Listener. it reads from the current context path and sets it there |
| 14:37:21 | <bwolfe> (at least thats how 1.x does it) |
| 14:37:32 | <djazayeri> wyclif: add that to the startup listener |
| 14:38:02 | <wyclif> ok |
| 14:39:10 | <djazayeri> Also, consider whether it's strictly necessary to use that constant. |
| 14:39:14 | <djazayeri> I don't really like having to do that. |
| 14:39:39 | *** rafa_ has joined #openmrs |
| 14:39:39 | *** ChanServ sets mode: +v rafa_ |
| 14:39:51 | <djazayeri> i.e. see if you can fetch the webapp name out of the servlet context yourself in the wizard. |
| 14:39:59 | <djazayeri> if not, just do what 1.x is doing. |
| 14:40:06 | <bwolfe> djazayeri, you don't like non constant constants? c'mon... |
| 14:40:25 | <djazayeri> wyclif: do you expect that ticket to take all day? |
| 14:40:36 | <djazayeri> bwolfe: can you get on skype? |
| 14:40:39 | <wyclif> i dont think so |
| 14:40:59 | <wyclif> now that i figures out all the changes you had made me |
| 14:41:04 | <djazayeri> :-) |
| 14:41:36 | <wyclif> though this took a while yesterday |
| 14:41:59 | <wyclif> sorry about the typos |
| 14:42:00 | *** rafa has quit IRC |
| 14:42:04 | <djazayeri> np |
| 14:42:11 | <djazayeri> okay, ben, you're up |
| 14:42:22 | <bwolfe> me today: |
| 14:42:23 | <bwolfe> investigated ticket for clinical summary in 1.8 |
| 14:42:23 | <bwolfe> created a bunch occ tickets: |
| 14:42:23 | <bwolfe> !ticket OCC-10 |
| 14:42:23 | <bwolfe> !ticket OCC-60 |
| 14:42:23 | <bwolfe> !ticket OCC-55 |
| 14:42:24 | <OpenMRSBot> bwolfe: [#OCC-60] Develop algorithm for concept priority - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-60 |
| 14:42:25 | <bwolfe> !ticket OCC-58 |
| 14:42:25 | <OpenMRSBot> bwolfe: [#OCC-10] Automatic Name Mapping page - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-10 |
| 14:42:26 | <OpenMRSBot> bwolfe: [#OCC-55] Retain uuid exporting a concept to the OCC server - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-55 |
| 14:42:27 | <OpenMRSBot> bwolfe: [#OCC-58] Automatically map uploaded concepts - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-58 |
| 14:42:27 | <bwolfe> !ticket OCC-56 |
| 14:42:28 | <OpenMRSBot> bwolfe: [#OCC-56] Add ability to export Concepts in 1.6 format - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-56 |
| 14:42:29 | <bwolfe> !ticket OCC-57 |
| 14:42:30 | <OpenMRSBot> bwolfe: [#OCC-57] Make occ module work in 1.6.x - OpenMRS JIRA - https://tickets.openmrs.org/browse/OCC-57 |
| 14:42:31 | <bwolfe> !ticket ITSM-1509 |
| 14:42:33 | <bwolfe> a bit of rest module ticket cleanup |
| 14:42:33 | <OpenMRSBot> bwolfe: OpenMRS JIRA - Log in - https://tickets.openmrs.org/browse/ITSM-1509 |
| 14:42:35 | <bwolfe> !ticket RESTWS-183 |
| 14:42:36 | <OpenMRSBot> bwolfe: [#RESTWS-183] Update hacky swing client example - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-183 |
| 14:42:37 | <bwolfe> !ticket RESTWS-182 |
| 14:42:38 | <OpenMRSBot> bwolfe: [#RESTWS-182] Add unit test to look for hacky conversion - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-182 |
| 14:42:39 | <bwolfe> tomorrow: |
| 14:42:43 | <bwolfe> design conf calls |
| 14:42:45 | <bwolfe> release test tickets (merge it?) |
| 14:42:47 | <bwolfe> ui2 sprinting |
| 14:42:49 | * bwolfe tries to get the bot kicked for flooding... :-) |
| 14:43:11 | *** rafa_ is now known as rafa |
| 14:43:40 | <bwolfe> djazayeri, why do you need me on skype? |
| 14:44:19 | <djazayeri> never mind, was going to catch up on the clinical summary ticket with paul |
| 14:44:24 | <djazayeri> but he says win says it's all good |
| 14:44:39 | <bwolfe> yeah, was the error I pointed out in the email |
| 14:44:51 | <bwolfe> (and which I had suggested to him last night...) |
| 14:44:54 | <djazayeri> I know, but he wanted to talk. |
| 14:44:58 | <djazayeri> anyway |
| 14:44:58 | <bwolfe> ah |
| 14:45:10 | <djazayeri> bwolfe: I don't think that mechanism of pasting !ticket a bunch of times reads very well, at least not in my client |
| 14:45:26 | <bwolfe> ampath has schedule their upgrade to 1.8 for this weekend, so thats the reason for the panic |
| 14:45:44 | <bwolfe> no, it doesn't...but that was an excessive number of tickets. |
| 14:45:51 | <bwolfe> if I only had a few I worked on it'd be ok |
| 14:46:16 | <bwolfe> heh, ITSM-1509 is protected apparently |
| 14:47:25 | <djazayeri> okay. |
| 14:47:28 | <djazayeri> blockers? |
| 14:48:09 | <bwolfe> not really. a few tickets that will need some design review thinking cycles. but I wrote them up as I would solve it. :-) |
| 14:48:26 | <djazayeri> okay, point us to them if you want more opinions. |
| 14:48:28 | <djazayeri> my turn: |
| 14:48:36 | <djazayeri> Monday: |
| 14:48:37 | <djazayeri> * 2.x UI sprint code reviews |
| 14:48:37 | <djazayeri> * Finished letting 1.x modules wrap existing pages as 2.x "pages" (took all day, partly my own fault) |
| 14:48:37 | <djazayeri> Today: |
| 14:48:37 | <djazayeri> * more code review |
| 14:48:37 | <djazayeri> * Work on letting 1.x modules warp existing porlets as 2.x "fragments" |
| 14:48:38 | <djazayeri> * Thoughtworks Code Jam |
| 14:49:15 | <bwolfe> there you go with the warping again. :-p |
| 14:49:35 | <djazayeri> copy + paste -> bugs |
| 14:50:23 | <djazayeri> no blockers for me |
| 14:50:36 | <djazayeri> okay, any other questions/comments from anyone? |
| 14:51:10 | <bwolfe> looks like a no |
| 14:51:21 | <djazayeri> okay, thanks everyone |
| 14:51:36 | <bwolfe> lata |
| 14:52:21 | *** goutham has joined #openmrs |
| 14:53:00 | <djazayeri> bwolfe & wyclif: I think we need to release 1.8.2 very soon, with a fix for the "last 3" -> "first 3" |
| 14:53:06 | <djazayeri> that seems like a near-blocker to me. |
| 14:53:26 | <wyclif> i agree |
| 14:54:24 | <djazayeri> bwolfe: you investigated and determined the problem. |
| 14:54:35 | <djazayeri> did you solve it already? or did you propose a solution? |
| 14:54:49 | <wyclif> i proposed a solution |
| 14:54:52 | <djazayeri> also, wyclif, can you please "release" the 1.8.1 version in jira? |
| 14:54:55 | <wyclif> am not sure if he worked on it |
| 14:55:06 | <wyclif> i did |
| 14:55:21 | <wyclif> unless what i did is not what you mean |
| 14:55:49 | <djazayeri> as of yesterday, when I am assigning a fixVersion to a ticket, it shows 1.8.1 as unreleased |
| 14:56:24 | <wyclif> so how do i release one in Jira, i have never done it before |
| 14:56:38 | <djazayeri> go into JIRA |
| 14:56:43 | <djazayeri> view any ticket in the TRUNK project |
| 14:57:05 | <djazayeri> then, in the "Administration" menu, "Project: OpenMRS Trunk" |
| 14:57:10 | <djazayeri> then Manage version |
| 14:57:20 | <djazayeri> see if you have privs to do all that |
| 15:00:00 | <djazayeri> bwolfe, wyclif: okay, so TRUNK-2465 is a blocker |
| 15:01:08 | <wyclif> done with releasing in Jira |
| 15:01:14 | <wyclif> thanks |
| 15:01:16 | <djazayeri> wyclif: I don't see a proposed solution by you on that ticket. |
| 15:01:21 | <djazayeri> are we talking about something else? |
| 15:01:56 | <wyclif> i meant am done with releasing 1.8.1 in Jira |
| 15:03:11 | <wyclif> as for TRUNK-2465, we need to change the form entry tab not use use the value of the var attribute but rather call the API for the last three encounters |
| 15:03:30 | <wyclif> and set sortByNames to false |
| 15:03:32 | <djazayeri> okay, wyclif, can you actually make that your top priority ticket? |
| 15:03:43 | <wyclif> sure |
| 15:03:58 | <djazayeri> to do ASAP, even before sprint tickets |
| 15:03:58 | <djazayeri> thanks |
| 15:04:14 | <wyclif> i will do it after my current sprint ticket |
| 15:04:39 | <djazayeri> no, do it now |
| 15:04:49 | <wyclif> ok |
| 15:05:01 | *** dkayiwa has quit IRC |
| 15:05:14 | <djazayeri> (blocker tickets for our current release line take precedence over everything else) |
| 15:05:27 | <djazayeri> (and telling people |
| 15:05:42 | <djazayeri> and telling people "actually, don't use 1.8.1" is a blocker. ;-) |
| 15:10:54 | *** jwishnie has joined #openmrs |
| 15:11:59 | <wyclif> got you |
| 15:51:58 | *** rafa has quit IRC |
| 15:56:03 | *** asgoyal has joined #openmrs |
| 16:04:35 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Facility Data 2.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=facilitydata&version=&2.0.1> |
| 16:13:21 | *** suho has joined #openmrs |
| 16:13:21 | *** ChanServ sets mode: +v suho |
| 16:21:14 | *** goutham has quit IRC |
| 16:25:04 | *** magoo has quit IRC |
| 16:37:49 | <bwolfe> djazayeri / wyclif : win has a fix for that 1.8.2 release as well |
| 16:38:28 | <djazayeri> bwolfe: the asm dependency one? |
| 16:38:31 | <bwolfe> yeah |
| 16:38:49 | <djazayeri> okay, seems appropriate to me |
| 16:45:20 | *** Suranga has joined #openmrs |
| 16:46:09 | <djazayeri> bwolfe: when he creates a ticket for it (or you do)... |
| 16:47:24 | *** goutham has joined #openmrs |
| 16:57:19 | <wyclif> is that for trunk-2465? |
| 17:00:28 | *** goutham has quit IRC |
| 17:12:36 | <djazayeri> wyclif: no |
| 17:16:48 | *** asgoyal has quit IRC |
| 17:19:37 | <wyclif> ok |
| 17:30:37 | *** rafa has joined #openmrs |
| 17:30:37 | *** ChanServ sets mode: +v rafa |
| 17:38:20 | <djazayeri> rafa: what sort of command object properties would we actually want to use a file upload for? |
| 17:38:38 | <djazayeri> I was originally thinking java.io.File, but I'm not sure that's the main use case. |
| 17:38:56 | <djazayeri> Maybe (File)InputStream? |
| 17:39:02 | <djazayeri> or byte[]? |
| 17:44:45 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @gauravpaliwal Glad you could recover! <http://twitter.com/OpenMRS/statuses/93364827665338369> |
| 17:45:15 | *** rafa has quit IRC |
| 17:57:03 | *** pascal` has quit IRC |
| 17:59:09 | *** wyclif has quit IRC |
| 18:01:31 | *** gbastien has quit IRC |
| 18:08:17 | *** suho has quit IRC |
| 18:20:13 | *** gbastien has joined #openmrs |
| 18:22:01 | *** vchircu has joined #openmrs |
| 18:26:35 | *** jportela has quit IRC |
| 18:43:48 | *** dkayiwa has joined #openmrs |
| 18:44:47 | <bwolfe> I think "ben koech" is the only other "Ben" in the last 6 years! |
| 18:44:53 | <bwolfe> (he just wrote to the impl list) |
| 18:47:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting 0.6.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reporting&version=&0.6.2> |
| 18:51:03 | <Suranga> last 6 years == since openmrs was launched, isnt it :) |
| 18:52:45 | <bwolfe> yep! |
| 18:58:55 | *** dkayiwa has quit IRC |
| 19:01:03 | *** jportela has joined #openmrs |
| 19:01:03 | *** ChanServ sets mode: +v jportela |
| 19:01:36 | *** bryq has quit IRC |
| 19:03:12 | *** bryq has joined #openmrs |
| 19:03:12 | *** ChanServ sets mode: +v bryq |
| 19:10:32 | *** dkayiwa has joined #openmrs |
| 19:26:22 | *** wyclif has joined #openmrs |
| 19:26:59 | <Suranga> mmm... i just managed to fix a really embarassing bug (Phew!) |
| 19:27:24 | <djazayeri> dkayiwa: are you working on DWR in 2.x? |
| 19:27:33 | <djazayeri> I see TRUNK-2462 about that, maybe a duplicate ticket? |
| 19:27:33 | <dkayiwa> yes |
| 19:27:48 | <dkayiwa> its not duplicate |
| 19:28:19 | <dkayiwa> while working on TRUNK-2456, i just found myself getting DWR errors |
| 19:28:42 | <djazayeri> okay, my point is that TRUNK-2462 is about doing DWR, and it's currently Ready For Work |
| 19:28:44 | <dkayiwa> so that why i also worked on DWR. Never knew that it had its own ticket: djazayeri |
| 19:28:48 | <djazayeri> so you should claim it |
| 19:28:56 | <dkayiwa> ok let me claim it immediately |
| 19:29:10 | <djazayeri> wyclif: were you able to deal with the blocker issues? |
| 19:29:21 | <djazayeri> well, one issue |
| 19:29:32 | <wyclif> about to |
| 19:29:36 | <djazayeri> okay |
| 19:30:12 | <djazayeri> Btw, there's a new ticket with a minor change to pom.xml in 1.8.2. Can you do that while you'd in the area? |
| 19:40:41 | *** Suranga has quit IRC |
| 19:43:16 | *** vchircu has quit IRC |
| 19:43:31 | <djazayeri> wyclif: I wasn't explicit about this earlier, but your job today is to release 1.8.2 |
| 19:43:42 | <djazayeri> (win may actually be committing that other fix) |
| 19:43:50 | *** bryq has quit IRC |
| 19:43:57 | <wyclif> what is win fixing? |
| 19:44:19 | <wyclif> 1.8.2 should be out today, right? |
| 19:44:20 | <djazayeri> the asm-related ticket, that's also assigned to 1.8.2 |
| 19:44:26 | <djazayeri> yes, that's the idea |
| 19:45:01 | <djazayeri> we should also write a regression test for the last-3-encounters thing |
| 19:45:50 | *** bryq has joined #openmrs |
| 19:45:50 | *** ChanServ sets mode: +v bryq |
| 19:45:56 | <djazayeri> anyway, let me know when the last-3 ticket is fixed and I'll code review |
| 19:46:34 | *** rafa has joined #openmrs |
| 19:46:34 | *** ChanServ sets mode: +v rafa |
| 19:48:04 | *** james_regen has quit IRC |
| 19:48:51 | *** rafa has quit IRC |
| 20:07:05 | <djazayeri> dkayiwa: are you working on 1.x portlets in 2.x yet? |
| 20:07:42 | <dkayiwa> djazayeri: not yet touched portlets |
| 20:07:46 | <djazayeri> okay |
| 20:07:52 | <djazayeri> I may. If I do I'll comment on your ticket |
| 20:07:57 | <dkayiwa> ok |
| 20:24:59 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Address Hierarchy 2.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=addresshierarchy&version=&2.1> |
| 20:38:42 | *** jwishnie has quit IRC |
| 20:51:46 | *** Echidna has quit IRC |
| 20:56:20 | *** Echidna has joined #openmrs |
| 20:56:20 | *** ChanServ sets mode: +v Echidna |
| 20:58:17 | *** dkayiwa has quit IRC |
| 21:15:54 | *** dkayiwa has joined #openmrs |
| 21:16:16 | *** jwishnie has joined #openmrs |
| 21:33:41 | <djazayeri> wyclif: how goes it? |
| 21:35:31 | <wyclif> djazayeri, it kind of tricky to figure out what to deprecate and what to not deprecate given that it seems like the methods i have added to the service layer is actually supposed to be deprecated in 1.9 and not in 1.8 |
| 21:35:55 | <djazayeri> What method are you adding? |
| 21:36:09 | <djazayeri> (IIRC Ben and I didn't like the change of sort order in the first place...) |
| 21:36:46 | <wyclif> i think the easiest fix is to just change back the sort order in 1.8 |
| 21:37:00 | <wyclif> and them we fix this as a 1.9 ticket |
| 21:37:12 | <wyclif> because there are changes in 1.9 |
| 21:37:21 | <djazayeri> That sounds right to me. Remind me what the original ticket is? |
| 21:37:29 | <djazayeri> the one where we changed sort order? |
| 21:37:34 | <wyclif> so trying to fix it in 1.9 kind of conflicts |
| 21:37:58 | <wyclif> 2465 |
| 21:38:49 | <wyclif> first of all it makes sense to always have these encounters sorted in descending order for most use cases |
| 21:39:30 | <wyclif> apparently none of the tickets mentioned to have affected this changed the order |
| 21:40:08 | <djazayeri> but you changed an underlying hibernate query in one of them, right? |
| 21:40:20 | <wyclif> nope |
| 21:40:40 | <wyclif> i only changed for the methods that searches by string |
| 21:41:26 | <wyclif> even in that case i actually didnt changed, i changed sort by name to be optional |
| 21:41:30 | <djazayeri> what's the name of the form entry portlet? |
| 21:41:57 | <wyclif> PersonFormEntryPortletController |
| 21:42:45 | <wyclif> so the solution ben was suggesting was to add 3 extra arguments to getEncounters(Patient.., Date...) |
| 21:42:59 | <wyclif> and adding an argument for setting the sort order |
| 21:43:04 | <wyclif> and add paging to it |
| 21:44:13 | <wyclif> i would suggest having this full implementation in 1.9 and for 1.8.2 we just change the sort order to desc in the DAO |
| 21:44:21 | <djazayeri> just opening up that portlet to look at it |
| 21:44:51 | <wyclif> the portlet uses the list of controllers set in PortletController as referenced data |
| 21:45:00 | <wyclif> so it actually does nothing |
| 21:45:12 | <wyclif> in setting the encounters |
| 21:46:37 | <djazayeri> it uses <openmrs:forEachEncounter> right? |
| 21:46:45 | <wyclif> yes |
| 21:47:10 | <djazayeri> ah, but it uses the encounters from the model |
| 21:47:20 | <wyclif> if am to do what Ben suggested, then it would still better to do it on the Branch and not in trunk and backport as we normally do |
| 21:47:36 | <wyclif> yes |
| 21:48:57 | <djazayeri> isn't the bug in the ForEachEncounter tag? That has a sortBy attribute which seems to be failing |
| 21:51:07 | <djazayeri> i.e. the sorting happens _after_ num is handled |
| 21:51:10 | <djazayeri> but it should happen before |
| 21:51:43 | <djazayeri> isn't the solution as easy as moving the "// Next, sort the encounters" segment of code to be first? |
| 21:52:13 | <wyclif> that is ok but that is not what Ben had suggested |
| 21:52:22 | <wyclif> but i would prefer that |
| 21:53:26 | <djazayeri> Does the EncounterService method that Ben is describing exist already? |
| 21:53:42 | <djazayeri> or are you saying the problem is that you'd have to write that, and it gets annoying? |
| 21:54:20 | <wyclif> yes |
| 21:54:56 | <djazayeri> I actually disagree with Ben. He's suggesting we do another service call, which would be another SQL query. Instead we should use the (too many) results we already have from the SQL query already done by portlet controllers |
| 21:55:05 | <wyclif> it gets annoying because it will be deprecated immediately in 1.9 because the methods we want to overload is already deprecated itself |
| 21:55:32 | <djazayeri> Okay, so do the easy fix and make ForEachEncounterTag work correctly, by sorting first, then limiting. |
| 21:56:13 | <wyclif> right |
| 21:56:23 | <djazayeri> Actually, though, sorry, one other thought |
| 21:56:41 | <wyclif> or to change the sort order in the query |
| 21:56:44 | <djazayeri> You changed the sort order of EncounterService.getEncountersByPatient(Patient)? |
| 21:57:05 | <wyclif> not in 1.8. |
| 21:57:22 | <djazayeri> well, that delegates to getEncounters(patient, null, null, null, null, null, null, false) |
| 21:57:34 | <wyclif> and i never changed that |
| 21:57:54 | <djazayeri> then when did the sort order change to be sorted by patient name instead of date? |
| 21:58:29 | <wyclif> the only changed i made was to PersonSearchCriteria to sort by names which is by the getEncounters(String..) |
| 21:59:02 | <djazayeri> I see. |
| 21:59:16 | <djazayeri> So, maybe Ben broke this himself. :-) |
| 21:59:36 | <wyclif> the bug is that the limit is done before the sorting and this was introduced in 1.8.1 and that is why ther bug isn't in 1.8.0 |
| 21:59:49 | <djazayeri> Yes. Okay, so do the sorting first. |
| 21:59:57 | <djazayeri> Fix the actual bug introduced, in the least invasive way possible. |
| 22:00:17 | <djazayeri> And add a unit test for this on the ForEachEncounterTag class. |
| 22:00:59 | <djazayeri> I mean: fix this in ForEachEncounterTag. Don't touch the service layer. |
| 22:03:28 | <djazayeri> wyclif: cool? |
| 22:04:11 | <wyclif> ok |
| 22:09:30 | <wyclif> there is also that bug on the concetpt stats page |
| 22:09:44 | <djazayeri> That's not a blocker. |
| 22:09:56 | <djazayeri> It can wait. |
| 22:11:48 | *** bryq has quit IRC |
| 22:13:29 | <wyclif> and then the other thin gis that we always need to decide the release date like a day before |
| 22:13:52 | <djazayeri> you mean about 1.8.1 or 1.8.2? |
| 22:14:13 | <djazayeri> 1.8.2 can wait until tomorrow. You don't have to work until midnight on it today... |
| 22:14:14 | <wyclif> because now i have to let Michael know since he has to make changes to certain pages on openmrs.org |
| 22:14:38 | <djazayeri> Hmmâ¦okay, well, we need a better process than that. |
| 22:14:47 | <djazayeri> we should discuss that over email though. |
| 22:15:01 | <wyclif> so if i can let him know now, then we will be ready to do it with me tomorrow |
| 22:15:12 | <djazayeri> anyway, it's fine if that happens the next day, right? |
| 22:15:28 | <wyclif> yeah, |
| 22:15:30 | <djazayeri> but sure, tell him now. |
| 22:16:16 | <wyclif> ok |
| 22:16:21 | <wyclif> so this is fixed |
| 22:16:43 | <djazayeri> You committed code you mean? |
| 22:17:38 | <wyclif> oh, you said i should add a test for the forEachEncounterTag? |
| 22:17:48 | <djazayeri> would be nice |
| 22:22:11 | *** dkayiwa has quit IRC |
| 22:22:16 | *** gbastien has quit IRC |
| 22:44:43 | *** jwishnie has quit IRC |
| 22:50:01 | *** jwishnie has joined #openmrs |
| 23:00:14 | *** gbastien has joined #openmrs |
| 23:57:16 | *** yanokwa has joined #openmrs |
| 23:57:16 | *** ChanServ sets mode: +v yanokwa |