01:31:30
|
*** suho has joined #openmrs
|
01:31:30
|
*** ChanServ sets mode: +v suho
|
01:46:27
|
*** jwishnie has quit IRC
|
02:23:33
|
*** suho has quit IRC
|
03:05:31
|
*** saimanohar has joined #openmrs
|
03:06:49
|
<saimanohar> Hi all,can i get some help on addresslayout portlet
|
03:07:04
|
<saimanohar> anybody around?
|
03:47:58
|
*** mathiaslin has joined #openmrs
|
04:05:08
|
*** saimanohar has quit IRC
|
04:35:10
|
*** surangak has joined #openmrs
|
05:49:28
|
*** magoo has joined #openmrs
|
06:04:58
|
*** magoo has quit IRC
|
06:21:03
|
*** muthah has joined #openmrs
|
06:21:14
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating ObsTest.java with unit tests to test complexValueText and complexValueKey <http://feedproxy.google.com/~r/OMRStrunk/~3/bZLuDMWPnIA/OpenMRS>
|
06:28:03
|
*** yanokwa has joined #openmrs
|
06:28:03
|
*** ChanServ sets mode: +v yanokwa
|
06:33:11
|
*** dkayiwa has joined #openmrs
|
06:34:25
|
*** magoo has joined #openmrs
|
06:53:44
|
*** magoo has quit IRC
|
06:54:44
|
*** rafa has joined #openmrs
|
06:54:44
|
*** ChanServ sets mode: +v rafa
|
06:55:11
|
*** danielf` has joined #openmrs
|
06:55:11
|
*** ChanServ sets mode: +v danielf`
|
07:00:25
|
*** muthah has quit IRC
|
07:03:26
|
*** bwolfe has joined #openmrs
|
07:03:26
|
*** ChanServ sets mode: +o bwolfe
|
07:03:34
|
*** mathiaslin has quit IRC
|
07:03:56
|
*** bwolfe sets mode: +v dkayiwa
|
07:03:59
|
<bwolfe> dkayiwa, you around?
|
07:04:12
|
<dkayiwa> bwolfe yes :)
|
07:04:21
|
<bwolfe> missed you on Friday...
|
07:04:31
|
<dkayiwa> oh yes
|
07:05:34
|
<dkayiwa> i went to the bank, the to forex bearau to change my money, and got caught up in alot o shopping :)
|
07:06:28
|
<bwolfe> ah
|
07:06:43
|
<bwolfe> so a holiday in the afternoon then? np
|
07:07:00
|
<bwolfe> did you get my email about the scrum?
|
07:07:12
|
<dkayiwa> yes unplanned one. yes i was about to reply
|
07:13:28
|
<bwolfe> ah, ok
|
07:18:01
|
*** pascal` has joined #openmrs
|
07:27:11
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating branch to Revision 21436 <http://feedproxy.google.com/~r/OMRStrunk/~3/ajfQoeoRZug/OpenMRS>
|
07:38:32
|
<surangak> thanks bot !
|
07:59:20
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating branch to Revision 21503 (It missed rev. 21502- check that) <http://feedproxy.google.com/~r/OMRStrunk/~3/iIdwCj5YNkM/OpenMRS>
|
08:02:08
|
*** ChanServ sets mode: +v pascal`
|
08:12:36
|
*** upul` has joined #openmrs
|
08:12:36
|
*** ChanServ sets mode: +v upul`
|
08:29:38
|
*** bryq has joined #openmrs
|
08:29:39
|
*** ChanServ sets mode: +v bryq
|
08:50:54
|
*** magoo has joined #openmrs
|
08:52:22
|
<magoo> is it possible for someone to login into the system anonymously?
|
08:52:43
|
<bwolfe> magoo, you mean "access" it anonymously? yes
|
08:54:30
|
<magoo> why login anonymously?
|
08:55:13
|
<bwolfe> if you "login" it is not anonymous
|
08:55:58
|
<bwolfe> but you might want to allow concepts to be viewed anonymously
|
08:56:13
|
<bwolfe> just assign privileges to teh Anonymous role
|
08:56:14
|
<magoo> okay ,so who are the anonymous user?
|
08:56:15
|
<bwolfe> brb
|
08:57:22
|
<magoo> because for me i thought i was a security risk for someone to login anonymously
|
08:57:57
|
<magoo> but if its for viewing the concept dictionary i think that's okay
|
09:03:17
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating branch to Revision 21621 <http://feedproxy.google.com/~r/OMRStrunk/~3/uEyE8w5ZFis/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating branch to Revision 21584 <http://feedproxy.google.com/~r/OMRStrunk/~3/faKQYsRQ6N8/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating branch to Revision 21540 <http://feedproxy.google.com/~r/OMRStrunk/~3/TId-01kh6Yo/OpenMRS>
|
09:16:16
|
*** bryq1 has joined #openmrs
|
09:18:01
|
*** bryq has quit IRC
|
09:39:54
|
*** goutham has joined #openmrs
|
09:42:49
|
<bwolfe> magoo, you as an admin define what can be seen by somone who is not logged in. everything in openmrs has a privilege attached to it. if the user (or anonymous user) doesn't have that privielge then they cannot see it
|
09:43:56
|
<magoo> okay ifarct i was setting up roles
|
10:05:25
|
*** suho has joined #openmrs
|
10:05:25
|
*** ChanServ sets mode: +v suho
|
10:14:53
|
*** suho has quit IRC
|
10:19:04
|
*** magoo has quit IRC
|
10:39:33
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): IN PROGRESS - issue TRUNK-2433: AdministrationService.saveGlobalProperties is dangerous, and should be changed ... <http://feedproxy.google.com/~r/OMRStrunk/~3/S9JsKMzIqnE/OpenMRS>
|
10:43:20
|
*** jportela has joined #openmrs
|
10:43:20
|
*** ChanServ sets mode: +v jportela
|
11:09:00
|
*** bwolfe has quit IRC
|
11:10:29
|
*** james_regen has joined #openmrs
|
11:10:29
|
*** ChanServ sets mode: +v james_regen
|
11:11:35
|
*** upul` has left #openmrs
|
11:14:35
|
*** surangak_ has joined #openmrs
|
11:14:35
|
*** surangak has quit IRC
|
11:17:44
|
*** bwolfe has joined #openmrs
|
11:17:44
|
*** ChanServ sets mode: +o bwolfe
|
11:23:27
|
*** surangak_ has quit IRC
|
11:33:54
|
*** magoo has joined #openmrs
|
11:36:25
|
<bwolfe> dkayiwa, rafa, are you getting an error about USER_DECLARED_METHODS on the ui2 project?
|
11:36:40
|
<dkayiwa> no
|
11:36:49
|
<bwolfe> grr
|
11:42:40
|
<bwolfe> dkayiwa, have you done an svn update since hte last spring, or are you using the old code? (if you haven't, don't do it now)
|
11:42:53
|
<bwolfe> looks like its a spring 3.0.5 issue, which would have been since the last spring
|
11:43:13
|
<dkayiwa> i updated today morning
|
11:43:51
|
<bwolfe> double grr
|
11:44:15
|
<dkayiwa> got some errors with SimpleObject not known and the went away after maven update dependencies and project configurations
|
11:45:10
|
<dkayiwa> on running , i got logic module errors
|
11:45:54
|
<dkayiwa> the checked out logic module, commented out a method call, redeployed, and all became well
|
12:13:47
|
*** gbastien has joined #openmrs
|
12:18:05
|
*** bwolfe has quit IRC
|
12:19:18
|
<rafa> It's all fine for me :)
|
12:19:28
|
<rafa> ups, bwolfe is away
|
12:19:38
|
<dkayiwa> :O
|
12:24:39
|
*** bwolfe has joined #openmrs
|
12:24:40
|
*** ChanServ sets mode: +o bwolfe
|
12:25:36
|
*** downeym has joined #openmrs
|
12:25:36
|
*** ChanServ sets mode: +o downeym
|
12:25:36
|
*** OpenMRSBot sets mode: +o downeym
|
12:38:43
|
*** dkayiwa has quit IRC
|
12:42:26
|
*** goutham has quit IRC
|
13:02:55
|
<rafa> bwolfe: Groovy question: row."${ it.property }". Why are quotes there?
|
13:03:05
|
*** dkayiwa has joined #openmrs
|
13:08:25
|
*** asgoyal has joined #openmrs
|
13:14:22
|
*** goutham has joined #openmrs
|
13:18:26
|
*** dkayiwa has quit IRC
|
13:20:23
|
*** wluyima has joined #openmrs
|
13:23:09
|
*** cta has joined #openmrs
|
13:27:32
|
*** goutham has quit IRC
|
13:28:05
|
<cta> wluyima: Hello, Wyclif! I have already read your last comment on TRUNK-2458 ticket and I think that it would not hurt if we will do this ticket within my branch because it closely related to it and we will probably merge my branch into trunk in next 2 weeks. SO, can we left it as is?
|
13:28:53
|
<wluyima> no, that is not how we dot it
|
13:29:19
|
<wluyima> you have to commit it to trunk and back port it since it is a trunk ticket
|
13:29:27
|
<pascal`> wluyima++
|
13:29:29
|
<wluyima> there are reasons for this
|
13:30:31
|
<cta> wluyima: Ok, Wyclif! Will be done ;-)
|
13:30:39
|
<wluyima> cta, thanks
|
13:30:54
|
<bwolfe> rafa, I think its just for explicitness
|
13:30:59
|
<wluyima> basically, just create a patch and attach it to the ticket
|
13:31:08
|
<bwolfe> rafa, the "step by step" tutorial says something about it
|
13:31:34
|
<wluyima> it gets reviewed, then you can merge it to your branch
|
13:31:46
|
<rafa> bwolfe: I need to read it again I guess. I don't remember...
|
13:32:21
|
<bwolfe> for shame
|
13:41:53
|
*** shyam057cs has joined #openmrs
|
13:42:01
|
<downeym> Hi shyam057cs and welcome to the #openmrs IRC channel.
|
13:42:24
|
<shyam057cs> thanks downeym :)
|
13:42:44
|
<shyam057cs> its my first time here..just checking it out
|
13:44:15
|
<downeym> shyam057cs: feel free to hang out as long as you like :)
|
13:44:30
|
*** downeym sets mode: +v wluyima
|
13:44:34
|
*** downeym sets mode: +v cta
|
13:44:36
|
*** downeym sets mode: +v asgoyal
|
13:44:38
|
*** downeym sets mode: +v bryq1
|
13:47:22
|
<bwolfe> shyam057cs, downeym, there is a daily lurking rate of 2 USD
|
13:48:17
|
<downeym> bwolfe: you wish
|
13:49:46
|
* bwolfe would be rich
|
13:54:49
|
<pascal`> bwolfe, do you know anything about setting the image directory in the BIRT HTMLRenderContext?
|
13:55:13
|
<pascal`> I'm seeing 5 Jul 2011 7:29:10 PM org.eclipse.birt.report.engine.api.HTMLServerImageHandler handleImage
|
13:55:14
|
<pascal`> SEVERE: imageURL or ImageDIR is not set!
|
13:55:14
|
<pascal`> when I try and render my reponrts to HTML.
|
13:55:23
|
<bwolfe> pascal`, nope
|
14:04:13
|
<djazayeri> hi all
|
14:04:14
|
<djazayeri> \
|
14:04:34
|
<djazayeri> hi bwolfe, rafa, wluyima
|
14:04:38
|
<bwolfe> was that wave without a body djazayeri?
|
14:04:44
|
<rafa> Hi djazayeri!
|
14:05:17
|
<djazayeri> hope you all had good weekends
|
14:05:44
|
<wluyima> hi
|
14:06:36
|
<bwolfe> good enough. sounds like yours was extra pleasant...
|
14:06:50
|
<djazayeri> Mine was good.
|
14:06:56
|
<djazayeri> So, sprint kickoff...
|
14:07:25
|
<djazayeri> I see that ben, Daniel, and Rafa have all picked up tickets already
|
14:08:22
|
<djazayeri> any questions?
|
14:08:36
|
*** bryq has joined #openmrs
|
14:08:36
|
*** ChanServ sets mode: +v bryq
|
14:08:44
|
<djazayeri> rafa, did you get your question answered about row."property"?
|
14:08:53
|
<rafa> yes, thanks :)
|
14:10:15
|
<rafa> All clear!
|
14:10:38
|
<djazayeri> Great.
|
14:10:50
|
<djazayeri> rafa: congrats on having the first completed-and-approved ticket of the sprint.
|
14:10:57
|
*** bryq1 has quit IRC
|
14:11:27
|
<shyam057cs> gotta say..i'm really proud to be get started with a noble cause like this.. :)
|
14:11:30
|
<djazayeri> Of course it was only one line of code...
|
14:11:35
|
<rafa> djazayeri: I didn't know it's been approved already, nice :)
|
14:11:40
|
<rafa> ;)
|
14:12:12
|
<rafa> djazayeri: no worries, I picked up two others :D
|
14:12:27
|
*** shyam057cs has quit IRC
|
14:12:32
|
<rafa> btw here's my worklog:
|
14:12:38
|
<rafa> Today: Added javadocs for RESTWS-153, did TRUNK-2433, TRUNK-2223. Reported TRUNK-2466.
|
14:12:38
|
<rafa> Tomorrow: Will work on TRUNK-2454, TRUNK-2453.
|
14:12:40
|
<rafa> No blockers.
|
14:13:49
|
<rafa> djazayeri: Do you rely on me inventing the UI for TRUNK-2453 or maybe you've got some ideas alredy?
|
14:14:09
|
<djazayeri> is that Manage Modules?
|
14:14:12
|
<rafa> yes
|
14:14:55
|
<bwolfe> darius always has ideas. thats a silly question
|
14:15:26
|
<rafa> bwolfe: oh right, my bad :D
|
14:15:50
|
*** dkayiwa has joined #openmrs
|
14:16:24
|
<djazayeri> I made some mockups for this 1+ years ago
|
14:16:26
|
<djazayeri> https://tickets.openmrs.org/browse/TRUNK-336
|
14:17:02
|
<rafa> djazayeri: cool do you still agree with them?
|
14:17:23
|
<djazayeri> For now I'm most interested that you be able to start/stop modules at all. I.e. better to quickly code something that works (and may be ugly) than to take longer coding something perfect
|
14:17:57
|
<rafa> djazayeri: Ok, clear
|
14:18:17
|
<rafa> I'm done.
|
14:18:24
|
<djazayeri> Done doing it?
|
14:18:28
|
<djazayeri> or done with questions?
|
14:18:34
|
<rafa> Done with questions ;)
|
14:18:42
|
* bwolfe apologizes for any/all spaghetti code in ModuleListController :-/
|
14:19:00
|
<djazayeri> The only thing I would like to get right is that uploading an omod should be done through the same widget regardless of whether it's "add" or "upgrade"
|
14:19:09
|
<rafa> bwolfe: Taken ;)
|
14:19:10
|
<wluyima> i picked up TRUNK-2079
|
14:20:21
|
<rafa> bwolfe: Accepted, I meant ;)
|
14:20:33
|
<wluyima> and i still don't know why we need a separate changelog file
|
14:20:38
|
<djazayeri> wluyima: great, I was hoping for that
|
14:20:39
|
<rafa> djazayeri: sure, i'll do that
|
14:21:14
|
<bwolfe> wluyima, becuase the api has its own changelog file
|
14:21:43
|
<djazayeri> wluyima: the idea is that going forwards we're going to have a more explicit distinction between what's in the API and what's in the Application.
|
14:22:44
|
<wluyima> i think i get the idea, now that i recall there are certain tables in the DB that are specific to the UI
|
14:22:53
|
<djazayeri> e.g. a table that stores things the user has marked as "my favorites" in the application is an application-level table
|
14:23:00
|
<wluyima> got you
|
14:23:08
|
<djazayeri> or the page mappings for what role sees what home page
|
14:23:47
|
<djazayeri> It needs to run *both* liquibase db upgrade scripts
|
14:24:33
|
<djazayeri> It may be worthwhile to actually refactor the upgrade wizard in *core* first, and then copy-paste that to 2.x
|
14:24:46
|
<djazayeri> I'm not sure. bwolfe would that be at all useful?
|
14:25:59
|
<bwolfe> djazayeri, I don't think it would be much of a change. and I don't see the 1.x webapp needing to make its own db tables anytime soon (which means never since 2.x is taking over "soon")
|
14:26:14
|
<djazayeri> okay
|
14:26:54
|
<djazayeri> still, wluyima, it would be cool if you can copy-paste the wizards as-they-are.
|
14:27:14
|
<djazayeri> and _then_ make the change to support multiple liquibase update xml files in its own commit
|
14:27:32
|
<wluyima> ok
|
14:28:37
|
<wluyima> just to confirm , if i run the 2.x app, there is no init/update wizard, correct?
|
14:28:43
|
<djazayeri> wluyima: correct
|
14:28:47
|
<wluyima> ok
|
14:33:19
|
<asgoyal> wyclif: hi
|
14:33:29
|
<bwolfe> wluyima, what about your friday?
|
14:34:10
|
<wluyima> that wasn;t my update, here is it is
|
14:34:40
|
<bwolfe> ok
|
14:35:51
|
<cta> wluyima: Wyclif, I added the patch for ticket TRUNK-2458 as you've asked for. This patch created for trunk. You can review it.
|
14:37:11
|
<wluyima> friday: worked on WS prior to release and worked with Ben and Darius to release WS module alpha, applied changes after code review for all pending tickets from the Orders and Visit Sprints, packaged 1.8.1 with ws module
|
14:38:20
|
<bwolfe> wluyima, you need to tag 1.8.1 as "latest" so that demo picks it up
|
14:38:40
|
<bwolfe> (I think thats int he release process wiki page, if not, add it. if it is, shame on you for now following all the steps!)
|
14:40:15
|
<wluyima> am looking through the steps and i can't seem to see it
|
14:40:44
|
<wluyima> we actually need to clean up the release process now that we don't include the installers
|
14:40:53
|
<bwolfe> must have gotten lost. ok. add it in there after tagging the branch. you just delete "latest" in svn and then tag 1.8.1 tag as "latest"
|
14:41:05
|
<wluyima> ok
|
14:41:55
|
*** Yekkanti has joined #openmrs
|
14:42:06
|
<downeym> Hi Yekkanti and welcome to the #openmrs IRC channel.
|
14:42:09
|
<bwolfe> dkayiwa?
|
14:42:19
|
<dkayiwa> Worked on TRUNK-2463 and committed. Did some investigations on TRUNK-2151. Blocked on a question which i posted on the ticket. As i waited, picked another ticket: TRUNK-2456 which am now looking into. DONE
|
14:44:11
|
<bwolfe> we need the bot to insert the ticket titles in here if it sees a TRUNK-XYZ pattern. downeym, think thats possible? :-)
|
14:44:31
|
<bwolfe> because I don't know what 2462 and 2151 are without going and looking them up
|
14:44:32
|
<bwolfe> :-/
|
14:44:43
|
<dkayiwa> :D
|
14:44:55
|
<Yekkanti> for ticket TRUNK-2258(service and dao for encounter role) do we have any validations to do during the encounter_role save?
|
14:45:08
|
<dkayiwa> 2462 + 1 :)
|
14:45:16
|
<rafa> bwolfe: it would help indeed
|
14:45:27
|
<bwolfe> dkayiwa, why not post your question here instead of the ticket? is it something that we could have helped with before darius woke up?
|
14:45:48
|
<dkayiwa> bwolfe: good one
|
14:46:02
|
*** Yekkanti has quit IRC
|
14:46:30
|
<downeym> bwolfe: not with any supybot plugin that I'm aware of ... although something like !ticket TRUNK-1 still works
|
14:46:33
|
<dkayiwa> bwolfe: ok now am asking :) But it requires reading the ticket to get some background
|
14:46:51
|
<asgoyal> wyclif: I have a doubt
|
14:47:53
|
*** danielf` has quit IRC
|
14:47:54
|
<bwolfe> downeym, that doesn't give me the title from the webpage. if it did htat I'd be satisfied
|
14:49:04
|
<bwolfe> asgoyal, doubt == question ?
|
14:49:20
|
<dkayiwa> :D
|
14:49:32
|
<asgoyal> bwolfe: yep :D
|
14:50:05
|
<pascal`> bwolfe, djazayeri, is mike seaton still around?
|
14:50:07
|
<bwolfe> asgoyal, where are you from?
|
14:50:15
|
<bwolfe> pascal`, around irc? was he ever?
|
14:50:19
|
<asgoyal> bwolfe: O.o ... from india
|
14:50:24
|
<djazayeri> pascal`: he's "still" around, but doesn't hang out on IRC.
|
14:50:31
|
<pascal`> bwolfe, no, just around.
|
14:50:32
|
<downeym> !title https://tickets.openmrs.org/browse/TRUNK-1
|
14:50:32
|
<bwolfe> asgoyal, I could have guessed from from your usage of doubt!
|
14:50:33
|
<OpenMRSBot> downeym: [#TRUNK-1] Limited number of trees in the world - OpenMRS JIRA
|
14:50:44
|
<asgoyal> bwolfe: but why so? O.o
|
14:50:48
|
<pascal`> djazayeri, ok thanks, I think I might need to ask him some stuff about the BIRT module.
|
14:50:58
|
<asgoyal> bwolfe: m i using that word wrongly? :D
|
14:50:58
|
<djazayeri> okay, justin actually wrote that module
|
14:51:14
|
<bwolfe> asgoyal, because doubt != question in english. but indians and sri lankans always seem to make that mistake!
|
14:51:15
|
<pascal`> djazayeri, I know, but he's definitely not around anymore afaik, right?
|
14:51:27
|
<asgoyal> bwolfe: whahahahaah
|
14:51:46
|
<bwolfe> downeym, oh, hmm, guess that'll work!
|
14:51:53
|
<djazayeri> pascal`: I would recommend asking the question on the dev list.
|
14:51:59
|
<downeym> bwolfe: i think any more than that we'd have to make a little custom plugin
|
14:52:16
|
<asgoyal> bwolfe: but doubt == confusion == leads to question
|
14:52:24
|
<pascal`> djazayeri, yes, I'll definitely do that as well.
|
14:54:37
|
<djazayeri> my turn
|
14:54:38
|
<djazayeri> Friday:
|
14:54:39
|
<djazayeri> * Created more sprint tickets
|
14:54:39
|
<djazayeri> * Worked on letting 1.x modules wrap existing pages as 2.x "pages"
|
14:54:39
|
<djazayeri> * Released WS module alpha
|
14:54:39
|
<djazayeri> * Researched an HTML form entry issue (about putting a line break after questions labels)
|
14:54:39
|
<djazayeri> Today:
|
14:54:40
|
<djazayeri> * 2.x UI Sprint code reviews
|
14:54:40
|
<djazayeri> * Finish letting 1.x modules wrap existing pages as 2.x "pages"
|
14:54:41
|
<djazayeri> * Work on letting 1.x modules warp existing porlets as 2.x "fragments"
|
14:54:42
|
<djazayeri> no blockers
|
14:55:44
|
<bwolfe> they're going to warp the portlets? :-)
|
14:55:56
|
<djazayeri> warp them while wrapping them
|
14:56:10
|
<downeym> !web title [jira TRUNK-1]
|
14:56:11
|
<OpenMRSBot> downeym: [#TRUNK-1] Limited number of trees in the world - OpenMRS JIRA
|
14:56:52
|
<bwolfe> wluyima / djazayeri, thanks for finishing up that ws module on friday. were you working on things for those 4 more hours? or just packaging, etc and other distractions?
|
14:57:29
|
<wluyima> apparently we got over the issues shortly after you went to bed
|
14:57:45
|
<bwolfe> ok, good
|
14:57:55
|
<bwolfe> cause I think i went to be at 1 and I didn't get Darius' email until 5
|
14:57:58
|
<djazayeri> yeah, I think those 4 hours included dinner
|
14:58:05
|
<bwolfe> ok, good
|
14:58:20
|
*** Yekkanti has joined #openmrs
|
14:58:49
|
<wluyima> it took me a while to upload the files, but i finally got them up
|
14:59:17
|
<bwolfe> downeym, thats not as convenient
|
14:59:48
|
<bwolfe> I'm up? today:
|
14:59:48
|
<bwolfe> * ws ticket cleanup
|
14:59:48
|
<bwolfe> * emails
|
14:59:48
|
<bwolfe> * releasetesting patch and experimentation
|
14:59:49
|
<bwolfe> * occ sprint investigation
|
14:59:49
|
<bwolfe> * ws fix
|
14:59:50
|
<bwolfe> * ui2 ticket:
|
14:59:52
|
<bwolfe> !web title [TRUNK-2464]
|
14:59:53
|
<wluyima> darius took a while to send out the email but we were already done with the packaging
|
14:59:53
|
<OpenMRSBot> bwolfe: Error: "TRUNK-2464" is not a valid command.
|
14:59:59
|
<bwolfe> * debugging trunk last 3 encounters (made ticket)
|
15:00:00
|
<bwolfe> tomorrow:
|
15:00:00
|
<bwolfe> * more ui2
|
15:00:01
|
<bwolfe> * occ sprint stuff
|
15:00:04
|
<downeym> s/TRUNK/jira TRUNK/
|
15:00:04
|
*** magoo has quit IRC
|
15:01:14
|
<bwolfe> I'm going to paste it again just to see. :-)
|
15:01:16
|
<bwolfe> today:
|
15:01:16
|
<bwolfe> * ws ticket cleanup
|
15:01:16
|
<bwolfe> * emails
|
15:01:16
|
<bwolfe> * releasetesting patch and experimentation
|
15:01:16
|
<bwolfe> * occ sprint investigation
|
15:01:16
|
<bwolfe> * ws fix
|
15:01:16
|
<bwolfe> * ui2 ticket:
|
15:01:17
|
<bwolfe> !web title [jira TRUNK-2464]
|
15:01:17
|
<bwolfe> * debugging trunk last 3 encounters (made ticket)
|
15:01:18
|
<bwolfe> tomorrow:
|
15:01:18
|
<bwolfe> * more ui2
|
15:01:19
|
<bwolfe> * occ sprint stuff
|
15:01:20
|
<bwolfe> the bot is kind of slow with it though...
|
15:01:21
|
<OpenMRSBot> bwolfe: [#TRUNK-2464] Logging in from a 1.x modules page fails in 2.x - OpenMRS JIRA
|
15:01:54
|
<bwolfe> there. sweet!
|
15:02:04
|
<bwolfe> downeym, can we alias it to something and just be able to do !jira TRUNK-2464 or something?
|
15:02:30
|
<bwolfe> or even if !ticket TRUNK-2464 also put in the title it'd be awesome
|
15:02:45
|
*** pascal` has quit IRC
|
15:02:49
|
<bwolfe> asgoyal ?
|
15:04:59
|
<bwolfe> djazayeri, do you have a plan to internationalize ui2?
|
15:05:07
|
<bwolfe> or to not hard code /openmrs2 everywhere?
|
15:05:17
|
* bwolfe saw both of those in login.jsp
|
15:05:29
|
<bwolfe> asgoyal, do you have a report from friday and what you're going to do today?
|
15:05:33
|
<djazayeri> login.jsp specifically doesn't go through the main framework
|
15:05:37
|
<djazayeri> (i have to figure that out)
|
15:05:49
|
<bwolfe> ah, ok
|
15:06:28
|
*** dkayiwa has quit IRC
|
15:06:46
|
*** cta has quit IRC
|
15:07:23
|
*** magoo has joined #openmrs
|
15:08:38
|
<bwolfe> dinnertime. bbl
|
15:09:09
|
*** rafa has quit IRC
|
15:10:03
|
*** rafa has joined #openmrs
|
15:10:03
|
*** ChanServ sets mode: +v rafa
|
15:22:40
|
*** magoo has quit IRC
|
15:23:40
|
<downeym> !ticket TRUNK-1
|
15:23:41
|
<OpenMRSBot> downeym: [#TRUNK-1] Limited number of trees in the world - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-1
|
15:23:44
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (root:): Preparing to upgrade latest tag to 1.8.1 <http://feedproxy.google.com/~r/OMRStrunk/~3/DMMMAIp29Tg/OpenMRS> || OpenMRS Modules: HTML Widgets 1.5.7.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlwidgets&version=&1.5.7.1>
|
15:24:01
|
*** dkayiwa has joined #openmrs
|
16:00:10
|
*** suho has joined #openmrs
|
16:00:10
|
*** ChanServ sets mode: +v suho
|
16:15:30
|
*** bwolfe has quit IRC
|
16:16:09
|
*** bwolfe has joined #openmrs
|
16:16:09
|
*** ChanServ sets mode: +o bwolfe
|
16:20:43
|
<suho> hi can some one help me how to run two different instance of OpenMRS in the same machine ?
|
16:23:42
|
*** vchircu has joined #openmrs
|
16:25:32
|
<suho> dkayiwa, hi I have now implemented upto filtering patients
|
16:25:44
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OpenMRS user in Rift Valley, #Kenya, looking for advice. Can you help? http://bit.ly/qs5IKt #ICT4D <http://twitter.com/OpenMRS/statuses/92984454619996160> || New Changeset: OpenMRS (root:): Tagging 1.8.1 as latest <http://feedproxy.google.com/~r/OMRStrunk/~3/tLNUVRGex8s/OpenMRS>
|
16:26:40
|
<suho> dkayiwa, but yet to do some development to filter concepts
|
16:29:09
|
*** dkayiwa has quit IRC
|
16:31:22
|
*** jportela has quit IRC
|
16:31:35
|
*** jportela has joined #openmrs
|
16:31:35
|
*** ChanServ sets mode: +v jportela
|
16:45:14
|
*** dkayiwa has joined #openmrs
|
16:45:52
|
*** pascal` has joined #openmrs
|
16:48:29
|
<suho> hi bwolfe
|
16:49:15
|
<suho> can we have two different unit values for a single concept ?
|
16:49:32
|
<suho> how thats handled in openmrs
|
16:49:38
|
<suho> e.g Fasting Blood sugar - mg/dl or mmol/dl ?
|
16:54:26
|
*** dkayiwa has quit IRC
|
17:01:51
|
<djazayeri> suho: no
|
17:01:56
|
<djazayeri> you'd need to create two different concepts for those
|
17:02:08
|
<djazayeri> alternately you'd have to have the form convert values on input/output
|
17:03:15
|
<suho> ok thanks djazayeri i'll give a try
|
17:14:05
|
*** omdesign has joined #openmrs
|
17:14:08
|
<omdesign> Hi all
|
17:14:12
|
<downeym> Hi omdesign and welcome to the #openmrs IRC channel.
|
17:14:19
|
<omdesign> I have a quick Q
|
17:15:57
|
<djazayeri> yes?
|
17:17:23
|
*** bwolfe has quit IRC
|
17:18:05
|
*** bwolfe has joined #openmrs
|
17:18:05
|
*** ChanServ sets mode: +o bwolfe
|
17:22:36
|
<omdesign> Hi Djazayeri..
|
17:23:14
|
<omdesign> my question is regarding whether OpenMRS is capable of handling 'Nation' level data?
|
17:23:42
|
<djazayeri> the answer is "sort ofâ¦it depends"
|
17:24:06
|
<djazayeri> If you mean storing 30 million detailed patient records in a single mysql database, the answer is no.
|
17:24:06
|
<omdesign> meaning Nation sized deployment and managing the whole infrastructure of an emerging democracy.
|
17:24:21
|
<omdesign> lol
|
17:24:44
|
<djazayeri> could you be more specific about what you're trying to do?
|
17:27:09
|
<omdesign> implement a national medical record system that handles consultation and suply management in a fairly developed infrastructure (hospitals, teaching hospitals) in a country currently undergoing 'transition' approximate size: 6M pop
|
17:27:24
|
*** asgoyal has quit IRC
|
17:27:45
|
<djazayeri> You want a single central installation storing all patient records? Or are you talking about deploying OpenMRS in different hospitals?
|
17:27:46
|
<omdesign> I was regional implementation of Omrs might be possible
|
17:28:26
|
<omdesign> feeding to a central ministry for higher level stats etc.
|
17:29:04
|
<omdesign> so, in conjunction with a separate logistics app - as yet to be designed.
|
17:29:09
|
<djazayeri> And by "consultation" what do you mean?
|
17:29:19
|
<djazayeri> (specifically?)
|
17:30:46
|
<omdesign> township clinitian provides report to regional hosp. for difficult diagnosis, coordination for emergent care
|
17:31:23
|
<omdesign> (someday.. future, transmits x-ray)
|
17:32:40
|
<omdesign> Basically I'm trying to asses functional capacity for OpenMRS in each -sub region- or if/how it could be deployed in this case
|
17:32:47
|
<djazayeri> So, you could build such a system on OpenMRS.
|
17:32:57
|
<djazayeri> But you'd also need to implement a significant amount of code to tie things together
|
17:34:04
|
<omdesign> is there anything out of the box targeted at this size of implementation? How learge would you suggest for each individual "block" in this puzzle?
|
17:34:17
|
<djazayeri> Specifically around exporting patient records from a local-level server and pushing them the regional hospital.
|
17:34:40
|
*** Yekkanti has quit IRC
|
17:34:52
|
<djazayeri> Presumably you'd want installs at the local clinics (where the "township clinicians" are)
|
17:35:16
|
<djazayeri> Sorry, taking a step back...
|
17:35:39
|
<omdesign> NP
|
17:35:42
|
<djazayeri> Is the goal to capture and store patient-level data at the local level (e.g. where the township clinicians are?)
|
17:36:04
|
<djazayeri> Or just at the district/regional level where the consults are serviced?
|
17:36:54
|
<omdesign> it seems like best practices would be to push Pt. records up to regional which have more ocnsistent power supply, seciruty etc.
|
17:37:20
|
<djazayeri> yes
|
17:37:39
|
<djazayeri> So, depending on your goals you could look at either:
|
17:38:15
|
<djazayeri> * (using the sync module) a network for each region so that data is actually replicated between the regional hospital and the clinics
|
17:38:39
|
<djazayeri> * (or else, and probably better) custom client (maybe openmrs-based) for doing consults
|
17:39:51
|
<djazayeri> You'd probably want to use the reporting + sdmxhd modules to generate some aggregated numbers at the local/regional level
|
17:39:58
|
<djazayeri> and push those into DHIS or something similar.
|
17:41:49
|
<omdesign> honestly, does this sound like the realm of Open MRS or should we be looking elsewhere?
|
17:43:02
|
<djazayeri> OpenMRS is a patient-level medical record system
|
17:43:12
|
<djazayeri> And also a framework for building other patient-level medical applications
|
17:43:41
|
<djazayeri> Some aspects of what you're asking for are handled by OpenMRS, others aren't.
|
17:43:58
|
<omdesign> so it sounds very much like what is needed at the terminal end. Plus I was very excited about the Frontline SMS integration.
|
17:44:14
|
<djazayeri> So, you should definitely be looking at connecting different systems together via standards and message-passing.
|
17:44:51
|
<djazayeri> If you come across a system that claims to be able to handle the national-level and patient-level side of your use case, do not believe them.
|
17:44:52
|
<djazayeri> :-)
|
17:45:01
|
<omdesign> yes, understood, just didn't know about it's practical capacity at the village or regional level
|
17:45:35
|
<omdesign> what is your real world working user numbers per install?
|
17:46:07
|
<djazayeri> you'd have to ask around on the implementers mailing list.
|
17:46:53
|
<djazayeri> I would speculate (wildly) that the largest installations have 1 million patient records, and ~30 simultaneous users
|
17:47:36
|
<downeym> https://wiki.openmrs.org/display/RES/Mailing+Lists
|
17:47:37
|
<OpenMRSBot> <http://ln-s.net/8ZWD> (at wiki.openmrs.org)
|
17:48:04
|
*** asgoyal has joined #openmrs
|
17:48:09
|
<omdesign> Awesome. Thanks for your info! Any other suggestions/ideas before I head out into the wilderness? :)
|
17:48:36
|
<djazayeri> not really
|
17:48:37
|
<djazayeri> good luck!
|
17:49:08
|
<omdesign> Thanks. Ta!
|
17:49:20
|
*** omdesign has quit IRC
|
17:54:40
|
<bwolfe> any bets on whether omdesign is from south sudan? :-)
|
17:57:10
|
<downeym> !ticket TRUNK-1991
|
17:57:11
|
<OpenMRSBot> downeym: [#TRUNK-1991] Support external master registries of Patient, Location, Provider, Concept and other metadata - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-1991
|
17:57:13
|
<downeym> +1 vote for that :)
|
17:57:25
|
*** dkayiwa has joined #openmrs
|
17:57:36
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Module not start <http://forum.openmrs.org/viewtopic.php?f=8&t=799#p3021>
|
18:05:11
|
<wluyima> djazayeri, are you able to run the ui2 app?
|
18:05:33
|
<dkayiwa> wluyima: do u get errors?
|
18:05:37
|
<wluyima> yeah
|
18:05:42
|
<djazayeri> I was able to as of yesterday
|
18:05:42
|
<dkayiwa> which ones
|
18:05:48
|
<djazayeri> haven't done an svn update yet today
|
18:05:59
|
<djazayeri> though actually it seems to be broken now
|
18:06:14
|
<dkayiwa> wluyima: which error?
|
18:06:22
|
<wluyima> java.lang.IllegalStateException: No WebApplicationContext found: no ContextLoaderListener registered?
|
18:06:42
|
<djazayeri> ben mentioned that he needed to downgrade ui2 to spring 3.0.3
|
18:06:50
|
<djazayeri> not sure if that's related
|
18:06:57
|
<djazayeri> I haven't (yet) needed to do that
|
18:07:13
|
<dkayiwa> i never downgraded mine and it is running fine
|
18:07:19
|
<dkayiwa> i did an svn update today
|
18:07:37
|
<bwolfe> dkayiwa, did you do a clean install ?
|
18:07:40
|
<bwolfe> or just run the webapp?
|
18:08:00
|
<dkayiwa> bwolfe: i did run Maven Install
|
18:08:04
|
<wluyima> i see that in rev:21679, the listen was removed
|
18:08:09
|
<wluyima> let try to register it back
|
18:08:42
|
<wluyima> the contextLoader is actually gone
|
18:10:10
|
<djazayeri> looking at that changeset I only see things added.
|
18:10:20
|
<wluyima> it is there
|
18:10:27
|
<wluyima> i was looking at a wrong file
|
18:10:31
|
<wluyima> sorry!
|
18:11:09
|
<dkayiwa> wluyima: could we look at the entire stack trace?
|
18:11:17
|
<dkayiwa> it could have some pointers somewhere
|
18:11:31
|
<wluyima> just a sec, am restarting it
|
18:15:20
|
<dkayiwa> Just done another svn update, mvn clean install, am mine runs well
|
18:29:56
|
<asgoyal> djazayeri: can you give me an example of getDrugOrdersByPatientAndIngredient(Patient, Concept) ?
|
18:31:23
|
<asgoyal> djazayeri: dj ^^
|
18:31:50
|
<djazayeri> gDOBPAI(patient, amoxacillin);
|
18:32:05
|
<djazayeri> this should find both drug orders for the drug "Amoxicillin"
|
18:32:06
|
<asgoyal> and what should be result i mean
|
18:32:14
|
<asgoyal> oh
|
18:32:24
|
<djazayeri> but also drug orders for the combination drug "Amoxicillin and Clavulonic Acid"
|
18:32:46
|
<djazayeri> (probably called "Augmentin" in the drug table, but including the amoxicillin concept in its ingredients.)
|
18:32:47
|
<asgoyal> (seeing stars in daylight)
|
18:33:04
|
<asgoyal> haha joking... hm...
|
18:33:18
|
<asgoyal> ah got it
|
18:33:28
|
<asgoyal> its basically related to calling of the first method in that ticket
|
18:33:54
|
<asgoyal> but will the result be Patient AND concept or\
|
18:34:00
|
<djazayeri> In fact I say in the ticket to see the amoxicillin example above...
|
18:34:01
|
<asgoyal> Patient OR concept?
|
18:34:12
|
<djazayeri> the result will be List<DrugOrder> as mentioned in the ticket.
|
18:34:40
|
<asgoyal> hm.. i mean to say... the result will contain the list of drug order which will be
|
18:34:45
|
<asgoyal> Patient AND concept
|
18:34:47
|
<asgoyal> or
|
18:34:52
|
<asgoyal> Patient OR concept
|
18:34:56
|
<asgoyal> (conditions)
|
18:35:24
|
<djazayeri> "ByPatientAndIngredient" -> patient AND ingredient
|
18:35:28
|
<asgoyal> oki
|
18:41:40
|
<wluyima> djazayeri, did you get the app running
|
18:41:52
|
<djazayeri> yes
|
18:41:56
|
<wluyima> hmm
|
18:41:57
|
<djazayeri> But I haven't done svn update yet.
|
18:42:06
|
<djazayeri> hold on, let me try that
|
18:44:12
|
<djazayeri> dkayiwa: btw, you said you were going to look at that logic issue for 30 mins
|
18:44:14
|
<djazayeri> how did that work out?
|
18:47:13
|
<djazayeri> wluyima: it starts fine for me
|
18:47:34
|
<djazayeri> try getting rid of all your modules before starting...
|
18:53:43
|
*** suhothayan has joined #openmrs
|
18:53:43
|
*** ChanServ sets mode: +v suhothayan
|
18:56:11
|
<dkayiwa> djazayeri: i did not look at it because i got problems with my laptop power adapter. it has just started working again
|
18:56:41
|
<djazayeri> okay, just wanted to make sure that you didn't spend 2 hours and keep working, instead of 30 minutes...
|
18:56:56
|
<dkayiwa> sure
|
18:57:09
|
*** suho has quit IRC
|
18:58:19
|
*** cta has joined #openmrs
|
19:01:26
|
<wluyima> i have no modules
|
19:01:46
|
<djazayeri> can you show us a stack trace?
|
19:01:48
|
<djazayeri> or log?
|
19:01:59
|
<djazayeri> also make sure to svn update and clean install trunk
|
19:06:44
|
*** bryq has quit IRC
|
19:09:49
|
<djazayeri> bwolfe: you there?
|
19:09:55
|
<bwolfe> no
|
19:10:00
|
<djazayeri> darn
|
19:10:16
|
<djazayeri> So, I've got an issue.
|
19:10:18
|
<bwolfe> yeah, bums me out too
|
19:12:02
|
<djazayeri> Actually, I may have been premature in asking you the question
|
19:12:21
|
<bwolfe> you haven't asked me a question yet
|
19:12:21
|
<djazayeri> But basically I'm trying to access Spring's DispatcherServlet programmatically.
|
19:12:29
|
<djazayeri> "you there?" was a question.
|
19:12:34
|
<bwolfe> fair enough
|
19:13:08
|
*** yanokwa has quit IRC
|
19:13:10
|
<bwolfe> the old webapp extended the dispatcherservlet and we used that.
|
19:13:11
|
<djazayeri> I.e. I'd like to programmatically ask Spring to render "/module/htmlformentry/htmlFormEntry.form" and then I'll take the generated String, decorate it, and display it.
|
19:13:14
|
<bwolfe> thats how I got at it
|
19:13:23
|
<djazayeri> hmm, okay
|
19:13:36
|
<djazayeri> I was trying to do "@Autowired DispatcherServlet" in one of my classes
|
19:13:37
|
<djazayeri> but that fails
|
19:13:45
|
<bwolfe> heh
|
19:14:17
|
<djazayeri> I was assuming it's because dispatcher-servlet doesn't load in the api stage, but rather in the ui stage.
|
19:14:30
|
<djazayeri> But perhaps it's not actually a Spring-managed bean? Rather it's in web.xml?
|
19:15:40
|
<djazayeri> that would make sense, right?
|
19:15:52
|
*** vchircu has quit IRC
|
19:16:06
|
<bwolfe> yes, its "higher" than a bean
|
19:16:47
|
<djazayeri> Makes sense. Okay.
|
19:16:57
|
<djazayeri> I'll look at what you did in 1.x
|
19:18:45
|
*** jwishnie has joined #openmrs
|
19:22:58
|
*** bryq has joined #openmrs
|
19:22:58
|
*** ChanServ sets mode: +v bryq
|
19:24:54
|
<djazayeri> wluyima, rafa: you're both working on tickets that this may relate to.
|
19:25:18
|
<djazayeri> I.e. I'm about to copy over our custom implementation of Spring's DispatcherServlet from 1.x to 2.x
|
19:25:36
|
<wluyima> ok
|
19:25:36
|
<djazayeri> I'm going to comment out some lines that relate to things that we don't have in 2.x yet
|
19:25:41
|
<djazayeri> specifically:
|
19:25:42
|
<wluyima> thanks
|
19:25:53
|
<wluyima> e.g
|
19:26:13
|
<djazayeri> * the fact that it looks at UpdateFilter and InitializationFilter
|
19:26:18
|
<djazayeri> (for wluyima)
|
19:26:37
|
<djazayeri> * the fact that it needs to do stuff after starting/stopping a module (for rafa)
|
19:26:41
|
<wluyima> so you are commenting them out, so that i can put them back in my ticket?
|
19:26:53
|
<djazayeri> That's what I assume I'm going to do.
|
19:26:59
|
<wluyima> sounds fine to me
|
19:27:08
|
<rafa> djazayeri: okay, do I need to follow any special steps or watch out for anything?
|
19:27:50
|
<djazayeri> Just remember that I mentioned this. It's related to WebModuleUtil, which I may have copied over and removed/commented large chunks of code from.
|
19:28:29
|
<rafa> cool
|
19:29:21
|
*** suhothayan has quit IRC
|
19:29:56
|
<djazayeri> Actually, rafa, looks like I copied WebModuleUtil into the 1x-compatibility sub-project.
|
19:30:40
|
<djazayeri> You'll probably want to move it into the framework sub-project. (It's not just for compatibility.)
|
19:31:05
|
<rafa> I see
|
19:31:40
|
<rafa> Shall I do it under a separate issue?
|
19:31:59
|
<djazayeri> Nah, that fits under allowing module management
|
19:32:11
|
<rafa> Ok
|
19:46:16
|
<asgoyal> djazayeri: i m not sure if i m correct but doens't the order.java file needs a property "Drug" as it has a many to one relationship with it?
|
19:46:33
|
<djazayeri> DrugOrder has a drug property
|
19:46:40
|
<asgoyal> oh
|
19:46:43
|
<djazayeri> (column might be drug_inventory_id)
|
19:47:20
|
*** rafa has quit IRC
|
19:48:19
|
<asgoyal> and in the drug.hbm.xml file... the relationship for drugorder is commented....
|
19:48:22
|
<asgoyal> do i have to add there?
|
19:48:59
|
<asgoyal> djazayeri: ^^
|
19:49:15
|
*** james_regen has quit IRC
|
19:49:17
|
<djazayeri> this is already there:
|
19:49:18
|
<djazayeri> <many-to-one
|
19:49:19
|
<djazayeri> name="drug"
|
19:49:19
|
<djazayeri> class="org.openmrs.Drug"
|
19:49:19
|
<djazayeri> not-null="true"
|
19:49:19
|
<djazayeri> >
|
19:49:19
|
<djazayeri> <column name="drug_inventory_id" />
|
19:49:19
|
<djazayeri> </many-to-one>
|
19:50:46
|
<djazayeri> sorry
|
19:50:52
|
<djazayeri> drug does not need a relationship to drugorder
|
19:50:57
|
<djazayeri> a drugorder has a drug
|
19:51:02
|
<djazayeri> but not vice versa
|
19:51:21
|
<djazayeri> not every foreign key needs a relationship in the hibernate mapping
|
20:04:25
|
*** wluyima has quit IRC
|
20:06:11
|
*** wyclif has joined #openmrs
|
20:13:41
|
<asgoyal> djazayeri: the column you said drug_inventory_id doesn't exist in any table when i browse in sql browser
|
20:13:45
|
*** rafa has joined #openmrs
|
20:13:45
|
*** ChanServ sets mode: +v rafa
|
20:13:53
|
<djazayeri> drug_order
|
20:14:44
|
*** cta has quit IRC
|
20:33:39
|
*** dkayiwa has quit IRC
|
20:48:53
|
*** asgoyal has quit IRC
|
20:51:03
|
*** pascal` has quit IRC
|
20:56:57
|
*** rafa has quit IRC
|
21:18:12
|
*** bryq has quit IRC
|
21:33:41
|
<wyclif> djazayeri, did yu commit the code?
|
21:33:45
|
<djazayeri> not yet
|
21:33:51
|
<wyclif> uh! ok
|
21:34:06
|
<djazayeri> do you need it?
|
21:34:11
|
<wyclif> not really
|
21:34:43
|
<djazayeri> Do you need it ASAP? I can commitâI'm in the middle of my ticket, but it won't break anything to commit.
|
21:34:44
|
<wyclif> i just wanted to be sure am not adding what it includes to minimise conflicts
|
21:34:59
|
<wyclif> itis ok
|
21:35:07
|
<wyclif> i dont need it as such
|
21:35:49
|
<djazayeri> Awesomeâ¦I just got this: Invalid access of stack red zone 0x113401ff8 rip=0x101075e60
|
21:36:08
|
<djazayeri> followed by jetty crashing/stopping entirely
|
21:36:32
|
<wyclif> hmm
|
21:36:39
|
<wyclif> apparently why app was failing is because for some reason i have to run DB updates
|
21:36:48
|
<wyclif> yet there is no liquibase file
|
21:36:57
|
<djazayeri> Hmm, someone should fix that. ;-)
|
21:37:16
|
<djazayeri> Did you find the create table commands on the wiki page?
|
21:37:20
|
<wyclif> and i wonder where it is getting it
|
21:37:27
|
<wyclif> i did
|
21:37:47
|
<djazayeri> yeah, ironic that this tripped you up while actually working on that precise ticket.
|
21:37:54
|
<wyclif> i already have them in my table from the last sprint
|
21:38:18
|
<djazayeri> hmm...
|
21:38:27
|
<djazayeri> maybe a change to liquibase-update-to-latest in trunk?
|
21:38:51
|
<wyclif> something wrong with myy settings
|
21:39:40
|
<wyclif> it strange when i set run updates to auto in the runtime properties, the changesets are strange
|
21:39:45
|
<wyclif> so it is a caching issue
|
21:40:12
|
<wyclif> i did mvn clean install but i wonder why it is not wiping everything
|
21:41:23
|
<djazayeri> mvn clean install won't have anything to do with liquibase updates
|
21:41:27
|
<djazayeri> or runtime properties
|
21:41:49
|
<djazayeri> it installs the artifacts (built by maven) into your local maven repository
|
22:10:14
|
*** jportela has quit IRC
|
22:14:41
|
*** downeym has quit IRC
|
22:33:47
|
*** wyclif has quit IRC
|
22:33:54
|
*** wyclif has joined #openmrs
|
22:36:49
|
*** jportela has joined #openmrs
|
22:36:49
|
*** ChanServ sets mode: +v jportela
|
22:38:26
|
<wyclif> djazayeri, i dont understand why you have compartibility1.x/... folders
|
22:39:49
|
<djazayeri> wyclif: the idea is that we have a lot of hacky code built into our existing web application
|
22:40:12
|
<djazayeri> and that the 2.x framework will be a lot cleaner if it doesn't have to replicate that.
|
22:40:37
|
<djazayeri> in practice we do need to support that stuff, at least for now.
|
22:41:08
|
<wyclif> ok, why asked is because i need to know the right folders to put the files
|
22:41:11
|
<djazayeri> but it helps make it clear what is actually part of the framework, and what is legacy from using 1.x
|
22:41:37
|
<djazayeri> you're adding the update and installation filters, right?
|
22:41:42
|
<wyclif> yes?
|
22:41:58
|
<wyclif> did you set anything in the code that always starts openmrs?
|
22:42:27
|
<wyclif> because i have the code in place, but the webapp always gets started
|
22:42:44
|
<djazayeri> perhaps the dispatcherservlet thing I mentioned
|
22:43:08
|
<wyclif> i have uncommented what you had commented
|
22:43:19
|
<djazayeri> But there's more than that.
|
22:43:33
|
<djazayeri> I mean that there's more code I commented out today
|
22:43:47
|
<djazayeri> rather, another class, with some more commented code, that I haven't checked in yet.
|
22:45:45
|
<djazayeri> I just did a checkin at rev:21695
|
22:45:49
|
<djazayeri> this introduces DispatcherServlet
|
22:46:24
|
<djazayeri> actually, looking at the code I commented out, that seems like it's not the issue
|
22:46:31
|
<djazayeri> it just does log.info...
|
22:46:52
|
<wyclif> right
|
22:47:08
|
<wyclif> let do an svn update
|
22:47:47
|
<djazayeri> you added StartupErrorFilter, InitializationFilter, and UpdateFilter to web.xml?
|
22:53:07
|
*** wyclif has quit IRC
|
23:19:04
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Module not start <http://forum.openmrs.org/viewtopic.php?f=8&t=799#p3022>
|
23:36:41
|
*** gbastien has quit IRC
|
23:37:43
|
*** bwolfe has quit IRC
|
23:42:01
|
*** wyclif has joined #openmrs
|