| 00:55:28 | *** downeym has quit IRC |
| 01:03:18 | *** muthah has quit IRC |
| 01:03:40 | *** muthah has joined #openmrs |
| 01:22:50 | *** jwishnie has quit IRC |
| 01:35:53 | *** mandric has joined #openmrs |
| 01:41:10 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Follow up to fix review comments for API support for Discontinuing orders - TRUNK-2367 <http://feedproxy.google.com/~r/OMRStrunk/~3/OvIxROLeBMc/OpenMRS> || New Changeset: OpenMRS (order-entry): applying auto formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/cq8IxVzaJKs/OpenMRS> |
| 02:44:13 | *** muthah has quit IRC |
| 02:49:00 | *** yanokwa has joined #openmrs |
| 02:49:00 | *** ChanServ sets mode: +v yanokwa |
| 02:56:02 | *** mandric has joined #openmrs |
| 03:02:10 | *** upul` has joined #openmrs |
| 03:02:10 | *** ChanServ sets mode: +v upul` |
| 03:30:16 | *** mandric has quit IRC |
| 03:31:26 | *** mandric has joined #openmrs |
| 03:33:45 | *** upul` has left #openmrs |
| 03:33:58 | *** upul` has joined #openmrs |
| 03:33:58 | *** ChanServ sets mode: +v upul` |
| 03:47:07 | *** surangak has joined #openmrs |
| 04:32:11 | *** djazayeri has quit IRC |
| 04:38:32 | *** djazayeri has joined #openmrs |
| 04:38:32 | *** ChanServ sets mode: +o djazayeri |
| 04:47:46 | *** kishoreyekkanti has joined #openmrs |
| 05:12:01 | <kishoreyekkanti> Hi, is sort="natural" in Provider.hbm.xml,Visit.hbm.xml necessary? This force us to implement the set as TreeSet in Java which in turn force us to implement the comparable interface for the corresponding classes. |
| 05:28:42 | <robbyoconnor> which is not hard |
| 05:28:45 | <robbyoconnor> either way |
| 05:29:21 | <robbyoconnor> if i remember right (haven't used OpenMRS in awhile) OpenmrsUtil has some comparators when to use |
| 05:31:23 | *** muthah has joined #openmrs |
| 05:41:41 | <kishoreyekkanti> Sure!, thank you! |
| 05:42:22 | *** lh_ has joined #openmrs |
| 05:44:37 | *** lh has quit IRC |
| 05:44:38 | *** lh_ is now known as lh |
| 06:01:12 | *** lh_ has joined #openmrs |
| 06:01:23 | *** lh_ has quit IRC |
| 06:03:01 | *** lh has quit IRC |
| 06:05:25 | *** danielf` has joined #openmrs |
| 06:05:25 | *** ChanServ sets mode: +v danielf` |
| 06:11:00 | *** kishoreyekkanti has quit IRC |
| 06:24:03 | *** dkayiwa has joined #openmrs |
| 06:25:52 | *** mandric has quit IRC |
| 06:28:18 | *** muthah has quit IRC |
| 06:42:03 | *** muthah has joined #openmrs |
| 06:49:52 | *** yanokwa has quit IRC |
| 07:05:34 | *** vchircu has joined #openmrs |
| 07:07:30 | *** magoo has joined #openmrs |
| 07:17:04 | *** rafa has joined #openmrs |
| 07:17:04 | *** ChanServ sets mode: +v rafa |
| 07:18:36 | *** magoo has quit IRC |
| 07:27:39 | *** pascal` has joined #openmrs |
| 07:28:52 | *** magoo has joined #openmrs |
| 07:56:42 | *** deadpool has quit IRC |
| 08:05:38 | *** muthah_ has joined #openmrs |
| 08:05:39 | *** muthah has quit IRC |
| 08:05:40 | *** muthah_ is now known as muthah |
| 08:11:26 | *** bryq has joined #openmrs |
| 08:11:26 | *** ChanServ sets mode: +v bryq |
| 08:28:39 | <dkayiwa> hi bwolfe |
| 08:29:31 | <dkayiwa> bwolfe: looks like there are no more web service tickets |
| 08:36:28 | <dkayiwa> bwolfe: should i in the meantime be working on some xforms tickets? |
| 08:47:41 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Changes to valueComplex, as discussed in CR-TRUNK-414... <http://feedproxy.google.com/~r/OMRStrunk/~3/rQD04tuHvLk/OpenMRS> || OpenMRS Forum: Re: openmrs_tag documentation? <http://forum.openmrs.org/viewtopic.php?f=11&t=797#p3017> |
| 08:50:55 | *** muthah_ has joined #openmrs |
| 08:50:55 | *** muthah has quit IRC |
| 08:50:56 | *** muthah_ is now known as muthah |
| 09:01:59 | *** bwolfe has quit IRC |
| 09:07:21 | <magoo> morning dkayiwa for the rest i dont what time its but i hope your all doing fine kindly send me the link to the concept dictionary my laptop seems to be having problem am using another pc forgetten the link u sent me yesterday |
| 09:07:59 | <dkayiwa> magoo: just google openmrs concept dictionary and you will see it |
| 09:08:14 | <magoo> thxs |
| 09:27:32 | *** dkayiwa has quit IRC |
| 09:32:26 | *** magoo has quit IRC |
| 09:35:17 | *** goutham has joined #openmrs |
| 09:39:10 | *** bwolfe has joined #openmrs |
| 09:39:10 | *** ChanServ sets mode: +o bwolfe |
| 09:40:33 | *** magoo has joined #openmrs |
| 09:40:43 | <rafa> bwolfe: Hello , I seem to have problem with a missing openmrs-test dependency |
| 09:41:01 | <bwolfe> where? |
| 09:41:09 | <rafa> bwolfe: In Eclipse only |
| 09:41:17 | <rafa> When I try to build the ws module |
| 09:42:11 | <bwolfe> a clean build? |
| 09:42:14 | <rafa> yes |
| 09:42:26 | <bwolfe> have you installed 1.8.x completely? (not doing -DskipTests |
| 09:42:50 | <rafa> I did skip tests |
| 09:42:55 | <rafa> will help? |
| 09:42:59 | <bwolfe> don't skip tests |
| 09:43:06 | <rafa> ok, thanks |
| 09:43:14 | <bwolfe> skipping tests also skips installing the jars that are in openmrs-test |
| 09:43:29 | <rafa> I see |
| 09:43:35 | <rafa> then the problem is resolved |
| 09:43:44 | <rafa> thanks a lot! |
| 09:46:11 | <rafa> bwolfe: today is a big day :) ws release, right? |
| 09:46:25 | <rafa> bwolfe: are there any outstanding issues? |
| 09:49:45 | <bwolfe> rafa, just the versioning issue! |
| 09:50:13 | <rafa> bwolfe: cool! |
| 09:50:53 | <rafa> bwolfe: Btw I have no objections to the uri ;) |
| 09:52:14 | <bwolfe> rafa: :-) |
| 09:52:55 | <rafa> bwolfe: I've investigated more on other big apis. I hope you've seen my comment. |
| 09:53:15 | <bwolfe> rafa, yes, thanks for that! |
| 09:53:16 | <bwolfe> it does make me nervous about no one using media types... |
| 09:53:28 | <bwolfe> (especially ta' goog) |
| 09:54:08 | <rafa> bwolfe: well google doesn't change that much, they would live without versioning I guess :) |
| 09:54:16 | <bwolfe> rafa, I too would prefer v1 over just 1, but I also like just "1.0" over v1.0 |
| 09:54:29 | <bwolfe> yeah, I wish we could |
| 09:55:37 | <rafa> bwolfe: I like v1 more too. |
| 09:56:03 | <bwolfe> (but we can't do 1.0 yet) |
| 09:56:05 | <bwolfe> hopefully eventually we can! |
| 09:56:51 | <rafa> actually I thought that a java package must start with a letter |
| 09:57:58 | <bwolfe> rafa, it does. thats why the package is actually v1_0 |
| 09:58:11 | <rafa> ohh ok I missed that |
| 09:58:14 | <bwolfe> but the rest uri is probably going to just be "1" until spring 3.1 comes out |
| 09:58:42 | *** vchircu has quit IRC |
| 09:59:17 | <rafa> bwolfe: let's hope we won't need 1.1 ever :) |
| 10:00:41 | <bwolfe> rafa, I guarantee we will |
| 10:00:57 | <bwolfe> when we make changes to the api like "multiple providers per encounter" or other such changes, we will probably need it |
| 10:01:25 | *** vchircu has joined #openmrs |
| 10:01:25 | <bwolfe> although if we really think we'll never need 1.1, I'd be inclined to actually go with v1 instead of just '1' |
| 10:03:18 | <rafa> bwolfe: How much code do we have to produce to release the next version of the api? |
| 10:03:38 | <bwolfe> rafa, the rest api or the openmrs api ? |
| 10:03:44 | <rafa> the rest api |
| 10:04:40 | <bwolfe> meaning after we release a final 1.0 ? or to get us from alpha to 1.0 ? |
| 10:05:04 | <rafa> bwolfe: from 1.0 to 1.1 for instance |
| 10:05:11 | <bwolfe> hopefully not much |
| 10:05:24 | <bwolfe> but I'm sure there will be features that will be asked for |
| 10:05:45 | <bwolfe> although getting from 1.0 to 1.1 in the rest module doesn't mean that the rest api version goes to 1.1 |
| 10:06:10 | <rafa> bwolfe: yes, but new features can be added to the existing api |
| 10:06:25 | <rafa> bwolfe: we'll need to advance the rest api only with incompatible changes |
| 10:06:53 | <bwolfe> correct |
| 10:06:55 | <bwolfe> rafa, see my new "versioning" section on https://wiki.openmrs.org/display/docs/REST+Web+Services+API |
| 10:06:56 | <OpenMRSBot> <http://ln-s.net/8zTB> (at wiki.openmrs.org) |
| 10:06:59 | <bwolfe> feel free to make any comments/additions |
| 10:07:30 | <rafa> ok |
| 10:08:52 | <rafa> bwolfe: What do you mean by that When necessary, insert table of rest module version to rest api version to openmrs required version? |
| 10:12:05 | <bwolfe> rafa, meaning when the modules goes to 1.1, the rest api version will stay at 1.0, and it requires version 1.8.1 or 1.9 |
| 10:12:07 | <bwolfe> that kind of thing |
| 10:14:50 | <rafa> I see |
| 10:20:01 | <goutham> bwolfe: i recently checked out trunk and run command "mvn install -Dmaven.test.skip=true " but its giving me error |
| 10:20:28 | <goutham> [ERROR] Failed to execute goal on project openmrs-web: Could not resolve dependencies for project org.openmrs.web:openmr s-web:jar:1.9.0-SNAPSHOT: Could not find artifact org.openmrs.api:openmrs-api:jar:tests:1.9.0-SNAPSHOT -> [Help 1] |
| 10:20:31 | <bwolfe> I've never seen that param before |
| 10:20:44 | <bwolfe> goutham, you have to run tests the first time. after that you can skip tests |
| 10:21:03 | *** muthah has quit IRC |
| 10:21:15 | <goutham> bwolfe: ok |
| 10:25:48 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): valueComplex changes to LocationHandler <http://feedproxy.google.com/~r/OMRStrunk/~3/a21PGxjBGnc/OpenMRS> |
| 10:27:26 | *** magoo has quit IRC |
| 10:33:04 | *** upul` has left #openmrs |
| 10:33:28 | <vchircu> hey guys, I have a couple of questions |
| 10:33:55 | <vchircu> I'm working on the Atlas module (with trunk version 1.9.0-snapshot) |
| 10:34:40 | <vchircu> and I need to get the moduleids and/or names and running state for all loaded modules |
| 10:34:50 | <vchircu> how can I achieve this ? |
| 10:34:58 | <bwolfe> ModuleFactory |
| 10:35:27 | <vchircu> ok...thanks |
| 10:35:31 | <vchircu> and the second one |
| 10:36:05 | <vchircu> I have to get some basic statistics (total number of patients, observations and visits) |
| 10:36:30 | <vchircu> I have created a hibernate dao |
| 10:36:48 | <bwolfe> there is the quickstats module. you could either copy some of that or write your own |
| 10:38:12 | <vchircu> ok, thanks again |
| 10:47:21 | *** sunbiz has joined #openmrs |
| 10:48:27 | <sunbiz> bwolfe: v1 in the URL?? |
| 10:48:35 | *** ChanServ sets mode: +v sunbiz |
| 10:48:38 | <bwolfe> ? |
| 10:48:47 | <sunbiz> or 1 ?? :D |
| 10:49:17 | <bwolfe> I'm about 50/50 on v1 vs just 1 |
| 10:49:36 | <sunbiz> 51/49 would be enough... |
| 10:49:41 | <bwolfe> I played around with it some more and can't get 1.0 to work...even with changing trunk's DefaultHandlerAnnotationMapping element |
| 10:49:44 | <bwolfe> haha |
| 10:49:56 | <sunbiz> yes, I tried that too |
| 10:50:19 | <bwolfe> burke and darius are the ones that need to weigh in. they actually had hard opinions about /not/ doing v1. they convinced me by saying lets do 1.0...but now that thats off hte table... |
| 10:50:28 | <bwolfe> sunbiz, have you done other investigations? |
| 10:51:01 | <bwolfe> sunbiz, /rest/ws/1.0/catalog shows up. bur /rest/ws/1.0/catalog/{somestring} fails to be found :-/ |
| 10:51:43 | <sunbiz> nope... it didn't show 1.0 |
| 10:52:10 | <sunbiz> I tried with patient and q |
| 10:54:55 | <bwolfe> yeah, frustrating |
| 10:59:34 | <sunbiz> yes... but how does it show for u?? |
| 11:00:28 | <sunbiz> did u just change the setUseDefaultSuffixPattern ?? |
| 11:00:44 | <sunbiz> in the trunk? |
| 11:04:21 | *** sunbiz has quit IRC |
| 11:04:33 | <bwolfe> sunbiz, /ws/rest/1.0/catalog worked without me changing anything |
| 11:04:41 | <bwolfe> boo, missed him! |
| 11:06:37 | *** surangak has quit IRC |
| 11:22:33 | *** sunbiz has joined #openmrs |
| 11:27:41 | *** james_regen has joined #openmrs |
| 11:27:41 | *** ChanServ sets mode: +v james_regen |
| 11:28:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: openmrs_tag documentation? <http://forum.openmrs.org/viewtopic.php?f=11&t=797#p3018> |
| 11:28:28 | <sunbiz> bwolfe: https://tickets.openmrs.org/browse/RESTWS-170 |
| 11:28:34 | <sunbiz> I have checked the fix and it works |
| 11:28:48 | <sunbiz> I want to commit... I have done the assessment |
| 11:30:20 | <bwolfe> sunbiz, are you not able to see the Ready For Work button? |
| 11:30:25 | <sunbiz> nope... |
| 11:30:41 | <bwolfe> bummer |
| 11:30:42 | <sunbiz> I clicked on "Assign to Me" |
| 11:30:49 | *** magoo has joined #openmrs |
| 11:31:07 | <sunbiz> but the status still remains..."Needs Assessment" |
| 11:31:11 | <bwolfe> ok, moved it |
| 11:31:16 | <bwolfe> and made it so you can move future ones |
| 11:31:31 | <sunbiz> thank u... thank u |
| 11:34:28 | *** muthah has joined #openmrs |
| 11:35:17 | <sunbiz> why do we have a org.openmrs.module.webservices.rest.web.controller.include in the test packages?? |
| 11:35:39 | <bwolfe> ? |
| 11:35:41 | <bwolfe> where? |
| 11:36:26 | <bwolfe> oh, looks empty |
| 11:37:04 | <bwolfe> looks like I committed that last month. perhaps a holdover from when I first created it? |
| 11:38:55 | <sunbiz> yes... it is empty |
| 11:39:55 | <rafa> sunbiz: Is there a reason why tests are not moved to the v1_0 package? |
| 11:40:46 | <rafa> sunbiz: I need to work on them and I'm wondering if you plan to change that and I'll run into conflicts. |
| 11:40:50 | <sunbiz> rafa: yes, they should be moved as well.. because they will also be another one |
| 11:41:13 | <sunbiz> for the new version |
| 11:41:29 | <sunbiz> rafa: should I change now... |
| 11:41:36 | <sunbiz> so.. that u dont have conflicts?? |
| 11:41:43 | <rafa> sunbiz: Great, let me know. |
| 11:42:23 | <sunbiz> bwolfe: in the same change... as the test package name change |
| 11:42:29 | <sunbiz> I will also make it v1 |
| 11:42:39 | <sunbiz> as the 2 dev rule is accepted |
| 11:42:55 | <sunbiz> rafa, dkayiwa and sunbiz have voted for v1 |
| 11:42:56 | <sunbiz> :P |
| 11:43:55 | <sunbiz> bwolfe: so that changes ur 50/50 to 99/1 in favor of v1?? |
| 11:44:39 | <bwolfe> your votes don't change my feelings on it...its just that your votes make the total lopsided |
| 11:44:57 | <bwolfe> so its 3.5 to 2 right now |
| 11:46:54 | <sunbiz> nope... we dont allow .5 votes in our democracy |
| 11:47:08 | <sunbiz> we also have a 2-party system :) |
| 11:47:28 | <bwolfe> haha |
| 11:47:36 | <bwolfe> good thing I own 2 votes then ;-) |
| 11:48:28 | <sunbiz> bwolfe: do we release 0.8 of the module today?? |
| 11:49:04 | <bwolfe> thats the idea... |
| 11:49:32 | <bwolfe> this version thing is the only holdup |
| 11:49:56 | <bwolfe> I would like to get at least an argument from djazayeri and burke about why "1" is sooo much better than "v1" |
| 11:50:08 | <sunbiz> either ways... its not working at the moment |
| 11:50:40 | <bwolfe> right |
| 11:51:06 | <bwolfe> but doing a global search/replace of 1.0 --> 1 or v1 is quick |
| 11:52:41 | <bwolfe> need to fix the poms to say 0.8-SNAPSHOT... |
| 11:52:58 | <sunbiz> :) |
| 12:04:43 | *** magoo has quit IRC |
| 12:06:06 | *** jriley has joined #openmrs |
| 12:17:37 | <sunbiz> rafa: for some reasons tests are failing |
| 12:17:49 | <sunbiz> when I change the packages |
| 12:18:54 | <rafa> sunbiz: I did a quick change and had the same, therefore I left it for you ;) |
| 12:19:19 | <sunbiz> :P |
| 12:19:50 | <rafa> sunbiz: enjoy :D |
| 12:20:00 | *** goutham has quit IRC |
| 12:27:57 | *** wyclif has quit IRC |
| 12:29:56 | <sunbiz> rafa: did u write the resource tests?? does the UserResourceTest fail for u?? |
| 12:30:13 | <rafa> It didn't yesterday. |
| 12:30:43 | <rafa> What is the reason? |
| 12:30:49 | <bwolfe> perhaps because of your null fix from today/. |
| 12:30:50 | <bwolfe> ? |
| 12:32:38 | <sunbiz> rafa: the asRepresentation fails |
| 12:33:02 | <rafa> Okay, leave it failing. I'll deal with it. |
| 12:33:19 | <sunbiz> and ConceptResourceTest |
| 12:33:35 | <rafa> That I can handle too :) |
| 12:33:38 | <sunbiz> bwolfe: independent of my changeset |
| 12:33:42 | <rafa> Anything else? |
| 12:33:45 | <sunbiz> it still fails |
| 12:46:27 | <pascal`> bwolfe, djazayeri, I'm seeing org.openmrs.module.ModuleException (A servlet mapping with name participationServlet already exists. permissionsengine's servlet is trying to overwrite it) |
| 12:46:57 | <pascal`> bwolfe, djazayeri, Whenever I upgrade a module which is a dependent module of the one which contains that servler (participationServlet) |
| 12:47:20 | <pascal`> bwolfe, djazayeri, My config looks okay. Any ideas? I'm 1.7.x. |
| 12:47:32 | *** magoo has joined #openmrs |
| 12:47:45 | *** bwolfe has quit IRC |
| 12:48:05 | *** bwolfe has joined #openmrs |
| 12:48:05 | *** ChanServ sets mode: +o bwolfe |
| 12:51:38 | <sunbiz> rafa: it's been fixed |
| 12:51:47 | <rafa> nice |
| 12:51:47 | <sunbiz> the problem was the component-scan |
| 12:52:16 | <sunbiz> in the webModuleApplicationContext... still was looking through the old packages |
| 12:52:22 | <sunbiz> I'll commit it... |
| 12:52:24 | <sunbiz> ok?? |
| 12:52:56 | <rafa> Fine for me. |
| 13:04:11 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 0.9.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&0.9.0.1> |
| 13:05:01 | <sunbiz> rafa: committed. you can now update and make the changes |
| 13:05:14 | <rafa> sunbiz: thanks! |
| 13:06:05 | *** sunbiz has quit IRC |
| 13:12:32 | *** downeym has joined #openmrs |
| 13:12:32 | *** OpenMRSBot sets mode: +o downeym |
| 13:12:32 | *** ChanServ sets mode: +o downeym |
| 13:21:26 | *** wyclif has joined #openmrs |
| 13:22:40 | *** wyclif has quit IRC |
| 13:22:49 | *** wyclif has joined #openmrs |
| 13:24:58 | *** sunbiz has joined #openmrs |
| 13:25:13 | *** ChanServ sets mode: +v sunbiz |
| 13:26:24 | <sunbiz> bwolfe: why doesnt tests work in eclipse :P |
| 13:28:12 | <bwolfe> whats the error? |
| 13:28:15 | <sunbiz> https://tickets.openmrs.org/browse/RESTWS-164 |
| 13:28:55 | <sunbiz> I wouldn't know... I use Netbeans |
| 13:29:01 | <sunbiz> u filed that issue |
| 13:29:20 | <sunbiz> was feeling bored... so thought I'd pull ur leg with ur sophisticated IDE :P |
| 13:31:00 | *** downeym sets mode: +v pascal` |
| 13:31:03 | *** downeym sets mode: +v wyclif |
| 13:31:05 | *** downeym sets mode: +v vchircu |
| 13:31:30 | <downeym> james_regen: please remember to do your GSoC midterm evaluation this morning. :) should take only a minute or two. thanks! |
| 13:34:49 | <sunbiz> downeym: my face wont b on the mainpage :P |
| 13:34:56 | <sunbiz> with an 'X' !!! |
| 13:35:09 | <downeym> sunbiz: thanks! :) |
| 13:35:25 | <sunbiz> downeym: I was waiting for my student's presentation yest |
| 13:37:42 | * downeym is very pleased with the quality of the presentations this year |
| 13:37:56 | <bwolfe> which mainpage? |
| 13:37:58 | <downeym> (and by extension the quality of the students' projects) |
| 13:38:24 | * downeym has a dashboard with student-mentors and big red "Not submitted"s |
| 13:39:39 | <sunbiz> OpenMRS homepage = mainpage :P |
| 13:40:05 | <sunbiz> yest... on the call ppl said who doesn't complete |
| 13:40:15 | <sunbiz> the mentors face will be put with an 'X' |
| 13:40:53 | <bwolfe> ah. that must have been mentioned one of the times I was dropped... |
| 13:41:13 | <sunbiz> :) |
| 13:41:54 | <downeym> i had it all ready to go to |
| 13:42:04 | <downeym> http://cl.ly/3b240v2q041w332H193k |
| 13:42:59 | <sunbiz> downeym-- |
| 13:43:29 | <sunbiz> ok guys... ciao... the theatre is waiting for me!! |
| 13:43:49 | *** sunbiz has quit IRC |
| 13:47:39 | <bwolfe> man, cl.ly is soo slow to load |
| 13:47:51 | <downeym> hm, really? |
| 13:47:54 | <bwolfe> for a simple pic it must be loading about 500k of js and css in the background or something |
| 13:48:34 | <downeym> s/500/279/ |
| 13:49:18 | <downeym> webfonts-- |
| 13:49:52 | <bwolfe> yeah, and they don't seem to cache |
| 13:50:22 | <bwolfe> everytime you've linked there it takes the same 1.5 minutes to load |
| 13:50:38 | <downeym> bwolfe: time to move |
| 13:52:24 | <bwolfe> it'd be easier for you to get a better image sharing site |
| 13:59:50 | *** gbastien has joined #openmrs |
| 14:04:16 | *** gbastien has quit IRC |
| 14:05:39 | <djazayeri> hi |
| 14:09:56 | *** danielf` has quit IRC |
| 14:12:56 | <djazayeri> bwolfe, wyclif, rafa, dkayiwa, scrum time? |
| 14:13:00 | <djazayeri> or did I miss it? |
| 14:13:43 | <rafa> djazayeri: Hi! |
| 14:13:49 | <bwolfe> no scrum done yet. |
| 14:13:56 | <bwolfe> but yes, it is time |
| 14:14:32 | <bwolfe> rafa, want to go first? |
| 14:14:42 | <rafa> sure |
| 14:15:21 | <rafa> today: release META 0.9.0.1, polished META docs, worked on RESTWS-153 and TRUNK-2433. |
| 14:15:32 | <wyclif> hey |
| 14:15:41 | <rafa> Monday: looking forward to the UI spring |
| 14:15:45 | <rafa> *sprint |
| 14:15:51 | <rafa> No blockers |
| 14:16:14 | <bwolfe> are you done with 155 ? |
| 14:16:22 | <rafa> 153? |
| 14:16:30 | <rafa> Not yet |
| 14:16:38 | <rafa> But in an hour yes |
| 14:17:06 | <bwolfe> ok, so by EOB today? |
| 14:17:13 | *** gbastien has joined #openmrs |
| 14:17:21 | <rafa> yes, thanks |
| 14:17:31 | <bwolfe> awesome |
| 14:17:46 | *** magoo has quit IRC |
| 14:17:59 | <bwolfe> we don't need to wait on the alpha release for that, but would be nice to have all sprint tickets completed this week :-) |
| 14:18:45 | <bwolfe> wyclif, ? |
| 14:19:09 | <rafa> sure hope it gets though code-review this time ;) |
| 14:19:09 | <wyclif> yesterday: spent time with ankur and helped him with TRUNK-2193 and liquibase in general, fixed getResourceCatalog url, finished the discontinueOrders ticket |
| 14:19:09 | <wyclif> review comments from last sprint. |
| 14:19:51 | <wyclif> Today: Work on tickets in TRUNK unless you want me to work on WS tickets |
| 14:20:40 | <bwolfe> wyclif, I have no ws tickets for you. so yes, do 1.9 TRUNk tickets and/or apply patches that have been submitted by volunteers |
| 14:20:50 | <bwolfe> (or go through your crucible queue) |
| 14:21:01 | <djazayeri> wyclif: https://source.openmrs.org/cru/CR-TRUNK-398 |
| 14:22:50 | <wyclif> djazayeri, i will review it |
| 14:23:10 | <wyclif> i have things to clean in crucible |
| 14:24:02 | <wyclif> oh yes, i need to create reviews for patchses for 1.9 tickets |
| 14:24:12 | <bwolfe> ok. theres always work to be done. if you're out of things to work on, you'll never be chastised for taking a ticket that is assigned to a release and doing it. :-) |
| 14:24:16 | <djazayeri> also, would you mind going through the installation instructions for 2.x here: https://wiki.openmrs.org/x/7ADn just to make sure that they still work for you? |
| 14:24:45 | <djazayeri> and/or doing an svn update on your existing checkout |
| 14:25:57 | <wyclif> ok |
| 14:26:59 | <bwolfe> ok, daniel has been missing all afternoon. perhaps internet/power issues? |
| 14:27:09 | <bwolfe> djazayeri? |
| 14:27:46 | <djazayeri> Yesterday: |
| 14:27:47 | <djazayeri> * prepared for 2.x UI sprint |
| 14:27:47 | <djazayeri> * fixed 2.x install documentation |
| 14:27:47 | <djazayeri> * code reviews on multiple-providers-per-encounter |
| 14:27:47 | <djazayeri> * final acceptance test of Metadata Sharing |
| 14:27:47 | <djazayeri> Today: |
| 14:27:48 | <djazayeri> * final pass at preparing 2.x sprint tickets |
| 14:27:48 | <djazayeri> * ??? |
| 14:28:25 | <bwolfe> ok, are the ??? supposed to mean you don't expect that ot take all day? :-) |
| 14:29:25 | <djazayeri> Yes. It means that I'll do something else, so I'm open to do something specific that anyone might ask for help with, or else I'll self-assing |
| 14:29:29 | <djazayeri> assign |
| 14:29:39 | <bwolfe> wyclif: bam! spring app setup error probably |
| 14:30:08 | <wyclif> bwolfe, is that CI |
| 14:30:10 | <bwolfe> djazayeri, there are other ws tickets...but there are also plenty of trunk things to do as told to wyclif :-) |
| 14:30:12 | <bwolfe> wyclif, yes |
| 14:30:21 | *** pascal` has quit IRC |
| 14:30:51 | *** mandric has joined #openmrs |
| 14:30:57 | <djazayeri> right, I know there's no shortage of things to do |
| 14:31:22 | <djazayeri> But if anyone has anything urgent, or semi-blocker-ish, I can help with that. |
| 14:32:55 | <bwolfe> ok |
| 14:33:14 | <bwolfe> me today: |
| 14:33:14 | <bwolfe> fought with versioning spring bug |
| 14:33:14 | <bwolfe> ws documentation cleanup and additions |
| 14:33:14 | <bwolfe> ws release prep |
| 14:33:14 | <bwolfe> ws ticket cleanup |
| 14:33:14 | <bwolfe> monday: |
| 14:33:16 | <bwolfe> ws final cleanup |
| 14:33:18 | <bwolfe> ui sprinting |
| 14:33:22 | <bwolfe> a little occ sprint setup |
| 14:34:01 | <bwolfe> my blocker is the versioning |
| 14:34:13 | <bwolfe> we need to decide on that before I can cut the release |
| 14:34:27 | <bwolfe> and wyclif, I 'll need you to do the standalone for that. |
| 14:34:36 | <djazayeri> okay, let's discuss. (I see you all discussed earlier too...) |
| 14:34:45 | <wyclif> for 1.8.1 with WS module? |
| 14:35:05 | <bwolfe> (just take the 1.8.1 standalone and add the released ws module to the web-inf/bundledModules folder and rezip) |
| 14:35:09 | <wyclif> ok |
| 14:35:43 | <bwolfe> be sure to name the file 1.8.1-stable-with-WS-alpha. then upload to https://sourceforge.net/projects/openmrs/files/prereleases/OpenMRS_1.8.1_Web_Services_Alpha/ |
| 14:46:04 | <wyclif> ok |
| 14:46:24 | <downeym> openmrs-1.8.1-stable-with-WS-alpha.zip ? |
| 14:46:25 | <bwolfe> djazayeri, so about versioning... |
| 14:46:30 | <djazayeri> yes... |
| 14:46:31 | <wyclif> just let me know when you are done with releaseing the alpha |
| 14:46:46 | <djazayeri> Do we know when spring expects to fix that bug? |
| 14:46:54 | <bwolfe> daniel, rafal, and sunny all vote for "v1" |
| 14:46:59 | <djazayeri> about the . I mean |
| 14:47:03 | <bwolfe> its supposed to be in 3.1 and then another fix in 3.2 |
| 14:47:16 | <djazayeri> we're on 3.0.5? |
| 14:47:17 | <bwolfe> but what has me worried is that the workaround in the ticket doesn't even work |
| 14:47:20 | <bwolfe> yes |
| 14:47:57 | <djazayeri> in any case we don't want to count on having to upgrade spring in our release branches just to get this to work |
| 14:48:08 | <djazayeri> So, I'm fine with v1 |
| 14:48:15 | <wyclif> bwolfe, just to a confirmation 1.8.1 with Ws module is a prerelease? |
| 14:48:30 | <wyclif> sorry about my grammar |
| 14:48:48 | <djazayeri> did we actually intend to use major and minor versions to refer to the WS API? |
| 14:49:07 | <djazayeri> i.e. I'm fine going v1, v2, v3, ... |
| 14:49:14 | <djazayeri> instead of 1.0, 1.1, ... |
| 14:49:17 | <bwolfe> wyclif, yes, that folder I linked you to was right |
| 14:49:35 | <bwolfe> djazayeri, yeah, thats my thought too, if we can never get it to work |
| 14:49:46 | <bwolfe> yes, 1.1, 1.2, 1.3 was the idea |
| 14:50:01 | <djazayeri> right, but was there an actual point to that? |
| 14:50:23 | <djazayeri> If we have an actual good reason for major and minor versions, we could do 1_0 |
| 14:50:24 | <bwolfe> the benefit of doing v1, v2, v3, v4 is that it will be significantly different than the module version and of the openmrs version that people won't get confused |
| 14:50:46 | <djazayeri> Yeah, I tend to think that v1 is actually _better_ than 1.0 |
| 14:50:49 | <djazayeri> so you have my blessing |
| 14:51:25 | <rafa> djazayeri, bwolfe do all representation need to include display property or just ref? |
| 14:51:50 | <djazayeri> so far only ref includes them, though our original intention may have been to include it in all reps |
| 14:51:51 | <bwolfe> ha, ok. now we just have to deal with burke's utter contempt for the next however many years we use this... |
| 14:52:01 | <downeym> :) |
| 14:52:16 | <rafa> so I'll test only ref |
| 14:53:09 | <djazayeri> bwolfe: thinking about that, shouldn't we be including "display" in all reps? |
| 14:53:33 | *** wyclif has quit IRC |
| 14:55:09 | <djazayeri> I suppose that can wait until 0.9 and/or if people ask for it. |
| 14:55:18 | <bwolfe> yeah, we can put it to a vote |
| 14:55:25 | <bwolfe> make a ticket for it and put it on the "ask the users" pile |
| 14:55:48 | <rafa> bwolfe: okay |
| 14:56:12 | <djazayeri> do we have a JIRA label for that? e.g. get-user-feedback or something? |
| 14:57:33 | *** wyclif has joined #openmrs |
| 14:57:33 | <djazayeri> (gotta run for a bit) |
| 15:00:20 | <bwolfe> djazayeri, I don't know of a label. The pile is all theoretical at this point |
| 15:00:30 | <bwolfe> dinner time for me. I'll be back to release soon |
| 15:00:49 | <bwolfe> rafa, wyclif, if you're bored, can one of you do the 1.0 to v1 change in the rest module? |
| 15:01:07 | <rafa> bwolfe: I'm finishing 153 |
| 15:01:15 | <wyclif> I WILL |
| 15:01:27 | <wyclif> BUT I ALSO WANT TO MAKE THE VERSION A CONSTANT |
| 15:01:44 | <wyclif> right now it is hard coded |
| 15:02:08 | <bwolfe> hard coded is fine. when we increment we'll be copying all the files and moving them to a new package |
| 15:02:44 | <wyclif> ok |
| 15:05:17 | *** mandric has quit IRC |
| 15:05:26 | *** asgoyal has joined #openmrs |
| 15:05:57 | *** muthah has quit IRC |
| 15:08:41 | <djazayeri> wyclif: in JIRA the 1.8.1 version is still showing up as unreleased |
| 15:08:44 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Removing stray not-null constraint added to visit.changed_by in rev:21618 - TRUNK-2239 <http://feedproxy.google.com/~r/OMRStrunk/~3/UwRRTmykCmo/OpenMRS> || OpenMRS Forum: Patient Register Module <http://forum.openmrs.org/viewtopic.php?f=8&t=798#p3019> || New Changeset: OpenMRS (trunk): Making changes after last review comments - TRUNK-2239 <http://feedproxy.google.com/~r/OMRStrunk/~3/LsTuVexxEag/OpenMRS> |
| 15:08:48 | *** goutham has joined #openmrs |
| 15:08:50 | <djazayeri> do you have privileges to release it? or should I? |
| 15:09:06 | <wyclif> let me see |
| 15:10:42 | <wyclif> i actually don't even know how to do it |
| 15:11:03 | <djazayeri> Administration -> Project: OpenMRS TRUNK |
| 15:11:07 | *** rafa has quit IRC |
| 15:11:12 | <djazayeri> (you need to be looking at a trunk ticket to see this in the menu bar) |
| 15:12:12 | *** rafa has joined #openmrs |
| 15:12:12 | *** ChanServ sets mode: +v rafa |
| 15:26:10 | *** lh has joined #openmrs |
| 15:26:58 | *** vchircu_ has joined #openmrs |
| 15:27:00 | *** vchircu has quit IRC |
| 15:29:48 | *** mandric has joined #openmrs |
| 15:37:01 | *** gbastien has quit IRC |
| 15:56:00 | *** kane77 has joined #openmrs |
| 16:01:11 | <wyclif> bwolfe, have you tagged the 0.8 yet? |
| 16:03:03 | *** jwishnie has joined #openmrs |
| 16:14:43 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Follow up to apply changes after code review for, UI changes to support Encounter.visit - TRUNK-2238 <http://feedproxy.google.com/~r/OMRStrunk/~3/mYI0O6leW3M/OpenMRS> |
| 16:19:38 | *** djazayeri has quit IRC |
| 16:30:04 | *** goutham has quit IRC |
| 16:41:31 | *** jriley has quit IRC |
| 16:43:09 | *** djazayeri has joined #openmrs |
| 16:43:09 | *** ChanServ sets mode: +o djazayeri |
| 17:09:08 | *** rahul__ has joined #openmrs |
| 17:11:42 | <rahul__> !next |
| 17:11:42 | <OpenMRSBot> rahul__: Error: "next" is not a valid command. |
| 17:17:07 | *** goutham has joined #openmrs |
| 17:20:56 | <asgoyal> djazayeri: i have a question |
| 17:21:01 | <djazayeri> yes? |
| 17:21:04 | <asgoyal> List cats = sess.createCriteria(Cat.class) |
| 17:21:04 | <asgoyal> .createAlias("kittens", "kt") |
| 17:21:04 | <asgoyal> .createAlias("mate", "mt") |
| 17:21:04 | <asgoyal> .add( Restrictions.eqProperty("kt.name", "mt.name") ) |
| 17:21:04 | <asgoyal> .list(); |
| 17:21:10 | <asgoyal> in this code snippet |
| 17:21:19 | <asgoyal> kittens and mate are they two different tables? |
| 17:21:27 | <djazayeri> no |
| 17:21:51 | <asgoyal> so like i want to create a join between drug and drugingredient |
| 17:21:53 | *** lh has quit IRC |
| 17:21:56 | <djazayeri> presumably you have something like: class Cat { Cat mate; Set<Cat> kittens; … } |
| 17:22:04 | <asgoyal> oh |
| 17:22:30 | <asgoyal> how will i do this for drug and drugingredient tables |
| 17:23:18 | <djazayeri> you mean you want to find all drugs that have the given ingredient? |
| 17:23:23 | <asgoyal> yes |
| 17:23:31 | <djazayeri> so, I can think of two ways to do this in HQL |
| 17:23:51 | <asgoyal> drug.ingredient = drugIngredient.ingredient = given ingredient |
| 17:23:59 | <djazayeri> 1. select distinct drug from DrugIngredient where concept = :concept |
| 17:24:06 | <asgoyal> i know how to do that in sql |
| 17:24:08 | <asgoyal> oh yeah |
| 17:25:23 | <asgoyal> Drugingredient has drug_id as its foreign key |
| 17:25:27 | <djazayeri> 2. something using "elements", which I've never actually used before |
| 17:25:50 | <djazayeri> something like: from Drug d where :concept = any elements(d.ingredients.concept) |
| 17:26:02 | <asgoyal> woah! |
| 17:26:14 | <asgoyal> ok i will search online for some tutorials |
| 17:26:30 | *** rahul__ has quit IRC |
| 17:26:34 | <djazayeri> I have never found good documentation of the "elements" thing |
| 17:27:15 | <djazayeri> but you can find hql tutorials, or look straight in the hibernate docs |
| 17:27:35 | <djazayeri> you can also do this with a criteria query, using a projection |
| 17:28:33 | <djazayeri> I find those a bit harder to think about than using HQL though. |
| 17:29:20 | <asgoyal> i know how to do it with sql queries |
| 17:29:42 | <djazayeri> asgoyal: hql != sql |
| 17:29:46 | <djazayeri> but it's more sql-like |
| 17:29:51 | <asgoyal> oops |
| 17:30:04 | *** bwolfe has quit IRC |
| 17:30:17 | <djazayeri> http://docs.jboss.org/hibernate/core/3.3/reference/en/html/queryhql.html |
| 17:30:22 | <OpenMRSBot> <http://ln-s.net/8zmg> (at docs.jboss.org) |
| 17:31:01 | <asgoyal> yep found it |
| 17:31:18 | <asgoyal> is there no way to do it using criteria api? |
| 17:31:28 | <djazayeri> yes, you can use criteria query with a projection |
| 17:31:40 | <djazayeri> i.e. you do the criteria query on _DrugIngredient_ (not on Drug) |
| 17:31:49 | <asgoyal> ok |
| 17:31:51 | <djazayeri> but you need to select the distinct Drug from that |
| 17:32:47 | <asgoyal> hm.. |
| 17:33:46 | <djazayeri> using a projection |
| 17:36:33 | *** rafa has quit IRC |
| 17:42:48 | *** bwolfe has joined #openmrs |
| 17:42:48 | *** ChanServ sets mode: +o bwolfe |
| 17:48:43 | *** lh has joined #openmrs |
| 17:49:26 | <bwolfe> are the restws tests workign for anyone else? I'm getting a lot of IllegalStateExceptions :-/ |
| 17:50:27 | <bwolfe> wyclif, djazayeri ^^ |
| 17:50:48 | <djazayeri> haven't tried recently |
| 17:50:51 | <djazayeri> I can update and try |
| 17:51:07 | <wyclif> hi |
| 17:51:42 | *** Suranga has joined #openmrs |
| 17:52:39 | <bwolfe> hi wyclif. can you run the tests? |
| 17:54:44 | <wyclif> let me try |
| 18:04:07 | <asgoyal> djazayeri: using projections will be like adding all the columns of drug table to projection list... kind of duplicating.. |
| 18:04:33 | <djazayeri> Are you sure? |
| 18:04:41 | <djazayeri> You can't just project to the "drug" property and that's all? |
| 18:04:54 | <asgoyal> hm... that is what i m seeing in the tutorial.. :S |
| 18:05:19 | <asgoyal> i dont know if we can say this |
| 18:05:26 | <asgoyal> .add(Projections.property(drug)); |
| 18:05:27 | <asgoyal> or |
| 18:05:32 | <asgoyal> .add(Projections.property(Drug.class)); |
| 18:05:43 | <djazayeri> .add(Projectsion.property("drug")) |
| 18:06:07 | <asgoyal> but... that is not a column... |
| 18:06:15 | <djazayeri> Don't think about columns. |
| 18:06:15 | <asgoyal> its a whole table |
| 18:06:20 | <asgoyal> oh ok |
| 18:06:23 | <djazayeri> In Hibernate you're working with java objects |
| 18:06:27 | <asgoyal> oh |
| 18:06:50 | <djazayeri> i.e. pretend you're working with the DrugIngredient java class, not with the underlying drug_ingredient table |
| 18:07:07 | <asgoyal> oh ok |
| 18:07:27 | <asgoyal> so even for expressions like : |
| 18:07:29 | <djazayeri> that's why you can say: .add(Restrictions.eq("concept", someConcept)) |
| 18:07:55 | <asgoyal> searchDrugCriteria.add(Expression.eq("drug", ingredient)); |
| 18:08:03 | <asgoyal> oh restrictions... |
| 18:08:18 | <asgoyal> whats the difference btw the restrictions and expression... |
| 18:08:20 | <asgoyal> both the same? |
| 18:08:31 | <djazayeri> expressions is the old way. I think it get deprecated in Hibernate 3.5 or something |
| 18:08:37 | <asgoyal> oh |
| 18:08:41 | <djazayeri> Use Restriction. (They behave identically.) |
| 18:08:46 | <asgoyal> oki |
| 18:08:57 | <djazayeri> so, the point is that you're talking about properties of java objects |
| 18:09:17 | <asgoyal> ahm |
| 18:09:30 | <djazayeri> so if you do a restriction against "drug" (on the DrugIngredient class) you need to compare it to a Drug |
| 18:10:51 | <djazayeri> in this case, you're looking for DrugIngredients whose *concept* (maybe the property is called "ingredient"?) is equal to the value passed in by the user |
| 18:12:12 | *** bwolfe has quit IRC |
| 18:21:26 | *** gbastien has joined #openmrs |
| 18:25:28 | *** bwolfe has joined #openmrs |
| 18:25:28 | *** ChanServ sets mode: +o bwolfe |
| 18:27:21 | *** Suranga has quit IRC |
| 18:28:32 | *** mandric has quit IRC |
| 18:31:57 | *** downeym has quit IRC |
| 18:32:12 | *** asgoyal has quit IRC |
| 18:38:14 | *** asgoyal has joined #openmrs |
| 18:43:33 | *** djazayeri has quit IRC |
| 18:56:12 | *** asgoyal has quit IRC |
| 19:00:24 | *** vchircu_ has quit IRC |
| 19:05:28 | *** downeym has joined #openmrs |
| 19:05:28 | *** ChanServ sets mode: +o downeym |
| 19:05:28 | *** OpenMRSBot sets mode: +o downeym |
| 19:07:13 | *** lh has quit IRC |
| 19:12:57 | *** kane77 has quit IRC |
| 19:13:45 | *** kane77 has joined #openmrs |
| 19:17:35 | *** downeym sets mode: +v goutham |
| 19:17:50 | <downeym> congratulations, bryq & goutham - everyone passed mid-term :) |
| 19:18:11 | <bryq> downeym: Thanks! |
| 19:21:12 | *** djazayeri has joined #openmrs |
| 19:21:12 | *** ChanServ sets mode: +o djazayeri |
| 19:32:35 | *** kane77 has quit IRC |
| 19:37:01 | <wyclif> bwolfe, |
| 19:48:57 | <wyclif> wyclif, the version number should be a constant because it is very easy to forget all the areas in the code to update when changing it value |
| 19:49:25 | <wyclif> djazayeri, bwolfe , right now all urls for representations ara wrong |
| 19:49:38 | <wyclif> because we never included the v1 |
| 19:49:52 | <wyclif> i will be committing the change |
| 19:52:49 | *** jwishnie has quit IRC |
| 19:53:17 | *** james_regen has quit IRC |
| 19:54:49 | *** jwishnie has joined #openmrs |
| 19:56:44 | <goutham> downeym: many thanks :) :) |
| 19:57:04 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congratulations to our 15 Google Summer of Code students on passing midterm evaluations! http://bit.ly/oObPFV #OpenMRS #GSoC <http://twitter.com/OpenMRS/statuses/91949194176241664> |
| 19:59:41 | *** rafa has joined #openmrs |
| 19:59:41 | *** ChanServ sets mode: +v rafa |
| 20:06:22 | <bwolfe> wyclif, is that why tests are failing? |
| 20:09:38 | <wyclif> am not sure, may be it could also one of the reasons |
| 20:10:04 | <wyclif> the funny thing is that i can run them individually |
| 20:10:12 | <wyclif> but they fail with maven test |
| 20:10:54 | <bwolfe> hmm, so seems to be a batch running problem |
| 20:18:00 | <bwolfe> wyclif, where are you putting the version in the reps? |
| 20:20:05 | <wyclif> bwolfe, DelegatingCrudResource.getUri |
| 20:20:18 | <wyclif> needs to include the v1 |
| 20:20:22 | <wyclif> i have added it |
| 20:20:27 | <wyclif> but have not yet committed |
| 20:20:28 | <bwolfe> wyclif, thats a temporary fix |
| 20:20:35 | *** mandric has joined #openmrs |
| 20:20:46 | <bwolfe> put a comment on there that that is NOT the right place to put it. what happens when we have a v2? |
| 20:21:29 | <wyclif> that is why am using constants |
| 20:21:39 | <djazayeri> constants isn't the point |
| 20:22:01 | <bwolfe> wyclif, we will still support v1 when v2 is out |
| 20:22:07 | <bwolfe> so a simple constant is also not the solution |
| 20:22:23 | <bwolfe> the resource needs to specify the version number somehow |
| 20:22:38 | <wyclif> i guess |
| 20:23:04 | <djazayeri> I think the right solution is probably to make sure that RequestContext gets passed everywhere, including to this getUri method |
| 20:23:20 | <djazayeri> but that's not something to do today before releasing the module |
| 20:32:20 | <wyclif> i added a TODO comment that the version number should be passed in to the getURI methods |
| 20:32:47 | <djazayeri> instead say that the RequestContext should be passed... |
| 20:35:27 | <djazayeri> none of the unit tests pass for me |
| 20:35:39 | <djazayeri> I get: No bean named 'xmlMarshallingHttpMessageConverter' is defined |
| 20:38:00 | <bwolfe> djazayeri, you have to update your 1.8.x and install it to your maven repo |
| 20:38:09 | <djazayeri> I did, I thought. |
| 20:38:14 | <djazayeri> okay, will try again |
| 20:43:41 | <bwolfe> wyclif, are you still testing? |
| 20:45:55 | *** goutham has quit IRC |
| 20:49:01 | <wyclif> the tests are still failing |
| 20:49:22 | <bwolfe> yeah, figures |
| 20:49:28 | <bwolfe> the tests don't really do anything with the self links |
| 20:49:36 | <wyclif> according to what am noticing, i get lazy initialization exceptions |
| 20:49:53 | <wyclif> i think the opensession in view is not working for ws urls |
| 20:49:55 | <wyclif> may be |
| 20:50:05 | *** rafa has quit IRC |
| 20:50:25 | <wyclif> but when i run them individually they pass |
| 20:52:18 | <bwolfe> wyclif, what changed recently? |
| 20:52:27 | <bwolfe> they were passing within the last few days... |
| 20:52:42 | * bwolfe wishes he had set up ci |
| 20:56:58 | <wyclif> adding versions to urls and the resource tests |
| 20:57:05 | <wyclif> could be the resource tests |
| 20:58:57 | <djazayeri> does it work when you run it at the command line, i.e. not through eclipse? |
| 20:59:14 | <bwolfe> not for me, same error |
| 20:59:21 | <djazayeri> it's NPEs? |
| 20:59:36 | <bwolfe> no, LIEs |
| 20:59:39 | <bwolfe> all LIEs |
| 21:00:12 | <djazayeri> oh, right, sorry, that |
| 21:03:20 | <djazayeri> dunno, it won't run at all for me. |
| 21:03:25 | <djazayeri> I keep seeing no such bean definition |
| 21:03:53 | <bwolfe> djazayeri, clean install on both 1.8.x and restws? |
| 21:03:55 | <djazayeri> (hmm, maybe because I rebuild 1.8.x with skip-tests) |
| 21:04:17 | <bwolfe> skipping tests shoudl be ok |
| 21:04:20 | <bwolfe> did you do "install" ? |
| 21:04:33 | <djazayeri> I've done clean install on 1.8.x three times now... |
| 21:04:37 | <djazayeri> both through eclipse and from the command line |
| 21:05:20 | <djazayeri> Anyway, I'll only continue trying to figure that out if it's useful to you. |
| 21:06:31 | <bwolfe> no, thats alright |
| 21:06:40 | <bwolfe> its failing for wyclif in the same way, thats good enough for me |
| 21:07:44 | *** bwolfe_ has joined #openmrs |
| 21:07:44 | *** ChanServ sets mode: +o bwolfe_ |
| 21:11:18 | *** bwolfe has quit IRC |
| 21:11:41 | <bwolfe_> JIRA on a slow connection is really REALLY annoying |
| 21:14:35 | <wyclif> he he he |
| 21:15:54 | <wyclif> have you gys tried to change your maven dependency to 1.8.1-SNAPSHOT given that after releasing 1.8.1 the snaphot name changed |
| 21:16:12 | <wyclif> but if this was the reason for failing, the error message would say so |
| 21:16:26 | <wyclif> sorry to 1.8.2-SNAPSHOT |
| 21:16:33 | <bwolfe_> ah, good catch wyclif |
| 21:17:01 | <djazayeri> :-) |
| 21:17:01 | <bwolfe_> he probably still has the 1.8.0-SNAPSHOT in his repo and so when he rebuilds 1.8.x it is installing 1.8.1-SNAPSHOT |
| 21:17:12 | <djazayeri> yup |
| 21:17:28 | <djazayeri> really we should be pointing at the released 1.8.1, not our snapshot builds |
| 21:17:31 | *** bwolfe_ is now known as bwolfe |
| 21:17:33 | <bwolfe> right |
| 21:17:46 | <bwolfe> wyclif, did you submit 1.8.1 to the openmrs maven repo? |
| 21:18:00 | <wyclif> nope |
| 21:20:31 | <bwolfe> can you do that? then we can change the restws poms to point at 1.8.1 |
| 21:21:22 | <djazayeri> Are there instructions somewhere on how to submit to the openmrs maven repo? |
| 21:22:06 | <bwolfe> release process page? |
| 21:22:07 | <downeym> btw - nexus was upgraded last night to 1.9.2. if you see any strangeness (not expected) let me know. |
| 21:23:47 | <wyclif> how do you add them o the nexus repo? |
| 21:25:26 | <wyclif> hello |
| 21:26:18 | <bwolfe> I dunno |
| 21:26:26 | <bwolfe> is it not on the release process page? |
| 21:26:56 | <djazayeri> the release process page mentions "mvn clean deploy --batch-mode" |
| 21:27:50 | <djazayeri> so, wyclif, try the instructions on that apge |
| 21:28:45 | <wyclif> ok |
| 21:32:13 | <wyclif> the instructions on the release process page hardly say anything |
| 21:43:21 | *** bwolfe has quit IRC |
| 21:43:53 | *** bwolfe has joined #openmrs |
| 21:43:53 | *** ChanServ sets mode: +o bwolfe |
| 21:48:53 | *** bwolfe_ has joined #openmrs |
| 21:48:53 | *** ChanServ sets mode: +o bwolfe_ |
| 21:49:25 | <wyclif> am not authorized to do so, am getting error 401 |
| 21:49:27 | *** bwolfe has quit IRC |
| 21:49:30 | *** bwolfe_ is now known as bwolfe |
| 21:49:37 | <djazayeri> bwolfe: ^^ |
| 21:49:40 | <wyclif> an trying to find out how i authenticate |
| 21:49:43 | <bwolfe> I can make him an admin |
| 21:49:55 | <bwolfe> its seperate from all the id stuff, iirc |
| 21:50:01 | <wyclif> that if even i have the privileges |
| 21:51:08 | <downeym> wyclif: do you have an account? |
| 21:51:33 | <wyclif> for nexus repo? |
| 21:51:34 | <wyclif> no |
| 21:51:47 | <downeym> Do you want one? :) |
| 21:51:57 | <bwolfe> I just made him one |
| 21:52:01 | <downeym> k |
| 21:52:48 | <wyclif> what is my username and password |
| 21:52:48 | <wyclif> ? |
| 21:53:39 | <bwolfe> wyclif, I sent a private message to you with them |
| 21:54:55 | <wyclif> ok |
| 21:54:58 | <wyclif> thanks |
| 21:57:02 | <wyclif> i still cant log in |
| 21:58:52 | <wyclif> apparently i can login via the browser but not the command line |
| 22:05:42 | <bwolfe> djazayeri, its getting way too late for me here. any chance you have time this afternoon to do the final release? :-( |
| 22:06:03 | <djazayeri> okay |
| 22:06:04 | <bwolfe> I have the email typed up, you just have to send it once you package/post the omod and wyclif uploads the standalone |
| 22:06:17 | <djazayeri> are things actually working unit-test-wise? |
| 22:06:31 | <djazayeri> are we actually blocked on putting 1.8.1 in nexus? |
| 22:06:37 | <djazayeri> I haven't done that before, so I'll try now. |
| 22:06:45 | <wyclif> bwolfe, am trying to look at the usage for the command bu t i cant seem to tell how to pass in my username and password |
| 22:07:08 | <bwolfe> wyclif, the same way you do for all other maven commands probably |
| 22:07:20 | <bwolfe> or you can just upload in nexus manually, can't you? |
| 22:07:30 | <bwolfe> no, we don't have to block on 1.8.1 in the repo |
| 22:08:48 | <wyclif> that is the last resort |
| 22:09:13 | <bwolfe> -Dusername=wyclif -Dpassword=123123123 didn't work for you? |
| 22:09:21 | <wyclif> the maven commands -Dusername and -Dpassword have failed |
| 22:09:42 | <wyclif> they are the ones i have been using all along |
| 22:09:48 | <bwolfe> djazayeri, unit tests are not working as a batch, but they work individually. somewhere there is a variable or cache that is not getting cleared |
| 22:10:09 | <djazayeri> okay, so perhaps we should release restws first, and deal with nexus later? |
| 22:11:01 | <bwolfe> I'm fine with that |
| 22:11:08 | <bwolfe> wyclif, http://www.google.com/search?client=ubuntu&channel=fs&q=mvn+deploy+username+password&ie=utf-8&oe=utf-8 |
| 22:11:11 | <OpenMRSBot> <http://ln-s.net/8zot> (at www.google.com) |
| 22:11:33 | <bwolfe> and http://maven.apache.org/plugins/maven-deploy-plugin/usage.html says that it should be in your settings.xml file |
| 22:11:36 | <OpenMRSBot> <http://ln-s.net/8zou> (at maven.apache.org) |
| 22:12:03 | <djazayeri> do I have credentials for nexus, btw? |
| 22:12:18 | <bwolfe> no, but I can give you some |
| 22:13:14 | <djazayeri> settings.xml is in the same directory as pom.xml? |
| 22:13:27 | <bwolfe> djazayeri, its in your .m2 maven repo folder |
| 22:14:30 | <bwolfe> downeym, shouldn't the 1.8 ci project deploy the 1.8.1 to nexus? or did matt not finish setting that up? |
| 22:15:11 | <downeym> the junit project? |
| 22:15:19 | <djazayeri> any mac users know how to show files that start with a . in Finder? |
| 22:16:01 | <downeym> djazayeri: i don't think you can through the normal finder UI |
| 22:16:09 | <downeym> djazayeri: if you have onyx installed it's an option |
| 22:16:21 | <downeym> bwolfe: all we do in CI is clean install --batch-mode |
| 22:18:04 | <wyclif> in the browser i cant even see the upload/add buttons |
| 22:18:18 | <bwolfe> djazayeri, why not use the command line? |
| 22:18:18 | <wyclif> probably i dont have enough provileges to deploy |
| 22:18:44 | <wyclif> because it is also failing because authentication is failing |
| 22:18:49 | <bwolfe> downeym, I thought we made a new project for creating release packages for 1.8 |
| 22:19:05 | <downeym> bwolfe: no, we never got past documenting the release process :) |
| 22:19:25 | <bwolfe> ok |
| 22:20:00 | <bwolfe> alright, I'm off for the night. if you guys don't feel comfortable releasing later today, don't worry about it, we still have tomorrow... technically we told paul "end of the week" :-) |
| 22:20:17 | <djazayeri> bwolfe: can you send me the text of your email? |
| 22:20:36 | <bwolfe> already sent |
| 22:20:58 | <wyclif> so has updated the repo before? |
| 22:21:04 | *** pascal` has joined #openmrs |
| 22:21:54 | <bwolfe> only saptarshi and matt blanchette that I know of |
| 22:22:53 | <djazayeri> I successfully created a .m2/settings.xml and put my username and password there |
| 22:23:00 | <djazayeri> now I'm trying to deploy to nexus |
| 22:23:48 | <djazayeri> it's running tests now |
| 22:24:52 | *** bwolfe_ has joined #openmrs |
| 22:24:52 | *** ChanServ sets mode: +o bwolfe_ |
| 22:26:54 | *** bwolfe has quit IRC |
| 22:27:20 | <djazayeri> hmm, heap space error, gotta figure out how to increase memory... |
| 22:29:26 | <downeym> The artifact 'org.openmrs.web:openmrs-web:1.8.1' in repository 'Releases' was deployed.Action was initiated by user "darius". |
| 22:29:56 | <djazayeri> can you tell if the 1.8.1 war is there? |
| 22:30:02 | <djazayeri> that's the step that hit heap space |
| 22:31:57 | <wyclif> so thet deploy command doesnt use flags for authentication |
| 22:32:14 | <downeym> there is no org.openmrs.web.openmrs-webapp.1.8.1 if that's what you mean |
| 22:32:20 | <djazayeri> It does use authentication, I had to put my user/pass in .m2/settings.xml |
| 22:33:24 | <djazayeri> hmm, trying again but it seems to have stopped at 38468 KB |
| 22:34:44 | <djazayeri> stopped and tried again, and once again it's stopped at 38468 KB of the upload |
| 22:35:02 | <djazayeri> in any case, it looks like I got the api jars up there, so we should be able to point the WS module there now. |
| 22:36:50 | <djazayeri> wyclif: it all ran for me (i.e. all tests passed in the WS module, when doing an mvn install on the root project) |
| 22:41:06 | <djazayeri> bwolfe_, wyclif: we're set to release now, right? no more checkins required? |
| 22:42:07 | <wyclif> i have checked in my changes |
| 22:42:47 | <wyclif> the links set on representations miss the version in them |
| 22:43:02 | <djazayeri> ah, so we're not ready to release yet. |
| 22:45:55 | <wyclif> not yet |
| 22:48:01 | <djazayeri> when I ran the tests in eclipse they do break, like you're saying |
| 22:48:15 | <djazayeri> though they pass as part of the mvn package |
| 22:49:12 | <djazayeri> annoying |
| 22:50:06 | <djazayeri> wyclif: you have a one-line fix for the version in links? |
| 22:50:43 | *** downeym has quit IRC |
| 22:51:31 | <wyclif> am already done with it |
| 22:51:38 | <djazayeri> you checked it in? |
| 22:52:22 | <wyclif> i have changed the also the v1 to a RestConstants.URL_PREFIX |
| 22:52:41 | <djazayeri> have you checked it in? |
| 22:55:05 | <djazayeri> wyclif: ^^? |
| 22:57:48 | *** deadpool has joined #openmrs |
| 22:58:22 | <wyclif> hhi |
| 23:02:27 | <deadpool> djazayeri: i have a question for you. Before in i think 1.8 if i made a mistake in the xml file it would show up in openmrs but now it kills it in 1.9 is there a fix for that or is that just the way things are now? |
| 23:03:01 | <djazayeri> deadpool: mistakes in certain xml files have always killed openmrs, I think. |
| 23:03:05 | <djazayeri> not sure about others |
| 23:03:37 | <deadpool> really hmm never knew that |
| 23:03:42 | <djazayeri> It's not intentional on our part. I think sometimes crashing is unavoidable. But other times it may be that we haven't tested yet. |
| 23:03:47 | <djazayeri> depends on the xml file, I think. |
| 23:05:26 | <djazayeri> wyclif: have you checked it in? |
| 23:08:35 | <wyclif> my computer is nearly freezing |
| 23:08:52 | <wyclif> its giving me a hard time but i shd in the next 2min |
| 23:09:04 | <djazayeri> ok |
| 23:09:49 | <deadpool> djazayeri: uhhh now that i restarted it i am getting a OpenMRS is not able to start because of the modules not being able to start some null pointer exception i never had this problem before |
| 23:10:33 | <djazayeri> on a teaching note, you should really be catching xml errors in a unit test, not by uploading to the webapp. :-) |
| 23:11:15 | <djazayeri> Perhaps you can figure out which module is the bad one (from the logs, or starting with the one you edited) and delete from the .OpenMRS/modules folder then restart |
| 23:11:30 | <deadpool> ah never learned about unit testing |
| 23:12:27 | <djazayeri> I would say that in 100% of circumstances where you're doing something in the API, xml, hibernate, etc, writing unit tests will save you time. |
| 23:12:35 | <deadpool> there are no modules located in .OpenMRS/modules |
| 23:12:53 | <djazayeri> odd. |
| 23:12:57 | <djazayeri> what's your error? |
| 23:14:47 | <deadpool> so in the console i see the xml error for the module and then jetty starts and then when i try to go to the webpage i get this http://pastebin.com/begXdryW |
| 23:15:01 | <wyclif> done |
| 23:15:16 | <djazayeri> if you see an xml error for the module, obviously the module is being loaded |
| 23:15:36 | <djazayeri> maybe openmrs isn't looking in the .OpenMRS/modules folder, but elsewhere. |
| 23:15:47 | <djazayeri> watch as jetty starts up to see where the runtime props it uses live. |
| 23:15:51 | <djazayeri> the modules folder is next to there |
| 23:15:58 | <djazayeri> delete your module's omod from there, and restart |
| 23:19:57 | <deadpool> djazayeri: it says that it can't find the openmrs runtime properties is that normal? |
| 23:20:17 | <deadpool> this is my output and after that i get the errors http://pastebin.com/fKNUJFaj |
| 23:20:20 | <djazayeri> it should say that a few times, because it looks in various locations |
| 23:20:43 | <djazayeri> it should find them somewhere, after printing a few "can't find" messages |
| 23:20:58 | <djazayeri> wyclif: cool, thanks, hold on I'll release/tag the module |
| 23:21:26 | <wyclif> have you run the tests again |
| 23:21:33 | <deadpool> djazayeri: ah cool yeah i found it |
| 23:21:38 | <wyclif> i failed to run them on my machine |
| 23:21:42 | <djazayeri> wyclif: trying now |
| 23:21:49 | <wyclif> i know when tagging they will get run |
| 23:24:34 | <wyclif> i will probably need to create two 1.8.1 zips with ws module |
| 23:24:47 | <wyclif> one with demo data and the other with no data] |
| 23:25:08 | <djazayeri> wyclif: no |
| 23:25:15 | <djazayeri> just one with demo data |
| 23:25:23 | <djazayeri> it's purely for test purposes of the ws module |
| 23:26:11 | <wyclif> ok |
| 23:27:08 | *** wyclif has quit IRC |
| 23:35:18 | *** wyclif has joined #openmrs |
| 23:35:47 | *** wyclif has quit IRC |
| 23:35:47 | <djazayeri> okay, module is here: https://modules.openmrs.org/modules/view.jsp?module=webservices.rest |
| 23:35:54 | <OpenMRSBot> <http://ln-s.net/8zpU> (at modules.openmrs.org) |
| 23:35:55 | *** wyclif has joined #openmrs |
| 23:36:10 | <djazayeri> wyclif: can you download that and add it to the standalone? |
| 23:36:23 | <djazayeri> while you're at it, do a quick test to make sure it works. :-) |
| 23:36:31 | *** gbastien has quit IRC |
| 23:39:46 | *** pascal` has quit IRC |
| 23:40:06 | <wyclif> ok |
| 23:49:17 | <wyclif> am testing it |
| 23:58:15 | <wyclif> works fine |
| 23:58:21 | <djazayeri> excellent |
| 23:59:10 | <wyclif> am uploading |