| 00:52:41 | *** yanokwa has quit IRC |
| 01:22:18 | *** djazayeri has joined #openmrs |
| 01:22:18 | *** ChanServ sets mode: +o djazayeri |
| 02:09:47 | *** jwishnie has joined #openmrs |
| 02:11:14 | *** gbastien has joined #openmrs |
| 02:18:38 | *** gbastien has quit IRC |
| 02:21:15 | *** jwishnie has quit IRC |
| 03:02:58 | *** gbastien has joined #openmrs |
| 03:21:39 | *** mandric has joined #openmrs |
| 03:40:00 | *** mandric has quit IRC |
| 03:41:54 | *** gbastien has quit IRC |
| 03:53:56 | *** mandric has joined #openmrs |
| 04:01:38 | *** surangak has joined #openmrs |
| 04:36:45 | <surangak> !surangak |
| 04:36:45 | <OpenMRSBot> surangak: Error: "surangak" is not a valid command. |
| 04:45:28 | *** goutham has joined #openmrs |
| 05:02:58 | *** goutham has quit IRC |
| 05:18:44 | *** vchircu has quit IRC |
| 05:35:25 | *** surangak has quit IRC |
| 05:36:25 | *** surangak has joined #openmrs |
| 05:53:40 | *** upul` has joined #openmrs |
| 05:53:40 | *** ChanServ sets mode: +v upul` |
| 05:54:04 | *** pascal` has quit IRC |
| 06:09:04 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Committing LocationHandler class. It integrates with exiting code base with no errors. <http://feedproxy.google.com/~r/OMRStrunk/~3/5QtsNeAQR6s/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Converting PatientHandler 'displayLink' value to a constant <http://feedproxy.google.com/~r/OMRStrunk/~3/wE2ZNAV5FUQ/OpenMRS> |
| 06:11:37 | <surangak> well bot, you are kinda slow today, arnt you ? |
| 06:12:58 | *** mandric has quit IRC |
| 06:24:08 | *** bwolfe has joined #openmrs |
| 06:24:08 | *** ChanServ sets mode: +o bwolfe |
| 06:26:41 | <bwolfe> upul`, sent you a "memo" in return to yours from 12 days ago. :-) |
| 06:31:46 | *** dkayiwa has joined #openmrs |
| 06:32:38 | <surangak> howdy ppl.... |
| 06:32:42 | <surangak> im wondering, how do I create a mock uuid to include in test xmls used by unite tests |
| 06:34:13 | <surangak> assuming i do something like <person person_id="2" gender="M" dead="false" creator="1" date_created="2011-07-11 00:00:00.0" voided="false" uuid="b9cb4fb6-6ce3-4475-b08d-6e1a7d4345ce"/> in a unit test... |
| 06:34:24 | <surangak> should the uuid be 'make belive'... |
| 06:54:32 | <bwolfe> surangak, just make up some numbers |
| 06:54:43 | <bwolfe> I typically take another uuid from a file and modify 5 or 6 of the digets |
| 06:54:46 | <bwolfe> *digits |
| 06:54:55 | <bwolfe> or you can open mysql and type "select uuid()" |
| 06:55:06 | <surangak> bwolfe, aha.. thats what i've been doing so far :P |
| 06:55:12 | <bwolfe> or you can take one from your database that has them generated for a new row |
| 06:55:19 | <surangak> bwolfe, thanks, will do... |
| 06:56:09 | *** bwolfe sets mode: +v dkayiwa |
| 06:56:12 | *** bwolfe sets mode: +v wyclif |
| 06:56:18 | *** rafa has joined #openmrs |
| 06:56:18 | *** ChanServ sets mode: +v rafa |
| 06:56:18 | *** bwolfe sets mode: +v surangak |
| 06:56:25 | <bwolfe> good morning rafa |
| 06:57:39 | <rafa> good morning bwolfe |
| 06:59:07 | <bwolfe> dkayiwa, welcome. your car all fixed now? |
| 06:59:20 | <dkayiwa> bwolfe: yes :) |
| 06:59:54 | <dkayiwa> bwolfe: did you sell yours? |
| 07:00:07 | <bwolfe> I'm selling my car? |
| 07:00:38 | <dkayiwa> the one you wanted to sell before you came to kenya. did you get a buyer bwolfe? |
| 07:01:15 | <bwolfe> yeah, sold it about 3 weeks after we got here |
| 07:01:21 | <dkayiwa> oh i see |
| 07:01:26 | <bwolfe> my wife's parents did the transaction for me |
| 07:01:37 | <dkayiwa> oh thats so nice |
| 07:01:48 | <dkayiwa> hoping you got what it was worth |
| 07:01:50 | <dkayiwa> :) |
| 07:03:27 | <bwolfe> yeah, I had 3 people all wanting to see it at the same time. so I used that to get exactly what I was asking for it. :-) |
| 07:03:37 | <dkayiwa> hahahahaha |
| 07:03:46 | <dkayiwa> that was very good for you. :) |
| 07:03:57 | <bwolfe> I had priced it about 1k lower than it was truly worth so there was a lot of interest |
| 07:04:08 | <dkayiwa> lolllllllllll |
| 07:05:01 | <dkayiwa> bwolfe: do you have comments for: https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources |
| 07:05:09 | <OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org) |
| 07:05:17 | <dkayiwa> bwolfe: as in the way it is now? |
| 07:05:55 | <bwolfe> have you updated it? |
| 07:06:17 | <bwolfe> ah yes, you have |
| 07:06:43 | <dkayiwa> yes |
| 07:06:56 | <bwolfe> dkayiwa, use h3s instead of h2s for "url" and "representations" so that you don't have that extra underline in there |
| 07:07:09 | <dkayiwa> ok |
| 07:07:14 | <dkayiwa> thanks for the tip |
| 07:08:14 | <bwolfe> and what is "Available HTTP Verbs" halfway down the page? is that from an annotation? |
| 07:08:39 | <bwolfe> it also screws up your markup: all things after that point are tabbed over. perhaps not closing an "li" or a "ul" tag? |
| 07:09:45 | <dkayiwa> yes its from the javadoc tags |
| 07:09:56 | <bwolfe> and whats with hl7source? |
| 07:10:36 | <bwolfe> drop the server:port/context part of the url, the user shoudl be able to figure that part out |
| 07:11:02 | <dkayiwa> hl7source has no controller |
| 07:11:10 | <dkayiwa> ok |
| 07:11:44 | <bwolfe> ok, then don't include its url. but its ref/default/full properties are weird too |
| 07:11:58 | <bwolfe> and change it so that its always in order: ref then default then full |
| 07:12:45 | <dkayiwa> ok |
| 07:13:04 | <bwolfe> so there are 5 changes for you. make those and let me know when its done |
| 07:13:13 | <dkayiwa> ok |
| 07:14:05 | <bwolfe> and then we need to figure out how to discover the urls. perhaps it would be time to look into one of those jars that saptarshi was referring to. they did discovery and display of the urls, just wouldn't get the representations |
| 07:14:13 | <bwolfe> your stuff can get the representations but not the urls. :-) |
| 07:14:30 | <dkayiwa> ok :) |
| 07:15:58 | <bwolfe> dkayiwa, we need to cycle on this quickly though. because I don't want to release with docs |
| 07:16:10 | <bwolfe> and I need you to do a package of 1.8.1 with ws before midweek probably |
| 07:16:17 | <bwolfe> rafa, how goes mds? |
| 07:16:20 | <dkayiwa> did you mean without docs? |
| 07:16:24 | <dkayiwa> bwolfe |
| 07:16:39 | <bwolfe> dkayiwa, ha, yes, *without* docs |
| 07:16:46 | <dkayiwa> ok :D |
| 07:17:47 | <rafa> bwolfe: Please assign me some ws ticket :) |
| 07:18:04 | <bwolfe> rafa, so you're ready? |
| 07:18:13 | <bwolfe> did you do any ws stuff before? should I start you off slowly? :-) |
| 07:18:24 | <rafa> bwolfe: yes, I'm ready. |
| 07:18:37 | <rafa> bwolfe: yes, I did. |
| 07:18:53 | * bwolfe looks for an open ticket |
| 07:19:01 | <rafa> bwolfe: filtering ips if i remember right |
| 07:19:06 | * bwolfe sees one: package/release 1.8.1 :-D |
| 07:19:10 | <bwolfe> ah yes, ok |
| 07:19:39 | <bwolfe> has wyclif done any of this one: https://tickets.openmrs.org/browse/RESTWS-153 ? |
| 07:19:44 | <bwolfe> I haven't heard... |
| 07:20:16 | <bwolfe> but we do need to verify that each rep works for each object. saptarshi found one that didn't in concept which crashed his client |
| 07:20:41 | <bwolfe> I think wyclif has moved onto look at core 1.8.1 changes that might be necessary |
| 07:20:57 | <bwolfe> so I'll reassign you to that one. sorry that it isn't more glamorous rafa! |
| 07:20:59 | <rafa> bwolfe: Do you suggest stealing it from him? :D |
| 07:22:04 | <bwolfe> rafa, I just stole it from him and gave it to you |
| 07:22:40 | <rafa> bwolfe: ok, thanks! |
| 07:23:10 | <rafa> bwolfe: I need to go to a bank first. I'll be back in two hours and start coding :D |
| 07:23:13 | <bwolfe> rafa, start at the "bottom" and work up just in case wyclif tells you in 7 hours (when he wakes up) that he has some code for you |
| 07:23:25 | <bwolfe> it takes 2 hours to go to the bank rafa?! |
| 07:23:45 | <rafa> bwolfe: Yes, I need to open an account :) |
| 07:24:23 | <rafa> bwolfe: for my OpenMRS business ;) |
| 07:25:01 | <bwolfe> rafa, ahaha |
| 07:25:10 | <bwolfe> very nice. this is so we can pay you as a consultant? |
| 07:25:19 | <bwolfe> what are you naming your business? |
| 07:25:26 | <rafa> yeah :D |
| 07:26:34 | <rafa> I needed to make it simple Rafal Korytkowski :( |
| 07:27:06 | <rafa> so it's just my name |
| 07:28:51 | <bwolfe> boo |
| 07:28:57 | <bwolfe> double boo |
| 07:29:14 | <bwolfe> poland, right? |
| 07:29:21 | <bwolfe> how about popenmrs ? |
| 07:29:31 | <bwolfe> polapenmrs? |
| 07:29:36 | <rafa> right |
| 07:29:40 | <bwolfe> polapenmrs consulting |
| 07:29:52 | <bwolfe> PO Consulting |
| 07:29:58 | *** danielf` has joined #openmrs |
| 07:29:58 | *** ChanServ sets mode: +v danielf` |
| 07:30:17 | <bwolfe> or think big: Eastern European OpenMRS Consulting Agency. EEOCA FTW |
| 07:30:35 | <rafa> bwolfe: haha :D |
| 07:30:49 | <rafa> bwolfe: I would have to write it down on every document I sing :D |
| 07:30:54 | <bwolfe> or get a cool acronum. Free The Workers Consulting Agency |
| 07:30:57 | <bwolfe> FTW Consulting |
| 07:31:16 | <rafa> bwolfe: they said that it needs to contain my name anyway so it would be too long |
| 07:31:26 | <bwolfe> rats |
| 07:31:54 | <bwolfe> who said it needs your name? |
| 07:32:02 | <bwolfe> Poland or the openmrs folks? |
| 07:32:23 | <rafa> bwolfe: officials in Poland :/ |
| 07:32:38 | <rafa> bwolfe: some law regulations |
| 07:33:14 | <rafa> bwolfe: it sucks, but anyway I need to go now |
| 07:33:21 | <rafa> see you soon guys! |
| 07:34:25 | *** rafa has quit IRC |
| 07:38:51 | *** pascal` has joined #openmrs |
| 07:46:54 | *** bryq has joined #openmrs |
| 07:46:54 | *** ChanServ sets mode: +v bryq |
| 08:08:19 | *** gauravpaliwal has joined #openmrs |
| 08:08:19 | *** ChanServ sets mode: +v gauravpaliwal |
| 08:23:22 | <upul`> bwolfe: fastest way to send important messages :-) |
| 08:23:46 | <bwolfe> upul`, 12 days is fast? :-) |
| 08:24:41 | <upul`> bwolfe: you don't appreciate what you have. those days it took months to send messages |
| 08:24:57 | <bwolfe> haha |
| 08:54:12 | *** bwolfe has quit IRC |
| 09:01:38 | *** muthah has joined #openmrs |
| 09:40:24 | *** muthah has quit IRC |
| 09:40:24 | *** pascal` has quit IRC |
| 09:40:24 | *** gauravpaliwal has quit IRC |
| 09:40:24 | *** wyclif has quit IRC |
| 09:42:32 | *** suho has joined #openmrs |
| 09:42:32 | *** ChanServ sets mode: +v suho |
| 09:45:38 | *** muthah has joined #openmrs |
| 09:47:08 | *** pascal` has joined #openmrs |
| 09:48:01 | *** wyclif has joined #openmrs |
| 09:48:07 | *** gauravpaliwal has joined #openmrs |
| 09:48:07 | *** ChanServ sets mode: +v gauravpaliwal |
| 09:48:18 | *** gauravpaliwal has left #openmrs |
| 10:02:38 | *** rafa has joined #openmrs |
| 10:02:38 | *** ChanServ sets mode: +v rafa |
| 10:30:01 | *** bwolfe has joined #openmrs |
| 10:30:01 | *** ChanServ sets mode: +o bwolfe |
| 10:31:09 | *** bwolfe_ has joined #openmrs |
| 10:31:09 | *** ChanServ sets mode: +o bwolfe_ |
| 10:35:00 | *** bwolfe has quit IRC |
| 10:36:19 | *** bwolfe_ is now known as bwolfe |
| 10:36:58 | <bwolfe> dkayiwa, the resources page looks better. (https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources) |
| 10:36:59 | <OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org) |
| 10:37:26 | <bwolfe> you're hiding hl7source altogether? I suppose thats right since there is no controller and so no way to fetch it... |
| 10:37:41 | <dkayiwa> bwolfe: yes am just hinding it |
| 10:37:43 | <bwolfe> dkayiwa, now you just need to figure out how to get the urls. :-) |
| 10:37:55 | <dkayiwa> yes thats what am on now. :) |
| 10:38:12 | <bwolfe> cool. using or looking at the other libraries, or just going it alone? |
| 10:39:23 | <rafa> bwolfe: do you mind if I create a generic tests in BaseDelegatingResourceTest for RESTWS-153 that will test all declared resources? |
| 10:39:28 | <dkayiwa> bwolfe: looking at the other libraries (one of the in groovy. :)) |
| 10:39:59 | <bwolfe> rafa, I tried to convince darius of that (might be in the tickets there), but he wants it in each one |
| 10:40:00 | <rafa> bwolfe: rather than separate test class for each resource? |
| 10:40:24 | <rafa> bwolfe: hmm :/ |
| 10:41:42 | <rafa> bwolfe: where shall I put @should then? |
| 10:42:04 | <rafa> bwolfe: the asRepresentation method is inherited |
| 10:43:14 | <bwolfe> you don't need @shoulds for them. just follow the method naming pattern |
| 10:43:37 | <rafa> bwolfe: Okay, thanks |
| 10:46:46 | *** surangak has quit IRC |
| 10:47:45 | *** surangak has joined #openmrs |
| 10:54:56 | *** suho has quit IRC |
| 10:55:55 | <rafa> bwolfe: how about this pattern: http://pastebin.com/f5FtLy9s? |
| 10:56:20 | <rafa> bwolfe: I'll create separate test classes for each resource :) |
| 10:56:28 | <rafa> bwolfe: so Darius should be fine with it ;) |
| 10:58:37 | <rafa> bwolfe: I understand that now I only need to get a representation, create an object, call asRepresentation and compare |
| 11:00:25 | <bwolfe> rafa, I can't follow that patch easily |
| 11:00:30 | <bwolfe> can you send me the file? |
| 11:01:18 | <rafa> bwolfe: Can you see the file transfer in IRC? |
| 11:01:35 | <bwolfe> yeah, but nothing is happening... |
| 11:01:50 | <bwolfe> it just opened an empty file transfer box |
| 11:01:55 | <bwolfe> email it to me |
| 11:02:04 | <rafa> I see waiting for acceptance, well okay I'll e-mail |
| 11:02:16 | <bwolfe> hmm, I did accept... |
| 11:02:55 | <rafa> sent |
| 11:03:34 | <rafa> bwolfe: I could have attached it to the ticket ;) |
| 11:03:38 | <bwolfe> received |
| 11:04:48 | <bwolfe> rafa, not sure that will work. you have to use that representation to get an object and its data |
| 11:06:07 | <rafa> bwolfe: I just need to call asRepresentation for an object and validate against the representation |
| 11:07:09 | <bwolfe> yeah |
| 11:07:11 | <rafa> bwolfe: I'll set the object in UserResourceTest |
| 11:07:23 | <bwolfe> if by "validate" you mean make sure it doesn't fail, then yes |
| 11:07:27 | <bwolfe> you don't have to compare each field |
| 11:07:29 | <rafa> bwolfe: but test the thing in BaseDelegatingResourceTest |
| 11:07:51 | <rafa> bwolfe: Don't I? |
| 11:08:35 | <rafa> bwolfe: I mean I would test if fields are there |
| 11:08:49 | <rafa> bwolfe: Do I need to make sure that they've got a right value? |
| 11:09:16 | <bwolfe> no, this is more of a "make sure it doesn't fail" test. |
| 11:09:40 | <rafa> bwolfe: then it should work nice I think |
| 11:09:45 | <bwolfe> the tests should be in UserResourceTest, PatientResourceTest, etc |
| 11:10:11 | <rafa> bwolfe: technically they'll be there :) |
| 11:10:36 | <bwolfe> ha. but its not testing against a user in the db, a patient in the db, etc |
| 11:10:49 | <rafa> bwolfe: Yes, it'll be. |
| 11:10:54 | <bwolfe> the framework hsa to call those methods/properties on actual objects |
| 11:11:01 | <bwolfe> ok, send me what you're thinking then |
| 11:11:02 | <rafa> bwolfe: I'll set the object to test in UserResourceTest |
| 11:11:13 | <rafa> bwolfe: Good |
| 11:11:47 | <bwolfe> ok. I think I see what you mean |
| 11:21:14 | <rafa> bwolfe: see now https://tickets.openmrs.org/browse/RESTWS-153 |
| 11:21:57 | <rafa> bwolfe: additionally, I could test if all properties in the returned objects are valid |
| 11:22:19 | <rafa> bwolfe: Simply comparing it to a description. |
| 11:22:49 | *** upul` has left #openmrs |
| 11:23:18 | <bwolfe> rafa, just to make sure each one is included? that'd be fine I guess. you just have to make sure each object has everything (no conditionals) |
| 11:23:31 | <bwolfe> can't you automatically find the resource to use? |
| 11:23:43 | <bwolfe> the same way the controller parent class does it? |
| 11:23:58 | <rafa> bwolfe: I don't know what do you mean by automatically? |
| 11:24:20 | <bwolfe> meaning the dev doesn't have to fill in a getResource method |
| 11:24:25 | <bwolfe> (if they don't want to) |
| 11:24:46 | <bwolfe> see BaseCrudController.getResource |
| 11:24:56 | <rafa> bwolfe: I guess I could, but this way we say explicitly what we test |
| 11:25:09 | <bwolfe> you could probably just copy/paste that method ;-) |
| 11:25:30 | <bwolfe> leave it as a method and the test author can override it if they really ened ot |
| 11:25:52 | <rafa> bwolfe: ok |
| 11:25:53 | <bwolfe> because the 98% use-case is that it will be the same thing as the generic param on the class |
| 11:26:12 | <rafa> bwolfe: do you remember where was that method? |
| 11:26:23 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Improving unit tests of ObsServiceTest <http://feedproxy.google.com/~r/OMRStrunk/~3/Q5R48HKvdEU/OpenMRS> |
| 11:26:27 | <rafa> bwolfe: ohh sorry, you've mentioned it |
| 11:36:30 | <rafa> bwolfe: my generic param is UserAndPassword not UserResource, I don't think I can use that method |
| 11:37:12 | <rafa> bwolfe: I'll leave it as it is. It's just three lines of code ;) |
| 11:38:05 | <bwolfe> 3 lines too many... |
| 11:38:06 | <bwolfe> :-p |
| 11:38:45 | <rafa> bwolfe: btw full representation for UserAndPassword fails ;) |
| 11:39:47 | <bwolfe> ha |
| 11:39:54 | <bwolfe> see, there you go. a reason for the tests ;-) |
| 11:39:57 | *** james_regen has joined #openmrs |
| 11:39:57 | *** ChanServ sets mode: +v james_regen |
| 11:40:03 | <rafa> indeed :) |
| 11:40:07 | <bwolfe> whats the error? can you see the fix easily? |
| 11:40:42 | <rafa> bwolfe: it seems that the real reason is eaten, I'll have to debug |
| 11:41:10 | <bwolfe> hmm |
| 11:41:11 | <bwolfe> ok |
| 11:41:46 | <rafa> bwolfe: oh no I got it Caused by: org.openmrs.api.APIException: Service not found: interface org.openmrs.module.webservices.rest.web.api.RestService |
| 11:41:51 | <rafa> strange |
| 11:43:16 | <rafa> bwolfe: maybe it's because I run it in eclipse |
| 11:43:24 | <rafa> I'll test with mvn |
| 11:47:06 | <rafa> bwolfe: yes, it's fine with mvn |
| 11:47:42 | <bwolfe> strange |
| 11:47:47 | <bwolfe> perhaps you need a clean compile in maven? |
| 11:47:49 | <bwolfe> or a full install? |
| 11:48:26 | <rafa> bwolfe: ok, I see where is my fault. |
| 11:48:38 | <rafa> bwolfe: I did new UserResource() instead of Context.get... |
| 11:48:41 | <rafa> ;) |
| 11:48:44 | <bwolfe> for shame |
| 11:48:59 | <rafa> bwolfe: now it's strange that mvn is ok with it ;) |
| 11:50:23 | <bwolfe> yeah, wonder why |
| 11:50:52 | <rafa> bwolfe: no worries, I'll play with it ;) |
| 11:56:16 | <rafa> bwolfe: okay, got it. Any idea why junit in eclipse does not return Context.getService(RestService.class)? |
| 11:56:33 | <rafa> bwolfe: what happend to moduleApplicationContext.xml? |
| 11:56:43 | <rafa> I can't find that guy. |
| 11:57:05 | <bwolfe> its all in webModuleApplicationContext.xml |
| 11:57:06 | <rafa> bwolfe: I guess I need it on the classpath. |
| 11:57:29 | <bwolfe> I wonder if both are not on there for the unit testing... |
| 12:01:47 | <rafa> bwolfe: yes, it's there... okay I'll stick with mvn |
| 12:02:04 | <rafa> bwolfe: I see that other tests are failing in my eclipse as well |
| 12:02:19 | <rafa> bwolfe: it must be something wrong with my config |
| 12:15:08 | *** downeym has joined #openmrs |
| 12:15:08 | *** OpenMRSBot sets mode: +o downeym |
| 12:15:08 | *** ChanServ sets mode: +o downeym |
| 12:17:15 | <bwolfe> rafa, hmm, my unit tests fail in eclipse and pass at command line too... |
| 12:17:16 | <bwolfe> :-/ |
| 12:17:42 | <rafa> bwolfe: okay, then we need to investigate it. |
| 12:17:54 | <rafa> bwolfe: I can look into this when I finish with the ticket. |
| 12:19:53 | <bwolfe> ok |
| 12:24:42 | *** wyclif has quit IRC |
| 12:45:50 | *** bwolfe has quit IRC |
| 12:50:46 | *** ChanServ sets mode: +v pascal` |
| 13:20:33 | *** downeym_ has joined #openmrs |
| 13:20:33 | *** ChanServ sets mode: +o downeym_ |
| 13:22:19 | *** wyclif has joined #openmrs |
| 13:23:06 | *** downeym has quit IRC |
| 13:23:06 | *** downeym_ is now known as downeym |
| 13:32:00 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @gauravpaliwal: #OpenMRS FDBK svn to GitHub http://t.co/okyPWpJ #GSoC <http://twitter.com/OpenMRS/statuses/90399461351751680> || On Twitter: OpenMRS: @EricWaltR Merci! <http://twitter.com/OpenMRS/statuses/90399242383917056> |
| 13:48:40 | *** bwolfe has joined #openmrs |
| 13:48:40 | *** ChanServ sets mode: +o bwolfe |
| 13:48:58 | *** surangak has quit IRC |
| 13:49:37 | *** asgoyal has joined #openmrs |
| 13:57:00 | <dkayiwa> hi bwolfe |
| 13:57:24 | <bwolfe> hi dkayiwa |
| 13:57:44 | <dkayiwa> bwolfe: does the '!' character mean anything on the purge parameter? @RequestMapping(value = "/{uuid}", method = RequestMethod.DELETE, params = "!purge") |
| 13:58:32 | <rafa> !ticket RESTWS-153 |
| 13:58:32 | <OpenMRSBot> rafa: Allow me to help you with that. More details on ticket RESTWS-153 can be found at http://tickets.openmrs.org/browse/RESTWS-153 |
| 13:58:36 | <bwolfe> means if its not there |
| 13:58:37 | <dkayiwa> bwolfe: or is it a slip of the keyboard? |
| 13:58:43 | <dkayiwa> oh |
| 13:58:46 | <bwolfe> just like != |
| 13:58:48 | <rafa> bwolfe: (see the comment) |
| 13:59:21 | <dkayiwa> bwolfe: means if its not there, then??? |
| 14:00:28 | <pascal`> bwolfe, the four initial encounter types, why are those not considered "demo data" (and are hence added to a clean install)? |
| 14:01:05 | <bwolfe> rafa, recommented for you |
| 14:01:24 | <bwolfe> pascal`, not sure. |
| 14:01:28 | <bwolfe> open a ticket to get them in there |
| 14:01:32 | <wyclif> hello |
| 14:01:34 | <bwolfe> dkayiwa, yes |
| 14:01:39 | <rafa> bwolfe: thanks |
| 14:01:43 | <bwolfe> hi wyclif. djazayeri, you awake yet? |
| 14:01:53 | <pascal`> bwolfe, kk |
| 14:02:43 | <bwolfe> guess thats a no on darius |
| 14:03:57 | <bwolfe> ok, lets start without him. serves him right for hitting snooze. ;_) |
| 14:03:58 | <bwolfe> ;-=) |
| 14:04:00 | <bwolfe> ;-) |
| 14:04:02 | <djazayeri> hi |
| 14:04:05 | <djazayeri> happy week |
| 14:04:08 | <bwolfe> sheesh, winking faces are tough. |
| 14:04:12 | <bwolfe> hiya darius |
| 14:04:42 | <djazayeri> pascal`: core data is only *required* date |
| 14:04:42 | <bwolfe> ok, dkayiwa, you go first |
| 14:04:44 | <djazayeri> data |
| 14:04:52 | <bwolfe> djazayeri, he asked about demo though |
| 14:05:04 | <djazayeri> oh, yeah, fine |
| 14:05:17 | <pascal`> djazayeri, bwolfe, I did a clean install, asked for no demo data, but still got the 4 default encounter types |
| 14:05:19 | <bwolfe> (that was my first thought too, then reread it) |
| 14:05:37 | <bwolfe> pascal`, ah, ok, yeah, those should be moved |
| 14:06:44 | <bwolfe> did we lose dkayiwa, or is he typing... no one knows... |
| 14:06:52 | <dkayiwa> worked on the review comments from Ben for REST-148 (web service automatic documentattion). Now working on including the various urls for each resource operation. I have so far been able to iterate over the resource controller and got the urls. But as for the description, i have done some automation but it may need customizations in some cases. DONE |
| 14:06:58 | <bwolfe> ah, there we go. :-) |
| 14:07:24 | <bwolfe> dkayiwa, so you will finish with that soon, or you are done, or you will finish tomorrow? |
| 14:07:33 | *** muthah has quit IRC |
| 14:08:03 | <dkayiwa> bwolfe: will finish in 30 minutes today |
| 14:08:05 | <bwolfe> dkayiwa, it can be a manual process now. or you can do the fake kind of thing that I suggested. perhaps annotations on the controllers with a replaceable string with the object name? |
| 14:08:09 | <bwolfe> dkayiwa, perfect |
| 14:08:20 | <bwolfe> looking forward to seeing it later tonight |
| 14:08:24 | <dkayiwa> sure |
| 14:08:30 | <bwolfe> rafa? |
| 14:08:37 | <pascal`> bwolfe, downeym, when creating a new ticket, if you select (the seemingly valid) "None" option for severity, the ticket won't save. |
| 14:08:56 | <pascal`> bwolfe, djazayeri, TRUNK-2446 |
| 14:09:01 | <pascal`> !ticket TRUNK-2446 |
| 14:09:01 | <OpenMRSBot> pascal`: Allow me to help you with that. More details on ticket TRUNK-2446 can be found at http://tickets.openmrs.org/browse/TRUNK-2446 |
| 14:09:07 | <bwolfe> oh wait. dkayiwa, plans for tomorrow? there are a few outstanding tickets in your name. finish those. |
| 14:09:20 | <dkayiwa> ok |
| 14:09:32 | <rafa> Today: I tried to fix !ticket META-93, but I can't reproduce it and it's hard to guess. I'm working on !ticket RESTWS-153 and it's almost ready. Later today/tomorrow: will look into why junits fail in the rest module, release a slighlty fixed META and announce it on devs list. No blockers. |
| 14:09:32 | <bwolfe> and then will need to get you to package up 1.8.x as a standalone with the module included...is that a quick process now? or will we be delayed 2 weeks again? :-( |
| 14:09:39 | <downeym> pascal`: that was creating a trunk ticket? |
| 14:09:46 | <pascal`> downeym, yeah |
| 14:10:29 | <dkayiwa> bwolfe: all it takes is get one of the existing standalones and drop the war file in the appropriate folder, then zip. |
| 14:10:55 | <downeym> pascal`: Unfortunately Atlassian includes "None" as null. And for TRUNK, severity is a required field |
| 14:10:56 | <bwolfe> dkayiwa, ah yes, because there are no db changes? (are there db changes?) |
| 14:11:01 | <downeym> pascal`: bad ui design :) |
| 14:11:15 | <dkayiwa> the standalone needs no recompilation because it has no changes |
| 14:11:18 | <rafa> djazayeri: do you think you can help me with META-93 by sending your database dump so I can reproduce it? |
| 14:11:24 | <djazayeri> downeym: for what it's worth, severity shouldn't be required |
| 14:11:29 | <pascal`> downeym, kk, just thought I'd let you know. |
| 14:11:34 | <downeym> djazayeri: talk to bwolfe about that decision :) |
| 14:11:41 | <dkayiwa> bwolfe: if there are db changes, then we need to run the setup wizard on the bundled database |
| 14:11:48 | <downeym> pascal`: /me adds it to the atlassian annoyance list :) |
| 14:11:49 | <djazayeri> rafa: yes |
| 14:11:53 | <bwolfe> downeym, I decided severity is required?! |
| 14:12:03 | <djazayeri> severity is the user-specified one, right? |
| 14:12:06 | <djazayeri> 1, 2, 3, 4? |
| 14:12:08 | <pascal`> imo, you shouldn't have invalid options in a dropdown. |
| 14:12:24 | <pascal`> djazayeri, yeah |
| 14:12:36 | <bwolfe> severity should be words anyway. that was my only vote on it iirc |
| 14:12:48 | <djazayeri> It should be words, and it shouldn't be required. |
| 14:12:53 | <downeym> severity 1-n is a universal concept in the IT world. :) |
| 14:12:56 | <bwolfe> rafa, ok, so you're blocked on one ticket that djazayeri will help with. |
| 14:13:02 | <downeym> i don't mind making it optional |
| 14:13:04 | <djazayeri> not for self-reporting bugs by users |
| 14:13:26 | <rafa> bwolfe: well ok, it's a blocker :) |
| 14:13:35 | <bwolfe> downeym, it might be used by a lot of people, but that doesn't make it right. (see OS choice by the masses) |
| 14:14:34 | <bwolfe> rafa, ok, ping him over email about it. ;-) he's distracted here |
| 14:14:55 | <djazayeri> I said yes |
| 14:15:05 | <bwolfe> rafa, ping me tomorrow when you finish the tickets and we can find something else for you to work on. not sure it will be ws related... |
| 14:15:14 | <bwolfe> oh, sorry, missed that |
| 14:15:22 | <bwolfe> wyclif? |
| 14:15:33 | <rafa> great thanks |
| 14:16:23 | <wyclif> friday: Fixed TRUNK-2424 (for 1.8.1 release), finish upRESTWS-113, Tested 1.8.1 to locate the bug i thought i had run into before, and RESTWS-160(xml support) and created https://tickets.openmrs.org/browse/TRUNK-2445 |
| 14:16:35 | <wyclif> Today: work on ResourceDocCreator to find module resources, i should complete work on returning xml(got it to work besides supporting extensions on the URL) |
| 14:16:41 | <wyclif> no blockers |
| 14:17:14 | <rafa> Oh wyclif, Ben has stolen a ticket from you :) |
| 14:17:23 | <wyclif> which one? |
| 14:17:29 | <dkayiwa> :D |
| 14:17:33 | <rafa> RESTWS-153 |
| 14:18:06 | <bwolfe> wyclif, ok, I commented on a few of your tickets. skip the xml extension stuff. |
| 14:19:07 | <rafa> wyclif: I hope you don't mind I'm working on it ;) |
| 14:19:11 | <bwolfe> wyclif, I commented on a few more TRUNK tickets in 1.8.1 as well. looks like some should be quick wins. |
| 14:19:42 | <bwolfe> getting 1.8.1 ready and ONLY tickets assigned to it that are really going to be in 1.8.1 is high high priority for you beginning of this week |
| 14:20:14 | *** suho has joined #openmrs |
| 14:20:14 | *** ChanServ sets mode: +v suho |
| 14:20:41 | <wyclif> rafa you can work on RESTWS-153 |
| 14:21:03 | <wyclif> James sent me an email about them |
| 14:21:57 | <wyclif> which are the tickets that you are most interested in to get fixed |
| 14:22:03 | <bwolfe> ok, there were a few more just 10 mins ago |
| 14:22:15 | <bwolfe> wyclif, at this point, only include ones that are easy to fix |
| 14:22:20 | <bwolfe> everything else can wait until 1.8.2 |
| 14:22:43 | <wyclif> which is the link the tickets |
| 14:22:44 | <djazayeri> btw, I'm seeing a handful of tickets committed to trunk that were "waiting to be backported to 1.8.1" |
| 14:22:59 | <djazayeri> are we delatying those, to avoid having to re-test? or what? |
| 14:23:08 | <wyclif> or it is just those whose fixVersion is 1.8.1 |
| 14:23:29 | <bwolfe> wyclif, see the 1.8.1 ticket in RESTWS. I put links in there for you |
| 14:23:35 | <djazayeri> e.g. TRUNK-2317, TRUNK-2108 |
| 14:23:49 | <bwolfe> djazayeri, I suggest backporting those. we need to test everything as we do anyway |
| 14:24:11 | <bwolfe> wyclif, yes, fixVersion=1.8.1 tickets |
| 14:25:33 | <wyclif> ok |
| 14:26:52 | <bwolfe> ok, so wyclif you have your marching orders. and they sound to the beat of 1.8.1 |
| 14:27:12 | <bwolfe> djazayeri? |
| 14:27:22 | <djazayeri> Friday: |
| 14:27:22 | <djazayeri> * Code reviews |
| 14:27:22 | <djazayeri> * Went through metadata sharing import (filed UI comments, and bug reports) |
| 14:27:22 | <djazayeri> * Went through 2.x tickets |
| 14:27:22 | <djazayeri> Today: |
| 14:27:23 | <djazayeri> * Help Rafal reproduce META-93 |
| 14:27:23 | <djazayeri> * Release new version of HTML Form Entry (to go with Metadata Sharing 0.9) |
| 14:27:24 | <djazayeri> * 2.x sprint prep |
| 14:27:25 | <djazayeri> No blockers |
| 14:28:32 | <djazayeri> (done) |
| 14:28:58 | <bwolfe> djazayeri, for the 2.x sprint, are there any tests being added? would it benefit from a CI build on the branch during those two weeks? |
| 14:29:15 | <djazayeri> I don't think so, no |
| 14:29:41 | <bwolfe> bummer |
| 14:29:59 | <bwolfe> ok, we need to make use of that during the sprints. could have used one for ws for sure |
| 14:30:03 | <djazayeri> good point that at some point we need to start |
| 14:30:34 | <bwolfe> maybe with the "next sprint" |
| 14:30:40 | <bwolfe> or maybe just "soon" |
| 14:31:36 | <bwolfe> ok, asgoyal / asgoyal_ ? |
| 14:34:42 | <bwolfe> ok, no ankur I guess. myself: did a few ws reviews. cleaned up some more ws documentation. looked at trunk tickets for 1.8.1. |
| 14:35:34 | <bwolfe> I have a conf call later tonight and tomorrow will clean up any 1.8.1 tickets that wyclif has deemed 1.8.1 worthy but has yet to backport. I also need to do more work on ws docs, but need to know where/what to add... |
| 14:36:09 | <asgoyal> oops |
| 14:36:12 | <asgoyal> sorry |
| 14:36:51 | <asgoyal> friday: did apptest-21, read tutorials on spring and hibernate today: will continue with the same |
| 14:37:31 | <asgoyal> bwolfe: sorry was away from keyboard for a while |
| 14:37:46 | <bwolfe> np |
| 14:38:10 | <bwolfe> asgoyala, are the tests running fine on your machine now? |
| 14:38:43 | <asgoyal> oh i did not see that yet... i will do it today |
| 14:38:52 | <asgoyal> but i will be checking that on firefox |
| 14:38:57 | <asgoyal> my chrome still gives me probls |
| 14:39:50 | <bwolfe> ok |
| 14:40:23 | <bwolfe> alright, any other questions or comments? |
| 14:40:35 | <asgoyal> nope |
| 14:41:12 | <rafa> what was the xml file with a default dataset for tests? |
| 14:41:30 | <djazayeri> rafa: I just emailed you my 1.8 database dump, let me know if it works |
| 14:42:13 | <rafa> djazayeri: ohh perfect |
| 14:42:22 | <bwolfe> rafa, starts with "standard" |
| 14:42:34 | <bwolfe> rafa, do a control-shift-r in eclipse to find it |
| 14:42:43 | <rafa> djazayeri: it's 1.8.x right? |
| 14:42:43 | <djazayeri> going offline for a bit |
| 14:42:48 | <djazayeri> standardTestDataset.xml |
| 14:42:49 | <djazayeri> yes, 1.8.x |
| 14:43:13 | <rafa> ok thank you both! |
| 14:44:11 | <bwolfe> dkayiwa, I don't like the TOC in there as it is. can you put a param in the {toc} to make it only show top-level ? |
| 14:44:33 | <dkayiwa> bwolfe: what do you mean by top level? |
| 14:44:48 | <dkayiwa> do you mean to show as it is but at the top? bwolfe |
| 14:44:48 | <bwolfe> meaning it shoudln't show the "urls" and "representations" in the toc |
| 14:45:06 | <dkayiwa> oh, only the resource names? |
| 14:45:25 | *** danielf` has quit IRC |
| 14:45:34 | <bwolfe> dkayiwa, yeah |
| 14:45:37 | <dkayiwa> ok |
| 14:46:02 | <bwolfe> dkayiwa, djazayeri, is that cohortmember's real rep ?? https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources |
| 14:46:03 | <OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org) |
| 14:46:29 | <bwolfe> dkayiwa, I like how you did the sentences. better than my suggestion of putting in the object name. :-) |
| 14:46:37 | <dkayiwa> hahahah |
| 14:46:39 | <dkayiwa> :) |
| 14:46:57 | <bwolfe> dkayiwa, we'll either need manual editing or some annotations for things like encounter that has extra special methods |
| 14:47:17 | <dkayiwa> bwolfe: yes i agree |
| 14:48:01 | <dkayiwa> bwolfe: as for cohortMember, that is what is in the code |
| 14:48:41 | <bwolfe> interesting. its a subresource, so I suppose thats ok |
| 14:48:52 | *** jwishnie has joined #openmrs |
| 14:48:53 | <dkayiwa> ok |
| 14:49:04 | <bwolfe> dkayiwa, so are you thinking manual editing or annotations ? |
| 14:49:19 | <dkayiwa> i prefer annotations |
| 14:49:30 | <bwolfe> ok, how long ot implement that? :_) |
| 14:49:39 | <dkayiwa> because manual editing will be overwritten |
| 14:49:48 | <bwolfe> right |
| 14:49:50 | <bwolfe> agreed |
| 14:50:21 | <dkayiwa> i think since the framework is in place, it should take like 30 mins |
| 14:50:38 | <dkayiwa> if all goes well |
| 14:53:36 | <bwolfe> ooo |
| 14:53:47 | * bwolfe notices a pattern with dkayiwa. everything is "30 mins" |
| 14:53:49 | <bwolfe> :-) |
| 14:53:55 | <dkayiwa> lolllllllllllllllllll |
| 14:54:13 | <dkayiwa> in reality it ends up more |
| 14:54:26 | <dkayiwa> thats convenient estimation :) |
| 14:54:34 | *** gbastien has joined #openmrs |
| 14:54:46 | <djazayeri> dkayiwa: what annotations are we doing? |
| 14:55:06 | <dkayiwa> for? |
| 14:55:09 | <djazayeri> where, I mean. |
| 14:55:24 | <djazayeri> for things like encounter that have extra methods |
| 14:55:37 | <dkayiwa> not yet done them |
| 14:56:13 | <dkayiwa> any suggestions? |
| 14:56:14 | <djazayeri> I mean (and bwolfe, your comment welcome too), strictly speaking we should be marking methods on the *controller* |
| 14:56:36 | <djazayeri> because just having a method on the resource doesn't actually make it user-facing. |
| 14:56:49 | <djazayeri> I don't know if that will completely muck with our documentation-producing code so far. |
| 14:56:51 | <bwolfe> djazayeri, yes, controller is where they should be |
| 14:57:22 | <djazayeri> So, what annotation do we do/ |
| 14:57:58 | <dkayiwa> for now we have done for @RequestMapping |
| 14:58:02 | <djazayeri> If we were to do a _real_ annotation (i.e. not just in the javadoc) then we could actually use introspection to determine which methods should be annotated |
| 14:58:26 | <djazayeri> oh, you're just going to look for @RequestMapping? That's neat. So we don't add anything custom for the documentation |
| 14:58:53 | <bwolfe> we need an annotation or something for the sentence of explanation though |
| 14:58:55 | <djazayeri> works for me |
| 14:59:03 | <dkayiwa> @RequestMapping is what we use for the current documentation |
| 14:59:26 | <dkayiwa> but it has no descriptions |
| 15:00:10 | <djazayeri> okay, so if we added a _real_ annotation we could use introspection, i.e. find the method with @RequestMapping, and then look for an @WSDoc annotation on that method |
| 15:01:04 | <djazayeri> not sure if the doc-generating code currently works based on text or on compiled java |
| 15:01:28 | <dkayiwa> it can use both |
| 15:01:50 | <dkayiwa> i used text for the javadoc tags |
| 15:02:17 | <djazayeri> okay, well, I'll let you figure out which way is best |
| 15:02:25 | <djazayeri> rafa: any luck reproducing the error? |
| 15:02:29 | <dkayiwa> hahaahahaha |
| 15:02:45 | *** pascal` has quit IRC |
| 15:03:15 | <wyclif> djazayeri, bwolfe , which date do you want to have 1.8.1 release? |
| 15:03:21 | <rafa> djazayeri: I'm finishing the other ws ticket. I'll look into META in 30 minutes. |
| 15:03:26 | <djazayeri> ok |
| 15:03:40 | <djazayeri> wyclif: as soon as is feasible... |
| 15:03:49 | <dkayiwa> :) |
| 15:03:52 | <wyclif> meaninf i can even do it tomorrow |
| 15:03:54 | <djazayeri> absolutely must be this week |
| 15:04:06 | <djazayeri> I don't see any reason to delay it once you're ready. |
| 15:04:09 | <djazayeri> bwolfe? |
| 15:04:10 | <wyclif> ok |
| 15:04:33 | <wyclif> then i guess i try to focus on the tickets today |
| 15:05:29 | <bwolfe> wyclif, asap |
| 15:05:35 | <wyclif> ok |
| 15:07:14 | <asgoyal> djazayeri: i have a question |
| 15:07:48 | <asgoyal> i was reading spring frame work document for transactional annotation.. it saays it must be used only for concrete classes and should be avoided for interfaces |
| 15:08:05 | <bwolfe> asgoyal, yeah, theres a ticket about that |
| 15:08:05 | <asgoyal> but its been used for conceptservice interface |
| 15:08:19 | <asgoyal> oh |
| 15:08:30 | <bwolfe> asgoyal, can you ghost your other nick? type /ghost asgoyal_ yournickservpassword |
| 15:08:35 | <djazayeri> yes, we're doing that wrong |
| 15:08:48 | <asgoyal> ok |
| 15:09:30 | <asgoyal> so.... dj my confusion is |
| 15:09:35 | <asgoyal> when we implement that |
| 15:09:48 | <asgoyal> like some concrete class implements that |
| 15:10:06 | <asgoyal> it cant inherit the transactional functionalities right? |
| 15:11:00 | *** asgoyal_ has quit IRC |
| 15:11:13 | <asgoyal> djazayeri: ^^ |
| 15:16:44 | <djazayeri> asgoyal: there are two problems with our current implementation |
| 15:16:52 | <asgoyal> oh ok and they are? |
| 15:16:54 | <djazayeri> 1. we're annotating the interface instead of the concrete class |
| 15:17:02 | <asgoyal> oki |
| 15:17:02 | <djazayeri> 2. we're annotating the service layer instead of the DAO layer |
| 15:17:18 | <asgoyal> oh... 2. one i need to read the docs... |
| 15:17:19 | <asgoyal> ok |
| 15:17:32 | <djazayeri> really we should be putting the transactional annotation on the method where the transaction is actually required |
| 15:17:35 | <asgoyal> so that means... annotating with transactional has no affect at all? |
| 15:17:45 | <djazayeri> no it does not mean that |
| 15:17:47 | <asgoyal> yes that is what i was wondering |
| 15:17:52 | <asgoyal> oh |
| 15:18:06 | <asgoyal> so whats the problem then? |
| 15:18:16 | <asgoyal> the docs says that annnotations cannot be inherited |
| 15:18:28 | <djazayeri> So, the right thing to do would be something like class HibernatePersonDAO { @Transactional savePerson(Person p) { sess.savePersonâ } } |
| 15:18:40 | <djazayeri> the annotations are not inheritied |
| 15:18:54 | <asgoyal> yeah... so how can they play any role to concrete classes then? |
| 15:19:00 | <asgoyal> they show no use that means |
| 15:19:22 | <djazayeri> the reason they work (as we've done them now) is that when you say Context.getPersonService() you get back a Spring-defined proxy for the PersonServiceImpl that has transactional behavior wrapped around it. |
| 15:19:41 | <djazayeri> so as long as you say Context.getPersonService().savePerson(â¦), things work fine |
| 15:19:41 | <asgoyal> oh!! |
| 15:20:35 | <asgoyal> and getPersonService returns... an object of interface class? |
| 15:23:41 | *** cta has joined #openmrs |
| 15:27:18 | <asgoyal> djazayeri: ok so it returns an interface instace.... |
| 15:27:22 | <asgoyal> instance |
| 15:27:39 | <asgoyal> .... that creats less flexibility to access things... |
| 15:27:45 | <asgoyal> creates* |
| 15:28:31 | <asgoyal> cant this be changed? |
| 15:40:41 | *** gbastien has quit IRC |
| 15:43:26 | *** gauravpaliwal has joined #openmrs |
| 15:43:26 | *** ChanServ sets mode: +v gauravpaliwal |
| 15:43:35 | *** gauravpaliwal has left #openmrs |
| 15:45:57 | *** pascal` has joined #openmrs |
| 15:48:20 | <rafa> djazayeri: I've got your excpetion :) |
| 15:48:36 | <rafa> djazayeri: Now, I can debug :) |
| 15:49:21 | <djazayeri> great |
| 15:54:11 | <dkayiwa> hi bwolfe |
| 15:54:51 | <asgoyal> djazayeri: which file should contain the implementation for getDrugByIngredient(Concept) method? |
| 15:55:27 | <djazayeri> Drug-related methods go in ConceptService |
| 15:55:32 | <dkayiwa> bwolfe: will you now adding the http operation url descriptions using this annotation? e.g @WSDoc(description = "Fetch all non-retired encounters for a given patient") |
| 15:55:54 | <asgoyal> djazayeri: that is the interface but which class implements it ? |
| 15:56:11 | <djazayeri> dkayiwa: side-point, make it value, not description, so you can just say @WSDoc("Fetch â¦") |
| 15:56:17 | <djazayeri> asgoyal: ConceptServiceImpl |
| 15:56:24 | <asgoyal> ok |
| 15:57:36 | *** dkayiwa has quit IRC |
| 16:05:33 | *** dkayiwa has joined #openmrs |
| 16:07:03 | *** dkayiwa has quit IRC |
| 16:08:56 | *** lh has joined #openmrs |
| 16:09:30 | *** gbastien has joined #openmrs |
| 16:15:04 | *** mandric has joined #openmrs |
| 16:28:46 | *** downeym has quit IRC |
| 16:42:46 | *** jriley has joined #openmrs |
| 16:52:26 | *** gbastien has quit IRC |
| 17:10:29 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): Changed attributes for Person, PersonAttribute and PersonAttributeType <http://feedproxy.google.com/~r/OMRStrunk/~3/oWwV1vdsXw8/OpenMRS> |
| 17:42:30 | <OpenMRSBot> Recent updates in the world of openmrs: Burke Mamlin: Displaying OpenMRS observations using Groovy <http://blog.burkeware.com/archives/163> |
| 17:52:45 | <asgoyal> djazayeri: can you explain me what is a "locale" used for? :S |
| 17:55:31 | <djazayeri> asgoyal: http://java.sun.com/developer/technicalArticles/J2SE/locale/ |
| 17:55:37 | <OpenMRSBot> <http://ln-s.net/8zD2> (at java.sun.com) |
| 18:03:38 | *** bwolfe has quit IRC |
| 18:11:46 | *** Suranga has joined #openmrs |
| 18:14:34 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): Changed methods for PersonAttributeTypeFormController by adjasting them for AttributeHandler <http://feedproxy.google.com/~r/OMRStrunk/~3/tEnr2YpctpQ/OpenMRS> |
| 18:25:35 | *** downeym has joined #openmrs |
| 18:25:35 | *** ChanServ sets mode: +o downeym |
| 18:25:35 | *** OpenMRSBot sets mode: +o downeym |
| 18:26:43 | *** goutham has joined #openmrs |
| 18:28:00 | *** pascal` has quit IRC |
| 18:32:49 | <asgoyal> djazayeri: dj, why do we need a function like "getDrugsByIngredient" when we already have one implemented in the name of "getDrugsByConcept" ? |
| 18:33:17 | <asgoyal> or in the ticket 2193 .. is the return type given wrongly? |
| 18:33:18 | *** goutham has quit IRC |
| 18:33:37 | <asgoyal> cuz in ticket it says add a function like getDrugsByIngredient(Concept) |
| 18:33:45 | <asgoyal> oh sorry i mean the parameter to function |
| 18:33:59 | <djazayeri> getDrugsbyConcept(x) finds drugs for whom drug.concept = x |
| 18:34:23 | <asgoyal> i think it must be getDrugsByIngredient(DrugIngredient) .. shouldn't it be so? |
| 18:34:36 | <djazayeri> getDrugsByIngredient(x) finds drugs for whom drug.concept = x or drug.ingredient[i].concept = x |
| 18:35:09 | <asgoyal> oh |
| 18:46:36 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Support XML marshalling in spring MVC - TRUNK-2445 <http://feedproxy.google.com/~r/OMRStrunk/~3/F5yMv8AyU8g/OpenMRS> |
| 19:11:28 | *** suho has quit IRC |
| 19:11:48 | <asgoyal> djazayeri: is it fine if i add a new function of my own in the hibernateconceptdao file? |
| 19:12:13 | <djazayeri> you _have_ to |
| 19:12:52 | <asgoyal> ok just making sure whether i m allowed to stuff besides what is given in ticket |
| 19:13:36 | *** cta has quit IRC |
| 19:17:38 | *** Suranga has quit IRC |
| 19:20:03 | *** gbastien has joined #openmrs |
| 19:27:24 | <wyclif> djazayeri, how do we add a library to the nexus repo/ |
| 19:27:51 | <wyclif> forinstance i added a new lib in the pom.xml file |
| 19:28:04 | <djazayeri> asgoyal: If the ticket says add a method to a service, you usually need to add a DAO method too. it's implied |
| 19:28:07 | <djazayeri> wyclif: not sure |
| 19:28:10 | <wyclif> and i need to have it included |
| 19:28:25 | <wyclif> have you seen the latest failed build |
| 19:28:50 | <wyclif> it is because i have added a new lib in the pom file and ci can't find it |
| 19:29:08 | *** mandric has quit IRC |
| 19:41:38 | *** jriley has quit IRC |
| 19:42:55 | *** bryq1 has joined #openmrs |
| 19:44:07 | *** bryq has quit IRC |
| 19:44:36 | *** jriley has joined #openmrs |
| 19:45:57 | *** james_regen has quit IRC |
| 19:50:13 | <djazayeri> wyclif: haven't seen it yet. bwolfe would know how to add things (and I should find out) |
| 19:52:03 | <asgoyal> djazayeri: a simple question... what will be the relationship between a Drug and DrugIngredients?? |
| 19:52:09 | <asgoyal> many-to-many? |
| 19:52:25 | <djazayeri> yes |
| 19:52:36 | <asgoyal> aaaaahhh messed my code!! |
| 19:52:36 | <djazayeri> one drug has many ingredients |
| 19:52:45 | <djazayeri> the same ingredient can also belong to many drugs |
| 19:52:46 | <asgoyal> i mapped it as one to many |
| 19:52:50 | <djazayeri> right? |
| 19:52:52 | <asgoyal> ... yep |
| 19:52:55 | <djazayeri> is there an intermediate table? |
| 19:52:56 | <asgoyal> very correct |
| 19:53:02 | <asgoyal> nope |
| 19:53:24 | <asgoyal> will need to change a lot again! |
| 19:53:31 | <asgoyal> ok thanks |
| 19:54:00 | *** asgoyal has quit IRC |
| 20:04:42 | *** dkayiwa has joined #openmrs |
| 20:11:33 | *** dkayiwa has quit IRC |
| 20:16:01 | *** gbastien has quit IRC |
| 20:17:12 | *** jwishnie has quit IRC |
| 20:22:38 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Displaying #OpenMRS observations using #Groovy: http://bit.ly/r9y0Ow /via @ekrub <http://twitter.com/OpenMRS/statuses/90504947308834816> |
| 20:22:44 | <rafa> djazayeri: are you there? |
| 20:27:13 | *** gbastien has joined #openmrs |
| 20:43:39 | *** mandric has joined #openmrs |
| 20:45:40 | <djazayeri> rafa: I am now |
| 20:48:07 | <rafa> djazayeri: I think I fixed the problem. |
| 20:48:20 | <djazayeri> alright, i'll update and try again |
| 20:48:27 | <rafa> djazayeri: I'll commit now and you can try again. |
| 20:49:15 | *** mandric has quit IRC |
| 20:49:16 | <rafa> djazayeri: It's a hibernate issue. It didn't notice that I updated the collection of names. |
| 20:49:55 | <rafa> djazayeri: I don't know why. |
| 20:50:10 | <rafa> djazayeri: I've been investigating it for quite a while and gave up. |
| 20:50:21 | <djazayeri> but you solved it now? |
| 20:50:26 | <rafa> djazayeri: I applied a hacky fix. |
| 20:50:53 | <rafa> djazayeri: I save concept names manually rather than leaving it for hibernate |
| 20:53:14 | <rafa> djazayeri: Have you seen https://tickets.openmrs.org/browse/META-94? |
| 20:53:32 | <djazayeri> rafa: I commented on the ticket. :-P |
| 20:53:42 | <rafa> oh, right :) |
| 20:53:45 | <rafa> hehe |
| 20:53:58 | <djazayeri> Actually I think that "All non-retired" should actually be the default rather than "add all" |
| 20:54:05 | <djazayeri> It's a good suggestion. |
| 20:56:39 | *** mandric has joined #openmrs |
| 21:07:05 | *** jriley has quit IRC |
| 21:07:21 | *** gbastien has quit IRC |
| 21:10:10 | *** Echidna has quit IRC |
| 21:12:54 | *** jwishnie has joined #openmrs |
| 21:13:11 | <djazayeri> rafa: you did that svn commit, right? |
| 21:13:23 | <rafa> djazayeri: The code is committed. |
| 21:13:28 | <djazayeri> cool, will test now |
| 21:13:46 | <rafa> djazayeri: My last commit just a sec ago. |
| 21:14:12 | *** Echidna has joined #openmrs |
| 21:14:12 | *** ChanServ sets mode: +v Echidna |
| 21:14:29 | *** bryq1 has left #openmrs |
| 21:17:29 | <rafa> djazayeri: I'll leave you now. Please comment or close the ticket if it works for you. |
| 21:18:07 | <djazayeri> ok |
| 21:24:52 | *** mandric has quit IRC |
| 21:33:47 | *** rafa has quit IRC |
| 22:30:26 | *** wyclif has quit IRC |
| 22:30:48 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Backporting, Dashboard Slow to Load for Patients with Many Encounters(rev:20496) - TRUNK-1375 <http://feedproxy.google.com/~r/OMRStrunk/~3/B3WND_khMBM/OpenMRS> |
| 22:35:13 | *** downeym has quit IRC |
| 23:28:42 | *** wyclif has joined #openmrs |
| 23:39:05 | *** elliott_w has joined #openmrs |
| 23:39:05 | *** ChanServ sets mode: +o elliott_w |
| 23:41:04 | *** mandric has joined #openmrs |
| 23:45:36 | *** elliott_w has left #openmrs |