| 00:02:41 | *** Echidna has joined #openmrs |
| 00:02:41 | *** ChanServ sets mode: +v Echidna |
| 00:09:24 | *** gbastien has joined #openmrs |
| 00:12:19 | *** lh has quit IRC |
| 00:14:11 | *** gbastien has quit IRC |
| 00:32:30 | *** mandric has joined #openmrs |
| 00:51:23 | *** jwishnie has quit IRC |
| 01:00:32 | *** wyclif has joined #openmrs |
| 01:17:03 | *** suho has quit IRC |
| 01:39:34 | *** djazayeri has quit IRC |
| 01:42:23 | *** djazayeri has joined #openmrs |
| 01:42:23 | *** ChanServ sets mode: +o djazayeri |
| 01:45:42 | *** djazayeri has quit IRC |
| 01:48:08 | *** yanokwa has quit IRC |
| 02:20:17 | *** downeym has quit IRC |
| 02:23:09 | *** mandric has quit IRC |
| 02:42:44 | *** upul` has joined #openmrs |
| 02:42:44 | *** ChanServ sets mode: +v upul` |
| 03:24:37 | *** djazayeri has joined #openmrs |
| 03:24:38 | *** ChanServ sets mode: +o djazayeri |
| 03:47:39 | *** surangak has joined #openmrs |
| 04:00:06 | *** surangak_ has joined #openmrs |
| 04:12:17 | *** mccallumg has joined #openmrs |
| 04:12:17 | *** ChanServ sets mode: +v mccallumg |
| 04:12:34 | <mccallumg> hi surangak_ |
| 04:14:12 | <mccallumg> hi surangak |
| 04:34:19 | <surangak_> mccallumg, hello |
| 04:34:42 | <mccallumg> surangak_: hey |
| 04:34:46 | <surangak_> mccallumg, very sorry, somehow i had misssed your message |
| 04:35:13 | <surangak_> mccallumg, i see i kept you waiting for some time :-( |
| 04:35:22 | <mccallumg> surangak_: i'm getting better with maven |
| 04:35:44 | <surangak_> mccallumg, aha, is it working now ? |
| 04:35:55 | <mccallumg> surangak_: i can build trunk with no issues |
| 04:35:56 | <surangak_> mccallumg, our branch, i mean |
| 04:36:11 | <mccallumg> surangak_: same cryptic failre |
| 04:36:23 | <mccallumg> surangak_: failure |
| 04:36:42 | <surangak_> mccallumg, the openmrs trunk is ok, but not branch ? |
| 04:36:52 | <surangak_> still the openmrs api :tests right ? |
| 04:36:54 | <mccallumg> surangak_: true |
| 04:37:37 | <surangak_> mccallumg, did you check if tht jar exists in your repo ? |
| 04:37:53 | <mccallumg> surangak_: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.5:test (default-test) on project openmrs-api: There are test failures. |
| 04:38:21 | <mccallumg> surangak_: it is not missing a jar now ... |
| 04:38:36 | <surangak_> mccallumg, aha, these are for the tests right ? |
| 04:38:51 | <surangak_> mccallumg, but you @Ignored both failed tests, i believe |
| 04:39:06 | <mccallumg> surangak_: come on connect, plz? |
| 04:39:22 | <surangak_> mccallumg, sure.. |
| 04:41:49 | *** surangak__ has joined #openmrs |
| 04:41:56 | *** surangak_ has quit IRC |
| 04:42:09 | *** surangak has quit IRC |
| 04:42:50 | *** surangak has joined #openmrs |
| 04:55:02 | <surangak__> !surangak |
| 04:55:02 | <OpenMRSBot> surangak__: Error: "surangak" is not a valid command. |
| 04:57:28 | <mccallumg> surangak__: I think that it passed the openmrs-api build this time |
| 04:57:51 | <surangak__> mccallumg, i realized what happened.. |
| 04:58:13 | <mccallumg> surangak__: Yeah. It seemed like it. |
| 04:58:26 | <mccallumg> surangak__: [INFO] BUILD SUCCESS |
| 04:58:29 | <surangak__> mccallumg, after you got the mven working, it failed on the obsservicetest |
| 04:58:44 | <surangak__> mccallumg, now u can have a go running it :) |
| 04:58:53 | <mccallumg> surangak__: Yay!!! |
| 04:59:16 | <mccallumg> surangak__: alright. I have to run now. thanks for all your help this week with the whole process. |
| 04:59:23 | <surangak__> mccallumg no problem |
| 04:59:32 | <mccallumg> surangak__: keep in touch by email over the weekend? |
| 04:59:36 | <surangak__> mccallumg, im working on tests and docs |
| 04:59:55 | <surangak__> mccallumg, ill let you know how it goes |
| 05:00:02 | <mccallumg> surangak__: I agree that it is time for some docs. |
| 05:00:24 | <surangak__> mccallumg, i will probably have some drafts prepared to review by monday ? |
| 05:01:10 | <mccallumg> surangak__: (1) how to use the complex datatype you implemented. (2) how developers can create their own custom datatypes |
| 05:01:39 | <surangak__> mccallumg, we are looking at several wiki pages, i think :-) |
| 05:02:02 | <mccallumg> surangak__: whatever it takes |
| 05:02:08 | <surangak__> mccallumg, sure thing, will do... |
| 05:02:10 | <mccallumg> surangak__: have a good day. bye. |
| 05:02:37 | <surangak__> mccallumg, have a nice weekend... bye |
| 05:03:46 | *** mccallumg has quit IRC |
| 05:29:00 | *** pascal` has quit IRC |
| 05:43:04 | *** bryq has joined #openmrs |
| 05:43:04 | *** ChanServ sets mode: +v bryq |
| 05:48:44 | *** vchircu has quit IRC |
| 05:56:21 | *** vchircu has joined #openmrs |
| 06:16:36 | *** lh has joined #openmrs |
| 06:21:07 | *** bwolfe has joined #openmrs |
| 06:21:07 | *** ChanServ sets mode: +o bwolfe |
| 06:34:05 | *** bryq has quit IRC |
| 06:39:29 | *** yanokwa has joined #openmrs |
| 06:39:39 | *** ChanServ sets mode: +v yanokwa |
| 06:45:03 | *** yanokwa has quit IRC |
| 06:51:03 | *** bwolfe_ has joined #openmrs |
| 06:51:03 | *** ChanServ sets mode: +o bwolfe_ |
| 06:54:03 | *** bwolfe has quit IRC |
| 07:04:00 | *** filip_jovi has joined #openmrs |
| 07:04:33 | <filip_jovi> excuse me everyone, is there a way i can register myself on OpenMRS ? |
| 07:06:47 | <bwolfe_> filip_jovi, which part of openmrs? |
| 07:07:14 | <filip_jovi> well, i just installed the application |
| 07:07:21 | <filip_jovi> the version with the demo |
| 07:07:30 | <filip_jovi> on internet, on the official site |
| 07:07:41 | <filip_jovi> it asks for login |
| 07:08:03 | <filip_jovi> or is the web site only for the admins maybe? |
| 07:08:45 | <bwolfe_> filip_jovi, can you give me the url? |
| 07:08:50 | <filip_jovi> yup |
| 07:08:58 | <bwolfe_> filip_jovi, *.openmrs.org is for everyone and anyone |
| 07:09:06 | *** bwolfe_ is now known as bwolfe |
| 07:09:58 | <filip_jovi> http://demo.openmrs.org/openmrs/index.htm;jsessionid=C02FACE731BD6E4BCC2A4FB9E84611F7 |
| 07:10:03 | <filip_jovi> (Demo) |
| 07:10:03 | <OpenMRSBot> <http://ln-s.net/8yqM> (at demo.openmrs.org) |
| 07:10:11 | <bwolfe> filip_jovi, demo uses "admin" and "test" as the login |
| 07:10:16 | *** rafa has joined #openmrs |
| 07:10:16 | *** ChanServ sets mode: +v rafa |
| 07:10:57 | <filip_jovi> ou |
| 07:10:58 | <filip_jovi> :D |
| 07:11:00 | <filip_jovi> great |
| 07:11:02 | <filip_jovi> thanks |
| 07:11:14 | <filip_jovi> couldn't know that actually |
| 07:11:31 | <bwolfe> filip_jovi, wiki.openmrs.org, tickets.openmrs.org, svn.openmrs.org, source.openmrs.org, they all use a common "openmrs id". see https://wiki.openmrs.org/display/RES/OpenMRS+ID |
| 07:11:44 | <bwolfe> filip_jovi, hmm, its not on the header there? it used to be... |
| 07:15:07 | <filip_jovi> maybe i just didn't see it |
| 07:15:26 | <filip_jovi> no problem |
| 07:16:53 | <filip_jovi> can anybody see my patient history (my allergies, medicaments, tests, ...) |
| 07:16:55 | <filip_jovi> ? |
| 07:17:02 | <filip_jovi> it's private right? |
| 07:17:31 | <bwolfe> filip_jovi, what do you mean? on demo? or on your local install of openmrs? |
| 07:17:54 | <filip_jovi> :D |
| 07:17:57 | <filip_jovi> i'm sorry |
| 07:18:06 | <filip_jovi> i got confused a bit |
| 07:18:17 | <filip_jovi> i meant on the demo |
| 07:18:21 | <filip_jovi> but it's demo |
| 07:18:27 | *** rafa has quit IRC |
| 07:18:28 | <filip_jovi> not so clever of me |
| 07:18:33 | <filip_jovi> ... |
| 07:20:48 | <bwolfe> right, the demo server is open to everyone...hench the pw just being "test". :-) the database on that server is wiped out every night, so I hope you weren't planning on using that for a production system. ;-) |
| 07:24:11 | <filip_jovi> haha, |
| 07:24:31 | <filip_jovi> the offline app takes pretty much to extract |
| 07:24:41 | <filip_jovi> in the meantime, i'm checking the demo |
| 07:29:51 | <filip_jovi> wthat's the report tag about? |
| 07:30:07 | <filip_jovi> to make a comment about the program maybe!? |
| 07:30:09 | <bwolfe> what do you mean by "report tag" ? |
| 07:33:52 | <filip_jovi> Reporting part of the menu |
| 07:34:05 | <filip_jovi> on the demo.opnmrs.org |
| 07:34:09 | <filip_jovi> *open |
| 07:34:40 | <bwolfe> reporting is generating reports on the data stored in the openmrs database |
| 07:36:30 | <filip_jovi> like notes? |
| 07:38:50 | *** rafa has joined #openmrs |
| 07:38:50 | *** ChanServ sets mode: +v rafa |
| 08:03:06 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: PatientDashboard modification module <http://forum.openmrs.org/viewtopic.php?f=8&t=793#p2995> || New Changeset: OpenMRS (obs-codes-expanded): Changes to ObsService - depricating obsolete service layer methods <http://feedproxy.google.com/~r/OMRStrunk/~3/7IhpL14mRNk/OpenMRS> |
| 08:07:20 | *** filip_jovi has quit IRC |
| 08:10:06 | *** pascal` has joined #openmrs |
| 08:34:58 | *** danielf` has joined #openmrs |
| 08:34:58 | *** ChanServ sets mode: +v danielf` |
| 09:02:00 | *** muthah has joined #openmrs |
| 09:09:19 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): New Extension Point in headerfull.jsp for Feedback Module - TRUNK-2441 <http://feedproxy.google.com/~r/OMRStrunk/~3/lCBqwj487AQ/OpenMRS> |
| 09:20:33 | *** bryq has joined #openmrs |
| 09:20:33 | *** ChanServ sets mode: +v bryq |
| 09:22:47 | *** dkayiwa has joined #openmrs |
| 09:58:15 | <dkayiwa> hi bwolfe |
| 09:58:44 | <bwolfe> hey |
| 09:58:45 | <bwolfe> whats up? |
| 09:58:51 | <dkayiwa> nothing much |
| 09:58:59 | <dkayiwa> whatz up |
| 09:59:23 | <dkayiwa> i can see you cleaned up the REST Web Service Resources page |
| 09:59:40 | <dkayiwa> does this mean that the automatic output should look like this bwolfe? |
| 10:00:35 | <bwolfe> I just did the one for user. it was my suggestion, you don't have to do it exactly like that if you don't want to |
| 10:00:53 | <bwolfe> I meant to go back and comment on the ticket saying what I did, but forgot. glad you found it! |
| 10:04:02 | <dkayiwa> :) |
| 10:04:53 | <dkayiwa> on the contrary i actually like it!!! It looks much much better than what i had done. bwolfe :) |
| 10:05:10 | <dkayiwa> am only hoping i will be able to automate it :) |
| 10:05:49 | <bwolfe> dkayiwa, we need to document the POST content too somehow. is there a way for you to pull that out? or do we just make it match to the full rep ? |
| 10:06:59 | <dkayiwa> bwolfe: by POST content, do you mean Available HTTP Verbs? |
| 10:07:09 | <dkayiwa> like for the Encounter resource? |
| 10:08:47 | <bwolfe> dkayiwa, we def want to show all the verbs like I did with User. but what I meant is what content is possible to include request body when submitting a POST |
| 10:12:08 | <dkayiwa> ok |
| 10:15:17 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: PatientDashboard modification module <http://forum.openmrs.org/viewtopic.php?f=8&t=793#p2996> |
| 10:38:28 | *** muthah has quit IRC |
| 10:40:06 | *** bwolfe has quit IRC |
| 10:49:19 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: PatientDashboard modification module <http://forum.openmrs.org/viewtopic.php?f=8&t=793#p2997> || New Changeset: OpenMRS (1.8.x): New Extension Point in headerfull.jsp for Feedback Module - TRUNK-2441... <http://feedproxy.google.com/~r/OMRStrunk/~3/GMcwwTkFd7k/OpenMRS> |
| 10:54:32 | *** r-friedman has quit IRC |
| 11:11:04 | *** surangak__ has quit IRC |
| 11:21:30 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Could not proceed with the installation of openMRS1.8.0 <http://forum.openmrs.org/viewtopic.php?f=9&t=794#p2999> || OpenMRS Forum: Could not proceed with the installation of openMRS1.8.0 <http://forum.openmrs.org/viewtopic.php?f=9&t=794#p2998> |
| 11:21:31 | *** surangak has quit IRC |
| 11:26:31 | *** upul` has quit IRC |
| 11:27:24 | *** james_regen has joined #openmrs |
| 11:27:24 | *** ChanServ sets mode: +v james_regen |
| 11:28:14 | *** bryq has quit IRC |
| 12:13:17 | *** bryq has joined #openmrs |
| 12:13:17 | *** ChanServ sets mode: +v bryq |
| 12:15:21 | *** danielf` has quit IRC |
| 12:18:52 | *** bryq1 has joined #openmrs |
| 12:19:03 | *** bryq has quit IRC |
| 12:19:05 | *** dkayiwa has quit IRC |
| 12:21:39 | *** wyclif has quit IRC |
| 12:24:44 | *** gbastien has joined #openmrs |
| 12:33:27 | *** vchircu_ has joined #openmrs |
| 12:34:38 | *** vchircu has quit IRC |
| 12:37:05 | *** downeym has joined #openmrs |
| 12:37:05 | *** OpenMRSBot sets mode: +o downeym |
| 12:37:05 | *** ChanServ sets mode: +o downeym |
| 12:48:04 | *** bryq1 has quit IRC |
| 12:54:54 | *** danielf` has joined #openmrs |
| 12:54:54 | *** ChanServ sets mode: +v danielf` |
| 12:55:05 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Could not proceed with the installation of openMRS1.8.0 <http://forum.openmrs.org/viewtopic.php?f=9&t=794#p3000> |
| 13:09:51 | *** bwolfe has joined #openmrs |
| 13:09:51 | *** ChanServ sets mode: +o bwolfe |
| 13:15:55 | *** wyclif has joined #openmrs |
| 13:16:15 | *** bwolfe_ has joined #openmrs |
| 13:16:16 | *** ChanServ sets mode: +o bwolfe_ |
| 13:20:13 | *** bwolfe has quit IRC |
| 13:25:41 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Could not proceed with the installation of openMRS1.8.0 <http://forum.openmrs.org/viewtopic.php?f=9&t=794#p3001> |
| 13:26:18 | *** bryq has joined #openmrs |
| 13:26:18 | *** ChanServ sets mode: +v bryq |
| 13:33:56 | *** danielf` has quit IRC |
| 13:36:20 | *** downeym has quit IRC |
| 13:37:24 | *** wyclif has quit IRC |
| 13:38:33 | *** wyclif has joined #openmrs |
| 13:40:12 | *** downeym has joined #openmrs |
| 13:40:12 | *** OpenMRSBot sets mode: +o downeym |
| 13:40:12 | *** ChanServ sets mode: +o downeym |
| 13:44:31 | *** downeym has quit IRC |
| 13:48:37 | *** bryq has quit IRC |
| 14:00:48 | *** wyclif has quit IRC |
| 14:00:58 | *** wyclif has joined #openmrs |
| 14:04:28 | <bwolfe_> djazayeri, wyclif, rafa, asgoyal_, (and a missing dkayiwa...) |
| 14:04:28 | <djazayeri> hi |
| 14:04:32 | *** bwolfe_ is now known as bwolfe |
| 14:04:36 | <rafa> Hi guys! |
| 14:04:39 | <wyclif> hi guys |
| 14:04:41 | *** downeym has joined #openmrs |
| 14:04:41 | *** ChanServ sets mode: +o downeym |
| 14:04:41 | *** OpenMRSBot sets mode: +o downeym |
| 14:04:43 | <bwolfe> everyone around for the scrum? |
| 14:05:57 | <djazayeri> yes... |
| 14:06:02 | <bwolfe> ok, rafa, you want to go first? |
| 14:06:28 | <rafa> Today: Released Metadata Sharing! |
| 14:06:30 | <bwolfe> is daniel on skype right now? can someone ping him to jump in here? |
| 14:06:35 | <bwolfe> rafa: congrats. :-) |
| 14:06:40 | <bwolfe> I didn't see an email about it though... |
| 14:06:43 | <rafa> thanks! |
| 14:06:45 | <downeym> rafa++ |
| 14:06:53 | <rafa> bwolfe: right, it's just a few minutes ago :) |
| 14:07:06 | <rafa> I'll e-mail devs soon. |
| 14:07:24 | <rafa> Maybe, I should work on HtmlForm first. |
| 14:07:30 | <rafa> Darius what do you think? |
| 14:07:50 | <djazayeri> I only skimmed mark's comment. |
| 14:08:01 | <djazayeri> I think it would be good to update htmlformentry first |
| 14:08:10 | <djazayeri> because that's the main thing that people actually share with MDS. |
| 14:08:23 | <rafa> Mark replied that I can try to implement the onSave method. |
| 14:08:27 | <djazayeri> otherwise all you'll be doing is releasing a new version of MDS that has no useful content |
| 14:08:38 | <rafa> He seems to be busy. |
| 14:08:57 | <djazayeri> yes, let's take a look and see whether it'll be easy for you to do the onsave method |
| 14:09:32 | <rafa> I have two more hours today. I can have a look at it. |
| 14:09:34 | <djazayeri> because I'm a bit worried about releasing the new metadata sharing but then telling people "all existing packages with html forms will break. and there's no way to create new compatible packages yet" |
| 14:09:36 | <djazayeri> ok |
| 14:09:58 | <bwolfe> heh, yes, seems like you should work that kink out first rafa |
| 14:10:02 | <djazayeri> (did you make the UI changes and bugfixes I mentioned?) |
| 14:10:09 | <rafa> bwolfe: sorry, I'm not yet ready for ws :( |
| 14:10:19 | <rafa> djazayeri: a couple of them |
| 14:10:22 | <rafa> djazayeri: see my e-mail |
| 14:10:38 | <djazayeri> ok, will check. (Just woke up...) |
| 14:10:53 | <rafa> djazayeri: I managed to display datatype in all places though. |
| 14:11:14 | *** yanokwa has joined #openmrs |
| 14:11:14 | *** ChanServ sets mode: +v yanokwa |
| 14:11:50 | <rafa> djazayeri: The search works slightly better now. I search only for names and omit descriptions. It's what caused the more relevant items to appear at the end of the list. |
| 14:12:13 | <djazayeri> oh, excellent |
| 14:12:44 | <rafa> djazayeri: I also suggest the first matching item by name. |
| 14:12:59 | <djazayeri> great. |
| 14:13:08 | <djazayeri> (I'll read the email, and try running the code again) |
| 14:13:17 | <rafa> ok |
| 14:13:32 | <rafa> On Monday, I'll join the sprint for sure :D |
| 14:13:37 | <rafa> No blockers. |
| 14:14:19 | <rafa> djazayeri: Darius have a look at the docs I've added to the wiki. |
| 14:14:53 | <rafa> https://wiki.openmrs.org/display/docs/Metadata+Sharing+Module |
| 14:14:59 | <rafa> Okay, it's all from me. |
| 14:14:59 | <OpenMRSBot> <http://ln-s.net/8yuP> (at wiki.openmrs.org) |
| 14:15:01 | <rafa> thanks |
| 14:15:02 | <bwolfe> great...just in time to miss all the main ws tickets rafa :-) |
| 14:15:29 | <rafa> What a shame... |
| 14:16:03 | <bwolfe> luckily theres plenty of work. :-) |
| 14:16:21 | <rafa> bwolfe: I hope it's not only docs ;) |
| 14:16:23 | <bwolfe> I'll review our status first thing monday and let you know. ping me when you start working |
| 14:16:35 | <bwolfe> rafa, ha |
| 14:17:21 | <bwolfe> ok, djazayeri? |
| 14:17:33 | <djazayeri> Yesterday: |
| 14:17:33 | <djazayeri> * Reviewed metadata sharing UI |
| 14:17:33 | <djazayeri> * Did two small WS tickets |
| 14:17:33 | <djazayeri> * Did code reviews of "provider" code by thoughtworks |
| 14:17:33 | <djazayeri> Today: |
| 14:17:34 | <djazayeri> * Prep for UI sprint |
| 14:17:34 | <djazayeri> * Code review |
| 14:17:37 | <djazayeri> no blockers |
| 14:18:00 | <bwolfe> code review of... ? |
| 14:18:09 | <djazayeri> I have lots of overdue ones |
| 14:18:18 | <djazayeri> * Code review*s* |
| 14:18:20 | <asgoyal_> sry i arrived a little late |
| 14:18:27 | <bwolfe> ah, just general ones then? oe or other openmrs ones? |
| 14:19:22 | <djazayeri> Whatever's in my crucible backlog |
| 14:19:37 | <djazayeri> I'll look at WS first if there's anything assigned to me |
| 14:20:31 | <bwolfe> there are only a few ws ones, I've been closing a lot of htem without your second review |
| 14:20:56 | <djazayeri> that's fine. core dev author + 1 review is enough |
| 14:21:25 | <bwolfe> ok. wyclif? |
| 14:21:40 | *** asgoyal has joined #openmrs |
| 14:22:13 | <wyclif> Yesterday: Completed concept description resource and updated the fix for RESTWS-155(conceptresource), spent time with ankur and helped him with TRUNK-2193, investigated xml support in ws, committed a few small bug fixes on ws help page, partialy worked on RESTWS-113(list a catalog of resources) |
| 14:22:57 | <wyclif> Today: finish upRESTWS-113, Testing 1.8.1 to locate the bug i mentioned and fix if i reproduce it, and possibly RESTWS-160(xml support), No blockers |
| 14:23:19 | <bwolfe> wyclif, look at the 1.8.1 open tickets too |
| 14:23:26 | <wyclif> ok |
| 14:23:34 | <bwolfe> james has opened a few in reference to your new search widgets and your new short patient edit screen |
| 14:23:45 | <wyclif> so do you want me to do 1.8.1 release? |
| 14:23:55 | <wyclif> i can do the packaging |
| 14:24:23 | <djazayeri> by the way, are we sure that the 1.8.0 maven artifacts got published to our nexus repo? |
| 14:24:49 | <bwolfe> I haven't checked to see if they were |
| 14:25:24 | <bwolfe> wyclif, don't package it yet, but determine which of the tickets with fixVersion=1.8.1 really MUST be fixed and which we can punt to 1.8.2 |
| 14:25:51 | <djazayeri> Looks like they are. (I wasn't able to find them when exploring through the m2eclipse tool yesterday though. Stupid m2e.) |
| 14:26:13 | <downeym> http://mavenrepo.openmrs.org/nexus/index.html#nexus-search;quick~openmrs |
| 14:26:18 | <OpenMRSBot> <http://ln-s.net/8yuX> (at mavenrepo.openmrs.org) |
| 14:26:44 | <bwolfe> who did that publishing? |
| 14:27:20 | <downeym> !me |
| 14:27:20 | <OpenMRSBot> downeym: Error: "me" is not a valid command. |
| 14:27:24 | <downeym> jej |
| 14:27:27 | <downeym> s/j/h/g |
| 14:27:33 | <bwolfe> jej is german for heh |
| 14:27:46 | <downeym> ja ja est ist |
| 14:28:33 | *** pascal` has quit IRC |
| 14:28:35 | <bwolfe> ok |
| 14:29:02 | <bwolfe> wyclif, feel free to do the punting now (you might have to make a 1.8.2 release version first in jira) |
| 14:29:48 | <bwolfe> asgoyal_ ? |
| 14:29:49 | <wyclif> ok |
| 14:29:52 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 0.9 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&0.9> |
| 14:29:57 | <asgoyal_> yesterday: studies tutorials on hibernate, worked on trunk 2913 today: will continue with the same |
| 14:30:02 | <asgoyal_> studied* |
| 14:30:27 | <asgoyal_> 2193* |
| 14:30:52 | <bwolfe> ok. any blockers with that? |
| 14:31:09 | <asgoyal_> (dont know what blockers mean....) |
| 14:31:25 | <rafa> :) |
| 14:31:38 | <bwolfe> anything blocking you from continuing ? |
| 14:31:41 | <asgoyal_> nope |
| 14:31:55 | <asgoyal_> discussed with wyclif.. so for now none |
| 14:32:57 | <bwolfe> ok |
| 14:33:11 | <bwolfe> no daniel yet...anyone check to see if he's on skype? |
| 14:33:45 | <djazayeri> not on skype |
| 14:34:01 | <bwolfe> hmm, ok, guess we'll do an email checkup with him |
| 14:35:45 | <bwolfe> today I cleaned up my email queue (added to you-alls), answered some forum posts, did TRUNK-24411 for guarav, cleaned up the ws tickets, did RESTWS-162 , and worked on the ws wiki pages. |
| 14:36:20 | <djazayeri> "thanks" for all the wiki page notifications about WS docs. :-) |
| 14:36:25 | <bwolfe> monday I'm focusing on finalizing the docs, doing what it takes to get 1.8.1 released, n dmaking sure ws is almost done |
| 14:36:45 | <bwolfe> djazayeri, hope you reviewed all those changes for me :-D |
| 14:36:55 | <djazayeri> um⦠"yes"? |
| 14:37:10 | <bwolfe> heh |
| 14:37:11 | <djazayeri> (for false values of yes) |
| 14:38:02 | <bwolfe> ok. any other questions? |
| 14:38:16 | <bwolfe> (before I adjourn this meeting) |
| 14:39:01 | <djazayeri> sounds like no |
| 14:39:04 | <bwolfe> guess not. talk to you guys later. I'll be on late tonight, but otherwise have a good weekend |
| 14:39:19 | * bwolfe wishes irc had a "typing" indicator like skype |
| 14:39:34 | <downeym> xmpp just released a standard for real-time typing |
| 14:40:20 | <bwolfe> irc != xmpp, does it? |
| 14:42:13 | <downeym> that's a tricky question actually |
| 14:42:33 | <downeym> there are gateways that do the translation |
| 14:43:46 | <bwolfe> alright... |
| 14:43:56 | <bwolfe> anyway. meeting over. back to work everyone |
| 15:10:28 | *** bwolfe has quit IRC |
| 15:19:19 | *** downeym sets mode: +v asgoyal |
| 15:44:54 | *** mandric has joined #openmrs |
| 16:00:15 | <rafa> djazayeri: Darius, the xml of htmlform is not clear enough to me to write safe code to replace uuids. |
| 16:01:18 | <rafa> djazayeri: Simple xml.replace(oldUuid, newUuid) is not an option. |
| 16:07:38 | <djazayeri> rafa: hmm, okay |
| 16:08:05 | <djazayeri> what's the ticket number for this? |
| 16:08:12 | <rafa> HTML-184 |
| 16:09:41 | *** gbastien has quit IRC |
| 16:10:39 | <djazayeri> so, a relevant method seems to be HtmlFormEntryUtil.replaceIdsWithUuids |
| 16:10:54 | <djazayeri> oh, wait, that's for export, we need import. |
| 16:11:14 | <rafa> djazayeri: well we could use that, but it's pretty complex |
| 16:11:17 | <rafa> djazayeri: lots of regex |
| 16:11:27 | <rafa> djazayeri: and it finds ids rather than uuids |
| 16:12:19 | <djazayeri> but the point is that there's a loop about AttributeDescriptor, which we can use to determine what class is relevant for each tag + attribute. |
| 16:13:01 | <djazayeri> I don't know if we'd do it using regex, or by building an xml dom or something (or maybe a streaming parser) |
| 16:14:06 | <djazayeri> for example ObsTagHandler has: AttributeDescriptor("conceptIds", Concept.class) |
| 16:15:34 | <djazayeri> so, by iterating over all taghandlers, and their attribute descriptors, we can build the reverse map, which is Class<? extends OpenmrsObject> -> (list of) "tag + attribute that could lead to that class" |
| 16:16:15 | <djazayeri> then iterate over the replacement map, and for each replaced item, find the list of tag+attribute we need to look at |
| 16:16:46 | <rafa> djazayeri: in replaceIdsWithUuidsHelper there are also handled some macros |
| 16:16:48 | <djazayeri> and then do uuid->uuid replacement there, either via regex, or by walking the xml dom |
| 16:18:43 | <djazayeri> Hmm... |
| 16:19:06 | <djazayeri> yes, so, if we do implement this, we should do a first-pass where we ignore macros, and then let mark deal with the macros |
| 16:19:22 | <djazayeri> alternately: why can't we just do replaceAll(oldUuid, newUuid)? |
| 16:19:37 | *** pascal` has joined #openmrs |
| 16:21:00 | *** surangak has joined #openmrs |
| 16:21:31 | <rafa> djazayeri: It might happen that we have oldUuid = "AAA" and in the xml there's some other "AAAA" uuid. The replacement will fail. |
| 16:22:05 | <djazayeri> but it will work fine if all uuids are actually 36 chars, right? |
| 16:22:23 | <rafa> djazayeri: Yes |
| 16:23:12 | <djazayeri> How about we iterate over all the replacements and check for this case. If we find it, we throw an exception saying we can't save this form. |
| 16:23:25 | <rafa> djazayeri: We could do that. |
| 16:23:30 | <djazayeri> If we don't find this case, just do an easy replaceAll |
| 16:23:53 | <djazayeri> that'll be quick to implement, and solve the 90+% use case |
| 16:24:04 | <djazayeri> mark can rewrite when he has time if he wants. |
| 16:24:09 | <rafa> djazayeri: Ok, I'll do that. |
| 16:24:41 | <rafa> djazayeri: How will we release this? |
| 16:25:58 | <djazayeri> you do that, I'll take care of releasing it. |
| 16:26:01 | <djazayeri> HFE, I mean. |
| 16:26:07 | <djazayeri> rather: you release MDS, I'll release HFE |
| 16:26:23 | <rafa> Ok |
| 16:26:48 | <rafa> MDS is out there already ;) |
| 16:26:56 | <djazayeri> on the module repo? |
| 16:27:00 | <rafa> yes |
| 16:27:03 | <djazayeri> and wiki pages? |
| 16:27:06 | <rafa> yes |
| 16:28:58 | <djazayeri> Okay, would you like to write a draft email, and we'll coordinate to "release" both on Monday? |
| 16:29:45 | <rafa> Sure, I'll write something over the weekend and send you :) |
| 16:30:02 | <djazayeri> cool |
| 16:30:13 | <djazayeri> can you do the replaceall implementation in HFE now? |
| 16:30:24 | <rafa> Yes, I'm doing it right now. |
| 16:31:10 | <djazayeri> actually, I may end up committing some changes to MDS, in the messages.properties file. |
| 16:31:24 | <djazayeri> perhaps you'd want to release 0.9.0.1 or something like that. |
| 16:31:28 | <djazayeri> I'll warn you if I do so |
| 16:32:30 | <rafa> djazayeri: Ok, just not all messages are in .properties. Many of them are still hardcoded. |
| 16:32:45 | <djazayeri> okay, well, regardless, I may fix some |
| 16:34:48 | <djazayeri> um, trying to import the Admission form you sent me yesterday with MDS 0.9 + HFE 1.7.2, and I get an error |
| 16:34:58 | <djazayeri> could not resolve property: name of: org.openmrs.module.htmlformentry.HtmlForm |
| 16:35:16 | <rafa> Please be sure that you run HFE 1.7.2 |
| 16:35:59 | <rafa> Maybe it's reset again. |
| 16:36:19 | <djazayeri> the manage modules page tells me it's your 1.7.2, but I'll try re-uploading to make sure |
| 16:37:01 | <djazayeri> that worked |
| 16:37:14 | <rafa> Cool. |
| 16:37:21 | <djazayeri> That bug is really annoying |
| 16:37:37 | <rafa> It's not necessarily a bug. |
| 16:37:45 | <djazayeri> That bug in core I mean. |
| 16:37:45 | *** lh has joined #openmrs |
| 16:38:01 | <rafa> If you run two versions of OpenMRS, they share modules. |
| 16:38:36 | *** surangak has quit IRC |
| 16:38:40 | <djazayeri> that's not the problem in this case |
| 16:38:57 | <rafa> Then it's bug :) |
| 16:39:09 | <djazayeri> I specifically looked for this, and it told me 1.7.2 was loaded. |
| 16:39:17 | <djazayeri> The only 1.7.2 I have anywhere is the one you sent me |
| 16:39:29 | <djazayeri> when it resets it resets to 1.7.3 |
| 16:39:43 | <djazayeri> anyway, the workaround will be to release this as HFE 1.7.4 |
| 16:41:36 | <djazayeri> hmm... |
| 16:42:16 | <djazayeri> I just realized why it isn't realizing that some incoming concept classes aren't identical to the ones I already have: |
| 16:42:38 | <djazayeri> incoming: Date modified: Mon Mar 01 21:00:00 PST 2004 |
| 16:42:39 | <djazayeri> existing: Date modified: 2004-03-02 00:00:00.0 |
| 16:43:07 | <djazayeri> Those are the same exact moment, but one is EST |
| 16:43:44 | <rafa> djazayeri: yes, it's a date problem. |
| 16:44:16 | <rafa> djazayeri: But clocks won't ever be accurate. |
| 16:44:47 | <djazayeri> this is OpenMRS core data though |
| 16:45:06 | <djazayeri> specifically the ConceptClass "Finding" |
| 16:46:08 | <djazayeri> from liquibase-core-data.xml: |
| 16:46:27 | <djazayeri> <insert tableName="concept_class"> |
| 16:46:27 | <djazayeri> ⦠|
| 16:46:27 | <djazayeri> <column name="name" value="Finding"/> |
| 16:46:27 | <djazayeri> ⦠|
| 16:46:27 | <djazayeri> <column name="date_created" valueDate="2004-03-02"/> |
| 16:47:43 | <rafa> djazayeri: Is it that big issue? |
| 16:48:09 | <djazayeri> well, it's going to be annoying |
| 16:48:50 | <djazayeri> I worry that it will confuse people and they won't feel confident if we're telling them we're overwriting core things |
| 16:50:24 | <rafa> If you overwrite once, the next time it should be keep mine. |
| 16:50:27 | <djazayeri> looking in the metadata.xml from that admissions.zip, I see: dateCreated id="29">2004-03-02 00:00:00.0 EST</dateCreated> |
| 16:50:56 | <djazayeri> (but if I import forms from multiple sources in different time zones, they'll keep fighting about it, right?) |
| 16:51:13 | <djazayeri> so, is it actually correct to include the timezone in our exported package? |
| 16:51:28 | <djazayeri> the database isn't storing date+timezone, it's just storing timezone |
| 16:51:34 | <djazayeri> um, I mean it's just storing date |
| 16:52:35 | <djazayeri> Can we just change the dateformat we're using for dates in exported packages to drop the timezone? |
| 16:53:06 | <rafa> We can do that. |
| 16:54:53 | <djazayeri> I recommend it. |
| 16:55:26 | <rafa> Are you sure time zones are not stored in sql timestamps? |
| 16:56:01 | <djazayeri> well, I just did a select date_created from ⦠and I get "2004-03-02 00:00:00" |
| 16:56:19 | <djazayeri> which matches what I see in the webapp for existing item |
| 16:58:03 | <djazayeri> certainly the way we're doing things in openmrs, we don't assume the db stores timezones. |
| 16:58:50 | *** cta has joined #openmrs |
| 16:58:55 | <cta> hello |
| 16:59:26 | <djazayeri> rafa: actually, we don't use sql timestamp, we use date and datetime, which don't store time zones |
| 17:00:28 | *** djazayeri has left #openmrs |
| 17:00:38 | *** djazayeri has joined #openmrs |
| 17:00:38 | *** ChanServ sets mode: +o djazayeri |
| 17:00:58 | <rafa> djazayeri: ok, I agree. We can discard timezones. |
| 17:02:47 | <cta> djazayeri: Darius, you remeber, you've left comment on review CR-MOD-212 (hl7 messages enquening) about why I'm extending IncomingHl7Message class from BaseOpenmrsData. I did that because I'm using its uuid property. Am I right? |
| 17:03:05 | <cta> remeber - > remember |
| 17:03:06 | <djazayeri> rafa: I just hit my first example where there's one matching existing item and it's autoselected. I *love* it |
| 17:04:00 | <djazayeri> cta: if the only purpose is to use the uuid propery, I would say do not extend the class, and declare your own uuid property |
| 17:04:27 | <djazayeri> because extending BaseOpenmrsData also adds a bunch of other properties. |
| 17:05:00 | <rafa> djazayeri: You had a good idea :) It's almost our awaited suggesting feature. |
| 17:05:26 | <cta> djazayeri: And uuid will be generated in this case also automatically, yes? |
| 17:05:28 | <djazayeri> rafa: still would be nice to have some sort of shading, or something, because when the choose existing sub-options are revealed, there's just a lot of words on that page, and no visual cues for separating them |
| 17:06:10 | <djazayeri> cta: not sure, don't remember. perhaps what you should do is just extends BaseOpenmrsObject instead of BaseOpenmrsData. |
| 17:06:29 | <rafa> djazayeri: I indented it and thought it was enough |
| 17:06:32 | <djazayeri> that has a uuid property, but not dateChanged, etc |
| 17:06:49 | <cta> djazayeri: Darius, I will try that. Thank you. |
| 17:07:19 | <djazayeri> rafa: it's definitely better. I don't think it's enough, but we can improve it in the next release |
| 17:08:05 | *** jwishnie has joined #openmrs |
| 17:10:09 | <cta> djazayeri: but in this case, when I'm extending BaseOpenmrsObject I can't use IncomingHl7Message class as generic parameter for DataDelegatingCrudResource<>. What I shoul do? |
| 17:10:33 | <djazayeri> cta: ah, I see. fine, just leave it as it is. |
| 17:11:12 | <cta> djazayeri: ok |
| 17:12:37 | <djazayeri> rafa, I notice that the Choose Replacement has a datatable that's larger than the dialog box it's in. So I need to scroll up and down each time I page. That's bad. Perhaps we can just use "infinite scrolling" instead of paging, assuming our version of datatables supports it. Should be trivial to implement. http://www.datatables.net/examples/basic_init/scroll_y_infinite.html |
| 17:12:44 | <OpenMRSBot> <http://ln-s.net/8yvu> (at www.datatables.net) |
| 17:14:07 | <rafa> djazayeri: It's a nice feature. I haven't seen that before. |
| 17:14:33 | <djazayeri> I just found a bug due to not escaping quotes, or something like that |
| 17:14:54 | <djazayeri> Maybe I'll make a list of these things, and email you all at once. |
| 17:15:30 | <rafa> djazayeri: Yes, email is better. |
| 17:17:52 | <cta> djazayeri: Darius, I fixed all your comments and commited code at rev:21425. Do I need to add just created changeset into existing review and resume it or you can close the ticket? |
| 17:18:32 | *** yanokwa has quit IRC |
| 17:19:42 | <djazayeri> just comment the revision number on the ticket. |
| 17:19:51 | <djazayeri> and ask to review the revision quickly |
| 17:26:29 | <cta> djazayeri: Done. Can you make review right now? |
| 17:26:50 | <djazayeri> cta: not this instant, no |
| 17:27:03 | <djazayeri> will do it later today |
| 17:27:17 | <cta> djazayeri: ok |
| 17:43:18 | *** mandric has quit IRC |
| 17:44:46 | *** mandric has joined #openmrs |
| 17:46:40 | *** rafa has quit IRC |
| 17:48:07 | *** asgoyal has quit IRC |
| 17:48:57 | *** mandric has quit IRC |
| 17:55:17 | *** mandric has joined #openmrs |
| 18:03:20 | *** r2friedman has joined #openmrs |
| 18:03:31 | <r2friedman> djazayeri: hi darius u there? |
| 18:03:39 | <djazayeri> yes |
| 18:03:56 | <r2friedman> djazayeri: please watch ben's recently created web service api pages for comments |
| 18:04:25 | <djazayeri> okay, do you have a link to the page offhand? |
| 18:05:26 | <r2friedman> https://wiki.openmrs.org/display/docs/REST+Web+Services+API?focusedCommentId=20383810&#comment-20383810 |
| 18:05:31 | <OpenMRSBot> <http://ln-s.net/8ywG> (at wiki.openmrs.org) |
| 18:06:01 | <r2friedman> https://tickets.openmrs.org/browse/RESTWS-161?focusedCommentId=171564#comment-171564 |
| 18:06:05 | <OpenMRSBot> <http://ln-s.net/8ywH> (at tickets.openmrs.org) |
| 18:07:46 | *** lh has quit IRC |
| 18:08:24 | *** yanokwa has joined #openmrs |
| 18:08:24 | *** ChanServ sets mode: +v yanokwa |
| 18:14:24 | *** gbastien has joined #openmrs |
| 18:14:27 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Unable to Save New Concept when OpenMRS is run in a JVM in Indonesia/French Locale - TRUNK-2424 <http://feedproxy.google.com/~r/OMRStrunk/~3/qniQMDZqeJU/OpenMRS> |
| 18:22:32 | *** r2friedman has quit IRC |
| 18:23:26 | *** james_regen has quit IRC |
| 18:28:54 | *** mandric_ has joined #openmrs |
| 18:31:21 | *** mandric has quit IRC |
| 18:31:40 | *** mandric has joined #openmrs |
| 18:36:47 | *** yanokwa has quit IRC |
| 18:37:23 | *** bwolfe has joined #openmrs |
| 18:37:23 | *** ChanServ sets mode: +o bwolfe |
| 18:38:44 | *** vchircu_ has quit IRC |
| 18:39:10 | *** Echidna has quit IRC |
| 18:41:34 | *** Echidna has joined #openmrs |
| 18:41:34 | *** ChanServ sets mode: +v Echidna |
| 18:52:53 | *** asgoyal has joined #openmrs |
| 18:58:10 | *** wyclif has quit IRC |
| 18:59:46 | *** wyclif has joined #openmrs |
| 19:04:56 | *** cta has quit IRC |
| 19:13:09 | *** bryq has joined #openmrs |
| 19:13:09 | *** ChanServ sets mode: +v bryq |
| 19:15:42 | *** jwishnie has quit IRC |
| 19:18:31 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting, Unable to Save New Concept when OpenMRS is run in a JVM in Indonesia/French Locale - TRUNK-2424 <http://feedproxy.google.com/~r/OMRStrunk/~3/bnW_KU7LidE/OpenMRS> |
| 19:24:39 | *** pascal` has quit IRC |
| 19:27:19 | <wyclif> djazayeri, bwolfe , looks like i can't reproduce the bug i ran into on the short patient form |
| 19:27:40 | <wyclif> i have tested it and it works fine for 1.8.x branch |
| 19:27:42 | <bwolfe> wyclif, was it a bug you saw or one reported? |
| 19:27:49 | <wyclif> i saw |
| 19:28:13 | <wyclif> i think i ran it againt wrong database or something |
| 19:28:29 | <wyclif> because at the time we were working on order entry |
| 19:29:41 | *** bryq has quit IRC |
| 19:29:54 | <bwolfe> wyclif, ok, well, there are a few other kinks that james has put into tickets |
| 19:29:58 | <bwolfe> those are more of an issue |
| 20:01:55 | *** lh has joined #openmrs |
| 20:20:01 | *** lh has quit IRC |
| 20:20:16 | *** lh has joined #openmrs |
| 20:28:44 | *** asgoyal has quit IRC |
| 20:33:18 | *** mandric has quit IRC |
| 21:02:27 | *** mandric has joined #openmrs |
| 21:30:41 | *** Echidna has quit IRC |
| 21:34:40 | *** Echidna has joined #openmrs |
| 21:34:40 | *** ChanServ sets mode: +v Echidna |
| 21:35:01 | *** yanokwa has joined #openmrs |
| 21:35:01 | *** ChanServ sets mode: +v yanokwa |
| 21:35:31 | <yanokwa> anyway to do basic or digest auth in openmrs? |
| 21:36:59 | <bwolfe> yanokwa, using just the webapp? |
| 21:37:05 | <bwolfe> or using a web service? |
| 21:38:10 | <yanokwa> er. i wanna auth the mobile phone to daniel's module using basic/digest |
| 21:39:19 | <bwolfe> I don't think you can. his servlet could set that up though |
| 21:39:45 | <bwolfe> you can auth by posting elsewhere and then passing in a the session id in the jsessionid cookie though |
| 21:40:30 | <yanokwa> sawa sawa. i think it's time to talk to daniel. |
| 21:40:44 | <downeym> bwolfe: still no subscription from sami |
| 21:41:14 | <bwolfe> downeym, no idea what he's doing |
| 21:42:00 | * downeym shrugs |
| 22:04:21 | *** gbastien has quit IRC |
| 22:05:13 | *** bwolfe has quit IRC |
| 22:26:27 | *** gbastien has joined #openmrs |
| 22:28:43 | *** downeym has quit IRC |
| 22:52:58 | <wyclif> djazayeri, are still planning to release 1.8.1 and WS module |
| 22:53:09 | <djazayeri> eh? |
| 22:53:14 | <djazayeri> I'm not planning to do anything. |
| 22:53:18 | <djazayeri> You and/or Ben will. Right? |
| 22:53:26 | <djazayeri> Or are you asking a different question? |
| 22:53:48 | <wyclif> probably i meant, are we supposed to do it today? |
| 22:53:54 | <wyclif> that is me and Ben |
| 22:54:09 | <djazayeri> No, we're committed to doing it by the end of _next_ week |
| 22:58:14 | <wyclif> ok |
| 23:02:38 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): review comments from CR-TRUNK-336 (added an @since) <http://feedproxy.google.com/~r/OMRStrunk/~3/zd4lzdxj4Ds/OpenMRS> |
| 23:05:58 | <wyclif> djazayeri, can you look at this ticket i have created https://tickets.openmrs.org/browse/TRUNK-2445 |
| 23:06:29 | <wyclif> i already have a patch for it, so i need some else to look at before i can commit the code |
| 23:20:52 | *** deadpool has joined #openmrs |