| 00:44:58 | *** mathiaslin has joined #openmrs |
| 01:44:00 | *** mandric has quit IRC |
| 01:49:00 | *** jwishnie has quit IRC |
| 02:06:01 | *** mandric has joined #openmrs |
| 02:14:36 | *** mandric has quit IRC |
| 02:56:14 | *** Mkop has joined #openmrs |
| 02:56:14 | *** ChanServ sets mode: +v Mkop |
| 02:56:56 | *** upul` has joined #openmrs |
| 02:56:56 | *** ChanServ sets mode: +v upul` |
| 03:16:38 | *** wyclif has joined #openmrs |
| 05:07:02 | *** Mkop has quit IRC |
| 05:36:21 | *** muthah has joined #openmrs |
| 05:43:48 | *** mandric has joined #openmrs |
| 05:58:03 | *** mandric has quit IRC |
| 06:01:07 | *** dkayiwa has joined #openmrs |
| 06:57:33 | *** pascal` has joined #openmrs |
| 06:58:51 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Trunk rev 21355 <http://feedproxy.google.com/~r/OMRStrunk/~3/q4qpo-m7rSk/OpenMRS> |
| 07:09:43 | *** dkayiwa has left #openmrs |
| 07:12:59 | *** ChanServ sets mode: +v pascal` |
| 07:16:25 | *** dkayiwa has joined #openmrs |
| 07:16:38 | *** bryq has joined #openmrs |
| 07:16:38 | *** ChanServ sets mode: +v bryq |
| 07:32:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating handlers to use constants <http://feedproxy.google.com/~r/OMRStrunk/~3/UZaIpRJ__Ss/OpenMRS> |
| 07:34:23 | *** muthah has quit IRC |
| 07:48:12 | *** bwolfe has joined #openmrs |
| 07:48:12 | *** ChanServ sets mode: +o bwolfe |
| 08:07:41 | <dkayiwa> Morning bwolfe |
| 08:09:09 | <dkayiwa> bwolfe: why does the user need to set the "webservices.rest.uriPrefix" global property? |
| 08:12:00 | *** rafa has joined #openmrs |
| 08:12:00 | *** ChanServ sets mode: +v rafa |
| 08:18:39 | *** pascal` has quit IRC |
| 08:38:58 | *** goutham has joined #openmrs |
| 08:39:38 | *** rafa has quit IRC |
| 08:41:22 | <bwolfe> dkayiwa, you mean instead of us determining it magically like you were doing? |
| 08:41:29 | <dkayiwa> yes |
| 08:41:38 | <dkayiwa> bwolfe |
| 08:42:04 | <bwolfe> two reasons: Its difficult to determine that at run time in in every location |
| 08:42:29 | <dkayiwa> non servlet locations? |
| 08:42:31 | <bwolfe> and because the user might be behind a proxy or have some other reason that the url that the server knows about is not the one that the clients use |
| 08:42:42 | <dkayiwa> oh i see!!!! |
| 09:03:10 | *** goutham has quit IRC |
| 09:17:09 | *** rafa has joined #openmrs |
| 09:17:09 | *** ChanServ sets mode: +v rafa |
| 09:53:11 | <dkayiwa> hi bwolfe |
| 09:53:16 | <bwolfe> hey |
| 09:54:45 | <dkayiwa> bwolfe: i need to call BaseDelegatingResource.newDelegate() from somewhere outside this class hierarchy. But this method is protected. Should i change it to public? |
| 09:55:14 | <dkayiwa> bwolfe: to be more specific, i want to call it from ResourceDocCreator |
| 09:57:53 | <bwolfe> why do you need to call it? |
| 09:58:17 | <bwolfe> are you using reflection when you'r etrying to call it? |
| 09:58:28 | <dkayiwa> no |
| 09:58:57 | <dkayiwa> bwolfe: i want to call BaseDelegatingResource.asRepresentation(T delegate, Representation representation) |
| 09:59:29 | <dkayiwa> bwolfe: in order to get the resource default, full, and ref representations |
| 10:00:18 | <bwolfe> hmm, if you were using reflection you could just set the method to be visible. :-) |
| 10:00:37 | <dkayiwa> so you are suggesting i use reflection? :) |
| 10:01:49 | <bwolfe> it'd be a quick way to get at it |
| 10:01:55 | <dkayiwa> ok |
| 10:01:57 | <bwolfe> class.getMethod("...") |
| 10:02:05 | <bwolfe> method.setVisible(true) |
| 10:02:09 | <bwolfe> (I think its setVisible) |
| 10:03:04 | <dkayiwa> my problem is a compile time error. so if i go the reflection route, i suppose wont even need to call setVisible |
| 10:03:15 | <dkayiwa> will just call it. :) |
| 10:03:22 | <bwolfe> you will |
| 10:03:38 | <dkayiwa> ok let me give it a shot |
| 10:41:39 | *** pascal` has joined #openmrs |
| 11:03:48 | *** surangak_ has quit IRC |
| 11:15:22 | *** bwolfe has quit IRC |
| 11:15:23 | *** bwolfe_ has joined #openmrs |
| 11:15:23 | *** ChanServ sets mode: +o bwolfe_ |
| 11:15:39 | *** mathiaslin has left #openmrs |
| 11:15:51 | *** upul` has quit IRC |
| 11:18:05 | *** james_regen has joined #openmrs |
| 11:18:05 | *** ChanServ sets mode: +v james_regen |
| 11:29:12 | *** dkayiwa has quit IRC |
| 11:32:04 | *** cta has joined #openmrs |
| 11:32:09 | <cta> hello |
| 11:42:40 | *** dkayiwa has joined #openmrs |
| 11:43:22 | *** jriley has joined #openmrs |
| 11:44:54 | *** asgoyal has joined #openmrs |
| 11:48:44 | *** dkayiwa has quit IRC |
| 11:56:34 | *** sreya has joined #openmrs |
| 11:56:42 | <sreya> hi all |
| 11:56:46 | <sreya> hey bwolfe_ |
| 11:57:06 | <sreya> i am using AOP for he messageSourceImple |
| 11:57:11 | <bwolfe_> sreya, ok, good |
| 11:57:17 | <bwolfe_> is it working? |
| 11:57:18 | *** bwolfe_ is now known as bwolfe |
| 11:57:29 | <sreya> well half way |
| 11:57:33 | <sreya> i mean |
| 11:57:44 | <sreya> i included this in my config.xml |
| 11:57:46 | <sreya> <advice> <point>org.openmrs.messagesource.MessageSourceService</point> <class>org.openmrs.module.databasemessages.advice.MessageProviderAroundAdvisor</class> </advice> |
| 11:58:24 | <sreya> so the AOP method is only getting called for getLocales |
| 11:59:01 | <sreya> how can this be possible while debugging i can seee the call goes through the service implementation |
| 11:59:13 | <sreya> but doesnt call my method |
| 12:00:15 | <sreya> bwolfe: look at my advisor http://pastebin.com/MMUE556V |
| 12:02:51 | <sreya> bwolfe: u there |
| 12:03:19 | <bwolfe> looks like a lot of methods are "getPresentation" |
| 12:04:00 | <bwolfe> I don't know why only one would be called |
| 12:04:04 | <bwolfe> errr, one method would be called |
| 12:04:31 | <sreya> yes |
| 12:04:55 | <sreya> but when you refresh the page getMessage is the one getting called |
| 12:05:10 | <sreya> now what do i do the advisor is not getting invoked |
| 12:05:17 | <sreya> i am going crazy with this |
| 12:05:22 | <sreya> :( |
| 12:08:09 | <bwolfe> sreya, try a before or an after advice |
| 12:08:12 | <bwolfe> see if that gets it called |
| 12:09:32 | <sreya> i tried before |
| 12:09:41 | <sreya> even that is not getting called |
| 12:10:00 | <sreya> it gets called for only one method that is getLocales |
| 12:10:14 | <bwolfe> strange |
| 12:10:22 | <bwolfe> if you add other custom methods to the service, do they get called? |
| 12:10:26 | <bwolfe> I'm not sure why the others wouldn't be |
| 12:10:45 | *** dkayiwa has joined #openmrs |
| 12:11:09 | <sreya> i did not try adding cusom methods |
| 12:11:43 | <sreya> should i try creating the custom methods in the service |
| 12:12:00 | *** bryq has quit IRC |
| 12:12:04 | <sreya> i will have to create a controller also to call thse methods from the service |
| 12:19:02 | <bwolfe> yes |
| 12:19:30 | <sreya> doing it |
| 12:28:08 | *** sreya has quit IRC |
| 12:37:24 | *** wyclif has quit IRC |
| 12:41:37 | *** srey has joined #openmrs |
| 12:53:28 | *** gbastien has joined #openmrs |
| 12:54:54 | *** srey has quit IRC |
| 12:58:06 | *** gbastien has quit IRC |
| 12:58:21 | *** downeym has joined #openmrs |
| 12:58:21 | *** OpenMRSBot sets mode: +o downeym |
| 12:58:21 | *** ChanServ sets mode: +o downeym |
| 13:10:42 | *** gbastien has joined #openmrs |
| 13:21:33 | *** gbastien has quit IRC |
| 13:21:36 | <pascal`> bwolfe, around? |
| 13:21:47 | <bwolfe> around where? |
| 13:22:14 | <pascal`> bwolfe, tomcat crashed, and now on a restart all I see is: Waiting for changelog lock.... |
| 13:22:18 | <pascal`> bwolfe, in the logs |
| 13:22:33 | <bwolfe> google that and you'll find your answer on our wiki |
| 13:22:37 | <pascal`> bwolfe, do you know what data i need to clear or what I need to do |
| 13:22:54 | <pascal`> kk |
| 13:23:28 | *** sreyakmit has joined #openmrs |
| 13:23:47 | <dkayiwa> :) |
| 13:24:45 | <downeym> FYI we have a google+ hangout going during the dev call today |
| 13:25:08 | <pascal`> cool |
| 13:29:09 | *** wyclif has joined #openmrs |
| 13:32:45 | <dkayiwa> hi bwolfe |
| 13:33:23 | <dkayiwa> bwolfe: which is the controller for PersonAttributeType ? |
| 13:34:39 | <bwolfe> um, not sure |
| 13:35:12 | <dkayiwa> bwolfe: i was getting urls off controllers. so that is why it has a null url |
| 13:37:11 | <bwolfe> perhaps its not fetchable by itself? (yet) |
| 13:38:37 | <bwolfe> wyclif, are you going to start the review for RESTWS=155 ? |
| 13:40:27 | <wyclif> bwolfe, if you see the last comment i added with the changest revision, there changes are very minor, |
| 13:40:36 | <sreyakmit> bwolfe: hey i created a method m1 in my service |
| 13:40:47 | <sreyakmit> and invoked it using a controller |
| 13:40:53 | <wyclif> so i dont think am creating a review for it |
| 13:41:02 | <sreyakmit> m1 methos in the messageSourceService |
| 13:41:03 | <bwolfe> wyclif, ok, but you have a draft review for it already... |
| 13:41:34 | <sreyakmit> n before , after advisor points are getting called for m1 |
| 13:41:57 | <bwolfe> hmm, strange |
| 13:42:04 | <bwolfe> so is there another aop around that class already? |
| 13:42:22 | <bwolfe> whats the stacktrace look like in that m1 method when you stop it in debug mode? |
| 13:42:22 | <sreyakmit> no i dont think so |
| 13:43:32 | <sreyakmit> form controller invokes ---->m1 |
| 13:43:46 | <sreyakmit> before advice point getting called |
| 13:43:53 | <sreyakmit> m1 executing |
| 13:44:01 | <sreyakmit> after advice point getting called |
| 13:44:19 | <wyclif> bwolfe, can you increase my privileges for the rest module? if you can |
| 13:44:35 | <bwolfe> hmm, can you be trusted? ;-) |
| 13:44:41 | <wyclif> i guess |
| 13:45:10 | <wyclif> i added a ticket but i couldnt change its status |
| 13:45:19 | <sreyakmit> me ?? |
| 13:46:27 | <sreyakmit> bwolfe: what should i do |
| 13:46:55 | <bwolfe> sreyakmit, was referring to wyclif |
| 13:47:08 | <bwolfe> sreyakmit, I'm not sure what else |
| 13:47:17 | <bwolfe> I would suggest looking at that jar saptarshi pointed you to |
| 13:47:35 | <bwolfe> that should have a configuration in it or in its documentation on how to use both it and normal messages.properites files |
| 13:48:08 | <wyclif> dkayiwa, are you working on https://tickets.openmrs.org/browse/RESTWS-113 |
| 13:48:24 | <wyclif> i can help you with it |
| 13:48:50 | <dkayiwa> wyclif: i had just started it. let me unassign myself from it |
| 13:48:59 | <dkayiwa> ok? |
| 13:49:03 | <wyclif> ok |
| 13:49:29 | <dkayiwa> wyclif: done. thanks :) |
| 13:50:05 | <wyclif> dkayiwa, thanks |
| 13:51:29 | <sreyakmit> hey bwolfe |
| 13:51:51 | <bwolfe> yes? |
| 13:52:35 | <sreyakmit> sorry i didnt read your earlier comment |
| 13:52:58 | <sreyakmit> but how is it possible that when the other methods are getting intercepted by the AOP |
| 13:53:05 | <sreyakmit> why not getMessages |
| 13:53:33 | *** jportela has joined #openmrs |
| 13:53:33 | *** ChanServ sets mode: +v jportela |
| 13:54:18 | <bwolfe> sreyakmit, if there is another aop around it done by the framework and that aop is not continuing the chain, then yours will not get called |
| 13:56:49 | <dkayiwa> bwolfe: "Can you list off other urls other than just the simple getters?" Where do i get these other urls from? |
| 13:57:23 | <bwolfe> controllers |
| 13:57:43 | <bwolfe> I guess just list the GET/POST/PURGE |
| 13:57:45 | *** asgoyal has quit IRC |
| 13:57:55 | <bwolfe> and then there are a few non normal getters (for patients I think) |
| 13:58:10 | <dkayiwa> bwolfe: the controller has something like @RequestMapping(value = "/rest/encountertype") |
| 13:58:59 | <bwolfe> and it has a method type |
| 13:59:11 | *** r-friedman has joined #openmrs |
| 13:59:13 | <downeym> !devmtg |
| 13:59:13 | <OpenMRSBot> downeym: "devmtg" --- Reminder: Developer meeting Thursday at 10:00 AM Eastern - http://wiki.openmrs.org/display/docs/Weekly+Developer+Meeting |
| 13:59:17 | <downeym> get in here :) |
| 13:59:47 | <bwolfe> nice hold music downeym |
| 14:02:01 | <downeym> djazayeri: you arond? |
| 14:03:02 | <djazayeri> yes |
| 14:03:05 | <djazayeri> just got on call |
| 14:03:10 | <djazayeri> downeym: ^^ |
| 14:03:17 | <djazayeri> can't hear talking though |
| 14:03:42 | *** r8friedman has joined #openmrs |
| 14:03:55 | <downeym> Hi r8friedman and welcome to the #openmrs IRC channel. |
| 14:04:16 | * bwolfe thinks its shaun grannis |
| 14:04:34 | *** sreyakmit has quit IRC |
| 14:04:57 | *** vchircu has joined #openmrs |
| 14:05:40 | *** r-friedman has quit IRC |
| 14:10:32 | *** r8friedman is now known as r-friedman |
| 14:11:05 | <cta> bwolfe: Ben, as for your comment on CR-MOD-212 (about enquing hl7 messages). Did you mean that I can remove all code from method _getRepresentationDescription()_ from Hl7SourceResorce class? right? |
| 14:11:13 | <r-friedman> downeym: i'm here but I can't talk today, skype not working nor connect audio |
| 14:11:22 | *** yanokwa has joined #openmrs |
| 14:11:22 | *** ChanServ sets mode: +v yanokwa |
| 14:11:35 | <downeym> r-friedman: 10-4 |
| 14:17:22 | <djazayeri> bwolfe: your code gives me "error trying to log in" |
| 14:17:48 | <bwolfe> in the logs? or as a popup? |
| 14:18:23 | <bwolfe> djazayeri, whats the error? |
| 14:19:11 | <djazayeri> bwolfe: as a popup. response status of 405 Method Not Allowed |
| 14:19:57 | <djazayeri> Request method 'GET' not supported |
| 14:20:01 | *** lh has joined #openmrs |
| 14:20:15 | <bwolfe> what url is it trying? |
| 14:20:26 | <djazayeri> GET http://localhost:8080/openmrs/ws/rest/session |
| 14:20:37 | <downeym> google hangout during the meeting: https://talkgadget.google.com/talkgadget/hangout/71d11caef6361782cdc4e31715f5db2dac4de4b1?authuser=0&hl=en-US# |
| 14:20:41 | <OpenMRSBot> <http://ln-s.net/8ygI> (at talkgadget.google.com) |
| 14:21:25 | <djazayeri> bwolfe: perhaps I need to update my restws module |
| 14:23:09 | *** downeym sets mode: +v dkayiwa |
| 14:23:13 | *** downeym sets mode: +v r-friedman |
| 14:23:17 | *** downeym sets mode: +v wyclif |
| 14:23:21 | *** downeym sets mode: +v vchircu |
| 14:23:26 | *** downeym sets mode: +v cta |
| 14:23:27 | <bwolfe> djazayeri, well, quick fix is to take that login call out. it is just a placeholder and you can still auth with the patient searches |
| 14:23:30 | *** downeym sets mode: +v pascal` |
| 14:24:43 | <r-friedman> downeym: what is the link for the wiki page for the new address hierarchy |
| 14:25:32 | <downeym> r-friedman: https://wiki.openmrs.org/display/docs/Address+Hierarchy+Module ? |
| 14:25:39 | <OpenMRSBot> <http://ln-s.net/8ygS> (at wiki.openmrs.org) |
| 14:25:50 | <r-friedman> tks |
| 14:26:18 | <djazayeri> bwolfe: commenting out openloginwindow doesn't help |
| 14:26:29 | <djazayeri> I then get a 401 unauthorized when I try to search for patients |
| 14:26:51 | <bwolfe> djazayeri, comment out RestClient:62 |
| 14:29:59 | <r-friedman> downeym: that page hasn't been edited in a year, I tried search without success before I asked |
| 14:30:03 | <bwolfe> djazayeri, I couldn't figure out (quickly) how to get the jar to send the basicauth creds without them being asked for. so the cookie/session stuff isn't in there :-/ |
| 14:30:22 | <downeym> r-friedman: last edited by Mark Goodrich on Jul 06, 2011 |
| 14:30:43 | <downeym> T-5 minutes for mark |
| 14:31:23 | <r-friedman> downeym: sorry, I had the wrong tab selected :-( |
| 14:31:29 | <downeym> r-friedman: no problem :) |
| 14:31:44 | <djazayeri> bwolfe: can't just comment that line |
| 14:31:46 | <djazayeri> the whole method? |
| 14:31:51 | <bwolfe> djazayeri, thats fine too |
| 14:33:05 | <djazayeri> bwolfe: good, works! |
| 14:38:44 | *** gbastien has joined #openmrs |
| 14:50:03 | <wyclif> bwolfe, djazayeri , there are some bugs that i see after backporting in 1.8.x |
| 14:50:16 | <wyclif> which are not in 1.8.0 |
| 14:50:25 | <djazayeri> what are they? |
| 14:50:52 | <wyclif> i think creating a patient either on the long or short form |
| 14:51:03 | <wyclif> i will cross check |
| 14:51:35 | <bwolfe> you mean ticketsA? |
| 14:58:25 | *** suho has joined #openmrs |
| 14:58:25 | *** ChanServ sets mode: +v suho |
| 15:09:29 | *** mandric has joined #openmrs |
| 15:25:48 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Awesome demo of new #OpenMRS web services happening right now by @djazayeri and @bawolfe - join us: http://bit.ly/rprkWO <http://twitter.com/OpenMRS/statuses/88980518217068545> |
| 15:46:41 | <suho> hi dkayiwa |
| 15:46:50 | <dkayiwa> hi suho |
| 15:47:01 | <suho> are you free now ? |
| 15:47:09 | <bwolfe> wyclif, you want to go first since the group around you probably wants to leave for lunch asap ? |
| 15:47:10 | <djazayeri> asgoyal_, bwolfe, dkayiwa, rafa, wyclif: quick scrum? |
| 15:47:16 | <djazayeri> ok |
| 15:47:21 | <djazayeri> go first wyclif |
| 15:47:30 | <wyclif> ok |
| 15:49:07 | <suho> dkayiwa, i need to discuss on deciding the way we are going to match critics |
| 15:49:23 | <suho> dkayiwa, let me know your convenient time |
| 15:49:25 | <dkayiwa> suho: lets talk after this scrum |
| 15:49:26 | <wyclif> yesterday: i worked on RESTWS-155, after a couple of hours trying all the suggested options, i got it fixed, created RESTWS-157 which i worked on, should commit the code |
| 15:49:49 | <suho> dkayiwa, ok great, please ping me |
| 15:49:54 | <dkayiwa> ok |
| 15:50:23 | <bwolfe> wyclif, put RESTWS-157 in the sprint 2 release |
| 15:50:36 | <bwolfe> (and update the desc to say 'subresource') |
| 15:50:54 | <wyclif> today: took RESTWS-113 from daniel, and i want to test if xml is bieng spit out if not i fix that too |
| 15:52:03 | <bwolfe> ok. do you have ideas for 113? |
| 15:53:07 | <wyclif> it is not yet clear to me about exactly what i have to print out |
| 15:53:45 | <wyclif> what is the significant difference between it and the one for the help page for the module in the web app |
| 15:54:18 | <bwolfe> you have to print out (or just return) any/all available resources. ideally you could then ask each of those resources what urls are available for it, but that might be a separate ticket |
| 15:54:59 | <wyclif> just the resources? |
| 15:55:43 | <wyclif> something like actual Openmrs object along with its resource? |
| 15:56:25 | <wyclif> if yes, then i have no blocker and am set |
| 15:56:31 | <wyclif> after lunch |
| 15:57:13 | <bwolfe> just hte resource, not the openmrsobject necessarily. (because there might be some objects registered that either don't have an object backing them and/or that object is not an OpenmrsObject) |
| 15:57:16 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.7.x): openmrs 1.7.x... <http://feedproxy.google.com/~r/OMRStrunk/~3/X-Wn8JrhWns/OpenMRS> |
| 15:57:18 | *** downeym has quit IRC |
| 15:57:25 | <wyclif> ok |
| 15:58:04 | <djazayeri> okay, next? |
| 15:58:15 | <dkayiwa> Finished working on RESTWS-114 according to its past review comments. Started working on RESTWS-148 and created a wiki page with the automatically generated output. Now working on its JIRA comments from Ben. DONE |
| 15:59:13 | <djazayeri> Yesterday: |
| 15:59:13 | <djazayeri> * Design call |
| 15:59:13 | <djazayeri> * Built WS demo app |
| 15:59:13 | <djazayeri> * A bit of code review |
| 15:59:13 | <djazayeri> * Helped Wyclif look into a WS bug |
| 15:59:14 | <djazayeri> Today: |
| 15:59:15 | <djazayeri> * Review Rafal's MDS module (sorry I didn't do this yesterday) |
| 15:59:15 | <djazayeri> * Prep for UI sprint |
| 15:59:16 | <djazayeri> no blockers |
| 15:59:36 | <rafa> djazayeri: np ;) |
| 15:59:53 | <bwolfe> djazayeri, there are two tickets assigned to you in the sprint now |
| 15:59:57 | <bwolfe> one I think we are closing/punting |
| 16:00:11 | <bwolfe> the other appears to be more of a cleanup issue? |
| 16:00:38 | <djazayeri> bwolfe: I'll do them. |
| 16:00:40 | <bwolfe> dkayiwa, ok, sounds good |
| 16:00:45 | <dkayiwa> ok |
| 16:00:53 | <bwolfe> ok |
| 16:00:57 | <djazayeri> one is refactoring, the other is the one I wanted to punt, but I can do your suggestion for it |
| 16:01:21 | <djazayeri> alternately I can look into Roger's proposal if you want |
| 16:01:23 | <wyclif> am off for the group lunch |
| 16:01:27 | <djazayeri> but you create a ticket for that and decide. |
| 16:01:43 | <bwolfe> I created the ticket for Roger's suggestion. its in the "needs assessment" stage. |
| 16:01:49 | <djazayeri> (I'm only very-part-time on this sprint) |
| 16:02:05 | <bwolfe> if you want to do a mini spike on that it'd be helpful. |
| 16:02:19 | <bwolfe> yes, understandable. only take it on if it looks like you have time. |
| 16:03:04 | <bwolfe> me: ws client app, ws reviews, ws ticket creation, dev call, another call later tonight. |
| 16:03:24 | <bwolfe> I'm going to focus on getting the docs in order and making sure a 1.8.1 release is ready. |
| 16:04:00 | <bwolfe> wyclif, do you want to do the 1.8.1 stuff, or do you want me to? I seem to be the defacto maintenance releaser...which is fine if we're only doing it every 6 months like the last one. :-) |
| 16:04:32 | <dkayiwa> :D |
| 16:04:44 | <bwolfe> looks like wyclif left for lunch already |
| 16:04:48 | <bwolfe> I'll ping him separately |
| 16:04:54 | <dkayiwa> He was very hungry. :) |
| 16:05:06 | <bwolfe> apparnetly |
| 16:05:12 | <bwolfe> asgoyal_? |
| 16:05:49 | <bwolfe> dkayiwa, they all drive/walk together in Indianapolis ot lunch on Thursday. so it was probably jkeiper that was hungry and he pushed the group out the door. :-) |
| 16:06:01 | <dkayiwa> lollllllllll |
| 16:06:10 | <dkayiwa> i can remember that very well :D |
| 16:06:12 | <djazayeri> not sure asgoyal_ is here |
| 16:06:21 | <rafa> Ok my turn, today: Finished testing metadatasharing, am cleaning up the code and writing documentation. Tomorrow: Release the module. Start working on WS tickets (will ping Ben when I'm ready for something). No blockers. |
| 16:06:59 | <bwolfe> rafa, great |
| 16:07:45 | <rafa> bwolfe: or you can find me one already |
| 16:08:20 | <rafa> Hopefully, Darius won't have much objections to meta ;) |
| 16:08:21 | <bwolfe> rafa, I'll assign one to you if I see one. if one isn't assigned to you tmrw when you're done, ping me |
| 16:08:44 | <rafa> bwolfe: sure |
| 16:09:02 | <bwolfe> ok, time for a late dinner for me. talk to you guys later |
| 16:09:25 | <djazayeri> rafa: I'll load up your module and check it out now |
| 16:11:30 | <djazayeri> should I use the omod you sent me, or build from svn? |
| 16:11:35 | <djazayeri> rafa: ^^ |
| 16:14:15 | *** bwolfe has quit IRC |
| 16:14:25 | <rafa> djazayeri: SVN is better |
| 16:16:51 | <rafa> djazayeri: please watch out for sqldiff, I adjusted it for the release. |
| 16:17:18 | <djazayeri> what do you mean "watch out"? |
| 16:17:43 | <rafa> djazayeri: your tables might not be updated |
| 16:18:15 | *** dkayiwa has left #openmrs |
| 16:18:30 | <djazayeri> rafa: you mean you edited an existing sqldiff change? |
| 16:20:02 | <rafa> djazayeri: just try and see if you have errors |
| 16:20:09 | <djazayeri> ok |
| 16:20:38 | <rafa> djazayeri: I changed existing sqldiff for development, but now it's the way it should be to upgrade from 0.8.x |
| 16:20:49 | <djazayeri> okay, makes sense |
| 16:27:55 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: PatientDashboard modification module <http://forum.openmrs.org/viewtopic.php?f=8&t=793#p2994> |
| 16:29:08 | <djazayeri> rafa: I get an xstream ConversionException when trying to import the HAS form |
| 16:29:10 | <djazayeri> on the first page |
| 16:29:21 | <djazayeri> I'm running 1.8.x, so maybe that's the problem, but that'd be unfortunate. |
| 16:29:45 | <rafa> Do you use the htmlformentrymodule I sent you? |
| 16:29:48 | <djazayeri> Yes |
| 16:30:01 | <rafa> And the form as well? |
| 16:30:07 | <djazayeri> yes |
| 16:30:12 | <rafa> What does it say exactly? |
| 16:30:19 | <djazayeri> on the Admission form I get: Element dependencies of type java.util.HashSet is not defined as field in type org.openmrs.module.htmlformentry.HtmlForm |
| 16:30:40 | <rafa> Then you're not running the correct version of htmlformentry |
| 16:30:40 | <djazayeri> on the Lab form I get the same. |
| 16:30:54 | <rafa> Maybe. I sent you a wrong one ;) |
| 16:31:08 | <djazayeri> hmm, it says 1.7.2 (and I manually downloaded from 1.7.3 that I was running) |
| 16:33:12 | <djazayeri> oh, wait, maybe it's my mistake |
| 16:33:27 | <djazayeri> when I switched from trunk to 1.8 it might have reverted to the bundled htmlformentry |
| 16:33:54 | <rafa> djazayeri: in any case I sent you the right htmlformentry again |
| 16:35:21 | <djazayeri> SQLGrammarException |
| 16:35:26 | <djazayeri> rafa: perhaps the sqldiff issue? |
| 16:35:31 | <rafa> djazayeri: for sure |
| 16:35:33 | <djazayeri> should I drop tables and restart? |
| 16:35:48 | <djazayeri> (and reset the database_version GP) |
| 16:35:57 | <rafa> yes, should work |
| 16:36:05 | <rafa> btw how to do the reset? |
| 16:36:20 | <rafa> I couldn't find that one. |
| 16:36:42 | <djazayeri> delete from global_property where property = 'metadatasharing.database_version' |
| 16:36:58 | <rafa> cool thanks |
| 16:37:43 | <rafa> djazayeri: I think I've fixed has lab since yesterday. |
| 16:37:53 | <rafa> djazayeri: There were some extra validation errors. |
| 16:38:34 | <djazayeri> so I need the new versions of the forms you sent me today? |
| 16:38:36 | <rafa> djazayeri: so I sent you these forms once again. |
| 16:40:29 | <rafa> djazayeri: btw it would be cool, if we had htmlformentry that actually has the onSave method working. |
| 16:40:53 | <rafa> djazayeri: I can try to figure that out and replace uuids. |
| 16:41:27 | <djazayeri> Maybe contact mark by email/skype and see what needs to be done |
| 16:41:31 | <djazayeri> would be worthwhile |
| 16:41:59 | <rafa> djazayeri: I left him a comment in JIRA. |
| 16:43:00 | <djazayeri> rafa: I get a SQLGrammarException |
| 16:43:01 | *** bryq has joined #openmrs |
| 16:43:01 | *** ChanServ sets mode: +v bryq |
| 16:43:16 | <djazayeri> but it's: Unknown column 'this_.template' in 'field list' |
| 16:43:38 | <djazayeri> oh, I know, it's that I'm using a trunk database where that column was removed from the form table |
| 16:43:40 | <rafa> djazayeri: it says nothing to me |
| 16:43:51 | <rafa> djazayeri: oh ok |
| 16:44:03 | <djazayeri> grr, annoying, okay, I'll try to set up a separate 1.8.x database then |
| 16:44:30 | <djazayeri> anybody know if there's a param I'd pass to jetty:run to tell it to deploy the war with a different url? |
| 16:44:32 | <rafa> djazayeri: indeed. |
| 16:44:42 | <djazayeri> I mean: as /openmrs18 instead of /openmrs? |
| 16:46:57 | <rafa> there's the webapp.name property in webapp\pom.xml, it's worth trying. |
| 16:48:26 | <rafa> if it works, then there's a way to overwrite it from the cmd |
| 16:49:11 | <rafa> djazayeri: |
| 16:49:44 | <djazayeri> thx, I edited that in pom.xml, and it appears to work |
| 16:50:26 | <rafa> adding "-Dwebapp.name=openmrs18" should work as well |
| 16:53:46 | <djazayeri> got NPE importing Admission form |
| 16:54:11 | <djazayeri> at org.openmrs.module.metadatasharing.model.validator.PackageValidator.validateForWarnings(PackageValidator.java:31) |
| 16:54:27 | <djazayeri> do I need to svn update my 1.8.x code to get your recent fix rafa? |
| 16:54:39 | <rafa> yes |
| 16:54:54 | <rafa> I mean it committed it 2-3 days ago |
| 17:00:53 | <rafa> djazayeri: You made me doubt. I'm installing 1.8 :) |
| 17:01:09 | <djazayeri> I hadn't done svn update though |
| 17:04:12 | <djazayeri> rafa: still got the NPE at PackageValidator:31 |
| 17:04:15 | <djazayeri> gotta run for a bit |
| 17:04:32 | <rafa> djazayeri: OK, I'll check it out. |
| 17:05:25 | <rafa> djazayeri: you're right. It's not working in 1.8 :/ |
| 17:06:39 | <rafa> djazayeri: looks like OpenmrsConstants.OPENMRS_VERSION is null |
| 17:07:12 | *** jportela has left #openmrs |
| 17:08:45 | *** Suranga has joined #openmrs |
| 17:09:11 | <djazayeri> A quick fix for the module? |
| 17:09:43 | <rafa> djazayeri: We won't check version... |
| 17:10:16 | <djazayeri> or just ignore if it's null. |
| 17:10:21 | <rafa> djazayeri: if it's null of course ;) |
| 17:10:22 | <rafa> right |
| 17:10:23 | <djazayeri> (was this non-null in 1.6 and 1.7? |
| 17:10:28 | <rafa> yes |
| 17:10:29 | <rafa> worked fine |
| 17:10:40 | <djazayeri> hmm, okay, we should follow up on why it's null in 1.8 |
| 17:10:58 | <rafa> how to run jetty in debug? |
| 17:11:32 | <djazayeri> in eclipse, just do "debug as" or "debug configurations" |
| 17:11:43 | <djazayeri> you can use the same run configuraion, but under the debugger |
| 17:11:48 | <djazayeri> i.e. you don't have to _do_ anything |
| 17:12:08 | <rafa> ok thanks |
| 17:17:23 | <rafa> djazayeri: it might be a problem with running jetty from mvn |
| 17:17:32 | <rafa> djazayeri: I'll test it on tomcat |
| 17:23:54 | <rafa> djazayeri: Confirm. It's just an issue with jetty. It works fine on tomcat. |
| 17:24:25 | <rafa> djazayeri: Probably it's even just an issue when it's run on jetty from mvn. |
| 17:25:33 | <rafa> djazayeri: Anyway, I disabled version checking, if the constant is null. It's committed to trunk. |
| 17:26:56 | <rafa> djazayeri: Okay, I need to go. |
| 17:28:44 | *** rafa has quit IRC |
| 17:32:08 | *** gbastien has quit IRC |
| 17:34:02 | *** asgoyal has joined #openmrs |
| 17:34:18 | <Suranga> gentlemen, |
| 17:34:21 | <Suranga> let me try to put this shortly |
| 17:34:29 | <Suranga> I have just made some changes that break existing service layer methods |
| 17:34:40 | <Suranga> so I should ideally delete these methods (they are not needed any more anyway) instead of trying to depricate them, right ? |
| 17:35:22 | <Suranga> because if I depricate, and someone tries to use them, it'll go 'craaash' :-) |
| 17:36:34 | <djazayeri> Suranga: what method, for example? |
| 17:38:02 | <Suranga> hi, djazayeri for example, i dont need registerhandler(key...) any more |
| 17:38:02 | <Suranga> etc. |
| 17:38:02 | <Suranga> djazayeri, or unregisterhandler(...) |
| 17:38:02 | <Suranga> djazayeri, these are based on changes i made to obsserviceimple layer... |
| 17:38:51 | <djazayeri> the idea is that you should mark the method as @deprecated, and make the ObsServiceImpl method just return null or do nothing |
| 17:39:07 | <djazayeri> it shouldn't crash, but modules that incidentally call that method should still be able to compile |
| 17:40:04 | <Suranga> ah djazayeri excellent.... |
| 17:40:04 | <Suranga> djazayeri, i will do it that way... |
| 17:40:05 | <Suranga> thanks |
| 17:46:52 | *** cta has quit IRC |
| 17:56:14 | <bryq> Hi djazayeri, are you around? |
| 17:56:29 | <djazayeri> yes |
| 17:58:19 | <djazayeri> bryq: yes |
| 17:59:57 | *** lh has quit IRC |
| 18:00:04 | <bryq> djazayeri: I've got a question. When I create a URL mapping in a controller and try to access it, it always want from me an ".form", ".list", ... extension |
| 18:00:10 | <bryq> djazayeri: How to ommit it? |
| 18:00:26 | <bryq> djazayeri: I want to create RESTful links |
| 18:00:47 | <djazayeri> Starting in 1.8.x, I believe that for anything under /ws you can omit the .list and .form |
| 18:00:49 | <bryq> djazayeri: I.e /ws/rest/meta/abc (without e.g. ".form") |
| 18:01:05 | <djazayeri> but that didn't happen till 1.8 I think |
| 18:01:24 | <djazayeri> How about if you use .json or .xml |
| 18:01:35 | <bryq> djazayeri: In 1.6 it doesn't work |
| 18:01:39 | <djazayeri> still non-ideal, but better than .list/.form |
| 18:02:02 | *** Suranga has quit IRC |
| 18:02:26 | <djazayeri> hmm, actually, in 1.6 your only options are .list, .form, and .htm |
| 18:02:40 | <bryq> djazayeri: It doesn't accept .xml |
| 18:02:49 | <djazayeri> and it's defined in web.xml, so you can't change that. |
| 18:02:53 | <bryq> djazayeri: Is there any way to change it? |
| 18:02:55 | <djazayeri> just go with .form |
| 18:03:02 | <bryq> djazayeri: Yes, I'll use .htm |
| 18:03:16 | <bryq> djazayeri: Ooops |
| 18:03:18 | <djazayeri> it's possible that .htm is handled specially and bypasses controllers |
| 18:03:28 | <djazayeri> I'd say just go with .form, even though it's ugly. |
| 18:03:31 | <bryq> djazayeri: Okay |
| 18:03:37 | *** gbastien has joined #openmrs |
| 18:07:35 | *** asgoyal has quit IRC |
| 18:07:56 | *** bwolfe has joined #openmrs |
| 18:07:56 | *** ChanServ sets mode: +o bwolfe |
| 18:20:24 | *** rafa has joined #openmrs |
| 18:20:24 | *** ChanServ sets mode: +v rafa |
| 18:20:38 | <djazayeri> rafa, I'm writing you another novel of comments |
| 18:20:42 | <djazayeri> mostly they should be easy though |
| 18:21:27 | <rafa> djazayeri: I'm curious |
| 18:23:37 | *** lh has joined #openmrs |
| 18:24:26 | *** downeym has joined #openmrs |
| 18:24:26 | *** ChanServ sets mode: +o downeym |
| 18:24:26 | *** OpenMRSBot sets mode: +o downeym |
| 18:28:14 | <djazayeri> rafa why would it be the case that I'm importing and I see Create/Skip/Choose Existing options, but it defaults to Skip, and fails when I try to choose Create New? |
| 18:28:26 | <djazayeri> this just happened for 3 concepts in a row, but not others. |
| 18:29:26 | <rafa> djazayeri: Incoming must be failing validation. Create New should be disabled though with an explanation next to it. |
| 18:29:46 | <rafa> djazayeri: If it's not the case, I need to look into it once again. |
| 18:29:50 | <djazayeri> I saw that work several times, but in this case that's not the issue |
| 18:29:57 | <djazayeri> I mean: it's not showing me a validation warning |
| 18:30:39 | <rafa> djazayeri: please send me the exception you get then |
| 18:31:08 | <rafa> djazayeri: It's not a feature we want ;) |
| 18:32:03 | <djazayeri> http://pastebin.com/1u45XsKg |
| 18:33:40 | <rafa> djazayeri: It is definitely failing validation. Maybe the message returned by ValidateUtil is null, thus it's not displayed and create new is not grayed out. |
| 18:34:02 | *** jwishnie has joined #openmrs |
| 18:34:10 | <djazayeri> okay, need to follow up |
| 18:55:22 | <djazayeri> rafa: email sent |
| 18:55:47 | <djazayeri> I really like it. I was able to go through the whole thing quite quickly. |
| 18:55:58 | <djazayeri> Just need a few small bugfixes and cosmetic changes. |
| 18:56:22 | <rafa> djazayeri: ok thanks! Will look into it tomorrow. |
| 18:56:53 | <djazayeri> cool |
| 19:08:39 | *** cta has joined #openmrs |
| 19:15:43 | *** mandric has quit IRC |
| 19:17:15 | *** dkayiwa has joined #openmrs |
| 19:24:05 | *** suho has quit IRC |
| 19:36:24 | *** suho has joined #openmrs |
| 19:36:24 | *** ChanServ sets mode: +v suho |
| 19:48:29 | *** rafa has quit IRC |
| 19:53:10 | *** james_regen has quit IRC |
| 20:14:12 | *** bwolfe has quit IRC |
| 20:15:18 | *** Echidna has quit IRC |
| 20:18:57 | *** jriley has quit IRC |
| 20:19:36 | *** Echidna has joined #openmrs |
| 20:19:38 | *** ChanServ sets mode: +v Echidna |
| 20:25:15 | *** bryq has quit IRC |
| 20:47:29 | *** dkayiwa has quit IRC |
| 20:50:51 | <cta> bye guys |
| 20:51:18 | *** cta has quit IRC |
| 21:00:40 | *** mandric has joined #openmrs |
| 21:02:00 | *** gbastien has quit IRC |
| 21:49:05 | *** downeym has quit IRC |
| 22:23:28 | *** mandric has quit IRC |
| 22:23:40 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @techne_labs: Helped a public health volunteer with setup of OpenMRS. Fun to look at Apache Tomcat for old times sake. <http://twitter.com/OpenMRS/statuses/89090767930404864> |
| 22:53:53 | *** wyclif has quit IRC |
| 23:20:57 | *** downeym has joined #openmrs |
| 23:20:57 | *** OpenMRSBot sets mode: +o downeym |
| 23:20:57 | *** ChanServ sets mode: +o downeym |
| 23:40:13 | *** jriley has joined #openmrs |
| 23:40:40 | *** jriley has left #openmrs |
| 23:58:24 | *** Echidna has quit IRC |