| 00:14:51 | *** gbastien has quit IRC |
| 00:28:39 | *** mandric has joined #openmrs |
| 01:34:30 | *** yanokwa has quit IRC |
| 01:57:21 | *** yanokwa has joined #openmrs |
| 01:57:21 | *** ChanServ sets mode: +v yanokwa |
| 02:11:48 | <djazayeri> guduji: are you actively working on TRUNK-2193? |
| 02:12:00 | <guduji> yes |
| 02:12:08 | <djazayeri> okay |
| 02:12:12 | <guduji> will start from tomorrow though |
| 02:12:41 | <guduji> today i need to do some documentation for the work that i have done so far |
| 02:13:02 | <guduji> plus some apptest if possible |
| 03:28:46 | *** vchircu has joined #openmrs |
| 03:33:07 | *** Adee has joined #openmrs |
| 03:33:31 | <Adee> hi all.... |
| 03:33:39 | <Adee> i need help in the maven installation |
| 03:33:43 | <Adee> anybody there |
| 03:34:44 | <Adee> Help please |
| 03:35:13 | <chopin> Adee, what's up |
| 03:38:43 | <Adee> i need help in maven installation |
| 03:38:59 | <Adee> when i am trying the command mvn install |
| 03:39:10 | <Adee> some connection timed out error |
| 03:39:15 | <Adee> unable to get resource |
| 03:39:23 | <Adee> there is not much help that i got till now |
| 03:39:42 | <chopin> Adee, you have to be online to pull resources |
| 03:39:55 | <chopin> maven lets us specify them for download instead of including them in the svn checkout (like before) |
| 03:40:10 | <chopin> so until you can download all dependencies, you will be unable to install |
| 03:40:14 | <chopin> :( |
| 03:40:41 | <Adee> i am being online... |
| 03:41:10 | <Adee> after downloading maven from the url... |
| 03:41:21 | <Adee> what all configuration changes do we need to do? |
| 03:41:39 | <chopin> "unable to get resource" usually means that it could not download something |
| 03:41:57 | <Adee> ya...that is what i am not sure |
| 03:42:03 | <Adee> i have an internet connection.. |
| 03:42:10 | <chopin> ok |
| 03:42:28 | <Adee> what do we do after unzipping the files .. |
| 03:42:36 | <chopin> watch the output ... you may be having connectivity problems with one of the resources |
| 03:42:36 | <Adee> i tried mvn --version |
| 03:42:40 | <Adee> it worked fine |
| 03:42:44 | <chopin> right |
| 03:42:53 | <Adee> ya. |
| 03:42:56 | <chopin> you should be doing "mvn clean install" |
| 03:43:05 | <chopin> from the openmrs checkout |
| 03:43:11 | <Adee> ok..let me try that as well |
| 03:43:13 | <chopin> ok |
| 03:43:17 | <chopin> sorry, gotta run ... gl |
| 03:43:48 | <Adee> kk |
| 03:46:51 | *** mandric has quit IRC |
| 03:49:08 | <Adee> TEXT must be immediately followed by END_TAG and not START_TAG (position: START_TAG seen ...< pluginGroup>\r\n\t <groupId>... @11:12) |
| 03:49:15 | <Adee> this is the new error |
| 03:49:31 | <Adee> after some changes in the settings.xml file and the pom.xml file |
| 03:50:01 | <Adee> any help |
| 03:50:03 | *** mandric has joined #openmrs |
| 03:50:31 | *** Adee is now known as hge |
| 03:52:13 | *** upul` has joined #openmrs |
| 03:52:13 | *** ChanServ sets mode: +v upul` |
| 03:55:16 | *** surangak has joined #openmrs |
| 03:56:18 | *** mandric has quit IRC |
| 04:00:33 | *** mandric has joined #openmrs |
| 04:02:08 | <hge> there? |
| 04:04:48 | *** hge has quit IRC |
| 04:07:53 | <surangak> djazayeri, hi, dont know if u r still here |
| 04:08:30 | <surangak> djazayeri, i just saw your response to my mail, i just added a small clarification, so if you are still here, itll be great if u could take a look :-) |
| 04:11:02 | *** surangak_ has joined #openmrs |
| 04:13:05 | *** robbyoconnor has quit IRC |
| 04:15:29 | *** mccallumg has joined #openmrs |
| 04:15:29 | *** ChanServ sets mode: +v mccallumg |
| 04:17:03 | <mccallumg> hey surangak: sorry I'm late |
| 04:18:02 | <mccallumg> hey surangak_ |
| 04:18:15 | <surangak_> mccallumg, hellooo |
| 04:18:22 | <surangak_> mccallumg, hows it going ? |
| 04:18:33 | <mccallumg> surangak_: sorry I'm late. I just got home. |
| 04:18:45 | <surangak_> mccallumg, no problem at all... |
| 04:19:41 | <mccallumg> surangak_: I'm just going through your sheet of tips. |
| 04:20:19 | <surangak_> mccallumg, no problem, take your time, its 9.49 am my time, so I wont be going away anytime soon... :) |
| 04:23:46 | <surangak_> mccallumg, let me know if you run into any issues - usually setting up the environment can be harder than the dev work sometimes ... |
| 04:26:49 | <mccallumg> surangak_: you're just trying to make me good. I'm going to start check-out again from the beginning. |
| 04:27:16 | <surangak_> mccallumg, does the folder structure look ok to you ? |
| 04:27:58 | <surangak_> mccallumg, there are 5 modules + root ? |
| 04:28:15 | <mccallumg> surangak_: yes. 5 modules. not in the same order as yours. |
| 04:28:32 | <surangak_> mccallumg, api is above, right ? |
| 04:28:44 | <mccallumg> surangak_: yes |
| 04:28:53 | <surangak_> mccallumg, lets run through the steps as you go along the process... |
| 04:29:12 | <surangak_> mccallumg, tell me each step as u go, and ill replicate... |
| 04:29:36 | <mccallumg> surangak_: no tests are failing... |
| 04:30:19 | <surangak_> mccallumg, did u get the check out ? ran it already ? |
| 04:31:47 | <mccallumg> I'm looking at your screenshot. You're using external maven installation. |
| 04:32:02 | <mccallumg> surangak_: I'm trying with embedded |
| 04:32:17 | <surangak_> mccallumg, aha... but you do have an external one, right ? |
| 04:32:37 | <mccallumg> surangak_: no. it is messed up on the mac. |
| 04:32:58 | <surangak_> mccallumg, still, i dont think the embeded maven should be a problem |
| 04:33:28 | <surangak_> mccallumg, but if the api module is above everything else, i guess a new check out is the way to go |
| 04:33:56 | <surangak_> mccallumg, im thinking that copy pasting the jar will fix your problem, but on the long run.. it will bring problems... |
| 04:34:20 | <mccallumg> surangak_: https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers |
| 04:34:21 | <OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org) |
| 04:34:47 | <mccallumg> surangak_: subclipse doesn't work well on non-windows installations |
| 04:35:06 | <mccallumg> surangak_: I'm using svnkit |
| 04:35:13 | <surangak_> mccallumg, ooops |
| 04:36:18 | <surangak_> mccallumg, maybe if we were to use an external tool to check out the code instead of going through the ide ? |
| 04:36:20 | <mccallumg> surangak_: well. I can't say for sure that it doesn't work well. But I had to do a weird installation process. Now I'm having problems with dependencies. Maybe I should try without subclipse. |
| 04:36:29 | <mccallumg> surangak_: good idea :) |
| 04:36:57 | <surangak_> mccallumg, not very sure if there is an mac os version for tortoise though.. |
| 04:37:46 | <surangak_> mccallumg, so im thinking that your problem is caused becoz the checkout is not working properly, that is is due to a problem with how the tools work on mac.. |
| 04:37:58 | <mccallumg> surangak_: there are a couple I use. http://versionsapp.com/, http://www.syntevo.com/smartsvn/index.html |
| 04:39:34 | *** robbyoconnor has joined #openmrs |
| 04:39:40 | *** robbyoconnor has joined #openmrs |
| 04:39:40 | *** ChanServ sets mode: +v robbyoconnor |
| 04:40:23 | *** chopin has quit IRC |
| 04:40:47 | *** robbyoconnor has quit IRC |
| 04:41:13 | *** robbyoconnor has joined #openmrs |
| 04:41:13 | *** ChanServ sets mode: +v robbyoconnor |
| 04:41:19 | <surangak_> mccallumg, are u going ahead with one of these tools ? |
| 04:41:29 | <mccallumg> surangak_: yes. just doing it now |
| 04:44:40 | *** Adee has joined #openmrs |
| 04:44:45 | <Adee> hey all |
| 04:44:55 | <Adee> help in maven |
| 04:44:58 | <Adee> anybod |
| 04:45:01 | <Adee> anybody? |
| 04:45:54 | <surangak_> hello |
| 04:46:00 | <surangak_> ill try to help.. |
| 04:49:46 | <Adee> when i try mvn install |
| 04:49:55 | <Adee> download from the site |
| 04:50:02 | <Adee> mvn 2.2.1 |
| 04:50:13 | <Adee> it shows the following |
| 04:50:39 | <Adee> Cannot execute mojo: resources. It requires a project with an existing pom.xml but the build is not using one. |
| 04:51:16 | <mccallumg> Adee: are you working in eclipse? |
| 04:51:36 | <Adee> no from cmd |
| 04:52:17 | <mccallumg> Adee which version of openmrs are you using? |
| 04:52:44 | <Adee> i just downloaded apache maven 2.2.1 |
| 04:52:47 | <Adee> nothing else |
| 04:52:57 | <Adee> set the env variables |
| 04:53:07 | <surangak_> that basically means u r truing to run a project that is not maven based |
| 04:53:15 | <mccallumg> Adee: are you trying to build maven or openmrs? |
| 04:53:21 | <Adee> maven |
| 04:53:32 | <Adee> any thing would help |
| 04:53:42 | <surangak_> are u using windows |
| 04:53:43 | <surangak_> ? |
| 04:53:46 | <Adee> yes |
| 04:54:04 | <Adee> i just want the libraries for the HL7 protocol |
| 04:54:13 | <surangak_> then go to cmd, and type sion of openmrs are you using? |
| 04:54:32 | <surangak_> sorry, i meant, go to cmd, and type mvn --version |
| 04:54:38 | <surangak_> what does it give u ? |
| 04:54:41 | <Adee> i did that |
| 04:54:49 | <surangak_> does that show? |
| 04:54:49 | <Adee> it is showing normal result |
| 04:54:55 | <Adee> ya |
| 04:54:58 | <Adee> version and all |
| 04:55:00 | <Adee> stuff |
| 04:55:08 | <surangak_> where are you trying to run maven from , may i ask ? |
| 04:55:43 | <Adee> i didnt get ? |
| 04:56:02 | <surangak_> u r executing that clean install command from ? |
| 04:56:18 | <Adee> cmd |
| 04:56:30 | <surangak_> i mean, what folder r u in ? |
| 04:56:44 | <Adee> apache maven 2.2.1/bin |
| 04:56:57 | <surangak_> ah, afraid thats not how it works |
| 04:57:06 | <surangak_> have u got an openmrs trunk somewhere ? |
| 04:57:19 | <Adee> no.. |
| 04:57:19 | <surangak_> u need to navigate into that via cmd and then run the command |
| 04:57:41 | <Adee> i am new to this.. |
| 04:57:49 | <surangak_> as in, u can run that only is there is a pom.xml file in the folder |
| 04:57:50 | <Adee> this is the error |
| 04:57:54 | <mccallumg> Adee: you need to download openmrs before you can build it |
| 04:58:00 | <Adee> ok..] |
| 04:58:03 | <Adee> url please |
| 04:58:14 | <mccallumg> Adee: https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers |
| 04:58:15 | <OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org) |
| 04:58:35 | <surangak_> yep, i think it'll be easy if u folow that, it has a lot of steps |
| 04:59:19 | <Adee> ok.. |
| 04:59:24 | <surangak_> let me also promote this article from my blog :) |
| 04:59:25 | <surangak_> http://surangakas.wordpress.com/2011/05/29/openmrs-top-problems-beginners-may-face/ |
| 04:59:32 | <surangak_> its on maven mostly |
| 04:59:41 | <Adee> what about the open mrs trunk that you were talking about? |
| 05:00:24 | <surangak_> thats the code, basially.. in the wiki they'll show a lonk for u to download it to eclipse |
| 05:01:37 | *** mandric has quit IRC |
| 05:01:58 | <surangak_> mccallumg, any luck checking out with that tool ? |
| 05:02:24 | <mccallumg> surangak_: doing the whole setup without IDE now. had the ObsValidationTest failure. Added the @Ignore line. |
| 05:02:33 | <mccallumg> surangak_: just re-running maven |
| 05:02:55 | <surangak_> mccallumg, great, ill be focussing on the test errors for the next few days |
| 05:03:24 | <surangak_> mccallumg, ill give you a detailed report on what test were fixed, and what are outstanding |
| 05:03:40 | <mccallumg> surangak_: alright |
| 05:04:43 | <Adee> thnx all |
| 05:05:04 | <surangak_> no problem, just wondering, where are u from ? your time zone ? |
| 05:06:11 | *** robbyoconnor has quit IRC |
| 05:13:19 | *** guduji has quit IRC |
| 05:13:53 | <mccallumg> Adee: where are you? Nigeria? |
| 05:16:12 | <mccallumg> surangak_: Running org.openmrs.validator.ObsValidatorTest |
| 05:16:12 | <mccallumg> WARN - ConceptServiceImpl.setBooleanConcepts(1520) |2011-07-05 21:49:47,823| Concept ids for boolean concepts should be numbers |
| 05:16:13 | <mccallumg> WARN - ConceptServiceImpl.setBooleanConcepts(1520) |2011-07-05 21:49:47,830| Concept ids for boolean concepts should be numbers |
| 05:16:13 | <mccallumg> WARN - ConceptServiceImpl.setBooleanConcepts(1520) |2011-07-05 21:49:47,832| Concept ids for boolean concepts should be numbers |
| 05:16:13 | <mccallumg> WARN - ConceptServiceImpl.setBooleanConcepts(1520) |2011-07-05 21:49:47,834| Concept ids for boolean concepts should be numbers |
| 05:16:13 | <mccallumg> Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.373 sec <<< FAILURE! |
| 05:16:43 | <mccallumg> surangak_: failure here. but it doesn't tell me which method... |
| 05:17:19 | <surangak_> mccallumg, aha, yes, let me check that |
| 05:17:26 | <surangak_> mccallumg, give me a minute plz |
| 05:17:50 | <mccallumg> surangak_: sure. I'm just glad that I'm getting different problems now. |
| 05:18:36 | <surangak_> mccallumg, pretty soon we will make a developer out of you again :) |
| 05:19:24 | <mccallumg> surangak_: Hey. I'm making a comeback. I did some python scripting today! |
| 05:19:56 | <surangak_> mccallumg, wow, im totally new to that... |
| 05:19:58 | *** Adee has quit IRC |
| 05:20:44 | <surangak_> mccallumg, for now can u do this, go to obsvalidator class |
| 05:20:55 | <surangak_> and uncomment line 121 |
| 05:21:26 | <surangak_> mccallumg, i will give an detailed explanation on this once i clean up on the unit tests... |
| 05:22:53 | <mccallumg> surangak_: can you paste the line into irc? |
| 05:23:16 | <surangak_> mccallumg, else if (obs.getValueBoolean() == null && obs.getValueCoded() == null && obs.getValueCodedName() == null |
| 05:23:16 | <surangak_> && obs.getValueComplex() == null && obs.getValueDatetime() == null && obs.getValueDrug() == null |
| 05:23:16 | <surangak_> && obs.getValueModifier() == null && obs.getValueNumeric() == null && obs.getValueText() == null) { |
| 05:23:16 | <surangak_> //errors.reject("error.noValue"); |
| 05:23:16 | <surangak_> } |
| 05:24:54 | <mccallumg> surangak_: so just uncomment the last line? |
| 05:25:10 | <surangak_> mccallumg, yep, that should fix the obsvalidator faliure |
| 05:25:30 | <surangak_> mccallumg, this represents one of my more importaints // to dos for unit tests :( |
| 05:25:42 | <mccallumg> surangak_: mvn clean install |
| 05:26:09 | <surangak_> mccallumg, yep... first time apparently u need to run all the test |
| 05:28:36 | <surangak_> mccallumg, hi |
| 05:28:49 | <surangak_> terribly sorry, but looks like u will need to do @idnore |
| 05:29:30 | <mccallumg> surangak_: I've done it on a couple of tests already. |
| 05:29:31 | <surangak_> mccallumg, seems i was wrong, in obsvalidatorTest, do @Ignore to public void validate_shouldFailIfObsHasNoValuesAndNotParent() |
| 05:30:03 | <surangak_> mccallumg, how many , exactly ? to me its only two i think... |
| 05:32:13 | <mccallumg> surangak_: yeah. two. |
| 05:33:02 | <surangak_> mccallumg, i ment to make tests my priority from now, but based on Dariuses's response to yesterdays mail, i will need an extra day or so :P |
| 05:36:43 | *** wyclif has quit IRC |
| 05:40:46 | <surangak_> mccallumg, was it successful this time :) |
| 05:41:30 | <mccallumg> surangak_: No. it is being cryptic. |
| 05:41:41 | <surangak_> mccallumg, what does it say ? |
| 05:41:46 | <surangak_> mccallumg, the final result ? |
| 05:41:56 | <mccallumg> surangak_: well it tells me there is an error. But it doesn't tell me where. |
| 05:42:12 | <surangak_> can u paste the entire message |
| 05:42:14 | <mccallumg> surangak_: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.5:test (default-test) on project openmrs-api: There are test failures. |
| 05:42:19 | <djazayeri> surangak_: is your question to me still relevant? |
| 05:42:28 | <djazayeri> from an hour ago? or is it what I replied to via email? |
| 05:42:36 | <mccallumg> surangak_: Tests run: 1699, Failures: 0, Errors: 5, Skipped: 25 |
| 05:42:42 | <surangak_> djazayeri, hi your reply solved it, thanks |
| 05:42:49 | <surangak_> djazayeri, ill work it that way... |
| 05:43:03 | <djazayeri> okay. |
| 05:43:05 | *** gauravpaliwal has joined #openmrs |
| 05:43:05 | *** ChanServ sets mode: +v gauravpaliwal |
| 05:43:32 | <surangak_> the errors wil come from the obsservicetest.java |
| 05:43:43 | <surangak_> but it builds successfully, doesnt it ? |
| 05:44:33 | <surangak_> mccallumg, ah, it says faliures :0 the the error says that there are error messages.... |
| 05:44:47 | <gauravpaliwal> djazayeri: Hi |
| 05:44:57 | <mccallumg> surangak_: [INFO] Reactor Summary: |
| 05:44:57 | <mccallumg> [INFO] |
| 05:44:57 | <mccallumg> [INFO] OpenMRS ........................................... SUCCESS [1.645s] |
| 05:44:57 | <mccallumg> [INFO] openmrs-tools ..................................... SUCCESS [1.974s] |
| 05:44:58 | <mccallumg> [INFO] openmrs-test ...................................... SUCCESS [0.010s] |
| 05:44:58 | <mccallumg> [INFO] openmrs-api ....................................... FAILURE [3:43.470s] |
| 05:44:58 | <mccallumg> [INFO] openmrs-web ....................................... SKIPPED |
| 05:44:58 | <mccallumg> [INFO] openmrs-webapp .................................... SKIPPED |
| 05:45:37 | <mccallumg> surangak_: errors should halt the build should they? |
| 05:45:45 | <mccallumg> surangak_: _shouldn't |
| 05:46:21 | <surangak_> mccallumg, im suprised that it says faliures :0 but then says 'there are test faliures |
| 05:46:31 | <surangak_> mccallumg, yes, u r right |
| 05:46:58 | <mccallumg> surangak_: it is weird. I'll let you share my screen another night. i'm heading to bed. Thanks for your help. |
| 05:47:07 | <surangak_> mccallumg, i think djazayeri has gone off for the night |
| 05:47:15 | <surangak_> maybe we could get him to help later |
| 05:47:29 | <surangak_> mccallumg, or just lets copy paste my jar :) |
| 05:54:34 | *** mccallumg has quit IRC |
| 06:02:04 | *** yanokwa has quit IRC |
| 06:02:08 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision no. 21270 of trunk <http://feedproxy.google.com/~r/OMRStrunk/~3/1iA5in7k150/OpenMRS> |
| 06:14:56 | *** gauravpaliwal has left #openmrs |
| 06:19:14 | *** Echidna has quit IRC |
| 06:32:46 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Reverting Back Changes from Revision, sync problems <http://feedproxy.google.com/~r/OMRStrunk/~3/VhxFsWIoGyE/OpenMRS> |
| 06:41:23 | *** pascal` has joined #openmrs |
| 06:41:41 | *** dkayiwa has joined #openmrs |
| 07:03:44 | *** ChanServ sets mode: +v pascal` |
| 07:17:00 | *** bryq has joined #openmrs |
| 07:17:00 | *** ChanServ sets mode: +v bryq |
| 07:26:59 | <surangak_> dkayiwa, helo, r u around |
| 07:27:04 | <dkayiwa> yes |
| 07:27:15 | <surangak_> dkayiwa, need to ask u a question |
| 07:27:20 | <dkayiwa> ok |
| 07:27:33 | <surangak_> dkayiwa, earlier on, we decided to use constants in each handler class |
| 07:27:41 | <dkayiwa> ok |
| 07:28:13 | <surangak_> but now i realized that sometimes we call handlers using an interface, such that the interface does not know of the constant, |
| 07:28:20 | <surangak_> so it wont let us call the constant |
| 07:28:34 | <surangak_> did u understand what i ment ? |
| 07:28:56 | <dkayiwa> do you mean that the interface does not see the class and you get compiler errors? |
| 07:29:04 | <surangak_> as in, assume child class has constant |
| 07:29:13 | <surangak_> chaild class extends interface |
| 07:29:24 | <surangak_> now i have the interface, and need to call the constant |
| 07:29:36 | <surangak_> unless i downcast, i dont see how im able to do that.... |
| 07:30:17 | <dkayiwa> are the constants static and public? |
| 07:30:47 | <surangak_> yep |
| 07:31:17 | <surangak_> but it does not know, becoz i dont downcast... |
| 07:31:30 | <dkayiwa> why doesnt the interface just do ClassName.constantsName? |
| 07:32:20 | <surangak_> im working with a list of objects that impliment the same interfac |
| 07:32:33 | <surangak_> so im refering to them via the interface... |
| 07:32:44 | <dkayiwa> how about putting the constants on the interface? |
| 07:33:21 | <surangak_> mmm... but then i would need to put in several |
| 07:33:48 | <surangak_> as in, different implimenting classes need different constant values, im afraid... |
| 07:34:07 | <surangak_> class1 impliments interface A and needs constant A |
| 07:34:23 | <surangak_> class2 impliments interface A BUT need constant B |
| 07:34:29 | <dkayiwa> how about having a separate class for just constants |
| 07:34:42 | <dkayiwa> the way we have OpenmrsConstants |
| 07:34:57 | <surangak_> aha, and put them all in there ? |
| 07:35:02 | <dkayiwa> yes |
| 07:35:22 | <surangak_> but umm.. how would we allocated the constant to each class... |
| 07:35:53 | <dkayiwa> arent the constant values fixed at compile time? |
| 07:36:17 | <surangak_> dkayiwa, sorry, did not get you.... |
| 07:36:43 | <dkayiwa> give me an example of a declaration for such a constant |
| 07:38:06 | <surangak_> in PatientHandler class, i have public static final string HANDLER_TYPE ="PatientHandler" |
| 07:38:43 | <surangak_> so in patientHandler class, should I instead say public string = MY_CONSTANTS.PATINET_HANDLER_TYPE ? |
| 07:39:12 | <surangak_> and in MY_CONSTANTS class have PATIENT_HANDLER_TYPE = "patienthandler" |
| 07:41:57 | <surangak_> dkayiwa, but doing that, im afraid i dont see how to make the interface aware of the constant, without casting... |
| 07:42:32 | <dkayiwa> if the constants are static and public, is there any class which cannot see them? |
| 07:42:39 | <dkayiwa> maybe am not getting you well |
| 07:43:21 | <surangak_> dkayiwa, but im calling them via the interface, so interface does now know of it right ? |
| 07:44:13 | <surangak_> as in lets assume that PatientHandler impliments interfaceA |
| 07:44:26 | <surangak_> and patientHandler has constant value set |
| 07:44:55 | <surangak_> dkayiwa, but since im using the interface. to call the method, it does now know of it... |
| 07:45:31 | <dkayiwa> ok |
| 07:46:18 | <dkayiwa> are you commiting this code any where? may be i need to look at it |
| 07:46:47 | <surangak_> dkayiwa i have not comitted yet... but maybe i could screenshare |
| 07:48:44 | <dkayiwa> yes |
| 07:49:45 | <surangak_> im on connect. |
| 07:51:27 | <dkayiwa> ok let me go there |
| 07:53:24 | <dkayiwa> am there as d |
| 07:56:01 | <surangak_> now im on imagehandler class ? |
| 07:57:11 | <dkayiwa> your screen went off |
| 07:57:27 | <surangak_> dkayiwa, hi, now ? |
| 07:57:48 | <dkayiwa> now i see it |
| 07:57:53 | <surangak_> great |
| 07:58:00 | <surangak_> dkayiwa, see, my clas is |
| 07:58:17 | <surangak_> imagehandler impliments complexObshandler interface |
| 07:58:34 | <surangak_> i have HANDLER_TYPE constant |
| 07:58:35 | <dkayiwa> can u talk on connect? |
| 07:59:32 | <surangak_> hi, can u hear me now ? |
| 07:59:38 | <surangak_> im with mic |
| 07:59:57 | <dkayiwa> no |
| 08:00:31 | <surangak_> still no ? |
| 08:00:37 | <dkayiwa> i heard hello |
| 08:02:06 | <surangak_> still no ? |
| 08:02:12 | <surangak_> i dont hear u at all |
| 08:02:17 | <dkayiwa> i only hear hello |
| 08:02:21 | <dkayiwa> ok you can just type |
| 08:02:29 | <surangak_> verry sorry |
| 08:02:48 | <surangak_> mm.. i have like i said, patient handler which extends complex obshandler |
| 08:03:11 | <surangak_> earlier patienthandler had a string variable called handlerCOnfig, with getter setters |
| 08:03:11 | <dkayiwa> ok |
| 08:03:32 | <surangak_> now im working with a bunch of similar handlers that all extend complexobshandler |
| 08:03:47 | <surangak_> so what i did was, define a gethandlercongif() method in the interface |
| 08:04:13 | <surangak_> so when working with a list i can say complexobshandler c |
| 08:04:20 | <surangak_> c.gethandlerType() |
| 08:04:23 | <surangak_> and that would work |
| 08:04:40 | <surangak_> becoz the interface was aware of the get handler config method defined in the interface |
| 08:05:01 | <surangak_> but since i moved tp constants, there are no set get methods in child class or interface, |
| 08:05:32 | <surangak_> so no way to tell class that it knows of a constant called handler Type |
| 08:06:37 | <surangak_> rry sorry |
| 08:06:38 | <surangak_> <surangak_> mm.. i have like i said, patient handler which extends complex obshandler |
| 08:06:38 | <surangak_> <surangak_> earlier patienthandler had a string variable called handlerCOnfig, with getter setters |
| 08:06:38 | <surangak_> <dkayiwa> ok |
| 08:06:38 | <surangak_> <surangak_> now im working with a bunch of similar handlers that all extend complexobshandler |
| 08:06:38 | <surangak_> <surangak_> so what i did was, define a gethandlercongif() method in the interface |
| 08:06:40 | <surangak_> <surangak_> so when working with a list i can say complexobshandler c |
| 08:06:42 | <surangak_> <surangak_> c.gethandlerType() |
| 08:06:44 | <surangak_> <surangak_> and that would work |
| 08:06:46 | <surangak_> <surangak_> becoz the interface was aware of the get handler config method defined in the interface |
| 08:06:48 | <surangak_> <surangak_> but since i moved tp constants, there are no set get methods in child class or interface, |
| 08:06:50 | <surangak_> <surangak_> so no way to tell class that it knows of a constant called handler Type |
| 08:06:58 | <surangak_> wooops, sorry, wrong copies message |
| 08:07:00 | <dkayiwa> is that a module? |
| 08:07:09 | <dkayiwa> or openmrs trunk? |
| 08:07:10 | <surangak_> no, im working on obs actually |
| 08:07:12 | <surangak_> yep |
| 08:07:15 | <surangak_> trunk |
| 08:07:15 | <dkayiwa> where do you commit? |
| 08:07:24 | <dkayiwa> are you working on a branch? |
| 08:07:29 | <surangak_> to a branch, yes |
| 08:07:47 | <dkayiwa> can u commit and i have a look |
| 08:08:05 | <surangak_> can i use pastebin or something instead ? |
| 08:08:13 | <surangak_> would that be ok :) |
| 08:09:55 | <dkayiwa> ok |
| 08:18:45 | <surangak_> dkayiwa, hi, ive pasted at http://pastebin.com/gNZnNkJw |
| 08:18:55 | <dkayiwa> ok |
| 08:18:55 | <surangak_> dkayiwa, this is a greeeeeeeeeeeeet help :) |
| 08:19:26 | <dkayiwa> so what next? |
| 08:19:36 | <surangak_> dkayiwa, sory, didnt get you ? |
| 08:19:43 | <dkayiwa> see the class |
| 08:19:45 | <dkayiwa> and now? |
| 08:20:10 | <surangak_> dkayiwa, im wondering, i mean, how to make the interface award that it has a constant |
| 08:21:39 | <dkayiwa> why dont you just do PatientHandler.HANDLER_TYPE ? |
| 08:23:06 | <dkayiwa> oh now i get you |
| 08:23:34 | <dkayiwa> what do you want to use that handler type value for? |
| 08:27:01 | <dkayiwa> surangak_ are u there? |
| 08:49:36 | <surangak_> dkayiwa, really sorry, we had scrum meeting over here :P |
| 08:49:46 | <surangak_> dkayiwa, r u still there ? |
| 08:50:08 | <dkayiwa> yes |
| 08:50:16 | *** rafa has joined #openmrs |
| 08:50:16 | *** ChanServ sets mode: +v rafa |
| 08:50:24 | <surangak_> basically the handler type is rellt importaint |
| 08:50:34 | <surangak_> its for me to identify class types |
| 08:50:44 | <dkayiwa> why dont you have the handlers register themselves? |
| 08:51:09 | <surangak_> dkayiwa, i do, but several handler classes may belong to same type |
| 08:51:29 | <dkayiwa> then you need register one. not so? |
| 08:51:32 | <surangak_> for example, Imagehandler and webimagehandler both exist, but i need to get only the one with the higher priority |
| 08:51:46 | <surangak_> mm.. i register both , then select the higher priority |
| 08:51:55 | <surangak_> thats how it works with @component im afraid... |
| 08:52:24 | <dkayiwa> how about the registration method checking and only replace if of higher priority |
| 08:53:11 | <surangak_> aha, but to do that, i still need the handler type |
| 08:53:39 | <dkayiwa> why not add the gethandler type to the interface? |
| 08:53:41 | <surangak_> for example, see how many classes have handlertype = patientHandler, then check which has top priority out of these |
| 08:54:09 | <surangak_> and then have a gethandler method in the patienthnalder also, and have that return the constant in each ? |
| 08:54:15 | <dkayiwa> yes |
| 08:54:21 | <surangak_> dkayiwa, hmm... that will be the only way to do it |
| 08:54:29 | <surangak_> dkayiwa, ya i agree |
| 08:54:52 | <dkayiwa> another alternative is the registerhandler to also take the priority param |
| 08:55:15 | <dkayiwa> then it knows when to replace |
| 08:55:21 | <dkayiwa> and when not to |
| 08:55:29 | <surangak_> dkayiwa, let me look into that also |
| 08:55:34 | <dkayiwa> ok |
| 08:55:37 | <surangak_> dkayiwa, you took a lot of trouble over this |
| 08:55:41 | <surangak_> thanks a lot for everything |
| 08:55:46 | <dkayiwa> lollll |
| 08:56:03 | <surangak_> basically, i was muddled up because it was, ya know design decision... |
| 08:56:19 | <dkayiwa> :) |
| 08:56:40 | <surangak_> dkayiwa, i will do this your way... |
| 08:56:45 | <dkayiwa> hahahah |
| 08:56:50 | <dkayiwa> our way. :) |
| 09:10:58 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: New information?? <http://forum.openmrs.org/viewtopic.php?f=2&t=792#p2992> |
| 09:53:16 | *** Echidna has joined #openmrs |
| 09:53:16 | *** ChanServ sets mode: +v Echidna |
| 10:07:04 | *** goutham has joined #openmrs |
| 10:17:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: New information?? <http://forum.openmrs.org/viewtopic.php?f=2&t=792#p2993> |
| 10:30:51 | *** bwolfe_ has joined #openmrs |
| 10:30:51 | *** ChanServ sets mode: +o bwolfe_ |
| 11:07:07 | *** cta has joined #openmrs |
| 11:07:13 | <cta> hello |
| 11:11:43 | <bwolfe_> hi cta |
| 11:16:25 | <cta> bwolfe_: Hi, Ben. I have a question about implementing GET and DELETE operation for hl7 messages. So, currently, for implement them we need to have _getByUniqueId()_ method for fetching different kinds of hl7 messages (e.g. inqueue, archive, error). But that method will be probably implemented within 1.9 version. And since we are using for rest-ws module Openmrs 1.8.1, it goes that these (GET, DELETE) operations won't be implemented for now. Am I right? |
| 11:16:58 | <bwolfe_> you are right |
| 11:17:00 | *** bwolfe_ is now known as bwolfe |
| 11:17:37 | <cta> bwolfe: Thank you, Ben. |
| 11:17:40 | *** surangak has quit IRC |
| 11:32:43 | *** upul` has quit IRC |
| 11:39:10 | *** james_regen has joined #openmrs |
| 11:39:10 | *** ChanServ sets mode: +v james_regen |
| 11:44:41 | *** downeym has joined #openmrs |
| 11:44:41 | *** ChanServ sets mode: +o downeym |
| 11:44:41 | *** OpenMRSBot sets mode: +o downeym |
| 11:53:15 | *** goutham has quit IRC |
| 11:58:13 | *** jriley has joined #openmrs |
| 12:42:25 | *** chopin has joined #openmrs |
| 12:44:45 | *** muthah has joined #openmrs |
| 13:10:59 | *** chopin has quit IRC |
| 13:12:25 | *** gbastien has joined #openmrs |
| 13:17:41 | *** gbastien has quit IRC |
| 13:30:13 | *** gbastien has joined #openmrs |
| 13:37:46 | *** muthah has quit IRC |
| 13:46:23 | *** dkayiwa has quit IRC |
| 13:54:55 | *** mathiaslin has joined #openmrs |
| 14:00:48 | *** dkayiwa has joined #openmrs |
| 14:04:03 | <djazayeri> hi |
| 14:04:09 | <bwolfe> good morning/afternoon/evening developers |
| 14:04:43 | <bwolfe> looks like we're missing wyclif |
| 14:05:05 | <rafa> hi! |
| 14:05:13 | <bwolfe> hey raffle |
| 14:05:14 | <bwolfe> :-D |
| 14:05:21 | <downeym> missing wyclif? Never |
| 14:05:30 | <bwolfe> heh |
| 14:05:57 | <rafa> bwolfe: I've got no idea where you found that? :P |
| 14:06:13 | <djazayeri> I made a typo yesterda |
| 14:06:22 | *** wyclif has joined #openmrs |
| 14:06:25 | <djazayeri> yesterday. (and obviously today too) |
| 14:06:27 | <wyclif> hi |
| 14:06:35 | <rafa> I see |
| 14:06:41 | <djazayeri> hopefully it doesn't stick forever. |
| 14:07:04 | <bwolfe> I like it. I'm going to try my best to make it stick :-D |
| 14:07:09 | <bwolfe> welcome wyclif |
| 14:07:26 | <bwolfe> wyclif, since you're hte last one here, how about you start today's round of reviews? |
| 14:07:36 | <rafa> bwolfe: hehe please don't do that :P |
| 14:07:36 | <wyclif> ok |
| 14:07:46 | <djazayeri> just call him bwolef until he stops |
| 14:08:20 | <wyclif> Fixed ConcepNameResource(TRUNK-131)issue, did TRUNK-149, TRUNK150 |
| 14:08:51 | <wyclif> Today: i picked up RESTWS-153 |
| 14:08:58 | <wyclif> and should pick up more |
| 14:09:06 | <djazayeri> were TRUNK-149 and TRUNK-150 related to web services? |
| 14:09:08 | <bwolfe> djazayeri, should be bwoffle I think to match :-) |
| 14:09:17 | <djazayeri> or bwaffle |
| 14:09:33 | <wyclif> sorry RESTWS-149 an 150, yes |
| 14:09:46 | <rafa> bwaffle the best one :D |
| 14:10:34 | <bwolfe> wyclif, ok. any blockers? is 153 your only task right now? |
| 14:11:23 | <wyclif> i just picked it up, no blockers yest, note that our day here is just starting |
| 14:11:57 | <bwolfe> I know. I just meant is it the only thing you will be focusing on? |
| 14:12:09 | <djazayeri> bwolfe: let's create a specific ticket about handling dates, rather than repeatedly re-opening/closing RESTWS-146 |
| 14:12:10 | <wyclif> hope not |
| 14:12:46 | <bwolfe> djazayeri, go for it |
| 14:12:46 | <wyclif> but it seems like it might require slighly more time since the tests are for all resources |
| 14:13:04 | <bwolfe> wyclif, so your answer is "yes" ?? |
| 14:13:23 | <djazayeri> wyclif: why that ticket in particular, and not one of the open MUST tickets? |
| 14:13:41 | <bwolfe> isn't that a must ticket too? |
| 14:13:41 | *** asgoyal has joined #openmrs |
| 14:13:42 | <wyclif> then i would rather start with the musts |
| 14:13:44 | <bwolfe> or just a should? |
| 14:13:53 | <bwolfe> oh, its a could |
| 14:13:56 | <djazayeri> currently it's a "should" |
| 14:14:00 | <djazayeri> I mean "could" |
| 14:14:24 | <bwolfe> yes, def start with musts, but hte two open musts are more meta: RESTWS-146 |
| 14:14:28 | <bwolfe> err https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&mode=hide&jqlQuery=project+%3D+%22WebServices.REST+Module%22+AND+fixVersion+%3D+%22Sprint+2%22+AND+status+%3D+%22Ready+for+Work%22+AND+%28labels+is+EMPTY+OR+labels+%21%3D+epic%29+AND+resolution+%3D+Unresolved |
| 14:14:34 | <OpenMRSBot> <http://ln-s.net/8yUG> (at tickets.openmrs.org) |
| 14:15:12 | <djazayeri> Well, it doesn't matter if they're meta, they still have to get done. |
| 14:15:43 | <djazayeri> For RESTWS-155 I propose we go with the workaround that doesn't require modifying core. |
| 14:15:54 | <bwolfe> yes. (had typed out half that already) |
| 14:16:13 | <wyclif> then am going to work on the unassigned tickets among the musts |
| 14:16:31 | <djazayeri> RESTWS-148 is actually a grouping ticket, and dkayiwa owns all the sub-tasks. |
| 14:16:46 | <bwolfe> right |
| 14:16:49 | <djazayeri> so do 155 |
| 14:17:18 | *** mathiaslin has quit IRC |
| 14:18:16 | <bwolfe> ok, focus on 155. then do 153. |
| 14:18:39 | <bwolfe> then ping us when you're through and ready for another task. (because you'll have to either pick up with someone else or do a general bug fix) |
| 14:18:44 | <bwolfe> dkayiwa, you're up |
| 14:18:56 | *** downeym sets mode: +v cta |
| 14:18:58 | *** downeym sets mode: +v asgoyal |
| 14:19:00 | *** downeym sets mode: +v dkayiwa |
| 14:19:03 | *** downeym sets mode: +v wyclif |
| 14:19:06 | *** downeym sets mode: +v vchircu |
| 14:19:08 | *** downeym sets mode: +v surangak_ |
| 14:19:32 | <downeym> those who i just voiced: http://freenode.net/faq.shtml#nicksetup |
| 14:19:53 | <wyclif> ok |
| 14:20:19 | <dkayiwa> Finished displaying resource representations on the help page. Done it in such a way that it is the same code which we shall use for generating some of the wiki documentation. Now picking another ws ticket. No Blockers. |
| 14:20:49 | <bwolfe> dkayiwa, you have a few assigned to you, right? |
| 14:20:53 | <bwolfe> are they all the documentation ones? |
| 14:21:01 | <dkayiwa> two |
| 14:21:16 | <dkayiwa> yes |
| 14:21:38 | <djazayeri> Daniel, you have three tickets currently assigned to you and In Progress |
| 14:21:55 | <djazayeri> RESTWS-114, RESTWS-113, RESTWS-15 |
| 14:22:07 | <bwolfe> the second two should be in code review state as of now, right? |
| 14:22:15 | <dkayiwa> oh yes |
| 14:23:06 | <bwolfe> ok, after the person attribute one start copying your generated documentation onto the wiki. we can "review" things there more easily |
| 14:23:27 | <bwolfe> you don't have to necessarily follow the example I put up (separate pages). but it does have to be navigatable somehow |
| 14:23:29 | <dkayiwa> ok |
| 14:23:42 | <djazayeri> Perhaps just do {toc}? |
| 14:24:41 | <djazayeri> and count on the h2, h3, etc? |
| 14:24:48 | <bwolfe> yeah, perhaps |
| 14:25:04 | <bwolfe> I was thinking something like making them expandable |
| 14:25:21 | <dkayiwa> ok |
| 14:26:46 | <bwolfe> ok, raffle? err rafa? |
| 14:26:55 | <rafa> :P |
| 14:26:58 | <rafa> Today: Worked on META. Darius, I'll let you know later today when it's ready for you to click through. Tomorrow: Write extra functional tests for META and document changes in the module for end users. No blockers. |
| 14:27:59 | <djazayeri> okay, looking forward to clicking (a lot) |
| 14:28:45 | <rafa> djazayeri: Oh I almost forgot. I need to make the "next" button to be focused by default :) |
| 14:29:00 | <cta> bwolfe: Ben, and what's about me? I'd also *need* ;-) the ticket for sprint since I finished previous one (I've committed code and am waiting for approve) ;-) |
| 14:29:03 | <djazayeri> please do that before asking me to test it this time |
| 14:29:29 | <bwolfe> rafa, haha |
| 14:29:34 | <bwolfe> rafa, leave it out, just to be cruel |
| 14:29:46 | <bwolfe> cta, is the review out of draft state? |
| 14:29:56 | <bwolfe> I wanted to go through it earlier but it looked like you had just made it |
| 14:30:56 | <cta> bwolfe: I didn't start review yet |
| 14:31:13 | <bwolfe> ah, start it and I'll try to review it later tonight |
| 14:31:26 | <cta> bwolfe: ok |
| 14:31:56 | <bwolfe> cta, in the mean time, I'm not sure we have other ws tickets. |
| 14:32:12 | <bwolfe> I need to make a few tickets around packaging up the module and releasing it, but we can't do those until the others are done |
| 14:32:55 | <cta> bwolfe: ce la Vie ;-) |
| 14:32:59 | <bwolfe> djazayeri ? |
| 14:33:10 | <djazayeri> Yesterday: |
| 14:33:10 | <djazayeri> * Explored a web service ticket and decided not to do it |
| 14:33:10 | <djazayeri> * Prep for UI sprint |
| 14:33:10 | <djazayeri> * Organized some tickets & code reviews for a thoughtworks code jam today |
| 14:33:10 | <djazayeri> * Email |
| 14:33:11 | <djazayeri> Today: |
| 14:33:12 | <djazayeri> * Design calls |
| 14:33:12 | <djazayeri> * Prep for UI sprint |
| 14:33:30 | <djazayeri> No blockers. |
| 14:35:21 | <djazayeri> (done) |
| 14:35:26 | <djazayeri> bwolfe? |
| 14:36:39 | <bwolfe> judy: why do rainstorms knock out the power here?? does it happen in nbo too? |
| 14:36:55 | <downeym> bwolfe? |
| 14:38:56 | <cta> bwolfe: Ben, as you've asked for I started review for RESTWS-138. Here is review https://source.openmrs.org/cru/CR-MOD-212. |
| 14:39:15 | <djazayeri> looks like we lost bwolfe |
| 14:39:47 | <djazayeri> rafa: I made a comment on that ticket that we should discuss, but perhaps not for an hour |
| 14:39:59 | <cta> djazayeri: Darius, I added you too reviewers list for that too. ;-) |
| 14:40:09 | <cta> too -> to |
| 14:40:18 | <djazayeri> going afk for a bit, then have a call |
| 14:40:35 | <rafa> djazayeri: I've replied. Are you still in doubt? |
| 14:41:00 | *** bwolfeandroid has joined #openmrs |
| 14:41:15 | <downeym> Hi bwolfeandroid and welcome to the #openmrs IRC channel. |
| 14:41:55 | <bwolfeandroid> Thanks downeymbot |
| 14:42:08 | <bwolfeandroid> Had the meeting adjourned? |
| 14:42:34 | <bwolfeandroid> Not having a monitor when the power goes out really sucks... |
| 14:42:41 | <asgoyal_> i m still here |
| 14:42:48 | *** dkayiwa has quit IRC |
| 14:45:47 | <bwolfeandroid> asgoyal, did you give your update? |
| 14:45:53 | <asgoyal_> nope |
| 14:47:13 | <asgoyal_> yesterday: worked on Trunk 235, attached patch and put it up for code review.. studied a little bit on springframework, today: working on Trunk 2193, currently studying hibernate tutorial and later will do apptest if possible |
| 14:47:35 | *** lh has joined #openmrs |
| 14:47:49 | <bwolfeandroid> 2193 is... ? |
| 14:48:04 | <bwolfeandroid> Sorry, don't have am easy way of loading that up quickly |
| 14:48:05 | <asgoyal_> add drug ingredients to API |
| 14:48:20 | <asgoyal> https://tickets.openmrs.org/browse/TRUNK-2193 |
| 14:48:48 | <bwolfeandroid> Was that from the oe sprint last week? |
| 14:48:53 | <asgoyal_> yes |
| 14:49:12 | <djazayeri> the drug ingredient ticket is not from a sprint |
| 14:49:23 | <djazayeri> it's a (large) intro ticket |
| 14:49:28 | <asgoyal_> oh ... ok |
| 14:49:31 | <asgoyal_> actually |
| 14:49:44 | <djazayeri> so it's a "learn liquibase, hibernate, and spring" ticket |
| 14:49:45 | <asgoyal_> i asked djazayeri to give me a ticket which will help me learn more |
| 14:49:50 | <asgoyal_> nice! |
| 14:49:55 | <bwolfeandroid> Ok |
| 14:50:00 | <asgoyal_> so i will do that ... plz? |
| 14:50:08 | <asgoyal_> thank you! :) |
| 14:50:09 | <bwolfeandroid> Sure |
| 14:50:30 | <asgoyal_> for the apptest... i will do that in the evening after i get back home |
| 14:51:05 | <asgoyal_> also i m still stuck on the confirm pop up... cudn't find a proper function to automate it using selenium |
| 14:51:20 | <bwolfeandroid> My update is similar to yesterday. :-) did some non ws reviews, sent some emails, did a few ws reviews. I have half a day left, but will be spending that on conference calls |
| 14:51:37 | *** downeym sets mode: +v bwolfeandroid |
| 14:51:52 | <bwolfeandroid> asgoyal, should check with the tw guys on that one. Out the selenium forum/irc? |
| 14:52:15 | <asgoyal_> oh ok |
| 14:52:31 | <bwolfeandroid> Out=or |
| 14:52:53 | <asgoyal_> oh ok .. i think i will post a question on selenium forum |
| 14:53:12 | <asgoyal_> for that time i can keep that particular ticket on hold cuz it just needs that one function to automate the confirm |
| 14:53:19 | <bwolfeandroid> Ok, nothing in their docs? |
| 14:53:30 | *** pascal` has quit IRC |
| 14:53:44 | <asgoyal_> hm... i did find one .. but it didn't work |
| 14:53:50 | <asgoyal_> i dont remember the function no |
| 14:53:51 | <asgoyal_> now |
| 14:56:04 | <asgoyal_> bwolfeandroid: there are few tickets in progress by someone else... so is it fine if i finish them.. cuz they are somewhat similar to ones i did? |
| 14:56:48 | <bwolfeandroid> In what? App test? |
| 14:56:56 | <asgoyal_> apptest 42 |
| 14:57:11 | <asgoyal_> 37 |
| 14:57:57 | <djazayeri> rafa: yes, still in doubt. You mentioned mapping concept names. I don't know if I understood right. |
| 14:58:05 | <bwolfeandroid> Ask the ticket owner. If no reply, then streak they ticket from then |
| 14:58:26 | <asgoyal_> ok |
| 14:58:27 | <bwolfeandroid> Err, steal |
| 14:58:43 | <asgoyal_> haha was looking that word on dictionary.com :D |
| 14:59:08 | *** jriley has quit IRC |
| 14:59:23 | <bwolfeandroid> Heh |
| 14:59:35 | <bwolfeandroid> Please don't streak at work |
| 14:59:36 | *** mandric has joined #openmrs |
| 14:59:57 | <asgoyal> hahaha |
| 15:00:04 | *** mandric has quit IRC |
| 15:00:13 | <asgoyal> just joking |
| 15:00:29 | *** mandric has joined #openmrs |
| 15:00:52 | <djazayeri> rafa: I have 20 mins now, if you're there |
| 15:01:21 | *** bwolfeandroid has quit IRC |
| 15:06:58 | *** cta has quit IRC |
| 15:08:33 | *** bwolfe has quit IRC |
| 15:08:50 | *** vchircu has quit IRC |
| 15:09:19 | *** goutham has joined #openmrs |
| 15:10:28 | <rafa> djazayeri: I didn't mention mapping concept names. It's all about concepts. |
| 15:10:42 | <djazayeri> actually on a call now, my bad |
| 15:11:16 | <rafa> djazayeri: No problem. I just wanted to say that your suggestion is yet another feature. |
| 15:11:31 | <rafa> djazayeri: We can add that to the next release. |
| 15:11:45 | <rafa> djazayeri: This release is closed for new features ;) |
| 15:12:12 | *** mathiaslin has joined #openmrs |
| 15:20:03 | *** jwishnie has joined #openmrs |
| 15:22:02 | *** downeym_ has joined #openmrs |
| 15:22:02 | *** ChanServ sets mode: +o downeym_ |
| 15:22:13 | *** bryq has quit IRC |
| 15:23:09 | <djazayeri> rafa: I'm saying add one line to the per-item controller to validate the object. |
| 15:23:33 | <djazayeri> if it fails, then show a warning/error message next to the "create" radio button. |
| 15:24:51 | <djazayeri> How about just that one teeny tiny new feature? :-) |
| 15:24:54 | *** yanokwa has joined #openmrs |
| 15:24:54 | *** ChanServ sets mode: +v yanokwa |
| 15:24:57 | <djazayeri> (done with my call now) |
| 15:25:21 | *** downeym has quit IRC |
| 15:25:21 | *** downeym_ is now known as downeym |
| 15:25:31 | <rafa> djazayeri: OK, the last one :P |
| 15:25:49 | <yanokwa> anyone seen this font error before? "SEVERE: Servlet.service() for servlet showGraphServlet threw exception java.lang.Error: Probable fatal error:No fonts found." http://dpaste.com/562710/ |
| 15:27:14 | *** bryq has joined #openmrs |
| 15:27:14 | *** ChanServ sets mode: +v bryq |
| 15:27:26 | <djazayeri> yanokwa: nope |
| 15:28:52 | <yanokwa> djazayeri: awesome. i like being a trend setter. |
| 15:50:43 | <yanokwa> "sudo apt-get remove sun-java6* && sudo apt-get install sun-java6*" solved my problem. |
| 15:57:46 | *** pascal` has joined #openmrs |
| 15:59:16 | *** gbastien has quit IRC |
| 16:10:34 | *** gbastien has joined #openmrs |
| 16:17:06 | *** jriley has joined #openmrs |
| 16:48:04 | *** yanokwa has quit IRC |
| 16:49:12 | *** cta has joined #openmrs |
| 17:05:48 | *** goutham has quit IRC |
| 17:17:41 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Address Hierarchy 2.0.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=addresshierarchy&version=&2.0.2> |
| 17:35:22 | *** mandric has quit IRC |
| 17:53:44 | *** bwolfe has joined #openmrs |
| 17:53:44 | *** ChanServ sets mode: +o bwolfe |
| 18:02:08 | *** saimanohar has joined #openmrs |
| 18:02:21 | <saimanohar> hi all.. |
| 18:03:07 | <saimanohar> i am trying to create a page similar to the patientForm.jsp |
| 18:03:40 | <saimanohar> which includes two portlets nameLayout.jsp and addressLayout,jsp |
| 18:04:08 | <djazayeri> and? |
| 18:04:16 | <djazayeri> :-) |
| 18:04:22 | <saimanohar> i am binding it to person.names instead of patient.names |
| 18:05:11 | *** mathiaslin has quit IRC |
| 18:05:23 | <saimanohar> but i get a property not found : personName on java.lang.string error in both the portlets when i say layoutextended=true |
| 18:06:46 | <saimanohar> what is the difference using spring:nestedPath = patient.names to that of person.names |
| 18:06:58 | *** mandric has joined #openmrs |
| 18:07:19 | <djazayeri> could you have done patient.names instead of ${patient.names} ? |
| 18:08:48 | <djazayeri> saimanohar: I mean, did you accidentally forget the ${ }? |
| 18:09:23 | <saimanohar> nope i did bindpath="person.names[${varStatus.index}] just the same way it is in the patientForm.jsp |
| 18:10:10 | <saimanohar> i mean nestedPath= |
| 18:10:52 | *** bryq has left #openmrs |
| 18:11:56 | <djazayeri> saimanohar: can you put the whole code snippet in pastebin? |
| 18:12:06 | <saimanohar> yup |
| 18:13:15 | <saimanohar> here it is - http://pastebin.com/dhnk7NqB |
| 18:13:42 | <saimanohar> the form is from lines 274-350 |
| 18:19:49 | *** jwishnie has quit IRC |
| 18:24:38 | <djazayeri> saimanohar: took a quick peek at the code. do you have any PersonName rows with voided=true but voided_by is null? |
| 18:25:26 | <saimanohar> nope |
| 18:25:47 | *** asgoyal has quit IRC |
| 18:26:08 | *** Echidna has quit IRC |
| 18:26:14 | <djazayeri> what's the exact error you get? |
| 18:26:47 | <saimanohar> as you might have noticed what i had tried to do is combine the way we create a user with the long person form |
| 18:27:14 | <saimanohar> this is the error i get - The following error happened somewhere on this page:<br/> javax.servlet.jsp.JspException: javax.el.PropertyNotFoundException: Property 'personName' not found on type java.lang.String |
| 18:27:38 | <djazayeri> is there a stack trace of some sort? |
| 18:28:11 | <saimanohar> well,the stack trace says the same |
| 18:28:40 | <djazayeri> does it have references to nested tags? |
| 18:29:24 | <saimanohar> nope i dont see any |
| 18:30:15 | <djazayeri> can I see the stack trace anyway? |
| 18:30:28 | <saimanohar> it just says that..however since its only coming when layoutshowextended is true i think its when showing the creator and other stuff |
| 18:30:31 | <saimanohar> ya sure |
| 18:30:45 | *** Echidna has joined #openmrs |
| 18:30:45 | *** ChanServ sets mode: +v Echidna |
| 18:31:35 | <saimanohar> http://pastebin.com/egABAHVG |
| 18:35:35 | <djazayeri> saimanohar: I can't tell what's going on. |
| 18:36:13 | <djazayeri> If you're using tomcat, you could try looking in the work directory for the compiled jsp file mentioned: |
| 18:36:14 | <djazayeri> 1. at org.apache.jsp.WEB_002dINF.view.portlets.addressLayout_jsp._jspx_meth |
| 18:36:15 | <djazayeri> 2. _c_005fif_005f24(addressLayout_jsp.java:2582) |
| 18:36:20 | <djazayeri> and see exactly what line the error is at |
| 18:36:47 | <saimanohar> okay and we have the personName property on which object? |
| 18:37:13 | <saimanohar> in person.java or personname.java |
| 18:37:32 | <djazayeri> person.java has getPersonName |
| 18:37:49 | <saimanohar> okay |
| 18:46:38 | *** saimanohar has quit IRC |
| 18:50:47 | *** saimanohar has joined #openmrs |
| 18:59:35 | <djazayeri> rafa: how's it goign? |
| 18:59:57 | <rafa> djazayeri: I'm testing. |
| 19:00:40 | <rafa> djazayeri: I'll mail you instructions within an hour. |
| 19:00:44 | <djazayeri> ok |
| 19:21:23 | *** mandric has quit IRC |
| 19:23:08 | *** james_regen has quit IRC |
| 19:24:21 | *** jwishnie has joined #openmrs |
| 19:25:59 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @daeaves: Why not create an #Open311 add-on for #Ushahidi? (#openMRS shows the way) http://bit.ly/ozCMcw #gov20 #ICT4D <http://twitter.com/OpenMRS/statuses/88677013958828032> || On Twitter: OpenMRS: RT @bawolfe: Definitely looks like an alpha release of the rest ws module this week! #openmrs <http://twitter.com/OpenMRS/statuses/88676887311810560> |
| 19:33:15 | *** saimanohar has quit IRC |
| 19:34:19 | <wyclif> djazayeri, propery getter doesn't seem to work in the module |
| 19:34:56 | <djazayeri> restws? |
| 19:35:01 | <djazayeri> can you give an example? |
| 19:35:09 | <wyclif> may be i should rephrase, it doesn't seem to solve the problem for for concept.isSet |
| 19:36:21 | <djazayeri> I recall we never actually wanted an "isSet". |
| 19:36:30 | <wyclif> looks to me like jackson inspects the class still |
| 19:36:42 | <djazayeri> So, the problem happens when you try to convert a Concept to json via jackson |
| 19:36:45 | <djazayeri> that should never be happening |
| 19:37:13 | <djazayeri> all concepts should be converted to (SimpleObject) representations by our rest framework before being passed to jackson |
| 19:37:23 | <wyclif> it is happening even when i dont include the property in the desctiption |
| 19:37:42 | <djazayeri> Could it be that some *other* object has a Concept property that isn't being converted right? |
| 19:37:49 | <djazayeri> What's the specific test/example? |
| 19:39:19 | <wyclif> am fetching the concept itself |
| 19:42:14 | <djazayeri> wyclif: is there a failing unit test? |
| 19:43:47 | <wyclif> no |
| 19:44:11 | <djazayeri> Does it only happen when deployed for real? |
| 19:45:12 | *** dkayiwa has joined #openmrs |
| 19:45:56 | <wyclif> correct |
| 19:46:15 | <wyclif> tests are fine but they fail in the app |
| 19:46:27 | <djazayeri> Even if you do Util.log in the tests? That uses jackson... |
| 19:47:36 | <wyclif> the tests have always passed |
| 19:47:53 | <djazayeri> okay, so how do I reproduce the error? |
| 19:50:43 | <wyclif> just try fetching the concept from the web layer |
| 19:50:52 | <wyclif> in the we app |
| 19:52:30 | *** pascal` has quit IRC |
| 19:53:51 | <djazayeri> okay, will try to run it |
| 19:58:58 | <bwolfe> djazayeri, are you going to fix the trunk build error? |
| 19:59:59 | <djazayeri> just noticed that. I don't know what's up with it. |
| 20:01:30 | <djazayeri> wondering if it's just a maven project issue... |
| 20:01:52 | <djazayeri> the build error I see is about Relationship.setStartDate, and that method does exist in Relationship in trunk |
| 20:03:37 | <bwolfe> No bean named 'migrationActionController' is defined |
| 20:04:01 | <djazayeri> oh, haven't noticed that. my bad |
| 20:04:25 | <djazayeri> Inconveniently I see build errors in my eclipse project, though they shouldn't be there. |
| 20:07:19 | <wyclif> i assumed a merge with order-entry branch will remove migrationController automatically since it was removed from the branch |
| 20:07:39 | <djazayeri> Well, someone picked up the ticket and I committed their patch |
| 20:07:49 | <djazayeri> but didn't run the unit tests |
| 20:07:50 | <djazayeri> tsk tsk |
| 20:20:35 | <bwolfe> hmm, djazayeri, do you have a demo cued up for tomorrow's dev call? or were you just planning on using curl? :-) |
| 20:20:48 | <djazayeri> oh, doh, I'd forgotten about that. |
| 20:20:54 | <djazayeri> No, nothing queued up |
| 20:21:14 | <bwolfe> and is burke actually going to be back from vacation to talk about order entry next steps? |
| 20:21:14 | <djazayeri> Any chance you want to take that demo over, since I'm not really looking at restws now? |
| 20:21:38 | <bwolfe> hmm, "on cue" vs "in queue" |
| 20:22:51 | <cta> bwolfe: Ben, I have a question related to your comment about using of Hl7Source object as field of IncomingHl7Message instead of hl7SourceId. In this case outside user will pass through json something like this : " { source : { name : 'source name' id : 0}, sourceKey : 'test key' data : 'SFD|||JK||^GH|||' }", right? |
| 20:22:55 | <bwolfe> I was hoping we'd have a mini app to demo...not sure I can hack one together in half a day |
| 20:23:20 | <djazayeri> bwolfe: I can give you a snippet of groovy code... |
| 20:23:33 | <bwolfe> how large is that snippet? |
| 20:23:59 | <djazayeri> cta: no. { source: 'source name', sourceKey: 'the key', data: 'â¦' } |
| 20:24:00 | <bwolfe> cta, minus the "id : 0" probably |
| 20:24:41 | <bwolfe> ah yes, "source name" will be a unique identifier, so you can use it that way |
| 20:24:50 | <bwolfe> or source: "uuid of the source object" |
| 20:25:16 | <djazayeri> bwolfe: how much longer are you working tonight? and how are you with groovy? |
| 20:25:27 | <djazayeri> Let me rephrase... |
| 20:25:52 | <djazayeri> I can hack together a very quick swing app that will do some rest stuff. |
| 20:25:55 | <cta> bwolfe, djazayeri: but we don't have method for fetching source by uuid, we have for fetching by id and name |
| 20:26:01 | <djazayeri> Nothing very interesting |
| 20:26:05 | <bwolfe> djazayeri, thats a heck of a rephrasing |
| 20:26:13 | <djazayeri> and perhaps you can put some further touches on it tomorrow? |
| 20:26:44 | <djazayeri> cta: luckily I named the method "getByUniqueId" in the interface. So it's not required to be a uuid. :-) |
| 20:26:47 | <djazayeri> just use the name for now. |
| 20:27:09 | <bwolfe> that'd be fine. both my swing and groovy are weak...but I remember/learn quickly |
| 20:27:28 | <djazayeri> and create a ticket for adding the getConceptSourceByUuid method |
| 20:27:32 | <bwolfe> but to answer your question, I'm only awake for another 5 mins. I was just checking on the dev call tmrw before closing down to make sure we're ready |
| 20:27:46 | <djazayeri> okay, well, thanks for checking, because we're not |
| 20:28:07 | <djazayeri> I'll see if I can do the start of a demo, and hand it off to you. Maybe I'll just use java if I can find an appropriate rest client. |
| 20:28:12 | <bwolfe> cta, strange that we don't have that method. but yes, just use name for now. |
| 20:28:29 | <djazayeri> off to lunch |
| 20:28:32 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.7.x): Search terms do not appear when viewing concept - TRUNK-2315... <http://feedproxy.google.com/~r/OMRStrunk/~3/TD8kyf0SXQ4/OpenMRS> || New Changeset: OpenMRS (trunk): Remove MigrationController - TRUNK-2390... <http://feedproxy.google.com/~r/OMRStrunk/~3/qtYwGyJzNc4/OpenMRS> |
| 20:28:46 | <bwolfe> djazayeri, use whatever is quickest for you. I can add more in tomorrow in the 4 hours I have before the call |
| 20:29:09 | <downeym> bwolfe: i started building an asterisk server over the weekend |
| 20:29:17 | <downeym> it won't be ready for tomorrow unfortunately |
| 20:29:24 | *** bryq1 has joined #openmrs |
| 20:29:29 | <bwolfe> downeym, going to be ready for the call for me to test? :-) |
| 20:29:31 | <bwolfe> oh |
| 20:29:35 | <bwolfe> boo |
| 20:29:38 | <cta> bwolfe, djazayeri: no problem, but how framework will realize that it's need to call method getHl7SourceByName() when it will set the property _Hl7Source source_ of class IncomingHl7Message? |
| 20:30:09 | <bwolfe> you have 18 hours before the call takes place though...get to work! |
| 20:30:35 | <bwolfe> downeym, if you have that, can you set it up to take any number of voip calls into the same line? |
| 20:30:39 | <cta> it goes that we need to have property String sourceName instead of Hl7Source for class IncomingHl7Message? |
| 20:31:13 | <downeym> bwolfe: i'm hoping to be able to use jingle/xmpp to connect into the connect meeting room |
| 20:32:27 | <bwolfe> cta, the framework looks for a converter for HL7Source. that is usually the Hl7SourceResource class |
| 20:33:03 | <bwolfe> (look at the parents of the resource classes, somewhere one of them is a spring "Converter" |
| 20:33:17 | <wyclif> bwolfe, djazayeri , i haven't yet managed to get around isSet within the module, strangely the unit tests are fine and some classes have isVoided and getVoided working without issues |
| 20:33:26 | <bwolfe> the parent to the resource classes take that required method of Converter and call getByUniqueId() on the resource class |
| 20:33:46 | <wyclif> so why would only isSet fail |
| 20:33:50 | <bwolfe> wyclif, have you double checked the lowercase b versus uppercase B ? |
| 20:34:08 | <wyclif> on Concept |
| 20:37:23 | <cta> bwolfe: Yes, fetching resource by unique ID, but not by _name_. So, it goes that I need to add class Hl7SourceResource, right? But how to be with lack method for getting hl7 source by its uuid? |
| 20:38:14 | <bwolfe> cta, look at the other resources. they first look up by uuid, then look up by name |
| 20:38:47 | <cta> bwolfe: ok. Thank you, Ben |
| 20:38:58 | <bwolfe> we have said that objects can be looked up (and specified by the clients) by EITHER uuid or by name (if the name is unique...obviously patients don't have that) |
| 20:41:05 | *** jriley has quit IRC |
| 20:41:48 | *** dkayiwa has quit IRC |
| 20:45:51 | *** lh has quit IRC |
| 20:46:08 | <djazayeri> wyclif: I finally got my trunk compiling (the problem was I had another branch open, and maven was confused) |
| 20:46:18 | <djazayeri> I will try running the module and see what I think about the error |
| 20:47:20 | <wyclif> ok |
| 20:48:44 | <djazayeri> wyclif: can you give me a curl command to try offhand? |
| 20:49:42 | <wyclif> djazayeri, http://localhost:8080/openmrs/ws/rest/concept/be373082-1691-11df-97a5-7038c432aabf |
| 20:50:03 | <wyclif> djazayeri, curl -i -u admin:test http://localhost:8080/openmrs/ws/rest/concept/be373082-1691-11df-97a5-7038c432aabf |
| 20:50:51 | *** bwolfe has quit IRC |
| 20:51:49 | <wyclif> i think the problem has to do with the representations |
| 20:53:47 | *** jwishnie has quit IRC |
| 21:00:59 | *** cta_ has joined #openmrs |
| 21:00:59 | *** cta has quit IRC |
| 21:01:02 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @ryanstevencaro Hi! :-) <http://twitter.com/OpenMRS/statuses/88705246523703298> |
| 21:05:29 | *** rafa has quit IRC |
| 21:06:47 | <djazayeri> wyclif: is it specifically for sets that it fails? |
| 21:07:47 | <djazayeri> because I just curled two concepts and they come back fine. |
| 21:08:07 | <wyclif> hmm |
| 21:08:41 | <wyclif> the only get back results for ref rep |
| 21:08:52 | <wyclif> i wonder whether it is my environment |
| 21:09:02 | <wyclif> are you running that off trunk |
| 21:09:13 | <djazayeri> yes |
| 21:09:18 | <djazayeri> found it |
| 21:09:25 | <djazayeri> I mean: I successfully replicated the error |
| 21:09:32 | <djazayeri> it happens for my conceptId 6 but not 3 or 4 |
| 21:10:04 | <djazayeri> okay, hold on |
| 21:13:48 | <wyclif> in my dataset all those 3 concepts are not sets |
| 21:14:00 | <djazayeri> yeah, I have only a few random concepts |
| 21:14:02 | <djazayeri> but 6 isn't a set |
| 21:15:53 | <wyclif> mine fails for all |
| 21:16:13 | <wyclif> unless an i set the represenation to ref |
| 21:16:21 | <wyclif> default and full fail |
| 21:16:46 | <wyclif> even when i leave out the set property, i wonder why it still tries to set it |
| 21:16:53 | <cta_> bye guys |
| 21:17:11 | *** downeym has quit IRC |
| 21:17:13 | *** cta_ has quit IRC |
| 21:25:04 | <djazayeri> wyclif: I found the problem |
| 21:25:19 | <djazayeri> Concepts with descriptions fail |
| 21:25:54 | <djazayeri> I assume we don't have any descriptions in the test dataset. |
| 21:25:57 | <djazayeri> for unit tests |
| 21:26:21 | <djazayeri> anyway, you need to write a (placeholder) Resource for ConceptDescription. |
| 21:27:18 | <wyclif> i realised it and i was trying to comment it out |
| 21:27:46 | <djazayeri> the way I found this was using the debugger, setting a breakpoint on the line the error complained about (StdSerializerProvider.java:636), and walking up the call stack until I found the property it was trying to serialize when things failed. |
| 21:27:54 | <djazayeri> anyway, you can take it from here, right? |
| 21:30:33 | <wyclif> concept descriptionss is the problem |
| 21:31:32 | <wyclif> i now realise that we need that test on all resources |
| 21:32:09 | <djazayeri> well, there is no concept description resource |
| 21:32:12 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Search terms do not appear when viewing concept - TRUNK-2315... <http://feedproxy.google.com/~r/OMRStrunk/~3/BC2fN1fU4po/OpenMRS> || New Changeset: OpenMRS (trunk): Remove MigrationController - TRUNK-2390... <http://feedproxy.google.com/~r/OMRStrunk/~3/4Pqwug8RsDg/OpenMRS> || New Changeset: OpenMRS (1.8.x): Search terms do not appear when viewing concept - TRUNK-2315... <http://feedproxy.google.com/~r/OMRStrunk/~3/vMsmtbZGwMw/OpenMRS> |
| 21:32:16 | <djazayeri> the problem is the test dataset, right? |
| 21:32:54 | <wyclif> i dont think so |
| 21:33:51 | <wyclif> i can do the conceptdescription resource before i wind down my day |
| 21:34:22 | <djazayeri> hmm, yeah, concept 88 (which is the test I looked at) does have a description |
| 21:34:31 | <djazayeri> oh well |
| 21:34:39 | <djazayeri> go ahead and fix it anyway. should be trivial |
| 21:34:42 | <wyclif> ok |
| 21:35:24 | <wyclif> thanks |
| 21:35:40 | <wyclif> the error message is quite misleading |
| 21:36:35 | <wyclif> running home |
| 21:36:42 | <wyclif> will back online like in 30min |
| 21:49:27 | *** wyclif has quit IRC |
| 21:51:44 | *** robbyoconnor has joined #openmrs |
| 21:51:44 | *** ChanServ sets mode: +v robbyoconnor |
| 22:03:17 | *** jwishnie has joined #openmrs |
| 22:10:37 | *** gbastien_ has joined #openmrs |
| 22:13:11 | *** gbastien has quit IRC |
| 22:15:31 | *** gbastien_ has quit IRC |
| 22:18:06 | *** bryq1 has quit IRC |
| 22:24:06 | *** czakian has joined #openmrs |
| 22:24:40 | *** czakian has quit IRC |
| 22:26:13 | *** czakian has joined #openmrs |
| 22:26:55 | *** czakian_ has joined #openmrs |
| 22:27:18 | *** czakian has quit IRC |
| 22:27:27 | *** czakian has joined #openmrs |
| 22:44:37 | *** czakian_ has quit IRC |
| 22:49:37 | *** mandric has joined #openmrs |