| 00:01:10 | *** akapil has joined #openmrs |
| 00:01:28 | <akapil> I'm having issues deploying openms.war in apache tomcat |
| 00:01:39 | <akapil> it always says fail instead of true... |
| 00:01:57 | <akapil> I didn't know what path to choose, so I always just select file and click deploy |
| 00:02:00 | <akapil> and it never works. |
| 00:19:46 | *** akapil has quit IRC |
| 01:17:00 | *** deadpool has quit IRC |
| 02:50:50 | *** upul` has joined #openmrs |
| 02:50:50 | *** ChanServ sets mode: +v upul` |
| 03:30:10 | *** gbastien has quit IRC |
| 03:41:49 | *** surangak has joined #openmrs |
| 04:02:05 | *** mccallumg has joined #openmrs |
| 04:02:05 | *** ChanServ sets mode: +v mccallumg |
| 04:04:17 | <surangak> mccallumg, howdy |
| 04:04:31 | <mccallumg> hey surangak |
| 04:05:25 | <mccallumg> surangak: how's it going? |
| 04:05:32 | <surangak> mccallumg, i was adding some finishing touches to Burkes requirement |
| 04:05:50 | <surangak> mccallumg, he had responded to both mails on friday.... |
| 04:06:01 | <mccallumg> on the dev list. I recall. |
| 04:06:31 | <surangak> mccallumg, on saturday, i also commited a very 'initial' draft of the validator |
| 04:06:41 | <surangak> mccallumg, that we discussed on the design call.... |
| 04:07:20 | <mccallumg> surangak: good. I'll have to grab the most recent version from svn |
| 04:07:57 | <surangak> mccallumg, so far, my test results show 0 faliures and i thonk 4 errors |
| 04:08:09 | <surangak> mccallumg, I really should work on the tests :) |
| 04:08:25 | <mccallumg> surangak: yes. and documentation :) |
| 04:09:01 | <surangak> mccallumg, for now, can u use the branch without the tests :) |
| 04:09:41 | <surangak> mccallumg, i will take on tests and documents as my next //to do |
| 04:09:46 | <surangak> mccallumg, and start work on those... |
| 04:11:57 | <mccallumg> surangak: what is the mvn command from the command line again? to skip tests? |
| 04:12:28 | <surangak> mccallumg, u can do mvn clean install -Dmaven.test.skip=true |
| 04:12:34 | <surangak> from the trunk |
| 04:12:55 | <surangak> mccallumg, then navigate to the webapp, and do mvn jetty:run |
| 04:13:35 | <mccallumg> surangak: which configuration is it using? the one in .openMRS fill in my home directory? |
| 04:13:48 | <mccallumg> surangak: is that obsolete in newest versions? |
| 04:13:59 | <surangak> mccallumg, sorry, did not get you ? |
| 04:14:19 | <mccallumg> [ERROR] Failed to execute goal on project openmrs-web: Could not resolve dependencies for project org.openmrs.web:openmrs-web:jar:1.9.0-SNAPSHOT: Could not find artifact org.openmrs.api:openmrs-api:jar:tests:1.9.0-SNAPSHOT in openmrs-repo (http://mavenrepo.openmrs.org/nexus/content/repositories/public) -> [Help 1] |
| 04:14:20 | <OpenMRSBot> <http://ln-s.net/8-2X> (at mavenrepo.openmrs.org) |
| 04:14:43 | <mccallumg> surangak: something to do with my maven config? |
| 04:15:00 | <surangak> mccallumg, u get this when u try to run the clean install, is it ? |
| 04:15:18 | <mccallumg> mvn clean install -Dmaven.test.skip=true |
| 04:15:26 | <surangak> mccallumg, does your IDE show any errors to you ? |
| 04:15:48 | <mccallumg> surangak: opening ... |
| 04:17:24 | <mccallumg> surangak: nothing highlighted in eclipse. I downloaded it with m2e right into eclipse |
| 04:17:52 | <surangak> mccallumg, could you try running it via the IDE ? |
| 04:18:03 | <surangak> mccallumg, oh, u got an error doing that, I think |
| 04:18:12 | <mccallumg> surangak: same error in the IDE now |
| 04:18:33 | <mccallumg> Failure to find org.openmrs.api:openmrs-api:jar:tests:1.9.0-SNAPSHOT |
| 04:18:49 | <surangak> mccallumg, give me a minute on that... |
| 04:19:40 | <mccallumg> surangak: so it is skipping tests.. but it still should build openmrs tests in the jar right? just not execute them with maven. |
| 04:20:06 | <surangak> mccallumg, oh yep, thats right... |
| 04:20:40 | <surangak> mccallumg, trying to see if anyone has got the same error before... |
| 04:21:48 | <surangak> mccallumg, hi, i found this http://openmrs-mailing-list-archives.1560443.n2.nabble.com/Regarding-GSoC-2011-td6092583.html |
| 04:21:56 | <OpenMRSBot> <http://ln-s.net/8yFt> (at openmrs-mailing-list-archives.1560443.n2.nabble.com) |
| 04:22:35 | <surangak> mccallumg, here Dkayaiwa suggests "I got the same error the first time i tried to run the mavenized openmrs trunk. |
| 04:22:35 | <surangak> I solved it by running Maven Install on the root module (openmrs), instead of just the webapp module." |
| 04:23:02 | <mccallumg> surangak: I have been running it on the root module ... |
| 04:23:17 | <surangak> mccallumg, could we do a screenshare on this one |
| 04:23:27 | <surangak> mccallumg, to see if i can spot anything ? |
| 04:24:03 | <mccallumg> surangak: gladly. sure. |
| 04:25:14 | <mccallumg> surangak: you following now? |
| 04:26:08 | <surangak> mccallumg, hi, i see you... |
| 04:29:37 | <surangak> mccallumg, hi, can u go to your repository |
| 04:29:48 | <surangak> mccallumg, and check if in org/openmrs/ |
| 04:30:07 | <surangak> mccallumg, u have \api\openmrs-api\1.9.0-SNAPSHOT |
| 04:31:39 | <mccallumg> surangak: openmrs-SURANGA/api/target/openmrs-api-1.9.0-SNAPSHOT.jar |
| 04:32:44 | <mccallumg> surangak: I have to run now. I'll be around tomorrow. We can talk more then. No hurry. |
| 04:32:59 | <surangak> mccallumg, sorry about this glen |
| 04:33:21 | <surangak> mccallumg, im not sure whats exactly wrong, but ill look into this.... |
| 04:33:27 | <mccallumg> surangak: its not your problem. It is my inadequate knowledge of maven. I should do a tutorial. |
| 04:33:43 | <surangak> mccallumg, none of us know everything :P |
| 04:33:54 | <mccallumg> surangak: have a good day. |
| 04:34:09 | <surangak> mccallumg, will do, ill keep u posted on the progess |
| 04:34:31 | *** mccallumg has quit IRC |
| 05:30:36 | *** muthah has joined #openmrs |
| 06:07:31 | *** robbyoconnor has joined #openmrs |
| 06:07:31 | *** ChanServ sets mode: +v robbyoconnor |
| 06:12:32 | *** dkayiwa has joined #openmrs |
| 06:12:39 | *** muthah has quit IRC |
| 06:29:34 | *** rafa has joined #openmrs |
| 06:29:35 | *** muthah has joined #openmrs |
| 06:29:37 | *** ChanServ sets mode: +v rafa |
| 06:48:59 | *** bwolfe has joined #openmrs |
| 06:48:59 | *** ChanServ sets mode: +o bwolfe |
| 06:51:00 | <dkayiwa> hi bwolfe |
| 06:51:08 | <bwolfe> morning daniel |
| 06:51:28 | <dkayiwa> bwolfe: how was independence day |
| 06:51:30 | <dkayiwa> :) |
| 06:51:39 | <bwolfe> very good, thanks |
| 06:51:46 | <dkayiwa> :D |
| 06:51:55 | <bwolfe> how was your regular monday? :-) |
| 06:52:00 | <dkayiwa> lolllllllllllll |
| 06:52:08 | <dkayiwa> was lonely :) |
| 06:52:14 | <bwolfe> ha |
| 06:52:18 | <bwolfe> just you and rafa? |
| 06:52:21 | <dkayiwa> yes |
| 06:52:35 | <dkayiwa> and surangak :) |
| 06:52:57 | <surangak> :P we were celebrating becoz all our US clents were also on leave |
| 06:53:09 | <dkayiwa> hahahaha |
| 06:54:01 | <dkayiwa> bwolfe: do u have a minute to run the ResourceDocCreatorTest? |
| 06:54:10 | <bwolfe> sure |
| 06:54:16 | <bwolfe> have you added more to it? |
| 06:54:29 | <dkayiwa> bwolfe: no. but it fails |
| 06:55:06 | <dkayiwa> bwolfe: so i want to know whether i should change the test or fix the resource |
| 06:55:42 | <dkayiwa> bwolfe: and looks like many resources fail |
| 06:55:56 | <bwolfe> whats the error? |
| 06:56:30 | <dkayiwa> java.lang.ExceptionInInitializerError |
| 06:56:30 | <dkayiwa> at org.openmrs.module.webservices.rest.web.resource.CohortMemberResource.getRepresentationDescription(CohortMemberResource.java:108) |
| 06:57:41 | <bwolfe> on the addLink line?? |
| 06:57:45 | <dkayiwa> ys |
| 06:57:47 | <dkayiwa> yes |
| 06:57:59 | <bwolfe> strange |
| 06:58:07 | <bwolfe> let me run them and see. I have to resolve some conflicts first though |
| 06:58:19 | <dkayiwa> oh sorry |
| 06:59:58 | <dkayiwa> bwolfe: all resources fail on that description.addLink( |
| 07:00:16 | <bwolfe> hmm |
| 07:02:37 | <dkayiwa> bwolfe some where it has the Caused by: org.openmrs.api.APIException: Service not found: interface org.openmrs.api.AdministrationService |
| 07:02:37 | *** pascal` has joined #openmrs |
| 07:02:54 | <bwolfe> dkayiwa, correct, that should have been your hint. :-) |
| 07:03:02 | <dkayiwa> :D |
| 07:03:05 | <bwolfe> one of the conflicts I had to resolve was "extends BaseModuleWebContextSensitiveTest" on the test |
| 07:03:11 | <bwolfe> add that back on and it runs fine |
| 07:03:16 | <bwolfe> (or add it in the first place) |
| 07:03:21 | <dkayiwa> thanks :D |
| 07:04:10 | <bwolfe> let me commit my minor changes so you have them before you continue much further. :-) |
| 07:04:28 | <dkayiwa> ok :) |
| 07:06:38 | <bwolfe> ok, committed. it was a little reordering of the reps, added some confluence formatting, (assuming we'll copy/paste, but if not, then you can remove those again), and made some of it conditionally displayed |
| 07:07:05 | <bwolfe> dkayiwa, have you looked at the tools saptarshi was mentioning? |
| 07:07:16 | <bwolfe> perhaps some of the docs can be automatically generated from that? |
| 07:08:12 | <bwolfe> maybe a combination of your test and his library to create docs automatically? |
| 07:08:53 | <dkayiwa> bwolfe: yes looked at them. still looking |
| 07:24:30 | *** danielf` has joined #openmrs |
| 07:24:39 | *** ChanServ sets mode: +v danielf` |
| 07:29:54 | *** muthah has quit IRC |
| 07:37:35 | *** muthah has joined #openmrs |
| 07:41:21 | *** bryq has joined #openmrs |
| 07:41:21 | *** ChanServ sets mode: +v bryq |
| 07:44:51 | *** ChanServ sets mode: +v pascal` |
| 07:48:33 | *** goutham has joined #openmrs |
| 07:51:24 | *** dkayiwa has quit IRC |
| 07:54:50 | *** dkayiwa has joined #openmrs |
| 08:32:34 | *** goutham has quit IRC |
| 08:45:55 | *** muthah_ has joined #openmrs |
| 08:48:09 | *** muthah has quit IRC |
| 08:48:09 | *** muthah_ is now known as muthah |
| 08:59:41 | <surangak> hi, a friend is having a problem working on the trunk.. he gets "Failure to find org.openmrs.api:openmrs-api:jar:tests:1.9.0-SNAPSHOT" when he tries to do a clean install |
| 09:00:03 | <surangak> as a solution, shall i get the api tests jar from my local repo and tell him to put it in his ? |
| 09:49:12 | *** gauthami has joined #openmrs |
| 09:50:38 | *** gauthami has left #openmrs |
| 09:54:17 | <bwolfe> surangak, is he doing the "clean install" at the root leveL? |
| 09:54:26 | <bwolfe> and make sure he is not skipping tests |
| 09:54:36 | <surangak> bwolfe, yep, he says that he is doing that... |
| 09:55:01 | <surangak> ah, is it the tests ? i was asking him to skip tests for now, because some were failing for him... |
| 09:56:10 | <surangak> bwolfe, sorry, would a mvn clean compile do the trick then ? |
| 09:56:36 | <bwolfe> if you say "install", then the "compile" step is done at some point |
| 09:56:41 | <bwolfe> but you can try to see if that makes a diff |
| 09:57:48 | <surangak> bwolfe, let me ry that... but if all else fails, giving him the jar is the fastest solution isnt it :) |
| 09:57:59 | <bwolfe> yes, probably |
| 09:58:42 | <surangak> bwolfe, (thumbs up) |
| 10:14:08 | <bwolfe> dkayiwa, what are you planning to do on the ws help.jsp page? |
| 10:27:06 | <surangak> bwolfe, sorry, i just got the error message off him, its [ERROR] Failed to execute goal on project openmrs-web: Could not resolve dependencies for project org.openmrs.web:openmrs-web:jar:1.9.0-SNAPSHOT: Could not find artifact org.openmrs.api:openmrs-api:jar:tests:1.9.0-SNAPSHOT in openmrs-repo |
| 10:28:01 | <bwolfe> and you're sure he's running (or has run) "mvn clean install" at the root level? |
| 10:28:04 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Full version OpenMRS <http://forum.openmrs.org/viewtopic.php?f=11&t=790#p2991> |
| 10:28:22 | <surangak> bwolfe, yeps, i got him to double check on that one |
| 10:28:25 | <bwolfe> is he using trunk? |
| 10:28:41 | <surangak> actually its Geln |
| 10:28:50 | <bwolfe> and he is not using "-DskipTests", is he? |
| 10:28:56 | <surangak> bwolfe, he was trying out my branch |
| 10:29:04 | <surangak> bwolfe, actually he was :) |
| 10:29:15 | <bwolfe> don't do that |
| 10:29:28 | <bwolfe> at least for the first run |
| 10:29:48 | <surangak> bwolfe, aha, so if i have a failing test, ill tell him to do the @Ignore instead ? |
| 10:29:55 | <bwolfe> yes |
| 10:30:16 | <surangak> bwolfe, thanks a lot, will do.... |
| 10:32:34 | <bwolfe> dkayiwa, what are you planning ot do with the help.jsp page? |
| 10:41:24 | *** surangak has quit IRC |
| 10:41:34 | *** surangak has joined #openmrs |
| 10:55:24 | *** goutham has joined #openmrs |
| 11:05:22 | <dkayiwa> bwolfe: sorry was off my computer |
| 11:06:05 | <dkayiwa> bwolfe: i have displayed a list of resources and their urls |
| 11:07:03 | <bwolfe> ok. all fancy-like, or just a normal list? |
| 11:07:12 | <dkayiwa> normal list |
| 11:09:26 | <dkayiwa> bwolfe: was adding in the representations of the various resources. But i guess i should first commit the resource listings for you to have a look? |
| 11:21:23 | *** surangak has quit IRC |
| 11:21:53 | <dkayiwa> bwolfe: commited |
| 11:31:18 | *** upul` has left #openmrs |
| 11:31:21 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Upgrading springframework library 3.0.5 to improve ws module compatibility in the 1.8.x line <http://feedproxy.google.com/~r/OMRStrunk/~3/3cXcbAQ8Alw/OpenMRS> |
| 11:44:50 | <bwolfe> dkayiwa, you should use the global property for the url instead of determining it on the fly. |
| 11:44:58 | <bwolfe> (although your logic in there was pretty good) |
| 11:46:41 | *** dkayiwa_ has joined #openmrs |
| 11:46:41 | *** dkayiwa has quit IRC |
| 11:46:42 | *** dkayiwa_ is now known as dkayiwa |
| 11:47:52 | <bwolfe> dkayiwa, you should also move your logic about finding the controllers to a central place. won't your documentation script use that too? |
| 11:48:05 | <dkayiwa> ok |
| 11:48:09 | <bwolfe> (you might have missed this one) dkayiwa, you should use the global property for the url instead of determining it on the fly. |
| 11:48:09 | <bwolfe> (although your logic in there was pretty good) |
| 11:48:44 | <bwolfe> you can determine the right controllers by all the ones that extend BaseRestController, instead of listing out all the other non-resource controllers |
| 11:49:02 | <dkayiwa> oh i see |
| 11:49:08 | <dkayiwa> thanks for the tip |
| 11:49:41 | <bwolfe> the help.jsp needs some localization too |
| 11:49:44 | <bwolfe> but looks fine |
| 11:49:49 | <dkayiwa> ok |
| 11:50:22 | <bwolfe> if/when you are done with listing those out you can make it into a expandable/collapsable tree with jquery pretty easily. |
| 11:50:25 | *** bryq has quit IRC |
| 11:50:32 | <dkayiwa> ok |
| 11:51:11 | <bwolfe> and if you do get the representations in there pretty easily, then this could be how we generate the docs for the wiki too. :-) |
| 11:51:40 | <bwolfe> are you just going to iterate over the returned objects to get the representations? or do something fancier like you did for the docstest? |
| 11:52:11 | <dkayiwa> still thinking :) |
| 11:52:21 | <bwolfe> heh |
| 11:52:58 | <bwolfe> actually, just iterating over the object won't work because there are some conditionally shown parts of it |
| 11:53:14 | <dkayiwa> ok |
| 12:08:00 | *** james_regen has joined #openmrs |
| 12:08:00 | *** ChanServ sets mode: +v james_regen |
| 12:11:02 | *** muthah has quit IRC |
| 12:11:39 | *** muthah has joined #openmrs |
| 12:21:23 | <asgoyal_> bwolfe: how to automate clicking OK for a confirm pop up in selenium? |
| 12:23:19 | *** guduji has joined #openmrs |
| 12:25:42 | *** bwolfe has quit IRC |
| 12:26:56 | *** bwolfe has joined #openmrs |
| 12:26:56 | *** ChanServ sets mode: +o bwolfe |
| 12:42:43 | *** bwolfe_ has joined #openmrs |
| 12:42:43 | *** ChanServ sets mode: +o bwolfe_ |
| 12:44:21 | <bwolfe_> asgoyal_, I don't know how to click on a popup really |
| 12:44:33 | <asgoyal_> oh ok |
| 12:46:57 | *** bwolfe has quit IRC |
| 12:49:00 | *** bwolfe_ is now known as bwolfe |
| 12:49:23 | <bwolfe> asgoyal_, have you fixed any of the tests yet? or figured out why its failing? I'd love to get the APPTEST branch cleaned up and merged soon! |
| 12:52:29 | <guduji> yes |
| 12:52:38 | <guduji> i m working on apptest 23 now |
| 12:52:47 | <guduji> i mean almost done but stuck at some point |
| 12:53:04 | <guduji> will do it today .. right now studying some tutorials to figure out trunk 235 |
| 12:53:12 | <guduji> and also need to start with trunk 2193 |
| 12:53:24 | <guduji> as for the browser problem |
| 12:53:40 | <guduji> all i did is i "downgraded" my firefox from 5 to 4 :D |
| 12:55:43 | <guduji> bwolfe: i think i attached a patch for apptest 23 |
| 12:55:56 | <guduji> and put it up for code review |
| 12:56:19 | *** gauthamikmit has joined #openmrs |
| 13:02:09 | <bwolfe> guduji, I see nothing on APPTEST-23 |
| 13:02:16 | <bwolfe> !ticket APPTEST-23 |
| 13:02:16 | <OpenMRSBot> bwolfe: Allow me to help you with that. More details on ticket APPTEST-23 can be found at http://tickets.openmrs.org/browse/APPTEST-23 |
| 13:02:25 | <guduji> a min let me see |
| 13:03:31 | <guduji> bwolfe: oops its apptest-22 |
| 13:03:34 | <guduji> sorry for that |
| 13:03:49 | <guduji> add a regimen for a patient |
| 13:06:09 | <bwolfe> guduji, you create a new project in eclipse for each ticket?? |
| 13:06:43 | <guduji> hm... i checkout webapp branch and merge my new files for that ticket only |
| 13:07:00 | <guduji> while creating the patch i just rename them.. |
| 13:07:26 | <guduji> did i do something wrong? :/ |
| 13:08:04 | <bwolfe> not really, its just showing me your project name, which has APPTEST-22 in it, so I was wondering |
| 13:08:27 | <guduji> oh yes i renamed it while checking out |
| 13:08:52 | <bwolfe> although you should create patches as "project" patches, not "workspace" patches (the last question in the create-a-patch wizard) |
| 13:11:10 | *** schuyler1d has joined #openmrs |
| 13:12:21 | *** schuyler1d has left #openmrs |
| 13:12:57 | <guduji> bwolfe: u mean just name them as project.patch? |
| 13:13:36 | <bwolfe> no, I mean when you are in eclipse creating the patch. the last question asks what type of patch. choose "project". |
| 13:14:38 | <bwolfe> guduji, actually, lets skip that test |
| 13:14:51 | <bwolfe> the order entry sprint will change all of that, so it will have to be rewritten anyway |
| 13:14:52 | <guduji> oh |
| 13:14:58 | <bwolfe> so skip the regimen and drug stuff |
| 13:15:11 | <guduji> so all the tests related to regimen and drug not to be done? |
| 13:15:53 | <bwolfe> right, lets skip those |
| 13:15:55 | <guduji> ok |
| 13:16:30 | <guduji> ok will work on patient related stuff then |
| 13:16:39 | <guduji> one question |
| 13:16:54 | <guduji> do you know a function that can modify or update the cache of browser? |
| 13:17:10 | <guduji> like for trunk 235 |
| 13:17:22 | <guduji> i have to press shift and refresh the page to see my changes |
| 13:18:26 | <bwolfe> !ticket TRUNK-235 |
| 13:18:26 | <OpenMRSBot> bwolfe: Allow me to help you with that. More details on ticket TRUNK-235 can be found at http://tickets.openmrs.org/browse/TRUNK-235 |
| 13:19:36 | <bwolfe> guduji, I believe there is a global property listener that clears the cache whenever its saved |
| 13:19:52 | <bwolfe> because that cahce also stores some global property settings |
| 13:20:08 | <guduji> ok... i have no clue of that.. |
| 13:20:08 | <bwolfe> look for that and do the same thing in the profile form controller |
| 13:20:13 | <guduji> oh ok |
| 13:20:20 | *** r7friedman has joined #openmrs |
| 13:20:23 | <bwolfe> go to the GlobalPropertyListener class |
| 13:20:26 | *** r7friedman is now known as r-friedman |
| 13:20:39 | <bwolfe> right click on the name and look for project references |
| 13:20:56 | <guduji> wyclif told me to use response.setheader("expires", 0) |
| 13:20:57 | <guduji> oh ok |
| 13:21:18 | <bwolfe> no, its in openmrs somewhere |
| 13:21:38 | <guduji> alrighty searching it |
| 13:22:32 | <guduji> bwolfe: its an interface with three functions |
| 13:23:00 | <bwolfe> yes, now find references to it |
| 13:23:11 | <bwolfe> one of the references will lead you to the cache setting and how its being cleared |
| 13:23:19 | <guduji> oh |
| 13:23:41 | <guduji> in eclipse.. hehe oki.. i was searching in normal file system of ubuntu :P |
| 13:24:08 | <bwolfe> control-shift-t in eclipse to find classes |
| 13:24:24 | <bwolfe> control-shift-r to find other non-java files |
| 13:25:16 | <guduji> oh ok |
| 13:27:38 | <guduji> i found the file now after right clicking it which option will give me its references? |
| 13:28:39 | <bwolfe> guduji, this will seem rude, but I can't say it any other way |
| 13:28:42 | <bwolfe> just look for it. :-) |
| 13:29:34 | <guduji> lol |
| 13:32:20 | <guduji> sorry i have a habit of asking too many questions :) |
| 13:32:49 | <bwolfe> but in the time it took you to type out the question you would have found it! :-) |
| 13:34:56 | *** dkayiwa_ has joined #openmrs |
| 13:35:14 | <guduji> hehe i understand :) |
| 13:37:00 | *** dkayiwa has quit IRC |
| 13:37:00 | *** dkayiwa_ is now known as dkayiwa |
| 13:42:29 | *** jriley has joined #openmrs |
| 13:48:06 | *** cta has joined #openmrs |
| 13:48:12 | *** rafa has quit IRC |
| 13:49:03 | <cta> ÑÑÐ´Ð´Ñ |
| 13:49:08 | <cta> hello |
| 13:49:24 | <dkayiwa> hi |
| 13:49:41 | <dkayiwa> ÑÑÐ´Ð´Ñ |
| 13:50:29 | *** gbastien has joined #openmrs |
| 13:50:42 | *** james_regen has quit IRC |
| 13:51:01 | <bwolfe> heh |
| 13:51:14 | <bwolfe> dkayiwa, how do you know he wasn't swearing at you ? |
| 13:51:23 | <dkayiwa> hahahahaahhahahaha |
| 13:51:39 | <dkayiwa> i completely have no idea :D |
| 13:52:02 | <cta> guys, don't panic - that word means hello ;-) |
| 13:52:24 | <dkayiwa> thats what i suspected. But in this world, you never know :) |
| 13:52:27 | <bwolfe> cta, uh huh, sure it does... |
| 13:52:31 | *** rafa has joined #openmrs |
| 13:52:31 | *** ChanServ sets mode: +v rafa |
| 13:52:54 | <dkayiwa> cta is it Arabic or Hebrew? |
| 13:53:02 | *** gauthamikmit has quit IRC |
| 13:53:19 | <dkayiwa> or Swahili :) |
| 13:54:39 | <cta> bwolfe: stop joking, ir in russian, I beguiled keyboard layouts ;-) |
| 13:54:41 | <bwolfe> my guess is a russian variant |
| 13:54:55 | <dkayiwa> :D |
| 13:54:56 | <cta> yep |
| 13:55:21 | *** gbastien has quit IRC |
| 13:55:54 | <r-friedman> bwolfe: hi ben, do I remember correctly that there's an api call to get a person name in the currently defined name format? |
| 13:56:48 | <bwolfe> r-friedman, you do not |
| 13:57:01 | <bwolfe> and there is not |
| 13:57:17 | <r-friedman> so where does the name format have effect? |
| 13:57:42 | <bwolfe> in the name layout template |
| 13:57:49 | <bwolfe> in the web layer |
| 13:58:11 | <bwolfe> there is a portlet that displays the names |
| 13:58:38 | <r-friedman> isn't it sort of weird to have a parseName but not a buildName? |
| 13:58:55 | <r-friedman> or does parseName not use it either |
| 13:59:32 | <bwolfe> parseName does not use it |
| 13:59:44 | <bwolfe> it is a simple tri-name vs comma parser |
| 13:59:54 | <r-friedman> gah |
| 14:02:57 | *** djazayeri has joined #openmrs |
| 14:02:57 | *** ChanServ sets mode: +o djazayeri |
| 14:03:27 | <bwolfe> ok, we're going to try something new here today. we have a daily "scrum" between the openmrs developers to get their progress in the last day and what they will work on the next day (or current day) |
| 14:03:41 | <wyclif> ok |
| 14:04:05 | <rafa> I'm ready. |
| 14:04:13 | <bwolfe> djazayeri / wyclif / dkayiwa / rafa / guduji : please try to keep your responses to one line. don't break up your report into multiple. it gets hard to read especially if multiple people ask questions or give responses |
| 14:04:34 | <dkayiwa> oh i had forgotten that this time we are on IRC |
| 14:04:39 | <dkayiwa> was waiting for skype. :) |
| 14:04:55 | <bwolfe> no more skype...at least for this sprint |
| 14:05:11 | <djazayeri> bwolfe: you _do_ want long single-message responses? |
| 14:05:16 | <bwolfe> darius leads the next sprint, so he can decide how we'll do the daily scrums again |
| 14:05:21 | <bwolfe> djazayeri, yes, long single message responses |
| 14:05:55 | <bwolfe> I can go first |
| 14:07:15 | <bwolfe> today I worked on: cleaning out the inbox from the long weekend, reviewed a few tickets, committed some ws code I had written last week, reviewed my gsoc studen'ts code, finished some other ws tickets along with reviews, reviewed some apptest tickets, started on some random tickets-with-attachments from other volunteers |
| 14:07:48 | *** gbastien has joined #openmrs |
| 14:07:50 | <bwolfe> tomorrow I plan to: review ws commits, review apptest tickets, have 4 hours of design conf calls. |
| 14:07:52 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: i2b2 Export 1.0.6 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=i2b2export&version=&1.0.6> || OpenMRS Modules: Household Module 0.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=household&version=&0.0.1> || OpenMRS Modules: i2b2 Export 1.0.5 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=i2b2export&version=&1.0.5> || OpenMRS Modules: Restrict By Role 1.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=restrictbyrole&version=&1.2> || OpenMRS Modules: Google Maps Image Viewer 0.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=gmapsimageviewer&version=&0.3> || OpenMRS Modules: HTML Widgets 1.5.7 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlwidgets&version=&1.5.7> |
| 14:07:55 | <bwolfe> done. no blockers |
| 14:08:29 | <bwolfe> if no questions, djazayeri, you're up |
| 14:09:13 | <bwolfe> ( dkayiwa, wyclif, rafa, guduji: you can start typing out your reply from today so you can be ready to post it when you're up) |
| 14:09:40 | <djazayeri> Friday: |
| 14:09:40 | <djazayeri> * reviewed a bunch of order entry code |
| 14:09:40 | <djazayeri> * finished several order entry tickets |
| 14:09:40 | <djazayeri> * discussed metadata sharing UI with raffle |
| 14:09:40 | <djazayeri> Today: |
| 14:09:40 | <djazayeri> * Do web service tickets if Ben wants |
| 14:09:41 | <djazayeri> * Prepare for upcoming UI sprint |
| 14:09:44 | <djazayeri> No blockers |
| 14:10:33 | <dkayiwa> Worked on traversing controllers for the various resource urls and displayed them on the web services help page. Now working on displaying the resource object representations. I had, during the other sprint, written some code which outputs this in a unit test but it was not working when the module is deployed. So had to make some changes for it to be used by the help page. Finished that and now formatting the resource representations on the help page. NO B |
| 14:10:51 | <bwolfe> djazayeri, theres one ws sprint 2 ticket with your name on it. finish that one, then prepare for your sprint |
| 14:11:08 | <guduji> today: working on trunk 235, studying some tutorials related to springframework, will work on apptest tickets, will start with trunk 2193 |
| 14:11:31 | <bwolfe> can I call rafal raffle too? or is that just an endearing term between you and him? ;-) |
| 14:12:06 | <bwolfe> dkayiwa, see if you can reconcile the two with one convenience method. |
| 14:12:08 | <djazayeri> hah, that's just a typo between me and me at 7am |
| 14:12:14 | <rafa> bwolfe: I know nothing about raffle... |
| 14:12:35 | <dkayiwa> bwolfe: some more info |
| 14:12:37 | <bwolfe> dkayiwa, also get in touch with saptarshi to see how you or he can work on the output for the wiki |
| 14:12:47 | <dkayiwa> ok |
| 14:13:13 | <bwolfe> dkayiwa, its quite possible that we just use a simple output for now for when the module is released and get something fancier or more automatic later if/when sunny finishes using that jar |
| 14:13:26 | <dkayiwa> ok |
| 14:13:33 | <bwolfe> dkayiwa/ guduji, we're still going in order. please just queue your responses until you're up |
| 14:13:34 | <bwolfe> :-) |
| 14:13:46 | <dkayiwa> :) |
| 14:14:14 | <guduji> ok |
| 14:14:26 | <wyclif> Friday: Follow up to Move assignment of orderNumber into OrderSaveHandler and removed ORDER_STATUS, did some code review on the order-entry branch and fixed one faulty changeset i found, had a skype chat with my GSoC student |
| 14:14:51 | <wyclif> Today: i plan to complete https://tickets.openmrs.org/browse/RESTWS-149 by adding more tests, i will also work on https://tickets.openmrs.org/browse/RESTWS-149 which was assigned to me, i think these are small so i should be able to pick up another today, no blockers. |
| 14:16:07 | <bwolfe> guduji, see if you can get the apptests working in general after my commit. either theres something wrong with my setup or something isn't working right, I always was getitng errors |
| 14:16:25 | <guduji> ok |
| 14:17:30 | <bwolfe> wyclif, ok, there are only a few RESTWS tickets intentionally, so picking RESTWS-153 or RESTWS-150 |
| 14:18:15 | <dkayiwa> oh i see. i thought Ben was just being lazy :) |
| 14:18:19 | <bwolfe> djazayeri, you might be the best person for RESTWS-111 |
| 14:18:27 | <cta> bwolfe: Ben, I think that it wouldn't hurt if I'll done ticket or two within current sprint, so which ticket can you give me? |
| 14:18:34 | <bwolfe> dkayiwa, no, the goal if this week's sprint is to actually release an alpha |
| 14:18:41 | <dkayiwa> ok |
| 14:18:45 | <bwolfe> if we're all writing a ton of code it makes it hard to release |
| 14:19:15 | <bwolfe> so theres a good chance we'll finish early...which is fine. we'll all just move onto an impromptu bug fix sprint or an "off week / cleanup week" |
| 14:19:33 | <djazayeri> bwolfe: I'll take a look at that. |
| 14:19:37 | <bwolfe> cta, ah yes, saw you sign up today, thanks! |
| 14:19:58 | <cta> np |
| 14:20:58 | <bwolfe> cta, I actually really want this ticket in: https://tickets.openmrs.org/browse/RESTWS-138 think you can tackle it? |
| 14:21:19 | <bwolfe> (it was voted out by Burke/Darius a few weeks ago due to our end goal of this week) |
| 14:21:27 | <wyclif> ok |
| 14:22:47 | <bwolfe> rafa ? |
| 14:22:49 | <rafa> bwolfe: Didn't you forget about me? :) |
| 14:23:04 | <rafa> Yesterday/Today: Finished TRUNK-2428, META-81, META-82. Worked on TRUNK-2432, META-89. Tomorrow: Will backport TRUNK-2432, finish META-89, adjust default actions (META), add the "trust" button (META). No blockers. |
| 14:23:12 | <bwolfe> nope, just making sure there aren't questions before going on. thanks for being patient! |
| 14:24:01 | <bwolfe> rafa, how many more tickets in META before you're ready for a release and to join us in our regular sprinting? :-) (cc djazayeri) |
| 14:24:40 | <djazayeri> I was going to ask the same. Can we wrap that up this week? |
| 14:24:53 | <rafa> definitely! |
| 14:25:33 | <cta> bwolfe: Ben, You can assign it to me, I'll trying to do it in best way |
| 14:25:57 | <rafa> I will answer to no more change requests for this release ;) |
| 14:26:47 | <bwolfe> rafa, so just META-89 and then package and release (and document?) ? |
| 14:27:05 | <djazayeri> Well, I imagine it will need a round of public comment. |
| 14:27:25 | <rafa> bwolfe: right, adjusting actions and the trust button is a piece of cake |
| 14:28:49 | <bwolfe> rafa, is this addressing everything from the dev call pres? |
| 14:29:41 | <rafa> bwolfe: Sadly not all. |
| 14:30:04 | <bwolfe> unacceptable |
| 14:30:12 | <bwolfe> ;-) |
| 14:30:17 | <rafa> There's no enhanced comparison. |
| 14:30:47 | <bwolfe> ah yes, that will take some work |
| 14:30:55 | *** james_regen has joined #openmrs |
| 14:30:55 | *** ChanServ sets mode: +v james_regen |
| 14:30:58 | <bwolfe> can you at least do a slightly enhanced comparison |
| 14:31:05 | <rafa> bwolfe: days are too short ;) |
| 14:31:05 | <bwolfe> just provide a small amount of more data? |
| 14:31:23 | <rafa> bwolfe: I could use a hack to display some extra data for concepts |
| 14:31:33 | <rafa> bwolfe: but it will have to be rewritten at some point |
| 14:32:06 | <bwolfe> I'd feel fine about a quick hack for the 90% use case object. but djazayeri can have the final say on it |
| 14:32:41 | <djazayeri> I'm fine doing a special-case for concepts |
| 14:32:57 | <djazayeri> for almost everything else just the name and description is enough |
| 14:33:13 | <rafa> okay, I'll add that. |
| 14:33:24 | <bwolfe> awesome. |
| 14:33:46 | *** yanokwa has quit IRC |
| 14:33:46 | <bwolfe> so in a few days you can join the ws sprinting |
| 14:33:53 | <bwolfe> and we can see a MDS release |
| 14:34:14 | <rafa> I can't wait :) |
| 14:34:52 | <bwolfe> great. any other issues? |
| 14:34:59 | *** yanokwa has joined #openmrs |
| 14:34:59 | *** ChanServ sets mode: +v yanokwa |
| 14:35:10 | <rafa> It's all from me, thanks. |
| 14:35:38 | <bwolfe> ok, EOB |
| 14:36:05 | <dkayiwa> none from me |
| 14:36:28 | <djazayeri> catch you all in a few |
| 14:36:40 | <djazayeri> rafa: do we need to discuss anything on those MDS tickets/ |
| 14:37:41 | <wyclif> ok |
| 14:38:06 | <rafa> djazayeri: No need. I'll handle them. |
| 14:38:22 | <djazayeri> ok, let me know when you've got something testable. |
| 14:38:27 | <djazayeri> (or at least that will show the UI steps) |
| 14:39:53 | <guduji> bwolfe: do you have some time? |
| 14:40:00 | <rafa> djazayeri: Sure. |
| 14:40:33 | <r-friedman> djazayeri: |
| 14:40:43 | *** dkayiwa has quit IRC |
| 14:40:51 | <djazayeri> yes r-friedman? |
| 14:41:07 | <r-friedman> darius, the other day you said there was a generalized way of handling embedded objects for metadata sharing that you did for htmlforms |
| 14:41:11 | <r-friedman> where can i find it? |
| 14:41:56 | <djazayeri> rafa: have we documented what htmlformentry needed to do to integrate with metadata sharing? |
| 14:42:10 | <djazayeri> (though we're changing it in the latest version...) |
| 14:42:20 | <r-friedman> nothing is constant but change |
| 14:42:28 | <rafa> djazayeri: yes, it's under construction. |
| 14:42:38 | <djazayeri> r-friedman: the best way at this point is probably to just ask rafa. |
| 14:42:51 | <r-friedman> ok will do tks |
| 14:43:14 | <r-friedman> rafa: do you have a minute to discuss with me? |
| 14:43:15 | <djazayeri> rafa: we should create a wiki page giving a very brief description of it and a "draft / changing rapidly" text |
| 14:43:31 | <r-friedman> or better to spend time making wiki :-) |
| 14:43:51 | *** bwolfe has quit IRC |
| 14:43:52 | <rafa> r-friedman: I'll document everything by the end of this week. |
| 14:44:14 | <r-friedman> ok, just let me know when and where it's there |
| 14:44:27 | <r-friedman> maybe via dev list |
| 14:44:27 | <rafa> r-friedman: Ok! |
| 14:44:34 | <r-friedman> tks |
| 14:46:06 | <rafa> guys, what is the best way to backport changes from trunk to other branches? Do you checkout all branches and apply changes one by one? |
| 14:51:08 | <cta> bwolfe: Correct me if I wrong. As I understood, within ticket restws-138 we should add new HL7Messages controller class and handle next operations: GET (for receiving status of HL7 message within queue), POST (for pushing message into HL7 queue) and DELETE (for removing message from queue). Right? |
| 14:51:57 | *** pascal` has quit IRC |
| 14:59:29 | <djazayeri> rafa: I check out all the branches |
| 15:00:05 | <djazayeri> Usually for some of them you can use team -> merge from eclipse |
| 15:00:37 | <djazayeri> or else you get the relevant changeset as unified diff, and apply that as team -> apply patch |
| 15:00:58 | <djazayeri> usually as you get to the older branches you may run into differences, and need to commit manually. |
| 15:01:04 | <djazayeri> I mean: make changes manually. |
| 15:01:47 | <djazayeri> cta: the most important part is that you be able to POST to push messages into the queu. |
| 15:02:18 | <djazayeri> The rest is bonus. |
| 15:02:21 | *** Echidna has quit IRC |
| 15:02:30 | <cta> djazayeri: so, for now I can ignore rest? |
| 15:02:31 | <rafa> djazayeri: Okay, thanks. It's the way I do it. I hoped for anything less manual :) |
| 15:02:47 | <djazayeri> you only have to go back as far as 1.6.x. :-) |
| 15:02:57 | <djazayeri> cta: sure, do the POST first. |
| 15:03:23 | <djazayeri> cta: since this has non-standard behavior (I think) you might want to just extend BaseRestController, instead of the CrudController. |
| 15:03:58 | *** danielf` has quit IRC |
| 15:05:38 | <cta> djazayeri: Thanx for clarification, Darius. |
| 15:15:26 | <guduji> Djazayeri: do you have some time, Darius? |
| 15:16:12 | *** muthah has quit IRC |
| 15:17:14 | *** muthah has joined #openmrs |
| 15:17:25 | <djazayeri> guduji: what's up? |
| 15:17:55 | <cta> djazayeri: I'll be off for next 2 hours. I gotta get home. |
| 15:18:20 | *** cta has quit IRC |
| 15:18:24 | <guduji> can you explain in short how this file is functioning PseudoStaticContentController.java |
| 15:21:26 | <djazayeri> guduji: hopefully you shouldn't need to know... |
| 15:22:17 | <guduji> oh... cuz for trunk 235 i need to update the cache for reflecting the changes |
| 15:22:32 | <djazayeri> remind me what's going on? |
| 15:22:37 | <guduji> oh ok |
| 15:22:47 | <djazayeri> So, when the user clicks a checkbox to change their settings |
| 15:22:51 | <guduji> yes |
| 15:23:00 | <guduji> that must be reflected on dictionary link |
| 15:23:06 | <djazayeri> okay |
| 15:23:16 | <guduji> if i do shift+refresh |
| 15:23:16 | <djazayeri> but why do you need to modify a javascript file in this case? |
| 15:23:20 | <guduji> the change is reflected |
| 15:23:36 | <guduji> I modified the openmrsSearch.js file |
| 15:23:40 | <djazayeri> Really javascript code should be static, and it should be up to the page to pass it the relevant configuration. |
| 15:24:10 | <djazayeri> you modified the openmrsSearch.js file by adding a parameter? Or by doing <openmrs:something.../> |
| 15:24:11 | <djazayeri> ? |
| 15:24:49 | <guduji> like i also added openmrs:userproperty tag in openmrsmessages.js.withjstl |
| 15:24:51 | <guduji> then |
| 15:25:24 | <guduji> used that variable in if statement.. to set the checkbox |
| 15:25:46 | <djazayeri> Okay, I understand. |
| 15:25:56 | <guduji> now that withjstl file |
| 15:25:58 | <guduji> is cached |
| 15:26:04 | <guduji> i need to update its new values |
| 15:26:19 | <djazayeri> Okay, so the idea behind the PseudoStaticContentController is that javascript code is supposed to be static, and cacheable. |
| 15:26:27 | <guduji> oh ok |
| 15:27:07 | <djazayeri> However back in 2005 we didn't realize this and we made several js pages require global properties and/or message translations |
| 15:27:18 | <guduji> oh ok |
| 15:27:29 | <guduji> oh then i need to do the same for user properties |
| 15:28:11 | <djazayeri> the PseudoStaticContentController basically makes it such that if you name a file .js.withjstl it will be rebuilt dynamically every request, instead of done statically once. |
| 15:28:27 | <guduji> ah ok |
| 15:29:09 | <djazayeri> so... |
| 15:29:13 | <guduji> now how are the overriden functions helping in changing the cache? |
| 15:29:28 | <guduji> cuz they just set a variable |
| 15:29:31 | <guduji> lastmodified |
| 15:29:45 | <djazayeri> So, caching is basically handled by the web server and client. |
| 15:29:50 | <guduji> ahm |
| 15:30:31 | <djazayeri> that is based on us proving a last-modified date |
| 15:31:01 | <guduji> ah ok i get it .. the getlastmodified function returns the last modified date to the servletdispatcher |
| 15:31:06 | <djazayeri> i.e. if the last-modified date has changed, the server will send a new copy of the file to the client, otherwise it will just tell the client (i.e. the browser) that js file is the same. |
| 15:31:20 | <guduji> oh alright |
| 15:32:02 | *** rafa has quit IRC |
| 15:32:04 | <guduji> so i need to do the same for user properties |
| 15:32:17 | <djazayeri> So, in order to avoid making the client reload that file every time, we use this last-modified date to only have to reload when "something" has changed |
| 15:32:31 | <djazayeri> Currently "something" just means global properties |
| 15:32:31 | <guduji> ahm understood |
| 15:32:34 | <guduji> yep |
| 15:32:46 | <guduji> what if i add function to this file itself to handle user properties? |
| 15:35:10 | <djazayeri> I think you should add a public static method to PseudoStaticContentController like |
| 15:35:36 | *** muthah has quit IRC |
| 15:35:38 | <djazayeri> (comment) Call this method when something has changed that should trigger files clients have cached to expire (/comment) |
| 15:35:38 | <djazayeri> notifyOfChange() |
| 15:36:07 | <djazayeri> and then call that when a user property is saved |
| 15:36:12 | <djazayeri> from the user property save controller. |
| 15:36:41 | <djazayeri> This is a bit hacky, and it's possible that in code review we'll decide it's not quite good enough... |
| 15:37:25 | <djazayeri> The "right" solution would be to write an interface UserPreferenceListener that's like GlobalPropertyListener |
| 15:37:43 | <djazayeri> But I recommend doing it the quick and hacky way to start. |
| 15:39:12 | *** wyclif has quit IRC |
| 15:41:02 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.6.x): CODE REVIEW (POST-COMMIT) - issue TRUNK-2432: ValidateUtil does not validate Concept ... <http://feedproxy.google.com/~r/OMRStrunk/~3/6udbAryxGhU/OpenMRS> || New Changeset: OpenMRS (1.7.x): CODE REVIEW (POST-COMMIT) - issue TRUNK-2432: ValidateUtil does not validate Concept ... <http://feedproxy.google.com/~r/OMRStrunk/~3/ItHNFBFM5W8/OpenMRS> || New Changeset: OpenMRS (1.8.x): CODE REVIEW (POST-COMMIT) - issue TRUNK-2432: ValidateUtil does not validate Concept ... <http://feedproxy.google.com/~r/OMRStrunk/~3/MtFJWtCD-lc/OpenMRS> |
| 15:42:23 | <guduji> djazayeri: ok darius |
| 15:42:30 | <guduji> i will make a new controller then for that |
| 15:42:40 | <guduji> thanks for your help :) |
| 15:42:51 | <djazayeri> guduji: not a new controller |
| 15:42:58 | <djazayeri> a new method in that controller |
| 15:43:01 | <guduji> oh |
| 15:43:06 | <djazayeri> and call that method from the save user preferences controller |
| 15:43:38 | <guduji> oh ok |
| 15:43:54 | <guduji> i will check it out |
| 15:44:30 | <guduji> alright i will be out for 2 hours to help a new employee with his documents |
| 15:44:36 | <guduji> thanks dj :)) |
| 15:53:57 | *** pascal` has joined #openmrs |
| 16:01:29 | *** bryq has joined #openmrs |
| 16:01:29 | *** ChanServ sets mode: +v bryq |
| 16:02:06 | <guduji> djazayeri: I couldn't find the controller that u mentioned dj |
| 16:02:20 | <guduji> (back) |
| 16:03:56 | *** jriley has left #openmrs |
| 16:09:31 | <guduji> djazayeri: save user preference controller ... which file is it? |
| 16:10:39 | <guduji> optionsformcontroller.java? |
| 16:12:48 | <guduji> nvm i found it thanks :) |
| 16:19:15 | *** guduji has quit IRC |
| 16:20:54 | *** james_regen has quit IRC |
| 16:21:29 | *** james_regen has joined #openmrs |
| 16:21:29 | *** ChanServ sets mode: +v james_regen |
| 16:24:22 | *** wyclif has joined #openmrs |
| 16:29:35 | *** mandric has joined #openmrs |
| 16:51:50 | *** cta has joined #openmrs |
| 16:53:20 | <cta> !ticket RESTWS-138 |
| 16:53:20 | <OpenMRSBot> cta: Allow me to help you with that. More details on ticket RESTWS-138 can be found at http://tickets.openmrs.org/browse/RESTWS-138 |
| 16:59:09 | *** guduji has joined #openmrs |
| 17:10:01 | *** rafa has joined #openmrs |
| 17:10:01 | *** ChanServ sets mode: +v rafa |
| 17:11:11 | *** rafa has quit IRC |
| 17:19:53 | *** goutham has quit IRC |
| 17:20:20 | *** goutham has joined #openmrs |
| 17:28:28 | <cta> djazayeri: Darius, clarify me if I wrong. So, for pushing hl7 message into hl7_in_queue I need to call _Context.getHL7Service().parseHL7String(String) and then, if parsing was succesfull, need to call processHL7Message(Message), right? and as result for this I should return uri and status of just created Hl7InQueue message, right? |
| 17:30:49 | <djazayeri> cta: I'm not totally sure. I 'm not very familiar with the hl7 service |
| 17:31:04 | <djazayeri> I would expect that the basic thing for you is to call saveHl7InQueue |
| 17:31:48 | <djazayeri> I know that's poorly named, but that's the method that actually represents putting something in the queue. |
| 17:31:51 | *** chopin has joined #openmrs |
| 17:31:55 | <chopin> o/ |
| 17:33:02 | <djazayeri> cta: chopin is actually the resident expert on the hl7 service |
| 17:33:06 | <djazayeri> can you repeat your question? |
| 17:34:28 | *** cta_ has joined #openmrs |
| 17:34:53 | <cta_> djazayeri: sorry, connection broken |
| 17:35:15 | <djazayeri> cta: chopin is actually the resident expert on the hl7 service |
| 17:35:40 | *** cta has quit IRC |
| 17:36:24 | <djazayeri> cta_: chopin is actually the resident expert on the hl7 service |
| 17:36:34 | <djazayeri> can you repeat your question? |
| 17:36:42 | <chopin> :-) |
| 17:36:42 | <cta_> yes |
| 17:37:17 | <cta_> chopin: Jeremy, clarify me if I wrong. For pushing hl7 message into hl7_in_queue I need to call _Context.getHL7Service().parseHL7String(String) and then, if parsing was succesfull, need to call processHL7Message(Message), right? and as result for this I should return uri and status of just created Hl7InQueue message, right? |
| 17:37:44 | <chopin> cta_, checking ... one sec ... |
| 17:38:00 | <djazayeri> I said: you want to call hl7Service.saveHl7InQueue |
| 17:38:06 | <djazayeri> that's how you put something in the queue. |
| 17:38:11 | <chopin> YES |
| 17:38:12 | <djazayeri> the parse method is supposed to be internal |
| 17:38:15 | <chopin> that's how it works |
| 17:38:33 | <chopin> ah right ... cta_: you just create a HL7InQueue object and save it |
| 17:38:35 | <chopin> that enqueues it |
| 17:38:51 | <cta_> chopin: Thank you, Jeremy |
| 17:38:58 | <chopin> yep, don't need to parse the string |
| 17:39:03 | <chopin> just save it as the HL7Data |
| 17:39:38 | <chopin> cta_: you can process an HL7 manually if you want to run tests |
| 17:39:56 | <chopin> cta_: check out the ORUR01HandlerTest class for those |
| 17:40:04 | <djazayeri> cta_: in the first pass, just put it in the queue. If possible, return some sort of token or pointer that the user can later use to check the status. |
| 17:40:30 | <chopin> HL7s usually have a unique message Id you could use as the token |
| 17:40:40 | <cta_> djazayeri, chopin Ok, I will take it in my account |
| 17:40:43 | <djazayeri> does hl7_in_queue have a uuid? |
| 17:41:16 | <chopin> idk ... but that UUID dies when the HL7 goes to the archives or the error queue |
| 17:41:52 | <djazayeri> oh, okay |
| 17:42:00 | <djazayeri> that's too bad. |
| 17:42:04 | <chopin> it is |
| 17:42:23 | <chopin> it's also unfortunate that we don't have an audit trail for HL7 -> encounter/visit/obs ... |
| 17:42:41 | <djazayeri> cta_: one benefit of doing this ticket is going to help us figure out what's going on... |
| 17:43:03 | <cta_> ok |
| 17:43:50 | <cta_> one more question - I'm receiving hl7 message from REST as just string so it goes that I need to parse it somehow for having oportunity to call saveHl7InQueue(HL7InQueue), right? |
| 17:45:05 | <djazayeri> hmm |
| 17:45:23 | <djazayeri> chopin: do you think we should create an HL7 Source to represent the rest ws module? |
| 17:45:42 | <djazayeri> or should the client be required to specify a source by uuid/name? |
| 17:46:26 | <djazayeri> cta_: you need to instantiate an HL7InQueue object, and set all these properties: hl7Source, hl7SourceKey (maybe), hl7Data (this is the string passed in). |
| 17:47:06 | *** bwolfe has joined #openmrs |
| 17:47:06 | *** ChanServ sets mode: +o bwolfe |
| 17:47:09 | <chopin> djazayeri: in practice, HL7Source hasn't been used (at AMPATH) ... but it seems appropriate to generate one for WS |
| 17:47:16 | <djazayeri> bwolfe: welcome. :-) |
| 17:47:24 | <djazayeri> we're talking about the POST hl7 via ws ticket |
| 17:47:43 | <djazayeri> do you think we should create an HL7 Source to represent the rest ws module? or should the client be required to specify a source by uuid/name? |
| 17:47:57 | <bwolfe> client required |
| 17:48:01 | <bwolfe> they can create one if they want to |
| 17:48:30 | <bwolfe> the source could be a lims system that just so happens to be submitting over rest |
| 17:49:07 | <djazayeri> Okay, but does the client just get to decide what source it represents? Or is there some authorization model? |
| 17:49:22 | <djazayeri> Probably a question for the dev list. |
| 17:49:50 | <djazayeri> cta_: the quick answer is that the client is required to provide a uuid/name to represent the hl7Source |
| 17:49:56 | <bwolfe> I'd go with the client deciding |
| 17:50:28 | <chopin> the source could be a string and if it doesn't match, WS responds with an appropriate error |
| 17:50:29 | <djazayeri> chopin, bwolfe: what's hl7SourceKey? |
| 17:50:38 | <bwolfe> def go with client deciding as the first step. we can debate and choose something more spectacular in version 1.1 |
| 17:50:44 | <chopin> source key is a unique id within that source (i think) |
| 17:50:50 | <djazayeri> cta_: just write a standard Resource/Converter for Hl7Source |
| 17:50:58 | <bwolfe> its a unique number passed through from the original, iirc |
| 17:51:05 | <cta_> cool, so it goes that we will use Hl7InQueue as generic parameter for Hl7MessageResource and will specify what source to set by uuid/name? right? |
| 17:51:08 | <djazayeri> Do a placeholder. |
| 17:51:22 | <bwolfe> was something burke threw in to track which hl7 messages came from which forms |
| 17:51:53 | <djazayeri> cta_: please do *not* let the web service client know that there's something called "HL7InQueue" |
| 17:51:57 | <chopin> there is a default source of "Local" in all implementations (i think) |
| 17:52:16 | <djazayeri> (local is not appropriate for something posted via ws) |
| 17:52:31 | <chopin> right |
| 17:53:09 | <djazayeri> I recommend creating a helper class in the ws module that's going to represent an hl7 message, no matter what queue it's in. (In/Archive/Error) |
| 17:53:29 | <djazayeri> e.g. call it IncomingHl7Message or something |
| 17:53:56 | <djazayeri> as far as the client is concerned, they have to provide a source, sourceKey, and hl7Data |
| 17:54:27 | <djazayeri> they get back something with a unique id (start with uuid, though Jeremy points out this is insufficient) and a status |
| 17:54:39 | <cta_> djazayeri: and use it class as generic for resource? |
| 17:54:46 | <djazayeri> yes |
| 17:55:02 | <cta_> cool, I understand ;-) |
| 17:56:08 | *** kishoreyekkanti has joined #openmrs |
| 17:59:25 | *** kishoreyekkanti has quit IRC |
| 17:59:49 | <cta_> djazayeri: will client provide source, sourceKey, and hl7Data within JSON e.g "{ source : {"test"} sourceKey : {"test key"} hl7Data : {"data||||fg||"} }"? |
| 18:00:13 | <djazayeri> yes |
| 18:00:42 | *** kishoreyekkanti has joined #openmrs |
| 18:03:43 | <kishoreyekkanti> Hi, I have a basic question around submitting the patches. |
| 18:04:20 | <kishoreyekkanti> I've done with a story TRUNK-2267 and attached the patch. Currently it is in Code Review stage. |
| 18:04:30 | <cta_> djazayeri, chopin, bwolfe: thank |
| 18:04:59 | <djazayeri> kishoreyekkanti: normally at that point one would just wait until it gets reviewed |
| 18:05:03 | <kishoreyekkanti> I've picked up the story TRUNK-2257 now. Can the patch submitted for TRUNK-2257 can have the details of TRUNK-2267 |
| 18:05:14 | <djazayeri> But in this case thanks for reminding me, because I'd forgotten about it. |
| 18:05:55 | <kishoreyekkanti> djazayeri: :) ok no problem.. I've just now completed the story TRUNK-2257 and was wondering how to submit the patch. |
| 18:05:59 | <djazayeri> you may include the files from the prior patch in the second patch, if it's a dependent ticket. |
| 18:06:29 | <djazayeri> But actually, you're working in a branch, right? |
| 18:06:33 | <djazayeri> there's a providers branch? |
| 18:06:37 | <kishoreyekkanti> yeah exactly |
| 18:06:49 | <kishoreyekkanti> i'm working on providers branch |
| 18:07:05 | <djazayeri> So, really you should just be committing to the branch, and the code review should be post-commit. |
| 18:07:29 | <djazayeri> Do you have commit privileges? |
| 18:07:45 | <kishoreyekkanti> Not sure about that lemme check it |
| 18:10:31 | <kishoreyekkanti> Actually i've forked the mirror git repository of zabil and developed on that.. |
| 18:11:08 | <kishoreyekkanti> Can you tell me whats the actual process? |
| 18:11:27 | <djazayeri> unfortunately we're using svn rather than git |
| 18:13:16 | <djazayeri> so what you should be doing (from the openmrs perspective) is that you should have checked out the code via svn, and committed from that |
| 18:13:24 | <djazayeri> I don't know how Zabil had things set up. |
| 18:13:37 | <djazayeri> with git, I mean. |
| 18:13:49 | <djazayeri> effectively you need to commit your changes to the svn repository. |
| 18:14:14 | <kishoreyekkanti> gotcha! ok! no problem i'll try to ask zabil about how he was doing that. For now can i take a patch for 2257 without the code of 2267 as they are independent tickets? |
| 18:14:44 | <kishoreyekkanti> Zabil is on vacation..I'll try to mail him.. any ways he's back on this friday 8th july. |
| 18:14:46 | <djazayeri> if the tickets are independent, then yes, better to do the patches independently |
| 18:15:02 | <djazayeri> we should move to getting you to commit code directly as soon as possible. |
| 18:15:46 | <kishoreyekkanti> Sure! definitely i'll try to make it as soon as possible |
| 18:16:06 | <kishoreyekkanti> Thanks a lot for info! |
| 18:19:22 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: i2b2 Export 1.0.7 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=i2b2export&version=&1.0.7> |
| 18:22:54 | *** mathiaslin has quit IRC |
| 18:27:43 | *** james_regen has quit IRC |
| 18:30:14 | *** mimi has joined #openmrs |
| 18:33:06 | <wyclif> djazayeri, i think uuids are not getting set on subresources |
| 18:34:34 | *** mimi has quit IRC |
| 18:35:13 | <djazayeri> wyclif: which one for example? |
| 18:35:30 | <djazayeri> and they're not getting set by whom? |
| 18:53:23 | *** djazayeri has quit IRC |
| 18:59:35 | *** djazayeri has joined #openmrs |
| 18:59:38 | *** ChanServ sets mode: +o djazayeri |
| 19:00:58 | *** pascal` has quit IRC |
| 19:01:13 | *** kishoreyekkanti has quit IRC |
| 19:01:30 | *** kishoreyekkanti has joined #openmrs |
| 19:01:42 | *** kishoreyekkanti has left #openmrs |
| 19:05:11 | <wyclif> djazayeri, person name resource |
| 19:05:38 | <djazayeri> not being set _when_? on create? on get? |
| 19:05:41 | <wyclif> i assumed the framework sets uuid |
| 19:05:46 | <wyclif> get |
| 19:06:09 | *** rafa has joined #openmrs |
| 19:06:09 | *** ChanServ sets mode: +v rafa |
| 19:07:13 | <wyclif> i think this was changed |
| 19:07:17 | <wyclif> i will include them |
| 19:08:21 | <wyclif> djazayeri, i have looked at patientIdentifierResource and it i have noticed that uuids are getting set individually in the resource |
| 19:08:39 | <djazayeri> ok |
| 19:10:26 | <rafa> bryq: Are you around? |
| 19:10:34 | <bryq> rafa: Yes |
| 19:11:03 | <rafa> bryq: I'm just reading the chat you had with Darius |
| 19:11:26 | <rafa> bryq: I'm sorry I've been missing. |
| 19:11:53 | <rafa> bryq: Totally forgot to set up a reminder. |
| 19:12:08 | <bryq> rafa: No problem. Please tell me if you don't agree with something we've stated |
| 19:12:39 | <rafa> bryq: Give me a moment :) |
| 19:16:09 | *** mandric has quit IRC |
| 19:18:47 | *** r-friedman has quit IRC |
| 19:19:48 | <rafa> bryq: I didn't really catch it, do you want to use the rest module or not? |
| 19:20:21 | <bryq> rafa: No |
| 19:20:35 | <rafa> bryq: good, I don't think it's necessary. |
| 19:20:43 | <bryq> rafa: I will not use it, I'll only follow URL conventions |
| 19:20:50 | <rafa> bryq: I like the UI and changes. |
| 19:21:41 | <bryq> rafa: Me too :) |
| 19:21:49 | <rafa> bryq: what will the error tooltips say? |
| 19:22:45 | <bryq> rafa: Now we have an error e.g. "Service unavailable", but real life user might not now what does it mans |
| 19:23:25 | <bryq> rafa: That tooltip (or image-based question mark) will explain what could be the problem |
| 19:23:33 | <rafa> bryq: Ohh okay, you just want to add a user friendly explenation. |
| 19:23:41 | <rafa> That's ok |
| 19:23:47 | <bryq> rafa: Exactly |
| 19:25:17 | <rafa> bryq: Very nice. I have nothing to add. |
| 19:25:28 | <rafa> bryq: Do you have any specific questions to me? |
| 19:25:35 | <bryq> rafa: Yes |
| 19:26:18 | <bryq> rafa: Have you read the announcement about mid-term evaluations? |
| 19:26:33 | <rafa> yes, It's next week. |
| 19:28:29 | <bryq> rafa: Okay, good :) |
| 19:29:00 | <rafa> Cool :) |
| 19:29:13 | <rafa> I won't miss that for sure |
| 19:29:50 | <bryq> rafa: I've created 5 tickets for next week work |
| 19:30:09 | <bryq> rafa: I'll do my best to finish them before presentation, to have something to show |
| 19:31:45 | <rafa> bryq: Indeed, it looks promising :) If you finish that, ot |
| 19:31:57 | <rafa> it's going to be very interesting demo :) |
| 19:32:06 | <bryq> rafa: I hope so :) |
| 19:33:26 | <rafa> bryq: Ohh and btw you should test screen sharing via connect.openmrs.org |
| 19:34:00 | <bryq> rafa: I know |
| 19:34:10 | <bryq> rafa: I'll do it next week |
| 19:35:01 | <rafa> bryq: I'll be there if you need me. |
| 19:35:25 | <bryq> rafa: Okay, thanks |
| 19:36:06 | <rafa> bryq: I'm really happy with our progress so far. |
| 19:36:18 | <rafa> bryq: Great job! |
| 19:36:38 | <cta_> bwolfe, djazayeri: I have a question about impelementing of GET hl7 message by UUID. How to accomplish this if there isn't method for getting hl7 message in_queue by UUID (currently, there is only one method for getting it by ID)? Also I can get collection of hl7_in_queue and iterate over it. |
| 19:37:15 | <bryq> rafa: I'm happy that you're happy too :) |
| 19:37:43 | <djazayeri> cta_: create a ticket for adding getHL7InQueueByUuid in the TRUNK jira project |
| 19:37:47 | <bwolfe> cta_, getting all hl7 in queue messages could bring down the system. :-) |
| 19:37:50 | <djazayeri> and leave this as a to-do later |
| 19:38:37 | <djazayeri> mention in the ticket that you create that we eventually need a mechanism to fetching hl7 messages from the three different tables (in, archive, error) |
| 19:38:39 | <cta_> djazayeri: ok, Darius |
| 19:38:59 | <rafa> bryq: We'll need to update your branch again some time soon, but probably it's better to do it after the demo ;) |
| 19:39:07 | <cta_> bwolfe: Why, Ben? |
| 19:39:19 | <bwolfe> because there might be millions of them |
| 19:39:26 | <cta_> ;-) |
| 19:39:27 | <bryq> rafa: Yes, definitely after the demo :P |
| 19:39:51 | <rafa> ;) |
| 19:40:17 | <cta_> bwolfe: and why we are still having such method if it can bring down system? |
| 19:40:26 | <djazayeri> cta_: necessary for testing |
| 19:40:36 | <djazayeri> in a production system those tables are huge |
| 19:40:46 | <rafa> bryq: Do you want to discuss anything else? |
| 19:41:01 | <cta_> djazayeri: ok, understand. Thanx |
| 19:41:09 | <cta_> bwolfe: Thnx |
| 19:41:10 | <bryq> rafa: No, that's all |
| 19:42:30 | <rafa> bryq: and all from me. Have a nice evening! |
| 19:42:59 | <bryq> rafa: Thanks! |
| 19:52:14 | <cta_> djazayeri: I've already created new ticket in JIRA as you've asked for. See https://tickets.openmrs.org/browse/TRUNK-2440 |
| 19:52:36 | <cta_> also I commited code for RESTWS-138 |
| 19:52:49 | *** rafa has quit IRC |
| 19:55:26 | *** bwolfe_ has joined #openmrs |
| 19:55:26 | *** ChanServ sets mode: +o bwolfe_ |
| 19:59:15 | *** bwolfe has quit IRC |
| 20:06:04 | *** yanokwa has quit IRC |
| 20:16:34 | *** goutham has quit IRC |
| 20:16:43 | *** goutham has joined #openmrs |
| 20:21:43 | <cta_> guys, it's half to midnight in Ukraine, so I gotta get shuteye, see tomorrow |
| 20:24:57 | *** cta_ has quit IRC |
| 20:25:07 | *** yanokwa has joined #openmrs |
| 20:25:07 | *** ChanServ sets mode: +v yanokwa |
| 20:25:10 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: i2b2 Export 1.0.8 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=i2b2export&version=&1.0.8> |
| 20:25:55 | *** yanokwa has quit IRC |
| 20:31:15 | *** bryq has quit IRC |
| 20:31:43 | *** bwolfe_ has quit IRC |
| 20:32:26 | <wyclif> djazayeri, is there a way we get units for a question concept |
| 20:33:11 | <wyclif> i.e https://tickets.openmrs.org/browse/RESTWS-149 |
| 20:33:37 | <wyclif> or this will be specific to only concept numerics? |
| 20:35:51 | <djazayeri> wyclif: only numerics |
| 20:37:03 | <wyclif> ok |
| 20:43:47 | *** Echidna has joined #openmrs |
| 20:43:47 | *** ChanServ sets mode: +v Echidna |
| 20:46:18 | *** bryq has joined #openmrs |
| 20:46:18 | *** ChanServ sets mode: +v bryq |
| 21:09:39 | *** dkayiwa has joined #openmrs |
| 21:28:38 | *** dkayiwa has quit IRC |
| 21:42:04 | <guduji> wyclif: none of them are working |
| 21:52:09 | <djazayeri> Damn, apparently I had uncommitted code for thwe rest webservice module |
| 21:52:18 | <djazayeri> (that'll teach me) |
| 21:54:33 | <guduji> djazayeri: i have a question |
| 21:55:18 | <djazayeri> ok |
| 21:55:38 | <guduji> for trunk 235 .. i have placed my implementation inside _create function |
| 21:55:48 | <guduji> is that creating cache problems for me? |
| 21:56:01 | *** wyclif has quit IRC |
| 21:56:09 | <guduji> because _create function's description says that it gets run once, immediately after instantiation. |
| 21:56:10 | <djazayeri> what function? |
| 21:56:16 | <guduji> _create |
| 21:56:17 | <djazayeri> _create for what? |
| 21:56:21 | <guduji> jquery ui |
| 21:56:55 | <djazayeri> that gets run once per time the page is loaded |
| 21:57:01 | <guduji> oh |
| 21:57:17 | <djazayeri> so, no, that's not creating a cache problem |
| 21:57:35 | <djazayeri> Have you successfully made things work, when you do a shift-refresh to force reloading of the js files? |
| 21:57:40 | <guduji> grr .. i tried all .. i cant come around that problem |
| 21:57:42 | <guduji> yes |
| 21:57:50 | <guduji> when i do shift refresh |
| 21:57:54 | <guduji> then it shows the changes |
| 21:58:24 | <guduji> the retired checkbox is checked/unchecked depending on the "my profile" |
| 21:58:40 | <guduji> (retired checkbox in dictionary link) |
| 21:58:55 | <guduji> and i tried one more thing |
| 21:59:12 | <guduji> i manually disabled the browser cache |
| 21:59:15 | <guduji> and then tried |
| 21:59:16 | <guduji> that time |
| 21:59:25 | <guduji> it was working without shift + refresh |
| 21:59:58 | *** goutham has quit IRC |
| 22:00:11 | <djazayeri> try this: change the user preference |
| 22:00:21 | <djazayeri> then go into Manage Global Properties, change anything, and re-save that page. |
| 22:00:35 | <djazayeri> then go to the dictionary search page and see if the change is reflected. |
| 22:00:57 | <guduji> let me see |
| 22:02:18 | <guduji> ok a silly quesiton.. where to find the user preference link ? :S |
| 22:02:36 | <djazayeri> my preferences |
| 22:02:41 | <djazayeri> my profile |
| 22:02:43 | <djazayeri> whatever it's called |
| 22:03:24 | <guduji> my profile ok i check the retired checkbox and saved it... and where is manage global properties link? |
| 22:04:14 | <djazayeri> admin page |
| 22:04:43 | <guduji> oh oh |
| 22:04:44 | <guduji> ok |
| 22:05:52 | <guduji> woah it works now! |
| 22:06:18 | <guduji> now how do i do that for changes only made for my profile |
| 22:06:20 | <guduji> ! |
| 22:06:38 | <djazayeri> okay, so, what happens when you save global property changes is that the GlobalPropertyListener part of PseudoStaticContentController happens. |
| 22:06:47 | <guduji> yep |
| 22:06:49 | <djazayeri> specifically, it changes the lastModifiedDate to now. |
| 22:06:53 | <guduji> yep |
| 22:07:06 | <djazayeri> Have you added another that updates that property? |
| 22:07:16 | <djazayeri> And do you call that method when the my profile page is saved? |
| 22:07:26 | <guduji> i did that too |
| 22:07:34 | <guduji> like i made a function for user properties |
| 22:07:50 | <guduji> and provided last-modified = current date |
| 22:08:05 | <guduji> hm... but... where to cal that from? |
| 22:08:14 | <guduji> from optionsformcontroller.java? |
| 22:08:38 | <djazayeri> from whichever controller method gets invoked when you click save on my profile |
| 22:08:45 | <djazayeri> probably optionsformcontroller, but I don't know offhand |
| 22:08:48 | <guduji> likeyes\ |
| 22:08:49 | <guduji> yes |
| 22:08:56 | <guduji> that is the controller |
| 22:09:37 | <guduji> so i just add a function to update last modified in that controller? |
| 22:09:50 | <djazayeri> just call the method, yes |
| 22:10:54 | <guduji> u mean make a new a function in that controller right? or call the function already defined in psuedostaticcontentcontroller? :S |
| 22:11:02 | <guduji> sorry i m confused.. |
| 22:11:28 | <djazayeri> So, step back a moment and think about what we're trying to do. |
| 22:12:06 | <djazayeri> The issue is that we have a mechanism (PseudoStaticContentController) that decides how long things should be cached. |
| 22:12:14 | <guduji> ok |
| 22:12:20 | <djazayeri> And it currently only expires the cache when a global property changes. |
| 22:12:26 | <guduji> yes |
| 22:12:34 | <djazayeri> We need to start expiring the cache when the user changes their preferences. |
| 22:12:37 | <djazayeri> also. |
| 22:12:43 | <guduji> ahm... |
| 22:16:08 | <djazayeri> guduji: and you've just added a method to PseudoStaticContentController than expires the cache. |
| 22:16:19 | <djazayeri> Soâ¦when should you call that? |
| 22:16:27 | <guduji> when the |
| 22:16:33 | <guduji> profile form is changed |
| 22:16:39 | <guduji> which will call the controller file |
| 22:17:17 | <guduji> right? |
| 22:17:25 | <djazayeri> Yes. |
| 22:18:13 | <guduji> the thing is .. i dont know how the other controller files are calling the psuedo files functions... :S that is why i m confused.. i m checking that now |
| 22:18:33 | <djazayeri> guduji: nothing else ever calls PseudoSCC |
| 22:18:42 | <guduji> ... |
| 22:18:45 | <djazayeri> As I mentioned this morning, this whole thing is a hacky. |
| 22:19:07 | <djazayeri> So make the method you created public static, and just call it by name from the options controller |
| 22:19:35 | <guduji> wow with just one statement to last modified = current date? |
| 22:20:28 | <djazayeri> yes |
| 22:20:30 | <guduji> i was trying response.setHeader() |
| 22:20:34 | <guduji> wow.. ok |
| 22:20:35 | <djazayeri> no |
| 22:21:02 | <djazayeri> the PseudoSCC already handles caching, it just doesn't know about this new additional time to expire the cache |
| 22:21:08 | <djazayeri> so all you have to do is tell it about that. |
| 22:21:30 | <guduji> oh ok |
| 22:34:28 | *** bryq has quit IRC |
| 22:38:16 | <guduji> it works!! |
| 22:39:00 | <guduji> (oh my god... i feel so dumb...) |
| 22:40:08 | <djazayeri> if it's any consolation I'm feeling pretty dump now too... |
| 22:40:41 | <djazayeri> I just noticed that I have two copies of the rest web service project checked out, one has local changes, but I don't remember if I meant to commit them or not. |
| 22:40:43 | <guduji> why... i feel dumb cuz i cannot figure out these simple things... |
| 22:41:13 | <djazayeri> guduji: that ticket turned out to have a particularly tricky aspect to it. |
| 22:41:21 | <guduji> O.o |
| 22:41:33 | <guduji> no but it was still simple |
| 22:41:38 | <guduji> i feel so dumb now... |
| 22:41:46 | <guduji> wasted like whole day for this issue! |
| 22:42:15 | <guduji> and .. i m still in little bit of confusion over the psuedo file |
| 22:42:44 | <guduji> the last modified variable it is sent to the servlet dispatcher... wheere can i find that xml file where the mapping is done? :S |
| 22:44:54 | <djazayeri> it's in openmrs_static_content-servlet.xml |
| 22:45:01 | <guduji> oh ok |
| 22:45:09 | <guduji> one last question |
| 22:45:16 | <djazayeri> if you're using eclipse, or any other IDE, you can just search the project for files with text "pseudostatic" |
| 22:45:31 | <guduji> oh |
| 22:46:19 | *** yanokwa has joined #openmrs |
| 22:46:19 | *** ChanServ sets mode: +v yanokwa |
| 22:46:21 | <guduji> so one last question |
| 22:46:43 | <guduji> all i knew was that pom.xml is the boss behind all this |
| 22:46:57 | <guduji> so .. now the one which u mentioneed.. is a created one |
| 22:47:09 | <guduji> so do we have to do the mapping for that in pom.xml file too? |
| 22:47:18 | <djazayeri> pom.xml isn't really the boss of everything |
| 22:47:26 | <guduji> ! |
| 22:47:31 | <djazayeri> it describes the structure and dependencies of the maven project |
| 22:47:46 | <guduji> so that means we can create our own .xml files .. but how is the mapping done? |
| 22:47:48 | <djazayeri> but it doesn't really describe anything about the application itself |
| 22:47:59 | <djazayeri> web.xml |
| 22:48:04 | <guduji> woah |
| 22:48:18 | <djazayeri> web.xml is what includes both openmrs-servlet.xml and openmrs_static_content-servlet.xml |
| 22:48:27 | <djazayeri> You rarely have to care about those things though. |
| 22:48:45 | <guduji> nah just curious... |
| 22:48:54 | <djazayeri> web.xml is referred to as "the deployment descriptor" |
| 22:49:04 | <djazayeri> it describes how the whole webapp gets deployed in a servlet container |
| 22:49:15 | <guduji> (my problem if i dont clear my doubts in mind.. i get frustrated... :/) |
| 22:49:16 | <guduji> wow |
| 22:49:26 | <djazayeri> but we try to keep the majority of the webapp specific configuration out of there |
| 22:49:44 | <guduji> oh but i searched for .xml files... and seems that there are many! |
| 22:50:03 | <guduji> some of them are.. like hbm.xml |
| 22:50:08 | <guduji> what are they? |
| 22:50:16 | <djazayeri> hibernate mappings |
| 22:50:21 | <guduji> oh |
| 22:50:25 | <djazayeri> the map our domain objects to database tables |
| 22:50:45 | <guduji> but that is done by liquibase... :S isn't it? |
| 22:51:36 | <djazayeri> no |
| 22:51:49 | <djazayeri> liquibase controls how we update the database tables across OpenMRS versions. |
| 22:52:09 | <guduji> :S .... |
| 22:52:24 | <guduji> where can i learn about these stuff from? :S |
| 22:52:27 | <djazayeri> hibernate maps between domain objects and database tables at runtime |
| 22:52:32 | <djazayeri> read a tutorial on hibernate |
| 22:52:38 | <guduji> oh |
| 22:53:33 | <guduji> well thats all for now... |
| 22:53:41 | <guduji> thousand thanks to you! |
| 22:54:27 | <guduji> will come back after few hours |
| 22:56:22 | *** wyclif has joined #openmrs |