| 00:16:49 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Follow up to Move assignment of orderNumber into OrderSaveHandler to correct spelling of PREFIX - TRUNK-2426 <http://feedproxy.google.com/~r/OMRStrunk/~3/sVOKHpJ3RzU/OpenMRS> || New Changeset: OpenMRS (order-entry): Move assignment of orderNumber into OrderSaveHandler - TRUNK-2426 <http://feedproxy.google.com/~r/OMRStrunk/~3/cT0sVgfAVrM/OpenMRS> || New Changeset: OpenMRS (order-entry): Cleaned up validation logic for discontinuing orders. TRUNK-2367 <http://feedproxy.google.com/~r/OMRStrunk/~3/oLQeY_fc1Zk/OpenMRS> || New Changeset: OpenMRS (order-entry): Fixed DrugOrderValidator to check all things that have units columns - TRUNK-2364 <http://feedproxy.google.com/~r/OMRStrunk/~3/gdqVRyIN2iE/OpenMRS> |
| 00:37:10 | *** wyclif has joined #openmrs |
| 01:24:51 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Follow up to Add "Order Set" as a core ConceptClass to include uuid in the query - TRUNK-2371 <http://feedproxy.google.com/~r/OMRStrunk/~3/JzgkLI13Y8s/OpenMRS> |
| 02:03:05 | *** yanokwa has joined #openmrs |
| 03:01:07 | *** gbastien has quit IRC |
| 03:02:52 | *** r0bby has quit IRC |
| 03:26:26 | *** Echidna has quit IRC |
| 03:27:11 | *** guduji has quit IRC |
| 03:32:51 | *** Echidna has joined #openmrs |
| 03:32:51 | *** ChanServ sets mode: +v Echidna |
| 03:57:25 | *** surangak has joined #openmrs |
| 04:44:43 | *** sreya has joined #openmrs |
| 05:05:18 | *** upul` has joined #openmrs |
| 05:05:18 | *** ChanServ sets mode: +v upul` |
| 05:08:42 | *** rafa_ has joined #openmrs |
| 05:08:42 | *** ChanServ sets mode: +v rafa_ |
| 05:26:26 | *** r0bby has joined #openmrs |
| 05:26:26 | *** ChanServ sets mode: +v r0bby |
| 05:31:25 | *** sreya_ has joined #openmrs |
| 05:32:32 | *** rafa has joined #openmrs |
| 05:32:32 | *** ChanServ sets mode: +v rafa |
| 05:33:04 | *** rafa_ has quit IRC |
| 05:40:16 | *** dkayiwa has joined #openmrs |
| 05:41:37 | *** pratyush has joined #openmrs |
| 05:41:46 | *** rafa has quit IRC |
| 05:42:34 | *** sreya_ has quit IRC |
| 06:12:12 | *** pascal` has quit IRC |
| 06:13:13 | *** sreya_ has joined #openmrs |
| 06:15:14 | <sreya> hidk |
| 06:15:14 | *** sreya_ has quit IRC |
| 06:15:15 | <sreya> hi dkayiwa |
| 06:15:15 | <sreya> did you get the patch |
| 06:15:25 | <dkayiwa> hi sreya |
| 06:15:37 | <dkayiwa> can i look at your exact module code |
| 06:15:56 | <dkayiwa> not just the trunk patch |
| 06:16:08 | <sreya> i have checked in my module |
| 06:16:15 | <sreya> under databasemessages--->braches----> |
| 06:16:15 | <dkayiwa> url |
| 06:16:20 | <sreya> svn |
| 06:16:58 | <dkayiwa> shouldn't module be in the module svn repo? |
| 06:17:17 | <sreya> yes |
| 06:17:19 | <sreya> it is |
| 06:18:41 | <dkayiwa> svn url for checking out? |
| 06:21:15 | <dkayiwa> sreya |
| 06:21:19 | <sreya> yes |
| 06:21:23 | <dkayiwa> :) |
| 06:24:28 | *** sreya_ has joined #openmrs |
| 06:25:32 | <sreya_> dkayiwa: |
| 06:25:32 | <sreya_> http://svn.openmrs.org/openmrs-modules/databasemessages/branches |
| 06:25:38 | <OpenMRSBot> <http://ln-s.net/8xTy> (at svn.openmrs.org) |
| 06:25:40 | <dkayiwa> ok |
| 06:25:50 | *** sreya has quit IRC |
| 06:31:23 | <dkayiwa> i wonder why it messes up the url like this |
| 06:31:24 | <dkayiwa> svn: URL 'http://svn.openmrs.org/openmrs/-modules/databasemessages/branches' doesn't exist |
| 06:33:11 | <sreya_> http://svn.openmrs.org/openmrs-modules/databasemessages/branches |
| 06:33:11 | <sreya_> there is no / after openmrs |
| 06:33:11 | <OpenMRSBot> <http://ln-s.net/8xTy> (at svn.openmrs.org) |
| 06:33:38 | <dkayiwa> it put it there by itself |
| 06:34:51 | <sreya_> i just checked it i could access it gave the same url |
| 06:34:51 | <sreya_> http://svn.openmrs.org/openmrs-modules/databasemessages/branches/ |
| 06:34:56 | <OpenMRSBot> <http://ln-s.net/8xU9> (at svn.openmrs.org) |
| 06:35:27 | <dkayiwa> are you using m2eclipse? |
| 06:35:50 | *** djazayeri has joined #openmrs |
| 06:35:50 | *** ChanServ sets mode: +o djazayeri |
| 06:36:13 | <dkayiwa> djazayeri: arent you supposed to be sleeping? :) |
| 06:37:02 | <djazayeri> dkayiwa: just plugging in my computer before going to bed. :-) |
| 06:37:11 | <dkayiwa> oh i see |
| 06:37:38 | <dkayiwa> do u have a min? |
| 06:37:46 | <djazayeri> Maybe 5 |
| 06:38:01 | <dkayiwa> which ticket woudl u recomend that i do now? |
| 06:38:33 | <djazayeri> have you finished all the followups from the code review? |
| 06:38:52 | <dkayiwa> yes |
| 06:40:11 | <djazayeri> dkayiwa: can you make sure that TRUNK-2372 is "done"? |
| 06:40:32 | <djazayeri> I put it in design review because I meant to go back through the big code review and revise the ticket description |
| 06:40:41 | <djazayeri> (the description is no longer right) |
| 06:41:17 | <djazayeri> so, if you've fixed everything OrderSet and OrderSetMember related in the big code review, you can probably close the ticket outright. |
| 06:41:31 | <dkayiwa> ok |
| 06:43:15 | <djazayeri> also, any of the "grouping tickets" that have subtickets that are all done... |
| 06:43:25 | <dkayiwa> ok |
| 06:43:43 | <djazayeri> feel free to claim those, write a unit test that covers the entire big ticket, and commit them. |
| 06:43:52 | <dkayiwa> ok |
| 06:44:15 | <djazayeri> and if you're looking for something else, look at TRUNK-2366. |
| 06:44:23 | <dkayiwa> ok |
| 06:44:30 | <djazayeri> Currently there are some getOrders methods that take an enum for "what types of orders" |
| 06:44:34 | <djazayeri> this needs to change. |
| 06:44:38 | <dkayiwa> ok |
| 06:44:40 | <djazayeri> I don't know if we keep an enum... |
| 06:44:46 | <dkayiwa> ok |
| 06:44:49 | <djazayeri> or if we have a bunch of different methods for the different categories. |
| 06:44:56 | <dkayiwa> ok |
| 06:45:01 | <djazayeri> so, the thing to do for that ticket is think about a solution, and propose something on the dev list. |
| 06:45:10 | <djazayeri> Hopefully that's enough for until I wake up again? |
| 06:45:10 | <dkayiwa> ok |
| 06:45:11 | <djazayeri> :-) |
| 06:45:20 | <dkayiwa> sure thanks :D |
| 07:05:45 | *** danielf` has joined #openmrs |
| 07:05:45 | *** ChanServ sets mode: +v danielf` |
| 07:13:39 | <sreya_> hey did u get access to my code dkayiwa |
| 07:15:05 | <dkayiwa> do u checkout using m2eclipse |
| 07:15:45 | *** goutham has joined #openmrs |
| 07:19:24 | *** r0bby has quit IRC |
| 07:20:41 | <sreya_> yes |
| 07:20:45 | <sreya_> dkayiwa: |
| 07:21:24 | <dkayiwa> do u use file import or file new project |
| 07:24:21 | *** pascal` has joined #openmrs |
| 07:26:28 | <sreya_> import new maven project |
| 07:26:30 | <sreya_> dkayiwa: |
| 07:26:35 | <sreya_> sorry |
| 07:26:44 | <sreya_> import exsisting maven project |
| 07:26:46 | <sreya_> dkayiwa: |
| 07:26:57 | *** pratyush has quit IRC |
| 07:27:22 | *** pratyush has joined #openmrs |
| 07:29:41 | *** ChanServ sets mode: +v pascal` |
| 07:48:42 | *** goutham has quit IRC |
| 07:49:02 | <dkayiwa> sreya_ sorry was away |
| 07:49:26 | *** sreya_ has quit IRC |
| 08:26:55 | *** rafa has joined #openmrs |
| 08:26:55 | *** ChanServ sets mode: +v rafa |
| 09:04:36 | *** dkayiwa has quit IRC |
| 09:05:12 | *** goutham has joined #openmrs |
| 09:16:04 | *** dkayiwa has joined #openmrs |
| 09:45:26 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Add 'Beta Testing' step to initialization wizard - TRUNK-1945 <http://feedproxy.google.com/~r/OMRStrunk/~3/Ss2piwAET9o/OpenMRS> |
| 09:49:00 | *** bryq has joined #openmrs |
| 09:49:00 | *** ChanServ sets mode: +v bryq |
| 10:22:42 | *** bwolfe has joined #openmrs |
| 10:22:42 | *** ChanServ sets mode: +o bwolfe |
| 10:24:55 | *** pratyush has quit IRC |
| 10:37:42 | *** bwolfe has quit IRC |
| 10:49:37 | *** bwolfe has joined #openmrs |
| 10:49:41 | *** ChanServ sets mode: +o bwolfe |
| 10:58:00 | *** dkayiwa has quit IRC |
| 11:01:57 | *** dkayiwa has joined #openmrs |
| 11:23:32 | *** surangak_ has joined #openmrs |
| 11:25:13 | *** surangak has quit IRC |
| 11:36:12 | *** bwolfe has quit IRC |
| 11:36:24 | *** upul` has quit IRC |
| 11:53:10 | *** bwolfe has joined #openmrs |
| 11:53:10 | *** ChanServ sets mode: +o bwolfe |
| 11:55:13 | *** james_regen has joined #openmrs |
| 11:55:13 | *** ChanServ sets mode: +v james_regen |
| 12:03:05 | *** bryq has quit IRC |
| 12:24:05 | *** downeym has joined #openmrs |
| 12:24:05 | *** ChanServ sets mode: +o downeym |
| 12:24:05 | *** OpenMRSBot sets mode: +o downeym |
| 12:33:03 | *** bwolfe has quit IRC |
| 12:40:33 | *** wyclif has quit IRC |
| 12:42:18 | *** gbastien has joined #openmrs |
| 12:47:01 | *** gbastien has quit IRC |
| 12:59:42 | *** gbastien has joined #openmrs |
| 13:01:44 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Removing order type from order entry forms - TRUNK-2403 <http://feedproxy.google.com/~r/OMRStrunk/~3/DUzoxP2Jtu4/OpenMRS> |
| 13:27:07 | *** wyclif has joined #openmrs |
| 13:28:28 | *** cta has joined #openmrs |
| 13:29:01 | <cta> hello |
| 13:29:42 | *** asgoyal has quit IRC |
| 13:48:22 | *** bryq has joined #openmrs |
| 13:48:22 | *** ChanServ sets mode: +v bryq |
| 13:56:28 | *** r7friedman has joined #openmrs |
| 13:56:39 | *** r7friedman is now known as r-friedman |
| 13:56:43 | <downeym> Hi r-friedman and welcome to the #openmrs IRC channel. |
| 14:03:04 | *** r-friedman has quit IRC |
| 14:03:09 | *** r8friedman has joined #openmrs |
| 14:03:13 | *** r8friedman is now known as r-friedman |
| 14:03:18 | *** bwolfe has joined #openmrs |
| 14:03:18 | *** ChanServ sets mode: +o bwolfe |
| 14:03:24 | <downeym> Hi r-friedman and welcome to the #openmrs IRC channel. |
| 14:03:28 | *** downeym has quit IRC |
| 14:03:33 | <bwolfe> https://wiki.openmrs.org/display/docs/2011-06-30+Developer+Meeting |
| 14:03:36 | <bwolfe> !devmtg |
| 14:03:36 | <OpenMRSBot> bwolfe: "devmtg" --- Reminder: Developer meeting Thursday at 10:00 AM Eastern - http://wiki.openmrs.org/display/docs/Weekly+Developer+Meeting |
| 14:03:40 | <OpenMRSBot> <http://ln-s.net/8xXQ> (at wiki.openmrs.org) |
| 14:04:03 | *** danielf` has quit IRC |
| 14:13:23 | <bwolfe> http://connect.openmrs.org |
| 14:16:06 | *** vchircu has joined #openmrs |
| 14:21:57 | *** downeym has joined #openmrs |
| 14:21:57 | *** OpenMRSBot sets mode: +o downeym |
| 14:21:57 | *** ChanServ sets mode: +o downeym |
| 14:29:02 | *** chughgaurav has joined #openmrs |
| 14:37:18 | *** mandric has joined #openmrs |
| 14:38:45 | *** surangak_ has quit IRC |
| 14:41:31 | *** elliott_w has joined #openmrs |
| 14:41:31 | *** ChanServ sets mode: +o elliott_w |
| 14:41:35 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Fixing compilation errors in the web layer after changes in the API <http://feedproxy.google.com/~r/OMRStrunk/~3/Nj4Wm_SWHVI/OpenMRS> || New Changeset: OpenMRS (order-entry): Follow up to Remove order_type table - TRUNK-2403 <http://feedproxy.google.com/~r/OMRStrunk/~3/FPsNi8pZGDk/OpenMRS> |
| 14:41:58 | *** dkayiwa has quit IRC |
| 14:42:02 | *** mandric has quit IRC |
| 14:44:13 | *** mandric has joined #openmrs |
| 14:46:08 | *** dkayiwa has joined #openmrs |
| 14:49:55 | *** bwolfe has quit IRC |
| 14:53:52 | <wyclif> djazayeri, is there a column on order set that references concept? |
| 14:54:27 | <wyclif> there is a failing changeset 0101209-1111-order_set |
| 14:58:34 | <djazayeri> there was originally a concept column, but we got rid of it |
| 14:58:40 | <djazayeri> is it failing because of checksum? |
| 14:58:51 | <djazayeri> wyclif: ^^ |
| 15:04:52 | *** chughgaurav has quit IRC |
| 15:07:42 | *** pascal` has quit IRC |
| 15:12:19 | <wyclif> djazayeri, |
| 15:12:41 | <wyclif> well, i have fixed the changeset |
| 15:13:50 | <wyclif> djazayeri, i think we need to leave orders that are not drug orders as just orders rather than making them Test orders during migration |
| 15:16:26 | <djazayeri> wyclif: we need to investigate with dev and implementers to see if anyone is using anything other than Drug orders and Lab Test orders. |
| 15:17:48 | <djazayeri> As far as we know (though we have investigated yetâ¦) the only use cases we know about are (1) drug orders (as supported in the pre-1.9 webapp, used a lot at PIH at least. And (2) lab test orders (as supported by the Simple Lab Entry module) |
| 15:19:20 | *** goutham has quit IRC |
| 15:35:52 | <vchircu> /quit |
| 15:36:12 | *** vchircu has quit IRC |
| 15:36:48 | *** schuyler1d has joined #openmrs |
| 15:37:04 | <downeym> Hi schuyler1d and welcome to the #openmrs IRC channel. |
| 15:38:41 | <r-friedman> downeym: is the core team located at 410 W 10th |
| 15:39:36 | <downeym> r-friedman: some of us :) |
| 15:39:46 | <r-friedman> paul? |
| 15:40:21 | <r-friedman> downeym: paul? |
| 15:41:00 | *** bwolfe has joined #openmrs |
| 15:41:00 | *** ChanServ sets mode: +o bwolfe |
| 15:42:03 | <downeym> r-friedman: yes |
| 15:42:12 | <r-friedman> cool tks |
| 15:44:18 | *** cta has quit IRC |
| 15:44:21 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Fixing a couple of liquibase changesets to remove addition of a constraint on none existent column on order_set table an... <http://feedproxy.google.com/~r/OMRStrunk/~3/vyNhdUmXuFo/OpenMRS> || New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : Merged trunk into branch localize-setup-wizard rev:20986 - rev:21170 <http://feedproxy.google.com/~r/OMRStrunk/~3/ZOhep79RynI/OpenMRS> || OpenMRS Modules: HTML Widgets 1.5.7 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlwidgets&version=&1.5.7> |
| 15:44:32 | <downeym> r-friedman: planning a visit? |
| 15:44:44 | <r-friedman> pkg coming today |
| 15:45:02 | <downeym> r-friedman: 10-4 |
| 15:46:48 | <wyclif> djazayeri, i added the changeset that converts all orders that are not drug orders to be test orders but we can remove it when we decide |
| 15:46:49 | *** bwolfe has quit IRC |
| 15:47:15 | <djazayeri> wyclif: I like that. Can you create a ticket to investigate whether that's appropriate? |
| 15:48:30 | *** bwolfe has joined #openmrs |
| 15:48:30 | *** ChanServ sets mode: +o bwolfe |
| 15:59:28 | *** mandric has quit IRC |
| 16:00:15 | *** mandric has joined #openmrs |
| 16:00:39 | <djazayeri> rafa: one random commentâ¦when showing incoming next to existing, you showed them in two divs next to each other |
| 16:01:11 | <rafa> djazayeri: correct |
| 16:01:20 | <djazayeri> but what I'd meant was more a table with || Property || Incoming || Existing |
| 16:01:44 | <rafa> djazayeri: We had that once ;) |
| 16:01:46 | <djazayeri> (that way the values you need to visually compare are next to each other, without an extra label column |
| 16:01:53 | <djazayeri> Did I ask to get rid of it? :-) |
| 16:02:00 | <rafa> djazayeri: yes :) |
| 16:02:19 | <djazayeri> well, you shouldn't always listen to me... |
| 16:02:28 | <rafa> djazayeri: no problem, I'll put it in a table. |
| 16:02:41 | <djazayeri> often you shouldn't have listened to me in the past. But you should always listen to me in the present. :-) |
| 16:03:00 | <rafa> hehe |
| 16:04:01 | <rafa> djazayeri: I'll work on validators tomorrow. There're two tickets for that: META-81 and META-82 |
| 16:04:05 | *** elliott_w has quit IRC |
| 16:04:09 | <djazayeri> okay. |
| 16:04:25 | <rafa> djazayeri: I'll probably have time for something extra. |
| 16:04:37 | <rafa> djazayeri: What do you think should be prioritized? |
| 16:04:41 | <djazayeri> When should we discuss how to better decide which items can be imported without confirmation? |
| 16:05:02 | <rafa> djazayeri: Tomorrow? |
| 16:05:30 | <rafa> djazayeri: Do you have time tomorrow? |
| 16:05:44 | <djazayeri> yes |
| 16:06:19 | <rafa> djazayeri: Perfect. I'll take notes on what it looks like right now. |
| 16:06:57 | <rafa> djazayeri: And then we can decide which behavior to change. |
| 16:07:14 | <djazayeri> Okay. Another thing that seems important is to display more properties side-by-side for comparison |
| 16:07:46 | <rafa> That might require more work. |
| 16:08:30 | <rafa> We've got general handlers that implement getName, getDescription, ... |
| 16:08:42 | <rafa> We'll need to change that completely |
| 16:09:03 | <rafa> To display different properties for different types. |
| 16:09:33 | <djazayeri> But in theory we could have a base one that introspects the type and returns bean properties. |
| 16:09:41 | <rafa> The other option is to actually display xml representations of objects we compare |
| 16:10:12 | <djazayeri> Well, we'd need to pretty it up... |
| 16:10:41 | <rafa> I mean there's no point of displaying bean properties of a Concept |
| 16:10:59 | <rafa> Because mostly all we can see are references to other objects |
| 16:11:00 | <djazayeri> why not? |
| 16:11:13 | <djazayeri> Ideally we'd show: |
| 16:11:23 | <djazayeri> datatype: Numeric |
| 16:11:39 | <djazayeri> (i.e. show the name/toString of the other object) |
| 16:11:53 | <djazayeri> so if you've got existing and incoming with different values, you can see that. |
| 16:12:10 | <djazayeri> So, let's discuss further later. |
| 16:12:14 | <djazayeri> For now, do the validation tickets. |
| 16:12:22 | <rafa> Sure |
| 16:12:37 | <djazayeri> And I'd say add a question at the beginning of the import asking whether you want to overwrite or map by default. |
| 16:12:59 | <rafa> ok |
| 16:15:03 | <djazayeri> good presentation |
| 16:16:50 | <rafa> djazayeri: Thanks! No NullPointerException == success ;) |
| 16:20:55 | *** rafa has quit IRC |
| 16:33:09 | *** rafa has joined #openmrs |
| 16:33:09 | *** ChanServ sets mode: +v rafa |
| 16:44:56 | <bryq> Hi rafa. Heve some free time? |
| 16:47:17 | <rafa> Hi bryq, I've got about 10 minutes now. |
| 16:47:32 | <bryq> rafa: Okay |
| 16:47:38 | <rafa> I'll be later too. |
| 16:48:02 | <bryq> rafa: No problem, I've got only a suggestion to you :) |
| 16:48:26 | <rafa> bryq: Yes? |
| 16:48:35 | <bryq> rafa: Now after package import there is a page with text "Package import succeed!" |
| 16:49:10 | <bryq> rafa: We could change it to something similar that is after e.g. module upgrade |
| 16:49:47 | <bryq> rafa: We could redirect to "Manage Metadata Sharing" page and there display a message "Package import succeed" |
| 16:50:21 | <rafa> bryq: sure, it'll be nicer :) |
| 16:50:23 | <djazayeri> I don't know, I think that importing a package is a large and significant process, so having a success page is kind of nice |
| 16:50:47 | <djazayeri> But it should show the summary, like: # created, # modified, # omitted |
| 16:50:52 | <djazayeri> or something like that |
| 16:51:04 | <bryq> rafa, djazayeri: So at least we shoul have a link here |
| 16:51:14 | <djazayeri> bryq: definitely |
| 16:53:07 | <bryq> rafa, djazayeri: Now, when I'm testing the module I feel the lack of a link targeting "Manage Metadata Sharing" |
| 16:53:19 | <bryq> rafa, djazayeri: But it's just a detail :) |
| 16:53:38 | <bryq> rafa, djazayeri: And that's all form me |
| 16:55:05 | <rafa> bryq: There was a link once. I don't know when we lost it ;) |
| 16:55:24 | <rafa> Anyway displaying the summary seems right |
| 16:55:33 | <rafa> bryq: Thanks! |
| 16:56:12 | <bryq> rafa: Yes, Darius as always beat me in UI design :) |
| 16:56:30 | *** dkayiwa has quit IRC |
| 17:00:16 | <rafa> bryq: Haha, yes, you can count on Darius to do that :) |
| 17:27:41 | *** dkayiwa has joined #openmrs |
| 17:33:58 | *** bwolfe has quit IRC |
| 17:40:09 | *** yanokwa has quit IRC |
| 17:44:18 | *** nribeka has joined #openmrs |
| 17:44:18 | *** ChanServ sets mode: +v nribeka |
| 17:48:18 | *** elliott_w has joined #openmrs |
| 17:48:18 | *** ChanServ sets mode: +o elliott_w |
| 17:50:23 | <djazayeri> I just started up the standalone (without having changed anything AFAIK) and got a mysql connection error |
| 17:50:27 | <djazayeri> sound familiar to anyone? |
| 17:56:33 | *** kishoreyekkanti has joined #openmrs |
| 17:56:42 | <downeym> Hi kishoreyekkanti and welcome to the #openmrs IRC channel. |
| 18:01:20 | *** kishoreyekkanti has quit IRC |
| 18:03:52 | *** rafa has quit IRC |
| 18:06:42 | *** bwolfe has joined #openmrs |
| 18:06:42 | *** ChanServ sets mode: +o bwolfe |
| 18:15:15 | *** r-friedman has quit IRC |
| 18:50:28 | <dkayiwa> djazayeri: could you give me an example of orderables? |
| 18:50:54 | <djazayeri> currently they are: |
| 18:51:20 | <djazayeri> Concepts whose class = Drug -> orderable as GenericDrug |
| 18:51:26 | <djazayeri> Drug -> orderable as itself |
| 18:51:39 | <djazayeri> OrderSet -> orderable as PublishedOrderSet |
| 18:52:04 | <djazayeri> eventually: Concepts whose class = Test -> orderable as SimpleLabTest (or something like that), and more |
| 18:52:13 | <dkayiwa> ok |
| 18:52:34 | <djazayeri> basically, Orderables are primarily meant to drive the pick list in the UI of things the user may choose, that eventually lead to an Order. |
| 18:52:42 | *** bwolfe has quit IRC |
| 18:52:44 | <dkayiwa> ok |
| 18:54:06 | <dkayiwa> djazayeri: so these orderables have different ids (e.g concept_id, drug_id, order_set_id, etc)? |
| 18:54:27 | <djazayeri> yes. |
| 18:54:45 | <djazayeri> actually the orderable interface doesn't have an "id" or "uuid" |
| 18:54:48 | <djazayeri> it probably should |
| 18:55:06 | <dkayiwa> djazayeri: that is what i was driving at |
| 18:55:07 | <djazayeri> (Orderable will definitely get further design for the next sprint) |
| 18:55:28 | <dkayiwa> ok |
| 18:55:39 | <djazayeri> Are you looking at a unit test for "user chooses an orderable"? |
| 18:55:51 | <dkayiwa> no |
| 18:55:58 | <dkayiwa> UI for chosing them |
| 18:56:08 | <dkayiwa> UI Widget |
| 18:56:35 | <djazayeri> Good point |
| 18:57:18 | <djazayeri> okay, do this: add a "String getUniqueIdentifier()" method to the Orderable interface |
| 18:57:21 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Google Maps Image Viewer 0.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=gmapsimageviewer&version=&0.3> |
| 18:57:23 | <djazayeri> it should be abstract on BaseOrderable |
| 18:57:50 | <djazayeri> on GenericDrug it should return "GenericDrug:concept=${ conceptId }" |
| 18:58:16 | <djazayeri> on Drug it should return "Drug:${ drugId }" |
| 18:58:37 | <djazayeri> (actually, make those "org.openmrs.Drug:${ drugId }", etc |
| 18:58:56 | <djazayeri> for now it's sufficient for the ui widget to produce this for the selection. |
| 18:59:04 | <dkayiwa> ok |
| 18:59:29 | <djazayeri> Eventually we'll need a "getOrderableByUniqueId(String)" method, that will be used on the form the widget submits to. But let's deal with that later. |
| 18:59:39 | <dkayiwa> ok |
| 19:01:04 | <dkayiwa> djazayeri: after storing the id of the selected orderable, do we also store the type of orderable? |
| 19:01:15 | <djazayeri> storing? |
| 19:01:41 | <dkayiwa> like when the ui widget needs to display the previously selected orderable |
| 19:01:51 | <dkayiwa> eg when a form displays data from the database |
| 19:02:35 | <dkayiwa> the way the concept search widget will display the concept name after being passed a concept_id from the database |
| 19:03:11 | <djazayeri> That's part of "deal with that later" |
| 19:03:22 | <dkayiwa> ok |
| 19:03:33 | <djazayeri> if you want to write a quick and hacky getOrderableByUniqueId(String) that matches the getUniqueId of the orderable classes, that's fine. |
| 19:03:42 | <djazayeri> (The quick hacky version should only take 5 minutes to write) |
| 19:03:54 | <djazayeri> and this would allow what you're asking about. |
| 19:04:19 | <djazayeri> Basically the widget should be able to store the uniqueId of the chosen orderable in a hidden input |
| 19:04:33 | <djazayeri> but it should display the name |
| 19:04:36 | <dkayiwa> the unique id Integer? |
| 19:04:47 | <djazayeri> no |
| 19:04:54 | <dkayiwa> UUID? |
| 19:04:58 | <djazayeri> Not that either. |
| 19:05:09 | <dkayiwa> :) |
| 19:05:25 | <djazayeri> The unique ID for an orderable is basically the orderable type + a unique id within that type |
| 19:05:37 | <dkayiwa> oh i see!!! |
| 19:05:56 | <djazayeri> Eventually we may need some sort of "OrderableFactory" interface and we'll have implementations for generic drug, order set, drug, lab test, etc. |
| 19:06:08 | <djazayeri> but we haven't designed that far ahead. |
| 19:06:16 | <dkayiwa> ok |
| 19:06:37 | <djazayeri> So for now, the unique id would be "org.openmrs.GenericDrug:88" or "org.openmrs.Drug:7" |
| 19:06:46 | <dkayiwa> ok |
| 19:07:29 | <djazayeri> oh, dkayiwa, a question about the standalone |
| 19:07:44 | <dkayiwa> which mysql connection error do u get? |
| 19:07:50 | <djazayeri> I just started it up, and it's broken. Specifically I can't connect to the mysql db with that username |
| 19:08:13 | <dkayiwa> which run time properties file is it using? |
| 19:08:19 | <dkayiwa> from its logs |
| 19:08:23 | <djazayeri> it shows me the initialsetup page with "Error occurred while trying to get the updates needed for the database. Unable to get a connection to the database. Please check your openmrs runtime properties file and make sure you have the correct connection.username and connection.password set" |
| 19:08:59 | <dkayiwa> are you using the 1.8 standalone release? |
| 19:09:12 | *** bwolfe has joined #openmrs |
| 19:09:12 | *** ChanServ sets mode: +o bwolfe |
| 19:09:26 | <djazayeri> folder says 1.8.0.1 |
| 19:09:33 | <djazayeri> it's using the right runtime props: Using runtime properties file: openmrs-standalone-runtime.properties |
| 19:09:48 | <djazayeri> I tried connecting to the database using MySQL Workbench, and that fails. |
| 19:10:05 | <djazayeri> It worked a few days ago when I tried last time. I don't *think* I've done anything since then. |
| 19:10:16 | <djazayeri> It would be nice to have a "reset" script. |
| 19:10:38 | <djazayeri> my real question is: is there a way to reset the database, or should I just download again? |
| 19:10:41 | <dkayiwa> how many mysqld processes do you have running? |
| 19:11:04 | <djazayeri> looks like 3 |
| 19:11:34 | <dkayiwa> i suspect it could be connecting to a wrong process which has different authentication information |
| 19:11:53 | <djazayeri> hmm, maybe the app-test one is still running for some reason |
| 19:12:16 | <djazayeri> and maybe they used the same port as you did, since they copied the standalone |
| 19:12:18 | <dkayiwa> and it that is the case, even if you reset the database (which is as simple as deleting the data folder), you will still get the same error message |
| 19:12:24 | *** rafa has joined #openmrs |
| 19:12:24 | *** ChanServ sets mode: +v rafa |
| 19:12:34 | <dkayiwa> try changing the port |
| 19:12:43 | <djazayeri> how about I try killing the apptest process |
| 19:12:52 | <dkayiwa> that will work too |
| 19:13:38 | <djazayeri> thats works, thanks! |
| 19:13:45 | <dkayiwa> ok good |
| 19:15:07 | *** james_regen has quit IRC |
| 19:26:56 | *** bryq1 has joined #openmrs |
| 19:27:41 | *** bryq has quit IRC |
| 19:37:48 | *** dkayiwa_ has joined #openmrs |
| 19:38:43 | *** robbyoconnor has joined #openmrs |
| 19:38:43 | *** ChanServ sets mode: +v robbyoconnor |
| 19:39:45 | *** dkayiwa has quit IRC |
| 19:39:45 | *** dkayiwa_ is now known as dkayiwa |
| 20:03:41 | *** yanokwa has joined #openmrs |
| 20:03:54 | *** bwolfe has quit IRC |
| 20:06:41 | *** bryq1 has quit IRC |
| 20:06:51 | *** pratyush has joined #openmrs |
| 20:08:33 | *** mandric has quit IRC |
| 20:27:33 | *** rafa has quit IRC |
| 20:36:29 | *** mandric has joined #openmrs |
| 20:36:30 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Adding getUniqueIdentifier() method to orderables. <http://feedproxy.google.com/~r/OMRStrunk/~3/ccJui9ggI1A/OpenMRS> |
| 20:37:34 | *** r9friedman has joined #openmrs |
| 20:37:44 | *** r9friedman is now known as r-friedman |
| 20:37:46 | <downeym> Hi r-friedman and welcome to the #openmrs IRC channel. |
| 20:37:47 | *** downeym has quit IRC |
| 20:40:56 | <r-friedman> djazayeri: Is leadership call over? |
| 20:41:03 | <djazayeri> r-friedman: yes |
| 20:41:09 | <djazayeri> a couple hours ago |
| 20:41:17 | <r-friedman> ok tks |
| 20:42:48 | *** guduji has joined #openmrs |
| 20:53:43 | *** elliott_w has left #openmrs |
| 20:59:06 | *** schuyler1d has quit IRC |
| 21:01:06 | *** pratyush has quit IRC |
| 21:03:33 | *** mandric has quit IRC |
| 21:07:14 | *** mandric has joined #openmrs |
| 21:07:26 | *** mandric has joined #openmrs |
| 21:08:08 | *** mandric has joined #openmrs |
| 21:11:17 | *** dkayiwa has quit IRC |
| 21:15:21 | *** Echidna has quit IRC |
| 21:19:31 | *** Echidna has joined #openmrs |
| 21:19:42 | *** ChanServ sets mode: +v Echidna |
| 21:26:49 | *** mandric has quit IRC |
| 21:31:39 | *** nribeka has quit IRC |
| 21:40:36 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Restrict By Role 1.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=restrictbyrole&version=&1.2> |
| 21:53:16 | *** yanokwa has quit IRC |
| 21:53:53 | *** yanokwa has joined #openmrs |
| 21:55:30 | *** yanokwa has quit IRC |
| 22:01:05 | *** yanokwa has joined #openmrs |
| 22:08:45 | <wyclif> djazayeri, am a little confused, when does discontinuing become allowed, because the logic fails if the order is not yet activated at the same time it cannot activate one has been activated which means theres no way you can actually activate since these conditions can't co-exist |
| 22:10:15 | <djazayeri> wyclif, some of the confusion is because we have methods in place that allow you to do things you're not supposed to be allowed to do yet |
| 22:10:49 | <djazayeri> When Daniel originally started working on this, the persist, sign, and activate methods were all distint. |
| 22:11:00 | <djazayeri> I.e. you were allowed to do them apart from each other. |
| 22:11:14 | <djazayeri> Recently we changed things so that you must persist, sign, and activate all in one go. |
| 22:11:23 | <djazayeri> i.e. all orders in the database must be both signed and activated. |
| 22:11:28 | <wyclif> ok |
| 22:11:32 | <djazayeri> however in the future we know we're going to relax this. |
| 22:12:19 | <djazayeri> Plus, there's one bug that I introduced when making the change. |
| 22:12:50 | <wyclif> so if all orders in the DB are activated then it means we can't discontinue any since the logic can't allow discontinuing an activated one, so should i drop this constraint? |
| 22:12:53 | <djazayeri> Since you're not allowed to modify an order after it has been activated, the discontinueOrder and fillOrder methods now always fail. |
| 22:13:21 | <wyclif> correct! that is what am trying to say |
| 22:13:32 | <wyclif> so should i fix this? |
| 22:13:53 | <djazayeri> The restrictions about discontinue only being allowed for activated orders, and within certain date ranges should stay in place. |
| 22:14:05 | <djazayeri> The bug where you can't actually discontinue anything ever needs to be fixed. |
| 22:15:08 | <wyclif> ok |
| 22:15:20 | <djazayeri> My proposal would be to introduce a new method, called saveOrderWithLesserValidation(Order) |
| 22:15:29 | <djazayeri> that would still do ValidateUtil.validat() |
| 22:15:58 | <djazayeri> In fact it would do everything saveOrder does, except skip the isActivatedInDatabase check. |
| 22:16:12 | <djazayeri> Then discontinueOrder and fillOrder should delegate to that, rather than to saveOrder |
| 22:17:44 | <wyclif> got it |
| 22:20:10 | *** nribeka has joined #openmrs |
| 22:20:10 | *** ChanServ sets mode: +v nribeka |
| 22:40:04 | *** r-friedman has quit IRC |
| 22:43:41 | *** yanokwa has quit IRC |
| 22:45:19 | *** wyclif has quit IRC |
| 23:13:52 | *** yanokwa has joined #openmrs |
| 23:28:24 | *** mandric has joined #openmrs |