| 00:06:35 | *** yanokwa has joined #openmrs |
| 01:34:02 | *** galinganmd has joined #openmrs |
| 01:34:44 | <galinganmd> hi, is anybody still awake? |
| 01:35:30 | <galinganmd> Is anybody familiar with the Jembi HTML Form entry module? |
| 03:10:01 | *** gbastien has quit IRC |
| 03:20:58 | *** galinganmd has quit IRC |
| 03:41:35 | *** bwolfe has joined #openmrs |
| 03:41:35 | *** ChanServ sets mode: +o bwolfe |
| 03:44:27 | *** jportela has quit IRC |
| 03:44:28 | *** bwolfe has quit IRC |
| 04:46:57 | *** yanokwa has quit IRC |
| 04:49:39 | *** saimanohar has joined #openmrs |
| 04:51:36 | *** suho has joined #openmrs |
| 04:51:36 | *** ChanServ sets mode: +v suho |
| 04:55:29 | *** surangak has joined #openmrs |
| 05:22:41 | *** bwolfe has joined #openmrs |
| 05:22:41 | *** ChanServ sets mode: +o bwolfe |
| 05:37:37 | *** asgoyal has quit IRC |
| 05:42:57 | *** sreya has joined #openmrs |
| 05:56:11 | <sreya> hi bwolfe |
| 05:56:27 | <bwolfe> hey |
| 05:57:20 | <sreya> if i keep my class which provides the message id with "messageSourceServiceTarget" |
| 05:57:46 | <sreya> this id is already mentioned in applicationcontext.xml |
| 05:58:02 | <sreya> would my bean override it ?? |
| 05:58:12 | <sreya> i am just checking that |
| 05:58:24 | <sreya> would let you know if i am having errors |
| 05:58:50 | *** goutham has joined #openmrs |
| 05:58:56 | <bwolfe> you should always use a new id |
| 05:59:37 | <sreya> but then how would i tell the spring framework "hey this is your new messageSource" |
| 06:02:43 | <bwolfe> sreya, <alias name="yourModuleMessageSourceServiceTarget" alias="messageSource"/> |
| 06:02:46 | <bwolfe> or something similar |
| 06:02:56 | <sreya> the main pt. is my module should act as a new messageProvider |
| 06:02:59 | <bwolfe> it might complain with you trying to alias it to something that is already aliased |
| 06:03:11 | <sreya> ok |
| 06:03:16 | <bwolfe> so look up in the spring docs how to manually assign it instead of using the keyword "messageSource" |
| 06:03:40 | <sreya> should i be having the <alias> tag in my moduleapplicationContext |
| 06:03:41 | <sreya> ok |
| 06:04:30 | <bwolfe> yes |
| 06:04:57 | *** muthah has joined #openmrs |
| 06:46:28 | *** bryq has joined #openmrs |
| 06:46:28 | *** ChanServ sets mode: +v bryq |
| 06:53:31 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): NullPointerException when adding a new patient - TRUNK-2421 <http://feedproxy.google.com/~r/OMRStrunk/~3/7HcMB39_Kxw/OpenMRS> || New Changeset: OpenMRS (1.8.x): NullPointerException when adding a new patient - TRUNK-2421 <http://feedproxy.google.com/~r/OMRStrunk/~3/XIIR_rK-vB4/OpenMRS> |
| 06:54:00 | *** sreya has quit IRC |
| 06:58:02 | *** goutham has quit IRC |
| 07:10:24 | *** rafa has joined #openmrs |
| 07:10:24 | *** ChanServ sets mode: +v rafa |
| 07:23:50 | *** rafa_ has joined #openmrs |
| 07:23:50 | *** ChanServ sets mode: +v rafa_ |
| 07:23:57 | *** pascal` has joined #openmrs |
| 07:25:25 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.7.x): Removing dev from version number in prep for 1.7.2 release <http://feedproxy.google.com/~r/OMRStrunk/~3/_C__pfQh_u0/OpenMRS> || New Changeset: OpenMRS (1.5.x): Removing dev from version number in prep for 1.5.4 release <http://feedproxy.google.com/~r/OMRStrunk/~3/ygNqwxnR4Bk/OpenMRS> || New Changeset: OpenMRS (1.6.x): Removing dev from version number in prep for 1.6.3 release <http://feedproxy.google.com/~r/OMRStrunk/~3/jIU_E7w4tYc/OpenMRS> |
| 07:26:06 | *** rafa has quit IRC |
| 07:30:56 | *** suhothayan has joined #openmrs |
| 07:30:56 | *** ChanServ sets mode: +v suhothayan |
| 07:34:02 | *** suho has quit IRC |
| 07:49:15 | *** ChanServ sets mode: +v pascal` |
| 07:51:20 | *** danielf` has joined #openmrs |
| 07:51:20 | *** ChanServ sets mode: +v danielf` |
| 08:00:50 | *** robbyoconnor has quit IRC |
| 08:31:31 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Initial draft of Edit function for custom data types <http://feedproxy.google.com/~r/OMRStrunk/~3/A_7UVL2ACNE/OpenMRS> |
| 08:38:06 | *** rafa_ is now known as rafa |
| 09:33:21 | *** suhothayan has quit IRC |
| 10:10:26 | *** bryq has quit IRC |
| 10:10:39 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Fix the logic in EventListeners.setGlobalPropertyListeners - TRUNK-2323 <http://feedproxy.google.com/~r/OMRStrunk/~3/aiz7qTTnD2g/OpenMRS> |
| 10:14:00 | *** mblanchette has joined #openmrs |
| 10:18:09 | *** mblanchette has quit IRC |
| 10:32:54 | *** saimanohar has quit IRC |
| 11:08:44 | *** sreya has joined #openmrs |
| 11:08:53 | <sreya> hey bwolfe |
| 11:09:39 | <bwolfe> hi |
| 11:10:53 | <sreya> i tried having two messageSources in a normal spring app |
| 11:11:07 | <sreya> it takes the one which ever is defined the latest |
| 11:11:39 | <sreya> i tried using the <alias > for message source in openmrs-servlet.xml |
| 11:11:51 | <sreya> but i know that is not the proper way to do it |
| 11:12:04 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.6.x): Fix the logic in EventListeners.setGlobalPropertyListeners - TRUNK-2323 <http://feedproxy.google.com/~r/OMRStrunk/~3/-p7EVYHoRTo/OpenMRS> || New Changeset: OpenMRS (1.7.x): Fix the logic in EventListeners.setGlobalPropertyListeners - TRUNK-2323 <http://feedproxy.google.com/~r/OMRStrunk/~3/kJIN8tax48Q/OpenMRS> |
| 11:12:22 | <sreya> i should write it somewhere , like when i deploy my module it should have a latest entry with the <alias > |
| 11:12:48 | <sreya> am i sound clear |
| 11:13:16 | <sreya> i tried to put it in my moduleapplcation context but it does not work |
| 11:14:33 | <sreya> bwolfe: |
| 11:15:04 | <bwolfe> define "doesn't work". that should be the solution |
| 11:15:27 | <sreya> i mean when i refresh the page , |
| 11:16:13 | <sreya> the <spring:messagecode="openmrs.title"> should invoke my service for looking at the code from the db n giving the value back |
| 11:19:55 | <sreya> bwolfe: just send you a mail as how i am trying to hook my module for acting as messageSource |
| 11:20:42 | *** surangak has quit IRC |
| 11:21:48 | *** james_regen has joined #openmrs |
| 11:21:48 | *** ChanServ sets mode: +v james_regen |
| 11:22:20 | <bwolfe> sreya, so you're not getting hte "hello" text printed out? |
| 11:22:41 | <bwolfe> why are you aliasing twice in the same file? |
| 11:22:51 | <sreya> yes |
| 11:23:18 | <bwolfe> and why is your package called "friends"? :-) |
| 11:24:08 | <sreya> hey that is a mistake |
| 11:24:30 | <sreya> i was just trying this thing as a separate module |
| 11:24:46 | <sreya> this module is not my actual application |
| 11:24:58 | <sreya> was just trying to do a basic thing |
| 11:25:11 | <sreya> n then wanted to hook it with the trunk |
| 11:25:37 | <bwolfe> ah |
| 11:26:01 | <sreya> i am going crazy with this arrggg:( |
| 11:26:52 | <sreya> whatever i write in my moduleapplication.xml overrides openmrs-servlet.xml???? |
| 11:26:53 | <bwolfe> sreya, try putting <alias name="BasicServiceTarget" alias="messageSource"/> after the definition of BasicServiceTarget |
| 11:27:04 | <sreya> ok |
| 11:27:08 | <bwolfe> it does not overwrite it necessary, but it gets added in after it |
| 11:27:46 | <sreya> so it should add my alias |
| 11:27:54 | <bwolfe> yes, it should |
| 11:28:06 | <sreya> checking it ..... |
| 11:28:14 | <bwolfe> you can also try just naming your bean "messageSource" instead of BasicServiceTarget with an alias |
| 11:28:35 | <sreya> can i directly name it as messageSource |
| 11:28:36 | <sreya> would do it |
| 11:31:16 | *** rafa has quit IRC |
| 11:32:44 | <sreya> no change its still the same |
| 11:33:11 | <sreya> bwolfe: |
| 11:37:38 | <bwolfe> what about naming it messageSource? |
| 11:38:20 | <sreya> earlier when i had it using alias the service' constructor was atleast getting called |
| 11:38:57 | <sreya> i named it with messageSource now even the constructor of the service is not getting called |
| 11:40:28 | <sreya> bw |
| 11:40:28 | <sreya> bwolfe: http://pastebin.com/cfzq3VEX |
| 11:40:40 | <sreya> my modulecontext.xml |
| 11:41:27 | <bwolfe> ok... |
| 11:42:53 | <bwolfe> hmm, The MessageSourceAware interface can also be used to acquire a reference to any MessageSource that has been defined. Any bean that is defined in an ApplicationContext that implements the MessageSourceAware interface will be injected with the application context's MessageSource when it (the bean) is being created and configured. |
| 11:42:57 | <bwolfe> from: http://static.springsource.org/spring/docs/2.5.x/reference/beans.html |
| 11:42:58 | <OpenMRSBot> <http://ln-s.net/3RPb> (at static.springsource.org) |
| 11:45:47 | <sreya> i will try that |
| 11:46:06 | <bwolfe> sreya, actually I think I found it |
| 11:46:13 | <bwolfe> you have to use the machinery in openmrs, not in spring |
| 11:46:37 | <bwolfe> MessageSourceServiceImpl.setActiveMessageSource keeps a list of source |
| 11:46:42 | <bwolfe> so you just have to set your source onto that |
| 11:47:21 | <bwolfe> something like <bean parent="messageSourceServiceTarget"> <<property name="activeMessageSource"><ref bean="BasicServiceTarget"/> |
| 11:47:21 | <bwolfe> </property> |
| 11:47:21 | <bwolfe> </bean> |
| 11:47:41 | <bwolfe> (not sure if the parent bean works like that or not) |
| 11:48:11 | <sreya> ok i will this one first |
| 11:48:18 | <bwolfe> but you will also have the issue of whether the core one or yours will be called first |
| 11:56:32 | *** muthah has quit IRC |
| 12:10:59 | *** downeym has joined #openmrs |
| 12:10:59 | *** OpenMRSBot sets mode: +o downeym |
| 12:10:59 | *** ChanServ sets mode: +o downeym |
| 12:14:28 | *** sreya has quit IRC |
| 12:15:08 | *** bwolfe has quit IRC |
| 12:32:13 | *** robbyoconnor has joined #openmrs |
| 12:32:13 | *** ChanServ sets mode: +v robbyoconnor |
| 12:34:37 | *** danielf` has quit IRC |
| 12:34:42 | *** pascal` has quit IRC |
| 12:39:25 | *** bwolfe has joined #openmrs |
| 12:39:25 | *** ChanServ sets mode: +o bwolfe |
| 12:39:38 | *** danielf` has joined #openmrs |
| 12:39:38 | *** ChanServ sets mode: +v danielf` |
| 12:47:51 | *** pascal` has joined #openmrs |
| 12:48:59 | *** muthah has joined #openmrs |
| 12:54:25 | <pascal`> bwolfe, to reference scripts in my module's resources folder, what URL should I use? |
| 12:54:44 | <pascal`> bwolfe, specifically, I'm trying to include javascript inside an HTML form. |
| 12:56:25 | *** downeym has quit IRC |
| 12:56:29 | *** downeym_ has joined #openmrs |
| 12:56:29 | *** ChanServ sets mode: +o downeym_ |
| 13:12:39 | *** wyclif has joined #openmrs |
| 13:13:18 | <pascal`> bwolfe, found it here: https://wiki.openmrs.org/display/docs/Module+Resources |
| 13:13:20 | <pascal`> bwolfe++ |
| 13:13:25 | <OpenMRSBot> <http://ln-s.net/8wxJ> (at wiki.openmrs.org) |
| 13:24:17 | *** wyclif has quit IRC |
| 13:32:32 | *** asgoyal has joined #openmrs |
| 13:35:11 | *** wyclif has joined #openmrs |
| 13:35:29 | <bwolfe> pascal`, glad I could help ;-) |
| 13:46:16 | <pascal`> bwolfe, you can now |
| 13:46:44 | <pascal`> bwolfe, can you think of a way I use JavaScript to generate the source for an HTML Form |
| 13:47:22 | <pascal`> bwolfe, I'm thinking it's not possible, because if I generate an <obs> tag in JavaScript, there's no way the HTML Forms module will be able to render the appropriate HTML |
| 13:47:39 | <pascal`> bwolfe, because the processing of the <obs> tag is done server side... right? |
| 13:51:02 | *** bwolfe has quit IRC |
| 13:57:57 | *** rafa has joined #openmrs |
| 13:57:57 | *** ChanServ sets mode: +v rafa |
| 14:02:08 | *** djazayeri has joined #openmrs |
| 14:02:08 | *** ChanServ sets mode: +o djazayeri |
| 14:06:05 | *** bwolfe has joined #openmrs |
| 14:06:05 | *** ChanServ sets mode: +o bwolfe |
| 14:30:17 | *** cta has joined #openmrs |
| 14:30:22 | <cta> hello |
| 14:30:39 | <djazayeri> hi cta |
| 14:31:51 | <pascal`> hi |
| 14:35:48 | *** mandric has joined #openmrs |
| 14:36:05 | *** mandric has quit IRC |
| 14:36:14 | *** mandric has joined #openmrs |
| 14:41:36 | *** pascal` has quit IRC |
| 14:41:39 | *** danielf` has quit IRC |
| 14:49:25 | *** burke_away has joined #openmrs |
| 14:49:25 | *** ChanServ sets mode: +o burke_away |
| 14:59:17 | <wyclif> djazayeri, did you remove validateAndSaveOrder? |
| 14:59:50 | <djazayeri> wyclif: I might have, is it no longer there? |
| 15:00:19 | <djazayeri> no you should just call saveOrder. |
| 15:00:22 | <djazayeri> which also validates. |
| 15:00:41 | <djazayeri> and it's probably best to do it like Context.getOrderService().saveOrder |
| 15:00:55 | <djazayeri> so that AOP annotations get invoked |
| 15:03:32 | <djazayeri> wyclif: make sense? |
| 15:10:39 | *** Hazamonzo has joined #openmrs |
| 15:11:04 | <burke_away> unless we're saving drafts in the orders tables (which I don't believe we're doing now), we shouldn't be saving invalid orders. :) |
| 15:22:39 | *** mandric_ has joined #openmrs |
| 15:23:35 | *** mandric_ has joined #openmrs |
| 15:24:48 | *** mandric has quit IRC |
| 15:24:48 | *** mandric_ is now known as mandric |
| 15:26:50 | <asgoyal> hi djazayeri |
| 15:27:13 | <asgoyal> <spring:messagecode="LocationTag.manage"/> |
| 15:27:22 | <asgoyal> i dont understand this line in locationtag.jsp |
| 15:27:52 | <asgoyal> code = "..." is locationtag.manage a file ? |
| 15:28:02 | <djazayeri> It means: print out the localized message (from messages.properties for the user's locale) whose key is "LocationTag.manage" |
| 15:28:15 | <djazayeri> probably something like "Manage Location Tags" |
| 15:28:19 | <asgoyal> oh |
| 15:28:23 | <asgoyal> so now for orders |
| 15:28:24 | <djazayeri> it's not logic. |
| 15:28:31 | <asgoyal> how will i find the keys to print the messages |
| 15:28:37 | <asgoyal> oh |
| 15:29:03 | <asgoyal> for orders will it be order.manage or something? |
| 15:29:14 | <asgoyal> or they are defined in message.properties file? |
| 15:29:18 | <djazayeri> you will have to add them to messages.properties |
| 15:29:21 | <djazayeri> they're not defined yet |
| 15:29:22 | <asgoyal> oohh |
| 15:29:29 | <asgoyal> ok i will do it then |
| 15:29:49 | <asgoyal> ok that was the only confusion i had |
| 15:29:53 | <asgoyal> thanks |
| 15:31:22 | *** muthah has quit IRC |
| 15:32:55 | <burke_away> bbl |
| 15:41:54 | *** mandric has quit IRC |
| 15:42:18 | *** jwishnie has joined #openmrs |
| 15:50:17 | *** gauravpaliwal has joined #openmrs |
| 15:50:17 | *** ChanServ sets mode: +v gauravpaliwal |
| 15:57:30 | <asgoyal> Darius I just need to display the name and description of orders right? |
| 15:57:39 | <djazayeri> of the Orderables. |
| 15:57:59 | <asgoyal> yep |
| 15:58:18 | <asgoyal> and that will be on the url "Manage Orders" .. right? |
| 15:59:46 | <djazayeri> no |
| 15:59:57 | *** mandric has joined #openmrs |
| 15:59:58 | <djazayeri> it's going to be a page that lets you *place* an order for a patient |
| 16:00:32 | <asgoyal> oh |
| 16:00:49 | <djazayeri> it will eventually go on a patient page of some sort |
| 16:00:56 | <djazayeri> no need to put a link *to* this page yet. |
| 16:01:15 | <asgoyal> but at the controller i need to do requestmapping |
| 16:01:49 | *** cta has quit IRC |
| 16:02:34 | *** jwishnie has quit IRC |
| 16:02:51 | <asgoyal> so dont i need to provide the url for the @requestmapping? |
| 16:12:31 | <asgoyal> djazayeri: ^^ |
| 16:12:50 | <djazayeri> asgoyal: you do need a url for the @RequestMapping |
| 16:12:57 | <djazayeri> you don't need to add a link to the admin page. |
| 16:13:53 | <asgoyal> oh ok |
| 16:21:35 | <asgoyal> I am little confused... djazayeri how will the controller i created be invoked? |
| 16:21:55 | <djazayeri> For the moment you will manually type the URL into the address bar. |
| 16:22:19 | <djazayeri> Remember how the original ticket is to create the re-usable widgets for selecting these? |
| 16:22:30 | <djazayeri> but we're starting off with a plain page? |
| 16:22:36 | *** wyclif has quit IRC |
| 16:22:39 | *** gauravpaliwal has left #openmrs |
| 16:22:42 | <djazayeri> Well, eventually this will go in the patient dashboard. |
| 16:22:56 | <djazayeri> but we're not there yet. |
| 16:23:42 | <asgoyal> original ticket? ... I m sorry but i dont remember :( ... or can you give me the URL? |
| 16:24:13 | <djazayeri> I mean the ticket you're working on now |
| 16:24:16 | <djazayeri> TRUNK-2383 |
| 16:24:22 | <asgoyal> ah ok |
| 16:24:28 | <asgoyal> oh |
| 16:24:36 | *** rafa_ has joined #openmrs |
| 16:24:36 | *** ChanServ sets mode: +v rafa_ |
| 16:25:16 | <asgoyal> and what is the URL you mentioned above? |
| 16:25:29 | <djazayeri> you can make one up |
| 16:25:41 | <djazayeri> for example call it "chooseOrderable" |
| 16:25:53 | <djazayeri> e.g. localhost:8080/openmrs/chooseOrderable |
| 16:26:04 | <djazayeri> or maybe "orderEntry" |
| 16:26:36 | <djazayeri> i.e. you are adding a page temporarily, which is going to be refactored later. |
| 16:26:42 | <djazayeri> So you can call the URL whatever yo want. |
| 16:26:54 | *** rafa has quit IRC |
| 16:28:09 | <asgoyal> ok .... a silly question... how do i make my own url... is it that jsp file? :S |
| 16:28:57 | <djazayeri> Basically you need to just use a (made-up) URL in the @RequestMapping, and put a jsp page with that same name (in the right folder) |
| 16:28:59 | *** wyclif has joined #openmrs |
| 16:29:18 | <asgoyal> aaaww ok |
| 16:29:33 | <asgoyal> ok got it |
| 16:31:07 | <asgoyal> One more question |
| 16:31:16 | <asgoyal> once i m done with those two files |
| 16:31:26 | <asgoyal> how will i run it to see? |
| 16:31:39 | <asgoyal> mvn jetty:run in webapp folder? |
| 16:31:56 | <djazayeri> yes |
| 16:32:27 | <asgoyal> or first navigate to the controller folder and then use some other command? |
| 16:32:32 | <asgoyal> oh ok |
| 16:33:39 | *** wyclif has quit IRC |
| 16:35:34 | *** bwolfe has quit IRC |
| 16:43:48 | *** downeym has joined #openmrs |
| 16:43:48 | *** OpenMRSBot sets mode: +o downeym |
| 16:43:48 | *** ChanServ sets mode: +o downeym |
| 16:47:03 | *** downeym_ has quit IRC |
| 16:47:38 | *** gauravpaliwal has joined #openmrs |
| 16:47:38 | *** ChanServ sets mode: +v gauravpaliwal |
| 16:47:49 | *** gauravpaliwal has left #openmrs |
| 16:49:20 | *** wyclif has joined #openmrs |
| 16:49:59 | *** cta has joined #openmrs |
| 16:50:26 | *** asgoyal has quit IRC |
| 16:57:37 | *** goutham has joined #openmrs |
| 17:01:58 | *** downeym has quit IRC |
| 17:02:21 | *** rafa_ has quit IRC |
| 17:09:23 | *** bwolfe has joined #openmrs |
| 17:09:23 | *** ChanServ sets mode: +o bwolfe |
| 17:10:22 | *** Suranga_ has joined #openmrs |
| 17:16:14 | *** goutham has quit IRC |
| 17:19:42 | *** saimanohar has joined #openmrs |
| 17:20:08 | <saimanohar> hi all! |
| 17:20:31 | <saimanohar> how are we storing visit attributes in openmrs? |
| 17:20:40 | <djazayeri> hi sai |
| 17:21:06 | <djazayeri> it's a very alpha feature, but in OpenMRS trunk you can see VisitAttribute, VisitAttributeType, AttributeTypeHandler, ... |
| 17:21:43 | *** bryq has joined #openmrs |
| 17:21:43 | *** ChanServ sets mode: +v bryq |
| 17:22:08 | <saimanohar> i havent found an addAttribute method in visit class to add to the list so i was wondering |
| 17:23:04 | <djazayeri> Visit implements Customizable<VisitAttribute> |
| 17:23:14 | <djazayeri> -> it should have addAttribute(VisitAttribute) |
| 17:23:20 | <djazayeri> and setAttribute(VisitAttribute) |
| 17:23:36 | <djazayeri> those are defined in BaseCustomizableData |
| 17:23:46 | <saimanohar> okay! |
| 17:24:03 | <djazayeri> we're trying to write the methods in a standardized way so that everything that supports attributes behaves the same way |
| 17:24:24 | <saimanohar> okay fantastic |
| 17:27:08 | *** mandric has quit IRC |
| 17:30:49 | *** bwolfe has quit IRC |
| 17:31:56 | <saimanohar> hey Darius |
| 17:32:20 | <saimanohar> i cant use the attributeservice |
| 17:32:32 | <saimanohar> with out adding a maven dependency |
| 17:32:38 | <saimanohar> right? |
| 17:32:49 | <djazayeri> for trunk you mean? |
| 17:34:05 | <saimanohar> i have a module which has an object which can have attributes,hence i have created object,object_attribute and object_attribute_type |
| 17:34:47 | <djazayeri> so, this attribute stuff isn't coming until OpenMRS 1.9 |
| 17:34:58 | <djazayeri> What OpenMRS version is your module targeting? |
| 17:35:31 | <saimanohar> my maven dependency is having 1.8 alpha right now |
| 17:36:26 | <saimanohar> i think it comes from the basic module |
| 17:37:24 | <djazayeri> I mean: for business reasons, what OpenMRS version are you targeting? |
| 17:37:39 | <djazayeri> Roger probably has an opinion on this. |
| 17:38:02 | <djazayeri> If you're targeting OpenMRS 1.8 or below, you can't use the upcoming attribute handler stuff |
| 17:38:19 | <djazayeri> if you're okay having the HR module not work until OpenMRS 1.9, then you can use it. |
| 17:38:38 | <djazayeri> Note that it's very alpha, and trying to use it you'll certainly run into bugs. |
| 17:38:50 | <saimanohar> yeah i have to probably discuss with him about which version we are targetting |
| 17:38:52 | <djazayeri> Are generic attributes strictly required for your use case right now? |
| 17:40:11 | <saimanohar> yeah i am not sure though,but most proabably yes and we are trying to implement it the new way |
| 17:52:03 | *** bwolfe has joined #openmrs |
| 17:52:03 | *** ChanServ sets mode: +o bwolfe |
| 17:53:00 | *** downeym has joined #openmrs |
| 17:53:00 | *** ChanServ sets mode: +o downeym |
| 17:53:00 | *** OpenMRSBot sets mode: +o downeym |
| 17:56:06 | *** yanokwa has joined #openmrs |
| 17:58:41 | <yanokwa> now that the standalone is out, do people think the appliance/vm is needed? |
| 17:59:22 | <bwolfe> yanokwa, theres less of a need for it. are you thinking of discontinuing it ? |
| 18:00:06 | <djazayeri> yanokwa: I think the appliance becomes much less useful for someone just wanting to try OpenMRS out on their machine yes. |
| 18:00:14 | <yanokwa> bwolfe: yup. thinking about retiring it after this 1.80 release... |
| 18:00:14 | <bwolfe> yanokwa, would be worth pinging the dev list to ask if anyone sees the use and/or wants to take over "ownership" from you |
| 18:00:43 | *** gbastien has joined #openmrs |
| 18:00:44 | <djazayeri> But having an appliance that's sort of a "starter version" for VM-hosted solutions is still useful. |
| 18:00:55 | <djazayeri> yanokwa: is the appliance useful for that at this point? |
| 18:01:39 | <yanokwa> djazayeri: yeah, it's super useful for hosted solutions. that's how win and i test the clinical summary stuff. multiple vms on one big machine. |
| 18:02:02 | <djazayeri> Okay, well, then I think it's still useful. |
| 18:02:21 | *** downeym has quit IRC |
| 18:02:59 | <djazayeri> bwolfe: did you fix the destructive bug related to https://tickets.openmrs.org/browse/RESTWS-13? |
| 18:03:06 | <bwolfe> djazayeri, yes |
| 18:03:06 | <yanokwa> djazayeri: agreed. i think i'll keep releasing them as long as i keep using them. after that, i'll pass it on |
| 18:03:24 | <djazayeri> bwolfe: please comment on the ticket then. |
| 18:03:27 | <djazayeri> yanokwa: makes sense |
| 18:03:32 | <bwolfe> yanokwa, how long does it take you to package it all, start to finish? |
| 18:03:38 | <bwolfe> djazayeri, odd, I thought I did |
| 18:04:15 | <yanokwa> bwolfe: depends on how beefy your machine is. generally, takes an hour or two to build and test. |
| 18:05:38 | <yanokwa> bwolfe: the catch is whomever takes it over will have to tweak things a bit so it's more ubuntu/mac independent |
| 18:05:56 | *** gbastien has quit IRC |
| 18:08:16 | <djazayeri> bwolfe: when did you say you were planning to merge app-test? |
| 18:08:22 | <bwolfe> asap |
| 18:08:45 | *** downeym has joined #openmrs |
| 18:08:45 | *** ChanServ sets mode: +o downeym |
| 18:08:45 | *** OpenMRSBot sets mode: +o downeym |
| 18:08:45 | <bwolfe> asap -- after applying ankur's last 4 patches |
| 18:08:52 | <djazayeri> cool |
| 18:13:58 | <yanokwa> @bwolfe if i point you to a url with the vm, can you add it to the sourceforge page? |
| 18:14:05 | *** mandric has joined #openmrs |
| 18:14:20 | <djazayeri> maybe easier for downeym to do that |
| 18:14:27 | <djazayeri> downeym: ^^ |
| 18:14:36 | <downeym> yanokwa: sure |
| 18:14:48 | <yanokwa> http://cs.washington.edu/homes/yanokwa/tmp/OpenMRS_1.8.0.vmwarevm.7z |
| 18:14:50 | <downeym> yanokwa: or i can give you permissions if you have an SF account |
| 18:14:54 | <OpenMRSBot> <http://ln-s.net/8x0U> (at cs.washington.edu) |
| 18:15:10 | <yanokwa> @downeym permissions me |
| 18:17:50 | * downeym added yanokwa |
| 18:18:05 | * yanokwa thanks downeym. now to recover my sf password :) |
| 18:18:18 | <downeym> i'm downloading from uw but it may take longer to download it than your password reset. |
| 18:18:24 | *** gbastien has joined #openmrs |
| 18:23:55 | *** vchircu has joined #openmrs |
| 18:25:59 | *** downeym_ has joined #openmrs |
| 18:25:59 | *** ChanServ sets mode: +o downeym_ |
| 18:27:49 | *** mandric_ has joined #openmrs |
| 18:27:50 | *** Suranga_ has quit IRC |
| 18:28:36 | *** mandric_ has quit IRC |
| 18:29:01 | *** mandric_ has joined #openmrs |
| 18:29:09 | *** downeym has quit IRC |
| 18:29:09 | *** downeym_ is now known as downeym |
| 18:29:29 | *** downeym sets mode: +v yanokwa |
| 18:29:32 | *** downeym sets mode: +v wyclif |
| 18:29:34 | *** downeym sets mode: +v vchircu |
| 18:29:36 | *** downeym sets mode: +v saimanohar |
| 18:29:39 | *** downeym sets mode: +v cta |
| 18:29:47 | *** mandric_ has quit IRC |
| 18:30:11 | *** mandric has quit IRC |
| 18:31:04 | *** mandric has joined #openmrs |
| 18:51:00 | <djazayeri> cta: I added a comment on the review. It's up to you whether you want to try to address it or not. |
| 18:51:10 | <djazayeri> (It's not required) |
| 18:51:26 | <djazayeri> let me know what you decide, and I'll either close the ticket or put it back in Rework Needed. |
| 18:53:17 | *** vchircu has quit IRC |
| 18:53:19 | <yanokwa> downeym the pw reset will take a week or so -- my registered email addy is no longer valid. anyway, upload whenever you are ready. |
| 18:55:18 | *** vchircu has joined #openmrs |
| 18:56:33 | <djazayeri> bwolfe, wyclif, burke_away: what privilege should we check on getOrderables(String)? |
| 18:56:47 | <downeym> yanokwa: roger that |
| 18:56:59 | <burke_away> djazayeri: Can View Orderables |
| 18:57:06 | *** burke_away is now known as burke |
| 18:57:09 | <djazayeri> and how about on saveOrderSet and publishOrderSet |
| 18:57:37 | <djazayeri> Is there a use case for View Orderables != View Orders? |
| 18:57:40 | <burke> djazayeri: Can Manage Order Sets |
| 18:58:14 | <djazayeri> I agree that both OrderSet and PublishedOrderSet-related stuff gets Manage Order Sets. |
| 18:58:35 | <djazayeri> (or View Order Sets) i.e. nothing specific for PublishedOrderSEt |
| 18:58:41 | <burke> What's the diff b/w order set & published order set? Just published == true? |
| 18:59:06 | <djazayeri> nah, PublishedOrderSet is the extra mapping table we created to link concept to OrderSet. |
| 18:59:18 | <burke> Actually, there *should* be a difference between viewing published data sets and viewing unpublished data sets. |
| 18:59:36 | <djazayeri> published actually means "linked to a concept" so maybe that's the wrong term |
| 18:59:39 | <burke> Oh. OrderableOrderSet. |
| 18:59:40 | <djazayeri> it's the "top-level order sets" |
| 18:59:41 | <djazayeri> yes |
| 18:59:46 | <burke> Ok. |
| 19:00:07 | <djazayeri> I guess I can rename to OrderableOrderSet |
| 19:00:17 | <djazayeri> not sure that's clearer though |
| 19:00:29 | <burke> (you may know this), but an order set can be both top-level and not top-level -- i.e., pain meds. |
| 19:00:45 | <cta> djazayeri: Darius, I'm here, I read your comment |
| 19:01:00 | <burke> Not 100% sure it matters, but "publishing" may become a distinct workflow from making orderable. |
| 19:01:13 | <burke> When ordering, people will definitely see those order sets linked to orderables. |
| 19:01:23 | <burke> But there might be other mechanisms for getting to order sets |
| 19:01:26 | <djazayeri> okay, well, we should probably review all terminology we've added in one go at the end of the sprint. |
| 19:02:00 | <burke> For example, wiring up a decision support rule to show an order set. You want to select from published order sets, but may want to include published order sets that are not "orderable" (linked to a concept). |
| 19:02:09 | <downeym> yanokwa: http://sourceforge.net/projects/openmrs/files/releases/OpenMRS_1.8.0/OpenMRS_1.8.0.vmwarevm.7z/download |
| 19:02:43 | <djazayeri> burke: I agree that we may want to distinguish between those. |
| 19:03:33 | <djazayeri> but, ignoring that for the moment, do you agree that managing OrderSet/OrderSetMember, and also OrderableOrderSet is all one privilege? |
| 19:03:56 | <burke> Yes. That's all part of managing order sets. |
| 19:05:40 | *** hxiao has joined #openmrs |
| 19:05:44 | <djazayeri> And the other question, what about listing Orderables vs viewing Orders. |
| 19:05:47 | <downeym> Hi hxiao and welcome to the #openmrs IRC channel. |
| 19:05:50 | <djazayeri> Are those the same or different? |
| 19:05:55 | <djazayeri> (privilege-wise) |
| 19:07:28 | <burke> djazayeri: hmmm.... |
| 19:07:31 | * burke thinking |
| 19:08:12 | <burke> Viewing Orderables is much more akin to viewing concepts and Orders like viewing Obs â i.e., the former is viewing metadata & the latter is viewing patient data, so should have different privs, IMHO. |
| 19:08:23 | <yanokwa> thanks downeym |
| 19:08:32 | <djazayeri> Fair enoug |
| 19:08:35 | <djazayeri> h |
| 19:08:52 | <burke> i |
| 19:10:26 | <cta> djazayeri: I've read your comment and I will try to fix your comments |
| 19:11:06 | <cta> djazayeri: I'd like to close this ticket, so I will add required fixes asap |
| 19:13:31 | <djazayeri> okay |
| 19:14:06 | <djazayeri> cta: if as you start to change that, you find that the code gets less readable, then just tell me that, and we'll it as-is with a context-sensitive test |
| 19:15:14 | <cta> djazayeri: no problem |
| 19:22:23 | <burke> bbl |
| 19:22:26 | *** burke has quit IRC |
| 19:23:29 | <hxiao> I used fieldgen to display all choices of a coded concept (e.g. race). Is there a way to sort the choice display by answer ID's rather than by the alphabetic order of the answer texts? |
| 19:25:17 | <djazayeri> hxiao: AFAIK that's not possible |
| 19:25:44 | <djazayeri> take a look at conceptField.tag and its use of showAnswer and see if there's a way around that. |
| 19:28:28 | *** yanokwa has quit IRC |
| 19:29:26 | <hxiao> Thank you Darius for your quick answer. I'll look at the conceptField.tag then. |
| 19:36:40 | *** saimanohar has quit IRC |
| 19:43:26 | *** burke_away has joined #openmrs |
| 19:43:26 | *** ChanServ sets mode: +o burke_away |
| 19:44:23 | <cta> djazayeri: Darius, I changed OrderGroupValidator class and now it's not base test sensitive. And I do beleive that code didn't became unreadable. You can check the code here - http://pastebin.com/3eTr7YVS. Please, do it ASAP and say that you agree with me and then I commit the code. |
| 19:45:32 | <djazayeri> cta: I like this. |
| 19:45:39 | <djazayeri> can you make one change to it before committing? |
| 19:45:50 | <cta> dfjazayeri: ok, what? |
| 19:45:51 | <djazayeri> in a couple cases you have Assert.assertTrue(errors.hasErrors()) |
| 19:45:59 | <cta> yes |
| 19:46:00 | <djazayeri> but you don't actually verify which field has the error. |
| 19:46:11 | <djazayeri> e.g. lines 64-67 of that pastebin |
| 19:46:29 | <djazayeri> There and in 1-2 other places you should also add an Assert.assertTrue(errors.hasFieldErrors("...")) |
| 19:47:41 | <cta> djazayeri: May I ask a question how to detect error that was set as errors.reject("OrderGroup.orderPatientMatching") for example? |
| 19:48:34 | <djazayeri> cta: IIRC you did that reject within a pushNestedPath, right? |
| 19:48:48 | <djazayeri> in that case from the parent the field that was rejected is members[0] or something |
| 19:48:50 | <djazayeri> right? |
| 19:49:05 | <cta> not everywhere |
| 19:49:40 | <cta> for example this code: |
| 19:49:47 | <cta> if (order.getPatient() != null && !order.getPatient().equals(group.getPatient())) |
| 19:49:47 | <cta> |
| 19:49:49 | <cta> errors.reject("OrderGroup.orderPatientMatching"); |
| 19:51:07 | <djazayeri> ah, then you actually need to change the OrderGroupValidator so that you reject a specific field. |
| 19:51:32 | <djazayeri> actually, just move that above the popNestedPath()... |
| 19:51:51 | <djazayeri> inside the try, I mean. |
| 19:52:14 | <cta> ok, understood |
| 20:05:37 | *** dkayiwa has joined #openmrs |
| 20:15:19 | <cta> djazayeri: Darius, I'm bit confused, may be I wrong understood you, but after adding that like nested path errors, call Assert.assertTrue(errors.hasFieldErrors("members[0]")) fails for me |
| 20:27:39 | <wyclif> djazayeri, which code formatter do you use? |
| 20:27:46 | <wyclif> i used the openmrs code formatter |
| 20:28:24 | <djazayeri> cta: can you try errors.getAllFieldErrors() and inspect them (e.g. in the debugger) to see what field actually has the error? |
| 20:28:39 | <djazayeri> wyclif: I commented on a specific line, right? Doesn't it seem to have been cut short to you? |
| 20:28:54 | <cta> djazayeri: ok;-) |
| 20:29:02 | *** james_regen has quit IRC |
| 20:29:31 | *** vchircu has quit IRC |
| 20:32:40 | *** dkayiwa_ has joined #openmrs |
| 20:33:57 | *** dkayiwa has quit IRC |
| 20:33:57 | *** dkayiwa_ is now known as dkayiwa |
| 20:35:02 | <cta> djazayeri: Darius, I inspected them and found out that in this case method getFiledErrors():List<FieldError> returns empty list and method getAllErrors():List<ObjectError> returns 1 element. In fact, I do not know another way how to check nested path errors (as you can see, they are represented as general erros and we can check them only by errors.hasErrors() method |
| 20:36:14 | <cta> djazayeri: I propose to leave all as-is because we actually know where should be error, it only tests at all |
| 20:36:37 | <djazayeri> well, not quiteâwe do need to report the error on the right field. |
| 20:36:59 | <djazayeri> but if you need to move on to other things, we can leave this as a to-do for later. |
| 20:37:28 | <djazayeri> Can you create a ticket saying "Make sure OrderGroupValidator reports error on the correct field when (situation)"? |
| 20:37:30 | <cta> djazayeri: ok. So, can I commit the code? |
| 20:37:41 | <djazayeri> Yes, then commit and we'll close the existing ticket. |
| 20:37:44 | *** dkayiwa_ has joined #openmrs |
| 20:37:52 | <cta> ok, just a minute |
| 20:38:30 | *** dkayiwa has quit IRC |
| 20:42:48 | *** dkayiwa_ has quit IRC |
| 20:43:50 | <cta> djazayeri: I've commited code at revision 21055. Youi can close the ticket https://tickets.openmrs.org/browse/TRUNK-2378 |
| 20:46:34 | *** dkayiwa has joined #openmrs |
| 20:48:15 | <djazayeri> bwolfe: did you mavenize the serialization.xstream module? |
| 20:49:43 | *** mandric has quit IRC |
| 20:50:15 | *** mseaton has joined #openmrs |
| 20:50:20 | *** mseaton_ has joined #openmrs |
| 20:50:29 | <mseaton_> @bwolfe - you there? |
| 20:50:31 | <downeym> Hi mseaton_ and welcome to the #openmrs IRC channel. |
| 20:50:36 | *** bwolfe has quit IRC |
| 20:50:58 | <djazayeri> doh |
| 20:51:13 | <mseaton_> yeah |
| 20:51:37 | *** mseaton_ has quit IRC |
| 20:51:37 | *** mseaton has quit IRC |
| 20:51:46 | <cta> djazayeri: Darius, I added new ticjet as you asked. It is https://tickets.openmrs.org/browse/TRUNK-2423 |
| 20:51:56 | <djazayeri> thanks, cta, I'll close these, link them, etc. |
| 20:52:13 | *** dkayiwa has quit IRC |
| 20:53:24 | <djazayeri> off to lunch for now |
| 20:53:56 | *** mandric has joined #openmrs |
| 21:13:03 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Fixed OrderGroupValidatorTest to be not BaseContextSensitiveTest dependent and fixed after review comments - TRUNK-2378 <http://feedproxy.google.com/~r/OMRStrunk/~3/FxedkXcCQqA/OpenMRS> || On Twitter: OpenMRS: RT @askanter: MVP is looking for a senior developer in NY with Python/Django ,#rapidsms and @openMRS exerience. Bamako/NBO shortly, too. <http://twitter.com/OpenMRS/statuses/85447466190782464> || On Twitter: OpenMRS: The #OpenMRS 1.8 Appliance virtual machine by @yanokwa is now available! More info & download: http://bit.ly/kpwyFO <http://twitter.com/OpenMRS/statuses/85447434788016128> |
| 21:16:22 | *** hxiao has quit IRC |
| 21:21:24 | *** burke_away has quit IRC |
| 21:27:48 | *** bryq has quit IRC |
| 21:57:56 | *** Echidna has quit IRC |
| 22:03:05 | *** Echidna has joined #openmrs |
| 22:03:05 | *** ChanServ sets mode: +v Echidna |
| 22:10:36 | <cta> djazayeri: Darius, I'd like to know what do you think about 2391 ticket? Since you've already removed corresponding code at saveOrder(...) method by yourself (for getting rid of versioning and preventing duplication of orders numbers), can we close this one too? |
| 22:10:56 | <djazayeri> !ticket trunk-239 |
| 22:10:56 | <OpenMRSBot> djazayeri: Allow me to help you with that. More details on ticket trunk-239 can be found at http://tickets.openmrs.org/browse/trunk-239 |
| 22:11:05 | <djazayeri> !ticket TRUNK-2391 |
| 22:11:05 | <OpenMRSBot> djazayeri: Allow me to help you with that. More details on ticket TRUNK-2391 can be found at http://tickets.openmrs.org/browse/TRUNK-2391 |
| 22:12:07 | <djazayeri> cta: is the section I commented on there something that I then later changed myself? |
| 22:12:30 | <djazayeri> i.e. I already got rid of the whole if/then/else block? |
| 22:13:53 | <cta> djazayeri: Yes you did |
| 22:14:02 | <djazayeri> okay, then I will close this ticket. |
| 22:14:15 | <djazayeri> Thanks for pointing that out. I've been looking at a lot of code and reviews lately. :-) |
| 22:14:48 | <cta> djazayeri: no problem. thank you Darius! |
| 22:15:38 | <cta> now I'm off, gotta shuteye, see tomorrow |
| 22:15:45 | <djazayeri> bye, thanks for all the tickets! |
| 22:15:46 | <cta> bye guys |
| 22:16:03 | *** cta has quit IRC |
| 22:17:43 | *** downeym has quit IRC |
| 22:24:56 | *** gbastien has quit IRC |
| 22:25:11 | *** gbastien has joined #openmrs |
| 22:30:00 | *** wyclif has quit IRC |
| 23:23:21 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Followup from code review: adding @since and @Authorized - TRUNK-2373 <http://feedproxy.google.com/~r/OMRStrunk/~3/m7dFUKwN5do/OpenMRS> |
| 23:58:31 | *** wyclif has joined #openmrs |