| 00:08:19 | *** vlad__ has joined #openmrs |
| 00:13:49 | *** wyclif has quit IRC |
| 00:20:52 | *** vlad__ has quit IRC |
| 00:32:12 | *** mandric has quit IRC |
| 00:55:07 | *** wyclif has joined #openmrs |
| 01:16:01 | *** muthah_ has joined #openmrs |
| 01:16:33 | *** muthah has quit IRC |
| 01:16:36 | *** muthah_ is now known as muthah |
| 01:56:45 | *** mandric has joined #openmrs |
| 02:27:27 | *** djazayeri has quit IRC |
| 03:00:40 | *** mandric has quit IRC |
| 03:06:52 | *** gbastien has quit IRC |
| 03:14:32 | *** vlad___ has joined #openmrs |
| 03:22:50 | *** djazayeri has joined #openmrs |
| 03:22:50 | *** ChanServ sets mode: +o djazayeri |
| 03:27:41 | *** vlad___ has quit IRC |
| 04:22:53 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Remove order_type table - TRUNK-2403 <http://feedproxy.google.com/~r/OMRStrunk/~3/O-HJLqvw2xA/OpenMRS> |
| 04:56:24 | *** goutham has joined #openmrs |
| 05:09:15 | <djazayeri> wyclif: careful with those commitsâ¦I see a "testMe()" method... |
| 05:10:37 | <djazayeri> as well as 6 conflicts on the svn update I just did. (though that could be my fault, I'm not sure) |
| 05:13:00 | *** goutham has quit IRC |
| 05:15:17 | <djazayeri> make sure to run a maven build to get the formatting done before committing |
| 05:18:42 | <djazayeri> (actually they're all real conflictsâwe just both added methods to the bottom of the same files.) |
| 05:28:49 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @djazayeri: Removing a net 550 lines of code in a commit: priceless. #OpenMRS <http://twitter.com/OpenMRS/statuses/84478783607947264> |
| 05:53:21 | *** goutham has joined #openmrs |
| 06:01:01 | *** bwolfe has joined #openmrs |
| 06:01:01 | *** ChanServ sets mode: +o bwolfe |
| 06:13:08 | *** goutham has quit IRC |
| 06:35:03 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): allow publishing order sets as concepts - TRUNK-2373 <http://feedproxy.google.com/~r/OMRStrunk/~3/anaB0RsqsaM/OpenMRS> |
| 06:52:07 | *** muthah has quit IRC |
| 06:54:40 | *** bwolfe_ has joined #openmrs |
| 06:54:40 | *** ChanServ sets mode: +o bwolfe_ |
| 06:57:02 | *** bwolfe has quit IRC |
| 07:07:03 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Searching Orderables needs to return OrderSets too - TRUNK-2377 <http://feedproxy.google.com/~r/OMRStrunk/~3/W_Tj5JQi6sQ/OpenMRS> |
| 08:23:45 | *** sreya has joined #openmrs |
| 08:26:35 | <sreya> hi bwolfe_ |
| 08:26:38 | <sreya> u there |
| 08:27:27 | <sreya> i am trying to override the default messagesourceimpl so that instaed my module is used , but i am unable to do so |
| 08:28:55 | <sreya> i made my service extend from the reloadableresourcebundlemessage also , tried with the abstractmessagesource , tried using only interface message source and heiracrhical but no use |
| 09:16:11 | *** jportela has quit IRC |
| 09:16:31 | *** jportela has joined #openmrs |
| 09:16:31 | *** ChanServ sets mode: +v jportela |
| 09:27:53 | *** pascal` has joined #openmrs |
| 09:34:32 | *** jportela has quit IRC |
| 09:37:44 | *** vlad__ has joined #openmrs |
| 09:41:46 | *** sreya has quit IRC |
| 10:01:39 | *** muthah has joined #openmrs |
| 10:15:05 | *** rafa has joined #openmrs |
| 10:15:05 | *** ChanServ sets mode: +v rafa |
| 10:22:21 | *** bwolfe_ is now known as bwolfe |
| 11:19:16 | *** goutham has joined #openmrs |
| 11:39:06 | *** goutham has quit IRC |
| 12:11:53 | *** goutham has joined #openmrs |
| 13:50:13 | *** Hazamonzo has left #openmrs |
| 13:57:20 | *** goutham has quit IRC |
| 13:57:50 | *** goutham has joined #openmrs |
| 14:02:06 | *** goutham has quit IRC |
| 14:22:54 | *** gbastien has joined #openmrs |
| 14:25:34 | *** bryq has joined #openmrs |
| 14:25:34 | *** ChanServ sets mode: +v bryq |
| 14:45:26 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): TRUNK-2292 : backporting to 1.8.x as part of RESTWS-147 <http://feedproxy.google.com/~r/OMRStrunk/~3/jOMNOKVblv4/OpenMRS> |
| 14:51:42 | *** muthah has quit IRC |
| 15:22:30 | *** sreya has joined #openmrs |
| 15:24:46 | <sreya> hey bwolfe |
| 15:24:48 | <sreya> u there |
| 15:24:55 | <bwolfe> hi |
| 15:26:03 | <sreya> hey |
| 15:26:11 | <sreya> thank god i found you |
| 15:26:41 | <sreya> i am trying to invoke my service for resource bundle rather than the messagesourceimpl |
| 15:26:58 | <sreya> but whatever i tried just does not work |
| 15:27:33 | <sreya> i tried creating a class which extends ReloadableResourceBundleMessageSource |
| 15:27:55 | <sreya> then i tried only extending from AbstarctMessageSource |
| 15:28:24 | <sreya> but<spring:message> does not invoke my class |
| 15:28:54 | <sreya> but for bean configuration i didnot use any property like basename , etc |
| 15:29:55 | <sreya> my bean defination was very simple <bean id=messageSource class= org.openmrs.module.DatabaseMessageProperties.MS> |
| 15:30:16 | <sreya> where org.openmrs.module.DatabaseMessageProperties.MS is the subclass of reloadbleresourcebundle |
| 15:30:31 | <sreya> bwolfe: |
| 15:30:47 | <sreya> how should i delegate the call to my service |
| 15:30:50 | <sreya> bwolfe: |
| 15:30:59 | <bwolfe> sreya, did you try just overwriting it in the spring app context file? |
| 15:31:10 | <sreya> no |
| 15:31:13 | <bwolfe> or maybe spring will let you register another one |
| 15:31:27 | <bwolfe> so that first yours is checked, then if not found it goes ot the messages.properties files |
| 15:31:36 | <sreya> i only wrote the bean configuration in my module application context |
| 15:31:42 | <bwolfe> look in openmrs-servlet.xml for how to register |
| 15:31:51 | <bwolfe> yes, your moduleappcontext is a spring app context file |
| 15:32:19 | <sreya> i dont know how to register the it as the message source |
| 15:32:42 | <sreya> i simply declared it under <bean> as i have mentioned above |
| 15:33:06 | <sreya> are there any speacial properties to override it |
| 15:33:23 | <sreya> its simply not overriding the exsising messagesource |
| 15:34:33 | <sreya> how should i declare it in my context file |
| 15:34:37 | <sreya> bwolfe: |
| 15:37:03 | <bwolfe> yes, there is something you need to set it on |
| 15:37:19 | <bwolfe> look at messagesourceservicetarget in applicationcontext-services.xml maybe |
| 15:37:34 | * bwolfe can't remember which spring file actually does the registering |
| 15:42:01 | <sreya> i have seen it all |
| 15:43:02 | <sreya> in it messagesourceservicetarget is set to class which is extending from reloadableresourcebundle |
| 15:44:48 | <sreya> i will do one thing bwolfe i would try it once more n send you the zip file of what i have done |
| 15:44:57 | <sreya> if i dont get the thing working |
| 15:45:18 | *** sreya_ has joined #openmrs |
| 15:46:13 | <sreya> bwolfe: |
| 15:46:32 | *** saimanohar has joined #openmrs |
| 15:46:46 | <bwolfe> sreya, just send me the xml files |
| 15:46:54 | <bwolfe> I don't want a zip of the entire project |
| 15:46:54 | <sreya> ok |
| 15:46:57 | <bwolfe> (or send a patch file) |
| 15:46:58 | <sreya> fine |
| 15:47:02 | <sreya> ok |
| 15:47:13 | *** kmit has joined #openmrs |
| 15:47:22 | <saimanohar> hello all |
| 15:47:35 | <bwolfe> hi sai |
| 15:47:44 | <saimanohar> i have a strange behaviour in my code. |
| 15:48:24 | <saimanohar> i have a conceptid=7777703 |
| 15:48:57 | <saimanohar> i have entries for sconcept_map and conept_srource |
| 15:49:27 | <saimanohar> when i execute something like this - Concept conceptId=cs.getConceptByMapping("Cadre q","HR Module"); Concept cadre=cs.getConcept(7777703); |
| 15:49:32 | *** sreya_ has quit IRC |
| 15:49:45 | <saimanohar> i dont get my concept i need |
| 15:50:22 | <saimanohar> but if i dont call the getConceptsByMapping method and pass the static value to getConcept method it works fine |
| 15:50:58 | <saimanohar> any idea about this behaviour? |
| 15:51:22 | *** sreya has quit IRC |
| 15:51:23 | <saimanohar> oh actually i pasted some wrong code there |
| 15:51:58 | <saimanohar> ConceptService cs=Context.getConceptService(); int conceptId=cs.getConceptByMapping("Cadre","HR Module").getConceptId(); Concept cadre=cs.getConcept(conceptId); |
| 15:52:05 | <saimanohar> this is the correct version |
| 15:53:36 | <bwolfe> saimanohar, can't you do Concept cadre = Context.getConceptService().getConceptByMapping("...", "..."); |
| 15:54:06 | <bwolfe> is getConceptByMapping throwing an error due to multiple matches? |
| 15:54:41 | <saimanohar> nope no error |
| 15:54:52 | <saimanohar> yeah i did that initially |
| 15:55:17 | <saimanohar> but it was not returning the concept i needed |
| 15:55:29 | <bwolfe> what is it returning then? |
| 15:55:42 | <bwolfe> if its not returning hte right one, then theres a problem with your mapping or th esource or the concept :-p |
| 15:55:53 | <bwolfe> bbl, have to get some kids some baths |
| 15:55:53 | <saimanohar> it gave me a concept which had id=7777703 |
| 15:55:59 | <saimanohar> but nothing else set |
| 15:56:06 | <saimanohar> everything else was null |
| 15:58:53 | <saimanohar> thats why i thought of getting the concept again by calling getConcept() method with one argument 7777703 after the call to getConceptByMapping |
| 16:00:56 | <saimanohar> no matter whether i passed that argument from getConceptByMapping("....","....").getConceptId() or as a static value 7777703 it was not giving me the concept |
| 16:01:14 | <saimanohar> but if i hadnt called the getConcept |
| 16:01:28 | <saimanohar> *getCocneptByMapping method |
| 16:01:48 | <saimanohar> the getConcept(7777703) was returning me the required concept |
| 16:08:27 | *** mandric has joined #openmrs |
| 16:13:50 | <bwolfe> saimanohar, were you looking at it with a debugger? the other fields aren't null, they are just lazy loaded by hibernate |
| 16:14:06 | <bwolfe> you have to call "getName()" or "getVersion()" or "getDescription()" for those other fields to be loaded in |
| 16:14:12 | <bwolfe> just calling getConceptByMapping shoudl work |
| 16:14:19 | <saimanohar> okay,yeah i was debugging it |
| 16:14:56 | <saimanohar> i just deleted the tomcat temp folder restarted and the same old code starts working!! |
| 16:15:33 | <saimanohar> damn it ate half an hour of mine! |
| 16:17:11 | <saimanohar> Thanks Ben,I dont see that issue anymore |
| 16:19:37 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Added OrderGroupValidator and fixed all after-review comments - TRUNK-2378 <http://feedproxy.google.com/~r/OMRStrunk/~3/nOFdslutSrw/OpenMRS> |
| 16:31:24 | *** pascal` has quit IRC |
| 16:42:58 | *** kmit has quit IRC |
| 17:22:18 | *** muthah has joined #openmrs |
| 17:37:09 | *** mandric_ has joined #openmrs |
| 17:37:37 | *** mandric_ has quit IRC |
| 17:40:10 | *** mandric has quit IRC |
| 17:48:30 | *** cta has joined #openmrs |
| 17:48:40 | <cta> hello |
| 17:50:40 | <bwolfe> hi cta |
| 18:02:39 | <djazayeri> hi |
| 18:06:34 | *** muthah has quit IRC |
| 18:18:30 | *** djazayeri has quit IRC |
| 18:38:02 | *** rafa has quit IRC |
| 18:43:42 | *** bwolfe has quit IRC |
| 18:46:38 | *** saimanohar has quit IRC |
| 19:03:52 | *** Suranga has joined #openmrs |
| 19:12:29 | *** Suranga has quit IRC |
| 19:28:38 | *** djazayeri has joined #openmrs |
| 19:28:38 | *** ChanServ sets mode: +o djazayeri |
| 20:04:08 | *** wyclif has quit IRC |
| 20:35:28 | <cta> djazayeri: Hello, Darius! I already made tests for OrderGroupValidator and run them. They were "green", so, I commited them. Also I made some minor changes within OrderServiceTest (exactly, within _unvoidOrderGroup_shouldUnvoidOrdersGroup_ test method). |
| 20:35:48 | <djazayeri> okay |
| 20:36:13 | <djazayeri> I probably won't look at this until monday |
| 20:37:04 | <cta> djazayeri: I know, it was for information |
| 20:39:30 | <cta> djazayeri: I did it today because next week I'm not going to do any tickets within sprint anymore. So, I decided to complete this ticket before next week starts. |
| 20:40:14 | <djazayeri> okay, cool |
| 20:40:26 | <djazayeri> so, if there are followup fixes required, would you like me to make them |
| 20:40:27 | <djazayeri> ? |
| 20:40:35 | <djazayeri> or assign them to you and you'll eventually get to them |
| 20:40:38 | <djazayeri> ? |
| 20:42:17 | <cta> if will be any required followup fixes you will assign them to me and I'll fix them, because, you know, I should _do_ complete that ticket. |
| 20:47:12 | *** djazayeri has quit IRC |
| 20:48:19 | *** djazayeri has joined #openmrs |
| 20:48:20 | *** ChanServ sets mode: +o djazayeri |
| 20:49:06 | <cta> djazayeri: Darius, you know, I noticed that time flies so imperceptibly, and it's already 23:45, and I need shuteye, so good bye and have a great weekend. See next week. |
| 20:49:27 | <djazayeri> gnight cta |
| 20:49:35 | <cta> bye, guys |
| 20:49:39 | *** cta has quit IRC |
| 21:11:58 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Added tests for OrderGroupValidator - TRUNK-2378 <http://feedproxy.google.com/~r/OMRStrunk/~3/NboTEtueVyw/OpenMRS> |
| 21:21:37 | *** djazayeri has quit IRC |
| 21:58:23 | *** djazayeri has joined #openmrs |
| 21:58:23 | *** ChanServ sets mode: +o djazayeri |
| 21:58:40 | *** bryq has quit IRC |
| 22:01:18 | *** djazayeri has quit IRC |