| 00:07:48 | *** downeym has joined #openmrs |
| 00:07:48 | *** ChanServ sets mode: +o downeym |
| 00:07:48 | *** OpenMRSBot sets mode: +o downeym |
| 00:25:13 | *** mandric has joined #openmrs |
| 00:30:22 | *** downeym has quit IRC |
| 00:44:10 | *** vlad____ has quit IRC |
| 01:31:53 | *** wyclif has joined #openmrs |
| 01:42:17 | *** dmexs has joined #openmrs |
| 02:05:24 | *** dmexs has quit IRC |
| 02:20:18 | *** dmexs has joined #openmrs |
| 02:43:43 | *** mandric has quit IRC |
| 02:46:18 | *** mandric has joined #openmrs |
| 02:48:35 | *** dmexs has quit IRC |
| 02:58:14 | *** mandric has quit IRC |
| 03:20:41 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Follow up to add descriptions for OrderAction enum values and improving drugorder constructor that takes in an orderable... <http://feedproxy.google.com/~r/OMRStrunk/~3/gkjoYW0sm-c/OpenMRS> |
| 03:53:05 | *** gbastien has quit IRC |
| 04:02:31 | *** pusakat has joined #openmrs |
| 04:13:09 | *** pusakat has quit IRC |
| 04:30:50 | *** dmexs has joined #openmrs |
| 04:33:19 | *** mandric has joined #openmrs |
| 04:38:10 | *** djazayeri has quit IRC |
| 04:38:40 | *** djazayeri has joined #openmrs |
| 04:38:40 | *** ChanServ sets mode: +o djazayeri |
| 04:53:08 | *** surangak has joined #openmrs |
| 04:54:14 | *** dmexs has quit IRC |
| 05:00:21 | *** mandric has quit IRC |
| 05:32:39 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Our friends at AMPATH in Western #Kenya are hiring IT project managers & #mobile devs. Interested? DM us! #ICT4D #mHealth <http://twitter.com/OpenMRS/statuses/84127328594173952> |
| 05:41:41 | *** vlad___ has joined #openmrs |
| 05:52:01 | *** gauravpaliwal has joined #openmrs |
| 05:52:01 | *** ChanServ sets mode: +v gauravpaliwal |
| 05:56:48 | *** vlad___ has quit IRC |
| 05:59:49 | *** vlad__ has joined #openmrs |
| 06:00:56 | *** vlad__ has quit IRC |
| 06:20:38 | *** bwolfe_ has joined #openmrs |
| 06:20:38 | *** ChanServ sets mode: +o bwolfe_ |
| 06:29:38 | *** pascal` has joined #openmrs |
| 06:32:36 | *** ChanServ sets mode: +v pascal` |
| 06:41:44 | <surangak> bwolfe_, hi, wonder if i may have some design advice..... |
| 06:42:26 | <bwolfe_> sure |
| 06:43:29 | <surangak> bwolfe_, its like this... in obsform.jsp |
| 06:43:41 | <surangak> bwolfe_, i can select a concept using the conceptfield.tag class |
| 06:43:59 | <surangak> i need to find a way to pass this into a new tag... |
| 06:44:21 | <surangak> bwolfe_, as in, every time the user selects a new concept via concept tag, |
| 06:44:37 | <surangak> the concept is returned to the javascript... |
| 06:44:56 | <surangak> i need to think of a way to grab that concept, and pass it into my own custom tag class |
| 06:45:43 | <surangak> right now obsform call to concept looks like |
| 06:45:44 | <surangak> <openmrs_tag:conceptField formFieldName="concept" formFieldId="conceptId" excludeDatatypes="N/A" initialValue="${status.editor.value.conceptId}" onSelectFunction="onQuestionSelect" /> |
| 06:46:11 | <surangak> the returned concept is passed direct to the javascript method =onquestionselect... |
| 06:46:16 | <bwolfe_> a "custom tag class" is a taglib? or a .tag? both of those are "compile time" as far as the html page. They are generated when the page is sent to the user. Javascript is RUNTIME, meaning the user chooses it after. you CANNOT send something from javascript ot a tag. (can't go from runtime back to compile time) |
| 06:46:37 | <bwolfe_> you will only be able to go from runtime to runtime. so from javascript to javascript |
| 06:46:38 | *** bwolfe_ is now known as bwolfe |
| 06:46:39 | <surangak> ya, thats the problem |
| 06:47:02 | <surangak> i was thinking, when the user selects a concept in the tag class, what is we set it as an attribute or so |
| 06:47:17 | <surangak> and then call that attribute in the second tag class |
| 06:47:50 | <surangak> the javascript to jsp issue is the kinda problem i am facing... |
| 06:48:33 | <surangak> im also thinking, in the concept tag, insted of sending only to the javascript tag, maybe i could also assign it to a new variable also ? and use that maybe.... |
| 06:50:44 | <bwolfe> no |
| 06:50:55 | <bwolfe> once the page is rendered/compiled, all you have is html+javascript |
| 06:51:41 | <surangak> if i were to assign the variable to an attribute in the tag classs, i can access that attribute from a second tag class ? |
| 06:51:51 | <surangak> woooopss... |
| 06:54:30 | *** pascal` has quit IRC |
| 06:55:57 | <bwolfe> its a tricky concept to get, but once you understand the order of compilation, running, etc, you will realize that what you are wanting to do is impossible |
| 06:56:13 | <bwolfe> once hte page is in the browser, all you have is javascript |
| 06:56:31 | <bwolfe> so you can use your tag to put javascript on the page. and then that javascript reads from the other concept (and uses dwr) to look up other info |
| 06:57:54 | <surangak> bwolfe, so u mean that the custom tag i created should use DWR service to see what concept has been selected is it |
| 06:58:18 | <bwolfe> kind of |
| 06:58:30 | <surangak> as in, every time a concept is slected, it is written into the dwr, an later my own tag reads that concept from drw |
| 06:58:35 | <surangak> *dwr... |
| 06:58:40 | <bwolfe> the custom tag should put javscript into the page that reads the other concept and then calls dwr with that concept once it knows about it |
| 06:59:15 | <surangak> bwolfe, thanks ben, let me look into that system |
| 06:59:16 | *** pascal` has joined #openmrs |
| 06:59:37 | <bwolfe> every time a concept is selected a javascript event is thrown. so you need more javascript on the page that reads that event |
| 06:59:57 | <bwolfe> surangak, perhaps the easiest thing for you to do is ot forget using tags for now. Just write it all in obsForm with javascript as you need to |
| 07:00:04 | <bwolfe> then later pull out hte code into tags as you figure htose out |
| 07:00:50 | <surangak> bwolfe, mm... u are referring to going ahead using just a text box right ? |
| 07:01:05 | <bwolfe> no, I mean just forget using tags/taglibs for now |
| 07:01:11 | <bwolfe> use straight js |
| 07:01:15 | <bwolfe> err, js in the form |
| 07:02:43 | <surangak> bwolfe, let me try that system... |
| 07:03:32 | *** danielf` has joined #openmrs |
| 07:03:32 | *** ChanServ sets mode: +v danielf` |
| 07:09:38 | *** bwolfe has quit IRC |
| 07:21:17 | *** bryq has joined #openmrs |
| 07:21:17 | *** ChanServ sets mode: +v bryq |
| 07:23:39 | *** bwolfe has joined #openmrs |
| 07:23:39 | *** ChanServ sets mode: +o bwolfe |
| 07:35:54 | *** bwolfe has quit IRC |
| 08:07:38 | *** rafa has joined #openmrs |
| 08:07:38 | *** ChanServ sets mode: +v rafa |
| 09:28:08 | *** bwolfe has joined #openmrs |
| 09:28:08 | *** ChanServ sets mode: +o bwolfe |
| 09:30:30 | <pascal`> wb bwolfe |
| 09:30:40 | <bwolfe> uh, thanks? |
| 09:30:41 | <pascal`> bwolfe, ever seen this guy on form entry: ERROR - ORUR01Handler.getConcept(873) |2011-06-24 10:50:53,743| Unable to find concept with code: null and mapping: null in hl7 message with uid: tIpspAdb2BEusBXtGYAf |
| 09:31:16 | <bwolfe> no |
| 09:31:21 | <bwolfe> but I think you have a null concept ;-) |
| 09:31:48 | <pascal`> Well, I have a null concept as a result |
| 09:34:03 | <pascal`> bwolfe, it's got something to do with the form schema |
| 09:34:19 | <pascal`> I can fix it by renaming the obs root node in the schema |
| 09:34:46 | <pascal`> bwolfe, when that fields name is "3. Obs" then I get the error, but if I rename it to "Obs" and set the field number to three, then I don't get the error. |
| 09:35:13 | <bwolfe> ok, theres your solution ;-) |
| 09:35:47 | <pascal`> bwolfe, yeah, except with xforms that mean doing a _lot_ of work |
| 09:35:55 | <bwolfe> I see |
| 09:36:03 | <pascal`> specifically, re-ordering a bunch of answers. |
| 09:41:58 | *** goutham has joined #openmrs |
| 10:06:26 | *** goutham has quit IRC |
| 10:12:08 | *** goutham has joined #openmrs |
| 10:23:04 | *** djazayeri has quit IRC |
| 10:24:43 | *** gauravpaliwal has quit IRC |
| 10:33:44 | *** dkayiwa has joined #openmrs |
| 10:35:04 | *** djazayeri has joined #openmrs |
| 10:35:04 | *** ChanServ sets mode: +o djazayeri |
| 10:35:53 | *** goutham_ has joined #openmrs |
| 10:36:08 | *** goutham has quit IRC |
| 10:56:36 | *** bwolfe has quit IRC |
| 11:08:25 | *** bwolfe has joined #openmrs |
| 11:08:25 | *** ChanServ sets mode: +o bwolfe |
| 11:10:28 | *** surangak has quit IRC |
| 11:26:22 | *** goutham_ has quit IRC |
| 11:35:38 | *** goutham has joined #openmrs |
| 11:48:33 | *** dkayiwa has quit IRC |
| 11:54:39 | *** bwolfe has quit IRC |
| 12:06:38 | *** goutham has quit IRC |
| 12:09:19 | *** pascal` has quit IRC |
| 12:11:48 | *** bwolfe has joined #openmrs |
| 12:11:48 | *** ChanServ sets mode: +o bwolfe |
| 12:11:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Removing hard coding of the order number prefix - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/NFWDfwp47wo/OpenMRS> || New Changeset: OpenMRS (order-entry): Setting order number only when it is null in order to allow one to manually specify it. - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/3acfVSO-JBU/OpenMRS> |
| 12:20:25 | *** rafa has quit IRC |
| 12:28:44 | *** danielf` has quit IRC |
| 12:30:05 | *** pascal` has joined #openmrs |
| 12:33:45 | *** danielf` has joined #openmrs |
| 12:33:45 | *** ChanServ sets mode: +v danielf` |
| 12:35:09 | *** wyclif has quit IRC |
| 12:38:05 | *** rafa has joined #openmrs |
| 12:38:05 | *** ChanServ sets mode: +v rafa |
| 12:59:29 | <pascal`> djazayeri, with HTML forms, do you know if it's possible to include some javascript like document.write("<td class='heading'>" + myVar + "</td">) |
| 12:59:48 | <pascal`> djazayeri, because what I'm seeing is the single quotes getting changed to double quotes |
| 13:00:35 | <bwolfe> pascal`, your ending double quote is misplaced |
| 13:00:54 | <pascal`> bwolfe, ok yeah, even if they're correct |
| 13:01:08 | <bwolfe> pascal`, you could either drop those (if no spaces) or escape with backslash? |
| 13:01:38 | <pascal`> bwolfe, drop which, the quotes surrounding _heading_? |
| 13:01:43 | <pascal`> bwolfe, escaping doesn't work |
| 13:01:45 | <bwolfe> yeah |
| 13:01:53 | <bwolfe> quadruple backslash |
| 13:02:02 | <bwolfe> (good name for a band) |
| 13:03:45 | <pascal`> dropping them gives: Open quote is expected for attribute "class" associated with an element type "td" |
| 13:03:45 | <pascal`> quad backslash |
| 13:03:45 | <pascal`> hah, ok I'll try that |
| 13:03:50 | <pascal`> well, it would be if it worked =S |
| 13:04:23 | <pascal`> bwolfe, still get: An error occurred while loading the html. Open quote is expected for attribute "class" associated with an element type "td". |
| 13:04:27 | <bwolfe> pascal`, what about reversing the quotes? |
| 13:04:42 | <pascal`> did try, but will try again |
| 13:04:45 | <bwolfe> hmm, quintuple backslash? ;-) |
| 13:06:48 | *** bwolfe has left #openmrs |
| 13:06:48 | <pascal`> ah, switching the quotes seems to work |
| 13:06:50 | <pascal`> weird! |
| 13:06:57 | *** bwolfe has joined #openmrs |
| 13:06:57 | *** ChanServ sets mode: +o bwolfe |
| 13:07:02 | *** downeym has joined #openmrs |
| 13:07:02 | *** OpenMRSBot sets mode: +o downeym |
| 13:07:02 | *** ChanServ sets mode: +o downeym |
| 13:09:28 | <pascal`> thanks bwolfe++ |
| 13:09:48 | <bwolfe> which worked? |
| 13:10:04 | <pascal`> switching the quotes |
| 13:10:12 | <bwolfe> haha, awesome |
| 13:10:17 | <pascal`> that's so weird |
| 13:10:18 | <bwolfe> !karma bwolfe |
| 13:10:18 | <OpenMRSBot> bwolfe: Karma for "bwolfe" has been increased 116 times and decreased 28 times for a total karma of 88. |
| 13:10:27 | <pascal`> must be an html form entry module special thing? |
| 13:10:30 | <bwolfe> pushing 100 |
| 13:10:32 | <bwolfe> probably |
| 13:10:43 | <pascal`> !karma pascal` |
| 13:10:43 | <OpenMRSBot> pascal`: Karma for "pascal`" has been increased 26 times and decreased 3 times for a total karma of 23. |
| 13:10:55 | <bwolfe> they might be doing some sort of quote replacing or escaping and aren't doing a good job of looking within quotes |
| 13:11:51 | <pascal`> bwolfe, the only number that really matters is <karma increased>/<karma decreased> |
| 13:11:58 | <pascal`> =D |
| 13:12:09 | <bwolfe> haha |
| 13:12:31 | <pascal`> and you're the only one who's ever decreased my karma, so those three don't count (= |
| 13:12:44 | <pascal`> !karma |
| 13:12:44 | <OpenMRSBot> pascal`: Highest karma: "bwolfe" (88), "dkayiwa" (42), and "groovy" (30). Lowest karma: "emacs" (-8), "windows" (-5), and "[INFO] ----------------------------------------------------------------------" (-5). You (pascal`) are ranked 4 out of 241. |
| 13:12:51 | <pascal`> !karma dkatiwa |
| 13:12:51 | <OpenMRSBot> pascal`: dkatiwa has neutral karma. |
| 13:12:55 | <pascal`> !karma dkayiwa |
| 13:12:55 | <OpenMRSBot> pascal`: Karma for "dkayiwa" has been increased 44 times and decreased 2 times for a total karma of 42. |
| 13:13:04 | <bwolfe> [INFO] ?? |
| 13:13:16 | <pascal`> yeah, people pasting logs in here |
| 13:13:19 | <pascal`> [INFO]-- |
| 13:13:33 | <pascal`> except it's [INFO]--------------------------------------------------- etc |
| 13:13:38 | <bwolfe> no, this is [INFO] ------------------------------------------------------------------------ |
| 13:13:44 | <bwolfe> !karma |
| 13:13:44 | <OpenMRSBot> bwolfe: Highest karma: "bwolfe" (88), "dkayiwa" (42), and "groovy" (30). Lowest karma: "emacs" (-8), "windows" (-5), and "[INFO] ----------------------------------------------------------------------" (-5). You (bwolfe) are ranked 1 out of 243. |
| 13:13:53 | <pascal`> [INFO] ------------------------------------------------------------------------ |
| 13:13:58 | <pascal`> !karma |
| 13:13:58 | <OpenMRSBot> pascal`: Highest karma: "bwolfe" (88), "dkayiwa" (42), and "groovy" (30). Lowest karma: "emacs" (-8), "[INFO] ----------------------------------------------------------------------" (-6), and "windows" (-5). You (pascal`) are ranked 4 out of 243. |
| 13:14:11 | <bwolfe> !karma [INFO] ---------------------------------------------------------------------- |
| 13:14:11 | <OpenMRSBot> bwolfe: Error: The command "info" is available in the Factoids and RSS plugins. Please specify the plugin whose command you wish to call by using its name as a command before "info". |
| 13:14:19 | <pascal`> haha |
| 13:14:32 | <bwolfe> !karma [INFO]---------------------------------------------------------------------- |
| 13:14:32 | <OpenMRSBot> bwolfe: Error: The command "info" is available in the Factoids and RSS plugins. Please specify the plugin whose command you wish to call by using its name as a command before "info". |
| 13:14:36 | <bwolfe> boo |
| 13:15:02 | <pascal`> OpenMRSBot-- |
| 13:17:47 | <bwolfe> OpenMRSBot++ |
| 13:17:52 | <bwolfe> he's just doing what he's told! |
| 13:23:48 | *** dmexs has joined #openmrs |
| 13:25:08 | *** gauravpaliwal has joined #openmrs |
| 13:25:08 | *** ChanServ sets mode: +v gauravpaliwal |
| 13:30:41 | *** wyclif has joined #openmrs |
| 13:45:28 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Another related job in Africa today - @PIH is hiring an #OpenMRS Java developer in #Rwanda - more info: http://bit.ly/kM1lOl <http://twitter.com/OpenMRS/statuses/84250849462861825> |
| 13:52:00 | *** vlad____ has joined #openmrs |
| 13:52:23 | <downeym> ok folks i have a question and a challenge |
| 13:53:04 | <downeym> we want to put openmrs+tomcat behind an apache reverse proxy server, such that the URL becomes something like http://foobar.com/NN/openmrs/ |
| 13:53:36 | <downeym> anyone here ever tried such a thing? :) |
| 13:57:00 | <djazayeri> pascal`: did you figure out the double quotes issue? |
| 13:59:48 | *** dkayiwa has joined #openmrs |
| 14:02:22 | <bwolfe> downeym, openmrs demo was behind a reverse proxy at some point early in its life |
| 14:02:34 | <downeym> it still is |
| 14:02:40 | <downeym> but not in the situation described above :) |
| 14:03:06 | *** asgoyal has joined #openmrs |
| 14:03:24 | <bwolfe> no |
| 14:11:20 | *** gauravpaliwal has left #openmrs |
| 14:20:59 | *** cta has joined #openmrs |
| 14:23:24 | <cta> hello |
| 14:26:06 | <bwolfe> good evening cta |
| 14:28:01 | <djazayeri> hi cta |
| 14:28:14 | <djazayeri> I made a bunch of code review comments. Let me know if you have questions. |
| 14:28:24 | <cta> djazayeri: yep |
| 14:28:31 | <cta> I have |
| 14:28:36 | <djazayeri> dkayiwa: what % of the code review comments have you addressed? |
| 14:28:53 | <dkayiwa> 70% |
| 14:29:30 | <cta> djazayeri: Darius, I need clarification about OrderGroup. How can we activate it? It seems that we can activate (and sign) only orders within group. Right? |
| 14:29:45 | <djazayeri> I asked Burke that question on the ticket, right? |
| 14:30:02 | <djazayeri> I think that we don't actually have to activate the OrderGroup itself |
| 14:30:15 | <djazayeri> we save the OrderGroup, but we _activate_ its children. |
| 14:30:39 | <djazayeri> actually, this ties into a broader discussion I've been meaning to have. |
| 14:31:03 | <pascal`> djazayeri, switching the quotes seemed to work |
| 14:31:06 | <djazayeri> bwolfe, dkayiwa, wyclif, cta: as currently implemented, we have |
| 14:31:21 | <pascal`> djazayeri, that is, using single quotes as the outer quotes and double as the inner |
| 14:31:22 | <djazayeri> * a saveOrder method that actually does quite a bit of logic |
| 14:31:46 | <djazayeri> * a private validateAndSaveOrder method that gets called by other methods, but doesn't get AOPd. |
| 14:32:17 | <wyclif> ok |
| 14:32:35 | <pascal`> djazayeri, does that sound like it should work? |
| 14:32:38 | *** danielf` has quit IRC |
| 14:32:42 | <djazayeri> * methods like signOrder & activateOrder that then call saveOrder or validateAndSave, but without going through Context.getService, so they don't get our AOP magic |
| 14:32:47 | <djazayeri> pascal`: if it works it works |
| 14:33:25 | <djazayeri> I think we need to get all logic outside of saveOrder, and make saveOrder just do validate + dao.save |
| 14:33:44 | <pascal`> djazayeri, well, I've only tested one level of nesting, I'll test more more though and let you know if it breaks. |
| 14:34:01 | <djazayeri> methods like sign, activate, etc, should call Context.getOrderService().saveOrder(...) |
| 14:34:11 | *** gbastien has joined #openmrs |
| 14:34:16 | <djazayeri> and we should get rid of the private validateAndSave (because that's what saveOrder should be doing) |
| 14:34:21 | <djazayeri> does that sound right? |
| 14:34:50 | <cta> yes |
| 14:34:53 | <dkayiwa> djazayeri: One more question. Do we create a new method for the logic currently existing in saveOrder() |
| 14:35:29 | <djazayeri> what logic does that currently do? |
| 14:35:50 | <djazayeri> it deals with versioning, right? |
| 14:36:02 | <djazayeri> that should be removed for now, since we're getting rid of the version column until we really need it |
| 14:36:02 | <cta> yep |
| 14:36:18 | <cta> djazayeri: I've already added some methods, those you asked for (e.g. saveOrderGroup., void/unvoid/getById/uuid/forPatient). Also I tested them, tests were green, but not committed yet. |
| 14:36:20 | <dkayiwa> yes. create and saves a new copy of the passed in order |
| 14:36:57 | <djazayeri> I think we want to get rid of that behavior for now |
| 14:37:03 | <dkayiwa> ok |
| 14:37:10 | <djazayeri> We don't save a new copy |
| 14:37:22 | <dkayiwa> Have you got any feedback about it from Burke? |
| 14:37:30 | <djazayeri> for now we will save if it's legal, and throw and error if it's already active |
| 14:37:41 | <djazayeri> activated, I mean |
| 14:38:00 | <djazayeri> if you want to change an existing order that's already activated, you have to call a special "modifyOrder" method or something. |
| 14:38:12 | <dkayiwa> ok |
| 14:38:14 | <djazayeri> I have talked to burke about it, he's okay getting rid of versioning until version 2 |
| 14:38:22 | <dkayiwa> ok |
| 14:39:00 | *** asgoyal_ has joined #openmrs |
| 14:39:03 | <djazayeri> so, all that saveOrder should do is validate(), assign a new order number if necessary, and dao.save |
| 14:39:14 | <dkayiwa> ok |
| 14:39:58 | <djazayeri> Although, it would be nice to have some way of preventing people from doing saveOrder on something that's already activated. |
| 14:40:01 | <dkayiwa> so if order.getOrderId() != null, we throw exception?? |
| 14:40:19 | <asgoyal_> Is there a better source to learn spring mvc framework other than the springframework reference doc provided on their website? |
| 14:40:21 | <djazayeri> But at the same time we need to allow ourselves to set the discontinuedDate on an existing order |
| 14:41:01 | <djazayeri> dkayiwa: if (order.isActivated()) throw exception |
| 14:41:15 | <dkayiwa> ok |
| 14:41:54 | <dkayiwa> its now clear |
| 14:42:11 | <djazayeri> can you make those changes right now and commit them? |
| 14:42:19 | <djazayeri> Or are you taking off for a bit at the moment? |
| 14:42:37 | <djazayeri> asgoyal_: there are many spring mvc tutorials on the web |
| 14:42:39 | <dkayiwa> will be taking off in a moment. :) |
| 14:42:39 | <asgoyal_> Is there a better source to learn spring mvc framework other than the springframework reference doc provided on their website? |
| 14:42:52 | <asgoyal_> oops sorry ffor duplicate message |
| 14:43:34 | <djazayeri> okay, then dkayiwa, maybe I'll do that now |
| 14:43:48 | <dkayiwa> 8) |
| 14:44:22 | *** pascal` has quit IRC |
| 14:45:06 | <djazayeri> asgoyal_: we also have a few short spring mvc tutorials on our wiki |
| 14:45:24 | <djazayeri> cta: cool, by the way |
| 14:46:03 | <cta> djazayeri: what? |
| 14:46:11 | <djazayeri> that you've implemented those things |
| 14:46:19 | <djazayeri> replying to irc comments slowly. :-) |
| 14:46:23 | <cta> It was not difficult)) |
| 14:47:46 | *** dkayiwa has quit IRC |
| 14:49:31 | <cta> djazayeri: Darius, here is review s://source.openmrs.org/cru/CR-TRUNK-380 |
| 14:49:48 | <cta> hhtps://source.openmrs.org/cru/CR-TRUNK-380 |
| 14:49:59 | <djazayeri> I'll figure it out. :-) |
| 14:50:04 | <cta> ok)) |
| 14:50:09 | <cta> one a question |
| 14:50:17 | <djazayeri> cta: did you notice that you forgot to _start_ the review from yesterday? |
| 14:50:24 | *** vlad____ has quit IRC |
| 14:50:31 | <cta> and today probably)) |
| 14:50:43 | <djazayeri> also, by the way, if you're doing a second revision on an existing review, it's often better to add more content to an existing review. |
| 14:50:58 | <djazayeri> so the reviewers can see all the context |
| 14:51:24 | <cta> can I do it aftyer review has been created? |
| 14:52:44 | <djazayeri> you can add content to an existing review, yes. |
| 14:52:58 | <djazayeri> Normally I create my reviews by going to the crucible dashboard, under the "commits" section |
| 14:53:13 | <djazayeri> The revision I just committed is at the top there |
| 14:53:34 | <djazayeri> and from that row in the table you can create a review |
| 14:53:48 | <djazayeri> when you do that it will sometimes suggest that you add it to an existing review |
| 14:54:01 | <djazayeri> which you should do, if it's actually a followup |
| 14:54:25 | <djazayeri> it may not suggest this to you because either you did a manual Create Review, or else because you didn't start yesterday's one |
| 14:56:51 | <cta> djazayeri: thanx, I will take it into account further |
| 14:59:02 | <cta> djazayeri: I fixed inconvenience with review content, now it contains rev 20968 and 20982 |
| 14:59:19 | <djazayeri> did you "start" it? |
| 14:59:40 | *** mandric has joined #openmrs |
| 14:59:57 | *** bwolfe has quit IRC |
| 15:00:05 | <cta> yes, green line began to move)) |
| 15:00:26 | <djazayeri> cool, I'll re-review. make sure the ticket has a link to the code review in it |
| 15:00:28 | <cta> it says that "Under Review for a few seconds " |
| 15:00:30 | <djazayeri> in its comments |
| 15:00:31 | <djazayeri> perfect |
| 15:02:03 | <cta> question: Do I still need to resolve problem with order's number within saveOrder method ? |
| 15:02:29 | <djazayeri> maybe I'll resolve that in the thing I'm about to do that I discussed with daniel... |
| 15:02:59 | <cta> sorry, I didn't read yours conversation yet)) |
| 15:03:19 | <djazayeri> remind me what the problem was with order numbers in saveOrder? |
| 15:03:47 | <cta> just a second, I'm forming thought |
| 15:04:27 | <cta> djazayeri: "we should be preventing duplicate order numbers ... " |
| 15:04:59 | <djazayeri> oh, yeah, I'll take care of that don't worry |
| 15:05:41 | <cta> djazayeri: thanx |
| 15:06:50 | *** chopin has joined #openmrs |
| 15:06:50 | *** ChanServ sets mode: +v chopin |
| 15:06:55 | <chopin> o/ |
| 15:07:53 | *** cta has quit IRC |
| 15:24:40 | *** chopin has left #openmrs |
| 15:27:57 | *** pascal` has joined #openmrs |
| 15:31:48 | *** vlad__ has joined #openmrs |
| 15:37:51 | *** pascal` has quit IRC |
| 15:51:07 | *** pascal` has joined #openmrs |
| 15:53:47 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): After review fixes. Added base methods (save, void/unvoid, get*) for OrderGroup within OrderService. Implemented Service... <http://feedproxy.google.com/~r/OMRStrunk/~3/wJLpom7PkRc/OpenMRS> |
| 15:56:20 | *** jkeiper has joined #openmrs |
| 15:57:15 | <asgoyal_> djazayeri can you explain me what is a model used for in spring mvc? |
| 15:57:37 | <djazayeri> Effectively, the model is any data that might need to be displayed in the view |
| 15:57:44 | <asgoyal_> oh |
| 15:57:56 | <djazayeri> The idea is that the only way the controller can communicate with the view is by passing it a Model |
| 15:58:08 | <asgoyal_> aaah got it |
| 15:58:17 | <djazayeri> so any data (e.g. list of possible search results) go in the model |
| 15:58:28 | <djazayeri> and the view determines how to display the model |
| 15:58:34 | <asgoyal_> and @SessionAttributes give a name to the model passed to the attribute right? |
| 15:59:32 | <djazayeri> are you looking at the location tag controller? |
| 15:59:51 | <asgoyal_> yep |
| 15:59:58 | <djazayeri> sessionAttributes is misused there |
| 16:00:03 | <asgoyal_> the list(ModelMap model) |
| 16:00:04 | <djazayeri> ignore it. it should actually be removed |
| 16:00:15 | <asgoyal_> woah ok |
| 16:00:20 | <djazayeri> In annotation-driven Spring MVC, the model doesn't actually have a name |
| 16:00:25 | <asgoyal_> oh |
| 16:00:30 | <djazayeri> all attributes you put in the model have names |
| 16:00:35 | <asgoyal_> so what is the use of session attributes? |
| 16:00:40 | <djazayeri> e.g. model.addAttribute("patients", searchResults) |
| 16:00:49 | <djazayeri> or modelMap.put("patients", searchResults) |
| 16:01:06 | *** mandric has quit IRC |
| 16:01:24 | <djazayeri> saying that something is a SessionAttribute means that that attribute of the model will be stored in the HTTP Session, so it will still be available at the next http request |
| 16:01:28 | <asgoyal_> ok |
| 16:01:44 | <djazayeri> But that's almost never used in OpenMRS. |
| 16:01:44 | <asgoyal_> aaah ok |
| 16:01:49 | <asgoyal_> oki |
| 16:02:22 | <asgoyal_> and what is the the difference between the two functions u mentioned? |
| 16:02:29 | <asgoyal_> it seems both do the same thing |
| 16:02:42 | <djazayeri> they are identical |
| 16:02:46 | <asgoyal_> oki |
| 16:02:57 | <djazayeri> Good style is to use a Model object for your model |
| 16:03:05 | <asgoyal_> oki |
| 16:03:17 | <djazayeri> I was confused about this when we started using annotation-driven Spring MVC, so you'll see examples of ModelMap instead |
| 16:03:22 | <djazayeri> (that's my fault) |
| 16:03:27 | <asgoyal_> oh ok |
| 16:03:29 | <djazayeri> it implements Model, but it's also a Map. |
| 16:03:36 | <asgoyal_> :) |
| 16:03:37 | <djazayeri> so it allows you to say modelMap.put(...) |
| 16:03:45 | <asgoyal_> ok :) |
| 16:03:49 | <djazayeri> when really it is better style to say model.addAttribute(...) |
| 16:03:58 | <asgoyal_> why do you say so? |
| 16:04:08 | <asgoyal_> since both do the same function |
| 16:04:39 | <djazayeri> One is better style because it better describes what you're actually trying to do |
| 16:05:13 | <djazayeri> so if someone is skimming the code quickly, they immediately see "adding an attribute to a model" |
| 16:05:19 | <djazayeri> as opposed to "putting something in a map" |
| 16:05:32 | <asgoyal_> oh ok |
| 16:06:45 | <asgoyal_> alright i will keep going thanks :) |
| 16:09:57 | <asgoyal_> which class implements the Orderable interface? |
| 16:10:15 | <djazayeri> for now GenericDrug and Drug |
| 16:10:20 | <djazayeri> soon, PublishedOrderSet |
| 16:10:21 | <asgoyal_> oh |
| 16:10:35 | <asgoyal_> oh oki |
| 16:12:53 | *** downeym_ has joined #openmrs |
| 16:12:53 | *** ChanServ sets mode: +o downeym_ |
| 16:13:36 | *** cta has joined #openmrs |
| 16:15:29 | *** downeym has quit IRC |
| 16:15:29 | *** downeym_ is now known as downeym |
| 16:18:12 | <asgoyal_> djazayeri what is the purpose of LocationTagEditor.java file? |
| 16:18:40 | <asgoyal_> that class extends the PropertyEditorSupport class provided by java beans |
| 16:19:01 | <djazayeri> because http requests can only include String parameters, Editor classes are responsible for converting between String and the type you really want |
| 16:19:10 | <djazayeri> e.g. PatientEditor converts String <-> Patient |
| 16:19:11 | <asgoyal_> oooh |
| 16:19:19 | <djazayeri> and LocationTagEditor does String <-> LocationTag |
| 16:19:21 | <asgoyal_> oh ok |
| 16:21:00 | <dmexs> hey everybody |
| 16:21:08 | <djazayeri> hi |
| 16:21:13 | <rafa> djazayeri: I won't finish the UI today. There're more changes than expected. I'll finish it tomorrow and let you know. |
| 16:22:28 | <djazayeri> okay rafa, what does it look like now? |
| 16:23:09 | *** mandric has joined #openmrs |
| 16:24:07 | <dmexs> I'm interested in getting involved in OpenMRS development since my recent experimentation with implementing it this summer, any suggestions for reading/back-story? |
| 16:24:26 | <rafa> djazayeri: I only added statistics on the reviewPackage page. I need to apply what you've mocked up. I'll get rid of ajax I wrote. |
| 16:25:00 | <djazayeri> rafa: probably easier to do it as plain pages for now, and we can ajaxify later once we're happy with everything |
| 16:25:48 | <djazayeri> dmexs: have you looked at http://openmrs.org/help/developers/? |
| 16:26:09 | <djazayeri> rafa: particularly because we still have to add in the suggested matches. |
| 16:27:03 | *** yanokwa_ has joined #openmrs |
| 16:27:15 | <downeym> Hi yanokwa_ and welcome to the #openmrs IRC channel. |
| 16:27:22 | <rafa> djazayeri: Will we be implementing the suggested matches feature for this release? |
| 16:27:27 | <djazayeri> no |
| 16:27:33 | <rafa> good |
| 16:27:51 | <dmexs> djazayeri: a bit yes, i guess I'm trying to understand more of how tomcat and spring work right now |
| 16:28:06 | *** yanokwa_ has quit IRC |
| 16:28:17 | <djazayeri> I mean we should just do the UI so it looks right, but let's delay ajaxifying it until after we've done the suggested matches feature |
| 16:28:27 | *** yanokwa has joined #openmrs |
| 16:28:40 | <djazayeri> hi yanokwa |
| 16:28:48 | <djazayeri> comcast.net must mean you're back in Seattle. :-) |
| 16:29:27 | *** yanokwa has left #openmrs |
| 16:29:35 | <djazayeri> dmexs: ah. I find that the best way may be to just dive in and try to do an intro ticket |
| 16:29:53 | <djazayeri> it will probably force you to figure out how spring and everything work |
| 16:30:43 | <dmexs> agreed. one question I had in particular is why you need to set implementation id/passphrases during install? |
| 16:31:07 | <djazayeri> dmexs: it's not required |
| 16:31:20 | <dmexs> i spent several hours migrating our install form a macbook to a windows PC yesterday, i was disappointed in how difficult i found it |
| 16:31:24 | <dmexs> it's not? |
| 16:31:29 | *** rafa has quit IRC |
| 16:31:40 | <djazayeri> implementation id is not required, no. |
| 16:31:47 | <djazayeri> dmexs: what were the difficulties? |
| 16:31:50 | *** yanokwa has joined #openmrs |
| 16:32:31 | <dmexs> the openrs-runtime.properties file was no where to be found after a broken install |
| 16:32:47 | <dmexs> until i found it deep in a windows\system32 folder |
| 16:32:57 | <djazayeri> hmm…finding that file is way harder than it should be |
| 16:33:06 | <dmexs> it was in an OS specific location and not within the tomcat root |
| 16:33:40 | <dmexs> then for reasons unknown the install process kept locking up near the end of the db creation on one machine |
| 16:33:52 | <dmexs> I'm not sure how much of this is Tomcat problems or OpenMRS problems |
| 16:34:07 | <dmexs> i'm kind of weary as to how reliable and nice of a platform tomcat is? |
| 16:34:25 | <djazayeri> are you trying to migrate an actual production system? |
| 16:34:29 | <djazayeri> or just playing around? |
| 16:34:44 | <djazayeri> As of this week we have a nice "standalone" distribution of 1.8 |
| 16:34:56 | <djazayeri> I guess if you're planning to do development work, though, that's not sufficient. |
| 16:35:51 | <dmexs> Production for now. I had already deployed 1.7.1 before I got to Peru so I didn't want to upgrade. Hmm.. |
| 16:36:24 | <dmexs> for dev, I'm reading Maven is the way to go though |
| 16:36:28 | <djazayeri> yes, definitely |
| 16:37:57 | <dmexs> how do you feel able Tomcat in particular? my experience has always been with apache, which I find a lot less quirkier? |
| 16:38:54 | <dmexs> I'm kind of split between my interest in the project and tomcat being a very odd animal |
| 16:38:57 | <djazayeri> well, apache can't do java web applications |
| 16:39:11 | <djazayeri> so you need tomcat. Or glassfish, or jboss, or something |
| 16:39:23 | <djazayeri> or, jetty in production, I suppose |
| 16:39:41 | <djazayeri> I feel like I've always been able to set up tomcat well enough to not have to care about it for the next several years |
| 16:39:48 | <djazayeri> Don't love it, don't hate it. |
| 16:40:37 | <dmexs> gotcha, but you don't feel like the whole java servlet/tomcat thing will be a limiting factor in openmrs's growth? |
| 16:40:39 | *** yanokwa has quit IRC |
| 16:40:48 | *** yanokwa has joined #openmrs |
| 16:41:23 | <djazayeri> I think that the java ee ecosystem is good |
| 16:41:26 | <djazayeri> tomcat included |
| 16:41:34 | <djazayeri> so, no, I don't think it's a limiting factor for openmrs |
| 16:43:11 | <dmexs> cool, thanks |
| 16:43:17 | *** yanokwa has left #openmrs |
| 16:45:13 | <dmexs> any idea why that runtime file is hard to find?/ideas to fix it? |
| 16:47:36 | *** cta_ has joined #openmrs |
| 16:47:57 | <djazayeri> in theory when you start openmrs up it tells you where it finds the file |
| 16:48:06 | <djazayeri> in the logs |
| 16:49:15 | <djazayeri> wyclif: do the order entry service unit tests pass for you? |
| 16:49:32 | <wyclif> no |
| 16:49:47 | <wyclif> i think i might know the problem |
| 16:49:51 | <djazayeri> how many break? |
| 16:50:00 | <djazayeri> I just ran them after changing some things and notices a whole bunch break |
| 16:50:06 | <djazayeri> but they're doing something dumb |
| 16:50:11 | *** cta has quit IRC |
| 16:50:14 | *** yanokwa has joined #openmrs |
| 16:50:20 | <djazayeri> I mean: they're fetching stuff for the wrong patient |
| 16:50:44 | <wyclif> all, am trying sincei have changed the table structure |
| 16:51:12 | <wyclif> but am trying to get them to the point where at least the test data is populated |
| 16:51:18 | <wyclif> really? |
| 16:51:33 | <djazayeri> e.g. getOrderHistoryByConcept_shouldReturnOrdersWithTheGivenConcept |
| 16:51:47 | <djazayeri> it tries to fetch orders for patient 1 |
| 16:51:50 | <djazayeri> but there is no patient 1 |
| 16:51:52 | <wyclif> i will check it out |
| 16:52:37 | <wyclif> i have few changes in the sprint, we need to look at the liquibase file and review them |
| 16:52:50 | <wyclif> i have found afew wrong things about them |
| 16:53:03 | <wyclif> forinstance test order has a uuid column |
| 16:53:20 | <wyclif> and a test_order_id column which is wrong |
| 16:53:46 | <wyclif> given it is a subclass of order, so i changed it |
| 16:54:25 | <wyclif> djazayeri, so i believe there might be more like this |
| 17:05:49 | <djazayeri> wyclif: definitely we're going to need to re-review everything when we do the merge |
| 17:06:08 | <djazayeri> some of that stuff (e.g. test_order_id) was discussed in daniel's big code review |
| 17:06:42 | <wyclif> ok |
| 17:08:35 | <djazayeri> btw, the particular broken unit test I'm looking at was changed in rev:20952 by daniel this morning, so I'm going to blame him |
| 17:08:39 | <djazayeri> and commit my code. :-) |
| 17:14:05 | <asgoyal_> how to automate by selenium to click on OK button on a pop up warning window after I click on Purge Encounter Types button on manage encounter types?? |
| 17:17:55 | <asgoyal_> djazayeri: ^^ |
| 17:19:31 | <djazayeri> asgoyal_: no idea |
| 17:19:38 | <asgoyal_> oh ok |
| 17:32:29 | *** asgoyal_ has quit IRC |
| 17:34:19 | *** muthah has joined #openmrs |
| 18:00:42 | *** bwolfe has joined #openmrs |
| 18:00:42 | *** ChanServ sets mode: +o bwolfe |
| 18:00:46 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Refactor OrderService.saveOrder and the things that call it - TRUNK-2418 <http://feedproxy.google.com/~r/OMRStrunk/~3/kang7z-RwlA/OpenMRS> |
| 18:03:26 | *** bmamlin has joined #openmrs |
| 18:03:33 | <downeym> Hi bmamlin and welcome to the #openmrs IRC channel. |
| 18:03:33 | *** bmamlin is now known as burke |
| 18:03:59 | *** ChanServ sets mode: +o burke |
| 18:06:44 | *** pascal` has quit IRC |
| 18:09:30 | <wyclif> djazayeri, bwolfe i find the code in OrderServiceImpl.saveOrder invalid |
| 18:09:41 | <djazayeri> wyclif: the code I just committed? |
| 18:10:07 | *** mandric has quit IRC |
| 18:10:49 | <wyclif> it assumes there is a margical machinery that will set dateCreated, changeBy etc which actually seems false |
| 18:10:54 | *** mandric has joined #openmrs |
| 18:11:04 | <djazayeri> wyclif: we _do_ have magical machinery to set those |
| 18:11:05 | <wyclif> djazayeri, am not sure who made the change |
| 18:11:09 | <wyclif> no way |
| 18:11:19 | <djazayeri> did you svn update in the last hour? |
| 18:11:20 | <wyclif> aleast not inside the API |
| 18:11:32 | <wyclif> just a sec |
| 18:12:57 | <wyclif> it has ben fixed |
| 18:13:01 | <wyclif> thanks |
| 18:13:30 | <wyclif> the latest revision actually fixed it |
| 18:13:33 | <burke> quick question. are folks getting code insight (autocomplete in Eclipse) when working on modules within Eclipse? |
| 18:15:30 | <djazayeri> burke, I can do control-space in eclipse, both in trunk and modules |
| 18:18:01 | <burke> victor (my GSoC) student has his module using maven and isn't getting code insight behavior in eclipse |
| 18:18:59 | <wyclif> djazayeri, burke , am going out for lunch |
| 18:19:02 | <burke> djazayeri: if you download the basic module into eclipse, do you have ctrl-space working? |
| 18:19:52 | <djazayeri> dunno, i never download the basic module |
| 18:20:40 | *** vchircu has joined #openmrs |
| 18:21:28 | <bwolfe> burke, you have to make sure its a java project |
| 18:21:41 | <bwolfe> put the .classpath and .project file into the omod mavenmodel project in eclipse |
| 18:21:52 | <bwolfe> (just copy from the api module project) |
| 18:23:08 | <burke> bwolfe: is that not already done for the basic module? |
| 18:23:49 | <bwolfe> I don't think we put those files in, maven or eclipse is supposed to do it automatically |
| 18:24:16 | <bwolfe> it used to do it...but I think the latest version of doesn't get them magically for some reason |
| 18:24:49 | <bwolfe> (I actually get an NPE when checking out a module as a maven project in eclipse...I assume thats when its trying to do the .project stuff) |
| 18:34:11 | <djazayeri> bwolfe, burke: actually, if you use the current version of eclipse and m2eclipse, our projects are all screwed up |
| 18:34:22 | *** dmexs has quit IRC |
| 18:34:34 | *** dmexs has joined #openmrs |
| 18:34:43 | <bwolfe> how else are they? |
| 18:34:44 | <djazayeri> well, that may be an overstatement, but they require manual work |
| 18:35:11 | <bwolfe> I only have to do the .project/.classpath copy and its ready to go |
| 18:36:28 | *** burke has quit IRC |
| 19:02:36 | *** bwolfe has quit IRC |
| 19:22:18 | *** vchircu has quit IRC |
| 19:23:27 | *** downeym_ has joined #openmrs |
| 19:23:27 | *** ChanServ sets mode: +o downeym_ |
| 19:24:59 | *** dmexs_ has joined #openmrs |
| 19:26:42 | *** dmexs has quit IRC |
| 19:26:42 | *** dmexs_ is now known as dmexs |
| 19:27:13 | *** downeym has quit IRC |
| 19:27:13 | *** downeym_ is now known as downeym |
| 19:43:04 | <djazayeri> cta_: just commented on TRUNK-2378, agreeing with Burke's comment. |
| 19:43:08 | <djazayeri> Can you rename that one field? |
| 19:43:14 | <djazayeri> I mean, method? |
| 19:43:23 | <djazayeri> (I haven't done the full code review yet, so it can wait.) |
| 19:43:41 | <cta_> djazayeri: wait a minute, I'm on call right now |
| 19:46:20 | *** vlad__ has quit IRC |
| 19:49:03 | <cta_> djazayeri: Of course I can do it ;-) Please, let me know when you will finish the review. Ok? |
| 19:49:27 | <djazayeri> yup, I'm looking at it now |
| 19:50:43 | <cta_> ok |
| 20:00:24 | *** downeym has quit IRC |
| 20:10:14 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): Merging trunk into branch localize-setup-wizard rev:20215 - rev:20985 <http://feedproxy.google.com/~r/OMRStrunk/~3/42U4oEdzzHM/OpenMRS> |
| 20:11:22 | *** downeym has joined #openmrs |
| 20:11:22 | *** ChanServ sets mode: +o downeym |
| 20:11:22 | *** OpenMRSBot sets mode: +o downeym |
| 20:18:38 | <cta_> djazayeri: As for ranaming method for signing and activating orders grou. Do we only need to rename it, don't we? Or we also should do signature refactoring? |
| 20:19:00 | <djazayeri> what's the signature now? |
| 20:19:13 | <cta_> signAndActivateOrderGroup(OrderGroup group, User user, Date activated) |
| 20:19:32 | <djazayeri> That seems like the right signature going forwards too |
| 20:19:41 | <djazayeri> btw, make sure you do a svn update |
| 20:19:58 | <cta_> I did, thanx |
| 20:20:02 | <djazayeri> I changed your signAndActivateOrderGroup method in OrderServiceImpl |
| 20:20:14 | <cta_> just? |
| 20:20:15 | <djazayeri> can you please review the method and make sure it's acting right? |
| 20:20:24 | <djazayeri> ~3 hours ago |
| 20:20:34 | <cta_> how many? |
| 20:20:45 | <cta_> it impossible |
| 20:21:23 | <cta_> yes, you did it 3:03 minutes ago |
| 20:21:43 | <djazayeri> basically you were calling a private signAndActivate method, and I switched it to call the public one |
| 20:21:45 | <cta_> sorry |
| 20:23:58 | <cta_> ok, I'll check this, just give me 10 minutes |
| 20:24:11 | <djazayeri> no rush |
| 20:24:12 | *** mandric has quit IRC |
| 20:25:13 | <djazayeri> cta_: when you added files to the review, how did you do it? |
| 20:25:19 | <djazayeri> did you add files? |
| 20:25:22 | <djazayeri> or just add a changeset? |
| 20:25:41 | <cta_> I added change set |
| 20:26:12 | <djazayeri> I'm not sure why, but the reviews keep showing other people's code (e.g. Daniel's commit in 20973) as being changed. |
| 20:26:12 | <cta_> what is problem? |
| 20:26:38 | <djazayeri> So I keep thinking "why did Taras change that?" and the answer is that you didn.t |
| 20:28:02 | <cta_> stop, are you talking about OrderSetMember, aren't you? |
| 20:28:23 | <djazayeri> in this case I'm looking at OrderServiceImpl |
| 20:28:23 | *** bryq has quit IRC |
| 20:28:57 | <cta_> I don't know what is going on with it |
| 20:32:42 | *** jkeiper has quit IRC |
| 20:38:45 | <djazayeri> downeym: I think crucible is acting strange |
| 20:39:34 | <djazayeri> Go to CR-TRUNK-380 |
| 20:39:43 | <djazayeri> then Add Content to Review |
| 20:39:54 | <djazayeri> search for changeset 20973 by dkayiwa |
| 20:40:23 | <djazayeri> it does _not_ have a check in its box, but it shows a link next to it saying it's in CR-TRUNK-380 |
| 20:40:26 | <djazayeri> which is the current review. |
| 20:40:44 | <djazayeri> And this review (by cta) is showing some of Daniel's changes too... |
| 20:45:24 | <downeym> at 10:48 cta_ added branches/order-entry/api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java 20973 20982 to the review which is why it's listed |
| 20:46:06 | <djazayeri> hmm, cta_, sounds like you accidentally included Daniel's revision too. |
| 20:46:12 | <downeym> :) |
| 20:46:18 | <downeym> so that's why it looked a bit strange |
| 20:46:37 | <downeym> under the "Tools" menu in the upper right you can choose "View Review History" to see how i saw that |
| 20:47:04 | <cta_> guys, sorry for that, I did it mistakely |
| 20:47:19 | <djazayeri> thanks for the pointer downeym |
| 20:47:23 | <downeym> it happens :) |
| 20:47:27 | <cta_> I should be more attentive |
| 20:47:43 | <downeym> btw i accidentally clicked a box and the unclicked it so please make sure everything is still there that needs to be. |
| 20:47:45 | <downeym> (sorry!) |
| 20:51:33 | <cta_> don't mind |
| 21:18:15 | *** szrrizvi has joined #openmrs |
| 21:23:26 | <szrrizvi> Hi, I have an odd situation. I have created an admin page for relationship management and would to submit these additions. But since I am doing this for university research, I am not suppose to have a link to the repository. Any suggestions? |
| 21:42:34 | *** downeym_ has joined #openmrs |
| 21:42:34 | *** ChanServ sets mode: +o downeym_ |
| 21:44:02 | *** downeym_ has quit IRC |
| 21:45:19 | *** downeym has quit IRC |
| 21:49:35 | <szrrizvi> djazayeri: are you on? |
| 21:49:42 | <djazayeri> szrrizvi: yes |
| 21:50:29 | <szrrizvi> Do you have any suggestion on how I could submit my additions? |
| 21:50:30 | *** dmexs has quit IRC |
| 21:50:37 | <djazayeri> to what? |
| 21:50:55 | <szrrizvi> I have created an admin page to manager relationships. |
| 21:51:17 | *** dmexs has joined #openmrs |
| 21:51:53 | <szrrizvi> But since I am doing this for university research, I am not suppose to be connected to the repository. |
| 21:52:25 | <djazayeri> Why can't you be connected to the repository? |
| 21:53:03 | <szrrizvi> Since it is for research, the university won't allow it. |
| 21:53:31 | <djazayeri> meaning that you have done an svn checkout + svn disconnect? |
| 21:53:44 | <szrrizvi> yes |
| 21:54:36 | <djazayeri> So, the technical answer is that you can check out exactly the branch and revision that you started from, as a separate eclipse project, and then compar with -> each other |
| 21:55:01 | <djazayeri> that will take a very long time, and I'm not 100% certain how to create a diff out of it, but there's probably a way |
| 21:55:09 | <djazayeri> would work at the command line, or in another ide too. |
| 21:55:50 | <djazayeri> the process answer is that you should create an issue at tickets.openmrs.org (in the trunk project) saying "Add a Manage Relationships page" and attach your patch to that ticket. |
| 21:57:48 | <szrrizvi> Alrite, I'll try that. |
| 21:59:10 | <cta_> djazayeri: Darius, I've fixed all your comments and also added OrderGroupValidator class, but did not tested it. I suppose to do it tomorrow and the make commit. Now, I gotta sleep, good evening! |
| 21:59:20 | <djazayeri> gnight |
| 21:59:27 | *** dmexs has quit IRC |
| 21:59:33 | <cta_> bye, guys |
| 21:59:37 | *** cta_ has quit IRC |
| 22:09:05 | *** szrrizvi has quit IRC |
| 22:13:46 | *** jportela has joined #openmrs |
| 22:13:46 | *** ChanServ sets mode: +v jportela |
| 22:37:09 | *** gbastien has quit IRC |
| 22:37:25 | *** mandric has joined #openmrs |
| 23:22:39 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Remove all deprecated methods in OrderService - TRUNK-2420 <http://feedproxy.google.com/~r/OMRStrunk/~3/fwsJV65hEAA/OpenMRS> |
| 23:45:56 | *** gbastien has joined #openmrs |