| 00:03:29 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Follow up after code review to Can't create encounter from administration screen - TRUNK-2349 <http://feedproxy.google.com/~r/OMRStrunk/~3/vS6-4M4VvgA/OpenMRS> || New Changeset: OpenMRS (order-entry): Refactor Order and DrugOrder classes - TRUNK-2360 <http://feedproxy.google.com/~r/OMRStrunk/~3/4uiuauqtqe8/OpenMRS> || New Changeset: OpenMRS (order-entry): Fixed javadoc within DrugOrder - TRUNK-2387 <http://feedproxy.google.com/~r/OMRStrunk/~3/xiXe3UTuY70/OpenMRS> |
| 00:25:15 | *** wyclif has quit IRC |
| 01:10:38 | *** wyclif has joined #openmrs-sprint |
| 01:10:43 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Follow up to, Refactor Order and DrugOrder classes to add a constructor that takes in an orderable - TRUNK-2360 <http://feedproxy.google.com/~r/OMRStrunk/~3/84jioagTqGY/OpenMRS> |
| 01:26:00 | <wyclif> djazayeri, i committed another constructor for DrugOrders that takes in an orderable, can you please have a look at it and let me know if that is the implied behavior |
| 01:26:32 | <wyclif> djazayeri, this is the code |
| 01:27:11 | <wyclif> djazayeri, it only contains this.setConcept(drugOrder.getConcept()); |
| 02:07:24 | *** wyclif has quit IRC |
| 02:28:46 | *** wyclif has joined #openmrs-sprint |
| 02:51:39 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Applying code review comments for - TRUNK-2360 <http://feedproxy.google.com/~r/OMRStrunk/~3/gFYRmMMGIm4/OpenMRS> |
| 05:03:46 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): Adding useful comments in the save methods for concept map type and reference term <http://feedproxy.google.com/~r/OMRStrunk/~3/gMDqv6FYE-U/OpenMRS> |
| 05:23:40 | *** bwolfe has quit IRC |
| 05:31:15 | *** bwolfe has joined #openmrs-sprint |
| 05:31:15 | *** ChanServ sets mode: +o bwolfe |
| 05:35:59 | *** dkayiwa has joined #openmrs-sprint |
| 06:10:21 | *** bwolfe has quit IRC |
| 06:17:26 | *** bwolfe has joined #openmrs-sprint |
| 06:17:26 | *** ChanServ sets mode: +o bwolfe |
| 06:23:18 | *** bwolfe has quit IRC |
| 06:47:11 | <dkayiwa> djazayeri: am now working on comments in the OrderServiceImpl class |
| 06:50:00 | *** rafa has joined #openmrs-sprint |
| 06:50:00 | *** ChanServ sets mode: +v rafa |
| 07:48:13 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): Using annotation for provider controller. TRUNK-2253 <http://feedproxy.google.com/~r/OMRStrunk/~3/CYPNKGKsriQ/OpenMRS> || New Changeset: OpenMRS (order-entry): Correcting javadoc on getOrderHistoryByConcept - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/RtdihaITDUs/OpenMRS> |
| 09:10:35 | *** rafa has quit IRC |
| 09:38:20 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Adding patient parameter to discontinueOrderByConcept method - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/fJtf16xZswA/OpenMRS> |
| 10:09:00 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Checking if an order has been activated before it can be filled - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/V0BKXKN22_M/OpenMRS> || New Changeset: OpenMRS (order-entry): Adding patient parameter to getOrderHistoryByConcept method - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/x9_5M78MdII/OpenMRS> |
| 10:48:38 | *** rafa has joined #openmrs-sprint |
| 10:48:38 | *** ChanServ sets mode: +v rafa |
| 11:10:34 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Making the signAndActivateOrder method go through AOP - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/8xJSNLMeMoY/OpenMRS> || New Changeset: OpenMRS (providers): Fixed the redirect to happen to the same page on creating of a provider - TRUNK-2253 <http://feedproxy.google.com/~r/OMRStrunk/~3/KNTNcYoDlcY/OpenMRS> |
| 12:32:54 | *** wyclif has quit IRC |
| 13:05:58 | *** dkayiwa has quit IRC |
| 13:11:15 | *** downeym has joined #openmrs-sprint |
| 13:11:15 | *** ChanServ sets mode: +o downeym |
| 13:11:16 | *** OpenMRSBot sets mode: +o downeym |
| 13:19:33 | *** wyclif has joined #openmrs-sprint |
| 13:29:40 | *** rafa has quit IRC |
| 13:34:24 | <wyclif> djazayeri, is an activated order one whose startDate is not null? |
| 13:35:01 | <wyclif> djazayeri, and an active one is one whose start date is not null and endDate is still is null or in the future? |
| 13:47:20 | <djazayeri> wyclif: an "activated" order is one whose dateActivated is in the past |
| 13:47:57 | <djazayeri> an "active" order is one that's activated _and_ it's curren't between the startDate and min(autoExpireDate,discontinuedDate) |
| 13:48:05 | <wyclif> djazayeri, oops! i was way of the truth |
| 13:49:35 | *** r3friedman has joined #openmrs-sprint |
| 13:52:24 | *** r3friedman is now known as r-friedman |
| 14:02:56 | *** rafa has joined #openmrs-sprint |
| 14:02:56 | *** ChanServ sets mode: +v rafa |
| 14:40:29 | *** asgoyal has joined #openmrs-sprint |
| 14:40:42 | <asgoyal> Hi djazayeri |
| 14:40:52 | <asgoyal> a quick question |
| 14:40:55 | <asgoyal> can you briefly tell me what is the use of log and log factory.. i do got the gist of it.. that is to display errors.. but still need to know more |
| 14:41:20 | <asgoyal> not display but to ... kind of store errors... i m confused with this thing a little |
| 14:42:31 | <djazayeri> are you using eclipse with jetty? |
| 14:45:19 | *** asgoyal_ has joined #openmrs-sprint |
| 14:45:27 | <asgoyal_> sorry got disconnected |
| 14:45:34 | *** asgoyal has quit IRC |
| 14:49:58 | *** asgoyal_ has quit IRC |
| 14:53:27 | *** asgoyal has joined #openmrs-sprint |
| 15:06:24 | *** dkayiwa has joined #openmrs-sprint |
| 15:14:08 | *** cta has joined #openmrs-sprint |
| 15:14:14 | <cta> hello |
| 15:17:00 | <asgoyal> djazayeri i couldn't find this function in OrderService.java file -> OrderService.getOrderable(String) |
| 15:18:42 | <djazayeri> how about getOrderables(String) |
| 15:18:52 | <djazayeri> by the way, have you checked out the OrderEntry branch? |
| 15:19:27 | <djazayeri> asgoyal: ^^ |
| 15:19:39 | <asgoyal> oh |
| 15:19:42 | <asgoyal> no i haven't |
| 15:20:22 | <asgoyal> nope searched for getOrderables() also not there |
| 15:20:47 | <asgoyal> i m checking this in trunk |
| 15:22:14 | <djazayeri> you need to check out the branch at svn.openmrs.org/openmrs/branches/order-entry |
| 15:22:27 | <asgoyal> oh ok |
| 15:22:34 | <djazayeri> You do this the same way as checking out trunk, except for one thing |
| 15:23:13 | <djazayeri> you need to set the "name template" in the advanced settings while checking out from SCM |
| 15:23:22 | <djazayeri> to something like "orderEntry-[artifactId]" |
| 15:23:29 | <asgoyal> oki |
| 15:24:00 | <asgoyal> is it fine if i check out thru terminal .. i find it more convinient :P |
| 15:24:03 | <djazayeri> that will cause the maven projects checked out to have their names start with "orderEntry-" in eclipse |
| 15:24:11 | <asgoyal> oh |
| 15:24:16 | <asgoyal> ok in eclipse then |
| 15:24:17 | <djazayeri> you can check it out however you want |
| 15:24:25 | <asgoyal> hehe oki |
| 15:36:38 | *** cta has quit IRC |
| 15:45:46 | *** downeym has quit IRC |
| 15:46:03 | *** downeym has joined #openmrs-sprint |
| 15:46:03 | *** ChanServ sets mode: +o downeym |
| 15:46:04 | *** OpenMRSBot sets mode: +o downeym |
| 15:49:48 | *** rafa has quit IRC |
| 15:51:20 | *** downeym has quit IRC |
| 15:51:44 | *** downeym has joined #openmrs-sprint |
| 15:51:44 | *** ChanServ sets mode: +o downeym |
| 15:51:45 | *** OpenMRSBot sets mode: +o downeym |
| 16:02:11 | *** r-friedman has quit IRC |
| 16:06:22 | *** dkayiwa has quit IRC |
| 16:06:38 | *** cta has joined #openmrs-sprint |
| 16:07:27 | <cta> djazayeri: Hello Darius, what ticket will be next for me? |
| 16:10:17 | *** dkayiwa has joined #openmrs-sprint |
| 16:12:08 | <djazayeri> cta: can you look at TRUNK-2361 |
| 16:12:23 | <djazayeri> dkayiwa: is there already a signAndActivateOrder method? |
| 16:12:51 | <dkayiwa> yes |
| 16:13:01 | <djazayeri> okay, cta then don't do that ticket |
| 16:13:04 | <djazayeri> it's probably already done |
| 16:13:28 | <djazayeri> cta: how about TRUNK-2377 |
| 16:13:46 | <djazayeri> (that's very similar to the tickets you've already done, actually.) |
| 16:14:15 | <djazayeri> another option is TRUNK-2378 |
| 16:14:24 | <cta> stop |
| 16:15:03 | <cta> )) i'm looking at them now |
| 16:16:59 | <cta> djazayeri: Darius, I can start work on any of them because they are all interesting. |
| 16:17:21 | <djazayeri> 2377 is quick, 2378 is bigger |
| 16:17:30 | <djazayeri> depends how much time you have, and when you're starting |
| 16:17:32 | <djazayeri> up to you |
| 16:18:26 | <cta> I'm starting at 14:45 Pm (I need to get home from my work, it takes about an hour) |
| 16:18:51 | <djazayeri> okay, well, when you get home, ask on IRC if I have an opinion. |
| 16:18:55 | <djazayeri> but for now, either is fine. |
| 16:19:56 | <cta> 2378 looks more interesting for me |
| 16:21:04 | <cta> djazayeri: Darius, I'd like to work on this |
| 16:21:22 | <djazayeri> ok, well, claim it when you get home and start working :-) |
| 16:21:40 | <cta> no problem)) |
| 16:21:46 | *** cta has quit IRC |
| 16:48:58 | *** rafa has joined #openmrs-sprint |
| 16:48:58 | *** ChanServ sets mode: +v rafa |
| 16:54:00 | *** rafa has quit IRC |
| 17:59:16 | *** asgoyal has quit IRC |
| 18:10:38 | *** bwolfe has joined #openmrs-sprint |
| 18:10:38 | *** ChanServ sets mode: +o bwolfe |
| 18:11:47 | *** cta has joined #openmrs-sprint |
| 18:13:35 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Fantastic work! RT @ScottMuc: Completed a bug fix for @OpenMRS in the code-jam! (Pairing w/Joel Tellez) http://bit.ly/iBhHZP <http://twitter.com/OpenMRS/statuses/83956308335804416> || On Twitter: OpenMRS: @jeffbrandt Thanks for the tweet! <http://twitter.com/OpenMRS/statuses/83955993536499712> || On Twitter: OpenMRS: RT @ScottMuc: Mob programming on @OpenMRS with #thoughtworks http://t.co/r8Natje <http://twitter.com/OpenMRS/statuses/83955837357408256> |
| 18:25:39 | <cta> djazayeri: Hey Darius, I'm just back home and ready to work |
| 18:26:01 | <djazayeri> okay, if the ticket is still free, go ahead and claim it |
| 18:27:33 | <cta> djazayeri: I took 2378 |
| 18:32:56 | <djazayeri> great |
| 18:36:39 | *** bwolfe has quit IRC |
| 18:36:42 | *** bwolfe_ has joined #openmrs-sprint |
| 18:36:42 | *** ChanServ sets mode: +o bwolfe_ |
| 18:56:04 | <wyclif> djazayeri, what is the rationale of having DrugOrder class and a Drug Order order type, how different are they? |
| 18:59:47 | <djazayeri> our original implementation of OrderType is bad |
| 18:59:56 | <djazayeri> if we can get rid of it or re-implement it, great. |
| 19:00:26 | <djazayeri> I think we should have an order_type column on the orders table that's a discriminator |
| 19:00:55 | <djazayeri> that should determine whether it's a DrugOrder, TestOrder, etc. |
| 19:01:37 | <djazayeri> it would be better if we didn't have an order_type table. |
| 19:01:44 | <wyclif> and then get rid of the order_type table |
| 19:02:01 | <djazayeri> Would be good to have a 5-minute brainstorm with burke on this |
| 19:02:25 | <wyclif> in Uganda, we say you just got the statement out of my mouth meaning just before i said it |
| 19:02:42 | <dkayiwa> :) |
| 19:02:47 | <djazayeri> I wonder if maybe we're going to want to keep an OrderType for future purposes |
| 19:03:01 | <djazayeri> e.g. so you can distinguish between radiology and hematology TestOrders. |
| 19:03:05 | <wyclif> djazayeri, bwolfe_ , why should we have to copy properties from an order to its discontinue order when discontinuing it, i assumed a discontinue order is completely different and not a 'replacement' where the only relationship it has to the other is the fact it has been placed to cancel it |
| 19:03:48 | <djazayeri> and we just stop using that OrderType as a descriminator for now, but don't delete it. |
| 19:04:02 | <djazayeri> on the other hand, the data that's currently in there is crap, so getting rid of it would be nice. |
| 19:04:14 | <djazayeri> wyclif: I just commented on the ticket |
| 19:04:22 | <wyclif> ok |
| 19:04:30 | <djazayeri> discontinue != replacement, so you're right that you shouldn't copy over all the properties |
| 19:04:53 | <djazayeri> Concept should be copied |
| 19:04:55 | <djazayeri> I don't know what else. |
| 19:16:41 | <wyclif> got you, |
| 19:16:58 | <wyclif> i think order type should probably be an enumeration |
| 19:19:28 | <wyclif> djazayeri, where by for order_type is a final private value |
| 19:20:08 | <djazayeri> if order_type is a discriminator, it should be an Enum, yes. |
| 19:20:46 | <wyclif> can we have a ticket to make this switch, sothat eomeone can work on it |
| 19:21:06 | <wyclif> djazayeri, sorry someone |
| 19:21:41 | <djazayeri> Okay, it's mentioned in some ticket already, but it should probably be its own. |
| 19:21:49 | <wyclif> ok, thanks |
| 19:33:00 | <cta> djazayeri: Darius, just for clarification. At ticket description is saying that we should add List<Order> for OrderGroup class. This means that we need to add one-to-many relation between order_group and order tables and then map it as one-to-many. But it strange that there isn't column called order_group_id within order at giffty data model diagram. So. is it bug of diagram and we should to add that column, or I misunderstood ticket's description? |
| 19:33:48 | <djazayeri> one tangential comment is that it should probably a Set<Order>, not a List<Order> because they don't have a natural order |
| 19:34:06 | <cta> ok. but anyway? |
| 19:34:33 | *** bwolfe_ has quit IRC |
| 19:34:46 | <djazayeri> the orders table should have an order_group_id column that references the order_group table |
| 19:35:09 | <djazayeri> you're right, that's not in gliffy, but that's an oversight |
| 19:35:58 | <cta> so, may be need to fix giffty? |
| 19:36:24 | <djazayeri> yes, can you do that please? |
| 19:36:28 | <cta> ok |
| 19:37:54 | <dkayiwa> djazayeri: why would you prefer Set to List? |
| 19:38:16 | <djazayeri> dkayiwa: is there an inherent ordering to the Orders in an OrderGroup? |
| 19:38:31 | <djazayeri> I don't think there is. |
| 19:39:51 | <dkayiwa> Not very sure, when a user adds them in a particular order, wouldn't they want to see they retrieved and displayed in the same order? especially if all we need to achieve that is just use List? |
| 19:40:16 | <djazayeri> we'd need to add a list_index_in_order_group column to orders (or something like that) |
| 19:40:45 | <djazayeri> alternately instead of adding orders.order_group_id we would need a mapping table that has fk to order_group and order, and an index |
| 19:41:19 | <djazayeri> Good question, though, let's pose this on the ticket and try to get burke's opinion. (I have no idea whether preserving ordering makes sense or not.) |
| 19:41:58 | <dkayiwa> ok. if it does not cost us anything, i would vote for preserving it by default |
| 19:42:11 | <wyclif> djazayeri, then order type for now should be nullable until we add the OrderType Enum and define an enum value for it |
| 19:42:30 | <djazayeri> In the ticket I just created I propose dropping orders.order_type |
| 19:43:49 | <wyclif> which is the ticket number i could do it first because it is turning out to be a blocker |
| 19:44:07 | <djazayeri> look here: https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10251 |
| 19:44:14 | <OpenMRSBot> <http://ln-s.net/8wJU> (at tickets.openmrs.org) |
| 19:44:19 | <djazayeri> I put it in Design Review because I wanted Burke to approve first. |
| 19:58:38 | *** burke has joined #openmrs-sprint |
| 19:58:38 | *** ChanServ sets mode: +o burke |
| 20:12:29 | *** burke has left #openmrs-sprint |
| 20:12:34 | *** burke has joined #openmrs-sprint |
| 20:12:34 | *** ChanServ sets mode: +o burke |
| 20:13:52 | <cta> djazayeri: Darius, so, what to do with Set<Order>? Do we still need it? |
| 20:14:16 | *** burke has left #openmrs-sprint |
| 20:14:21 | *** burke has joined #openmrs-sprint |
| 20:14:21 | *** ChanServ sets mode: +o burke |
| 20:15:51 | <dkayiwa> wyclif: are you working on the Order class? I want to add some missing javadoc to its class member variables. |
| 20:21:07 | *** elliott_w has joined #openmrs-sprint |
| 20:21:07 | *** ChanServ sets mode: +o elliott_w |
| 20:22:01 | <downeym> burke: what is "too much traffic"? |
| 20:23:34 | <djazayeri> burke: we have two open questions for you |
| 20:23:35 | <burke> downeym: "too much traffic" means there's so many people chatting in #openmrs that sprinters can't effectively communicate across the chatter. maybe there's a more precise & equally concise way to say it. |
| 20:23:57 | <downeym> burke: yeah, not sure |
| 20:25:01 | * burke trying to retire this channel (I would redirect, but then we lose it. It's ok to keep around for a chatty day, since we have it logged & setup already), but would like 99% of activity to happen in #openmrs. |
| 20:31:23 | <djazayeri> burke, downeym, elliott_w, cta, dkayiwa, robbyoconnor, wyclif: as of now let's stop using this channel. Join #openmrs instead (if you haven't already) |
| 20:31:36 | <downeym> OK all, pool's closed |
| 20:31:56 | <dkayiwa> ok 8) |
| 20:31:59 | <cta> ok |
| 20:31:59 | <elliott_w> Aw :-( |
| 20:32:15 | *** cta has quit IRC |
| 20:32:45 | *** elliott_w has left #openmrs-sprint |
| 20:34:18 | *** burke has left #openmrs-sprint |
| 20:34:35 | *** OpenMRSBot sets mode: -o djazayeri |
| 20:34:36 | *** OpenMRSBot sets mode: +b *!~Adium@c-67-168-72-140.hsd1.wa.comcast.net |
| 20:34:37 | *** djazayeri was kicked by OpenMRSBot (Pool's closed) |
| 20:34:40 | *** OpenMRSBot sets mode: +b *!~dkayiwa@41.202.225.151 |
| 20:34:41 | *** dkayiwa was kicked by OpenMRSBot (Pool's closed) |
| 20:34:45 | *** OpenMRSBot sets mode: +b *!~wakawaka@guifications/user/r0bby |
| 20:34:46 | *** robbyoconnor was kicked by OpenMRSBot (Pool's closed) |
| 20:34:47 | *** OpenMRSBot sets mode: +b *!~wluyima_@149-166-218-40.dhcp-in.iupui.edu |
| 20:34:48 | *** wyclif was kicked by OpenMRSBot (Pool's closed) |
| 20:34:57 | *** downeym has left #openmrs-sprint |
| 20:37:35 | *** OpenMRSBot sets mode: -b *!~Adium@c-67-168-72-140.hsd1.wa.comcast.net |
| 20:37:40 | *** OpenMRSBot sets mode: -b *!~dkayiwa@41.202.225.151 |
| 20:37:45 | *** OpenMRSBot sets mode: -b *!~wakawaka@guifications/user/r0bby |
| 20:37:48 | *** OpenMRSBot sets mode: -b *!~wluyima_@149-166-218-40.dhcp-in.iupui.edu |
| 20:41:44 | *** rafa has joined #openmrs-sprint |
| 20:41:44 | *** ChanServ sets mode: +v rafa |
| 20:42:44 | *** cta has joined #openmrs-sprint |
| 20:55:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Making the patient regimen portlet able to save without a drug brand name - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/aOIAnC6zOE4/OpenMRS> |
| 21:14:45 | *** wyclif has joined #openmrs-sprint |
| 21:29:56 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Adding more javadoc to the Order class - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/3AsXbCbmJ1s/OpenMRS> |
| 21:39:26 | *** rafa has quit IRC |
| 23:02:19 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Added all necessary domain object and service methods for OrderGroups class - TRUNK-2378 <http://feedproxy.google.com/~r/OMRStrunk/~3/RNO9Xsoqim4/OpenMRS> |
| 23:03:33 | *** wyclif has quit IRC |