| 00:12:57 | <wyclif> hey |
| 00:13:13 | <wyclif> djazayeri, did rafal test the standalone on windows |
| 00:13:35 | <wyclif> it is not running in my windows vm |
| 00:13:45 | <djazayeri> I didn't ask him if he did or not |
| 00:13:50 | <djazayeri> should I try on my windows vm? |
| 00:14:17 | <downeym> that would be good |
| 00:14:36 | <djazayeri> where do I download from? |
| 00:15:07 | <downeym> wyclif: is it the one on slashtmp still? |
| 00:15:33 | <wyclif> those are the ones i sent to you |
| 00:15:47 | <djazayeri> (I only have Windows XP though, not 7, or whatever it's called now) |
| 00:15:53 | <downeym> djazayeri needs a URL to the correct version |
| 00:18:01 | <djazayeri> wyclif: ^^ |
| 00:18:22 | <wyclif> am testing on xp too |
| 00:18:48 | <downeym> djazayeri: https://slashtmp.iu.edu/files/download?FILE=mjdowney%2F789428Mbcdt |
| 00:18:53 | <downeym> pw: OpenMRS1 |
| 00:19:13 | <wyclif> https://slashtmp.iu.edu/files/download?FILE=mjdowney%2F319289ciDU6 |
| 00:19:31 | <downeym> mine is without demo data, wyclif link is with demo data |
| 00:21:17 | <djazayeri> yours had a slightly easier uri to manually type into my other window. :-) |
| 00:22:22 | <downeym> :) |
| 00:22:35 | <djazayeri> oy, 17 minutes left to download, and increasing slowly, so don't expect my testing to be done soon |
| 00:23:34 | <downeym> hmm, using 2G again? |
| 00:24:02 | <djazayeri> apparently comcast is only giving me 120KB/Sec |
| 00:24:15 | <djazayeri> And I'm not on wireless... |
| 00:26:30 | <downeym> yikes. |
| 00:37:37 | <downeym> wyclif: one from this AM (no data) https://slashtmp.iu.edu/files/download?FILE=mjdowney%2F23699j6aW32 |
| 00:52:41 | <wyclif> djazayeri, hi |
| 01:18:55 | <downeym> !cs 20811 |
| 01:18:55 | <OpenMRSBot> downeym: Details of changeset 20811 should be available at http://source.openmrs.org/qsearch?q=20811 |
| 01:20:49 | <djazayeri> wyclif: hi, sorry, was away from computer, what's up? |
| 01:21:44 | <wyclif> have you tested the standalone on windows? |
| 01:22:29 | <djazayeri> doing it right now |
| 01:22:50 | <wyclif> is that xp? |
| 01:22:56 | <djazayeri> yes |
| 01:24:36 | <djazayeri> by the way, the README has unit line breaks, so it doesn't open right in notepad on win xp |
| 01:24:41 | <djazayeri> hopefully windows 7 doesn't suffer from this |
| 01:25:37 | <djazayeri> doh, I don't have java installed |
| 01:26:58 | <downeym> wyclif: it's not going to work for him either |
| 01:27:03 | <downeym> no point in wasting more time |
| 01:28:28 | <djazayeri> loads for me, actually |
| 01:28:33 | <djazayeri> what error am I supposed to see? |
| 01:28:52 | <wyclif> is that on windows? |
| 01:29:06 | <djazayeri> windows xp (in a vm) says: Hello, Super. Welcome to openmrs-standalone |
| 01:29:07 | <wyclif> djazayeri, is that on windows? |
| 01:29:16 | <djazayeri> yes, on windows |
| 01:29:20 | <downeym> which one did you download? if you recall |
| 01:29:26 | <djazayeri> no data |
| 01:29:43 | <djazayeri> the link downeym sent me |
| 01:30:22 | <djazayeri> it correctly has no patients and no concepts |
| 01:30:36 | <wyclif> what revision number do you have in the footer |
| 01:30:52 | <djazayeri> 20843 |
| 01:30:57 | <wyclif> hmm! |
| 01:31:14 | <wyclif> as i was saying there is a permissions issue |
| 01:31:30 | <wyclif> and this is why i guess it is running on yours |
| 01:32:10 | <djazayeri> By the way, we should include .bat files to launch this on windows, in addition to the .sh for linux. |
| 01:32:49 | <djazayeri> I would vote for two .bat files, one with javaw and the other with java (call the second one "run-on-windows-debug.bat" or something) |
| 01:32:54 | <downeym> wyclif: are you going to release or not |
| 01:35:46 | <djazayeri> wyclif, downeym: going away from keyboard again, do you need me? |
| 01:36:22 | <wyclif> yeah |
| 01:36:25 | <wyclif> we need you |
| 01:36:36 | <wyclif> we are still wondering why it fails sometimes |
| 01:36:48 | <wyclif> would be right to release it |
| 01:36:59 | <wyclif> if this issues shows up |
| 01:37:13 | <wyclif> since it is in the standalone, we can always update it |
| 01:37:19 | <djazayeri> so, what is the failure mode for you? |
| 01:37:34 | <downeym> !ticket https://tickets.openmrs.org/browse/STAND-16 |
| 01:37:34 | <OpenMRSBot> downeym: Allow me to help you with that. More details on ticket https://tickets.openmrs.org/browse/STAND-16 can be found at http://tickets.openmrs.org/browse/https://tickets.openmrs.org/browse/STAND-16 |
| 01:37:37 | <downeym> see above |
| 01:39:48 | <wyclif> i highly believe why it is failing in my VM is because of permission issues |
| 01:40:12 | <wyclif> i have made some code changes that made it work on windows for me |
| 01:40:24 | <djazayeri> and they're permission-related? |
| 01:40:43 | <wyclif> because the context path is null |
| 01:41:49 | <wyclif> and the methods that sets it in his code, looks at all directories in webapp and tries to find the war file and uses that to resolve the context path which but it is returning null in my windows vm |
| 01:42:10 | <wyclif> meaning it is not finding it |
| 01:42:50 | <wyclif> should i release with this in mind after all this is something in the standalone |
| 01:43:10 | <wyclif> assuming we can replace the jar file with the fix |
| 01:43:22 | <wyclif> solong as the war file stays the same |
| 01:43:30 | <wyclif> i think this would be fine with me |
| 01:43:50 | <djazayeri> Since it worked for me, on a clean attempt, I feel fine releasing it. |
| 01:44:12 | <wyclif> djazayeri, we are trying to get in touch with paul |
| 01:44:18 | <wyclif> to get his view |
| 01:45:05 | <djazayeri> Okay. You have my sign-off to release it today. |
| 01:45:22 | <djazayeri> Although honestly I'd prefer if we had batch files to start it on windows, I guess that can wait until 1.8.1 or 1.9 |
| 02:03:44 | <downeym> 1.8.0.1 :) |
| 02:03:53 | <downeym> those can rev faster than trunk |
| 02:52:37 | *** downeym has quit IRC |
| 03:05:06 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OpenMRS 1.8 is now available! Download it today and be running in minutes: http://openmrs.org/download #eHealth #ICT4D #HFOSS <http://twitter.com/OpenMRS/statuses/83001068627308544> || OpenMRS Announcements List: OpenMRS 1.8.0 Released! <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1106&L=openmrs-announce-l&P=74> |
| 03:13:02 | *** wyclif has quit IRC |
| 03:35:19 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Announcements List: OpenMRS 1.8.0 Released! <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1106&L=openmrs-announce-l&P=878> |
| 04:04:07 | *** wyclif has joined #openmrs-sprint |
| 04:27:25 | *** bwolfe has joined #openmrs-sprint |
| 04:27:25 | *** ChanServ sets mode: +o bwolfe |
| 06:25:37 | *** rafa has joined #openmrs-sprint |
| 06:25:37 | *** ChanServ sets mode: +v rafa |
| 06:46:44 | *** dkayiwa has joined #openmrs-sprint |
| 06:56:23 | *** rafa has quit IRC |
| 07:15:42 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): [katta/zabil] Header label toggles between create and edit TRUNK 2253 <http://feedproxy.google.com/~r/OMRStrunk/~3/Jq_ls8bxd-A/OpenMRS> || New Changeset: OpenMRS (providers): [katta/zabil] Added visual separators between person and provider details, also validating for provider identifier if pr... <http://feedproxy.google.com/~r/OMRStrunk/~3/MnWL9s6MYEs/OpenMRS> |
| 08:23:25 | *** bwolfe has quit IRC |
| 09:08:49 | *** rafa has joined #openmrs-sprint |
| 09:08:49 | *** ChanServ sets mode: +v rafa |
| 09:14:43 | *** dkayiwa has quit IRC |
| 09:39:58 | *** dkayiwa has joined #openmrs-sprint |
| 11:33:02 | *** dkayiwa has quit IRC |
| 11:37:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Adding signedBy and dateSigned not null validation as per review comments - TRUNK-2386 <http://feedproxy.google.com/~r/OMRStrunk/~3/khKeqn-DWMk/OpenMRS> || New Changeset: OpenMRS (order-entry): Deleting the META-INF folder as per the review comments. <http://feedproxy.google.com/~r/OMRStrunk/~3/DQxNzEvaHGI/OpenMRS> |
| 12:02:15 | *** mimi_ has joined #openmrs-sprint |
| 12:05:06 | *** mimi_ has quit IRC |
| 12:12:01 | *** dkayiwa has joined #openmrs-sprint |
| 14:04:44 | <djazayeri> wyclif: ayt? on skype? |
| 14:06:16 | <wyclif> yes |
| 14:11:23 | *** dkayiwa has joined #openmrs-sprint |
| 14:44:07 | <djazayeri> wyclif: more (unrelated) questions for you on skype, when you have time |
| 14:44:19 | <wyclif> sure |
| 14:47:39 | <dkayiwa> djazayeri: do you prefer smaller multiple smaller commits for each review comment? Or Do you prefer one big commit after addressing all the review comments? |
| 14:47:50 | <djazayeri> I prefer smaller multiple commits |
| 14:47:53 | <dkayiwa> ok |
| 14:51:10 | *** djazayeri has left #openmrs-sprint |
| 14:51:40 | *** djazayeri has joined #openmrs-sprint |
| 14:51:40 | *** ChanServ sets mode: +o djazayeri |
| 14:59:28 | *** asgoyal has joined #openmrs-sprint |
| 14:59:34 | <asgoyal> hello |
| 15:00:40 | <asgoyal> Darius can you suggest me a ticket that can give me a good start and understanding about order entry? :) |
| 15:04:22 | <djazayeri> I was about to send you a ticket number, but I realized that dkayiwa is probably going to do that while addressing code review comments |
| 15:04:55 | <asgoyal> oh ok |
| 15:05:11 | <djazayeri> asgoyal: take a look at TRUNK-2383. (First read its parent ticket TRUNK-2382.) |
| 15:05:22 | <asgoyal> cool ok |
| 15:05:54 | <asgoyal> i will finish apptest 34 first .. is it fine? :) need just 15 mins more |
| 15:06:05 | <djazayeri> sure |
| 15:06:14 | <asgoyal> aight i will not this trunk down |
| 15:19:30 | *** asgoyal has quit IRC |
| 15:35:03 | <rafa> djazayeri: if you're free, update to trunk and see the latest version of the one-by-one dialog. |
| 15:36:19 | <djazayeri> rafa: I'll check it out |
| 15:36:38 | <djazayeri> or rather update it. :-) |
| 15:41:15 | <djazayeri> rafa: fyi, org.apache.jasper.JasperException |
| 15:41:15 | <djazayeri> /WEB-INF/template/include.jsp(9,64) PWC6303: Attempt to redefine the prefix form to /WEB-INF/taglibs/spring-form.tld, when it was already defined as http://www.springframework.org/tags/form in the current scope. |
| 15:41:53 | <djazayeri> I mentioned this on a ticket comment just now, but basically you can't include spring-form.tld as "form", or else things break in 1.7+. |
| 15:42:09 | <djazayeri> I'll fix this instance |
| 15:43:50 | <djazayeri> rev:20863 |
| 15:49:08 | <rafa> djazayeri: I'm still using 1.6. |
| 15:49:29 | <djazayeri> good, that means we'll end up testing on both |
| 15:57:37 | <djazayeri> rafa: I ran into an error when actually trying to finalize the import, so I can't determine whether the whole thing worked |
| 15:57:37 | <djazayeri> https://tickets.openmrs.org/browse/META-77 |
| 15:57:41 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Adding missing javadoc to order filler as per review comments - TRUNK-2386 <http://feedproxy.google.com/~r/OMRStrunk/~3/VUuShj58apc/OpenMRS> || New Changeset: OpenMRS (order-entry): Adding missing javadoc to previous order number as per review comments - TRUNK-2386 <http://feedproxy.google.com/~r/OMRStrunk/~3/JVTPi75qkUc/OpenMRS> |
| 15:57:43 | <djazayeri> I like the UI a lot more. |
| 15:57:56 | <djazayeri> I have some more comments about its flow |
| 15:58:28 | <djazayeri> rafa: should I comment here or on the ticket? |
| 15:59:17 | <rafa> djazayeri: we can discuss it her |
| 15:59:18 | <rafa> e |
| 15:59:41 | *** dkayiwa has quit IRC |
| 15:59:45 | <djazayeri> Okay |
| 16:00:25 | <djazayeri> one cosmetic point is that since the description of each item is a different length, the table keeps changing size, and the Back to the List / Next buttons move side to side |
| 16:00:59 | <djazayeri> I'd say specify the column widths as 20%, 40%, 40% or something. |
| 16:01:32 | <djazayeri> I would move the "Back to the list" button up next to "Item 19 out of 107" |
| 16:01:54 | <djazayeri> Okay, now the _real_ issue. |
| 16:02:12 | <djazayeri> "choose different" needs to be linked to the radio buttons, both visually, and logically |
| 16:02:35 | <djazayeri> i.e. if I say "Omit if possible" but I choose a different existing item, that doesn't make sense. |
| 16:04:23 | <rafa> I see your point. |
| 16:04:27 | <djazayeri> I'm not sure the best way to display things |
| 16:04:58 | <rafa> Yes, it's hard to approach this right. |
| 16:05:01 | <djazayeri> Maybe the radio buttons need to be next to the Existing column |
| 16:05:25 | <rafa> But they actually refer to the incoming item |
| 16:05:47 | <rafa> Only map and merge make use of existing |
| 16:05:56 | <djazayeri> I don't think the end-user would think that way. |
| 16:06:28 | <djazayeri> That they refer to the incoming item, I mean. They're just choosing what to do based on two items |
| 16:06:34 | <djazayeri> (or one item and a blank) |
| 16:07:01 | <djazayeri> What's probably better is to move the Choose Different button, actually |
| 16:08:51 | <djazayeri> If there's already a matching record (by uuid, or by doing a Map in a previous import), are you allowed to choose "map" again? |
| 16:09:17 | <djazayeri> I don't think that should be allowed. |
| 16:09:29 | <rafa> you're allowed |
| 16:12:12 | <djazayeri> It doesn't make sense, though, does it? |
| 16:13:13 | <djazayeri> Actually, I think that if you already have an existing item with a matching UUID your only options should be Merge and Don't-Merge |
| 16:13:22 | <djazayeri> (per our discussion with Andy, etc, recently) |
| 16:13:41 | <rafa> What is don't merge? |
| 16:13:42 | <djazayeri> if there's no matching UUID your options are: create new, map, omit-if-possible |
| 16:13:43 | <djazayeri> right? |
| 16:14:03 | <djazayeri> I mean you have the option of whether or not you want to overwrite your existing item. |
| 16:14:27 | <djazayeri> I forget the terminology we used |
| 16:15:24 | <rafa> If you don't want to overwrite you use omit. |
| 16:15:37 | <rafa> Actually, I set only a few restrictions and that is: |
| 16:15:48 | <rafa> Same uuid -> Create new is restricted |
| 16:16:20 | <rafa> Same conceptNameTag -> Create new is restricted |
| 16:16:20 | <djazayeri> My point is that we should actually have two different sets of options. #1 for things that are already mapped (or have the exact uuid). #2 for things that don't have a mapping yet. |
| 16:16:27 | <rafa> All other options are allowed |
| 16:16:33 | <rafa> But I can easily disallow them. |
| 16:17:17 | <djazayeri> 1. the options are: keep vs overwrite |
| 16:17:34 | <djazayeri> 2. the options are: create new, map to existing, omit if possible |
| 16:18:12 | <djazayeri> some of these may be the same actions across 1 and 2, just named differently, but the naming is important. |
| 16:18:21 | <rafa> I think that in two there should also be possible to merge |
| 16:18:39 | <djazayeri> What does merge mean if Existing is empty? |
| 16:19:00 | <rafa> impossible |
| 16:19:20 | <djazayeri> that's the case we're talking about, right? |
| 16:20:18 | <rafa> You can pick whatever existing item you want. |
| 16:20:34 | <rafa> And then you can merge. |
| 16:21:23 | <djazayeri> But really the end use should think of that as "map" right? |
| 16:21:58 | <djazayeri> i.e. they choose to replace it with an existing item. then they choose the item. then they decide whether to keep / overwrite |
| 16:22:40 | *** djazayeri has left #openmrs-sprint |
| 16:22:47 | *** djazayeri has joined #openmrs-sprint |
| 16:22:47 | *** ChanServ sets mode: +o djazayeri |
| 16:23:22 | <djazayeri> sorry, I accidentally closed this window. please re-send if you sent anything in that 30 seconds. :-) |
| 16:23:31 | <rafa> keep / overwrite -> map / merge |
| 16:23:41 | <djazayeri> Yes. |
| 16:23:58 | <djazayeri> But those shouldn't really be separate radio buttons in #2. |
| 16:24:46 | <djazayeri> It should be one radio button for "I have an existing item" which _then_ requires you to indicate the existing item, and decide whether to keep / overwrite |
| 16:25:46 | <rafa> I wish we had a whiteboard ;) |
| 16:26:00 | <djazayeri> Indeed. |
| 16:26:14 | <djazayeri> Probably time for a balsamiq mockup in JIRA |
| 16:26:40 | <rafa> Yes, please do that. |
| 16:28:03 | <djazayeri> hey, do you have easy access to the dateCreated / dateChanged on the existing and incoming items? |
| 16:28:17 | <rafa> yes |
| 16:28:27 | <djazayeri> good |
| 16:28:56 | <rafa> but remember that not all objects have them |
| 16:29:03 | <rafa> or use them |
| 16:29:41 | <rafa> like locations (at least in 1.6) |
| 16:29:42 | <djazayeri> What doesn't? |
| 16:29:49 | <djazayeri> hmm, okay |
| 16:30:02 | <djazayeri> well, it should :-P |
| 16:41:27 | *** rafa has quit IRC |
| 16:45:22 | *** cta has joined #openmrs-sprint |
| 16:45:30 | <cta> hello |
| 17:00:32 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Removing the redundant implements serializable as per review comments - TRUNK-2386 <http://feedproxy.google.com/~r/OMRStrunk/~3/mLKMFt9E-TM/OpenMRS> |
| 17:12:01 | *** dkayiwa has joined #openmrs-sprint |
| 17:20:50 | <cta> djazayeri: Hello Darius, do we need to override an existing _getDescription_ and _getName_ method for Drug class when implementing orderable or just can leave aeverything as is? |
| 17:23:48 | <djazayeri> cta leave as is for now |
| 17:24:07 | <djazayeri> we'll see how the UI plays out |
| 17:29:49 | *** rafa has joined #openmrs-sprint |
| 17:29:49 | *** ChanServ sets mode: +v rafa |
| 17:35:39 | *** rafa has quit IRC |
| 17:39:55 | <cta> djazayeri: ok, thanx |
| 17:46:04 | <cta> djazayeri: Darius, I just added patch for 2358. What is next? |
| 17:58:53 | <djazayeri> dkayiwa: you around? |
| 17:59:00 | <dkayiwa> yes |
| 17:59:37 | <djazayeri> The review comments on that big review overlap significantly with the tickets |
| 17:59:51 | <dkayiwa> ohhhhhhh |
| 18:00:05 | <djazayeri> I need some way to figure out what you're working on, so that for example when cta asks what ticket to do next, I can tell him |
| 18:00:25 | <djazayeri> not sure the best way to do this. maybe you can just comment here what piece you're fixing at the moment. |
| 18:00:34 | <djazayeri> for now, a question: https://tickets.openmrs.org/browse/TRUNK-2387 |
| 18:00:41 | <djazayeri> https://tickets.openmrs.org/browse/TRUNK-2387 |
| 18:00:51 | <dkayiwa> ok |
| 18:00:53 | <djazayeri> Can I assign this to Taras, or have you done it / will do it soon? |
| 18:01:48 | <dkayiwa> yes you can assign him |
| 18:01:58 | <djazayeri> okay, cta, how about https://tickets.openmrs.org/browse/TRUNK-2387 |
| 18:02:15 | <djazayeri> it's a bigger ticket than the others. |
| 18:02:24 | <dkayiwa> ok |
| 18:02:42 | <cta> djazayeri: lets see |
| 18:05:58 | <cta> djazayeri: you can assign this ticket to me, but I'll need some clarifications of this |
| 18:07:06 | <djazayeri> basically the point is to change the data model by removing the complex boolean and complex_dosing string, and replacing those with an "unstructured_dosing" string. |
| 18:07:52 | <djazayeri> this will involve doing a liquibase changeset, changing the hibernate mapping, changing the domain object. |
| 18:07:58 | <cta> djazayeri: ok, so I need to add changeset into liquibase |
| 18:08:07 | <djazayeri> yes |
| 18:08:14 | <cta> ok, its very interesting |
| 18:08:23 | <djazayeri> have you done that before, btw? |
| 18:09:25 | <cta> I have changed liquibase for many times, but do not add changes into existing mappings and domain objects but I don't think that it will make any problem for me |
| 18:10:10 | <djazayeri> okay, cool, so the ticket is yours then. |
| 18:10:13 | <djazayeri> ask if you have questions |
| 18:13:12 | <cta> djazayeri: Ok. Moreover, since my GSoC project is related to DB update wizard I did changes within liquibase for many times for testing purposes |
| 18:13:12 | <cta> . So, thanx, I gotta start work on this ticket after 15 PM EST. |
| 18:13:30 | <djazayeri> okay, it's possible that someone else will take this ticket before then |
| 18:13:45 | <djazayeri> so ping me at 15:00 EST and we'll confirm. |
| 18:14:23 | <cta> ok, but I already claimed issue |
| 18:14:39 | <djazayeri> Okay, really you shouldn't do that until you're really going to start working on it. |
| 18:14:56 | <cta> ok, I disclaiming it now |
| 18:14:59 | <djazayeri> Normally this doesn't matter, but since this is a sprint, hours actually matter. :-) |
| 18:15:21 | <cta> )) |
| 18:27:16 | *** dkayiwa has quit IRC |
| 18:31:03 | *** cta has quit IRC |
| 18:36:00 | *** dkayiwa has joined #openmrs-sprint |
| 18:36:05 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Adding missing javadoc to the OrderSet class as per review comments - TRUNK-2386 <http://feedproxy.google.com/~r/OMRStrunk/~3/vL8Zbj-o5WI/OpenMRS> |
| 18:37:56 | *** cta has joined #openmrs-sprint |
| 18:44:06 | *** wyclif has quit IRC |
| 18:46:53 | *** wyclif has joined #openmrs-sprint |
| 18:50:52 | *** bwolfe has joined #openmrs-sprint |
| 18:50:52 | *** ChanServ sets mode: +o bwolfe |
| 18:59:11 | <cta> djazayeri: I found two columns "complex : boolean" and "complex_dosing : boolean" for drug_order table. So, my steps: I'll remove them using liquibase, then instead of them I'll add new column "unstructured_dosing : varchar(255)", after that I'll change hibernate mapping inside /org/openmrs/api/db/hibernate/Order.hbm.xml, and only after all these steps I will make changes within org.openmrs.DrugOrder class. Correct me if I missed something. |
| 18:59:34 | <djazayeri> correct. |
| 18:59:44 | <cta> so, can I act? |
| 18:59:50 | <djazayeri> yes |
| 18:59:54 | <djazayeri> you can re-claim the ticket |
| 19:00:08 | <cta> ok, thanks |
| 19:24:10 | <cta> djazayeri: do we need to validate unstructuredDosing field for DrugOrder class? If yes, how? check for empty? |
| 19:24:19 | <djazayeri> no validation |
| 19:24:27 | <cta> cool |
| 19:24:29 | <djazayeri> it's allowed to be blank, or any text. |
| 19:24:52 | <cta> I got it |
| 19:25:00 | <cta> thank you |
| 19:35:22 | *** dkayiwa_ has joined #openmrs-sprint |
| 19:36:42 | *** dkayiwa has quit IRC |
| 19:36:43 | *** dkayiwa_ is now known as dkayiwa |
| 19:38:58 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Removing the not null constraint from the order hibernate mapping file - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/WoLjuZ-Wqxc/OpenMRS> || New Changeset: OpenMRS (order-entry): Removing the requiring of brand name from DrugOrder.js.withjstl - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/TpgHH2TV0d8/OpenMRS> || New Changeset: OpenMRS (order-entry): Removing unnecessary changeset which was setting null brand name to an empty string - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/SsxyyLrEcC0/OpenMRS> |
| 19:53:20 | <cta> djazayeri: I have refactored /web/src/main/java/org/openmrs/web/dwr/DrugOrderListItem and web/src/main/java/org/openmrs/web/controller/migration/MigrationController |
| 19:56:56 | <djazayeri> cta: what needed to change in DrugOrderListItem? |
| 19:57:08 | <djazayeri> (We should probably get rid of MigrationController, so nobody ever wasted time on that again.) |
| 19:57:26 | <djazayeri> actually, can you create a ticket in trunk for "Remove MigrationController from the web layer" please? |
| 19:57:42 | <cta> because it uses getComplex() method from DrugOrder |
| 19:57:57 | <cta> about ticket, ok, no problem |
| 19:58:36 | <djazayeri> ah, okay |
| 20:05:13 | <cta> djazayeri: I've already added new ticket: https://tickets.openmrs.org/browse/TRUNK-2390 |
| 20:06:40 | *** rafa has joined #openmrs-sprint |
| 20:06:40 | *** ChanServ sets mode: +v rafa |
| 20:10:23 | *** dkayiwa has quit IRC |
| 20:16:21 | <djazayeri> wyclif: have you put up new versions of standalone yet? |
| 20:24:19 | <wyclif> yes i have djazayeri |
| 20:24:40 | <djazayeri> wyclif: did you rename them? |
| 20:24:50 | <wyclif> djazayeri, yes |
| 20:25:01 | <wyclif> to standalone-1.8.0.1 |
| 20:25:17 | <djazayeri> okay, that hasn't been updated on openmrs.org/download |
| 20:25:30 | <wyclif> let me check |
| 20:26:59 | <wyclif> wait |
| 20:27:19 | <wyclif> wai supposed to rename the standalone zip or the jar? |
| 20:27:25 | <wyclif> sorry was i? |
| 20:27:43 | <wyclif> when i talked about renaming, i meant the jar file |
| 20:27:54 | <wyclif> but i can rename the zips |
| 20:29:41 | <wyclif> i think we are mixing up things here |
| 20:32:46 | <wyclif> djazayeri, what do you mean renaming? |
| 20:32:52 | <wyclif> the jar file or the zip |
| 20:33:44 | <wyclif> my connection at home being slow |
| 20:36:13 | <cta> djazayeri: Daruis, I've already done update of DB and all refactoring for code and mappings. It seems that everyting works fine. Also I runned OrderServiceTest and it also was "green". So, waht else I should do to prepare patch? Telll me please, you know, its very important because it's bug refactoring, and we should be 100% sure that all works normally. |
| 20:37:00 | <cta> (big) not bug |
| 20:37:21 | <djazayeri> cta: just attach the patch |
| 20:37:27 | <cta> cool |
| 20:37:31 | <cta> thanx |
| 20:37:35 | <djazayeri> we'll code review it, and maybe a second set of eyes will notice something |
| 20:38:01 | <cta> Yep, I need fresh pair of eyes for this |
| 20:40:52 | <djazayeri> wyclif, I figured that we should be able to ask people "what file did you download?" and know if they have the buggy one or not |
| 20:42:11 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Setting date created to null when saving an order such that our framework can take over this duty - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/TcmP4ENQ4HA/OpenMRS> |
| 20:46:41 | *** rafa has quit IRC |
| 20:50:24 | <cta> djazayeri: Darius, I've already attached the patch for 2387 |
| 20:51:09 | <djazayeri> cta: i'm on the phone now |
| 20:51:15 | <djazayeri> will review when i can |
| 20:56:27 | <cta> ok, no problem |
| 21:01:17 | *** cta_ has joined #openmrs-sprint |
| 21:01:17 | *** cta has quit IRC |
| 21:32:45 | <wyclif> djazayeri, i added a comment on https://tickets.openmrs.org/browse/TRUNK-2360 |
| 21:33:11 | <wyclif> can you please respond it? |
| 21:33:21 | <djazayeri> btw, wyclif, note that cta is implementing the ustructuredDosing change |
| 21:33:29 | <djazayeri> I am on the phone, will reply when I can. |
| 21:47:23 | <cta_> djazayeri: Small reminder)) I've attached the patch for 2387, so I'll wait for your feedbacks. But not I need sleep, it's about 1 AM in Ukraine. |
| 21:47:32 | <cta_> good night guys |
| 21:50:32 | <djazayeri> good night cta_ |
| 21:50:43 | <djazayeri> will review today |
| 21:50:54 | *** cta_ has quit IRC |
| 22:27:50 | <djazayeri> wyclif: I just commented, but actually we're going to need Burke to answer the question. |
| 22:30:05 | <djazayeri> You may want to switch to a different ticket until he replies. A good ticket that doesn't overlap with what Daniel is doing is: https://tickets.openmrs.org/browse/TRUNK-2378 |