| 05:35:10 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Converting handler classes to use @Component. ... <http://feedproxy.google.com/~r/OMRStrunk/~3/pvQ3p3sBGik/OpenMRS> |
| 05:41:26 | *** mimi has joined #openmrs-sprint |
| 05:44:47 | *** djazayeri has quit IRC |
| 05:45:11 | *** mimi has left #openmrs-sprint |
| 05:52:19 | *** bwolfe has joined #openmrs-sprint |
| 05:52:19 | *** ChanServ sets mode: +o bwolfe |
| 06:01:30 | *** djazayeri has joined #openmrs-sprint |
| 06:01:30 | *** ChanServ sets mode: +o djazayeri |
| 06:18:10 | <bwolfe> djazayeri, you really online now, or are you sleeping? |
| 06:50:02 | *** dkayiwa has joined #openmrs-sprint |
| 06:51:23 | <bwolfe> dkayiwa, is the work you did on orderentry in the order-entry branch already? |
| 06:53:07 | <dkayiwa> bwolfe: i created a patch for it. should i apply it to the order-entry branch? |
| 06:53:55 | <bwolfe> yes, or I can if you're busy with standalone stuff. we need to have the stuff you've worked on before we begin work on everything else. has darius |
| 06:54:08 | <bwolfe> *has darius asked you about what you've done so far and which tickets are actually complete already? |
| 06:54:47 | <dkayiwa> bwolfe: let me checkout the branch and apply it now |
| 06:54:57 | <dkayiwa> NO. Darius has not yet asked me anything |
| 07:12:19 | <dkayiwa> bwolfe: does checking out the order entry branch also take long for you? |
| 07:12:40 | <bwolfe> dkayiwa, yes, took a while |
| 07:12:50 | <bwolfe> mainly because of the logic module in it I think |
| 07:13:00 | <dkayiwa> ok was getting worried :) |
| 07:13:29 | <dkayiwa> bwolfe: have you ever run the demo.sql script on 1.8? |
| 07:13:47 | *** Katta has joined #openmrs-sprint |
| 07:14:15 | <dkayiwa> bwolfe: the one here: https://wiki.openmrs.org/display/RES/Demo+Data\ |
| 07:15:58 | <bwolfe> dkayiwa, the one that wyclif just made? |
| 07:16:43 | <dkayiwa> bwolfe: looks like Michael made this one |
| 07:16:55 | <dkayiwa> where is the one that wyclif made? |
| 07:18:17 | <bwolfe> I see the 1.8.0 one by wyclif on that link |
| 07:18:25 | <bwolfe> did you see wyclif's email that he had made it? |
| 07:18:38 | <bwolfe> he just mentioned it in the email yesterday |
| 07:20:09 | <dkayiwa> bwolfe: i saw the email and the 1.8 war link but not demo data link |
| 07:21:55 | <bwolfe> ok, yes, do you see it now though? using the 1.8 demo should make your job a lot faster |
| 07:22:35 | *** Katta has quit IRC |
| 07:23:06 | *** rafa has joined #openmrs-sprint |
| 07:23:06 | *** ChanServ sets mode: +v rafa |
| 07:23:39 | <dkayiwa> oh yes i have refreshed the page and seen it. thanks bwolfe |
| 07:24:47 | <bwolfe> aha. beautiful |
| 07:25:27 | <bwolfe> dkayiwa, did you see the email about it? Looks like darius copied it to your dkayiwaatopenmrs email |
| 07:26:32 | <dkayiwa> bwolfe: what is the email subject |
| 07:26:46 | <bwolfe> "beginning of next week" |
| 07:27:09 | <bwolfe> dkayiwa, you should just forward your @openmrs account to your other gmail, then you don't have to worry about missing any. :-) |
| 07:27:28 | <bwolfe> you can set up different senders in gmail so that when you reply to something sent to @openmrs.org it changes the "from" to be the same |
| 07:27:56 | <dkayiwa> bwolfe: i read my openmrs emails all the time :) |
| 07:28:12 | <bwolfe> ah, ok |
| 07:28:29 | <bwolfe> just missed that last point in Wyclif's then? :-) |
| 07:29:25 | <dkayiwa> the one he sent today (Ugandan time)? :) |
| 07:36:19 | <bwolfe> yes, some time after midnight |
| 07:49:47 | *** Katta has joined #openmrs-sprint |
| 07:56:24 | *** bwolfe has quit IRC |
| 08:05:33 | *** bwolfe has joined #openmrs-sprint |
| 08:05:33 | *** ChanServ sets mode: +o bwolfe |
| 08:14:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Service layer and spring configuration changes to support @Component <http://feedproxy.google.com/~r/OMRStrunk/~3/hqQxGxxKEf0/OpenMRS> |
| 08:21:48 | <dkayiwa> bwolfe: does double clicking the standalone app to run on your linux box require it to be signed? |
| 08:27:29 | <bwolfe> dkayiwa, I don't remember it asking to be signed |
| 08:27:38 | <bwolfe> but I don't have it downloaded right now to try... |
| 08:29:01 | <dkayiwa> ok |
| 08:33:55 | <bwolfe> does the mac require a sig? |
| 08:34:02 | <dkayiwa> no |
| 08:34:08 | <bwolfe> (I don't even know what goes into signing or why its done) |
| 08:34:45 | <dkayiwa> i will ask wyclif for the link which says that linux requires signing |
| 09:23:54 | *** bwolfe has quit IRC |
| 09:49:07 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): [katta/zabil] Added providerId in the ProviderListItem TRUNK 2253 <http://feedproxy.google.com/~r/OMRStrunk/~3/6sauaKcfUUI/OpenMRS> || New Changeset: OpenMRS (order-entry): Applying the order entry patch that Daniel was working on before the June 20th order entry sprint. <http://feedproxy.google.com/~r/OMRStrunk/~3/bCaw2O8ScFc/OpenMRS> || New Changeset: OpenMRS (trunk): mvn-compiler-plugin has encoding problems - TRUNK-2375 <http://feedproxy.google.com/~r/OMRStrunk/~3/VVLMRK_P4RI/OpenMRS> || New Changeset: OpenMRS (providers): [katta/zabil] Now displaying just one name colum, removed incorrect identifier in the search parameters. Also added DWRP... <http://feedproxy.google.com/~r/OMRStrunk/~3/vCcn-OLu1Lo/OpenMRS> |
| 09:59:17 | *** Katta has quit IRC |
| 10:13:23 | *** Katta has joined #openmrs-sprint |
| 10:21:30 | *** Katta has quit IRC |
| 10:22:54 | *** Katta has joined #openmrs-sprint |
| 10:47:26 | *** bwolfe has joined #openmrs-sprint |
| 10:47:26 | *** ChanServ sets mode: +o bwolfe |
| 10:48:47 | <dkayiwa> bwolfe: i have committed the order entry patch |
| 10:49:02 | <bwolfe> awesome, thanks! |
| 10:49:49 | <dkayiwa> bwolfe: do you have an account on the bafang server? |
| 10:50:11 | <bwolfe> I think so, but I don't have my ssh key on my computer yet, so I can't log in :-/ |
| 10:50:14 | <bwolfe> why? |
| 10:50:17 | <bwolfe> are they done? |
| 10:50:35 | <dkayiwa> would love some people to test |
| 10:52:00 | <bwolfe> how big is the download? |
| 10:55:07 | <dkayiwa> bwolfe: 143MB, 146MB, 195MB with no data, core data, demo data respectively |
| 10:55:27 | <bwolfe> ok |
| 10:55:35 | <dkayiwa> i think thats not healthy for yo connection :) |
| 10:55:36 | <bwolfe> that will take me a while to download. :-) |
| 10:57:25 | <dkayiwa> bwolfe: i wanted to do some research on signing the jar. But am not sure whether it is true that double clicking on linux requires jar signing |
| 10:57:46 | <bwolfe> ah, right |
| 10:57:51 | <bwolfe> rafa, what OS are you running? |
| 11:04:23 | *** bwolfe has quit IRC |
| 11:04:25 | *** bwolfe_ has joined #openmrs-sprint |
| 11:04:25 | *** ChanServ sets mode: +o bwolfe_ |
| 11:06:54 | <rafa> bwolfe_: Hi, windows |
| 11:07:03 | <bwolfe_> boo rafa |
| 11:07:05 | <rafa> but I've got Ubuntu on VM as well. |
| 11:07:47 | <rafa> bwolfe_: works for me ;) |
| 11:08:11 | *** bwolfe_ is now known as bwolfe |
| 11:10:52 | *** bwolfe_ has joined #openmrs-sprint |
| 11:10:52 | *** ChanServ sets mode: +o bwolfe_ |
| 11:11:37 | *** bwolfe has quit IRC |
| 11:15:02 | *** dkayiwa has quit IRC |
| 11:20:54 | *** wluyima has quit IRC |
| 11:30:05 | *** dkayiwa has joined #openmrs-sprint |
| 11:34:30 | *** wluyima has joined #openmrs-sprint |
| 12:02:18 | *** bwolfe_ has quit IRC |
| 12:03:58 | *** bwolfe_ has joined #openmrs-sprint |
| 12:03:58 | *** ChanServ sets mode: +o bwolfe_ |
| 12:09:16 | *** dkayiwa has quit IRC |
| 12:16:26 | *** dkayiwa has joined #openmrs-sprint |
| 12:30:59 | *** Katta has quit IRC |
| 12:34:42 | *** wluyima has quit IRC |
| 13:10:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): [katta/zabil] Fixed the retire / unretire functionality in providers TRUNK 2253 <http://feedproxy.google.com/~r/OMRStrunk/~3/zLVX2jf-u_0/OpenMRS> || New Changeset: OpenMRS (order-entry): API support for finding active orders for a patient - TRUNK-2365... <http://feedproxy.google.com/~r/OMRStrunk/~3/cw5Lk-9jJHU/OpenMRS> |
| 13:12:28 | *** bwolfe_ is now known as bwolfe |
| 13:16:20 | *** downeym has joined #openmrs-sprint |
| 13:16:20 | *** ChanServ sets mode: +o downeym |
| 13:16:21 | *** OpenMRSBot sets mode: +o downeym |
| 13:37:28 | *** wluyima has joined #openmrs-sprint |
| 13:45:12 | *** bwolfe_ has joined #openmrs-sprint |
| 13:45:12 | *** ChanServ sets mode: +o bwolfe_ |
| 13:46:15 | *** bwolfe has quit IRC |
| 13:47:28 | <wluyima> hi dkayiwa |
| 13:48:22 | <dkayiwa> hi wluyima |
| 13:58:32 | *** downeym_ has joined #openmrs-sprint |
| 13:58:32 | *** ChanServ sets mode: +o downeym_ |
| 13:59:05 | <djazayeri> good morning/afternoon |
| 13:59:22 | <rafa> Hi Darius |
| 13:59:23 | <djazayeri> dkayiwa: I see a message from you many hours ago saying you committed an order entry patch |
| 13:59:55 | <dkayiwa> yes |
| 14:00:26 | <djazayeri> I guess I'll just take a look at the svn history to see what's contained there |
| 14:00:39 | *** downeym has quit IRC |
| 14:00:39 | *** downeym_ is now known as downeym |
| 14:02:00 | <djazayeri> also, bwolfe_, dkayiwa, just reading emails, but have we decided exactly what standalone versions to include? |
| 14:05:08 | *** Katta has joined #openmrs-sprint |
| 14:05:24 | *** burke has joined #openmrs-sprint |
| 14:07:34 | *** burke has quit IRC |
| 14:16:01 | <downeym> djazayeri: Paul just came by and he said he only cares about the empty/clean installation and the 5000 patient version. he said someone else (?) asked for the dictionary only version but he wasn't interested in that. |
| 14:16:31 | <djazayeri> downeym: yes, we independently decided the same thing over skype |
| 14:16:34 | <djazayeri> thanks |
| 14:17:32 | <downeym> also - he asked about https://tickets.openmrs.org/browse/TRUNK-2375 and whether or not it's a blocker so to speak for 1.8.0. Ben has committed the fix to 1.8.x but it's not yet in 1.8.0 and as a result, 1.8.0 has problems building on some environments. |
| 14:18:28 | <bwolfe_> how does he know about 2375? |
| 14:18:47 | <downeym> jira i guess |
| 14:21:17 | <bwolfe_> ook. |
| 14:21:40 | <downeym> idk, he wanted to know if it's "fragile" |
| 14:21:43 | *** asgoyal_ has joined #openmrs-sprint |
| 14:26:27 | <bwolfe_> no, its not fragile, its a funky setup in CI builds |
| 14:30:24 | <downeym> since your fix fixed it it doesn't strike me as too funky |
| 14:31:20 | <bwolfe_> its funky because it /only/ happens within the ci environment (not on the machine with diff user and not on any developers' machines) |
| 14:32:33 | <downeym> we don't want our builds to be platform independent? |
| 14:32:43 | <djazayeri> downeym: rafa needs access to one of the standalone jars on bafang for testing |
| 14:33:01 | <downeym> rafa: which one? |
| 14:33:14 | <djazayeri> any one, i think |
| 14:33:18 | <djazayeri> point is to test on windows 7 |
| 14:33:58 | <rafa> downeym: as Darius said :) |
| 14:34:23 | <downeym> rafa: ok :) |
| 14:34:24 | <downeym> stand by |
| 14:35:59 | <downeym> rafa: https://slashtmp.iu.edu/files/download?FILE=mjdowney%2F3941HKEAfP -- password OpenMRS1 |
| 14:36:04 | <OpenMRSBot> <http://ln-s.net/8vdI> (at slashtmp.iu.edu) |
| 14:36:31 | <rafa> downeym: thanks! |
| 14:47:36 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Fixing unit tests in order entry branch - TRUNK-2385 <http://feedproxy.google.com/~r/OMRStrunk/~3/OcBXwE0Rb2Q/OpenMRS> |
| 14:58:31 | *** burke has joined #openmrs-sprint |
| 15:11:45 | *** bwolfe_ has quit IRC |
| 15:37:19 | *** dkayiwa has quit IRC |
| 16:50:07 | *** ChanServ sets mode: +o burke |
| 16:50:39 | *** ChanServ sets mode: +v wluyima |
| 16:59:48 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): [katta] removed few whitespaces <testing cronjob> <http://feedproxy.google.com/~r/OMRStrunk/~3/5DYC7O41CYg/OpenMRS> |
| 17:00:06 | *** Katta has left #openmrs-sprint |
| 17:13:06 | <downeym> wluyima: https://slashtmp.iu.edu/files/download?FILE=mjdowney%2F70133WWVl7C (core data) |
| 17:14:46 | <downeym> wluyima: https://slashtmp.iu.edu/files/download?FILE=mjdowney%2F72792LK1bz6 (full demo data) |
| 17:15:12 | *** Katta has joined #openmrs-sprint |
| 17:16:26 | *** Katta has left #openmrs-sprint |
| 17:44:01 | <burke> @djazayeri: In the orders data model (https://wiki.openmrs.org/x/PIPP), I replaced two attributes, complex_dosing (boolean) & complex_dosing_instructions (text), with one: unstructured_dosing (text). Do I need to make a ticket for this change or not? |
| 17:44:38 | <djazayeri> Ticket would help, since Daniel's code has now added those fields. |
| 17:44:59 | <djazayeri> Btw, I'm soon going to ask you to take a look at the code review, where I have a bunch of "what is this property" questions. |
| 17:45:18 | <djazayeri> but I'll wait till I've finished looking at the DAO and Service interfaces. |
| 17:47:03 | <djazayeri> burke: ^^ |
| 17:47:51 | *** bwolfe_ has joined #openmrs-sprint |
| 17:47:51 | *** ChanServ sets mode: +o bwolfe_ |
| 17:54:11 | <djazayeri> burke, I'm ready for you to start looking at https://source.openmrs.org/cru/CR-TRUNK-372 |
| 17:54:42 | <djazayeri> (focus on answering the questions I've posed in comments on the domain objects.) |
| 17:54:54 | <djazayeri> I don't need actual code review. |
| 17:56:07 | <burke> ok. looking now. |
| 17:56:46 | *** bwolfe__ has joined #openmrs-sprint |
| 17:57:11 | *** bwolfe__ is now known as bwolfe |
| 18:00:30 | *** bwolfe_ has quit IRC |
| 18:00:50 | *** dkayiwa has joined #openmrs-sprint |
| 18:01:18 | <djazayeri> hi dkayiwa, I semi-accidentally unassigned a ticket from you, assuming you were off for the day, but if you're still working, feel free to re-claim it. |
| 18:02:27 | <dkayiwa> no problem :) |
| 18:05:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : improved javadoc for custom localization tool <http://feedproxy.google.com/~r/OMRStrunk/~3/ApoTyNeFn5E/OpenMRS> |
| 18:07:27 | *** asgoyal_ has quit IRC |
| 18:15:10 | *** cta has joined #openmrs-sprint |
| 18:15:24 | <cta> hello |
| 18:15:37 | <djazayeri> hi cta |
| 18:16:10 | <cta> I'd like to take a part in currrent sprint |
| 18:19:11 | <cta> djazayeri: I think that it would not be hurt if I'll do a couple of some tickets)) |
| 18:19:38 | <djazayeri> cta: cool. at the moment we're a bit slow starting because we just had a code check-in this morning, so we're reviewing that and reconsidering tickets. |
| 18:19:59 | <djazayeri> dkayiwa: did you re-claim that ticket? |
| 18:20:11 | <dkayiwa> not yet |
| 18:20:19 | <djazayeri> are you planning to do so today? |
| 18:20:27 | <dkayiwa> tomorrow |
| 18:20:39 | <djazayeri> okay, then you'll probably get a different ticket. :-) |
| 18:20:55 | <dkayiwa> ok :) |
| 18:21:41 | <cta> djazayeri: ok, but anyway, I can start working on TRUNK-2367 (support for discontinuing order) |
| 18:22:09 | <djazayeri> cta: the first ticket in the sprint is: https://tickets.openmrs.org/browse/TRUNK-2356 |
| 18:22:27 | <djazayeri> if you are going to do this _right now_ then you should do that ticket. |
| 18:23:05 | <djazayeri> 2367 isn't great because it still needs clarification on one point |
| 18:23:19 | <cta> djazayeri: I actually know |
| 18:23:23 | <djazayeri> maybe @burke can comment on the NEEDS CLARIFICATION point in https://tickets.openmrs.org/browse/TRUNK-2367 |
| 18:32:23 | <djazayeri> so, cta, if you can do it right now, do 2356 |
| 18:33:29 | <cta> djazayeri: Darius, I can begin to do it after 15:00 EST |
| 18:33:46 | <djazayeri> In that case, it will probably be done already |
| 18:33:57 | <djazayeri> I'll be online at 15:00EST, so ask me what to do then. |
| 18:34:25 | <cta> ok, thank you |
| 18:37:01 | *** dkayiwa has left #openmrs-sprint |
| 18:38:47 | <burke> djazayeri, cta: FYI, just added a comment to https://tickets.openmrs.org/browse/TRUNK-2367 |
| 18:39:16 | <djazayeri> thx, can you do 2369 too? |
| 18:39:35 | <djazayeri> and if I've gotten the terminology wrong ("revising an activated order") fix that? |
| 18:40:28 | <cta> burke: thanx |
| 18:43:45 | <djazayeri> cta: do trunk-2356 |
| 18:43:52 | <cta> ok |
| 18:43:53 | <djazayeri> (make sure you're working off the order-entry branch!) |
| 18:44:08 | <djazayeri> it should be quite quick to do, just creating an interface with a few methods. |
| 18:45:23 | <djazayeri> cta: let me know if you have any questions about it, or if anything isn't clear. |
| 18:45:36 | <cta> where to put that interface? |
| 18:45:51 | <djazayeri> org.openmrs.Orderable |
| 18:45:56 | *** djazayeri has left #openmrs-sprint |
| 18:46:16 | *** djazayeri has joined #openmrs-sprint |
| 18:46:16 | *** ChanServ sets mode: +o djazayeri |
| 18:46:41 | <cta> djazayeri: into org.openmrs package? |
| 18:47:31 | <djazayeri> yes |
| 18:48:17 | <cta> djazayeri: thank you |
| 19:05:17 | <cta> djazayeri : do I also need to add BaseOrderable abstract class? or we just can skip it? |
| 19:05:48 | <djazayeri> if it's in the ticket description, do that oo |
| 19:05:52 | <djazayeri> (too) |
| 19:27:17 | *** ChanServ sets mode: +o bwolfe |
| 19:41:51 | <cta> djazayeri : To be more informative and do not wait while you receive an email with code review request I'm saying here that I've added the patch for 2356. What I should do next? 2357? |
| 19:41:56 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (): Removing the 1.8.0 tag before creating a new one that includes the addition of the maven-encoding-plugin <http://feedproxy.google.com/~r/OMRStrunk/~3/vsyJPgrb2x0/OpenMRS> |
| 19:43:04 | <djazayeri> cta: yes, 2357 |
| 19:43:17 | <djazayeri> (getting lunch now, so partly away from keyboard) |
| 19:43:33 | <cta> )) bon appetit |
| 19:54:31 | *** dkayiwa_ has joined #openmrs-sprint |
| 19:56:35 | <cta> djazayeri: I need small clarification about 2357. There is saying that I need implement two methods _getOrderable(...)_ within OrderService. First of them receives query string (probably, it's concept's name), and the 2nd, additionally, accepts type. What is difference beetwen them? |
| 19:56:53 | <djazayeri> for now, skip the second method |
| 19:56:57 | <djazayeri> also, I commented on the previous ticket |
| 19:59:34 | <cta> ok, it gos that I need implement method that search through concepts by name where class=Drug and return result as list of concepts wrapped into GenericDrug? |
| 19:59:44 | <cta> (goes) |
| 19:59:46 | <djazayeri> yes |
| 20:00:15 | <cta> djazayeri: you are so fast)) are you reading my minds? |
| 20:35:05 | *** bwolfe has quit IRC |
| 20:45:06 | *** dkayiwa_ has quit IRC |
| 20:46:15 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): [maven-release-plugin] prepare for next development iteration <http://feedproxy.google.com/~r/OMRStrunk/~3/ZsfsLrkrE2U/OpenMRS> || New Changeset: OpenMRS (): [maven-release-plugin] copy for tag 1.8.0 <http://feedproxy.google.com/~r/OMRStrunk/~3/jn2zGeE9SNg/OpenMRS> || New Changeset: OpenMRS (1.8.x): [maven-release-plugin] prepare release 1.8.0 <http://feedproxy.google.com/~r/OMRStrunk/~3/ouGqJuQC9n0/OpenMRS> |
| 20:51:54 | <djazayeri> rafa: what do I do to see the new module version |
| 20:52:02 | <djazayeri> just check out metadatasharing/trunk from svn and build it? |
| 20:52:11 | <rafa> right |
| 20:52:19 | <rafa> it's in trunk |
| 20:52:33 | <rafa> should be version 0.9 |
| 21:00:02 | <wluyima> hey |
| 21:00:27 | <wluyima> djazayeri, why shouldn't i mention standalone |
| 21:00:31 | <wluyima> in the warnings |
| 21:00:47 | <djazayeri> I mean move the "warning" about standalone into the text above warnings |
| 21:01:26 | <djazayeri> i.e. the text I include there describes the warning. I just this it's sufficient to mention that in the Background. |
| 21:01:44 | *** cta_ has joined #openmrs-sprint |
| 21:01:54 | <wluyima> ok |
| 21:03:20 | <wluyima> djazayeri, i have added the username and password for admin to the readme file and added another warning for users to change it immediately upon installation |
| 21:03:47 | *** cta_ has quit IRC |
| 21:04:17 | *** cta has quit IRC |
| 21:04:18 | <djazayeri> I approve |
| 21:04:59 | *** cta has joined #openmrs-sprint |
| 21:10:18 | <rafa> djazayeri: one thing: importing forms doesn't work right now. the htmlform class needs to be changed to new requirements. |
| 21:11:23 | *** cta has quit IRC |
| 21:15:11 | *** cta has joined #openmrs-sprint |
| 21:16:03 | *** burke has quit IRC |
| 21:17:45 | <djazayeri> rafa: okay, what are the requirements, in short? |
| 21:18:03 | <cta> djazayeri: Darius, for testing getOrderables I had to create own separate dataset. Is it good? |
| 21:18:22 | <djazayeri> cta: probably. I assume that standardTestDataset has no concepts with class=Drug |
| 21:19:02 | <cta> I added 3 concepts (2 with class drug) into new dataset |
| 21:19:35 | <djazayeri> that sounds good |
| 21:19:41 | <rafa> djazayeri: there's a new saveReplace method with the following signature T saveReplace(Map<OpenmrsObject, OpenmrsObject> mappings); |
| 21:19:52 | <djazayeri> rafa: oh, right, for the replacements. |
| 21:20:09 | <cta> and wrote 2 unit tests : one for normal situation, another for checking failures when null parameter is passed |
| 21:20:11 | <djazayeri> Can you make it so that it also works with the old saveReplace method? |
| 21:20:25 | <rafa> djazayeri: I've left the old saveReplace, but if you call that, you won't get any mappings |
| 21:20:28 | <djazayeri> or is it dangerous to let old modules keep working |
| 21:21:12 | <djazayeri> cta: okay, did you use the Amoxicillin example for the data? |
| 21:21:24 | <cta> yep |
| 21:21:29 | <djazayeri> good |
| 21:21:32 | <cta> how you know? |
| 21:22:01 | <cta> it is impossible)) |
| 21:22:12 | <rafa> guys see you tomorrow! |
| 21:22:29 | <djazayeri> bye rafa I'll take a look at the module later today |
| 21:23:00 | <rafa> djazayeri: okay just let me know what to do tomorrow or else I decide on my own ;) |
| 21:23:25 | <cta> djazayeri: I used Ampicillin and Amoxicillin for data examples |
| 21:24:01 | <djazayeri> rafa: if I don't say anything else, improve the UI. |
| 21:24:05 | <djazayeri> cta: cool |
| 21:24:40 | <cta> djazayeri: and also going to use Epicillin for cover all sutiation, but it is not so important |
| 21:25:51 | <djazayeri> cta: I vote for moving quickly and attaching another patch, rather than covering all the failure cases |
| 21:26:29 | <cta> djazayeri: give me just a 5 minutes |
| 21:27:06 | <djazayeri> np |
| 21:40:31 | <cta> djazayeri: I added patch for 2357. What is next? 2358? |
| 21:40:43 | <djazayeri> cta, did you fix 2356? |
| 21:41:01 | <cta> what exactly? |
| 21:42:20 | <djazayeri> abstract class needs properties for concept, name, and desccription. |
| 21:42:26 | <djazayeri> see ticket comment |
| 21:42:52 | <cta> djazayeri: Yes, I added abstract class. Haven't you see the patch? I added patch and did everything as you advised. |
| 21:43:55 | <djazayeri> the abstract class needs to have: protected Concept concept; protected String name; ... |
| 21:44:09 | <cta> djazayeri: may be I understand something wrong? please, don't let me be misunderstood |
| 21:44:22 | <cta> o! |
| 21:44:31 | <djazayeri> Or did you change things in the patch on 2357? |
| 21:44:36 | <cta> that is wright |
| 21:46:11 | <djazayeri> I mean that the BaseOrderable should actually have properties for all those three fields. Got it? |
| 21:47:13 | <cta> yep, but I didn't comment them yet |
| 21:49:01 | <cta> djazayeri: What about getName and getDescription. Are they implemented correctly for BaseOrderable? |
| 21:49:25 | <djazayeri> no, actually |
| 21:50:10 | <djazayeri> getName should be: if (name != null) return name; else if (concept != null) return concept.getName().getName(); else return null; |
| 21:50:17 | <djazayeri> same pattern for getDescription |
| 21:50:22 | *** wluyima has quit IRC |
| 21:50:37 | <cta> djazayeri: thanx |
| 21:56:33 | *** wluyima has joined #openmrs-sprint |
| 21:56:33 | *** wluyima has quit IRC |
| 21:56:50 | *** wyclif has joined #openmrs-sprint |
| 21:57:33 | <cta> djazayeri: I just added a new patch that completely fixes 2356. |
| 21:57:45 | <djazayeri> great, I just commented on 2357 asking for one fix |
| 21:57:54 | <cta> ok |
| 21:58:20 | <djazayeri> I'm going to apply 2356 (and make a minor comment to your javadoc). 2358 can be next, yes. |
| 21:59:25 | <cta> ok, I'll rename dataSet for 2357, add patch and next will be moving to 2358 |
| 22:01:08 | <wyclif> djazayeri, how comes the core dataset had horatio's data |
| 22:01:17 | <djazayeri> core dataset where? |
| 22:01:50 | <wyclif> because when i look at the zip daniel created, and i search for hor, |
| 22:02:04 | <wyclif> i find are record in the core data standalone |
| 22:03:06 | <djazayeri> sounds like dkayiwa gave you the wrong database as "core" |
| 22:03:19 | <djazayeri> the core dataset should have zero concepts. check that. |
| 22:05:22 | <djazayeri> cta: are you using eclipse? |
| 22:05:57 | <cta> djazayeri: yes, what is wrong? |
| 22:06:09 | <djazayeri> can you do the patches off of the root project? |
| 22:06:20 | <downeym> wyclif: here it is again - https://slashtmp.iu.edu/files/download?FILE=mjdowney%2F93104g5r4W -- openmrs-standalone-1.8.0-with-no-data.zip, 137.3 MB |
| 22:06:47 | <djazayeri> cta: looking at the patch on 2356 I see the first file is Index: src/main/java/org/openmrs/BaseOrderable.java |
| 22:06:59 | <cta> djazayeri: strange I did them out of root |
| 22:07:00 | <djazayeri> I assume that's on the api sub-project |
| 22:07:11 | <djazayeri> It's okay, I don't need you to change them. |
| 22:07:39 | <djazayeri> It's obvious enough to figure out. Just check next time to (try to) make sure it's off the parent project |
| 22:08:13 | <cta> ok |
| 22:09:18 | <cta> djazayeri: so, Will you fix it by yourself? |
| 22:09:27 | <djazayeri> yes |
| 22:09:28 | <djazayeri> no worries |
| 22:09:38 | <cta> djazayeri: thank you |
| 22:09:42 | *** rafa has quit IRC |
| 22:09:49 | <djazayeri> wyclif: by the way, that time you sent me a standalone zip, it included some log files from your computer |
| 22:10:14 | <djazayeri> probably that was random, but you should check to make sure you're not distributing that under tomcat/logs. |
| 22:10:19 | <wyclif> tomcat log? |
| 22:10:30 | <wyclif> am going to remove them |
| 22:11:40 | <djazayeri> Yes, if I "grep wyclif standalone/tomcat/logs/*" (from the zip you sent me) I find some hits. So do remove tomcat/logs |
| 22:12:02 | <downeym> yeah the /home/wyclif logs are back from yesterday :D |
| 22:12:40 | <wyclif> am going to just delete them |
| 22:12:50 | <wyclif> just before upoading the files |
| 22:13:00 | <wyclif> because each time i run the app, it creates them |
| 22:13:17 | <djazayeri> cool |
| 22:14:20 | <downeym> wyclif: make sure it's shut down first before deleting them. :) |
| 22:18:09 | <wyclif> actually the archive dont have them |
| 22:24:38 | <cta> djazayeri: I have small question about 2358. Is it goes that we will use _query_ (passed into getOrderables method) for retrieving concepts and drugs both? |
| 22:25:29 | <djazayeri> cta: eventually we're going to have some more sophisticated mechanism where core can do some searching, and modules can also register themselves to search for orderables too. |
| 22:25:51 | <cta> ou |
| 22:25:55 | <djazayeri> But for now, we're starting with a simple implementation that will search both Concept and Drug and return all results from either of them. |
| 22:26:11 | <djazayeri> what you're doing now is a placeholder implementation. |
| 22:26:19 | <cta> ok |
| 22:27:04 | <djazayeri> cta, the patch for 2357 is not applying cleanly |
| 22:27:11 | <djazayeri> can you do an svn update and re-create the patch? |
| 22:27:29 | <cta> of course I can |
| 22:27:40 | <cta> wait a minute |
| 22:36:41 | <cta> djazayeri: I've updated project and recreated patch off root of project, see new patch attached to ticket |
| 22:42:56 | <djazayeri> okay, cta, i'll look at that in a sec |
| 22:52:09 | <djazayeri> cta: did you do an svn update on that? |
| 22:52:20 | <djazayeri> I'm getting 3 files that show merge errors |
| 22:52:24 | <cta> yes I did, to head |
| 22:52:33 | <djazayeri> oh, wait, nm, I didn't apply to root |
| 22:52:45 | <djazayeri> perfect, thanks |
| 22:53:02 | <cta> no problem |
| 23:07:04 | <cta> djazayeri: Darius, I think that I'll add patch for 2358 tomorrow, because now 2 AM in Ukraine and I need shuteye. May be you have any questions before I off? |
| 23:10:57 | <djazayeri> cta: no questions, good work! |
| 23:11:27 | <cta> djazayeri: thanx, good night |
| 23:11:35 | *** cta has quit IRC |
| 23:20:34 | <wyclif> djazayeri, just curious, if i remove the war file from tomcat, are you aware of any short comings? |
| 23:20:54 | <wyclif> i know Ben thinks tomcat might undeploy the app |
| 23:21:05 | <wyclif> but i doubt |
| 23:21:56 | <wyclif> apparently on windows the war file is not getting extracted in the standalone unless i include the extracted folder |
| 23:22:48 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/nb2otvOsavg/OpenMRS> || New Changeset: OpenMRS (order-entry): create Orderable interface - TRUNK-2356... <http://feedproxy.google.com/~r/OMRStrunk/~3/bHAGFaEtRgE/OpenMRS> || New Changeset: OpenMRS (order-entry): formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/e5pajDm6rMs/OpenMRS> |
| 23:23:45 | <downeym> as long as you make sure tomcat is not running when it's removed |
| 23:25:17 | <downeym> wyclif: what is the behavior in windows |
| 23:25:56 | <downeym> ? |
| 23:26:24 | <wyclif> the standalone is failing on windows now |
| 23:26:34 | <wyclif> the contextpath is null |
| 23:26:52 | <downeym> is there a context.xml? |
| 23:26:54 | <wyclif> still trying to figure out the work around |
| 23:26:57 | <wyclif> yeah' |
| 23:27:02 | <wyclif> and it is null |
| 23:27:12 | <wyclif> sorry, it has no doc base |
| 23:27:18 | <downeym> hm |
| 23:27:22 | <wyclif> i guess this is why it is null |
| 23:27:25 | <djazayeri> hmm |
| 23:27:38 | <downeym> well the way it is now, the war file has not been extracted within the zip |
| 23:27:41 | <downeym> so that has to be done first |
| 23:29:43 | <wyclif> so i have to copy over the context.xml file |
| 23:29:50 | <downeym> let me shut it down |
| 23:30:06 | <downeym> remove war file, start again |
| 23:31:03 | <downeym> started up and working ok (i guess) without war file |
| 23:31:15 | <downeym> but webapps/openmrs-standalone has to exist |
| 23:31:30 | <downeym> which requires that first startup |
| 23:54:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): Expose concepts with class=Drug as Orderables - TRUNK-2357... <http://feedproxy.google.com/~r/OMRStrunk/~3/sv0ewB3P4RE/OpenMRS> |