00:18:45
|
<wyclif> djazayeri, the stacktrace you emailed was helpful
|
00:18:51
|
<djazayeri> good
|
00:18:55
|
<wyclif> so that is the main reason we gave up
|
00:19:17
|
<wyclif> but funny enough it works fine on ubuntu
|
00:19:20
|
<wyclif> and windows
|
00:19:39
|
<wyclif> it worked for mac when Daniel created it
|
00:19:58
|
<wyclif> so i guess he knows the small bit we missing
|
00:20:29
|
<wyclif> we could get that stacktrace on michael's machine
|
00:20:45
|
<wyclif> i have looking at RESTWS-141, i added a comment
|
00:22:16
|
<wyclif> and i think it closely related with the way are handling conversion of some types
|
00:22:24
|
<djazayeri> Okay, I'm planning to take a look at that now.
|
00:22:33
|
<djazayeri> I saw your comment.
|
00:22:43
|
<wyclif> but i think it is doable
|
00:23:05
|
<wyclif> am testing concept with concept names and i think it might be the same case
|
00:23:39
|
<djazayeri> So, note that I avoided this problem with person/patient and personname
|
00:23:44
|
<djazayeri> (and address, and identifier)
|
00:24:06
|
<djazayeri> by having a "preferredName" property that's used when creating
|
00:24:40
|
<djazayeri> i.e. when you create a patient you can specify one "preferredName", but you can't specify "names"
|
00:24:56
|
<djazayeri> That trick should work with Concept and ConceptName.
|
00:25:11
|
<djazayeri> But not with Encounter and Obs, because you do need to be able to create many obs.
|
00:27:11
|
<wyclif> am trying to think of way to get around it
|
00:27:18
|
<djazayeri> for which?
|
00:27:21
|
<wyclif> but i understand what you mean
|
00:27:36
|
<wyclif> creating an enccounter with obs
|
00:28:10
|
<djazayeri> I don't mind taking over that ticket for now, if you're getting to the end of your day
|
00:28:17
|
<djazayeri> and you can switch to the concept one?
|
00:39:54
|
<djazayeri> wyclif: ^^
|
00:40:09
|
<djazayeri> (depends how much later you plan to work today)
|
00:40:32
|
<wyclif> extra reserach is telling me the concept names or obs are getting sent to the API as SimpleObjects and
|
00:40:45
|
<wyclif> bceause the conversion logic is ignoring them
|
00:41:01
|
<wyclif> am basically done till tomorrow
|
00:41:17
|
<djazayeri> do they have converters that are being ignored? or are we missing the converters?
|
00:46:17
|
<wyclif> well i think the solution is around line 281 in BaseDelegatingResouce
|
00:47:23
|
<wyclif> if we get that far, we need to add extra logic to handle them
|
00:50:22
|
<wyclif> i think we need work on the logic after line 281 to be smarter than just setting a value of type SimpleObject
|
00:52:24
|
<wyclif> i think we need a smart generic converter for collections when json is coming in
|
00:52:40
|
<wyclif> talk to you later
|
00:52:47
|
<djazayeri> bye, i'll take a look at that now
|
01:09:33
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (order-entry): creating order-entry branch for next week's sprint <http://feedproxy.google.com/~r/OMRStrunk/~3/Rm40xRKckkI/OpenMRS>
|
02:50:41
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @djazayeri: First #OpenMRS sprint on Order Entry starts on Monday! Sign up at https://wiki.openmrs.org/x/moImAQ to participate. <http://twitter.com/OpenMRS/statuses/81905916269699072>
|
06:03:50
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: installation exception <http://forum.openmrs.org/viewtopic.php?f=8&t=785#p2982>
|
06:34:04
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Refactor : Changing name from 'DomainObjectHandler' to 'CustomDatatypeHandler' <http://feedproxy.google.com/~r/OMRStrunk/~3/blVYr3TKdCw/OpenMRS>
|
11:17:15
|
*** rafa has joined #openmrs-sprint
|
11:17:15
|
*** ChanServ sets mode: +v rafa
|
13:33:20
|
*** wluyima has joined #openmrs-sprint
|
13:33:20
|
*** wyclif has quit IRC
|
18:42:36
|
*** dkayiwa has joined #openmrs-sprint
|
19:07:32
|
<dkayiwa> hi wyclif
|
19:08:08
|
<dkayiwa> hi wluyima
|
19:45:36
|
*** rafa has quit IRC
|
20:13:16
|
*** dkayiwa has quit IRC
|
21:38:44
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): Changed attributes for Person, PersonAttribute and PersonAttributeType <http://feedproxy.google.com/~r/OMRStrunk/~3/2waZ2fFmbnY/OpenMRS>
|
23:20:47
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): Changed attributes for Person, PersonAttribute and PersonAttributeType <http://feedproxy.google.com/~r/OMRStrunk/~3/GbDxW93lYSY/OpenMRS>
|