| 00:51:54 | *** deadpool has joined #openmrs |
| 01:12:33 | <deadpool> djazayeri: uhhh how do i get jquery to work in my module. I followed the example online and it didn't work |
| 01:12:56 | <djazayeri> deadpool: more info please |
| 01:13:20 | <deadpool> i followed this https://wiki.openmrs.org/display/archive/Intro+to+JQuery+Framework |
| 01:13:26 | <OpenMRSBot> <http://ln-s.net/8uM4> (at wiki.openmrs.org) |
| 01:14:01 | <deadpool> i am trying to use the datepicker |
| 01:19:16 | <deadpool> djazayeri: do i have to include jquery in my resources under web/module/resources? |
| 01:19:34 | <djazayeri> deadpool: what version of openmrs are you using? |
| 01:19:47 | <djazayeri> You don't need to include jquery in your resources |
| 01:20:02 | <deadpool> djazayeri: i am using 1.9 |
| 01:20:05 | <djazayeri> it's included with OpenMRS. |
| 01:20:22 | <djazayeri> As of 1.7 it's automatically included via the headerFull.jsp |
| 01:20:29 | <deadpool> so i assume it is not 1.3 then? |
| 01:21:47 | <djazayeri> Looksi like it was 1.3.2 in OpenMRS 1.6 |
| 01:21:50 | <deadpool> so do i still follow the website? |
| 01:22:36 | <djazayeri> That page is old. Note that it's on our "archive" wiki. |
| 01:22:58 | <deadpool> yeah but that is what i got pointed to when i was looking for jquery |
| 01:22:59 | <djazayeri> You should just be able to do $j(â¦) on a script on a page, and it should jsut work |
| 01:23:11 | <deadpool> so no include then |
| 01:23:32 | <djazayeri> correct, no include |
| 01:23:44 | <djazayeri> (it happens automatically if you include header.jsp |
| 01:28:36 | <deadpool> djazayeri: allright got rid of it and still not working i did this http://pastebin.com/nrjLTZiG |
| 01:28:55 | <deadpool> where do i put the $j in that code i tried different places but it comes to no avail |
| 01:29:09 | <djazayeri> you don't need to do the $j = jQuery.noConflict() line either |
| 01:29:18 | <djazayeri> The problem is that you're not actually using jquery in no-conflict mode |
| 01:29:43 | <djazayeri> You need to change line 11 and 12 by replacing $ with $j |
| 01:30:14 | <djazayeri> Basically jQuery defaults to registering itself to $. |
| 01:30:41 | <djazayeri> But since jQuery and Dojo both co-exist in OpenMRS, we left $ with dojo, and put jQuery in no-conflict mode, so you can say: |
| 01:30:56 | <djazayeri> $j('div').show(); |
| 01:31:02 | <djazayeri> or jQuery('div').show(); |
| 01:31:03 | <djazayeri> or whateer |
| 01:32:41 | *** dlawson has quit IRC |
| 01:35:17 | <deadpool> djazayeri: uhh where would i put that $j('div').show(); |
| 01:36:29 | <djazayeri> try http://pastebin.com/AgBrLcbU |
| 01:37:09 | <djazayeri> I mean, any snippet of jquery code needs to use $j instead of just $ |
| 01:39:15 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting Fix for EncounterService.getCountOfEncounters() - TRUNK-2332 <http://feedproxy.google.com/~r/OMRStrunk/~3/EfsL_fAtKo8/OpenMRS> || New Changeset: OpenMRS (webapp-testing): Merging trunk to webapp-testing rev:20672 <http://feedproxy.google.com/~r/OMRStrunk/~3/4asMNmtzS8A/OpenMRS> |
| 01:39:25 | <deadpool> djazayeri: thanks a bunch that worked |
| 01:39:34 | <djazayeri> np |
| 01:41:06 | <deadpool> djazayeri: one quick question? sorry. what is the way to make datepicker use the current locale which is set in openmrs |
| 01:43:09 | <djazayeri> the old way of doing things was: |
| 01:43:10 | <djazayeri> <input type="text" id="enrollmentDateElement" size="10" onClick="showCalendar(this)" /> |
| 01:43:32 | <djazayeri> That ought to still work, as a standard date picker |
| 01:44:05 | <djazayeri> see the example in activeListAllergy.jsp for a more complex newer example |
| 01:47:00 | <deadpool> djazayeri: cool thanks for the help |
| 01:55:10 | *** deadpool has quit IRC |
| 01:55:30 | *** deadpool has joined #openmrs |
| 02:57:01 | *** surangak has joined #openmrs |
| 03:08:45 | <surangak> djazayeri, hi, r u around.... |
| 03:09:07 | <djazayeri> surangak: yes |
| 03:09:32 | <surangak> djazayeri, i was planning on starting on the web layer handlers soon |
| 03:10:25 | <surangak> djazayeri, how much longer will u be around today, i need to read up everything before i can engage in an inteligent converation :P |
| 03:10:36 | <surangak> djazayeri, regarding my potential design... |
| 03:11:07 | <djazayeri> I'm going to cook dinner and eat now |
| 03:11:13 | <djazayeri> I will be occasionally at my computer |
| 03:12:04 | <surangak> djazayeri, sure no probs, i'll get back to you.. or maybe i'll jot dont my queries in point form and come back later.... |
| 03:12:30 | <surangak> umm.. quick question though, right now, i need a to be thinkin of a web layer right ? |
| 03:13:00 | <surangak> djazayeri, i may have to change design significantly because my stducture is somewhat different |
| 03:13:48 | <surangak> djazayeri, but basically, an api layer handlers and matching web layer (with firldgen attributes like you pointed out last time) are nessesary , isnt it |
| 03:14:43 | <djazayeri> well, you do need both layers |
| 03:14:48 | <djazayeri> it's tricky |
| 03:15:14 | <djazayeri> The way I did it with attribute handlers is to make an API-layer interface and a web-layer interface |
| 03:15:37 | <djazayeri> and then typically an implementation of handler would have a class in the api layer, and a class that extends it in the web layer |
| 03:15:46 | <djazayeri> I don't know if you need the same complexity or not |
| 03:15:50 | <djazayeri> (probably do) |
| 03:16:25 | <surangak> hmm.. in my case, im wondering if adding generics is overkill |
| 03:16:33 | <surangak> since im having only one specific instance |
| 03:16:53 | <surangak> vs in your case, you had multiple instances of multiple types, as i remember... |
| 03:17:08 | <surangak> but, adding such a large number of classes is ok, is it ? |
| 03:17:40 | <djazayeri> if they're necessary it's okay to add them. |
| 03:22:08 | *** jportela has quit IRC |
| 03:26:04 | *** gbastien has quit IRC |
| 03:28:36 | *** mccallumg has joined #openmrs |
| 03:28:36 | *** ChanServ sets mode: +v mccallumg |
| 03:28:50 | <mccallumg> hi surangak |
| 03:28:59 | <surangak> surangak, howdy |
| 03:29:58 | <surangak> im just about finalizing the stuff to store patients, that part works ok... |
| 03:30:34 | <surangak> id say about 70% of the code is generalized enough to match the other handlers too |
| 03:30:46 | <mccallumg> what about the response on the list to the design question? Is that clear? |
| 03:31:55 | <surangak> mmm.. well actually it has raised more questions :) |
| 03:32:15 | <surangak> not really, its like this... currently the handlers are in my api layer |
| 03:32:33 | <surangak> so we can have that working fine, |
| 03:33:12 | <surangak> but as a better solution, we will need to impliment a new set of |
| 03:33:19 | <surangak> handler classes in the web layer |
| 03:33:26 | <surangak> following darius's pattern |
| 03:33:40 | <surangak> the web layer will extend the api layer handlers |
| 03:34:06 | <surangak> the basic idea is that the web layer handlers will be the ones that say 'use fieldGen to display a list here' |
| 03:34:11 | <surangak> or |
| 03:34:16 | <mccallumg> so was this close to the option you suggested of writing to fieldgen classes? |
| 03:34:25 | <mccallumg> _new_ |
| 03:34:31 | <surangak> alternatively, dont use fieldGen, use another one |
| 03:35:02 | <surangak> hmm.. rigght now it looks like we will be using the existing fieldGen, and handling errors via jsp |
| 03:35:19 | <surangak> and leaving the fledGen as it is.... for now :) |
| 03:35:55 | <mccallumg> so you're clear on next steps? |
| 03:35:59 | <surangak> the web layer will let us handler other methods, as opposed to fieldGen... |
| 03:36:13 | <surangak> hm... well i know what has to be done :P |
| 03:36:36 | <surangak> it will take some designing, to see how much of the existing pattern i can follow... |
| 03:36:47 | <mccallumg> yeah. that makes sense |
| 03:37:06 | <mccallumg> I'm around in the evenings this week too. |
| 03:37:15 | <mccallumg> (if that is any help ...) |
| 03:37:33 | <surangak> im going to commit the patient storing stuff today, and will send u guys an email on test data etc. |
| 03:37:40 | <surangak> aha, that'll be good |
| 03:37:53 | <surangak> umm.. by evening u mean this time right ? |
| 03:38:02 | <mccallumg> right. my evening |
| 03:38:39 | <surangak> right now im really worried about the design of the obs class :D |
| 03:39:02 | <surangak> as in, i have made some minor changes, to support my design, |
| 03:39:47 | <surangak> so i was thinking, commit that, and let the technical people review that, and while they do that maybe i could look at the web layer stuff... |
| 03:39:51 | <surangak> what do u think ? |
| 03:40:13 | *** dkayiwa has joined #openmrs |
| 03:40:35 | <mccallumg> that's a good idea. |
| 03:41:40 | *** mandric has joined #openmrs |
| 03:41:43 | <surangak> still not very sure how its done though.. :P |
| 03:41:58 | <mccallumg> but really that should have been clear in the db changes (reflected in the object model) |
| 03:42:20 | *** dlawson has joined #openmrs |
| 03:42:20 | *** ChanServ sets mode: +v dlawson |
| 03:42:43 | *** gauravpaliwal has joined #openmrs |
| 03:42:43 | *** ChanServ sets mode: +v gauravpaliwal |
| 03:42:53 | *** deadpool has quit IRC |
| 03:42:54 | <surangak> aha, u mean the changes to the obs class right ? |
| 03:42:59 | <mccallumg> yes |
| 03:43:35 | <mccallumg> there is a code review feature in the dev tools |
| 03:44:13 | <surangak> mmmm.... u mean I should request a design review ? |
| 03:44:31 | <mccallumg> No this is different: https://wiki.openmrs.org/display/docs/Code+Review |
| 03:44:38 | <OpenMRSBot> <http://ln-s.net/8uMx> (at wiki.openmrs.org) |
| 03:44:57 | <mccallumg> but there is quite a queue: https://tickets.openmrs.org/secure/IssueNavigator.jspa?mode=hide&requestId=10080 |
| 03:45:01 | <OpenMRSBot> <http://ln-s.net/8uMy> (at tickets.openmrs.org) |
| 03:45:02 | <surangak> oh, sorry |
| 03:45:06 | <mccallumg> maybe a design review would be simpler |
| 03:45:38 | <surangak> in my case since there are no changes to the db level, |
| 03:46:03 | <gauravpaliwal> Hi mccallumg |
| 03:46:17 | <mccallumg> hi gauravpaliwal |
| 03:46:41 | <surangak> unless the stuff that is geting stored in one column.. [first name] [middlename] [lastname] [id] |
| 03:47:14 | <mccallumg> unlikely |
| 03:47:27 | <gauravpaliwal> mccallumg : just wanted to know does I need to manually add the setuuid function before saving object incase of mysql |
| 03:48:20 | <gauravpaliwal> mccallumg : without explicitly calling uuid it is saving null values |
| 03:48:40 | <gauravpaliwal> i am extending BaseOpenmrsObject class |
| 03:48:40 | <mccallumg> gauravpaliwal: I believe that mysql should handle uuids with built in functionality. Can someone else confirm that? djazayeri |
| 03:49:46 | <surangak> he will be back soon i think... |
| 03:51:34 | <mccallumg> let's ask robbyoconnor |
| 03:53:13 | <surangak> mccallumg, in my case, the domain objects are storing ok, |
| 03:53:31 | <surangak> mccallumg, retire and delete functionality r also ok... |
| 03:53:46 | <surangak> mccallumg, but need to figure out the edit .. |
| 03:53:52 | <mccallumg> good |
| 03:54:10 | <surangak> mccallumg, that is still not working because of some retreival problems |
| 03:54:26 | <mccallumg> ok |
| 03:55:04 | <surangak> as in, when storing domain objects, basically im passing around an int id... so need to write up some better retrival stuff |
| 03:58:14 | <surangak> mccallumg, right now im rather upset that things have been moving rather slowly... |
| 03:58:46 | <mccallumg> surangak: you're making progress. that is sufficient for now. |
| 03:59:19 | <surangak> hopefully we should pick up speed soon :P |
| 03:59:46 | <mccallumg> once the design is solidified and proven then things will pick up |
| 04:00:19 | <robbyoconnor> mccallumg: it does I THINK |
| 04:00:32 | <robbyoconnor> mccallumg: the UUID was being set by the handler iirc |
| 04:00:48 | <robbyoconnor> but I haven't touched mysql or openmrs in a LONG time |
| 04:01:00 | <surangak> mccallumg, will u be around tomorrow morning your time ? |
| 04:01:03 | <djazayeri> gauravpaliwal: the idea is that we have automatic SaveHandlers that will set a uuid |
| 04:01:06 | <robbyoconnor> I haven't even coded in java in MONTHS |
| 04:01:24 | <mccallumg> surangak: I can be. |
| 04:01:25 | <djazayeri> They're a bit magical (in a bad way) |
| 04:01:45 | <robbyoconnor> springs aop is black magic. |
| 04:01:54 | <mccallumg> robbyoconnor: are you done school now? |
| 04:01:56 | *** goutham has joined #openmrs |
| 04:02:04 | <surangak> mccallumg, i was thinking by that time i could probably do the commits... |
| 04:02:09 | <djazayeri> surangak: I second mccallumg's suggestion that you request code review on some early code |
| 04:02:11 | <robbyoconnor> mccallumg: just my associates -- start my BA in Aug |
| 04:02:27 | <robbyoconnor> yeh school i'm going to gives BAs for Computer Science |
| 04:02:31 | <gauravpaliwal> djazayeri: you mean a bad configuration of https://wiki.openmrs.org/display/docs/API+Save+Handlers *may* lead to trouble |
| 04:02:36 | <OpenMRSBot> <http://ln-s.net/8uN0> (at wiki.openmrs.org) |
| 04:02:39 | <surangak> djazayeri, mccallumg good idea :) |
| 04:02:51 | <djazayeri> surangak: we can do a superficial code review and make some suggestions |
| 04:02:59 | <djazayeri> gauravpaliwal: you shouldn't have to configure anything |
| 04:03:15 | <surangak> how can i make a review request please ? |
| 04:03:33 | <mccallumg> surangak: you have to use the ticket tools |
| 04:03:39 | <djazayeri> gauravpaliwal: basically if you are saving something that implements OpenmrsObject via a service method whose name starts with "save" the uuid should be automatically set |
| 04:04:00 | <mccallumg> surangak: crucible |
| 04:04:00 | <gauravpaliwal> surangak : use crcuible interface. |
| 04:04:03 | <djazayeri> e.g. conceptService.saveConcept(new Concept()) would work |
| 04:04:21 | <surangak> aha, thanks guys, will do |
| 04:04:21 | <djazayeri> (I mean, it would assign a uuid, although it would obviously fail because the concept has some other required fields) |
| 04:04:43 | <djazayeri> surangak: for a "superficial" review you can attach a patch to a ticket and click request code review. |
| 04:05:00 | <gauravpaliwal> djazayeri : i am doing it but looks like i am doing some typo error |
| 04:05:03 | <djazayeri> Though I guess creating a review in crucible isn't much harder |
| 04:05:20 | <djazayeri> gauravpaliwal: in core or in a module? |
| 04:05:28 | <djazayeri> what domain object are you saving? |
| 04:05:46 | <gauravpaliwal> djazayeri: module |
| 04:05:48 | <robbyoconnor> how's GSoC coming along? |
| 04:06:09 | <surangak> djazayeri, umm.. so i need to attach a patch of my entire branch, isnt it ? |
| 04:06:24 | <djazayeri> no, don't do that |
| 04:06:27 | <djazayeri> use crucible then |
| 04:06:42 | <djazayeri> you can create a code review there and choose the content that goes in it. |
| 04:06:52 | <surangak> will do... |
| 04:07:11 | <surangak> robbyoconnor, as you can see, its rather hectic :P |
| 04:07:37 | <mccallumg> robbyoconnor: gsoc is going really well. my student is making good progress. |
| 04:09:24 | <robbyoconnor> surangak: welcome to GSoC |
| 04:09:33 | <djazayeri> gauravpaliwal: a service you wrote in your module? |
| 04:09:35 | <robbyoconnor> this is why I didn't do it |
| 04:09:38 | <robbyoconnor> I didn't want hectic -- I wanted laid back :) |
| 04:09:42 | <gauravpaliwal> yes |
| 04:09:59 | <robbyoconnor> gsoc can be what you make of it |
| 04:10:03 | <gauravpaliwal> and the object is saving without any problem if i manually do a set Uuid |
| 04:10:12 | <surangak> mccallumg, hopefully :P anyway right now im realy desperate to end my project successfully... I just got interviwed by a local magazine regading Gsoc, so if i crash it'll be terribly embarasing :P |
| 04:10:12 | <gauravpaliwal> djazayeri : the error is here : http://pastebin.com/KiL7zRE3 which means UUID is Null |
| 04:10:23 | <surangak> they even took a protograph :( |
| 04:10:40 | *** dkayiwa has quit IRC |
| 04:10:46 | <robbyoconnor> surangak: I interviewed in 2008 for Viacom (mtvU division) |
| 04:10:57 | <robbyoconnor> my GSoC at the time was my one bargaining chip |
| 04:11:06 | <robbyoconnor> that code is in the cemetary |
| 04:11:37 | <gauravpaliwal> djazayeri : service method is public class Severity extends BaseOpenmrsObject |
| 04:11:39 | <robbyoconnor> it's *DEAD* and never was finished htmlformentry made it unneeded so I gave up |
| 04:11:45 | <robbyoconnor> it's* |
| 04:12:17 | <robbyoconnor> surangak: don't feel bad if it *DOES* flounder --learn from it -- stick around, brush yourself off and reboot |
| 04:12:17 | <gauravpaliwal> and in Severity.hbm.xml ir is <property name="uuid" type="string" length="38" not-null="true" /> |
| 04:12:31 | <djazayeri> gauravpaliwal: do have you written other FeebackService methods that have worked with other domain objects? |
| 04:12:49 | <djazayeri> in the moduleApplicationContext.xml are you wrapping "serviceInterceptors" around your service? |
| 04:13:12 | <surangak> robbyoconnor, hmmm.. i think i should do ok :P |
| 04:13:18 | <robbyoconnor> you'll be fine |
| 04:13:30 | <robbyoconnor> Hopefully *ALL* GSoC students succeed |
| 04:13:40 | <mccallumg> robbyoconnor: are you doing gsoc this summer? |
| 04:13:53 | <gauravpaliwal> djazayeri: http://pastebin.com/scVXCG3r context is here |
| 04:13:57 | <robbyoconnor> mccallumg: no -- I wanted to be laid back |
| 04:14:07 | <robbyoconnor> plus I technically wasn't matriculated into a degree program |
| 04:14:26 | <robbyoconnor> I graduated and was retaking calc 2 over again |
| 04:14:26 | <gauravpaliwal> djazayeri: the object is saving without any problem untill and unless i try to save UUID which is NULL |
| 04:14:56 | <surangak> mccallumg, im syncronizing my branch now, so should be able to comitt soon..... |
| 04:15:33 | <djazayeri> gauravpaliwal: the problem is that in your moduleApplicationContext.xml in the preInterceptors section associated with FeedbackService you are only setting up one of the 3 interceptors we use |
| 04:15:33 | <surangak> mccallumg, once thats done, its back to 'design iteration with me, to think of web handlers... |
| 04:16:09 | <surangak> mccallumg, iah i had writen the code to add a new column to the db (handler_config) should i commit that, or wait for new developments :) |
| 04:16:11 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating changes to WebModuleUtil and ModuleFilterMapping which had been left out while merging with trunk <http://feedproxy.google.com/~r/OMRStrunk/~3/Z0qZPn49MmU/OpenMRS> |
| 04:16:12 | <djazayeri> you want this: <property name="preInterceptors"> |
| 04:16:12 | <djazayeri> <ref bean="serviceInterceptors"/> <!-- handles common metadata fields --> |
| 04:16:12 | <djazayeri> </property> |
| 04:16:40 | <mccallumg> surangak: well. if you're doing a crucible review ... i think it needs to be in the repository doesn't it? |
| 04:16:52 | <mccallumg> (maybe I'm wrong) |
| 04:17:11 | <mccallumg> (i haven't used crucible) |
| 04:17:50 | <surangak> mccallumg, yeps, but right now the table column is not part of the working obs code... |
| 04:18:08 | <surangak> that is, its not nessesary to get the domain object stored for now... |
| 04:18:11 | <gauravpaliwal> djazayeri : thanks :) looks like it will be done now :) |
| 04:18:34 | <mccallumg> surangak: then I wouldn't worry about it until you add it to the code |
| 04:19:10 | <surangak> mccallumg, great, will do... |
| 04:19:19 | <mccallumg> surangak: wait. that didn't make sense. |
| 04:19:43 | <mccallumg> surangak: don't need to add it until it you're using it for the current functionality |
| 04:19:45 | <surangak> u mean not to add it until it is working joinly with the obs code, right |
| 04:19:49 | <surangak> aha yep.. |
| 04:20:13 | <mccallumg> surangak: ok. I'm signing out. talk to you tomorrow. |
| 04:20:37 | <surangak> sure, hopefuly by that time u will have some code, |
| 04:20:50 | <surangak> and an e mail to check out :) |
| 04:21:49 | *** mandric has quit IRC |
| 04:21:52 | *** mccallumg has quit IRC |
| 04:26:05 | <djazayeri> surangak: it's easiest to use crucible to review code that's been checked in, eys |
| 04:26:07 | <djazayeri> (yes) |
| 04:26:59 | <surangak> djazayeri, i havent really worked with crucide before, but let e give it a try... |
| 04:30:50 | <gauravpaliwal> surangak : I have recently used it for asked for code review of whole trunk , let me know if i can help |
| 04:31:54 | <surangak> gauravpaliwal, thanks for the offer Gaurau.. I'll get back to you when I hit my first problem :) |
| 04:32:18 | <gauravpaliwal> okeys np :) |
| 04:36:27 | <gauravpaliwal> djazayeri : thanks its working :) |
| 04:36:42 | *** goutham has quit IRC |
| 04:45:16 | *** bryq has joined #openmrs |
| 04:45:16 | *** ChanServ sets mode: +v bryq |
| 04:54:19 | *** goutham has joined #openmrs |
| 04:56:52 | *** bryq has quit IRC |
| 05:21:41 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting a fix to a bug where editing an existing encounter fails if it had no location set <http://feedproxy.google.com/~r/OMRStrunk/~3/xlrW19ujl64/OpenMRS> |
| 05:43:09 | *** pascal` has joined #openmrs |
| 05:50:39 | *** gauravpaliwal has left #openmrs |
| 05:51:42 | *** dkayiwa has joined #openmrs |
| 06:05:42 | *** pascal` has quit IRC |
| 06:09:05 | *** surangak_ has joined #openmrs |
| 06:09:05 | *** surangak has quit IRC |
| 06:20:18 | *** bwolfe has joined #openmrs |
| 06:20:18 | *** ChanServ sets mode: +o bwolfe |
| 06:20:58 | *** sreya has joined #openmrs |
| 06:21:29 | <sreya> hey all |
| 06:22:24 | <sreya> can anyone tell me that how do i create a table dynamically when my module is getting deployed |
| 06:29:22 | *** surangak__ has joined #openmrs |
| 06:29:34 | *** surangak_ has quit IRC |
| 06:46:39 | *** surangak__ has quit IRC |
| 07:01:45 | *** mathiaslin has joined #openmrs |
| 07:09:02 | *** pascal` has joined #openmrs |
| 07:26:06 | *** sreya has quit IRC |
| 07:28:58 | *** squidsoup has quit IRC |
| 07:31:55 | *** dkayiwa has quit IRC |
| 07:41:48 | *** ChanServ sets mode: +v pascal` |
| 08:01:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Reverting Back to 20492 <http://feedproxy.google.com/~r/OMRStrunk/~3/BC8vXTerjJA/OpenMRS> |
| 08:35:55 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating branch to Revision 20672 <http://feedproxy.google.com/~r/OMRStrunk/~3/GcngE0NUAuk/OpenMRS> || OpenMRS Forum: Re: OpenEMPI integration module <http://forum.openmrs.org/viewtopic.php?f=8&t=784#p2967> |
| 08:37:04 | *** gauravpaliwal has joined #openmrs |
| 08:37:04 | *** ChanServ sets mode: +v gauravpaliwal |
| 08:43:21 | *** bwolfe has quit IRC |
| 08:45:33 | *** mathiaslin has quit IRC |
| 08:45:50 | *** dlawson has quit IRC |
| 09:33:18 | *** rafa has joined #openmrs |
| 09:33:18 | *** ChanServ sets mode: +v rafa |
| 09:41:39 | <gauravpaliwal> pascal` |
| 09:41:42 | <gauravpaliwal> Hi |
| 09:42:00 | <gauravpaliwal> anyone there ? |
| 09:43:37 | *** gauravpaliwal has quit IRC |
| 09:49:20 | <pascal`> Well he didn't wait very long |
| 09:50:03 | *** dkayiwa has joined #openmrs |
| 10:01:50 | *** dkayiwa_ has joined #openmrs |
| 10:02:27 | *** dkayiwa has quit IRC |
| 10:02:27 | *** dkayiwa_ is now known as dkayiwa |
| 10:33:26 | *** dkayiwa has quit IRC |
| 11:16:15 | *** james_regen has joined #openmrs |
| 11:16:15 | *** ChanServ sets mode: +v james_regen |
| 11:22:06 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Committing changes to ObsFormController and related classes (version 01 : Stores a Patient instance successfully <http://feedproxy.google.com/~r/OMRStrunk/~3/oxiKrSnzRBc/OpenMRS> |
| 12:19:48 | *** dkayiwa has joined #openmrs |
| 12:34:06 | *** asgoyal has joined #openmrs |
| 12:39:34 | *** dlawson has joined #openmrs |
| 12:39:34 | *** ChanServ sets mode: +v dlawson |
| 12:45:58 | *** gauravpaliwal has joined #openmrs |
| 12:45:58 | *** ChanServ sets mode: +v gauravpaliwal |
| 12:48:52 | *** dkayiwa has quit IRC |
| 12:51:56 | *** gauthami has joined #openmrs |
| 12:52:03 | <gauthami> hi james_regen |
| 12:52:34 | <james_regen> hi gauthami |
| 12:53:08 | <gauthami> sorry yesterday i was losing my internet connection |
| 12:53:20 | <gauthami> so could hardly get your responses |
| 12:53:32 | <gauthami> can we shift to openmrs_link |
| 12:53:34 | <gauthami> james_regen: |
| 12:53:34 | <james_regen> that's alright, we were still able to get a few things done. did you get my latest changes? |
| 12:53:36 | <james_regen> ok |
| 12:54:06 | <gauthami> no i will just check |
| 12:59:19 | *** dkayiwa has joined #openmrs |
| 13:13:02 | *** downeym has joined #openmrs |
| 13:13:02 | *** ChanServ sets mode: +o downeym |
| 13:13:02 | *** OpenMRSBot sets mode: +o downeym |
| 13:21:00 | *** uto has joined #openmrs |
| 13:21:14 | <downeym> Hi uto and welcome to the #openmrs IRC channel. |
| 13:21:52 | <uto> Hi, I am here for the first time. Is this the right place to ask about unit testing problem? |
| 13:22:18 | <downeym> Sure. :) |
| 13:22:19 | <pascal`> Hi downeym and welcome to the #openmrs IRC channel. |
| 13:22:28 | <rafa> Welcome uto! |
| 13:22:40 | <downeym> Hi pascal` and welcome to the #openmrs IRC channel. |
| 13:22:53 | <pascal`> downeym++ |
| 13:23:04 | <uto> I tried to start unit test and got "Failed to load ApplicationContext" exception |
| 13:23:11 | <uto> this is my first unit test run |
| 13:24:08 | <rafa> uto, please paste your full stacktrace here http://pastebin.com/ |
| 13:31:31 | *** mandric has joined #openmrs |
| 13:34:36 | *** gbastien has joined #openmrs |
| 13:34:38 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @djazayeri: Finishing off #OpenMRS web services (v1 at least) <http://twitter.com/OpenMRS/statuses/80625654734921728> |
| 13:38:57 | <gauravpaliwal> hi rafa |
| 13:39:21 | <rafa> Hi gauravpaliwal |
| 13:40:05 | <gauravpaliwal> I have a problem my @MODULE_ID@ is converting to org.openmrs.module.feedback-parent , where should I edit to change it to @MODULE_ID@ to org.openmrs.module.feedback |
| 13:40:06 | <gauravpaliwal> ? |
| 13:40:09 | <gauravpaliwal> any clue ? |
| 13:41:00 | <rafa> gauravpaliwal: look in config.xml |
| 13:41:19 | <gauravpaliwal> rafa : my config.xml file is here : http://pastebin.com/R3iHVA6r |
| 13:41:32 | <gauravpaliwal> it has configured to feedback |
| 13:41:33 | <gauravpaliwal> :( |
| 13:41:52 | <gauravpaliwal> <id>feedback</id>     <name>General Feedback Mechanism</name>     <version>1.0.0</version>     <package>org.openmrs.module.@MODULE_ID@</package>     <author>Gaurav Paliwal</author>     <description>             General Feedback Mechanism Module     </description>      <activator>@MODULE_PACKAGE@.FeedbackActivator</activator>     |
| 13:42:29 | <rafa> gauravpaliwal: I see. I haven't seen this behavior before. |
| 13:43:02 | *** uto has quit IRC |
| 13:43:16 | <gauravpaliwal> rafa : Is that has anything to do with the pom.xml ? |
| 13:44:01 | <rafa> gauravpaliwal: Good point. It is higly possible, but I have no experience with mavenized modules. |
| 13:44:55 | <pascal`> yeah, I saw djazayeri saying something about -parent and maven a while ago. |
| 13:46:24 | <rafa> gauravpaliwal: you can try inspecting poms in your module for artifactId |
| 13:47:38 | <gauravpaliwal> pascal` rafa : I am doing it but when I change the artifactId : Netbeans says Illegally configured Maven Project |
| 13:52:15 | <pascal`> gauravpaliwal, take a look here: https://wiki.openmrs.org/display/IRC/2011-06-06+-+OpenMRS#190718 |
| 13:52:23 | <OpenMRSBot> <http://ln-s.net/8uQK> (at wiki.openmrs.org) |
| 13:53:15 | <rafa> gauravpaliwal: You can hardcode the package in config.xml i.e. <package>org.openmrs.module.feedback</package> if it satisfies you. |
| 13:53:39 | <gauravpaliwal> rafa |
| 13:53:44 | <gauravpaliwal> i have done that |
| 13:53:49 | <gauravpaliwal> and its wirking |
| 13:53:49 | <pascal`> gauravpaliwal, there might also be something else here: http://goo.gl/kh3RV |
| 13:54:10 | <pascal`> gauravpaliwal, rafa, there are many reasons why that isn't a good idea |
| 13:54:34 | <gauravpaliwal> pascal` : but bawolfe ++1 also said this |
| 13:54:59 | <pascal`> gauravpaliwal, bwolfe said to hardcode the @MODULE_ID@ ? |
| 13:55:11 | <gauravpaliwal> pascal` : No |
| 13:55:35 | <gauravpaliwal> pascal` : he asked to have @MODULE_ID@ and remove hardcode |
| 13:56:02 | <pascal`> gauravpaliwal, yeah, that's the right way to do things |
| 13:56:11 | <pascal`> gauravpaliwal, there might be some more info here: https://wiki.openmrs.org/display/IRC/2011-05-18+-+OpenMRS#170414 |
| 13:56:18 | <OpenMRSBot> <http://ln-s.net/8uQM> (at wiki.openmrs.org) |
| 13:56:32 | <rafa> gauravpaliwal: Can you please try using @MODULE_PACKAGE@? |
| 14:01:42 | <gauravpaliwal> rafa : no success :( for @MODULE_PACKAGE@ |
| 14:02:00 | *** bwolfe has joined #openmrs |
| 14:02:00 | *** ChanServ sets mode: +o bwolfe |
| 14:03:48 | <djazayeri> bwolfe: waiting for you on the freeconferencing line now |
| 14:04:00 | <bwolfe> pin? |
| 14:04:14 | <djazayeri> 478709 |
| 14:06:26 | <rafa> gauravpaliwal: You could try comparing your configuration to restmodule for example. |
| 14:07:31 | <gauravpaliwal> rafa : doing it now , looks like *(07:26:11 PM) pascal`: gauravpaliwal, there might be some more info here: https://wiki.openmrs.org/display/IRC/2011-05-18+-+OpenMRS#170414* hold the possible solution |
| 14:07:39 | <OpenMRSBot> <http://ln-s.net/8uQS> (at wiki.openmrs.org) |
| 14:11:59 | *** bryq has joined #openmrs |
| 14:11:59 | *** ChanServ sets mode: +v bryq |
| 14:12:41 | <gauravpaliwal> rafa , pascal` problem solved in the modulename-omod pom.xml file i changed <MODULE_ID>${project.parent.artifactId}</MODULE_ID> to <MODULE_ID>${artifactId}</MODULE_ID> |
| 14:12:53 | <gauravpaliwal> and its working fine now :) |
| 14:12:58 | <gauravpaliwal> thanks for help |
| 14:13:24 | <gauravpaliwal> previous pascal` link solved the problem :) |
| 14:14:23 | <pascal`> glad it's sorted |
| 14:14:53 | <pascal`> gauravpaliwal, for bonus points, create a wiki page which explains how to solve the problem, |
| 14:15:08 | <pascal`> gauravpaliwal, with enough decent keyworks so people can find it in a google search |
| 14:15:15 | <pascal`> *weywords |
| 14:15:17 | <pascal`> dammit |
| 14:15:20 | <pascal`> you know what I mean |
| 14:15:46 | <gauravpaliwal> pascal` : will do it in next couple of hours :) |
| 14:16:02 | <pascal`> gauravpaliwal++ |
| 14:16:21 | <gauravpaliwal> pascal` : on what page should I add new page or edit an existing page ? |
| 14:17:52 | <pascal`> gauravpaliwal, not sure, browse around and see where it makes sense... maybe a module debugging/trouble shooting page or something? bwolfe? |
| 14:18:12 | <pascal`> as long as if you copy/paste the error into google, you find the page |
| 14:18:29 | <pascal`> downeym, might even have an idea |
| 14:18:38 | * downeym wakes up |
| 14:19:07 | <downeym> Troubleshooting maybe? |
| 14:19:30 | <downeym> https://wiki.openmrs.org/display/docs/Troubleshooting |
| 14:19:34 | <gauravpaliwal> downeym : okey |
| 14:19:37 | <OpenMRSBot> <http://ln-s.net/8uQX> (at wiki.openmrs.org) |
| 14:19:46 | <pascal`> downeym++ |
| 14:20:04 | *** gauthami has quit IRC |
| 14:20:14 | <downeym> When it comes to wiki pages, something is always better than nothing |
| 14:20:52 | <pascal`> something++ |
| 14:20:54 | <pascal`> nothing-- |
| 14:21:07 | <gauravpaliwal> downeym: will add by next few hours :) |
| 14:21:15 | <downeym> gauravpaliwal++ |
| 14:22:02 | <gauravpaliwal> downeym : eveningwalk +++ for now :) :D |
| 14:22:06 | *** gauravpaliwal has left #openmrs |
| 14:22:19 | <pascal`> downeym, bwolfe, seen this: http://www.in-the-box.org/ ? |
| 14:28:21 | <bwolfe> I saw it from the same tweet you did :-p |
| 14:30:09 | <pascal`> bwolfe, heh, ok good |
| 14:30:20 | <pascal`> bwolfe, now you can run your apps on a superior OS |
| 14:30:47 | <downeym> pascal`: hmm, intriguing |
| 14:34:32 | <pascal`> downeym, I saw your tweet about the unlocked phone |
| 14:34:49 | <pascal`> downeym, wish they had them a while back |
| 14:34:51 | <downeym> pascal`: yeah thought of you when i saw that :) |
| 14:35:29 | <pascal`> >.< |
| 14:58:27 | *** aja has joined #openmrs |
| 15:00:03 | *** pascal` has quit IRC |
| 15:06:05 | <aja> can anybody help me to create a extension point at user option page? |
| 15:07:40 | <bwolfe> aja, have you seen the "how to create extension points" wiki page? |
| 15:18:02 | <downeym> !refer bwolfe https://wiki.openmrs.org/display/docs/Module+Extension+Points |
| 15:18:02 | * OpenMRSBot refers bwolfe to https://wiki.openmrs.org/display/docs/Module+Extension+Points |
| 15:19:52 | <aja> ok fine |
| 15:28:41 | *** szrrizvi has joined #openmrs |
| 15:31:56 | <szrrizvi> Hello bwolfe and djazayeri. I created a presentation about the access control in openmrs. I was wondering if you guys would be interrested in having it for documentation. |
| 15:32:25 | <bwolfe> certainly |
| 15:32:43 | *** jwishnie has joined #openmrs |
| 15:33:18 | <szrrizvi> Is there someone I could send it to, who can review it and then post it on the wiki pages? |
| 15:33:40 | *** dlawson has quit IRC |
| 15:33:50 | <bwolfe> there are 3-4 of us that watch all wiki pages and can clean it up once there. thats the fun with wikis. :-) |
| 15:34:45 | <szrrizvi> Sounds great, I'll get started on it right away. |
| 15:45:42 | *** gauravpaliwal has joined #openmrs |
| 15:45:42 | *** ChanServ sets mode: +v gauravpaliwal |
| 15:51:41 | *** bwolfe has quit IRC |
| 15:53:40 | *** rafa has quit IRC |
| 16:08:22 | <szrrizvi> Anyone has any suggestion under which directory I should post the Access Control wiki page? |
| 16:17:24 | <gauravpaliwal> szrrizvi: ask downeym ? |
| 16:19:07 | <downeym> szrrizvi: Hmmm |
| 16:20:09 | <downeym> szrrizvi: I think it's OK to leave it where it is for now, as bwolfe says they might re-sort it later |
| 16:20:17 | <szrrizvi> I am working on documenting how the access control is managed in openmrs. bwolfe suggested i should post it on a wiki page. I am just wondering under which directory should i porti t. |
| 16:20:36 | <szrrizvi> post it* |
| 16:21:20 | <szrrizvi> Alrite. I wasn't planning on posting it incomplete. But by force of habit if pressed CTRL+S and it got posted. hehe |
| 16:22:22 | *** pascal` has joined #openmrs |
| 16:22:22 | *** ChanServ sets mode: +v pascal` |
| 16:23:06 | <downeym> szrrizvi: haha, no problem. the URL doesn't change when a page is "moved" only the structure in the side navigation, so it's not a major challenge to move things around. |
| 16:26:09 | <szrrizvi> alrite. |
| 16:29:32 | *** rafa has joined #openmrs |
| 16:29:32 | *** ChanServ sets mode: +v rafa |
| 16:48:14 | *** gauravpaliwal has left #openmrs |
| 16:48:55 | *** jwishnie has quit IRC |
| 16:51:15 | *** jwishnie has joined #openmrs |
| 16:58:25 | *** ena has joined #openmrs |
| 17:01:16 | *** wluyima has joined #openmrs |
| 17:01:16 | *** wyclif has quit IRC |
| 17:10:29 | <djazayeri> wluyima: you there? |
| 17:11:11 | *** downeym sets mode: +v dkayiwa |
| 17:11:14 | *** downeym sets mode: +v ena |
| 17:11:16 | *** downeym sets mode: +v goutham |
| 17:11:20 | *** downeym sets mode: +v wluyima |
| 17:14:45 | *** Suranga has joined #openmrs |
| 17:19:50 | *** aja has quit IRC |
| 17:20:50 | *** goutham has quit IRC |
| 17:21:02 | *** ena_ has joined #openmrs |
| 17:21:12 | *** szrrizvi has quit IRC |
| 17:21:17 | <downeym> Hi ena_ and welcome to the #openmrs IRC channel. |
| 17:21:56 | *** asgoyal has quit IRC |
| 17:22:33 | <ena_> Hi, I just got an warning: pastebin.com/ti1TbfmX |
| 17:22:40 | *** ena has quit IRC |
| 17:24:18 | <ena_> Could you help me with Unable to find pom.properties error |
| 17:24:36 | *** saimanohar has joined #openmrs |
| 17:26:51 | <djazayeri> hi saimanohar |
| 17:26:55 | <saimanohar> hi everybody,i have been having problems in gettting my module deployed with hibernate mappings |
| 17:27:00 | <saimanohar> hi darius |
| 17:27:07 | <djazayeri> I assume there was a much bigger stack trace than what you included in the email? |
| 17:27:17 | <saimanohar> yes |
| 17:27:23 | <saimanohar> it was just a part of it |
| 17:27:31 | <djazayeri> There's probably one line in the whole thing that tells you the problem |
| 17:27:37 | <djazayeri> it's often in the middle though. :-) |
| 17:28:31 | *** ena_ is now known as ena |
| 17:29:01 | <djazayeri> saimanohar: can you put the whole stack trace in pastebin? |
| 17:29:07 | <saimanohar> yes it was a very big one on the tomact console,this is one that i could make snese of |
| 17:30:13 | <saimanohar> yeah sure and between i got an error on the module list page too |
| 17:30:23 | <saimanohar> shall paste that one too! |
| 17:30:41 | <djazayeri> it's probably the same error |
| 17:32:10 | <saimanohar> okay!ill give you the link in a while |
| 17:33:42 | *** pascal` has quit IRC |
| 17:39:18 | <saimanohar> http://pastebin.com/YF6BDBLF |
| 17:39:21 | <saimanohar> this is the link |
| 17:39:36 | <saimanohar> and a little background on what i have found out |
| 17:40:04 | <saimanohar> when i have simple property elements in the hibernate file i have no probs getting the module deployed |
| 17:40:37 | <saimanohar> but when i have something like this - <many-to-one name="staff" class="org.openmrs.module.hr.Staff" fetch="select"> <column name="supervisor_id" /> </many-to-one> |
| 17:40:48 | <saimanohar> then it gives me this error |
| 17:41:16 | <djazayeri> and if you comment out that line the error disappears? |
| 17:41:58 | <djazayeri> because the root cause of that stack trace is: java.lang.ClassNotFoundException: org.openmrs.module.basicmodule.web.controller.BasicModuleFormController |
| 17:42:04 | <saimanohar> yup if i comment out this line and have only <property> tags then it works fine |
| 17:42:28 | <saimanohar> yeah it says that but i dont find any problem with that |
| 17:45:29 | <djazayeri> Just to check, can you try uploading a clean version both with and without? |
| 17:45:43 | <djazayeri> I mean: doing a clean build, both with and without that property |
| 17:45:50 | <djazayeri> and upload to your local instance |
| 17:45:52 | <djazayeri> and verify the error |
| 17:46:15 | <saimanohar> yup i did that plenty times thats how i arrived at this conclusion |
| 17:50:43 | <saimanohar> i can say the problem is not with the controller not found thing,because i tried removing the <mappingFiles> from the config.xml and it worked fine |
| 17:51:24 | <Suranga> downeym, hi, r u around ? wondering if you can give me a hand in creating a crucible review for my project... |
| 17:52:26 | <downeym> Suranga: I am around, but may not be the best person to answer your question. Go ahead anyway. :) |
| 17:52:44 | <Suranga> downeym, as in, right now im looking at a message box that says "select project for new review" it offers three options, but im not sure how to point to my branch... |
| 17:53:13 | <downeym> where does it live in subversion? |
| 17:53:13 | <djazayeri> Suranga: your code is checked into a branch, right? |
| 17:53:16 | <djazayeri> a branch of trunk? |
| 17:53:23 | <djazayeri> in that case you'd choose the Trunk option. |
| 17:53:25 | <Suranga> aha yepsss |
| 17:53:54 | <Suranga> so CR_trunk -> create review |
| 17:54:38 | <djazayeri> yes |
| 17:54:46 | <Suranga> now i get four options - browse, explore,search , pre commit , attachments... |
| 17:55:10 | <djazayeri> either explore or search, I forget |
| 17:55:35 | <djazayeri> saimanohar: I don't really know where to go from there, then. |
| 17:55:47 | <djazayeri> try deleting your tomcat's work directory, and restarting tomcat |
| 17:55:57 | <djazayeri> work and temp, I mean. |
| 17:56:12 | <djazayeri> and see if you get the same error or not |
| 17:56:22 | <saimanohar> and yeah one more thing,whenever i get this error i need to restart tomcat |
| 17:56:29 | <saimanohar> nothing else works from here |
| 17:56:43 | <saimanohar> work and temp i wud try |
| 17:56:49 | *** rafa has quit IRC |
| 17:57:57 | <Suranga> aha, i selected my branch,now it is asking, Add to Review as: |
| 17:57:58 | <Suranga> diff, whole files, diffs to last branch point ... |
| 17:58:22 | <djazayeri> What do you want reviewed? |
| 17:58:46 | <djazayeri> Probably diffs to last branch point. |
| 17:59:03 | <djazayeri> I assume that will show all differences you've introduced since the branch from trunk. |
| 17:59:40 | *** Suranga_ has joined #openmrs |
| 17:59:44 | *** wluyima has quit IRC |
| 18:00:04 | *** wyclif has joined #openmrs |
| 18:02:37 | *** Suranga has quit IRC |
| 18:04:51 | *** rafa has joined #openmrs |
| 18:04:51 | *** ChanServ sets mode: +v rafa |
| 18:16:35 | <Suranga_> djazayeri, is it possible for me to add people as reviewers ? |
| 18:16:43 | <djazayeri> it should be |
| 18:16:47 | <djazayeri> add me and ben |
| 18:16:48 | <Suranga_> u and ben were added by default, i think :P |
| 18:16:53 | <ena> Hi everybody, could anybody tell me why test run is displaying "Unable to find pom.properties file built by maven" in console? |
| 18:17:37 | <Suranga_> djazayeri, if possible, could u please look https://source.openmrs.org/cru/CR-TRUNK-369, and tell me if the review is in order ? :-) |
| 18:18:02 | <djazayeri> it's not in order |
| 18:18:06 | <djazayeri> there are no files in it. :-) |
| 18:18:17 | <djazayeri> you need to go back and Add Content again |
| 18:18:40 | <Suranga_> aha |
| 18:19:53 | <Suranga_> djazayeri, add to review as diffs ? |
| 18:20:06 | <djazayeri> diff from previous branch, I think |
| 18:20:24 | <djazayeri> Typically you add specific changesets |
| 18:20:50 | <djazayeri> so, if you know the revision numbers of all the commits you've made to your branch, you could add them all individually. |
| 18:21:09 | <djazayeri> But it sometimes gets confused when you edit the same file multiple times in those changesets. |
| 18:21:13 | <djazayeri> (crucible gets confused I mean) |
| 18:21:57 | <djazayeri> so, if you can find a way to identify the files, and say diff-since-latest-branch, that would be better. |
| 18:22:00 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Unit test excepion <http://forum.openmrs.org/viewtopic.php?f=8&t=783#p2968> |
| 18:22:00 | <djazayeri> (I've never done that though) |
| 18:22:17 | *** szrrizvi has joined #openmrs |
| 18:22:19 | *** djazayeri has quit IRC |
| 18:22:55 | *** djazayeri has joined #openmrs |
| 18:22:55 | *** ChanServ sets mode: +o djazayeri |
| 18:23:32 | *** szrrizvi has quit IRC |
| 18:23:49 | *** szrrizvi has joined #openmrs |
| 18:23:54 | *** Suranga has joined #openmrs |
| 18:26:14 | *** Suranga__ has joined #openmrs |
| 18:26:26 | <downeym> Hi Suranga__ and welcome to the #openmrs IRC channel. |
| 18:26:31 | *** szrrizvi has quit IRC |
| 18:27:14 | *** Suranga_ has quit IRC |
| 18:27:34 | *** saimanohar has quit IRC |
| 18:30:02 | *** Suranga has quit IRC |
| 18:31:45 | *** bwolfe has joined #openmrs |
| 18:31:45 | *** ChanServ sets mode: +o bwolfe |
| 18:37:15 | *** jwishnie has quit IRC |
| 18:45:18 | *** rafa has quit IRC |
| 19:00:22 | <djazayeri> wyclif, bwolfe: I'm looking at getting encounters via REST, and I've noticed that we include patient/person in both encounter and obs |
| 19:00:52 | <djazayeri> maybe we should move this to just a link, |
| 19:00:53 | <djazayeri> thoughts? |
| 19:01:22 | <bwolfe> a ref of the person and ref of patient, right? |
| 19:01:29 | <djazayeri> yes a ref |
| 19:01:43 | <djazayeri> I mean: encounter has encounter.patient |
| 19:01:47 | <djazayeri> obs has obs.encounter |
| 19:02:16 | <wyclif> hmm |
| 19:02:29 | <djazayeri> so the encounter's obs property contains an encounter property |
| 19:02:37 | <djazayeri> it's only a ref, but still, it looks hideous |
| 19:02:48 | <bwolfe> you mean obs has obs.person |
| 19:03:10 | <djazayeri> obs has obs.person and also obs.encounter |
| 19:03:27 | <bwolfe> if you fetch an obs alone, you want those |
| 19:03:34 | <djazayeri> Let me pastebin what I'm talking about |
| 19:03:42 | <bwolfe> but if you are getting the obs as a child of encounter, then you don't need those |
| 19:03:48 | <bwolfe> is there an easy way to exclude them though? |
| 19:05:14 | <djazayeri> http://pastebin.com/TSjrCyS3 |
| 19:05:20 | <djazayeri> that's an encounter with 2 obs |
| 19:06:18 | <djazayeri> maybe I shouldn't care, but this strikes me as just enormous |
| 19:07:27 | <bwolfe> when getting as a full, yes, that can be enormous |
| 19:07:43 | <djazayeri> So maybe I'd like to have the @PropertyGetter for "obs" in encounter be able to recursively surpress the encounter property of obs. |
| 19:07:58 | <bwolfe> could drop: "accessionNumber" : null, |
| 19:07:59 | <bwolfe> "obsGroup" : null, |
| 19:07:59 | <bwolfe> "groupMembers" : null, |
| 19:08:31 | <bwolfe> yes, and it shoudl surpress the person property |
| 19:08:35 | <djazayeri> (and also suppress obs.person) |
| 19:09:12 | <djazayeri> okay, it's trivial to do at the top level, but I'll see if it's doable recursively. |
| 19:22:22 | *** dkayiwa has quit IRC |
| 19:27:11 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Unit test excepion <http://forum.openmrs.org/viewtopic.php?f=8&t=783#p2969> |
| 19:44:14 | *** james_regen has quit IRC |
| 19:46:07 | *** bryq has quit IRC |
| 20:03:29 | *** jwishnie has joined #openmrs |
| 20:25:24 | *** bwolfe has quit IRC |
| 20:35:15 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : added complete translation for implemenation id setup page of initial setup wizard <http://feedproxy.google.com/~r/OMRStrunk/~3/u2ep3LAl78o/OpenMRS> || New Changeset: OpenMRS (webapp-testing): View encounters for a patient - APPTEST-24 <http://feedproxy.google.com/~r/OMRStrunk/~3/oaKla0Ql_nM/OpenMRS> || New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : added translation for error messages which can be displayed while wizards running <http://feedproxy.google.com/~r/OMRStrunk/~3/dF8UJaajaqw/OpenMRS> || OpenMRS Forum: Re: Unit test excepion <http://forum.openmrs.org/viewtopic.php?f=8&t=783#p2971> || OpenMRS Forum: Re: Unit test excepion <http://forum.openmrs.org/viewtopic.php?f=8&t=783#p2970> |
| 20:39:51 | *** Suranga__ has quit IRC |
| 20:45:22 | *** mandric has quit IRC |
| 21:09:18 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Unit test excepion <http://forum.openmrs.org/viewtopic.php?f=8&t=783#p2972> |
| 21:29:47 | <djazayeri> wyclif: you around? |
| 21:30:15 | <djazayeri> I'm working on making encounters include their obs (in RESTWS) |
| 21:30:16 | *** rafa has joined #openmrs |
| 21:30:16 | *** ChanServ sets mode: +v rafa |
| 21:30:41 | <djazayeri> and this happens in a hierarchy |
| 21:31:04 | <djazayeri> i.e. if you have an obs group, only the parent is included in the encounter |
| 21:31:40 | <djazayeri> Anyway, I ran into the problem that ObsResource's default rep only includes groupMembers as a Ref. |
| 21:32:28 | <djazayeri> So an encounter (in Full rep) only get the top-level obs as default. The group members are Refs. So groups of groups disappear. |
| 21:33:06 | <djazayeri> I think we should make ObsResource include groupMembers as Default (when you request the parent obs as Default) |
| 21:33:09 | <djazayeri> any objections? |
| 21:53:31 | *** mandric has joined #openmrs |
| 21:57:02 | *** rafa has quit IRC |
| 22:20:05 | <wyclif> hi jwishnie |
| 22:22:37 | *** mandric has quit IRC |
| 22:47:23 | *** jwishnie has quit IRC |
| 23:09:11 | *** downeym has quit IRC |
| 23:12:06 | *** ena has quit IRC |
| 23:47:18 | *** jwishnie has joined #openmrs |
| 23:51:35 | *** jwishnie has quit IRC |