| 00:05:25 | *** djazayeri has quit IRC |
| 00:11:02 | *** djazayeri has joined #openmrs-sprint |
| 00:11:58 | *** ChanServ sets mode: +o djazayeri |
| 01:05:27 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): URL patterns for module servlet filter mappings should be relative to the context path - TRUNK-2324 <http://feedproxy.google.com/~r/OMRStrunk/~3/WqEvI80o_pg/OpenMRS> |
| 04:14:14 | *** djazayeri has quit IRC |
| 04:45:03 | *** djazayeri has joined #openmrs-sprint |
| 04:45:03 | *** zelazny.freenode.net sets mode: +o djazayeri |
| 06:08:05 | *** dkayiwa has joined #openmrs-sprint |
| 08:55:20 | *** dkayiwa has quit IRC |
| 10:01:32 | *** bwolfe has joined #openmrs-sprint |
| 10:01:32 | *** ChanServ sets mode: +o bwolfe |
| 11:46:22 | *** bwolfe has quit IRC |
| 11:48:59 | *** bwolfe has joined #openmrs-sprint |
| 11:48:59 | *** ChanServ sets mode: +o bwolfe |
| 12:14:12 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (webapp-testing): Test case: View server log- APPTEST-11 <http://feedproxy.google.com/~r/OMRStrunk/~3/n2PTjOHMnFQ/OpenMRS> |
| 12:39:35 | *** wyclif has quit IRC |
| 12:53:23 | *** dkayiwa has joined #openmrs-sprint |
| 13:02:37 | *** wyclif has joined #openmrs-sprint |
| 13:05:11 | *** dkayiwa has quit IRC |
| 13:05:30 | *** dkayiwa has joined #openmrs-sprint |
| 13:16:35 | *** wyclif has quit IRC |
| 13:16:46 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (webapp-testing): Added mysql-mxj jars to profile - APPTEST-11 <http://feedproxy.google.com/~r/OMRStrunk/~3/EVuYRj6H3aI/OpenMRS> |
| 13:18:19 | *** cta has joined #openmrs-sprint |
| 13:21:38 | *** wyclif has joined #openmrs-sprint |
| 13:59:07 | <dkayiwa> hi bwolf |
| 13:59:15 | <dkayiwa> bwolfe |
| 13:59:53 | *** downeym has joined #openmrs-sprint |
| 13:59:53 | *** ChanServ sets mode: +o downeym |
| 13:59:54 | *** OpenMRSBot sets mode: +o downeym |
| 14:21:44 | <bwolfe> hi dkayiwa |
| 14:21:47 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.7.x): added @since tag to Address interface <http://feedproxy.google.com/~r/OMRStrunk/~3/lP8RTTqhztc/OpenMRS> || New Changeset: OpenMRS (1.6.x): added @since tag to Address interface <http://feedproxy.google.com/~r/OMRStrunk/~3/Tla1VPHQXIM/OpenMRS> |
| 14:22:16 | <dkayiwa> bwolfe: will ask you after the meeting :) |
| 14:22:25 | <bwolfe> ok |
| 14:22:52 | <bwolfe> right after the call I'll be going back to the house for a few hours to get some dinner and play with the kids |
| 14:23:08 | <dkayiwa> bwolfe: should i ask now? |
| 14:23:14 | <bwolfe> sure |
| 14:23:20 | <bwolfe> we can multi-task. :-) |
| 14:23:25 | <bwolfe> (or try to) |
| 14:23:28 | <dkayiwa> :D |
| 14:23:53 | <dkayiwa> bwolfe: if i have a small bug to fix on trunk, do i need to first create a ticket for it? |
| 14:24:09 | <bwolfe> yes, ideally. |
| 14:24:22 | <bwolfe> you don't have to for super minor fixes |
| 14:24:24 | <dkayiwa> even for something very very small? :D |
| 14:24:32 | <bwolfe> what is the fix? |
| 14:25:15 | <dkayiwa> when a non admin user clicks the edit patient link, it throws exceptions because the url is not properly built |
| 14:25:49 | <bwolfe> a redirect error? |
| 14:26:07 | <bwolfe> dkayiwa, if its something that someone might ever search for, you should make a ticket |
| 14:26:15 | <bwolfe> or if its something that will be backported |
| 14:26:28 | <dkayiwa> it should be backported |
| 14:26:35 | <bwolfe> so yeah, make a ticket, put the stacktrace in there, then commit/close/approve the ticket |
| 14:26:50 | <dkayiwa> the fix is just adding a missing appostrophe |
| 14:27:15 | <dkayiwa> ok will create the ticket |
| 14:27:24 | <dkayiwa> thanks bwolfe |
| 14:27:33 | <dkayiwa> thats it for now :) |
| 14:54:25 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): added @since tag to Address interface <http://feedproxy.google.com/~r/OMRStrunk/~3/pAYkm_9TlLQ/OpenMRS> || New Changeset: OpenMRS (1.8.x): added @since tag to Address interface <http://feedproxy.google.com/~r/OMRStrunk/~3/stj4VvpD2uc/OpenMRS> |
| 15:46:06 | *** goutham_ has joined #openmrs-sprint |
| 16:07:19 | *** downeym has quit IRC |
| 16:08:21 | *** bwolfe has quit IRC |
| 16:09:56 | <dkayiwa> hi wyclif |
| 16:10:25 | <wyclif> hi dkayiwa |
| 16:10:44 | <dkayiwa> do you think you will need to back port this to 1.8? |
| 16:10:45 | <dkayiwa> https://tickets.openmrs.org/browse/TRUNK-2326 |
| 16:15:01 | *** sunbiz has joined #openmrs-sprint |
| 16:54:27 | *** goutham_ has quit IRC |
| 17:02:59 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Adding a missing quote for the edit patient link for a non admin user - TRUNK-2326 <http://feedproxy.google.com/~r/OMRStrunk/~3/xcKzr7n-W3w/OpenMRS> |
| 17:05:35 | *** dkayiwa_ has joined #openmrs-sprint |
| 17:05:35 | *** dkayiwa has quit IRC |
| 17:05:37 | *** dkayiwa_ is now known as dkayiwa |
| 17:40:01 | *** bwolfe has joined #openmrs-sprint |
| 17:40:01 | *** ChanServ sets mode: +o bwolfe |
| 18:17:41 | <wyclif> hey dkayiwa |
| 18:17:53 | <wyclif> i was off for lunch with the group, it is thursday |
| 18:18:03 | <bwolfe> did you not stay at buggs wyclif? |
| 18:18:25 | *** downeym has joined #openmrs-sprint |
| 18:18:25 | *** ChanServ sets mode: +o downeym |
| 18:18:26 | *** OpenMRSBot sets mode: +o downeym |
| 18:18:36 | <dkayiwa> hey wyclif |
| 18:18:55 | <wyclif> am back |
| 18:18:56 | <dkayiwa> did they take you to white castle :D |
| 18:19:07 | <wyclif> no way i can go to white castle |
| 18:19:14 | <wyclif> i hate it |
| 18:19:37 | <bwolfe> dkayiwa, did you go to white castle while in Indy? |
| 18:19:49 | <dkayiwa> no way bwolfe |
| 18:19:53 | <dkayiwa> :D |
| 18:19:57 | <wyclif> anyways, to answer your question, i might back port it since is a simple fix in a jsp |
| 18:20:27 | <wyclif> with are having a meeting with some folks from IU bloomingntn\ |
| 18:20:34 | <dkayiwa> ok |
| 18:20:36 | <wyclif> bloomington |
| 18:20:49 | <dkayiwa> have fun there |
| 18:21:03 | <djazayeri> dkayiwa, wyclif: I commented on the ticket to please backport |
| 18:21:54 | <dkayiwa> ok |
| 19:08:57 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Followup fix for adding a new module from within OpenMRS web application reports an error following review - TRUNK-2032 <http://feedproxy.google.com/~r/OMRStrunk/~3/FFC3oPgVcvU/OpenMRS> || OpenMRS Modules: Reporting 0.6 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reporting&version=&0.6> |
| 19:41:22 | <wyclif> djazayeri, what is the new url for webservice calls? |
| 19:42:04 | *** bwolfe has quit IRC |
| 19:59:09 | <sunbiz> djazayeri , bwolfe : Please review https://source.openmrs.org/cru/CR-MOD-160 |
| 19:59:40 | <djazayeri> sunbiz: will do |
| 19:59:41 | <djazayeri> wyclif: what? |
| 20:00:03 | <djazayeri> I didn't change the urls... |
| 20:00:32 | <wyclif> http://localhost:8080/openmrs/ws/rest/patient/dd553355-1691-11df-97a5-7038c432aabf |
| 20:00:57 | <wyclif> openmrs/ws/rest/patient/dd553355-1691-11df-97a5-7038c432aabf |
| 20:01:32 | <djazayeri> is this different from before? |
| 20:19:12 | <dkayiwa> hi wyclif |
| 20:19:16 | <sunbiz> djazayeri: do u think generics and wildcards help improve readability of code? |
| 20:19:40 | <sunbiz> djazayeri: I find it kind of hard... but may be its just me :) |
| 20:21:33 | <djazayeri> sunbiz: they're very easy to *use*, but often hard to write. :-) |
| 20:21:58 | <sunbiz> djazayeri: my question was in response to your general comments about breaking code into multiple lines |
| 20:22:18 | <sunbiz> and to improve readability/maintainability of code is more important |
| 20:25:39 | <sunbiz> djazayeri: I think generics and more so wildcards... is just that compression in declaration |
| 20:25:57 | <djazayeri> sunbiz: sorry, was on phone. just finished |
| 20:26:10 | <djazayeri> I agree that the wildcards and bounded generics get really confusing to write. |
| 20:26:37 | <sunbiz> djazayeri: and confusing to read |
| 20:27:04 | <sunbiz> at the first glance |
| 20:27:05 | <sunbiz> :) |
| 20:27:32 | <djazayeri> the point, though, is that even though the genericized class itself is confusing to read, the other classes that use that class get simpler |
| 20:27:58 | <djazayeri> if we're not getting that effect, then we shouldn't be using the generics |
| 20:28:26 | <djazayeri> i.e. it's easier if several callers get to write "List<PersonName> names = removeVoided(getNames())" |
| 20:28:45 | <djazayeri> (without casting, or unnecessary looping) |
| 20:29:51 | <sunbiz> hmmm... yes, so the choice is easier to read Vs easier to use |
| 20:31:58 | <djazayeri> sunbiz: I think generally if you're writing a method you expect to use multiple times, it's worth making that method harder-to-read, such that the multiple uses are cleaner. |
| 20:34:04 | <djazayeri> but if it's a single-use method, obviously you shouldn't do that |
| 20:36:47 | <sunbiz> and what do u think about using generics and wildcards in the same method?? ... it obviously needs many many uses to weigh its crypt-ability |
| 20:37:20 | <djazayeri> are you particularly asking about the removeVoided method? |
| 20:37:25 | <djazayeri> or in general? |
| 20:37:42 | <sunbiz> removeVoided made me think this |
| 20:38:12 | <sunbiz> and ur comment about readability vs smaller code |
| 20:38:40 | <djazayeri> remind me what line in what file that is? |
| 20:39:52 | <sunbiz> @Override |
| 20:39:53 | <sunbiz> 110 public Object getProperty(Person instance, String propertyName) throws ConversionException { |
| 20:39:53 | <sunbiz> 111 if (propertyName.equals("attributes") || propertyName.equals("names") || propertyName.equals("addresses")) { |
| 20:39:53 | <sunbiz> 112 String getterName = "get" + WordUtils.capitalizeFully(propertyName); |
| 20:39:53 | <sunbiz> 113 Method getterMethod = ReflectionUtils.findMethod(instance.getClass(), getterName); |
| 20:39:53 | <sunbiz> 114 return RestUtil.removeVoidedData((Collection<OpenmrsData>) ReflectionUtils.invokeMethod(getterMethod, instance)); |
| 20:39:54 | <sunbiz> 115 } else { |
| 20:39:55 | <sunbiz> 116 return super.getProperty(instance, propertyName); |
| 20:39:57 | <sunbiz> 117 } |
| 20:39:58 | <sunbiz> 118 } |
| 20:40:15 | <sunbiz> ok... it was this piece of code... in an earlier revision... that isn't anymore |
| 20:40:35 | <djazayeri> okay |
| 20:40:51 | <djazayeri> (by the way there are two things I don't like about this code snippet: |
| 20:41:23 | <djazayeri> 1. use PropertyUtils from apache commons instead of manually finding the getter yourself and using reflection |
| 20:41:47 | <djazayeri> 2. the whole comment about not overriding getProperty |
| 20:44:22 | <sunbiz> so... I dont remember very clearly... but there wasn't there an access modifier that prevented grandchildren classes to use methods from grnadparents |
| 20:44:24 | <sunbiz> ?? |
| 20:46:02 | <sunbiz> so... probably the getProperty should be protected then?? |
| 20:46:17 | <djazayeri> Not sure what you mean there. I'm just saying that "PropertyUtils.getProperty(instance, propertyName)" replaces lines 112-113 and half of 114 |
| 20:46:46 | <djazayeri> but that the whole thing should disappear because you should stop overriding the getProperty method and use @PropertyGetter instead. |
| 20:47:09 | <sunbiz> then the getProperty should be protected then |
| 20:47:27 | <djazayeri> You mean final |
| 20:47:28 | <djazayeri> ? |
| 20:47:41 | <sunbiz> Im confused between the languages... |
| 20:48:09 | <sunbiz> but an access modifier that prevented subclasses of subclasses to override methods |
| 20:48:52 | <djazayeri> I'm not saying it should _never_ be overridden. I'm just saying that if you can avoid overriding a standard framework method, you should avoid it. |
| 20:49:06 | <sunbiz> ok |
| 20:49:09 | <djazayeri> a final method cannot be overridden. |
| 20:49:14 | <djazayeri> in java |
| 20:49:59 | <sunbiz> yes, but there isn't protected... only allowing direct subclasses to override... and not subclass to subclass |
| 20:50:09 | <sunbiz> *subclass of subclass |
| 20:50:31 | <djazayeri> I don't think protected works that way. |
| 20:50:51 | <djazayeri> protected means it can only be called by the class and its subclasses |
| 20:51:00 | <djazayeri> private cannot even be called by subclasses |
| 20:58:20 | *** downeym has quit IRC |
| 21:03:17 | *** downeym has joined #openmrs-sprint |
| 21:03:17 | *** ChanServ sets mode: +o downeym |
| 21:03:18 | *** OpenMRSBot sets mode: +o downeym |
| 21:03:19 | *** wyclif has quit IRC |
| 21:05:36 | *** cta has quit IRC |
| 21:05:36 | *** dkayiwa has quit IRC |
| 21:05:42 | *** dkayiwa has joined #openmrs-sprint |
| 21:08:50 | <sunbiz> djazayeri: lol... on why fisheye thinks that its deleted RestUtilTest :) |
| 21:09:03 | <sunbiz> the email from SVN... was better in doing the diff |
| 21:15:12 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : localized first pages of initialization wizard, done draft version custom localization tool <http://feedproxy.google.com/~r/OMRStrunk/~3/WZHYb1sFEhI/OpenMRS> || New Changeset: OpenMRS (trunk): Committing comment and unit test fixes for PersonService, per code review comments listed in https://source.openmrs.org/... <http://feedproxy.google.com/~r/OMRStrunk/~3/Mb5OfAQoJfk/OpenMRS> |
| 21:42:09 | *** downeym has quit IRC |
| 21:49:57 | *** dkayiwa has quit IRC |
| 22:23:00 | *** wyclif has joined #openmrs-sprint |
| 22:45:15 | *** sunbiz has left #openmrs-sprint |
| 23:38:08 | *** djazayeri has quit IRC |
| 23:42:50 | *** djazayeri has joined #openmrs-sprint |
| 23:42:50 | *** ChanServ sets mode: +o djazayeri |