04:43:44
|
*** bwolfe has joined #openmrs-sprint
|
05:01:49
|
*** djazayeri_ has quit IRC
|
05:11:18
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (webapp-testing): Initial check-in for the release-test module that will run tests on the web application TRUNK-2137 <http://feedproxy.google.com/~r/OMRStrunk/~3/5FjWQmU0fs4/OpenMRS>
|
06:18:59
|
*** bwolfe has quit IRC
|
06:36:01
|
*** dkayiwa has joined #openmrs-sprint
|
06:47:36
|
*** bwolfe has joined #openmrs-sprint
|
07:07:12
|
*** dkayiwa_ has joined #openmrs-sprint
|
07:07:51
|
*** dkayiwa has quit IRC
|
07:07:52
|
*** dkayiwa_ is now known as dkayiwa
|
07:09:48
|
*** Zabil has joined #openmrs-sprint
|
07:10:09
|
<Zabil> hi. is anybody around?
|
07:10:34
|
<dkayiwa> hi Zabil: am around
|
07:11:22
|
<Zabil> hi dkayiwa we just took an update of the webservices.rest module and all the tests fail.
|
07:11:35
|
<dkayiwa> lollllll
|
07:11:45
|
<Zabil> was there any change that was done recently ?
|
07:11:48
|
<dkayiwa> let me try run them
|
07:11:50
|
<dkayiwa> now
|
07:13:28
|
<dkayiwa> i have just run those under org.openmrs.module.webservices.rest.web.controller
|
07:13:32
|
<dkayiwa> and they all pass
|
07:14:02
|
<Zabil> hmm. and you have the latest update?
|
07:14:08
|
<dkayiwa> try running from eclipse by right clicking and then select Run As Junit test
|
07:14:18
|
<dkayiwa> yes just update 30 mins ago
|
07:14:34
|
<dkayiwa> how are you running the tests?
|
07:14:54
|
<Zabil> using eclipse junit runner
|
07:15:31
|
<dkayiwa> does they still fail after right clicking from eclipse and selecting Run As Junit test?
|
07:18:37
|
<Zabil> it give the error "Service not found: interface org.openmrs.module.webservices.rest.web.api.RestService" but running it from mvn test passes the tests that fail in the ui.
|
07:19:05
|
<dkayiwa> that could be an eclipse configuration issue
|
07:19:25
|
<dkayiwa> do you have any errors in eclipse?
|
07:19:39
|
<dkayiwa> say when project is marked with a red icon??
|
07:20:45
|
<Zabil> there are no errors. actually. might be becase of a local change let me revert and try it again.
|
07:20:54
|
<dkayiwa> ok
|
07:31:34
|
<Zabil> ok mvn test on the trunk without my changes passes. so must be something i goofed up. will check it.
|
07:31:51
|
<Zabil> thanks!
|
07:33:14
|
<dkayiwa> good you figured it out :)
|
07:58:30
|
<Zabil> actually they run when i right click and run as junit test under the package web.controller. if i run they from the project some of them fail. wierd.
|
07:58:43
|
<Zabil> meaning right clicking on the project.
|
08:00:27
|
<dkayiwa> very strange
|
08:22:45
|
*** dkayiwa has quit IRC
|
08:26:47
|
*** dkayiwa has joined #openmrs-sprint
|
08:34:13
|
<dkayiwa> hi bwolfe
|
08:35:49
|
<bwolfe> hey daniel
|
08:36:32
|
<dkayiwa> bwolfe: do you have any idea how enumerate javadoc tags?
|
08:36:42
|
<bwolfe> what do you mean?
|
08:37:00
|
<bwolfe> from java reflection I don't think you have access to the javadoc tags
|
08:37:06
|
<bwolfe> you only have access to annotations
|
08:37:11
|
<dkayiwa> yes thats what i found out
|
08:38:08
|
<dkayiwa> Darius suggested that i introduce javadoc tags like @getDescription, @postDescription, etc on classes
|
08:38:41
|
<dkayiwa> now when i load a class, i want to get all the contents of those javadoc tags
|
08:39:29
|
<bwolfe> yeah, pretty sure you can't do that
|
08:39:35
|
<dkayiwa> those javadoc tags are a way of telling us the available operations on each resource and what the operation means for this particular resource
|
08:39:45
|
<bwolfe> javadoc isn't compiled into bytecode, so java reflection doesn't have access to it
|
08:39:49
|
<dkayiwa> ok
|
08:40:05
|
<bwolfe> so you'll have to make true annotations for that if you want it
|
08:40:29
|
<dkayiwa> Darius is opposed to true annotations (because its what i had proposed at first)
|
08:41:16
|
<dkayiwa> was trying to google and see if i can get any other means of getting those javadoc tags
|
08:41:30
|
<dkayiwa> but also did not want waste much time incase somebody knew how to
|
08:41:40
|
<bwolfe> if you compile with debugging flag enabled I think you can access it
|
08:41:46
|
<bwolfe> but I'm not 100% sure on that
|
08:41:49
|
<dkayiwa> thats why i asked bwolfe :)
|
08:41:55
|
<dkayiwa> ok will try that too
|
08:41:59
|
<bwolfe> and I don't think we want to require that our module and other modules compile with debugging
|
08:42:19
|
<dkayiwa> then that will not work for us
|
08:42:20
|
<bwolfe> I need to run to lunch, I'll be back this afternoon
|
08:42:31
|
<dkayiwa> 8)
|
08:47:13
|
*** bwolfe has quit IRC
|
08:58:11
|
*** Zabil has quit IRC
|
09:06:43
|
*** dkayiwa has quit IRC
|
09:06:51
|
*** dkayiwa has joined #openmrs-sprint
|
09:11:53
|
*** Zabil has joined #openmrs-sprint
|
09:25:40
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): PatientHandler Class, DomainObjectHandler class skeleton and modifications to application-context <http://feedproxy.google.com/~r/OMRStrunk/~3/JgT7PW-X8V0/OpenMRS>
|
10:26:56
|
*** goutham_ has joined #openmrs-sprint
|
10:26:59
|
*** bwolfe has joined #openmrs-sprint
|
10:54:00
|
*** bwolfe has quit IRC
|
12:00:15
|
*** bwolfe has joined #openmrs-sprint
|
12:25:52
|
<dkayiwa> bwolfe: was thinking of just searching through the java file for comments on @getDocumentation
|
12:25:53
|
<dkayiwa> * @postDocumentation
|
12:25:53
|
<dkayiwa> * @putDocumentation
|
12:25:53
|
<dkayiwa> * @deleteDocumentation
|
12:26:14
|
<dkayiwa> should i go ahead?
|
12:26:29
|
<bwolfe> hmm
|
12:26:36
|
<bwolfe> how do you know where the files are? :-p
|
12:26:57
|
<dkayiwa> in the resource package
|
12:27:05
|
<bwolfe> I suppose that will work. your "script" / program is being run against the code, so I suppose that will do
|
12:27:16
|
<dkayiwa> ok
|
12:28:34
|
<dkayiwa> was looking at the javadoc tool source code but it has no obvious independent class for doing just this: bwolfe
|
13:06:54
|
*** dkayiwa has quit IRC
|
13:06:55
|
*** dkayiwa_ has joined #openmrs-sprint
|
13:34:30
|
*** goutham_ has quit IRC
|
13:52:44
|
*** dkayiwa_ has quit IRC
|
14:07:42
|
*** bwolfe has quit IRC
|
14:14:47
|
*** Zabil has quit IRC
|
14:15:05
|
*** dkayiwa has joined #openmrs-sprint
|
14:29:06
|
*** downeym has joined #openmrs-sprint
|
14:29:06
|
*** ChanServ sets mode: +o downeym
|
14:29:07
|
*** OpenMRSBot sets mode: +o downeym
|
14:41:14
|
*** dkayiwa has quit IRC
|
15:10:46
|
*** djazayeri_ has joined #openmrs-sprint
|
15:14:55
|
*** goutham has joined #openmrs-sprint
|
15:41:27
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.6.x): Added Address interface and LocationService.getPossibleAddressValues(Address,String) method per TRUNK-1924 <http://feedproxy.google.com/~r/OMRStrunk/~3/lF2ITdVb60k/OpenMRS>
|
16:24:54
|
*** cta has joined #openmrs-sprint
|
16:44:16
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Added Address interface and LocationService.getPossibleAddressValues(Address,String) method per TRUNK-1924 <http://feedproxy.google.com/~r/OMRStrunk/~3/qzInuy09CVk/OpenMRS> || New Changeset: OpenMRS (1.8.x): Added Address interface and LocationService.getPossibleAddressValues(Address,String) method per TRUNK-1924 <http://feedproxy.google.com/~r/OMRStrunk/~3/G0l6Lb40ORU/OpenMRS> || New Changeset: OpenMRS (1.7.x): Added Address interface and LocationService.getPossibleAddressValues(Address,String) method per TRUNK-1924 <http://feedproxy.google.com/~r/OMRStrunk/~3/K7NcK3hQguI/OpenMRS>
|
16:54:04
|
<cta> Hey, guys! After updating last version of restws from repo, my tests fails. Anything changed?
|
17:31:22
|
*** goutham has quit IRC
|
17:33:08
|
*** downeym_ has joined #openmrs-sprint
|
17:33:08
|
*** ChanServ sets mode: +o downeym_
|
17:33:17
|
<djazayeri_> cta: well, definitely something changed. :-)
|
17:33:21
|
<djazayeri_> what's the error message?
|
17:33:29
|
*** bwolfe has joined #openmrs-sprint
|
17:33:35
|
<cta> 56 errors in tests
|
17:33:45
|
<cta> I'm amased
|
17:35:46
|
<cta> Basing on "ERROR - LazyInitializationException.<init>(19) |2011-06-24 20:17:21,593| could not initialize proxy - no Session" I guess that now we are using something spring's? Or am I wrong?
|
17:36:30
|
*** downeym has quit IRC
|
17:36:30
|
*** downeym_ is now known as downeym
|
17:38:55
|
<cta> djazayeri_: Basing on "ERROR - LazyInitializationException.<init>(19) |2011-06-24 20:17:21,593| could not initialize proxy - no Session" I guess that now we are using something spring's? Or am I wrong?
|
17:41:28
|
<djazayeri_> cta: i just did an svn update and ran the unit tests and all pass (except for 1)
|
17:42:43
|
<cta> djazayeri_: Darius, I'm not lying, it's really a problem for me now.
|
17:43:06
|
<djazayeri_> cta: I know. what's the full error message?
|
17:43:34
|
<cta> djazayeri_: Please, a moment
|
17:47:19
|
<cta> djazayeri_: see http://pastebin.ca/2068581
|
17:50:17
|
<djazayeri_> cta: hmm, can't tell what the problem is from that
|
17:50:40
|
<djazayeri_> same error for all tests?
|
17:51:15
|
<cta> djazayeri_: definitely the same caouse of error for each failed tests
|
17:51:41
|
<cta> Tests run: 118, Failures: 1, Errors: 56, Skipped: 5
|
17:52:51
|
<djazayeri_> half of them work though?
|
17:53:48
|
<djazayeri_> cta: ^^
|
17:55:01
|
<cta> djazayeri_: isn't Friday 13th Today?
|
17:55:20
|
<djazayeri_> that was a couple weeks ago. :-)
|
17:56:51
|
<cta> ;-)
|
18:00:52
|
<cta> djazayeri_: I have checked out project again. Tried to build it, but the same errors appear again.
|
18:07:29
|
<djazayeri_> cta: have you made modifications to core code?
|
18:07:41
|
<djazayeri_> i.e. to openmrs trunk
|
18:07:48
|
<djazayeri_> that could have broken this?
|
18:08:08
|
<cta> djazayeri_: no, I haven't,
|
18:08:41
|
<djazayeri_> okay...are you doing this in eclipse? from the command line? in another ide?
|
18:17:11
|
<cta> djazayeri_: I'm doing it from the command line. Also I'm using Eclipse, but not for running the tests.
|
18:27:11
|
*** downeym_ has joined #openmrs-sprint
|
18:27:11
|
*** ChanServ sets mode: +o downeym_
|
18:29:47
|
*** downeym has quit IRC
|
18:29:47
|
*** downeym_ is now known as downeym
|
18:34:43
|
<djazayeri_> cta: what happens if you try running the tests in eclipse (run as -> junit test)
|
18:39:36
|
<cta> djazayeri_: the same mistakes in eclipse
|
18:42:26
|
<djazayeri_> cta: I don't know what to tell you, unfortunately
|
18:43:27
|
<cta> djazayeri_: Otherwise, thank you, for help!
|
18:48:30
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): update address layout for Lesotho and added Location.communityCouncil message code <http://feedproxy.google.com/~r/OMRStrunk/~3/vJQrh6p5TR8/OpenMRS> || New Changeset: OpenMRS (1.8.x): update address layout for Lesotho and added Location.communityCouncil message code <http://feedproxy.google.com/~r/OMRStrunk/~3/6ijfueHO0ro/OpenMRS> || New Changeset: OpenMRS (1.7.x): updated address layout for Lesotho and added Location.communityCouncil message code <http://feedproxy.google.com/~r/OMRStrunk/~3/FmLo8NWMTNo/OpenMRS> || New Changeset: OpenMRS (1.6.x): update address layout for Lesotho and added Location.communityCouncil message code <http://feedproxy.google.com/~r/OMRStrunk/~3/LoHya7YKWA0/OpenMRS>
|
18:54:34
|
<bwolfe> wyclif: you can add more changesets to a review as you add more fixes, you don't have to close the review each time
|
18:58:01
|
<wyclif> ok
|
18:58:22
|
<wyclif> some them Darius close them
|
18:59:07
|
<djazayeri_> wyclif, bwolfe, sorry, I'll stop closing reviews before we've closed the ticket
|
18:59:44
|
<wyclif> i think bwolfe means actually before another reviewer is done
|
19:00:13
|
<wyclif> sorry about my typos
|
19:02:33
|
<bwolfe> !seen sunbiz
|
19:02:33
|
<OpenMRSBot> bwolfe: sunbiz was last seen in #openmrs-sprint 1 day, 1 hour, 18 minutes, and 40 seconds ago: <sunbiz> just increases some code length
|
19:02:46
|
<bwolfe> boo
|
19:03:39
|
<djazayeri_> actually I just noticed that there's a difference between Summarize and Close today
|
19:03:58
|
<bwolfe> yeah, use summarize before the ticket is closed
|
19:04:06
|
<bwolfe> (like when requesting more changes)
|
19:24:11
|
*** wyclif has quit IRC
|
19:39:03
|
*** wyclif has joined #openmrs-sprint
|
19:40:49
|
*** djazayeri_ has quit IRC
|
19:41:16
|
*** djazayeri has joined #openmrs-sprint
|
19:50:52
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Please bear with us as we make some minor changes to the #OpenMRS web site. It will be available again very soon. Thanks for your patience! <http://twitter.com/OpenMRS/statuses/73105392346988544>
|
20:02:10
|
*** bwolfe has quit IRC
|
20:08:32
|
*** dkayiwa has joined #openmrs-sprint
|
20:56:01
|
*** cta has quit IRC
|
21:06:21
|
*** dkayiwa has quit IRC
|
21:06:33
|
*** dkayiwa has joined #openmrs-sprint
|
21:33:05
|
*** wyclif has quit IRC
|
22:00:07
|
*** dkayiwa has quit IRC
|
22:01:11
|
*** wyclif has joined #openmrs-sprint
|
22:53:31
|
*** downeym has quit IRC
|