| 05:52:46 | *** bwolfe has joined #openmrs-sprint |
| 05:52:46 | *** ChanServ sets mode: +o bwolfe |
| 06:02:03 | *** dkayiwa has joined #openmrs-sprint |
| 06:46:05 | *** sunbiz has joined #openmrs-sprint |
| 06:46:46 | <sunbiz> is the sprint happening on Sundays as well?? |
| 06:46:52 | <sunbiz> no holidays?? |
| 06:47:22 | <bwolfe> sunbiz: you should be constantly sprinting. no breaks! :-D |
| 07:00:44 | <sunbiz> then it shouldnt b called sprint |
| 07:00:49 | <sunbiz> it should be called a marathon |
| 07:10:42 | <dkayiwa> hi sunbiz |
| 07:10:49 | <sunbiz> djazayeri: hi daniel |
| 07:10:54 | <dkayiwa> lolllll |
| 07:11:00 | <sunbiz> dkayiwa: :) |
| 07:11:10 | <dkayiwa> i made some small changes to personname resource |
| 07:11:15 | <dkayiwa> you may want to update |
| 07:11:21 | <dkayiwa> to avoid conficts |
| 07:11:29 | <sunbiz> dkayiwa: yes... just updated the code |
| 07:11:32 | <sunbiz> saw thsoe |
| 07:12:12 | <dkayiwa> am not very sure if they do not break your stuff :) |
| 07:14:47 | <sunbiz> doesnt break |
| 07:14:58 | <dkayiwa> oh good :D |
| 07:16:02 | <sunbiz> bwolfe: why boo on Microsoft Skype... :) does microsoft name enough to ruin it?? |
| 07:33:44 | <bwolfe> yeah. |
| 07:34:01 | <bwolfe> I fear they will stop supporting (or support even less than skype did) the linux and android operating systems |
| 07:34:12 | <bwolfe> so I am trying to scale back my use of it |
| 07:38:08 | *** sunbiz has quit IRC |
| 08:33:10 | *** bwolfe has quit IRC |
| 09:33:59 | *** dkayiwa has quit IRC |
| 09:55:49 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: XForms 4.0.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.3> |
| 10:18:01 | *** dkayiwa has joined #openmrs-sprint |
| 11:58:23 | *** bwolfe has joined #openmrs-sprint |
| 11:58:23 | *** ChanServ sets mode: +o bwolfe |
| 12:58:05 | *** dkayiwa has quit IRC |
| 13:42:05 | *** cta has joined #openmrs-sprint |
| 13:42:18 | <cta> Hi, guys!! |
| 13:49:02 | <cta> djazayeri: I've fixed method getUri as you advised and now we have next URI for cohort member resource "uri" : "NEED-TO-CONFIGURE/ws/rest/cohort/05e08b3b-5690-41e1-b651-5391fd946c1a/patients/da7f524f-27ce-4bb2-86d6-6d1d05312bd5". Also I got rid extends BaseOpenmrsData from CohortMember |
| 14:56:03 | *** sunbiz has joined #openmrs-sprint |
| 14:57:22 | <sunbiz> bwolfe , djazayeri -- Should https://tickets.openmrs.org/browse/RESTWS-16 b closed? |
| 15:51:06 | *** sunbiz has quit IRC |
| 16:16:37 | *** cta has quit IRC |
| 16:29:08 | *** cta has joined #openmrs-sprint |
| 17:07:49 | *** dkayiwa has joined #openmrs-sprint |
| 18:23:58 | *** dkayiwa has quit IRC |
| 18:34:08 | <djazayeri> cta: did you comment that on the ticket? |
| 18:35:21 | <djazayeri> cta: I mostly count on getting email notifications about tickets, and on being able to look at the sprint dashboard to see things that need review |
| 18:35:24 | <djazayeri> i.e. https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10140 |
| 18:35:30 | <OpenMRSBot> <http://ln-s.net/8qD3> (at tickets.openmrs.org) |
| 18:35:58 | <djazayeri> so please make sure you comment on the ticket and set its state ("Committed Code") when you want a formal code review. |
| 18:36:43 | <cta> djazayeri: Darius, I haven't commited yet, it was only for showing my progress on the ticket. |
| 18:36:52 | <djazayeri> oh okay |
| 18:38:38 | <cta> djazaeri: I'm starting to investigate into your "slightly modify request " (general comment from review) |
| 18:38:52 | <djazayeri> okay |
| 18:39:19 | <djazayeri> I'll be around some if you have any questions |
| 18:44:25 | <cta> djazayeri: I think, to achieve that, the simpliest way will be overriding retrieve(), getAll() and asRepresentation() methods within CohortMemberResource class |
| 18:44:42 | <djazayeri> hmm, really? |
| 18:44:49 | <djazayeri> I was hoping it would be easier than that. |
| 18:45:09 | <cta> mm, let me think more |
| 18:45:36 | <djazayeri> So, my idea is that when you fetch a single CohortMember, you get back the rep that you asked for. |
| 18:45:56 | <djazayeri> But when you list all CohortMembers, you get back the rep "one level smaller" than what you asked for. |
| 18:46:22 | <djazayeri> i.e. DEFAULT for "all CohortMembers" -> REF for each individual patient |
| 18:46:40 | <djazayeri> cta: If this turns out to require lots of code, and changes, then _do not do it_ |
| 18:47:32 | <djazayeri> Because if it's not trivial, I'd like to discuss with Burke and Ben first about exactly what behavior we want. |
| 18:48:06 | <cta> ok , I understand |
| 18:49:42 | <cta> djazayeri: Darius, I'll try to do it in best way, and if it will be really difficult, I'll tell you first about that |
| 18:50:29 | <djazayeri> cta: Taking a quick peek at the code, I think that overriding getAll in CohortMemberResource should be enough. |
| 18:50:33 | <djazayeri> and that's not a lot of code |
| 18:50:53 | <cta> so, great! |
| 18:51:13 | <cta> sorry, i'll be more carefull |
| 19:13:52 | *** cta_ has joined #openmrs-sprint |
| 19:17:36 | *** cta has quit IRC |
| 20:23:25 | *** dkayiwa has joined #openmrs-sprint |
| 20:30:23 | *** bwolfe has quit IRC |
| 21:00:03 | *** dkayiwa has left #openmrs-sprint |
| 22:22:03 | *** cta_ has quit IRC |