00:32:55 *** wyclif has joined #openmrs-sprint
11:03:10 *** bwolfe has joined #openmrs-sprint
11:03:10 *** ChanServ sets mode: +o bwolfe
11:10:53 *** bwolfe has quit IRC
12:19:36 *** bwolfe has joined #openmrs-sprint
12:43:35 *** cta has joined #openmrs-sprint
15:14:01 <cta> djazayeri: Hello, Darius. I've already done a basic support for cohort's members. You can review it after my commit. I solved the problem with resource class similary to Saptarshi's approach (and few words about getByUniqueId - I just simply override retrieve method for Cohort member resource).
15:15:06 <djazayeri> cta: great!
15:16:55 <cta> djazayeri: I've already commited it 20204. Also I've recommited code for RESTWS-18 (of course, considering with you comments)
15:17:38 <djazayeri> Okay, just make sure that the revision number is mentioned in a ticket comment, and you do "Committed Code" on the ticket.
15:17:55 <cta> ok, no problem
15:18:01 *** cta has quit IRC
15:21:53 *** djazayeri has left #openmrs-sprint
15:21:54 *** djazayeri has quit IRC
15:25:56 *** bwolfe has quit IRC
15:26:25 *** bwolfe has joined #openmrs-sprint
15:26:25 *** ChanServ sets mode: +o bwolfe
15:56:01 *** bwolfe has quit IRC
16:03:29 *** bwolfe has joined #openmrs-sprint
16:03:29 *** ChanServ sets mode: +o bwolfe
16:27:11 *** cta has joined #openmrs-sprint
16:51:05 *** dkayiwa has joined #openmrs-sprint
16:55:39 *** dkayiwa has quit IRC
17:07:17 *** dkayiwa has joined #openmrs-sprint
17:20:13 *** dkayiwa has quit IRC
17:39:23 *** bwolfe has quit IRC
18:22:48 *** djazayeri has joined #openmrs-sprint
18:22:48 *** ChanServ sets mode: +o djazayeri
18:44:47 *** bwolfe has joined #openmrs-sprint
18:44:47 *** ChanServ sets mode: +o bwolfe
19:20:26 *** bwolfe has quit IRC
19:44:04 *** wyclif has quit IRC
19:44:33 *** wyclif has joined #openmrs-sprint
20:34:26 <cta> djazayeri: Darius, I have read all your comments and made necessarily changes within code. So, if you do not have any questions or suggestions, can I commit code just right now?
20:35:04 <djazayeri> cta: Yes, and mention the revision number in a comment when you do "Committed Code"
20:35:45 <djazayeri> Generally if I've marked a review as completed I'm not going to go back to look at it again. :-)
20:35:53 <cta> djazayeri: Ok, no problem.
20:38:07 <cta> dajazayeri: Thanks for so good review. I really enjoyed it. Thanx.
20:43:38 *** bwolfe has joined #openmrs-sprint
20:43:38 *** ChanServ sets mode: +o bwolfe
20:50:01 *** bwolfe has quit IRC
20:51:24 *** wyclif has quit IRC
20:52:14 <cta> djazayeri: Darius, I've commited code. Also added revision's number when clicked "Commited code" in jira ;-)
20:52:24 <djazayeri> thanks
20:52:56 <cta> Thank you for help, and good bye! See later.
20:52:58 <djazayeri> (the reason I ask people to do that is that the "Source" tab takes ~10 extra seconds to load, which is annoying, so it's much easier if you can tell from the comments what state a ticket is in.
20:53:01 <djazayeri> ciao
20:53:28 *** cta has quit IRC
21:06:27 *** wyclif has joined #openmrs-sprint