00:15:06
|
<djazayeri_> wyclif: I don't see a unit test checked in for RESTWS-94. how do you expect me to test it out and see the retired issue? :-)
|
00:16:46
|
<wyclif> djazayeri, unit test for the resource or controller?
|
00:16:59
|
<djazayeri_> I've been writing them for the controller
|
00:17:12
|
<djazayeri_> but I don't see one for the resource either
|
00:38:13
|
<wyclif> djazayeri, some objects can't be feteched by name, so why should we have getByUniqueId doing a serach by name too for all objects
|
00:39:14
|
<wyclif> because the code would have to go into the method that fetches by uuid
|
00:47:43
|
<djazayeri_> wyclif: the way I'd phrase it is that the resource is responsible for deciding what it wants to support for "getByUniqueId"
|
00:48:18
|
<djazayeri_> if a resource has unique names (as most metadata do) then they may choose to also support getting the resource by name.
|
00:48:25
|
<djazayeri_> But it's up to the resource.
|
00:49:05
|
<wyclif> so we overide the getByUuid methods?
|
00:49:21
|
<djazayeri_> so LocationResource.getByUniqueId can do: l = ls.getLocationByUuid(uid); if (l != null) return l; l = ls.getLocationByName(uid); return l;
|
00:49:22
|
<djazayeri_> yes
|
00:49:51
|
<djazayeri_> That's my plan.
|
00:54:46
|
<wyclif> the downside to this is that for objects that have uuid generated in their own way, it would mean the webservice can end up giving a user an object with a matching name yet the intended to get one with the matching uuid
|
00:54:59
|
<wyclif> or viceversa
|
00:55:45
|
<djazayeri_> so, what did you do in concept mapping where you manually set uuids?
|
00:55:51
|
<wyclif> we need to let the webservice consumer to get what they asked for
|
00:57:02
|
<djazayeri_> you're worried that if I do GET "/ws/rest/location/Unknown+Location" and there's a location whose UUID is "Unknown Location" that will be returned instead of a different one with that name?
|
00:57:45
|
<wyclif> yes
|
00:57:59
|
<djazayeri_> That doesn't strike me as a significant issue.
|
00:58:29
|
<wyclif> i understand unless we make it clear to consumers that this is the behaviour
|
01:00:12
|
<wyclif> and are you coding the test methods by yourself?
|
01:00:37
|
<djazayeri_> Take a look at PatientIdentifierControllerTest, which I just committed recently.
|
01:01:00
|
<djazayeri_> yes, I didn't use the behavior test generator with @should because the methods we're testing are not actually on the class itself, but a superclass.
|
01:08:06
|
<wyclif> i noticed that
|
01:12:28
|
<wyclif> we should probably move the log method to a utility class for reusability
|
01:13:29
|
<djazayeri_> I agree, although really we need to get rid of that logging once we know these things work.
|
03:10:15
|
*** djazayeri_ has quit IRC
|
04:01:01
|
*** bwolfe has joined #openmrs-sprint
|
04:01:01
|
*** ChanServ sets mode: +o bwolfe
|
05:50:42
|
*** djazayeri has joined #openmrs-sprint
|
05:50:42
|
*** ChanServ sets mode: +o djazayeri
|
05:58:06
|
<wyclif> djazayeri, i wonder what mistake i was making or if someone made a change but the problem i had with fetching parent and childLocations is gone
|
06:00:58
|
*** bwolfe has quit IRC
|
06:01:14
|
<djazayeri> wyclif: I noticed you uncommented those lines
|
06:01:46
|
<djazayeri> I did change something in one of of the handlers so it would return something instead of crashing
|
06:01:57
|
<djazayeri> So it could have fixed things
|
06:03:24
|
<wyclif> oh yeah, you added something to do with depth
|
06:03:55
|
<wyclif> djazayeri, cool! i guess that did the trick
|
06:35:19
|
*** dkayiwa has joined #openmrs-sprint
|
06:50:55
|
*** bwolfe has joined #openmrs-sprint
|
06:50:55
|
*** ChanServ sets mode: +o bwolfe
|
07:06:04
|
<bwolfe> dkayiwa: how goes things?
|
07:06:12
|
<bwolfe> are you back in uganda now?
|
07:06:34
|
<dkayiwa> bwolfe: yes am back. just about to start
|
07:09:38
|
<bwolfe> awesome
|
07:09:51
|
<bwolfe> I'm sad you didn't take a bus home and that you aren't here in Eldoret with me... :-/
|
07:23:07
|
<dkayiwa> lolllllllllllllllllllllllllll
|
07:23:44
|
<dkayiwa> i hate traveling in busses for such long distances :)
|
07:30:43
|
*** wyclif has quit IRC
|
07:40:15
|
<bwolfe> how long would that bus be? 6 hours? 8 hours?
|
07:41:02
|
<dkayiwa> i have no idea
|
07:41:17
|
<dkayiwa> u know more kenyan things than i do :)
|
07:41:30
|
<bwolfe> haha
|
07:41:34
|
<bwolfe> doubtful
|
07:41:51
|
<dkayiwa> for sure :D
|
07:41:59
|
<dkayiwa> u even know more swahili than i do
|
07:42:11
|
<bwolfe> hapana
|
07:42:22
|
<bwolfe> sijui swahili!
|
07:42:29
|
<dkayiwa> muzuri :D
|
07:51:13
|
<bwolfe> dkayiwa: "nzuri". :-)
|
07:51:41
|
<bwolfe> (although kenyans here in western region say the technically incorrect "mzuri"
|
07:52:44
|
*** dkayiwa has quit IRC
|
08:07:14
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Edit this Patient (Long Form) controller functionality to add new addresses needs to be updated to use new address field... <http://feedproxy.google.com/~r/OMRStrunk/~3/5P1BWCUyEaM/OpenMRS>
|
08:38:28
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Edit this Patient (Long Form) controller functionality to add new addresses needs to be updated to use new address field... <http://feedproxy.google.com/~r/OMRStrunk/~3/jmHxmOwHbno/OpenMRS>
|
08:43:05
|
<bwolfe> bbl
|
08:52:24
|
*** bwolfe has quit IRC
|
10:44:43
|
*** bwolfe has joined #openmrs-sprint
|
10:44:43
|
*** ChanServ sets mode: +o bwolfe
|
10:46:05
|
*** gauravpaliwal has joined #openmrs-sprint
|
11:12:17
|
*** gauravpaliwal has left #openmrs-sprint
|
11:57:24
|
*** robbyoconnor has quit IRC
|
12:05:06
|
*** dkayiwa has joined #openmrs-sprint
|
12:09:31
|
*** bwolfe has quit IRC
|
12:27:56
|
*** sunbiz has joined #openmrs-sprint
|
12:29:21
|
*** bwolfe has joined #openmrs-sprint
|
12:29:30
|
*** ChanServ sets mode: +o bwolfe
|
12:39:53
|
<sunbiz> bwolfe: do u know how to pass properties from one object to its property object??
|
12:39:54
|
<sunbiz> like for the UserAndPassword if the username property is set... I want to instead set that to the User object which is actually a property of UserAndPassword
|
12:41:19
|
<sunbiz> UserAndPassword {User user, String password} is the class with 2 properties .... if setProperty is called on UserAndPassword, I want that call to actually setProperty on User
|
12:43:38
|
<bwolfe> I think you have to add a setter on the controller for that. see the patient example with setpreferredidentifier I think
|
12:48:03
|
<sunbiz> bwolfe: nothing in the controller
|
12:48:17
|
<bwolfe> oh, sorry, resource
|
12:48:39
|
<sunbiz> yes... I did that in the resource... but it throws an exception
|
12:49:11
|
<bwolfe> whats the exception? can you pastebin the stacktrace?
|
12:50:04
|
<sunbiz> org.openmrs.module.webservices.rest.web.response.ConversionException: username
|
12:50:52
|
<sunbiz> http://pastebin.com/GcmjbnF0
|
12:54:05
|
<bwolfe> sunbiz: pastebin your userresource
|
12:54:40
|
<bwolfe> did you put the @PropertySetter on your resource setting? :-)
|
12:54:45
|
<bwolfe> sunbiz ^^
|
12:55:16
|
<sunbiz> its committed: http://svn.openmrs.org/openmrs-modules/webservices.rest/trunk/omod/src/main/java/org/openmrs/module/webservices/rest/web/resource/UserResource.java
|
12:55:21
|
<OpenMRSBot> <http://ln-s.net/8pOR> (at svn.openmrs.org)
|
12:56:23
|
<sunbiz> bwolfe: where??
|
12:57:12
|
<bwolfe> am thinking you will have to do it like patientresource:69
|
12:58:11
|
<sunbiz> PatientResource:69 has description.addProperty("age");
|
12:58:25
|
<bwolfe> setPreferredName
|
12:59:32
|
<bwolfe> sunbiz: you should keep up to date with the code. ;-) lots of commits/changes during a sprint.
|
13:00:04
|
<sunbiz> bwolfe: I just updated my code
|
13:00:29
|
<sunbiz> even then that line 69 on PatientResource.java says the same thing
|
13:01:59
|
<bwolfe> odd, I just updated and it said no changes for me
|
13:02:00
|
<bwolfe> oh well
|
13:02:07
|
<bwolfe> its the setPreferredName method that I am referring to
|
13:02:10
|
<bwolfe> do you see that?
|
13:02:21
|
<bwolfe> or any other method in patientresource with @PropertySetter on it?
|
13:02:40
|
<sunbiz> yes yes...
|
13:02:44
|
<sunbiz> I see that
|
13:03:31
|
<sunbiz> bwolfe: do I have to do that for all properties??
|
13:03:50
|
<sunbiz> cant I just make all properties except one... to go to user?
|
13:03:52
|
<bwolfe> I fear that you might have to, unless you have a better solution
|
13:04:02
|
<bwolfe> I don't know of a way, but Darius might
|
13:05:11
|
<sunbiz> bwolfe: there is a setProperty and getProperty in the BaseDelegatingResource
|
13:05:11
|
*** dkayiwa has quit IRC
|
13:05:21
|
<sunbiz> I've tried to override that... thinking that might help
|
13:05:26
|
*** dkayiwa has joined #openmrs-sprint
|
13:05:44
|
<sunbiz> and using the PropertyUtils from commons beanutils
|
13:05:48
|
<sunbiz> but that hasnt helped
|
13:09:51
|
<djazayeri> sunbiz: what are you trying to do?
|
13:14:40
|
<sunbiz> djazayeri: Im trying to set the username property to be set on the User, which is a property being sent to UserAndPassword
|
13:19:52
|
*** downeym has joined #openmrs-sprint
|
13:19:52
|
*** ChanServ sets mode: +o downeym
|
13:19:53
|
*** OpenMRSBot sets mode: +o downeym
|
13:19:53
|
<djazayeri> So, one way to do that is to use @PropertySetter
|
13:20:03
|
<djazayeri> (that may be the only way that currently works)
|
13:21:00
|
<djazayeri> The way that would be easier would be to add a new feature for remapping "username" -> "user.username"
|
13:21:32
|
<sunbiz> using the @PropertySetter... too many properties have to be mapped
|
13:21:50
|
<sunbiz> there is a setProperty and getProperty in the BaseDelegatingResource that I've overridden
|
13:21:55
|
<sunbiz> whats that used for??
|
13:26:08
|
*** wyclif has joined #openmrs-sprint
|
13:49:50
|
<djazayeri> sunbiz: that gets called internally by both the create and update methods
|
13:50:12
|
<sunbiz> djazayeri: so... overriding that doesnt help?
|
13:50:21
|
<djazayeri> overriding should help, yes
|
13:50:43
|
<sunbiz> but it doesnt work in setting "username" -> "user.username"
|
13:51:53
|
<djazayeri> basically something like setProperty(...) { if (propertyName.equals("username")) super.setProperty(...); else setPropertyOnUser(...);
|
13:51:59
|
<djazayeri> and write that new method
|
13:52:02
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Attempted followup fix to dashboard Slow to Load for Patients with Many Encounters - TRUNK-1375 <http://feedproxy.google.com/~r/OMRStrunk/~3/lwxf_3Phd-M/OpenMRS>
|
13:52:04
|
<djazayeri> seems like it ought to work
|
13:53:47
|
<sunbiz> djazayeri: I've already done that...
|
13:54:00
|
<sunbiz> and committed the code... but isn't working
|
13:54:31
|
<djazayeri> you committed it? let me update and see what it looks like
|
13:55:27
|
<djazayeri> so, are you seeing a particular error?
|
13:55:45
|
<sunbiz> org.openmrs.module.webservices.rest.web.response.ConversionException: username
|
13:55:45
|
<djazayeri> (I don't think what you did is going to work quite right, because it doesn't actually do type conversion.)
|
13:57:06
|
<djazayeri> (At the very least you need to do the thing with expectedType and convert that's in BaseDelegatingResource
|
13:58:39
|
<djazayeri> sunbiz: looking at the stack trace in the failing create unit test I see that the nested exception is "No bean specified"
|
13:58:50
|
<djazayeri> is use null?
|
13:59:25
|
<sunbiz> yes
|
13:59:34
|
<sunbiz> http://pastebin.com/GcmjbnF0
|
14:00:28
|
<djazayeri> okay, so you need to make sure you instantiate that bean first...
|
14:01:26
|
<djazayeri> i.e. either in newDelegate() or in the constructor for UserAndPassword() create a new user
|
14:01:29
|
<sunbiz> u mean the User bean??
|
14:01:30
|
<djazayeri> new User() I mean
|
14:01:55
|
<djazayeri> hold on
|
14:02:13
|
<djazayeri> yes
|
14:02:41
|
<djazayeri> the newDelegate() method needs to create a new instance of a delegate that can have its properties set.
|
14:03:14
|
<sunbiz> ok... in the getUser(), I can check if the User is null and then do a new User()... will that work??
|
14:04:21
|
<djazayeri> why do it that way?
|
14:04:35
|
<djazayeri> why not just create a new User() in the UserAndPassword() constructor?
|
14:06:10
|
<djazayeri> Basically UserAndPassword is supposed to represent a User and a password
|
14:06:29
|
<djazayeri> so when you construct a new UserAndPassword, it should always construct a User.
|
14:07:29
|
<sunbiz> djazayeri: oops... I thought it was in there... but then shouldnt a User create a new Person??
|
14:07:56
|
<djazayeri> No.
|
14:08:18
|
<sunbiz> org.openmrs.module.webservices.rest.web.response.ConversionException: person
|
14:08:23
|
<djazayeri> I mean that the semantics of UserAndPassword are basically that it's *supposed* to act as if it extends User and adds a password property
|
14:08:36
|
<djazayeri> yes, so the problem there is that you're not doing type conversion in your setProperty override
|
14:09:00
|
<djazayeri> the cause is argument type mismatch, right?
|
14:09:41
|
<djazayeri> you need to do what's in lines 230-233 of BaseDelegatingResource
|
14:10:03
|
<djazayeri> sunbiz: (ideally you'd put it in ConversionUtil, and have both BaseDelegatingResource and UserResource call that)
|
14:12:17
|
<sunbiz> djazayeri: yes... I see the 230-233 of BaseDelegatingResource... adding that to the overridden setProperty method in UserResource should work...right?
|
14:12:27
|
<djazayeri> yes
|
14:32:23
|
<sunbiz> djazayeri: seems to have gotten forward, but this: http://pastebin.com/7xwS3M67
|
14:36:03
|
<djazayeri> sunbiz: I think that's a bug in my code
|
14:36:26
|
<djazayeri> so, I didn't add the getProperty and setProperty methods on Converter until late in the game.
|
14:37:17
|
<djazayeri> The problem is that DelegatingResourceDescription.evaluate calls ConversionUtil.getPropertyWithRepresentation
|
14:37:44
|
<djazayeri> however that does not respect the re-mapping you might do within the getProperty method.
|
14:39:41
|
<sunbiz> djazayeri: u mean with the convertToRepresentation method??
|
14:39:48
|
<sunbiz> I dont see it
|
14:40:08
|
<djazayeri> sunbiz: ~ line 23 in DelegatingResourceDescription
|
14:43:17
|
<djazayeri> Try replacing the return statement around line 123 of DelegatingResourceDescription with this, and see if it works
|
14:43:19
|
<djazayeri> Object propVal = converter.getProperty(delegate, delegateProperty);
|
14:43:21
|
<djazayeri> if (propVal instanceof Collection) {
|
14:43:23
|
<djazayeri> List<Object> ret = new ArrayList<Object>();
|
14:43:25
|
<djazayeri> for (Object element : (Collection<?>) propVal)
|
14:43:27
|
<djazayeri> ret.add(ConversionUtil.convertToRepresentation(element, rep));
|
14:43:29
|
<djazayeri> return ret;
|
14:43:31
|
<djazayeri> } else {
|
14:43:33
|
<djazayeri> return ConversionUtil.convertToRepresentation(propVal, rep);
|
14:43:35
|
<djazayeri> }
|
14:45:49
|
*** downeym_ has joined #openmrs-sprint
|
14:45:49
|
*** ChanServ sets mode: +o downeym_
|
14:46:39
|
<sunbiz> looks like an import statement to me... ahh 123 :)
|
14:48:19
|
*** downeym has quit IRC
|
14:48:19
|
*** downeym_ is now known as downeym
|
15:01:26
|
<sunbiz> djazayeri: doesn't compile... Object propVal = converter.getProperty(delegate, delegateProperty);
|
15:01:55
|
<sunbiz> no suitable method found for getProperty(java.lang.Object,java.lang.String)
|
15:01:55
|
<sunbiz> method org.openmrs.module.webservices.rest.web.resource.impl.BaseDelegatingResource.getProperty(capture#1 of ?,java.lang.String) is not applicable
|
15:01:55
|
<sunbiz> (actual argument java.lang.Object cannot be converted to capture#1 of ? by method invocation conversion)
|
15:02:12
|
<djazayeri> oh, sorry, right, I changed the method sig to
|
15:02:14
|
<djazayeri> public <T> Object evaluate(BaseDelegatingResource<T> converter, T delegate) throws ConversionException {
|
15:06:04
|
<sunbiz> djazayeri: yes, it works now!!
|
15:07:17
|
<sunbiz> djazayeri: lemme me see if the update and retire work as wel
|
15:12:11
|
*** bwolfe has quit IRC
|
15:34:04
|
<sunbiz> djazayeri: http://pastebin.com/5Wzf1gzY
|
15:38:04
|
<sunbiz> djazayeri: the update isnt working
|
15:38:58
|
<djazayeri> sunbiz: on a phone call
|
15:39:30
|
<sunbiz> djazayeri: okies
|
16:04:36
|
<sunbiz> djazayeri: respond to this later... why do we nor return anything on update
|
16:07:24
|
<sunbiz> RFC2616: If a resource has been created on the origin server, the response SHOULD be 201 (Created) and contain an entity which describes the status of the request and refers to the new resource, and a Location header (see section 14.30)
|
16:22:19
|
<djazayeri> sunbiz: re the pastebin from an hour ago, I think the problem is that in the unit test you're trying to compare to a property using
|
16:22:30
|
<djazayeri> PropertyUtils that doesn't exist on UserAndPassword
|
16:23:03
|
<djazayeri> If a resource is *created* then we do return it, as well as a 201 + a Location header.
|
16:23:23
|
*** gauravpaliwal1 has joined #openmrs-sprint
|
16:23:29
|
<djazayeri> But if a resource is *updated* we don't necessarily need to do that.
|
16:23:36
|
*** gauravpaliwal1 has left #openmrs-sprint
|
16:24:00
|
*** gauravpaliwal has joined #openmrs-sprint
|
16:24:02
|
<djazayeri> sunbiz: so, I figure that if you want to update something *and* get its status, you'll do a POST then a GET
|
16:27:30
|
<sunbiz> djazayeri: yes... I figured that one
|
16:27:43
|
<sunbiz> I just assumed it would be the object
|
16:28:20
|
<sunbiz> but for an update nothing returned
|
16:34:20
|
<sunbiz> djazayeri: should I commit the fix to the DelegatingResourceDescription
|
16:40:04
|
<sunbiz> djazayeri: Im ready to commit all the changes... should I commit the DelegatingResourceDescription as well?? it is required to make the UserResource work
|
16:50:55
|
*** gauravpaliwal has quit IRC
|
16:59:23
|
*** djazayeri_ has joined #openmrs-sprint
|
16:59:28
|
<djazayeri> sunbiz: yes, commit that change. it doesn't break anything else, right?
|
16:59:33
|
*** djazayeri_ has quit IRC
|
16:59:39
|
<sunbiz> nope...
|
17:01:35
|
<sunbiz> djazayeri: committed... and creating a review and will add that to the ticker
|
17:03:00
|
<sunbiz> djazayeri: I use this netbeans plugin that comments on the JIRA issue and can do other things on it... should I continue using it?? or is it not acceptable??
|
17:03:45
|
*** wyclif has quit IRC
|
17:03:49
|
<djazayeri> sunbiz: as long as you're correctly setting the ticket status, I don't care if you do it manually or via plugin
|
17:04:19
|
<sunbiz> for every commit it comes automatically... and some more metadata... which I think is useful... and everyone should do it
|
17:05:17
|
*** dkayiwa has quit IRC
|
17:05:30
|
*** dkayiwa has joined #openmrs-sprint
|
17:07:26
|
<djazayeri> sunbiz: yes, I especially like that it always mentions the revision.
|
17:09:39
|
<sunbiz> https://source.openmrs.org/cru/CR-MOD-141
|
17:12:49
|
<sunbiz> djazayeri: should I move to the https://tickets.openmrs.org/browse/RESTWS-85
|
17:13:21
|
<djazayeri> sunbiz: sure. that one will probably be easier than User.
|
17:13:36
|
<djazayeri> :-)
|
17:13:38
|
<sunbiz> djazayeri: and now that I've made some changes to it as well
|
17:14:18
|
<djazayeri> sunbiz: while you're adding person, I bet you'll find that we need to have some other resources to support that.
|
17:14:26
|
<djazayeri> let me know what those are when you come across them
|
17:15:14
|
<sunbiz> djazayeri: sure
|
17:16:16
|
*** cta has joined #openmrs-sprint
|
17:16:27
|
<cta> Hello guys!
|
17:24:14
|
<sunbiz> hey cta
|
17:25:05
|
<cta> Any one now if will be developer call tomorrow?
|
17:25:12
|
<cta> know
|
17:25:28
|
<sunbiz> cta: I think there was an email
|
17:25:32
|
<sunbiz> that it wont happen
|
17:25:59
|
<sunbiz> cta: but this should probably be discussed in the #openmrs room
|
17:26:03
|
<sunbiz> and not the sprint room
|
17:26:28
|
<cta> ok, I just want to know this, thanx
|
17:27:50
|
<cta> I suppose that nobody felt bad of this)))
|
17:34:35
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Fantastic talk today together with @Mifos and @FrontlineSMS about #HFOSS and community building. The first of many - want to join us? #ICT4D <http://twitter.com/OpenMRS/statuses/70898964135821313>
|
17:49:34
|
*** robbyoconnor has joined #openmrs-sprint
|
17:53:23
|
<sunbiz> djazayeri: can we add the code formatter used by Openmrs-core to this module... I dont like committing worngly formatted code
|
17:58:27
|
*** wyclif has joined #openmrs-sprint
|
18:01:08
|
*** wyclif has quit IRC
|
18:02:13
|
*** wyclif has joined #openmrs-sprint
|
18:30:23
|
*** ThePing has joined #openmrs-sprint
|
18:30:24
|
*** ThePing has left #openmrs-sprint
|
18:31:26
|
<djazayeri> sunbiz: yes we can, though I don't know how to get that right, off the top of my head.
|
18:32:29
|
<sunbiz> djazayeri: can I add that to the webservices.rest pom?
|
18:32:54
|
<djazayeri> sunbiz: yes
|
18:33:07
|
<djazayeri> btw, sunbiz, did you create a review for RESTWS-16?
|
18:33:14
|
<sunbiz> sunbiz https://tickets.openmrs.org/browse/TRUNK-2229 why do u call it "crash my server" method??
|
18:33:26
|
<djazayeri> nm, found it
|
18:33:29
|
<sunbiz> djazayeri: yes... and add u to the reviewers
|
18:34:10
|
<djazayeri> if it fits in your workflow, please mention the review (preferrable, URL, otherwise review key, else just say "review created") in a ticket comment
|
18:35:40
|
<sunbiz> I thought it was part of the reviews tab... and ppl got emails
|
18:37:16
|
<djazayeri> it is part of the review tab, but that tab takes ~10 seconds to load for me, so I really prefer to know from a comment whether I'm going to find anythihng.
|
18:51:12
|
<djazayeri> sunbiz: if you're asking about getAllPersons for the web service ticket, don't
|
18:51:31
|
<djazayeri> i.e. the client should not be able to say "get all persons"
|
18:51:47
|
<djazayeri> they should be able to query with a search string, but not just get them all
|
18:52:22
|
<sunbiz> djazayeri: yes... just found that javadoc comment, but didnt find that method
|
18:53:35
|
<djazayeri> anyway, throw a ResourceDoesNotSupportMethod (or whatever that exception is called)
|
18:55:08
|
<sunbiz> where??
|
19:04:59
|
<sunbiz> djazayeri: should I commit all the formatted files with the formatter
|
19:05:14
|
<sunbiz> so that ppl dont get messed up?? without any changes??
|
19:06:14
|
<sunbiz> looks like there are changes that it made to nearly all files
|
19:13:15
|
<sunbiz> djazayeri: what's 'spacing' in the comments?
|
19:13:41
|
<djazayeri> put spaces after if and catch
|
19:13:48
|
<djazayeri> i.e. if(something) -> if (something)
|
19:14:03
|
<djazayeri> alternately you can resolve this using the formatter
|
19:14:32
|
<djazayeri> by the way, I will summarize the review when I'm done...you don't need to go through comment-by-comment while I'm doing it...
|
19:14:52
|
<sunbiz> djazayeri: :)
|
19:15:06
|
<sunbiz> djazayeri: should I commit the formatter??
|
19:15:17
|
<djazayeri> sunbiz: does it work?
|
19:15:25
|
<sunbiz> it looks ugly though... a new line seems often
|
19:15:34
|
<sunbiz> so...its very small lines
|
19:15:36
|
<sunbiz> and then breaks
|
19:16:10
|
<djazayeri> then don't commit it. :-P
|
19:16:20
|
<djazayeri> so, do you need to set the line size?
|
19:16:26
|
<djazayeri> or point it to the openmrs formatter xml?
|
19:18:13
|
<sunbiz> I think it finds the openmrs formatter
|
19:37:54
|
* robbyoconnor steals djazayeri's wallet and then proceeds to steal wyclif's and downeym's wallet too
|
19:38:02
|
* robbyoconnor is the #openmrs pickpocketer
|
19:38:03
|
<downeym> not much in there.
|
19:38:09
|
<robbyoconnor> DAMN IT
|
19:38:18
|
<robbyoconnor> I wanna commit a felony where I actually get something
|
19:38:35
|
<robbyoconnor> or in this case, an e-felony
|
19:40:41
|
<wyclif> e-felony will get you to e-prison(no online access)
|
20:11:11
|
<sunbiz> djazayeri: yes, the code formatting works fine... should I commit
|
20:11:36
|
<sunbiz> all files have CRLF line encoding... and those that I changed have other changes :)
|
20:13:03
|
<djazayeri> sunbiz: is it done the same way as the formatting in core?
|
20:13:28
|
<sunbiz> yes
|
20:13:34
|
<djazayeri> okay, sure
|
20:14:03
|
<sunbiz> do u want the codeFormatter README??
|
20:14:10
|
<sunbiz> I didnt think that was needed
|
20:14:16
|
<sunbiz> its in the core already :)
|
20:14:27
|
<djazayeri> no, as long as it's behaving identically, just commit it
|
20:26:09
|
*** dkayiwa has quit IRC
|
20:31:33
|
*** dkayiwa has joined #openmrs-sprint
|
20:40:20
|
<sunbiz> dkayiwa: are u doing the subtask for PersonResource : https://tickets.openmrs.org/browse/RESTWS-91
|
20:40:40
|
<dkayiwa> yes subbiz
|
20:40:52
|
<dkayiwa> sunbiz :D
|
20:41:39
|
<dkayiwa> is it already done?
|
20:42:14
|
<sunbiz> dkayiwa: nope... but was going towards it as part of the larger ticket
|
20:42:14
|
<dkayiwa> oh
|
20:42:24
|
<dkayiwa> oh i see
|
20:42:35
|
<dkayiwa> i can chose another ticket
|
20:42:49
|
<dkayiwa> just seen that too
|
20:42:56
|
<sunbiz> yes that would be easier I guess
|
20:43:10
|
<sunbiz> than merging
|
20:43:21
|
<dkayiwa> i completely agree
|
20:43:36
|
<dkayiwa> ok no problem. let me browse through for another ticket :)
|
20:50:04
|
*** sunbiz has quit IRC
|
20:55:35
|
*** robbyoconnor has quit IRC
|
21:05:20
|
*** dkayiwa has quit IRC
|
21:05:41
|
*** dkayiwa has joined #openmrs-sprint
|
21:53:36
|
<cta> Sprinters, I've just commited cohorts support (#18). My last build was successfull. Everyone can update and try it out.
|
21:58:40
|
*** downeym has quit IRC
|
22:07:14
|
*** dkayiwa has quit IRC
|
22:22:43
|
*** wyclif has quit IRC
|
22:40:24
|
*** cta has quit IRC
|