| 00:00:17 | <wluyima_> may be i will have to expose methods for the get by name |
| 00:05:54 | <sunbiz> djazayeri: what do we do for the OpenmrsMetaData |
| 00:06:05 | <sunbiz> DataDelegatingCrudResource<T extends OpenmrsData> |
| 00:06:54 | <sunbiz> sorry... I missed the Metadataone... |
| 01:01:03 | <wluyima_> djazayeri, create methods should not set the uuid |
| 01:01:12 | <wluyima_> i think this is not right |
| 01:40:38 | <sunbiz> djazayeri: should the user have a property as password? |
| 01:41:04 | <sunbiz> because it is always salted? |
| 01:41:28 | <sunbiz> and hashed? |
| 03:32:22 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Fixing broken 'add new concept map type' link on the manage concept map types page <http://feedproxy.google.com/~r/OMRStrunk/~3/aMRiHFwNhis/OpenMRS> |
| 04:56:47 | *** sunbiz has left #openmrs-sprint |
| 05:40:34 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Adding purge buttons to concept map types and reference term forms, replacing hidden column by greying... <http://feedproxy.google.com/~r/OMRStrunk/~3/9TVWm0hejbE/OpenMRS> |
| 05:55:38 | *** sunbiz has joined #openmrs-sprint |
| 05:56:23 | <sunbiz> djazayeri: User creation requires password... should that be added as a property to RequestContext |
| 05:56:33 | <djazayeri> sunbiz: good point, User has a non-standard create method |
| 05:56:34 | <sunbiz> because I think that will be passed as a parameter |
| 05:57:11 | <sunbiz> and the password is not a going to be a property on the UserResource |
| 05:57:49 | * sunbiz needs a Person ref |
| 05:58:06 | <sunbiz> actually the User needs a Person ref :) |
| 05:58:29 | <djazayeri> I think the password needs to be included in the posted json content |
| 05:59:17 | <sunbiz> that means as a property?? |
| 06:00:27 | <djazayeri> yes, I should have to post: { username: "xyz", password: "new-password", person: "uuid-of-a-person" } |
| 06:01:41 | <sunbiz> but that'll mean ConversionUtils wont work |
| 06:02:21 | <djazayeri> why not? |
| 06:02:44 | <djazayeri> wluyima_: you still there? |
| 06:03:00 | <sunbiz> because password is not on the real User |
| 06:03:46 | <djazayeri> can you override the save method in the UserResource? |
| 06:03:47 | <sunbiz> I mean on org.openmrs.User |
| 06:05:57 | <djazayeri> can you use @PropertySetter like I do in PatientResource? |
| 06:06:02 | <djazayeri> Oh, probably not. |
| 06:06:31 | <djazayeri> So, how about creating a custom subclass of User that adds the password and secret answer properties |
| 06:06:58 | <sunbiz> I got it working fine... by making the password as a RequestContext property |
| 06:07:24 | <djazayeri> I'm not thrilled about doing it that way. |
| 06:07:34 | <sunbiz> yes... I agree |
| 06:08:04 | <djazayeri> so, yeah, I would vote for: |
| 06:08:05 | <djazayeri> create a class UserAndPassword extends User |
| 06:08:11 | <wluyima_> djazayeri, yes |
| 06:08:24 | <djazayeri> UserResource extends DataDelegatingCrudResource<UserAndPassword> |
| 06:08:25 | <wluyima_> but it is quite late here in indy |
| 06:08:43 | <sunbiz> okies |
| 06:09:23 | <sunbiz> djazayeri: u mean MetadataDelegatingCrudResource |
| 06:09:38 | <djazayeri> wluyima_: no problem, I just wanted to answer questions if you had them |
| 06:09:43 | <djazayeri> I didn't notice those comments till now |
| 06:09:49 | <djazayeri> sunbiz: yes, I meant metadata |
| 06:09:53 | <wluyima_> go ahead |
| 06:11:26 | <wluyima_> djazayeri, right now if a user is creating a new object, they can specify a uuid which i think should be the case, this should be system generated, so the module logic should skip the uuid property when setting properties |
| 06:11:31 | <sunbiz> djazayeri: okies |
| 06:11:38 | <OpenMRSBot> Recent updates in the world of openmrs: Glen McCallum: GSOC Student Evaluation <http://glenmccallum.com/2011/05/16/gsoc-student-evaluation/> |
| 06:12:06 | <wluyima_> djazayeri, sorry! shouldn't be the case |
| 06:12:07 | <djazayeri> wluyima_: I don't think we should explicitly impossible to set the uuid at creation. |
| 06:12:22 | <djazayeri> what if you're doing some sort of metadata sharing or sync |
| 06:12:28 | <djazayeri> (not sure why you'd do that over web services) |
| 06:12:29 | <wluyima_> djazayeri, actually you might be right |
| 06:12:38 | <djazayeri> but you might want to set the uuid manually that way |
| 06:13:33 | <wluyima_> djazayeri, because it turns out with my concept reference terms, i generate the uuid manually |
| 06:15:41 | <djazayeri> so yeah, I don't think we need to treat uuid in a special way |
| 06:17:04 | <wluyima_> goodnight guys |
| 06:17:37 | <wluyima_> djazayeri, thanks for putting up with all our questions |
| 06:17:45 | <djazayeri> gnight |
| 06:19:29 | <sunbiz> wluyima_: goodnite |
| 06:22:14 | <wluyima_> djazayeri, by the way, i committed the changes from the review, see rev:20071 |
| 06:22:21 | <wluyima_> bye |
| 06:22:31 | <djazayeri> bye, please comment that on the ticket |
| 06:42:47 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: switching getAllConceptReferenceTerms to exclude retired terms <http://feedproxy.google.com/~r/OMRStrunk/~3/Ie7g3Z5IGmc/OpenMRS> |
| 07:18:43 | *** djazayeri has quit IRC |
| 07:18:56 | *** dkayiwa has joined #openmrs-sprint |
| 07:19:08 | *** djazayeri has joined #openmrs-sprint |
| 07:19:08 | *** ChanServ sets mode: +o djazayeri |
| 08:03:22 | *** sunbiz has quit IRC |
| 08:36:39 | *** dkayiwa has quit IRC |
| 09:03:10 | *** dkayiwa has joined #openmrs-sprint |
| 09:37:53 | *** dkayiwa has quit IRC |
| 12:14:52 | *** bwolfe has joined #openmrs-sprint |
| 12:14:52 | *** ChanServ sets mode: +o bwolfe |
| 12:19:04 | *** sunbiz has joined #openmrs-sprint |
| 12:56:35 | <bwolfe> wluyima_: whatcha working on now? |
| 13:25:18 | *** cta has joined #openmrs-sprint |
| 13:25:24 | <sunbiz> how do we manage the Person... |
| 13:25:54 | <sunbiz> can't ref to him now... because PersonResource doesn't have the correct properties |
| 13:25:57 | <sunbiz> like gender |
| 13:26:52 | <sunbiz> bwolfe or djazayeri ?? |
| 13:27:17 | <bwolfe> where are you managing it ? |
| 13:27:27 | <bwolfe> (aka, what do you mean by "manage") ? |
| 13:27:39 | <sunbiz> for the User.... it has a ref to a Person |
| 13:28:33 | <sunbiz> so... if I POST say, {username:xyz, password: Abc, person:<uuid>} doesnt work |
| 13:29:07 | <bwolfe> so you're saying in creation? |
| 13:29:17 | <sunbiz> yes |
| 13:29:19 | <bwolfe> if you know the uudi of a person, it means you don't have ot pass the other props, right? |
| 13:29:27 | <bwolfe> so you just look up the person by uuid (or the framework shoudl) |
| 13:29:48 | <sunbiz> there is just a placeholder at the moment with a getUri |
| 13:30:02 | <sunbiz> not the properties to get a Person from the uui |
| 13:30:27 | <bwolfe> oh, so you're saying you're blocked on personresource being finished? |
| 13:30:36 | <sunbiz> so... basically... the PersonResource should be finished |
| 13:30:38 | <sunbiz> dont u agree?? |
| 13:31:18 | <sunbiz> for the record Im doing: https://tickets.openmrs.org/browse/RESTWS-16 |
| 13:32:06 | <bwolfe> can't you just implement a few methods and its done for you? like getByUniqueId ? |
| 13:32:37 | <sunbiz> https://tickets.openmrs.org/browse/RESTWS-85 - so RESTWS-16 depends on RESTWS-85 |
| 13:32:45 | <sunbiz> yes... I can be |
| 13:33:21 | <bwolfe> or have you updated since yesterday? darius put in the basecrudcontroller which does 90% of the work in the controllers now |
| 13:33:47 | <sunbiz> bwolfe: yes, I've updated |
| 13:34:20 | <sunbiz> the problem is there isnt a Representation for a PersonResource |
| 13:40:04 | <sunbiz> bwolfe: move to RESTWS-85 then?? |
| 13:41:05 | <bwolfe> !ticket REST-85 |
| 13:41:05 | <OpenMRSBot> bwolfe: Allow me to help you with that. More details on ticket REST-85 can be found at http://tickets.openmrs.org/browse/REST-85 |
| 13:41:25 | <bwolfe> sure |
| 13:41:40 | <bwolfe> but I would think you could just add one quick method and you could continue with some user stuff |
| 13:42:08 | <sunbiz> bwolfe: I was asking u :P |
| 13:42:29 | <bwolfe> oh, yes, I guess you need the rep too |
| 13:42:35 | <bwolfe> sure, move on and claim that one then. :-) |
| 13:42:47 | <bwolfe> attach your current patch to the user ticket in case you don't make it back there for some reason |
| 13:43:43 | * sunbiz thinks Ben to take that ticket and spike |
| 13:43:53 | <sunbiz> nevermind then... |
| 13:45:22 | <bwolfe> ? |
| 13:46:40 | <bwolfe> argh! its been 2 weeks since I committed things...and I already forget how to do it. (left out hte ticket number in my message) |
| 13:48:03 | <wluyima_> bwolfe, now am working on https://tickets.openmrs.org/browse/RESTWS-94 |
| 13:48:39 | <bwolfe> wluyima_: awesome |
| 13:52:17 | <sunbiz> bwolfe: Im doing to the PersonResource whatever is required... for time-being and then move to RESTWS-85 |
| 13:52:32 | <sunbiz> ok?? |
| 13:52:45 | <bwolfe> ok |
| 13:52:50 | <bwolfe> are you claiming both? |
| 13:52:54 | <bwolfe> (is fine if you do) |
| 14:08:35 | <sunbiz> bwolfe: not claiming yet... will commit some small pieces that are required... |
| 14:08:53 | <sunbiz> and then move to the PersonResource ticket |
| 14:09:43 | <bwolfe> ok, that works |
| 14:28:18 | *** Zabil has joined #openmrs-sprint |
| 14:46:50 | *** bwolfe has quit IRC |
| 15:32:16 | *** Zabil has quit IRC |
| 15:54:16 | <cta> Hello guys! I have a question. |
| 15:57:17 | <cta> When I'm creating new Cohort I'm sending cohort's members ids as follows: 'memberIds: [ 2, 6 ]' but ConversionUtil.setConvertedProperty() method fails in this case, 'cause cannot set value [2, 6] to memberIds (has type TreeSet) |
| 15:57:50 | <cta> are there any woraround? |
| 16:12:52 | <djazayeri> good morning all |
| 16:13:37 | <djazayeri> cta: are you still stuck on that? |
| 16:14:20 | <cta> djazayeri: what do you mean? |
| 16:14:39 | <djazayeri> the question you asked 20 minutes ago |
| 16:14:48 | <djazayeri> about converting [2, 6] to a TreeSet |
| 16:14:55 | <cta> yes |
| 16:15:37 | <djazayeri> sunbiz: if you're still dealing with the issue from 3 hours ago, just create a placeholder for PersonResource, like is done in PatientIdentifierTypeResource |
| 16:15:55 | <djazayeri> cta: what's the whole stack trace? |
| 16:16:30 | <djazayeri> is the "cannot set value ..." coming from an org.openmrs class? |
| 16:17:01 | <cta> top of trace is: |
| 16:17:01 | <cta> at org.openmrs.module.webservices.rest.web.ConversionUtil.setConvertedProperty(ConversionUtil.java:66) |
| 16:17:02 | <cta> at org.openmrs.module.webservices.rest.web.ConversionUtil.setConvertedProperties(ConversionUtil.java:33) |
| 16:17:27 | <djazayeri> there are probably a lot of nested Caused By right? |
| 16:18:06 | <cta> Caused by: org.openmrs.module.webservices.rest.web.response.ConversionException: Don't know how to convert from class java.util.ArrayList to interface java.util.Set |
| 16:22:37 | <djazayeri> cta: good point |
| 16:22:52 | <cta> not very good)) |
| 16:22:53 | <djazayeri> so, that ConversionUtil.convert method is kind of hacky |
| 16:23:31 | <djazayeri> at some point I think we want to replace it with some proper spring framework. |
| 16:23:52 | <djazayeri> but for now, I think the fix is to add another branch for "else if (object instanceof Collection)" |
| 16:24:22 | <djazayeri> and use reflection to convert from the incoming collection type to the expected collection type. |
| 16:24:58 | <cta> So, can I make that "magic" ( "else if (object instanceof Collection)") or you? |
| 16:25:07 | <djazayeri> can you do it? |
| 16:25:12 | <cta> yep, |
| 16:25:18 | <djazayeri> okay, go ahead then. |
| 16:25:38 | <cta> thanx a lot for a help, Darius!!! |
| 16:25:47 | <djazayeri> no problem |
| 16:26:08 | <djazayeri> (the code will probably get a bit tricky, because of the generic types) |
| 16:26:41 | <djazayeri> and you'll probably also need to add handling of the Integer class alongside the special case for Date. |
| 16:27:27 | <sunbiz> djazayeri: PatientIdentifierTypeResource doesnt have a representation |
| 16:29:26 | <djazayeri> sunbiz: I believe that gets handled (at least for Ref representation) by the DataDelegatingCrudResource superclass |
| 16:29:50 | <sunbiz> djazayeri: create user shouldn't need a org.openmrs.Person.gender... right?? just should need {"username":"test","password":"Admin@123","person":{"uuid":"personUuid"}} |
| 16:30:17 | <djazayeri> that should be {"username":"test","password":"Admin@123","person":"personUuid"} |
| 16:30:23 | <sunbiz> but I need to extend DataDelegatingCrudResource<Person> |
| 16:31:06 | <djazayeri> I'm saying that I couldn't get create/fetch working on PatientIdentifier until I put in that placeholder for PatientIdentifierType. |
| 16:31:16 | <djazayeri> I assume you can do the same by putting in a placeholder for Person |
| 16:31:31 | <sunbiz> yes... I've put a place holder is bad looking representation |
| 16:31:37 | <sunbiz> that will be dealth with in the other ticket |
| 16:32:06 | <djazayeri> "person":{"uuid":"personUuid"} -> a person with only the uuid property set |
| 16:32:17 | <djazayeri> "person":"personUuid" -> fetch the person from the DB with the given uuid |
| 16:32:20 | <sunbiz> ahhh... yes |
| 16:32:24 | <sunbiz> booo |
| 17:21:48 | <wluyima_> djazayeri, has anyone run into issues with the retired property? |
| 17:22:13 | <djazayeri> wluyima_: oh, yes, something coming from jackson json conversion? |
| 17:22:35 | <djazayeri> or what? |
| 17:22:39 | <wluyima_> yes, getting to confused between isRetired and getRetired |
| 17:23:02 | <wluyima_> it complains that these are conflicting getters |
| 17:23:32 | <djazayeri> what class? |
| 17:24:15 | <djazayeri> I'm aware of that problem. (By having both isRetired() and getRetired() we are not following conventions.) |
| 17:24:41 | <djazayeri> There's a ticket in the 2.0 UI framework where I was discussing this with Mike. |
| 17:24:58 | <djazayeri> And there was a jackson property we might be able to change. |
| 17:25:13 | <djazayeri> or rather, an annotation we might be able to put on our getRetired. |
| 17:25:31 | <wluyima_> Location |
| 17:25:38 | <djazayeri> But in the rest module, jackson should really only be converting to/from SimpleObject, right? |
| 17:26:09 | <wluyima_> the problem is when i try to include childLocations or parentLocation |
| 17:26:35 | <djazayeri> I think those should also get converted though, right? |
| 17:26:43 | <wluyima_> the ironic thing is that when i don't include them, the problem doesn't show up |
| 17:26:57 | <djazayeri> i.e. you'd do something like addProperty("parentLocation", Representation.REF) |
| 17:27:04 | <djazayeri> and same for child locations. |
| 17:27:05 | <wluyima_> i did that |
| 17:27:31 | <djazayeri> can you show me a stack trace through pastebin? |
| 17:28:59 | <wluyima_> question, is parentLocation considered a subresource |
| 17:29:18 | <djazayeri> no, parentLocation should be a property |
| 17:29:34 | <wluyima_> and childLocations? |
| 17:29:35 | <djazayeri> childLocations...that's an interesting question. |
| 17:30:06 | <djazayeri> for now I'd say no, make them a regular property. |
| 17:35:40 | <djazayeri> back in a few |
| 17:39:37 | *** wluyima_ has quit IRC |
| 17:42:46 | *** Guest57204 has joined #openmrs-sprint |
| 17:43:01 | *** Guest57204 is now known as wyclif |
| 17:56:56 | *** dkayiwa has joined #openmrs-sprint |
| 17:59:15 | <sunbiz> djazayeri: MetadataDelegatingCrudResource cannot provide auditInfo?? |
| 18:03:03 | <djazayeri> sunbiz: you probably have to copy the method over from DataDelegatingCrudResource |
| 18:03:15 | <djazayeri> they differ in that one has retired and the other has voided |
| 18:09:15 | <sunbiz> djazayeri: yes... copying it then :) |
| 18:17:46 | *** bwolfe has joined #openmrs-sprint |
| 18:17:46 | *** ChanServ sets mode: +o bwolfe |
| 18:23:38 | <cta> bwolfe: I've already impemented and tested 1-6 subtasks for cohorts. But now I'd like to clarify some thing |
| 18:23:54 | <bwolfe> awesome |
| 18:23:56 | <bwolfe> ok, whats that? |
| 18:24:40 | <cta> sub-task "patient" sub-resources means that I should return list of patients for cohort? |
| 18:26:20 | <bwolfe> yes, probably a list of patients as the subresource |
| 18:26:44 | <bwolfe> it'll be a list of "links" or "refs" (whatever you want to call them) unless the user wants a full |
| 18:27:17 | <cta> ok, and one more |
| 18:29:01 | <sunbiz> djazayeri: on full representation of a user I get: Unable to convert object into response content |
| 18:29:26 | <sunbiz> this is my GET /openmrs/ws/rest/user/19d5aac7-0ada-468e-bfc7-8356925a0e6d?v=full |
| 18:30:17 | <cta> bwolfe: it's related to testing - As we do not have cohorts in standardTestDataset.xml can you add entries for cohorts into that file. 4 lines will be enought. I can resend them for you. |
| 18:30:36 | <bwolfe> are they in any other data set? |
| 18:30:44 | <bwolfe> you could create your own xml and reference that |
| 18:31:20 | <bwolfe> we should put some in the standard set too though. that would be a separate ticket on trunk. (the ws module should not depend on that though, should still use its own so its backwards compatible) |
| 18:33:20 | <cta> so, ok, I understood |
| 18:33:55 | <cta> and what will be a proof of ticket's success completion? |
| 18:34:31 | <bwolfe> unit tests I think |
| 18:34:40 | <bwolfe> and a code review |
| 18:34:50 | <bwolfe> and an eventual example application that reads from the urls |
| 18:35:42 | <cta> but application is a separate ticket as I know |
| 18:38:54 | <cta> bwolfe: so, I'll attach corresponding screenshots and entire patch for RESTWS-18 tomorrow (or, in worse case - day after tomorrow) |
| 18:40:01 | <bwolfe> no screenshots needed |
| 18:40:24 | <bwolfe> and if you are confident you don't break the build, go ahead and commit it and comment on the ticket you did as much. |
| 18:40:33 | <bwolfe> I can't remember, do you have commit rights yet taras? |
| 18:42:17 | <cta> I don't have commit rights yet. All my patches so far were commited by wyclif or by you |
| 18:43:00 | <cta> patches for core, of course, not for restws |
| 18:49:09 | <bwolfe> cta: ok, see http://wiki.openmrs.org/display/docs/Code+Repository#CodeRepository-RequestingRepositoryAccess |
| 18:49:10 | <OpenMRSBot> <http://ln-s.net/8m_A> (at wiki.openmrs.org) |
| 18:49:17 | <bwolfe> you will need access for gsoc anyway |
| 18:49:46 | <cta> yep, thanx, I'll see |
| 18:54:38 | *** bwolfe has quit IRC |
| 18:54:49 | *** dkayiwa has quit IRC |
| 19:09:21 | <cta> djazayeri: as we do not have any cohorts within in-memory data set, my test will fail after commit, how to avoid it? |
| 19:09:59 | <cta> now all tests for cohorts are sucessfull |
| 19:19:51 | *** bwolfe has joined #openmrs-sprint |
| 19:19:51 | *** ChanServ sets mode: +o bwolfe |
| 19:20:11 | <bwolfe> ok, back, sorry guys...had to fix my internet situation here at the house |
| 19:20:59 | <djazayeri> cta: you could include a custom test dataset with a cohort |
| 19:21:10 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @healthglobal: "open-souce EMRs are coming" an article from @TheLancet http://bit.ly/mzd6Bo saludos @jblaya @CamiloErazoL @TheLancet ... <http://twitter.com/OpenMRS/statuses/70563955315191808> || On Twitter: OpenMRS: Some helpful thoughts from #OpenMRS mentor Glen McCallum at the start of Google Summer of Code this year: http://bit.ly/kU95Hh #GSoC <http://twitter.com/OpenMRS/statuses/70563660505952256> |
| 19:21:39 | <cta> ok |
| 19:22:14 | <cta> thanx one more |
| 19:59:45 | <sunbiz> on trying to retire... I am getting Unknown entity: org.openmrs.module.webservices.rest.web.resource.UserAndPassword |
| 20:00:00 | <sunbiz> do u know how to solve this? |
| 20:03:43 | <djazayeri> Are you doing Context.getUserService().retireUser(userAndPassword)? |
| 20:04:03 | <djazayeri> sunbiz: or retireUser(userAndPassword.getUser())? |
| 20:04:26 | <djazayeri> I wonder if hibernate freaks out because it doesn't recognize our subclass... |
| 20:04:32 | <djazayeri> does save work and retire doesn't? |
| 20:04:55 | <sunbiz> djazayeri: I guess that was the problem... lemme try |
| 20:05:42 | <sunbiz> BTW, should there be a User property on the subclass? |
| 20:05:59 | <sunbiz> userAndPassword.getUser() ?? |
| 20:06:27 | <djazayeri> well, I think that last night I said make it a subclass, but I wonder if that was wrong |
| 20:06:37 | <djazayeri> because hibernate won't know how to save it... |
| 20:07:14 | <djazayeri> does it need to be class UserAndPassword { private User user; private String password; } ? |
| 20:07:58 | <sunbiz> yes for the save... it needs userservice.saveUser (User user, String password) |
| 20:09:27 | <djazayeri> sunbiz: I mean: have you gotten save/create to work? |
| 20:09:34 | <sunbiz> yes |
| 20:09:57 | <djazayeri> by doing UserService.saveUser(userAndPassword, password)? |
| 20:10:11 | <sunbiz> nope |
| 20:10:42 | <sunbiz> saveUser( us.getUserByUuid( user.getUuid()), user.getPassword()) |
| 20:11:09 | <sunbiz> UserAndPassword user = new UserAndPassword() |
| 20:12:22 | <sunbiz> its a little convoluted... but saves |
| 20:12:52 | <djazayeri> sunbiz: how does that let you create a new user? |
| 20:13:46 | <djazayeri> with taht getUserByUuid call? |
| 20:13:51 | <sunbiz> I do a check if the user exists... if it does not new User(user.getPerson()), user.getPassword() |
| 20:14:10 | <sunbiz> sorry: saveUser( new User(user.getPerson()), user.getPassword() ) |
| 20:15:13 | <djazayeri> sunbiz: okay, but that's not going to allow you to edit properties on the user, right? |
| 20:16:24 | <sunbiz> nope... should I commit... what works |
| 20:16:37 | <sunbiz> djazayeri: so u can comment easily and suggest changes? |
| 20:16:43 | <djazayeri> sure |
| 20:16:58 | <sunbiz> djazayeri: I will ignore other tests |
| 20:20:03 | <djazayeri> sunbiz: I need to run out and get lunch, but I'll be back to look at this in 30-40 minutes |
| 20:21:05 | <sunbiz> djazayeri: okies |
| 20:43:04 | *** bwolfe has quit IRC |
| 20:47:35 | <djazayeri> sunbiz: I'm back |
| 20:48:41 | <sunbiz> djazayeri: in the meantime... I was doing https://tickets.openmrs.org/browse/RESTWS-12 |
| 20:48:53 | <sunbiz> seemed small :) |
| 20:50:24 | <wyclif> djazayeri, i have committed code for https://tickets.openmrs.org/browse/RESTWS-94, but i still failed to figure out how to get around the retired column |
| 20:51:00 | <wyclif> djazayeri, i guess we will figure out how to handle this |
| 20:51:49 | <djazayeri> wyclif: i'll check it out |
| 20:53:17 | <sunbiz> djazayeri: can you check if the UserAndPassword is what u were thinking?? or should it not be subclass... and just have User as a property? |
| 20:54:11 | <djazayeri> sunbiz: yes, did you check it in? |
| 20:54:55 | <sunbiz> yes |
| 20:55:13 | <sunbiz> https://tickets.openmrs.org/browse/RESTWS-85 - it shows in the source tab |
| 20:55:23 | <sunbiz> sorry wrong one... |
| 20:55:53 | <sunbiz> !ticket RESTWS-16 |
| 20:55:53 | <OpenMRSBot> sunbiz: Allow me to help you with that. More details on ticket RESTWS-16 can be found at http://tickets.openmrs.org/browse/RESTWS-16 |
| 21:03:44 | <sunbiz> djazayeri: do u see the problem?? |
| 21:04:08 | <djazayeri> what's the exception? |
| 21:04:24 | <sunbiz> the update doesnt work... |
| 21:04:46 | <djazayeri> ok, hold on, i have a sandwich in one hand |
| 21:16:11 | *** djazayeri has quit IRC |
| 21:20:12 | *** djazayeri_ has joined #openmrs-sprint |
| 21:22:54 | *** cta has quit IRC |
| 21:24:05 | *** sunbiz has left #openmrs-sprint |
| 21:24:13 | *** wyclif has quit IRC |
| 21:29:02 | *** sunbiz has joined #openmrs-sprint |
| 21:40:49 | <sunbiz> djazayeri_: https://source.openmrs.org/cru/CR-MOD-135 review for https://tickets.openmrs.org/browse/RESTWS-12 |
| 21:41:22 | <djazayeri_> sunbiz: thanks, i'll review that after i review wyclif's checkin. |
| 21:43:17 | <sunbiz> djazayeri_: thanks! |
| 22:36:19 | *** sunbiz has left #openmrs-sprint |
| 22:36:25 | *** sunbiz has joined #openmrs-sprint |
| 22:36:27 | *** sunbiz has left #openmrs-sprint |
| 23:46:04 | *** wyclif has joined #openmrs-sprint |