| 00:07:59 | *** sunbiz has quit IRC |
| 08:05:17 | *** djazayeri_ has quit IRC |
| 10:28:38 | *** dkayiwa has joined #openmrs-sprint |
| 10:45:54 | *** dkayiwa has quit IRC |
| 11:18:28 | *** dkayiwa has joined #openmrs-sprint |
| 11:30:36 | *** downeym has joined #openmrs-sprint |
| 11:30:36 | *** ChanServ sets mode: +o downeym |
| 11:30:37 | *** OpenMRSBot sets mode: +o downeym |
| 12:07:24 | *** sunbiz has joined #openmrs-sprint |
| 12:21:06 | *** bwolfe has joined #openmrs-sprint |
| 12:21:06 | *** ChanServ sets mode: +o bwolfe |
| 12:38:58 | *** dkayiwa has quit IRC |
| 12:46:22 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Mark your calendars! #OpenMRS user/implementer training workshop in #Kenya June 8-10: http://reach.ampath.or.ke/ #ICT4D #eHealth <http://twitter.com/OpenMRS/statuses/70099973722742784> |
| 13:25:13 | *** cta has joined #openmrs-sprint |
| 13:25:20 | <cta> hello |
| 13:26:43 | <sunbiz> cta: hello |
| 13:27:03 | <sunbiz> cta: Im Saptarshi, who are u?? |
| 13:27:30 | <cta> I'm not Saptarshi,I'm Taras Chorny |
| 13:28:23 | <cta> sunbiz: nice to met you, Saptarshi! |
| 13:29:10 | * downeym waves |
| 13:35:00 | <sunbiz> Hi, nice to see you Taras |
| 13:35:17 | <sunbiz> we are probably 30min early... for the meeting :) |
| 13:36:13 | <downeym> http://go.openmrs.org/time |
| 13:36:48 | <cta> yep, but anyway it's better to be early that to be late |
| 13:52:57 | *** downeym has quit IRC |
| 13:53:17 | *** downeym has joined #openmrs-sprint |
| 13:53:17 | *** ChanServ sets mode: +o downeym |
| 13:53:17 | *** OpenMRSBot sets mode: +o downeym |
| 13:56:38 | *** rafa has joined #openmrs-sprint |
| 13:56:38 | *** ChanServ sets mode: +v rafa |
| 13:57:03 | <rafa> hi bwolfe |
| 13:57:14 | <bwolfe> hey rafal |
| 13:57:22 | <rafa> how are you? |
| 14:01:06 | *** wluyima_ has joined #openmrs-sprint |
| 14:05:07 | <cta> guys, I'd like to know whether current meeting will be held by using skype or just on IRC? |
| 14:06:08 | <rafa> bwolfe: I'd like to know that as well :) |
| 14:06:35 | <bwolfe> I think we'll start here on irc and open up a skype call as soon as darius wakes up |
| 14:06:52 | <rafa> :) |
| 14:06:53 | <cta> cool)) |
| 14:08:27 | <bwolfe> sheesh, 8 mins after, sorry, didn't notice that |
| 14:08:32 | <bwolfe> everyone have the module checked out? |
| 14:08:50 | <bwolfe> first page to read/skim is: https://wiki.openmrs.org/display/projects/Web+Services+API+%28Design+Page%29 |
| 14:08:52 | <wluyima_> sure |
| 14:08:58 | <OpenMRSBot> <http://ln-s.net/8p2$> (at wiki.openmrs.org) |
| 14:09:17 | <bwolfe> everyone MUST have a recent copy of trunk. (within the last week or so) |
| 14:09:25 | <bwolfe> otherwise none of the rest urls will work |
| 14:09:43 | <bwolfe> (I added a /ws/* mapping to the core web.xml pointing at spring) |
| 14:11:22 | <rafa> bwolfe: I don't have the module checked out yet. Will I need it now? |
| 14:11:35 | <cta> yep, I've downloaded and built it yesterday, testing of module was almost fine |
| 14:12:21 | <bwolfe> rafa: yes, check out http://svn.openmrs.org/openmrs-modules/webservices.rest/trunk through maven |
| 14:12:26 | <OpenMRSBot> <http://ln-s.net/8p2:> (at svn.openmrs.org) |
| 14:12:28 | <bwolfe> (the through maven part is important) |
| 14:12:43 | <bwolfe> cta, darius has added some stuff overnight, so be sure to do an update |
| 14:12:49 | <rafa> good then |
| 14:13:03 | <cta> ok, thanx |
| 14:13:48 | <bwolfe> next item of business: we'll be doing "post-commit" reviews of most things |
| 14:14:41 | <bwolfe> so if your code doesn't break any compiling, commit, link to ticket in message, and then create a crucible review with ((darius|ben) |
| 14:16:27 | <rafa> very nice |
| 14:16:31 | <sunbiz> bwolfe: so we select any ticket we want to start with?? |
| 14:17:16 | <bwolfe> yeah, if there is one that you are eyeing, let me know |
| 14:17:24 | <sunbiz> you know, https://tickets.openmrs.org/browse/RESTWS-12 is not valid as WSUtil does not exist anymore |
| 14:17:32 | <bwolfe> (we want to make sure the higher priority tickets are done first, so its not totally willy-nilly) |
| 14:18:39 | <sunbiz> https://tickets.openmrs.org/browse/RESTWS-14 - I was thinking of this |
| 14:19:04 | <cta> RESTWS-24 - I think that I'm able to do it |
| 14:19:38 | <rafa> bwolfe: I've got limited time so I'd appreciate if you could help me finding something doable in up to 8 hours and some extra time for fixes |
| 14:19:58 | <sunbiz> cta, RESTWS-24 seems to be assigned to darius already |
| 14:20:20 | <bwolfe> yeah, cta, pick a differnet one. :-) |
| 14:20:21 | <cta> ow, sorry |
| 14:20:44 | <cta> I just forgot to update the page since yesterday |
| 14:20:48 | <bwolfe> sunbiz: that is a lower priority one and might be more suited to rafa's limited timeframe |
| 14:21:28 | <sunbiz> bwolfe: okkk... yes I agree |
| 14:21:55 | <bwolfe> rafa: can you take on https://tickets.openmrs.org/browse/RESTWS-14 ? |
| 14:22:06 | <rafa> sure |
| 14:22:11 | <bwolfe> rafa: check out the restmodule from svn and you can copy/paste a lot of code |
| 14:22:28 | <cta> bwolfe: what about this RESTWS-19? |
| 14:22:56 | <bwolfe> cta: how about https://tickets.openmrs.org/browse/RESTWS-18 instead ? |
| 14:23:02 | <rafa> bwolfe: okay, I'm settled |
| 14:23:24 | <bwolfe> I fear that the obsresource is large and hairy |
| 14:23:31 | <cta> bwolfe: no problem |
| 14:23:38 | <bwolfe> rafa: ok, assign yourself to the ticket and take off |
| 14:23:59 | <bwolfe> cta: ok, assign yourself to 18 and get to work. :-D |
| 14:24:13 | <rafa> bwolfe: I meant to take off on Sunday :) |
| 14:24:22 | <bwolfe> ooo, one last item of business. how is this time for everyone for a daily 5 minute checkin? (the 10am time) |
| 14:24:41 | <wluyima_> i will pick from the remaining ones |
| 14:24:41 | <bwolfe> rafa: you would have just spun your wheels, darius finished out the patientresource last night I think |
| 14:24:58 | <bwolfe> so now it should be easier to copy/paste from patientresource and patientcontroller |
| 14:25:06 | <bwolfe> everyone: also see https://wiki.openmrs.org/display/projects/Adding+a+Web+Service+Step+by+Step+Guide+for+Core+Developers |
| 14:25:10 | <OpenMRSBot> <http://ln-s.net/8p2E> (at wiki.openmrs.org) |
| 14:25:26 | <bwolfe> I updated it this morning so that it refers to all the /new/ wording of classes and annotations |
| 14:25:27 | <sunbiz> bwolfe: u didn't suggest one for me?? |
| 14:25:38 | <sunbiz> https://tickets.openmrs.org/browse/RESTWS-16 ... good ?? |
| 14:25:42 | <bwolfe> wyclif: use this page to https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&mode=hide&jqlQuery=project+%3D+%22WebServices.REST+Module%22+AND+fixVersion+%3D+%22Sprint+1%22+AND+status+%3D+%22Ready+for+Work%22+AND+%28labels+is+EMPTY+OR+labels+%21%3D+epic%29+AND+resolution+%3D+Unresolved |
| 14:25:46 | <OpenMRSBot> <http://ln-s.net/8p2F> (at tickets.openmrs.org) |
| 14:25:52 | <bwolfe> sunbiz: i was waiting for you to suggest another one. :-) |
| 14:25:53 | <wluyima_> you can one for me too |
| 14:25:56 | <cta> bwolfe: When I should done it before my limit finishes, more precisely before may 23rd |
| 14:26:41 | <cta> bwolfe: are there anu tim e limits for this ticket |
| 14:26:49 | <bwolfe> cta 2 weeks for everything. :-) |
| 14:26:57 | <cta> cool!!! |
| 14:27:00 | <bwolfe> that one does not have any dependencies, so you are good |
| 14:27:24 | <bwolfe> sunbiz: sorry, internet slow here. yeah, userresource is good |
| 14:28:50 | <sunbiz> bwolfe: thanks then... |
| 14:29:08 | <bwolfe> wyclif, https://tickets.openmrs.org/browse/RESTWS-105 ? |
| 14:29:13 | <sunbiz> bwolfe: BTW, we should remove the WSUtil reference from tickets... its called RestUtil now I guess |
| 14:29:18 | <bwolfe> wluyima_: should be a quick one for you :-) |
| 14:29:31 | <bwolfe> sunbiz: thanks, I'll do that now |
| 14:30:34 | <wluyima_> bwolfe great!! |
| 14:31:28 | <wluyima_> so are we set? |
| 14:32:10 | <bwolfe> I think so. just need to assign one to downeym and we're good ;-) |
| 14:32:50 | <wluyima_> ok, i need to restart my machine, will be back in a sec |
| 14:32:55 | <cta> guys, may I ask a technical question? |
| 14:33:00 | <wluyima_> sure |
| 14:33:08 | <cta> I have a question that is related to transferring list of resources back to client? What will be the best approach: using of wrapper object for lists of resources or something else? |
| 14:33:41 | <downeym> heh |
| 14:34:37 | <bwolfe> cta: I think there is a method in restutil that does that for you. I need to double check to make sure darius hasn't deleted that method since I first made it. :-) |
| 14:34:46 | <bwolfe> cta: are you referring to a cohort object or a list of cohorts? |
| 14:34:52 | *** wluyima_ has quit IRC |
| 14:34:59 | <cta> to list of cohorts |
| 14:36:28 | <bwolfe> cta: yeah, that'd essentially just be printing out the cohortresource multiple times. def should NOT be a separate resource/object |
| 14:36:59 | <cta> bwolfe: yes,it looks that there isn't such method within restutil |
| 14:37:05 | <bwolfe> grr |
| 14:37:48 | <bwolfe> cta: ok, looks like maybe its not needed now. he is using more spring magic than I was. look at PatientController.findPatients |
| 14:38:05 | <bwolfe> control-click into the ".search" method and you will see it is just returning a list of the objects |
| 14:38:09 | <cta> ok, just a moment |
| 14:40:01 | <bwolfe> brb, checking for better internet |
| 14:40:55 | *** wluyima_ has joined #openmrs-sprint |
| 14:41:55 | <cta> bwolfe: it seems that it's nice decision from darius, i will tryna implement my searchs likewise |
| 14:44:25 | *** bwolfe has quit IRC |
| 14:45:13 | <cta> guyz, I' so sorry but I need a small clarification about CohortEditor. I have not working with it so far, so I'd like to know what is it? |
| 14:45:37 | <cta> where can i get source code if it's a separate module? |
| 14:47:33 | <cta> I found out that there are cohortbuilder/, cohortcreation/ and cohortreports/ modules under the svn repository. Am I on wright way? |
| 14:47:37 | <sunbiz> cta: I dont think there is a separate module called CohortEditor |
| 14:50:22 | *** bwolfe has joined #openmrs-sprint |
| 14:50:22 | *** ChanServ sets mode: +o bwolfe |
| 14:50:55 | <bwolfe> boo, no better internet. still using my phone for now |
| 14:52:43 | <bwolfe> sunbiz: I only found that one remaining reference to wsutil. its now updated. |
| 14:53:29 | <bwolfe> everyone: let me know if hte ticket description doesn't make sense. I can update it. (I first made a bunch of tickets 2 weeks ago before we decided to change a lot of the framework around, so some tickets might still reference old stuff) |
| 14:59:50 | *** bwolfe has quit IRC |
| 15:06:20 | <wluyima_> DelegatingCrudResource.java doesn't seem to compile on my machine, is anyone else noticing this |
| 15:07:32 | *** bwolfe has joined #openmrs-sprint |
| 15:07:32 | *** ChanServ sets mode: +o bwolfe |
| 15:09:43 | <sunbiz> wluyima_: nope compiles fine for me on rev 20050 |
| 15:11:09 | <wluyima_> i think it has do with my eclipse prefs |
| 15:11:17 | <wluyima_> i need to trun off something |
| 15:11:22 | <wluyima_> i need to turn off something |
| 15:12:50 | <sunbiz> hmm... I thought I fixed the 1.8.0-SNAPSNOT from the openmrs maven-repo public |
| 15:12:58 | <sunbiz> suddenly... its failing for me now |
| 15:13:30 | <sunbiz> bwolfe: did u check if my deploy of the openmrs-test worked for u?? |
| 15:13:44 | <bwolfe> it was never broken for me |
| 15:13:53 | <bwolfe> probably because I've built and locally deployed that test jar |
| 15:13:54 | <sunbiz> thats because u had a local one... |
| 15:14:01 | <sunbiz> delete the local from .m2 |
| 15:16:33 | *** djazayeri has joined #openmrs-sprint |
| 15:16:33 | *** ChanServ sets mode: +o djazayeri |
| 15:19:44 | <sunbiz> hey djazayeri |
| 15:27:06 | <bwolfe> sunbiz: I'm still using internet over my phone. so every extra mb download costs me money. :-/ |
| 15:28:15 | *** wluyima_ has quit IRC |
| 15:29:59 | *** cta has quit IRC |
| 15:32:52 | *** cta has joined #openmrs-sprint |
| 15:35:45 | <sunbiz> bwolfe: okies... so later then |
| 15:39:56 | <bwolfe> cta: your quit message was "Óõîæó ÿ îò âàñ", is that a real sentence?! |
| 15:41:07 | <cta> my xchat writes it by default, "Óõîæó ÿ îò âàñ" its in russian and it means "I leave you" |
| 15:42:01 | <sunbiz> bwolfe: ahhh... I figured out now... someone deployed a newer version of the artifacts again... on 11th May. downeym, do u have the deploy target configured in ci?? |
| 15:43:05 | *** wluyima_ has joined #openmrs-sprint |
| 15:43:48 | <cta> bwolfe: any problem with that? |
| 15:44:42 | <bwolfe> cta: no, not at all. I just was amazed that /every/ character had some sort of modifier |
| 15:47:34 | <cta> bwolfe: hh)) strange xchat's behavior. I will make some changes within it configuration to avoid those mystical characters in future |
| 15:49:16 | *** cta has quit IRC |
| 15:49:44 | *** cta has joined #openmrs-sprint |
| 15:50:54 | <bwolfe> cta: yeah, now it was standard english. ...although the crazy characters gave your leaving some panache ;-) |
| 15:51:44 | <cta> )) |
| 16:06:19 | <bwolfe> ok, going back to get some dinner |
| 16:06:23 | <bwolfe> I'll be back on in a few hours |
| 16:11:47 | *** downeym_ has joined #openmrs-sprint |
| 16:11:47 | *** ChanServ sets mode: +o downeym_ |
| 16:12:58 | *** bwolfe has quit IRC |
| 16:13:09 | <djazayeri> hi all |
| 16:13:31 | <djazayeri> sorry I'm late, we had another thoughtworks call |
| 16:13:54 | *** downeym has quit IRC |
| 16:13:54 | *** downeym_ is now known as downeym |
| 16:13:57 | <sunbiz> djazayeri: yes, saw those design questions wiki that u created |
| 16:15:23 | <djazayeri> sunbiz, wluyima_ do those tickets make sense? |
| 16:15:39 | <djazayeri> Did Ben give an intro? |
| 16:17:07 | <sunbiz> just that we picked tickets... and have to commit and then post-commit reviews |
| 16:17:43 | <djazayeri> okay, did he point you to a tutorial, or some existing classes to look at for patterns? |
| 16:17:49 | <sunbiz> and shared the design pages: http://ln-s.net/8p2E |
| 16:18:29 | <wluyima_> yes |
| 16:20:14 | <wluyima_> i just read through the wiki pages, i have looked at the code for the superclasses in the class hierarchy and things seem to make sense to me |
| 16:21:42 | <djazayeri> the main point is that you need to copy what's done in PatientResource and PatientController. |
| 16:39:23 | *** Zabil has joined #openmrs-sprint |
| 16:40:21 | <sunbiz> hey Zabil |
| 16:40:24 | <djazayeri> hi Zabil |
| 16:40:48 | <Zabil> hi there. |
| 16:41:26 | <Zabil> i was getting started on one of the tickets for this sprint. |
| 16:41:42 | <Zabil> RESTWS-37 |
| 16:42:41 | <djazayeri> Zabil: I'm just seeing your comment now |
| 16:43:16 | <djazayeri> can you attach your RestController as a patch? |
| 16:43:39 | <djazayeri> I'm a bit confused about what you're duplicating, since the controller only has 3-line functions. |
| 16:44:01 | <Zabil> if you check the earlier version of the patient controller. |
| 16:44:20 | <Zabil> it had custom methods like createpatient etc |
| 16:44:41 | <Zabil> while implementing the encountercontroller. i found out that the code was the same |
| 16:44:59 | <Zabil> so i pulled it up to the RestController |
| 16:45:25 | <djazayeri> The only difference is that it's using the encounter resource instead of the patient resource? |
| 16:45:32 | <Zabil> yeah. |
| 16:45:46 | <djazayeri> So, I assumed we would not be able to pull those up into a rest controller because we needed the method-level @RequestMapping annotation |
| 16:45:59 | <wluyima_> djazayeri, am will be treating concept datatype as a separately managed object |
| 16:46:00 | <djazayeri> to include the "patient" or "encounter" |
| 16:46:04 | <djazayeri> wluyima_: yes |
| 16:46:08 | <wluyima_> thanks |
| 16:46:40 | <djazayeri> Zabil: but I think you're right that since the method-level annotation only needs to specify the relative URL, we can do that. |
| 16:46:50 | <Zabil> yeah. |
| 16:47:06 | <djazayeri> Can you please attach a patch, and I'll look at it and apply it quickly? |
| 16:47:16 | <Zabil> i did attach the patch |
| 16:47:27 | <djazayeri> oh, i see it. |
| 16:47:32 | <djazayeri> (lost it in all the sub-tickets) |
| 16:47:49 | <Zabil> also are you using curl to test it? |
| 16:47:59 | <Zabil> or have you used it? |
| 16:48:17 | <djazayeri> I'm not, and I haven't used that since the late 90s. |
| 16:48:36 | <djazayeri> ben put together a test page: |
| 16:48:39 | <djazayeri> https://wiki.openmrs.org/display/projects/Adding+a+Web+Service+Step+by+Step+Guide+for+Core+Developers |
| 16:48:40 | <OpenMRSBot> <http://ln-s.net/8p2E> (at wiki.openmrs.org) |
| 16:50:12 | <Zabil> ok wil check that. for simple testing of REST services on our other projects we usually use curl. works quite well. will see if i can do that. |
| 16:50:33 | <djazayeri> Zabil: just to check, you're certain that using a base class in this way will work with spring mvc? |
| 16:50:39 | <djazayeri> (it seems like it should) |
| 16:51:15 | <Zabil> i think it should. that's why i wanted to test it using curl to confirm. |
| 16:51:29 | <djazayeri> okay, do please check and let me know. |
| 16:51:59 | <djazayeri> If you're done working for the day, I can test that out and apply parts of the patch |
| 16:53:08 | <Zabil> actually yeah. i am going to sleep. it's late here. if you do have the time and you can check easily that would be great. |
| 16:53:14 | <djazayeri> okay, will do |
| 16:53:20 | <djazayeri> thanks for finding this |
| 16:53:25 | <Zabil> bye bye. |
| 16:53:36 | *** Zabil has quit IRC |
| 16:53:41 | <wluyima_> i love the test page |
| 16:54:16 | <djazayeri> I'm stepping away for 30 mins. anyone have questions before that? |
| 16:56:11 | <cta> no |
| 16:56:58 | <djazayeri> okay, back soon |
| 16:58:47 | *** sunbiz has left #openmrs-sprint |
| 17:02:57 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @zabilcm: @diptanu the openmrs REST is coming out pretty good. checkout it out at http://t.co/hPxNOun <http://twitter.com/OpenMRS/statuses/70162813259223041> |
| 17:05:35 | *** sunbiz has joined #openmrs-sprint |
| 17:15:35 | *** rafa has quit IRC |
| 17:22:46 | *** downeym_ has joined #openmrs-sprint |
| 17:22:46 | *** ChanServ sets mode: +o downeym_ |
| 17:24:10 | *** downeym has quit IRC |
| 17:24:11 | *** downeym_ is now known as downeym |
| 17:25:09 | <wluyima_> my ticket requires a listable |
| 17:25:34 | <wluyima_> and i plan to include it in my patch, is this ok? |
| 17:25:51 | <wluyima_> djazayeri, and i plan to include it in my patch, is this ok? |
| 17:26:04 | <djazayeri> wluyima_: yes |
| 17:26:11 | <djazayeri> no problem |
| 17:26:30 | <wluyima_> ok |
| 17:27:36 | <djazayeri> what's the signature of the method you defined in listable? |
| 17:39:16 | <djazayeri> for anyone who was following along, Zabil figured out something really helpful. |
| 17:39:38 | <djazayeri> Because of the way we have our URLs set up (i.e. the class has the root url, and the individual methods are relative urls to that) |
| 17:39:55 | <djazayeri> we can actually move all the create/retrieve/update/delete controller methods to a base class. |
| 17:40:04 | <djazayeri> (I just tested, and this works.) |
| 17:40:06 | <djazayeri> I'm going to code that up and commit it now. |
| 17:45:30 | <sunbiz> djazayeri: thats going to be helpful |
| 17:45:37 | <sunbiz> so... we dont write our controllers?? |
| 17:47:34 | *** dkayiwa has joined #openmrs-sprint |
| 18:03:32 | <djazayeri> sunbiz: I just committed |
| 18:04:06 | <djazayeri> so if you do an update now you should get a BaseCrudController, which you can extend to make your own controller. |
| 18:04:32 | <djazayeri> see PatientController for an example. |
| 18:06:50 | <sunbiz> djazayeri: yes, the test works! nice! |
| 18:07:28 | <djazayeri> it was zabil's idea, he gets the credit. |
| 18:09:59 | <cta> djazayeri: I've already saw it, looks cool. +1 to zabil |
| 18:32:51 | <cta> guys, when I tested voiding of cohort I found out that contained in db void reason was incorrect "because?v=", instead of "because" for example |
| 18:34:37 | <djazayeri> did you put ?v= instead of &v=? |
| 18:38:14 | <djazayeri> cta: does the url you did the DELETE to have a ?v= in it? |
| 18:38:22 | <cta> no |
| 18:38:33 | <cta> it doest have ?v |
| 18:38:46 | <djazayeri> that's interesting |
| 18:38:50 | <cta> yep |
| 18:39:00 | <djazayeri> you have a working unit test though? |
| 18:39:30 | <cta> I didnt use ?v= basically |
| 18:40:27 | <cta> no, I'm testing through Test.jsp page from adfmin interface |
| 18:43:42 | <cta> I used this request string "DELETE /openmrs/ws/rest/cohort/05e08b3b-5690-41e1-b651-5391fd946c1a?reason=because" |
| 18:44:09 | <djazayeri> cta: do you have a unit test? does that work right? |
| 18:44:20 | <djazayeri> rather, can you write a unit test and see if that works? |
| 18:44:27 | <djazayeri> see the PatientControllerTest example |
| 18:44:43 | <cta> ok, thanks for advice, Darius! |
| 19:14:25 | <wluyima_> djazayeri, what class do we use to get the authenticated user? |
| 19:14:36 | <wluyima_> is it still Context? |
| 19:15:26 | <wluyima_> sorry |
| 19:16:04 | <wluyima_> must be the same way |
| 19:17:51 | *** dkayiwa has left #openmrs-sprint |
| 19:21:33 | <djazayeri> wluyima_: sorry, missed that message, but yes, Context.getAuthenticatedUser() |
| 19:21:36 | <djazayeri> why do you need this? |
| 19:23:38 | <wluyima_> API has no retireConceptDatatype method, so i have to set retired by |
| 19:23:55 | <wluyima_> probably i will create a ticket for this in core |
| 19:49:57 | <djazayeri> wluyima_: yes, do not hack around this in the rest module, instead create a ticket for core |
| 19:59:10 | <wluyima_> djazayeri, that means retire concept datatypes will stay unimplemented for now |
| 20:14:39 | <djazayeri> wluyima_: yes |
| 20:14:57 | <djazayeri> leave that unimplemented for now if core doesn't support it, but create a ticket |
| 20:29:11 | *** cta has quit IRC |
| 20:36:18 | *** downeym has quit IRC |
| 21:01:15 | <djazayeri> wluyima_: how do I search for patients, by fuzzy name, through the API? |
| 21:04:08 | <wluyima_> djazayeri, getPatients(name, identifier, List<PatientIdentifiers, false>) |
| 21:04:27 | <djazayeri> what if I want paging? |
| 21:04:30 | <wluyima_> djazayeri, getPatients(name, identifier, List<PatientIdentifiers>, false) |
| 21:04:32 | <djazayeri> i.e. start and size? |
| 21:05:14 | <djazayeri> The specific problem I noticed is that when I call the getPatients(String, Integer, Integer) method it ends up doing a case-sensitive search on name. |
| 21:05:14 | <wluyima_> djazayeri, getPatients(String name, String identifier, List<PatientIdentifierType> identifierTypes, |
| 21:05:15 | <wluyima_> boolean matchIdentifierExactly, Integer start, Integer length) |
| 21:05:32 | <djazayeri> i.e. if I type "darius" it won't find "Darius" |
| 21:05:51 | <wluyima_> i think it might be case sensitive |
| 21:05:57 | <wluyima_> let me confirm |
| 21:06:17 | <djazayeri> It's not case-sensitive in the webapp though, is it? |
| 21:08:46 | <wluyima_> when i look at the code it user Expressions.like |
| 21:08:49 | <wluyima_> on names |
| 21:09:12 | <wluyima_> which should be case insensitive which makes it fine |
| 21:09:51 | <wluyima_> are you trying the search via the webservice |
| 21:10:29 | <wluyima_> i think it works fine |
| 21:10:49 | <djazayeri> So, when I use the webapp, if I search for "darius", I find patients named "Darius" |
| 21:10:55 | <djazayeri> I believe that is the correct behavior. |
| 21:10:56 | <wluyima_> me too |
| 21:11:09 | <djazayeri> When I search through the web service, I do *not* find "Darius" |
| 21:11:19 | <djazayeri> That's bad behavior. |
| 21:11:46 | <djazayeri> i.e. it's case-insensitive through the UI, but case-sensitive through the web service. |
| 21:11:59 | <djazayeri> But I can't tell where it's being set to be case-insensitive. |
| 21:12:16 | <wluyima_> hmm |
| 21:12:35 | <wluyima_> have you looked at the unit tests? |
| 21:12:56 | <djazayeri> where? |
| 21:13:13 | <wluyima_> the method that pages uses the same patient criteria as the one without paging |
| 21:13:15 | <djazayeri> In the web service module's PatientController unit test I had to search for "Horatio", because "horatio" didn't work. |
| 21:13:36 | <djazayeri> anyway, you don't remember setting case-sensitivity anywhere? |
| 21:14:28 | <wluyima_> the paging methods methods onlys limits the result set size and beginning index |
| 21:17:08 | <wluyima_> but as i have said, if you look at PatientSearchCriteria, i think it should be ilike and not like for the expression |
| 21:17:10 | <djazayeri> wluyima_ I agree, so perhaps we should just change it there, but I'd like to understand why it behaves the way it does. |
| 21:17:16 | <djazayeri> wluyima_: never mind, I just tried it in the webapp under web services, and it works fine there. |
| 21:17:41 | <djazayeri> I guess mysql is treating that table/column case-insensitively, but h2 is being case-sensitive in the unit tests. |
| 21:17:43 | <wluyima_> djazayeri, so what do you think is the problem |
| 21:17:55 | <djazayeri> so there's no problem. |
| 21:18:20 | <djazayeri> (I mean, there's a problem in that our testing framework isn't behaving the same way as production, but I'm going to ignore that because my code is currently working as intended.) |
| 21:19:14 | <wluyima_> cool, i agree there a couple of tests in trunk that fail and we set @ignore on them because h2 behaves differently |
| 21:19:50 | *** sunbiz has quit IRC |
| 21:20:23 | <wluyima_> i think we can change it and explicitly use ilike |
| 21:52:08 | <wluyima_> djazayeri, is there a convention for the name of parameters for includeVoided/Retired? |
| 21:52:52 | <wluyima_> i.e request paramters would be good to have one just like 'v' |
| 21:53:36 | <djazayeri> what params do you need? |
| 21:53:42 | <djazayeri> oh, sorry, got it |
| 21:54:10 | <djazayeri> I just sent an email to the dev list about how I think we should not show voided things under web services. |
| 21:54:27 | <djazayeri> we can expose them under some other resource uri at some point if people really want |
| 21:55:01 | <djazayeri> For now I'd vote for always including retired, and excluding voided. |
| 21:55:19 | <djazayeri> So, you're talking about GET /ws/rest/conceptdatatype.json? |
| 21:55:35 | <djazayeri> or GET /ws/rest/conceptdatatype.json?q=numer |
| 21:55:38 | <djazayeri> ? |
| 21:56:53 | <djazayeri> wluyima_: ping, in case you looked away |
| 21:57:52 | <wluyima_> djazayeri, hi |
| 21:58:04 | <djazayeri> Note that GET /ws/rest/conceptdatatype/Numeric.json should return a datatype by unique name. |
| 21:58:43 | <djazayeri> So, I think that both the GETs on /ws/rest/conceptdatatype (to list all, and to search by fuzzy name) should include retired, but sort them at the bottom. |
| 22:02:38 | *** sunbiz has joined #openmrs-sprint |
| 22:04:11 | *** sunbiz has quit IRC |
| 22:04:35 | *** sunbiz has joined #openmrs-sprint |
| 22:08:38 | <wluyima_> has anyone tested the create methods from the test page? |
| 22:21:30 | <wluyima_> got it |
| 22:58:57 | <wluyima_> djazayeri, am doing this next https://tickets.openmrs.org/browse/RESTWS-94 |
| 22:59:28 | <djazayeri> okay. did you check in the ConceptDatatype one? |
| 22:59:50 | <wluyima_> yes and i have created a review |
| 23:00:55 | <wluyima_> dzajayeri, what is the approach torwards subtasks? |
| 23:01:21 | <wluyima_> do all and commit once for the master task or one by one |
| 23:02:41 | <wluyima_> am heading home, will get back online when i get there |
| 23:05:27 | <djazayeri> wluyima_: commit as often as you want, but for the master task |
| 23:06:58 | *** wluyima_ has quit IRC |
| 23:35:57 | *** wluyima_ has joined #openmrs-sprint |
| 23:59:49 | <wluyima_> djazayeri concept datatypes are not really searchable |