05:23:08
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): UI changes to support Encounter.visit - TRUNK-2238 <http://feedproxy.google.com/~r/OMRStrunk/~3/NQOrex_ldxI/OpenMRS>
|
07:39:21
|
*** dkayiwa has joined #openmrs-sprint
|
08:57:41
|
*** djazayeri has quit IRC
|
09:05:20
|
*** dkayiwa has quit IRC
|
09:05:26
|
*** dkayiwa has joined #openmrs-sprint
|
09:12:51
|
*** djazayeri has joined #openmrs-sprint
|
09:12:51
|
*** ChanServ sets mode: +o djazayeri
|
11:17:54
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Add All PropertyEditors to the global OpenmrsBindingInitializer - TRUNK-2293 <http://feedproxy.google.com/~r/OMRStrunk/~3/7mTlr_wD9wE/OpenMRS> || New Changeset: OpenMRS (trunk): Adding ability to unretire visit attribute types from the user interface - TRUNK-2249 <http://feedproxy.google.com/~r/OMRStrunk/~3/oT8e7oXgVJU/OpenMRS> || New Changeset: OpenMRS (trunk): Add web.xml mapping for web services - TRUNK-2292 <http://feedproxy.google.com/~r/OMRStrunk/~3/81hHZ7Kw2-g/OpenMRS>
|
11:31:11
|
*** dkayiwa has quit IRC
|
11:35:27
|
*** dkayiwa has joined #openmrs-sprint
|
12:19:38
|
*** wyclif has quit IRC
|
12:22:05
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Adding more minOccurs and maxOccurs validation to visit attribute types - TRUNK-2249 <http://feedproxy.google.com/~r/OMRStrunk/~3/cRX0xE94-sg/OpenMRS> || New Changeset: OpenMRS (trunk): Add uuid search to all PropertyEditors - TRUNK-2294 <http://feedproxy.google.com/~r/OMRStrunk/~3/puDab4qIYBE/OpenMRS> || New Changeset: OpenMRS (trunk): Changing the logical type property widget to a drop down list for visit attribute types - TRUNK-2249 <http://feedproxy.google.com/~r/OMRStrunk/~3/wJ7WYLIOgEg/OpenMRS>
|
13:05:35
|
*** dkayiwa_ has joined #openmrs-sprint
|
13:05:35
|
*** dkayiwa has quit IRC
|
13:05:37
|
*** dkayiwa_ is now known as dkayiwa
|
13:13:57
|
*** wyclif has joined #openmrs-sprint
|
13:15:45
|
*** dkayiwa has quit IRC
|
13:23:31
|
*** dkayiwa has joined #openmrs-sprint
|
13:23:43
|
*** downeym has joined #openmrs-sprint
|
13:23:43
|
*** ChanServ sets mode: +o downeym
|
13:23:44
|
*** OpenMRSBot sets mode: +o downeym
|
13:26:18
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Register 1.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=register&version=&1.0.1>
|
14:25:46
|
*** dkayiwa has left #openmrs-sprint
|
14:30:29
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): removing unused import <http://feedproxy.google.com/~r/OMRStrunk/~3/jM_4UOXQGWM/OpenMRS>
|
15:05:57
|
<wyclif> should we have a separate package for visits or we should use the one for patients?
|
15:25:00
|
*** downeym has quit IRC
|
15:30:07
|
*** downeym has joined #openmrs-sprint
|
15:30:07
|
*** ChanServ sets mode: +o downeym
|
15:30:08
|
*** OpenMRSBot sets mode: +o downeym
|
15:34:41
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Adding changeset for adding core concept map types <http://feedproxy.google.com/~r/OMRStrunk/~3/0Rw7bv5ELnE/OpenMRS>
|
15:46:03
|
<djazayeri> hi all
|
15:46:25
|
<djazayeri> wyclif: you should ping me when you have a question. :-)
|
15:46:30
|
<djazayeri> you mean a java package?
|
15:46:56
|
<djazayeri> it should just be org.openmrs.Visit.
|
15:47:07
|
<djazayeri> service and dao should also be in the regular api packages
|
15:47:19
|
<djazayeri> the web layer could probably be its own package for the controllers
|
15:57:39
|
<wyclif> i mean for controllers and forms
|
15:59:48
|
<wyclif> djazayeri, the web layer forms and controllers are in separate packages say EncounterFormController i located in the org/openmrs/web/controller/encounter
|
16:00:37
|
<wyclif> djazayeri, and am asking i should add /openmrs/web/controller/visit
|
16:01:02
|
<djazayeri> wyclif: yes, visit should have its own
|
16:01:08
|
<wyclif> or i should just put it under org/openmrs/web/controller/patient
|
16:01:15
|
<wyclif> ok, thanks
|
16:06:55
|
<wyclif> djazayeri, i think visitTypeForm and VisitAttributeTypeForm controllers should be annotated and not extending the deprecate simpleform controller
|
16:07:41
|
<djazayeri> wyclif: I prefer annotated controllers myself, and we should probably ask Daniel to start using them.
|
16:08:08
|
<djazayeri> But I think that it's okay for list/manage pages to keep using deprecated simpleformcontroller, since that allows them to be copied.
|
16:08:35
|
<djazayeri> I mean: since we already have 20 list/manage pages using the simpleformcontroller pattern, I think it's fine to add two more that replicate that.
|
16:08:37
|
<wyclif> why should they be copied?
|
16:09:10
|
<wyclif> but i thought if something is deprecates, it is bad practice to continue using it
|
16:09:20
|
<wyclif> sorry deprecated
|
16:09:27
|
<djazayeri> All other things being equal, yes.
|
16:09:41
|
<djazayeri> But in this case I think it's better to copy-and-modify the manage encounter types pages for manage visit types.
|
16:10:08
|
<djazayeri> rather than rewrite the manage visit types page from scratch
|
16:12:27
|
<wyclif> i get what you mean, but there are annotated controllers that have similar functionality that you can just copy e.g conceptStopWordController and they have fewer lines
|
16:13:14
|
<wyclif> it has the code for get all objects and list them on the page
|
16:13:20
|
<wyclif> and it is annotated
|
16:18:51
|
*** downeym has quit IRC
|
16:22:47
|
*** downeym has joined #openmrs-sprint
|
16:22:47
|
*** ChanServ sets mode: +o downeym
|
16:22:49
|
*** OpenMRSBot sets mode: +o downeym
|
16:38:52
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Inconsistency between Encounter & Form Entry tabs on Patient Dashboard - TRUNK-221... <http://feedproxy.google.com/~r/OMRStrunk/~3/U8vSNTSH3JA/OpenMRS>
|
16:40:00
|
<djazayeri> wyclif: you're right, but I don't think it's worth the effort in this case.
|
16:40:18
|
<djazayeri> but you should mention that one to Daniel.
|
16:40:28
|
<djazayeri> (It's possible that in this case he took the code from the pre-existing patch too.)
|
16:53:41
|
*** djazayeri has quit IRC
|
17:24:09
|
*** wyclif has quit IRC
|
17:31:42
|
*** djazayeri has joined #openmrs-sprint
|
17:31:42
|
*** ChanServ sets mode: +o djazayeri
|
17:37:23
|
*** wyclif has joined #openmrs-sprint
|
17:53:45
|
<wyclif> djazayeri, can't visit types be a drop down instead of a search, are they expected to be many
|
17:54:11
|
<djazayeri> wyclif: it should be a dropdown, sorry, I was just lazy in that mockup
|
17:54:41
|
<djazayeri> I put in a search for a bunch of things, that don't necessarily need them.
|
17:57:27
|
<wyclif> djazayeri, ok, thanks
|
18:41:10
|
*** downeym has quit IRC
|
18:42:12
|
*** downeym has joined #openmrs-sprint
|
18:42:12
|
*** ChanServ sets mode: +o downeym
|
18:42:13
|
*** OpenMRSBot sets mode: +o downeym
|
19:05:08
|
*** dkayiwa has joined #openmrs-sprint
|
19:18:03
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: One of our network providers is currently having problems - several #OpenMRS sites are unavailable. Sorry for the inconvenience! <http://twitter.com/OpenMRS/statuses/63315011593977856>
|
20:09:09
|
*** wyclif has quit IRC
|
20:24:18
|
*** wyclif has joined #openmrs-sprint
|
20:55:35
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Our network provider's problems have now been resolved. Sorry for the delay. #OpenMRS <http://twitter.com/OpenMRS/statuses/63334033408528385>
|
21:06:58
|
*** dkayiwa has quit IRC
|
21:06:59
|
*** dkayiwa_ has joined #openmrs-sprint
|
21:26:16
|
*** downeym has quit IRC
|
21:26:19
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Removing confirmation for retiring visit attribute types and also changing the message code to start with small letter U... <http://feedproxy.google.com/~r/OMRStrunk/~3/qqotCThjHtY/OpenMRS> || New Changeset: OpenMRS (trunk): Removing unused code - TRUNK-2237 <http://feedproxy.google.com/~r/OMRStrunk/~3/AG3XSLuZRO8/OpenMRS>
|
21:37:58
|
*** dkayiwa_ has quit IRC
|
21:57:49
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @FOSSwiki: #OpenSource #EMRs #EHRs Worth Reviewing: OpenEMR, OSCAR McMaster, Hospital OS, OpenMRS, Free MED http://bit.ly/e... http:/ ... <http://twitter.com/OpenMRS/statuses/63349042293379072>
|
22:11:12
|
*** downeym has joined #openmrs-sprint
|
22:11:12
|
*** ChanServ sets mode: +o downeym
|
22:11:13
|
*** OpenMRSBot sets mode: +o downeym
|
22:29:58
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting save* and create* Before Advisor throws ClassCastException to 1.8.x - TRUNK-2026 <http://feedproxy.google.com/~r/OMRStrunk/~3/RzHKs-aaVUI/OpenMRS>
|
22:35:54
|
*** wyclif has quit IRC
|
23:05:25
|
*** Guest35389 has joined #openmrs-sprint
|
23:05:34
|
*** Guest35389 is now known as wyclif
|
23:46:49
|
*** downeym has quit IRC
|