00:50:44 *** downeym has joined #openmrs-sprint
00:50:44 *** ChanServ sets mode: +o downeym
00:50:45 *** OpenMRSBot sets mode: +o downeym
01:02:50 *** downeym has quit IRC
05:23:13 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Domain object, liquibase, and hibernate mapping for VisitAttributeType - TRUNK-2244... <http://feedproxy.google.com/~r/OMRStrunk/~3/rc0SQ60D5oc/OpenMRS>
05:28:29 *** Zabil has joined #openmrs-sprint
07:39:10 *** dkayiwa has joined #openmrs-sprint
08:49:38 *** dkayiwa has quit IRC
08:55:25 *** dkayiwa has joined #openmrs-sprint
08:55:39 *** dkayiwa has quit IRC
08:57:27 *** dkayiwa has joined #openmrs-sprint
09:05:04 *** dkayiwa has quit IRC
09:05:30 *** dkayiwa has joined #openmrs-sprint
10:03:40 *** dkayiwa has quit IRC
10:08:07 *** dkayiwa has joined #openmrs-sprint
12:11:59 *** Zabil has quit IRC
12:59:59 *** Zabil has joined #openmrs-sprint
13:06:01 *** dkayiwa has quit IRC
13:06:11 *** dkayiwa has joined #openmrs-sprint
13:32:53 *** Zabil has quit IRC
14:00:04 *** Zabil has joined #openmrs-sprint
14:30:21 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: XForms 4.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.1>
15:38:19 <djazayeri> good morning everyone
15:38:33 <dkayiwa> good afternoon Darius
15:40:07 <djazayeri> dkayiwa: I see you picked up ticket TRUNK-2249, but tickets TRUNK-2242 and TRUNK-2239 are higher priority.
15:40:59 <djazayeri> if you're already partway through the first one, go ahead and continue with it though.
15:42:07 <dkayiwa> ok. any tips on how to chose the next ticket? :)
15:43:43 <djazayeri> look at https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10134
15:43:44 <OpenMRSBot> <http://ln-s.net/8jsH> (at tickets.openmrs.org)
15:43:52 <djazayeri> (the dashboard)
15:43:54 <dkayiwa> ok
15:44:10 <djazayeri> and pick the highest-priority Visit-related ticket that's ready for work
15:44:24 <djazayeri> there are two Musts.
15:44:45 <dkayiwa> ok
15:45:04 <djazayeri> (There are a few random bugfix tickets too. You should stick to Visit ones, though, and not do the random bugfixes.)
15:45:26 <dkayiwa> ok
15:48:24 <djazayeri> hi Zabil
15:48:45 <Zabil> hi darius. so i have uploaded a patch for https://tickets.openmrs.org/browse/TRUNK-2250 raised a comment on it also. I am not of what tests to write and see if the patch works.
15:48:46 <djazayeri> I see the patch on the ticket you sent. I'll review it today.
15:49:11 <Zabil> because the tests comes later on. when the service stories are played.
15:49:14 <djazayeri> Yes.
15:49:27 <djazayeri> You should move onto the next ticket, and hopefully you'll be able to add tests to that one.
15:49:49 <djazayeri> e.g. TRUNK-2251
15:50:03 <Zabil> ok will do that tommorrow. you can do a preliminary review of it and i can make the changes. by then. thanks.
15:50:16 <djazayeri> sure
16:07:47 <djazayeri> Zabil: I commented on the ticket, but you can revisit tomorrow
16:08:17 <Zabil> thanks. will take a look.
16:30:49 *** Zabil has quit IRC
16:37:02 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Domain object, liquibase, and hibernate mapping for VisitAttributeType - TRUNK-2244... <http://feedproxy.google.com/~r/OMRStrunk/~3/6leJKPRqLvU/OpenMRS>
17:06:22 *** dkayiwa_ has joined #openmrs-sprint
17:06:24 *** dkayiwa has quit IRC
17:06:24 *** dkayiwa_ is now known as dkayiwa
17:09:10 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Domain object, liquibase, and hibernate mapping for VisitAttributeType - TRUNK-2244... <http://feedproxy.google.com/~r/OMRStrunk/~3/duszhhxSLwM/OpenMRS>
17:28:11 <djazayeri> hey wyclif how's it going?
17:43:07 <wyclif> djazayeri, good
17:43:54 <wyclif> djazayeri, i had to actually play around with the patientTag to repopulate the visit select when a patient is changed
17:44:18 <wyclif> djazayeri, otherwise the list would be invalid
17:44:23 <djazayeri> Ah, right...
17:44:34 <djazayeri> you can only change the patient when creating a new encounter, right?
17:44:40 <wyclif> djazayeri, so i have added the DWRVisitService and dwr stuff
17:44:56 <djazayeri> I thought I looked at the demo server and you couldn't change the patient on an encounter there.
17:45:06 <wyclif> djazayeri, though i have only added two methods so far
17:45:32 <djazayeri> wyclif: if that's the way it needs to be done, go ahead
17:46:25 <wyclif> djazayeri, on the encounter form the patient actually can be changed and i think this isn't quite right
17:47:16 <wyclif> djazayeri, why would the patient get changed, if it was a data entrant mistake, then the encounter should be voided
17:47:51 <wyclif> djazayeri, that is my opinion
17:47:55 <djazayeri> wyclif: if you spent 15 minutes filling out a form for the wrong person, you'd prefer to just change the person, rather than having to void it and do it all again. :-)
17:48:08 <wyclif> djazayeri, ok
17:48:33 <wyclif> djazayeri, i should get the code in today
17:49:07 <wyclif> djazayeri, am adding the validator right now
17:49:40 <djazayeri> wyclif: I created a VisitValidator last night
17:49:42 <djazayeri> make sure you svn update
17:51:46 <wyclif> this is an encounter validator that checks that the patient's are the same
17:51:55 <wyclif> for tha encounter and the visit
17:52:00 <djazayeri> oh, okay
17:52:48 <wyclif> nice that you added the visit validator, i thought about it
17:53:36 <djazayeri> it's minimal, I'm just checking the minOccurs/maxOccurs of visit attribute types
17:53:54 <wyclif> yes i will
17:54:39 <wyclif> we will add more to enforce the required fields like visit type
17:55:03 <wyclif> thanks for the update otherwise
18:13:21 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Improve location hierarchy "simple" widget - TRUNK-2067... <http://feedproxy.google.com/~r/OMRStrunk/~3/_D7fMoF73r4/OpenMRS> || New Changeset: OpenMRS (trunk): Adding Managing Visit Attribute Types pages - TRUNK-2249 <http://feedproxy.google.com/~r/OMRStrunk/~3/T94XDhLHook/OpenMRS>
19:24:16 *** dkayiwa has quit IRC
19:38:00 *** dkayiwa has joined #openmrs-sprint
19:54:35 *** dkayiwa has left #openmrs-sprint
21:23:56 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Security error when relationship name is clicked on the patient dashboard: You are not authorized to view this page - TR... <http://feedproxy.google.com/~r/OMRStrunk/~3/-wK5Z_kfJLg/OpenMRS> || New Changeset: OpenMRS (trunk): Security error when relationship name is clicked on the patient dashboard: You are not authorized to view this page - TR... <http://feedproxy.google.com/~r/OMRStrunk/~3/WdoK-fhkZx0/OpenMRS>