05:47:34
|
*** Zabil has joined #openmrs-sprint
|
06:35:48
|
*** Zabil has quit IRC
|
08:51:09
|
*** Zabil has joined #openmrs-sprint
|
11:24:58
|
*** downeym has joined #openmrs-sprint
|
11:24:58
|
*** ChanServ sets mode: +o downeym
|
11:24:59
|
*** OpenMRSBot sets mode: +o downeym
|
11:54:24
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @vishalarora Yes! With Tomcat & MySQL installed, drop in openmrs.war. Or try new 1.8 standalone installer: https://wiki.openmrs.org/x/zQLX <http://twitter.com/OpenMRS/statuses/62478231181340672>
|
12:01:23
|
*** Zabil has quit IRC
|
12:59:56
|
*** Guest93241 has joined #openmrs-sprint
|
13:00:03
|
*** Guest93241 is now known as wyclif
|
13:35:52
|
*** Zabil has joined #openmrs-sprint
|
13:57:12
|
*** Zabil has quit IRC
|
14:26:19
|
*** Zabil has joined #openmrs-sprint
|
14:52:29
|
*** Zabil has quit IRC
|
14:54:28
|
*** Zabil has joined #openmrs-sprint
|
14:54:48
|
*** Zabil has quit IRC
|
14:55:50
|
*** Zabil has joined #openmrs-sprint
|
14:58:11
|
*** wyclif has quit IRC
|
14:58:25
|
*** wluyima has joined #openmrs-sprint
|
14:58:33
|
*** wluyima is now known as Guest1467
|
15:02:34
|
*** Guest1467 is now known as wyclif
|
15:04:55
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Making changes according to code review comments - TRUNK-2236 <http://feedproxy.google.com/~r/OMRStrunk/~3/IIk-VfxvXCw/OpenMRS>
|
15:12:44
|
<wyclif> hi
|
15:13:39
|
<wyclif> am trying to pick the next ticket for on the visits but it seems like there are some dependency issues that are blocking me
|
15:14:00
|
<wyclif> wanted to do TRUNK-2239
|
15:18:41
|
<downeym> !ticket TRUNK-2239
|
15:18:41
|
<OpenMRSBot> downeym: Allow me to help you with that. More details on ticket TRUNK-2239 can be found at http://tickets.openmrs.org/browse/TRUNK-2239
|
15:20:35
|
<wyclif> thanks
|
15:22:41
|
*** robbyoconnor has quit IRC
|
15:30:10
|
<djazayeri> wyclif: you can do TRUNK-2238
|
15:30:27
|
<djazayeri> it depends on TRUNK-2237, which is still in-progress by Daniel, but he's already committed dcode
|
15:31:31
|
<wyclif> oh, i didn't know he had committed some initial code, then i will work on it
|
15:31:45
|
<wyclif> am going for lunch
|
15:31:50
|
<djazayeri> okay
|
15:38:18
|
<Zabil> hi darius. we were also planning to take some tickets. but stopped because of dependencies.
|
15:39:08
|
<Zabil> so should be wait till visitattributetype is implemented?
|
15:44:33
|
<djazayeri> Zabil, sorry, the dependencies are tough to visualize in JIRA.
|
15:44:46
|
<djazayeri> Inconvenient that we're 12 time zones apart.
|
15:46:09
|
<Zabil> :-) is there anything we could pick up?
|
15:46:29
|
<djazayeri> right now? or tomorrow?
|
15:47:58
|
<Zabil> 12 hours from now.
|
15:48:15
|
<djazayeri> the state of things will be different by then.
|
15:48:25
|
<djazayeri> But provider attributes is probably a good one.
|
15:48:31
|
<djazayeri> sorry
|
15:48:33
|
<djazayeri> visit attributes
|
15:48:56
|
<djazayeri> Zabil: I'll email you when I'm stopping work for the day and let you know what tickets are open and ready
|
15:49:57
|
<djazayeri> Most likely: TRUNK-2244
|
15:50:23
|
<djazayeri> then 2245 and 2246
|
16:32:14
|
*** Zabil has quit IRC
|
16:49:33
|
*** Zabil has joined #openmrs-sprint
|
16:55:37
|
*** downeym has quit IRC
|
16:55:53
|
<wyclif> going for RG meeting
|
16:56:12
|
<wyclif> will be back at 2:30pm
|
17:00:52
|
*** downeym has joined #openmrs-sprint
|
17:00:52
|
*** ChanServ sets mode: +o downeym
|
17:00:53
|
*** OpenMRSBot sets mode: +o downeym
|
18:16:06
|
*** downeym has quit IRC
|
18:19:46
|
<wyclif> back
|
18:19:56
|
*** downeym has joined #openmrs-sprint
|
18:19:56
|
*** ChanServ sets mode: +o downeym
|
18:19:57
|
*** OpenMRSBot sets mode: +o downeym
|
18:46:28
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Location.isInHierarchy is inefficient - TRUNK-2283 <http://feedproxy.google.com/~r/OMRStrunk/~3/Hs9FNqP7Xj0/OpenMRS>
|
19:16:25
|
*** robbyoconnor has joined #openmrs-sprint
|
19:17:40
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congratulations and good luck to our 16 #OpenMRS Summer of Code participants for 2011! http://go.openmrs.org/soc2011 #GSoC #ICT4D <http://twitter.com/OpenMRS/statuses/62591836174286848>
|
20:21:37
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Additional validations required while creating patients - TRUNK-2252... <http://feedproxy.google.com/~r/OMRStrunk/~3/OSeFOAIkIqs/OpenMRS>
|
20:37:25
|
<wyclif> I think it would be right to set a visit when creating an encounter but rather add an encounter to a visit on the create/edit visit form
|
20:37:33
|
<wyclif> sorry wouldn't
|
20:47:51
|
*** downeym has quit IRC
|
21:24:04
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Add AttributeTypeHandler to the API, which can be used by multiple classes that need to support user-defined Attributes ... <http://feedproxy.google.com/~r/OMRStrunk/~3/0ig6uE730jA/OpenMRS>
|
21:51:31
|
<wyclif> djazayeri, and if we wish to have the visit editable on the obs form, then i would prefer the new approach of myField.tag approach that supports autocomplete
|
21:51:43
|
<wyclif> sorry on the encounter form
|
21:52:07
|
<wyclif> many typos there
|
22:00:02
|
<djazayeri> wyclif: we definitely need a "choose a visit" widget
|
22:00:31
|
<djazayeri> are you saying that fieldgen isn't good enough? or something else?
|
22:01:26
|
<wyclif> i meant adding visitField.tag since this is a form
|
22:01:46
|
<wyclif> which leaves it editable
|
22:01:58
|
<djazayeri> I agree that you should encapsulate this in a widget
|
22:02:32
|
<wyclif> ok
|
22:02:44
|
<djazayeri> ideally it would also be available as a fieldgen
|
22:02:55
|
<djazayeri> (although if we don't have a fieldgen for encounter we don't need one for visit either)
|
22:03:27
|
<wyclif> i think the concept is the same, i just found this approach the preferred since it works with the new jquery autocomplete
|
22:03:58
|
<djazayeri> So, I agree that it would be good to do an encapsulated reusable autosuggest widget
|
22:04:07
|
<wyclif> ok
|
22:04:11
|
<djazayeri> but I would recommend _not_ doing that as part of the visit ticket you're looking at
|
22:04:22
|
<djazayeri> create a ticket for making something fancy and reusable
|
22:04:40
|
<djazayeri> but for purposes of TRUNK-2238 just do a dropdown list of the current patient's visits.
|
22:04:50
|
<djazayeri> sorted by start-date descending
|
22:05:14
|
<djazayeri> more important that we get visits working completely first, and afterwards we can make them pretty
|
22:05:48
|
<djazayeri> wyclif: and actually, I suspect that choosing a visit via a dropdown is probably better than an autosuggest in some cases
|
22:09:05
|
<wyclif> djazayeri, i understand why you say that and i agree, but still i think i can make the widget to restrict on visits for a specific patient
|
22:09:51
|
<djazayeri> of course only for the specific patient
|
22:17:16
|
<wyclif> got it
|
22:17:19
|
<wyclif> thanks
|
22:17:22
|
<wyclif> am heading home
|
22:17:36
|
<wyclif> will be completing this real quick
|
22:19:34
|
<djazayeri> ciao
|
22:24:20
|
*** wyclif has quit IRC
|
22:59:39
|
*** wyclif has joined #openmrs-sprint
|