00:00:38 *** downeym has joined #openmrs-sprint
00:00:38 *** ChanServ sets mode: +o downeym
00:00:39 *** OpenMRSBot sets mode: +o downeym
00:31:44 *** downeym has quit IRC
00:50:16 *** downeym has joined #openmrs-sprint
00:50:16 *** ChanServ sets mode: +o downeym
00:50:17 *** OpenMRSBot sets mode: +o downeym
02:46:25 *** downeym has quit IRC
04:30:28 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting, OpenMRS in-app Help is not helpful - TRUNK-2118 <http://feedproxy.google.com/~r/OMRStrunk/~3/seqcpTQuc0U/OpenMRS> || New Changeset: OpenMRS (trunk): OpenMRS in-app Help is not helpful - TRUNK-2054... <http://feedproxy.google.com/~r/OMRStrunk/~3/L8rbSXEOehQ/OpenMRS>
05:01:57 *** bwolfe has quit IRC
06:56:32 *** bwolfe has joined #openmrs-sprint
06:56:32 *** ChanServ sets mode: +o bwolfe
07:01:02 *** dkayiwa has joined #openmrs-sprint
07:23:41 <dkayiwa> hi bwolfe
07:23:49 <bwolfe> hey daniel
07:23:59 <dkayiwa> how is kenya?
07:24:34 <bwolfe> its good
07:24:36 <bwolfe> great weather
07:24:42 <bwolfe> (because the rains haven't started yet)
07:24:47 <dkayiwa> oh yeah
07:25:02 <dkayiwa> does kenya also celebrate Good Friday as a public holiday?
07:32:40 <bwolfe> yep
07:32:43 <bwolfe> everyone is off today
07:32:47 <bwolfe> and everyone is off on monday too
07:32:54 <dkayiwa> oh i see
07:43:24 *** bwolfe has quit IRC
07:43:47 *** bwolfe has joined #openmrs-sprint
07:43:47 *** ChanServ sets mode: +o bwolfe
07:48:40 *** suho has joined #openmrs-sprint
09:06:57 *** dkayiwa has quit IRC
09:07:09 *** dkayiwa has joined #openmrs-sprint
09:17:14 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Changing from sort desc to asc for getEncountersByVisit - TRUNK-2237 <http://feedproxy.google.com/~r/OMRStrunk/~3/fjP0NKcgZoE/OpenMRS> || New Changeset: OpenMRS (trunk): Adding Visit property to Encounter - TRUNK-2237 <http://feedproxy.google.com/~r/OMRStrunk/~3/Ojc1_tDmiaQ/OpenMRS>
09:36:01 *** dkayiwa has quit IRC
09:47:28 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Addressing comments on Adding Visit property to Encounter - TRUNK-2237 <http://feedproxy.google.com/~r/OMRStrunk/~3/zB70ImtQBag/OpenMRS>
10:15:03 *** suho has quit IRC
11:18:00 *** robbyoconnor has quit IRC
12:26:54 *** wyclif has joined #openmrs-sprint
12:56:31 *** downeym has joined #openmrs-sprint
12:56:31 *** ChanServ sets mode: +o downeym
12:56:32 *** OpenMRSBot sets mode: +o downeym
13:28:03 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Form Entry 5.0.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=formentry&version=&5.0.3>
14:00:12 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Upgrading form entry, reporting and xforms modules to their latest versions <http://feedproxy.google.com/~r/OMRStrunk/~3/hL7sbJ938R8/OpenMRS>
15:05:39 *** jportela has joined #openmrs-sprint
15:08:27 <djazayeri> hi all
15:08:48 <jportela> hi
15:09:36 <djazayeri> jportela: I see you in the sprint channel. Is that because you're hoping to do a ticket? :-)
15:09:54 <jportela> well, i just did submitted a patch for one ticket
15:10:08 <jportela> !ticket 221
15:10:08 <OpenMRSBot> jportela: Allow me to help you with that. More details on ticket 221 can be found at http://tickets.openmrs.org/browse/221
15:10:24 <jportela> oops wrong ticket i guess
15:10:46 <jportela> !ticket TRUNK-221
15:10:46 <OpenMRSBot> jportela: Allow me to help you with that. More details on ticket TRUNK-221 can be found at http://tickets.openmrs.org/browse/TRUNK-221
15:11:06 <jportela> I'm looking for another ticket to do :P
15:11:11 <djazayeri> I was just seeing your comment with the patch. A question:
15:11:43 <djazayeri> If I try to sort by the encounterDatetime column, will datatables sort it correctly, or will it sort alphabetically?
15:12:10 <djazayeri> i.e. is there already a hidden column for encounterDatetime sorting?
15:12:32 <jportela> they will sort using another hidden column, that contains the milisseconds of the encounterDatetime column
15:13:03 <jportela> there's one thing that bugs me about that table
15:13:14 <jportela> there are some redundancy in it
15:13:20 <djazayeri> I mean: as I read your comment, I think you added another column. But my question is, wasn't there already a column you could have sorted on?
15:13:32 <jportela> well, that column has a problem
15:13:47 <jportela> for encounters in the same day
15:14:07 <jportela> the sorting is "random"
15:14:10 <djazayeri> I see
15:14:20 <jportela> so it would be inconsistent with the Form Entry table
15:14:26 <djazayeri> Did you add a column at the beginning/end?
15:14:33 <jportela> that uses the sorting provided by the ForEachEncounter tag
15:14:39 <jportela> yes, I added at the end
15:14:56 <djazayeri> Could you instead have fixed the encounter date column?
15:15:24 <jportela> I think I can use the sort order in that column
15:15:36 <jportela> although it wouldn't contain the milisseconds
15:15:43 <jportela> it would containt the appropriate sort order
15:15:47 <jportela> would that be okay?
15:17:39 <djazayeri> looking at the original code (not your patch) I see that it sorts on column 3 i.e. the datetime
15:17:53 <djazayeri> so what you should do is fix it so that sorting by datetime sorts correctly.
15:20:13 <djazayeri> (I think the problem is that the formatDate tag does not do what I would expect if you give it a "milliseconds" argument
15:20:42 <djazayeri> (oh, never mind, I guess it does)
15:21:23 <djazayeri> if for some reason it's necessary to add *another* hidden column, that's okay, but it really ought to be possible to just fix the datetime sort.
15:23:31 <jportela> there is already a hidden column (the one with the milisseconds) that's used exclusively for sorting the datetime, so maybe I could use that column to keep the sorting order provided by the ForEachEncounterTag
15:23:58 <jportela> that would be used for sorting by Encounter Date and the initial sorting (to look the same as the Form Entry tab)
15:25:37 <djazayeri> oh, I am just now understanding.
15:27:09 <djazayeri> Is the problem that the ForEachEncounter tag doesn't sort consistently?
15:28:06 <djazayeri> so if you call it twice you may get a different order?
15:28:16 <jportela> no, it does sort consistently
15:28:26 <djazayeri> oh, but datatables doesn't necessarily sort consistently
15:28:26 <jportela> the problem is that the DataTable plugin for jQuery
15:28:31 <djazayeri> gotcha
15:29:12 <jportela> so I thought using the order of the array provided by the ForEachEncounterTag (which is already sorted)
15:29:16 <djazayeri> Okay, so I would propose that you just take your extra column and make that be the sorting for the datetime column
15:29:25 <jportela> yes I'm doing that now
15:29:31 <jportela> I think it's the best solution
15:30:06 <jportela> and may also improve performance a little (the value is smaller and it wouldn't need to calculate the date in milisseconds)
15:30:07 <djazayeri> and add a comment to the patientEncounters.jsp page next to where it says sortBy="encounterDatetime" saying that if anyone ever changes this, they'll need to change the hidden column for endcounter datetime
15:30:21 <jportela> ok
15:31:53 <djazayeri> if you're feeling particularly inspired after working on the encounters page, you can take a look at TRUNK-422 next.
15:31:57 <djazayeri> !ticket TRUNK-422
15:31:57 <OpenMRSBot> djazayeri: Allow me to help you with that. More details on ticket TRUNK-422 can be found at http://tickets.openmrs.org/browse/TRUNK-422
15:33:02 <djazayeri> the idea is that we don't love the current view/edit paradigm, and we'd like to have a single "view" button (on the dashboard) and only have the edit button be on the view page.
15:33:13 <djazayeri> anyway, step 1, as the ticket says, is to do a mockup of what it should look like
15:33:42 <jportela> sounds interesting
15:34:26 <jportela> usability and UI are my favorite areas :P
15:34:42 <jportela> I'll look at it as soon as I finish this one
15:37:00 *** robbyoconnor has joined #openmrs-sprint
15:41:45 *** downeym is now known as downeym|OpenMRS
15:43:28 <jportela> already uploaded the patch for TRUNK-422
15:43:35 <jportela> TRUNK-221
15:44:38 <jportela> I'll begin working on TRUNK-422 now (after I eat something)
15:56:48 <djazayeri> wyclif: I uploaded HTML Form Entry 1.7.2 to the module repository
15:58:06 <wyclif> ok, i will upgrade, my rudimentary testing went well, i hope it doesn;t affec anything
15:58:17 <wyclif> thanks
16:08:33 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry 1.7.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformentry&version=&1.7.2>
16:40:38 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): [maven-release-plugin] prepare for next development iteration <http://feedproxy.google.com/~r/OMRStrunk/~3/C96rf00kvj0/OpenMRS> || New Changeset: OpenMRS (): [maven-release-plugin] copy for tag 1.8.0-RC <http://feedproxy.google.com/~r/OMRStrunk/~3/3pB8RSbdGAo/OpenMRS> || New Changeset: OpenMRS (1.8.x): [maven-release-plugin] prepare release 1.8.0-RC <http://feedproxy.google.com/~r/OMRStrunk/~3/Sbb4jBzzmWg/OpenMRS> || New Changeset: OpenMRS (1.8.x): Upgrading html form entry to version 1.7.2 <http://feedproxy.google.com/~r/OMRStrunk/~3/ufOfMzeyAs8/OpenMRS>
17:05:16 <jportela> djazayeri, I already submitted a mockup for TRUNK-422
17:05:32 <djazayeri> !ticket TRUNK-422
17:05:32 <OpenMRSBot> djazayeri: Allow me to help you with that. More details on ticket TRUNK-422 can be found at http://tickets.openmrs.org/browse/TRUNK-422
17:14:55 <djazayeri> jportela: I commented there. Basically it's a bit more complicated because the view/edit encounter links for particular encounters may be provided by form entry modules.
17:15:40 <djazayeri> Can you do a second mockup, given my comment? It should include two encounters in the encounters table, one called "an xform" and the other called "an html form"
17:15:53 <djazayeri> xforms does not provide a view URL, but it does provide an edit URL.
17:15:59 <djazayeri> html form entry provides both
17:16:16 <djazayeri> Let me know if that all makes sense. (First read my ticket comment, then what I wrote here.)
17:30:44 <jportela> so, the xforms should use the edit page as the view page (with disabled input), while html forms will use the view page they provide?
17:30:46 <jportela> is that it?
17:31:37 <djazayeri> xforms should use the _core_ edit page (with disabled input) as the view page. it will use the _xforms_ edit page to edit.
17:31:46 <djazayeri> html forms will use its own view page, and its own edit page.
17:32:15 <djazayeri> (Yes, same as what you said, I just wanted to clarify that it's the _core_ edit page for xforms.)
17:33:19 <djazayeri> Also, when I say "with the inputs disabled" I don't really mean just putting disabled="disabled" on all the html elements. I mean not having forms, and printing values normally.
17:33:42 <djazayeri> Perhaps it should actually be a new page, but maybe it's easier to make the edit encounter page take a mode argument.
17:35:44 <jportela> ok
17:35:45 <jportela> got it
17:37:06 <jportela> I'll be working for something different now, but I'll try to do the mockups today :)
17:41:43 <djazayeri> cool
18:04:35 *** harsha has joined #openmrs-sprint
18:10:17 *** bwolfe has quit IRC
18:20:47 *** wyclif has quit IRC
18:33:11 *** downeym|OpenMRS is now known as OpenMRS|downeym
18:47:01 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OpenMRS 1.8 Release Candidate now available for testing! http://bit.ly/fsp33G #ICT4D #eHealth <http://twitter.com/OpenMRS/statuses/61493011363807233>
18:57:12 *** djazayeri is now known as OpenMRS|djazayer
19:15:46 *** harsha has quit IRC
19:15:51 *** harsha1 has joined #openmrs-sprint
19:18:10 *** OpenMRS|downeym is now known as downeym
19:28:32 *** OpenMRS|djazayer is now known as djazayeri
20:02:20 *** harsha1 has left #openmrs-sprint
21:08:17 *** downeym has quit IRC
21:55:35 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Error when creating Patient Identifier with duplicate value - TRUNK-224... <http://feedproxy.google.com/~r/OMRStrunk/~3/zMSlzPZmQvI/OpenMRS>
23:22:02 *** jportela has quit IRC