| 00:18:41 | *** dmexs_ has quit IRC |
| 00:18:57 | *** dmexs_ has joined #openmrs-sprint |
| 02:11:52 | *** wyclif has joined #openmrs-sprint |
| 02:12:18 | *** Guest60650 has joined #openmrs-sprint |
| 03:39:58 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Add Service, Privileges and DAO for Visit - TRUNK-2236 <http://feedproxy.google.com/~r/OMRStrunk/~3/4uARibUW_gI/OpenMRS> |
| 04:10:12 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Adding global property for enabling/disabling concept map type management on admin page <http://feedproxy.google.com/~r/OMRStrunk/~3/9LIofu7mDNQ/OpenMRS> |
| 04:11:46 | *** bwolfe has joined #openmrs-sprint |
| 04:11:46 | *** ChanServ sets mode: +o bwolfe |
| 04:42:42 | *** robbyoconnor has joined #openmrs-sprint |
| 05:37:50 | *** bwolfe has quit IRC |
| 05:47:43 | *** dmexs has joined #openmrs-sprint |
| 05:47:43 | *** dmexs_ has quit IRC |
| 05:50:54 | *** bwolfe has joined #openmrs-sprint |
| 05:50:54 | *** ChanServ sets mode: +o bwolfe |
| 07:05:29 | *** robbyoconnor has quit IRC |
| 07:34:20 | *** robbyoconnor has joined #openmrs-sprint |
| 07:34:23 | *** robbyoconnor has joined #openmrs-sprint |
| 07:36:35 | *** robbyoconnor has quit IRC |
| 07:39:30 | *** robbyoconnor has joined #openmrs-sprint |
| 07:39:30 | *** robbyoconnor has joined #openmrs-sprint |
| 07:46:28 | *** robbyoconnor has quit IRC |
| 07:47:11 | *** robbyoconnor has joined #openmrs-sprint |
| 07:48:05 | *** robbyoconnor has quit IRC |
| 07:48:26 | *** robbyoconnor has joined #openmrs-sprint |
| 09:45:19 | *** dkayiwa has joined #openmrs-sprint |
| 11:36:38 | *** Guest60650 has quit IRC |
| 11:37:17 | *** wyclif has quit IRC |
| 12:20:48 | *** Guest60650 has joined #openmrs-sprint |
| 12:20:48 | *** wyclif has joined #openmrs-sprint |
| 13:05:03 | *** dkayiwa has quit IRC |
| 13:07:13 | *** dkayiwa has joined #openmrs-sprint |
| 13:21:38 | <wyclif> hi dkayiwa |
| 13:22:00 | <dkayiwa> hi wyclif |
| 13:22:03 | <wyclif> i have renamed your changeset for adding visit type so that the check digit doesn't fail |
| 13:22:41 | <wyclif> and that means other deve will have to drop their existing table for it to get recreated with the changes you made |
| 13:23:01 | <dkayiwa> oh thanks so much. have you commited? |
| 13:23:32 | <dkayiwa> did you rename the changeset id? |
| 13:24:18 | <wyclif> yes |
| 13:24:31 | <wyclif> i have just changed the last 1000 to 1001 |
| 13:24:42 | <wyclif> in the changeset id |
| 13:24:53 | <dkayiwa> oh, i did not know that 1000 is not allowed |
| 13:25:00 | <dkayiwa> is it? |
| 13:25:25 | <wyclif> that is okay, but whenever you edit a changest that has been run, it will fail |
| 13:25:37 | <dkayiwa> yes |
| 13:25:42 | <wyclif> because liquibase discourages editing of executed changesets |
| 13:25:49 | <dkayiwa> i did not edit |
| 13:26:05 | <dkayiwa> i instead created a new one as ben suggested |
| 13:26:25 | <dkayiwa> for renaming the retired_reason column to retire_reason |
| 13:26:46 | <wyclif> then someelse might have |
| 13:26:55 | <dkayiwa> might have? |
| 13:27:41 | <dkayiwa> might have done what? |
| 13:28:06 | <wyclif> someone might have edited it, because it was failing the check and it is the only reason why this occurs |
| 13:28:26 | <wyclif> look at that changeset's history |
| 13:28:50 | <dkayiwa> did you have it fail even after reverting your local changes? |
| 13:29:16 | <dkayiwa> because i updated and still found the changeset to have the retired_reason column instead of retire_reason |
| 13:29:35 | <wyclif> see rev:19501 |
| 13:29:41 | <dkayiwa> let me check that |
| 13:29:54 | <wyclif> you added a not null check |
| 13:30:07 | <dkayiwa> lollllllllllllllllllll |
| 13:30:35 | <dkayiwa> do you mean when i removed the not null constraint on the description column? |
| 13:31:14 | <wyclif> i think so |
| 13:31:43 | <dkayiwa> I had forgotten about that. you have caught me red handed :D |
| 13:31:59 | <dkayiwa> have you committed your changes? |
| 13:32:01 | <wyclif> why not blue handed? |
| 13:32:13 | <dkayiwa> hahahahhaa red is more dangerous :) |
| 13:32:21 | <wyclif> ha ha ha! yes i have, it should be fine |
| 13:32:39 | <dkayiwa> ok let me update. thanks :) |
| 13:32:52 | <wyclif> Since we know everyone working on the sprint |
| 13:33:25 | <dkayiwa> :D |
| 13:33:53 | <wyclif> i suggest we just ask everyone to drop the table |
| 13:33:59 | <dkayiwa> ok |
| 13:34:19 | <dkayiwa> should we also rename the retired_column |
| 13:34:26 | <wyclif> i also updated the one visit so you might need to drop it too |
| 13:34:29 | <dkayiwa> such that i do not have to create a new changeset for it? |
| 13:34:37 | <dkayiwa> no problem |
| 13:34:39 | <dkayiwa> i can do that |
| 13:34:43 | *** downeym has joined #openmrs-sprint |
| 13:34:43 | *** ChanServ sets mode: +o downeym |
| 13:34:44 | *** OpenMRSBot sets mode: +o downeym |
| 13:35:27 | <wyclif> correct, the point is that since we are doing sprints, we need to be able to edit changesets after code review without having to create new changesets |
| 13:35:39 | <wyclif> with checksum numbers to be validated |
| 13:36:24 | <dkayiwa> i love that better than having to create new changesets for small mistakes that the devs made before releasing |
| 13:36:56 | <dkayiwa> so, are you renaming the column and commit again? |
| 13:37:06 | <wyclif> actually i have notices this as one of the drawbacks to sprints |
| 13:37:16 | <dkayiwa> retired_reason to retire_reason |
| 13:37:16 | <wyclif> sorry! noticed |
| 13:37:43 | <dkayiwa> why would it be a drawback of sprints? |
| 13:38:03 | <wyclif> it is hard to manage changesets if you edit them without |
| 13:38:06 | <dkayiwa> couldn't it happen even when we are not sprinting? |
| 13:38:12 | <wyclif> ofcourse it is minor |
| 13:38:32 | <wyclif> when we are not sprinting, normally you commit once |
| 13:38:49 | *** dmexs has quit IRC |
| 13:38:52 | <wyclif> so it is rare to edit it |
| 13:39:17 | <wyclif> but now, since we commit early, there is s higher chance that we will editing them |
| 13:39:19 | <dkayiwa> do sprints force us to commit more than once? |
| 13:39:51 | <dkayiwa> i see people recommend comiting early and often. |
| 13:39:55 | <wyclif> Ben was suggesting that actually changesets should probably be precommit code reviewed |
| 13:40:00 | <wyclif> to minimise this |
| 13:40:19 | <dkayiwa> i love your having used minimise instead of solve |
| 13:40:22 | <wyclif> and i agree with him |
| 13:40:28 | <dkayiwa> sure |
| 13:41:13 | <wyclif> and i agree with you that sprints are not the only cause of this |
| 13:41:22 | <dkayiwa> ok, so are you renaming the retired_reason column, or should i? |
| 13:41:28 | <dkayiwa> correct |
| 13:41:46 | <wyclif> am not sure how you handling it |
| 13:41:57 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Follow up to, changing the changeset id for add visit_type table so that the checksum validation passes - TRUNK-2232 <http://feedproxy.google.com/~r/OMRStrunk/~3/x-LIRj77QV4/OpenMRS> |
| 13:42:05 | <wyclif> i thought you had already committed that other changeset |
| 13:42:23 | *** dmexs has joined #openmrs-sprint |
| 13:42:23 | <dkayiwa> i was about to commit (5 mins) and then you told me about your change |
| 13:42:41 | <dkayiwa> so i did not want risk getting conflicts |
| 13:43:07 | <dkayiwa> but i can do it and commit |
| 13:43:10 | <dkayiwa> let me do so |
| 13:43:23 | <wyclif> i think you can do the same, just rename it and make the change |
| 13:43:33 | <dkayiwa> ok |
| 13:43:38 | <wyclif> i will drop my table again |
| 13:43:42 | <dkayiwa> ok |
| 13:43:50 | <wyclif> i guess am the only one with my change |
| 13:43:55 | <dkayiwa> ok |
| 13:44:40 | <wyclif> i mean you have torename the changeset id again |
| 13:44:55 | <dkayiwa> yes |
| 13:44:58 | <wyclif> thanks |
| 13:45:05 | <dkayiwa> 1002 |
| 13:45:09 | <wyclif> cool |
| 13:46:07 | *** dmexs has quit IRC |
| 13:58:37 | <downeym> !devmtg |
| 13:58:37 | <OpenMRSBot> downeym: Error: "devmtg" is not a valid command. |
| 13:58:48 | <downeym> oh well. :) time for meeting anyway |
| 13:59:38 | *** bwolfe has quit IRC |
| 14:12:05 | *** bwolfe has joined #openmrs-sprint |
| 14:12:05 | *** ChanServ sets mode: +o bwolfe |
| 14:19:29 | *** dkayiwa has quit IRC |
| 14:27:48 | *** dkayiwa has joined #openmrs-sprint |
| 14:43:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Adding Manage Visit Types pages - TRUNK-2234 <http://feedproxy.google.com/~r/OMRStrunk/~3/l1ZCP-ex0UU/OpenMRS> |
| 15:45:18 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Adding validation of visit types to the service layer - TRUNK-2234 <http://feedproxy.google.com/~r/OMRStrunk/~3/liCw3l8dm4Q/OpenMRS> |
| 16:08:15 | *** downeym has quit IRC |
| 16:36:39 | <djazayeri> hi everyone |
| 16:36:52 | <dkayiwa> hi Darius |
| 16:38:32 | <djazayeri> Sorry I missed the conversation about changesets |
| 16:39:26 | <djazayeri> Personally I think that for a completely new feature like visits, it's okay to ask the few people who are running the head revision to drop the table. |
| 16:39:50 | <djazayeri> But I think it'd be good practice to show a changeset to _someone_ before committing it. |
| 16:40:01 | <djazayeri> it could be a pre-commit review, or even just using pastebin. |
| 16:40:01 | <dkayiwa> ok |
| 16:40:08 | <dkayiwa> ok |
| 16:40:34 | <djazayeri> But only if there's someone else on this sprint channel who can look at it quickly. |
| 16:40:48 | <djazayeri> When we're sprinting, we should be fast. :-) |
| 16:41:14 | <dkayiwa> sure :D |
| 17:05:42 | *** dkayiwa has quit IRC |
| 17:05:55 | *** dkayiwa has joined #openmrs-sprint |
| 17:08:34 | <bwolfe> djazayeri: the problem with asking the people running the head revision is that we're committing to trunk. that could be anyone. especially if the changeset isn't reviewed for a few hours/days |
| 17:09:13 | <djazayeri> bwolfe: yeah, I only think it's okay in the context of a sprint where the code review happens within hours. |
| 17:09:26 | <djazayeri> In retrospect, though, we (I) should have created a visits branch. |
| 17:21:44 | <djazayeri> dkayiwa, wyclif: thanks for including the revision number and code review links in your ticket comments. :-) |
| 17:21:57 | <dkayiwa> :) |
| 17:42:09 | *** downeym has joined #openmrs-sprint |
| 17:42:09 | *** ChanServ sets mode: +o downeym |
| 17:42:10 | *** OpenMRSBot sets mode: +o downeym |
| 17:52:21 | <djazayeri> dkayiwa, wyclif, I code reviewed both your tickets and summarized them |
| 17:52:32 | <dkayiwa> ok thanks |
| 18:11:02 | <wyclif> djazayeri, thanks, i will look at the comments |
| 18:13:06 | <wyclif> i agree that this should have been a branch |
| 18:14:03 | <wyclif> because that way the people working on the branch(the sprinters) can be asked to take the necessary action e.g dropping a table |
| 18:25:00 | *** dkayiwa has quit IRC |
| 18:42:30 | <wyclif> djazayeri, The issue of the auditable interceptor is something that am not sure how to solve, but sometimes it doesn't work as expected. I doubt if we have a ticket for it, but it has to do with the fact that hibernate drops the previousState array it passes to the intercept which makes the logic fail because it checks if that array is not null, this occurs once you have multiple objects with the same id because it can't tell which state to choos |
| 18:42:30 | <wyclif> e(as per my research), and i technically expect an exception to get thrown, which i actually never get. This relates back to the debate i started on the dev list about of using merge vs saveOrUpdate because with merge this never arises and the interceptor becomes flawless. |
| 18:42:45 | <wyclif> may be my findings from the research on previousSate being null may be invalid |
| 18:47:25 | <djazayeri> (will reply in 15 mins when done with phone call) |
| 19:04:01 | <djazayeri> Okay, I'm back. |
| 19:04:23 | <djazayeri> wyclif: can you replicate the auditable interceptor bug in a unit test? |
| 19:04:31 | <djazayeri> it looks like you can do so in this one |
| 19:08:00 | <wyclif> i will |
| 19:10:33 | <wyclif> i recall daniel wanted such a test for that issue because i guess he wanted to work on it in the past |
| 19:10:48 | <wyclif> i will create a ticket and attach the test |
| 19:10:53 | <djazayeri> That would be great |
| 20:16:38 | *** downeym has quit IRC |
| 20:52:45 | *** wyclif has quit IRC |
| 20:52:45 | *** Guest60650 has quit IRC |
| 21:05:35 | *** Guest60650 has joined #openmrs-sprint |
| 21:05:52 | *** wyclif has joined #openmrs-sprint |
| 22:21:39 | *** wyclif has quit IRC |
| 22:22:00 | *** Guest60650 has quit IRC |