| 01:10:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): TRUNK-2213 - error en el tag obsValueField - error in the obsValueField tag <http://feedproxy.google.com/~r/OMRStrunk/~3/d0fL6QBWO44/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2213 - error en el tag obsValueField - error in the obsValueField tag <http://feedproxy.google.com/~r/OMRStrunk/~3/OL2Gx0tkAFA/OpenMRS> |
| 01:18:43 | *** downeym has joined #openmrs-sprint |
| 01:18:43 | *** ChanServ sets mode: +o downeym |
| 01:18:44 | *** OpenMRSBot sets mode: +o downeym |
| 01:37:03 | *** downeym has quit IRC |
| 02:15:05 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Fixing possible errors on the concept reference term form <http://feedproxy.google.com/~r/OMRStrunk/~3/JysTQfeoXzY/OpenMRS> |
| 03:25:39 | *** suho has joined #openmrs-sprint |
| 03:27:18 | <suho> hi djazayeri when i try to void the person name |
| 03:28:01 | <suho> It calls BaseVoidHandler and then it stores the personName |
| 03:28:29 | <suho> and then only returns to the PersonServiceImpl |
| 03:28:49 | <djazayeri> The void handler is called _before_ the method? |
| 03:29:27 | <suho> at this time its already stored so the checking i do in the PersonServiceImpl is not worth |
| 03:29:30 | <suho> yes |
| 03:30:13 | <djazayeri> hmm, that's unfortunate |
| 03:30:18 | <suho> so what am i todo |
| 03:30:22 | <suho> so shall i |
| 03:30:30 | <suho> delete the personName |
| 03:30:44 | <suho> if condition fails |
| 03:32:02 | <djazayeri> no |
| 03:32:55 | <djazayeri> So, I was hoping you wouldn't have to deal with this in this ticket. |
| 03:33:13 | <djazayeri> We have these automatic SaveHandler, VoidHandler, RetireHandler, etc. |
| 03:33:41 | <djazayeri> They seemed like a great idea at the time, because they do lots of things automatically, and let us stick to conventions. |
| 03:33:48 | <djazayeri> But I don't think we implemented them exactly right. |
| 03:34:34 | <djazayeri> So, I believe what you might have to do is move the validation code you wrote out of the save method, and into a SaveHandler specifically for PersonName. |
| 03:35:04 | <suho> ok i'll take that approach |
| 03:36:47 | <djazayeri> Take an example like ConceptNameSaveHandler. |
| 03:36:55 | <djazayeri> and try following that pattern |
| 03:38:01 | <suho> ok great |
| 03:38:08 | <djazayeri> the key is that you have to put the @Handler(PersonName.class) annotation on it |
| 03:39:16 | <suho> ok i got it |
| 03:51:25 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Fixing possible errors when removing invalid mappings on the concept form <http://feedproxy.google.com/~r/OMRStrunk/~3/XNdUj4qz16E/OpenMRS> |
| 04:23:28 | *** suho has quit IRC |
| 06:39:45 | *** bwolfe has joined #openmrs-sprint |
| 06:39:45 | *** ChanServ sets mode: +o bwolfe |
| 06:49:44 | *** dkayiwa has joined #openmrs-sprint |
| 07:10:52 | *** wyclif has quit IRC |
| 07:11:42 | *** wyclif has joined #openmrs-sprint |
| 07:45:10 | *** wyclif has quit IRC |
| 07:54:29 | *** wyclif has joined #openmrs-sprint |
| 09:05:41 | *** dkayiwa has quit IRC |
| 09:05:48 | *** dkayiwa has joined #openmrs-sprint |
| 09:29:19 | *** bwolfe has quit IRC |
| 09:42:57 | *** bwolfe has joined #openmrs-sprint |
| 09:42:57 | *** ChanServ sets mode: +o bwolfe |
| 11:24:44 | *** bwolfe has quit IRC |
| 11:45:35 | *** bwolfe has joined #openmrs-sprint |
| 11:45:35 | *** ChanServ sets mode: +o bwolfe |
| 12:21:01 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Adding domain object, liquibase, and hibernate mapping for VisitType - TRUNK-2232 <http://feedproxy.google.com/~r/OMRStrunk/~3/Qviq7QSRYUM/OpenMRS> |
| 12:44:55 | *** downeym has joined #openmrs-sprint |
| 12:44:55 | *** ChanServ sets mode: +o downeym |
| 12:44:57 | *** OpenMRSBot sets mode: +o downeym |
| 13:05:08 | *** dkayiwa has quit IRC |
| 13:05:46 | *** dkayiwa has joined #openmrs-sprint |
| 13:29:04 | <wyclif> hi Darius |
| 13:36:44 | *** bwolfe has quit IRC |
| 13:49:20 | *** bwolfe has joined #openmrs-sprint |
| 13:49:24 | *** ChanServ sets mode: +o bwolfe |
| 14:43:23 | *** suho has joined #openmrs-sprint |
| 15:10:35 | <djazayeri> good morning all |
| 15:10:46 | <djazayeri> dkayiwa: I see that you committed code for 2232 |
| 15:10:50 | <dkayiwa> yes |
| 15:11:17 | <djazayeri> and you've moved onto the service and DAO ticket |
| 15:11:24 | <dkayiwa> TRUNK-2233 |
| 15:11:28 | <dkayiwa> yes |
| 15:12:03 | <djazayeri> wyclif: daniel has done the domain objects for visit type, you'll do the domain objects for visit. |
| 15:12:12 | <djazayeri> 2235 |
| 15:13:05 | <wyclif> cool |
| 15:28:10 | <suho> hi djazayeri I have attached the patch to https://tickets.openmrs.org/browse/TRUNK-2198 |
| 15:28:38 | <djazayeri> suho: great, I will take a look, but probably not for half an hour. |
| 15:29:11 | <suho> ok I'll work on the other one TRUNK-2211 |
| 15:29:21 | <djazayeri> that's the equivalent ticket for addresses, right? |
| 15:29:55 | <suho> yes |
| 15:30:22 | <djazayeri> cool |
| 16:00:34 | *** downeym has quit IRC |
| 16:32:56 | <djazayeri> bwolfe: how goes the spike? |
| 16:55:17 | <djazayeri> dkayiwa: I made some minor comments on your commit. (they are not urgent) |
| 16:55:26 | <dkayiwa> ok |
| 16:55:40 | <dkayiwa> thanks djazayeri |
| 16:55:55 | <djazayeri> I see you just committed the other too |
| 16:55:59 | <dkayiwa> how do i see those comments? |
| 16:56:03 | <dkayiwa> yes |
| 16:58:51 | <djazayeri> dkayiwa: I made the comments on the ticket. https://tickets.openmrs.org/browse/TRUNK-2232 |
| 16:58:59 | <dkayiwa> ok |
| 16:59:31 | <dkayiwa> thanks seen them |
| 17:05:28 | *** dkayiwa has quit IRC |
| 17:05:50 | *** dkayiwa has joined #openmrs-sprint |
| 17:15:21 | <djazayeri> dkayiwa: reviewed the other commits also. one defect, the rest is stylistic |
| 17:15:38 | <dkayiwa> ok. thanks :) |
| 17:22:31 | <suho> hi djazayeri |
| 17:22:49 | <suho> I have attached a patch for https://tickets.openmrs.org/browse/TRUNK-2211 as well |
| 17:22:49 | <bwolfe> djazayeri: the spike is going well. I'm on the third iteration :-) |
| 17:22:50 | <djazayeri> hi suho I'm just looking at your attached patch now--does this include the SaveHandler? |
| 17:23:04 | <djazayeri> (for the prior ticket I mean) |
| 17:23:21 | <bwolfe> djazayeri: I have some questions about some options I'll post to the ticket for you/burke/whomever to comment on |
| 17:23:29 | <djazayeri> bwolfe: great, looking forward to them |
| 17:23:33 | <suho> no I finally found out that its not needed |
| 17:24:13 | <djazayeri> because you're throwing an exception? |
| 17:24:54 | <suho> because it not used return dao.savePersonName(personName); |
| 17:25:57 | <djazayeri> I don't understand. |
| 17:26:46 | <djazayeri> suho: I did notice one other thing just now, that I wish I'd noticed earlier. It may be that the voidPersonName and unvoidPersonName methods should be empty (because the BaseVoidHandler and BaseUnvoidHandler take care of this). Would you mind commenting out the code in those methods, then re-running the unit tests, and seeing if they still pass? |
| 17:27:17 | <suho> yes |
| 17:27:32 | <suho> thats the place i thought it was saving |
| 17:27:38 | <suho> but its not |
| 17:28:16 | <suho> yes if you comment it will still get |
| 17:28:25 | <suho> converted |
| 17:29:29 | <suho> actually I have to do the saving in the voidPersonName() |
| 17:29:30 | <djazayeri> Yes, we did things that way so that all the void/unvoid methods would behave consistently. |
| 17:30:09 | <djazayeri> you mean: voidPersonName(PersonName pn) { personService.savePersonName(pn); } ? |
| 17:30:21 | <suho> yes |
| 17:32:11 | <djazayeri> Cool. Can you make one more patch, then, with that change? |
| 17:32:18 | <djazayeri> Probably the same change can be made on the other ticket. |
| 17:33:38 | *** downeym has joined #openmrs-sprint |
| 17:33:38 | *** ChanServ sets mode: +o downeym |
| 17:33:38 | <suho> ok in the |
| 17:33:39 | *** OpenMRSBot sets mode: +o downeym |
| 17:33:40 | <suho> public Relationship voidRelationship(Relationship relationship, String voidReason) throws APIException { |
| 17:33:40 | <suho> if (relationship.isVoided()) |
| 17:33:40 | <suho> return relationship; |
| 17:33:55 | <suho> in the voidRelationship |
| 17:34:35 | <suho> it checks for if (relationship.isVoided()) but in the voidPersonName(PersonName pn) I'm not doing that |
| 17:35:04 | <djazayeri> if you look at the code for BaseVoidHandler, you'll see that it already does that. |
| 17:35:35 | <suho> yes.. now I got it .. Thanks :) |
| 17:42:20 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Adding applicationContext-service.xml changes for Service and DAO for VisitType - TRUNK-2233 <http://feedproxy.google.com/~r/OMRStrunk/~3/oTe9yclZDS8/OpenMRS> || New Changeset: OpenMRS (trunk): Adding Service and DAO for VisitType - TRUNK-2233 <http://feedproxy.google.com/~r/OMRStrunk/~3/DmMiUJyVrRQ/OpenMRS> |
| 17:50:11 | *** dkayiwa has quit IRC |
| 17:58:01 | <bwolfe> djazayeri: why is the liquibase stuff for provider "non essential" ?? |
| 17:58:16 | <djazayeri> because all the provider stuff is non-essential for this sprint |
| 17:58:21 | <djazayeri> Visit is essential. |
| 17:58:42 | <djazayeri> Depending on how fast we get that done, we may bring in the provider stuff too. |
| 17:58:56 | <djazayeri> VisitAttribute stuff is non-essential also. |
| 17:59:13 | <bwolfe> ah, got it |
| 17:59:29 | <djazayeri> Basically I don't know how best to represent this. Is it better to start with fewer tickets in a sprint and add more if we finish the initial ones? |
| 17:59:46 | <djazayeri> Or is it better to have lots of extra tickets, and bump them out if we don't get to them. |
| 18:05:43 | <bwolfe> djazayeri: so far its been the latter |
| 18:05:55 | <bwolfe> but we should we probably do the former |
| 18:06:14 | <bwolfe> so that we can do a testing loop at the end of sprints potentially |
| 18:06:24 | <bwolfe> or focus everyone on finishing outstanding reviews |
| 18:11:13 | *** dkayiwa has joined #openmrs-sprint |
| 18:12:39 | <suho> djazayeri, I attached both patches, TRUNK-2198 & TRUNK-2211, |
| 18:12:50 | <djazayeri> bwolfe: I agree, so I'll set up a new sprint for 1.9 Road Map Sprint 2, and move the provider tickets there. |
| 18:13:09 | <djazayeri> suho: great, I'll take a look at them soon, but I imagine they're perfect now. |
| 18:13:29 | *** bwolfe has quit IRC |
| 18:13:51 | <suho> djazayeri, great, thanks for your time :) |
| 18:16:07 | <djazayeri> suho: thanks for _your_ time. :-) |
| 18:17:04 | <suho> djazayeri, I'm learning a lot here :) |
| 18:33:00 | *** bwolfe has joined #openmrs-sprint |
| 18:33:00 | *** ChanServ sets mode: +o bwolfe |
| 18:35:04 | *** downeym_ has joined #openmrs-sprint |
| 18:35:04 | *** ChanServ sets mode: +o downeym_ |
| 18:35:24 | *** downeym has quit IRC |
| 18:35:24 | *** downeym_ is now known as downeym |
| 18:58:46 | <wyclif> unit tests in trunk don't seem to be failing |
| 19:07:32 | *** suho has quit IRC |
| 19:15:49 | <wyclif> sorry, seem to be failing |
| 19:17:29 | *** bwolfe has quit IRC |
| 19:36:05 | <wyclif> hi Daniel |
| 19:36:11 | <dkayiwa> Hi Why |
| 19:36:46 | <wyclif> can you have a look at standardDataset, the unit tests are failing |
| 19:36:59 | <wyclif> because of some changes in the order rows |
| 19:37:06 | <dkayiwa> oh i seee |
| 19:37:24 | <wyclif> have you added the orders stuff? |
| 19:37:43 | <wyclif> i think it got in by mistake |
| 19:37:59 | <dkayiwa> i think i committed the order rows in that file when i was supposed not to |
| 19:38:09 | <dkayiwa> can you revert it to an earlier revision? |
| 19:38:14 | <wyclif> oh i see |
| 19:39:06 | <wyclif> what is did to make them pass on mine was to replace the test data set file to the one before it |
| 19:39:40 | <dkayiwa> that makes perfect sense |
| 19:39:49 | <dkayiwa> you can overwrite mine and commit |
| 19:40:01 | <wyclif> sure i will do that |
| 19:40:08 | <dkayiwa> thanks alot |
| 19:40:17 | <wyclif> no problem, one other thing |
| 19:40:23 | <dkayiwa> ok |
| 19:40:33 | <wyclif> have you written the tests for visity type? |
| 19:40:43 | <dkayiwa> yes i commited them |
| 19:41:14 | <wyclif> which class is that? |
| 19:41:19 | <wyclif> the test class? |
| 19:42:03 | <dkayiwa> VisitServiceTest |
| 19:48:19 | <wyclif> sorry my mistake, when i reverted the test data, i removed the visit type rows but now it should be fine after putting them back |
| 19:48:21 | <wyclif> thanks |
| 19:49:24 | <dkayiwa> ok |
| 19:54:45 | *** downeym has quit IRC |
| 20:04:10 | <djazayeri> I wonder why we didn't get an email to the dev list about the failed unit tests. |
| 20:04:41 | <dkayiwa> could be they do not run on immediately on commit |
| 20:05:21 | <djazayeri> They used to. I noticed you committed those rows, and commented in the code review, but I didn't copy them into the comment on the ticket. |
| 20:05:31 | <djazayeri> I figured that since I didn't get an email, nothing broke. :-) |
| 20:05:41 | <dkayiwa> :D |
| 20:05:46 | <djazayeri> Anyway, I summarized the review for you. |
| 20:05:52 | <dkayiwa> oh thanks |
| 20:06:03 | <djazayeri> off to lunch |
| 20:06:10 | <dkayiwa> ok |
| 20:18:33 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Follow up to clean up drug_order rows in standard test dataset - TRUNK-2233 <http://feedproxy.google.com/~r/OMRStrunk/~3/Nl61V3T4Nvc/OpenMRS> || New Changeset: OpenMRS (trunk): Add voidPersonAddress method in PersonService - TRUNK-2211... <http://feedproxy.google.com/~r/OMRStrunk/~3/AUsx8fpjiDc/OpenMRS> || New Changeset: OpenMRS (trunk): Domain object, liquibase, and hibernate mapping for Visit - TRUNK-2235 <http://feedproxy.google.com/~r/OMRStrunk/~3/eKshkP3drMA/OpenMRS> || New Changeset: OpenMRS (trunk): Implement voiding of PersonNames - TRUNK-2198... <http://feedproxy.google.com/~r/OMRStrunk/~3/VcDw5Z9C9vo/OpenMRS> |
| 21:07:11 | *** dkayiwa has quit IRC |
| 21:07:15 | *** dkayiwa_ has joined #openmrs-sprint |
| 22:07:27 | *** dkayiwa_ has left #openmrs-sprint |
| 22:11:31 | <djazayeri> wyclif: I see that you have two of the visits tickets assigned to you |
| 22:11:33 | <djazayeri> what's up with that? |
| 22:12:23 | <djazayeri> i.e. I think TRUNK-2236 should stay unassigned until you've committed something for 2235 |
| 22:17:48 | <wyclif> i have committed 2235 |
| 22:28:45 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Fixing concept reference term auto complete not to return retired ones <http://feedproxy.google.com/~r/OMRStrunk/~3/ssnD1GCvo8o/OpenMRS> || New Changeset: OpenMRS (concept_mappings): concept_mappings: Fixing concept reference term and map type editors <http://feedproxy.google.com/~r/OMRStrunk/~3/iwHUYtZoeWY/OpenMRS> || OpenMRS Modules: XForms 4.0.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.0> |
| 22:40:35 | <djazayeri> wyclif: one or two very small fixes to 2235. |
| 22:42:11 | <wyclif> ok |
| 23:00:52 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @isaacholeman: People in the @OpenMRS community hiring again #ehealth #ict4d http://openmrs.org/about/jobs <http://twitter.com/OpenMRS/statuses/60465926063132672> |
| 23:40:12 | *** dmexs has joined #openmrs-sprint |