| 00:04:01 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Fixing the name of the purge patient programs privilege in trunk. See TRUNK-296. <http://feedproxy.google.com/~r/OMRStrunk/~3/4wfiUBBndX4/OpenMRS> || New Changeset: OpenMRS (1.8.x): Fixing the name of the purge patient programs privilege in 1.8.x branch. See TRUNK-296. <http://feedproxy.google.com/~r/OMRStrunk/~3/v3AbFEFUfFo/OpenMRS> || New Changeset: OpenMRS (1.7.x): Fixing the name of the purge patient programs privilege in 1.7.x branch. See TRUNK-296. <http://feedproxy.google.com/~r/OMRStrunk/~3/QVel3xH3bMI/OpenMRS> |
| 00:30:26 | *** dmexs has joined #openmrs |
| 00:38:29 | *** gbastien has quit IRC |
| 00:55:25 | *** dmexs_ has joined #openmrs |
| 00:58:44 | *** dmexs has quit IRC |
| 01:22:03 | <deadpool> bwolfe; how do you find a patient by their identifier i tried looking at patientservice.java but the closest thing i could find was getpatientuuid but that is not what i wanted |
| 01:27:16 | *** chopin has joined #openmrs |
| 01:27:16 | *** ChanServ sets mode: +v chopin |
| 01:28:46 | *** gbastien has joined #openmrs |
| 01:39:56 | <deadpool> chopin: do you know how to get a patient by their identifier? |
| 01:39:57 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Fixes to the Concept Dictionary search and view pages, which add appropriate privilege checks in such that an anonymous ... <http://feedproxy.google.com/~r/OMRStrunk/~3/EFKotZ4fFCw/OpenMRS> |
| 01:51:08 | *** ohla has joined #openmrs |
| 01:52:15 | <deadpool> hello |
| 01:52:26 | *** ohla has left #openmrs |
| 01:55:35 | *** jriley has joined #openmrs |
| 02:06:28 | <chopin> deadpool: sorry |
| 02:06:51 | <chopin> deadpool: yes, um ... PatientService.getPatients() has an identifier variable i believe |
| 02:07:18 | <deadpool> chopin: i used that it only does it by the patientid |
| 02:08:24 | <chopin> deadpool: getPatients(null, "12345-6", null, true) perhaps? |
| 02:08:28 | * chopin looks |
| 02:08:41 | <chopin> yeah |
| 02:08:44 | <chopin> i think that would do it |
| 02:08:48 | <chopin> it goes for an exact match |
| 02:09:53 | <deadpool> chopin: ooh cool thanks |
| 02:10:50 | <chopin> if you want to match all patients with similar identifiers, use false as the last param |
| 02:11:20 | <chopin> deadpool: gl |
| 02:11:21 | <chopin> :-) |
| 02:11:51 | * chopin runs afk |
| 02:16:38 | *** chopin has quit IRC |
| 02:21:24 | *** deadpool has quit IRC |
| 02:44:07 | *** gbastien has quit IRC |
| 03:40:12 | *** batkinson has joined #openmrs |
| 03:40:54 | *** lh has quit IRC |
| 04:16:53 | *** bwolfe has quit IRC |
| 05:07:46 | *** r0bby has quit IRC |
| 05:08:33 | *** r0bby has joined #openmrs |
| 05:08:33 | *** ChanServ sets mode: +v r0bby |
| 05:17:55 | *** r0bby is now known as robbyoconnor |
| 05:26:32 | *** r0bby has joined #openmrs |
| 05:26:32 | *** ChanServ sets mode: +v r0bby |
| 05:26:41 | *** robbyoconnor has quit IRC |
| 05:52:21 | *** r0bby is now known as robbyoconnor |
| 06:24:30 | *** dkayiwa has joined #openmrs |
| 06:36:21 | *** pascal` has joined #openmrs |
| 06:39:22 | *** pascal` has quit IRC |
| 06:42:18 | *** bwolfe has joined #openmrs |
| 06:42:18 | *** ChanServ sets mode: +o bwolfe |
| 06:44:41 | *** pascal` has joined #openmrs |
| 06:46:26 | *** bwolfe has quit IRC |
| 06:46:48 | *** bwolfe has joined #openmrs |
| 06:46:48 | *** ChanServ sets mode: +o bwolfe |
| 06:59:50 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Adding 'hide' column to concept map types and updating the UI with the changes <http://feedproxy.google.com/~r/OMRStrunk/~3/A-K8Y6wvkYA/OpenMRS> |
| 07:02:09 | *** ChanServ sets mode: +v pascal` |
| 07:12:47 | *** rafa has joined #openmrs |
| 07:12:47 | *** ChanServ sets mode: +v rafa |
| 07:15:50 | *** rahul_ has joined #openmrs |
| 07:16:41 | *** sreya has joined #openmrs |
| 07:16:50 | <sreya> hi dkayiwa |
| 07:17:02 | <dkayiwa> hi sreya: |
| 07:17:07 | <sreya> i have trouble usinf the ncd module |
| 07:17:40 | <sreya> i have applied for Message Delivery Triggered by Conditions within OpenMRS |
| 07:17:53 | <dkayiwa> never used the ncd module, but go ahead and ask |
| 07:17:56 | <sreya> I am familiar with the messaging module |
| 07:18:18 | <dkayiwa> ok |
| 07:18:31 | <sreya> i just wanted to check how to create a critic |
| 07:18:55 | <sreya> n go through the code as to what happens when the critic is met |
| 07:19:11 | <sreya> coz that is the time when we would send the message |
| 07:19:52 | <sreya> so while anybody is creating a critic at that time only a message should be created so when it meets the condition message should be triggered |
| 07:20:43 | <sreya> now the problem is i am unable to install ncd module , so i dont know whether the critic is made for a single patient or it can be created for a gropu too |
| 07:20:58 | <sreya> depending on that we would be sending the messages to the people |
| 07:21:24 | <sreya> I did not include all these detail in my project proposal , coz i didnt know how does ncd module works |
| 07:21:36 | <sreya> but i think now atleast i should add the idea dkayiwa |
| 07:22:05 | <dkayiwa> ok |
| 07:22:32 | <dkayiwa> oh sorry, i had mistaken the ncd module with something else :) |
| 07:22:41 | <dkayiwa> now i know what you are talking about |
| 07:22:46 | <dkayiwa> the gsoc project? |
| 07:23:32 | <bwolfe> sreya: what error are you getting when trying to install it? no one here is an expert on the ncd module, but we might be able to debug its startup |
| 07:23:46 | <sreya> ok wait |
| 07:23:55 | <sreya> lemme start the tomcat |
| 07:24:00 | *** tinasherioga has joined #openmrs |
| 07:24:30 | <sreya> yes, dkayiwa i am talking about the ndc module |
| 07:24:40 | <sreya> i mean the gsoc project |
| 07:25:03 | <dkayiwa> so we do not have such a module yet? right? |
| 07:25:13 | <dkayiwa> it is just the gsoc project. right? |
| 07:25:15 | <sreya> bwolfe: since we have two projects which depend on messaging module , cant we merge them ???? |
| 07:25:48 | <bwolfe> probably not |
| 07:25:58 | <bwolfe> I havne't looked, but they were probably created that way intentionally |
| 07:26:58 | <dkayiwa> sreya: the way i understand it is that the messaging module is just one which provides core services which can be consumed by any other module that needs them |
| 07:28:36 | <sreya> java.lang.ClassNotFoundException: org.openmrs.module.ncd.monitor.SystemActivityA ppender |
| 07:28:41 | <sreya> this is the error |
| 07:29:42 | <sreya> yes correct dkayiwa using the messaging module , we can send the messages. depending on when we need to send messages we just need to code in that module |
| 07:29:44 | <sreya> dkayiwa: |
| 07:29:56 | <sreya> bwolfe: the error is java.lang.ClassNotFoundException: org.openmrs.module.ncd.monitor.SystemActivityA ppender |
| 07:30:14 | <bwolfe> exactly like that? with the space between the A and pp ? |
| 07:30:54 | <sreya> no there is no space |
| 07:30:58 | <sreya> typing error |
| 07:31:57 | <sreya> so in the ncd module , we would provide the functionality of sending messages using messageing module |
| 07:31:59 | <sreya> dkayiwa: |
| 07:32:11 | <dkayiwa> ok |
| 07:32:14 | <sreya> thats thereason i want to install the ncd module and play with it |
| 07:32:52 | <dkayiwa> i thought the gsoc project was about a new module to be created |
| 07:32:57 | <sreya> bwolfe: I am using openmrs 1.7 i think it should work |
| 07:33:02 | <dkayiwa> did we already have the module? |
| 07:33:32 | <sreya> ya we can create a new module too which talks to ncd as well as messaging module |
| 07:35:35 | <sreya> in the wiki its mentioned "The goal is to allow the NCD module to deliver a user specified message via the messaging module when an incoming datum matches a user defined pattern or critic. " |
| 07:35:59 | <sreya> so i thought we include a new feature for the NCD module dkayiwa |
| 07:36:00 | <bwolfe> sreya: edits will be done in the ncd module only probably |
| 07:36:09 | <sreya> yeah ...:) |
| 07:36:21 | <sreya> thats what the project description said |
| 07:36:28 | <sreya> n what i understood |
| 07:36:56 | <dkayiwa> and it makes alot of sense too |
| 07:37:20 | <sreya> i thought i was wrong when dkayiwa said that , but my interpretion was kinda right thanks bwolfe |
| 07:37:39 | <dkayiwa> :D |
| 07:37:55 | <sreya> one more thing i havent mentioned all these things in the proposal , i cant even edit it now ??? |
| 07:39:56 | <sreya> bwolfe: can we add comments would those be considered as a part of proposal |
| 07:41:21 | <bwolfe> some mentors might read comments, some might not. I'm not sure |
| 07:42:12 | <sreya> ohh |
| 07:42:27 | <sreya> thats means i made a terrible mistake |
| 07:43:49 | <dkayiwa> but just incase, you do not lose anything by adding the comments |
| 07:45:47 | <sreya> ya i would first install the ncd module , figure it how it works and then write comments :) |
| 07:46:10 | <dkayiwa> sure :D |
| 07:46:13 | *** dmexs_ has quit IRC |
| 07:50:10 | *** sreya has quit IRC |
| 07:53:39 | *** EClaesson has joined #openmrs |
| 07:57:56 | *** Hazamonzo has joined #openmrs |
| 08:03:08 | *** rafa has quit IRC |
| 08:06:22 | *** rafa has joined #openmrs |
| 08:06:22 | *** ChanServ sets mode: +v rafa |
| 08:08:45 | *** EClaesson has left #openmrs |
| 08:20:24 | *** Mkop has joined #openmrs |
| 08:20:24 | *** ChanServ sets mode: +v Mkop |
| 08:23:31 | *** tinasherioga has left #openmrs |
| 08:23:53 | *** bwolfe has quit IRC |
| 08:36:33 | *** bwolfe has joined #openmrs |
| 08:36:33 | *** ChanServ sets mode: +o bwolfe |
| 08:41:51 | *** bwolfe has quit IRC |
| 08:41:59 | *** bwolfe has joined #openmrs |
| 08:41:59 | *** ChanServ sets mode: +o bwolfe |
| 08:57:05 | *** batkinson has quit IRC |
| 08:57:52 | *** rafa has quit IRC |
| 09:02:41 | *** bwolfe has quit IRC |
| 09:06:30 | *** dkayiwa has quit IRC |
| 09:06:35 | *** dkayiwa has joined #openmrs |
| 09:07:36 | <jriley> |
| 09:07:39 | *** batkinson has joined #openmrs |
| 09:21:44 | *** bwolfe has joined #openmrs |
| 09:21:44 | *** ChanServ sets mode: +o bwolfe |
| 09:33:59 | <jriley> modules.openmrs.org has been giving 500 errors for the last 15-20 minutes. |
| 09:34:49 | *** rafa has joined #openmrs |
| 09:34:49 | *** ChanServ sets mode: +v rafa |
| 09:42:32 | *** batkinson has quit IRC |
| 09:57:43 | *** batkinson has joined #openmrs |
| 10:06:42 | *** jriley has left #openmrs |
| 10:29:47 | *** dmexs has joined #openmrs |
| 10:30:08 | *** bwolfe has quit IRC |
| 10:33:13 | *** batkinson has quit IRC |
| 10:35:22 | *** batkinson has joined #openmrs |
| 10:47:18 | *** bwolfe has joined #openmrs |
| 10:47:18 | *** ChanServ sets mode: +o bwolfe |
| 10:53:53 | *** james_regen has joined #openmrs |
| 10:53:53 | *** ChanServ sets mode: +v james_regen |
| 11:13:57 | <pascal`> bwolfe, around? |
| 11:15:04 | <bwolfe> yep |
| 11:15:51 | <pascal`> bwolfe, a question about collation |
| 11:16:18 | <pascal`> bwolfe, from the liquibase schema creation xml, openmrs doesn't seem to explicitly set collation for tables |
| 11:16:33 | <pascal`> bwolfe, so, this means that tables are created with whatever the default is, right? |
| 11:17:48 | <pascal`> bwolfe, brb (sorry) |
| 11:22:11 | <bwolfe> yes |
| 11:33:30 | <pascal`> bwolfe, right |
| 11:34:26 | <pascal`> bwolfe, I thought so, but I'm getting a create table error (150) on a table which references the 'role' coloumn in the 'role' table |
| 11:34:39 | <bwolfe> are both tables innodb? |
| 11:36:22 | <pascal`> well, the table I'm creating is |
| 11:37:01 | <bwolfe> and have you verified role is? |
| 11:37:23 | <pascal`> yeah it is, just checked |
| 11:38:00 | <pascal`> I had this exact same problem when i was explicitly setting the collation when creating the table, but now I'm not and it's happening again |
| 11:38:50 | <bwolfe> not sure |
| 11:38:59 | <pascal`> hehe, wait |
| 11:40:05 | <pascal`> no... arg. |
| 11:40:26 | <pascal`> my collation variables are all 'latin1_swedish_ci' |
| 11:40:36 | <bwolfe> odd |
| 11:40:49 | <pascal`> what are yours? |
| 11:42:20 | <pascal`> SHOW VARIABLES LIKE '%collation%'; |
| 11:45:49 | <bwolfe> +----------------------+-------------------+ |
| 11:45:50 | <bwolfe> |
| 11:45:50 | <bwolfe> +----------------------+-------------------+ |
| 11:45:50 | <bwolfe> |
| 11:45:50 | <bwolfe> |
| 11:45:50 | <bwolfe> |
| 11:45:52 | <bwolfe> +----------------------+-------------------+ |
| 11:45:55 | <bwolfe> pascal` ^^ |
| 11:46:36 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Concept.getAnswers should include retired answers by default - TRUNK-285... <http://feedproxy.google.com/~r/OMRStrunk/~3/OOA-24qKHaU/OpenMRS> |
| 11:49:47 | <pascal`> ah, so the same |
| 11:50:08 | <pascal`> bwolfe, I'll try explicitly set the collation to the same as the role table and see if it creates then |
| 11:50:31 | <pascal`> but if it does, that means that either my table or role table isn't created using the default for some reason |
| 11:54:54 | *** danielf` has joined #openmrs |
| 11:54:54 | *** ChanServ sets mode: +v danielf` |
| 12:12:02 | *** jportela has joined #openmrs |
| 12:18:06 | *** saimanohar has joined #openmrs |
| 12:18:23 | <saimanohar> hi all! |
| 12:18:54 | <saimanohar> i have put a proposal for improved person attribute types project of openmrs in gsoc 2011 |
| 12:19:42 | <saimanohar> i mail nyoman ribeka asking what more should i include in my proposal. |
| 12:19:51 | <saimanohar> but i still didnt get any reply |
| 12:20:22 | <saimanohar> can any of the people here help about this.is he not available |
| 12:25:05 | <bwolfe> saimanohar: did you submit it to the gsoc app already? |
| 12:26:01 | <saimanohar> yes i have submitted the proposal on gsoc melange website |
| 12:31:05 | <bwolfe> ok, that should be enough |
| 12:31:29 | <saimanohar> okk...thanks ben |
| 12:34:49 | *** Mkop has quit IRC |
| 12:41:26 | *** dkayiwa has quit IRC |
| 12:57:59 | *** aja has joined #openmrs |
| 12:59:36 | *** aja has joined #openmrs |
| 13:02:00 | <pascal`> bwolfe, if I explicitly set the collation then everything works |
| 13:02:32 | <pascal`> bwolfe, do think this means that the liquibase could be setting the collation to something other than the default when creating the schema? |
| 13:04:29 | <pascal`> arg. That's what happens when you try and write full sentences with too little coffee in your system. |
| 13:04:32 | <pascal`> coffee++ |
| 13:04:42 | *** batkinson has quit IRC |
| 13:09:27 | <pascal`> bwolfe, it definitely looks that way because a bunch of the other module's tables are all created with the default collation. |
| 13:55:53 | *** dkayiwa has joined #openmrs |
| 13:56:29 | *** chopin has joined #openmrs |
| 13:56:29 | *** ChanServ sets mode: +v chopin |
| 13:56:49 | *** saimanohar has quit IRC |
| 13:57:52 | <chopin> o/ |
| 13:57:57 | <chopin> coffee++ |
| 13:59:36 | *** shomon has joined #openmrs |
| 14:02:29 | <pascal`> chopin++ |
| 14:06:03 | *** upul` has joined #openmrs |
| 14:06:03 | *** ChanServ sets mode: +v upul` |
| 14:17:16 | *** jportela has quit IRC |
| 14:22:30 | *** bryq has joined #openmrs |
| 14:24:53 | *** suho has joined #openmrs |
| 14:29:11 | *** robbyoconnor has quit IRC |
| 14:29:50 | <chopin> pascal`++ |
| 14:29:51 | <chopin> :-D |
| 14:30:51 | <pascal`> =D |
| 14:32:57 | *** danielf` has quit IRC |
| 14:43:58 | *** pascal` has quit IRC |
| 14:52:10 | *** cta has joined #openmrs |
| 14:53:58 | *** downeym has joined #openmrs |
| 14:53:58 | *** ChanServ sets mode: +o downeym |
| 14:53:58 | *** OpenMRSBot sets mode: +o downeym |
| 14:56:48 | <shomon> hiya, I just discovered openmrs |
| 14:57:00 | <shomon> would it be a good tool to use for a small private clinic, or overkill? |
| 15:01:51 | *** dmexs has quit IRC |
| 15:02:40 | <downeym> shomon: It's often used in small clinics with a single laptop or PC. |
| 15:03:29 | <downeym> shomon: That said, it does require time to configure and knowledge by one or more people in programming and medical expertise. |
| 15:10:07 | <shomon> I could do that... but I think the requirements are: no money for a server, so it's got to live on the cloud... and lots of off site visits, so it's got to work on phones... |
| 15:10:34 | <shomon> but looks good... I'm also looking at openclinica, this time for much bigger projects |
| 15:10:45 | <shomon> and this one looks like one to watch |
| 15:11:14 | <downeym> Have you looked at http://www.opendatakit.org/ ? It's another open source project for Android that does remote data collection for OpenMRS. |
| 15:11:25 | <shomon> aaah, that'd be nice |
| 15:11:28 | <shomon> thanks! |
| 15:13:33 | *** jkeiper has joined #openmrs |
| 15:13:33 | *** ChanServ sets mode: +v jkeiper |
| 15:13:39 | <downeym> Hi jkeiper and welcome to the #openmrs IRC channel. |
| 15:13:43 | *** jkeiper has quit IRC |
| 15:14:26 | *** shomon has quit IRC |
| 15:27:24 | *** cta has quit IRC |
| 15:28:33 | *** lh has joined #openmrs |
| 15:45:00 | *** bwolfe has quit IRC |
| 15:48:53 | *** rafa has quit IRC |
| 15:54:54 | *** rafa has joined #openmrs |
| 15:54:54 | *** ChanServ sets mode: +v rafa |
| 15:55:15 | *** suho has quit IRC |
| 15:56:42 | *** dkayiwa has quit IRC |
| 15:58:55 | *** mjohnst has joined #openmrs |
| 16:03:11 | *** zubair has joined #openmrs |
| 16:03:18 | <zubair> hello |
| 16:05:19 | <downeym> hi. :) |
| 16:07:07 | <zubair> how r u ?? |
| 16:15:06 | *** dkayiwa has joined #openmrs |
| 16:15:25 | <downeym> fine. :) |
| 16:20:19 | *** gauravpaliwal has joined #openmrs |
| 16:22:03 | *** batkinson has joined #openmrs |
| 16:30:34 | *** gauravpaliwal has quit IRC |
| 16:37:20 | *** harsha has joined #openmrs |
| 16:39:55 | *** jportela has joined #openmrs |
| 16:58:55 | *** batkinson has quit IRC |
| 16:59:22 | *** batkinson has joined #openmrs |
| 16:59:48 | *** harsha has quit IRC |
| 17:03:29 | *** cta has joined #openmrs |
| 17:06:21 | *** batkinson_ has joined #openmrs |
| 17:06:21 | *** dkayiwa has quit IRC |
| 17:06:29 | <downeym> Hi batkinson_ and welcome to the #openmrs IRC channel. |
| 17:07:14 | *** dkayiwa has joined #openmrs |
| 17:08:53 | *** batkinson has quit IRC |
| 17:18:39 | *** upul`` has joined #openmrs |
| 17:18:39 | *** ChanServ sets mode: +v upul`` |
| 17:18:47 | <downeym> Hi upul`` and welcome to the #openmrs IRC channel. |
| 17:19:00 | <chopin> upul``++ |
| 17:19:30 | <upul``> hi chopin |
| 17:20:16 | *** upul` has quit IRC |
| 17:21:10 | <chopin> hey upul`` |
| 17:21:41 | *** jportela has left #openmrs |
| 17:24:05 | *** rafa has quit IRC |
| 17:37:41 | *** downeym has quit IRC |
| 17:37:41 | *** cta has quit IRC |
| 17:43:48 | *** aja has quit IRC |
| 17:54:46 | *** upul`` has quit IRC |
| 17:56:02 | *** mjohnst has quit IRC |
| 17:59:48 | *** rafa has joined #openmrs |
| 17:59:48 | *** ChanServ sets mode: +v rafa |
| 18:01:05 | *** bwolfe has joined #openmrs |
| 18:01:05 | *** ChanServ sets mode: +o bwolfe |
| 18:08:55 | *** bwolfe has quit IRC |
| 18:14:48 | *** robbyoconnor has joined #openmrs |
| 18:14:48 | *** ChanServ sets mode: +v robbyoconnor |
| 18:17:16 | *** bwolfe has joined #openmrs |
| 18:17:16 | *** ChanServ sets mode: +o bwolfe |
| 18:24:11 | *** bwolfe has quit IRC |
| 18:25:48 | *** bwolfe has joined #openmrs |
| 18:25:48 | *** ChanServ sets mode: +o bwolfe |
| 18:29:04 | *** zubair has quit IRC |
| 18:43:09 | *** mjohnst has joined #openmrs |
| 18:43:09 | <djazayeri> I've got a spring question. |
| 18:44:03 | <djazayeri> I'm trying to use the Spring 3.0 ConversionService and type converters mechanism, and I need one type converter to be able to delegate to another one. |
| 18:44:43 | <djazayeri> I.e. I'd like to be able to have: PatientToSimpleObjectConverter implements Converter... { @Autowired ConversionService ... |
| 18:45:53 | <djazayeri> The problem is that this introduces a circular dependency between the ConversionService bean (which needs to contain this converter bean in its converters list) and this bean (which needs to refer to the conversion service) |
| 18:45:57 | <djazayeri> and it bombs on startup |
| 18:46:21 | <djazayeri> I'm having trouble figuring out how to resolve this from the spring docs. |
| 18:46:21 | <djazayeri> Any suggestions? |
| 18:46:29 | <djazayeri> bwolfe: pinging you so you can comment if you know the answer |
| 18:47:25 | <djazayeri> (Ideally without doing post-processing.) |
| 18:47:59 | <bwolfe> djazayeri: there are params to the @autowired, aren't there? can't you do some sort of ignore or propogation ignore thing? |
| 18:48:25 | <djazayeri> the @autowired annotation only has a "required" param |
| 18:50:56 | <bwolfe> I've got nothin' for you |
| 18:51:04 | <djazayeri> oh well, thanks |
| 18:51:24 | <djazayeri> (I'd been unable to think of the term "circular dependency" in my previous round of googling, so maybe now I'll find an answer) |
| 18:56:33 | *** robbyoconnor has quit IRC |
| 18:56:43 | *** robbyoconnor has joined #openmrs |
| 18:56:43 | *** ChanServ sets mode: +v robbyoconnor |
| 18:58:37 | *** dkayiwa has quit IRC |
| 19:13:00 | <rafa> djazayeri: Are you sure it's the real problem? I think that Spring handles circular dependencies. |
| 19:13:33 | <djazayeri> rafa: the docs seem to say it doesn't. |
| 19:14:08 | <djazayeri> and yes, I tried just commenting out the @autowired annotation, and things load fine. (But I get an NPE later of course.) |
| 19:14:32 | <rafa> Ohh then I'm wrong :) |
| 19:14:33 | <djazayeri> what's odd is that I cannot seem to find any hits on google for people who want their converters to collaborate. |
| 19:14:50 | <djazayeri> at least not using autowired. |
| 19:16:00 | <rafa> djazayeri: I've just hit this page http://stackoverflow.com/questions/3485347/circular-dependency-in-spring |
| 19:16:05 | <OpenMRSBot> <http://ln-s.net/8izO> (at stackoverflow.com) |
| 19:18:28 | <djazayeri> I'm trying to do something like <parent><property name="converters"><list>...<child> |
| 19:18:50 | <djazayeri> maybe I can try pulling the child definition out and see if that works. |
| 19:18:52 | <rafa> The hint there and in docs is to use the setter injection instead of the constructor injection. |
| 19:19:04 | <djazayeri> as-is I get a "bean currently in creation exception" which makes sense |
| 19:20:24 | <rafa> so try using @Autowired on the setter method instead of the field |
| 19:21:17 | <djazayeri> hmm, are setters called later on in the lifecycle? |
| 19:21:19 | <djazayeri> that'd help |
| 19:21:34 | <rafa> yes, they can be called only after beans are created |
| 19:21:43 | <djazayeri> good point |
| 19:25:12 | *** bwolfe has quit IRC |
| 19:25:22 | <djazayeri> hmm, didn't work |
| 19:26:06 | <rafa> Have you set it in both classes? |
| 19:28:39 | *** batkinson_ has quit IRC |
| 19:29:56 | <djazayeri> I don't control the parent class |
| 19:31:08 | <djazayeri> Maybe I need to read up a bit more about ConversionServiceFactoryBean and whether it has options for handling this |
| 19:32:15 | <rafa> Ohh right it's a spring class... |
| 19:35:04 | <djazayeri> One solution I know would work, but I've been trying to avoid, might actually be a good idea |
| 19:35:25 | <rafa> Can you show me your class? |
| 19:36:49 | <djazayeri> the UiUtils class should have a method that converts a complex object to something suitable to be turned into json. |
| 19:37:03 | <djazayeri> e.g. UiUtils.convertToSimpleObject(Object complex) |
| 19:37:28 | <djazayeri> This would delegate to calling conversion service |
| 19:38:15 | <djazayeri> but basically instead of having every converter that needs to delegate have to do something funky in spring, I can have the converters autowire a UiUtils instead of a ConversionService. |
| 19:38:26 | <djazayeri> And put a post-processor on just the one UiUtils bean. |
| 19:39:45 | <rafa> It seems like a good way out. |
| 19:40:37 | <djazayeri> http://pastebin.com/XcTksTSe |
| 19:40:42 | <djazayeri> that is the class as of now |
| 19:41:12 | <djazayeri> I think it's actually a good idea to have this method in UiUtils anyway. Instead of requiring people to call convert(object, SimpleObject.class) |
| 19:41:25 | <djazayeri> perhaps I'll call it: UiUtils.simplifyForJson(Object) |
| 19:53:12 | *** jportela has joined #openmrs |
| 19:53:13 | *** r0bby has joined #openmrs |
| 19:53:13 | *** ChanServ sets mode: +v r0bby |
| 19:53:29 | <rafa> djazayeri: I think I've found a solution |
| 19:53:42 | <rafa> just let me test it |
| 19:55:18 | *** dkayiwa has joined #openmrs |
| 19:55:25 | <djazayeri> okay |
| 19:55:46 | <djazayeri> I'll go grab lunch |
| 19:56:08 | *** robbyoconnor has quit IRC |
| 20:05:15 | <rafa> djazayeri: http://pastebin.com/HkCrKZ8Z |
| 20:06:03 | <rafa> the problem is that conversion service builds all converters in its constructor and we must wait for the moment it's done |
| 20:07:10 | <rafa> so we just autowire the application context to get the conversion service by lazy initalization |
| 20:07:29 | <djazayeri> rafa: makes sense, and this would work, but I think it is actually uglier than my alternative |
| 20:07:55 | <djazayeri> I'd rather not introduce a spring dependency in multiple converters |
| 20:08:07 | <djazayeri> (obviously they're _spring_ converters, but still...) |
| 20:08:50 | <rafa> you're right if there's no real gain |
| 20:08:57 | <djazayeri> I'd rather autowire the UiUtils interface, and put a hack in the BasicUiUtils to get the ConversionService in a bean post processor |
| 20:09:21 | <rafa> It was a nice problem anyway ;) |
| 20:09:37 | *** r0bby_ has joined #openmrs |
| 20:09:37 | *** ChanServ sets mode: +v r0bby_ |
| 20:09:50 | <djazayeri> glad you enjoyed it |
| 20:10:39 | *** r0bby has quit IRC |
| 20:12:47 | *** r0bby_ is now known as robbyoconnor |
| 20:18:15 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @jwesonga @gmeltdown What'd we miss? <http://twitter.com/OpenMRS/statuses/57893495150616576> || On Twitter: OpenMRS: @NateOsit Not only is our software open, our community is too! http://t.co/6VEdak1 /cc @pomawhit <http://twitter.com/OpenMRS/statuses/57893201054400512> || New Changeset: OpenMRS (1.7.x): backporting TRUNK-2225 to branches/1.7.x - adding DWR engine and DWRAlertService to headerMinimal <http://feedproxy.google.com/~r/OMRStrunk/~3/ycQ3cWCzcoY/OpenMRS> || New Changeset: OpenMRS (1.8.x): backporting TRUNK-2225 to branches/1.8.x - adding DWR engine and DWRAlertService to headerMinimal <http://feedproxy.google.com/~r/OMRStrunk/~3/etAVTGoJ93k/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2225 - adding DWR engine and DWRAlertService to headerMinimal <http://feedproxy.google.com/~r/OMRStrunk/~3/Bjn3gZNrOAs/OpenMRS> |
| 20:38:25 | *** james_regen has quit IRC |
| 20:50:16 | *** robbyoconnor has quit IRC |
| 20:56:34 | *** mjohnst has left #openmrs |
| 21:01:39 | *** bryq has quit IRC |
| 21:05:02 | *** dkayiwa has quit IRC |
| 21:05:24 | *** dkayiwa has joined #openmrs |
| 21:08:12 | *** Hazamonzo has quit IRC |
| 21:11:14 | *** Hazamonzo has joined #openmrs |
| 21:13:25 | <djazayeri> hey dkayiwa |
| 21:13:53 | <djazayeri> Has the issue been solved in XForms where if you create a new location or provider you need to rebuild the form to get them reflected? |
| 21:14:31 | <dkayiwa> hey djazayeri: Not yet |
| 21:14:37 | <djazayeri> okay |
| 21:37:39 | *** rafa has quit IRC |
| 22:16:39 | *** downeym has joined #openmrs |
| 22:16:39 | *** ChanServ sets mode: +o downeym |
| 22:16:39 | *** OpenMRSBot sets mode: +o downeym |
| 22:16:54 | <downeym> lh: Know anything about http://www.communityleadershipsummit.com/ ? |
| 22:43:59 | *** lh has quit IRC |
| 22:49:16 | *** gbastien has joined #openmrs |
| 22:58:18 | *** Hazamonzo has quit IRC |
| 23:01:53 | *** Hazamonzo has joined #openmrs |
| 23:52:16 | *** dkayiwa has quit IRC |