| 00:04:02 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Fixing the name of the purge patient programs privilege in trunk. See TRUNK-296. <http://feedproxy.google.com/~r/OMRStrunk/~3/4wfiUBBndX4/OpenMRS> || New Changeset: OpenMRS (1.8.x): Fixing the name of the purge patient programs privilege in 1.8.x branch. See TRUNK-296. <http://feedproxy.google.com/~r/OMRStrunk/~3/v3AbFEFUfFo/OpenMRS> || New Changeset: OpenMRS (1.7.x): Fixing the name of the purge patient programs privilege in 1.7.x branch. See TRUNK-296. <http://feedproxy.google.com/~r/OMRStrunk/~3/QVel3xH3bMI/OpenMRS> |
| 01:07:47 | *** deadpool has joined #openmrs-sprint |
| 01:09:45 | *** deadpool has left #openmrs-sprint |
| 01:27:15 | *** chopin has joined #openmrs-sprint |
| 01:27:15 | *** ChanServ sets mode: +v chopin |
| 01:39:58 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Fixes to the Concept Dictionary search and view pages, which add appropriate privilege checks in such that an anonymous ... <http://feedproxy.google.com/~r/OMRStrunk/~3/EFKotZ4fFCw/OpenMRS> |
| 02:16:38 | *** chopin has quit IRC |
| 04:16:53 | *** bwolfe has quit IRC |
| 05:55:22 | *** surangak has joined #openmrs-sprint |
| 05:55:39 | <surangak> howdy |
| 06:25:19 | *** dkayiwa has joined #openmrs-sprint |
| 06:42:17 | *** bwolfe has joined #openmrs-sprint |
| 06:42:17 | *** ChanServ sets mode: +o bwolfe |
| 06:46:26 | *** bwolfe has quit IRC |
| 06:46:47 | *** bwolfe has joined #openmrs-sprint |
| 06:46:47 | *** ChanServ sets mode: +o bwolfe |
| 06:50:46 | *** surangak has quit IRC |
| 06:53:38 | <dkayiwa> morning bwolfe: |
| 06:54:02 | <bwolfe> hi daniel |
| 06:54:31 | <dkayiwa> I got into troble while using ServiceContext:setModuleService |
| 06:55:15 | <dkayiwa> after investigating, i found out that it is called by spring when creating beans |
| 06:55:56 | <dkayiwa> no wonder the logic service just froze |
| 06:56:13 | <dkayiwa> so i have two options which i have tried and they seem to work |
| 06:56:30 | <dkayiwa> but just wanted to confirm with you and also chose which is more appropriate |
| 06:57:24 | <dkayiwa> First option was to wait on refreshingContext before running the onStartup method |
| 06:57:32 | <dkayiwa> refreshingContext.wait(); |
| 06:59:48 | <bwolfe> whats the second? |
| 06:59:51 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Adding 'hide' column to concept map types and updating the UI with the changes <http://feedproxy.google.com/~r/OMRStrunk/~3/A-K8Y6wvkYA/OpenMRS> |
| 06:59:56 | <dkayiwa> the other option is to do it all during Context.startup() |
| 07:02:48 | <dkayiwa> so during Context.startup(), i add another call like ServiceContext.startup() |
| 07:03:59 | <dkayiwa> Then in there, i loop through instance.services |
| 07:04:13 | <dkayiwa> checking for which implements the OpenmrsService interface |
| 07:04:26 | <dkayiwa> which of the two do you think is better? |
| 07:04:35 | <dkayiwa> or do you have other alternatives? |
| 07:05:58 | <dkayiwa> what i had love about the first approach is that i do not have to loop through the list of services |
| 07:06:19 | <dkayiwa> but i realized that i may need to do so for OpenmrsService.onShutdown() |
| 07:07:31 | <dkayiwa> any way, that is what am already doing for shutdown, so just wanted to be sure if there are no better alternatives |
| 07:08:44 | <bwolfe> dkayiwa: context.startup is only at the very first openmrs startup. no modules will be loaded at that point |
| 07:08:49 | <bwolfe> so you should do the first option |
| 07:09:03 | <dkayiwa> oh i see |
| 07:09:13 | <bwolfe> onshutdown should work very similar to onstartup and be called just before the context is refreshing (when a module is being removed) |
| 07:11:05 | <dkayiwa> in otherwards, i should not put onShutdown() in Context.shutdown, right? |
| 07:12:21 | <bwolfe> right |
| 07:12:25 | <dkayiwa> ok |
| 07:12:28 | <bwolfe> thats only when openmrs is shut down |
| 07:12:28 | *** surangak has joined #openmrs-sprint |
| 07:12:32 | <dkayiwa> ok |
| 07:13:02 | <dkayiwa> one other thing, i also notice that onStartup and onShutdown are not called for the core openmrs services |
| 07:13:11 | <dkayiwa> am i correct? |
| 07:14:52 | <bwolfe> yeah, you're correct |
| 07:15:00 | <bwolfe> those should be called from context.startup and context.shutdown |
| 07:15:03 | <bwolfe> :-) |
| 07:15:10 | <bwolfe> there might be a separate ticket for that already |
| 07:15:16 | <dkayiwa> ok |
| 07:15:20 | <dkayiwa> :) |
| 07:44:50 | <dkayiwa> bwolfe: basing on your advice, am thinking of calling the onShutdown() in ModuleFactory.stopModule |
| 07:45:19 | <bwolfe> sounds right |
| 07:45:22 | <dkayiwa> Now the question is. How do i get the services for the module that is being stopped |
| 07:45:49 | <dkayiwa> Should i add a method to the ServiceContext which takes the module package and loops through the registered services? |
| 07:47:21 | <dkayiwa> Or do we already have an API that can give me that? Not seen it so far |
| 07:51:02 | <bwolfe> dkayiwa: you need to ping me by saying my name or nickname after you ask a question. I only flip back here every 5 minutes otherwise. :-) |
| 07:51:15 | <dkayiwa> lollllllll |
| 07:51:22 | <dkayiwa> will do that bwolfe: |
| 07:51:25 | <bwolfe> I don't know of a method that will give you the registered services from a module |
| 07:51:41 | <bwolfe> if you can save that info when the services are being registered, then just use that |
| 07:52:10 | <dkayiwa> bwolfe: is it ok to save it in the ServiceContext? |
| 07:52:39 | <bwolfe> yeah, that'd be fine because thats where the module services are first being added |
| 07:52:54 | <dkayiwa> ok thanks |
| 08:04:10 | <dkayiwa> bwolfe: should i make the onShutdown() method block instead of running it in a separate thread? |
| 08:04:57 | <bwolfe> yes, definitely |
| 08:05:03 | <bwolfe> yes == block |
| 08:05:03 | <dkayiwa> ok |
| 08:05:11 | <dkayiwa> :D |
| 08:23:53 | *** bwolfe has quit IRC |
| 08:44:56 | *** bwolfe has joined #openmrs-sprint |
| 08:44:56 | *** ChanServ sets mode: +o bwolfe |
| 09:00:18 | <bwolfe> lunchtime, bbl |
| 09:01:55 | <surangak> ah, looks like im 2 hrs ahead of you guys now |
| 09:02:41 | *** bwolfe has quit IRC |
| 09:06:30 | *** dkayiwa has quit IRC |
| 09:06:35 | *** dkayiwa has joined #openmrs-sprint |
| 09:21:44 | *** bwolfe has joined #openmrs-sprint |
| 09:21:44 | *** ChanServ sets mode: +o bwolfe |
| 09:52:38 | *** surangak has quit IRC |
| 10:30:08 | *** bwolfe has quit IRC |
| 10:47:18 | *** bwolfe has joined #openmrs-sprint |
| 10:47:18 | *** ChanServ sets mode: +o bwolfe |
| 10:58:44 | *** surangak has joined #openmrs-sprint |
| 10:58:52 | <surangak> hello |
| 10:59:02 | <surangak> anyone around |
| 10:59:08 | <dkayiwa> i am |
| 11:00:40 | <bwolfe> hi surangak |
| 11:00:45 | <bwolfe> how goes your work so far? |
| 11:00:55 | <surangak> oh, hello guys, ive just finished my first bug for the sprint... |
| 11:01:07 | <bwolfe> awesome |
| 11:01:11 | <surangak> ill be comitting it in a while.. still at office |
| 11:01:11 | <bwolfe> is it in code review state? |
| 11:03:22 | <surangak> sorry ... not yet |
| 11:03:29 | <surangak> still at office :p |
| 11:03:59 | <surangak> i will be around in a couple of hours again |
| 11:06:04 | <bwolfe> ok, np |
| 11:18:23 | *** surangak has quit IRC |
| 11:46:37 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Concept.getAnswers should include retired answers by default - TRUNK-285... <http://feedproxy.google.com/~r/OMRStrunk/~3/OOA-24qKHaU/OpenMRS> |
| 11:56:14 | <dkayiwa> bwolf: created a review for my ticket. should i just go ahead and pick another ticket, in the meantime? |
| 11:56:26 | <dkayiwa> bwolfe: created a review for my ticket. should i just go ahead and pick another ticket, in the meantime? |
| 11:56:37 | <bwolfe> yep |
| 11:56:40 | <dkayiwa> ok |
| 12:41:26 | *** dkayiwa has quit IRC |
| 13:00:18 | *** aja_ has joined #openmrs-sprint |
| 13:55:53 | *** dkayiwa has joined #openmrs-sprint |
| 13:56:28 | *** chopin has joined #openmrs-sprint |
| 13:56:28 | *** ChanServ sets mode: +v chopin |
| 13:57:48 | <chopin> hi |
| 14:44:31 | <bwolfe> hi chopin |
| 14:53:58 | *** downeym has joined #openmrs-sprint |
| 14:53:58 | *** ChanServ sets mode: +o downeym |
| 14:53:59 | *** OpenMRSBot sets mode: +o downeym |
| 15:45:00 | *** bwolfe has quit IRC |
| 15:56:42 | *** dkayiwa has quit IRC |
| 16:15:06 | *** dkayiwa has joined #openmrs-sprint |
| 17:06:21 | *** dkayiwa has quit IRC |
| 17:07:14 | *** dkayiwa has joined #openmrs-sprint |
| 17:37:41 | *** downeym has quit IRC |
| 17:43:04 | *** aja_ has quit IRC |
| 18:01:05 | *** bwolfe has joined #openmrs-sprint |
| 18:01:05 | *** ChanServ sets mode: +o bwolfe |
| 18:08:55 | *** bwolfe has quit IRC |
| 18:27:48 | *** bwolfe has joined #openmrs-sprint |
| 18:27:48 | *** ChanServ sets mode: +o bwolfe |
| 18:27:55 | *** surangak has joined #openmrs-sprint |
| 18:33:16 | *** aja has joined #openmrs-sprint |
| 18:34:34 | <aja> Hi, i attached the patch for TRUNK-203,please review it. |
| 18:40:29 | <djazayeri> !ticket TRUNK-203 |
| 18:40:29 | <OpenMRSBot> djazayeri: Allow me to help you with that. More details on ticket TRUNK-203 can be found at http://tickets.openmrs.org/browse/TRUNK-203 |
| 18:42:38 | <bwolfe> done |
| 18:45:24 | *** surangak has quit IRC |
| 18:58:37 | *** dkayiwa has quit IRC |
| 19:25:12 | *** bwolfe has quit IRC |
| 19:25:47 | *** surangak has joined #openmrs-sprint |
| 19:35:11 | <surangak> hi ppl |
| 19:35:22 | <surangak> can anyone help me understand TRUNK-227 |
| 19:35:43 | <surangak> im not understanding what a concept_word is |
| 19:41:28 | *** aja has quit IRC |
| 19:48:22 | *** surangak has quit IRC |
| 19:55:18 | *** dkayiwa has joined #openmrs-sprint |
| 20:18:16 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @jwesonga @gmeltdown What'd we miss? <http://twitter.com/OpenMRS/statuses/57893495150616576> || On Twitter: OpenMRS: @NateOsit Not only is our software open, our community is too! http://t.co/6VEdak1 /cc @pomawhit <http://twitter.com/OpenMRS/statuses/57893201054400512> || New Changeset: OpenMRS (1.7.x): backporting TRUNK-2225 to branches/1.7.x - adding DWR engine and DWRAlertService to headerMinimal <http://feedproxy.google.com/~r/OMRStrunk/~3/ycQ3cWCzcoY/OpenMRS> || New Changeset: OpenMRS (1.8.x): backporting TRUNK-2225 to branches/1.8.x - adding DWR engine and DWRAlertService to headerMinimal <http://feedproxy.google.com/~r/OMRStrunk/~3/etAVTGoJ93k/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2225 - adding DWR engine and DWRAlertService to headerMinimal <http://feedproxy.google.com/~r/OMRStrunk/~3/Bjn3gZNrOAs/OpenMRS> |
| 21:05:02 | *** dkayiwa has quit IRC |
| 21:05:24 | *** dkayiwa has joined #openmrs-sprint |
| 22:16:39 | *** downeym has joined #openmrs-sprint |
| 22:16:39 | *** ChanServ sets mode: +o downeym |
| 22:16:40 | *** OpenMRSBot sets mode: +o downeym |
| 23:52:16 | *** dkayiwa has quit IRC |