| 03:20:23 | *** djazayeri has joined #openmrs-sprint |
| 03:20:23 | *** ChanServ sets mode: +o djazayeri |
| 04:37:58 | *** bwolfe has quit IRC |
| 06:11:19 | *** dkayiwa has joined #openmrs-sprint |
| 06:34:59 | *** bwolfe has joined #openmrs-sprint |
| 06:34:59 | *** ChanServ sets mode: +o bwolfe |
| 06:36:57 | <dkayiwa> bwolfe: Hi Ben, should i just pick any unassigned ticket from the list for this week's sprint? |
| 06:37:12 | <bwolfe> yep, go for it |
| 06:37:18 | <dkayiwa> sure thanks |
| 06:37:30 | <bwolfe> one that is "ready for work" though. there are a few I need to go through still |
| 06:37:39 | <dkayiwa> ok |
| 07:13:18 | <dkayiwa> bwolfe: TRUNK-232 is OpenmrsService.onStartup() to be called when the module is being started? |
| 07:14:27 | <dkayiwa> and is onShutdown for when the module is being stopped? |
| 07:14:35 | <bwolfe> !ticket TRUNK-232 |
| 07:14:35 | <OpenMRSBot> bwolfe: Allow me to help you with that. More details on ticket TRUNK-232 can be found at http://tickets.openmrs.org/browse/TRUNK-232 |
| 07:21:54 | <bwolfe> dkayiwa: sorry, got distracted by someone here. |
| 07:22:04 | <dkayiwa> no problem |
| 07:22:07 | <dkayiwa> :) |
| 07:22:32 | <bwolfe> yes, onShutdown is for both stopped and unloading of modules. but you can just deal with stopping, because I think when you unload a module it is first stopped |
| 07:22:59 | <bwolfe> and the module's service onStartup is for every time the module is started |
| 07:23:14 | <dkayiwa> ok |
| 08:50:03 | <bwolfe> I'm off to lunch dkayiwa (still on american-timed lunches). I'll be back soon to answer any questions you have. |
| 08:50:13 | <dkayiwa> lolllllll |
| 08:50:18 | <dkayiwa> no problem. thanks |
| 08:50:18 | <bwolfe> if anyone comes in asking about how to join, just tell them to pick a ticket and start |
| 08:50:24 | <dkayiwa> ok |
| 08:50:30 | <bwolfe> bbl |
| 08:50:38 | <dkayiwa> cool |
| 08:55:23 | *** bwolfe has quit IRC |
| 08:55:33 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Fixed module engine executing sqldiff based on the String ordering - TRUNK-1668... <http://feedproxy.google.com/~r/OMRStrunk/~3/NENpJXbS8SM/OpenMRS> || New Changeset: OpenMRS (trunk): User management page fails on searching with role and include disabled users - TRUNK-2108... <http://feedproxy.google.com/~r/OMRStrunk/~3/eVGcDioSkh0/OpenMRS> |
| 09:07:01 | *** dkayiwa_ has joined #openmrs-sprint |
| 09:07:01 | *** dkayiwa has quit IRC |
| 09:07:02 | *** dkayiwa_ is now known as dkayiwa |
| 11:07:09 | <dkayiwa> bwolfe: back from lunch? |
| 11:12:19 | *** bwolfe has joined #openmrs-sprint |
| 11:12:19 | *** ChanServ sets mode: +o bwolfe |
| 11:22:59 | <dkayiwa> bwolfe: back from lunch? |
| 11:27:53 | <bwolfe> I am |
| 11:28:00 | <bwolfe> dkayiwa: whats up? |
| 11:28:23 | <bwolfe> had to go and deliver 3 of the 12 phones I came with to some ampath guys. :-) |
| 11:29:04 | <dkayiwa> lollll |
| 11:29:11 | <dkayiwa> are all of them taken? |
| 11:29:39 | <bwolfe> all but one. maybe two. I haven't heard back from one guy that wanted one on craigslist |
| 11:29:47 | <dkayiwa> ok |
| 11:30:56 | <dkayiwa> just wanted to confirm whether am on track . looked for something existing that i could use, and was thinking of Context.getRegisteredComponents(OpenmrsService.class) |
| 11:31:26 | <dkayiwa> https://tickets.openmrs.org/browse/TRUNK-232 |
| 11:32:10 | <bwolfe> hmm, I don't know that the services are registered like that, are they? |
| 11:32:31 | <dkayiwa> not very sure |
| 11:32:49 | <bwolfe> hmm, I hadn't thought about 'how to know which module service to use". :-/ |
| 11:33:09 | <bwolfe> perhaps you just keep track of them when ServiceContext.addService is called? |
| 11:33:10 | <dkayiwa> ok |
| 11:33:19 | <dkayiwa> ok |
| 11:47:42 | *** bwolfe has quit IRC |
| 11:47:59 | *** bwolfe has joined #openmrs-sprint |
| 11:47:59 | *** ChanServ sets mode: +o bwolfe |
| 12:19:06 | *** dkayiwa has quit IRC |
| 12:24:15 | *** wluyima_ has quit IRC |
| 13:05:07 | *** wluyima_ has joined #openmrs-sprint |
| 13:13:50 | <wluyima_> hello |
| 13:13:55 | *** dkayiwa has joined #openmrs-sprint |
| 13:21:45 | <bwolfe> good morning wyclif |
| 13:27:50 | *** downeym has joined #openmrs-sprint |
| 13:27:50 | *** ChanServ sets mode: +o downeym |
| 13:27:51 | *** OpenMRSBot sets mode: +o downeym |
| 13:28:09 | <wluyima_> hi Ben! |
| 13:39:27 | *** rafa has joined #openmrs-sprint |
| 13:39:27 | *** ChanServ sets mode: +v rafa |
| 13:40:55 | <bwolfe> dkayiwa: how goes the work on the ticket? |
| 13:41:07 | <bwolfe> wluyima_: have you picked out some sprint tickets and assigned yourself yet? |
| 13:41:44 | <dkayiwa> bwolfe: looked and found no method called addService |
| 13:41:57 | <dkayiwa> will this do? setModuleService |
| 13:42:13 | <dkayiwa> ServiceContext:setModuleService |
| 13:42:17 | <bwolfe> ooo yes, thats even better. then we know its a module service one |
| 13:42:25 | <bwolfe> does that take in which module is loading it too? |
| 13:43:13 | <dkayiwa> not as far as i have understood it so far. but i do not need to know which module anyway |
| 13:43:36 | <bwolfe> no? |
| 13:43:38 | <bwolfe> why not? |
| 13:44:17 | <dkayiwa> i only need to check if it implements the OpenmrsService interface and then invoke the onStartup and onShutdown methods |
| 13:45:23 | <bwolfe> so for each module startup/shutdown you're calling all module service service.startup/shutdown? |
| 13:45:29 | <wluyima_> just picked one |
| 13:46:44 | <dkayiwa> bwolfe: yes |
| 13:47:09 | <dkayiwa> any comments on that? |
| 13:47:17 | <bwolfe> dkayiwa: I suppose that is right. since spring is restarted whenever any module is loaded... |
| 13:47:38 | <dkayiwa> ok |
| 13:56:10 | *** chopin has joined #openmrs-sprint |
| 13:56:10 | *** ChanServ sets mode: +v chopin |
| 13:56:14 | <chopin> o/ |
| 13:56:44 | <bwolfe> yo |
| 13:56:45 | <bwolfe> welcome |
| 13:56:51 | <chopin> tanks |
| 14:02:09 | *** bwolfe has quit IRC |
| 14:03:07 | *** bwolfe has joined #openmrs-sprint |
| 14:03:07 | *** ChanServ sets mode: +o bwolfe |
| 14:26:12 | *** chopin has quit IRC |
| 14:28:10 | *** rafa has left #openmrs-sprint |
| 14:31:05 | *** downeym has quit IRC |
| 14:54:53 | *** chopin has joined #openmrs-sprint |
| 14:54:53 | *** ChanServ sets mode: +v chopin |
| 14:58:08 | <chopin> hey guys, i've got some specific tickets i'll be working on (AMPATH-related) |
| 15:03:41 | <bwolfe> chopin++ |
| 15:12:33 | *** downeym has joined #openmrs-sprint |
| 15:12:33 | *** ChanServ sets mode: +o downeym |
| 15:12:34 | *** OpenMRSBot sets mode: +o downeym |
| 15:13:31 | *** rafa has joined #openmrs-sprint |
| 15:13:31 | *** ChanServ sets mode: +v rafa |
| 15:14:06 | *** rafa has quit IRC |
| 15:14:27 | *** rafa has joined #openmrs-sprint |
| 15:14:27 | *** ChanServ sets mode: +v rafa |
| 15:15:31 | *** rafa has quit IRC |
| 15:18:08 | *** rafa has joined #openmrs-sprint |
| 15:18:08 | *** ChanServ sets mode: +v rafa |
| 15:18:57 | *** rafa has quit IRC |
| 15:19:22 | *** mynick has joined #openmrs-sprint |
| 15:20:12 | <dkayiwa> bwolfe: should i run onStartup in some sort of spawned thread? Looks like org.openmrs.logic.token.TokenService.onStartup is taking forever |
| 15:20:43 | <bwolfe> hmm, yes, thats from an old logic module, isn't it? |
| 15:21:52 | <dkayiwa> version 0.5 |
| 15:22:09 | <bwolfe> hmm, maybe not |
| 15:22:21 | <bwolfe> I think the tokenservice is registering all concepts |
| 15:22:31 | <bwolfe> so might be useful to run it in a new thread. |
| 15:22:43 | *** mynick has quit IRC |
| 15:22:58 | <bwolfe> the other module activator/startup things are in new threads, right dkayiwa ? |
| 15:23:34 | <dkayiwa> let me check |
| 15:26:44 | <dkayiwa> looks like so Daemon.startModule(module); |
| 15:27:01 | <dkayiwa> which will eventually call the activator |
| 15:32:03 | <bwolfe> ok, so you'll have to do something similar with daemon |
| 15:32:09 | <bwolfe> (new method in Daemon class) |
| 15:32:37 | *** surangak has joined #openmrs-sprint |
| 15:32:38 | *** downeym has quit IRC |
| 15:34:04 | <surangak> hello guys |
| 15:35:20 | <bwolfe> hi suranga |
| 15:35:24 | <bwolfe> welcome :-) |
| 15:37:13 | <surangak> let me go have a look see at the list :P |
| 15:38:11 | <surangak> um... I see someof these tickets r claimed by people other than those on the list... |
| 15:38:26 | <surangak> should I leave those tickets alone and try out other ones ? |
| 15:38:58 | <bwolfe> surangak: yes, try other ones |
| 15:39:05 | <bwolfe> surangak: there are non sprint sprinters :-) |
| 15:39:23 | <bwolfe> because some of the tickets I chose are just "low complexity" and so are in the "intro tickets" list that all new devs see |
| 15:39:24 | <surangak> sure, wil do.. |
| 15:40:55 | <bwolfe> ok, I'm off to dinner. I'll be back in a few hours when the kids go to bed (hopefully) |
| 15:43:38 | *** surangak has quit IRC |
| 15:44:20 | *** surangak has joined #openmrs-sprint |
| 15:44:38 | <surangak> aha, looks like we're closer to the same time zone now :) |
| 16:01:38 | *** downeym has joined #openmrs-sprint |
| 16:01:38 | *** ChanServ sets mode: +o downeym |
| 16:01:39 | *** OpenMRSBot sets mode: +o downeym |
| 16:05:29 | *** chopin has quit IRC |
| 16:06:36 | *** dkayiwa has quit IRC |
| 16:19:08 | *** chopin has joined #openmrs-sprint |
| 16:19:14 | *** ChanServ sets mode: +v chopin |
| 16:22:08 | *** surangak has quit IRC |
| 16:23:39 | <wluyima_> am working on https://tickets.openmrs.org/browse/TRUNK-2034 |
| 16:24:04 | <wluyima_> and am just wondering how you create a user from a patient |
| 16:24:15 | <wluyima_> i see creating a user from an existing person |
| 16:24:20 | <wluyima_> is it what he implied? |
| 16:44:39 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Retired locations should appear at the bottom of choice lists on the "Edit Patient" page - TRUNK-2128 <http://feedproxy.google.com/~r/OMRStrunk/~3/8BtMWjX8eIQ/OpenMRS> |
| 16:49:14 | *** surangak has joined #openmrs-sprint |
| 16:56:00 | <djazayeri> wluyima_: regarding your comment from half an hour ago, yes, he means creating a user from an existing person (where that person is a patient) |
| 16:56:23 | <djazayeri> i.e. the test is to create a patient Xyz, and then try to create a user account for them. |
| 16:56:46 | <djazayeri> Mario said it does not attach the user account to the existing person_id of the patient, but rather it creates a new person. |
| 17:03:34 | <wluyima_> thanks Darius |
| 17:05:58 | <surangak> Hi guys |
| 17:06:13 | <surangak> wonder if anyone can help me understand TRUNK-1883 |
| 17:06:27 | <djazayeri> !ticket TRUNK-1883 |
| 17:06:27 | <OpenMRSBot> djazayeri: Allow me to help you with that. More details on ticket TRUNK-1883 can be found at http://tickets.openmrs.org/browse/TRUNK-1883 |
| 17:07:05 | <surangak> it says "First, if the obs value is numeric, the string generated should respect the 'precise' property of the related ConceptNumeric." |
| 17:07:13 | <djazayeri> From reading the ticket description I understand there are two issues |
| 17:07:25 | <surangak> yeps |
| 17:07:33 | <djazayeri> precise = true -> the concept supports fractional values. |
| 17:07:38 | <djazayeri> precise = false -> only integers |
| 17:08:11 | <surangak> ah, so if it is false, no 0.222 etc |
| 17:08:13 | <djazayeri> So I believe the point is that if I have an obs for a concept with precise=false, then when I convert it to a string it should not end in .0 |
| 17:08:14 | *** aja has joined #openmrs-sprint |
| 17:08:49 | <djazayeri> for example if I do numberOfYearsOfSchoolingObs.getValueAsString(Locale.US) I should get "7", not "7.0" |
| 17:09:23 | <djazayeri> and apparently it's also returning values >1000 with a comma, which we don't want |
| 17:10:07 | <djazayeri> Regarding dates, I'm not convinced they should be yyyy-MM-dd. |
| 17:10:58 | <djazayeri> bwolfe: what date format do you think Obs.getValueAsString(Locale) should return in? (Dave Thomas says yyyy-MM-dd. I think it should be the user context's date format though.) |
| 17:12:03 | *** aja has quit IRC |
| 17:12:29 | <surangak> I think I get the meaning now... |
| 17:12:40 | <surangak> Ill start off with the first part.. |
| 17:12:45 | <surangak> thanks guys |
| 17:15:45 | *** chopin has quit IRC |
| 17:16:41 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Delete meetings <http://forum.openmrs.org/viewtopic.php?f=22&t=778#p2950> |
| 17:17:59 | *** downeym has quit IRC |
| 17:28:36 | *** chopin has joined #openmrs-sprint |
| 17:28:36 | *** ChanServ sets mode: +v chopin |
| 17:35:33 | *** dkayiwa has joined #openmrs-sprint |
| 17:41:40 | <bwolfe> djazayeri: its doing the user's date context now, the ticket is asking for changing it to year first |
| 17:41:49 | <bwolfe> (so that things like reports are consistent) |
| 17:44:16 | *** surangak has quit IRC |
| 17:47:23 | <dkayiwa> hi bwolfe: |
| 17:47:58 | <dkayiwa> is there any need for me to you the DeamonThread or i can just use any thread? |
| 17:56:53 | *** surangak has joined #openmrs-sprint |
| 18:02:48 | <surangak> great, 1/2 done :) |
| 18:13:36 | *** dkayiwa has quit IRC |
| 18:17:08 | <bwolfe> dkayiwa: probably want to do the daemon thread so it is authenticated and users don't have to worry about what user is logged in |
| 18:18:17 | <bwolfe> surangak: half done with what? |
| 18:19:06 | <surangak> https://tickets.openmrs.org/browse/TRUNK-1883 |
| 18:19:49 | <surangak> i seem to have fixed the first bit given in the discription |
| 18:20:14 | <djazayeri> bwolfe: I know that's what Dave is asking for, and why. I just think it's not correct behavior for this method. I.e. this method should provide the human-readable output, which means using the user's date format. |
| 18:20:31 | <djazayeri> Data exports should use a different mechanism to do date formatting. |
| 18:20:51 | <djazayeri> (In 2.x I'm changing this around completely, but this is more about the spirit of 1.x.) |
| 18:21:04 | <bwolfe> djazayeri: which ticket is this again? |
| 18:21:21 | <djazayeri> !ticket TRUNK-1883 |
| 18:21:21 | <OpenMRSBot> djazayeri: Allow me to help you with that. More details on ticket TRUNK-1883 can be found at http://tickets.openmrs.org/browse/TRUNK-1883 |
| 18:21:22 | <bwolfe> personally I think yyyy-mm-dd is readable enough :-) |
| 18:22:22 | <surangak> guys, to me dates get displayed as Mon Apr 11 23:51:46 IST 2011 etc |
| 18:22:35 | <bwolfe> oh, hmm, I think we had an RCM ticket to fix the data export locale changed-ness. no? |
| 18:23:12 | <djazayeri> (I 110% agree that data exports should do yyyy-MM-dd) |
| 18:24:19 | <surangak> am I right to assume that the ticket is talking about created date, modified date etc. display guys ? |
| 18:24:57 | <surangak> u mean that instead of Mon Apr 11 23:51:46 IST 2011, i should have a 2011-04-11 format ... |
| 18:26:19 | <djazayeri> My opinion is that the method we are talking about (on Obs) should return Context.getDateFormat().format(...). Ben has the final voice on this, though. |
| 18:26:48 | <bwolfe> surangak: its talking about the getValueAsString method on Obs only |
| 18:27:34 | <bwolfe> you almost have me convinced. data exports could fix this by not copying using its own getvalueasstring method |
| 18:29:21 | <surangak> I see that this method returns data time for DT, TM,and TS abbrivations... |
| 18:30:15 | <surangak> u mean that in case of an concept of these three types, we should return the value in yyyy-mm-dd format ? |
| 18:31:34 | <djazayeri> Actually the return format should differ for Date, Time, and Timestamp. |
| 18:31:53 | <djazayeri> Date -> just the Date. Time -> Just the time. Timestamp -> "${ Date } ${ Time}" |
| 18:32:50 | <surangak> so these changes will affect only Date and timestamp right ? |
| 18:33:27 | <djazayeri> The purpose of this method is to take an observation, and convert it to a string, suitable for printing and displaying to a user. |
| 18:34:11 | <djazayeri> I'm not looking at the code now, but if it's currently printing out the same format for Date, Time, and Timestamp, that's another bug, and you should fix that too while you're working on the file. |
| 18:34:29 | <djazayeri> Yes, these changes will affect only Date and timestamp. |
| 18:34:53 | <surangak> righto, ill start with that... |
| 18:34:58 | <surangak> thanks guys |
| 18:38:56 | <bwolfe> surangak: I think theres another ticket for doing the time vs timestamp thing |
| 18:39:41 | *** downeym has joined #openmrs-sprint |
| 18:39:41 | *** ChanServ sets mode: +o downeym |
| 18:39:42 | *** OpenMRSBot sets mode: +o downeym |
| 18:43:09 | <surangak> wooops |
| 18:44:00 | <surangak> just to clarify what I should try to do here... If i create an obs with a concept of TM |
| 18:44:15 | <surangak> then using this method, it should print out as yyyy-mm-dd |
| 18:44:22 | <surangak> is it.. |
| 18:48:09 | <bwolfe> surangak: is it using Context.getDateFormat now ? |
| 18:50:12 | <surangak> it goes |
| 18:50:18 | <surangak> else if (abbrev.equals("DT")) return (getValueDatetime() == null ? "" : Format.format(getValueDatetime(), locale, FORMAT_TYPE.DATE)); |
| 18:51:05 | <surangak> same for DT, TM and TS |
| 18:51:40 | <surangak> sorry, in each just the FORMAT_TYPEs are different... |
| 18:53:10 | <bwolfe> ok, so leave it like and and just make the date one use a short instead of a long |
| 18:57:37 | <surangak> ah, to do that i will change the util class |
| 18:57:55 | <surangak> thats where the Format.format method is calling |
| 19:14:43 | *** dkayiwa has joined #openmrs-sprint |
| 19:19:13 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Happy birthday to #OpenMRS community member & developer @djazayeri! <http://twitter.com/OpenMRS/statuses/57516321470025728> |
| 19:35:22 | *** surangak has quit IRC |
| 19:53:44 | *** surangak has joined #openmrs-sprint |
| 19:57:20 | *** surangak has quit IRC |
| 20:22:36 | *** dkayiwa has quit IRC |
| 20:42:33 | *** chopin has quit IRC |
| 21:05:56 | *** miranda_ has joined #openmrs-sprint |
| 21:06:17 | *** miranda_ has quit IRC |
| 21:54:52 | *** downeym has quit IRC |
| 22:20:17 | *** wluyima_ has quit IRC |
| 22:51:18 | *** wluyima_ has joined #openmrs-sprint |
| 22:57:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Trying to create a user account for an existing patient actually duplicates the person - TRUNK-2034 <http://feedproxy.google.com/~r/OMRStrunk/~3/ZmDyd56B888/OpenMRS> |