01:02:42
|
<abbas-hachem> heya @djazayeri
|
01:02:48
|
<djazayeri> hi
|
01:03:02
|
<abbas-hachem> I saw your comment. just to confirm further, your fix works. Thanks!
|
01:03:14
|
<djazayeri> great
|
01:03:26
|
<djazayeri> I'm going through and creating tickets for the points in your email.
|
01:03:37
|
<djazayeri> What JIRA username are you using? I see both abbas and h@shm@p
|
01:03:45
|
<abbas-hachem> yeah, I've received notifications.
|
01:03:48
|
<abbas-hachem> abbas
|
01:03:50
|
<djazayeri> okay
|
01:04:25
|
<abbas-hachem> your name sounds Persian by the way. do you have persian roots?
|
01:04:46
|
<djazayeri> My dad (and his whole side of the family) is Iranian
|
01:05:15
|
<abbas-hachem> oh cool. is Darius a nickname though?
|
01:05:21
|
<djazayeri> (they're all in southern california at this point though)
|
01:05:24
|
<djazayeri> what's your background?
|
01:05:52
|
<abbas-hachem> I'm from Lebanon. my family is still there. I moved here 3 years ago.
|
01:05:58
|
<djazayeri> Darius is my name. The English version of Dariush
|
01:06:13
|
<abbas-hachem> which was the name of the emperor right?
|
01:06:19
|
<djazayeri> yup
|
01:06:54
|
<abbas-hachem> nice. by the way, your last name in arabic means "algerian" . so you might have arabic roots too like me :)
|
01:08:15
|
<djazayeri> I think in farsi it means "someone from the island"
|
01:08:54
|
<abbas-hachem> it's true same in arabic. algeria is "jazayer" = islands.
|
01:09:04
|
<abbas-hachem> maybe the word island comes from farsi
|
01:10:04
|
<djazayeri> Nice. (People do occasionally come up to me at meetings and say hello in arabic, because they assume I must be Algerian.)
|
01:11:36
|
<abbas-hachem> i guessed from the first name. :)
|
01:12:59
|
<abbas-hachem> did you see my question in the "Finally" part of my email?
|
01:14:44
|
<djazayeri> just read it
|
01:15:07
|
<djazayeri> I saw that exact behavior when I was writing the patientIdentifiers fragment and the tutorial.
|
01:15:40
|
<djazayeri> The problem was that the table widget wasn't setting the action links correctly when refreshing the table via javascript
|
01:16:02
|
<djazayeri> I fixed that on Monday or Tuesday I think.
|
01:16:11
|
<djazayeri> could it be that you need to svn update?
|
01:16:43
|
<djazayeri> Or maybe because you're not returning the id property with the same name via json?
|
01:19:54
|
<abbas-hachem> hmm let me see
|
01:23:29
|
<abbas-hachem> it's still occuring; what do you mean by not returning the if with the same name
|
01:23:31
|
<abbas-hachem> ?
|
01:28:09
|
<djazayeri> Looking at the patch you attached before, I believe the problem is that in your buildPatientProgramResults method you are not including the patientProgramId property
|
01:28:50
|
<djazayeri> so after the ajax refresh the "delete" action icons have bad links. (But that's not visibly noticeable)
|
01:29:31
|
<djazayeri> make sense?
|
01:31:19
|
<abbas-hachem> sorry was away
|
01:31:22
|
<abbas-hachem> let me see
|
01:32:15
|
<abbas-hachem> ahh
|
01:32:18
|
<abbas-hachem> makes sense!
|
01:34:18
|
<abbas-hachem> works perfectly now
|
01:34:25
|
<abbas-hachem> thanks
|
02:03:14
|
<abbas-hachem> @djazayeri : I will sign off for the day. I attached the updated patch for your review
|
02:05:25
|
*** abbas-hachem has quit IRC
|
04:12:41
|
*** wluyima_ has quit IRC
|
09:04:38
|
*** wluyima has joined #openmrs-sprint
|
09:05:04
|
*** wluyima is now known as Guest5984
|
10:26:18
|
*** jwmajors81 has quit IRC
|
12:52:17
|
*** Guest5984 has quit IRC
|
12:58:50
|
*** downeym has joined #openmrs-sprint
|
12:58:50
|
*** ChanServ sets mode: +o downeym
|
12:58:51
|
*** OpenMRSBot sets mode: +o downeym
|
13:28:24
|
*** Guest5984 has joined #openmrs-sprint
|
13:50:35
|
*** downeym has quit IRC
|
13:56:04
|
*** downeym has joined #openmrs-sprint
|
13:56:04
|
*** ChanServ sets mode: +o downeym
|
13:56:05
|
*** OpenMRSBot sets mode: +o downeym
|
14:09:05
|
*** chopin has joined #openmrs-sprint
|
14:09:10
|
<chopin> haay
|
14:09:15
|
*** ChanServ sets mode: +v chopin
|
14:09:30
|
<downeym> hey
|
15:03:18
|
<djazayeri> hi downeym
|
15:04:21
|
<downeym> yes sir
|
15:05:40
|
<djazayeri> sorry, that was a tired response to "hey"
|
15:05:51
|
<djazayeri> never mind me
|
15:06:12
|
<downeym> heh, no worries
|
15:06:23
|
<downeym> the hour delay threw me off :P
|
15:06:46
|
<downeym> or gsoc desensitization :)
|
15:06:56
|
<djazayeri> I just enabled timestamps in my IRC client. That should help.
|
15:27:00
|
*** rafa_ has joined #openmrs-sprint
|
15:27:00
|
*** ChanServ sets mode: +v rafa_
|
15:27:13
|
*** rafa_ is now known as rafa
|
16:03:04
|
*** Guest5984 has quit IRC
|
16:03:58
|
*** Guest8192 has joined #openmrs-sprint
|
16:05:16
|
*** Guest8192 has quit IRC
|
16:08:53
|
*** wluyima_ has joined #openmrs-sprint
|
16:43:55
|
<djazayeri> rafa: I commented on your patch. wluyima_ just starting to look at yours
|
16:44:29
|
<rafa> ohh great, thanks!
|
16:44:55
|
<djazayeri> looking forward to your comments on what the framework is missing
|
16:45:15
|
<djazayeri> ah, I see you put them in the etherpad
|
16:45:19
|
<djazayeri> just hadn't scrolled down
|
16:45:32
|
<rafa> right
|
16:47:21
|
*** bwolfe has joined #openmrs-sprint
|
16:47:21
|
*** ChanServ sets mode: +o bwolfe
|
16:52:57
|
<rafa> djazayeri: do I get right the publish / subscribe pattern? why do you want to provide the entire person / patient object when updating only some properties?
|
16:54:02
|
<djazayeri> My reasoning is that proving the entire object is only a small amount of extra computation and network bandwidth
|
16:54:35
|
<djazayeri> But if there are multiple fragments on the page that need to update themselves, you save a lot of bandwidth if most of those can avoid doing an ajax call
|
16:54:57
|
<djazayeri> That said, I guess my approach only makes sense if you're sending the generic patient/#.changed message
|
16:55:11
|
<djazayeri> i.e. if I've only changed the identifiers, I should only send a list of identifiers.
|
16:55:32
|
<rafa> yes that was my point
|
16:55:32
|
<djazayeri> Trying to remember why I approached it this way...
|
16:56:54
|
<rafa> well I think it would be perfectly fine to return a patient object with it's id, but with only changed data included
|
16:57:16
|
<djazayeri> I believe I was thinking about what happens if other modifications happen to the patient (by other users or other browser windows) while we're looking at the page.
|
16:57:49
|
<djazayeri> But probably that's not really necessary.
|
16:58:17
|
<djazayeri> I do agree that we should always be returning a Patient object with its id, even if only some changed data is included.
|
17:01:32
|
<djazayeri> wluyima_: see comments on the review. (it's complete.)
|
17:01:50
|
<rafa> djazayeri: what do you mean by "We should be following the address layout specified in a global property"?
|
17:02:48
|
<djazayeri> there's a global property called "layout.address.format"
|
17:03:27
|
<djazayeri> in openmrs core, there's a bean: org.openmrs.layout.web.address.AddressSupport
|
17:04:08
|
<djazayeri> that has registered layouts in it. (e.g. USA is one way, and Kenya is another)
|
17:04:49
|
<djazayeri> defining which fields are actually shown, in what order, and what their country-specific labels are.
|
17:05:05
|
<djazayeri> e.g. in the kenya one: <prop key="address4">Location.division</prop>
|
17:05:14
|
<rafa> I see, I didn
|
17:05:22
|
<rafa> I haven't noticed that
|
17:05:27
|
<djazayeri> anyway, I don't think those classes are actually included in the 2.x UI project yet, since they're in the web layer.
|
17:05:40
|
<djazayeri> and we're only including the API layer from openmrs 1.x.
|
17:05:57
|
<djazayeri> You don't actually need to fix this, just pointint it out.
|
17:06:23
|
<rafa> I understand, thanks for the explanation anyway!
|
17:11:47
|
*** rafa has quit IRC
|
17:28:15
|
*** downeym has quit IRC
|
17:28:23
|
*** downeym has joined #openmrs-sprint
|
17:28:23
|
*** ChanServ sets mode: +o downeym
|
17:28:24
|
*** OpenMRSBot sets mode: +o downeym
|
18:03:40
|
*** downeym has quit IRC
|
18:06:49
|
*** downeym has joined #openmrs-sprint
|
18:06:49
|
*** ChanServ sets mode: +o downeym
|
18:06:50
|
*** OpenMRSBot sets mode: +o downeym
|
18:07:33
|
*** downeym has quit IRC
|
18:07:40
|
*** downeym has joined #openmrs-sprint
|
18:07:40
|
*** ChanServ sets mode: +o downeym
|
18:07:41
|
*** OpenMRSBot sets mode: +o downeym
|
20:36:11
|
*** chopin has quit IRC
|
20:57:24
|
*** downeym has quit IRC
|
21:09:14
|
*** downeym has joined #openmrs-sprint
|
21:09:15
|
*** downeym has joined #openmrs-sprint
|
21:09:15
|
*** OpenMRSBot sets mode: +o downeym
|
21:09:15
|
*** ChanServ sets mode: +o downeym
|
21:47:45
|
*** downeym has quit IRC
|
22:11:13
|
*** wluyima_ has quit IRC
|
22:41:03
|
*** wluyima_ has joined #openmrs-sprint
|