00:56:58
|
*** jwmajors81 has joined #openmrs-sprint
|
02:17:21
|
*** chopin has joined #openmrs-sprint
|
02:17:21
|
*** ChanServ sets mode: +v chopin
|
03:23:04
|
*** chopin has quit IRC
|
09:48:57
|
*** rafa has joined #openmrs-sprint
|
12:12:37
|
*** jwmajors81 has quit IRC
|
12:26:38
|
*** chopin has joined #openmrs-sprint
|
12:26:38
|
*** ChanServ sets mode: +v chopin
|
12:32:55
|
*** wluyima_ has quit IRC
|
12:57:56
|
*** Guest61187 has joined #openmrs-sprint
|
12:58:48
|
*** Guest61187 is now known as wyclif
|
13:40:28
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Add admin page for mapping concept reference terms and add a search widget - TRUNK-2130 <http://feedproxy.google.com/~r/OMRStrunk/~3/Oj4VqJWJXeA/OpenMRS>
|
13:53:58
|
*** downeym has joined #openmrs-sprint
|
13:53:58
|
*** ChanServ sets mode: +o downeym
|
13:53:59
|
*** OpenMRSBot sets mode: +o downeym
|
14:19:28
|
*** chopin has quit IRC
|
14:30:51
|
*** downeym is now known as downeym|meeting
|
14:37:46
|
*** wyclif has quit IRC
|
14:43:06
|
*** wluyima_ has joined #openmrs-sprint
|
14:43:14
|
*** wluyima_ has quit IRC
|
14:47:35
|
*** wluyima_ has joined #openmrs-sprint
|
15:14:50
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Follow up, Add admin page for mapping concept reference terms and add a search widget - TRUNK-2130 <http://feedproxy.google.com/~r/OMRStrunk/~3/65viwMbSWNM/OpenMRS>
|
15:28:48
|
<downeym|meeting> are these updates from OpenMRSBot helpful to post in this channel?
|
15:29:30
|
*** ChanServ sets mode: +v rafa
|
15:33:36
|
<djazayeri> downeym|meeting: personally I find them completely useless in this channel
|
15:33:48
|
<djazayeri> because i've set my notification very high for this channel
|
15:33:50
|
<downeym|meeting> yeah i would agree
|
15:33:56
|
<downeym|meeting> i'll work on it
|
15:51:32
|
*** downeym|meeting is now known as downeym
|
15:52:03
|
<rafa> djazayeri: Hi Darius, I've got a quick question regarding TRUNK-2184. Do I need to create this fragment for Person or Patient?
|
15:52:09
|
<rafa> !ticket TRUNK-2184
|
15:52:09
|
<OpenMRSBot> rafa: Allow me to help you with that. More details on ticket TRUNK-2184 can be found at http://tickets.openmrs.org/browse/TRUNK-2184
|
15:54:18
|
<rafa> I mean should it be PatientFragmentExtension or should I create PersonFragmentExtension?
|
16:09:12
|
*** chughgaurav has joined #openmrs-sprint
|
16:10:25
|
<djazayeri> rafa: sorry, was in a meeting
|
16:11:14
|
<rafa> djazayeri: np, could you advise me on that?
|
16:11:39
|
<djazayeri> The extension should be a PatientFragmentExtension.
|
16:12:20
|
<djazayeri> We will probably also need to create a "PersonFragmentExtension", and this fragment could publish both.
|
16:12:33
|
<rafa> djazayeri: okay, shall I use Person or Patient in the controller then?
|
16:12:42
|
<djazayeri> I mean: the personAddresses fragment would publish itself both as a PatientFragmentExtension and a PersonFragmentExtension
|
16:12:49
|
<djazayeri> but that still needs some thought.
|
16:13:02
|
<djazayeri> I think you should make it operate on a Person
|
16:13:13
|
<djazayeri> in the controller
|
16:13:20
|
<rafa> very good
|
16:13:56
|
*** downeym has quit IRC
|
16:15:45
|
<rafa> I'm very positive about the new ui framework, very powerful, great job
|
16:16:31
|
<rafa> I'll post some of my observations to the dev list.
|
16:16:40
|
<djazayeri> Okay. You can also note theme here if you want: http://notes.openmrs.org/2x-UI-framework-needs
|
16:16:47
|
<djazayeri> but happy to have them on the dev list too
|
16:17:00
|
<djazayeri> and i'll summarize everyone's comments on the notes page
|
16:17:03
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: The thoughts of the #OpenMRS community continue to be with the people of Japan today during yet another earthquake. <http://twitter.com/OpenMRS/statuses/56018144669609985> || New Changeset: OpenMRS (concept_mappings): Merging trunk to concept_mappings rev:18709 - rev:19178 <http://feedproxy.google.com/~r/OMRStrunk/~3/Te-VrKQRXrI/OpenMRS>
|
16:17:13
|
<rafa> okay, I'll do that.
|
16:17:24
|
<rafa> thanks!
|
16:23:27
|
<rafa> djazayeri:
|
16:24:06
|
<djazayeri> yes?
|
16:24:36
|
<rafa> Does formPopup support Spring backing beans so that I can use PersonAddress in addAddress instead of specyfing all request parameters?
|
16:25:13
|
<rafa> I meant popupForm
|
16:25:23
|
<rafa> the widget
|
16:25:52
|
<djazayeri> rafa: no, it doesn't, but that would be a very nice feature
|
16:26:10
|
<rafa> I'll note that :)
|
16:29:26
|
<djazayeri> (away for a bit)
|
16:59:56
|
*** rafa has quit IRC
|
17:05:59
|
*** chughgaurav has quit IRC
|
17:29:12
|
*** rafa has joined #openmrs-sprint
|
17:29:15
|
*** ChanServ sets mode: +v rafa
|
17:54:36
|
*** downeym has joined #openmrs-sprint
|
17:54:36
|
*** ChanServ sets mode: +o downeym
|
17:54:37
|
*** OpenMRSBot sets mode: +o downeym
|
18:20:27
|
<wluyima_> so am done going trough all the tutorials
|
18:20:55
|
<wluyima_> what code up just to get more coding experience with the new famework?
|
18:21:14
|
<wluyima_> sorry! through
|
18:21:40
|
<djazayeri> wluyima_: great! pick a "xyz fragment" ticket from https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&mode=hide&jqlQuery=fixVersion+%3D+%222.x+Dashboard+Fragments+Sprint%22+AND+resolution+is+EMPTY+AND+status+%3D+%22Ready+for+Work%22+AND+resolution+%3D+Unresolved+ORDER+BY+priority+DESC%2C+key+DESC
|
18:21:45
|
<OpenMRSBot> <http://ln-s.net/8i-G> (at tickets.openmrs.org)
|
18:22:12
|
<wluyima_> thanks djazayeri
|
18:23:32
|
<wluyima_> are all the 9 on the page unassigned?
|
18:23:50
|
<djazayeri> yes, the tickets should be up to date
|
18:24:01
|
<wluyima_> thanks
|
20:23:41
|
*** downeym has quit IRC
|
21:05:00
|
<rafa> djazayeri: How much polished should be the code in this sprint? Do I need to validate fields and so on?
|
21:05:40
|
<djazayeri> Ideally you should validate them, yes.
|
21:05:45
|
<djazayeri> You don't need to display the errors nicely though.
|
21:05:54
|
<djazayeri> The framework needs to do that.
|
21:06:09
|
<djazayeri> Specifically, you can say 'return new FailureResult(errors)'
|
21:06:45
|
<rafa> good
|
21:06:46
|
<djazayeri> And you can do something like:
|
21:07:01
|
<djazayeri> * declare a FragmentActionRequest parameter to the action method
|
21:07:14
|
<djazayeri> * call far.fieldError(fieldName, message)
|
21:07:24
|
<djazayeri> return new FailureResult(far.getErrors())
|
21:08:24
|
<rafa> okay got it and another thing does @InitBinder annotation work? I need to convert requestParam to java.util.Date
|
21:09:02
|
<rafa> I can't force it to work :/
|
21:09:54
|
<djazayeri> no, we don't use @InitBinder
|
21:10:09
|
<djazayeri> https://wiki.openmrs.org/display/docs/Type+Converters+in+2.x
|
21:10:16
|
<OpenMRSBot> <http://ln-s.net/8iA6> (at wiki.openmrs.org)
|
21:10:24
|
<djazayeri> You probably have to write StringToDateConverter
|
21:10:34
|
<rafa> right
|
21:10:59
|
<djazayeri> (I thought I'd written that already, but apparently not, judging from the code of Abbas's that I'm reviewing
|
21:11:59
|
<djazayeri> looking at the code, I do see that class
|
21:12:44
|
<djazayeri> so it should just work if you declare a @RequestParam... Date date
|
21:13:04
|
<rafa> yes, apparently the problem is in formatting style
|
21:13:23
|
<djazayeri> are you using the java.util.Date field?
|
21:13:44
|
<rafa> StringToDateConverter takes date with the separator "-" and popupForm has "/"
|
21:13:48
|
<rafa> yes
|
21:14:00
|
<djazayeri> hmm, but it's yyyy/mm/dd, right?
|
21:14:28
|
<rafa> hmm in my system it's MM/dd/yyyy
|
21:14:40
|
<djazayeri> ah, okay, that's the problem then.
|
21:14:45
|
<djazayeri> need to fix that widget
|
21:24:17
|
<djazayeri> rafa: can you look at that? And if you can make the one-line fix in java.util.Date.gsp to specify a date format, can you check that in immediately?
|
21:25:34
|
<rafa> It's pretty late here. I can look at that tomorrow.
|
21:25:48
|
<djazayeri> ah, no problem, I'll take a look sooner than that.
|
21:28:10
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Attention students: Final hours to submit your #gsoc 2011 proposals to OpenMRS! http://go.openmrs.org/soc2011 <http://twitter.com/OpenMRS/statuses/56094474920665088>
|
21:34:50
|
*** rafa has quit IRC
|
22:32:37
|
*** wluyima_ has quit IRC
|
22:32:39
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Patient Flags 1.2.9 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=patientflags&version=&1.2.9>
|
22:43:33
|
*** abbas-hachem has joined #openmrs-sprint
|
22:43:41
|
<abbas-hachem> Hi Darius
|
22:43:50
|
<djazayeri> hi abbas-hachem
|
22:44:08
|
<abbas-hachem> any updates on the date issue you mentioned on JIRA?
|
22:44:30
|
<djazayeri> Yes. I created another ticket (about the date format of the datepicker) which I copied you on (I think)
|
22:44:35
|
<djazayeri> And I committed code for it
|
22:44:54
|
<djazayeri> so you should do an svn update, remove the date format stuff you did, and test and see if it works
|
22:45:02
|
<abbas-hachem> ok, so now I don't need to do anything? it'll send the date as yyyy-MM-dd?
|
22:45:08
|
<djazayeri> yes
|
22:45:13
|
<abbas-hachem> ok cool.
|
22:45:14
|
<djazayeri> (I hope!)
|
22:45:23
|
<djazayeri> I haven't actually tested the code I checked in.
|
22:45:33
|
<abbas-hachem> ok, will test. I'll reattach the patch when i test this
|
23:09:07
|
*** wluyima_ has joined #openmrs-sprint
|
23:55:34
|
*** jwmajors81 has joined #openmrs-sprint
|