01:06:52
|
<chopin> cool
|
01:06:54
|
<chopin> thanks djazayeri
|
01:17:04
|
*** abbas-hachem has joined #openmrs-sprint
|
01:17:17
|
<abbas-hachem> Hi Darius, are you there?
|
01:28:19
|
*** djazayeri_ has joined #openmrs-sprint
|
01:28:53
|
*** djazayeri_ has left #openmrs-sprint
|
01:29:03
|
*** djazayeri_ has joined #openmrs-sprint
|
01:30:44
|
*** djazayeri_ has joined #openmrs-sprint
|
01:31:02
|
<djazayeri_> abbas-hachem: sorry, network difficulties
|
01:33:59
|
*** djazayeri has quit IRC
|
01:34:14
|
*** djazayeri_ is now known as djazayeri
|
01:34:26
|
*** ChanServ sets mode: +o djazayeri
|
01:49:39
|
*** downeym has joined #openmrs-sprint
|
01:49:39
|
*** ChanServ sets mode: +o downeym
|
01:49:40
|
*** OpenMRSBot sets mode: +o downeym
|
01:55:07
|
<abbas-hachem> @djazayeri: to what extend are we trying to replicate what's currently in 1.x in this week's sprint?
|
01:55:50
|
<abbas-hachem> for example, the patient programs jsp page currently does a bunch of things
|
01:56:10
|
<djazayeri> The goal is to iterate our way there...
|
01:56:36
|
<djazayeri> And build up a list of good-practice examples as we do it.
|
01:57:47
|
<djazayeri> So we do need to eventually replicate the programs portlet from 1.x, but not necessarily on one pass.
|
01:58:10
|
<djazayeri> However trying to do it should inform whether we need to build some more generic widgets for this sort of thing.
|
02:04:48
|
*** chopin has quit IRC
|
02:07:02
|
<abbas-hachem> perfect.
|
02:07:55
|
<abbas-hachem> Thanks.
|
02:10:23
|
<djazayeri> so, if you try working on that ticket, as you work through the tutorial, be thinking about how we can extend some of the generic widgets to handle this.
|
02:11:58
|
<abbas-hachem> ok, in that perspective for example, does the current table widget support derived properties? for example, the programs table has a dateCompleted colukn which should be "still enrolled" if that date is null
|
02:12:17
|
<djazayeri> nope
|
02:12:30
|
<djazayeri> so for the moment it's fine for it to just show "null"
|
02:12:36
|
<djazayeri> I mean: to be blank
|
02:12:46
|
<djazayeri> but definitely make a list of missing features as you go along
|
02:13:26
|
<abbas-hachem> ok.
|
02:37:21
|
*** downeym has quit IRC
|
02:52:07
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Updating concept reference term forms with new changes to reference terms <http://feedproxy.google.com/~r/OMRStrunk/~3/SYrAdVPELmo/OpenMRS> || New Changeset: OpenMRS (concept_mappings): concept_mappings: Updating concept reference term form, validation and save handler <http://feedproxy.google.com/~r/OMRStrunk/~3/DDBmO05INiI/OpenMRS> || New Changeset: OpenMRS (concept_mappings): concept_mappings: Improving concept reference term mappings <http://feedproxy.google.com/~r/OMRStrunk/~3/WDRQFujW9HY/OpenMRS> || New Changeset: OpenMRS (trunk): Add Missing help tool tips on the concept form when datatype is changed - TRUNK-2052... <http://feedproxy.google.com/~r/OMRStrunk/~3/pVaLgN7eyzY/OpenMRS> || On Twitter: OpenMRS: #OpenMRS acquired by @Google, moves to commercial license - http://go.openmrs.org/acquisition #ICT4D #HFOSS <http://twitter.com/OpenMRS/statuses/53812787075489792> || New Changeset: OpenMRS (trunk): Change Patient Identifier Location to be optional. See ticket TRUNK-427... <http://feedproxy.google.com/~r/OMRStrunk/~3/IPBQevhxj7c/OpenMRS> || New Changeset: OpenMRS (trunk): Committing changes that formatter automatically made in a clean checkout <http://feedproxy.google.com/~r/OMRStrunk/~3/bVgcpTJwwkY/OpenMRS> || New Changeset: OpenMRS (trunk): svn:ignore of WEB-INF/tags/module <http://feedproxy.google.com/~r/OMRStrunk/~3/YLTfJcvQDaU/OpenMRS> || New Changeset: OpenMRS (root:): OpenMRS patches applied to correct jsp compilation issues. <http://feedproxy.google.com/~r/OMRStrunk/~3/0iK-MFdrnBA/OpenMRS> || Shazin Sadakath: Sri Lanka Vs India, A lot more than just World Cup Final. <http://shazsterblog.blogspot.com/2011/03/sri-lanka-vs-india-lot-more-than-just.html> || OpenMRS Forum: Unloading Libraries <http://forum.openmrs.org/viewtopic.php?f=8&t=777#p2949> || New Changeset: OpenMRS (1.7.x): backporting TRUNK-2117 to branches/1.7.x - fixed banner bar for legacy theme (and minor change to footer) <http://feedproxy.google.com/~r/OMRStrunk/~3/wQKzUR1bgH4/OpenMRS> || New Changeset: OpenMRS (1.8.x): backporting TRUNK-2117 to branches/1.8.x - fixed banner bar for legacy theme (and minor change to footer) <http://feedproxy.google.com/~r/OMRStrunk/~3/cl-UukjmB-4/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2117 - fixed banner bar for legacy theme (and minor change to footer) <http://feedproxy.google.com/~r/OMRStrunk/~3/xwe4m15G2x0/OpenMRS> || New Changeset: OpenMRS (trunk): fixed a comment <http://feedproxy.google.com/~r/OMRStrunk/~3/hy6ylRP-Ccc/OpenMRS> || OpenMRS Forum: Re: Customization of openmrs <http://forum.openmrs.org/viewtopic.php?f=3&t=774#p2948> || OpenMRS Forum: Patient Beds <http://forum.openmrs.org/viewtopic.php?f=2&t=776#p2947> || OpenMRS Forum: Create new privileges <http://forum.openmrs.org/viewtopic.php?f=8&t=775#p2946> || OpenMRS Forum: Customization of openmrs <http://forum.openmrs.org/viewtopic.php?f=3&t=774#p2945> || New Changeset: OpenMRS (1.8.x): Back porting, Removing 'View Observations' privilege from Anonymous user - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/-tqIFIGv3Vk/OpenMRS> || New Changeset: OpenMRS (trunk): Removing 'View Observations' privilege from Anonymous user - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/67JEWqxvrIY/OpenMRS> || New Changeset: OpenMRS (1.8.x): Back porting, Don't display encounter index page when a user isn't authenticated - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/AufxEhpULWs/OpenMRS> || New Changeset: OpenMRS (trunk): Don't display encounter index page when a user isn't authenticated - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/1q5YvFAEBfk/OpenMRS> || New Changeset: OpenMRS (trunk): Add a basic OpenmrsSerializer to core - followup fix - TRUNK-2008 <http://feedproxy.google.com/~r/OMRStrunk/~3/zxzhXH8RN-Y/OpenMRS> || New Changeset: OpenMRS (trunk): Add a basic OpenmrsSerializer to core - TRUNK-2008... <http://feedproxy.google.com/~r/OMRStrunk/~3/bZffw3InykM/OpenMRS> || New Changeset: OpenMRS (trunk): Add error message in ADTA28Handler if AssigningAuthority is missing - TRUNK-2056... <http://feedproxy.google.com/~r/OMRStrunk/~3/jp_cCGhWt9o/OpenMRS> || New Changeset: OpenMRS (trunk): Clean up favicon - TRUNK-2066 <http://feedproxy.google.com/~r/OMRStrunk/~3/qBaCDqpUfTs/OpenMRS> || New Changeset: OpenMRS (trunk): patch for: TRUNK-1611... <http://feedproxy.google.com/~r/OMRStrunk/~3/9Arh0zInoAo/OpenMRS> || New Changeset: OpenMRS (trunk): Random formatting fix <http://feedproxy.google.com/~r/OMRStrunk/~3/oTeKW0TERRA/OpenMRS> || OpenMRS Forum: Re: Package org.openmrs <http://forum.openmrs.org/viewtopic.php?f=11&t=773#p2944>
|
03:18:45
|
*** bwolfe has quit IRC
|
03:26:47
|
<abbas-hachem> @djazayeri if you're still there, I was wondering whether the plan is to commit gradually in this sprint, or send a patch and attach it to JIRA as I usually do with Ben. let me know what process I should be following.
|
04:32:46
|
*** abbas-hachem has quit IRC
|
12:46:13
|
*** chopin has joined #openmrs-sprint
|
12:46:13
|
*** ChanServ sets mode: +v chopin
|
12:54:22
|
*** downeym has joined #openmrs-sprint
|
12:54:22
|
*** ChanServ sets mode: +o downeym
|
12:54:23
|
*** OpenMRSBot sets mode: +o downeym
|
13:14:49
|
*** wluyima_ has joined #openmrs-sprint
|
13:15:53
|
*** chopin has quit IRC
|
13:31:20
|
*** chopin has joined #openmrs-sprint
|
13:31:20
|
*** ChanServ sets mode: +v chopin
|
13:59:14
|
<downeym> FYI we are logging this channel since yesterday, but the scripts to publish the logs will have to be refactored a bit to get them up on the wiki real-time
|
14:00:30
|
<downeym> s/factor/vis/
|
14:25:33
|
*** chopin has quit IRC
|
14:34:37
|
*** wluyima_ has quit IRC
|
14:39:10
|
*** chopin has joined #openmrs-sprint
|
14:39:13
|
*** ChanServ sets mode: +v chopin
|
15:42:35
|
*** Guest75348 has joined #openmrs-sprint
|
15:43:20
|
<djazayeri> chopin: how goes the personNames fragment?
|
15:43:31
|
<djazayeri> want to attach a patch to the ticket? or is it too soon for that?
|
15:43:42
|
*** Guest56900 has joined #openmrs-sprint
|
15:44:37
|
<djazayeri> hi Guest56900 aka wyclif
|
15:45:06
|
*** Guest56900 is now known as wyclif
|
15:45:27
|
*** wyclif is now known as wluyima_
|
15:46:12
|
<wluyima_> off for lunch'
|
15:46:20
|
<wluyima_> will be back in 45min
|
15:46:25
|
<djazayeri> okay, afterwards you should pick a ticket to work on as you go through the tutorial
|
15:46:26
|
<wluyima_> 30-45min
|
17:10:35
|
*** chopin has quit IRC
|
17:10:50
|
*** chopin has joined #openmrs-sprint
|
17:10:50
|
*** ChanServ sets mode: +v chopin
|
18:15:18
|
<chopin> djazayeri: one moment and i'll have the patch up
|
18:15:27
|
<chopin> feels like it needs improvement
|
18:15:30
|
<chopin> but not so bad
|
18:37:03
|
<chopin> djazayeri: !ticket TRUNK-2181
|
18:37:10
|
<chopin> !ticket TRUNK-2181
|
18:37:10
|
<OpenMRSBot> chopin: Allow me to help you with that. More details on ticket TRUNK-2181 can be found at http://tickets.openmrs.org/browse/TRUNK-2181
|
18:37:20
|
<djazayeri> looking at the patch now
|
18:37:24
|
<chopin> ah jk
|
18:37:27
|
<chopin> er k
|
18:37:47
|
<chopin> i should also update the ticket re: clearing form fields
|
18:37:56
|
<chopin> i changed mine to match what we had discussed
|
18:38:50
|
<downeym> !refer chopin TRUNK-2181
|
18:38:50
|
* OpenMRSBot refers chopin to TRUNK-2181
|
18:38:52
|
<downeym> meh
|
18:38:58
|
<chopin> haha
|
18:38:59
|
<chopin> close
|
18:39:12
|
<downeym> !refer chopin ticket TRUNK-2181
|
18:39:12
|
* OpenMRSBot refers chopin to ticket TRUNK-2181
|
18:39:18
|
<downeym> !refer chopin !ticket TRUNK-2181
|
18:39:18
|
* OpenMRSBot refers chopin to !ticket TRUNK-2181
|
18:39:20
|
<downeym> i give up :)
|
18:53:12
|
<djazayeri> commented
|
18:53:26
|
<djazayeri> chopin: commented. Some TODOs for you, some discussion points.
|
18:53:52
|
<chopin> k, became apparent that we aren't handling preferred policy in the API
|
18:53:53
|
<djazayeri> But I think we'll try to gather those discussion points up for when there are more people than you and me who know enough to have an opinion.
|
18:53:54
|
<chopin> or voiding
|
18:55:54
|
<djazayeri> so create tickets. :-)
|
18:56:01
|
<chopin> hah ok
|
18:56:10
|
<chopin> just wondered if there was some historical / insider info on that already
|
18:57:58
|
<djazayeri> Yes: historically we've occasionally flipped back and forth on whether something like a PersonName should really stand on its own in the API, or if it should only be accessible through its parent object
|
18:58:57
|
<djazayeri> We should use the fact that we're going to be revisiting everything in the API as we do 2.x UI work to find these inconsistencies
|
18:59:19
|
<chopin> yup
|
18:59:30
|
<chopin> we'll find all the weirdness
|
19:21:13
|
*** tscieplek has joined #openmrs-sprint
|
19:31:13
|
<tscieplek> Hi again, I was using web-based IRC Client and after posting my last post at 20:20 it stopped responding. I would like to ask you if there is any sql script containing sample data?
|
19:33:25
|
<djazayeri> tscieplek: this channel is for discussions about the sprint that is currently going on.
|
19:33:41
|
<djazayeri> I'm happy to answer that question on the #openmrs channel
|
19:36:13
|
<tscieplek> I'm sorry, I have to change the room.
|
19:50:51
|
<chopin> djazayeri: you got it right on all your assumptions (no getPersonName(int), no voidPersonName(), removeName() actually purges it)
|
19:54:51
|
<chopin> djazayeri: should i be null-checking to make sure there's at least one not-null name part?
|
20:05:00
|
<djazayeri> yes
|
20:05:08
|
<djazayeri> chopin: no empty names
|
20:05:27
|
<djazayeri> actually you should use PersonNameValidator
|
20:07:01
|
<djazayeri> and you can actually do "new FailureResult(errors)"
|
20:07:24
|
*** chughgaurav has joined #openmrs-sprint
|
20:07:45
|
<djazayeri> although the idea there is that the field errors of the errors object refer to fields on the submission
|
20:08:14
|
*** chughgaurav has quit IRC
|
20:10:25
|
<chopin> ah good idea
|
20:10:28
|
<chopin> didn't realize that existed
|
20:10:56
|
<djazayeri> so it will only work right if you have the form field names exactly the same as the property names on PersonName
|
20:11:00
|
<djazayeri> (I need to think this through)
|
20:11:21
|
<djazayeri> also, the error message won't actually be displayed right in the UI for now. That's a to-do for me.
|
20:12:10
|
<chopin> ok
|
20:12:35
|
<djazayeri> but anyway, you should use the PersonNameValidator
|
20:12:57
|
<chopin> is there one sitting in the context, or do i instantiate it?
|
20:13:27
|
<djazayeri> the errors object? if you declare a FragmentActionRequest parameter on the request, that has an errors.
|
20:13:35
|
<djazayeri> I should probably expose Errors directly.
|
20:14:13
|
<chopin> ah k ... but i meant the PersonNameValidator
|
20:14:39
|
<djazayeri> oh, just do new PersonNameValidator().validate(...)
|
20:17:33
|
<chopin> k
|
20:35:21
|
*** chopin has quit IRC
|
20:42:00
|
*** tscieplek has left #openmrs-sprint
|
21:09:44
|
*** rafa has joined #openmrs-sprint
|
21:12:45
|
*** downeym has quit IRC
|
21:18:11
|
*** rafa has quit IRC
|
22:22:41
|
*** wluyima_ has quit IRC
|
23:23:59
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Handle HttpSessionRequiredException in spring annotated controllers - TRUNK-2005:... <http://feedproxy.google.com/~r/OMRStrunk/~3/cQ2s4Z96_Q8/OpenMRS>
|
23:27:28
|
*** wluyima_ has joined #openmrs-sprint
|