00:21:27
|
<dmexs> djazayeri: but that isn't not possible with xforms
|
00:21:58
|
<djazayeri> dmexs: what exactly? (I'm not an expert on xforms)
|
00:22:39
|
<dmexs> have identifiers assigned automatically when patients are created
|
00:22:51
|
<dkayiwa> dmexs: the xforms module does not in any way interact with the idgen module
|
00:23:13
|
<djazayeri> are you creating patients through the xforms module? Or through the regular find/create patient pages?
|
00:23:21
|
<dmexs> xforms
|
00:23:47
|
<djazayeri> ah, okay, then I don't know what your solution would be.
|
00:23:58
|
<dmexs> and I apologize to everybody for beating this to death
|
00:24:05
|
<dmexs> djazayeri: thanks though
|
01:26:38
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Add a basic OpenmrsSerializer to core - followup fix - TRUNK-2008 <http://feedproxy.google.com/~r/OMRStrunk/~3/zxzhXH8RN-Y/OpenMRS>
|
01:27:27
|
*** arthursribeiro has joined #openmrs
|
01:47:10
|
<dkayiwa> dmexs: are you still on?
|
01:50:33
|
*** tenaj has joined #openmrs
|
01:54:48
|
*** Mkop has joined #openmrs
|
01:54:48
|
*** ChanServ sets mode: +v Mkop
|
01:55:15
|
*** wyclif has joined #openmrs
|
01:56:48
|
<dmexs> dkayiwa: yup
|
01:57:04
|
<dkayiwa> which version of openmrs are you running?
|
01:57:20
|
<dmexs> Version: 1.7.1 Build 17223
|
01:57:41
|
<dkayiwa> which version of the idgen module are you running?
|
01:58:19
|
<dmexs> 2.0.1
|
01:59:07
|
<dkayiwa> does the idgen module autogenerate for you patient identifiers?
|
02:04:24
|
<dkayiwa> dmexs: or you have never used it before?
|
02:08:04
|
<dmexs> never used it before
|
02:08:16
|
<dmexs> i'm completely new to openmrs as of two weeks ago
|
02:08:32
|
<dkayiwa> ok. have you read its documentation on the wiki?
|
02:08:35
|
<dmexs> yup
|
02:08:47
|
<dkayiwa> so i guess you know how to use it now?
|
02:09:06
|
<dkayiwa> for autogenerating patient identifiers?
|
02:10:16
|
<dmexs> yes but the issue is having it work with an xforms create patient page, which I guess is not possible because there is no interaction between the two
|
02:11:34
|
<dkayiwa> can i send you an updated (to optionally use the idgen module) version of the xforms module and u test it?
|
02:14:07
|
<dmexs> absolutely
|
02:14:24
|
<dkayiwa> i send to you email address?
|
02:14:41
|
<dmexs> pm
|
02:14:49
|
<dkayiwa> ok
|
02:17:05
|
<dkayiwa> sent
|
02:18:13
|
<dkayiwa> dmexs: you will need to set two global properties
|
02:18:17
|
<dkayiwa> xforms.autoGeneratePatientIdentifier
|
02:18:19
|
<dkayiwa> and
|
02:18:29
|
<dkayiwa> xforms.new_patient_identifier_type_id
|
02:19:53
|
<dmexs> hmm ok
|
02:20:00
|
<dmexs> the first being set to true
|
02:20:05
|
<dkayiwa> yes
|
02:20:16
|
<dmexs> and the second set to the id of the patient identifier that i want autogenerated by idgen
|
02:20:36
|
<dkayiwa> yes id of patient identifier type
|
02:20:54
|
<dkayiwa> test and tell me if it does what you need
|
02:21:46
|
<dmexs> ok i'm assuming that by unistalling xforms and loading this new omod that I won't lose the work I've put in to the form design thus far?
|
02:21:59
|
<dkayiwa> no you will not lose any
|
02:22:07
|
<dmexs> k
|
02:22:42
|
* dmexs just realized dkayiwa wrote the xforms omod
|
02:22:57
|
<dkayiwa> also fill free to use the undo redo functionality on the design surface
|
02:23:16
|
<dmexs> ok, this could take a while, tomcat crashed last time i installed this module
|
02:23:37
|
<dkayiwa> you may just restart it
|
02:23:52
|
<dmexs> yeah i will if it locks up like ladt time
|
02:23:55
|
<dmexs> *last
|
02:24:56
|
*** gbastien has quit IRC
|
02:25:35
|
*** arthursribeiro has quit IRC
|
02:29:08
|
<dmexs> phenomenal
|
02:29:20
|
<dmexs> dkayiwa: it works great :)
|
02:29:24
|
<dmexs> thanks
|
02:29:30
|
<dkayiwa> oh good
|
02:29:35
|
<dkayiwa> thanks for the feedback
|
02:29:44
|
<dmexs> did you already have that in the pipeline or did you just write that tonight/
|
02:29:53
|
<dkayiwa> i just did it now
|
02:30:06
|
<dkayiwa> it was not complicated to add
|
02:30:34
|
<dmexs> cool, i've always despised java but if I stick with openmrs for a while it might be worth learning
|
02:30:57
|
<dkayiwa> oh yes
|
02:31:05
|
<dkayiwa> very very worth learning
|
02:31:38
|
<tenaj> Can someone give me a couple hints on extension points? I'm looking at the Registration model to understand it better, and there's some magic going on I don't understand
|
02:32:08
|
<tenaj> I want to know how they made "Find/Create Patient" go to their own reg form
|
02:32:24
|
<tenaj> I found the bit in the config file that says <extension>
|
02:32:24
|
<tenaj> <point>org.openmrs.gutter.tools</point>
|
02:32:24
|
<tenaj> <class>org.openmrs.module.registration.extension.html.Reg_LinkExt</class>
|
02:32:25
|
<tenaj> </extension>
|
02:32:39
|
<dkayiwa> tenaj: have you read: https://wiki.openmrs.org/display/docs/Module+Extension+Points
|
02:32:41
|
<tenaj> Now I'm grepping through the reg module for org.openmrs.module.registration.extension.html.Reg_LinkExt
|
02:32:50
|
<dmexs> dkayiwa: well thanks again sir
|
02:32:58
|
<tenaj> Yes, I started there
|
02:33:11
|
<dkayiwa> dmexs: yo welcome
|
02:33:12
|
<tenaj> Where is Reg_LinkExt ? Is it part of OpenMRS, or part of their module?
|
02:33:55
|
<dkayiwa> the Reg_LinkExt class is in the module
|
02:34:24
|
<dkayiwa> but it is openmrs core which provides the ability to extend using the extension point
|
02:34:32
|
<dkayiwa> org.openmrs.gutter.tools
|
02:34:50
|
<dkayiwa> so the registration module extends that
|
02:35:04
|
<dkayiwa> using the Reg_LinkExt class
|
02:35:14
|
<tenaj> Where would the Reg_LinkExt cass be in the file hierarcy? I've grepped and can't find it
|
02:35:19
|
<tenaj> Can't find a file or class called Reg_Link*
|
02:35:36
|
<dkayiwa> oh sorry i mislead you
|
02:35:47
|
<dkayiwa> let me correct it
|
02:35:56
|
<tenaj> No no, you're helping me make sure I'm going down the right path
|
02:36:23
|
<dkayiwa> :D
|
02:36:42
|
<tenaj> Two brains are better than one :)
|
02:37:16
|
<tenaj> $ grep -Ri Reg_Link *
|
02:37:16
|
<tenaj> build/config.xml: <class>org.openmrs.module.registration.extension.html.Reg_LinkExt</class>
|
02:37:17
|
<tenaj> Binary file build/org/openmrs/module/registration/extension/html/Reg_LinkExt.class matches
|
02:37:17
|
<tenaj> Binary file dist/registration-1.3.omod matches
|
02:37:28
|
<tenaj> It's in there somewhere! That omod didn't build itself
|
02:37:39
|
<dkayiwa> oh i was correct
|
02:37:50
|
<dkayiwa> i did not mislead u :)
|
02:38:04
|
<dkayiwa> you will see that class when you check out the module's source code
|
02:38:45
|
<dkayiwa> http://svn.openmrs.org/openmrs-modules/remoteregistration/
|
02:38:50
|
<OpenMRSBot> <http://ln-s.net/8g-R> (at svn.openmrs.org)
|
02:39:07
|
<dkayiwa> sorry i meant this;
|
02:39:08
|
<dkayiwa> http://svn.openmrs.org/openmrs-modules/registration/
|
02:39:09
|
<OpenMRSBot> <http://ln-s.net/8g-S> (at svn.openmrs.org)
|
02:39:58
|
<dkayiwa> or you can put this in your browser to view all the modules:
|
02:39:59
|
<dkayiwa> http://svn.openmrs.org/openmrs-modules/
|
02:40:07
|
<tenaj> I've checked it out and got it open in Eclipse
|
02:40:19
|
<tenaj> I used both Eclipse and the command line grep to try to find it
|
02:40:27
|
<dkayiwa> so you will now see that class
|
02:40:38
|
<tenaj> .... where? ....
|
02:41:10
|
<dkayiwa> what is the name of the module?
|
02:41:18
|
*** arthursribeiro has joined #openmrs
|
02:41:22
|
<tenaj> The only thing I see in api.src.main.java.org.opemrs.registration.extension.html is AdminList
|
02:41:27
|
<tenaj> The module is called Registration
|
02:41:45
|
<tenaj> the class I'm looking for is org.openmrs.module.registration.extension.html.Reg_LinkExt
|
02:42:04
|
<tenaj> AdminList takes care of the administration pane
|
02:43:20
|
<dkayiwa> where did you get config file from?
|
02:44:56
|
<tenaj> It's in registration > build > config.xml
|
02:45:32
|
<dkayiwa> was browsing the repo in browser and have not yet seen it
|
02:45:58
|
<tenaj> Let me open the browser
|
02:47:54
|
*** bwolfe has quit IRC
|
02:48:06
|
<tenaj> That's bizarre. Eclipse is organizing files much differently
|
02:48:35
|
<tenaj> I want to re-check it out from svn
|
02:48:46
|
<dkayiwa> ok
|
02:48:48
|
<tenaj> which probably won't change anything, but ...
|
02:50:11
|
<tenaj> I have a slow connection. This will take a few minutes.
|
02:50:26
|
<dkayiwa> ok
|
02:51:40
|
*** bwolfe has joined #openmrs
|
02:51:40
|
*** ChanServ sets mode: +o bwolfe
|
02:56:40
|
<tenaj> Much better. I don't know what I was looking at before
|
02:56:53
|
<tenaj> This config file only shows an extension point for AdminList, which matches the code
|
02:57:25
|
<tenaj> So my next question is, how did the Registration module make it so when I click Find/Add patient, it goes to the Registration form?
|
02:58:34
|
*** mjohnst has joined #openmrs
|
02:58:44
|
<tenaj> I bet there's a magic word with a lot of related documentation in the wiki
|
02:59:00
|
<dkayiwa> look it the metadata folder
|
02:59:54
|
<dkayiwa> for the for a file named webModuleApplicationContext.xml
|
03:00:08
|
<dkayiwa> or moduleApplicationContext.xml
|
03:01:29
|
<tenaj> ok, looking..
|
03:02:33
|
<tenaj> Ah, looks like this might be it:
|
03:02:37
|
<tenaj> <bean id="registrationUrlMapping" class="org.springframework.web.servlet.handler.SimpleUrlHandlerMapping">
|
03:02:37
|
<tenaj> <property name="order"><value>98</value></property>
|
03:02:37
|
<tenaj> <property name="mappings">
|
03:02:39
|
<tenaj> <props>
|
03:02:39
|
<tenaj> <prop key="module/@MODULE_ID@/main.form">registrationMainForm</prop>
|
03:02:39
|
<tenaj> <prop key="module/@MODULE_ID@/options.form">registrationOptionsForm</prop>
|
03:02:39
|
<tenaj> <prop key="**/findPatient.htm">registrationMainForm</prop>
|
03:02:39
|
<tenaj> </props>
|
03:02:40
|
<tenaj> </property>
|
03:02:40
|
<tenaj> </bean>
|
03:02:45
|
<dkayiwa> yes
|
03:03:05
|
<tenaj> What happens if two modules try to handle the same URL? Does it throw an error, or does the last module loaded win?
|
03:03:19
|
<dkayiwa> thats the purpose of the order value
|
03:03:48
|
<dkayiwa> order determines which wins
|
03:04:12
|
<tenaj> That could still get ugly. :)
|
03:04:35
|
<dkayiwa> talk to the spring guys :D
|
03:04:39
|
<tenaj> Ok, that gives me some good things to work with today
|
03:05:35
|
<dkayiwa> ok
|
03:05:46
|
<tenaj> Off the top of your head, do you know of a good example module which extends the gutter.tools to change the toolbar?
|
03:05:51
|
<tenaj> I was looking at the MDRTB module yesterday
|
03:06:00
|
<dkayiwa> no
|
03:06:04
|
<tenaj> but can't run it, because I hit a problem with the Reporting module
|
03:06:19
|
<dkayiwa> what problem with the reporting module?
|
03:06:22
|
<tenaj> MDRTB is hard to understand without seeing it
|
03:06:25
|
<tenaj> I filed a bug for it
|
03:06:28
|
<tenaj> I get an error when I start it up
|
03:06:48
|
<dkayiwa> when you start the reporting or MDRTB module?
|
03:06:50
|
<tenaj> ... digging up the number ...
|
03:07:00
|
<tenaj> When I start reporting. MDRTB won't start unless Reporting starts.
|
03:07:13
|
<dkayiwa> ok
|
03:07:56
|
<tenaj> https://tickets.openmrs.org/browse/REPORT-211
|
03:08:01
|
<dkayiwa> ok
|
03:08:57
|
<dkayiwa> are you now able to start the reporting module?
|
03:10:24
|
<dkayiwa> if you get version 0.2.5 of the xstream module, the report module should run fine
|
03:10:59
|
<tenaj> Still not starting. I'll update the module.
|
03:11:16
|
<dkayiwa> even after using xstream 0.2.5?
|
03:11:29
|
<tenaj> still updating, sorry
|
03:13:35
|
<tenaj> Admin > Manage Modules > check for upgrades didn't detect that there was a new version. Strange. Ok, now installing 0.2.5 ...
|
03:13:46
|
<dkayiwa> ok
|
03:14:34
|
<tenaj> WOO HOO! Success! Thank you! I will close my bug
|
03:15:37
|
<dkayiwa> ok
|
03:16:20
|
<tenaj> Thank you very much for your help. I was quite stuck.
|
03:16:30
|
<dkayiwa> yo welcome
|
03:30:31
|
*** tenaj has quit IRC
|
03:34:46
|
*** surangak has joined #openmrs
|
03:57:13
|
*** dkayiwa has left #openmrs
|
03:59:24
|
*** bwolfe has quit IRC
|
03:59:57
|
*** tenaj has joined #openmrs
|
04:00:00
|
*** pulasthi has joined #openmrs
|
04:03:13
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): Back porting, Removing 'View Observations' privilege from Anonymous user - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/-tqIFIGv3Vk/OpenMRS> || New Changeset: OpenMRS (trunk): Removing 'View Observations' privilege from Anonymous user - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/67JEWqxvrIY/OpenMRS> || New Changeset: OpenMRS (1.8.x): Back porting, Don't display encounter index page when a user isn't authenticated - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/AufxEhpULWs/OpenMRS> || New Changeset: OpenMRS (trunk): Don't display encounter index page when a user isn't authenticated - TRUNK-2144 <http://feedproxy.google.com/~r/OMRStrunk/~3/1q5YvFAEBfk/OpenMRS>
|
04:08:31
|
*** bwolfe has joined #openmrs
|
04:08:31
|
*** ChanServ sets mode: +o bwolfe
|
04:40:02
|
*** upul` has joined #openmrs
|
04:40:02
|
*** ChanServ sets mode: +v upul`
|
04:40:17
|
*** bwolfe has quit IRC
|
04:43:35
|
*** tenaj has quit IRC
|
04:46:28
|
*** emeka has joined #openmrs
|
04:49:05
|
*** dmexs has quit IRC
|
04:52:47
|
*** arthursribeiro has quit IRC
|
05:04:15
|
*** Mkop has quit IRC
|
05:05:35
|
*** emeka has quit IRC
|
05:39:01
|
*** anu has joined #openmrs
|
05:40:26
|
*** anu has quit IRC
|
05:41:28
|
*** anu has joined #openmrs
|
05:42:43
|
<anu> hello...any admin around?
|
05:55:40
|
<anu> hey surangak
|
06:34:10
|
<surangak> helooo
|
06:34:25
|
<surangak> terribly sorry, I was at a discussion
|
06:39:54
|
*** Suneeth has joined #openmrs
|
06:48:00
|
*** kmit has joined #openmrs
|
06:55:22
|
*** Suneeth has quit IRC
|
07:01:58
|
*** surangak has quit IRC
|
07:17:01
|
*** tenaj has joined #openmrs
|
07:25:21
|
*** pulasthi1 has joined #openmrs
|
07:28:35
|
*** pulasthi has quit IRC
|
07:57:23
|
*** pulasthi1 has quit IRC
|
08:35:08
|
*** rafa has joined #openmrs
|
08:35:08
|
*** ChanServ sets mode: +v rafa
|
08:36:49
|
*** mjohnst has quit IRC
|
08:38:18
|
*** ashishmittal has joined #openmrs
|
08:46:28
|
*** anu has quit IRC
|
08:53:22
|
*** anu has joined #openmrs
|
09:07:09
|
*** pascal` has joined #openmrs
|
09:07:19
|
*** ChanServ sets mode: +v pascal`
|
09:07:44
|
*** anu has quit IRC
|
09:27:21
|
*** rafa has quit IRC
|
09:43:11
|
*** tenaj has quit IRC
|
10:18:04
|
*** surangak has joined #openmrs
|
10:28:25
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Customization of openmrs <http://forum.openmrs.org/viewtopic.php?f=3&t=774#p2945>
|
10:33:51
|
*** ashishmittal has quit IRC
|
10:43:48
|
*** surangak has quit IRC
|
10:49:17
|
*** bwolfe has joined #openmrs
|
10:49:17
|
*** ChanServ sets mode: +o bwolfe
|
10:53:59
|
*** bwolfe has quit IRC
|
10:54:26
|
*** kmit has quit IRC
|
10:56:08
|
*** nribeka has quit IRC
|
11:00:32
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Create new privileges <http://forum.openmrs.org/viewtopic.php?f=8&t=775#p2946>
|
11:30:30
|
*** gauravpaliwal has joined #openmrs
|
11:32:37
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Patient Beds <http://forum.openmrs.org/viewtopic.php?f=2&t=776#p2947>
|
11:34:48
|
*** upul` has quit IRC
|
11:37:04
|
*** gauravpaliwal has left #openmrs
|
11:58:08
|
*** bwolfe has joined #openmrs
|
11:58:08
|
*** ChanServ sets mode: +o bwolfe
|
11:58:12
|
*** Chaitalishah has joined #openmrs
|
12:02:23
|
*** emeka has joined #openmrs
|
12:15:50
|
*** mjohnst has joined #openmrs
|
12:16:36
|
*** nribeka has joined #openmrs
|
12:16:36
|
*** ChanServ sets mode: +v nribeka
|
12:23:53
|
*** dkayiwa has joined #openmrs
|
12:24:25
|
*** mjohnst has quit IRC
|
12:32:12
|
*** cta has joined #openmrs
|
12:33:29
|
*** wyclif has quit IRC
|
12:34:59
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Customization of openmrs <http://forum.openmrs.org/viewtopic.php?f=3&t=774#p2948>
|
12:40:52
|
*** muthah has joined #openmrs
|
13:13:52
|
*** wyclif has joined #openmrs
|
13:20:50
|
<cta> wyclif: Hello, Wyclif. Are you present? I've some questions.
|
13:21:53
|
<wyclif> yes
|
13:22:10
|
<cta> wyclif: I was thinking of TRUNK-2141. In my point of view, it will be better, if we will provide opportunity for admin users to set these result's parameters both from search widgets and/or through a global property. And use values that was set on widget as preferred.
|
13:23:09
|
<wyclif> okay
|
13:25:56
|
<cta> wyclif: Next question. As I understood, this functionality need to be added to patient, encounter, observation, orderDrug list, programs and concepts search forms? or anywhere else?
|
13:26:02
|
<cta> more
|
13:26:38
|
<cta> ?
|
13:26:58
|
*** mjohnst has joined #openmrs
|
13:27:02
|
<wyclif> the search widget is one but customizable
|
13:27:18
|
<wyclif> so you only need to add the change in one place
|
13:28:32
|
<cta> wyclif: you meant add changes to openmrsSearch.js?
|
13:29:03
|
<wyclif> that is the place where to add the changes
|
13:29:53
|
<cta> wyclif: but in case of using global properties we also need to make small changes in dwr services too?
|
13:31:38
|
<cta> wyclif: am I right?
|
13:32:06
|
*** downeym has joined #openmrs
|
13:32:06
|
*** ChanServ sets mode: +o downeym
|
13:32:38
|
*** surangak has joined #openmrs
|
13:32:48
|
<surangak> hello ppl, Im back
|
13:37:48
|
*** downeym_ has joined #openmrs
|
13:37:48
|
*** ChanServ sets mode: +o downeym_
|
13:37:49
|
*** downeym has quit IRC
|
13:37:50
|
*** downeym_ is now known as downeym
|
13:42:42
|
*** gbastien has joined #openmrs
|
13:44:15
|
<wyclif> i meant that the changes have to made in the search and also adding global properties
|
13:44:30
|
<wyclif> you can read the description i put on the ticket
|
13:53:59
|
<cta> wyclif: ok, I'll tryed to do it in the best way
|
13:54:02
|
*** pulasthi has joined #openmrs
|
13:55:20
|
<wyclif> cta, basically add global properties for admins to set, then add checkboxes to the widget that represent the global property values but can be overridden by the user
|
13:55:47
|
*** ashishmittal has joined #openmrs
|
13:56:23
|
*** Chaitalishah has quit IRC
|
13:58:02
|
<cta> wyclif: I've understood. I gotta start work
|
13:58:14
|
*** emeka has quit IRC
|
13:59:25
|
<wyclif> i.e if the admin sets the number to display per page to 10, the widget should have a select where the user can set it to another value
|
14:00:01
|
<wyclif> but user set value should not be persisted
|
14:00:19
|
<cta> why?
|
14:00:28
|
<cta> sorry))
|
14:00:55
|
<wyclif> users are not allowed to set system wide properties
|
14:00:59
|
<cta> i meant preferred not persisted as is))
|
14:01:22
|
<cta> ok.
|
14:01:26
|
<wyclif> what do you mean?
|
14:02:08
|
<cta> I read wrong your reply "but user set value should not be PREFERRED"
|
14:02:32
|
<cta> as result was suprized
|
14:03:28
|
<wyclif> ok
|
14:04:13
|
<wyclif> actually set values should probably be persisted within their session or request
|
14:09:57
|
*** muthah has quit IRC
|
14:10:37
|
*** emeka has joined #openmrs
|
14:10:39
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): fixed a comment <http://feedproxy.google.com/~r/OMRStrunk/~3/hy6ylRP-Ccc/OpenMRS>
|
14:14:10
|
<surangak> im off guys, going home, catch u later...
|
14:14:52
|
*** aja has joined #openmrs
|
14:15:07
|
<cta> wyclif: is these set values mast be different to concept and patient for example or must be only two global properties (MAX_SHOW_RESULT and TOTAL size for example) for every kind of search?
|
14:15:49
|
*** robbyoconnor has quit IRC
|
14:22:07
|
<wyclif> the values are for the generic search widget, which means they will appear on all the widget
|
14:22:52
|
<wyclif> there actually only one search widget but customizable for doing searches for any object
|
14:23:01
|
*** tenaj has joined #openmrs
|
14:23:06
|
<wyclif> whether concept, patients, encounters
|
14:23:11
|
<wyclif> it is the same widget
|
14:23:14
|
<downeym> Hi tenaj and welcome to the #openmrs IRC channel.
|
14:23:28
|
<tenaj> Hello, thanks
|
14:23:38
|
<wyclif> cta, sorry about my typos
|
14:23:46
|
<emeka> good morning all
|
14:23:50
|
*** emeka is now known as dmexs
|
14:25:23
|
<tenaj> I have a couple questions about forms, but I don't want to break the flow of conversation.
|
14:27:05
|
<tenaj> ... and it looks like Wyclif has finished that thread. Ok!
|
14:27:36
|
<tenaj> I made a form with HTMLFormEntry. I don't know whether any of this is specific to that module or whether it's part of the core.
|
14:28:28
|
<tenaj> If it were a normal HTML form, I'd include a hidden input with the patient's ID number, and another with the encounter ID if it were an edit. It looks like that's taken care of. Is that right?
|
14:29:04
|
*** surangak has quit IRC
|
14:29:17
|
*** Mkop has joined #openmrs
|
14:29:17
|
*** ChanServ sets mode: +v Mkop
|
14:30:40
|
<nribeka> try pinging djazayeri tenaj
|
14:31:12
|
<tenaj> Ok
|
14:31:16
|
<djazayeri> hi tenaj
|
14:31:41
|
<djazayeri> what's up?
|
14:31:52
|
*** mjohnst has quit IRC
|
14:31:54
|
<tenaj> I'm exploring the wild world of forms
|
14:32:25
|
<wyclif> tenaj, feel free to interrupt
|
14:32:51
|
<tenaj> In a normal web app, I'd specify the patient ID (and encounter id) as a hidden input in a form. It looks like I don't need to worry about that with the forms I made in HTMLFormEntry. Is that right?
|
14:33:20
|
<tenaj> And is that because I did it with HTMLFormEntry, or is that part of core openmrs?
|
14:36:10
|
*** pascal` has quit IRC
|
14:41:47
|
<djazayeri> tenaj, That's built into html form entry
|
14:42:03
|
<djazayeri> html forms are assumed to be about one patient and one encounter.
|
14:42:17
|
<djazayeri> (you shouldn't have to do any <input...> tags either
|
14:42:50
|
<djazayeri> Really you're just using HTML for layout, and using the "special" html form entry tags (like <obs...>) to get the openmrs-integrated behavior.
|
14:43:28
|
<tenaj> Ok. I wasn't sure if the name "HTML form entry" was strictly the part where I, as an admin, enter an HTML form through that interface, or whether it was also the users filling out the html form
|
14:44:24
|
<djazayeri> "HTML Form Entry" refers to the OpenMRS module. It provides both the admin interface where you manage forms and layouts. It also provides a "FormEntryHandler" allowing plain users to fill out the forms in its technology
|
14:44:55
|
<tenaj> I'd like my module to do some logic when an encounter is saved. How can I insert myself into that process?
|
14:45:35
|
<tenaj> For example, when a surgical encounter is added, I'd like to add a person attribute that says "this patient had surgery". (The paper file gets put in a different location from that point forward, and it will help Registration find the file more quickly. )
|
14:45:44
|
<tenaj> I understand the Person API, and I see how to add an attribute to a person
|
14:45:58
|
<tenaj> but I need to barge into that sequence when an encounter is added
|
14:46:23
|
<tenaj> It looks like extension points pertain only to displaying pages
|
14:46:48
|
*** dmexs has quit IRC
|
14:46:52
|
*** emeka has joined #openmrs
|
14:47:31
|
<djazayeri> Right, to do something like that, you would use AOP to modify the behavior of the EncounterService.saveEncounter method.
|
14:48:06
|
<djazayeri> You would do this from a module that changes core OpenMRS behavior. (Thus it will affect encounters created by html form entry, or any other technology)
|
14:48:14
|
<djazayeri> https://wiki.openmrs.org/display/docs/OpenMRS+AOP
|
14:48:17
|
<OpenMRSBot> <http://ln-s.net/8gLx> (at wiki.openmrs.org)
|
14:49:11
|
<tenaj> Great! That's the kind of answer I was hoping for
|
14:49:52
|
<djazayeri> that page is actually a bit general
|
14:50:25
|
<tenaj> Do you know of an example module or part of the API, off the top of your head, or a keyword I can grep for?
|
14:50:27
|
*** Herat has joined #openmrs
|
14:50:41
|
<downeym> Hi Herat and welcome to the #openmrs IRC channel.
|
14:50:41
|
<djazayeri> but on the page, search for /metadata/config.xml
|
14:50:45
|
<tenaj> " after" might do
|
14:51:06
|
<djazayeri> the code block before, and the xml block after, are a trivial example
|
14:54:07
|
<tenaj> Ok. That'll keep me busy tomorrow
|
14:54:53
|
<tenaj> I'll read through it. Thank you
|
14:56:39
|
<djazayeri> tenaj, the first module I wrote that does AOP was the restrictbyrole module. You could look at it as an example, but it's ~5 years old, so maybe it won't show best-practice coding style.
|
14:56:59
|
*** emeka has quit IRC
|
14:59:36
|
<tenaj> I'll take a look. Thanks.
|
15:03:40
|
*** wyclif is now known as wycleflo
|
15:03:46
|
*** wycleflo is now known as wyclif
|
15:04:25
|
*** wyclif is now known as wluyima
|
15:06:42
|
*** wluyima_ has joined #openmrs
|
15:06:51
|
<downeym> Hi wluyima_ and welcome to the #openmrs IRC channel.
|
15:07:09
|
*** suho has joined #openmrs
|
15:07:21
|
*** wluyima has quit IRC
|
15:07:21
|
*** wluyima_ has quit IRC
|
15:07:36
|
*** wluyima has joined #openmrs
|
15:07:50
|
<downeym> Hi wluyima and welcome to the #openmrs IRC channel.
|
15:15:31
|
<downeym> Herat: Hi, you can ask your question here
|
15:17:11
|
*** aja has quit IRC
|
15:19:52
|
*** Herat has quit IRC
|
15:20:09
|
*** ashishmittal has quit IRC
|
15:21:09
|
*** rafa has joined #openmrs
|
15:21:09
|
*** ChanServ sets mode: +v rafa
|
15:21:50
|
*** dmexs has joined #openmrs
|
15:22:05
|
<downeym> Hi dmexs and welcome to the #openmrs IRC channel.
|
15:22:05
|
<bwolfe> downeym: wluyima is now a registered nick...do what you will
|
15:22:38
|
<downeym> wluyima has NOT COMPLETED registration verification
|
15:22:49
|
<downeym> :(
|
15:24:38
|
*** cta has quit IRC
|
15:25:11
|
*** ChanServ sets mode: +v wluyima
|
15:28:32
|
<bwolfe> downeym: does he have to respond to an email they send?
|
15:29:20
|
<downeym> http://freenode.net/faq.shtml#userregistration : The email address that you select will not be given out by staff, and is mainly used to allow us to help you recover the account in the event that you forget your password. For this reason, you are required to use a real, non-disposable, email address. Upon registering, you will receive an email with a verification command that you will need to run to complete the registration process. Failure to veri
|
15:29:20
|
<downeym> account will cause it to be automatically dropped after about 24 hours.
|
15:30:02
|
<bwolfe> I see. well, eventually wluyima will see irc blinking and/or see that email and respond to it :-p
|
15:30:13
|
<downeym> :P
|
15:33:12
|
*** pascal` has joined #openmrs
|
15:37:19
|
*** rafa has quit IRC
|
15:41:10
|
*** Echidna has quit IRC
|
15:42:26
|
*** wluyima has quit IRC
|
15:42:46
|
*** tenaj has left #openmrs
|
15:43:40
|
*** aja has joined #openmrs
|
15:44:18
|
*** Echidna has joined #openmrs
|
15:44:18
|
*** ChanServ sets mode: +v Echidna
|
15:47:45
|
*** rafa has joined #openmrs
|
15:47:45
|
*** ChanServ sets mode: +v rafa
|
15:50:23
|
*** gbastien has quit IRC
|
15:53:15
|
*** yg has joined #openmrs
|
15:53:27
|
<downeym> Hi yg and welcome to the #openmrs IRC channel.
|
15:53:46
|
*** rafa has quit IRC
|
15:54:17
|
*** pascal` has quit IRC
|
15:54:58
|
*** wluyima has joined #openmrs
|
15:57:04
|
*** yg has left #openmrs
|
15:57:09
|
*** dmexs has quit IRC
|
16:01:26
|
*** Mkop has quit IRC
|
16:04:23
|
<wluyima> i can't find the log in
|
16:04:34
|
<downeym> ?
|
16:05:24
|
<wluyima> when i try to complete the registration, it asks me to login
|
16:09:00
|
*** pulasthi has left #openmrs
|
16:09:12
|
<downeym> wluyima: what irc client are you using
|
16:09:13
|
*** ChanServ sets mode: +v wluyima
|
16:09:36
|
<wluyima> done
|
16:09:59
|
<downeym> hmm
|
16:10:00
|
<downeym> ok
|
16:10:23
|
<downeym> as listed in # 6 at http://freenode.net/faq.shtml#userregistration you can identify as part of connecting to the server
|
16:33:42
|
*** gbastien has joined #openmrs
|
16:36:05
|
*** arthursribeiro has joined #openmrs
|
16:46:49
|
*** Chaitalishah has joined #openmrs
|
16:47:10
|
*** Chaitalishah has quit IRC
|
16:54:55
|
*** gbastien has quit IRC
|
16:58:27
|
*** ashishmittal has joined #openmrs
|
17:09:59
|
*** nribeka has quit IRC
|
17:19:34
|
*** nribeka has joined #openmrs
|
17:19:34
|
*** ChanServ sets mode: +v nribeka
|
17:44:19
|
*** mjohnst has joined #openmrs
|
17:51:06
|
*** bwolfe has quit IRC
|
18:04:46
|
*** bwolfe has joined #openmrs
|
18:04:46
|
*** ChanServ sets mode: +o bwolfe
|
18:18:03
|
*** bwolfe has quit IRC
|
18:28:39
|
*** cta has joined #openmrs
|
18:30:35
|
*** bwolfe has joined #openmrs
|
18:30:35
|
*** ChanServ sets mode: +o bwolfe
|
18:31:55
|
*** cta has left #openmrs
|
18:38:41
|
*** aja has quit IRC
|
18:49:05
|
*** bryq has joined #openmrs
|
18:56:06
|
*** sfb has joined #openmrs
|
18:56:13
|
<downeym> Hi sfb and welcome to the #openmrs IRC channel.
|
18:56:35
|
<sfb> bwolfe: hi
|
19:02:47
|
<bwolfe> hi sfb
|
19:02:51
|
<bwolfe> I'm in a meeting, so can't chat now
|
19:02:59
|
<bwolfe> others in here should be able to answer your questions though
|
19:03:17
|
<sfb> bwolfe: I have a question abuot a student yuo mentored last year.
|
19:03:45
|
<sfb> You and/or bmamlin..
|
19:05:03
|
<sfb> So I can wait.
|
19:15:21
|
*** kane77 has joined #openmrs
|
19:17:20
|
<downeym> sfb feel free to msg me privately with questions
|
19:20:16
|
*** arthur_sribeiro has joined #openmrs
|
19:20:25
|
<downeym> Hi arthur_sribeiro and welcome to the #openmrs IRC channel.
|
19:20:43
|
<arthur_sribeiro> downeym, thank you
|
19:22:29
|
<ashishmittal> hi djazayeri
|
19:22:47
|
<djazayeri> hi ashishmittal
|
19:23:03
|
*** arthursribeiro has quit IRC
|
19:23:54
|
*** arthur_sribeiro is now known as arthursribeiro
|
19:24:05
|
<ashishmittal> djazayeri, I am working on TRUNK-350. regarding that, I downloaded the reporting module and mavenized it using mavenize-module-9_openmrs1.8.sh
|
19:24:16
|
<downeym> !ticket TRUNK-350
|
19:24:16
|
<OpenMRSBot> downeym: Allow me to help you with that. More details on ticket TRUNK-350 can be found at http://tickets.openmrs.org/browse/TRUNK-350
|
19:24:48
|
<ashishmittal> but when I run 'mvn clean package' on the reporting module, it gives me a build failure
|
19:25:35
|
<djazayeri> the reporting module doesn't use maven
|
19:26:03
|
<djazayeri> you mean "ant clean" and "ant package-module"?
|
19:26:07
|
<ashishmittal> do I have to use ant to get the omod then?
|
19:26:23
|
<djazayeri> yes
|
19:26:26
|
<ashishmittal> ohk. I was mavenizing and trying to use maven
|
19:26:30
|
<ashishmittal> thanks
|
19:27:20
|
<ashishmittal> btw, just for general information, can't we mavenize any module using the srcipt and use maven for building?
|
19:34:13
|
*** robbyoconnor has joined #openmrs
|
19:34:16
|
*** robbyoconnor has quit IRC
|
19:34:16
|
*** robbyoconnor has joined #openmrs
|
19:34:16
|
*** ChanServ sets mode: +v robbyoconnor
|
19:41:24
|
*** robbyoconnor has quit IRC
|
19:42:53
|
*** robbyoconnor has joined #openmrs
|
19:42:53
|
*** ChanServ sets mode: +v robbyoconnor
|
20:02:36
|
*** bryq has quit IRC
|
20:07:25
|
*** surangak has joined #openmrs
|
20:11:46
|
<djazayeri> ashishmittal, I don't think the script is foolproof. And if you mavenize a module, any patches you submit would not work to apply.
|
20:26:33
|
*** rafa has joined #openmrs
|
20:26:33
|
*** ChanServ sets mode: +v rafa
|
20:30:35
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.7.x): backporting TRUNK-2117 to branches/1.7.x - fixed banner bar for legacy theme (and minor change to footer) <http://feedproxy.google.com/~r/OMRStrunk/~3/wQKzUR1bgH4/OpenMRS> || New Changeset: OpenMRS (1.8.x): backporting TRUNK-2117 to branches/1.8.x - fixed banner bar for legacy theme (and minor change to footer) <http://feedproxy.google.com/~r/OMRStrunk/~3/cl-UukjmB-4/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2117 - fixed banner bar for legacy theme (and minor change to footer) <http://feedproxy.google.com/~r/OMRStrunk/~3/xwe4m15G2x0/OpenMRS>
|
20:33:18
|
*** mjohnst has quit IRC
|
20:39:50
|
*** surangak has quit IRC
|
20:52:47
|
*** gbastien has joined #openmrs
|
21:05:45
|
*** kane77 has quit IRC
|
21:07:00
|
*** bwolfe has quit IRC
|
21:14:07
|
*** dkayiwa has quit IRC
|
21:24:58
|
<downeym> upgraded Bamboo now available at http://ci.openmrs.org
|
21:31:25
|
*** nribeka has quit IRC
|
21:48:05
|
*** suho has quit IRC
|
21:55:05
|
*** robbyoconnor has quit IRC
|
21:59:11
|
*** mjohnst has joined #openmrs
|
22:08:11
|
*** downeym has quit IRC
|
22:29:19
|
*** rafa has quit IRC
|
22:35:41
|
*** ashishmittal has quit IRC
|
22:38:13
|
*** dkayiwa has joined #openmrs
|
22:39:42
|
*** wluyima has quit IRC
|
23:11:43
|
*** wluyima has joined #openmrs
|
23:17:41
|
*** robbyoconnor has joined #openmrs
|
23:17:41
|
*** ChanServ sets mode: +v robbyoconnor
|
23:20:22
|
*** nribeka has joined #openmrs
|
23:20:22
|
*** ChanServ sets mode: +v nribeka
|
23:29:23
|
*** gbastien has quit IRC
|