IRC Chat : 2010-11-05 - OpenMRS

00:09:19 *** misha680 has joined #openmrs
00:21:15 *** bwolfe has joined #openmrs
00:21:16 *** ChanServ sets mode: +o bwolfe
00:46:56 <misha680> bwolfe: quick question, could you explain request.getServletPath in ./web/src/main/java/org/openmrs/web/controller/SpringController.java? We seem to change any servletPath ending in .htm or .jsp to blank, but based on my read of http://download.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getServletPath() is supposed to return the _servlet_ name, or am I misreading? Thx
00:47:00 <OpenMRSBot> <http://ln-s.net/85II> (at download.oracle.com)
00:47:32 <misha680> bwolfe: I ask because right now with OSGi web container (Apache Felix HTTP Service) this is actually an empty string, rather than "index" returned by jetty and I'm trying to figure out why... Thx
00:50:39 <bwolfe> misha680: its only used in one place it seems. in openmrs-servlet.xml, a mapping to all .htm urls <prop key="**/*.htm">springController</prop>
00:51:13 <bwolfe> misha680: but I don't remember why thats there
00:51:56 <misha680> bwolfe: ok, I will investigate farther. I'm trying to see what the actual Spring controllers do. It may very well be correct and there may be something about my setup of Apache Felix HTTP Service that is incorrect. In any case I'm not 100% clear yet. Thx.
00:53:22 <misha680> bwolfe: I am going to try with getRequestURI and see if that helps - that's supposed to be the part after the http://localhost:8080/openmrs/ to my understanding
00:54:22 <bwolfe> misha680: you can try just taking it out and see if it can still work with a default controller
01:01:29 <misha680> bwolfe: which one do you mean. There's one in org.springframework.web.servlet.mvc.mapping that just returns indexView. The one OpenMRS implements is an interface. There are some others but I'm not sure which is "default."
01:02:00 <bwolfe> I'm not sure either, unfortunately :-/
01:28:13 <misha680> bwolfe: ok, getRequestURI not quite correct either. Maybe this is a bug in Felix HTTP Server... not sure
01:33:39 <misha680> bwolfe: weird, equinox HTTP service has same behavior. Maybe it's something that changed in servlet spec with version increase.
02:11:38 <misha680> fyi, I asked on the Apache Felix mailing list: http://old.nabble.com/HttpServletRequest.getServletPath()-behavior-on-HTTP-Service-does-not-match-Jetty--td30137615.html#a30137615 I was going to add a link on http://tickets.openmrs.org/browse/TRUNK-1596 but I get a JiraLockedError
02:32:57 <bwolfe> misha680: jira is being upgraded tonight. maybe you hit that window? (michael posted about it earlier today)
02:34:08 <misha680> bwolfe: maybe. thank you for the info. :)
02:50:27 <bwolfe> misha680: from michaels latest post, it looks like it should be working again.
02:50:57 <misha680> bwolfe: thx. just back up
03:00:08 *** bwolfe has quit IRC
03:09:03 <misha680> Thx. Fyi I found the relevant controller: http://static.springsource.org/spring/docs/1.1.2/api/org/springframework/web/servlet/mvc/UrlFilenameViewController.html
03:09:07 <OpenMRSBot> <http://ln-s.net/85KN> (at static.springsource.org)
03:24:44 *** muthah has quit IRC
03:33:18 *** bwolfe has joined #openmrs
03:33:18 *** ChanServ sets mode: +o bwolfe
04:49:31 *** upul` has joined #openmrs
04:49:31 *** ChanServ sets mode: +v upul`
05:44:00 *** muthah has joined #openmrs
06:21:04 *** robota has joined #openmrs
06:41:41 *** Pkirwa has joined #openmrs
07:07:33 *** upul` has quit IRC
07:15:35 *** robbyoconnor has quit IRC
09:14:05 *** ted__ has joined #openmrs
09:15:35 *** ted__ has quit IRC
09:49:53 *** robbyoconnor has joined #openmrs
09:49:53 *** ChanServ sets mode: +v robbyoconnor
10:27:13 *** mathiaslin has joined #openmrs
10:39:52 *** robota has quit IRC
10:56:01 *** muthah has quit IRC
11:49:07 *** bwolfe has quit IRC
13:00:22 *** bwolfe has joined #openmrs
13:00:22 *** ChanServ sets mode: +o bwolfe
13:12:30 *** Pkirwa has quit IRC
13:25:58 *** robota has joined #openmrs
13:39:03 *** ted__ has joined #openmrs
13:39:24 *** ted__ has quit IRC
14:27:45 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS trunk #16351: [bwolfe] Fixing url to tomcat for windows installer <http://feedproxy.google.com/~r/OMRStrunk/~3/IXyS0DIr2Vg/> || New Changeset: OpenMRS 1.7.x #16350: [bwolfe] Fixing url to tomcat for windows installer <http://feedproxy.google.com/~r/OMRStrunk/~3/NxfVQCp9bF0/> || New Changeset: OpenMRS #16349: [bwolfe] Updating error report page to include propert implementation id - TRUNK-1808 <http://feedproxy.google.com/~r/OMRStrunk/~3/7Is2pONYfBw/> || New Changeset: OpenMRS trunk #16348: [bwolfe] Let the javascript pages cache - TRUNK-28 Added an openmrsmessages.js.withjstl file to contain all jstl related code for all js files. This page is cached per locale in the users browser and only updated when a global prope <http://feedproxy.google.com/~r/OMRStrunk/~3/UdB-esVKZjo/>
14:34:56 *** robota has quit IRC
14:35:23 *** robota has joined #openmrs
14:43:04 *** robota has quit IRC
15:31:56 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Forum: Re: Designing Xforms from Basic Form <http://forum.openmrs.org/viewtopic.php?f=3&t=707#p2674>
15:48:50 *** mathiaslin has quit IRC
15:48:56 *** mathiaslin has joined #openmrs
16:02:09 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Reminder: Come hang out with the #OpenMRS community at #mHS10 on Tuesday night - http://go.openmrs.org/meetup #mHS2010 <http://twitter.com/OpenMRS/statuses/568368222437376>
16:07:39 *** aja has joined #openmrs
16:08:35 *** misha680 has quit IRC
16:19:07 <aja> bwolfe:hi i am working with http://tickets.openmrs.org/browse/TRUNK-1744.shall i implement it for predefined number of data types or pay attention to future data types?
16:34:18 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS trunk #16359: [wyclif] Added encounter batch look up in the API and updating the encounter search widget to use it - TRUNK-1652 <http://feedproxy.google.com/~r/OMRStrunk/~3/Ek5Q_d8U0Qo/> || New Changeset: OpenMRS trunk #16355: [djazayeri] use eq instead of like in getAllLocations <http://feedproxy.google.com/~r/OMRStrunk/~3/5l835Nlobas/>
16:37:00 *** mathiaslin has quit IRC
16:40:09 <bwolfe> aja: I suggest just doing it for some predefined types
16:40:37 <bwolfe> aja: you could make it very flexible under the hood by using hibernate magic. (passing in a class name to use in the hibernate criteria)
16:45:00 *** misha680 has joined #openmrs
16:54:41 <aja> bwolfe:ok." A small module could ask for the period, the type of object to delete (encounter vs obs vs concept)".here i have to check the name of the type that given by user for spelling errors.i thought to put a switch case to check the type and call DAO function.OR i can list available voidable types to select by user.which one is better? and possible?
16:55:23 <bwolfe> aja: for now just have a dropdown with those three types
16:55:38 <bwolfe> later you can make it so that it finds all voidable types
16:56:22 <bwolfe> but then it gets tricky because you should be calling encounterSErvice.voidEncounter(encObject). because when an encounter is voided, all obs shoudl be voided as well
17:06:25 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: DataIntegrity Module 1.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=dataintegrity&version=&1.1>
17:18:45 <aja> bwolfe:ah! when an encounter is purged if i delete all related obs then no problem.i am correct?
17:19:39 <bwolfe> oh yeah, forgot this was purging, not voiding
17:19:51 <bwolfe> yes, if you purge all obs first, no problem
17:20:07 <bwolfe> if you purge anything and forgot another object that depends on it, the db should complain anyway
17:29:30 <aja> ok.i am going to instantiate my custom made DAO(to retrieve voided objects to be deleted) in controller.is it good?
17:30:22 <aja> or how to inject into context?
17:32:41 <aja> as a service.
17:44:00 <aja> bwolfe:i got it.shall i take datadeletion module as example module to get idea for my module.Or are there an best one for my requirement?
17:45:32 <aja> bwolfe:i need example specially for hibernate coding of my module.
17:45:42 <bwolfe> aja: that one should be ok. its kind of old, but thats fine
17:57:06 <aja> bwolfe:ok.that is suitable one.thanks
18:09:21 *** aja has quit IRC
18:22:09 *** gbastien has joined #openmrs
19:12:41 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS trunk #16362: [wyclif] Fixing "unresponsive script" errors in encounter search widget due to slow responses from server - TRUNK-1652 <http://feedproxy.google.com/~r/OMRStrunk/~3/typros_iFHY/>
19:44:45 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS trunk #16363: [bwolfe] Partial fix to data exports slow and OOM - RCM-20 <http://feedproxy.google.com/~r/OMRStrunk/~3/gMQDVBpGEQs/>
19:47:17 *** batkinson2 has joined #openmrs
19:51:12 *** batkinson2 has quit IRC
19:51:34 *** batkinson has joined #openmrs
20:08:34 *** batkinson has quit IRC
20:16:50 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Patient Image 0.3.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=patientimage&version=&0.3.3> || OpenMRS Modules: Reporting Compatibility 1.5.1.5 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reportingcompatibility&version=&1.5.1.5>
20:20:41 *** Hazamonzo has quit IRC
21:22:50 *** bwolfe has quit IRC
23:06:53 *** misha680 has quit IRC
23:34:18 *** gbastien has quit IRC